Skip to content
Success

Changes

Summary

  1. Changed clubb_bin_diff_regression_gfortran_test_new to clubb_bin_diff_regression_gfortran_test and clubb_bin_diff_regression_gfortran_test to clubb_bin_diff_regression_gfortran_test_old to reflect current usage. (details)
  2. This commit is not bit changing (details)
  3. This commt is not bit changing (details)
  4. The G_unit tests never allocated pdf_implicit_coefs_terms. It's unclear to me how these were working before, but it seems that something about making these 2D allocatable arrays exposed the bug. (details)
  5. Making zt2zm calls with pdf_implicit_coefs_terms use the 2D version. (details)
  6. Removing setup_grid and setup_parameters functionality from setup_clubb_core. This is beacuse in host models the required grid information may not be known during the setup process, resulting in dummy arguments for setup_clubb_core and the grid and paramters being setup during runtime anyway. Now, in the host models we can call these subroutines immediately after setup_clubb_core to maintain identical functionality (sam, wrf), and in others we can wait to call these until the main timestepping procedure (cam,e3sm). (details)
  7. Making 2D versions of setup_grid and setup_parameters. (details)
Commit d3e945d16e887b46b07827c135f73d33831fa900 by pbroels
Changed clubb_bin_diff_regression_gfortran_test_new to clubb_bin_diff_regression_gfortran_test and clubb_bin_diff_regression_gfortran_test to clubb_bin_diff_regression_gfortran_test_old to reflect current usage.
The file was addedjenkins_tests/clubb_bin_diff_regression_gfortran_test_old/Jenkinsfile
The file was modified jenkins_tests/clubb_bin_diff_regression_gfortran_test/Jenkinsfile (diff)
The file was removedjenkins_tests/clubb_bin_diff_regression_gfortran_test_new/Jenkinsfile
Commit 291e87da51321a48b5c9d5c46e6b4459b51ab2a4 by noreply
This commit is not bit changing
The file was modified README (diff)
Commit 0ff480f574ef756272df942a2cd6e217fba760e2 by noreply
This commt is not bit changing

But commit e4f125ba067ba8083f917e0e06b6b2398483d3e4 was BIT_CHANGING for simulations that use silhs
The file was modified README (diff)
Commit aa26820b4f080d4a8721dd0f578737344061f9a3 by Gunther Huebler
The G_unit tests never allocated pdf_implicit_coefs_terms. It's unclear to me how these were working before, but it seems that something about making these 2D allocatable arrays exposed the bug.
The file was modified src/CLUBB_core/new_pdf_main.F90 (diff)
The file was modified src/G_unit_test_types/spurious_source_test.F90 (diff)
The file was modified src/G_unit_test_types/pdf_parameter_tests.F90 (diff)
The file was modified src/CLUBB_core/new_hybrid_pdf_main.F90 (diff)
Commit b736467752bbdc37c77ea2504d0b4ffcc7383ac8 by Gunther Huebler
Making zt2zm calls with pdf_implicit_coefs_terms use the 2D version.
The file was modified src/CLUBB_core/advance_xp2_xpyp_module.F90 (diff)
Commit 8b9b43ecb1c82b2a06882613bbe7e2e61b86e0af by Gunther Huebler
Removing setup_grid and setup_parameters functionality from setup_clubb_core. This is beacuse in host models the required grid information may not be known during the setup process, resulting in dummy arguments for setup_clubb_core and the grid and paramters being setup during runtime anyway. Now, in the host models we can call these subroutines immediately after setup_clubb_core to maintain identical functionality (sam, wrf), and in others we can wait to call these until the main timestepping procedure (cam,e3sm).
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
The file was modified src/clubb_driver.F90 (diff)
The file was modified src/CLUBB_core/clubb_api_module.F90 (diff)
Commit ed85915bbcd00d1dba9b17752de763547bfa429b by Gunther Huebler
Making 2D versions of setup_grid and setup_parameters.
The file was modified src/CLUBB_core/parameters_tunable.F90 (diff)
The file was modified src/G_unit_test_types/spurious_source_test.F90 (diff)
The file was modified src/CLUBB_core/grid_class.F90 (diff)
The file was modified src/CLUBB_core/clubb_api_module.F90 (diff)