Skip to content
Success

Changes

Summary

  1. Making column mirror test work by comparing two different output files rather than one. This test now runs once with 3 different columns in a certain order, say ABC, and again with reverse order CBA, then ensures that A=A B=B and C=C (bit-for-bit equivalence) in both files. This should fail now actually, as there is currently a bug, and this update is intented to improve this test so that it fails before we fix the bug (details)
  2. Making column mirror test use CPU. This makes it much faster and doesn't change the test at all - not sure why I made it use GPU originally. (details)
  3. Fixing microphys bug that has been around for quite a while. This happened when making clubb standalone use multiple columns, and only affects columns other than the first. This is BIT_CHANGING, but only for microphysics cases using multiple columns (#1358) (details)
Commit 9baabf2f36b5f7b9c88b719954598e278be24a1a by Gunther Huebler
Making column mirror test work by comparing two different output files rather than one. This test now runs once with 3 different columns in a certain order, say ABC, and again with reverse order CBA, then ensures that A=A B=B and C=C (bit-for-bit equivalence) in both files. This should fail now actually, as there is currently a bug, and this update is intented to improve this test so that it fails before we fix the bug
The file was modifiedtests/check_mirrored_multi_col_output.py (diff)
The file was modifiedjenkins_tests/clubb_nvhpc_gpu_column_mirror_test/Jenkinsfile (diff)
The file was modifiedtests/README (diff)
Commit 26cfce3b9083a3d32fe4fbec9d4294c2cbafdc27 by Gunther Huebler
Making column mirror test use CPU. This makes it much faster and doesn't change the test at all - not sure why I made it use GPU originally.
The file was removedjenkins_tests/clubb_nvhpc_gpu_column_mirror_test/Jenkinsfile
The file was addedjenkins_tests/clubb_column_mirror_test/Jenkinsfile
Commit 37da5d26c1a8137c484f3b8b0eb1a5d79ac011b8 by noreply
Fixing microphys bug that has been around for quite a while. This happened when making clubb standalone use multiple columns, and only affects columns other than the first. This is BIT_CHANGING, but only for microphysics cases using multiple columns (#1358)
The file was modifiedsrc/Microphys/microphys_driver.F90 (diff)
The file was modifiedsrc/Microphys/mixed_moment_PDF_integrals.F90 (diff)
The file was modifiedsrc/CLUBB_core/advance_xp2_xpyp_module.F90 (diff)
The file was modifiedsrc/SILHS/est_kessler_microphys_module.F90 (diff)