Skip to content
Success

Changes

Summary

  1. Creating new flags to control monotonic flux limiter (#1039) (details)
  2. I am adding cloudy_updraft_frac and cloudy_downdraft_frac as (details)
  3. I forgot to add cld_updr_frac and cld_downdr_frac to all_stats.in (details)
Commit 5b79c73c681b98162df10f5500226f6940704016 by noreply
Creating new flags to control monotonic flux limiter (#1039)

* Creating new flags to control monotonic flux limiter and the IF statement fix for the spikes found in CAM.

* Removing no-longer-necessary logical l_mono_flux_lim.

* Adding requested changes from PR (intent statements and editing error statement).

* Accidentally set flag to false. Changing to true.
The file was modified src/clubb_tuner.F90 (diff)
The file was modified src/CLUBB_core/model_flags.F90 (diff)
The file was modified src/CLUBB_core/advance_xm_wpxp_module.F90 (diff)
The file was modified src/CLUBB_core/mono_flux_limiter.F90 (diff)
The file was modified input/tunable_parameters_compatible_r8029/configurable_model_flags.in (diff)
The file was modified src/CLUBB_core/clubb_api_module.F90 (diff)
The file was modified src/G_unit_test_types/pdf_parameter_tests.F90 (diff)
The file was modified input/tunable_parameters_e3sm/configurable_model_flags.in (diff)
The file was modified input/tunable_parameters_Lscale/configurable_model_flags.in (diff)
The file was modified input/tunable_parameters/configurable_model_flags.in (diff)
The file was modified src/clubb_driver.F90 (diff)
The file was modified src/G_unit_test_types/spurious_source_test.F90 (diff)
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
Commit 7550b3e11a7b6218c5eedc78f78e6397423141bb by bmg2
I am adding cloudy_updraft_frac and cloudy_downdraft_frac as
outputs to the calculate_w_up_in_cloud code.

These fields are non-interactive for the standard set of cases.
Thus, all cases are bit-for-bit identical.

However, for the w_up_in_cloud and w_down_in_cloud results themselves,
it is possible that results might not be bit-for-bit since
the location of the max(eps, ...) clipping in the denominator
is changed.  However, results should not be appreciable different.
The file was modified src/clubb_driver.F90 (diff)
The file was modified src/CLUBB_core/clubb_api_module.F90 (diff)
The file was modified src/CLUBB_core/pdf_closure_module.F90 (diff)
The file was modified src/CLUBB_core/stats_clubb_utilities.F90 (diff)
The file was modified src/CLUBB_core/stats_variables.F90 (diff)
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
The file was modified src/CLUBB_core/stats_zt_module.F90 (diff)
The file was modified src/G_unit_test_types/w_up_in_cloud_tests.F90 (diff)
Commit dd43df7acdaec448a6db87daff8537523060d646 by bmg2
I forgot to add cld_updr_frac and cld_downdr_frac to all_stats.in
in the last commit.
The file was modified input/stats/all_stats.in (diff)