Skip to content
Success

Changes

Summary

  1. Multicol CLUBB (#1193) (details)
Commit ebbe8662d74aaeb06f853280849b84c54d47edc2 by noreply
Multicol CLUBB (#1193)

* Adding column loop to run_clubb

* Lot more changes

* Adding multicolumn output support and improving stats code.

* Conditionally closing stats files. This is just a bug fix. I'm not sure how this ever worked without the conditionals.

* Improvements and some cleanup.

* Bug fix

* Merge with master

* Removing num_standalone_columns, it's no longer needed.

* Changes to make CPU vs GPU test work with new multicol mode. Columns now run with different parameter sets, tolerance script checks average diff instead, increasing number of cobra timestep run, removing mpace_b because it turns out that cobra has ice and is capable of detecting the same ice code errors that mpace_b was added to test.

* Jenkins script update

* Jenkins script update

* Jenkins script update

* Jenkins script update

* Jenkins script update

* Jenkins script update

* Tightening tolerance

* Script cleanup and improvement

* Some more slight changes and cleanup. Making monoflux script work with new multicol mode.

* Small bug fix that was breaking bugsrad when using multiple columns.

* Bug fix to script

* Small cleanup and renaming of read_parameters

* Slight update to ifdef NETCDF statement

* Better change to ifdefs

* Adding new name init_read_clubb_params_api to public api list

* Name changes and adding section in README

* Renaming script

* Renaming script

* Removing C1 from list of variables to change, it was breaking the CPU vs GPU test, and also clubb warns that 'l_damp_wp2_using_em = T requires C1=C14 and l_stability_correct_tau_zm = F', so perhaps chaning it is just unstable. I've confirmed that GPU bugs are still dectable though.
The file was modified input/case_setups/gabls2_model.in (diff)
The file was modified input/case_setups/cloud_feedback_s6_model.in (diff)
The file was modified input/case_setups/dycoms2_rf02_ds_model.in (diff)
The file was modified input/case_setups/dycoms2_rf02_nd_model.in (diff)
The file was modified input/case_setups/mc3e_model.in (diff)
The file was modified input/case_setups/rico_silhs_model.in (diff)
The file was modified input/case_setups/cloud_feedback_s6_p2k_model.in (diff)
The file was modified src/jacobian.F90 (diff)
The file was modified input/case_setups/dycoms2_rf02_nd_model.LR.in (diff)
The file was modified src/G_unit_test_types/pdf_parameter_tests.F90 (diff)
The file was modified input/case_setups/nov11_altocu_model.in (diff)
The file was modified input/case_setups/dycoms2_rf02_morr_model.in (diff)
The file was modified src/clubb_model_settings.F90 (diff)
The file was modified input/case_setups/cgils_s11_model.in (diff)
The file was modified input/case_setups/dycoms2_rf01_fixed_sst_model.in (diff)
The file was modified input/case_setups/dycoms2_rf02_do_model.HR.in (diff)
The file was modified src/clubb_standalone.F90 (diff)
The file was modified src/SILHS/latin_hypercube_driver_module.F90 (diff)
The file was modified input/case_setups/cgils_s6_model.in (diff)
The file was modified input/case_setups/jun25_altocu_model.in (diff)
The file was modified input/case_setups/mpace_a_model.in (diff)
The file was removedrun_scripts/check_multicol_error.py
The file was modified src/clubb_driver.F90 (diff)
The file was modified input/case_setups/README (diff)
The file was modified input/case_setups/mpace_b_silhs_model.in (diff)
The file was modified input/tunable_parameters/configurable_model_flags.in (diff)
The file was modified input/case_setups/rico_model.in (diff)
The file was modified input/tunable_parameters_Lscale/configurable_model_flags.in (diff)
The file was modified input/case_setups/neutral_model.in (diff)
The file was modified src/sounding.F90 (diff)
The file was modified input/case_setups/dycoms2_rf02_so_model.HR.in (diff)
The file was modified input/case_setups/mpace_b_model.in (diff)
The file was modified src/CLUBB_core/parameters_tunable.F90 (diff)
The file was modified input/case_setups/cloud_feedback_s12_model.in (diff)
The file was modified src/SILHS/silhs_api_module.F90 (diff)
The file was modified input/case_setups/gabls3_night_model.in (diff)
The file was modified input/case_setups/arm_model.in (diff)
The file was modified input/case_setups/dycoms2_rf02_nd_model.HR.in (diff)
The file was modified input/case_setups/atex_model.in (diff)
The file was modified src/CLUBB_core/stats_clubb_utilities.F90 (diff)
The file was modified src/CLUBB_core/output_netcdf.F90 (diff)
The file was modified input/case_setups/lba_model.in (diff)
The file was modified input/case_setups/arm_0003_model.in (diff)
The file was modified input/case_setups/dycoms2_rf02_so_model.in (diff)
The file was modified input/case_setups/cloud_feedback_s11_model.in (diff)
The file was modified input/case_setups/clex9_oct14_model.in (diff)
The file was modified input/case_setups/bomex_model.in (diff)
The file was modified input/case_setups/clex9_nov02_model.in (diff)
The file was modified input/case_setups/wangara_model.in (diff)
The file was addedrun_scripts/check_multi_col_error.py
The file was modified input/case_setups/twp_ice_model.in (diff)
The file was modified README (diff)
The file was modified input/case_setups/cloud_feedback_s11_p2k_model.in (diff)
The file was modified input/case_setups/cgils_s12_p2k_model.in (diff)
The file was modified src/error.F90 (diff)
The file was modified input/case_setups/dycoms2_rf02_ds_model.LR.in (diff)
The file was modified jenkins_tests/clubb_nvhpc_gpu_vs_cpu_diffness/Jenkinsfile (diff)
The file was modified input/case_setups/cgils_s6_p2k_model.in (diff)
The file was modified input/case_setups/gabls3_model.in (diff)
The file was modified input/case_setups/cloud_feedback_s12_p2k_model.in (diff)
The file was modified src/G_unit_test_types/spurious_source_test.F90 (diff)
The file was modified src/clubb_thread_test.F90 (diff)
The file was modified src/input_netcdf.F90 (diff)
The file was modified input/case_setups/dycoms2_rf02_do_model.in (diff)
The file was modified input/case_setups/fire_model.in (diff)
The file was modified input/case_setups/cobra_model.in (diff)
The file was modified src/CLUBB_core/clubb_api_module.F90 (diff)
The file was modified input/case_setups/cgils_s11_p2k_model.in (diff)
The file was modified input/case_setups/dycoms2_rf02_do_model.LR.in (diff)
The file was modified input/case_setups/astex_a209_model.in (diff)
The file was modified run_scripts/test_monoflux_limiter_GPU.py (diff)
The file was modified input/grid/README (diff)
The file was modified input/case_setups/arm_97_model.in (diff)
The file was modified input/case_setups/arm_3year_model.in (diff)
The file was modified input/case_setups/dycoms2_rf02_ds_model.HR.in (diff)
The file was modified input/case_setups/dycoms2_rf02_so_model.LR.in (diff)
The file was modified input/case_setups/cgils_s12_model.in (diff)
The file was addedrun_scripts/create_multi_col_params.py
The file was modified input/case_setups/dycoms2_rf01_model.in (diff)