Skip to content
Failed

Changes

Summary

  1. These changes allow you to call the 4 clubb "advance" subroutines in any (details)
  2. Placing the order variables in a nice, convenient place for testing use. (details)
  3. I reordered advance_clubb_core so that the "Advance xp3" (which is a (details)
  4. I am committing the idiot-proofing code that forces l_min_xp2_from_corr_wx (details)
  5. I am indenting the portion of the code where the advance subroutines (details)
  6. Temporarily commenting out the idiot proofing in order to run some tests ... (details)
  7. Now official reinstating the idiot-proofing and turning off the (details)
  8. I am committing some idiot proofing in regards to the advance (details)
Commit a7c61266346ca0d113aaf2e12fc9580c8a6186d0 by Brian Griffin
These changes allow you to call the 4 clubb "advance" subroutines in any
order that you want to try. In the default order (where the order is the
same as found in the current version of the CLUBB master), results are
bit-for-bit when compared to CLUBB master.
The file was modified src/CLUBB_core/advance_xm_wpxp_module.F90 (diff)
The file was modified src/G_unit_test_types/spurious_source_test.F90 (diff)
The file was modified src/CLUBB_core/advance_windm_edsclrm_module.F90 (diff)
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
Commit 35d03fc4ee564148d7c718591ba0e48b86c97072 by Brian Griffin
Placing the order variables in a nice, convenient place for testing use.
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
Commit 05a0c45a46b4d2bb8afbb235969868a878d755d3 by Brian Griffin
I reordered advance_clubb_core so that the "Advance xp3" (which is a
basic calculation of xp3 by the ansatz by default) section is moved out
of the way of the "advance loop" to a point that is after
advance_windm_edsclrm (or whatever will be called last in the advance
loop.

This change does not alter the default results. Everything is still
bit-for-bit.
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
Commit ab8d447789861d018a0e50d06bedea3e044d5ecb by Brian Griffin
I am committing the idiot-proofing code that forces l_min_xp2_from_corr_wx
and l_enable_relaxed_clipping to have opposite values (one must be true
and the other must be false). In this commit, both are set to true, so
the code will produce an exception.
The file was modified src/CLUBB_core/advance_xm_wpxp_module.F90 (diff)
The file was modified src/CLUBB_core/clubb_api_module.F90 (diff)
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
The file was modified src/clubb_driver.F90 (diff)
Commit 9b22e11df82804105e6f34728d42e29ebd8dc9da by Brian Griffin
I am indenting the portion of the code where the advance subroutines
are located within the new ordering loop.
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
Commit 71ab332a524b2802f9e406d8e9ac00712a3b96c0 by Brian Griffin
Temporarily commenting out the idiot proofing in order to run some tests ...
The results from this branch are still bit-for-bit with the master branch.
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
Commit 06d48b1c9da2a8a65f080fa16450d807b97a19ea by bmg2
Now official reinstating the idiot-proofing and turning off the
l_enable_relaxed_clipping flag. This commit is BIT_CHANGING
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
The file was modified src/CLUBB_core/advance_xm_wpxp_module.F90 (diff)
Commit fa5559b6fd09f3da30b4d4d0255c532b3dd53607 by bmg2
I am committing some idiot proofing in regards to the advance
subroutines ordering. No index can have a value of less than 1,
greater than 4, and no index can have the same value as any other
index. Each adv routine order index must have a unique value.
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)