Skip to content
Success

Changes

Summary

  1. Ri_zm calc (Part 2) - Move the brunt_vaisala smoothing into calc_brunt_vaisala_freq_sqd (#1156) (details)
  2. Testing the new module system with our GPU diffness test. See https://github.com/larson-group/sys_admin/issues/829 (details)
  3. The module system is setup via paths in /etc/profile.d/larson-group.sh, so we need to source it. https://github.com/larson-group/sys_admin/issues/829 (details)
  4. Fixing bug in jenkinsfiles. (details)
Commit e3a10e0ff494ca2a57b5895f5ab8cb40b45e7036 by noreply
Ri_zm calc (Part 2) - Move the brunt_vaisala smoothing into calc_brunt_vaisala_freq_sqd (#1156)

CLUBB ticket #1145

Includes previous steps:
* First step: Move call to calc_bv
* Ri_zm calc (Part 1.5) - Adjusted signature of diagnose_Lscale_from_tau #1145

Newest changes: Ri_zm calc (Part 2) - Move brunt_vaisala smoothing into calc_brunt_vaisala_freq_sqd

`brunt_vaisala_frq_sqd_smth` is now calculated in subroutine `calc_brunt_vaisala_freq_sqd` and it is now written to disk in `advance_clubb_core` with all the other `brunt_vaisala` variables.

Unfortunately, I had to make a couple more changes since moving this calculation into `calc_brunt_vaisala_freq_sqd` meant that any subroutine involved in calling `calc_stability_correction` would need to get `l_modify_limiters_for_cnvg_test` fed in, because `calc_brunt_vaisala_freq_sqd` is also called in `calc_stability_correction`.

This commit is BIT_CHANGING since `brunt_vaisala_frq_sqd_smth` used to be all zeros before this change in Lscale mode and now it is actually calculated. BFB in taus code.
The file was modified src/G_unit_test_types/spurious_source_test.F90 (diff)
The file was modified src/CLUBB_core/advance_xm_wpxp_module.F90 (diff)
The file was modified src/CLUBB_core/mixing_length.F90 (diff)
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
The file was modified src/CLUBB_core/advance_helper_module.F90 (diff)
Commit 40d301330e9263c649c014bcae7e371829f42ac8 by Gunther Huebler
Testing the new module system with our GPU diffness test. See https://github.com/larson-group/sys_admin/issues/829
The file was modified jenkins_tests/clubb_nvhpc_gpu_vs_cpu_diffness/Jenkinsfile (diff)
The file was modified compile/config/linux_x86_64_nvhpc_gpu_openmp.bash (diff)
The file was modified compile/config/linux_x86_64_nvhpc.bash (diff)
The file was modified compile/config/linux_x86_64_nvhpc_gpu_openacc.bash (diff)
Commit a166adc53620547cc0858fc77d0ab03095fcce70 by Gunther Huebler
The module system is setup via paths in /etc/profile.d/larson-group.sh, so we need to source it. https://github.com/larson-group/sys_admin/issues/829
The file was modified jenkins_tests/clubb_nvhpc_gpu_vs_cpu_diffness/Jenkinsfile (diff)
Commit bff26070fff07143dd27206fd332f3ccbfc2556b by Gunther Huebler
Fixing bug in jenkinsfiles.
The file was modified jenkins_tests/clubb_nvhpc_gpu_vs_cpu_diffness/Jenkinsfile (diff)