Skip to content
Sign in
Success

Changes

Summary

  1. Toolchain names were changed, so the references to them should've changed in the jenkins tests. (details)
  2. Toolchain names were changed, so the references to them should've changed in this test too. (details)
  3. ADG1_w_closure consistency fix (#1282) (details)
  4. Fixing clubb_error_handling_gfortran_test (#1281) (details)
Commit 02123793194ca95295bbd90c35129faf395b9525 by Gunther Huebler
Toolchain names were changed, so the references to them should've changed in the jenkins tests.
The file was modifiedjenkins_tests/clubb_nvhpc_gpu_vs_cpu_diffness/Jenkinsfile (diff)
The file was modifiedjenkins_tests/clubb_nvhpc_gpu_column_mirror_test/Jenkinsfile (diff)
Commit 36ca61e3203b201832c5ca74ce764fc7e97786a8 by Gunther Huebler
Toolchain names were changed, so the references to them should've changed in this test too.
The file was modifiedrun_scripts/test_monoflux_limiter_GPU.py (diff)
Commit c15b1d3c005fdffa76902e976acdb5db5dbde012 by noreply
ADG1_w_closure consistency fix (#1282)

* G_unit_test / ADG1_w_closure fix. A recent commit (bff619bdb2836f83ac658be8b8c258d41aaa6e14) introduced a change to ADG1_ADG2_responder_params that caused an inconsistency in the pdf calculations that the G_unit tests picked up on. This corrects it, but is also BIT_CHANGING, since it changes the calculation slightly when wp2 is exactly tolerance.

* Adding test to ensure err_info is correctly set by adg1 routines when calling with bad inputs - also moving wp2 check to ADG1_w_closure because it makes more sense there
The file was modifiedsrc/G_unit_test_types/pdf_parameter_tests.F90 (diff)
The file was modifiedsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90 (diff)
The file was modifiedsrc/G_unit_tests.F90 (diff)
The file was modifiedsrc/G_unit_test_types/spurious_source_test.F90 (diff)
Commit bdee6e6dbac76a996cdf73a88522c47affdd4d90 by noreply
Fixing clubb_error_handling_gfortran_test (#1281)

* Fixing error test by making the code check for NaNs in all solver cases - before it was only checking in Lapack. Also making a python version of the test and updating jenkins script to use it.

* A little cleanup

* Adding more comments and making a little data structure for the tests
The file was modifiedjenkins_tests/clubb_error_handling_gfortran_test/Jenkinsfile (diff)
The file was modifiedsrc/CLUBB_core/lapack_wrap.F90 (diff)
The file was addedrun_scripts/test_fatal_error_handling.py
The file was modifiedsrc/CLUBB_core/matrix_solver_wrapper.F90 (diff)