Skip to content
Success

Changes

Summary

  1. Clubb ticket #1025: Implemented way to make esa tuner reproducible, h… (#1068) (details)
Commit 981b9ba9bc9b5d80edc82f52f502ab9bcce097db by noreply
Clubb ticket #1025: Implemented way to make esa tuner reproducible, h… (#1068)

* Clubb ticket #1025: Implemented way to make esa tuner reproducible, hid error output of optional diagnostic variables behind check, fixed parallelization issue with tuner, esa max_iters parameter is now in stats namelist, fixed issue with TUNER compiler directive, some small fixes.
- New namelist variables prescribed_rand_seed and l_use_prescribed_rand_seed determine if the esa tuner will use a random or a fixed value as random seed. Added descriptions to README.
- Added max_iters to stats namelist to make it more modifiable.
- Renamed stp_adjst_intercept_in and stp_adjst_slope_in to stp_adjst_shift_in and stp_adjst_factor_in, respectively, to better reflect their influence on step size.
- The error output in src/CLUBB_core/pdf_closure_module.F90 for the diagnostic variables wprtp2, wpthlp2, wprtpthlp, and rcp2 is now hidden behind existence checks for these variables. And a clarification was added to "#ifdef TUNER" directive.
- NetCDF file access caused the tuner to crash in parallel mode (-fopenmp flag in config file and multiple cases). Adding an $OMP CRITICAL structure around the call to stats_init in clubb_driver.F90 fixed that.
- Fixed compile/README. Config files are specified with the -c option.
- The -t option in run_scripts/run_tuner.bash interfered with the previous usage of the TUNER compiler directive. Renamed the old TUNER directive to NR_SP, a short for "numerical recipes, single precision". TUNER now is the option to "turn on" code changes required to run the tuner.
The file was modified input_misc/tuner/error_fire.in (diff)
The file was modified input_misc/tuner/error_dycoms2_rf02_nd.in (diff)
The file was modified input_misc/tuner/error_nov11_altocu.in (diff)
The file was modified input_misc/tuner/error_dycoms2_rf02_ds.in (diff)
The file was modified input_misc/tuner/error_four_cases.in (diff)
The file was modified input_misc/tuner/error_arm.in (diff)
The file was modified input_misc/tuner/error_rico.in (diff)
The file was modified input_misc/tuner/error_atex.in (diff)
The file was modified src/G_unit_test_types/tuner_tests.F90 (diff)
The file was modified input_misc/tuner/error_all.in (diff)
The file was modified input_misc/tuner/error_gabls3_night.in (diff)
The file was modified compile/README (diff)
The file was modified src/clubb_driver.F90 (diff)
The file was modified input_misc/tuner/error_dycoms2_rf02_do.in (diff)
The file was modified input_misc/tuner/error_wangara.in (diff)
The file was addedinput_misc/tuner/error_bomex_fire.in
The file was modified src/enhanced_simann.F90 (diff)
The file was modified compile/compile.bash (diff)
The file was modified README (diff)
The file was modified src/error.F90 (diff)
The file was modified input_misc/tuner/error_gabls2.in (diff)
The file was modified input_misc/tuner/error_bomex.in (diff)
The file was modified input_misc/tuner/error_lba.in (diff)
The file was modified input_misc/tuner/error_ticket_756.in (diff)
The file was modified input_misc/tuner/error_arm_97.in (diff)
The file was modified input_misc/tuner/error_dycoms2_rf01.in (diff)
The file was modified input_misc/tuner/README (diff)
The file was modified src/clubb_tuner.F90 (diff)
The file was modified src/CLUBB_core/pdf_closure_module.F90 (diff)