Skip to content
Failed

Changes

Summary

  1. Clubb driver upgrades part2 (#1257) (details)
  2. Clubb driver upgrades part2 (#1257) (details)
  3. Changes needed for compatibility with clubb_driver_upgrades_part2, from PR https://github.com/larson-group/clubb/pull/1257 (#204) (details)
Commit 6061db38ecdeb1e2e7a5f50a1c0dfdb784e7a155 by noreply
Clubb driver upgrades part2 (#1257)

* Initial commit. Breaking up clubb driver into sections. This should be bfb on everything, but this hasn't been checked well yet.

* Combining namelist read into case init, same stuff really

* Reorganizing many things, mainly in the pursuit of sectioning off code into groups like Microphys or Radiation

* Organizing clubb_driver. All cases still BFB.

* Mostly cosmetic improvements

* Small improvements, comments, making clubb_driver_test to ensure consistency functionality of new compartmentalized model run components

* Removing accidentally added files.

* Mostly breaking up structure initialization behavior, split into init_ and zero_ so that we don't have to allocate to reset.

* Doing away with clubb_model_settings and parameters_module in the spirit of consolidating functionality and spiting module variables.

* Missed some changes to commit, should've been included in previous commit

* Splitting up funcionality of setup_parameters. Now theres one part that calculates and another checks flag values.

* GPU code working, but not BFB yet

* GPU all BFB with mutliple columns, except gabls3, and driver test doesnt work (pass reinitialize, fails double timestep test)

* Turning off multi_column output for the new driver test

* Changes needed after rebase

* Name changes, comments, and threadprivate additions for parallel runs

* Adding variables to openacc data statements. Without this, the code crashes when using the GPU with l_godunov_upwind_xpyp_ta=.true.

* Modifying compiler configurations (mainly optimization level) in order to prepare for switching scipts and tests to cmake, specifically separating out this BIT_CHANGING commit from the rest

* thlm_ed and rtm_ed caused GPU errors since those variables were added to a acc loop, but never added to the acc data statement. This change makes it so they're only calculated on the CPU, since they are only used for stats, fixing the issue without adding the GPU memory footprint.

* Adding -Mstack_arrays to the nvfortran flags causes us to use more stack space, which means we need to allow processes to use more stack space (when using lots of columns, since that increases memory footprint). We do by using using 'ulimit BIGNUMBER'.

* Making old compiler script work with new file structure, also making Input_fields directory and library.

* Missed text_writer_lib

* Undoing Input_fields directory, it has too many depencencies currently, certainly can be simplified with argument lists.

* Adding library dependency

* Small changes to cmake list

* Adding openmp flag back to gfortran script, needed for jenkins test

* Making the init_inputfields get called for restarts too, because restart code call input_field code.

* Making pdf_implicit_coefs_terms conditional in generalized grid test

* Adding microphys directory to acc_to_omp script

* Renaming -iters option in run_scm.py to -max_iters

* Making run_scm_all.py and new driver test

* Test and script improvements

* Limiting iterations in jenkins test

* Name change

* adding ulimit

* name update

* jenkins script update

* jenkins script update

* jenkins script update

* jenkins script update

* jenkins script and run_scm_all.py update

* jenkins script update

* Turning calc_lmin_nu into calc_derrived_params, which is more general, and now calculates mixt_frac_max_mag

* Small improvement for GPU

* Small updates needed for host model integration

* Removing accidentally added file

* Small cleanup
The file was modified mixing_length.F90 (diff)
The file was modified numerical_check.F90 (diff)
The file was modified clubb_api_module.F90 (diff)
The file was modified pdf_closure_module.F90 (diff)
The file was modified CMakeLists.txt (diff)
The file was modified advance_helper_module.F90 (diff)
The file was modified grid_class.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified grid_adaptation_module.F90 (diff)
The file was modified advance_windm_edsclrm_module.F90 (diff)
The file was modified advance_xm_wpxp_module.F90 (diff)
The file was removedmt95.F90
The file was modified parameters_tunable.F90 (diff)
The file was modified stats_clubb_utilities.F90 (diff)
The file was modified hydromet_pdf_parameter_module.F90 (diff)
The file was removedparameters_model.F90
The file was modified sfc_varnce_module.F90 (diff)
The file was modified output_netcdf.F90 (diff)
The file was modified pdf_parameter_module.F90 (diff)
The file was modified clip_explicit.F90 (diff)
The file was modified model_flags.F90 (diff)
Commit 65c0ff8e7f89aa0cf15f016d0bec345de92a4b1f by noreply
Clubb driver upgrades part2 (#1257)

* Initial commit. Breaking up clubb driver into sections. This should be bfb on everything, but this hasn't been checked well yet.

* Combining namelist read into case init, same stuff really

* Reorganizing many things, mainly in the pursuit of sectioning off code into groups like Microphys or Radiation

* Organizing clubb_driver. All cases still BFB.

* Mostly cosmetic improvements

* Small improvements, comments, making clubb_driver_test to ensure consistency functionality of new compartmentalized model run components

* Removing accidentally added files.

* Mostly breaking up structure initialization behavior, split into init_ and zero_ so that we don't have to allocate to reset.

* Doing away with clubb_model_settings and parameters_module in the spirit of consolidating functionality and spiting module variables.

* Missed some changes to commit, should've been included in previous commit

* Splitting up funcionality of setup_parameters. Now theres one part that calculates and another checks flag values.

* GPU code working, but not BFB yet

* GPU all BFB with mutliple columns, except gabls3, and driver test doesnt work (pass reinitialize, fails double timestep test)

* Turning off multi_column output for the new driver test

* Changes needed after rebase

* Name changes, comments, and threadprivate additions for parallel runs

* Adding variables to openacc data statements. Without this, the code crashes when using the GPU with l_godunov_upwind_xpyp_ta=.true.

* Modifying compiler configurations (mainly optimization level) in order to prepare for switching scipts and tests to cmake, specifically separating out this BIT_CHANGING commit from the rest

* thlm_ed and rtm_ed caused GPU errors since those variables were added to a acc loop, but never added to the acc data statement. This change makes it so they're only calculated on the CPU, since they are only used for stats, fixing the issue without adding the GPU memory footprint.

* Adding -Mstack_arrays to the nvfortran flags causes us to use more stack space, which means we need to allow processes to use more stack space (when using lots of columns, since that increases memory footprint). We do by using using 'ulimit BIGNUMBER'.

* Making old compiler script work with new file structure, also making Input_fields directory and library.

* Missed text_writer_lib

* Undoing Input_fields directory, it has too many depencencies currently, certainly can be simplified with argument lists.

* Adding library dependency

* Small changes to cmake list

* Adding openmp flag back to gfortran script, needed for jenkins test

* Making the init_inputfields get called for restarts too, because restart code call input_field code.

* Making pdf_implicit_coefs_terms conditional in generalized grid test

* Adding microphys directory to acc_to_omp script

* Renaming -iters option in run_scm.py to -max_iters

* Making run_scm_all.py and new driver test

* Test and script improvements

* Limiting iterations in jenkins test

* Name change

* adding ulimit

* name update

* jenkins script update

* jenkins script update

* jenkins script update

* jenkins script update

* jenkins script and run_scm_all.py update

* jenkins script update

* Turning calc_lmin_nu into calc_derrived_params, which is more general, and now calculates mixt_frac_max_mag

* Small improvement for GPU

* Small updates needed for host model integration

* Removing accidentally added file

* Small cleanup
The file was modified CMakeLists.txt (diff)
The file was modified output_2D_samples_module.F90 (diff)
The file was modified latin_hypercube_driver_module.F90 (diff)
The file was addedmt95.F90
The file was modified silhs_api_module.F90 (diff)
Commit 03ffdce62430d42792ba7bb52c729bb5c6712fa2 by noreply
Changes needed for compatibility with clubb_driver_upgrades_part2, from PR https://github.com/larson-group/clubb/pull/1257 (#204)

The file was modified src/physics/cam/clubb_intr.F90 (diff)
The file was modified src/physics/cam/subcol_SILHS.F90 (diff)