Skip to content
Success

Changes

Summary

  1. This commit is not bit changing (details)
  2. The G_unit tests never allocated pdf_implicit_coefs_terms. It's unclear to me how these were working before, but it seems that something about making these 2D allocatable arrays exposed the bug. (details)
  3. Making zt2zm calls with pdf_implicit_coefs_terms use the 2D version. (details)
  4. Removing setup_grid and setup_parameters functionality from setup_clubb_core. This is beacuse in host models the required grid information may not be known during the setup process, resulting in dummy arguments for setup_clubb_core and the grid and paramters being setup during runtime anyway. Now, in the host models we can call these subroutines immediately after setup_clubb_core to maintain identical functionality (sam, wrf), and in others we can wait to call these until the main timestepping procedure (cam,e3sm). (details)
  5. Making compatible with latest clubb change. (details)
  6. Making 2D versions of setup_grid and setup_parameters. (details)
  7. Now using 2D versions of setup_grid and setup_parameters (details)
Commit c20662363e47160831e6737942e9f0074f06630d by noreply
This commit is not bit changing

but  the following commits are
        BIT_CHANGING:29e08c789aef09db2b76a418d3ab4c35bfc50a04
BIT_CHANGING:741338adec67b4d8d6087af4c8c3e2206692dc04
BIT_CHANGING:ed63800262913a0c130c80cd16067e7d68548613
for simulations that include silhs
The file was modified run_scripts/run_scam.bash (diff)
Commit 7bc6f76ec8b70bc1789f90b554dca47122c40001 by Gunther Huebler
The G_unit tests never allocated pdf_implicit_coefs_terms. It's unclear to me how these were working before, but it seems that something about making these 2D allocatable arrays exposed the bug.
The file was modified new_hybrid_pdf_main.F90 (diff)
The file was modified new_pdf_main.F90 (diff)
Commit de73c4eefaee2b50045b4f5e706868e84b0f4550 by Gunther Huebler
Making zt2zm calls with pdf_implicit_coefs_terms use the 2D version.
The file was modified advance_xp2_xpyp_module.F90 (diff)
Commit 3643c78f6fe2260f971bba96ead125858b665f1c by Gunther Huebler
Removing setup_grid and setup_parameters functionality from setup_clubb_core. This is beacuse in host models the required grid information may not be known during the setup process, resulting in dummy arguments for setup_clubb_core and the grid and paramters being setup during runtime anyway. Now, in the host models we can call these subroutines immediately after setup_clubb_core to maintain identical functionality (sam, wrf), and in others we can wait to call these until the main timestepping procedure (cam,e3sm).
The file was modified clubb_api_module.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
Commit 25568b67709f1d52bc277cbd64bca0ee4c6b86c0 by Gunther Huebler
Making compatible with latest clubb change.
The file was modified src/physics/cam/clubb_intr.F90 (diff)
Commit c623b91a9bf812b85b51b575233ad00e8b98f16c by Gunther Huebler
Making 2D versions of setup_grid and setup_parameters.
The file was modified parameters_tunable.F90 (diff)
The file was modified grid_class.F90 (diff)
The file was modified clubb_api_module.F90 (diff)
Commit ffa8c5c5860210f89bb463fc8aac90c1ba9c5e00 by Gunther Huebler
Now using 2D versions of setup_grid and setup_parameters
The file was modified src/physics/cam/clubb_intr.F90 (diff)