Started by an SCM change76d3946a586f66f155af6c32d7c6f9ed92389388cfd3946a586f66f155af6c32d7c6f9ed92389388cforigin/masterd3946a586f66f155af6c32d7c6f9ed92389388cfd3946a586f66f155af6c32d7c6f9ed92389388cforigin/master72c7eb33836dd22870dc48b2acd2b5b340dbeef909c7eb33836dd22870dc48b2acd2b5b340dbeef909origin/changes_to_not_breakc7eb33836dd22870dc48b2acd2b5b340dbeef909c7eb33836dd22870dc48b2acd2b5b340dbeef909origin/changes_to_not_break3489687a1ee74c0ebddbb19c8399a4a4488cbfc0a509687a1ee74c0ebddbb19c8399a4a4488cbfc0a50refs/remotes/origin/master9687a1ee74c0ebddbb19c8399a4a4488cbfc0a509687a1ee74c0ebddbb19c8399a4a4488cbfc0a50refs/remotes/origin/master9687a1ee74c0ebddbb19c8399a4a4488cbfc0a509687a1ee74c0ebddbb19c8399a4a4488cbfc0a50refs/remotes/origin/masterhttps://github.com/larson-group/wrf.gitfalse#34819428791483010wrf_clubb_silhs_parallel_ifort #348348false3481315SUCCESS1714638066287http://carson.math.uwm.edu/jenkins/view/all/job/wrf_clubb_silhs_parallel_ifort/348/advance_clubb_core_module.F90d6ca5b0e6179de58c7571bea8650e3cd93c3de5e1714537919000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bug. RESOLVED:556370c6406e6b943b88affbe7728a5036b1ba22, this was catchable by using debugging flags, but seems to otherwise cause no issues. Investigating I found that it only clips the below ground level, so that must not have been affecting other levels. This is technically BIT_CHANGING since it resolves an issue. 2024-04-30 23:31:59 -0500d6ca5b0e6179de58c7571bea8650e3cd93c3de5eFixing bug. RESOLVED:556370c6406e6b943b88affbe7728a5036b1ba22, this was catchable by using debugging flags, but seems to otherwise cause no issues. Investigating I found that it only clips the below ground level, so that must not have been affecting other levels. This is technically BIT_CHANGING since it resolves an issue.editadvance_clubb_core_module.F90fill_holes.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90clubb_api_module.F90advance_xm_wpxp_module.F90c2849fa3c750562ffdd5abd6bc9937c081e662261714587276000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking num_draw_points in fill_holes a constant. We were already using this value as a constant everywhere, but passing a constant by argument list makes it difficult/impossible for a compiler to optimize using that constant, unless it does inlining. Now, rather than passing the constant num_hf_draw_points (or sometimes a hardcoded 2) we just use num_hf_draw_points directly from constants_clubb. This massively improves the performance of a loop in fill holes when using nvhpc+omp, which was the motivation for this, but should also improve the performance on CPUs. Everything is BFB. 2024-05-01 13:14:36 -0500c2849fa3c750562ffdd5abd6bc9937c081e66226Making num_draw_points in fill_holes a constant. We were already using this value as a constant everywhere, but passing a constant by argument list makes it difficult/impossible for a compiler to optimize using that constant, unless it does inlining. Now, rather than passing the constant num_hf_draw_points (or sometimes a hardcoded 2) we just use num_hf_draw_points directly from constants_clubb. This massively improves the performance of a loop in fill holes when using nvhpc+omp, which was the motivation for this, but should also improve the performance on CPUs. Everything is BFB.editadvance_clubb_core_module.F90editclubb_api_module.F90editfill_holes.F90editadvance_wp2_wp3_module.F90editadvance_xp2_xpyp_module.F90editadvance_xm_wpxp_module.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse349http://carson.math.uwm.edu/jenkins/view/all/job/wrf_clubb_silhs_parallel_ifort/349/347http://carson.math.uwm.edu/jenkins/view/all/job/wrf_clubb_silhs_parallel_ifort/347/