Started by an SCM change76d3946a586f66f155af6c32d7c6f9ed92389388cfd3946a586f66f155af6c32d7c6f9ed92389388cforigin/masterd3946a586f66f155af6c32d7c6f9ed92389388cfd3946a586f66f155af6c32d7c6f9ed92389388cforigin/master72c7eb33836dd22870dc48b2acd2b5b340dbeef909c7eb33836dd22870dc48b2acd2b5b340dbeef909origin/changes_to_not_breakc7eb33836dd22870dc48b2acd2b5b340dbeef909c7eb33836dd22870dc48b2acd2b5b340dbeef909origin/changes_to_not_break2430ee1d3e76cd4919578a6233ef29f9e1fc2d8be650ee1d3e76cd4919578a6233ef29f9e1fc2d8be65refs/remotes/origin/master0ee1d3e76cd4919578a6233ef29f9e1fc2d8be650ee1d3e76cd4919578a6233ef29f9e1fc2d8be65refs/remotes/origin/master0ee1d3e76cd4919578a6233ef29f9e1fc2d8be650ee1d3e76cd4919578a6233ef29f9e1fc2d8be65refs/remotes/origin/masterhttps://github.com/larson-group/wrf.gitfalse#24330940991483010wrf_clubb_silhs_parallel_ifort #243243false24320013SUCCESS1674120008501http://carson.math.uwm.edu/jenkins/view/all/job/wrf_clubb_silhs_parallel_ifort/243/mixing_length.F90saturation.F90advance_clubb_core_module.F90model_flags.F9038b63ff28ea145707d4ee1d9469013ee20b1697b1674081416000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRestructuring and Porting of Compute_mixing_length subroutine(Phase 2) (#1054) * Restructuring and Porting of Compute_mixing_length subroutine(Phase 2) Restructure: sat_mixrat_liq_2D_acc is being directly called instead of calling the 1D version inside the column loop. Changing sat_mixrat_liq_2D_acc to a subroutine from a function and adding output array, start_index as additional argument. This is a workaround for passing sub-arrays. The OpenACC doen't like the sub-arrays being passed and fails the validation. Porting: OpenACC directives are added inside sat_mixrat_liq_2D_acc for porting Validation: Answers are Bit for Bit with arm-multicolumn case + nvhpc compiler * Fix for compilation issues Issue 1: Missed out declaring 'start_index' while intergrating the change Issue 2: The use of error_code module and the procedures inside it causes OpenACC compilation issues when run on the device. * Removing the sat_mixrat_liq_acc and sat_mixrat_liq_2D_acc, making the normal sat_mixrat_liq work for all current use cases, and making the other versions of sat_mixrat_liq (bolton,gfdl,lookup) functional with OPENACC. Co-authored-by: huebler <huebler@uwm.edu> 2023-01-18 16:36:56 -060038b63ff28ea145707d4ee1d9469013ee20b1697bRestructuring and Porting of Compute_mixing_length subroutine(Phase 2) (#1054)editmodel_flags.F90editadvance_clubb_core_module.F90editmixing_length.F90editsaturation.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse244http://carson.math.uwm.edu/jenkins/view/all/job/wrf_clubb_silhs_parallel_ifort/244/242http://carson.math.uwm.edu/jenkins/view/all/job/wrf_clubb_silhs_parallel_ifort/242/