Started by an SCM change743655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master76d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes67c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break601344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break731d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates884471f4d48b6f6f9860366771c513cde551fab5874471f4d48b6f6f9860366771c513cde551fab587refs/remotes/origin/master4471f4d48b6f6f9860366771c513cde551fab5874471f4d48b6f6f9860366771c513cde551fab587refs/remotes/origin/master4471f4d48b6f6f9860366771c513cde551fab5874471f4d48b6f6f9860366771c513cde551fab587refs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_micro_drizzle_intel_test/detail/sam_micro_drizzle_intel_test/88/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_micro_drizzle_intel_test/detail/sam_micro_drizzle_intel_test/88/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_micro_drizzle_intel_test/detail/sam_micro_drizzle_intel_test/88/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_micro_drizzle_intel_test/detail/sam_micro_drizzle_intel_test/88/testsfalseSetup LES_KK_microEdit Make FileEdit Default CaseCompileRun SAMfalse#8814868723073772sam_micro_drizzle_intel_test #8888false887489SUCCESS1627977789520http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/88/calendar.F90clip_explicit.F90clubb_api_module.F90input_reader.F90diagnose_correlations_module.F90grid_class.F90setup_clubb_pdf_params.F90mono_flux_limiter.F90mixing_length.F90advance_wp2_wp3_module.F90file_functions.F90advance_xp2_xpyp_module.F90output_grads.F90stats_rad_zt_module.F90stats_rad_zm_module.F90pdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F90code_timer_module.F90corr_varnce_module.F90precipitation_fraction.F90clip_semi_implicit.F90numerical_check.F90output_netcdf.F90mt95.f90pdf_parameter_module.F90parameters_tunable.F90sponge_layer_damping.F90advance_xp3_module.F90advance_clubb_core_module.F90stats_zt_module.F90fill_holes.F90interpolation.F90stats_clubb_utilities.F90stats_zm_module.F90sfc_varnce_module.F90matrix_operations.F903f4568e6d528cb591d7bbdd4b36faea5c65ab97d1627927021000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduAdding comments labeling subroutine calls with intent. Goes all the way up until stats_clubb_utils. BFB identical. For ticket #942. 2021-08-02 12:57:01 -05003f4568e6d528cb591d7bbdd4b36faea5c65ab97dAdding comments labeling subroutine calls with intent.editpdf_closure_module.F90editmatrix_operations.F90editinterpolation.F90editinput_reader.F90editdiagnose_correlations_module.F90editfile_functions.F90editadg1_adg2_3d_luhar_pdf.F90editstats_rad_zt_module.F90editmixing_length.F90editprecipitation_fraction.F90editsponge_layer_damping.F90editstats_zt_module.F90editadvance_xp3_module.F90editcorr_varnce_module.F90editoutput_grads.F90editstats_rad_zm_module.F90editoutput_netcdf.F90editpdf_parameter_module.F90editclip_semi_implicit.F90editparameters_tunable.F90editadvance_xp2_xpyp_module.F90editadvance_wp2_wp3_module.F90editsetup_clubb_pdf_params.F90editgrid_class.F90editmono_flux_limiter.F90editstats_clubb_utilities.F90editclip_explicit.F90editsfc_varnce_module.F90editcalendar.F90editfill_holes.F90editclubb_api_module.F90editstats_zm_module.F90editnumerical_check.F90editadvance_clubb_core_module.F90editcode_timer_module.F90editmt95.f90githttp://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodeskfalseStarted by an SCM change743655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master76d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes67c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break601344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break731d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates89e240156ca4469279a7ea8ca5f3cbdcd389857ec0e240156ca4469279a7ea8ca5f3cbdcd389857ec0refs/remotes/origin/mastere240156ca4469279a7ea8ca5f3cbdcd389857ec0e240156ca4469279a7ea8ca5f3cbdcd389857ec0refs/remotes/origin/mastere240156ca4469279a7ea8ca5f3cbdcd389857ec0e240156ca4469279a7ea8ca5f3cbdcd389857ec0refs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.gitfalse#8915020643073772sam_micro_drizzle_intel_test #8989false897551SUCCESS1628064188044http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/89/output_grads.F90stats_rad_zm_module.F90stats_rad_zt_module.F90output_netcdf.F90stats_lh_zt_module.F90stats_lh_sfc_module.F90stats_type_utilities.F90stats_clubb_utilities.F908ae8997357c4cf9424fff53c57a41f07d0e589a51628008649000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduAdding intent labels for subroutines throughout clubb. All calls to subroutines now have intent comments next to them all the way up through stats_sfc_module. Results are BFB identical. For ticket #942. 2021-08-03 11:37:29 -05008ae8997357c4cf9424fff53c57a41f07d0e589a5Adding intent labels for subroutines throughout clubb.editoutput_netcdf.F90editstats_type_utilities.F90editstats_rad_zm_module.F90editstats_rad_zt_module.F90editstats_clubb_utilities.F90editstats_lh_zt_module.F90editstats_lh_sfc_module.F90editoutput_grads.F90advance_wp2_wp3_module.F90de5061956ab80fe70758fae3535569ac2577ffca1628009021000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemoving unnecessary constant from use statement 2021-08-03 11:43:41 -0500de5061956ab80fe70758fae3535569ac2577ffcaRemoving unnecessary constant from use statementeditadvance_wp2_wp3_module.F90githttp://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskhttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse90http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/90/88http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/88/Started by an SCM change743655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master76d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes67c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break601344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break731d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates8758ede38d05190fba819e82b551ca5ea3c3f20f6758ede38d05190fba819e82b551ca5ea3c3f20f67refs/remotes/origin/master58ede38d05190fba819e82b551ca5ea3c3f20f6758ede38d05190fba819e82b551ca5ea3c3f20f67refs/remotes/origin/master58ede38d05190fba819e82b551ca5ea3c3f20f6758ede38d05190fba819e82b551ca5ea3c3f20f67refs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.gitfalse#8714557553073772sam_micro_drizzle_intel_test #8787false877421SUCCESS1627718587444http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/87/setup_clubb_pdf_params.F90d7fab3c6bdd5d928a2f6c377fe38514933d91cae1627654958000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduRemoving l_interp_prescribed_params from setup_clubb_pdf_params. The flag has been removed and so has any code underneat a logic statement involving this statement unless it has multiple flags. The else statement in the if block involving this flag has been set to execute without an if block. For ticket #916 Results are BFB identical. Additionally, complex logic statements with the use of more flags had those flags adjusted and BFB results were also confirmed with these changes. 2021-07-30 09:22:38 -0500d7fab3c6bdd5d928a2f6c377fe38514933d91caeRemoving l_interp_prescribed_params from setup_clubb_pdf_params.editsetup_clubb_pdf_params.F90SRC/readiopdata_module.F90b0a3323a6895eccc71928eadc88b978feca4f6521627668927000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comChanges readiopdata_module to use nf90 subroutines 2021-07-30 13:15:27 -0500b0a3323a6895eccc71928eadc88b978feca4f652Changes readiopdata_module to use nf90 subroutineseditSRC/readiopdata_module.F90SRC/readiopdata_module.F901e61599a05eff47349fa4b60c2a32c80e9962c2d1627668927000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comSwitches nf_real to nf90_real 2021-07-30 13:15:27 -05001e61599a05eff47349fa4b60c2a32c80e9962c2dSwitches nf_real to nf90_realeditSRC/readiopdata_module.F90SRC/readiopdata_module.F903e986f6221934c9fc8abdc56a6956b92d37ad80b1627668927000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comReplaces nf_get_var_<type> family with nf90_get_var 2021-07-30 13:15:27 -05003e986f6221934c9fc8abdc56a6956b92d37ad80bReplaces nf_get_var_<type> family with nf90_get_vareditSRC/readiopdata_module.F90SRC/readiopdata_module.F90a6701b00795eb0d4918c5ffb651fb2f7435a8f9b1627668927000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comMoves more calls to nf90 2021-07-30 13:15:27 -0500a6701b00795eb0d4918c5ffb651fb2f7435a8f9bMoves more calls to nf90editSRC/readiopdata_module.F90SRC/readiopdata_module.F903fcededb5c5c8f397460c8cf6596a35dda52e7d81627668927000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comReplace nf_inq_dimlen with nf90_inquire_dimension Fix spelling of nf90_inquire_variable on use statement 2021-07-30 13:15:27 -05003fcededb5c5c8f397460c8cf6596a35dda52e7d8Replace nf_inq_dimlen with nf90_inquire_dimensioneditSRC/readiopdata_module.F90SRC/readiopdata_module.F904b7c9ec9c54f82e361df216342dbbca2494423e41627668927000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comReplace nf_inq_dimname with nf90_inquire_dimension 2021-07-30 13:15:27 -05004b7c9ec9c54f82e361df216342dbbca2494423e4Replace nf_inq_dimname with nf90_inquire_dimensioneditSRC/readiopdata_module.F90SRC/readiopdata_module.F9099ca2975805eacf3e51b8756f54d0616813f65e11627668927000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comReplace nf_get_vara_ subroutines with nf90_get_var 2021-07-30 13:15:27 -050099ca2975805eacf3e51b8756f54d0616813f65e1Replace nf_get_vara_ subroutines with nf90_get_vareditSRC/readiopdata_module.F90SRC/readiopdata_module.F904a7f10003ebc49b3753b7bb6c55128c8e9a7685c1627668927000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comRemove `include netcdf.inc` statements 2021-07-30 13:15:27 -05004a7f10003ebc49b3753b7bb6c55128c8e9a7685cRemove `include netcdf.inc` statementseditSRC/readiopdata_module.F90SRC/readiopdata_module.F905ed0296e812cb28482b83b57fea5e964efb3be811627668927000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comRemove redundant code 2021-07-30 13:15:27 -05005ed0296e812cb28482b83b57fea5e964efb3be81Remove redundant codeeditSRC/readiopdata_module.F90SRC/readiopdata_module.F9029270c40128777b5da1e1b65e559a7e8226ab2a71627668927000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comUse nf90_inquire_dimension to manually set count value for nf90_get_var Issue larson-group/clubb#900 2021-07-30 13:15:27 -050029270c40128777b5da1e1b65e559a7e8226ab2a7Use nf90_inquire_dimension to manually set count value for nf90_get_vareditSRC/readiopdata_module.F90SRC/setdata_module.F90d3bc298c277c694aebca7fc539a0aa4b69723f811627668927000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comAdd workaround for k=1 2021-07-30 13:15:27 -0500d3bc298c277c694aebca7fc539a0aa4b69723f81Add workaround for k=1editSRC/setdata_module.F90SRC/readiopdata_module.F90ed8cda01501dfa3c517d8ed700a0db2c42f6b77c1627668927000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comSwitch to using nf90_inquire_variable to find information to allocate var 2021-07-30 13:15:27 -0500ed8cda01501dfa3c517d8ed700a0db2c42f6b77cSwitch to using nf90_inquire_variable to find information to allocate vareditSRC/readiopdata_module.F90SRC/readiopdata_module.F9099de4b8f4b89aca5952b36eb3488b47dec2dfacc1627668927000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comFix manual specification of values 2021-07-30 13:15:27 -050099de4b8f4b89aca5952b36eb3488b47dec2dfaccFix manual specification of valueseditSRC/readiopdata_module.F90SRC/readiopdata_module.F90e48261fe5f500c50ac6b0bbcdcd332a2b8e6df521627668927000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comFix issues with deallocation of variables Remove the allocatable attribute from var in get_netcdf_var1d_real Add deallocate statement for local allocatables in get_netcdf_var1d_real 2021-07-30 13:15:27 -0500e48261fe5f500c50ac6b0bbcdcd332a2b8e6df52Fix issues with deallocation of variableseditSRC/readiopdata_module.F90SRC/readiopdata_module.F90597e5797421e05a5676db7c396d2d1ee152a9a461627668927000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comRewrite some of get_netcdf_var2d_real - nf90_get_var is now only called once - Due to problems with the order of the values, a new section has been added to the subroutine 2021-07-30 13:15:27 -0500597e5797421e05a5676db7c396d2d1ee152a9a46Rewrite some of get_netcdf_var2d_realeditSRC/readiopdata_module.F90SRC/readiopdata_module.F90e2ff191f1102d4b66968ca1d82acfcd8cd8b18471627668927000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comAdd deallocate statement to get_netcdf_var2d_real after change 2021-07-30 13:15:27 -0500e2ff191f1102d4b66968ca1d82acfcd8cd8b1847Add deallocate statement to get_netcdf_var2d_real after changeeditSRC/readiopdata_module.F90SRC/readiopdata_module.F90f94721b0426a13d77a9cd9294daea37ddf6c438e1627668927000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comRemove unused variable 'length' in get_netcdf_var*d_real Add additional comments 2021-07-30 13:15:27 -0500f94721b0426a13d77a9cd9294daea37ddf6c438eRemove unused variable 'length' in get_netcdf_var*d_realeditSRC/readiopdata_module.F90SRC/readiopdata_module.F904fda5fba341495ad39c675433d2ba9ae5ff1c7881627668927000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comAdd statement to ensure dplevs initializes with zeroed values 2021-07-30 13:15:27 -05004fda5fba341495ad39c675433d2ba9ae5ff1c788Add statement to ensure dplevs initializes with zeroed valueseditSRC/readiopdata_module.F90SRC/setdata_module.F90ab9e44dfc3cebbdb868496ff268ea73adde8d4e41627668927000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comRevert "Add workaround for k=1" This reverts commit 79a8797cbba6545390c196dd3a14337b351da1b8. The workaround that was added is no longer necessary. 2021-07-30 13:15:27 -0500ab9e44dfc3cebbdb868496ff268ea73adde8d4e4Revert "Add workaround for k=1"editSRC/setdata_module.F90SRC/readiopdata_module.F90c39e5b35785af03a0475eff299f0a844685a73631627668927000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comUpdate comments and variable names as requested 2021-07-30 13:15:27 -0500c39e5b35785af03a0475eff299f0a844685a7363Update comments and variable names as requestededitSRC/readiopdata_module.F90SRC/readiopdata_module.F90ee6f68d83415545117b599a0915fbd4bc767c3b81627668927000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comFix comments 2021-07-30 13:15:27 -0500ee6f68d83415545117b599a0915fbd4bc767c3b8Fix commentseditSRC/readiopdata_module.F90SRC/readiopdata_module.F90b81c696a2516a83e063453b1dccaa212a728d30c1627668927000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comSet intent of var back to inout, as in the case of dplevs, it may not assign all values 2021-07-30 13:15:27 -0500b81c696a2516a83e063453b1dccaa212a728d30cSet intent of var back to inout, as in the case of dplevs, it may not assign all valueseditSRC/readiopdata_module.F90SRC/readiopdata_module.F90029a7cf619b1815df8c4c05df8e5b0be230ea51a1627668927000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comRemove some of the old variables from get_netcdf_var2d_real 2021-07-30 13:15:27 -0500029a7cf619b1815df8c4c05df8e5b0be230ea51aRemove some of the old variables from get_netcdf_var2d_realeditSRC/readiopdata_module.F90githttp://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldchttp://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskfalse88http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/88/86http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/86/