Started by an SCM change743655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master76d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes67c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break601344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break731d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates3277758b1ec6b31e78f4e9105f318d096379aa54cfb7758b1ec6b31e78f4e9105f318d096379aa54cfbrefs/remotes/origin/master7758b1ec6b31e78f4e9105f318d096379aa54cfb7758b1ec6b31e78f4e9105f318d096379aa54cfbrefs/remotes/origin/master7758b1ec6b31e78f4e9105f318d096379aa54cfb7758b1ec6b31e78f4e9105f318d096379aa54cfbrefs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_micro_drizzle_intel_test/detail/sam_micro_drizzle_intel_test/327/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_micro_drizzle_intel_test/detail/sam_micro_drizzle_intel_test/327/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_micro_drizzle_intel_test/detail/sam_micro_drizzle_intel_test/327/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_micro_drizzle_intel_test/detail/sam_micro_drizzle_intel_test/327/testsfalseSetup LES_KK_microEdit Make FileEdit Default CaseCompileRun SAMfalse#32715061243073772sam_micro_drizzle_intel_test #327327false3271227SUCCESS1714550647410http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/327/advance_xm_wpxp_module.F9013811b3b0775ce0412d5ca84a1c0e8787e3823f61714471119000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduMoved the ghost-point setting of xm(1) = xm(2) to the last line of the subroutine so this command doesn't get overwritten. This is technically BIT_CHANGING because it alters rtm (and some rtm-related calculations) at the ghost point, but it is not answer changing. This is being done in preparation for ghost point removal. 2024-04-30 04:58:39 -050013811b3b0775ce0412d5ca84a1c0e8787e3823f6Moved the ghost-point setting of xm(1) = xm(2) to the last lineeditadvance_xm_wpxp_module.F90advance_wp2_wp3_module.F90mixing_length.F90advance_xp2_xpyp_module.F90advance_xp3_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90grid_class.F90setup_clubb_pdf_params.F90calc_pressure.F90advance_windm_edsclrm_module.F90advance_helper_module.F906db5d3c85dd296d8ccafe66f5e7e20b241d371881714534975000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comOptional arguments are just best sometimes (#1150) * Adding optional argument to zm2zt/zt2zm to act as threshold. This cuts down on lots of bulk and reduces the chances of breaking the GPU code. All BFB. * Removing TODO * Replacing hardcoded 0.0_core_rknd with zero_threshold 2024-04-30 22:42:55 -05006db5d3c85dd296d8ccafe66f5e7e20b241d37188Optional arguments are just best sometimes (#1150)editadvance_helper_module.F90editsetup_clubb_pdf_params.F90editadvance_xp3_module.F90editadvance_xp2_xpyp_module.F90editcalc_pressure.F90editadvance_windm_edsclrm_module.F90editadvance_wp2_wp3_module.F90editadvance_xm_wpxp_module.F90editadvance_clubb_core_module.F90editgrid_class.F90editmixing_length.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreplyfalseStarted by an SCM change743655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master76d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes67c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break601344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break731d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates3283319ad8bfd74d7829cdf03a0ac7813c22d4094c53319ad8bfd74d7829cdf03a0ac7813c22d4094c5refs/remotes/origin/master3319ad8bfd74d7829cdf03a0ac7813c22d4094c53319ad8bfd74d7829cdf03a0ac7813c22d4094c5refs/remotes/origin/master3319ad8bfd74d7829cdf03a0ac7813c22d4094c53319ad8bfd74d7829cdf03a0ac7813c22d4094c5refs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.gitfalse#32815059703073772sam_micro_drizzle_intel_test #328328false3281295SUCCESS1714637046174http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/328/advance_clubb_core_module.F90d6ca5b0e6179de58c7571bea8650e3cd93c3de5e1714537919000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bug. RESOLVED:556370c6406e6b943b88affbe7728a5036b1ba22, this was catchable by using debugging flags, but seems to otherwise cause no issues. Investigating I found that it only clips the below ground level, so that must not have been affecting other levels. This is technically BIT_CHANGING since it resolves an issue. 2024-04-30 23:31:59 -0500d6ca5b0e6179de58c7571bea8650e3cd93c3de5eFixing bug. RESOLVED:556370c6406e6b943b88affbe7728a5036b1ba22, this was catchable by using debugging flags, but seems to otherwise cause no issues. Investigating I found that it only clips the below ground level, so that must not have been affecting other levels. This is technically BIT_CHANGING since it resolves an issue.editadvance_clubb_core_module.F90advance_wp2_wp3_module.F90fill_holes.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90clubb_api_module.F90advance_xm_wpxp_module.F90c2849fa3c750562ffdd5abd6bc9937c081e662261714587276000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking num_draw_points in fill_holes a constant. We were already using this value as a constant everywhere, but passing a constant by argument list makes it difficult/impossible for a compiler to optimize using that constant, unless it does inlining. Now, rather than passing the constant num_hf_draw_points (or sometimes a hardcoded 2) we just use num_hf_draw_points directly from constants_clubb. This massively improves the performance of a loop in fill holes when using nvhpc+omp, which was the motivation for this, but should also improve the performance on CPUs. Everything is BFB. 2024-05-01 13:14:36 -0500c2849fa3c750562ffdd5abd6bc9937c081e66226Making num_draw_points in fill_holes a constant. We were already using this value as a constant everywhere, but passing a constant by argument list makes it difficult/impossible for a compiler to optimize using that constant, unless it does inlining. Now, rather than passing the constant num_hf_draw_points (or sometimes a hardcoded 2) we just use num_hf_draw_points directly from constants_clubb. This massively improves the performance of a loop in fill holes when using nvhpc+omp, which was the motivation for this, but should also improve the performance on CPUs. Everything is BFB.editadvance_wp2_wp3_module.F90editfill_holes.F90editclubb_api_module.F90editadvance_clubb_core_module.F90editadvance_xp2_xpyp_module.F90editadvance_xm_wpxp_module.F90SRC/MICRO_M2005_UWM/microphysics.F90SRC/micro_field_utils.F90SRC/SGS_CLUBB/clubb_sgs.F90ecc32fd475a7a380a33f9361537db3f4741a19621714587855000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking compatible with latest clubb changes. 2024-05-01 13:24:15 -0500ecc32fd475a7a380a33f9361537db3f4741a1962Making compatible with latest clubb changes.editSRC/MICRO_M2005_UWM/microphysics.F90editSRC/SGS_CLUBB/clubb_sgs.F90editSRC/micro_field_utils.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse329http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/329/327http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/327/Started by an SCM change743655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master76d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes67c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break601344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break731d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates326fc58a2cc73b31589b297fc0b4b495abba3690a0dfc58a2cc73b31589b297fc0b4b495abba3690a0drefs/remotes/origin/masterfc58a2cc73b31589b297fc0b4b495abba3690a0dfc58a2cc73b31589b297fc0b4b495abba3690a0drefs/remotes/origin/masterfc58a2cc73b31589b297fc0b4b495abba3690a0dfc58a2cc73b31589b297fc0b4b495abba3690a0drefs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.gitfalse#32614614813073772sam_micro_drizzle_intel_test #326326false3261110SUCCESS1714205048246http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/326/grid_class.F90f3b2d7a6a63ceea30a960b27be61c18ea0279b711713916476000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI'm changing the way ddzt handles the derivative over momentum level 1. Previously, it was based on the differential between the ghost point and the first level above the surface. Now, the value of the derivative at momentum level 2 is simply being dropped down to momentum level 1. This is being done in advance of ghost point removal. The results of this commit are BIT_CHANGING. 2024-04-23 18:54:36 -0500f3b2d7a6a63ceea30a960b27be61c18ea0279b71I'm changing the way ddzt handles the derivative over momentum level 1.editgrid_class.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false327http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/327/325http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/325/