Started by an SCM change743655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master76d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes67c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break601344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break731d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates24488deb6a5a506f03a2c2987f157a24877df0f21af88deb6a5a506f03a2c2987f157a24877df0f21afrefs/remotes/origin/master88deb6a5a506f03a2c2987f157a24877df0f21af88deb6a5a506f03a2c2987f157a24877df0f21afrefs/remotes/origin/master88deb6a5a506f03a2c2987f157a24877df0f21af88deb6a5a506f03a2c2987f157a24877df0f21afrefs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_micro_drizzle_intel_test/detail/sam_micro_drizzle_intel_test/244/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_micro_drizzle_intel_test/detail/sam_micro_drizzle_intel_test/244/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_micro_drizzle_intel_test/detail/sam_micro_drizzle_intel_test/244/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_micro_drizzle_intel_test/detail/sam_micro_drizzle_intel_test/244/testsfalseSetup LES_KK_microEdit Make FileEdit Default CaseCompileRun SAMfalse#24419000533073772sam_micro_drizzle_intel_test #244244false24421287SUCCESS1678352587343http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/244/mixing_length.F90pdf_utilities.F90saturation.F90advance_clubb_core_module.F90mean_adv.F90pdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F90grid_class.F90turbulent_adv_pdf.F9061ea0db56546ea2946cb3c0ee368fd57752c14511678297579000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comGpu updates (#1070) * Fixing bug. This was only triggered when l_input_fields=.true., which I am only testing because it needs to be true so that I can test ADG2_driver. * Removing usage of gr from pdf_closure. It was only ever used for nz, which is now fed in directly. * Making openacc statements more consistent. Ensuring all statments on double loops have specified gang and vector, and that all parallel loops have an end parallel loop statment at the end of them. Everything BFB on CPUs and GPUs. * Pushing acc data region to outermost parts of mixing_length. * Removing pdf_implicit_coefs_terms from acc copyin and copyout. It is only used when iiPDF_type == iiPDF_new .or. iiPDF_type == iiPDF_new_hybrid, so we do not need to do any copying with it. The inclusion of it also caused the data statement to copy unallocated arrays, which are just garbage pointers, and that was causing random occasional crashes (either segfaults or gpu out of memory). * The update device clauses for return variables seems to only be requried for arrays contained in types. See https://github.com/larson-group/clubb/issues/1049\#issuecomment-1440624778 * Moving acc end data to end of pdf_closure. This reuqired removing any conditional return statements that appear before the final return, since we're not allowed to branch out of an acc region early. I also moved a large printout statement outside of a loop. The only reason it was in the loop to begin with was because pdf_params used to be an array of types, but now is a type of arrays, allowing us to print the full arrays directly. * Making loop an acc loop. If we weren't outputting w_[up/down]_in_cloud (iw_up_in_cloud <= 0 .or. iw_down_in_cloud <= 0, then these arrays were only being zerod out on the CPU and would've getting overwritten by the uninitialized GPU data at the end of the data statement. This change causes the arrays to get correctly zerod out on the GPU when we need. * Update VariableGroupNondimMoments.py Fixed a typo * Merging new changes from master * Removing need for -gpu=deepcopy, pushing some acc data statements up call tree, and replacing some acc data statements with acc delare statements so that return statements can be added back in. * Adding back an acc loop that was accidentally removed during a merge. --------- Co-authored-by: Brian Griffin <31553422+bmg929@users.noreply.github.com> 2023-03-08 11:46:19 -060061ea0db56546ea2946cb3c0ee368fd57752c1451Gpu updates (#1070)editadvance_clubb_core_module.F90editmixing_length.F90editmean_adv.F90editsaturation.F90editadg1_adg2_3d_luhar_pdf.F90editpdf_closure_module.F90editpdf_utilities.F90editgrid_class.F90editturbulent_adv_pdf.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreplyfalseStarted by an SCM change743655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master76d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes67c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break601344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break731d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates245a3d61f7dc93479c7e0c089e6fcb28f69d1048cb8a3d61f7dc93479c7e0c089e6fcb28f69d1048cb8refs/remotes/origin/mastera3d61f7dc93479c7e0c089e6fcb28f69d1048cb8a3d61f7dc93479c7e0c089e6fcb28f69d1048cb8refs/remotes/origin/mastera3d61f7dc93479c7e0c089e6fcb28f69d1048cb8a3d61f7dc93479c7e0c089e6fcb28f69d1048cb8refs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.gitfalse#24519288413073772sam_micro_drizzle_intel_test #245245false24521359SUCCESS1678438986142http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/245/mono_flux_limiter.F90fdf454198c75d605df4d989599620e23c42135fe1678350700000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comImplements Thomas Toniazzo's bug fix for spike removal in the monotonic flux limiter. See https://github.com/larson-group/clubb_release/pull/11/files This code change is expected to be BIT_CHANGING for cases in which `l_predict_upwp_vpwp = T`, `l_mono_flux_lim_um = T` or `l_mono_flux_lim_vm = T`, and the monotonic flux limiter is triggered. This bug fix prevents non-conservation of momentum when the vertical integral of either of the wind components `um` or `vm` is negative. 2023-03-09 02:31:40 -0600fdf454198c75d605df4d989599620e23c42135feImplements Thomas Toniazzo's bug fix for spike removaleditmono_flux_limiter.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse246http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/246/244http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/244/Started by an SCM change743655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master76d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes67c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break601344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break731d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates2436a8891acf07645e32851b21008f1cf4f9c7ef68a6a8891acf07645e32851b21008f1cf4f9c7ef68arefs/remotes/origin/master6a8891acf07645e32851b21008f1cf4f9c7ef68a6a8891acf07645e32851b21008f1cf4f9c7ef68arefs/remotes/origin/master6a8891acf07645e32851b21008f1cf4f9c7ef68a6a8891acf07645e32851b21008f1cf4f9c7ef68arefs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.gitfalse#24319429273073772sam_micro_drizzle_intel_test #243243false24321121SUCCESS1677661389891http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/243/pdf_closure_module.F9090851771d55ebaeb104a3bd7edae92ffd4a248a61677613563000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb ticket #1025: Implemented way to make esa tuner reproducible, h… (#1068) * Clubb ticket #1025: Implemented way to make esa tuner reproducible, hid error output of optional diagnostic variables behind check, fixed parallelization issue with tuner, esa max_iters parameter is now in stats namelist, fixed issue with TUNER compiler directive, some small fixes. - New namelist variables prescribed_rand_seed and l_use_prescribed_rand_seed determine if the esa tuner will use a random or a fixed value as random seed. Added descriptions to README. - Added max_iters to stats namelist to make it more modifiable. - Renamed stp_adjst_intercept_in and stp_adjst_slope_in to stp_adjst_shift_in and stp_adjst_factor_in, respectively, to better reflect their influence on step size. - The error output in src/CLUBB_core/pdf_closure_module.F90 for the diagnostic variables wprtp2, wpthlp2, wprtpthlp, and rcp2 is now hidden behind existence checks for these variables. And a clarification was added to "#ifdef TUNER" directive. - NetCDF file access caused the tuner to crash in parallel mode (-fopenmp flag in config file and multiple cases). Adding an $OMP CRITICAL structure around the call to stats_init in clubb_driver.F90 fixed that. - Fixed compile/README. Config files are specified with the -c option. - The -t option in run_scripts/run_tuner.bash interfered with the previous usage of the TUNER compiler directive. Renamed the old TUNER directive to NR_SP, a short for "numerical recipes, single precision". TUNER now is the option to "turn on" code changes required to run the tuner. 2023-02-28 13:46:03 -060090851771d55ebaeb104a3bd7edae92ffd4a248a6Clubb ticket #1025: Implemented way to make esa tuner reproducible, h… (#1068)editpdf_closure_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse244http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/244/242http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/242/