Started by an SCM change743655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master76d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes67c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break601344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break731d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates2326ddae87b6a0ad6dc45df6f72439dc7dab41f5b396ddae87b6a0ad6dc45df6f72439dc7dab41f5b39refs/remotes/origin/master6ddae87b6a0ad6dc45df6f72439dc7dab41f5b396ddae87b6a0ad6dc45df6f72439dc7dab41f5b39refs/remotes/origin/master6ddae87b6a0ad6dc45df6f72439dc7dab41f5b396ddae87b6a0ad6dc45df6f72439dc7dab41f5b39refs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_micro_drizzle_intel_test/detail/sam_micro_drizzle_intel_test/232/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_micro_drizzle_intel_test/detail/sam_micro_drizzle_intel_test/232/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_micro_drizzle_intel_test/detail/sam_micro_drizzle_intel_test/232/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_micro_drizzle_intel_test/detail/sam_micro_drizzle_intel_test/232/testsfalseSetup LES_KK_microEdit Make FileEdit Default CaseCompileRun SAMfalse#23218979313073772sam_micro_drizzle_intel_test #232232false23219903SUCCESS1673600590753http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/232/mixing_length.F90saturation.F90model_flags.F90constants_clubb.F9021426fea400c37cfd10dbde5beb0f96690a2f8381673549655000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRestructuring and Porting of Compute_mixing_length subroutine(Phase 1) (#1052) * Restructuring and Porting of Compute_mixing_length subroutine(Phase 1) Restructure: The compute_mixing_length is one of the top most routine taking 35-50% of the total time in a single timestep. The subroutine has been restructured to push the i-loop further down to extract vectorization and parallelization. The restructuring also involves introduction of sat_mixrat_liq_acc routines to extract parallelism when called inside a OpenACC parallel region. Porting: OpenACC directives are inserted to port the restructured compute_mixing_length code on to the GPUs. This port is currently unoptimized and there is still room for improvement. NOTE: Currently, l_sat_mixrat_lookup = false and saturation_formula = saturation_flatau (Earthworks config options) case is supported on OpenACC build. Any other options works on CPUs as usual. OpenACC declare create directives are inserted in model_flags and constants_clubb, as these module variables are used inside the saturation routines. * Added debug message about only supporting l_sat_mixrat_lookup = false and saturation_formula = saturation_flatau on GPUs Answers are Bit for Bit with arm-multicolumn case + nvhpc compiler. * Changing CLUBB debug level 1 to 0 for the saturation formula support running on GPUs * Changing indentation to make gfortran happy, it wants ifdefs to start at the beginning of the line. * Adding use statements for error checks and printouts, also making the errors set err_code to clubb_fatal_error. Co-authored-by: huebler <huebler@uwm.edu> 2023-01-12 12:54:15 -060021426fea400c37cfd10dbde5beb0f96690a2f838Restructuring and Porting of Compute_mixing_length subroutine(Phase 1) (#1052)editmodel_flags.F90editsaturation.F90editmixing_length.F90editconstants_clubb.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreplyfalseStarted by an SCM change743655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master76d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes67c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break601344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break731d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates2337eb38185c31f4150043fa9350e8af24540a679697eb38185c31f4150043fa9350e8af24540a67969refs/remotes/origin/master7eb38185c31f4150043fa9350e8af24540a679697eb38185c31f4150043fa9350e8af24540a67969refs/remotes/origin/master7eb38185c31f4150043fa9350e8af24540a679697eb38185c31f4150043fa9350e8af24540a67969refs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.gitfalse#23319316653073772sam_micro_drizzle_intel_test #233233false23319995SUCCESS1674118988354http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/233/mixing_length.F90saturation.F90advance_clubb_core_module.F90model_flags.F9038b63ff28ea145707d4ee1d9469013ee20b1697b1674081416000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRestructuring and Porting of Compute_mixing_length subroutine(Phase 2) (#1054) * Restructuring and Porting of Compute_mixing_length subroutine(Phase 2) Restructure: sat_mixrat_liq_2D_acc is being directly called instead of calling the 1D version inside the column loop. Changing sat_mixrat_liq_2D_acc to a subroutine from a function and adding output array, start_index as additional argument. This is a workaround for passing sub-arrays. The OpenACC doen't like the sub-arrays being passed and fails the validation. Porting: OpenACC directives are added inside sat_mixrat_liq_2D_acc for porting Validation: Answers are Bit for Bit with arm-multicolumn case + nvhpc compiler * Fix for compilation issues Issue 1: Missed out declaring 'start_index' while intergrating the change Issue 2: The use of error_code module and the procedures inside it causes OpenACC compilation issues when run on the device. * Removing the sat_mixrat_liq_acc and sat_mixrat_liq_2D_acc, making the normal sat_mixrat_liq work for all current use cases, and making the other versions of sat_mixrat_liq (bolton,gfdl,lookup) functional with OPENACC. Co-authored-by: huebler <huebler@uwm.edu> 2023-01-18 16:36:56 -060038b63ff28ea145707d4ee1d9469013ee20b1697bRestructuring and Porting of Compute_mixing_length subroutine(Phase 2) (#1054)editmodel_flags.F90editmixing_length.F90editadvance_clubb_core_module.F90editsaturation.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse234http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/234/232http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/232/Started by an SCM change743655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master76d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes67c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break601344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break731d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates231f4c25cf5e6d4901e40d66881d04ae51ee124c616f4c25cf5e6d4901e40d66881d04ae51ee124c616refs/remotes/origin/masterf4c25cf5e6d4901e40d66881d04ae51ee124c616f4c25cf5e6d4901e40d66881d04ae51ee124c616refs/remotes/origin/masterf4c25cf5e6d4901e40d66881d04ae51ee124c616f4c25cf5e6d4901e40d66881d04ae51ee124c616refs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.gitfalse#23119157513073772sam_micro_drizzle_intel_test #231231false23119831SUCCESS1673514189080http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/231/matrix_solver_wrapper.F90lapack_wrap.F9038f9da3d580e38623856fb89bf73e274c5207f791673472578000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comPushing column loop into lapack wrap. 2023-01-11 15:29:38 -060038f9da3d580e38623856fb89bf73e274c5207f79Pushing column loop into lapack wrap.editlapack_wrap.F90editmatrix_solver_wrapper.F90githttp://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwmfalse232http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/232/230http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/230/