Started by an SCM change743655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master76d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes67c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break601344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break731d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates193d0a07b0a900be518afcce72911f061fb84d31f81d0a07b0a900be518afcce72911f061fb84d31f81refs/remotes/origin/masterd0a07b0a900be518afcce72911f061fb84d31f81d0a07b0a900be518afcce72911f061fb84d31f81refs/remotes/origin/masterd0a07b0a900be518afcce72911f061fb84d31f81d0a07b0a900be518afcce72911f061fb84d31f81refs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_micro_drizzle_intel_test/detail/sam_micro_drizzle_intel_test/193/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_micro_drizzle_intel_test/detail/sam_micro_drizzle_intel_test/193/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_micro_drizzle_intel_test/detail/sam_micro_drizzle_intel_test/193/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_micro_drizzle_intel_test/detail/sam_micro_drizzle_intel_test/193/testsfalseSetup LES_KK_microEdit Make FileEdit Default CaseCompileRun SAMfalse#19320033173073772sam_micro_drizzle_intel_test #193193false19315638SUCCESS1654070587046http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/193/advance_xm_wpxp_module.F90clip_explicit.F90clubb_api_module.F90stats_type_utilities.F90grid_class.F90setup_clubb_pdf_params.F90new_pdf_main.F90advance_windm_edsclrm_module.F90advance_helper_module.F90mono_flux_limiter.F90new_tsdadg_pdf.F90mixing_length.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90LY93_pdf.F90pdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F90new_hybrid_pdf_main.F90numerical_check.F90pos_definite_module.F90new_pdf.F90sponge_layer_damping.F90turbulent_adv_pdf.F90advance_xp3_module.F90advance_clubb_core_module.F90fill_holes.F90stats_clubb_utilities.F90db5164bb7ed0c78ce4f06f92e7bf6118d10addf31654031468000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAlmost final loop pushes (#1012) * Pushing loop into clip_rcm * Pushing column loop into trapezoid routines. * Pushing column loop into clip_covar routines. * Pushing column loop into clip_variance and clip_skewness. * Replacing sgn_turbulent_velocity with built in fortran sign * Removing gr from argument list of stats calls, replacing with just nz * Replacing some usages of gr with just the number of vertical levels * Replacing some usages of gr with just the number of vertical levels again * Missed a couple files to commit * Pushing some loops and removing need for gr to be passed into some routines. * Pushing loop into advance_xp3 * Pushing loop into mixing length * Some more loop pushing * Pushing some loops into mono_flux limit, skipping the lhs routine since it's a bit tricky at the moment, will do after change to grid class. * Removing gr from argument list of stats accumulate * Precalculating zt2zm so that we can use 2d version * Precalculating um/vm ddzt so that we can use 2d version * Precalculating things to use 2d version of zt2zm * Making 2d version of cubic interp for grid class * Small modifications to sponge damping code argument lists * Renaming some variables 2022-05-31 16:11:08 -0500db5164bb7ed0c78ce4f06f92e7bf6118d10addf3Almost final loop pushes (#1012)editadvance_xm_wpxp_module.F90editclip_explicit.F90editnew_pdf_main.F90editadvance_xp3_module.F90editturbulent_adv_pdf.F90editclubb_api_module.F90editgrid_class.F90editadvance_helper_module.F90editmono_flux_limiter.F90editpos_definite_module.F90editadvance_windm_edsclrm_module.F90editnew_tsdadg_pdf.F90editLY93_pdf.F90editstats_type_utilities.F90editadg1_adg2_3d_luhar_pdf.F90editnew_pdf.F90editmixing_length.F90editnumerical_check.F90editadvance_clubb_core_module.F90editsponge_layer_damping.F90editsetup_clubb_pdf_params.F90editstats_clubb_utilities.F90editadvance_wp2_wp3_module.F90editfill_holes.F90editnew_hybrid_pdf_main.F90editadvance_xp2_xpyp_module.F90editpdf_closure_module.F90SRC/MICRO_M2005_UWM/microphysics.F90SRC/micro_field_utils.F90SRC/SGS_CLUBB/clubb_sgs.F909701c2054c2b0228fdaf8aefb5844479ef68c66b1654040073000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking compatible with latest clubb change. 2022-05-31 18:34:33 -05009701c2054c2b0228fdaf8aefb5844479ef68c66bMaking compatible with latest clubb change.editSRC/MICRO_M2005_UWM/microphysics.F90editSRC/SGS_CLUBB/clubb_sgs.F90editSRC/micro_field_utils.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90clubb_api_module.F90pdf_closure_module.F90pdf_parameter_module.F90new_hybrid_pdf_main.F90new_pdf_main.F90113beb1ec6663fcef3f6bb75c7ee971ab3c0fa451654040788000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comMaking pdf_implicit_coefs_terms a type containing 2D arrays. (#1014) 2022-05-31 18:46:28 -0500113beb1ec6663fcef3f6bb75c7ee971ab3c0fa45Making pdf_implicit_coefs_terms a type containing 2D arrays. (#1014)editnew_hybrid_pdf_main.F90editadvance_xp2_xpyp_module.F90editnew_pdf_main.F90editadvance_xm_wpxp_module.F90editadvance_clubb_core_module.F90editclubb_api_module.F90editpdf_parameter_module.F90editpdf_closure_module.F90editadvance_wp2_wp3_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther HueblerhueblerfalseStarted by an SCM change743655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master76d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes67c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break601344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break731d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates194ae022b7da67da81c8112bb65ad05406ebb3d474cae022b7da67da81c8112bb65ad05406ebb3d474crefs/remotes/origin/masterae022b7da67da81c8112bb65ad05406ebb3d474cae022b7da67da81c8112bb65ad05406ebb3d474crefs/remotes/origin/masterae022b7da67da81c8112bb65ad05406ebb3d474cae022b7da67da81c8112bb65ad05406ebb3d474crefs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.gitfalse#19415976853073772sam_micro_drizzle_intel_test #194194false19415710SUCCESS1654156987457http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/194/new_hybrid_pdf_main.F90new_pdf_main.F907bc6f76ec8b70bc1789f90b554dca47122c400011654112656000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduThe G_unit tests never allocated pdf_implicit_coefs_terms. It's unclear to me how these were working before, but it seems that something about making these 2D allocatable arrays exposed the bug. 2022-06-01 14:44:16 -05007bc6f76ec8b70bc1789f90b554dca47122c40001The G_unit tests never allocated pdf_implicit_coefs_terms. It's unclear to me how these were working before, but it seems that something about making these 2D allocatable arrays exposed the bug.editnew_hybrid_pdf_main.F90editnew_pdf_main.F90advance_xp2_xpyp_module.F90de73c4eefaee2b50045b4f5e706868e84b0f45501654117361000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking zt2zm calls with pdf_implicit_coefs_terms use the 2D version. 2022-06-01 16:02:41 -0500de73c4eefaee2b50045b4f5e706868e84b0f4550Making zt2zm calls with pdf_implicit_coefs_terms use the 2D version.editadvance_xp2_xpyp_module.F90advance_clubb_core_module.F90clubb_api_module.F903643c78f6fe2260f971bba96ead125858b665f1c1654122180000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving setup_grid and setup_parameters functionality from setup_clubb_core. This is beacuse in host models the required grid information may not be known during the setup process, resulting in dummy arguments for setup_clubb_core and the grid and paramters being setup during runtime anyway. Now, in the host models we can call these subroutines immediately after setup_clubb_core to maintain identical functionality (sam, wrf), and in others we can wait to call these until the main timestepping procedure (cam,e3sm). 2022-06-01 17:23:00 -05003643c78f6fe2260f971bba96ead125858b665f1cRemoving setup_grid and setup_parameters functionality from setup_clubb_core. This is beacuse in host models the required grid information may not be known during the setup process, resulting in dummy arguments for setup_clubb_core and the grid and paramters being setup during runtime anyway. Now, in the host models we can call these subroutines immediately after setup_clubb_core to maintain identical functionality (sam, wrf), and in others we can wait to call these until the main timestepping procedure (cam,e3sm).editadvance_clubb_core_module.F90editclubb_api_module.F90SRC/SGS_CLUBB/clubb_sgs.F90b709f9e50c7ce9642fe0a6c0dcd874a14a472c761654122223000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking compatible with latest clubb change. 2022-06-01 17:23:43 -0500b709f9e50c7ce9642fe0a6c0dcd874a14a472c76Making compatible with latest clubb change.editSRC/SGS_CLUBB/clubb_sgs.F90grid_class.F90parameters_tunable.F90clubb_api_module.F90c623b91a9bf812b85b51b575233ad00e8b98f16c1654129942000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking 2D versions of setup_grid and setup_parameters. 2022-06-01 19:32:22 -0500c623b91a9bf812b85b51b575233ad00e8b98f16cMaking 2D versions of setup_grid and setup_parameters.editclubb_api_module.F90editgrid_class.F90editparameters_tunable.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse195http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/195/193http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/193/Started by an SCM change743655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master76d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes67c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break601344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break731d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates192da819132aeee13067059621dd4910c5b976e4e45da819132aeee13067059621dd4910c5b976e4e45refs/remotes/origin/masterda819132aeee13067059621dd4910c5b976e4e45da819132aeee13067059621dd4910c5b976e4e45refs/remotes/origin/masterda819132aeee13067059621dd4910c5b976e4e45da819132aeee13067059621dd4910c5b976e4e45refs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.gitfalse#19215075303073772sam_micro_drizzle_intel_test #192192false19215564SUCCESS1653724990986http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/192/setup_clubb_pdf_params.F90clubb_api_module.F90e3cdb98eb6cc532f8ef187f2d1cc56481a75d1f51653690057000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comConstructing rcm within SILHS (as rcm_pdf) (#1011) * Constructing rcm within SILHS (as rcm_pdf) to avoid having to pass rcm directly to SILHS. Relevant to possibly moving PDF call placement into the "post" position in CAM. See https://github.com/ESCOMP/CAM/issues/582. * Reconstructing rcm inside of setup_pdf_parameters instead of passing it through the argument lists. Might help NCAR move the PDF call placement to "post" position in CAM. See https://github.com/larson-group/clubb/issues/997. * Adding descriptive comment. 2022-05-27 16:20:57 -0600e3cdb98eb6cc532f8ef187f2d1cc56481a75d1f5Constructing rcm within SILHS (as rcm_pdf) (#1011)editclubb_api_module.F90editsetup_clubb_pdf_params.F90silhs_api_module.F90latin_hypercube_driver_module.F90f6c58abafbfc4b18957f9eedff60deeb321bad321653690057000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comConstructing rcm within SILHS (as rcm_pdf) (#1011) * Constructing rcm within SILHS (as rcm_pdf) to avoid having to pass rcm directly to SILHS. Relevant to possibly moving PDF call placement into the "post" position in CAM. See https://github.com/ESCOMP/CAM/issues/582. * Reconstructing rcm inside of setup_pdf_parameters instead of passing it through the argument lists. Might help NCAR move the PDF call placement to "post" position in CAM. See https://github.com/larson-group/clubb/issues/997. * Adding descriptive comment. 2022-05-27 16:20:57 -0600f6c58abafbfc4b18957f9eedff60deeb321bad32Constructing rcm within SILHS (as rcm_pdf) (#1011)editlatin_hypercube_driver_module.F90editsilhs_api_module.F90SRC/SGS_CLUBB/clubb_sgs.F9056d698f9776ce2802dfc991ed50a8dc952f0ec951653690141000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comUpdating for changes to CLUBB. See https://github.com/larson-group/clubb/commit/e4f125ba067ba8083f917e0e06b6b2398483d3e4. 2022-05-27 17:22:21 -050056d698f9776ce2802dfc991ed50a8dc952f0ec95Updating for changes to CLUBB. See https://github.com/larson-group/clubb/commit/e4f125ba067ba8083f917e0e06b6b2398483d3e4.editSRC/SGS_CLUBB/clubb_sgs.F90githttp://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephenshttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse193http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/193/191http://carson.math.uwm.edu/jenkins/view/all/job/sam_micro_drizzle_intel_test/191/