Started by user pbroelspbroelspbroels7720c75ae6657d50abbd04f3f76ffd2f8c04429e1320c75ae6657d50abbd04f3f76ffd2f8c04429e13origin/master20c75ae6657d50abbd04f3f76ffd2f8c04429e1320c75ae6657d50abbd04f3f76ffd2f8c04429e13origin/master75c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break681344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break62e6f0eda7621cb341ccecceda9af8b67e7a4f1407e6f0eda7621cb341ccecceda9af8b67e7a4f1407refs/remotes/origin/mastere6f0eda7621cb341ccecceda9af8b67e7a4f1407e6f0eda7621cb341ccecceda9af8b67e7a4f1407refs/remotes/origin/master20c75ae6657d50abbd04f3f76ffd2f8c04429e1320c75ae6657d50abbd04f3f76ffd2f8c04429e13origin/masterhttps://github.com/larson-group/sam_clubb.gitfalse#7750729572906sam_clubb_silhs_gfortran_build #7777false775909SUCCESS1625071779260http://carson.math.uwm.edu/jenkins/view/all/job/sam_clubb_silhs_gfortran_build/77/clubb_api_module.F90126c61f5ee20ef2a88c9c01a19b94d0b4e54dc131624289253000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFeeding gr through arg list for functions outside of CLUBB_core. Gr has been removed as a moduler variable from clubb_api_module and has been moved to clubb_driver as the top level moduler variable. There is only one instance where a use clubb_driver gr statement is used and that is within clubb_tuner. Results are BFB identical. For ticket #886. 2021-06-21 10:27:33 -0500126c61f5ee20ef2a88c9c01a19b94d0b4e54dc13Feeding gr through arg list for functions outside of CLUBB_core.editclubb_api_module.F90silhs_api_module.F90latin_hypercube_driver_module.F90feebefeb35da1d990f72fe4551982a80d01c86ab1624289253000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFeeding gr through arg list for functions outside of CLUBB_core. Gr has been removed as a moduler variable from clubb_api_module and has been moved to clubb_driver as the top level moduler variable. There is only one instance where a use clubb_driver gr statement is used and that is within clubb_tuner. Results are BFB identical. For ticket #886. 2021-06-21 10:27:33 -0500feebefeb35da1d990f72fe4551982a80d01c86abFeeding gr through arg list for functions outside of CLUBB_core.editsilhs_api_module.F90editlatin_hypercube_driver_module.F90SRC/SILHS/latin_hypercube_driver_module.F90SRC/micro_field_utils.F90SRC/SGS_CLUBB/sgs.F90SRC/CLUBB/clubb_api_module.F90SRC/MICRO_M2005_UWM/microphysics.F90SRC/SILHS/silhs_api_module.F90SRC/SGS_CLUBB/stat_clubb.F90SRC/SGS_CLUBB/clubb_sgs.F90cd913c4e9a5aee64f91e7db20c12bd69f63e1a9a1624304717000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduReflecting changes made to clubb_api_module's subroutine's argument lists. #886. 2021-06-21 14:45:17 -0500cd913c4e9a5aee64f91e7db20c12bd69f63e1a9aReflecting changes made to clubb_api_module's subroutine's argument lists. #886.editSRC/MICRO_M2005_UWM/microphysics.F90editSRC/SILHS/silhs_api_module.F90editSRC/SGS_CLUBB/stat_clubb.F90editSRC/SILHS/latin_hypercube_driver_module.F90editSRC/SGS_CLUBB/sgs.F90editSRC/SGS_CLUBB/clubb_sgs.F90editSRC/CLUBB/clubb_api_module.F90editSRC/micro_field_utils.F90SRC/ADV_UM5/advect_scalar3D.f90.oldSRC/main.F90SRC/surface.ricoSRC/ADV_UM5/advect_um_lib.f90SRC/RAD_RRTM/cldefrint.f90SRC/abcoefs.f90SRC/ADV_MPDATA/advect_scalar.F90SRC/header.F90SRC/RAD_DUMMY/rad.f90SRC/MICRO_DRIZZLE/microphysics.F90SRC/task_exchange.F90SRC/SGS_TKE/sgs.F90SRC/SGS_CLUBB/diffuse_scalar2D_xy.f90SRC/utils.f90SRC/vars.F90SRC/MICRO_SAM1MOM/microphysics.f90.RCEOBSSRC/RAD_RRTM/rrtmg_lw_read_nc.f90SRC/SGS_CLUBB/diffuse_scalar.f90SRC/stat_covar_u2.F90SRC/RAD_CAM/traceini.f90SRC/stat_covar_wv.F90SRC/grid.F90SRC/rad_simple.f90SRC/bound_exchange.f90SRC/ADV_UM5/advect_scalar.F90SRC/ADV_UM5/advect_um_lib.f90.oldSRC/SGS_CLUBB/fluxes_scalar_z.f90SRC/ADV_UM5/advect_scalar2D.f90SRC/MICRO_DRIZZLE/cloud.F90SRC/rad_simple_uwm.F90SRC/MICRO_SAM1MOM/microphysics.F90SRC/stepout.F90SRC/stat_varscalar.f90SRC/RAD_CAM/rad.f90SRC/ADV_MPDATA/advect_scalar3D.f90SRC/SGS_CLUBB/diffuse_scalar3D.f90SRC/movies.f90SRC/stat_covar_wu.F90SRC/SGS_TEMPLATE/sgs.f90SRC/MICRO_2MOM/microphysics.F90SRC/SGS_CLUBB/clubbvars.F90SRC/compute_correlation_module.F90SRC/SGS_CLUBB/diffuse_scalar_xy.f90SRC/tracers.f90SRC/pressure.f90SRC/MICRO_TEMPLATE/.microphysics.f90.template.swpSRC/hbuffer.F90SRC/MICRO_DRIZZLE/micro_params.F90SRC/SGS_CLUBB/diffuse_scalar3D_z.f90SRC/SGS_CLUBB/sgs.F90SRC/SGS_CLUBB/diffuse_scalar2D_z.f90SRC/SIMULATORS/instrument_diagnostics.f90SRC/RAD_RRTM/rrtmg_sw_read_nc.f90MakefileSRC/ADV_MPDATA/advect_scalar2D.f90SRC/task_assign_bnd.f90SRC/MICRO_M2005/module_mp_graupel.f90SRC/SGS_CLUBB/diffuse_scalar_z.f90SRC/compute_chi_module.F90SRC/MICRO_TEMPLATE/microphysics.f90.templateSRC/SGS_CLUBB/diffuse_scalar2D.f90SRC/SGS_TKE/diffuse_scalar.f90SRC/MICRO_M2005_UWM/microphysics.F90SRC/RAD_CAM/ppgrid.f90SRC/SGS_TKE/diffuse_scalar3D.f90SRC/SGS_CLUBB/clubb_sgs.F90SRC/radiation.F90SRC/SGS_CLUBB/diffuse_scalar3D_xy.f90SRC/stat_covar_sw.F90SRC/readiopdata_module.F90SRC/SGS_TKE/diffuse_scalar2D.f90SRC/SGS_CLUBB/clubb_silhs_vars.F90SRC/MICRO_SAM1MOM/micro_params.f90SRC/RAD_CAM/cldefrint.f90SRC/task_ranks.f90SRC/ADV_UM5/advect_scalar2D.f90.oldSRC/stat_covar_w2w3.F90SRC/MICRO_2MOM/micro_params.f90SRC/task_util_MPI.f90SRC/MICRO_M2005/microphysics.f90SRC/stat_covar_v2.F90SRC/task_init.f90SRC/boundaries.f90SRC/setdata.F90SRC/MICRO_SAM1MOM/micro_params.f90.RCEOBSSRC/RAD_RRTM/rad.f90SRC/micro_field_utils.F90SRC/simple_ocean.f90SRC/params.F90SRC/compress3D.F90SRC/RAD_CAM/rad_full.f90SRC/ADV_UM5/advect_scalar3D.f90SRC/SGS_CLUBB/stat_clubb.F90184a06df2d3975fc22f9445e4085495429922e311624462048000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduDefining gr at the top level main as a local variable and feeding it down as needed. Additionally, the file grid had to be changed to grid_config in order to avoid conflicts between the type grid in grid_class and the module named grid. Sam compiles. 2021-06-23 10:27:28 -0500184a06df2d3975fc22f9445e4085495429922e31Defining gr at the top level main as a local variable and feeding it down as needed.editSRC/SGS_CLUBB/diffuse_scalar2D_xy.f90editSRC/MICRO_SAM1MOM/microphysics.f90.RCEOBSeditSRC/stat_covar_sw.F90editSRC/stepout.F90editSRC/vars.F90editSRC/SGS_CLUBB/diffuse_scalar.f90editSRC/SGS_CLUBB/clubb_silhs_vars.F90editSRC/rad_simple_uwm.F90editSRC/simple_ocean.f90editSRC/readiopdata_module.F90editSRC/stat_covar_wu.F90editSRC/stat_covar_w2w3.F90editSRC/MICRO_M2005/microphysics.f90editSRC/SIMULATORS/instrument_diagnostics.f90editSRC/RAD_CAM/rad_full.f90editSRC/task_ranks.f90editSRC/RAD_CAM/rad.f90editSRC/ADV_MPDATA/advect_scalar2D.f90editSRC/abcoefs.f90editSRC/MICRO_DRIZZLE/cloud.F90editSRC/MICRO_TEMPLATE/microphysics.f90.templateeditSRC/SGS_TKE/diffuse_scalar2D.f90editSRC/SGS_TKE/sgs.F90editSRC/compute_chi_module.F90editSRC/radiation.F90editSRC/MICRO_DRIZZLE/microphysics.F90editSRC/SGS_CLUBB/clubbvars.F90editSRC/SGS_CLUBB/diffuse_scalar2D.f90editSRC/stat_varscalar.f90editSRC/header.F90editSRC/ADV_UM5/advect_scalar2D.f90editSRC/SGS_TKE/diffuse_scalar.f90editSRC/stat_covar_u2.F90editSRC/task_init.f90editSRC/micro_field_utils.F90editSRC/MICRO_M2005/module_mp_graupel.f90editSRC/setdata.F90editSRC/ADV_MPDATA/advect_scalar3D.f90deleteSRC/grid.F90editSRC/task_exchange.F90editSRC/ADV_MPDATA/advect_scalar.F90editSRC/ADV_UM5/advect_um_lib.f90editSRC/SGS_CLUBB/diffuse_scalar_z.f90editSRC/ADV_UM5/advect_scalar.F90editSRC/RAD_RRTM/cldefrint.f90editSRC/SGS_CLUBB/diffuse_scalar3D_xy.f90editSRC/SGS_CLUBB/diffuse_scalar_xy.f90editMakefileeditSRC/MICRO_M2005_UWM/microphysics.F90editSRC/ADV_UM5/advect_um_lib.f90.oldeditSRC/SGS_TEMPLATE/sgs.f90editSRC/RAD_RRTM/rrtmg_sw_read_nc.f90editSRC/MICRO_2MOM/micro_params.f90editSRC/SGS_CLUBB/diffuse_scalar3D_z.f90editSRC/MICRO_SAM1MOM/micro_params.f90.RCEOBSeditSRC/SGS_CLUBB/diffuse_scalar3D.f90editSRC/compress3D.F90editSRC/MICRO_SAM1MOM/microphysics.F90editSRC/RAD_CAM/traceini.f90editSRC/task_assign_bnd.f90editSRC/movies.f90editSRC/SGS_TKE/diffuse_scalar3D.f90editSRC/SGS_CLUBB/sgs.F90editSRC/stat_covar_wv.F90editSRC/SGS_CLUBB/fluxes_scalar_z.f90editSRC/params.F90editSRC/MICRO_2MOM/microphysics.F90editSRC/RAD_CAM/ppgrid.f90editSRC/ADV_UM5/advect_scalar3D.f90editSRC/pressure.f90editSRC/bound_exchange.f90editSRC/RAD_RRTM/rrtmg_lw_read_nc.f90editSRC/SGS_CLUBB/diffuse_scalar2D_z.f90editSRC/SGS_CLUBB/stat_clubb.F90editSRC/tracers.f90editSRC/utils.f90editSRC/RAD_RRTM/rad.f90editSRC/MICRO_DRIZZLE/micro_params.F90editSRC/main.F90editSRC/MICRO_SAM1MOM/micro_params.f90editSRC/ADV_UM5/advect_scalar3D.f90.oldeditSRC/MICRO_TEMPLATE/.microphysics.f90.template.swpeditSRC/SGS_CLUBB/clubb_sgs.F90editSRC/RAD_CAM/cldefrint.f90editSRC/boundaries.f90editSRC/task_util_MPI.f90editSRC/stat_covar_v2.F90editSRC/RAD_DUMMY/rad.f90editSRC/compute_correlation_module.F90editSRC/ADV_UM5/advect_scalar2D.f90.oldeditSRC/rad_simple.f90editSRC/surface.ricoeditSRC/hbuffer.F90SRC/grid_config.F9055da14242748277ceac32924fd96a15eb36c17831624462732000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduAdding grid_config file 2021-06-23 10:38:52 -050055da14242748277ceac32924fd96a15eb36c1783Adding grid_config fileaddSRC/grid_config.F90SRC/SGS_CLUBB/clubb_sgs.F90a9460b01e20f9efc56acb4e59479d6e6c0bb26971624466950000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFixing certain instances of gr missing from clubb_sgs.F90. 2021-06-23 11:49:10 -0500a9460b01e20f9efc56acb4e59479d6e6c0bb2697Fixing certain instances of gr missing from clubb_sgs.F90.editSRC/SGS_CLUBB/clubb_sgs.F90SRC/micro_field_utils.F90SRC/main.F902f36fb2662c574940365d42d1b86acffec74871e1624468024000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduAdding references to gr as needed 2021-06-23 12:07:04 -05002f36fb2662c574940365d42d1b86acffec74871eAdding references to gr as needededitSRC/main.F90editSRC/micro_field_utils.F90SRC/main.F903697ff299604031d4d41f63be800361f2ca082ef1624468284000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduAdding references to gr where needed 2021-06-23 12:11:24 -05003697ff299604031d4d41f63be800361f2ca082efAdding references to gr where needededitSRC/main.F90SRC/stepout_module.F90SRC/domain.F90SRC/main.F90SRC/setdata_module.F90SRC/stepout.F90SRC/setdata.F901344f8a40d6116af1b567307eb389b4be1009fc41624553513000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduAdding in preprocessor directives so that way sam compiles without clubb. Jenkins tests pass. Additionally, I renamed setdata and stepout so that way we can use them as modules because they previously only contained subroutines. 2021-06-24 11:51:53 -05001344f8a40d6116af1b567307eb389b4be1009fc4Adding in preprocessor directives so that way sam compiles without clubb.editSRC/domain.F90addSRC/setdata_module.F90editSRC/main.F90deleteSRC/stepout.F90addSRC/stepout_module.F90deleteSRC/setdata.F90Makefilefcb64a792d6631be39938f67e613ded134dd5dca1624639893000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFixed make file being broke 2021-06-25 11:51:33 -0500fcb64a792d6631be39938f67e613ded134dd5dcaFixed make file being brokeeditMakefileSRC/SILHS/latin_hypercube_driver_module.F90SRC/CLUBB/clubb_api_module.F90SRC/SILHS/silhs_api_module.F90c5c01fc5da140dc13df06c2919c4f4f5a0318b5f1624980250000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduReverted changes to clubb files 2021-06-29 10:24:10 -0500c5c01fc5da140dc13df06c2919c4f4f5a0318b5fReverted changes to clubb fileseditSRC/SILHS/silhs_api_module.F90editSRC/SILHS/latin_hypercube_driver_module.F90editSRC/CLUBB/clubb_api_module.F90jenkins_tests/micro_drizzle_test/Jenkinsfilejenkins_tests/sam_clubb_silhs_build/Jenkinsfilejenkins_tests/sam_clubb_build/Jenkinsfile74f8b9acaaaecdc05763bb35929a066cc551a0441624998670000http://carson.math.uwm.edu/jenkins/user/pbroelspbroelspbroels@uwm.eduAdding name specific functionality to prevent workspace removal and emails. larson-group/sys_admin#735 2021-06-29 15:31:10 -050074f8b9acaaaecdc05763bb35929a066cc551a044Adding name specific functionality to prevent workspace removal and emails. larson-group/sys_admin#735editjenkins_tests/micro_drizzle_test/Jenkinsfileeditjenkins_tests/sam_clubb_build/Jenkinsfileeditjenkins_tests/sam_clubb_silhs_build/Jenkinsfilejenkins_tests/micro_drizzle_test/Jenkinsfilejenkins_tests/sam_clubb_silhs_build/Jenkinsfilejenkins_tests/sam_clubb_build/Jenkinsfile20c75ae6657d50abbd04f3f76ffd2f8c04429e131625071563000http://carson.math.uwm.edu/jenkins/user/pbroelspbroelspbroels@uwm.eduFixing syntax error preventing jenkins tests from running. larson-group/sys_admin#727 2021-06-30 11:46:03 -050020c75ae6657d50abbd04f3f76ffd2f8c04429e13Fixing syntax error preventing jenkins tests from running. larson-group/sys_admin#727editjenkins_tests/sam_clubb_build/Jenkinsfileeditjenkins_tests/micro_drizzle_test/Jenkinsfileeditjenkins_tests/sam_clubb_silhs_build/Jenkinsfilegithttp://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskhttp://carson.math.uwm.edu/jenkins/user/pbroelspbroelsfalse78http://carson.math.uwm.edu/jenkins/view/all/job/sam_clubb_silhs_gfortran_build/78/76http://carson.math.uwm.edu/jenkins/view/all/job/sam_clubb_silhs_gfortran_build/76/