Started by an SCM change47ab2bd8e707b411f4eb6430a626ff7c3b1e8ac2a4ab2bd8e707b411f4eb6430a626ff7c3b1e8ac2a4refs/remotes/origin/masterab2bd8e707b411f4eb6430a626ff7c3b1e8ac2a4ab2bd8e707b411f4eb6430a626ff7c3b1e8ac2a4refs/remotes/origin/masterab2bd8e707b411f4eb6430a626ff7c3b1e8ac2a4ab2bd8e707b411f4eb6430a626ff7c3b1e8ac2a4refs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.gitfalse#4733527572906sam_clubb_silhs_gfortran_build #4747false474397FAILURE1620807908824http://carson.math.uwm.edu/jenkins/view/all/job/sam_clubb_silhs_gfortran_build/47/advance_wp2_wp3_module.F90stats_variables.F90stats_zt_module.F9037095bf5ace54791fd4db1161ba1f8e010cb9ac21620739983000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding some new code that puts the diffusion term d(wp2*em)/dz into a new function, creates a new wp3 budget term (wp3_pr_dfsn), and adds that new budget term to pyplotgen. 2021-05-11 08:33:03 -050037095bf5ace54791fd4db1161ba1f8e010cb9ac2Adding some new code that puts the diffusion term d(wp2*em)/dz into a new function, creates a new wp3 budget term (wp3_pr_dfsn), and adds that new budget term to pyplotgen.editadvance_wp2_wp3_module.F90editstats_zt_module.F90editstats_variables.F90advance_wp2_wp3_module.F90parameters_tunable.F90parameter_indices.F90clubb_api_module.F90bc7ddc176b62b69e5f4d20e730795946851ea82e1620739983000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding new coefficient to control the wp3 pressure diffusion term. 2021-05-11 08:33:03 -0500bc7ddc176b62b69e5f4d20e730795946851ea82eAdding new coefficient to control the wp3 pressure diffusion term.editadvance_wp2_wp3_module.F90editclubb_api_module.F90editparameter_indices.F90editparameters_tunable.F90advance_wp2_wp3_module.F9096e5f1e5197fb6e1e353d02f5b211b1e8c5f96af1620739983000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comSome minor updates to advance_wp2_wp3 relevant to the pr_turb and pr_dfsn terms. 2021-05-11 08:33:03 -050096e5f1e5197fb6e1e353d02f5b211b1e8c5f96afSome minor updates to advance_wp2_wp3 relevant to the pr_turb and pr_dfsn terms.editadvance_wp2_wp3_module.F90stats_clubb_utilities.F90advance_wp2_wp3_module.F906126e2953143ab61f74665b3922ee4cc94894fae1620739983000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comConverting em*d(em)/dz to d(em^2)/dz in the wp3_pr_turb term and fixing a typo. 2021-05-11 08:33:03 -05006126e2953143ab61f74665b3922ee4cc94894faeConverting em*d(em)/dz to d(em^2)/dz in the wp3_pr_turb term and fixing a typo.editstats_clubb_utilities.F90editadvance_wp2_wp3_module.F90advance_wp2_wp3_module.F90parameters_tunable.F90parameter_indices.F90clubb_api_module.F900566da01bc8cc1fa3a19f92f3b19f1a4d453839d1620739983000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comRenaming C_wp3_turb --> C_wp3_pr_turb (BIT_CHANGING due to name change in netcdf output). See #884. 2021-05-11 08:33:03 -05000566da01bc8cc1fa3a19f92f3b19f1a4d453839dRenaming C_wp3_turb --> C_wp3_pr_turb (BIT_CHANGING due to name change in netcdf output).editadvance_wp2_wp3_module.F90editclubb_api_module.F90editparameters_tunable.F90editparameter_indices.F90advance_wp2_wp3_module.F90pdf_closure_module.F90advance_clubb_core_module.F90stats_variables.F90stats_zm_module.F90stats_clubb_utilities.F9045aa88a48da8927786467626eea335eea48498bc1620739983000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comThese changes add the new fourth-order moment variables wp2up2 and wp2vp2 to the CLUBB code. This requires a new function in pdf_closure_module since they must be calculated separately with a new formula, and they are fed through into advance_wp2_wp3 for use with the pr_dfsn subroutine. They are also added to the standard stats file and will be output to netcdf, hence this commit is BIT_CHANGING. The new variables are also added to pyplotgen as part of VariableGroupWs.py where wp4 is found. See #920. 2021-05-11 08:33:03 -050045aa88a48da8927786467626eea335eea48498bcThese changes add the new fourth-order moment variables wp2up2 and wp2vp2 to the CLUBB code. This requires a new function in pdf_closure_module since they must be calculated separately with a new formula, and they are fed through into advance_wp2_wp3 for use with the pr_dfsn subroutine. They are also added to the standard stats file and will be output to netcdf, hence this commit is BIT_CHANGING.editadvance_clubb_core_module.F90editpdf_closure_module.F90editadvance_wp2_wp3_module.F90editstats_variables.F90editstats_zm_module.F90editstats_clubb_utilities.F90tunable_parameters.inf93e240972461676abf906e01b37399306126ead1620739983000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding new coefficient to control the wp3 pressure diffusion term. 2021-05-11 08:33:03 -0500f93e240972461676abf906e01b37399306126eadAdding new coefficient to control the wp3 pressure diffusion term.edittunable_parameters.inadvance_wp2_wp3_module.F9012176c345358d78a4d827cf2b6e7abdbaec0ea8c1620739983000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comPutting the wp3_pr_turb formulation back to its d(rho*wp2*em)/dz form. This would be a BIT_CHANGING commit since it would change the answers for the pr_turb term. However once this branch is merged into the master branch, results should be bit-for-bit since this term was only modified in the alternate branch. See #920. 2021-05-11 08:33:03 -050012176c345358d78a4d827cf2b6e7abdbaec0ea8cPutting the wp3_pr_turb formulation back to its d(rho*wp2*em)/dz form. This would be a BIT_CHANGING commit since it would change the answers for the pr_turb term. However once this branch is merged into the master branch, results should be bit-for-bit since this term was only modified in the alternate branch.editadvance_wp2_wp3_module.F90tunable_parameters.in35540475b191c71945e840eb1b1d43b19ef485121620739983000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comThese changes add the new fourth-order moment variables wp2up2 and wp2vp2 to the CLUBB code. This requires a new function in pdf_closure_module since they must be calculated separately with a new formula, and they are fed through into advance_wp2_wp3 for use with the pr_dfsn subroutine. They are also added to the standard stats file and will be output to netcdf, hence this commit is BIT_CHANGING. The new variables are also added to pyplotgen as part of VariableGroupWs.py where wp4 is found. See #920. 2021-05-11 08:33:03 -050035540475b191c71945e840eb1b1d43b19ef48512These changes add the new fourth-order moment variables wp2up2 and wp2vp2 to the CLUBB code. This requires a new function in pdf_closure_module since they must be calculated separately with a new formula, and they are fed through into advance_wp2_wp3 for use with the pr_dfsn subroutine. They are also added to the standard stats file and will be output to netcdf, hence this commit is BIT_CHANGING.edittunable_parameters.instats_type_utilities.F90interpolation.F90advance_clubb_core_module.F90advance_windm_edsclrm_module.F90calc_pressure.F90advance_helper_module.F901dbc0bf3a0b130e9c249a7142eefba732e17b1e71620766665000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@uwm.eduAdded intent comments for the following files: advance_clubb_core_module, advance_helper_module, and advance_windm_edsclrm_module. These changes are BFB. For ticket #924. 2021-05-11 15:57:45 -05001dbc0bf3a0b130e9c249a7142eefba732e17b1e7Added intent comments for the following files:editstats_type_utilities.F90editadvance_windm_edsclrm_module.F90editadvance_helper_module.F90editcalc_pressure.F90editinterpolation.F90editadvance_clubb_core_module.F90githttp://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskhttp://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens82false48http://carson.math.uwm.edu/jenkins/view/all/job/sam_clubb_silhs_gfortran_build/48/46http://carson.math.uwm.edu/jenkins/view/all/job/sam_clubb_silhs_gfortran_build/46/