http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/e3sm_run_gfortran_teste3sm_run_gfortran_teste3sm_run_gfortran_teste3sm_run_gfortran_testhttp://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/falseStarted by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break38396d0cb2d1dfdff676acb3473a0df8bfb8585e2b796d0cb2d1dfdff676acb3473a0df8bfb8585e2b7refs/remotes/origin/clubb_silhs_devel96d0cb2d1dfdff676acb3473a0df8bfb8585e2b796d0cb2d1dfdff676acb3473a0df8bfb8585e2b7refs/remotes/origin/clubb_silhs_devel96d0cb2d1dfdff676acb3473a0df8bfb8585e2b796d0cb2d1dfdff676acb3473a0df8bfb8585e2b7refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#383617423428101e3sm_run_gfortran_test #383383false3832715FAILURE1727251450737http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/383/advance_wp2_wp3_module.F90mixing_length.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90clubb_api_module.F90clip_explicit.F90numerical_check.F90stats_clubb_utilities.F90matrix_solver_wrapper.F90advance_windm_edsclrm_module.F90advance_helper_module.F90c3912e04050490382fe3e514cd9e4763ff18ecb81727204551000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comreduce compiler warnings (#1180) * refactor code to remove warnings for exceeding 100 characters per line * remove unused variables * remove unused parameters #1174 * fix for the GPU * remove new unused parameters * remove unused dummy arguments * make small changes to reduce compiler warnings * put solve_name back in as input variable to band_solve methods 2024-09-24 14:02:31 -0500c3912e04050490382fe3e514cd9e4763ff18ecb8reduce compiler warnings (#1180)editadvance_xp2_xpyp_module.F90editadvance_windm_edsclrm_module.F90editadvance_xm_wpxp_module.F90editclubb_api_module.F90editadvance_wp2_wp3_module.F90editnumerical_check.F90editstats_clubb_utilities.F90editclip_explicit.F90editmatrix_solver_wrapper.F90editmixing_length.F90editadvance_clubb_core_module.F90editadvance_helper_module.F90silhs_api_module.F90latin_hypercube_driver_module.F90004d3f520a1adab77ee44de70ebc6caca27074eb1727204551000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comreduce compiler warnings (#1180) * refactor code to remove warnings for exceeding 100 characters per line * remove unused variables * remove unused parameters #1174 * fix for the GPU * remove new unused parameters * remove unused dummy arguments * make small changes to reduce compiler warnings * put solve_name back in as input variable to band_solve methods 2024-09-24 14:02:31 -0500004d3f520a1adab77ee44de70ebc6caca27074ebreduce compiler warnings (#1180)editsilhs_api_module.F90editlatin_hypercube_driver_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonhttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse382http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/382/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3827da3239429d39cfba72d19a196e5f4844121f2097da3239429d39cfba72d19a196e5f4844121f209refs/remotes/origin/clubb_silhs_devel7da3239429d39cfba72d19a196e5f4844121f2097da3239429d39cfba72d19a196e5f4844121f209refs/remotes/origin/clubb_silhs_devel7da3239429d39cfba72d19a196e5f4844121f2097da3239429d39cfba72d19a196e5f4844121f209refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#3821462673428101e3sm_run_gfortran_test #382382false3822608FAILURE1726905846279http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/382/clip_explicit.F90clubb_api_module.F90advance_xm_wpxp_module.F90stats_lh_zt_module.F90mt95.F90stats_type_utilities.F90penta_lu_solver.F90grid_class.F90setup_clubb_pdf_params.F90new_pdf_main.F90advance_windm_edsclrm_module.F90mono_flux_limiter.F90advance_helper_module.F90advance_wp2_wp3_module.F90mixing_length.F90advance_xp2_xpyp_module.F90stats_rad_zm_module.F90stats_rad_zt_module.F90tridiag_lu_solver.F90pdf_closure_module.F90Skx_module.F90adg1_adg2_3d_luhar_pdf.F90matrix_solver_wrapper.F90corr_varnce_module.F90precipitation_fraction.F90diffusion.F90model_flags.F90numerical_check.F90output_netcdf.F90stats_lh_sfc_module.F90parameters_tunable.F90saturation.F90advance_xp3_module.F90advance_clubb_core_module.F90lapack_wrap.F90stats_zt_module.F90mean_adv.F90fill_holes.F90stats_sfc_module.F90stats_clubb_utilities.F90stats_zm_module.F90sfc_varnce_module.F90af499c027fac8a33da80b1430c7f2f1425d3553a1726848578000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comrefactor code to remove compiler warnings for exceeding 100 characters per line and unused variables and parameters (#1179) 2024-09-20 11:09:38 -0500af499c027fac8a33da80b1430c7f2f1425d3553arefactor code to remove compiler warnings for exceeding 100 characters per line and unused variables and parameters (#1179)editclip_explicit.F90editoutput_netcdf.F90editpenta_lu_solver.F90editstats_sfc_module.F90editlapack_wrap.F90editmatrix_solver_wrapper.F90editnew_pdf_main.F90editpdf_closure_module.F90editstats_rad_zm_module.F90editmono_flux_limiter.F90editSkx_module.F90edittridiag_lu_solver.F90editclubb_api_module.F90editstats_rad_zt_module.F90editadvance_xp3_module.F90editsfc_varnce_module.F90editprecipitation_fraction.F90editadvance_wp2_wp3_module.F90editmt95.F90editsaturation.F90editstats_lh_zt_module.F90editstats_zt_module.F90editmodel_flags.F90editstats_clubb_utilities.F90editfill_holes.F90editgrid_class.F90editadvance_windm_edsclrm_module.F90editstats_lh_sfc_module.F90editnumerical_check.F90editadvance_clubb_core_module.F90editadvance_xp2_xpyp_module.F90editadvance_helper_module.F90editcorr_varnce_module.F90editstats_zm_module.F90editadvance_xm_wpxp_module.F90editadg1_adg2_3d_luhar_pdf.F90editsetup_clubb_pdf_params.F90editdiffusion.F90editmean_adv.F90editstats_type_utilities.F90editparameters_tunable.F90editmixing_length.F90silhs_api_module.F90transform_to_pdf_module.F90lh_microphys_var_covar_module.F90output_2D_samples_module.F90latin_hypercube_driver_module.F90d52dc47a7c76ddc46b521d0fff0482f25ea91e5e1726848578000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comrefactor code to remove compiler warnings for exceeding 100 characters per line and unused variables and parameters (#1179) 2024-09-20 11:09:38 -0500d52dc47a7c76ddc46b521d0fff0482f25ea91e5erefactor code to remove compiler warnings for exceeding 100 characters per line and unused variables and parameters (#1179)editsilhs_api_module.F90edittransform_to_pdf_module.F90editoutput_2D_samples_module.F90editlatin_hypercube_driver_module.F90editlh_microphys_var_covar_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonhttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse383http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/383/381http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/381/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break38110a273f2caef3cab0f3e6c459b5536377e3b2d2910a273f2caef3cab0f3e6c459b5536377e3b2d29refs/remotes/origin/clubb_silhs_devel10a273f2caef3cab0f3e6c459b5536377e3b2d2910a273f2caef3cab0f3e6c459b5536377e3b2d29refs/remotes/origin/clubb_silhs_devel10a273f2caef3cab0f3e6c459b5536377e3b2d2910a273f2caef3cab0f3e6c459b5536377e3b2d29refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#3811283983428101e3sm_run_gfortran_test #381381false3812529FAILURE1726819449402http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/381/advance_clubb_core_module.F90fd8b67834697b6fae2a1933b212ba571e5a45e681726773850000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving duplicate definition of edsclr when CLUBB_CAM is defined. 2024-09-19 14:24:10 -0500fd8b67834697b6fae2a1933b212ba571e5a45e68Removing duplicate definition of edsclr when CLUBB_CAM is defined.editadvance_clubb_core_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90afaafca1b208625a00b7f826cae0d25251d2ad0d1726782540000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRi zm calc6 (#1177) * Ri_zm calc (Part 6) - Implementing calc_Ri_zm CLUBB tocket #1145 Eliminating call to calc_stability_correction in advance_xm_wpxp 1) In advance_xm_wpxp_module.F90: - Eliminated call to calc_stability_correction in calc_xm_wpxp_lhs_terms - stability_correction is now passed through advance_xm_wpxp to calc_xm_wpxp_lhs_terms - Cleaned up input lists 2) In advance_clubb_core: - Adjusted call to advance_xm_wpxp 3) Adjusted spurious_source_test 2024-09-19 16:49:00 -0500afaafca1b208625a00b7f826cae0d25251d2ad0dRi zm calc6 (#1177)editadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonhttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse382http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/382/380http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/380/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3807368455b3fcadd112a3a409563028bbb8210e2777368455b3fcadd112a3a409563028bbb8210e277refs/remotes/origin/clubb_silhs_devel7368455b3fcadd112a3a409563028bbb8210e2777368455b3fcadd112a3a409563028bbb8210e277refs/remotes/origin/clubb_silhs_devel7368455b3fcadd112a3a409563028bbb8210e2777368455b3fcadd112a3a409563028bbb8210e277refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#380618863428101e3sm_run_gfortran_test #380380false3802429FAILURE1726646647576http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/380/advance_clubb_core_module.F90advance_xp3_module.F90advance_xm_wpxp_module.F90stats_zt_module.F90numerical_check.F90pdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F90stats_zm_module.F90stats_clubb_utilities.F90advance_windm_edsclrm_module.F90new_hybrid_pdf_main.F90sfc_varnce_module.F903ab47e7b81c1bc1b6d5b8ee0fc7ab285614ae7c31726575983000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comchange loop index to sclr and edsclr for sclr_dim and edsclr_dim (#1173) Whenever a loop is dimensioned sclr_dim, use sclr as the loop index. Whenever a loop is dimensioned edsclr_dim, use edsclr as the loop index. Added changes and tested for binary differences with the following flags for the gabls2 case: l_host_applies_sfc_fluxes=true/false l_call_pdf_closure_twice=true/false l_lmm_stepping=true/false l_explicit_turbulent_adv_wpxp=true/false See #987. 2024-09-17 07:26:23 -05003ab47e7b81c1bc1b6d5b8ee0fc7ab285614ae7c3change loop index to sclr and edsclr for sclr_dim and edsclr_dim (#1173)editadvance_windm_edsclrm_module.F90editstats_zt_module.F90editadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90editnew_hybrid_pdf_main.F90editpdf_closure_module.F90editsfc_varnce_module.F90editstats_zm_module.F90editnumerical_check.F90editadg1_adg2_3d_luhar_pdf.F90editstats_clubb_utilities.F90editadvance_xp3_module.F90stats_variables.F90stats_zm_module.F90advance_clubb_core_module.F90advance_helper_module.F9077d72936a35198cc193e31782139908254a6b3f31726604813000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRi zm calc5 (#1175) * Ri_zm calc (Part 5) - Implementing calc_Ri_zm CLUBB tocket #1145 Cleaning up subroutine compute_Cx_fnc_Richardson 1) In advance_helper_module.F90: - Removed superfluous inputs - Added Brunt Väisälä frequency variables, shear_sqd, and Lscale_zm as inputs - Removed call to calc_brunt_vaisala_freq_sqd - Removed zt2zm(Lscale) - Removed calculation and stat_update_var of shear_sqd 2) In advance_clubb_core: - Added stat_update_var for shear_sqd - Adjusted call to compute_Cx_fnc_Richardson 3) Renamed netcdf variable `shear_sqd` to `ddzt_umvm_sqd` to keep variable names consistent. 2024-09-17 15:26:53 -050077d72936a35198cc193e31782139908254a6b3f3Ri zm calc5 (#1175)editadvance_helper_module.F90editstats_variables.F90editstats_zm_module.F90editadvance_clubb_core_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonhttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse381http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/381/379http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/379/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3793cec631e6c0bf5bf65bf36bba0e6e1ae8a968a113cec631e6c0bf5bf65bf36bba0e6e1ae8a968a11refs/remotes/origin/clubb_silhs_devel3cec631e6c0bf5bf65bf36bba0e6e1ae8a968a113cec631e6c0bf5bf65bf36bba0e6e1ae8a968a11refs/remotes/origin/clubb_silhs_devel3cec631e6c0bf5bf65bf36bba0e6e1ae8a968a113cec631e6c0bf5bf65bf36bba0e6e1ae8a968a11refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#379630413428101e3sm_run_gfortran_test #379379false3792265FAILURE1726128249364http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/379/advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_xm_wpxp_module.F90c631c7d3db48f650d77a570b2534e358aa02f1a81726084912000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@users.noreply.github.comChange variables from a1 and a3 to a1_coef and a3_coef For issue #977 2024-09-11 15:01:52 -0500c631c7d3db48f650d77a570b2534e358aa02f1a8Change variables from a1 and a3 to a1_coef and a3_coefeditadvance_xp2_xpyp_module.F90editadvance_wp2_wp3_module.F90editadvance_xm_wpxp_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonhttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse380http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/380/378http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/378/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3788eab1444c83d2e59dca96ad90774366f34563f268eab1444c83d2e59dca96ad90774366f34563f26refs/remotes/origin/clubb_silhs_devel8eab1444c83d2e59dca96ad90774366f34563f268eab1444c83d2e59dca96ad90774366f34563f26refs/remotes/origin/clubb_silhs_devel8eab1444c83d2e59dca96ad90774366f34563f268eab1444c83d2e59dca96ad90774366f34563f26refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#378771513428101e3sm_run_gfortran_test #378378false3782112FAILURE1725609846098http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/378/stats_zm_module.F90stats_variables.F90clip_semi_implicit.F90advance_xm_wpxp_module.F904cbb7d19a3edec730aa008d7f0acbfe51978902c1725574649000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduWell, this will probably anger the Grim Reaper, but I have finally removed the SICL from CLUBB (as discussed a number of months ago). That term is now expunged from the entirety of CLUBB, including all source code, stats files, and postprocessing files. This change is technically BIT_CHANGING because two stats variables, wprtp_sicl and wpthlp_sicl, have been removed from stats output files. However, all results remain exactly the same. 2024-09-05 17:17:29 -05004cbb7d19a3edec730aa008d7f0acbfe51978902cWell, this will probably anger the Grim Reaper, but I have finallydeleteclip_semi_implicit.F90editstats_zm_module.F90editstats_variables.F90editadvance_xm_wpxp_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse379http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/379/377http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/377/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3771c1a2b3992300e2c8d0bd48309cfdaddc3584e041c1a2b3992300e2c8d0bd48309cfdaddc3584e04refs/remotes/origin/clubb_silhs_devel1c1a2b3992300e2c8d0bd48309cfdaddc3584e041c1a2b3992300e2c8d0bd48309cfdaddc3584e04refs/remotes/origin/clubb_silhs_devel1c1a2b3992300e2c8d0bd48309cfdaddc3584e041c1a2b3992300e2c8d0bd48309cfdaddc3584e04refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#377662203428101e3sm_run_gfortran_test #377377false3772022FAILURE1725350649216http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/377/advance_helper_module.F90841d3a1606139e363e09e8bab9f6fda4a41f871e1725305536000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRi zm calc4 (#1168) Bug fix for Ri_zm calc (Part 4) commit CLUBB tocket #1145 * Added missing acc loop directive in calc_Ri_zm 2024-09-02 14:32:16 -0500841d3a1606139e363e09e8bab9f6fda4a41f871eRi zm calc4 (#1168)editadvance_helper_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse378http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/378/376http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/376/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break376c77ace1622c12f49b32f593e0346b4ba6f9bc4e3c77ace1622c12f49b32f593e0346b4ba6f9bc4e3refs/remotes/origin/clubb_silhs_develc77ace1622c12f49b32f593e0346b4ba6f9bc4e3c77ace1622c12f49b32f593e0346b4ba6f9bc4e3refs/remotes/origin/clubb_silhs_develc77ace1622c12f49b32f593e0346b4ba6f9bc4e3c77ace1622c12f49b32f593e0346b4ba6f9bc4e3refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#376670053428101e3sm_run_gfortran_test #376376false3762008FAILURE1725264250197http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/376/diagnostic_v2_0/function_cal_mean.pydiagnostic_v2_0/CLUBB_PROF_20240831.pyc77ace1622c12f49b32f593e0346b4ba6f9bc4e31725202977000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAn update of CLUBB Diagnostic In this update, eam and cam, as well as different SE meshes can be freely defined. 2024-09-01 23:02:57 +0800c77ace1622c12f49b32f593e0346b4ba6f9bc4e3An update of CLUBB Diagnosticadddiagnostic_v2_0/CLUBB_PROF_20240831.pyeditdiagnostic_v2_0/function_cal_mean.pygithttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse377http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/377/375http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/375/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3750260d9ea0fe9ecda7add7594f62e384fa6afbfe30260d9ea0fe9ecda7add7594f62e384fa6afbfe3refs/remotes/origin/clubb_silhs_devel0260d9ea0fe9ecda7add7594f62e384fa6afbfe30260d9ea0fe9ecda7add7594f62e384fa6afbfe3refs/remotes/origin/clubb_silhs_devel0260d9ea0fe9ecda7add7594f62e384fa6afbfe30260d9ea0fe9ecda7add7594f62e384fa6afbfe3refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#375723933428101e3sm_run_gfortran_test #375375false3751940FAILURE1725005047974http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/375/advance_clubb_core_module.F90advance_helper_module.F905d6de8e6e5c208f82bfb0bccc4ebf05346f9825a1724956382000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRi_zm calc (Part 4) - Implementing calc_Ri_zm (#1160) * Ri_zm calc (Part 4) - Implementing calc_Ri_zm CLUBB tocket #1145 1. advance_helper_module.F90 - Implemented calc_Ri_zm - Replaced Ri_zm calculations in compute_Cx_fnc_Richardson 2. advance_clubb_core_module.F90 Replaced Ri_zm calculations in advance_clubb_core 2024-08-29 13:33:02 -05005d6de8e6e5c208f82bfb0bccc4ebf05346f9825aRi_zm calc (Part 4) - Implementing calc_Ri_zm (#1160)editadvance_helper_module.F90editadvance_clubb_core_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse376http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/376/374http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/374/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break37463545accab071b814ed4df6f39b608699ecef3cd63545accab071b814ed4df6f39b608699ecef3cdrefs/remotes/origin/clubb_silhs_devel63545accab071b814ed4df6f39b608699ecef3cd63545accab071b814ed4df6f39b608699ecef3cdrefs/remotes/origin/clubb_silhs_devel63545accab071b814ed4df6f39b608699ecef3cd63545accab071b814ed4df6f39b608699ecef3cdrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#374727953428101e3sm_run_gfortran_test #374374false3741826FAILURE1724745849926http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/374/advance_helper_module.F905063ce59ebf30494012df2da0a8d9e1f5cc945891724704978000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduVariable name correction in acc data statement. 2024-08-26 15:42:58 -05005063ce59ebf30494012df2da0a8d9e1f5cc94589Variable name correction in acc data statement.editadvance_helper_module.F90advance_xp2_xpyp_module.F908553509b703bf07dd4c56fee55c47f11652aa7e21724708483000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSplitting zeros_vector into versions with nzt or nzm size to match sizes in subroutine. 2024-08-26 16:41:23 -05008553509b703bf07dd4c56fee55c47f11652aa7e2Splitting zeros_vector into versions with nzt or nzm size to match sizes in subroutine.editadvance_xp2_xpyp_module.F90clubb_api_module.F90c571fcfd510bd0c8721aadb8a37380212ac2b4ff1724708509000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking radf size correct in api and clubb_driver. 2024-08-26 16:41:49 -0500c571fcfd510bd0c8721aadb8a37380212ac2b4ffMaking radf size correct in api and clubb_driver.editclubb_api_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse375http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/375/373http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/373/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3730e5f6b5cf9014cdf240deb9b7f2fb659e23a57a30e5f6b5cf9014cdf240deb9b7f2fb659e23a57a3refs/remotes/origin/clubb_silhs_devel0e5f6b5cf9014cdf240deb9b7f2fb659e23a57a30e5f6b5cf9014cdf240deb9b7f2fb659e23a57a3refs/remotes/origin/clubb_silhs_devel0e5f6b5cf9014cdf240deb9b7f2fb659e23a57a30e5f6b5cf9014cdf240deb9b7f2fb659e23a57a3refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#373658213428101e3sm_run_gfortran_test #373373false3731642FAILURE1724400246779http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/373/advance_xm_wpxp_module.F90clubb_api_module.F90clip_explicit.F90grid_class.F90setup_clubb_pdf_params.F90advance_windm_edsclrm_module.F90advance_helper_module.F90mono_flux_limiter.F90mixing_length.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90pdf_closure_module.F90Skx_module.F90adg1_adg2_3d_luhar_pdf.F90calc_pressure.F90precipitation_fraction.F90diffusion.F90numerical_check.F90pos_definite_module.F90hydromet_pdf_parameter_module.F90parameters_tunable.F90sponge_layer_damping.F90turbulent_adv_pdf.F90advance_xp3_module.F90advance_clubb_core_module.F90mean_adv.F90fill_holes.F90stats_type.F90sigma_sqd_w_module.F90stats_clubb_utilities.F90sfc_varnce_module.F9090c974765822217b0693858a0ac0f115c5b964a21724333265000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb ghost exorcism (#1159) * I am adding grid_class_new.F90 to the code as a copy of grid_class.F90. The first step toward removing the ghost level from the model is to modify the grid file. Having a second grid file in play will allow functions and subroutines that are undergoing modification earlier in this process to use the new file, while functions and subroutines that have not yet been modified will continue to use the old grid file until they can be modified. At the end of this process, the old grid file will be able to be removed and grid_class_new.F90 will simply be able to be renamed grid_class.F90 at that point. In this commit, I have altered the schematic and the comments at the very start of the module to be "ghostless". * Updated grid_class for the changes to the grid interpolation weighting functions for the new "ghostless" ascending grid. * Committing some updates to the new grid class file for ghostless ascending. * Updating to match recent changes made to grid_class.F90. * I finished the removal of the ghost level from the entirety of the new grid_class file. This standalone file compiles successfully. * Removing the sources of compiler warnings in grid_class_new.F90 (these were carried over from grid_class.F90). * Committing progress in advance_wp2_wp3_module.F90 with regards to ghostless grid. * I am committing the updated version of grid_class_new.F90 that allows all cases to run, regardless of grid_type. * Fixed a bug in grid_class_new.F90 When grid_type = 2, the calculations of the indices begin_height and end_height are based on the thermodynamic level grids. Those grid indices should be used in the call to setup_grid_heights, where the array of thermodynamic_heights, from index begin_height to index end_height, should become gr%zt. When grid_type - 3, the calculations of the indices begin_height and end_height are based on the momentum grid levels. Either way, momentum_heights and thermodynamic_heights should both have the array from begin_height to end_height passed in. When grid_type = 2, only the thermodynamic height array is relevant in the setup. When grid_type = 3, only the momentum height array is relevant in the setup. * For thermodynamic_height, 1:nzmax-1 is the entire array, but I entered this for a clarification, especially considering the following check block. * Updated grid_class_new to better handle the begin_height and end_height indices. * Some modifications to advance_wp2_wp3 * Committed some temporary code. * committed some temporary changes to clubb_api_module. * Making a bunch of commits to clubb_driver that are mainly temporary for interface and printing purposes. * Deghosted another subroutine. * Updated wp2_term_ta_lhs to use the new gridding. * De-ghosting wp2_terms_ac_pr2_lhs * De-ghosted wp2_term_pr3_rhs * Deghosting wp3_term_tp_lhs. * Deghosted wp3_terms_ac_pr2_lhs * Updated the wp3_term_ta_ADG1_lhs subroutine to use boundary conditions where wp3 (at the top level and bottom momentum levels of the model) is assumed to have a value of 0. * For single loop vectors, removing the "collapse(2)" from the acc statements. This commit is not bit changing, but the previous commit to this branch was BIT_CHANGING:902d6caed8a4533f59f4165106276959b4f90895 * I updated wp3_term_ta_explicit_rhs for the ghostless grid. When l_explicit_turbulent_adv_wp3 is turned on, the results from this branch exactly match those found on the master branch. * Updating diffusion_zm_lhs for "Ghostless" gridding. * Fixed a typo in the comments that was introduced in the previous commit. * Updated for "ghostless" diffusion. * With wp3 now being set to a fixed-point boundary condition value of 0 at the current thermodynamic level 1 (first t-lev above the surface), it is not necessary to loop over level 1 within the code for each wp3 term. Also contains code to enforce a fixed-point boundary condition of wp3=0 at the first thermodynamic level above the surface. * Restoring diffusion to the way it should be for the exorcised ghost grid prior to the most recent master merge. Lines for the ghost point were accidentally added during the merge commit. * Updated code to correct wp3_bp1 and wp3_pr2 budget terms so that they still match bit-for-bit what is found in the master branch. * Updating term_ma_zm_lhs for ghostless gridding. Results are bit-for-bit identical. * After debugging, I am now committing the ghostless version of term_ma_zt_lhs. * Updating the clubb_ghost_exorcism branch for ghostless wp23 rhs, lhs, and solve. This revision runs; however, there are still some issues tracking down the source of problems in maintaining bit-for-bit results. * Updated to maintain bit-for-bitness with the master code. * Finished exorcising the ghost from advance_wp2_wp3_module.F90. * Small openacc changes to fix GPU runs * Adjusting new hybrid PDF code to continue to match the master branch bit-for-bit while construction continues. * Committing the first portion of a nomenclature change where the number of momentum vertical grid levels is denoted as nzm rather than nz. * Changing the notation of the number of grid levels on the momentum grid, previously nz, to nzm in some files. * Changed some comments and a little bit of code in the new grid_class file to provide a better description. * Updated sigma_sqd_w_module for ghostless gridding. * I added the new "ghostless" discretization to turbulent_adv_pdf.F90, and also appropriately altered the points in the code where the turbulent advection subroutines are called from in advance_xm_wpxp_module.F90 and advance_xp2_xpyp_module.F90. The code produced bit-for-bit results in regards to the standard configuration, the new hybrid PDF configuration, and also for the configuration with the godunov flags turned on. * Altered many of the lower-level subroutines in advance_xp2_xpyp_module.F90 for ghostless gridding. * Upgraded subroutine calc_xp2_xpyp_ta_terms for ghostless discretization. This should alter the results when the new_hybrid PDF is used in conjunction with upwind discretization, but it doesn't alter the results for anything else. * Completed making advance_xp2_xpyp ghostless. * Completed the de-ghosting of advance_windm_edsclrm. Results are BIT_CHANGING because the ghost level was interacting with the results. * The call to calc_xpwp from advance_microphys was not supposed to be updated yet. It wound up being sort of "partially updated" for ghostless gridding, which was a bug that led to some diagnostic output fields not being bit-for-bit. In this commit, I returned it to its prior form so that zm output files once again retain bit-for-bit status between this branch and the master. * The ghost point interface statements after the return from advance_windm_edsclrm needed to be encased in the same conditional statements that the calculations occurred in with the aforementioned subroutine. This change fixes a bug where a handful of cases had results that were not bit-for-bit from revisions before this code was added. * Fixed bug where the wrong stats were being recorded to the stats for coef_wpthlp2_implicit, etc. * I am committing a bug fix to the implicit surface flux calculation in the eddy-diffusivity wind code (which is used when l_predict_upwp_vpwp is turned off). I am also committing some temporary ghost point interface stats code within advance_windm_edsclrm. * I updated the diagrams in advance_windm_edsclrm to reflect the new ghostless grid. * I improved the description section of advance_windm_edsclrm. * Made numerous low-level subroutines ghostless within advance_xm_wpxp_module.F90. Maintained bit-for-bit results with the master branch. * I am updating the xm wpxp code that calls the wpxp turbulent advection term based on your PDF and option for ghostless gridding. * Updating some of the lower-level functions of the monotonic flux limiter for ghostless gridding. * I have updated the monotonic flux limiter for ghostless gridding! * A couple of redundant declarations were brought in on the last merge. * Committing further updates to ghostless gridding, including: 1) Further modifications to advance_xm_wpxp, which includes branching out in Brunt-Vaisala frequency calculations in advance_helper; 2) Update in calculating the initial pressure; and 3) updating grid class new to use the same "value drop down" in the zt2zm function and "derivative drop down" in the ddzt function that are now used in grid_class in the master. Results are bit-for-bit identical with the master. * Updated xm_wpxp_lhs for ghostless gridding. * Made xm_wpxp_rhs ghostless. * Updated xm_wpxp_solve for ghostless gridding! * Updating pos_definite_module.F90 for ghostless gridding. * Updated vertical hole filling and xm clipping and stats for ghost point removal. Results are still bit-for-bit with the master branch. * Updated advance_xm_wpxp to remove the ghost point. * Updating some zt stats to use a value of 0 for the "ghost" level. * Updated subroutine compute_mixing_length for ghostless gridding. * Removing the ghost point from calculate_Lscale_directly * Added a "ghostbuster" option (-g) in the run_bindiff_all.py python script that omits the "ghost" level from the comparison for _zt.nc output files when envoked. * I de-ghosted the l_diagnose_Lscale_from_tau code. * Fixing a couple bugs with the merge. * De-ghosted a couple of subroutines with advance_helper_module.F90. * Code wasn't compiling because of too many characters on one line. * De-ghosted precipitation_fraction.F90. * De-ghosted more code, including sfc_varnce_module.F90. * De-ghosted numerical_check.F90 * Committing a chunk of code that effectively "finishes off" the deghosting of CLUBB core, although results aren't there yet and it still needs more debugging. * This corrects the bug where an error would occur when trying to compare a run with a ghost level to a run without a ghost level. * Commiting some necessary ghost point removal code. * Updated the calculations of rcm_in_layer and cloud_cover for ghostless gridding. * I removed the ghost point from all the files within the Benchmark_cases directory. * I am committing code that removes the ghost level from setup_clubb_pdf_params and most of the collection of CLUBB's microphysics schemes. * Fixing a bug in SILHS where sample point values were being overwritten at level 1. * I fixed some bugs in the ghostless version of the Morrison microphysics driver. * I fixed some array declaration mismatches in silhs_api_module.F90. * I have deghosted the call to the code that calculates microphysics tendencies and everything below it. * Performed a de-ghosting, as well as an improvement that ensures that mean sedimentation is always conservative (excluding the amount of hydrometeor that leaves the domain at the surface), to all subroutines at the level of microphys_lhs and lower in advance_microphys_module.F90. This includes all process-related subroutines like those that govern sedimentation or turbulent sedimentation. Gee, how is it possible that such are large amount of work gets done when there's no office. It must have been magic elves who did it. I mean, a physical office must be key to every element of functioning in life, right? * Reversing the accidental stats file commit I made in the previous commit. * Updating the "leftovers" from the previous merge to make it consistent with the call syntax in the new, ghostless CLUBB. * Updated the turbulent sedimentation code to handle upper and lower boundary conditions in a better manner. * I have finished de-ghosting the entirety of advance_microphys_module.F90 and all codes that are underneath its umbrella. * I finished de-ghosting the radiation portion of CLUBB. * I have removed the ghost level from hydrostatic_module.F90. * I removed the ghost point from parameters_tunable and started referencing the ghostless grid through the entirety of clubb_api_module as well as in all of the G-unit tests. * Deghosted another file. Not too many left. * Deghosted sounding.F90 * I have deghosted clubb_driver.F90 and everything below its umbrella, which is a huge benchmark in this process. * It is not necessary to de-ghost the source code for the tuner, since the information on what levels it is tuning for is fed in from input files. Within the tuner input files, I have adjusted the tuning ranges by 1 to compensate for the fact that the ghost level has now been entirely removed from the model. * Got rid of some unnecessary "use grid_class" statements that were still referencing the old grid. * I have found a bug in the ghostless SILHS code in the SILHS code that calculates the variances and covariances of moisture and heat (that are fed back into the model predictive equations). In short, variables that were used to store the grid mean values of thl, rt, and w were being set to 0 at level 1. This was fine when level 1 was the ghost level, but level 1 is no longer the ghost level. This was root cause of the issue. * The line that sets rand_pool at level 1 that was merged in during the previous merge commit needs to be removed. * These lines also needed to be fixed because they were supposed to be changed to nzt / 2 after the previous merge commit. * Correcting a bug in coamps microphysics regarded the unnecessary interpolation of hydrometeor sedimentation velocities to the zm grid. This interpolation is a bug because CLUBB expects hydrometeor velocities output on the zt grid. * I am committing a fix to the _ta budget terms. It will fix the error messages as well allow for budget term agreement between the master and clubb_ghost_exorcism branches. * Fixing an error in the ghostless budget stats for turbulent sedimentation. * After the merge, I am once again updating the merged code for ghost level removal. * Getting rid of leftover ghost removal junk that was still lying around. * I needed to pass p_sfc inside CLUBB core to help set the value of p_in_Pa_zm at level 1. * C11_Skw_fnc is a zt variable, while Cx_fnc_Richardson is a zm variable. The offset is to keep results the same between the current master branch and the clubb_ghost_exorcism branch when the l_use_C11_Richardson flag is enabled. * Fixed a bug. * I found a couple more instances where the api had dimensions switched around. * Eliminated diffusion_cloud_frac_zt_lhs, which is unused code that isn't even hooked up (called from) anywhere in the model anymore. * Changes that also needed to be made with the previous commit. * The source of the array out-of-bounds error. * Moving grid_class_new back to grid_class! * Reminder notes in case input_fields gets used in the future. * I accidentally committed input fields related changes to rico_model.in that weren't meant to be committed in the previous commit. I am undoing those now. * Having clubb thermodynamic level 1 below the surface is no longer the stanard scenario! --------- Co-authored-by: Gunther Huebler <huebler@uwm.edu> 2024-08-22 08:27:45 -050090c974765822217b0693858a0ac0f115c5b964a2Clubb ghost exorcism (#1159)editmixing_length.F90editadvance_helper_module.F90editmono_flux_limiter.F90editcalc_pressure.F90edithydromet_pdf_parameter_module.F90editadvance_xp2_xpyp_module.F90editadvance_xm_wpxp_module.F90editfill_holes.F90editprecipitation_fraction.F90editsponge_layer_damping.F90editstats_type.F90editclubb_api_module.F90editnumerical_check.F90editadvance_xp3_module.F90editsfc_varnce_module.F90editclip_explicit.F90editsetup_clubb_pdf_params.F90editparameters_tunable.F90editstats_clubb_utilities.F90editmean_adv.F90editdiffusion.F90editadvance_wp2_wp3_module.F90editturbulent_adv_pdf.F90editgrid_class.F90editsigma_sqd_w_module.F90editadvance_clubb_core_module.F90editpdf_closure_module.F90editSkx_module.F90editadvance_windm_edsclrm_module.F90editpos_definite_module.F90editadg1_adg2_3d_luhar_pdf.F90silhs_api_module.F90est_kessler_microphys_module.F90transform_to_pdf_module.F90lh_microphys_var_covar_module.F90output_2D_samples_module.F90latin_hypercube_driver_module.F903b4700eb924086aac1093d1401fb4f59c7a66b501724333265000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb ghost exorcism (#1159) * I am adding grid_class_new.F90 to the code as a copy of grid_class.F90. The first step toward removing the ghost level from the model is to modify the grid file. Having a second grid file in play will allow functions and subroutines that are undergoing modification earlier in this process to use the new file, while functions and subroutines that have not yet been modified will continue to use the old grid file until they can be modified. At the end of this process, the old grid file will be able to be removed and grid_class_new.F90 will simply be able to be renamed grid_class.F90 at that point. In this commit, I have altered the schematic and the comments at the very start of the module to be "ghostless". * Updated grid_class for the changes to the grid interpolation weighting functions for the new "ghostless" ascending grid. * Committing some updates to the new grid class file for ghostless ascending. * Updating to match recent changes made to grid_class.F90. * I finished the removal of the ghost level from the entirety of the new grid_class file. This standalone file compiles successfully. * Removing the sources of compiler warnings in grid_class_new.F90 (these were carried over from grid_class.F90). * Committing progress in advance_wp2_wp3_module.F90 with regards to ghostless grid. * I am committing the updated version of grid_class_new.F90 that allows all cases to run, regardless of grid_type. * Fixed a bug in grid_class_new.F90 When grid_type = 2, the calculations of the indices begin_height and end_height are based on the thermodynamic level grids. Those grid indices should be used in the call to setup_grid_heights, where the array of thermodynamic_heights, from index begin_height to index end_height, should become gr%zt. When grid_type - 3, the calculations of the indices begin_height and end_height are based on the momentum grid levels. Either way, momentum_heights and thermodynamic_heights should both have the array from begin_height to end_height passed in. When grid_type = 2, only the thermodynamic height array is relevant in the setup. When grid_type = 3, only the momentum height array is relevant in the setup. * For thermodynamic_height, 1:nzmax-1 is the entire array, but I entered this for a clarification, especially considering the following check block. * Updated grid_class_new to better handle the begin_height and end_height indices. * Some modifications to advance_wp2_wp3 * Committed some temporary code. * committed some temporary changes to clubb_api_module. * Making a bunch of commits to clubb_driver that are mainly temporary for interface and printing purposes. * Deghosted another subroutine. * Updated wp2_term_ta_lhs to use the new gridding. * De-ghosting wp2_terms_ac_pr2_lhs * De-ghosted wp2_term_pr3_rhs * Deghosting wp3_term_tp_lhs. * Deghosted wp3_terms_ac_pr2_lhs * Updated the wp3_term_ta_ADG1_lhs subroutine to use boundary conditions where wp3 (at the top level and bottom momentum levels of the model) is assumed to have a value of 0. * For single loop vectors, removing the "collapse(2)" from the acc statements. This commit is not bit changing, but the previous commit to this branch was BIT_CHANGING:902d6caed8a4533f59f4165106276959b4f90895 * I updated wp3_term_ta_explicit_rhs for the ghostless grid. When l_explicit_turbulent_adv_wp3 is turned on, the results from this branch exactly match those found on the master branch. * Updating diffusion_zm_lhs for "Ghostless" gridding. * Fixed a typo in the comments that was introduced in the previous commit. * Updated for "ghostless" diffusion. * With wp3 now being set to a fixed-point boundary condition value of 0 at the current thermodynamic level 1 (first t-lev above the surface), it is not necessary to loop over level 1 within the code for each wp3 term. Also contains code to enforce a fixed-point boundary condition of wp3=0 at the first thermodynamic level above the surface. * Restoring diffusion to the way it should be for the exorcised ghost grid prior to the most recent master merge. Lines for the ghost point were accidentally added during the merge commit. * Updated code to correct wp3_bp1 and wp3_pr2 budget terms so that they still match bit-for-bit what is found in the master branch. * Updating term_ma_zm_lhs for ghostless gridding. Results are bit-for-bit identical. * After debugging, I am now committing the ghostless version of term_ma_zt_lhs. * Updating the clubb_ghost_exorcism branch for ghostless wp23 rhs, lhs, and solve. This revision runs; however, there are still some issues tracking down the source of problems in maintaining bit-for-bit results. * Updated to maintain bit-for-bitness with the master code. * Finished exorcising the ghost from advance_wp2_wp3_module.F90. * Small openacc changes to fix GPU runs * Adjusting new hybrid PDF code to continue to match the master branch bit-for-bit while construction continues. * Committing the first portion of a nomenclature change where the number of momentum vertical grid levels is denoted as nzm rather than nz. * Changing the notation of the number of grid levels on the momentum grid, previously nz, to nzm in some files. * Changed some comments and a little bit of code in the new grid_class file to provide a better description. * Updated sigma_sqd_w_module for ghostless gridding. * I added the new "ghostless" discretization to turbulent_adv_pdf.F90, and also appropriately altered the points in the code where the turbulent advection subroutines are called from in advance_xm_wpxp_module.F90 and advance_xp2_xpyp_module.F90. The code produced bit-for-bit results in regards to the standard configuration, the new hybrid PDF configuration, and also for the configuration with the godunov flags turned on. * Altered many of the lower-level subroutines in advance_xp2_xpyp_module.F90 for ghostless gridding. * Upgraded subroutine calc_xp2_xpyp_ta_terms for ghostless discretization. This should alter the results when the new_hybrid PDF is used in conjunction with upwind discretization, but it doesn't alter the results for anything else. * Completed making advance_xp2_xpyp ghostless. * Completed the de-ghosting of advance_windm_edsclrm. Results are BIT_CHANGING because the ghost level was interacting with the results. * The call to calc_xpwp from advance_microphys was not supposed to be updated yet. It wound up being sort of "partially updated" for ghostless gridding, which was a bug that led to some diagnostic output fields not being bit-for-bit. In this commit, I returned it to its prior form so that zm output files once again retain bit-for-bit status between this branch and the master. * The ghost point interface statements after the return from advance_windm_edsclrm needed to be encased in the same conditional statements that the calculations occurred in with the aforementioned subroutine. This change fixes a bug where a handful of cases had results that were not bit-for-bit from revisions before this code was added. * Fixed bug where the wrong stats were being recorded to the stats for coef_wpthlp2_implicit, etc. * I am committing a bug fix to the implicit surface flux calculation in the eddy-diffusivity wind code (which is used when l_predict_upwp_vpwp is turned off). I am also committing some temporary ghost point interface stats code within advance_windm_edsclrm. * I updated the diagrams in advance_windm_edsclrm to reflect the new ghostless grid. * I improved the description section of advance_windm_edsclrm. * Made numerous low-level subroutines ghostless within advance_xm_wpxp_module.F90. Maintained bit-for-bit results with the master branch. * I am updating the xm wpxp code that calls the wpxp turbulent advection term based on your PDF and option for ghostless gridding. * Updating some of the lower-level functions of the monotonic flux limiter for ghostless gridding. * I have updated the monotonic flux limiter for ghostless gridding! * A couple of redundant declarations were brought in on the last merge. * Committing further updates to ghostless gridding, including: 1) Further modifications to advance_xm_wpxp, which includes branching out in Brunt-Vaisala frequency calculations in advance_helper; 2) Update in calculating the initial pressure; and 3) updating grid class new to use the same "value drop down" in the zt2zm function and "derivative drop down" in the ddzt function that are now used in grid_class in the master. Results are bit-for-bit identical with the master. * Updated xm_wpxp_lhs for ghostless gridding. * Made xm_wpxp_rhs ghostless. * Updated xm_wpxp_solve for ghostless gridding! * Updating pos_definite_module.F90 for ghostless gridding. * Updated vertical hole filling and xm clipping and stats for ghost point removal. Results are still bit-for-bit with the master branch. * Updated advance_xm_wpxp to remove the ghost point. * Updating some zt stats to use a value of 0 for the "ghost" level. * Updated subroutine compute_mixing_length for ghostless gridding. * Removing the ghost point from calculate_Lscale_directly * Added a "ghostbuster" option (-g) in the run_bindiff_all.py python script that omits the "ghost" level from the comparison for _zt.nc output files when envoked. * I de-ghosted the l_diagnose_Lscale_from_tau code. * Fixing a couple bugs with the merge. * De-ghosted a couple of subroutines with advance_helper_module.F90. * Code wasn't compiling because of too many characters on one line. * De-ghosted precipitation_fraction.F90. * De-ghosted more code, including sfc_varnce_module.F90. * De-ghosted numerical_check.F90 * Committing a chunk of code that effectively "finishes off" the deghosting of CLUBB core, although results aren't there yet and it still needs more debugging. * This corrects the bug where an error would occur when trying to compare a run with a ghost level to a run without a ghost level. * Commiting some necessary ghost point removal code. * Updated the calculations of rcm_in_layer and cloud_cover for ghostless gridding. * I removed the ghost point from all the files within the Benchmark_cases directory. * I am committing code that removes the ghost level from setup_clubb_pdf_params and most of the collection of CLUBB's microphysics schemes. * Fixing a bug in SILHS where sample point values were being overwritten at level 1. * I fixed some bugs in the ghostless version of the Morrison microphysics driver. * I fixed some array declaration mismatches in silhs_api_module.F90. * I have deghosted the call to the code that calculates microphysics tendencies and everything below it. * Performed a de-ghosting, as well as an improvement that ensures that mean sedimentation is always conservative (excluding the amount of hydrometeor that leaves the domain at the surface), to all subroutines at the level of microphys_lhs and lower in advance_microphys_module.F90. This includes all process-related subroutines like those that govern sedimentation or turbulent sedimentation. Gee, how is it possible that such are large amount of work gets done when there's no office. It must have been magic elves who did it. I mean, a physical office must be key to every element of functioning in life, right? * Reversing the accidental stats file commit I made in the previous commit. * Updating the "leftovers" from the previous merge to make it consistent with the call syntax in the new, ghostless CLUBB. * Updated the turbulent sedimentation code to handle upper and lower boundary conditions in a better manner. * I have finished de-ghosting the entirety of advance_microphys_module.F90 and all codes that are underneath its umbrella. * I finished de-ghosting the radiation portion of CLUBB. * I have removed the ghost level from hydrostatic_module.F90. * I removed the ghost point from parameters_tunable and started referencing the ghostless grid through the entirety of clubb_api_module as well as in all of the G-unit tests. * Deghosted another file. Not too many left. * Deghosted sounding.F90 * I have deghosted clubb_driver.F90 and everything below its umbrella, which is a huge benchmark in this process. * It is not necessary to de-ghost the source code for the tuner, since the information on what levels it is tuning for is fed in from input files. Within the tuner input files, I have adjusted the tuning ranges by 1 to compensate for the fact that the ghost level has now been entirely removed from the model. * Got rid of some unnecessary "use grid_class" statements that were still referencing the old grid. * I have found a bug in the ghostless SILHS code in the SILHS code that calculates the variances and covariances of moisture and heat (that are fed back into the model predictive equations). In short, variables that were used to store the grid mean values of thl, rt, and w were being set to 0 at level 1. This was fine when level 1 was the ghost level, but level 1 is no longer the ghost level. This was root cause of the issue. * The line that sets rand_pool at level 1 that was merged in during the previous merge commit needs to be removed. * These lines also needed to be fixed because they were supposed to be changed to nzt / 2 after the previous merge commit. * Correcting a bug in coamps microphysics regarded the unnecessary interpolation of hydrometeor sedimentation velocities to the zm grid. This interpolation is a bug because CLUBB expects hydrometeor velocities output on the zt grid. * I am committing a fix to the _ta budget terms. It will fix the error messages as well allow for budget term agreement between the master and clubb_ghost_exorcism branches. * Fixing an error in the ghostless budget stats for turbulent sedimentation. * After the merge, I am once again updating the merged code for ghost level removal. * Getting rid of leftover ghost removal junk that was still lying around. * I needed to pass p_sfc inside CLUBB core to help set the value of p_in_Pa_zm at level 1. * C11_Skw_fnc is a zt variable, while Cx_fnc_Richardson is a zm variable. The offset is to keep results the same between the current master branch and the clubb_ghost_exorcism branch when the l_use_C11_Richardson flag is enabled. * Fixed a bug. * I found a couple more instances where the api had dimensions switched around. * Eliminated diffusion_cloud_frac_zt_lhs, which is unused code that isn't even hooked up (called from) anywhere in the model anymore. * Changes that also needed to be made with the previous commit. * The source of the array out-of-bounds error. * Moving grid_class_new back to grid_class! * Reminder notes in case input_fields gets used in the future. * I accidentally committed input fields related changes to rico_model.in that weren't meant to be committed in the previous commit. I am undoing those now. * Having clubb thermodynamic level 1 below the surface is no longer the stanard scenario! --------- Co-authored-by: Gunther Huebler <huebler@uwm.edu> 2024-08-22 08:27:45 -05003b4700eb924086aac1093d1401fb4f59c7a66b50Clubb ghost exorcism (#1159)editoutput_2D_samples_module.F90edittransform_to_pdf_module.F90editsilhs_api_module.F90editest_kessler_microphys_module.F90editlh_microphys_var_covar_module.F90editlatin_hypercube_driver_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse374http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/374/372http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/372/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break372d7f3a5c8fd25ac9f91dcdd5c0915f7de1ba180cbd7f3a5c8fd25ac9f91dcdd5c0915f7de1ba180cbrefs/remotes/origin/clubb_silhs_develd7f3a5c8fd25ac9f91dcdd5c0915f7de1ba180cbd7f3a5c8fd25ac9f91dcdd5c0915f7de1ba180cbrefs/remotes/origin/clubb_silhs_develd7f3a5c8fd25ac9f91dcdd5c0915f7de1ba180cbd7f3a5c8fd25ac9f91dcdd5c0915f7de1ba180cbrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#372720733428101e3sm_run_gfortran_test #372372false3721512FAILURE1723881848722http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/372/latin_hypercube_driver_module.F900c35bdb2e850e41bab982505438cc7b575c3cde41723785812000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comNightly clubb plots (#1167) * Making step to plot output, copy to pub folder, then create an index.html file to display all plots in that folder. * Small tweaks * Small fixes in pyplotgen. * Copy needs -r * Using jenkins env variables and switching to scp/ssh commands to allow plots to be generated and created on any machine. * Adding quotes are env variable usage * Pyplotgen addition to create a git_info file containing branch and commit name. * Script should handle the pyplotgen _generated_on_... suffix. * Making script only run arm again during testing. * More robust way to get git branch in pyplotgen. * Testing single quotes * Making all cases run again. * Undoing most pyplotgen changes. Making create_plot_list script general and take in a directory. Returning short run test mode. * Update to create git_info line * Making all cases run again and adding plot support for ifort. * Adding plot step to nvhpc gpu diffness test. * Fixing error * Reverting diffness script, making new one specifically for plotting. * Changes to allow plotting of previous output. * Setting O0 for testing * Branch folder restructure. * Making tests run all cases again and update master output only. * Clean up and naming changes. * Addin -O2 back. * Small update to pyplotgen to make title reflect name of output specified in command. * This cuda call doesn't work with the subscript for some reason. * Making only priority cases run for GPU plot test and preventin it from running on carson 2024-08-16 00:23:32 -05000c35bdb2e850e41bab982505438cc7b575c3cde4Nightly clubb plots (#1167)editlatin_hypercube_driver_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse373http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/373/371http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/371/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3718521c188029aeba8d2f31c2c27bdd6f1f89b49ce8521c188029aeba8d2f31c2c27bdd6f1f89b49cerefs/remotes/origin/clubb_silhs_devel8521c188029aeba8d2f31c2c27bdd6f1f89b49ce8521c188029aeba8d2f31c2c27bdd6f1f89b49cerefs/remotes/origin/clubb_silhs_devel8521c188029aeba8d2f31c2c27bdd6f1f89b49ce8521c188029aeba8d2f31c2c27bdd6f1f89b49cerefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#371685193428101e3sm_run_gfortran_test #371371false3711240FAILURE1723190649359http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/371/advance_wp2_wp3_module.F90advance_xm_wpxp_module.F90d135c3d79b104de8ec0d611cf9854c542ee169191723145344000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdded zt2zm2zt-smoothing to remove noise in MPACE_B winds (#1161) BIT_CHANGING In order to remove noise in the wind fields in MPACE_B, we added some smoothing. * Added `zt2zm2zt`-smoothing to `diagnose_upxp` calls in `advance_xm_wpxp` * Added `zm2zt2zm`-smoothing to `wp2` and `em` vars fed into `wp3_term_pr_turb_rhs` in `advance_wp2_wp3` * Changed C_wp2_splat to 0.00 in default tunable_parameters.in 2024-08-08 14:29:04 -0500d135c3d79b104de8ec0d611cf9854c542ee16919Added zt2zm2zt-smoothing to remove noise in MPACE_B winds (#1161)editadvance_xm_wpxp_module.F90editadvance_wp2_wp3_module.F90parameters_model.F909153bbbc08436d993c2bb238095026e750059b721723145363000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMoving PosInf to clubb_model_settings.F90 2024-08-08 14:29:23 -05009153bbbc08436d993c2bb238095026e750059b72Moving PosInf to clubb_model_settings.F90editparameters_model.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse372http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/372/370http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/370/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break370192d30265348c90d246e67b9bef73fde8df5bcae192d30265348c90d246e67b9bef73fde8df5bcaerefs/remotes/origin/clubb_silhs_devel192d30265348c90d246e67b9bef73fde8df5bcae192d30265348c90d246e67b9bef73fde8df5bcaerefs/remotes/origin/clubb_silhs_devel192d30265348c90d246e67b9bef73fde8df5bcae192d30265348c90d246e67b9bef73fde8df5bcaerefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#370634283428101e3sm_run_gfortran_test #370370false3701164FAILURE1722585848199http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/370/.gitmodules192d30265348c90d246e67b9bef73fde8df5bcae1722546285000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing .gitmodules so submodules are cloned via https instead of ssh. See comment https://github.com/larson-group/sys_admin/issues/629\#issuecomment-561306186 and commit 4efea21 for slightly more info. 2024-08-01 16:04:45 -0500192d30265348c90d246e67b9bef73fde8df5bcaeFixing .gitmodules so submodules are cloned via https instead of ssh. See comment https://github.com/larson-group/sys_admin/issues/629\#issuecomment-561306186 and commit 4efea21 for slightly more info.edit.gitmodulesgithttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse371http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/371/369http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/369/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3693ec29b165cfad789324407d03730bb7a72d0a61a3ec29b165cfad789324407d03730bb7a72d0a61arefs/remotes/origin/clubb_silhs_devel3ec29b165cfad789324407d03730bb7a72d0a61a3ec29b165cfad789324407d03730bb7a72d0a61arefs/remotes/origin/clubb_silhs_devel3ec29b165cfad789324407d03730bb7a72d0a61a3ec29b165cfad789324407d03730bb7a72d0a61arefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#369496513428101e3sm_run_gfortran_test #369369false3691102FAILURE1722499449259http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/369/mono_flux_limiter.F90c304d15ab5483f1e7f0b0de1b9f01f06fb7d09b91722452248000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing GPU bug. There is a vertical dependency with wpxp. This is what was breaking the ECT test, see larson-group/cam#175 2024-07-31 13:57:28 -0500c304d15ab5483f1e7f0b0de1b9f01f06fb7d09b9Fixing GPU bug. There is a vertical dependency with wpxp. This is what was breaking the ECT test, see larson-group/cam#175editmono_flux_limiter.F90advance_clubb_core_module.F90pdf_closure_module.F9032a74a3cbba967b1b3558708ca78d7929dee6d601722455629000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bugs that are only caught when not outputting w_[up/down]_in_cloud stats or if l_host_applies_sfc_fluxes=.true. The l_host_applies_sfc_fluxes=.true. isn't testable (at least not in clubb_standalone), and I just caught that visually. The cloudy_updraft_frac and cloudy_downdraft_frac fields not being set were only noticable in cam, because we always run with iw_up_in_cloud>0 and iw_down_in_cloud>0 to output stats. 2024-07-31 14:53:49 -050032a74a3cbba967b1b3558708ca78d7929dee6d60Fixing bugs that are only caught when not outputting w_[up/down]_in_cloud stats or if l_host_applies_sfc_fluxes=.true. The l_host_applies_sfc_fluxes=.true. isn't testable (at least not in clubb_standalone), and I just caught that visually. The cloudy_updraft_frac and cloudy_downdraft_frac fields not being set were only noticable in cam, because we always run with iw_up_in_cloud>0 and iw_down_in_cloud>0 to output stats.editadvance_clubb_core_module.F90editpdf_closure_module.F90clubb_api_module.F9055c6276fbb2a1eb3db01e7b71a7909c22b694d3d1722465051000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMoving pdf_params copying to copyin. This is the data structure that contains pointers, and these pointers will be different on the host and device, so it is bad in theory to copy the structure back to the CPU as it might overwrite cpu memory pointers with gpu memory pointers. In practice though I've seen no problems caused by this, I'm just making this commit preemptively, and it has already been tested with the ECT test. 2024-07-31 17:30:51 -050055c6276fbb2a1eb3db01e7b71a7909c22b694d3dMoving pdf_params copying to copyin. This is the data structure that contains pointers, and these pointers will be different on the host and device, so it is bad in theory to copy the structure back to the CPU as it might overwrite cpu memory pointers with gpu memory pointers. In practice though I've seen no problems caused by this, I'm just making this commit preemptively, and it has already been tested with the ECT test.editclubb_api_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse370http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/370/368http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/368/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break36817fdf631073cfd9d0af7371a8bb7c0bcb064bb7617fdf631073cfd9d0af7371a8bb7c0bcb064bb76refs/remotes/origin/clubb_silhs_devel17fdf631073cfd9d0af7371a8bb7c0bcb064bb7617fdf631073cfd9d0af7371a8bb7c0bcb064bb76refs/remotes/origin/clubb_silhs_devel17fdf631073cfd9d0af7371a8bb7c0bcb064bb7617fdf631073cfd9d0af7371a8bb7c0bcb064bb76refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#368644153428101e3sm_run_gfortran_test #368368false368968FAILURE1721462648178http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/368/advance_xp2_xpyp_module.F9023f82fdc538b5a645dba8762085bfa621791cf471721419124000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduMaking a change to the l_C2_cloud_frac option with advance_xp2_xpyp. Cloud fraction needed to be interpolated to momentum levels for proper use in the code. Since this code change does not change CLUBB's default configuration, results are bit-for-bit for the default configuration. 2024-07-19 14:58:44 -050023f82fdc538b5a645dba8762085bfa621791cf47Making a change to the l_C2_cloud_frac option with advance_xp2_xpyp.editadvance_xp2_xpyp_module.F90advance_clubb_core_module.F90clubb_api_module.F909109926fff1ccf00b6495ec70ae57350d85a32ce1721424813000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bug. qclvar copying is handled by the api, but we were deleting it with an unstructured data statement. I added this due as a fix before thinking qclvar was a local variable, which happened because I mixed up the CLUBB_CAM and CLUBBND_CAM flags. https://github.com/larson-group/cam/issues/175 2024-07-19 15:33:33 -06009109926fff1ccf00b6495ec70ae57350d85a32ceFixing bug. qclvar copying is handled by the api, but we were deleting it with an unstructured data statement. I added this due as a fix before thinking qclvar was a local variable, which happened because I mixed up the CLUBB_CAM and CLUBBND_CAM flags. https://github.com/larson-group/cam/issues/175editadvance_clubb_core_module.F90editclubb_api_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse369http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/369/367http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/367/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3672ff840062349e6f41bf60d02587ea404ed5e6df42ff840062349e6f41bf60d02587ea404ed5e6df4refs/remotes/origin/clubb_silhs_devel2ff840062349e6f41bf60d02587ea404ed5e6df42ff840062349e6f41bf60d02587ea404ed5e6df4refs/remotes/origin/clubb_silhs_devel2ff840062349e6f41bf60d02587ea404ed5e6df42ff840062349e6f41bf60d02587ea404ed5e6df4refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#367491883428101e3sm_run_gfortran_test #367367false367896FAILURE1721376248772http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/367/latin_hypercube_driver_module.F90fd2a66ac11b726371135f2233834e2e87562682c1721277738000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduIn my previous commit, I changed the domain of the maxloc commands in the computation of k_lh_start to check over the arrays from levels 2:nz. However, when that happens, the output will be offset by 1. Consider a situation where the rcm max is at level 2. By being passed 2 through nz only, maxloc will return a value of 1. I needed to add +1 to the output to rectify this issue. The results are BIT_CHANGING. 2024-07-17 23:42:18 -0500fd2a66ac11b726371135f2233834e2e87562682cIn my previous commit, I changed the domain of the maxloc commandseditlatin_hypercube_driver_module.F90stats_clubb_utilities.F90precipitation_fraction.F900df67106e4001e1eda48b4740fe1b065df06cd771721289115000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThis commit brings the stats output from the all cases run with the master branch (using the default configuration) in bit-for-bit agreement with the stats output from all cases run with the clubb_ghost_exorcism branch. Of course, this agreement ignores the ghost level output in the zt files run with the master branch. This commit is technically BIT_CHANGING because it alters a few stats for a couple cases, but does not change results. 2024-07-18 02:51:55 -05000df67106e4001e1eda48b4740fe1b065df06cd77This commit brings the stats output from the all cases run witheditstats_clubb_utilities.F90editprecipitation_fraction.F90pdf_closure_module.F903e891b5d456b4ea869955e73e012cdd21813c1d91721347695000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduCommitting a change that will initialize this set of variables under all circumstances. This change does not affect output except when the New Hybrid PDF is used. In the case of the New Hybrid PDF, the variables F_rt, F_thl, F_rt_min, F_rt_max, F_thl_min, and F_thl_max were never initialized and never set (they are not part of the New Hybrid PDF -- only in the original New PDF), resulting NaN values being output to stat files. 2024-07-18 19:08:15 -05003e891b5d456b4ea869955e73e012cdd21813c1d9Committing a change that will initialize this set of variableseditpdf_closure_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse368http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/368/366http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/366/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break366f3139e197b4e5f48aea7a85689f098f472f4b248f3139e197b4e5f48aea7a85689f098f472f4b248refs/remotes/origin/clubb_silhs_develf3139e197b4e5f48aea7a85689f098f472f4b248f3139e197b4e5f48aea7a85689f098f472f4b248refs/remotes/origin/clubb_silhs_develf3139e197b4e5f48aea7a85689f098f472f4b248f3139e197b4e5f48aea7a85689f098f472f4b248refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#366513153428101e3sm_run_gfortran_test #366366false366818FAILURE1721289849132http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/366/latin_hypercube_driver_module.F906bb6d06fa0a70a779d86161b235282f847ef604e1721242346000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThere were furhter issues found with the k_lh_start code. The code would find that sometimes, the maximum location of rcm in cloud would occur at the ghost level, k = 1, and set that level as k_lh_start for SILHS. This is undesirable for two reasons: 1) k_lh_start should be set around a legimate, "within domain" grid level; and 2) Setting k_lh_start to 1 is unachievable for the ghostless branch of the model, making a match between the master and clubb_ghost_exorcism branhes unattainable. The issue is corrected here by allowing the maxloc function to only search over "in-domain levels" for maximum cloud. The results are BIT_CHANGING. 2024-07-17 13:52:26 -05006bb6d06fa0a70a779d86161b235282f847ef604eThere were furhter issues found with the k_lh_start code.editlatin_hypercube_driver_module.F90advance_clubb_core_module.F90mixing_length.F90advance_helper_module.F908662dc283f8186f9dc900d82a63fbc46abc658511721258040000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRi_zm calc (Part 3) - Moving calculations for Ri_zm out of diagnose_Lscale_from_taus (#1157) CLUBB tocket #1145 BIT_CHANGING for lscale since Ri_zm was not calculated before. 1. mixing_length.F90: - Removed unused input variables from diagnose_Lscale_from_taus: um, vm, exner, p_in_Pa, rtm, thlm, thvm, rcm, saturation_formula, l_brunt_vaisala_freq_moist, l_use_thvm_in_bv_freq, l_modify_limiters_for_cnvg_test; added ddzt_umvm_sqd as input; changed Ri_zm from out to in - Removed unused brunt_vaisala_freq_sqd variables from diagnose_Lscale_from_tau - Removed calculations for Ri_zm and ddzt_umvm_sqd - Fixed some line length issues 2. advance_helper_module.F90 - Removed unused input variables and imports - Fixed some line length issues 3. advance_clubb_core_module.F90 - Added calculations for ddzt_umvm_sqd and Ri_zm - Adjusted subroutine calls - Fixed some line length issues 2024-07-17 18:14:00 -05008662dc283f8186f9dc900d82a63fbc46abc65851Ri_zm calc (Part 3) - Moving calculations for Ri_zm out of diagnose_Lscale_from_taus (#1157)editadvance_clubb_core_module.F90editmixing_length.F90editadvance_helper_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse367http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/367/365http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/365/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3654b08eed0570d755e113f8007fceadc95f4495eaf4b08eed0570d755e113f8007fceadc95f4495eafrefs/remotes/origin/clubb_silhs_devel4b08eed0570d755e113f8007fceadc95f4495eaf4b08eed0570d755e113f8007fceadc95f4495eafrefs/remotes/origin/clubb_silhs_devel4b08eed0570d755e113f8007fceadc95f4495eaf4b08eed0570d755e113f8007fceadc95f4495eafrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#365479953428101e3sm_run_gfortran_test #365365false365746FAILURE1721203449040http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/365/stats_clubb_utilities.F90advance_clubb_core_module.F90fddad9485d30abe6c743a4be0445fdfe3a6a0a2e1721188165000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am committing changes to stats output for cloud_cover, rcm_in_layer, and z_cloud base owing to the gymnastics it takes to avoid the ghost point in calculations. These changes are BIT_CHANGING, but they don't change the answer. 2024-07-16 22:49:25 -0500fddad9485d30abe6c743a4be0445fdfe3a6a0a2eI am committing changes to stats output for cloud_cover, rcm_in_layer,editstats_clubb_utilities.F90editadvance_clubb_core_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse366http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/366/364http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/364/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break364daee4c641d33548494415150753cd8fb1b62e800daee4c641d33548494415150753cd8fb1b62e800refs/remotes/origin/clubb_silhs_develdaee4c641d33548494415150753cd8fb1b62e800daee4c641d33548494415150753cd8fb1b62e800refs/remotes/origin/clubb_silhs_develdaee4c641d33548494415150753cd8fb1b62e800daee4c641d33548494415150753cd8fb1b62e800refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#364500553428101e3sm_run_gfortran_test #364364false364660FAILURE1721030649641http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/364/latin_hypercube_driver_module.F90916b5a9793d042cc969aec6dabc5abbda67f21001720943555000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am updating the SILHS code that calculates k_lh_start to work consistently with ghostless CLUBB. This commit is BIT_CHANGING. 2024-07-14 02:52:35 -0500916b5a9793d042cc969aec6dabc5abbda67f2100I am updating the SILHS code that calculates k_lh_start to workeditlatin_hypercube_driver_module.F90diagnostic_v2_0/CESM_CLUBB_diag_tauspaper.py6c5ff30dd8f71783d1f013db55c99359313759851721023144000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate CESM_CLUBB_diag_tauspaper.py, a specific "ITCZ" is added that lets WP back to its original meaning "warm pool". 2024-07-15 13:59:04 +08006c5ff30dd8f71783d1f013db55c9935931375985Update CESM_CLUBB_diag_tauspaper.py, a specific "ITCZ" is added that lets WP back to its original meaning "warm pool".editdiagnostic_v2_0/CESM_CLUBB_diag_tauspaper.pydiagnostic_v2_0/E3SM_CLUBB_diag.pydaee4c641d33548494415150753cd8fb1b62e8001721023276000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comESM_CLUBB_diag was changed along with CESM_CLUBB_diag, otherwise it always confused us. 2024-07-15 14:01:16 +0800daee4c641d33548494415150753cd8fb1b62e800ESM_CLUBB_diag was changed along with CESM_CLUBB_diag, otherwise it always confused us.editdiagnostic_v2_0/E3SM_CLUBB_diag.pygithttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse365http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/365/363http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/363/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break363c41c1e3f9e700c406950479d82416172e568f487c41c1e3f9e700c406950479d82416172e568f487refs/remotes/origin/clubb_silhs_develc41c1e3f9e700c406950479d82416172e568f487c41c1e3f9e700c406950479d82416172e568f487refs/remotes/origin/clubb_silhs_develc41c1e3f9e700c406950479d82416172e568f487c41c1e3f9e700c406950479d82416172e568f487refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#363474593428101e3sm_run_gfortran_test #363363false363498FAILURE1720771449631http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/363/parameters_tunable.F90c5fc4e56b888f2b322372097522a5695b3b1386f1720755417000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThis code in adj_low_res_nu was using the ghost point when grid_type = 2. This has now been changed to not include the ghost level. This code is BIT_CHANGING. 2024-07-11 22:36:57 -0500c5fc4e56b888f2b322372097522a5695b3b1386fThis code in adj_low_res_nu was using the ghost point wheneditparameters_tunable.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false364http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/364/362http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/362/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break362e0525a5897b8eb3f00defd398aee668adb45d256e0525a5897b8eb3f00defd398aee668adb45d256refs/remotes/origin/clubb_silhs_devele0525a5897b8eb3f00defd398aee668adb45d256e0525a5897b8eb3f00defd398aee668adb45d256refs/remotes/origin/clubb_silhs_devele0525a5897b8eb3f00defd398aee668adb45d256e0525a5897b8eb3f00defd398aee668adb45d256refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#36230966223428101e3sm_run_gfortran_test #362362false362121SUCCESS1719993849035http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/362/mixing_length.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90advance_helper_module.F901af8762fc4b0c31a64535f1cb6689d893d0369261719948922000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRi_zm calc (Part 2) - Move the brunt_vaisala smoothing into calc_brunt_vaisala_freq_sqd (#1156) CLUBB ticket #1145 Includes previous steps: * First step: Move call to calc_bv * Ri_zm calc (Part 1.5) - Adjusted signature of diagnose_Lscale_from_tau #1145 Newest changes: Ri_zm calc (Part 2) - Move brunt_vaisala smoothing into calc_brunt_vaisala_freq_sqd `brunt_vaisala_frq_sqd_smth` is now calculated in subroutine `calc_brunt_vaisala_freq_sqd` and it is now written to disk in `advance_clubb_core` with all the other `brunt_vaisala` variables. Unfortunately, I had to make a couple more changes since moving this calculation into `calc_brunt_vaisala_freq_sqd` meant that any subroutine involved in calling `calc_stability_correction` would need to get `l_modify_limiters_for_cnvg_test` fed in, because `calc_brunt_vaisala_freq_sqd` is also called in `calc_stability_correction`. This commit is BIT_CHANGING since `brunt_vaisala_frq_sqd_smth` used to be all zeros before this change in Lscale mode and now it is actually calculated. BFB in taus code. 2024-07-02 14:35:22 -05001af8762fc4b0c31a64535f1cb6689d893d036926Ri_zm calc (Part 2) - Move the brunt_vaisala smoothing into calc_brunt_vaisala_freq_sqd (#1156)editadvance_clubb_core_module.F90editadvance_helper_module.F90editmixing_length.F90editadvance_xm_wpxp_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse363http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/363/361http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/361/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break36104208f3716fa9a9a8bef3f0b2203d31bbdb51ea504208f3716fa9a9a8bef3f0b2203d31bbdb51ea5refs/remotes/origin/clubb_silhs_devel04208f3716fa9a9a8bef3f0b2203d31bbdb51ea504208f3716fa9a9a8bef3f0b2203d31bbdb51ea5refs/remotes/origin/clubb_silhs_devel04208f3716fa9a9a8bef3f0b2203d31bbdb51ea504208f3716fa9a9a8bef3f0b2203d31bbdb51ea5refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#36137759883428101e3sm_run_gfortran_test #361361false3612365SUCCESS1718957050243http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/361/advance_clubb_core_module.F9096205889b3e27c8f482383f28de8a6dd08d36adb1718884181000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdds blank line so that I can note BIT_CHANGING:5df5fcb3d6c51d6af2e8017d270336eefa75ad3e 2024-06-20 06:49:41 -050096205889b3e27c8f482383f28de8a6dd08d36adbAdds blank line so that I can note BIT_CHANGING:5df5fcb3d6c51d6af2e8017d270336eefa75ad3eeditadvance_clubb_core_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse362http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/362/360http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/360/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break360e862083453c75b8e9456e7f0f19f2c048511ae7be862083453c75b8e9456e7f0f19f2c048511ae7brefs/remotes/origin/clubb_silhs_devele862083453c75b8e9456e7f0f19f2c048511ae7be862083453c75b8e9456e7f0f19f2c048511ae7brefs/remotes/origin/clubb_silhs_devele862083453c75b8e9456e7f0f19f2c048511ae7be862083453c75b8e9456e7f0f19f2c048511ae7brefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#36034116933428101e3sm_run_gfortran_test #360360false3602295SUCCESS1718870645993http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/360/mixing_length.F90advance_clubb_core_module.F90advance_helper_module.F90d5fb86b1bd228c5b17c18f63a17c0a37fead40ae1718832972000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRi zm calc (Part 1) - Combine and move call to calc_brunt_vaisala_freq_sqd (#1154) #1145 Combined call to `calc_brunt_vaisala_freq_sqd` in `advance_clubb_core` for both Lscale and taus code - BITCHANGING Call for taus code was moved out and in front of `diagnose_Lscale_from_tau` call and `zm2zt2zm` smoothing of `thlm` was removed. BITCHANGING for taus code due to removed smoothing. 2024-06-19 16:36:12 -0500d5fb86b1bd228c5b17c18f63a17c0a37fead40aeRi zm calc (Part 1) - Combine and move call to calc_brunt_vaisala_freq_sqd (#1154)editmixing_length.F90editadvance_helper_module.F90editadvance_clubb_core_module.F90advance_clubb_core_module.F90mixing_length.F90323b3445d15537a72479ff1c41c59edd6b74f6461718834177000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRi_zm calc (Part 1.5) - Adjusted signature of diagnose_Lscale_from_tau #1145 (#1155) Ri_zm calc (Part 1.5) - Adjusted signature of diagnose_Lscale_from_tau #1145 2024-06-19 16:56:17 -0500323b3445d15537a72479ff1c41c59edd6b74f646Ri_zm calc (Part 1.5) - Adjusted signature of diagnose_Lscale_from_tau #1145 (#1155)editadvance_clubb_core_module.F90editmixing_length.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse361http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/361/359http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/359/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break359b71ec4e3d49ec0db9f7b9ea41d55440c7cd9d5cbb71ec4e3d49ec0db9f7b9ea41d55440c7cd9d5cbrefs/remotes/origin/clubb_silhs_develb71ec4e3d49ec0db9f7b9ea41d55440c7cd9d5cbb71ec4e3d49ec0db9f7b9ea41d55440c7cd9d5cbrefs/remotes/origin/clubb_silhs_develb71ec4e3d49ec0db9f7b9ea41d55440c7cd9d5cbb71ec4e3d49ec0db9f7b9ea41d55440c7cd9d5cbrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#35927342093428101e3sm_run_gfortran_test #359359false3592141SUCCESS1718438647231http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/359/diagnostic_v2_0/draw_plots_hoz_3D.pydiagnostic_v2_0/draw_hollfiller.pydiagnostic_v2_0/CLUBB_diagnostics_template.htmldiagnostic_v2_0/draw_clubb_skew.pydiagnostic_v2_0/draw_large_scale.pydiagnostic_v2_0/draw_rain.pydiagnostic_v2_0/draw_large_scale_low.pydiagnostic_v2_0/draw_clubb_budget.pydiagnostic_v2_0/draw_clubb_standard.pydiagnostic_v2_0/draw_plots_hoz_2D.pydiagnostic_v2_0/draw_silhs_standard.pydiagnostic_v2_0/draw_e3sm_budget.pydiagnostic_v2_0/CESM_CLUBB_diag_tauspaper.pydiagnostic_v2_0/draw_micro_budget.pyb71ec4e3d49ec0db9f7b9ea41d55440c7cd9d5cb1718361959000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comFlexible settings for PNG resolution have been added. A new parameter PIXEL has been added as per Ben's requirements. this parameter can control the resolution of the PNG, the default value is 1000 in CESM_CLUBB_diag_tauspaper.py. 2024-06-14 18:45:59 +0800b71ec4e3d49ec0db9f7b9ea41d55440c7cd9d5cbFlexible settings for PNG resolution have been added.editdiagnostic_v2_0/draw_e3sm_budget.pyeditdiagnostic_v2_0/draw_plots_hoz_3D.pyadddiagnostic_v2_0/CESM_CLUBB_diag_tauspaper.pyeditdiagnostic_v2_0/draw_large_scale_low.pyeditdiagnostic_v2_0/draw_clubb_budget.pyeditdiagnostic_v2_0/draw_clubb_skew.pyeditdiagnostic_v2_0/CLUBB_diagnostics_template.htmleditdiagnostic_v2_0/draw_large_scale.pyeditdiagnostic_v2_0/draw_hollfiller.pyeditdiagnostic_v2_0/draw_plots_hoz_2D.pyeditdiagnostic_v2_0/draw_clubb_standard.pyeditdiagnostic_v2_0/draw_micro_budget.pyeditdiagnostic_v2_0/draw_silhs_standard.pyeditdiagnostic_v2_0/draw_rain.pygithttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse360http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/360/358http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/358/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3587813f6535d0fe90d43ecd46b77d60363c481ca857813f6535d0fe90d43ecd46b77d60363c481ca85refs/remotes/origin/clubb_silhs_devel7813f6535d0fe90d43ecd46b77d60363c481ca857813f6535d0fe90d43ecd46b77d60363c481ca85refs/remotes/origin/clubb_silhs_devel7813f6535d0fe90d43ecd46b77d60363c481ca857813f6535d0fe90d43ecd46b77d60363c481ca85refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#35827449383428101e3sm_run_gfortran_test #358358false3581933SUCCESS1717574646268http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/358/advance_clubb_core_module.F906ab16812ec6b8e1d0e8e98f5dd02e0794363299b1717567979000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking the only change required to make clubb run with openacc in cam. 2024-06-05 00:12:59 -06006ab16812ec6b8e1d0e8e98f5dd02e0794363299bMaking the only change required to make clubb run with openacc in cam.editadvance_clubb_core_module.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse359http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/359/357http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/357/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3576a299d0bc9918f46941f72e7f0bd625b4d2b6ca16a299d0bc9918f46941f72e7f0bd625b4d2b6ca1refs/remotes/origin/clubb_silhs_devel6a299d0bc9918f46941f72e7f0bd625b4d2b6ca16a299d0bc9918f46941f72e7f0bd625b4d2b6ca1refs/remotes/origin/clubb_silhs_devel6a299d0bc9918f46941f72e7f0bd625b4d2b6ca16a299d0bc9918f46941f72e7f0bd625b4d2b6ca1refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#35727093443428101e3sm_run_gfortran_test #357357false3571867SUCCESS1717488247555http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/357/mt95.F90mt95.f903d2c815522ee350d0dcb01d72877541e8317a5931717450146000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking the f in f90 capital for consistency. 2024-06-03 16:29:06 -05003d2c815522ee350d0dcb01d72877541e8317a593Making the f in f90 capital for consistency.addmt95.F90deletemt95.f90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse358http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/358/356http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/356/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break356150a92682f81315946a444a61d5e55c54edb0301150a92682f81315946a444a61d5e55c54edb0301refs/remotes/origin/clubb_silhs_devel150a92682f81315946a444a61d5e55c54edb0301150a92682f81315946a444a61d5e55c54edb0301refs/remotes/origin/clubb_silhs_devel150a92682f81315946a444a61d5e55c54edb0301150a92682f81315946a444a61d5e55c54edb0301refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#35628805033428101e3sm_run_gfortran_test #356356false3561797SUCCESS1717056250278http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/356/advance_clubb_core_module.F90clubb_api_module.F90advance_xm_wpxp_module.F90advance_helper_module.F9027bcd976257a9e518b3fef5318e1bb964f3fea741717028099000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThe variable rc_coef_zm needed to be passed in and saved from timestep-to-timestep rather than rc_coef. The results of this change are BIT_CHANGING. 2024-05-29 19:14:59 -050027bcd976257a9e518b3fef5318e1bb964f3fea74The variable rc_coef_zm needed to be passed in and saved fromeditadvance_clubb_core_module.F90editclubb_api_module.F90editadvance_helper_module.F90editadvance_xm_wpxp_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false357http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/357/355http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/355/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break35530f3f095deb580365b59b9e99608fd868325fbcf30f3f095deb580365b59b9e99608fd868325fbcfrefs/remotes/origin/clubb_silhs_devel30f3f095deb580365b59b9e99608fd868325fbcf30f3f095deb580365b59b9e99608fd868325fbcfrefs/remotes/origin/clubb_silhs_devel30f3f095deb580365b59b9e99608fd868325fbcf30f3f095deb580365b59b9e99608fd868325fbcfrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#35527598413428101e3sm_run_gfortran_test #355355false3551645SUCCESS1715933108273http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/355/advance_clubb_core_module.F90c7232ab0ff8a01c790b8ae8d7126696eeed84cc61715889108000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduFixing a bug. Does not change default results. 2024-05-16 14:51:48 -0500c7232ab0ff8a01c790b8ae8d7126696eeed84cc6Fixing a bug. Does not change default results.editadvance_clubb_core_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false356http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/356/354http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/354/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3543d2741a79d4df08cd19a91746fa779e3ccd2fc2e3d2741a79d4df08cd19a91746fa779e3ccd2fc2erefs/remotes/origin/clubb_silhs_devel3d2741a79d4df08cd19a91746fa779e3ccd2fc2e3d2741a79d4df08cd19a91746fa779e3ccd2fc2erefs/remotes/origin/clubb_silhs_devel3d2741a79d4df08cd19a91746fa779e3ccd2fc2e3d2741a79d4df08cd19a91746fa779e3ccd2fc2erefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#35427377553428101e3sm_run_gfortran_test #354354false3541579SUCCESS1715846709641http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/354/clubb_api_module.F90advance_xm_wpxp_module.F90805374a14b770257f081e083488dadbf954670441715800905000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing small GPU bug in advance_xm, also fixing a bug with sclrpthvp that's only detectable when were running 1 column on GPUs. 2024-05-15 14:21:45 -0500805374a14b770257f081e083488dadbf95467044Fixing small GPU bug in advance_xm, also fixing a bug with sclrpthvp that's only detectable when were running 1 column on GPUs.editclubb_api_module.F90editadvance_xm_wpxp_module.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse355http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/355/353http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/353/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break353b897c1c06bdea935f42f69f0ba9cd6699792b3ddb897c1c06bdea935f42f69f0ba9cd6699792b3ddrefs/remotes/origin/clubb_silhs_develb897c1c06bdea935f42f69f0ba9cd6699792b3ddb897c1c06bdea935f42f69f0ba9cd6699792b3ddrefs/remotes/origin/clubb_silhs_develb897c1c06bdea935f42f69f0ba9cd6699792b3ddb897c1c06bdea935f42f69f0ba9cd6699792b3ddrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#35328327773428101e3sm_run_gfortran_test #353353false3531505SUCCESS1715673907470http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/353/mixing_length.F900ce993b309b89a592fddf5c7df4d8384d35147231715624439000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.edugr%zm should be used here instead of gr%zt, since these are momentum-level variables being calculated. Results are BIT_CHANGING. 2024-05-13 13:20:39 -05000ce993b309b89a592fddf5c7df4d8384d3514723gr%zm should be used here instead of gr%zt, since these areeditmixing_length.F90advance_clubb_core_module.F90mixing_length.F90880007854a85598da82ccefa4724c4ddbda5f7d61715635045000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThermodynamic-level (zt) values should be used with zt-variable calculations. This commit changes results (but not visibly) for the l_avg_Lscale code, but since this code is not the default in CLUBB, the code remains bit-for-bit since the last commit. 2024-05-13 16:17:25 -0500880007854a85598da82ccefa4724c4ddbda5f7d6Thermodynamic-level (zt) values should be used with zt-variableeditadvance_clubb_core_module.F90editmixing_length.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false354http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/354/352http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/352/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3528c2b02318f728efd334c432958dc0d5a92be6e1d8c2b02318f728efd334c432958dc0d5a92be6e1drefs/remotes/origin/clubb_silhs_devel8c2b02318f728efd334c432958dc0d5a92be6e1d8c2b02318f728efd334c432958dc0d5a92be6e1drefs/remotes/origin/clubb_silhs_devel8c2b02318f728efd334c432958dc0d5a92be6e1d8c2b02318f728efd334c432958dc0d5a92be6e1drefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#35227424633428101e3sm_run_gfortran_test #352352false3521435SUCCESS1714809908565http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/352/advance_xm_wpxp_module.F90243d18ebd39084235f84c52d7ed538639bd23f951714763847000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding extra exclamation to acc statement to comment it out. 2024-05-03 14:17:27 -0500243d18ebd39084235f84c52d7ed538639bd23f95Adding extra exclamation to acc statement to comment it out.editadvance_xm_wpxp_module.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse353http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/353/351http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/351/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break351ed4c6d7921a899d94737ed49a2fc2b564d081f00ed4c6d7921a899d94737ed49a2fc2b564d081f00refs/remotes/origin/clubb_silhs_develed4c6d7921a899d94737ed49a2fc2b564d081f00ed4c6d7921a899d94737ed49a2fc2b564d081f00refs/remotes/origin/clubb_silhs_develed4c6d7921a899d94737ed49a2fc2b564d081f00ed4c6d7921a899d94737ed49a2fc2b564d081f00refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#35128702243428101e3sm_run_gfortran_test #351351false3511365SUCCESS1714723509805http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/351/advance_xm_wpxp_module.F900e6f459a8ca2110f661d78019a1f717ff9b9407a1714680265000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am committing code that effectively ignores the values of certain zt stats at the ghost level by setting them to 0. This is done to allow for bit-for-bitness comparisons between the master branch and the clubb_ghost_exorcism branch. Technically, since zt stat file output at the irrelevant ghost level is changed for some variables, this commit is BIT_CHANGING. Effectively, this commit doesn't change squat in terms of model results. 2024-05-02 15:04:25 -05000e6f459a8ca2110f661d78019a1f717ff9b9407aI am committing code that effectively ignores the values of certaineditadvance_xm_wpxp_module.F90advance_xm_wpxp_module.F904b4adc89f8fe60d9e9f89fadcab3f1f6c94992501714685456000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am moving the advance_xm_wpxp setting of xm(1) = xm(2) from the end of xm_clipping_and_stats to the very end of advance_xm_wpxp, right before the return to advance_clubb_core. The reason I am doing this is the nudging was done after setting xm(1) = xm(2) and would alter the results. This is no longer the case, as setting xm(1) = xm(2) is now being done after nudging. This is being done in advance of removal of the ghost point from CLUBB. This helps ensure a bit-for-bit match between the ghost exorcism branch and the master branch. This commit technically alter fields such as um, vm, um_bt, vm_bt, wpup2, wpvp2, and shear at level 1 only. Thus, this commit is technically BIT_CHANGING. Effectively, once again, this commit doesn't change squat. 2024-05-02 16:30:56 -05004b4adc89f8fe60d9e9f89fadcab3f1f6c9499250I am moving the advance_xm_wpxp setting of xm(1) = xm(2) from theeditadvance_xm_wpxp_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false352http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/352/350http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/350/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break350f85233ca5819e5fff7567dc3b20516c51f6f73c7f85233ca5819e5fff7567dc3b20516c51f6f73c7refs/remotes/origin/clubb_silhs_develf85233ca5819e5fff7567dc3b20516c51f6f73c7f85233ca5819e5fff7567dc3b20516c51f6f73c7refs/remotes/origin/clubb_silhs_develf85233ca5819e5fff7567dc3b20516c51f6f73c7f85233ca5819e5fff7567dc3b20516c51f6f73c7refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#35027913613428101e3sm_run_gfortran_test #350350false3501297SUCCESS1714637106176http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/350/advance_clubb_core_module.F90d6ca5b0e6179de58c7571bea8650e3cd93c3de5e1714537919000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bug. RESOLVED:556370c6406e6b943b88affbe7728a5036b1ba22, this was catchable by using debugging flags, but seems to otherwise cause no issues. Investigating I found that it only clips the below ground level, so that must not have been affecting other levels. This is technically BIT_CHANGING since it resolves an issue. 2024-04-30 23:31:59 -0500d6ca5b0e6179de58c7571bea8650e3cd93c3de5eFixing bug. RESOLVED:556370c6406e6b943b88affbe7728a5036b1ba22, this was catchable by using debugging flags, but seems to otherwise cause no issues. Investigating I found that it only clips the below ground level, so that must not have been affecting other levels. This is technically BIT_CHANGING since it resolves an issue.editadvance_clubb_core_module.F90fill_holes.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90clubb_api_module.F90advance_xm_wpxp_module.F90c2849fa3c750562ffdd5abd6bc9937c081e662261714587276000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking num_draw_points in fill_holes a constant. We were already using this value as a constant everywhere, but passing a constant by argument list makes it difficult/impossible for a compiler to optimize using that constant, unless it does inlining. Now, rather than passing the constant num_hf_draw_points (or sometimes a hardcoded 2) we just use num_hf_draw_points directly from constants_clubb. This massively improves the performance of a loop in fill holes when using nvhpc+omp, which was the motivation for this, but should also improve the performance on CPUs. Everything is BFB. 2024-05-01 13:14:36 -0500c2849fa3c750562ffdd5abd6bc9937c081e66226Making num_draw_points in fill_holes a constant. We were already using this value as a constant everywhere, but passing a constant by argument list makes it difficult/impossible for a compiler to optimize using that constant, unless it does inlining. Now, rather than passing the constant num_hf_draw_points (or sometimes a hardcoded 2) we just use num_hf_draw_points directly from constants_clubb. This massively improves the performance of a loop in fill holes when using nvhpc+omp, which was the motivation for this, but should also improve the performance on CPUs. Everything is BFB.editclubb_api_module.F90editfill_holes.F90editadvance_clubb_core_module.F90editadvance_wp2_wp3_module.F90editadvance_xp2_xpyp_module.F90editadvance_xm_wpxp_module.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse351http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/351/349http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/349/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3492049ef8940dc4719e1a3e21c784eb7f2a48ffdce2049ef8940dc4719e1a3e21c784eb7f2a48ffdcerefs/remotes/origin/clubb_silhs_devel2049ef8940dc4719e1a3e21c784eb7f2a48ffdce2049ef8940dc4719e1a3e21c784eb7f2a48ffdcerefs/remotes/origin/clubb_silhs_devel2049ef8940dc4719e1a3e21c784eb7f2a48ffdce2049ef8940dc4719e1a3e21c784eb7f2a48ffdcerefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#34928434903428101e3sm_run_gfortran_test #349349false3491229SUCCESS1714550707448http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/349/advance_xm_wpxp_module.F9013811b3b0775ce0412d5ca84a1c0e8787e3823f61714471119000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduMoved the ghost-point setting of xm(1) = xm(2) to the last line of the subroutine so this command doesn't get overwritten. This is technically BIT_CHANGING because it alters rtm (and some rtm-related calculations) at the ghost point, but it is not answer changing. This is being done in preparation for ghost point removal. 2024-04-30 04:58:39 -050013811b3b0775ce0412d5ca84a1c0e8787e3823f6Moved the ghost-point setting of xm(1) = xm(2) to the last lineeditadvance_xm_wpxp_module.F90advance_wp2_wp3_module.F90mixing_length.F90advance_xp2_xpyp_module.F90advance_xp3_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90grid_class.F90setup_clubb_pdf_params.F90calc_pressure.F90advance_windm_edsclrm_module.F90advance_helper_module.F906db5d3c85dd296d8ccafe66f5e7e20b241d371881714534975000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comOptional arguments are just best sometimes (#1150) * Adding optional argument to zm2zt/zt2zm to act as threshold. This cuts down on lots of bulk and reduces the chances of breaking the GPU code. All BFB. * Removing TODO * Replacing hardcoded 0.0_core_rknd with zero_threshold 2024-04-30 22:42:55 -05006db5d3c85dd296d8ccafe66f5e7e20b241d37188Optional arguments are just best sometimes (#1150)editgrid_class.F90editadvance_xp3_module.F90editadvance_wp2_wp3_module.F90editadvance_clubb_core_module.F90editadvance_xp2_xpyp_module.F90editadvance_helper_module.F90editcalc_pressure.F90editmixing_length.F90editadvance_windm_edsclrm_module.F90editadvance_xm_wpxp_module.F90editsetup_clubb_pdf_params.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse350http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/350/348http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/348/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break348a74d0bd85a4753da87a14f2f80caea0dd2c887daa74d0bd85a4753da87a14f2f80caea0dd2c887darefs/remotes/origin/clubb_silhs_devela74d0bd85a4753da87a14f2f80caea0dd2c887daa74d0bd85a4753da87a14f2f80caea0dd2c887darefs/remotes/origin/clubb_silhs_devela74d0bd85a4753da87a14f2f80caea0dd2c887daa74d0bd85a4753da87a14f2f80caea0dd2c887darefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#34827840453428101e3sm_run_gfortran_test #348348false3481112SUCCESS1714205108251http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/348/grid_class.F90f3b2d7a6a63ceea30a960b27be61c18ea0279b711713916476000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI'm changing the way ddzt handles the derivative over momentum level 1. Previously, it was based on the differential between the ghost point and the first level above the surface. Now, the value of the derivative at momentum level 2 is simply being dropped down to momentum level 1. This is being done in advance of ghost point removal. The results of this commit are BIT_CHANGING. 2024-04-23 18:54:36 -0500f3b2d7a6a63ceea30a960b27be61c18ea0279b71I'm changing the way ddzt handles the derivative over momentum level 1.editgrid_class.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false349http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/349/347http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/347/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break347951d706be64fe0cdd8db86b6b26cb3b14266f052951d706be64fe0cdd8db86b6b26cb3b14266f052refs/remotes/origin/clubb_silhs_devel951d706be64fe0cdd8db86b6b26cb3b14266f052951d706be64fe0cdd8db86b6b26cb3b14266f052refs/remotes/origin/clubb_silhs_devel951d706be64fe0cdd8db86b6b26cb3b14266f052951d706be64fe0cdd8db86b6b26cb3b14266f052refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#34727947853428101e3sm_run_gfortran_test #347347false3471044SUCCESS1713600249508http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/347/grid_class.F9015e15c30d8454b66017207782a4e949282420a2c1713562695000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduChanging the linear interpolation in the zt2zm function at momentum level 1 from an interpolation between the ghost point and the first level above the surface to simply a "drop down" of the value found at the first level above the surface. This is being done ahead of the removal of the ghost point from the model. Results of this change are BIT_CHANGING. 2024-04-19 16:38:15 -050015e15c30d8454b66017207782a4e949282420a2cChanging the linear interpolation in the zt2zm function at momentumeditgrid_class.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false348http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/348/346http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/346/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break346817a9cbb4ad7254fca2c2948c2d16f4e0ced8476817a9cbb4ad7254fca2c2948c2d16f4e0ced8476refs/remotes/origin/clubb_silhs_devel817a9cbb4ad7254fca2c2948c2d16f4e0ced8476817a9cbb4ad7254fca2c2948c2d16f4e0ced8476refs/remotes/origin/clubb_silhs_devel817a9cbb4ad7254fca2c2948c2d16f4e0ced8476817a9cbb4ad7254fca2c2948c2d16f4e0ced8476refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#34628251243428101e3sm_run_gfortran_test #346346false346976SUCCESS1713513845946http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/346/mixing_length.F90advance_xp2_xpyp_module.F90advance_xp3_module.F90advance_clubb_core_module.F90setup_clubb_pdf_params.F90calc_pressure.F90advance_helper_module.F901a044ef468ede907dbb651c69bef76e264906b4b1713448035000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduCommitting some thresholding around positive-definite fields after a zt2zm statement. This commit does not change the results in our CLUBB standalone cases. 2024-04-18 08:47:15 -05001a044ef468ede907dbb651c69bef76e264906b4bCommitting some thresholding around positive-definite fields aftereditsetup_clubb_pdf_params.F90editmixing_length.F90editcalc_pressure.F90editadvance_xp3_module.F90editadvance_helper_module.F90editadvance_clubb_core_module.F90editadvance_xp2_xpyp_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false347http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/347/345http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/345/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3450eda6c6b0023f5196912c486c53328b002ea65770eda6c6b0023f5196912c486c53328b002ea6577refs/remotes/origin/clubb_silhs_devel0eda6c6b0023f5196912c486c53328b002ea65770eda6c6b0023f5196912c486c53328b002ea6577refs/remotes/origin/clubb_silhs_devel0eda6c6b0023f5196912c486c53328b002ea65770eda6c6b0023f5196912c486c53328b002ea6577refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#34528118473428101e3sm_run_gfortran_test #345345false345908SUCCESS1713081849156http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/345/mono_flux_limiter.F90a9608e5509c2494c9805c0f6a754f254c5f20c7e1713021941000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am committing a stats change to the ghost point values of zt stats output variables found in the monotonic flux limiter. These values are all being set simply to 0 at the ghost point for purposes of providing an easy comparison to stats output files from the clubb_ghost_exorcism branch. The code change is not at all answer changing. However, it is technically BIT_CHANGING. 2024-04-13 10:25:41 -0500a9608e5509c2494c9805c0f6a754f254c5f20c7eI am committing a stats change to the ghost point values of zteditmono_flux_limiter.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false346http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/346/344http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/344/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break344652df06ecc91386add858de651dfdc280a061e23652df06ecc91386add858de651dfdc280a061e23refs/remotes/origin/clubb_silhs_devel652df06ecc91386add858de651dfdc280a061e23652df06ecc91386add858de651dfdc280a061e23refs/remotes/origin/clubb_silhs_devel652df06ecc91386add858de651dfdc280a061e23652df06ecc91386add858de651dfdc280a061e23refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#34428395513428101e3sm_run_gfortran_test #344344false344800SUCCESS1712909046753http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/344/advance_xm_wpxp_module.F9004935f95e72f2d182d6717d69c9e950ad3d387131712811418000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThis commit is being made to keep the stats zt output from the master branch inline with the output from the clubb_ghost_exorcism branch. In short, the only change is that the value of a couple of inputs relative to wpxp turbulent advection from thermodynamic level 1 are set to 0 for stats output in order to keep the master and ghost exorcism branches bit-for-bit with each other. The output at those levels are not used in any calculations and are unnecessary. However, this change is technically BIT_CHANGING. 2024-04-10 23:56:58 -050004935f95e72f2d182d6717d69c9e950ad3d38713This commit is being made to keep the stats zt output from theeditadvance_xm_wpxp_module.F90advance_helper_module.F9076244e00c736bd5bbc29f55e9fc41095e01070541712890626000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am committing a bug fix to the code that calculates mixed Brunt Vaisala frequency. The variable ice_supersat_frac was used directly in calculations that are supposed to take place on a momentum level. The fix is to interpolated ice_supersat_frac to momentum levels before use. This commit is BIT_CHANGING. 2024-04-11 21:57:06 -050076244e00c736bd5bbc29f55e9fc41095e0107054I am committing a bug fix to the code that calculates mixed Brunteditadvance_helper_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false345http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/345/343http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/343/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break34378d63fb15c65b0b70f0c537b44e3f87ec335361b78d63fb15c65b0b70f0c537b44e3f87ec335361brefs/remotes/origin/clubb_silhs_devel78d63fb15c65b0b70f0c537b44e3f87ec335361b78d63fb15c65b0b70f0c537b44e3f87ec335361brefs/remotes/origin/clubb_silhs_devel78d63fb15c65b0b70f0c537b44e3f87ec335361b78d63fb15c65b0b70f0c537b44e3f87ec335361brefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#34328761163428101e3sm_run_gfortran_test #343343false343730SUCCESS1712822648157http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/343/advance_xm_wpxp_module.F9009e6e7258c51f674efc6aefc0285458f1e74a2ce1712762923000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduWhile it doesn't affect results, I fixed what appears to be an obvious bug in advance_xm_wpxp. If everything is at a singular zm level, the referenced height shouldn't be gr%zt, but rather gr%zm. 2024-04-10 10:28:43 -050009e6e7258c51f674efc6aefc0285458f1e74a2ceWhile it doesn't affect results, I fixed what appears to be aneditadvance_xm_wpxp_module.F90advance_xm_wpxp_module.F905694aa6f6ccaca0ba89e4c4a54119edfbc05ed4b1712768355000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am updating the loop in subroutine diagnose_xpwp so that it doesn't loop over the model upper or lower boundaries. Calculations at those levels are irrelevant to the results, and their inclusion causes bitness differences between the master and clubb_ghost_exorcism branches. Since this code change causes differences in the zm stats file at the upper and lower boundaries for a few fields, this commit is technically BIT_CHANGING, although it should be noted that it does not change the simulation results. 2024-04-10 11:59:15 -05005694aa6f6ccaca0ba89e4c4a54119edfbc05ed4bI am updating the loop in subroutine diagnose_xpwp so that it doesn'teditadvance_xm_wpxp_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false344http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/344/342http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/342/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break34208ebf7b30de887e078b8e812c4cbe2f8acb842df08ebf7b30de887e078b8e812c4cbe2f8acb842dfrefs/remotes/origin/clubb_silhs_devel08ebf7b30de887e078b8e812c4cbe2f8acb842df08ebf7b30de887e078b8e812c4cbe2f8acb842dfrefs/remotes/origin/clubb_silhs_devel08ebf7b30de887e078b8e812c4cbe2f8acb842df08ebf7b30de887e078b8e812c4cbe2f8acb842dfrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#34228185793428101e3sm_run_gfortran_test #342342false342622SUCCESS1712477049342http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/342/advance_windm_edsclrm_module.F9079a203f9281c29c1f249395c0cd9beb28851684f1712412930000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduIt was discovered that the location where the ghost point values of um and vm were set equal to their respective values at the first thermodynamic level above the surface was not ideal. Their assignment occurred before the love nudge (l_uv_nudge). Then, the love nudge came along and altered their values so that um(1) no longer equaled um(2) -- and analogous for vm(1) and vm(2) -- for a half dozen cases. In addition to making the code inconsistent, it also caused bit-for-bitness differences between the master and clubb_ghost_exorcism branches. For those reasons, this BIT_CHANGING commit is being made. 2024-04-06 09:15:30 -050079a203f9281c29c1f249395c0cd9beb28851684fIt was discovered that the location where the ghost point valueseditadvance_windm_edsclrm_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false343http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/343/341http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/341/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break341ea8395f7c70bfd95eddb22be9fb66eceb2360377ea8395f7c70bfd95eddb22be9fb66eceb2360377refs/remotes/origin/clubb_silhs_develea8395f7c70bfd95eddb22be9fb66eceb2360377ea8395f7c70bfd95eddb22be9fb66eceb2360377refs/remotes/origin/clubb_silhs_develea8395f7c70bfd95eddb22be9fb66eceb2360377ea8395f7c70bfd95eddb22be9fb66eceb2360377refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#34127506403428101e3sm_run_gfortran_test #341341false341552SUCCESS1712390648542http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/341/advance_xp2_xpyp_module.F909e61ef088724b119d7c7f61a21b4c3d306058bcf1712297060000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAt the ghost point below the surface, which does not matter in the calculations, a value of 0 is now being entered for thermodynamic-level output stats coef_wprtp2_implicit, term_wprtp2_explicit, etc. Why would we do this? The answer is "Why Not??!!!!" This is being done to keep the trunk results bit-for-bit with the clubb_ghost_exorcism branch, which is no longer loops over the ghost level below the surface in the region of code where these stats are recorded. In terms of the master, this commit is technically BIT_CHANGING. However, only for these 6 output terms at the ghost point. 2024-04-05 01:04:20 -05009e61ef088724b119d7c7f61a21b4c3d306058bcfAt the ghost point below the surface, which does not matter ineditadvance_xp2_xpyp_module.F90advance_windm_edsclrm_module.F9068d7df96e0daefd601d9649c886f68401a780ba11712376324000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThe code that advances um and vm when l_predict_upwp_vpwp is turned off (as found in advance_windm_edsclrm) was accessing the ghost point in one spot. I rewrote it in the exact way the code in the clubb_ghost_exorcism branch is written so that it makes the same calculation without referencing the ghost point. I also rewrote a couple stats by outputting a value of 0 at the ghost point to maintain stat consistency between the master and the ghost exorcism branch. This commit is BIT_CHANGING, but only when the l_predict_upwp_vpwp flag is set to false (which is not the case by default). 2024-04-05 23:05:24 -050068d7df96e0daefd601d9649c886f68401a780ba1The code that advances um and vm when l_predict_upwp_vpwp is turned offeditadvance_windm_edsclrm_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false342http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/342/340http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/340/Started by user admincarsonadmin75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break340f53ec9c1686e7a2bd01a06b11c96150bf899f2eff53ec9c1686e7a2bd01a06b11c96150bf899f2efrefs/remotes/origin/clubb_silhs_develf53ec9c1686e7a2bd01a06b11c96150bf899f2eff53ec9c1686e7a2bd01a06b11c96150bf899f2efrefs/remotes/origin/clubb_silhs_develf53ec9c1686e7a2bd01a06b11c96150bf899f2eff53ec9c1686e7a2bd01a06b11c96150bf899f2efrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#34028246433428101e3sm_run_gfortran_test #340340false340480SUCCESS1712083804459http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/340/components/eam/src/physics/cam/clubb_intr.F90components/eam/src/physics/cam/subcol_SILHS.F90f53ec9c1686e7a2bd01a06b11c96150bf899f2ef1712083783000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking compatible with latest clubb changes. 2024-04-02 13:49:43 -0500f53ec9c1686e7a2bd01a06b11c96150bf899f2efMaking compatible with latest clubb changes.editcomponents/eam/src/physics/cam/clubb_intr.F90editcomponents/eam/src/physics/cam/subcol_SILHS.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse341http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/341/339http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/339/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3399f9da72ca37020a2f4d27653ff25e466e0fad6ff9f9da72ca37020a2f4d27653ff25e466e0fad6ffrefs/remotes/origin/clubb_silhs_devel9f9da72ca37020a2f4d27653ff25e466e0fad6ff9f9da72ca37020a2f4d27653ff25e466e0fad6ffrefs/remotes/origin/clubb_silhs_devel9f9da72ca37020a2f4d27653ff25e466e0fad6ff9f9da72ca37020a2f4d27653ff25e466e0fad6ffrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#3396711743428101e3sm_run_gfortran_test #339339false339402FAILURE1712045049367http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/339/advance_xm_wpxp_module.F90a39122dbb717c71138d553a1cf1f8cfaa7670d0b1712000028000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bug with C6 parameters, see https://github.com/larson-group/clubb/pull/1147. This is technically BIT_CHANGING, but only when C6thl != C6thlb and l_diag_Lscale_from_tau=.false. 2024-04-01 14:33:48 -0500a39122dbb717c71138d553a1cf1f8cfaa7670d0bFixing bug with C6 parameters, see https://github.com/larson-group/clubb/pull/1147. This is technically BIT_CHANGING, but only when C6thl != C6thlb and l_diag_Lscale_from_tau=.false.editadvance_xm_wpxp_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse340http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/340/338http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/338/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3382f759f5135da6da3a260d6a54bec77e5d5a73aff2f759f5135da6da3a260d6a54bec77e5d5a73affrefs/remotes/origin/clubb_silhs_devel2f759f5135da6da3a260d6a54bec77e5d5a73aff2f759f5135da6da3a260d6a54bec77e5d5a73affrefs/remotes/origin/clubb_silhs_devel2f759f5135da6da3a260d6a54bec77e5d5a73aff2f759f5135da6da3a260d6a54bec77e5d5a73affrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#3386718133428101e3sm_run_gfortran_test #338338false338320FAILURE1711958650730http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/338/clip_explicit.F90clubb_api_module.F90advance_xm_wpxp_module.F90parameters_tunable.F90new_pdf_main.F90advance_helper_module.F90mixing_length.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90pdf_closure_module.F90Skx_module.F90adg1_adg2_3d_luhar_pdf.F90new_hybrid_pdf_main.F90sfc_varnce_module.F90215f23ff2481515749a198c29db74d1005114b751711925174000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comPutting ngrdcol in clubb_params (#1147) * Initial changes to make clubb_params have an ngrdcol dimension. All BFB on CPU and GPU. * pdf_closure done * pdf_closure missed changes * calc_Lscale_directly changes and removed accidentally added files * advance_xp2_xpyp done * Missed file * Added space here because the addition of this line in the last commit is to prevent Ri_zm from being uninitialized when using l_diag_Lscale_from_tau=.false. * advance_wp2_wp3 done * advance_xm_wpxp done * Fixed bugs found by checking l_modify_limiters_for_cnvg_test=.true. * Fixed bug found by checking l_diffuse_rtm_and_thlm and l_stability_correct_Kh_N2_zm * Removing slightly redundant logic * Swapping back order of l_gamma_skw if statements. I'm not sure why I swapped them in the first place. 2024-03-31 17:46:14 -0500215f23ff2481515749a198c29db74d1005114b75Putting ngrdcol in clubb_params (#1147)editnew_hybrid_pdf_main.F90editpdf_closure_module.F90editclip_explicit.F90editparameters_tunable.F90editadg1_adg2_3d_luhar_pdf.F90editmixing_length.F90editadvance_xp2_xpyp_module.F90editclubb_api_module.F90editadvance_wp2_wp3_module.F90editadvance_xm_wpxp_module.F90editsfc_varnce_module.F90editSkx_module.F90editnew_pdf_main.F90editadvance_helper_module.F90editadvance_clubb_core_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse339http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/339/337http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/337/Started by user admincarsonadmin75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3374807c7bebd92c752352573a381b61519dcd9e2654807c7bebd92c752352573a381b61519dcd9e265refs/remotes/origin/clubb_silhs_devel4807c7bebd92c752352573a381b61519dcd9e2654807c7bebd92c752352573a381b61519dcd9e265refs/remotes/origin/clubb_silhs_devel4807c7bebd92c752352573a381b61519dcd9e2654807c7bebd92c752352573a381b61519dcd9e265refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#33727553463428101e3sm_run_gfortran_test #337337false337304SUCCESS1711771671526http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/337/cime_config/machines/config_machines.xmljenkins_tests/e3sm_ne4_silhs_run_gfortran_test/Jenkinsfilejenkins_tests/e3sm_run_gfortran_test/Jenkinsfilecime_config/machines/config_compilers.xml4807c7bebd92c752352573a381b61519dcd9e2651711771663000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduWe need to cherry-pick one commit to remove a polymorphic warning for gcc-10 and beyond, but also can't update the whole submodule. see https://github.com/larson-group/e3sm/issues/46\#issuecomment-1004408975 2024-03-29 23:07:43 -05004807c7bebd92c752352573a381b61519dcd9e265We need to cherry-pick one commit to remove a polymorphic warning for gcc-10 and beyond, but also can't update the whole submodule. see https://github.com/larson-group/e3sm/issues/46\#issuecomment-1004408975editcime_config/machines/config_machines.xmleditjenkins_tests/e3sm_run_gfortran_test/Jenkinsfileeditjenkins_tests/e3sm_ne4_silhs_run_gfortran_test/Jenkinsfileeditcime_config/machines/config_compilers.xmlgithttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse338http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/338/336http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/336/Started by user admincarsonadmin75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break33695b5b81dbee4ea42512a18338eecbeeb1ce2ca4095b5b81dbee4ea42512a18338eecbeeb1ce2ca40refs/remotes/origin/clubb_silhs_devel95b5b81dbee4ea42512a18338eecbeeb1ce2ca4095b5b81dbee4ea42512a18338eecbeeb1ce2ca40refs/remotes/origin/clubb_silhs_devel95b5b81dbee4ea42512a18338eecbeeb1ce2ca4095b5b81dbee4ea42512a18338eecbeeb1ce2ca40refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#3365696773428101e3sm_run_gfortran_test #336336false336301FAILURE1711763285822http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/336/cime_config/machines/config_compilers.xml95b5b81dbee4ea42512a18338eecbeeb1ce2ca401711763253000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking e3sm not reliant on gcc-8 by adding -fallow-argument-mismatch to fflags 2024-03-29 20:47:33 -050095b5b81dbee4ea42512a18338eecbeeb1ce2ca40Making e3sm not reliant on gcc-8 by adding -fallow-argument-mismatch to fflagseditcime_config/machines/config_compilers.xmlgithttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse337http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/337/335http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/335/Started by user admincarsonadmin75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break335bb0d45671cf02cb8be884ecd20c2b1654b642f57bb0d45671cf02cb8be884ecd20c2b1654b642f57refs/remotes/origin/clubb_silhs_develbb0d45671cf02cb8be884ecd20c2b1654b642f57bb0d45671cf02cb8be884ecd20c2b1654b642f57refs/remotes/origin/clubb_silhs_develbb0d45671cf02cb8be884ecd20c2b1654b642f57bb0d45671cf02cb8be884ecd20c2b1654b642f57refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#335795093428101e3sm_run_gfortran_test #335335false335286FAILURE1711755502947http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/335/false336http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/336/334http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/334/Started by user admincarsonadmin75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break334bb0d45671cf02cb8be884ecd20c2b1654b642f57bb0d45671cf02cb8be884ecd20c2b1654b642f57refs/remotes/origin/clubb_silhs_develbb0d45671cf02cb8be884ecd20c2b1654b642f57bb0d45671cf02cb8be884ecd20c2b1654b642f57refs/remotes/origin/clubb_silhs_develbb0d45671cf02cb8be884ecd20c2b1654b642f57bb0d45671cf02cb8be884ecd20c2b1654b642f57refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#3342880383428101e3sm_run_gfortran_test #334334false33464FAILURE1711685920128http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/334/false335http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/335/333http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/333/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break333bb0d45671cf02cb8be884ecd20c2b1654b642f57bb0d45671cf02cb8be884ecd20c2b1654b642f57refs/remotes/origin/clubb_silhs_develbb0d45671cf02cb8be884ecd20c2b1654b642f57bb0d45671cf02cb8be884ecd20c2b1654b642f57refs/remotes/origin/clubb_silhs_develbb0d45671cf02cb8be884ecd20c2b1654b642f57bb0d45671cf02cb8be884ecd20c2b1654b642f57refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#33326570533428101e3sm_run_gfortran_test #333333false33329290SUCCESS1711353848031http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/333/fill_holes.F902211b4ac393092503821aab54176124651ab4ba81711302893000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding sum part to comment 2024-03-24 12:54:53 -05002211b4ac393092503821aab54176124651ab4ba8Adding sum part to commenteditfill_holes.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse334http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/334/332http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/332/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break332c2a7f83cd0e2d5cc810ff1e7cd6525a739aedbfbc2a7f83cd0e2d5cc810ff1e7cd6525a739aedbfbrefs/remotes/origin/clubb_silhs_develc2a7f83cd0e2d5cc810ff1e7cd6525a739aedbfbc2a7f83cd0e2d5cc810ff1e7cd6525a739aedbfbrefs/remotes/origin/clubb_silhs_develc2a7f83cd0e2d5cc810ff1e7cd6525a739aedbfbc2a7f83cd0e2d5cc810ff1e7cd6525a739aedbfbrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#33226769513428101e3sm_run_gfortran_test #332332false33229222SUCCESS1711181047309http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/332/fill_holes.F90b3370acbc97df9a7f10cd183dbc0bb0d68036c491711137584000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding comment to explain unusual code choice. 2024-03-22 14:59:44 -0500b3370acbc97df9a7f10cd183dbc0bb0d68036c49Adding comment to explain unusual code choice.editfill_holes.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse333http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/333/331http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/331/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3318950f92fd1629bde18bdc205fb3babeccf3c8c828950f92fd1629bde18bdc205fb3babeccf3c8c82refs/remotes/origin/clubb_silhs_devel8950f92fd1629bde18bdc205fb3babeccf3c8c828950f92fd1629bde18bdc205fb3babeccf3c8c82refs/remotes/origin/clubb_silhs_devel8950f92fd1629bde18bdc205fb3babeccf3c8c828950f92fd1629bde18bdc205fb3babeccf3c8c82refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#33126533993428101e3sm_run_gfortran_test #331331false33129154SUCCESS1710835446985http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/331/fill_holes.F90advance_wp2_wp3_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90mono_flux_limiter.F90e46bd6ab09c336755a83f2ea26efbc6e066415641710806789000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comOpenMP Optimizations (#1146) * Small changes to improve omp performance. * Some more small changes to help openmp * Adhering to standards a little better by specifying _core_rknd 2024-03-18 19:06:29 -0500e46bd6ab09c336755a83f2ea26efbc6e06641564OpenMP Optimizations (#1146)editmono_flux_limiter.F90editadvance_xm_wpxp_module.F90editadvance_clubb_core_module.F90editfill_holes.F90editadvance_wp2_wp3_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse332http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/332/330http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/330/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3302f5c4f6d9bca1242aaef22675cecc4ebcd4bd6b72f5c4f6d9bca1242aaef22675cecc4ebcd4bd6b7refs/remotes/origin/clubb_silhs_devel2f5c4f6d9bca1242aaef22675cecc4ebcd4bd6b72f5c4f6d9bca1242aaef22675cecc4ebcd4bd6b7refs/remotes/origin/clubb_silhs_devel2f5c4f6d9bca1242aaef22675cecc4ebcd4bd6b72f5c4f6d9bca1242aaef22675cecc4ebcd4bd6b7refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#33026686303428101e3sm_run_gfortran_test #330330false33029046SUCCESS1709715847860http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/330/advance_clubb_core_module.F9009d7b40ad3f996bb73b0f8689947f758705f53111709675532000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemoves comment about Numerical Recipes 2024-03-05 15:52:12 -060009d7b40ad3f996bb73b0f8689947f758705f5311Removes comment about Numerical Recipeseditadvance_clubb_core_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse331http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/331/329http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/329/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break329a387f7eadbee97a5fa84476498eaf27257d7952ba387f7eadbee97a5fa84476498eaf27257d7952brefs/remotes/origin/clubb_silhs_devela387f7eadbee97a5fa84476498eaf27257d7952ba387f7eadbee97a5fa84476498eaf27257d7952brefs/remotes/origin/clubb_silhs_devela387f7eadbee97a5fa84476498eaf27257d7952ba387f7eadbee97a5fa84476498eaf27257d7952brefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#32926629083428101e3sm_run_gfortran_test #329329false32928976SUCCESS1708074248950http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/329/mixing_length.F90advance_clubb_core_module.F90model_flags.F90clubb_api_module.F90constants_clubb.F90pdf_closure_module.F90sfc_varnce_module.F90advance_helper_module.F90mono_flux_limiter.F904e3c5f2e0080925f0890ec6e36446f5dc1a67d851708052285000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comSmall acc tweaks (#1144) * Removing unneccesary acc declare statements. * Removing use of acc routine in favor of new 1D array routine for smooth_max. * The new tmp_calc_ngrdcol should be copied regardless of flag * tmp_calc_ngrdcol also needs to be deleted unconditionally. * Making separate conditional acc copy for edsclrdim variables. * Adding ifdefs around prints inside of openacc kernel * Making erf_cache and exp_cache scalars, there was no need for them to be arrays. * Making update host statements with sclr_dim or edsclr_dim conditional. Without these we get runtime errors with cray+openacc * Removed files 2024-02-15 20:58:05 -06004e3c5f2e0080925f0890ec6e36446f5dc1a67d85Small acc tweaks (#1144)editadvance_helper_module.F90editconstants_clubb.F90editmono_flux_limiter.F90editclubb_api_module.F90editsfc_varnce_module.F90editmixing_length.F90editmodel_flags.F90editpdf_closure_module.F90editadvance_clubb_core_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse330http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/330/328http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/328/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break328ea8cd23e9a18d970363beb9198bbbd8f7b60a92dea8cd23e9a18d970363beb9198bbbd8f7b60a92drefs/remotes/origin/clubb_silhs_develea8cd23e9a18d970363beb9198bbbd8f7b60a92dea8cd23e9a18d970363beb9198bbbd8f7b60a92drefs/remotes/origin/clubb_silhs_develea8cd23e9a18d970363beb9198bbbd8f7b60a92dea8cd23e9a18d970363beb9198bbbd8f7b60a92drefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#32826853473428101e3sm_run_gfortran_test #328328false32828908SUCCESS1707987848889http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/328/clubb_api_module.F909719713bc9b25dda36e2a076736d36d8052eb2a71707948133000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd blank line in order to trigger Jenkins tests for CAM In particular, Brian Griffin's code change from 7 Feb 2024, BIT_CHANGING:595e2c13024c1e913815d56ae724823a82bddc03 changes answers when using l_diag_Lscale_from_tau=.false. This code change was brought into the CAM repo in this commit: BIT_CHANGING:d275ac17f3e53d65641c3210df33ce0fad4e5aef 2024-02-14 16:02:13 -06009719713bc9b25dda36e2a076736d36d8052eb2a7Add blank line in order to trigger Jenkins tests for CAMeditclubb_api_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse329http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/329/327http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/327/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3278e57994dfde7bac6cced45b0561a5b46d4741b928e57994dfde7bac6cced45b0561a5b46d4741b92refs/remotes/origin/clubb_silhs_devel8e57994dfde7bac6cced45b0561a5b46d4741b928e57994dfde7bac6cced45b0561a5b46d4741b92refs/remotes/origin/clubb_silhs_devel8e57994dfde7bac6cced45b0561a5b46d4741b928e57994dfde7bac6cced45b0561a5b46d4741b92refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#32726758483428101e3sm_run_gfortran_test #327327false32728828SUCCESS1707901449382http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/327/stats_zt_module.F907533e5fc4247ea19f60309050610a3f35229436a1707839985000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@users.noreply.github.comfixing bug, name of wm_zt was left as "wm" 2024-02-13 09:59:45 -06007533e5fc4247ea19f60309050610a3f35229436afixing bug, name of wm_zt was left as "wm"editstats_zt_module.F90githttp://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonfalse328http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/328/326http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/326/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3264a6b995562fe4cd0d5433068d6b222bd792321024a6b995562fe4cd0d5433068d6b222bd79232102refs/remotes/origin/clubb_silhs_devel4a6b995562fe4cd0d5433068d6b222bd792321024a6b995562fe4cd0d5433068d6b222bd79232102refs/remotes/origin/clubb_silhs_devel4a6b995562fe4cd0d5433068d6b222bd792321024a6b995562fe4cd0d5433068d6b222bd79232102refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#32626643273428101e3sm_run_gfortran_test #326326false32628752SUCCESS1707469447772http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/326/model_flags.F90aa0b5742c1ecb87b896f03ad526ad9483bcc707d1707410339000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comadding equals sign cuz I've had it up to here with this typo! 2024-02-08 09:38:59 -0700aa0b5742c1ecb87b896f03ad526ad9483bcc707dadding equals sign cuz I've had it up to here with this typo!editmodel_flags.F90githttp://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensfalse327http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/327/325http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/325/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3254fa8c2837b55fa28c8376b739c2737f12bc6e6e14fa8c2837b55fa28c8376b739c2737f12bc6e6e1refs/remotes/origin/clubb_silhs_devel4fa8c2837b55fa28c8376b739c2737f12bc6e6e14fa8c2837b55fa28c8376b739c2737f12bc6e6e1refs/remotes/origin/clubb_silhs_devel4fa8c2837b55fa28c8376b739c2737f12bc6e6e14fa8c2837b55fa28c8376b739c2737f12bc6e6e1refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#32526594413428101e3sm_run_gfortran_test #325325false32528682SUCCESS1707383050414http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/325/advance_clubb_core_module.F90advance_xm_wpxp_module.F90advance_helper_module.F90f66e6de3fd5790a95a3e2ac792e58129985540fe1707345359000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduFixing a bug where the Lscale used in calculating the damping coefficient in advance_xm_wpxp_module.F90 should be Lscale_zm, since the term is calculated on momentum grid levels. Along the way, I found out that I could streamline the code by passing in the value of Lscale_zm that was already calculated (interpolated from Lscale) in advance_clubb_core. This value could be passed into both advance_xm_wpxp and calc_stability_correction, and then fed down. This results of this code change are bit-for-bit identical with the previous revision, most likely because this code only matters when certain flags are flipped that are not used by default. 2024-02-07 16:35:59 -0600f66e6de3fd5790a95a3e2ac792e58129985540feFixing a bug where the Lscale used in calculating the dampingeditadvance_helper_module.F90editadvance_xm_wpxp_module.F90editadvance_clubb_core_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false326http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/326/324http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/324/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break324f36f51657d9965f7fa28d3d98c99874c67846bacf36f51657d9965f7fa28d3d98c99874c67846bacrefs/remotes/origin/clubb_silhs_develf36f51657d9965f7fa28d3d98c99874c67846bacf36f51657d9965f7fa28d3d98c99874c67846bacrefs/remotes/origin/clubb_silhs_develf36f51657d9965f7fa28d3d98c99874c67846bacf36f51657d9965f7fa28d3d98c99874c67846bacrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#32428882173428101e3sm_run_gfortran_test #324324false32428520SUCCESS1706778250450http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/324/model_flags.F90d6d044841a3c4fca653f4822509f1f9ceacfd0eb1706649109000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduThis is (amazingly) BIT_CHANGING. The differences are due to some compiler optimizations, see https://github.com/larson-group/clubb/pull/1133\#issuecomment-1865156979. 2024-01-30 15:11:49 -0600d6d044841a3c4fca653f4822509f1f9ceacfd0ebThis is (amazingly) BIT_CHANGING. The differences are due to some compiler optimizations, see https://github.com/larson-group/clubb/pull/1133\#issuecomment-1865156979.editmodel_flags.F90input_names.F9089925a4e642c7993be58226934ff9a3cdf9a0d791706760368000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving backslashes. These should be slashes, but gnu,intel,nvidia generate code that treats slashes as whitespace and backslashes as a character, while cray treats backslashes as whitespace as well. This is easily fixed by using quotes, and in the meantime we will change the backslashes to forward slashes. See https://github.com/larson-group/clubb/issues/1138\#issuecomment-1910844013 2024-01-31 22:06:08 -060089925a4e642c7993be58226934ff9a3cdf9a0d79Removing backslashes. These should be slashes, but gnu,intel,nvidia generate code that treats slashes as whitespace and backslashes as a character, while cray treats backslashes as whitespace as well. This is easily fixed by using quotes, and in the meantime we will change the backslashes to forward slashes. See https://github.com/larson-group/clubb/issues/1138\#issuecomment-1910844013editinput_names.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse325http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/325/323http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/323/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break323820f44a500aefdda874400dd30ddcbde7b45d8d9820f44a500aefdda874400dd30ddcbde7b45d8d9refs/remotes/origin/clubb_silhs_devel820f44a500aefdda874400dd30ddcbde7b45d8d9820f44a500aefdda874400dd30ddcbde7b45d8d9refs/remotes/origin/clubb_silhs_devel820f44a500aefdda874400dd30ddcbde7b45d8d9820f44a500aefdda874400dd30ddcbde7b45d8d9refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#32330002423428101e3sm_run_gfortran_test #323323false32328422SUCCESS1706173446655http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/323/advance_wp2_wp3_module.F90623ed86ffb5b16dbcd6b72aa76e4aede6c38be6b1706079736000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduNow that the value of wp3 is being set to a boundary value of 0 at the first thermodynamic grid level above the surface, it doesn't make sense to loop over budget terms anymore at that particular level, since they don't factor in the solution and give a false impression. With this commit, wp3 budget terms now start their loop at level 3. This commit is BIT_CHANGING, but the only thing that changes are budget stats for a couple of wp3 budget terms. The solution does not actually change. 2024-01-24 01:02:16 -0600623ed86ffb5b16dbcd6b72aa76e4aede6c38be6bNow that the value of wp3 is being set to a boundary value of 0editadvance_wp2_wp3_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false324http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/324/322http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/322/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3225d21dfb98cd4e9cebef6f4a2d7505939a3d992485d21dfb98cd4e9cebef6f4a2d7505939a3d99248refs/remotes/origin/clubb_silhs_devel5d21dfb98cd4e9cebef6f4a2d7505939a3d992485d21dfb98cd4e9cebef6f4a2d7505939a3d99248refs/remotes/origin/clubb_silhs_devel5d21dfb98cd4e9cebef6f4a2d7505939a3d992485d21dfb98cd4e9cebef6f4a2d7505939a3d99248refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#32223704543428101e3sm_run_gfortran_test #322322false32228384SUCCESS1706087047956http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/322/diagnostic_v2_0/draw_plots_hoz_2D.py5d21dfb98cd4e9cebef6f4a2d7505939a3d992481706004257000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate draw_plots_hoz_2D.py Fixed a bug of RESTOM. RESTOM=FSNT-FLNT. 2024-01-23 18:04:17 +08005d21dfb98cd4e9cebef6f4a2d7505939a3d99248Update draw_plots_hoz_2D.pyeditdiagnostic_v2_0/draw_plots_hoz_2D.pygithttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse323http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/323/321http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/321/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break32190dda211a0588c88c933bfd71dee85823d26c03990dda211a0588c88c933bfd71dee85823d26c039refs/remotes/origin/clubb_silhs_devel90dda211a0588c88c933bfd71dee85823d26c03990dda211a0588c88c933bfd71dee85823d26c039refs/remotes/origin/clubb_silhs_devel90dda211a0588c88c933bfd71dee85823d26c03990dda211a0588c88c933bfd71dee85823d26c039refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#32124636893428101e3sm_run_gfortran_test #321321false32128336SUCCESS1706000648900http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/321/diagnostic_v2_0/draw_plots_hoz_2D.py90dda211a0588c88c933bfd71dee85823d26c0391705921261000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate draw_plots_hoz_2D.py Added wp3_vert_avg and wp2_vert_avg in the regional files. 2024-01-22 19:01:01 +080090dda211a0588c88c933bfd71dee85823d26c039Update draw_plots_hoz_2D.pyeditdiagnostic_v2_0/draw_plots_hoz_2D.pygithttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse322http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/322/320http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/320/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break320bcbedea4517332c399ea129fa756ae63e1b8cb3bbcbedea4517332c399ea129fa756ae63e1b8cb3brefs/remotes/origin/clubb_silhs_develbcbedea4517332c399ea129fa756ae63e1b8cb3bbcbedea4517332c399ea129fa756ae63e1b8cb3brefs/remotes/origin/clubb_silhs_develbcbedea4517332c399ea129fa756ae63e1b8cb3bbcbedea4517332c399ea129fa756ae63e1b8cb3brefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#32030014813428101e3sm_run_gfortran_test #320320false32028298SUCCESS1705914251219http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/320/advance_clubb_core_module.F90a1fd38a0ba17ef79fa0590646eb851fce4079bdb1705819808000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding clubb specific compiler flag -DCLUBB_GPU, intended for use with openmp or openacc running on the GPU. Also adding a compiler flags, -DCUDA, and case statment for generating random numbers in silhs. 2024-01-21 00:50:08 -0600a1fd38a0ba17ef79fa0590646eb851fce4079bdbAdding clubb specific compiler flag -DCLUBB_GPU, intended for use with openmp or openacc running on the GPU. Also adding a compiler flags, -DCUDA, and case statment for generating random numbers in silhs.editadvance_clubb_core_module.F90latin_hypercube_driver_module.F904b9838afa120e0a06c36eebb8e98027d0587dbba1705819808000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding clubb specific compiler flag -DCLUBB_GPU, intended for use with openmp or openacc running on the GPU. Also adding a compiler flags, -DCUDA, and case statment for generating random numbers in silhs. 2024-01-21 00:50:08 -06004b9838afa120e0a06c36eebb8e98027d0587dbbaAdding clubb specific compiler flag -DCLUBB_GPU, intended for use with openmp or openacc running on the GPU. Also adding a compiler flags, -DCUDA, and case statment for generating random numbers in silhs.editlatin_hypercube_driver_module.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse321http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/321/319http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/319/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3195c285b71059222f782fea907c9c6571dae9857d35c285b71059222f782fea907c9c6571dae9857d3refs/remotes/origin/clubb_silhs_devel5c285b71059222f782fea907c9c6571dae9857d35c285b71059222f782fea907c9c6571dae9857d3refs/remotes/origin/clubb_silhs_devel5c285b71059222f782fea907c9c6571dae9857d35c285b71059222f782fea907c9c6571dae9857d3refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#31925721653428101e3sm_run_gfortran_test #319319false31928180SUCCESS1705655057573http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/319/tridiag_lu_solver.F90ce785a929450dec9c013e6702b1bc9dcbc872b351705612684000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing tridiag solver bug. See https://github.com/larson-group/clubb/issues/1139 2024-01-18 15:18:04 -0600ce785a929450dec9c013e6702b1bc9dcbc872b35Fixing tridiag solver bug. See https://github.com/larson-group/clubb/issues/1139edittridiag_lu_solver.F90advance_clubb_core_module.F90clubb_api_module.F90e27a93ac46e46daa6d71e41f24993f9155dc02021705629086000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSlight rework to acc data statements. This allows us to use return calls in advance_clubb_core again. See https://github.com/larson-group/clubb/issues/1139 2024-01-18 19:51:26 -0600e27a93ac46e46daa6d71e41f24993f9155dc0202Slight rework to acc data statements. This allows us to use return calls in advance_clubb_core again. See https://github.com/larson-group/clubb/issues/1139editclubb_api_module.F90editadvance_clubb_core_module.F90mixing_length.F9033a2cb66dae21387f7a43e079180b02f622df4641705629109000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing small GPU stats bug 2024-01-18 19:51:49 -060033a2cb66dae21387f7a43e079180b02f622df464Fixing small GPU stats bugeditmixing_length.F90mono_flux_limiter.F90cf82acebf4a1cc31f092af210fd2e7970452e0691705629562000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduChanging xm to out in mono flux solver. There is no need for it to be inout, and it confused me for a bit so I'm fixing it. 2024-01-18 19:59:22 -0600cf82acebf4a1cc31f092af210fd2e7970452e069Changing xm to out in mono flux solver. There is no need for it to be inout, and it confused me for a bit so I'm fixing it.editmono_flux_limiter.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse320http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/320/318http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/318/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break318c2ea907b8c38aec771c71ce7231644655c3a3ef5c2ea907b8c38aec771c71ce7231644655c3a3ef5refs/remotes/origin/clubb_silhs_develc2ea907b8c38aec771c71ce7231644655c3a3ef5c2ea907b8c38aec771c71ce7231644655c3a3ef5refs/remotes/origin/clubb_silhs_develc2ea907b8c38aec771c71ce7231644655c3a3ef5c2ea907b8c38aec771c71ce7231644655c3a3ef5refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#31826696663428101e3sm_run_gfortran_test #318318false31828094SUCCESS1705050246981http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/318/mean_adv.F90830db1eac248ed03a0f52bf1d7402393b227b49e1705003858000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am altering the mean advection code in preparation for ghost point removal, since the mean advection code incorporates the ghost point in its current calculations. The lower boundary is now treated in the same manner as the upper boundary, where a zero derivative over the boundary is assumed. Any interaction of the current ghost level with the model code is now removed from the mean advection calculation. The results are bit-for-bit for most cases, but not all of them. They are not necessarily expected to be bit-for-bit. There are no discernable differences on plots of priority cases. However, this commit is technically BIT_CHANGING. 2024-01-11 14:10:58 -0600830db1eac248ed03a0f52bf1d7402393b227b49eI am altering the mean advection code in preparation for ghost pointeditmean_adv.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false319http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/319/317http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/317/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3176f9b0e73872d5a6e5a94809504b5aea710908b426f9b0e73872d5a6e5a94809504b5aea710908b42refs/remotes/origin/clubb_silhs_devel6f9b0e73872d5a6e5a94809504b5aea710908b426f9b0e73872d5a6e5a94809504b5aea710908b42refs/remotes/origin/clubb_silhs_devel6f9b0e73872d5a6e5a94809504b5aea710908b426f9b0e73872d5a6e5a94809504b5aea710908b42refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#31724508923428101e3sm_run_gfortran_test #317317false31727882SUCCESS1704791049891http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/317/advance_clubb_core_module.F90f759e61ac5c41dc5fe9615136b3347fcbef3aff41704774211000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding new argument list variables to openacc copyin statements 2024-01-08 22:23:31 -0600f759e61ac5c41dc5fe9615136b3347fcbef3aff4Adding new argument list variables to openacc copyin statementseditadvance_clubb_core_module.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse318http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/318/316http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/316/Started by user Gunther HueblerhueblerGunther Huebler75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break316bd519d002977bbae55a0ba664688e40f29feb690bd519d002977bbae55a0ba664688e40f29feb690refs/remotes/origin/clubb_silhs_develbd519d002977bbae55a0ba664688e40f29feb690bd519d002977bbae55a0ba664688e40f29feb690refs/remotes/origin/clubb_silhs_develbd519d002977bbae55a0ba664688e40f29feb690bd519d002977bbae55a0ba664688e40f29feb690refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#31620937603428101e3sm_run_gfortran_test #316316false31627819SUCCESS1704525756322http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/316/nightly_test/nightly_e3sm_ne4_silhs.cshjenkins_tests/e3sm_ne4_silhs_run_gfortran_test/Jenkinsfile6f89dd3fc2fcbdd30c226c84426b15c2e678d8a41704516232000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSmall updates 2024-01-05 22:43:52 -06006f89dd3fc2fcbdd30c226c84426b15c2e678d8a4Small updateseditjenkins_tests/e3sm_ne4_silhs_run_gfortran_test/Jenkinsfileeditnightly_test/nightly_e3sm_ne4_silhs.cshnightly_test/nightly_e3sm_scm_RICO.cshnightly_test/custom_case.submitnightly_test/nightly_e3sm_scm_ARM97.cshnightly_test/.nightly_e3sm_scm_BOMEX.csh.swpnightly_test/nightly_e3sm_scm_DYCOMSrf01.cshnightly_test/nightly_e3sm_scm_BOMEX.cshnightly_test/nightly_e3sm_ne4_silhs.cshbd519d002977bbae55a0ba664688e40f29feb6901704525727000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduNone of that worked, case.submit does not return a status indicator, causing tests to only report fail. Now we save output to a file and grep for an error message to determine whether or not there was an error. 2024-01-06 01:22:07 -0600bd519d002977bbae55a0ba664688e40f29feb690None of that worked, case.submit does not return a status indicator, causing tests to only report fail. Now we save output to a file and grep for an error message to determine whether or not there was an error.deletenightly_test/custom_case.submiteditnightly_test/nightly_e3sm_scm_DYCOMSrf01.csheditnightly_test/nightly_e3sm_scm_RICO.csheditnightly_test/nightly_e3sm_scm_BOMEX.csheditnightly_test/nightly_e3sm_scm_ARM97.cshaddnightly_test/.nightly_e3sm_scm_BOMEX.csh.swpeditnightly_test/nightly_e3sm_ne4_silhs.cshgithttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse317http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/317/315http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/315/Started by user Gunther HueblerhueblerGunther Huebler75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break315fad962bf785effce7b8e3bf3c84bbf846dac4c0afad962bf785effce7b8e3bf3c84bbf846dac4c0arefs/remotes/origin/clubb_silhs_develfad962bf785effce7b8e3bf3c84bbf846dac4c0afad962bf785effce7b8e3bf3c84bbf846dac4c0arefs/remotes/origin/clubb_silhs_develfad962bf785effce7b8e3bf3c84bbf846dac4c0afad962bf785effce7b8e3bf3c84bbf846dac4c0arefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#3154810313428101e3sm_run_gfortran_test #315315false31527815FAILURE1704515593028http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/315/nightly_test/nightly_e3sm_scm_DYCOMSrf01.cshnightly_test/nightly_e3sm_scm_RICO.cshnightly_test/nightly_e3sm_scm_BOMEX.cshnightly_test/nightly_e3sm_scm_ARM97.cshfad962bf785effce7b8e3bf3c84bbf846dac4c0a1704515584000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving wpthlp_entermfl and Richardson_num from clubb_vars_zm_list. These are no longer used, and overdefining namelists makes fortran unhappy. 2024-01-05 22:33:04 -0600fad962bf785effce7b8e3bf3c84bbf846dac4c0aRemoving wpthlp_entermfl and Richardson_num from clubb_vars_zm_list. These are no longer used, and overdefining namelists makes fortran unhappy.editnightly_test/nightly_e3sm_scm_ARM97.csheditnightly_test/nightly_e3sm_scm_RICO.csheditnightly_test/nightly_e3sm_scm_BOMEX.csheditnightly_test/nightly_e3sm_scm_DYCOMSrf01.cshgithttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse316http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/316/314http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/314/Started by user Gunther HueblerhueblerGunther Huebler75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3140c3a740e6b4a27e8171b27f4265126b93e41f8050c3a740e6b4a27e8171b27f4265126b93e41f805refs/remotes/origin/clubb_silhs_devel0c3a740e6b4a27e8171b27f4265126b93e41f8050c3a740e6b4a27e8171b27f4265126b93e41f805refs/remotes/origin/clubb_silhs_devel0c3a740e6b4a27e8171b27f4265126b93e41f8050c3a740e6b4a27e8171b27f4265126b93e41f805refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#3145074613428101e3sm_run_gfortran_test #314314false31427811FAILURE1704514838725http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/314/nightly_test/nightly_e3sm_ne4_silhs.csh=a_run_linknightly_test/nightly_e3sm_scm_RICO.cshnightly_test/custom_case.submitnightly_test/nightly_e3sm_scm_ARM97.cshnightly_test/nightly_e3sm_scm_DYCOMSrf01.cshnightly_test/nightly_e3sm_scm_BOMEX.cshnightly_test/nightly_e3sm_ne4_silhs.csh9cd878c5188eb0fcd7b40a8d1ff1255168d354461704514754000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking e3sm fail properly by making a custom version of case.submit that return an error status because for some reason the cime people only thought to do that for case.build. 2024-01-05 22:19:14 -06009cd878c5188eb0fcd7b40a8d1ff1255168d35446Making e3sm fail properly by making a custom version of case.submit that return an error status because for some reason the cime people only thought to do that for case.build.editnightly_test/nightly_e3sm_scm_DYCOMSrf01.cshaddnightly_test/custom_case.submiteditnightly_test/nightly_e3sm_scm_ARM97.csheditnightly_test/nightly_e3sm_ne4_silhs.csheditnightly_test/nightly_e3sm_scm_BOMEX.cshaddnightly_test/nightly_e3sm_ne4_silhs.csh=a_run_linkeditnightly_test/nightly_e3sm_scm_RICO.cshnightly_test/nightly_e3sm_ne4_silhs.csh=a_run_link0c3a740e6b4a27e8171b27f4265126b93e41f8051704514807000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving accidentally commited file 2024-01-05 22:20:07 -06000c3a740e6b4a27e8171b27f4265126b93e41f805Removing accidentally commited filedeletenightly_test/nightly_e3sm_ne4_silhs.csh=a_run_linkgithttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse315http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/315/313http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/313/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break31373522e2a49bf67e49552977a92cdc7c78100e29873522e2a49bf67e49552977a92cdc7c78100e298refs/remotes/origin/clubb_silhs_devel73522e2a49bf67e49552977a92cdc7c78100e29873522e2a49bf67e49552977a92cdc7c78100e298refs/remotes/origin/clubb_silhs_devel73522e2a49bf67e49552977a92cdc7c78100e29873522e2a49bf67e49552977a92cdc7c78100e298refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#31326126853428101e3sm_run_gfortran_test #313313false31327747SUCCESS1704445449002http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/313/corr_varnce_module.F906d345f45f5c0b3f99bd6b7c54cdf3b6c650943fa1704398011000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving awkward nan check in favor of a default for Ncnp2_on_Ncnm2 2024-01-04 13:53:31 -06006d345f45f5c0b3f99bd6b7c54cdf3b6c650943faRemoving awkward nan check in favor of a default for Ncnp2_on_Ncnm2editcorr_varnce_module.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse314http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/314/312http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/312/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3125f444944af496bd6fa94b968e803df18249a801e5f444944af496bd6fa94b968e803df18249a801erefs/remotes/origin/clubb_silhs_devel5f444944af496bd6fa94b968e803df18249a801e5f444944af496bd6fa94b968e803df18249a801erefs/remotes/origin/clubb_silhs_devel5f444944af496bd6fa94b968e803df18249a801e5f444944af496bd6fa94b968e803df18249a801erefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#31227133603428101e3sm_run_gfortran_test #312312false31227659SUCCESS1704359047256http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/312/components/eam/src/physics/cam/clubb_intr.F905f63282539ac5158547226772ef4b94aed12fd401704313018000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding if around allocation and adding call for fields to be output, these are both to prevent runtime bugs 2024-01-03 14:16:58 -06005f63282539ac5158547226772ef4b94aed12fd40Adding if around allocation and adding call for fields to be output, these are both to prevent runtime bugseditcomponents/eam/src/physics/cam/clubb_intr.F90advance_xm_wpxp_module.F90clubb_api_module.F90clip_explicit.F90diagnose_correlations_module.F90setup_clubb_pdf_params.F90advance_windm_edsclrm_module.F90advance_helper_module.F90mixing_length.F90advance_xp2_xpyp_module.F90error_code.F90pdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F90new_hybrid_pdf_main.F90corr_varnce_module.F90precipitation_fraction.F90index_mapping.F90model_flags.F90numerical_check.F90output_netcdf.F90stat_file_module.F90sponge_layer_damping.F90array_index.F90saturation.F90advance_clubb_core_module.F90advance_xp3_module.F90stats_zt_module.F90fill_holes.F90stats_zm_module.F90stats_clubb_utilities.F90parameters_model.F90sfc_varnce_module.F9069a0500429869014c93503d18cff3ccfd516dc6d1704332198000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comThreadpublic (#1133) * Initial threadprivate removals and simple changes. * model flags update, incomplete * Some updates, almost working * Added saturation_formula and l_host_applies_sfc_fluxes to clubb_config_flags * Accompanying changes to flags lists * Changes to corrrelation array setup * Adding more flag checking * Forgot to set l_host_applies_sfc_fluxes in initialize_clubb_config_flags_type and commit adding l_implemented to the argument loit * Adding saturation parameters to api * Most of the way through passing sclr_dim, hydromet_dim, edsclr_dim, and sclr_tol through arguemnt lists. Moved first_write breaking silhs stats aparently, and bit changing due to the way we were writing sclr_tol for cases that have sclr_dim=0 (arm different, gabls2 BFB). * Removing accidentally commited files. * Fixed silhs output, all cases BFB but sclr_tol is saved differently to stats files in cases where sclr_dim = 0, so this is bc also bc:fb20458d5212b007c79c17613201af637bbc3d7e since that introduced the difference. * Changing stats logicals back to false, only set to true for testing. So technically BIT_CHANGING * Starting array_vars changes. * No more global scalar indices * Starting to remove hydromet indices * Finished the annoying part with the microphysics interfaces. * No more global variables in array_index. All cases BFB relative to last commit. * No more global pdf_dim, Ncnp2_on_Ncnm2 now set via argument list, and added temporary hydromet_dim_glob because I thought it would fix a bug but it didn't, it might in the future though, so I left it in for now, it will be removed soon. * Added nan checking before overriding default value for Ncnp2_on_Ncnm2 * Finished hydromet_dim argument listing and removed global versions of it as well as sclr_dim, edsclr_dim, and sclr_tol. * open_netcdf_for_writing does nothing if nvars=0 for a stats file, which is understandable, but now that we call first_write immediately after we need that also to check for nvar=0 * Adding better error messages to stats_init * The nvidia compiler does not like zero size arrays. * Adding defaults for scalar arrays values in clubb driver, and adding an error check after calling stats_init. * Reverting accidental changes to clubb_thread_test * Changing name of scarr/scalar_array to sclr_idx and hydromet_array to hm_metadata * Adding new types to _api * Fixing erroneous name changes. * Fixing bug introduced in 65987c8a77496f7bb10bfd28717345b1f63de1b7 * Removing print * QuadTune: updates setup in order to read in 30x30 regional files automatically. For #910. * Updating the code to set the bottom of the thermodynamic level grid for diffusion at thermodynamic level 2 -- the first level above the surface. This is being done in preparation for ghostless gridding. * Commit to enforce a fixed-point boundary condition of wp3=0 at thermodynamic level k = 2, the first above-ground thermodynamic level. This is being done in preparation for ghostless gridding. This commit is bc. Results are much more similar to the previous results than using using zero-flux as the lower boundary condition for wp3. * With wp3 now being set to a fixed-point boundary condition value of 0 at the current thermodynamic level 2 (first t-lev above the surface), it is not necessary to loop over level 2 within the code for each wp3 term. This commit is BIT_CHANGING, but only for the wp3 budget terms (e.g. wp3_ta) in the zt output file at level k = 2. It doesn't change the actual answer. All other variables are bit-for-bit identical. * Removing omp parallel test line * Removing parameter declarion around l_quintic_poly_interp. Having this be a parameter causes bit changes when using -O2 --------- Co-authored-by: vlarson <vlarson@uwm.edu> Co-authored-by: bmg929 <bmg2@uwm.edu> 2024-01-03 19:36:38 -060069a0500429869014c93503d18cff3ccfd516dc6dThreadpublic (#1133)editmixing_length.F90editsetup_clubb_pdf_params.F90editadvance_windm_edsclrm_module.F90editparameters_model.F90editsfc_varnce_module.F90editstats_zt_module.F90editsaturation.F90editfill_holes.F90editarray_index.F90editcorr_varnce_module.F90editadvance_clubb_core_module.F90editdiagnose_correlations_module.F90editpdf_closure_module.F90editadvance_xm_wpxp_module.F90editclubb_api_module.F90editadvance_xp2_xpyp_module.F90editindex_mapping.F90editmodel_flags.F90editprecipitation_fraction.F90editadvance_xp3_module.F90editclip_explicit.F90editnew_hybrid_pdf_main.F90editoutput_netcdf.F90editstats_zm_module.F90editnumerical_check.F90editerror_code.F90editstat_file_module.F90editstats_clubb_utilities.F90editadg1_adg2_3d_luhar_pdf.F90editsponge_layer_damping.F90editadvance_helper_module.F90silhs_api_module.F90silhs_importance_sample_module.F90transform_to_pdf_module.F90latin_hypercube_driver_module.F90output_2D_samples_module.F9014c8636ab5c46f3f20204fae38b1eeb765bc804c1704332198000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comThreadpublic (#1133) * Initial threadprivate removals and simple changes. * model flags update, incomplete * Some updates, almost working * Added saturation_formula and l_host_applies_sfc_fluxes to clubb_config_flags * Accompanying changes to flags lists * Changes to corrrelation array setup * Adding more flag checking * Forgot to set l_host_applies_sfc_fluxes in initialize_clubb_config_flags_type and commit adding l_implemented to the argument loit * Adding saturation parameters to api * Most of the way through passing sclr_dim, hydromet_dim, edsclr_dim, and sclr_tol through arguemnt lists. Moved first_write breaking silhs stats aparently, and bit changing due to the way we were writing sclr_tol for cases that have sclr_dim=0 (arm different, gabls2 BFB). * Removing accidentally commited files. * Fixed silhs output, all cases BFB but sclr_tol is saved differently to stats files in cases where sclr_dim = 0, so this is bc also bc:fb20458d5212b007c79c17613201af637bbc3d7e since that introduced the difference. * Changing stats logicals back to false, only set to true for testing. So technically BIT_CHANGING * Starting array_vars changes. * No more global scalar indices * Starting to remove hydromet indices * Finished the annoying part with the microphysics interfaces. * No more global variables in array_index. All cases BFB relative to last commit. * No more global pdf_dim, Ncnp2_on_Ncnm2 now set via argument list, and added temporary hydromet_dim_glob because I thought it would fix a bug but it didn't, it might in the future though, so I left it in for now, it will be removed soon. * Added nan checking before overriding default value for Ncnp2_on_Ncnm2 * Finished hydromet_dim argument listing and removed global versions of it as well as sclr_dim, edsclr_dim, and sclr_tol. * open_netcdf_for_writing does nothing if nvars=0 for a stats file, which is understandable, but now that we call first_write immediately after we need that also to check for nvar=0 * Adding better error messages to stats_init * The nvidia compiler does not like zero size arrays. * Adding defaults for scalar arrays values in clubb driver, and adding an error check after calling stats_init. * Reverting accidental changes to clubb_thread_test * Changing name of scarr/scalar_array to sclr_idx and hydromet_array to hm_metadata * Adding new types to _api * Fixing erroneous name changes. * Fixing bug introduced in 65987c8a77496f7bb10bfd28717345b1f63de1b7 * Removing print * QuadTune: updates setup in order to read in 30x30 regional files automatically. For #910. * Updating the code to set the bottom of the thermodynamic level grid for diffusion at thermodynamic level 2 -- the first level above the surface. This is being done in preparation for ghostless gridding. * Commit to enforce a fixed-point boundary condition of wp3=0 at thermodynamic level k = 2, the first above-ground thermodynamic level. This is being done in preparation for ghostless gridding. This commit is bc. Results are much more similar to the previous results than using using zero-flux as the lower boundary condition for wp3. * With wp3 now being set to a fixed-point boundary condition value of 0 at the current thermodynamic level 2 (first t-lev above the surface), it is not necessary to loop over level 2 within the code for each wp3 term. This commit is BIT_CHANGING, but only for the wp3 budget terms (e.g. wp3_ta) in the zt output file at level k = 2. It doesn't change the actual answer. All other variables are bit-for-bit identical. * Removing omp parallel test line * Removing parameter declarion around l_quintic_poly_interp. Having this be a parameter causes bit changes when using -O2 --------- Co-authored-by: vlarson <vlarson@uwm.edu> Co-authored-by: bmg929 <bmg2@uwm.edu> 2024-01-03 19:36:38 -060014c8636ab5c46f3f20204fae38b1eeb765bc804cThreadpublic (#1133)editsilhs_importance_sample_module.F90editsilhs_api_module.F90edittransform_to_pdf_module.F90editlatin_hypercube_driver_module.F90editoutput_2D_samples_module.F90components/eam/src/physics/cam/clubb_intr.F90components/eam/src/physics/cam/subcol_SILHS.F90ba7ed42d545ad511fe53aa45900746100b35d7fb1704337453000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking compatible with latest clubb changes. 2024-01-03 21:04:13 -0600ba7ed42d545ad511fe53aa45900746100b35d7fbMaking compatible with latest clubb changes.editcomponents/eam/src/physics/cam/subcol_SILHS.F90editcomponents/eam/src/physics/cam/clubb_intr.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse313http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/313/311http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/311/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3116f0936f3a5582d9091ff4ac2fe47382545c3a6586f0936f3a5582d9091ff4ac2fe47382545c3a658refs/remotes/origin/clubb_silhs_devel6f0936f3a5582d9091ff4ac2fe47382545c3a6586f0936f3a5582d9091ff4ac2fe47382545c3a658refs/remotes/origin/clubb_silhs_devel6f0936f3a5582d9091ff4ac2fe47382545c3a6586f0936f3a5582d9091ff4ac2fe47382545c3a658refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#31126508133428101e3sm_run_gfortran_test #311311false31127563SUCCESS1703235851007http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/311/advance_wp2_wp3_module.F9039e110e1e0d3a674a66ff616a403f81f470fa8771703174134000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduWith wp3 now being set to a fixed-point boundary condition value of 0 at the current thermodynamic level 2 (first t-lev above the surface), it is not necessary to loop over level 2 within the code for each wp3 term. This commit is BIT_CHANGING, but only for the wp3 budget terms (e.g. wp3_ta) in the zt output file at level k = 2. It doesn't change the actual answer. All other variables are bit-for-bit identical. 2023-12-21 09:55:34 -060039e110e1e0d3a674a66ff616a403f81f470fa877With wp3 now being set to a fixed-point boundary condition valueeditadvance_wp2_wp3_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false312http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/312/310http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/310/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3105f8f31fc70bcf6468b056179fe347fb2e1d117055f8f31fc70bcf6468b056179fe347fb2e1d11705refs/remotes/origin/clubb_silhs_devel5f8f31fc70bcf6468b056179fe347fb2e1d117055f8f31fc70bcf6468b056179fe347fb2e1d11705refs/remotes/origin/clubb_silhs_devel5f8f31fc70bcf6468b056179fe347fb2e1d117055f8f31fc70bcf6468b056179fe347fb2e1d11705refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#31026086743428101e3sm_run_gfortran_test #310310false31027489SUCCESS1702976648972http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/310/diffusion.F9020d6130562d60f6c2c17972cdc5a81de5dacd8611702943185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comUpdating the code to set the bottom of the thermodynamic level grid for diffusion at thermodynamic level 2 -- the first level above the surface. This is being done in preparation for ghostless gridding. 2023-12-18 17:46:25 -060020d6130562d60f6c2c17972cdc5a81de5dacd861Updating the code to set the bottom of the thermodynamic level grid foreditdiffusion.F90advance_wp2_wp3_module.F90cebdb21aff77c08197f427a89df4712ee1fa5de01702943185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comCommit to enforce a fixed-point boundary condition of wp3=0 at thermodynamic level k = 2, the first above-ground thermodynamic level. This is being done in preparation for ghostless gridding. This commit is BIT_CHANGING. Results are much more similar to the previous results than using using zero-flux as the lower boundary condition for wp3. 2023-12-18 17:46:25 -0600cebdb21aff77c08197f427a89df4712ee1fa5de0Commit to enforce a fixed-point boundary condition of wp3=0 ateditadvance_wp2_wp3_module.F90githttp://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffinfalse311http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/311/309http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/309/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break309ead0b9f16de51f58fe1878e1f747b8bec46dc94eead0b9f16de51f58fe1878e1f747b8bec46dc94erefs/remotes/origin/clubb_silhs_develead0b9f16de51f58fe1878e1f747b8bec46dc94eead0b9f16de51f58fe1878e1f747b8bec46dc94erefs/remotes/origin/clubb_silhs_develead0b9f16de51f58fe1878e1f747b8bec46dc94eead0b9f16de51f58fe1878e1f747b8bec46dc94erefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#30926334153428101e3sm_run_gfortran_test #309309false30927401SUCCESS1702458248269http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/309/mixing_length.F90advance_clubb_core_module.F90stats_variables.F90stats_zm_module.F903ba52c6cb91becf07a3cd181ae018428675298bd1702424778000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@users.noreply.github.comAdded new Brunt-Väisälä frequency plots to pyplotgen's VariableGroupTaus CLUBB ticket #1132, BIT_CHANGING because new output fields were added - Added 3 new Brunt-Väisälä output fields: - bv_freq_sqd_smth: The smoothed bv_mixed which is used to calculate the invrs_taus - bv_freq_pos: The positive part of the sqrt of bv_freq_sqd_smth - bv_freq_out_cloud: The out-of-cloud part of bv_freq_pos - Added the plots of those fields to VariableGroupTaus 2023-12-12 17:46:18 -06003ba52c6cb91becf07a3cd181ae018428675298bdAdded new Brunt-Väisälä frequency plots to pyplotgen's VariableGroupTauseditadvance_clubb_core_module.F90editmixing_length.F90editstats_variables.F90editstats_zm_module.F90advance_clubb_core_module.F9059de6e143a1bdbf3e43d13f67d71deb63affdde21702425732000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdds commas to fix bug 2023-12-12 18:02:12 -060059de6e143a1bdbf3e43d13f67d71deb63affdde2Adds commas to fix bugeditadvance_clubb_core_module.F90githttp://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonhttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse310http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/310/308http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/308/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break308996fdc08617cd5d52f4e3cab4d115b74adf84308996fdc08617cd5d52f4e3cab4d115b74adf84308refs/remotes/origin/clubb_silhs_devel996fdc08617cd5d52f4e3cab4d115b74adf84308996fdc08617cd5d52f4e3cab4d115b74adf84308refs/remotes/origin/clubb_silhs_devel996fdc08617cd5d52f4e3cab4d115b74adf84308996fdc08617cd5d52f4e3cab4d115b74adf84308refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#30826144513428101e3sm_run_gfortran_test #308308false30827319SUCCESS1702112646953http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/308/advance_wp2_wp3_module.F9022b99ad5e75002985bbb982a508764c345927aec1702052124000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comAdding boundary conditions for the wp3_term_ta_ADG1_lhs subroutine. The value of wp3_zm at the model lower and upper boundaries is now assumed to be 0 for simplicity and conservation. 2023-12-08 10:15:24 -060022b99ad5e75002985bbb982a508764c345927aecAdding boundary conditions for the wp3_term_ta_ADG1_lhs subroutine.editadvance_wp2_wp3_module.F90advance_wp2_wp3_module.F90961f848884a3fce181c64c6c0ddc3fa73c33120e1702052124000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comFor single loop vectors, removing the "collapse(2)" from the acc statements. This commit is not bit changing, but the previous commit to this branch was BIT_CHANGING:902d6caed8a4533f59f4165106276959b4f90895 2023-12-08 10:15:24 -0600961f848884a3fce181c64c6c0ddc3fa73c33120eFor single loop vectors, removing the "collapse(2)" from the acc statements.editadvance_wp2_wp3_module.F90githttp://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffinfalse309http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/309/307http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/307/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break30702d723b413b8a364aa8f6c38e5ae07351856235c02d723b413b8a364aa8f6c38e5ae07351856235crefs/remotes/origin/clubb_silhs_devel02d723b413b8a364aa8f6c38e5ae07351856235c02d723b413b8a364aa8f6c38e5ae07351856235crefs/remotes/origin/clubb_silhs_devel02d723b413b8a364aa8f6c38e5ae07351856235c02d723b413b8a364aa8f6c38e5ae07351856235crefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#30717748273428101e3sm_run_gfortran_test #307307false30727297SUCCESS1701939847565http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/307/diagnostic_v2_0/draw_plots_hoz_2D.py02d723b413b8a364aa8f6c38e5ae07351856235c1701911619000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate draw_plots_hoz_2D.py Flexible regional files. Please change " intll = 30." to make the pixels (default is 30x30, i.e. the global is separated in to 6x12 boxes). 2023-12-07 09:13:39 +080002d723b413b8a364aa8f6c38e5ae07351856235cUpdate draw_plots_hoz_2D.pyeditdiagnostic_v2_0/draw_plots_hoz_2D.pygithttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse308http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/308/306http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/306/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break306e3281b011a93645eab0ac0e5ffcdaccfeeb46fe1e3281b011a93645eab0ac0e5ffcdaccfeeb46fe1refs/remotes/origin/clubb_silhs_devele3281b011a93645eab0ac0e5ffcdaccfeeb46fe1e3281b011a93645eab0ac0e5ffcdaccfeeb46fe1refs/remotes/origin/clubb_silhs_devele3281b011a93645eab0ac0e5ffcdaccfeeb46fe1e3281b011a93645eab0ac0e5ffcdaccfeeb46fe1refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#30626726263428101e3sm_run_gfortran_test #306306false30627225SUCCESS1701248650327http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/306/mixing_length.F9046dce38d9a340446c91e745aeb1cc059437e2d951701198848000http://carson.math.uwm.edu/jenkins/user/sdomkeSteffen Domkesdomke@uwm.eduRe-adjusted cap for invrs_tau_wpxp in src/CLUBB_core/mixing_length.F90 BIT_CHANGING! CLUBB ticket #1115 2023-11-28 13:14:08 -060046dce38d9a340446c91e745aeb1cc059437e2d95Re-adjusted cap for invrs_tau_wpxp in src/CLUBB_core/mixing_length.F90editmixing_length.F90githttp://carson.math.uwm.edu/jenkins/user/sdomkeSteffen Domkefalse307http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/307/305http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/305/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3059d3a87ec24dea486c9ef9ffb073d35d14e3335829d3a87ec24dea486c9ef9ffb073d35d14e333582refs/remotes/origin/clubb_silhs_devel9d3a87ec24dea486c9ef9ffb073d35d14e3335829d3a87ec24dea486c9ef9ffb073d35d14e333582refs/remotes/origin/clubb_silhs_devel9d3a87ec24dea486c9ef9ffb073d35d14e3335829d3a87ec24dea486c9ef9ffb073d35d14e333582refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#30517384523428101e3sm_run_gfortran_test #305305false30527199SUCCESS1700903050262http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/305/diagnostic_v2_0/draw_plots_hoz_2D.py9d3a87ec24dea486c9ef9ffb073d35d14e3335821700827220000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate draw_plots_hoz_2D.py Fix a bug of 'automatic' variable name. The previous version had a syntax error, so variables were assigned multiple times. 2023-11-24 20:00:20 +08009d3a87ec24dea486c9ef9ffb073d35d14e333582Update draw_plots_hoz_2D.pyeditdiagnostic_v2_0/draw_plots_hoz_2D.pygithttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse306http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/306/304http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/304/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3046acaab5488c1f8cb6adbfa738a67d0e25ccf4fac6acaab5488c1f8cb6adbfa738a67d0e25ccf4facrefs/remotes/origin/clubb_silhs_devel6acaab5488c1f8cb6adbfa738a67d0e25ccf4fac6acaab5488c1f8cb6adbfa738a67d0e25ccf4facrefs/remotes/origin/clubb_silhs_devel6acaab5488c1f8cb6adbfa738a67d0e25ccf4fac6acaab5488c1f8cb6adbfa738a67d0e25ccf4facrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#30417403543428101e3sm_run_gfortran_test #304304false30427143SUCCESS1700384650913http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/304/diagnostic_v2_0/draw_plots_hoz_2D.py2728586a3818aab11a1c5902a76c360e028ef2be1700311395000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate draw_plots_hoz_2D.py Fixed the bug of regional mean and add MSWCF = SWCF*-1. 2023-11-18 20:43:15 +08002728586a3818aab11a1c5902a76c360e028ef2beUpdate draw_plots_hoz_2D.pyeditdiagnostic_v2_0/draw_plots_hoz_2D.pydiagnostic_v2_0/E3SM_CLUBB_diag.py6acaab5488c1f8cb6adbfa738a67d0e25ccf4fac1700311661000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate E3SM_CLUBB_diag.py Fixed a bug of parameter list. 2023-11-18 20:47:41 +08006acaab5488c1f8cb6adbfa738a67d0e25ccf4facUpdate E3SM_CLUBB_diag.pyeditdiagnostic_v2_0/E3SM_CLUBB_diag.pygithttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse305http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/305/303http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/303/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break303c04d0eed97bc37ebceb3e3be85ad1c6194cc5764c04d0eed97bc37ebceb3e3be85ad1c6194cc5764refs/remotes/origin/clubb_silhs_develc04d0eed97bc37ebceb3e3be85ad1c6194cc5764c04d0eed97bc37ebceb3e3be85ad1c6194cc5764refs/remotes/origin/clubb_silhs_develc04d0eed97bc37ebceb3e3be85ad1c6194cc5764c04d0eed97bc37ebceb3e3be85ad1c6194cc5764refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#30326682923428101e3sm_run_gfortran_test #303303false30327083SUCCESS1700211849160http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/303/mixing_length.F90advance_clubb_core_module.F90advance_helper_module.F9071caa87dc4bf283982e72d7a5d548f0e19d36ca71700177490000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdded non-trapezoidal zm interpolation for cloud_frac (#1127) - Added a calculation for `cloud_frac_zm` when `l_call_pdf_closure_twice=false` and `l_trapezoidal_rule_zt=false` This is BIT_CHANGING if `l_call_pdf_closure_twice=false` and `l_trapezoidal_rule_zt=false` since, in that case, `cloud_frac_zm` is now nonzero. - Some minor formatting fixes - Some minor fixes to pyplotgen's source code - Added `a3_coef_min` to Lscale tunable_parameters.in 2023-11-16 17:31:30 -060071caa87dc4bf283982e72d7a5d548f0e19d36ca7Added non-trapezoidal zm interpolation for cloud_frac (#1127)editmixing_length.F90editadvance_clubb_core_module.F90editadvance_helper_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse304http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/304/302http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/302/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break302867836221c862d846a2b7db7cae8d6c6012d2483867836221c862d846a2b7db7cae8d6c6012d2483refs/remotes/origin/clubb_silhs_devel867836221c862d846a2b7db7cae8d6c6012d2483867836221c862d846a2b7db7cae8d6c6012d2483refs/remotes/origin/clubb_silhs_devel867836221c862d846a2b7db7cae8d6c6012d2483867836221c862d846a2b7db7cae8d6c6012d2483refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#30226074413428101e3sm_run_gfortran_test #302302false30226999SUCCESS1700039050542http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/302/Skx_module.F9094ceac8b9273b15c668961304300e0f042f9844c1699991156000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduChanging order of sqrt and **3 to improve stability, see clubb#1126. Since this is a change to the order of operations, it is BIT_CHANGING. 2023-11-14 13:45:56 -060094ceac8b9273b15c668961304300e0f042f9844cChanging order of sqrt and **3 to improve stability, see clubb#1126. Since this is a change to the order of operations, it is BIT_CHANGING.editSkx_module.F90constants_clubb.F9080f7ee00a316e443c95eeb822d14eb5ba4b10b831699995955000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSetting the minimum tolerance to be epsilon, this is BIT_CHANGING but only for single precision. See larson-group/clubb#1126 2023-11-14 15:05:55 -060080f7ee00a316e443c95eeb822d14eb5ba4b10b83Setting the minimum tolerance to be epsilon, this is BIT_CHANGING but only for single precision. See larson-group/clubb#1126editconstants_clubb.F90mixing_length.F9055b6329613ecf69fa8cd632b83ddc2dbf60f64711699997980000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comBIT_CHANGING! Updated taus code calculations - CLUBB ticket #1115 (#1125) - Changed invrs_tau_xp2/wp2 calculations to match the wpxp calculation: Those now have a brunt_freq_pos and a brunt_freq_out_cloud term - Changed tmp_calc magic number from .007 to .001 - Changed upper clipping bound for Ri_zm from 12 to 2 in invrs_tau_wpxp calculation - Reversed accidental changes to input_misc/tuner/error_four_cases.in 2023-11-14 15:39:40 -060055b6329613ecf69fa8cd632b83ddc2dbf60f6471BIT_CHANGING! Updated taus code calculations - CLUBB ticket #1115 (#1125)editmixing_length.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse303http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/303/301http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/301/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break301190e9d0a635afe5888b088072068fbd83b365a33190e9d0a635afe5888b088072068fbd83b365a33refs/remotes/origin/clubb_silhs_devel190e9d0a635afe5888b088072068fbd83b365a33190e9d0a635afe5888b088072068fbd83b365a33refs/remotes/origin/clubb_silhs_devel190e9d0a635afe5888b088072068fbd83b365a33190e9d0a635afe5888b088072068fbd83b365a33refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#30127683133428101e3sm_run_gfortran_test #301301false30126847SUCCESS1699693449729http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/301/components/eam/src/physics/cam/clubb_intr.F90components/eam/src/physics/cam/subcol_SILHS.F9096610a76a2c7f9369b6625c536c5d2fe555544371699659917000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking work with latest clubb changes. 2023-11-10 17:45:17 -060096610a76a2c7f9369b6625c536c5d2fe55554437Making work with latest clubb changes.editcomponents/eam/src/physics/cam/clubb_intr.F90editcomponents/eam/src/physics/cam/subcol_SILHS.F90nightly_test/nightly_e3sm_ne4_silhs.cshf9424d825225c07136f684980ebf6f22d164eedc1699660030000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving removed parameters from run file. 2023-11-10 17:47:10 -0600f9424d825225c07136f684980ebf6f22d164eedcRemoving removed parameters from run file.editnightly_test/nightly_e3sm_ne4_silhs.cshcomponents/eam/src/physics/cam/clubb_intr.F900c5c48612c3d0d83a2b868661f78386ef3ccd16e1699660138000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduChanging stat_indices to stats_metadata_type 2023-11-10 17:48:58 -06000c5c48612c3d0d83a2b868661f78386ef3ccd16eChanging stat_indices to stats_metadata_typeeditcomponents/eam/src/physics/cam/clubb_intr.F90advance_xm_wpxp_module.F90clip_explicit.F90clubb_api_module.F90stats_lh_zt_module.F90stats_type_utilities.F90setup_clubb_pdf_params.F90advance_windm_edsclrm_module.F90mono_flux_limiter.F90advance_helper_module.F90advance_wp2_wp3_module.F90mixing_length.F90advance_xp2_xpyp_module.F90output_grads.F90stats_rad_zm_module.F90stats_rad_zt_module.F90pdf_closure_module.F90precipitation_fraction.F90numerical_check.F90stats_lh_sfc_module.F90stats_variables.F90advance_clubb_core_module.F90advance_xp3_module.F90stats_zt_module.F90fill_holes.F90stats_sfc_module.F90stats_zm_module.F90stats_clubb_utilities.F90sfc_varnce_module.F900eb82e3d60c5fd567e1f24a0015d2c6fd8f210691699661720000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comNew Stats Indices Type (#1118) * Grouping stats indices into a derived type and making that accessible globally, for now. This does not run yet, but a checkpoint I wish to save. * Checkpoint to save * Checkpoint * It actually works now and is BFB with every case. * Starting to push the new derived type through the argument list. * The new dervied type, now stats_metadata, has been fed through the argument list. * Moved l_stats_samp into stats_metadata * Moved all the other stats_variables into stats_metadata * Small cleanup * Fixes a stats bug when calling compute_sample_mean in silhs. * Arrays in stats_metadata need only be allocated once, but we may want to call the stats init routines to set up more stats variables. So now we check for allocation before allocating. Also made the stat_indices type publicly available through clubb_api. * This should be initialized to 0. The new changes in cam were able to tease this out, which is a good sign. * A couple more to initialize to zero. * Moving stats_metadata to before stats_ variables in argument lists, just for consistency. * Changing stat_indices to stats_metadata_type 2023-11-10 18:15:20 -06000eb82e3d60c5fd567e1f24a0015d2c6fd8f21069New Stats Indices Type (#1118)editstats_rad_zm_module.F90editnumerical_check.F90editpdf_closure_module.F90editadvance_xp2_xpyp_module.F90editstats_rad_zt_module.F90editstats_zt_module.F90editstats_lh_zt_module.F90editadvance_clubb_core_module.F90editstats_sfc_module.F90editadvance_xm_wpxp_module.F90editadvance_windm_edsclrm_module.F90editsetup_clubb_pdf_params.F90editclip_explicit.F90editfill_holes.F90editadvance_wp2_wp3_module.F90editadvance_xp3_module.F90editstats_type_utilities.F90editstats_lh_sfc_module.F90editoutput_grads.F90editsfc_varnce_module.F90editstats_zm_module.F90editstats_clubb_utilities.F90editmono_flux_limiter.F90editclubb_api_module.F90editadvance_helper_module.F90editprecipitation_fraction.F90editstats_variables.F90editmixing_length.F90silhs_api_module.F90output_2D_samples_module.F90latin_hypercube_driver_module.F901fff41b95831158920098a46667c5bee20b406fd1699661720000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comNew Stats Indices Type (#1118) * Grouping stats indices into a derived type and making that accessible globally, for now. This does not run yet, but a checkpoint I wish to save. * Checkpoint to save * Checkpoint * It actually works now and is BFB with every case. * Starting to push the new derived type through the argument list. * The new dervied type, now stats_metadata, has been fed through the argument list. * Moved l_stats_samp into stats_metadata * Moved all the other stats_variables into stats_metadata * Small cleanup * Fixes a stats bug when calling compute_sample_mean in silhs. * Arrays in stats_metadata need only be allocated once, but we may want to call the stats init routines to set up more stats variables. So now we check for allocation before allocating. Also made the stat_indices type publicly available through clubb_api. * This should be initialized to 0. The new changes in cam were able to tease this out, which is a good sign. * A couple more to initialize to zero. * Moving stats_metadata to before stats_ variables in argument lists, just for consistency. * Changing stat_indices to stats_metadata_type 2023-11-10 18:15:20 -06001fff41b95831158920098a46667c5bee20b406fdNew Stats Indices Type (#1118)editsilhs_api_module.F90editoutput_2D_samples_module.F90editlatin_hypercube_driver_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse302http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/302/300http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/300/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break300b6c0f628a13f8e62c77c8d1b5b2d04a5953eb880b6c0f628a13f8e62c77c8d1b5b2d04a5953eb880refs/remotes/origin/clubb_silhs_develb6c0f628a13f8e62c77c8d1b5b2d04a5953eb880b6c0f628a13f8e62c77c8d1b5b2d04a5953eb880refs/remotes/origin/clubb_silhs_develb6c0f628a13f8e62c77c8d1b5b2d04a5953eb880b6c0f628a13f8e62c77c8d1b5b2d04a5953eb880refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#3005671383428101e3sm_run_gfortran_test #300300false30026769FAILURE1699607048467http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/300/mixing_length.F90parameters_tunable.F90advance_clubb_core_module.F90parameter_indices.F90clubb_api_module.F903e0adc18b4f8221be03da5e8670357090c34fd4d1699563846000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comZ displace tunable (#1122) CLUBB ticket #1115 Added the previously hard-coded z_displace as a tunable parameter. 2023-11-09 15:04:06 -06003e0adc18b4f8221be03da5e8670357090c34fd4dZ displace tunable (#1122)editclubb_api_module.F90editparameters_tunable.F90editmixing_length.F90editparameter_indices.F90editadvance_clubb_core_module.F90components/eam/src/physics/cam/clubb_intr.F90components/eam/bld/namelist_files/namelist_definition.xml9fd17ed84cb071ba2b6bfbac3f574077416e75651699564177000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comZ displace tunable (#62) Added CLUBB tunable parameter z_displace 2023-11-09 15:09:37 -06009fd17ed84cb071ba2b6bfbac3f574077416e7565Z displace tunable (#62)editcomponents/eam/src/physics/cam/clubb_intr.F90editcomponents/eam/bld/namelist_files/namelist_definition.xmlgithttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse301http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/301/299http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/299/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break299fd13f85889ca3b4bddbdf621bee0c3f93a4d0621fd13f85889ca3b4bddbdf621bee0c3f93a4d0621refs/remotes/origin/clubb_silhs_develfd13f85889ca3b4bddbdf621bee0c3f93a4d0621fd13f85889ca3b4bddbdf621bee0c3f93a4d0621refs/remotes/origin/clubb_silhs_develfd13f85889ca3b4bddbdf621bee0c3f93a4d0621fd13f85889ca3b4bddbdf621bee0c3f93a4d0621refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#2996043223428101e3sm_run_gfortran_test #299299false29926693FAILURE1699520650698http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/299/parameters_tunable.F90clubb_api_module.F90f7c02bb877ebac54c69c91bc0bbde80bb9f843601699478932000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdated CLUBB so that adj_low_res_nu (which can be called on its own or called through calling setup_parameters) no longer uses momentum_heights and thermodynamic_heights, but rather makes use of gr%zm and gr%zt, which are always set and available by the time the calls are made. 2023-11-08 15:28:52 -0600f7c02bb877ebac54c69c91bc0bbde80bb9f84360Updated CLUBB so that adj_low_res_nu (which can be called on its owneditparameters_tunable.F90editclubb_api_module.F90components/eam/src/physics/cam/clubb_intr.F9098a7b97376879ef2540fff0d9f94012318c5eb0b1699482269000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdated for recent changes to CLUBB. 2023-11-08 16:24:29 -060098a7b97376879ef2540fff0d9f94012318c5eb0bUpdated for recent changes to CLUBB.editcomponents/eam/src/physics/cam/clubb_intr.F90grid_class.F90advance_clubb_core_module.F90clubb_api_module.F906e985b7481ae287afeaf0a548e131482930840fe1699486824000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduRemoving begin_height and end_height as outputs from setup_grid. They are only necessary as local variables inside of setup_grid. 2023-11-08 17:40:24 -06006e985b7481ae287afeaf0a548e131482930840feRemoving begin_height and end_height as outputs from setup_grid. Theyeditgrid_class.F90editadvance_clubb_core_module.F90editclubb_api_module.F90components/eam/src/physics/cam/clubb_intr.F907970d3d740fdb90dba5d8c9f370c827a822a08eb1699487387000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdated for recent changes to CLUBB. 2023-11-08 17:49:47 -06007970d3d740fdb90dba5d8c9f370c827a822a08ebUpdated for recent changes to CLUBB.editcomponents/eam/src/physics/cam/clubb_intr.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse300http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/300/298http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/298/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break298d6a3fa41ebf8299994618d3c1197c6df70346d3bd6a3fa41ebf8299994618d3c1197c6df70346d3brefs/remotes/origin/clubb_silhs_develd6a3fa41ebf8299994618d3c1197c6df70346d3bd6a3fa41ebf8299994618d3c1197c6df70346d3brefs/remotes/origin/clubb_silhs_develd6a3fa41ebf8299994618d3c1197c6df70346d3bd6a3fa41ebf8299994618d3c1197c6df70346d3brefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#2985813263428101e3sm_run_gfortran_test #298298false29826574FAILURE1698825848520http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/298/mixing_length.F9022872a5139682034753065f97d05099ddf2e3a471698787332000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comLatest batch of non-bit changing code changes - CLUBB ticket #1115 (#1119) - Added new folder input/tunable_parameters_tauMatchLscale/ for latest taus code setup reproducing the master Lscale output. - Changes in src/CLUBB_core_mixing_length.F90: - Renamed ddzt_umvm -> ddzt_umvm_sqd ddzt_umvm_clipped -> ddzt_umvm_sqd_clipped sqrt_ddzt_umvm -> norm_ddzt_umvm smooth_sqrt_ddzt_umvm -> smooth_norm_ddzt_umvm Ri_zm_clipped -> Ri_zm_smooth in some places - Made some variable replacements for consistency's sake - Fixed path of log files in run_scripts/run_bindiff_all.py 2023-10-31 16:22:12 -050022872a5139682034753065f97d05099ddf2e3a47Latest batch of non-bit changing code changes - CLUBB ticket #1115 (#1119)editmixing_length.F90advance_clubb_core_module.F90mixing_length.F90337f2b0a17376a45c2c1ac2250b6cff75f15d6ad1698795774000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comBIT_CHANGING! Fixed some issues with wpxp_Ri_exp, changed z_displace value - CLUBB ticket #1115 (#1120) - Removed commented lines from tunable_parameters.in file in input/tunable_parameters_tauMatchLscale - Increased z_displace value from 10 to 25. This value was chosen so that the taus code with the parameter and flag settings in input/tunable_parameters_tauMatchLscale match the master Lscale output below clouds - Fixed some issues with the new parameter wpxp_Ri_exp: - Moved new exponentiation to a place so that it emulates the previous version with sqrt(Ri_zm) - Adjusted code for l_smooth_min_max=true to match the default version 2023-10-31 18:42:54 -0500337f2b0a17376a45c2c1ac2250b6cff75f15d6adBIT_CHANGING! Fixed some issues with wpxp_Ri_exp, changed z_displace value - CLUBB ticket #1115 (#1120)editadvance_clubb_core_module.F90editmixing_length.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse299http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/299/297http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/297/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2978de861c2e05851280678b22812b5102acfa102ac8de861c2e05851280678b22812b5102acfa102acrefs/remotes/origin/clubb_silhs_devel8de861c2e05851280678b22812b5102acfa102ac8de861c2e05851280678b22812b5102acfa102acrefs/remotes/origin/clubb_silhs_devel8de861c2e05851280678b22812b5102acfa102ac8de861c2e05851280678b22812b5102acfa102acrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#2975979113428101e3sm_run_gfortran_test #297297false29726304FAILURE1698221048892http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/297/stats_variables.F90stats_clubb_utilities.F90clubb_api_module.F909ca3f47f2c7361719136ed64975e29e55f8936261698188257000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comFinally removing scratch variables. (#1116) * Finally removing scratch variables. * Zeroing out below ground levels to prevent NaN in stats. 2023-10-24 17:57:37 -05009ca3f47f2c7361719136ed64975e29e55f893626Finally removing scratch variables. (#1116)editclubb_api_module.F90editstats_variables.F90editstats_clubb_utilities.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse298http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/298/296http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/296/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break296f026024d99da1dc9076680a26bb7c78f03cfcb43f026024d99da1dc9076680a26bb7c78f03cfcb43refs/remotes/origin/clubb_silhs_develf026024d99da1dc9076680a26bb7c78f03cfcb43f026024d99da1dc9076680a26bb7c78f03cfcb43refs/remotes/origin/clubb_silhs_develf026024d99da1dc9076680a26bb7c78f03cfcb43f026024d99da1dc9076680a26bb7c78f03cfcb43refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#29627287723428101e3sm_run_gfortran_test #296296false29626216SUCCESS1697789048566http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/296/advance_clubb_core_module.F90advance_helper_module.F904ebc70252b6ce52cfdb7883770217c34fd2e21071693937947000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comFixed some oversights for the bv_efold commits and increased string length for tuning field names for invrs_tau variables - CLUBB ticket #1069 (#1106) This commit is NOT bit changing - Removed remaining mentions of brunt_vaisala_freq_sqd_plus - Added assignment for invrs_tau_wp3_zm in Lscale mode in advance_clubb_core - Increased length of string variables hoc_v, les_v, and t_variables in src/error.F90 to accomodate tuning for invrs_tau fields 2023-09-05 13:19:07 -05004ebc70252b6ce52cfdb7883770217c34fd2e2107Fixed some oversights for the bv_efold commits and increased string length for tuning field names for invrs_tau variables - CLUBB ticket #1069 (#1106)editadvance_clubb_core_module.F90editadvance_helper_module.F90mixing_length.F90395023c230e9f1ddaa7411d592718b573ab65d151693950812000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comBIT_CHANGING! brunt_vaisala_freq_sqd_mixed now replaces brunt_vaisala_freq_sqd for later calculations - CLUBB ticket #1102 Changes in src/CLUBB_core/mixing_length.F90: - brunt_vaisala_freq_sqd_mixed is now used to calculate brunt_vaisala_freq_sqd_smth and brunt_vaisala_freq_sqd_clipped instead of brunt_vaisala_freq_sqd - Removed 0.1 factor for bkgnd term in calculation of invrs_tau_xp2_zm - Commented out clipping of invrs_tau_xp2_zm to 0.003 and lower out of cloud 2023-09-05 16:53:32 -0500395023c230e9f1ddaa7411d592718b573ab65d15BIT_CHANGING! brunt_vaisala_freq_sqd_mixed now replaces brunt_vaisala_freq_sqd for later calculations - CLUBB ticket #1102editmixing_length.F90model_flags.F907afb2bd7070e5e83204950c8b94a12b73b8f88fd1694635856000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comBIT_CHANGING for lscale setup. Updated configurable_model_flags.in and model_flags.F90 - CLUBB ticket #1102 (#1108) - Added new flags to inut/tunable_parameters_Lscale/configurable_model_flags.in - Changed default setting for l_use_tke_in_wp3_pr_turb_term in model_flags.F90 from false to true 2023-09-13 15:10:56 -05007afb2bd7070e5e83204950c8b94a12b73b8f88fdBIT_CHANGING for lscale setup. Updated configurable_model_flags.in and model_flags.F90 - CLUBB ticket #1102 (#1108)editmodel_flags.F90stats_zm_module.F90advance_clubb_core_module.F90stats_variables.F905256cf04633fd71551f6bd29ee0632494b611a931695154187000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comLikely BIT_CHANGING because of added output fields. Added code outputting C6_term and different Brunt Vaisala frequencies to disk - CLUBB ticket #1102 (#1109) - Added C6_term and bv_freq fields to all_stats.F90 and standard_stats.F90 - Added new fields to VariableGroupTaus.py in pyplotgen - Added calls to stat_update_var to advance_clubb_core_module.F90 - Modified stats_variables.F90 and stats_zm_module.F90 accordingly 2023-09-19 15:09:47 -05005256cf04633fd71551f6bd29ee0632494b611a93Likely BIT_CHANGING because of added output fields. Added code outputting C6_term and different Brunt Vaisala frequencies to disk - CLUBB ticket #1102 (#1109)editstats_zm_module.F90editadvance_clubb_core_module.F90editstats_variables.F90mixing_length.F90stats_zm_module.F90advance_clubb_core_module.F90stats_variables.F900735b8dca68da8eec17c24fca269223d8756e97a1695421268000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comChanged sqrt_Ri_zm to Ri_zm in preparation of changing the exponent for calculation of invrs_tau_wpxp_zm in mixing_length.F90 - CLUBB ticket #1102 (#1110) BIT_CHANGING! Changed sqrt_Ri_zm to Ri_zm in preparation of changing the exponent for calculation of invrs_tau_wpxp_zm in mixing_length.F90 - CLUBB ticket #1102 Changes in input/stats/all_stats.in, src/CLUBB_core/advance_clubb_core_module.F90, src/CLUBB_core/mixing_length.F90, src/CLUBB_core/stats_variables.F90, and src/CLUBB_core/stats_zm_module.F90 Ri_zm was added to input/stats/standard_stats.in 2023-09-22 17:21:08 -05000735b8dca68da8eec17c24fca269223d8756e97aChanged sqrt_Ri_zm to Ri_zm in preparation of changing the exponent for calculation of invrs_tau_wpxp_zm in mixing_length.F90 - CLUBB ticket #1102 (#1110)editstats_zm_module.F90editadvance_clubb_core_module.F90editmixing_length.F90editstats_variables.F90stats_variables.F90stats_zm_module.F90advance_helper_module.F9062e535382820e1ebdd77dbb79de655e217e552d91695428333000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comBIT_CHANGING! Removed Richardson_num and all corresponding code - CLUBB ticket #1102 (#1111) This commit is BIT_CHANGING because: 1. the output field Richardson_num was removed. 2. Since the flag l_use_shear_turb_freq_sqd was removed, the variable shear_sqd is now always written to disk. That means previously, the outputted field shear_sqd was 0 everywhere whereas now it is not anymore. The calculation of shear_sqd within CLUBB did not change! - Removed mentions in input/stats/all_stats.in and standards_stats.in - Removed mentions in src/CLUBB_core/stats_variables.F90 and stats_zm_module.F90 - In src/CLUBB_core/advance_helper_module.F90 removed mentions to [i]Richardson_num[_clipped], as well as l_use_shear_turb_freq_sqd, l_Richardson_vert_avg, and turb_freq_sqd sinc those are only used for calculation of Richardson_num. 2023-09-22 19:18:53 -050062e535382820e1ebdd77dbb79de655e217e552d9BIT_CHANGING! Removed Richardson_num and all corresponding code - CLUBB ticket #1102 (#1111)editadvance_helper_module.F90editstats_variables.F90editstats_zm_module.F90mixing_length.F90parameters_tunable.F90parameter_indices.F90clubb_api_module.F904263da9f7ae792444654c9d5acefb27ba5db0e061697137474000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comTunable Richardson number exponent - CLUBB ticket #1102 (#1114) BIT_CHANGING! Added the exponent to the Richardson number in the calculation of the invrs_tau_wpxp threshold term in src/CLUBB_core/mixing_length.F90 to the list of tunable parameters. This is bit changing due to the difference in Fortran between taking the sqrt and the .5th power. 2023-10-12 14:04:34 -05004263da9f7ae792444654c9d5acefb27ba5db0e06Tunable Richardson number exponent - CLUBB ticket #1102 (#1114)editclubb_api_module.F90editmixing_length.F90editparameter_indices.F90editparameters_tunable.F90advance_clubb_core_module.F901a7e15ee602ebadad150327e1e40ac59800ea1dc1697555413000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comDeletes svn id tag, will trigger host-model nightly tests. 2023-10-17 10:10:13 -05001a7e15ee602ebadad150327e1e40ac59800ea1dcDeletes svn id tag, will trigger host-model nightly tests.editadvance_clubb_core_module.F90advance_helper_module.F908be88d0f94ca7883638a1e87415cb48dc0d03ca01697723854000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemove svn id tag in order to trigger nightly tests. 2023-10-19 08:57:34 -05008be88d0f94ca7883638a1e87415cb48dc0d03ca0Remove svn id tag in order to trigger nightly tests.editadvance_helper_module.F90advance_windm_edsclrm_module.F90ffdd91c97979046cdbe2f9502cb3047a482c6da71697732821000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemoved 3rd svn id tag in order to trigger nightly tests 2023-10-19 11:27:01 -0500ffdd91c97979046cdbe2f9502cb3047a482c6da7Removed 3rd svn id tag in order to trigger nightly testseditadvance_windm_edsclrm_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse297http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/297/295http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/295/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break295c8542a09a79d31240a31ab76361cb18491d05a17c8542a09a79d31240a31ab76361cb18491d05a17refs/remotes/origin/clubb_silhs_develc8542a09a79d31240a31ab76361cb18491d05a17c8542a09a79d31240a31ab76361cb18491d05a17refs/remotes/origin/clubb_silhs_develc8542a09a79d31240a31ab76361cb18491d05a17c8542a09a79d31240a31ab76361cb18491d05a17refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#29523608433428101e3sm_run_gfortran_test #295295false29526112SUCCESS1697616248717http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/295/components/eam/bld/namelist_files/namelist_definition.xmlcomponents/eam/src/physics/cam/clubb_intr.F90c8542a09a79d31240a31ab76361cb18491d05a171697563398000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comwpxp_Ri_exp (#61) Added CLUBB parameter `wpxp_Ri_exp` to E3SM Branch test passed successfully 2023-10-17 12:23:18 -0500c8542a09a79d31240a31ab76361cb18491d05a17wpxp_Ri_exp (#61)editcomponents/eam/bld/namelist_files/namelist_definition.xmleditcomponents/eam/src/physics/cam/clubb_intr.F90githttp://carson.math.uwm.edu/jenkins/user/larsongroupsysadminLarsonGroupSysAdminhttp://carson.math.uwm.edu/jenkins/user/rootroothttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse296http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/296/294http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/294/Started by user Steffen DomkesdomkeSteffen Domke75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break294cf1849ec339094037474e42dbbcb6f2cba3706c8cf1849ec339094037474e42dbbcb6f2cba3706c8refs/remotes/origin/clubb_silhs_develcf1849ec339094037474e42dbbcb6f2cba3706c8cf1849ec339094037474e42dbbcb6f2cba3706c8refs/remotes/origin/clubb_silhs_develcf1849ec339094037474e42dbbcb6f2cba3706c8cf1849ec339094037474e42dbbcb6f2cba3706c8refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#2946501893428101e3sm_run_gfortran_test #294294false29426062FAILURE1697559666670http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/294/diagnostic_v2_0/draw_plots_hoz_2D.py739b351d4cda8de114ca0dba05ba4e89f69d095f1697549108000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate draw_plots_hoz_2D.py Clean up the code, use loops to get all regional files and observation files. 2023-10-17 21:25:08 +0800739b351d4cda8de114ca0dba05ba4e89f69d095fUpdate draw_plots_hoz_2D.pyeditdiagnostic_v2_0/draw_plots_hoz_2D.pydiagnostic_v2_0/E3SM_CLUBB_diag.py653636a0fb5bbe84be504e467c4ba66c74e4f11c1697550628000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate E3SM_CLUBB_diag.py Change the interface for new diagnostic code. We can set REG and its corresponding Latitude and longitude to generate (or modify) the new Regional files. 2023-10-17 21:50:28 +0800653636a0fb5bbe84be504e467c4ba66c74e4f11cUpdate E3SM_CLUBB_diag.pyeditdiagnostic_v2_0/E3SM_CLUBB_diag.pycomponents/eam/src/physics/clubb/advance_clubb_core_module.F90cf1849ec339094037474e42dbbcb6f2cba3706c81697555739000http://carson.math.uwm.edu/jenkins/user/larsongroupsysadminLarsonGroupSysAdminlarsongroupgithub@gmail.comRaw-copy updating components/eam/src/physics/clubb 2023-10-17 10:15:39 -0500cf1849ec339094037474e42dbbcb6f2cba3706c8Raw-copy updating components/eam/src/physics/clubbeditcomponents/eam/src/physics/clubb/advance_clubb_core_module.F90githttp://carson.math.uwm.edu/jenkins/user/larsongroupsysadminLarsonGroupSysAdminhttp://carson.math.uwm.edu/jenkins/user/rootroothttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse295http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/295/293http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/293/Started by user Steffen DomkesdomkeSteffen Domkefalse#2934163428101e3sm_run_gfortran_test #293293false29326059FAILURE1697559575889http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/293/http://carson.math.uwm.edu/jenkins/user/rootrootfalse294http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/294/292http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/292/Started by user Steffen DomkesdomkeSteffen Domkefalse#29281343428101e3sm_run_gfortran_test #292292false29226056ABORTED1697559006630http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/292/http://carson.math.uwm.edu/jenkins/user/rootrootfalse293http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/293/291http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/291/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break29155bb147fc8c5c603b8c58c5c697c3efca9a4c09055bb147fc8c5c603b8c58c5c697c3efca9a4c090refs/remotes/origin/clubb_silhs_devel55bb147fc8c5c603b8c58c5c697c3efca9a4c09055bb147fc8c5c603b8c58c5c697c3efca9a4c090refs/remotes/origin/clubb_silhs_devel55bb147fc8c5c603b8c58c5c697c3efca9a4c09055bb147fc8c5c603b8c58c5c697c3efca9a4c090refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#2914475683428101e3sm_run_gfortran_test #291291false29126002FAILURE1697270647185http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/291/components/eam/src/physics/clubb/parameter_indices.F90components/eam/src/physics/clubb/clubb_api_module.F90components/eam/src/physics/clubb/advance_helper_module.F90components/eam/src/physics/clubb/parameters_tunable.F90components/eam/src/physics/clubb/mixing_length.F90components/eam/src/physics/clubb/model_flags.F90components/eam/src/physics/clubb/advance_clubb_core_module.F90components/eam/src/physics/clubb/stats_zm_module.F90components/eam/src/physics/clubb/stats_variables.F9055bb147fc8c5c603b8c58c5c697c3efca9a4c0901697206890000http://carson.math.uwm.edu/jenkins/user/rootrootroot@carson.localdomainRaw-copy updating components/eam/src/physics/clubb 2023-10-13 09:21:30 -050055bb147fc8c5c603b8c58c5c697c3efca9a4c090Raw-copy updating components/eam/src/physics/clubbeditcomponents/eam/src/physics/clubb/model_flags.F90editcomponents/eam/src/physics/clubb/advance_clubb_core_module.F90editcomponents/eam/src/physics/clubb/stats_zm_module.F90editcomponents/eam/src/physics/clubb/parameter_indices.F90editcomponents/eam/src/physics/clubb/advance_helper_module.F90editcomponents/eam/src/physics/clubb/parameters_tunable.F90editcomponents/eam/src/physics/clubb/stats_variables.F90editcomponents/eam/src/physics/clubb/clubb_api_module.F90editcomponents/eam/src/physics/clubb/mixing_length.F90githttp://carson.math.uwm.edu/jenkins/user/rootrootfalse292http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/292/290http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/290/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break290e722eda4f99c2c4f979142d5cb3449cc6f0b2759e722eda4f99c2c4f979142d5cb3449cc6f0b2759refs/remotes/origin/clubb_silhs_devele722eda4f99c2c4f979142d5cb3449cc6f0b2759e722eda4f99c2c4f979142d5cb3449cc6f0b2759refs/remotes/origin/clubb_silhs_devele722eda4f99c2c4f979142d5cb3449cc6f0b2759e722eda4f99c2c4f979142d5cb3449cc6f0b2759refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#29027721333428101e3sm_run_gfortran_test #290290false29025702SUCCESS1696320249575http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/290/diagnostic_v2_0/draw_plots_hoz_2D.pydiagnostic_v2_0/E3SM_CLUBB_diag.pye722eda4f99c2c4f979142d5cb3449cc6f0b27591696298693000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdds code to loop over parameters instead of listing them all manually. 2023-10-02 21:04:53 -0500e722eda4f99c2c4f979142d5cb3449cc6f0b2759Adds code to loop over parameterseditdiagnostic_v2_0/draw_plots_hoz_2D.pyeditdiagnostic_v2_0/E3SM_CLUBB_diag.pygithttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse291http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/291/289http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/289/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break289929df778469f933c6309fd4ba86a572d4c21f886929df778469f933c6309fd4ba86a572d4c21f886refs/remotes/origin/clubb_silhs_devel929df778469f933c6309fd4ba86a572d4c21f886929df778469f933c6309fd4ba86a572d4c21f886refs/remotes/origin/clubb_silhs_devel929df778469f933c6309fd4ba86a572d4c21f886929df778469f933c6309fd4ba86a572d4c21f886refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#28922201263428101e3sm_run_gfortran_test #289289false28925206SUCCESS1694505848999http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/289/diagnostic_v2_0/draw_plots_hoz_2D.py929df778469f933c6309fd4ba86a572d4c21f8861694421011000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate draw_plots_hoz_2D.py Added two new metrics. RMSEP and RACC. 2023-09-11 16:30:11 +0800929df778469f933c6309fd4ba86a572d4c21f886Update draw_plots_hoz_2D.pyeditdiagnostic_v2_0/draw_plots_hoz_2D.pygithttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse290http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/290/288http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/288/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break288dd72b2f52160d6d8ec2c8f316e2efcdbd290f163dd72b2f52160d6d8ec2c8f316e2efcdbd290f163refs/remotes/origin/clubb_silhs_develdd72b2f52160d6d8ec2c8f316e2efcdbd290f163dd72b2f52160d6d8ec2c8f316e2efcdbd290f163refs/remotes/origin/clubb_silhs_develdd72b2f52160d6d8ec2c8f316e2efcdbd290f163dd72b2f52160d6d8ec2c8f316e2efcdbd290f163refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#28817400813428101e3sm_run_gfortran_test #288288false28825190SUCCESS1694419447990http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/288/diagnostic_v2_0/draw_plots_hoz_2D.pydd72b2f52160d6d8ec2c8f316e2efcdbd290f1631694403950000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate draw_plots_hoz_2D.py Fixed a bug about creating the Netcdf file of observational regional file. 2023-09-11 11:45:50 +0800dd72b2f52160d6d8ec2c8f316e2efcdbd290f163Update draw_plots_hoz_2D.pyeditdiagnostic_v2_0/draw_plots_hoz_2D.pygithttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse289http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/289/287http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/287/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break287c07ea88214ee717a74a824ca0aac79704678d1a1c07ea88214ee717a74a824ca0aac79704678d1a1refs/remotes/origin/clubb_silhs_develc07ea88214ee717a74a824ca0aac79704678d1a1c07ea88214ee717a74a824ca0aac79704678d1a1refs/remotes/origin/clubb_silhs_develc07ea88214ee717a74a824ca0aac79704678d1a1c07ea88214ee717a74a824ca0aac79704678d1a1refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#28722737523428101e3sm_run_gfortran_test #287287false28724972SUCCESS1693296246376http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/287/diagnostic_v2_0/draw_plots_hoz_2D.pyc07ea88214ee717a74a824ca0aac79704678d1a11693100242000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate draw_plots_hoz_2D.py Added the rmse function and the results are written to Regional files.This is not the final version. 2023-08-27 09:37:22 +0800c07ea88214ee717a74a824ca0aac79704678d1a1Update draw_plots_hoz_2D.pyeditdiagnostic_v2_0/draw_plots_hoz_2D.pygithttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse288http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/288/286http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/286/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break28683208c8afc80206acaa8ac82b8f8294d2b0b448283208c8afc80206acaa8ac82b8f8294d2b0b4482refs/remotes/origin/clubb_silhs_devel83208c8afc80206acaa8ac82b8f8294d2b0b448283208c8afc80206acaa8ac82b8f8294d2b0b4482refs/remotes/origin/clubb_silhs_devel83208c8afc80206acaa8ac82b8f8294d2b0b448283208c8afc80206acaa8ac82b8f8294d2b0b4482refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#28628126253428101e3sm_run_gfortran_test #286286false28624658SUCCESS1690963448072http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/286/advance_xp2_xpyp_module.F906fa34ce2d5ff0c26b7dcf4fed129a8d32ce7dc691690679815000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding wp_coef and wp_coef_zt to acc data statements. 2023-07-29 20:16:55 -05006fa34ce2d5ff0c26b7dcf4fed129a8d32ce7dc69Adding wp_coef and wp_coef_zt to acc data statements.editadvance_xp2_xpyp_module.F90mixing_length.F90advance_clubb_core_module.F90stats_zt_module.F90advance_helper_module.F90c0fdc2b307c5f63608c72f08ab493fce4516a7411690921282000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comBv efold bit changing (#1095) BIT_CHANGING! Added e-folding code for mixed Brunt Vaisala frequency - CLUBB ticket #1069 - Included usage for bv_efold in src/CLUBB_core/advance_helper_module.F90 - Added intent(out) for correction_stability in subroutine calc_correction_stability - Removed brunt_vaisala_freq_sqd_plus - Idiot proofed interaction between l_diag_Lscale_from_tau and l_use_invrs_tau_N2_iso - Moved stat_update_var(invrs_tau_wp3_zm) out of if ( l_diag_Lscale_from_tau ) - Fixed some typos in src/CLUBB_core/stats_zt_module.F90 - Added comment about to input_misc/tuner/README about t_variables adn input/stats/tuning_stats.in 2023-08-01 15:21:22 -0500c0fdc2b307c5f63608c72f08ab493fce4516a741Bv efold bit changing (#1095)editmixing_length.F90editstats_zt_module.F90editadvance_clubb_core_module.F90editadvance_helper_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse287http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/287/285http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/285/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break28502a366989b4435a2d60b876a5584c71eea375eb902a366989b4435a2d60b876a5584c71eea375eb9refs/remotes/origin/clubb_silhs_devel02a366989b4435a2d60b876a5584c71eea375eb902a366989b4435a2d60b876a5584c71eea375eb9refs/remotes/origin/clubb_silhs_devel02a366989b4435a2d60b876a5584c71eea375eb902a366989b4435a2d60b876a5584c71eea375eb9refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#28530294613428101e3sm_run_gfortran_test #285285false28524574SUCCESS1690358648975http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/285/Skx_module.F90advance_xp2_xpyp_module.F90mean_adv.F90e9ae50fd67886661f7d03ab3549044e5c2c9517a1690323761000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comBit changing changes (#1104) * Moving functions called inside loops to their own 2D subroutines. This is for performance, but is also BIT_CHANGING. * Correct range of values to calculate for term_dp1_lhs * Comments and cleanup * Slight change to Skx_func, this is mathematically equivalent but BIT_CHANGING. This is faster on GPUs, and doesn't seem to have a signficiant impact on CPU performance. * Introducing wp_coef and wp_coef_zt to reduce needed computations. This changes order of operations, so it is BIT_CHANGING. 2023-07-25 17:22:41 -0500e9ae50fd67886661f7d03ab3549044e5c2c9517aBit changing changes (#1104)editSkx_module.F90editadvance_xp2_xpyp_module.F90editmean_adv.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse286http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/286/284http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/284/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break284c6c7f1b252905f0413d60e205e71a3cf6180fe8ac6c7f1b252905f0413d60e205e71a3cf6180fe8arefs/remotes/origin/clubb_silhs_develc6c7f1b252905f0413d60e205e71a3cf6180fe8ac6c7f1b252905f0413d60e205e71a3cf6180fe8arefs/remotes/origin/clubb_silhs_develc6c7f1b252905f0413d60e205e71a3cf6180fe8ac6c7f1b252905f0413d60e205e71a3cf6180fe8arefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#28429300023428101e3sm_run_gfortran_test #284284false28424450SUCCESS1689753850814http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/284/diffusion.F90clip_semi_implicit.F90clubb_api_module.F90advance_xm_wpxp_module.F90clip_explicit.F90numerical_check.F90grid_class.F90penta_lu_solver.F90calc_roots.F90advance_windm_edsclrm_module.F90turbulent_adv_pdf.F90advance_helper_module.F90mono_flux_limiter.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_xp3_module.F90advance_clubb_core_module.F90tridiag_lu_solver.F90mean_adv.F90fill_holes.F90adg1_adg2_3d_luhar_pdf.F90corr_varnce_module.F901238826836d00367458527d254d2b3c9d7f87e931689730027000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comOpenacc tweaks and cleanup 2 (#1099) * Making all end parallel directives specify end loop * Replacing last acc declare in a procedure with acc enter/exit data commands * Removing pure declarations, turns out they dont really improve performance and openmp isn't allowed within them. * Adding explicit directives to penta_lu and tridiag_lu, as opposed to the previously used kernels directive. Also splitting up a loop to improve GPU performance. * Splitting up a couple loops for performance reasons. * Missed one somehow 2023-07-18 20:27:07 -05001238826836d00367458527d254d2b3c9d7f87e93Openacc tweaks and cleanup 2 (#1099)editadg1_adg2_3d_luhar_pdf.F90editgrid_class.F90editpenta_lu_solver.F90editmean_adv.F90editclubb_api_module.F90editadvance_xp3_module.F90editfill_holes.F90editadvance_xm_wpxp_module.F90editadvance_windm_edsclrm_module.F90editadvance_clubb_core_module.F90editcalc_roots.F90editclip_explicit.F90edittridiag_lu_solver.F90editadvance_helper_module.F90editdiffusion.F90editclip_semi_implicit.F90editcorr_varnce_module.F90editnumerical_check.F90editadvance_wp2_wp3_module.F90editturbulent_adv_pdf.F90editadvance_xp2_xpyp_module.F90editmono_flux_limiter.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse285http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/285/283http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/283/disabledStarted by an SCM changefalse#1105843428101e3sm_run_gfortran_test #11false1260FAILURE1609580889937http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/1/false2http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/2/Build stability: All recent builds failed.icon-health-00to19health-00to19.png0falseStarted by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break38396d0cb2d1dfdff676acb3473a0df8bfb8585e2b796d0cb2d1dfdff676acb3473a0df8bfb8585e2b7refs/remotes/origin/clubb_silhs_devel96d0cb2d1dfdff676acb3473a0df8bfb8585e2b796d0cb2d1dfdff676acb3473a0df8bfb8585e2b7refs/remotes/origin/clubb_silhs_devel96d0cb2d1dfdff676acb3473a0df8bfb8585e2b796d0cb2d1dfdff676acb3473a0df8bfb8585e2b7refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#383617423428101e3sm_run_gfortran_test #383383false3832715FAILURE1727251450737http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/383/advance_wp2_wp3_module.F90mixing_length.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90clubb_api_module.F90clip_explicit.F90numerical_check.F90stats_clubb_utilities.F90matrix_solver_wrapper.F90advance_windm_edsclrm_module.F90advance_helper_module.F90c3912e04050490382fe3e514cd9e4763ff18ecb81727204551000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comreduce compiler warnings (#1180) * refactor code to remove warnings for exceeding 100 characters per line * remove unused variables * remove unused parameters #1174 * fix for the GPU * remove new unused parameters * remove unused dummy arguments * make small changes to reduce compiler warnings * put solve_name back in as input variable to band_solve methods 2024-09-24 14:02:31 -0500c3912e04050490382fe3e514cd9e4763ff18ecb8reduce compiler warnings (#1180)editadvance_xp2_xpyp_module.F90editadvance_windm_edsclrm_module.F90editadvance_xm_wpxp_module.F90editclubb_api_module.F90editadvance_wp2_wp3_module.F90editnumerical_check.F90editstats_clubb_utilities.F90editclip_explicit.F90editmatrix_solver_wrapper.F90editmixing_length.F90editadvance_clubb_core_module.F90editadvance_helper_module.F90silhs_api_module.F90latin_hypercube_driver_module.F90004d3f520a1adab77ee44de70ebc6caca27074eb1727204551000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comreduce compiler warnings (#1180) * refactor code to remove warnings for exceeding 100 characters per line * remove unused variables * remove unused parameters #1174 * fix for the GPU * remove new unused parameters * remove unused dummy arguments * make small changes to reduce compiler warnings * put solve_name back in as input variable to band_solve methods 2024-09-24 14:02:31 -0500004d3f520a1adab77ee44de70ebc6caca27074ebreduce compiler warnings (#1180)editsilhs_api_module.F90editlatin_hypercube_driver_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonhttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse382http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/382/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break38396d0cb2d1dfdff676acb3473a0df8bfb8585e2b796d0cb2d1dfdff676acb3473a0df8bfb8585e2b7refs/remotes/origin/clubb_silhs_devel96d0cb2d1dfdff676acb3473a0df8bfb8585e2b796d0cb2d1dfdff676acb3473a0df8bfb8585e2b7refs/remotes/origin/clubb_silhs_devel96d0cb2d1dfdff676acb3473a0df8bfb8585e2b796d0cb2d1dfdff676acb3473a0df8bfb8585e2b7refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#383617423428101e3sm_run_gfortran_test #383383false3832715FAILURE1727251450737http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/383/advance_wp2_wp3_module.F90mixing_length.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90clubb_api_module.F90clip_explicit.F90numerical_check.F90stats_clubb_utilities.F90matrix_solver_wrapper.F90advance_windm_edsclrm_module.F90advance_helper_module.F90c3912e04050490382fe3e514cd9e4763ff18ecb81727204551000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comreduce compiler warnings (#1180) * refactor code to remove warnings for exceeding 100 characters per line * remove unused variables * remove unused parameters #1174 * fix for the GPU * remove new unused parameters * remove unused dummy arguments * make small changes to reduce compiler warnings * put solve_name back in as input variable to band_solve methods 2024-09-24 14:02:31 -0500c3912e04050490382fe3e514cd9e4763ff18ecb8reduce compiler warnings (#1180)editadvance_xp2_xpyp_module.F90editadvance_windm_edsclrm_module.F90editadvance_xm_wpxp_module.F90editclubb_api_module.F90editadvance_wp2_wp3_module.F90editnumerical_check.F90editstats_clubb_utilities.F90editclip_explicit.F90editmatrix_solver_wrapper.F90editmixing_length.F90editadvance_clubb_core_module.F90editadvance_helper_module.F90silhs_api_module.F90latin_hypercube_driver_module.F90004d3f520a1adab77ee44de70ebc6caca27074eb1727204551000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comreduce compiler warnings (#1180) * refactor code to remove warnings for exceeding 100 characters per line * remove unused variables * remove unused parameters #1174 * fix for the GPU * remove new unused parameters * remove unused dummy arguments * make small changes to reduce compiler warnings * put solve_name back in as input variable to band_solve methods 2024-09-24 14:02:31 -0500004d3f520a1adab77ee44de70ebc6caca27074ebreduce compiler warnings (#1180)editsilhs_api_module.F90editlatin_hypercube_driver_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonhttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse382http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/382/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break38396d0cb2d1dfdff676acb3473a0df8bfb8585e2b796d0cb2d1dfdff676acb3473a0df8bfb8585e2b7refs/remotes/origin/clubb_silhs_devel96d0cb2d1dfdff676acb3473a0df8bfb8585e2b796d0cb2d1dfdff676acb3473a0df8bfb8585e2b7refs/remotes/origin/clubb_silhs_devel96d0cb2d1dfdff676acb3473a0df8bfb8585e2b796d0cb2d1dfdff676acb3473a0df8bfb8585e2b7refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#383617423428101e3sm_run_gfortran_test #383383false3832715FAILURE1727251450737http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/383/advance_wp2_wp3_module.F90mixing_length.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90clubb_api_module.F90clip_explicit.F90numerical_check.F90stats_clubb_utilities.F90matrix_solver_wrapper.F90advance_windm_edsclrm_module.F90advance_helper_module.F90c3912e04050490382fe3e514cd9e4763ff18ecb81727204551000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comreduce compiler warnings (#1180) * refactor code to remove warnings for exceeding 100 characters per line * remove unused variables * remove unused parameters #1174 * fix for the GPU * remove new unused parameters * remove unused dummy arguments * make small changes to reduce compiler warnings * put solve_name back in as input variable to band_solve methods 2024-09-24 14:02:31 -0500c3912e04050490382fe3e514cd9e4763ff18ecb8reduce compiler warnings (#1180)editadvance_xp2_xpyp_module.F90editadvance_windm_edsclrm_module.F90editadvance_xm_wpxp_module.F90editclubb_api_module.F90editadvance_wp2_wp3_module.F90editnumerical_check.F90editstats_clubb_utilities.F90editclip_explicit.F90editmatrix_solver_wrapper.F90editmixing_length.F90editadvance_clubb_core_module.F90editadvance_helper_module.F90silhs_api_module.F90latin_hypercube_driver_module.F90004d3f520a1adab77ee44de70ebc6caca27074eb1727204551000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comreduce compiler warnings (#1180) * refactor code to remove warnings for exceeding 100 characters per line * remove unused variables * remove unused parameters #1174 * fix for the GPU * remove new unused parameters * remove unused dummy arguments * make small changes to reduce compiler warnings * put solve_name back in as input variable to band_solve methods 2024-09-24 14:02:31 -0500004d3f520a1adab77ee44de70ebc6caca27074ebreduce compiler warnings (#1180)editsilhs_api_module.F90editlatin_hypercube_driver_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonhttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse382http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/382/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break362e0525a5897b8eb3f00defd398aee668adb45d256e0525a5897b8eb3f00defd398aee668adb45d256refs/remotes/origin/clubb_silhs_devele0525a5897b8eb3f00defd398aee668adb45d256e0525a5897b8eb3f00defd398aee668adb45d256refs/remotes/origin/clubb_silhs_devele0525a5897b8eb3f00defd398aee668adb45d256e0525a5897b8eb3f00defd398aee668adb45d256refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#36230966223428101e3sm_run_gfortran_test #362362false362121SUCCESS1719993849035http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/362/mixing_length.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90advance_helper_module.F901af8762fc4b0c31a64535f1cb6689d893d0369261719948922000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRi_zm calc (Part 2) - Move the brunt_vaisala smoothing into calc_brunt_vaisala_freq_sqd (#1156) CLUBB ticket #1145 Includes previous steps: * First step: Move call to calc_bv * Ri_zm calc (Part 1.5) - Adjusted signature of diagnose_Lscale_from_tau #1145 Newest changes: Ri_zm calc (Part 2) - Move brunt_vaisala smoothing into calc_brunt_vaisala_freq_sqd `brunt_vaisala_frq_sqd_smth` is now calculated in subroutine `calc_brunt_vaisala_freq_sqd` and it is now written to disk in `advance_clubb_core` with all the other `brunt_vaisala` variables. Unfortunately, I had to make a couple more changes since moving this calculation into `calc_brunt_vaisala_freq_sqd` meant that any subroutine involved in calling `calc_stability_correction` would need to get `l_modify_limiters_for_cnvg_test` fed in, because `calc_brunt_vaisala_freq_sqd` is also called in `calc_stability_correction`. This commit is BIT_CHANGING since `brunt_vaisala_frq_sqd_smth` used to be all zeros before this change in Lscale mode and now it is actually calculated. BFB in taus code. 2024-07-02 14:35:22 -05001af8762fc4b0c31a64535f1cb6689d893d036926Ri_zm calc (Part 2) - Move the brunt_vaisala smoothing into calc_brunt_vaisala_freq_sqd (#1156)editadvance_clubb_core_module.F90editadvance_helper_module.F90editmixing_length.F90editadvance_xm_wpxp_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse363http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/363/361http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/361/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break362e0525a5897b8eb3f00defd398aee668adb45d256e0525a5897b8eb3f00defd398aee668adb45d256refs/remotes/origin/clubb_silhs_devele0525a5897b8eb3f00defd398aee668adb45d256e0525a5897b8eb3f00defd398aee668adb45d256refs/remotes/origin/clubb_silhs_devele0525a5897b8eb3f00defd398aee668adb45d256e0525a5897b8eb3f00defd398aee668adb45d256refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#36230966223428101e3sm_run_gfortran_test #362362false362121SUCCESS1719993849035http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/362/mixing_length.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90advance_helper_module.F901af8762fc4b0c31a64535f1cb6689d893d0369261719948922000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRi_zm calc (Part 2) - Move the brunt_vaisala smoothing into calc_brunt_vaisala_freq_sqd (#1156) CLUBB ticket #1145 Includes previous steps: * First step: Move call to calc_bv * Ri_zm calc (Part 1.5) - Adjusted signature of diagnose_Lscale_from_tau #1145 Newest changes: Ri_zm calc (Part 2) - Move brunt_vaisala smoothing into calc_brunt_vaisala_freq_sqd `brunt_vaisala_frq_sqd_smth` is now calculated in subroutine `calc_brunt_vaisala_freq_sqd` and it is now written to disk in `advance_clubb_core` with all the other `brunt_vaisala` variables. Unfortunately, I had to make a couple more changes since moving this calculation into `calc_brunt_vaisala_freq_sqd` meant that any subroutine involved in calling `calc_stability_correction` would need to get `l_modify_limiters_for_cnvg_test` fed in, because `calc_brunt_vaisala_freq_sqd` is also called in `calc_stability_correction`. This commit is BIT_CHANGING since `brunt_vaisala_frq_sqd_smth` used to be all zeros before this change in Lscale mode and now it is actually calculated. BFB in taus code. 2024-07-02 14:35:22 -05001af8762fc4b0c31a64535f1cb6689d893d036926Ri_zm calc (Part 2) - Move the brunt_vaisala smoothing into calc_brunt_vaisala_freq_sqd (#1156)editadvance_clubb_core_module.F90editadvance_helper_module.F90editmixing_length.F90editadvance_xm_wpxp_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse363http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/363/361http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/361/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break38396d0cb2d1dfdff676acb3473a0df8bfb8585e2b796d0cb2d1dfdff676acb3473a0df8bfb8585e2b7refs/remotes/origin/clubb_silhs_devel96d0cb2d1dfdff676acb3473a0df8bfb8585e2b796d0cb2d1dfdff676acb3473a0df8bfb8585e2b7refs/remotes/origin/clubb_silhs_devel96d0cb2d1dfdff676acb3473a0df8bfb8585e2b796d0cb2d1dfdff676acb3473a0df8bfb8585e2b7refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#383617423428101e3sm_run_gfortran_test #383383false3832715FAILURE1727251450737http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/383/advance_wp2_wp3_module.F90mixing_length.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90clubb_api_module.F90clip_explicit.F90numerical_check.F90stats_clubb_utilities.F90matrix_solver_wrapper.F90advance_windm_edsclrm_module.F90advance_helper_module.F90c3912e04050490382fe3e514cd9e4763ff18ecb81727204551000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comreduce compiler warnings (#1180) * refactor code to remove warnings for exceeding 100 characters per line * remove unused variables * remove unused parameters #1174 * fix for the GPU * remove new unused parameters * remove unused dummy arguments * make small changes to reduce compiler warnings * put solve_name back in as input variable to band_solve methods 2024-09-24 14:02:31 -0500c3912e04050490382fe3e514cd9e4763ff18ecb8reduce compiler warnings (#1180)editadvance_xp2_xpyp_module.F90editadvance_windm_edsclrm_module.F90editadvance_xm_wpxp_module.F90editclubb_api_module.F90editadvance_wp2_wp3_module.F90editnumerical_check.F90editstats_clubb_utilities.F90editclip_explicit.F90editmatrix_solver_wrapper.F90editmixing_length.F90editadvance_clubb_core_module.F90editadvance_helper_module.F90silhs_api_module.F90latin_hypercube_driver_module.F90004d3f520a1adab77ee44de70ebc6caca27074eb1727204551000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comreduce compiler warnings (#1180) * refactor code to remove warnings for exceeding 100 characters per line * remove unused variables * remove unused parameters #1174 * fix for the GPU * remove new unused parameters * remove unused dummy arguments * make small changes to reduce compiler warnings * put solve_name back in as input variable to band_solve methods 2024-09-24 14:02:31 -0500004d3f520a1adab77ee44de70ebc6caca27074ebreduce compiler warnings (#1180)editsilhs_api_module.F90editlatin_hypercube_driver_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonhttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse382http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/382/384truetruefalsefalse