Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break922b3932c9e748dfb0422dd8595f3f3781c5dfe0162b3932c9e748dfb0422dd8595f3f3781c5dfe016refs/remotes/origin/clubb_silhs_devel2b3932c9e748dfb0422dd8595f3f3781c5dfe0162b3932c9e748dfb0422dd8595f3f3781c5dfe016refs/remotes/origin/clubb_silhs_devel2b3932c9e748dfb0422dd8595f3f3781c5dfe0162b3932c9e748dfb0422dd8595f3f3781c5dfe016refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/92/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/92/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/92/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/92/testsfalseCheckout Branch and SubmodulesModify Run ScriptsRun BOMEXRun DYCOMSrf01Run RICOfalse#928758773428101e3sm_run_gfortran_test #9292false927423SUCCESS1627718647458http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/92/setup_clubb_pdf_params.F90d7fab3c6bdd5d928a2f6c377fe38514933d91cae1627654958000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduRemoving l_interp_prescribed_params from setup_clubb_pdf_params. The flag has been removed and so has any code underneat a logic statement involving this statement unless it has multiple flags. The else statement in the if block involving this flag has been set to execute without an if block. For ticket #916 Results are BFB identical. Additionally, complex logic statements with the use of more flags had those flags adjusted and BFB results were also confirmed with these changes. 2021-07-30 09:22:38 -0500d7fab3c6bdd5d928a2f6c377fe38514933d91caeRemoving l_interp_prescribed_params from setup_clubb_pdf_params.editsetup_clubb_pdf_params.F90githttp://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodeskfalseStarted by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break938efc91cec846061aa8b653e4b85e85af00d6340e8efc91cec846061aa8b653e4b85e85af00d6340erefs/remotes/origin/clubb_silhs_devel8efc91cec846061aa8b653e4b85e85af00d6340e8efc91cec846061aa8b653e4b85e85af00d6340erefs/remotes/origin/clubb_silhs_devel8efc91cec846061aa8b653e4b85e85af00d6340e8efc91cec846061aa8b653e4b85e85af00d6340erefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#939407143428101e3sm_run_gfortran_test #9393false937491SUCCESS1627977849533http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/93/calendar.F90clubb_api_module.F90clip_explicit.F90input_reader.F90diagnose_correlations_module.F90grid_class.F90setup_clubb_pdf_params.F90mono_flux_limiter.F90mixing_length.F90advance_wp2_wp3_module.F90file_functions.F90advance_xp2_xpyp_module.F90output_grads.F90stats_rad_zt_module.F90stats_rad_zm_module.F90pdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F90code_timer_module.F90corr_varnce_module.F90precipitation_fraction.F90clip_semi_implicit.F90numerical_check.F90output_netcdf.F90mt95.f90pdf_parameter_module.F90parameters_tunable.F90sponge_layer_damping.F90advance_clubb_core_module.F90advance_xp3_module.F90stats_zt_module.F90fill_holes.F90stats_clubb_utilities.F90stats_zm_module.F90interpolation.F90sfc_varnce_module.F90matrix_operations.F903f4568e6d528cb591d7bbdd4b36faea5c65ab97d1627927021000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduAdding comments labeling subroutine calls with intent. Goes all the way up until stats_clubb_utils. BFB identical. For ticket #942. 2021-08-02 12:57:01 -05003f4568e6d528cb591d7bbdd4b36faea5c65ab97dAdding comments labeling subroutine calls with intent.editclubb_api_module.F90editgrid_class.F90editstats_clubb_utilities.F90editstats_rad_zt_module.F90editinput_reader.F90editsfc_varnce_module.F90editpdf_parameter_module.F90editcalendar.F90editsetup_clubb_pdf_params.F90editadvance_clubb_core_module.F90editparameters_tunable.F90editprecipitation_fraction.F90editoutput_grads.F90editfile_functions.F90editmixing_length.F90editclip_semi_implicit.F90editstats_zt_module.F90editstats_zm_module.F90editcorr_varnce_module.F90editmono_flux_limiter.F90editmt95.f90editcode_timer_module.F90editmatrix_operations.F90editstats_rad_zm_module.F90editadvance_wp2_wp3_module.F90editadvance_xp3_module.F90editoutput_netcdf.F90editinterpolation.F90editclip_explicit.F90editdiagnose_correlations_module.F90editnumerical_check.F90editadg1_adg2_3d_luhar_pdf.F90editpdf_closure_module.F90editadvance_xp2_xpyp_module.F90editsponge_layer_damping.F90editfill_holes.F90githttp://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskfalse94http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/94/92http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/92/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break9108aefbda3d66b9c2eefe76268da68f29aae88add08aefbda3d66b9c2eefe76268da68f29aae88addrefs/remotes/origin/clubb_silhs_devel08aefbda3d66b9c2eefe76268da68f29aae88add08aefbda3d66b9c2eefe76268da68f29aae88addrefs/remotes/origin/clubb_silhs_devel08aefbda3d66b9c2eefe76268da68f29aae88add08aefbda3d66b9c2eefe76268da68f29aae88addrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#918670603428101e3sm_run_gfortran_test #9191false917357SUCCESS1627632247461http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/91/advance_clubb_core_module.F90setup_clubb_pdf_params.F90advance_xp2_xpyp_module.F90e542998c8db09fe108f69821eef74868caba2c461627569049000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFixing coding standard viloation of lines exceeding 100 characters. Violations were introduced as a result of changes made by ticket #733, this commit resolves the coding standard violations. Results BFB identical. 2021-07-29 09:30:49 -0500e542998c8db09fe108f69821eef74868caba2c46Fixing coding standard viloation of lines exceeding 100 characters.editadvance_xp2_xpyp_module.F90editadvance_clubb_core_module.F90editsetup_clubb_pdf_params.F90silhs_api_module.F90d5bdc8fbbb988928416a1fff23ec2592bb6142cd1627569049000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFixing coding standard viloation of lines exceeding 100 characters. Violations were introduced as a result of changes made by ticket #733, this commit resolves the coding standard violations. Results BFB identical. 2021-07-29 09:30:49 -0500d5bdc8fbbb988928416a1fff23ec2592bb6142cdFixing coding standard viloation of lines exceeding 100 characters.editsilhs_api_module.F90advance_wp2_wp3_module.F90parameters_tunable.F90stats_variables.F90parameter_indices.F90stats_zt_module.F90b1418c5d2b27c7560b6e18d9b05837722e7b13bb1627579701000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding wp3_pr_tp (aka "negative nose" term) to wp3 equation. Related to #920. This is not set up to change results currently, since the coefficient of the new term is zero, but it is BIT_CHANGING since it will include new output in the netcdf files. Also includes updates to pyplotgen to accommodate the new term. 2021-07-29 12:28:21 -0500b1418c5d2b27c7560b6e18d9b05837722e7b13bbAdding wp3_pr_tp (aka "negative nose" term) to wp3 equation. Related to #920.editadvance_wp2_wp3_module.F90editparameter_indices.F90editstats_zt_module.F90editparameters_tunable.F90editstats_variables.F90parameters_tunable.F90advance_wp2_wp3_module.F90stats_zt_module.F903c12f9c674cc1a5d8e49b0f2c71ca8e2159fcc991627579701000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comChanging the way the new wp3_pr_tp term works, by generalizing the wp3_terp_pr_lhs subroutine. Also cleaning up comments and changing the description of the wp3_pr_tp variable in the netcdf output files, hence this commit is BIT_CHANGING, although it will not affect numerical results since the wp3_pr_tp coefficient (C_wp3_pr_tp) is set to zero. Related to #920. 2021-07-29 12:28:21 -05003c12f9c674cc1a5d8e49b0f2c71ca8e2159fcc99Changing the way the new wp3_pr_tp term works, by generalizing the wp3_terp_pr_lhs subroutine. Also cleaning up comments and changing the description of the wp3_pr_tp variable in the netcdf output files, hence this commit is BIT_CHANGING, although it will not affect numerical results since the wp3_pr_tp coefficient (C_wp3_pr_tp) is set to zero.editparameters_tunable.F90editadvance_wp2_wp3_module.F90editstats_zt_module.F90githttp://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskhttp://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens82false92http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/92/90http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/90/