Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3693ec29b165cfad789324407d03730bb7a72d0a61a3ec29b165cfad789324407d03730bb7a72d0a61arefs/remotes/origin/clubb_silhs_devel3ec29b165cfad789324407d03730bb7a72d0a61a3ec29b165cfad789324407d03730bb7a72d0a61arefs/remotes/origin/clubb_silhs_devel3ec29b165cfad789324407d03730bb7a72d0a61a3ec29b165cfad789324407d03730bb7a72d0a61arefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/369/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/369/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/369/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/369/testsfalseCheckout Branch and Submodulesfalse#369496513428101e3sm_run_gfortran_test #369369false3691102FAILURE1722499449259http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/369/mono_flux_limiter.F90c304d15ab5483f1e7f0b0de1b9f01f06fb7d09b91722452248000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing GPU bug. There is a vertical dependency with wpxp. This is what was breaking the ECT test, see larson-group/cam#175 2024-07-31 13:57:28 -0500c304d15ab5483f1e7f0b0de1b9f01f06fb7d09b9Fixing GPU bug. There is a vertical dependency with wpxp. This is what was breaking the ECT test, see larson-group/cam#175editmono_flux_limiter.F90advance_clubb_core_module.F90pdf_closure_module.F9032a74a3cbba967b1b3558708ca78d7929dee6d601722455629000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bugs that are only caught when not outputting w_[up/down]_in_cloud stats or if l_host_applies_sfc_fluxes=.true. The l_host_applies_sfc_fluxes=.true. isn't testable (at least not in clubb_standalone), and I just caught that visually. The cloudy_updraft_frac and cloudy_downdraft_frac fields not being set were only noticable in cam, because we always run with iw_up_in_cloud>0 and iw_down_in_cloud>0 to output stats. 2024-07-31 14:53:49 -050032a74a3cbba967b1b3558708ca78d7929dee6d60Fixing bugs that are only caught when not outputting w_[up/down]_in_cloud stats or if l_host_applies_sfc_fluxes=.true. The l_host_applies_sfc_fluxes=.true. isn't testable (at least not in clubb_standalone), and I just caught that visually. The cloudy_updraft_frac and cloudy_downdraft_frac fields not being set were only noticable in cam, because we always run with iw_up_in_cloud>0 and iw_down_in_cloud>0 to output stats.editadvance_clubb_core_module.F90editpdf_closure_module.F90clubb_api_module.F9055c6276fbb2a1eb3db01e7b71a7909c22b694d3d1722465051000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMoving pdf_params copying to copyin. This is the data structure that contains pointers, and these pointers will be different on the host and device, so it is bad in theory to copy the structure back to the CPU as it might overwrite cpu memory pointers with gpu memory pointers. In practice though I've seen no problems caused by this, I'm just making this commit preemptively, and it has already been tested with the ECT test. 2024-07-31 17:30:51 -050055c6276fbb2a1eb3db01e7b71a7909c22b694d3dMoving pdf_params copying to copyin. This is the data structure that contains pointers, and these pointers will be different on the host and device, so it is bad in theory to copy the structure back to the CPU as it might overwrite cpu memory pointers with gpu memory pointers. In practice though I've seen no problems caused by this, I'm just making this commit preemptively, and it has already been tested with the ECT test.editclubb_api_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther HueblerhueblerfalseStarted by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break370192d30265348c90d246e67b9bef73fde8df5bcae192d30265348c90d246e67b9bef73fde8df5bcaerefs/remotes/origin/clubb_silhs_devel192d30265348c90d246e67b9bef73fde8df5bcae192d30265348c90d246e67b9bef73fde8df5bcaerefs/remotes/origin/clubb_silhs_devel192d30265348c90d246e67b9bef73fde8df5bcae192d30265348c90d246e67b9bef73fde8df5bcaerefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#370634283428101e3sm_run_gfortran_test #370370false3701164FAILURE1722585848199http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/370/.gitmodules192d30265348c90d246e67b9bef73fde8df5bcae1722546285000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing .gitmodules so submodules are cloned via https instead of ssh. See comment https://github.com/larson-group/sys_admin/issues/629\#issuecomment-561306186 and commit 4efea21 for slightly more info. 2024-08-01 16:04:45 -0500192d30265348c90d246e67b9bef73fde8df5bcaeFixing .gitmodules so submodules are cloned via https instead of ssh. See comment https://github.com/larson-group/sys_admin/issues/629\#issuecomment-561306186 and commit 4efea21 for slightly more info.edit.gitmodulesgithttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse371http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/371/369http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/369/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break36817fdf631073cfd9d0af7371a8bb7c0bcb064bb7617fdf631073cfd9d0af7371a8bb7c0bcb064bb76refs/remotes/origin/clubb_silhs_devel17fdf631073cfd9d0af7371a8bb7c0bcb064bb7617fdf631073cfd9d0af7371a8bb7c0bcb064bb76refs/remotes/origin/clubb_silhs_devel17fdf631073cfd9d0af7371a8bb7c0bcb064bb7617fdf631073cfd9d0af7371a8bb7c0bcb064bb76refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#368644153428101e3sm_run_gfortran_test #368368false368968FAILURE1721462648178http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/368/advance_xp2_xpyp_module.F9023f82fdc538b5a645dba8762085bfa621791cf471721419124000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduMaking a change to the l_C2_cloud_frac option with advance_xp2_xpyp. Cloud fraction needed to be interpolated to momentum levels for proper use in the code. Since this code change does not change CLUBB's default configuration, results are bit-for-bit for the default configuration. 2024-07-19 14:58:44 -050023f82fdc538b5a645dba8762085bfa621791cf47Making a change to the l_C2_cloud_frac option with advance_xp2_xpyp.editadvance_xp2_xpyp_module.F90advance_clubb_core_module.F90clubb_api_module.F909109926fff1ccf00b6495ec70ae57350d85a32ce1721424813000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bug. qclvar copying is handled by the api, but we were deleting it with an unstructured data statement. I added this due as a fix before thinking qclvar was a local variable, which happened because I mixed up the CLUBB_CAM and CLUBBND_CAM flags. https://github.com/larson-group/cam/issues/175 2024-07-19 15:33:33 -06009109926fff1ccf00b6495ec70ae57350d85a32ceFixing bug. qclvar copying is handled by the api, but we were deleting it with an unstructured data statement. I added this due as a fix before thinking qclvar was a local variable, which happened because I mixed up the CLUBB_CAM and CLUBBND_CAM flags. https://github.com/larson-group/cam/issues/175editadvance_clubb_core_module.F90editclubb_api_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse369http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/369/367http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/367/