Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break36817fdf631073cfd9d0af7371a8bb7c0bcb064bb7617fdf631073cfd9d0af7371a8bb7c0bcb064bb76refs/remotes/origin/clubb_silhs_devel17fdf631073cfd9d0af7371a8bb7c0bcb064bb7617fdf631073cfd9d0af7371a8bb7c0bcb064bb76refs/remotes/origin/clubb_silhs_devel17fdf631073cfd9d0af7371a8bb7c0bcb064bb7617fdf631073cfd9d0af7371a8bb7c0bcb064bb76refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/368/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/368/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/368/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/368/testsfalseCheckout Branch and Submodulesfalse#368644153428101e3sm_run_gfortran_test #368368false368968FAILURE1721462648178http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/368/advance_xp2_xpyp_module.F9023f82fdc538b5a645dba8762085bfa621791cf471721419124000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduMaking a change to the l_C2_cloud_frac option with advance_xp2_xpyp. Cloud fraction needed to be interpolated to momentum levels for proper use in the code. Since this code change does not change CLUBB's default configuration, results are bit-for-bit for the default configuration. 2024-07-19 14:58:44 -050023f82fdc538b5a645dba8762085bfa621791cf47Making a change to the l_C2_cloud_frac option with advance_xp2_xpyp.editadvance_xp2_xpyp_module.F90advance_clubb_core_module.F90clubb_api_module.F909109926fff1ccf00b6495ec70ae57350d85a32ce1721424813000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bug. qclvar copying is handled by the api, but we were deleting it with an unstructured data statement. I added this due as a fix before thinking qclvar was a local variable, which happened because I mixed up the CLUBB_CAM and CLUBBND_CAM flags. https://github.com/larson-group/cam/issues/175 2024-07-19 15:33:33 -06009109926fff1ccf00b6495ec70ae57350d85a32ceFixing bug. qclvar copying is handled by the api, but we were deleting it with an unstructured data statement. I added this due as a fix before thinking qclvar was a local variable, which happened because I mixed up the CLUBB_CAM and CLUBBND_CAM flags. https://github.com/larson-group/cam/issues/175editadvance_clubb_core_module.F90editclubb_api_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther HueblerhueblerfalseStarted by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3693ec29b165cfad789324407d03730bb7a72d0a61a3ec29b165cfad789324407d03730bb7a72d0a61arefs/remotes/origin/clubb_silhs_devel3ec29b165cfad789324407d03730bb7a72d0a61a3ec29b165cfad789324407d03730bb7a72d0a61arefs/remotes/origin/clubb_silhs_devel3ec29b165cfad789324407d03730bb7a72d0a61a3ec29b165cfad789324407d03730bb7a72d0a61arefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#369496513428101e3sm_run_gfortran_test #369369false3691102FAILURE1722499449259http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/369/mono_flux_limiter.F90c304d15ab5483f1e7f0b0de1b9f01f06fb7d09b91722452248000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing GPU bug. There is a vertical dependency with wpxp. This is what was breaking the ECT test, see larson-group/cam#175 2024-07-31 13:57:28 -0500c304d15ab5483f1e7f0b0de1b9f01f06fb7d09b9Fixing GPU bug. There is a vertical dependency with wpxp. This is what was breaking the ECT test, see larson-group/cam#175editmono_flux_limiter.F90advance_clubb_core_module.F90pdf_closure_module.F9032a74a3cbba967b1b3558708ca78d7929dee6d601722455629000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bugs that are only caught when not outputting w_[up/down]_in_cloud stats or if l_host_applies_sfc_fluxes=.true. The l_host_applies_sfc_fluxes=.true. isn't testable (at least not in clubb_standalone), and I just caught that visually. The cloudy_updraft_frac and cloudy_downdraft_frac fields not being set were only noticable in cam, because we always run with iw_up_in_cloud>0 and iw_down_in_cloud>0 to output stats. 2024-07-31 14:53:49 -050032a74a3cbba967b1b3558708ca78d7929dee6d60Fixing bugs that are only caught when not outputting w_[up/down]_in_cloud stats or if l_host_applies_sfc_fluxes=.true. The l_host_applies_sfc_fluxes=.true. isn't testable (at least not in clubb_standalone), and I just caught that visually. The cloudy_updraft_frac and cloudy_downdraft_frac fields not being set were only noticable in cam, because we always run with iw_up_in_cloud>0 and iw_down_in_cloud>0 to output stats.editadvance_clubb_core_module.F90editpdf_closure_module.F90clubb_api_module.F9055c6276fbb2a1eb3db01e7b71a7909c22b694d3d1722465051000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMoving pdf_params copying to copyin. This is the data structure that contains pointers, and these pointers will be different on the host and device, so it is bad in theory to copy the structure back to the CPU as it might overwrite cpu memory pointers with gpu memory pointers. In practice though I've seen no problems caused by this, I'm just making this commit preemptively, and it has already been tested with the ECT test. 2024-07-31 17:30:51 -050055c6276fbb2a1eb3db01e7b71a7909c22b694d3dMoving pdf_params copying to copyin. This is the data structure that contains pointers, and these pointers will be different on the host and device, so it is bad in theory to copy the structure back to the CPU as it might overwrite cpu memory pointers with gpu memory pointers. In practice though I've seen no problems caused by this, I'm just making this commit preemptively, and it has already been tested with the ECT test.editclubb_api_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse370http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/370/368http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/368/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3672ff840062349e6f41bf60d02587ea404ed5e6df42ff840062349e6f41bf60d02587ea404ed5e6df4refs/remotes/origin/clubb_silhs_devel2ff840062349e6f41bf60d02587ea404ed5e6df42ff840062349e6f41bf60d02587ea404ed5e6df4refs/remotes/origin/clubb_silhs_devel2ff840062349e6f41bf60d02587ea404ed5e6df42ff840062349e6f41bf60d02587ea404ed5e6df4refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#367491883428101e3sm_run_gfortran_test #367367false367896FAILURE1721376248772http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/367/latin_hypercube_driver_module.F90fd2a66ac11b726371135f2233834e2e87562682c1721277738000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduIn my previous commit, I changed the domain of the maxloc commands in the computation of k_lh_start to check over the arrays from levels 2:nz. However, when that happens, the output will be offset by 1. Consider a situation where the rcm max is at level 2. By being passed 2 through nz only, maxloc will return a value of 1. I needed to add +1 to the output to rectify this issue. The results are BIT_CHANGING. 2024-07-17 23:42:18 -0500fd2a66ac11b726371135f2233834e2e87562682cIn my previous commit, I changed the domain of the maxloc commandseditlatin_hypercube_driver_module.F90stats_clubb_utilities.F90precipitation_fraction.F900df67106e4001e1eda48b4740fe1b065df06cd771721289115000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThis commit brings the stats output from the all cases run with the master branch (using the default configuration) in bit-for-bit agreement with the stats output from all cases run with the clubb_ghost_exorcism branch. Of course, this agreement ignores the ghost level output in the zt files run with the master branch. This commit is technically BIT_CHANGING because it alters a few stats for a couple cases, but does not change results. 2024-07-18 02:51:55 -05000df67106e4001e1eda48b4740fe1b065df06cd77This commit brings the stats output from the all cases run witheditstats_clubb_utilities.F90editprecipitation_fraction.F90pdf_closure_module.F903e891b5d456b4ea869955e73e012cdd21813c1d91721347695000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduCommitting a change that will initialize this set of variables under all circumstances. This change does not affect output except when the New Hybrid PDF is used. In the case of the New Hybrid PDF, the variables F_rt, F_thl, F_rt_min, F_rt_max, F_thl_min, and F_thl_max were never initialized and never set (they are not part of the New Hybrid PDF -- only in the original New PDF), resulting NaN values being output to stat files. 2024-07-18 19:08:15 -05003e891b5d456b4ea869955e73e012cdd21813c1d9Committing a change that will initialize this set of variableseditpdf_closure_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse368http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/368/366http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/366/