Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break350f85233ca5819e5fff7567dc3b20516c51f6f73c7f85233ca5819e5fff7567dc3b20516c51f6f73c7refs/remotes/origin/clubb_silhs_develf85233ca5819e5fff7567dc3b20516c51f6f73c7f85233ca5819e5fff7567dc3b20516c51f6f73c7refs/remotes/origin/clubb_silhs_develf85233ca5819e5fff7567dc3b20516c51f6f73c7f85233ca5819e5fff7567dc3b20516c51f6f73c7refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/350/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/350/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/350/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/350/testsfalseCheckout Branch and SubmodulesModify Run ScriptsRun BOMEXRun DYCOMSrf01Run RICORun ARM97false#35027913613428101e3sm_run_gfortran_test #350350false3501297SUCCESS1714637106176http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/350/advance_clubb_core_module.F90d6ca5b0e6179de58c7571bea8650e3cd93c3de5e1714537919000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bug. RESOLVED:556370c6406e6b943b88affbe7728a5036b1ba22, this was catchable by using debugging flags, but seems to otherwise cause no issues. Investigating I found that it only clips the below ground level, so that must not have been affecting other levels. This is technically BIT_CHANGING since it resolves an issue. 2024-04-30 23:31:59 -0500d6ca5b0e6179de58c7571bea8650e3cd93c3de5eFixing bug. RESOLVED:556370c6406e6b943b88affbe7728a5036b1ba22, this was catchable by using debugging flags, but seems to otherwise cause no issues. Investigating I found that it only clips the below ground level, so that must not have been affecting other levels. This is technically BIT_CHANGING since it resolves an issue.editadvance_clubb_core_module.F90advance_wp2_wp3_module.F90fill_holes.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90clubb_api_module.F90c2849fa3c750562ffdd5abd6bc9937c081e662261714587276000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking num_draw_points in fill_holes a constant. We were already using this value as a constant everywhere, but passing a constant by argument list makes it difficult/impossible for a compiler to optimize using that constant, unless it does inlining. Now, rather than passing the constant num_hf_draw_points (or sometimes a hardcoded 2) we just use num_hf_draw_points directly from constants_clubb. This massively improves the performance of a loop in fill holes when using nvhpc+omp, which was the motivation for this, but should also improve the performance on CPUs. Everything is BFB. 2024-05-01 13:14:36 -0500c2849fa3c750562ffdd5abd6bc9937c081e66226Making num_draw_points in fill_holes a constant. We were already using this value as a constant everywhere, but passing a constant by argument list makes it difficult/impossible for a compiler to optimize using that constant, unless it does inlining. Now, rather than passing the constant num_hf_draw_points (or sometimes a hardcoded 2) we just use num_hf_draw_points directly from constants_clubb. This massively improves the performance of a loop in fill holes when using nvhpc+omp, which was the motivation for this, but should also improve the performance on CPUs. Everything is BFB.editadvance_xm_wpxp_module.F90editadvance_wp2_wp3_module.F90editclubb_api_module.F90editadvance_clubb_core_module.F90editadvance_xp2_xpyp_module.F90editfill_holes.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther HueblerhueblerfalseStarted by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break351ed4c6d7921a899d94737ed49a2fc2b564d081f00ed4c6d7921a899d94737ed49a2fc2b564d081f00refs/remotes/origin/clubb_silhs_develed4c6d7921a899d94737ed49a2fc2b564d081f00ed4c6d7921a899d94737ed49a2fc2b564d081f00refs/remotes/origin/clubb_silhs_develed4c6d7921a899d94737ed49a2fc2b564d081f00ed4c6d7921a899d94737ed49a2fc2b564d081f00refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#35128702243428101e3sm_run_gfortran_test #351351false3511365SUCCESS1714723509805http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/351/advance_xm_wpxp_module.F900e6f459a8ca2110f661d78019a1f717ff9b9407a1714680265000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am committing code that effectively ignores the values of certain zt stats at the ghost level by setting them to 0. This is done to allow for bit-for-bitness comparisons between the master branch and the clubb_ghost_exorcism branch. Technically, since zt stat file output at the irrelevant ghost level is changed for some variables, this commit is BIT_CHANGING. Effectively, this commit doesn't change squat in terms of model results. 2024-05-02 15:04:25 -05000e6f459a8ca2110f661d78019a1f717ff9b9407aI am committing code that effectively ignores the values of certaineditadvance_xm_wpxp_module.F90advance_xm_wpxp_module.F904b4adc89f8fe60d9e9f89fadcab3f1f6c94992501714685456000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am moving the advance_xm_wpxp setting of xm(1) = xm(2) from the end of xm_clipping_and_stats to the very end of advance_xm_wpxp, right before the return to advance_clubb_core. The reason I am doing this is the nudging was done after setting xm(1) = xm(2) and would alter the results. This is no longer the case, as setting xm(1) = xm(2) is now being done after nudging. This is being done in advance of removal of the ghost point from CLUBB. This helps ensure a bit-for-bit match between the ghost exorcism branch and the master branch. This commit technically alter fields such as um, vm, um_bt, vm_bt, wpup2, wpvp2, and shear at level 1 only. Thus, this commit is technically BIT_CHANGING. Effectively, once again, this commit doesn't change squat. 2024-05-02 16:30:56 -05004b4adc89f8fe60d9e9f89fadcab3f1f6c9499250I am moving the advance_xm_wpxp setting of xm(1) = xm(2) from theeditadvance_xm_wpxp_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false352http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/352/350http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/350/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break3492049ef8940dc4719e1a3e21c784eb7f2a48ffdce2049ef8940dc4719e1a3e21c784eb7f2a48ffdcerefs/remotes/origin/clubb_silhs_devel2049ef8940dc4719e1a3e21c784eb7f2a48ffdce2049ef8940dc4719e1a3e21c784eb7f2a48ffdcerefs/remotes/origin/clubb_silhs_devel2049ef8940dc4719e1a3e21c784eb7f2a48ffdce2049ef8940dc4719e1a3e21c784eb7f2a48ffdcerefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#34928434903428101e3sm_run_gfortran_test #349349false3491229SUCCESS1714550707448http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/349/advance_xm_wpxp_module.F9013811b3b0775ce0412d5ca84a1c0e8787e3823f61714471119000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduMoved the ghost-point setting of xm(1) = xm(2) to the last line of the subroutine so this command doesn't get overwritten. This is technically BIT_CHANGING because it alters rtm (and some rtm-related calculations) at the ghost point, but it is not answer changing. This is being done in preparation for ghost point removal. 2024-04-30 04:58:39 -050013811b3b0775ce0412d5ca84a1c0e8787e3823f6Moved the ghost-point setting of xm(1) = xm(2) to the last lineeditadvance_xm_wpxp_module.F90mixing_length.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xp3_module.F90advance_xm_wpxp_module.F90grid_class.F90setup_clubb_pdf_params.F90calc_pressure.F90advance_windm_edsclrm_module.F90advance_helper_module.F906db5d3c85dd296d8ccafe66f5e7e20b241d371881714534975000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comOptional arguments are just best sometimes (#1150) * Adding optional argument to zm2zt/zt2zm to act as threshold. This cuts down on lots of bulk and reduces the chances of breaking the GPU code. All BFB. * Removing TODO * Replacing hardcoded 0.0_core_rknd with zero_threshold 2024-04-30 22:42:55 -05006db5d3c85dd296d8ccafe66f5e7e20b241d37188Optional arguments are just best sometimes (#1150)editadvance_clubb_core_module.F90editcalc_pressure.F90editadvance_xm_wpxp_module.F90editadvance_helper_module.F90editmixing_length.F90editadvance_windm_edsclrm_module.F90editadvance_wp2_wp3_module.F90editadvance_xp2_xpyp_module.F90editadvance_xp3_module.F90editgrid_class.F90editsetup_clubb_pdf_params.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse350http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/350/348http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/348/