Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break350f85233ca5819e5fff7567dc3b20516c51f6f73c7f85233ca5819e5fff7567dc3b20516c51f6f73c7refs/remotes/origin/clubb_silhs_develf85233ca5819e5fff7567dc3b20516c51f6f73c7f85233ca5819e5fff7567dc3b20516c51f6f73c7refs/remotes/origin/clubb_silhs_develf85233ca5819e5fff7567dc3b20516c51f6f73c7f85233ca5819e5fff7567dc3b20516c51f6f73c7refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#35027913613428101e3sm_run_gfortran_test #350350false3501297SUCCESS1714637106176http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/350/advance_clubb_core_module.F90d6ca5b0e6179de58c7571bea8650e3cd93c3de5e1714537919000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bug. RESOLVED:556370c6406e6b943b88affbe7728a5036b1ba22, this was catchable by using debugging flags, but seems to otherwise cause no issues. Investigating I found that it only clips the below ground level, so that must not have been affecting other levels. This is technically BIT_CHANGING since it resolves an issue. 2024-04-30 23:31:59 -0500d6ca5b0e6179de58c7571bea8650e3cd93c3de5eFixing bug. RESOLVED:556370c6406e6b943b88affbe7728a5036b1ba22, this was catchable by using debugging flags, but seems to otherwise cause no issues. Investigating I found that it only clips the below ground level, so that must not have been affecting other levels. This is technically BIT_CHANGING since it resolves an issue.editadvance_clubb_core_module.F90advance_wp2_wp3_module.F90fill_holes.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90clubb_api_module.F90advance_xm_wpxp_module.F90c2849fa3c750562ffdd5abd6bc9937c081e662261714587276000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking num_draw_points in fill_holes a constant. We were already using this value as a constant everywhere, but passing a constant by argument list makes it difficult/impossible for a compiler to optimize using that constant, unless it does inlining. Now, rather than passing the constant num_hf_draw_points (or sometimes a hardcoded 2) we just use num_hf_draw_points directly from constants_clubb. This massively improves the performance of a loop in fill holes when using nvhpc+omp, which was the motivation for this, but should also improve the performance on CPUs. Everything is BFB. 2024-05-01 13:14:36 -0500c2849fa3c750562ffdd5abd6bc9937c081e66226Making num_draw_points in fill_holes a constant. We were already using this value as a constant everywhere, but passing a constant by argument list makes it difficult/impossible for a compiler to optimize using that constant, unless it does inlining. Now, rather than passing the constant num_hf_draw_points (or sometimes a hardcoded 2) we just use num_hf_draw_points directly from constants_clubb. This massively improves the performance of a loop in fill holes when using nvhpc+omp, which was the motivation for this, but should also improve the performance on CPUs. Everything is BFB.editadvance_wp2_wp3_module.F90editclubb_api_module.F90editadvance_xm_wpxp_module.F90editadvance_xp2_xpyp_module.F90editadvance_clubb_core_module.F90editfill_holes.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse351http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/351/349http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/349/