Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break21946f20657da56ce090d04943f1a446bd8e13fcb7046f20657da56ce090d04943f1a446bd8e13fcb70refs/remotes/origin/clubb_silhs_devel46f20657da56ce090d04943f1a446bd8e13fcb7046f20657da56ce090d04943f1a446bd8e13fcb70refs/remotes/origin/clubb_silhs_devel46f20657da56ce090d04943f1a446bd8e13fcb7046f20657da56ce090d04943f1a446bd8e13fcb70refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/219/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/219/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/219/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/219/testsfalsefalse#21919288373428101e3sm_run_gfortran_test #219219false21917669SUCCESS1660809848359http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/219/pdf_closure_module.F90493cf3aafada57c53b1508b2b5990ce0a7dcafea1660756368000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have optimized the new w_up_in_cloud and w_down_in_cloud code by only doing repeated operations one time and then saving them as a local variable. Since the numerical order of operations changes for the argument to the EXP term, the results will differ at the level of numerical round-off, making this revision not bit-for-bit with the last revision. This only affects the w_up_in_cloud and w_down_in_cloud statistical output variables, which in turn are not output as part of standard_stats.in. 2022-08-17 12:12:48 -0500493cf3aafada57c53b1508b2b5990ce0a7dcafeaI have optimized the new w_up_in_cloud and w_down_in_cloud code byeditpdf_closure_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2falseStarted by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break220e75e8f315366ff83dc1ad2fc82b4c4de24b12d67e75e8f315366ff83dc1ad2fc82b4c4de24b12d67refs/remotes/origin/clubb_silhs_devele75e8f315366ff83dc1ad2fc82b4c4de24b12d67e75e8f315366ff83dc1ad2fc82b4c4de24b12d67refs/remotes/origin/clubb_silhs_devele75e8f315366ff83dc1ad2fc82b4c4de24b12d67e75e8f315366ff83dc1ad2fc82b4c4de24b12d67refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#22025723313428101e3sm_run_gfortran_test #220220false22017845SUCCESS1661933049649http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/220/fill_holes.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90clubb_api_module.F90advance_xm_wpxp_module.F90ab4282b0f6e0a3a1e3404836c96121fb79a872d41661881531000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comRefactored fill_holes_vertical to make GPUization simple. This is BIT_CHANGING, but results are bit-for-bit when using -O0 optimization, thus it is not answer changing. The first pass over each grid column will not parallelize well, the k-loop needs to be done in serial. Maximum parallelization has been exposed for the global hole-filling though, at the cost of occasionally doing unneccesary calculations. larson-group/clubb#972. 2022-08-30 12:45:31 -0500ab4282b0f6e0a3a1e3404836c96121fb79a872d4Refactored fill_holes_vertical to make GPUization simple. This is BIT_CHANGING, but results are bit-for-bit when using -O0 optimization, thus it is not answer changing. The first pass over each grid column will not parallelize well, the k-loop needs to be done in serial. Maximum parallelization has been exposed for the global hole-filling though, at the cost of occasionally doing unneccesary calculations. larson-group/clubb#972.editclubb_api_module.F90editadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90editfill_holes.F90editadvance_wp2_wp3_module.F90editadvance_xp2_xpyp_module.F90fill_holes.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90constants_clubb.F90b0eeb2ebed4160829305c9a13bc60818b045fb221661881531000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comRemoving fill_holes_multiplicative and replacing magic numbers with parameters from constants_clubb. larson-group/clubb#972 2022-08-30 12:45:31 -0500b0eeb2ebed4160829305c9a13bc60818b045fb22Removing fill_holes_multiplicative and replacing magic numbers with parameters from constants_clubb. larson-group/clubb#972editadvance_xp2_xpyp_module.F90editconstants_clubb.F90editadvance_xm_wpxp_module.F90editfill_holes.F90editadvance_clubb_core_module.F90editadvance_wp2_wp3_module.F90fill_holes.F90advance_clubb_core_module.F90stats_clubb_utilities.F90clubb_api_module.F90mono_flux_limiter.F90advance_helper_module.F900a21a67e8c0d8373ae4315241b338842259b1d691661881531000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comMoving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972 2022-08-30 12:45:31 -05000a21a67e8c0d8373ae4315241b338842259b1d69Moving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972editmono_flux_limiter.F90editadvance_clubb_core_module.F90editstats_clubb_utilities.F90editadvance_helper_module.F90editclubb_api_module.F90editfill_holes.F90latin_hypercube_driver_module.F9018677b4114aff3b59943c43e9207fc7a8630060e1661881531000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comMoving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972 2022-08-30 12:45:31 -050018677b4114aff3b59943c43e9207fc7a8630060eMoving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972editlatin_hypercube_driver_module.F90githttp://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwmfalse221http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/221/219http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/219/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break218864d6693c8bdbb4fbd3a60bbd3d4206333541671864d6693c8bdbb4fbd3a60bbd3d4206333541671refs/remotes/origin/clubb_silhs_devel864d6693c8bdbb4fbd3a60bbd3d4206333541671864d6693c8bdbb4fbd3a60bbd3d4206333541671refs/remotes/origin/clubb_silhs_devel864d6693c8bdbb4fbd3a60bbd3d4206333541671864d6693c8bdbb4fbd3a60bbd3d4206333541671refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#21826947323428101e3sm_run_gfortran_test #218218false21817595SUCCESS1660723450418http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/218/pdf_closure_module.F90a7de6b09f4f0e09b48f663e2432b3e98b29bfe601660699106000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI altered the w_up_in_cloud and w_down_in_cloud code so that a thresholding is used similar to what is seen in the cloud fraction and cloud water code. If the PDF component mean of w more than the maximum allow number of standard deviations away from 0, the PDF component is either all-updrafty or all-downdrafty, and the code avoids expensive computations where large magnitude values can potentially be fed into ERF or EXP. Of course, the results are not bit-for-bit with the previous version, meaning that there are some situations where these thresholds come into effect. However, plots of all cases show no visible differences in w_up_in_cloud and w_down_in_cloud. Since w_up_in_cloud and w_down_in_cloud are not included in normal stats output, this commit does not change the bit-for-bitness of CLUBB code. 2022-08-16 20:18:26 -0500a7de6b09f4f0e09b48f663e2432b3e98b29bfe60I altered the w_up_in_cloud and w_down_in_cloud code so that aeditpdf_closure_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false219http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/219/217http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/217/