Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2173d2781955b21fb211e1709274d957fa951104e103d2781955b21fb211e1709274d957fa951104e10refs/remotes/origin/clubb_silhs_devel3d2781955b21fb211e1709274d957fa951104e103d2781955b21fb211e1709274d957fa951104e10refs/remotes/origin/clubb_silhs_devel3d2781955b21fb211e1709274d957fa951104e103d2781955b21fb211e1709274d957fa951104e10refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/217/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/217/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/217/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/217/testsfalsefalse#21728347583428101e3sm_run_gfortran_test #217217false21717507SUCCESS1660637047472http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/217/advance_clubb_core_module.F90pdf_closure_module.F90clubb_api_module.F909434be0736f63802f57dc200dad4c6eae62f68be1660590191000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI changed the w_up_in_cloud code in 2 ways: 1) The denominator term is now the "cloudy updraft" frac in each PDF component, rather than just the PDF component cloud_frac. This is more consistent with the quantity being integrated. 2) I also added a w_down_in_cloud for cloudy downdraft velocity. Since these fields are not output as part of standard stats, this commit will be bit-for-bit for the normal CLUBB output files. 2022-08-15 14:03:11 -05009434be0736f63802f57dc200dad4c6eae62f68beI changed the w_up_in_cloud code in 2 ways:editadvance_clubb_core_module.F90editpdf_closure_module.F90editclubb_api_module.F90pdf_closure_module.F90stats_clubb_utilities.F90advance_clubb_core_module.F90stats_variables.F90stats_zt_module.F90d0bd6bf033fe043e0218e55cf4059316e0d308e41660594604000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added stats output for w_down_in_cloud to all_stats.in. Since this stat was not added to standard_stats.in, official results will still be bit-for-bit. 2022-08-15 15:16:44 -0500d0bd6bf033fe043e0218e55cf4059316e0d308e4I added stats output for w_down_in_cloud to all_stats.in.editstats_clubb_utilities.F90editpdf_closure_module.F90editadvance_clubb_core_module.F90editstats_variables.F90editstats_zt_module.F90components/eam/src/physics/cam/clubb_intr.F904c4ee5a20f2aa6b971a1280e2303f6afe94fa02b1660599130000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduModifications for the latest CLUBB code changes. 2022-08-15 16:32:10 -05004c4ee5a20f2aa6b971a1280e2303f6afe94fa02bModifications for the latest CLUBB code changes.editcomponents/eam/src/physics/cam/clubb_intr.F90components/eam/src/physics/cam/clubb_intr.F908d7f385fbf475f4ca9f958ea87394d34c6525dbb1660599941000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAdding w_down_in_cl to the E3SM stats output, as well. 2022-08-15 16:45:41 -05008d7f385fbf475f4ca9f958ea87394d34c6525dbbAdding w_down_in_cl to the E3SM stats output, as well.editcomponents/eam/src/physics/cam/clubb_intr.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2falseStarted by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break218864d6693c8bdbb4fbd3a60bbd3d4206333541671864d6693c8bdbb4fbd3a60bbd3d4206333541671refs/remotes/origin/clubb_silhs_devel864d6693c8bdbb4fbd3a60bbd3d4206333541671864d6693c8bdbb4fbd3a60bbd3d4206333541671refs/remotes/origin/clubb_silhs_devel864d6693c8bdbb4fbd3a60bbd3d4206333541671864d6693c8bdbb4fbd3a60bbd3d4206333541671refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#21826947323428101e3sm_run_gfortran_test #218218false21817595SUCCESS1660723450418http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/218/pdf_closure_module.F90a7de6b09f4f0e09b48f663e2432b3e98b29bfe601660699106000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI altered the w_up_in_cloud and w_down_in_cloud code so that a thresholding is used similar to what is seen in the cloud fraction and cloud water code. If the PDF component mean of w more than the maximum allow number of standard deviations away from 0, the PDF component is either all-updrafty or all-downdrafty, and the code avoids expensive computations where large magnitude values can potentially be fed into ERF or EXP. Of course, the results are not bit-for-bit with the previous version, meaning that there are some situations where these thresholds come into effect. However, plots of all cases show no visible differences in w_up_in_cloud and w_down_in_cloud. Since w_up_in_cloud and w_down_in_cloud are not included in normal stats output, this commit does not change the bit-for-bitness of CLUBB code. 2022-08-16 20:18:26 -0500a7de6b09f4f0e09b48f663e2432b3e98b29bfe60I altered the w_up_in_cloud and w_down_in_cloud code so that aeditpdf_closure_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false219http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/219/217http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/217/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2161bb3b8f79b10155080df5a7cf2531b38fb1aeb681bb3b8f79b10155080df5a7cf2531b38fb1aeb68refs/remotes/origin/clubb_silhs_devel1bb3b8f79b10155080df5a7cf2531b38fb1aeb681bb3b8f79b10155080df5a7cf2531b38fb1aeb68refs/remotes/origin/clubb_silhs_devel1bb3b8f79b10155080df5a7cf2531b38fb1aeb681bb3b8f79b10155080df5a7cf2531b38fb1aeb68refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#21625991533428101e3sm_run_gfortran_test #216216false21617107SUCCESS1658304246895http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/216/stats_variables.F90stats_zm_module.F90mono_flux_limiter.F908d3e4542fb9b0c14babe8621eca51648539827a81658265385000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comFixing a bug in mono_flux_limiter.F90. (#1026) * Fixing a bug in mono_flux_limiter.F90. This code was outputting "xm" instead of "wpxp" in several places. This commit is BIT_CHANGING since it will affect the netcdf output for these variables, even though there is no real change to answers. * Renaming wpthlp_entermfl to wpthlp_enter_mfl which is more consistent with other variable names. This is BIT_CHANGING due to changing the name and description in the output netcdf files. * Renaming a few more instances of wpthlp_entermfl to wpthlp_enter_mfl. 2022-07-19 15:16:25 -06008d3e4542fb9b0c14babe8621eca51648539827a8Fixing a bug in mono_flux_limiter.F90. (#1026)editstats_variables.F90editmono_flux_limiter.F90editstats_zm_module.F90pdf_closure_module.F90fde756aa71b25daf7c103c445b2d6fc018df057b1658271937000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduFixing a bug. 2022-07-19 18:05:37 -0500fde756aa71b25daf7c103c445b2d6fc018df057bFixing a bug.editpdf_closure_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse217http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/217/215http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/215/