Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break20317370f01d98ecc8b406b30bbdeb5083d933b684717370f01d98ecc8b406b30bbdeb5083d933b6847refs/remotes/origin/clubb_silhs_devel17370f01d98ecc8b406b30bbdeb5083d933b684717370f01d98ecc8b406b30bbdeb5083d933b6847refs/remotes/origin/clubb_silhs_devel17370f01d98ecc8b406b30bbdeb5083d933b684717370f01d98ecc8b406b30bbdeb5083d933b6847refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/203/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/203/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/203/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/203/testsfalsefalse#20321070763428101e3sm_run_gfortran_test #203203false20315712SUCCESS1654157047466http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/203/new_pdf_main.F90new_hybrid_pdf_main.F907bc6f76ec8b70bc1789f90b554dca47122c400011654112656000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduThe G_unit tests never allocated pdf_implicit_coefs_terms. It's unclear to me how these were working before, but it seems that something about making these 2D allocatable arrays exposed the bug. 2022-06-01 14:44:16 -05007bc6f76ec8b70bc1789f90b554dca47122c40001The G_unit tests never allocated pdf_implicit_coefs_terms. It's unclear to me how these were working before, but it seems that something about making these 2D allocatable arrays exposed the bug.editnew_pdf_main.F90editnew_hybrid_pdf_main.F90advance_xp2_xpyp_module.F90de73c4eefaee2b50045b4f5e706868e84b0f45501654117361000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking zt2zm calls with pdf_implicit_coefs_terms use the 2D version. 2022-06-01 16:02:41 -0500de73c4eefaee2b50045b4f5e706868e84b0f4550Making zt2zm calls with pdf_implicit_coefs_terms use the 2D version.editadvance_xp2_xpyp_module.F90advance_clubb_core_module.F90clubb_api_module.F903643c78f6fe2260f971bba96ead125858b665f1c1654122180000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving setup_grid and setup_parameters functionality from setup_clubb_core. This is beacuse in host models the required grid information may not be known during the setup process, resulting in dummy arguments for setup_clubb_core and the grid and paramters being setup during runtime anyway. Now, in the host models we can call these subroutines immediately after setup_clubb_core to maintain identical functionality (sam, wrf), and in others we can wait to call these until the main timestepping procedure (cam,e3sm). 2022-06-01 17:23:00 -05003643c78f6fe2260f971bba96ead125858b665f1cRemoving setup_grid and setup_parameters functionality from setup_clubb_core. This is beacuse in host models the required grid information may not be known during the setup process, resulting in dummy arguments for setup_clubb_core and the grid and paramters being setup during runtime anyway. Now, in the host models we can call these subroutines immediately after setup_clubb_core to maintain identical functionality (sam, wrf), and in others we can wait to call these until the main timestepping procedure (cam,e3sm).editadvance_clubb_core_module.F90editclubb_api_module.F90components/eam/src/physics/cam/clubb_intr.F90b83d1400dc7bf7fe79743ed57362827f37e7ee8c1654122237000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking compatible with latest clubb change. 2022-06-01 17:23:57 -0500b83d1400dc7bf7fe79743ed57362827f37e7ee8cMaking compatible with latest clubb change.editcomponents/eam/src/physics/cam/clubb_intr.F90grid_class.F90parameters_tunable.F90clubb_api_module.F90c623b91a9bf812b85b51b575233ad00e8b98f16c1654129942000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking 2D versions of setup_grid and setup_parameters. 2022-06-01 19:32:22 -0500c623b91a9bf812b85b51b575233ad00e8b98f16cMaking 2D versions of setup_grid and setup_parameters.editgrid_class.F90editclubb_api_module.F90editparameters_tunable.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther HueblerhueblerfalseStarted by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break204838c893eab90a4404b2529881db27466b5c82c0e838c893eab90a4404b2529881db27466b5c82c0erefs/remotes/origin/clubb_silhs_devel838c893eab90a4404b2529881db27466b5c82c0e838c893eab90a4404b2529881db27466b5c82c0erefs/remotes/origin/clubb_silhs_devel838c893eab90a4404b2529881db27466b5c82c0e838c893eab90a4404b2529881db27466b5c82c0erefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#2045468173428101e3sm_run_gfortran_test #204204false20415782FAILURE1654243448217http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/204/mixing_length.F90advance_clubb_core_module.F90parameters_tunable.F90clubb_api_module.F9069aaa53016d97c134fc63c8ebc1a7c029d2b60741654197815000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking lmin a scalar again, twas a mistake to make it an array, it can only take on one value. 2022-06-02 14:23:35 -050069aaa53016d97c134fc63c8ebc1a7c029d2b6074Making lmin a scalar again, twas a mistake to make it an array, it can only take on one value.editadvance_clubb_core_module.F90editparameters_tunable.F90editmixing_length.F90editclubb_api_module.F90components/eam/src/physics/cam/clubb_intr.F908b0f71a6f18f6ddfd8c8de2c6bce246ab0fca7631654197852000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking compatible with latest clubb change. 2022-06-02 14:24:12 -05008b0f71a6f18f6ddfd8c8de2c6bce246ab0fca763Making compatible with latest clubb change.editcomponents/eam/src/physics/cam/clubb_intr.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90clubb_api_module.F90parameters_tunable.F90advance_windm_edsclrm_module.F9002455edff630a52bd333d2b0013748e4bce7e9ff1654200656000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking nu_vert_res_dep a type containing arrays, as opposed to being an array of types. 2022-06-02 15:10:56 -050002455edff630a52bd333d2b0013748e4bce7e9ffMaking nu_vert_res_dep a type containing arrays, as opposed to being an array of types.editadvance_wp2_wp3_module.F90editadvance_xp2_xpyp_module.F90editadvance_windm_edsclrm_module.F90editadvance_xm_wpxp_module.F90editparameters_tunable.F90editclubb_api_module.F90editadvance_clubb_core_module.F90components/eam/src/physics/cam/clubb_intr.F90cc23bb726a760eb04a42acaa91c4e30fec071cbf1654200674000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking compatible with latest clubb change. 2022-06-02 15:11:14 -0500cc23bb726a760eb04a42acaa91c4e30fec071cbfMaking compatible with latest clubb change.editcomponents/eam/src/physics/cam/clubb_intr.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse205http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/205/203http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/203/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2029cfeb9692778ebe864686165cfc9ae58b0c323959cfeb9692778ebe864686165cfc9ae58b0c32395refs/remotes/origin/clubb_silhs_devel9cfeb9692778ebe864686165cfc9ae58b0c323959cfeb9692778ebe864686165cfc9ae58b0c32395refs/remotes/origin/clubb_silhs_devel9cfeb9692778ebe864686165cfc9ae58b0c323959cfeb9692778ebe864686165cfc9ae58b0c32395refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#20222443123428101e3sm_run_gfortran_test #202202false20215640SUCCESS1654070647051http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/202/advance_xm_wpxp_module.F90clubb_api_module.F90clip_explicit.F90stats_type_utilities.F90grid_class.F90setup_clubb_pdf_params.F90advance_windm_edsclrm_module.F90new_pdf_main.F90advance_helper_module.F90mono_flux_limiter.F90advance_wp2_wp3_module.F90mixing_length.F90new_tsdadg_pdf.F90advance_xp2_xpyp_module.F90LY93_pdf.F90pdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F90new_hybrid_pdf_main.F90numerical_check.F90pos_definite_module.F90new_pdf.F90sponge_layer_damping.F90turbulent_adv_pdf.F90advance_clubb_core_module.F90advance_xp3_module.F90fill_holes.F90stats_clubb_utilities.F90db5164bb7ed0c78ce4f06f92e7bf6118d10addf31654031468000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAlmost final loop pushes (#1012) * Pushing loop into clip_rcm * Pushing column loop into trapezoid routines. * Pushing column loop into clip_covar routines. * Pushing column loop into clip_variance and clip_skewness. * Replacing sgn_turbulent_velocity with built in fortran sign * Removing gr from argument list of stats calls, replacing with just nz * Replacing some usages of gr with just the number of vertical levels * Replacing some usages of gr with just the number of vertical levels again * Missed a couple files to commit * Pushing some loops and removing need for gr to be passed into some routines. * Pushing loop into advance_xp3 * Pushing loop into mixing length * Some more loop pushing * Pushing some loops into mono_flux limit, skipping the lhs routine since it's a bit tricky at the moment, will do after change to grid class. * Removing gr from argument list of stats accumulate * Precalculating zt2zm so that we can use 2d version * Precalculating um/vm ddzt so that we can use 2d version * Precalculating things to use 2d version of zt2zm * Making 2d version of cubic interp for grid class * Small modifications to sponge damping code argument lists * Renaming some variables 2022-05-31 16:11:08 -0500db5164bb7ed0c78ce4f06f92e7bf6118d10addf3Almost final loop pushes (#1012)editadvance_windm_edsclrm_module.F90editadvance_wp2_wp3_module.F90editmixing_length.F90editadvance_clubb_core_module.F90editadvance_xp3_module.F90editpdf_closure_module.F90editsetup_clubb_pdf_params.F90editnew_tsdadg_pdf.F90editadg1_adg2_3d_luhar_pdf.F90editnew_pdf.F90editLY93_pdf.F90editfill_holes.F90editsponge_layer_damping.F90editadvance_helper_module.F90editnew_pdf_main.F90editadvance_xm_wpxp_module.F90editstats_clubb_utilities.F90editturbulent_adv_pdf.F90editmono_flux_limiter.F90editpos_definite_module.F90editstats_type_utilities.F90editclubb_api_module.F90editnumerical_check.F90editgrid_class.F90editclip_explicit.F90editnew_hybrid_pdf_main.F90editadvance_xp2_xpyp_module.F90components/eam/src/physics/cam/clubb_intr.F90448eb802d2930cd7bc3776ac409ab9cf6be85e511654040774000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking compatible with latest clubb change. 2022-05-31 18:46:14 -0500448eb802d2930cd7bc3776ac409ab9cf6be85e51Making compatible with latest clubb change.editcomponents/eam/src/physics/cam/clubb_intr.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90clubb_api_module.F90pdf_closure_module.F90pdf_parameter_module.F90new_hybrid_pdf_main.F90new_pdf_main.F90113beb1ec6663fcef3f6bb75c7ee971ab3c0fa451654040788000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comMaking pdf_implicit_coefs_terms a type containing 2D arrays. (#1014) 2022-05-31 18:46:28 -0500113beb1ec6663fcef3f6bb75c7ee971ab3c0fa45Making pdf_implicit_coefs_terms a type containing 2D arrays. (#1014)editadvance_xm_wpxp_module.F90editadvance_clubb_core_module.F90editnew_hybrid_pdf_main.F90editadvance_wp2_wp3_module.F90editclubb_api_module.F90editadvance_xp2_xpyp_module.F90editpdf_closure_module.F90editpdf_parameter_module.F90editnew_pdf_main.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse203http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/203/201http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/201/