Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break135e68bf0773ec1fbe1f4f623839959b4e63c10af17e68bf0773ec1fbe1f4f623839959b4e63c10af17refs/remotes/origin/clubb_silhs_devele68bf0773ec1fbe1f4f623839959b4e63c10af17e68bf0773ec1fbe1f4f623839959b4e63c10af17refs/remotes/origin/clubb_silhs_devele68bf0773ec1fbe1f4f623839959b4e63c10af17e68bf0773ec1fbe1f4f623839959b4e63c10af17refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/135/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/135/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/135/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/e3sm_run_gfortran_test/detail/e3sm_run_gfortran_test/135/testsfalseCheckout Branch and SubmodulesModify Run ScriptsRun BOMEXRun DYCOMSrf01Run RICODisplay BOMEX log filesDisplay DYCOMSrf01 log filesDisplay RICO log filesfalse#1357851763428101e3sm_run_gfortran_test #135135false13510706SUCCESS1638608665399http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/135/- advance_clubb_core_module.F90fcf74be3a201e5043cabaad104cc37cdbb8c0e9d1638567586000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemove clipping from a3_coef.
In principle, removing the clipping should reduce noise.
In practice, it makes rico noiser but mpace_b less noisy.
It also allows twp_ice to run to completion with the gfortran compiler.
This commit is BIT_CHANGING.
For #965.
2021-12-03 15:39:46 -0600fcf74be3a201e5043cabaad104cc37cdbb8c0e9dRemove clipping from a3_coef.editadvance_clubb_core_module.F90
githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreplyfalseStarted by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break136f64d98f635f0187bddb9dde417097e4c34428480f64d98f635f0187bddb9dde417097e4c34428480refs/remotes/origin/clubb_silhs_develf64d98f635f0187bddb9dde417097e4c34428480f64d98f635f0187bddb9dde417097e4c34428480refs/remotes/origin/clubb_silhs_develf64d98f635f0187bddb9dde417097e4c34428480f64d98f635f0187bddb9dde417097e4c34428480refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#136523583428101e3sm_run_gfortran_test #136136false13610965FAILURE1639818265413http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/136/- advance_clubb_core_module.F90advance_xm_wpxp_module.F90advance_windm_edsclrm_module.F90fe10a3988ec9c5ae38f9a6521364e5114303dc971639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comThese changes allow you to call the 4 clubb "advance" subroutines in any
order that you want to try. In the default order (where the order is the
same as found in the current version of the CLUBB master), results are
bit-for-bit when compared to CLUBB master.
2021-12-17 17:36:25 -0600fe10a3988ec9c5ae38f9a6521364e5114303dc97These changes allow you to call the 4 clubb "advance" subroutines in anyeditadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90editadvance_windm_edsclrm_module.F90
- advance_clubb_core_module.F90da7e393336c65553c3897fdb66f276cc70ba5a581639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comPlacing the order variables in a nice, convenient place for testing use.
2021-12-17 17:36:25 -0600da7e393336c65553c3897fdb66f276cc70ba5a58Placing the order variables in a nice, convenient place for testing use.editadvance_clubb_core_module.F90
- advance_clubb_core_module.F908aae767c4fcc474647d6b76867a06416de8057bd1639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comI reordered advance_clubb_core so that the "Advance xp3" (which is a
basic calculation of xp3 by the ansatz by default) section is moved out
of the way of the "advance loop" to a point that is after
advance_windm_edsclrm (or whatever will be called last in the advance
loop.
This change does not alter the default results. Everything is still
bit-for-bit.
2021-12-17 17:36:25 -06008aae767c4fcc474647d6b76867a06416de8057bdI reordered advance_clubb_core so that the "Advance xp3" (which is aeditadvance_clubb_core_module.F90
- advance_clubb_core_module.F90advance_xm_wpxp_module.F90clubb_api_module.F9089ceef8b3be53379b14beba84d90cef1f9ec9a391639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comI am committing the idiot-proofing code that forces l_min_xp2_from_corr_wx
and l_enable_relaxed_clipping to have opposite values (one must be true
and the other must be false). In this commit, both are set to true, so
the code will produce an exception.
2021-12-17 17:36:25 -060089ceef8b3be53379b14beba84d90cef1f9ec9a39I am committing the idiot-proofing code that forces l_min_xp2_from_corr_wxeditadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90editclubb_api_module.F90
- advance_clubb_core_module.F9051776de85578ab39a37d41b3a28771e66d58657f1639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comI am indenting the portion of the code where the advance subroutines
are located within the new ordering loop.
2021-12-17 17:36:25 -060051776de85578ab39a37d41b3a28771e66d58657fI am indenting the portion of the code where the advance subroutineseditadvance_clubb_core_module.F90
- advance_clubb_core_module.F909ffac7f447029ffd2f8bac3d59fb93019127171e1639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comTemporarily commenting out the idiot proofing in order to run some tests ...
The results from this branch are still bit-for-bit with the master branch.
2021-12-17 17:36:25 -06009ffac7f447029ffd2f8bac3d59fb93019127171eTemporarily commenting out the idiot proofing in order to run some tests ...editadvance_clubb_core_module.F90
- advance_clubb_core_module.F90advance_xm_wpxp_module.F90c587754da66182880513b7c16ccc23c289952ab51639784501000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduNow official reinstating the idiot-proofing and turning off the
l_enable_relaxed_clipping flag. This commit is BIT_CHANGING
2021-12-17 17:41:41 -0600c587754da66182880513b7c16ccc23c289952ab5Now official reinstating the idiot-proofing and turning off theeditadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90
- advance_clubb_core_module.F90b778226f990c7e852735312d0123c76452338a211639787077000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am committing some idiot proofing in regards to the advance
subroutines ordering. No index can have a value of less than 1,
greater than 4, and no index can have the same value as any other
index. Each adv routine order index must have a unique value.
2021-12-17 18:24:37 -0600b778226f990c7e852735312d0123c76452338a21I am committing some idiot proofing in regards to the advanceeditadvance_clubb_core_module.F90
- components/cam/src/physics/cam/clubb_intr.F90821bc5a0c2628d9fb13ac3f5933fd1e8fe9d98cb1639788262000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdating for the latest version of CLUBB.
2021-12-17 18:44:22 -0600821bc5a0c2628d9fb13ac3f5933fd1e8fe9d98cbUpdating for the latest version of CLUBB.editcomponents/cam/src/physics/cam/clubb_intr.F90
githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffinfalse137http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/137/135http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/135/Started by an SCM change75c0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_develc0797a7f204bf6c3e61b5934d30c765329532605c0797a7f204bf6c3e61b5934d30c765329532605origin/clubb_silhs_devel712b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break2b097205a2cf81c88b1f24a64a493307e06a9f972b097205a2cf81c88b1f24a64a493307e06a9f97origin/changes_to_not_break1344f4cff450b24695b5958f61fc0461ed411b9156a4f4cff450b24695b5958f61fc0461ed411b9156arefs/remotes/origin/clubb_silhs_devel4f4cff450b24695b5958f61fc0461ed411b9156a4f4cff450b24695b5958f61fc0461ed411b9156arefs/remotes/origin/clubb_silhs_devel4f4cff450b24695b5958f61fc0461ed411b9156a4f4cff450b24695b5958f61fc0461ed411b9156arefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#1347795753428101e3sm_run_gfortran_test #134134false13410638SUCCESS1638522265044http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/134/- pdf_closure_module.F9069a9f213c5189310355d117e82d7047829f4e5501632504823000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comSee ticket
#958
2021-09-24 12:33:43 -050069a9f213c5189310355d117e82d7047829f4e550See ticketeditpdf_closure_module.F90
- advance_clubb_core_module.F90stats_clubb_utilities.F90pdf_closure_module.F90f743922fbd8e78ed86270101cb28dbcbb5f5c0f71633009731000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comadded some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to disk
2021-09-30 08:48:51 -0500f743922fbd8e78ed86270101cb28dbcbb5f5c0f7added some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to diskeditpdf_closure_module.F90editadvance_clubb_core_module.F90editstats_clubb_utilities.F90
- pdf_closure_module.F90stats_clubb_utilities.F90advance_clubb_core_module.F90stats_variables.F90model_flags.F90stats_zt_module.F9024ab4b2089583ab183efc1963c23fb3153fd20481634058263000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comSee respective messages on the issue 958 on date 10/12/2021
2021-10-12 12:04:23 -050024ab4b2089583ab183efc1963c23fb3153fd2048See respective messages on the issue 958 on date 10/12/2021editstats_clubb_utilities.F90editstats_zt_module.F90editadvance_clubb_core_module.F90editpdf_closure_module.F90editstats_variables.F90editmodel_flags.F90
- pdf_closure_module.F90stats_zt_module.F905aad62fb6b44998c8eeea4e274d53e9f5b6fda2a1636491816000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comAdded sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90
2021-11-09 15:03:36 -06005aad62fb6b44998c8eeea4e274d53e9f5b6fda2aAdded sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90editpdf_closure_module.F90editstats_zt_module.F90
- advance_clubb_core_module.F90model_flags.F90pdf_closure_module.F900918704e4ca667f2dd901df9481fcab6d04ad5591636651886000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comResolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details
2021-11-11 11:31:26 -06000918704e4ca667f2dd901df9481fcab6d04ad559Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for detailseditpdf_closure_module.F90editadvance_clubb_core_module.F90editmodel_flags.F90
- pdf_closure_module.F9081d326f9c04198f2635a6b56b25bc395da7414351636664054000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comIncluded a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge
2021-11-11 14:54:14 -060081d326f9c04198f2635a6b56b25bc395da741435Included a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after mergeeditpdf_closure_module.F90
- pdf_closure_module.F90dc3c4b8f58acb3383731109218706676f789be071636664205000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comfixed a typo in pdf_closure_module.f90, line 1284
2021-11-11 14:56:45 -0600dc3c4b8f58acb3383731109218706676f789be07fixed a typo in pdf_closure_module.f90, line 1284editpdf_closure_module.F90
- stats_variables.F90e1572555370199b4fe0abf791462f1a0830a22f71638465215000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comfixed compiler warning regarding w_up_in_cloud
2021-12-02 11:13:35 -0600e1572555370199b4fe0abf791462f1a0830a22f7fixed compiler warning regarding w_up_in_cloudeditstats_variables.F90
githttp://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldfalse135http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/135/133http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_run_gfortran_test/133/