Started by an SCM change2465f444944af496bd6fa94b968e803df18249a801e5f444944af496bd6fa94b968e803df18249a801erefs/remotes/origin/clubb_silhs_devel5f444944af496bd6fa94b968e803df18249a801e5f444944af496bd6fa94b968e803df18249a801erefs/remotes/origin/clubb_silhs_devel5f444944af496bd6fa94b968e803df18249a801e5f444944af496bd6fa94b968e803df18249a801erefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#24640108692906312e3sm_ne4_silhs_run_gfortran_test #246246false24627690SUCCESS1704360968306http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_ne4_silhs_run_gfortran_test/246/components/eam/src/physics/cam/clubb_intr.F905f63282539ac5158547226772ef4b94aed12fd401704313018000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding if around allocation and adding call for fields to be output, these are both to prevent runtime bugs 2024-01-03 14:16:58 -06005f63282539ac5158547226772ef4b94aed12fd40Adding if around allocation and adding call for fields to be output, these are both to prevent runtime bugseditcomponents/eam/src/physics/cam/clubb_intr.F90clubb_api_module.F90clip_explicit.F90advance_xm_wpxp_module.F90diagnose_correlations_module.F90setup_clubb_pdf_params.F90advance_windm_edsclrm_module.F90advance_helper_module.F90mixing_length.F90advance_xp2_xpyp_module.F90error_code.F90pdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F90new_hybrid_pdf_main.F90corr_varnce_module.F90precipitation_fraction.F90index_mapping.F90model_flags.F90numerical_check.F90output_netcdf.F90stat_file_module.F90sponge_layer_damping.F90array_index.F90saturation.F90advance_clubb_core_module.F90advance_xp3_module.F90stats_zt_module.F90fill_holes.F90stats_clubb_utilities.F90stats_zm_module.F90sfc_varnce_module.F90parameters_model.F9069a0500429869014c93503d18cff3ccfd516dc6d1704332198000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comThreadpublic (#1133) * Initial threadprivate removals and simple changes. * model flags update, incomplete * Some updates, almost working * Added saturation_formula and l_host_applies_sfc_fluxes to clubb_config_flags * Accompanying changes to flags lists * Changes to corrrelation array setup * Adding more flag checking * Forgot to set l_host_applies_sfc_fluxes in initialize_clubb_config_flags_type and commit adding l_implemented to the argument loit * Adding saturation parameters to api * Most of the way through passing sclr_dim, hydromet_dim, edsclr_dim, and sclr_tol through arguemnt lists. Moved first_write breaking silhs stats aparently, and bit changing due to the way we were writing sclr_tol for cases that have sclr_dim=0 (arm different, gabls2 BFB). * Removing accidentally commited files. * Fixed silhs output, all cases BFB but sclr_tol is saved differently to stats files in cases where sclr_dim = 0, so this is bc also bc:fb20458d5212b007c79c17613201af637bbc3d7e since that introduced the difference. * Changing stats logicals back to false, only set to true for testing. So technically BIT_CHANGING * Starting array_vars changes. * No more global scalar indices * Starting to remove hydromet indices * Finished the annoying part with the microphysics interfaces. * No more global variables in array_index. All cases BFB relative to last commit. * No more global pdf_dim, Ncnp2_on_Ncnm2 now set via argument list, and added temporary hydromet_dim_glob because I thought it would fix a bug but it didn't, it might in the future though, so I left it in for now, it will be removed soon. * Added nan checking before overriding default value for Ncnp2_on_Ncnm2 * Finished hydromet_dim argument listing and removed global versions of it as well as sclr_dim, edsclr_dim, and sclr_tol. * open_netcdf_for_writing does nothing if nvars=0 for a stats file, which is understandable, but now that we call first_write immediately after we need that also to check for nvar=0 * Adding better error messages to stats_init * The nvidia compiler does not like zero size arrays. * Adding defaults for scalar arrays values in clubb driver, and adding an error check after calling stats_init. * Reverting accidental changes to clubb_thread_test * Changing name of scarr/scalar_array to sclr_idx and hydromet_array to hm_metadata * Adding new types to _api * Fixing erroneous name changes. * Fixing bug introduced in 65987c8a77496f7bb10bfd28717345b1f63de1b7 * Removing print * QuadTune: updates setup in order to read in 30x30 regional files automatically. For #910. * Updating the code to set the bottom of the thermodynamic level grid for diffusion at thermodynamic level 2 -- the first level above the surface. This is being done in preparation for ghostless gridding. * Commit to enforce a fixed-point boundary condition of wp3=0 at thermodynamic level k = 2, the first above-ground thermodynamic level. This is being done in preparation for ghostless gridding. This commit is bc. Results are much more similar to the previous results than using using zero-flux as the lower boundary condition for wp3. * With wp3 now being set to a fixed-point boundary condition value of 0 at the current thermodynamic level 2 (first t-lev above the surface), it is not necessary to loop over level 2 within the code for each wp3 term. This commit is BIT_CHANGING, but only for the wp3 budget terms (e.g. wp3_ta) in the zt output file at level k = 2. It doesn't change the actual answer. All other variables are bit-for-bit identical. * Removing omp parallel test line * Removing parameter declarion around l_quintic_poly_interp. Having this be a parameter causes bit changes when using -O2 --------- Co-authored-by: vlarson <vlarson@uwm.edu> Co-authored-by: bmg929 <bmg2@uwm.edu> 2024-01-03 19:36:38 -060069a0500429869014c93503d18cff3ccfd516dc6dThreadpublic (#1133)editindex_mapping.F90editmixing_length.F90editadvance_clubb_core_module.F90editadg1_adg2_3d_luhar_pdf.F90editarray_index.F90editsaturation.F90editsfc_varnce_module.F90editstats_clubb_utilities.F90editfill_holes.F90editclubb_api_module.F90editclip_explicit.F90editpdf_closure_module.F90editcorr_varnce_module.F90editmodel_flags.F90editadvance_xp2_xpyp_module.F90editstat_file_module.F90editadvance_xm_wpxp_module.F90editadvance_xp3_module.F90editsetup_clubb_pdf_params.F90editstats_zt_module.F90editprecipitation_fraction.F90editsponge_layer_damping.F90editparameters_model.F90editnew_hybrid_pdf_main.F90editdiagnose_correlations_module.F90editadvance_helper_module.F90editadvance_windm_edsclrm_module.F90editerror_code.F90editnumerical_check.F90editoutput_netcdf.F90editstats_zm_module.F90silhs_api_module.F90silhs_importance_sample_module.F90transform_to_pdf_module.F90output_2D_samples_module.F90latin_hypercube_driver_module.F9014c8636ab5c46f3f20204fae38b1eeb765bc804c1704332198000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comThreadpublic (#1133) * Initial threadprivate removals and simple changes. * model flags update, incomplete * Some updates, almost working * Added saturation_formula and l_host_applies_sfc_fluxes to clubb_config_flags * Accompanying changes to flags lists * Changes to corrrelation array setup * Adding more flag checking * Forgot to set l_host_applies_sfc_fluxes in initialize_clubb_config_flags_type and commit adding l_implemented to the argument loit * Adding saturation parameters to api * Most of the way through passing sclr_dim, hydromet_dim, edsclr_dim, and sclr_tol through arguemnt lists. Moved first_write breaking silhs stats aparently, and bit changing due to the way we were writing sclr_tol for cases that have sclr_dim=0 (arm different, gabls2 BFB). * Removing accidentally commited files. * Fixed silhs output, all cases BFB but sclr_tol is saved differently to stats files in cases where sclr_dim = 0, so this is bc also bc:fb20458d5212b007c79c17613201af637bbc3d7e since that introduced the difference. * Changing stats logicals back to false, only set to true for testing. So technically BIT_CHANGING * Starting array_vars changes. * No more global scalar indices * Starting to remove hydromet indices * Finished the annoying part with the microphysics interfaces. * No more global variables in array_index. All cases BFB relative to last commit. * No more global pdf_dim, Ncnp2_on_Ncnm2 now set via argument list, and added temporary hydromet_dim_glob because I thought it would fix a bug but it didn't, it might in the future though, so I left it in for now, it will be removed soon. * Added nan checking before overriding default value for Ncnp2_on_Ncnm2 * Finished hydromet_dim argument listing and removed global versions of it as well as sclr_dim, edsclr_dim, and sclr_tol. * open_netcdf_for_writing does nothing if nvars=0 for a stats file, which is understandable, but now that we call first_write immediately after we need that also to check for nvar=0 * Adding better error messages to stats_init * The nvidia compiler does not like zero size arrays. * Adding defaults for scalar arrays values in clubb driver, and adding an error check after calling stats_init. * Reverting accidental changes to clubb_thread_test * Changing name of scarr/scalar_array to sclr_idx and hydromet_array to hm_metadata * Adding new types to _api * Fixing erroneous name changes. * Fixing bug introduced in 65987c8a77496f7bb10bfd28717345b1f63de1b7 * Removing print * QuadTune: updates setup in order to read in 30x30 regional files automatically. For #910. * Updating the code to set the bottom of the thermodynamic level grid for diffusion at thermodynamic level 2 -- the first level above the surface. This is being done in preparation for ghostless gridding. * Commit to enforce a fixed-point boundary condition of wp3=0 at thermodynamic level k = 2, the first above-ground thermodynamic level. This is being done in preparation for ghostless gridding. This commit is bc. Results are much more similar to the previous results than using using zero-flux as the lower boundary condition for wp3. * With wp3 now being set to a fixed-point boundary condition value of 0 at the current thermodynamic level 2 (first t-lev above the surface), it is not necessary to loop over level 2 within the code for each wp3 term. This commit is BIT_CHANGING, but only for the wp3 budget terms (e.g. wp3_ta) in the zt output file at level k = 2. It doesn't change the actual answer. All other variables are bit-for-bit identical. * Removing omp parallel test line * Removing parameter declarion around l_quintic_poly_interp. Having this be a parameter causes bit changes when using -O2 --------- Co-authored-by: vlarson <vlarson@uwm.edu> Co-authored-by: bmg929 <bmg2@uwm.edu> 2024-01-03 19:36:38 -060014c8636ab5c46f3f20204fae38b1eeb765bc804cThreadpublic (#1133)editoutput_2D_samples_module.F90editsilhs_importance_sample_module.F90editsilhs_api_module.F90editlatin_hypercube_driver_module.F90edittransform_to_pdf_module.F90components/eam/src/physics/cam/clubb_intr.F90components/eam/src/physics/cam/subcol_SILHS.F90ba7ed42d545ad511fe53aa45900746100b35d7fb1704337453000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking compatible with latest clubb changes. 2024-01-03 21:04:13 -0600ba7ed42d545ad511fe53aa45900746100b35d7fbMaking compatible with latest clubb changes.editcomponents/eam/src/physics/cam/subcol_SILHS.F90editcomponents/eam/src/physics/cam/clubb_intr.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse247http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_ne4_silhs_run_gfortran_test/247/245http://carson.math.uwm.edu/jenkins/view/all/job/e3sm_ne4_silhs_run_gfortran_test/245/