Started by an SCM change883ca4d977790d80b9326adf1d3067b4899d09c5833ca4d977790d80b9326adf1d3067b4899d09c583refs/remotes/origin/master3ca4d977790d80b9326adf1d3067b4899d09c5833ca4d977790d80b9326adf1d3067b4899d09c583refs/remotes/origin/master3ca4d977790d80b9326adf1d3067b4899d09c5833ca4d977790d80b9326adf1d3067b4899d09c583refs/remotes/origin/masterhttps://github.com/larson-group/clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_release_diff_test/detail/clubb_release_diff_test/88/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_release_diff_test/detail/clubb_release_diff_test/88/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_release_diff_test/detail/clubb_release_diff_test/88/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_release_diff_test/detail/clubb_release_diff_test/88/testsfalseCheckout Clubb and Clubb_ReleaseDifffalse#8832996361419302clubb_release_diff_test #8888false885163SUCCESS1623832570471http://carson.math.uwm.edu/jenkins/view/all/job/clubb_release_diff_test/88/src/CLUBB_core/advance_xp3_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/KK_microphys_module.F90src/CLUBB_core/grid_class.F90src/estimate_scm_microphys_module.F90src/ice_dfsn_module.F90src/Benchmark_cases/atex.F90src/Benchmark_cases/wangara.F90src/Benchmark_cases/dycoms2_rf02.F90src/Benchmark_cases/cloud_sed_module.F90src/gfdl_activation.F90src/CLUBB_core/mixing_length.F90src/microphys_driver.F90src/Benchmark_cases/astex_a209.F90src/time_dependent_input.F90src/advance_microphys_module.F90src/CLUBB_core/calc_pressure.F90src/CLUBB_core/mono_flux_limiter.F90src/G_unit_test_types/pdf_parameter_tests.F90src/Benchmark_cases/dycoms2_rf01.F90src/CLUBB_core/advance_helper_module.F90src/Benchmark_cases/mpace_b.F90src/hydrostatic_module.F90src/G_unit_test_types/spurious_source_test.F90src/input_fields.F90src/Benchmark_cases/rico.F90src/SILHS/latin_hypercube_driver_module.F90src/mixed_moment_PDF_integrals.F90src/Benchmark_cases/gabls2.F90src/Benchmark_cases/nov11.F90src/Benchmark_cases/mpace_a.F90src/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/Benchmark_cases/bomex.F90src/simple_rad_module.F90src/morrison_microphys_module.F90src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F90src/sounding.F90src/CLUBB_core/setup_clubb_pdf_params.F90src/CLUBB_core/pos_definite_module.F90src/Benchmark_cases/lba.F90src/coamps_microphys_driver_module.F90cf466bce6e695ec1851b8e4a9bf9a8bbecae40581623708447000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduRemoving gr as a module variable from grid_class. gr is now a module variable in clubb_api_module. This was done in order to not break host models. Additonally, gr is now being fed through the arg list of all functions and subroutines that use gr within grid_class. Results are BFB identical. For ticket #886. 2021-06-14 17:07:27 -0500cf466bce6e695ec1851b8e4a9bf9a8bbecae4058Removing gr as a module variable from grid_class.editsrc/Benchmark_cases/nov11.F90editsrc/Benchmark_cases/rico.F90editsrc/KK_microphys_module.F90editsrc/Benchmark_cases/wangara.F90editsrc/ice_dfsn_module.F90editsrc/microphys_driver.F90editsrc/CLUBB_core/calc_pressure.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/mixed_moment_PDF_integrals.F90editsrc/CLUBB_core/advance_xp3_module.F90editsrc/advance_microphys_module.F90editsrc/Benchmark_cases/bomex.F90editsrc/Benchmark_cases/atex.F90editsrc/hydrostatic_module.F90editsrc/Benchmark_cases/lba.F90editsrc/gfdl_activation.F90editsrc/CLUBB_core/pos_definite_module.F90editsrc/G_unit_test_types/spurious_source_test.F90editsrc/Benchmark_cases/dycoms2_rf01.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/simple_rad_module.F90editsrc/CLUBB_core/mixing_length.F90editsrc/estimate_scm_microphys_module.F90editsrc/Benchmark_cases/dycoms2_rf02.F90editsrc/input_fields.F90editsrc/CLUBB_core/mono_flux_limiter.F90editsrc/CLUBB_core/setup_clubb_pdf_params.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/morrison_microphys_module.F90editsrc/Benchmark_cases/mpace_a.F90editsrc/CLUBB_core/grid_class.F90editsrc/sounding.F90editsrc/Benchmark_cases/astex_a209.F90editsrc/SILHS/latin_hypercube_driver_module.F90editsrc/coamps_microphys_driver_module.F90editsrc/Benchmark_cases/gabls2.F90editsrc/Benchmark_cases/cloud_sed_module.F90editsrc/Benchmark_cases/mpace_b.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/time_dependent_input.F90githttp://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodeskfalseStarted by an SCM change89110e59423cac50d7d49ddf6aabea8bf84bbec574110e59423cac50d7d49ddf6aabea8bf84bbec574refs/remotes/origin/master110e59423cac50d7d49ddf6aabea8bf84bbec574110e59423cac50d7d49ddf6aabea8bf84bbec574refs/remotes/origin/master110e59423cac50d7d49ddf6aabea8bf84bbec574110e59423cac50d7d49ddf6aabea8bf84bbec574refs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#8933968991419302clubb_release_diff_test #8989false895237SUCCESS1623918966618http://carson.math.uwm.edu/jenkins/view/all/job/clubb_release_diff_test/89/src/CLUBB_core/stats_zm_module.F90a4f5f736cb16168f40fdc01e454930ffa05fbb4d1623854429000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comFixing typo in stats_zm_module.F90. Background: Since this commit https://github.com/larson-group/clubb/commit/466c5383fa5c0cc85316c6d117826974a5e2e0a3# in August 2020 the upwp budget lines in Pyplotgen have not appeared to be balanced for any cases. It turns out the reason is that a comma and space were added to the upwp_tp variable name in stats_zm_module.F90 in the August 2020 commit. This unusual naming causes pyplotgen not to recognize this variable, so it doesn't get plotted and the lines appear unbalanced. However, since the budget balance test still found the variable, it kept passing successfully. This commit will fix the issue with the pyplotgen plotting by reverting the name to the standard format. This is BIT_CHANGING since it will affect the name of the upwp_tp variable in the X_zm.nc netcdf file, but it will not change results. 2021-06-16 09:40:29 -0500a4f5f736cb16168f40fdc01e454930ffa05fbb4dFixing typo in stats_zm_module.F90. Background: Since this commit https://github.com/larson-group/clubb/commit/466c5383fa5c0cc85316c6d117826974a5e2e0a3# in August 2020 the upwp budget lines in Pyplotgen have not appeared to be balanced for any cases. It turns out the reason is that a comma and space were added to the upwp_tp variable name in stats_zm_module.F90 in the August 2020 commit. This unusual naming causes pyplotgen not to recognize this variable, so it doesn't get plotted and the lines appear unbalanced. However, since the budget balance test still found the variable, it kept passing successfully. This commit will fix the issue with the pyplotgen plotting by reverting the name to the standard format.editsrc/CLUBB_core/stats_zm_module.F90src/CLUBB_core/stats_sfc_module.F90110e59423cac50d7d49ddf6aabea8bf84bbec5741623855537000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comFixing a typo from an earlier commit. See comments in this other commit where a similar typo was fixed: https://github.com/larson-group/clubb/commit/a4f5f736cb16168f40fdc01e454930ffa05fbb4d. 2021-06-16 09:58:57 -0500110e59423cac50d7d49ddf6aabea8bf84bbec574Fixing a typo from an earlier commit.editsrc/CLUBB_core/stats_sfc_module.F90githttp://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephenshttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse90http://carson.math.uwm.edu/jenkins/view/all/job/clubb_release_diff_test/90/88http://carson.math.uwm.edu/jenkins/view/all/job/clubb_release_diff_test/88/Started by an SCM change87699935b5bb4c04bc6e68e83d92a9e0687595449e699935b5bb4c04bc6e68e83d92a9e0687595449erefs/remotes/origin/master699935b5bb4c04bc6e68e83d92a9e0687595449e699935b5bb4c04bc6e68e83d92a9e0687595449erefs/remotes/origin/master699935b5bb4c04bc6e68e83d92a9e0687595449e699935b5bb4c04bc6e68e83d92a9e0687595449erefs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#8733822611419302clubb_release_diff_test #8787false875101SUCCESS1623400567119http://carson.math.uwm.edu/jenkins/view/all/job/clubb_release_diff_test/87/src/CLUBB_core/new_hybrid_pdf_main.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/advance_xp3_module.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/mean_adv.F90src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90src/CLUBB_core/sponge_layer_damping.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/stats_type_utilities.F90src/CLUBB_core/Skx_module.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/microphys_driver.F90src/advance_microphys_module.F90src/CLUBB_core/stats_clubb_utilities.F90src/CLUBB_core/calc_pressure.F90src/CLUBB_core/mono_flux_limiter.F90src/G_unit_test_types/pdf_parameter_tests.F90src/CLUBB_core/advance_helper_module.F90src/CLUBB_core/new_tsdadg_pdf.F90src/CLUBB_core/diffusion.F90src/hydrostatic_module.F90src/CLUBB_core/LY93_pdf.F90src/CLUBB_core/parameters_tunable.F90src/G_unit_test_types/spurious_source_test.F90src/SILHS/latin_hypercube_driver_module.F90src/CLUBB_core/clip_explicit.F90src/CLUBB_core/numerical_check.F90src/CLUBB_core/new_pdf.F90src/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/turbulent_adv_pdf.F90src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/setup_clubb_pdf_params.F90src/CLUBB_core/fill_holes.F90src/CLUBB_core/new_pdf_main.F90src/CLUBB_core/pos_definite_module.F90ddd58c65a871609687a3efd5c33085ff2bec62b31622741937000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFeeding gr through the arg list where need only in the CLUBB_core dir. Note, that since some of the functions/subroutines in CLUBB_core are used elsewhere throughout clubb, other parts of clubb such as a file in SILHS, and a few in the outer layer of the source folder needed to be updated in order to reflect the changes. However, everything outside of the CLUBB_core directory still uses use statements in order to use gr from grid class. For ticket #886. All changes are confirmed BFB identical. 2021-06-03 12:38:57 -0500ddd58c65a871609687a3efd5c33085ff2bec62b3Feeding gr through the arg list where need only in the CLUBB_core dir.editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/CLUBB_core/parameters_tunable.F90editsrc/CLUBB_core/diffusion.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/hydrostatic_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/numerical_check.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/fill_holes.F90editsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/new_pdf_main.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/LY93_pdf.F90editsrc/CLUBB_core/new_pdf.F90editsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90editsrc/SILHS/latin_hypercube_driver_module.F90editsrc/CLUBB_core/new_hybrid_pdf_main.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/advance_xp3_module.F90editsrc/CLUBB_core/sponge_layer_damping.F90editsrc/microphys_driver.F90editsrc/CLUBB_core/calc_pressure.F90editsrc/CLUBB_core/clip_explicit.F90editsrc/CLUBB_core/stats_clubb_utilities.F90editsrc/CLUBB_core/stats_type_utilities.F90editsrc/advance_microphys_module.F90editsrc/CLUBB_core/Skx_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/mean_adv.F90editsrc/CLUBB_core/pos_definite_module.F90editsrc/CLUBB_core/turbulent_adv_pdf.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/new_tsdadg_pdf.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/setup_clubb_pdf_params.F90editsrc/CLUBB_core/mono_flux_limiter.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90src/CLUBB_core/clubb_api_module.F90src/clubb_driver.F90d90832ab307d3fa2e3fb092ede3a0517928f74da1622745453000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduReverted changes to clubb_api. For #886 2021-06-03 13:37:33 -0500d90832ab307d3fa2e3fb092ede3a0517928f74daReverted changes to clubb_api. For #886editsrc/clubb_driver.F90editsrc/CLUBB_core/clubb_api_module.F90src/CLUBB_core/LY93_pdf.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/advance_xp3_module.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90src/CLUBB_core/clip_explicit.F90src/CLUBB_core/numerical_check.F90src/CLUBB_core/new_pdf.F90src/CLUBB_core/Skx_module.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/mono_flux_limiter.F90src/CLUBB_core/fill_holes.F90src/CLUBB_core/advance_helper_module.F90src/CLUBB_core/new_pdf_main.F90a6a774fe14452b30e4e1d011403805eb78a2433e1622821498000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduReplacing use gr statements with feeding gr throught the arg list. This commit is for slight improvement to the script in order to better adhere to the coding standard. For ticket #886. Results confirmed to be BFB identical. 2021-06-04 10:44:58 -0500a6a774fe14452b30e4e1d011403805eb78a2433eReplacing use gr statements with feeding gr throught the arg list.editsrc/CLUBB_core/new_pdf.F90editsrc/CLUBB_core/Skx_module.F90editsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90editsrc/CLUBB_core/LY93_pdf.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/mono_flux_limiter.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/fill_holes.F90editsrc/CLUBB_core/clip_explicit.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/new_pdf_main.F90editsrc/CLUBB_core/advance_xp3_module.F90editsrc/CLUBB_core/numerical_check.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/advance_xp3_module.F90src/CLUBB_core/grid_class.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/mean_adv.F90src/CLUBB_core/saturation.F90src/CLUBB_core/input_reader.F90src/CLUBB_core/sponge_layer_damping.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/stats_type_utilities.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/CLUBB_core/output_netcdf.F90src/CLUBB_core/file_functions.F90src/CLUBB_core/diffusion.F90src/CLUBB_core/matrix_operations.F90src/CLUBB_core/parameters_tunable.F90src/CLUBB_core/clip_explicit.F90src/SILHS/latin_hypercube_driver_module.F90src/CLUBB_core/new_pdf.F90src/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/endian.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/setup_clubb_pdf_params.F90src/CLUBB_core/stats_lh_zt_module.F90src/CLUBB_core/calendar.F90src/CLUBB_core/T_in_K_module.F90src/CLUBB_core/pos_definite_module.F90src/CLUBB_core/diagnose_correlations_module.F90src/CLUBB_core/new_hybrid_pdf_main.F90src/CLUBB_core/interpolation.F90src/CLUBB_core/stats_rad_zm_module.F90src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90src/CLUBB_core/Skx_module.F90src/CLUBB_core/stats_clubb_utilities.F90src/CLUBB_core/mono_flux_limiter.F90src/CLUBB_core/calc_pressure.F90src/CLUBB_core/advance_helper_module.F90src/CLUBB_core/new_tsdadg_pdf.F90src/CLUBB_core/stats_lh_sfc_module.F90src/CLUBB_core/clip_semi_implicit.F90src/CLUBB_core/output_grads.F90src/CLUBB_core/LY93_pdf.F90src/CLUBB_core/numerical_check.F90src/CLUBB_core/parameters_model.F90src/CLUBB_core/lapack_wrap.F90src/CLUBB_core/turbulent_adv_pdf.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/stats_sfc_module.F90src/CLUBB_core/corr_varnce_module.F90src/CLUBB_core/fill_holes.F90src/CLUBB_core/new_pdf_main.F90fead6c4b10ec833a9be084a0fcca80b987da79ea1623168054000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFixed spacing issue when adding in gr. BFB identical. For #886. 2021-06-08 11:00:54 -0500fead6c4b10ec833a9be084a0fcca80b987da79eaFixed spacing issue when adding in gr. BFB identical. For #886.editsrc/CLUBB_core/calendar.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/mono_flux_limiter.F90editsrc/CLUBB_core/clip_explicit.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/stats_type_utilities.F90editsrc/CLUBB_core/file_functions.F90editsrc/CLUBB_core/turbulent_adv_pdf.F90editsrc/CLUBB_core/grid_class.F90editsrc/CLUBB_core/stats_clubb_utilities.F90editsrc/CLUBB_core/endian.F90editsrc/CLUBB_core/diagnose_correlations_module.F90editsrc/CLUBB_core/clip_semi_implicit.F90editsrc/CLUBB_core/parameters_model.F90editsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90editsrc/CLUBB_core/stats_sfc_module.F90editsrc/CLUBB_core/lapack_wrap.F90editsrc/CLUBB_core/setup_clubb_pdf_params.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/new_pdf.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/diffusion.F90editsrc/CLUBB_core/output_grads.F90editsrc/CLUBB_core/fill_holes.F90editsrc/CLUBB_core/mean_adv.F90editsrc/CLUBB_core/new_tsdadg_pdf.F90editsrc/CLUBB_core/calc_pressure.F90editsrc/CLUBB_core/T_in_K_module.F90editsrc/CLUBB_core/numerical_check.F90editsrc/CLUBB_core/interpolation.F90editsrc/CLUBB_core/stats_rad_zm_module.F90editsrc/CLUBB_core/parameters_tunable.F90editsrc/CLUBB_core/advance_xp3_module.F90editsrc/CLUBB_core/Skx_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/stats_lh_sfc_module.F90editsrc/CLUBB_core/corr_varnce_module.F90editsrc/CLUBB_core/stats_lh_zt_module.F90editsrc/CLUBB_core/pos_definite_module.F90editsrc/CLUBB_core/input_reader.F90editsrc/CLUBB_core/new_pdf_main.F90editsrc/SILHS/latin_hypercube_driver_module.F90editsrc/CLUBB_core/LY93_pdf.F90editsrc/CLUBB_core/saturation.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/new_hybrid_pdf_main.F90editsrc/CLUBB_core/output_netcdf.F90editsrc/CLUBB_core/sponge_layer_damping.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/matrix_operations.F90githttp://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskfalse88http://carson.math.uwm.edu/jenkins/view/all/job/clubb_release_diff_test/88/86http://carson.math.uwm.edu/jenkins/view/all/job/clubb_release_diff_test/86/