Started by an SCM change4352090eb2e167c2bd651d84762128d49894a7d54602090eb2e167c2bd651d84762128d49894a7d5460refs/remotes/origin/master2090eb2e167c2bd651d84762128d49894a7d54602090eb2e167c2bd651d84762128d49894a7d5460refs/remotes/origin/master2090eb2e167c2bd651d84762128d49894a7d54602090eb2e167c2bd651d84762128d49894a7d5460refs/remotes/origin/masterhttps://github.com/larson-group/clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_release_diff_test/detail/clubb_release_diff_test/435/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_release_diff_test/detail/clubb_release_diff_test/435/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_release_diff_test/detail/clubb_release_diff_test/435/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_release_diff_test/detail/clubb_release_diff_test/435/testsfalseCheckout Clubb and Clubb_ReleaseDifffalse#435283731419302clubb_release_diff_test #435435false4351333SUCCESS1714639026377http://carson.math.uwm.edu/jenkins/view/all/job/clubb_release_diff_test/435/src/Morrison_microphys/microphysics.F902090eb2e167c2bd651d84762128d49894a7d54601714622486000http://carson.math.uwm.edu/jenkins/user/pickettCole Pickettlarsongroupgithub@gmail.comRaw-copy updating src/Morrison_microphys 2024-05-01 23:01:26 -05002090eb2e167c2bd651d84762128d49894a7d5460Raw-copy updating src/Morrison_microphyseditsrc/Morrison_microphys/microphysics.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2http://carson.math.uwm.edu/jenkins/user/pickettCole Pickettpicketthttp://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther HueblerhueblerfalseStarted by an SCM change436a64e4ba99f0396262814ca42e96ad0b31b2b258ba64e4ba99f0396262814ca42e96ad0b31b2b258brefs/remotes/origin/mastera64e4ba99f0396262814ca42e96ad0b31b2b258ba64e4ba99f0396262814ca42e96ad0b31b2b258brefs/remotes/origin/mastera64e4ba99f0396262814ca42e96ad0b31b2b258ba64e4ba99f0396262814ca42e96ad0b31b2b258brefs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#436302311419302clubb_release_diff_test #436436false4361401SUCCESS1714725430040http://carson.math.uwm.edu/jenkins/view/all/job/clubb_release_diff_test/436/microphysics.F90ada570416e5b0d8d9dc6b1745eb4c1d5ae6ba6641714587855000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking compatible with latest clubb changes. 2024-05-01 13:24:15 -0500ada570416e5b0d8d9dc6b1745eb4c1d5ae6ba664Making compatible with latest clubb changes.editmicrophysics.F90src/CLUBB_core/advance_xm_wpxp_module.F906146f6bd56087e573b5c660d1481e3dc928ff5411714680265000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am committing code that effectively ignores the values of certain zt stats at the ghost level by setting them to 0. This is done to allow for bit-for-bitness comparisons between the master branch and the clubb_ghost_exorcism branch. Technically, since zt stat file output at the irrelevant ghost level is changed for some variables, this commit is BIT_CHANGING. Effectively, this commit doesn't change squat in terms of model results. 2024-05-02 15:04:25 -05006146f6bd56087e573b5c660d1481e3dc928ff541I am committing code that effectively ignores the values of certaineditsrc/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_xm_wpxp_module.F903b3339a9e9932452f21db516965e9b7e379a22281714685456000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am moving the advance_xm_wpxp setting of xm(1) = xm(2) from the end of xm_clipping_and_stats to the very end of advance_xm_wpxp, right before the return to advance_clubb_core. The reason I am doing this is the nudging was done after setting xm(1) = xm(2) and would alter the results. This is no longer the case, as setting xm(1) = xm(2) is now being done after nudging. This is being done in advance of removal of the ghost point from CLUBB. This helps ensure a bit-for-bit match between the ghost exorcism branch and the master branch. This commit technically alter fields such as um, vm, um_bt, vm_bt, wpup2, wpvp2, and shear at level 1 only. Thus, this commit is technically BIT_CHANGING. Effectively, once again, this commit doesn't change squat. 2024-05-02 16:30:56 -05003b3339a9e9932452f21db516965e9b7e379a2228I am moving the advance_xm_wpxp setting of xm(1) = xm(2) from theeditsrc/CLUBB_core/advance_xm_wpxp_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse437http://carson.math.uwm.edu/jenkins/view/all/job/clubb_release_diff_test/437/435http://carson.math.uwm.edu/jenkins/view/all/job/clubb_release_diff_test/435/Started by user Gunther HueblerhueblerGunther Huebler4343abb325943da1a557e1213b2908ead3c828aff163abb325943da1a557e1213b2908ead3c828aff16refs/remotes/origin/master3abb325943da1a557e1213b2908ead3c828aff163abb325943da1a557e1213b2908ead3c828aff16refs/remotes/origin/master3abb325943da1a557e1213b2908ead3c828aff163abb325943da1a557e1213b2908ead3c828aff16refs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#434237681419302clubb_release_diff_test #434434false4341287FAILURE1714598811797http://carson.math.uwm.edu/jenkins/view/all/job/clubb_release_diff_test/434/src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/clubb_api_module.F90src/Morrison_microphys/microphysics.F90src/CLUBB_core/fill_holes.F90src/CLUBB_core/advance_xp2_xpyp_module.F903abb325943da1a557e1213b2908ead3c828aff161714587276000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking num_draw_points in fill_holes a constant. We were already using this value as a constant everywhere, but passing a constant by argument list makes it difficult/impossible for a compiler to optimize using that constant, unless it does inlining. Now, rather than passing the constant num_hf_draw_points (or sometimes a hardcoded 2) we just use num_hf_draw_points directly from constants_clubb. This massively improves the performance of a loop in fill holes when using nvhpc+omp, which was the motivation for this, but should also improve the performance on CPUs. Everything is BFB. 2024-05-01 13:14:36 -05003abb325943da1a557e1213b2908ead3c828aff16Making num_draw_points in fill_holes a constant. We were already using this value as a constant everywhere, but passing a constant by argument list makes it difficult/impossible for a compiler to optimize using that constant, unless it does inlining. Now, rather than passing the constant num_hf_draw_points (or sometimes a hardcoded 2) we just use num_hf_draw_points directly from constants_clubb. This massively improves the performance of a loop in fill holes when using nvhpc+omp, which was the motivation for this, but should also improve the performance on CPUs. Everything is BFB.editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/Morrison_microphys/microphysics.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/fill_holes.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse435http://carson.math.uwm.edu/jenkins/view/all/job/clubb_release_diff_test/435/433http://carson.math.uwm.edu/jenkins/view/all/job/clubb_release_diff_test/433/