Started by an SCM change11512407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master12407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master98b19b67713baf175f99baa0cb0bdde6e8c1fbc588b19b67713baf175f99baa0cb0bdde6e8c1fbc588origin/grid_fixesb19b67713baf175f99baa0cb0bdde6e8c1fbc588b19b67713baf175f99baa0cb0bdde6e8c1fbc588origin/grid_fixes92b928767c7238139d599dc55420d2a0956161726ab928767c7238139d599dc55420d2a0956161726aorigin/feeding_gr_to_hostb928767c7238139d599dc55420d2a0956161726ab928767c7238139d599dc55420d2a0956161726aorigin/feeding_gr_to_host3107f1decd0252e0b4d80f4b3873b0b48b6d3ec86317f1decd0252e0b4d80f4b3873b0b48b6d3ec8631refs/remotes/origin/master7f1decd0252e0b4d80f4b3873b0b48b6d3ec86317f1decd0252e0b4d80f4b3873b0b48b6d3ec8631refs/remotes/origin/master7f1decd0252e0b4d80f4b3873b0b48b6d3ec86317f1decd0252e0b4d80f4b3873b0b48b6d3ec8631refs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#3101808129633562clubb_openmp_gfortran_test #310310false31020011SUCCESS1674119828481http://carson.math.uwm.edu/jenkins/view/all/job/clubb_openmp_gfortran_test/310/src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/model_flags.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/saturation.F907f1decd0252e0b4d80f4b3873b0b48b6d3ec86311674081416000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRestructuring and Porting of Compute_mixing_length subroutine(Phase 2) (#1054) * Restructuring and Porting of Compute_mixing_length subroutine(Phase 2) Restructure: sat_mixrat_liq_2D_acc is being directly called instead of calling the 1D version inside the column loop. Changing sat_mixrat_liq_2D_acc to a subroutine from a function and adding output array, start_index as additional argument. This is a workaround for passing sub-arrays. The OpenACC doen't like the sub-arrays being passed and fails the validation. Porting: OpenACC directives are added inside sat_mixrat_liq_2D_acc for porting Validation: Answers are Bit for Bit with arm-multicolumn case + nvhpc compiler * Fix for compilation issues Issue 1: Missed out declaring 'start_index' while intergrating the change Issue 2: The use of error_code module and the procedures inside it causes OpenACC compilation issues when run on the device. * Removing the sat_mixrat_liq_acc and sat_mixrat_liq_2D_acc, making the normal sat_mixrat_liq work for all current use cases, and making the other versions of sat_mixrat_liq (bolton,gfdl,lookup) functional with OPENACC. Co-authored-by: huebler <huebler@uwm.edu> 2023-01-18 16:36:56 -06007f1decd0252e0b4d80f4b3873b0b48b6d3ec8631Restructuring and Porting of Compute_mixing_length subroutine(Phase 2) (#1054)editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/saturation.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/model_flags.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse311http://carson.math.uwm.edu/jenkins/view/all/job/clubb_openmp_gfortran_test/311/309http://carson.math.uwm.edu/jenkins/view/all/job/clubb_openmp_gfortran_test/309/