Started by an SCM change746fc57497840efaa7acc394c10ac9c6892ef162206fc57497840efaa7acc394c10ac9c6892ef16220origin/clubb_silhs_devel6fc57497840efaa7acc394c10ac9c6892ef162206fc57497840efaa7acc394c10ac9c6892ef16220origin/clubb_silhs_devel69cca799cfb394e7eeadc21211ae811b4a370d31eecca799cfb394e7eeadc21211ae811b4a370d31eeorigin/changes_to_not_breakcca799cfb394e7eeadc21211ae811b4a370d31eecca799cfb394e7eeadc21211ae811b4a370d31eeorigin/changes_to_not_break25616aac63217c6756290a5e6ae0e0040a691d268e216aac63217c6756290a5e6ae0e0040a691d268e2refs/remotes/origin/clubb_silhs_devel16aac63217c6756290a5e6ae0e0040a691d268e216aac63217c6756290a5e6ae0e0040a691d268e2refs/remotes/origin/clubb_silhs_devel16aac63217c6756290a5e6ae0e0040a691d268e216aac63217c6756290a5e6ae0e0040a691d268e2refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#25658606681992202cam_global_ERP_Ln9_gfortran_test #256256false25620051SUCCESS1674121628837http://carson.math.uwm.edu/jenkins/view/all/job/cam_global_ERP_Ln9_gfortran_test/256/mixing_length.F90saturation.F90advance_clubb_core_module.F90model_flags.F9038b63ff28ea145707d4ee1d9469013ee20b1697b1674081416000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRestructuring and Porting of Compute_mixing_length subroutine(Phase 2) (#1054) * Restructuring and Porting of Compute_mixing_length subroutine(Phase 2) Restructure: sat_mixrat_liq_2D_acc is being directly called instead of calling the 1D version inside the column loop. Changing sat_mixrat_liq_2D_acc to a subroutine from a function and adding output array, start_index as additional argument. This is a workaround for passing sub-arrays. The OpenACC doen't like the sub-arrays being passed and fails the validation. Porting: OpenACC directives are added inside sat_mixrat_liq_2D_acc for porting Validation: Answers are Bit for Bit with arm-multicolumn case + nvhpc compiler * Fix for compilation issues Issue 1: Missed out declaring 'start_index' while intergrating the change Issue 2: The use of error_code module and the procedures inside it causes OpenACC compilation issues when run on the device. * Removing the sat_mixrat_liq_acc and sat_mixrat_liq_2D_acc, making the normal sat_mixrat_liq work for all current use cases, and making the other versions of sat_mixrat_liq (bolton,gfdl,lookup) functional with OPENACC. Co-authored-by: huebler <huebler@uwm.edu> 2023-01-18 16:36:56 -060038b63ff28ea145707d4ee1d9469013ee20b1697bRestructuring and Porting of Compute_mixing_length subroutine(Phase 2) (#1054)editsaturation.F90editmodel_flags.F90editmixing_length.F90editadvance_clubb_core_module.F90githttp://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwmhttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse257http://carson.math.uwm.edu/jenkins/view/all/job/cam_global_ERP_Ln9_gfortran_test/257/255http://carson.math.uwm.edu/jenkins/view/all/job/cam_global_ERP_Ln9_gfortran_test/255/