Started by an SCM change170418af1b5ff11ae2a379e1c859956c5ac0a14e4fb418af1b5ff11ae2a379e1c859956c5ac0a14e4fbrefs/remotes/origin/clubb_silhs_devel418af1b5ff11ae2a379e1c859956c5ac0a14e4fb418af1b5ff11ae2a379e1c859956c5ac0a14e4fbrefs/remotes/origin/clubb_silhs_devel418af1b5ff11ae2a379e1c859956c5ac0a14e4fb418af1b5ff11ae2a379e1c859956c5ac0a14e4fbrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#17015893752524808cam_BFB_coarse_res_gfortran_test #170170false1708625SUCCESS1744273629823http://carson.math.uwm.edu/jenkins/view/all/job/cam_BFB_coarse_res_gfortran_test/170/precipitation_fraction.F90setup_clubb_pdf_params.F9055eae9b809c45299075475da2f488ecaac258a831744204547000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb silhs gg (#1239) * I added new subroutine pdf_hydromet_microphys_prep to encompass the code that calls the hydrometeor PDF and then ultimately handles the setup of SILHS sample points when SILHS is in use. * Placeholder subroutine for SILHS grid generalization test. * I have now connected the new subroutine to run_clubb. The results for all cases match bit-for-bit to the previous revision. * Cleaning up from the refactoring of the hydrometeor PDF and SILHS code into a wrapper subroutine. * I'm moving pdf_hydromet_microphys_prep to its own file to avoid circular dependency once it finally needs to be called from the generalized grid test code soon. * Added some code to the SILHS generalized grid test. * Changes to make this a fully functioning grid generalization test for the part of the microphysics code that encompasses setup_pdf_parameters and hydrometeor_mixed_moments. * I have completed the code for the SILHS generalized grid test. * I generalized precipitation fraction for ascending vs. descending grid. * Fixing a bug that I noticed in the precipitation fraction calculation when the component precip frac calculation was set to option 1 (which is currently not the default). * The code should now be successfully grid-generalized for SILHS. The ascending vs descending grid test should work now for all cases. * Updating the core flags .json file to change some of the SILHS flags. * I moved the call to advance_clubb_core_api (the default run option) to the top of the "if" block, ahead of the grid generalization test option that is now in the "else" block. * Adding a new, hardwired constant flag called l_ascending_grid and setting it to true in clubb_driver.F90. * Keeping lines under 100 characters in length. * Making it so the ascending vs. descending grid tests pass for the l_lh_random_start flag. 2025-04-09 08:15:47 -050055eae9b809c45299075475da2f488ecaac258a83Clubb silhs gg (#1239)editprecipitation_fraction.F90editsetup_clubb_pdf_params.F90silhs_api_module.F90latin_hypercube_driver_module.F9022f5d492241112ab03918dbd8041883b5b2ae28b1744204547000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb silhs gg (#1239) * I added new subroutine pdf_hydromet_microphys_prep to encompass the code that calls the hydrometeor PDF and then ultimately handles the setup of SILHS sample points when SILHS is in use. * Placeholder subroutine for SILHS grid generalization test. * I have now connected the new subroutine to run_clubb. The results for all cases match bit-for-bit to the previous revision. * Cleaning up from the refactoring of the hydrometeor PDF and SILHS code into a wrapper subroutine. * I'm moving pdf_hydromet_microphys_prep to its own file to avoid circular dependency once it finally needs to be called from the generalized grid test code soon. * Added some code to the SILHS generalized grid test. * Changes to make this a fully functioning grid generalization test for the part of the microphysics code that encompasses setup_pdf_parameters and hydrometeor_mixed_moments. * I have completed the code for the SILHS generalized grid test. * I generalized precipitation fraction for ascending vs. descending grid. * Fixing a bug that I noticed in the precipitation fraction calculation when the component precip frac calculation was set to option 1 (which is currently not the default). * The code should now be successfully grid-generalized for SILHS. The ascending vs descending grid test should work now for all cases. * Updating the core flags .json file to change some of the SILHS flags. * I moved the call to advance_clubb_core_api (the default run option) to the top of the "if" block, ahead of the grid generalization test option that is now in the "else" block. * Adding a new, hardwired constant flag called l_ascending_grid and setting it to true in clubb_driver.F90. * Keeping lines under 100 characters in length. * Making it so the ascending vs. descending grid tests pass for the l_lh_random_start flag. 2025-04-09 08:15:47 -050022f5d492241112ab03918dbd8041883b5b2ae28bClubb silhs gg (#1239)editlatin_hypercube_driver_module.F90editsilhs_api_module.F90src/physics/cam/subcol_SILHS.F904ee92ccfb630f3f8c3b56d986886b6b114d193b21744205138000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdating CAM-CLUBB for recent changes made to CLUBB-SILHS code. 2025-04-09 08:25:38 -05004ee92ccfb630f3f8c3b56d986886b6b114d193b2Updating CAM-CLUBB for recent changes made to CLUBB-SILHS code.editsrc/physics/cam/subcol_SILHS.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse171http://carson.math.uwm.edu/jenkins/view/all/job/cam_BFB_coarse_res_gfortran_test/171/169http://carson.math.uwm.edu/jenkins/view/all/job/cam_BFB_coarse_res_gfortran_test/169/