{ "_class" : "org.jenkinsci.plugins.workflow.job.WorkflowRun", "actions" : [ { "_class" : "hudson.model.ParametersAction", "parameters" : [ { "_class" : "hudson.model.StringParameterValue", "name" : "TEST", "value" : "sam_clubb_nvhpc_build" }, { "_class" : "net.uaznia.lukanus.hudson.plugins.gitparameter.GitParameterValue", "name" : "BRANCH", "value" : "origin/master" } ] }, { "_class" : "hudson.model.CauseAction", "causes" : [ { "_class" : "hudson.model.Cause$UserIdCause", "shortDescription" : "Started by user carstensen", "userId" : "carstensen", "userName" : "carstensen" } ] }, { }, { "_class" : "hudson.plugins.git.util.BuildData", "buildsByBranchName" : { "refs/remotes/origin/flag_removal" : { "_class" : "hudson.plugins.git.util.Build", "buildNumber" : 40, "buildResult" : None, "marked" : { "SHA1" : "9687fd653c50c09e15df81168c05b1fdaa1d8f98", "branch" : [ { "SHA1" : "9687fd653c50c09e15df81168c05b1fdaa1d8f98", "name" : "refs/remotes/origin/flag_removal" } ] }, "revision" : { "SHA1" : "9687fd653c50c09e15df81168c05b1fdaa1d8f98", "branch" : [ { "SHA1" : "9687fd653c50c09e15df81168c05b1fdaa1d8f98", "name" : "refs/remotes/origin/flag_removal" } ] } }, "refs/remotes/origin/ticket_1174_jenkins_test" : { "_class" : "hudson.plugins.git.util.Build", "buildNumber" : 75, "buildResult" : None, "marked" : { "SHA1" : "ae7fc181fd2bfff9d349e78ab031b2fc7172db1a", "branch" : [ { "SHA1" : "ae7fc181fd2bfff9d349e78ab031b2fc7172db1a", "name" : "refs/remotes/origin/ticket_1174_jenkins_test" } ] }, "revision" : { "SHA1" : "ae7fc181fd2bfff9d349e78ab031b2fc7172db1a", "branch" : [ { "SHA1" : "ae7fc181fd2bfff9d349e78ab031b2fc7172db1a", "name" : "refs/remotes/origin/ticket_1174_jenkins_test" } ] } }, "refs/remotes/origin/l_vary_convect_depth_addition" : { "_class" : "hudson.plugins.git.util.Build", "buildNumber" : 44, "buildResult" : None, "marked" : { "SHA1" : "ac319abf904ec136d6e0b259b9c74de95e4ac85a", "branch" : [ { "SHA1" : "ac319abf904ec136d6e0b259b9c74de95e4ac85a", "name" : "refs/remotes/origin/l_vary_convect_depth_addition" } ] }, "revision" : { "SHA1" : "ac319abf904ec136d6e0b259b9c74de95e4ac85a", "branch" : [ { "SHA1" : "ac319abf904ec136d6e0b259b9c74de95e4ac85a", "name" : "refs/remotes/origin/l_vary_convect_depth_addition" } ] } }, "refs/remotes/origin/changes_to_not_break" : { "_class" : "hudson.plugins.git.util.Build", "buildNumber" : 3, "buildResult" : None, "marked" : { "SHA1" : "fcb64a792d6631be39938f67e613ded134dd5dca", "branch" : [ { "SHA1" : "fcb64a792d6631be39938f67e613ded134dd5dca", "name" : "refs/remotes/origin/changes_to_not_break" } ] }, "revision" : { "SHA1" : "fcb64a792d6631be39938f67e613ded134dd5dca", "branch" : [ { "SHA1" : "fcb64a792d6631be39938f67e613ded134dd5dca", "name" : "refs/remotes/origin/changes_to_not_break" } ] } }, "refs/remotes/origin/readiopdata_nf90" : { "_class" : "hudson.plugins.git.util.Build", "buildNumber" : 28, "buildResult" : None, "marked" : { "SHA1" : "14edaf741e6d665c0f89a28cfaeca1a95ea693d7", "branch" : [ { "SHA1" : "14edaf741e6d665c0f89a28cfaeca1a95ea693d7", "name" : "refs/remotes/origin/readiopdata_nf90" } ] }, "revision" : { "SHA1" : "14edaf741e6d665c0f89a28cfaeca1a95ea693d7", "branch" : [ { "SHA1" : "14edaf741e6d665c0f89a28cfaeca1a95ea693d7", "name" : "refs/remotes/origin/readiopdata_nf90" } ] } }, "refs/remotes/origin/bv_efold" : { "_class" : "hudson.plugins.git.util.Build", "buildNumber" : 55, "buildResult" : None, "marked" : { "SHA1" : "19a49f4d999e3c3b6824b4ec8f9c3eee408b48e8", "branch" : [ { "SHA1" : "19a49f4d999e3c3b6824b4ec8f9c3eee408b48e8", "name" : "refs/remotes/origin/bv_efold" } ] }, "revision" : { "SHA1" : "19a49f4d999e3c3b6824b4ec8f9c3eee408b48e8", "branch" : [ { "SHA1" : "19a49f4d999e3c3b6824b4ec8f9c3eee408b48e8", "name" : "refs/remotes/origin/bv_efold" } ] } }, "refs/remotes/origin/systemf_bug_20231018" : { "_class" : "hudson.plugins.git.util.Build", "buildNumber" : 63, "buildResult" : None, "marked" : { "SHA1" : "e091ca1bcb39ea1ed267ec6e3f3f571965329608", "branch" : [ { "SHA1" : "e091ca1bcb39ea1ed267ec6e3f3f571965329608", "name" : "refs/remotes/origin/systemf_bug_20231018" } ] }, "revision" : { "SHA1" : "e091ca1bcb39ea1ed267ec6e3f3f571965329608", "branch" : [ { "SHA1" : "e091ca1bcb39ea1ed267ec6e3f3f571965329608", "name" : "refs/remotes/origin/systemf_bug_20231018" } ] } }, "refs/remotes/origin/z_displace_tunable" : { "_class" : "hudson.plugins.git.util.Build", "buildNumber" : 64, "buildResult" : None, "marked" : { "SHA1" : "d58c775f6c0698e0c1b1051aba1f1d520ef3ddbd", "branch" : [ { "SHA1" : "d58c775f6c0698e0c1b1051aba1f1d520ef3ddbd", "name" : "refs/remotes/origin/z_displace_tunable" } ] }, "revision" : { "SHA1" : "d58c775f6c0698e0c1b1051aba1f1d520ef3ddbd", "branch" : [ { "SHA1" : "d58c775f6c0698e0c1b1051aba1f1d520ef3ddbd", "name" : "refs/remotes/origin/z_displace_tunable" } ] } }, "refs/remotes/origin/spack_updates" : { "_class" : "hudson.plugins.git.util.Build", "buildNumber" : 67, "buildResult" : None, "marked" : { "SHA1" : "4d73cd62d819c07473f03a4831210759c8e57546", "branch" : [ { "SHA1" : "4d73cd62d819c07473f03a4831210759c8e57546", "name" : "refs/remotes/origin/spack_updates" } ] }, "revision" : { "SHA1" : "4d73cd62d819c07473f03a4831210759c8e57546", "branch" : [ { "SHA1" : "4d73cd62d819c07473f03a4831210759c8e57546", "name" : "refs/remotes/origin/spack_updates" } ] } }, "refs/remotes/origin/ticket_1152_jenkins_test" : { "_class" : "hudson.plugins.git.util.Build", "buildNumber" : 73, "buildResult" : None, "marked" : { "SHA1" : "b2539d0b0e596f1a78d93eabb40ea5c5853c9a9b", "branch" : [ { "SHA1" : "b2539d0b0e596f1a78d93eabb40ea5c5853c9a9b", "name" : "refs/remotes/origin/ticket_1152_jenkins_test" } ] }, "revision" : { "SHA1" : "b2539d0b0e596f1a78d93eabb40ea5c5853c9a9b", "branch" : [ { "SHA1" : "b2539d0b0e596f1a78d93eabb40ea5c5853c9a9b", "name" : "refs/remotes/origin/ticket_1152_jenkins_test" } ] } }, "refs/remotes/origin/stats_testing" : { "_class" : "hudson.plugins.git.util.Build", "buildNumber" : 7, "buildResult" : None, "marked" : { "SHA1" : "9ddfec7a3b139dfeeb8cfdaf78ad0f09d9c36f82", "branch" : [ { "SHA1" : "9ddfec7a3b139dfeeb8cfdaf78ad0f09d9c36f82", "name" : "refs/remotes/origin/stats_testing" } ] }, "revision" : { "SHA1" : "9ddfec7a3b139dfeeb8cfdaf78ad0f09d9c36f82", "branch" : [ { "SHA1" : "9ddfec7a3b139dfeeb8cfdaf78ad0f09d9c36f82", "name" : "refs/remotes/origin/stats_testing" } ] } }, "refs/remotes/origin/stats_for_host" : { "_class" : "hudson.plugins.git.util.Build", "buildNumber" : 24, "buildResult" : None, "marked" : { "SHA1" : "b8d176c11a7fc2b842245dcaec35cd93959f64c9", "branch" : [ { "SHA1" : "b8d176c11a7fc2b842245dcaec35cd93959f64c9", "name" : "refs/remotes/origin/stats_for_host" } ] }, "revision" : { "SHA1" : "b8d176c11a7fc2b842245dcaec35cd93959f64c9", "branch" : [ { "SHA1" : "b8d176c11a7fc2b842245dcaec35cd93959f64c9", "name" : "refs/remotes/origin/stats_for_host" } ] } }, "refs/remotes/origin/wpxp_Ri_exp" : { "_class" : "hudson.plugins.git.util.Build", "buildNumber" : 56, "buildResult" : None, "marked" : { "SHA1" : "100c216c1c1bc844ee40fcd6db176da835b08e7d", "branch" : [ { "SHA1" : "100c216c1c1bc844ee40fcd6db176da835b08e7d", "name" : "refs/remotes/origin/wpxp_Ri_exp" } ] }, "revision" : { "SHA1" : "100c216c1c1bc844ee40fcd6db176da835b08e7d", "branch" : [ { "SHA1" : "100c216c1c1bc844ee40fcd6db176da835b08e7d", "name" : "refs/remotes/origin/wpxp_Ri_exp" } ] } }, "refs/remotes/origin/sam_clubb_ghostless" : { "_class" : "hudson.plugins.git.util.Build", "buildNumber" : 68, "buildResult" : None, "marked" : { "SHA1" : "54361922bf9e85b072e7b13e863123146e98eed2", "branch" : [ { "SHA1" : "54361922bf9e85b072e7b13e863123146e98eed2", "name" : "refs/remotes/origin/sam_clubb_ghostless" } ] }, "revision" : { "SHA1" : "54361922bf9e85b072e7b13e863123146e98eed2", "branch" : [ { "SHA1" : "54361922bf9e85b072e7b13e863123146e98eed2", "name" : "refs/remotes/origin/sam_clubb_ghostless" } ] } }, "refs/remotes/origin/sam_mono2" : { "_class" : "hudson.plugins.git.util.Build", "buildNumber" : 54, "buildResult" : None, "marked" : { "SHA1" : "df4407eb7d7ee086d5ac3da209b3ad37a9c995a9", "branch" : [ { "SHA1" : "df4407eb7d7ee086d5ac3da209b3ad37a9c995a9", "name" : "refs/remotes/origin/sam_mono2" } ] }, "revision" : { "SHA1" : "df4407eb7d7ee086d5ac3da209b3ad37a9c995a9", "branch" : [ { "SHA1" : "df4407eb7d7ee086d5ac3da209b3ad37a9c995a9", "name" : "refs/remotes/origin/sam_mono2" } ] } }, "refs/remotes/origin/master" : { "_class" : "hudson.plugins.git.util.Build", "buildNumber" : 76, "buildResult" : None, "marked" : { "SHA1" : "a23f224b290487aeb6a4c0d90d486268a98b1164", "branch" : [ { "SHA1" : "a23f224b290487aeb6a4c0d90d486268a98b1164", "name" : "refs/remotes/origin/master" } ] }, "revision" : { "SHA1" : "a23f224b290487aeb6a4c0d90d486268a98b1164", "branch" : [ { "SHA1" : "a23f224b290487aeb6a4c0d90d486268a98b1164", "name" : "refs/remotes/origin/master" } ] } } }, "lastBuiltRevision" : { "SHA1" : "a23f224b290487aeb6a4c0d90d486268a98b1164", "branch" : [ { "SHA1" : "a23f224b290487aeb6a4c0d90d486268a98b1164", "name" : "refs/remotes/origin/master" } ] }, "remoteUrls" : [ "https://github.com/larson-group/sam_clubb.git" ], "scmName" : "" }, { }, { "_class" : "org.jenkinsci.plugins.workflow.libs.LibrariesAction" }, { }, { "_class" : "org.jenkinsci.plugins.workflow.cps.EnvActionImpl" }, { }, { }, { }, { "_class" : "org.jenkinsci.plugins.displayurlapi.actions.RunDisplayAction" }, { "_class" : "org.jenkinsci.plugins.pipeline.modeldefinition.actions.RestartDeclarativePipelineAction" }, { }, { "_class" : "org.jenkinsci.plugins.workflow.job.views.FlowGraphAction" }, { }, { }, { }, { } ], "artifacts" : [ ], "building" : False, "description" : None, "displayName" : "#76", "duration" : 54771, "estimatedDuration" : 778629, "executor" : None, "fullDisplayName" : "branch_sam_test #76", "id" : "76", "keepLog" : False, "number" : 76, "queueId" : 3096, "result" : "SUCCESS", "timestamp" : 1727896231040, "url" : "http://carson.math.uwm.edu/jenkins/view/all/job/branch_sam_test/76/", "changeSets" : [ { "_class" : "hudson.plugins.git.GitChangeSetList", "items" : [ { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_wp2_wp3_module.F90", "advance_xp2_xpyp_module.F90", "diffusion.F90", "advance_xm_wpxp_module.F90", "mean_adv.F90", "advance_windm_edsclrm_module.F90", "turbulent_adv_pdf.F90", "mono_flux_limiter.F90" ], "commitId" : "d31bd736050a9cad0297ae5ce8edc54b92e686f3", "timestamp" : 1654647552000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Lots of small loop pushes\u000a", "date" : "2022-06-07 19:19:12 -0500", "id" : "d31bd736050a9cad0297ae5ce8edc54b92e686f3", "msg" : "Lots of small loop pushes", "paths" : [ { "editType" : "edit", "file" : "advance_windm_edsclrm_module.F90" }, { "editType" : "edit", "file" : "mono_flux_limiter.F90" }, { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" }, { "editType" : "edit", "file" : "diffusion.F90" }, { "editType" : "edit", "file" : "mean_adv.F90" }, { "editType" : "edit", "file" : "turbulent_adv_pdf.F90" }, { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" }, { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mixing_length.F90" ], "commitId" : "a64cacf0a77189a2f5e834d18911b1b3e6594a7b", "timestamp" : 1654647552000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Small bug fix. This was not a bit changing bug, but could cause crashes if we compile with floating point trapping in a multicolumn run.\u000a", "date" : "2022-06-07 19:19:12 -0500", "id" : "a64cacf0a77189a2f5e834d18911b1b3e6594a7b", "msg" : "Small bug fix. This was not a bit changing bug, but could cause crashes if we compile with floating point trapping in a multicolumn run.", "paths" : [ { "editType" : "edit", "file" : "mixing_length.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mono_flux_limiter.F90" ], "commitId" : "fcfffe10437ae1515c57311853370d6d071411ac", "timestamp" : 1654647552000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Small refactoring to mfl_xm_lhs, just removing need to pass in gr.\u000a", "date" : "2022-06-07 19:19:12 -0500", "id" : "fcfffe10437ae1515c57311853370d6d071411ac", "msg" : "Small refactoring to mfl_xm_lhs, just removing need to pass in gr.", "paths" : [ { "editType" : "edit", "file" : "mono_flux_limiter.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "grid_class.F90", "clubb_api_module.F90" ], "commitId" : "9f6a4e357eb6f213de0fa9831082355536bebc4b", "timestamp" : 1654647552000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Final loop pushes needed before the grid change.\u000a", "date" : "2022-06-07 19:19:12 -0500", "id" : "9f6a4e357eb6f213de0fa9831082355536bebc4b", "msg" : "Final loop pushes needed before the grid change.", "paths" : [ { "editType" : "edit", "file" : "grid_class.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "fill_holes.F90" ], "commitId" : "3fbfd621fd949b5528742b496e77400bc076a08d", "timestamp" : 1654647552000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Replacing use of gr with nz\u000a", "date" : "2022-06-07 19:19:12 -0500", "id" : "3fbfd621fd949b5528742b496e77400bc076a08d", "msg" : "Replacing use of gr with nz", "paths" : [ { "editType" : "edit", "file" : "fill_holes.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "latin_hypercube_driver_module.F90" ], "commitId" : "dfe7ab7f892dc32e5d63486c1218f36076eac9f4", "timestamp" : 1654647552000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Replacing use of gr with nz\u000a", "date" : "2022-06-07 19:19:12 -0500", "id" : "dfe7ab7f892dc32e5d63486c1218f36076eac9f4", "msg" : "Replacing use of gr with nz", "paths" : [ { "editType" : "edit", "file" : "latin_hypercube_driver_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "Makefile" ], "commitId" : "f705e8f2f08c20a6f082647a6064051033d83bc2", "timestamp" : 1654784045000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/cernikt", "fullName" : "cernikt" }, "authorEmail" : "cernikt@msoe.edu", "comment" : "added -heap-arrays tag to FFlags on Makefile to fix jenkins testing error\u000a", "date" : "2022-06-09 09:14:05 -0500", "id" : "f705e8f2f08c20a6f082647a6064051033d83bc2", "msg" : "added -heap-arrays tag to FFlags on Makefile to fix jenkins testing error", "paths" : [ { "editType" : "edit", "file" : "Makefile" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "Makefile" ], "commitId" : "32cdf1eb92d93a5b37cbb9598275b59d07ff3c50", "timestamp" : 1654802592000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/cernikt", "fullName" : "cernikt" }, "authorEmail" : "cernikt@msoe.edu", "comment" : "Makefile came with a few other accidental changes, these have been corrected.\u000a", "date" : "2022-06-09 14:23:12 -0500", "id" : "32cdf1eb92d93a5b37cbb9598275b59d07ff3c50", "msg" : "Makefile came with a few other accidental changes, these have been corrected.", "paths" : [ { "editType" : "edit", "file" : "Makefile" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "diffusion.F90", "clip_explicit.F90", "clubb_api_module.F90", "advance_xm_wpxp_module.F90", "pos_definite_module.F90", "parameters_tunable.F90", "grid_class.F90", "sponge_layer_damping.F90", "setup_clubb_pdf_params.F90", "turbulent_adv_pdf.F90", "advance_windm_edsclrm_module.F90", "advance_helper_module.F90", "mono_flux_limiter.F90", "advance_wp2_wp3_module.F90", "mixing_length.F90", "advance_xp2_xpyp_module.F90", "advance_xp3_module.F90", "advance_clubb_core_module.F90", "fill_holes.F90", "pdf_closure_module.F90", "adg1_adg2_3d_luhar_pdf.F90", "stats_clubb_utilities.F90", "calc_pressure.F90" ], "commitId" : "fece46637566b9e53ed2e20894a4f53cc2f617da", "timestamp" : 1654818473000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "The big grid change. Converting gr from being an array of types containing 1D arrays, to a type containing 2D arrays. All cases BFB, cam multicolumn+silhs BFB, and cam multicolumn (no silhs) with backwards compatible settings BFB.\u000a", "date" : "2022-06-09 18:47:53 -0500", "id" : "fece46637566b9e53ed2e20894a4f53cc2f617da", "msg" : "The big grid change. Converting gr from being an array of types containing 1D arrays, to a type containing 2D arrays. All cases BFB, cam multicolumn+silhs BFB, and cam multicolumn (no silhs) with backwards compatible settings BFB.", "paths" : [ { "editType" : "edit", "file" : "turbulent_adv_pdf.F90" }, { "editType" : "edit", "file" : "pos_definite_module.F90" }, { "editType" : "edit", "file" : "adg1_adg2_3d_luhar_pdf.F90" }, { "editType" : "edit", "file" : "parameters_tunable.F90" }, { "editType" : "edit", "file" : "diffusion.F90" }, { "editType" : "edit", "file" : "grid_class.F90" }, { "editType" : "edit", "file" : "advance_helper_module.F90" }, { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" }, { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" }, { "editType" : "edit", "file" : "clip_explicit.F90" }, { "editType" : "edit", "file" : "stats_clubb_utilities.F90" }, { "editType" : "edit", "file" : "advance_xp3_module.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" }, { "editType" : "edit", "file" : "sponge_layer_damping.F90" }, { "editType" : "edit", "file" : "advance_windm_edsclrm_module.F90" }, { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" }, { "editType" : "edit", "file" : "calc_pressure.F90" }, { "editType" : "edit", "file" : "mono_flux_limiter.F90" }, { "editType" : "edit", "file" : "pdf_closure_module.F90" }, { "editType" : "edit", "file" : "fill_holes.F90" }, { "editType" : "edit", "file" : "mixing_length.F90" }, { "editType" : "edit", "file" : "setup_clubb_pdf_params.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "silhs_api_module.F90", "latin_hypercube_driver_module.F90" ], "commitId" : "dcb05d4849a9fd845627278f534f82c5d95b5424", "timestamp" : 1654818473000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "The big grid change. Converting gr from being an array of types containing 1D arrays, to a type containing 2D arrays. All cases BFB, cam multicolumn+silhs BFB, and cam multicolumn (no silhs) with backwards compatible settings BFB.\u000a", "date" : "2022-06-09 18:47:53 -0500", "id" : "dcb05d4849a9fd845627278f534f82c5d95b5424", "msg" : "The big grid change. Converting gr from being an array of types containing 1D arrays, to a type containing 2D arrays. All cases BFB, cam multicolumn+silhs BFB, and cam multicolumn (no silhs) with backwards compatible settings BFB.", "paths" : [ { "editType" : "edit", "file" : "latin_hypercube_driver_module.F90" }, { "editType" : "edit", "file" : "silhs_api_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SRC/SGS_CLUBB/clubb_sgs.F90" ], "commitId" : "a5246bded5cc0663b22915390a12a390b1c47c67", "timestamp" : 1654889200000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Adding column index to gr arrays, hard coding to 1 since sam only uses single column calls.\u000a", "date" : "2022-06-10 14:26:40 -0500", "id" : "a5246bded5cc0663b22915390a12a390b1c47c67", "msg" : "Adding column index to gr arrays, hard coding to 1 since sam only uses single column calls.", "paths" : [ { "editType" : "edit", "file" : "SRC/SGS_CLUBB/clubb_sgs.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "clubb_api_module.F90" ], "commitId" : "b283dcad1f9b9a9c6574f5c7466bd8125a80a917", "timestamp" : 1654901042000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Removing the zt2zm interface from clubb_api and making the api calls just redirect to the grid class interface for it.\u000a", "date" : "2022-06-10 17:44:02 -0500", "id" : "b283dcad1f9b9a9c6574f5c7466bd8125a80a917", "msg" : "Removing the zt2zm interface from clubb_api and making the api calls just redirect to the grid class interface for it.", "paths" : [ { "editType" : "edit", "file" : "clubb_api_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_wp2_wp3_module.F90", "advance_xp2_xpyp_module.F90", "advance_windm_edsclrm_module.F90", "advance_xm_wpxp_module.F90", "mean_adv.F90", "mono_flux_limiter.F90" ], "commitId" : "64ef912040e0e808923bb5c9354e39c0d4ddbe87", "timestamp" : 1654901042000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Pushing column loop into mean advection procedures.\u000a", "date" : "2022-06-10 17:44:02 -0500", "id" : "64ef912040e0e808923bb5c9354e39c0d4ddbe87", "msg" : "Pushing column loop into mean advection procedures.", "paths" : [ { "editType" : "edit", "file" : "mean_adv.F90" }, { "editType" : "edit", "file" : "advance_windm_edsclrm_module.F90" }, { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" }, { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" }, { "editType" : "edit", "file" : "mono_flux_limiter.F90" }, { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_xm_wpxp_module.F90" ], "commitId" : "76b6a7abbb040eb49f24eb5129dd3967bc34470d", "timestamp" : 1654904676000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Little loop push\u000a", "date" : "2022-06-10 18:44:36 -0500", "id" : "76b6a7abbb040eb49f24eb5129dd3967bc34470d", "msg" : "Little loop push", "paths" : [ { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_wp2_wp3_module.F90", "grid_class.F90", "turbulent_adv_pdf.F90", "mono_flux_limiter.F90", "mean_adv.F90" ], "commitId" : "dd7ed27deff26acabf5edfe1932224e64ae68f5e", "timestamp" : 1654904676000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Moving above/below index of grid weights to last dimension.\u000a", "date" : "2022-06-10 18:44:36 -0500", "id" : "dd7ed27deff26acabf5edfe1932224e64ae68f5e", "msg" : "Moving above/below index of grid weights to last dimension.", "paths" : [ { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" }, { "editType" : "edit", "file" : "turbulent_adv_pdf.F90" }, { "editType" : "edit", "file" : "grid_class.F90" }, { "editType" : "edit", "file" : "mono_flux_limiter.F90" }, { "editType" : "edit", "file" : "mean_adv.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SRC/micro_field_utils.F90", "SRC/MICRO_M2005_UWM/microphysics.F90", "SRC/SGS_CLUBB/sgs.F90", "SRC/SGS_CLUBB/stat_clubb.F90", "SRC/SGS_CLUBB/clubb_sgs.F90" ], "commitId" : "2813c59e885fa41ced8cbb7d9fe47eabd62d61d8", "timestamp" : 1655142566000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Hardcoding 1 into uses of gr arrays where single column versions of gr is used.\u000a", "date" : "2022-06-13 12:49:26 -0500", "id" : "2813c59e885fa41ced8cbb7d9fe47eabd62d61d8", "msg" : "Hardcoding 1 into uses of gr arrays where single column versions of gr is used.", "paths" : [ { "editType" : "edit", "file" : "SRC/micro_field_utils.F90" }, { "editType" : "edit", "file" : "SRC/SGS_CLUBB/clubb_sgs.F90" }, { "editType" : "edit", "file" : "SRC/SGS_CLUBB/sgs.F90" }, { "editType" : "edit", "file" : "SRC/MICRO_M2005_UWM/microphysics.F90" }, { "editType" : "edit", "file" : "SRC/SGS_CLUBB/stat_clubb.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "fill_holes.F90", "advance_wp2_wp3_module.F90", "advance_xp2_xpyp_module.F90", "advance_clubb_core_module.F90", "clubb_api_module.F90", "advance_xm_wpxp_module.F90" ], "commitId" : "61e346b94dc205f46ddb43e037f2758a535a20b3", "timestamp" : 1655335624000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Pushing loop into fill_holes.\u000a", "date" : "2022-06-15 18:27:04 -0500", "id" : "61e346b94dc205f46ddb43e037f2758a535a20b3", "msg" : "Pushing loop into fill_holes.", "paths" : [ { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" }, { "editType" : "edit", "file" : "fill_holes.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" }, { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" }, { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_xm_wpxp_module.F90" ], "commitId" : "77f12fcb41f06c9a95378a54bbae8889d032deb2", "timestamp" : 1655335624000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Forgot small change.\u000a", "date" : "2022-06-15 18:27:04 -0500", "id" : "77f12fcb41f06c9a95378a54bbae8889d032deb2", "msg" : "Forgot small change.", "paths" : [ { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SRC/micro_field_utils.F90", "SRC/MICRO_M2005_UWM/microphysics.F90", "SRC/SGS_CLUBB/clubb_sgs.F90" ], "commitId" : "27148d170d4f0c61c1aac3756f86bc63294b71ed", "timestamp" : 1655335675000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Making compatible with latest clubb change.\u000a", "date" : "2022-06-15 18:27:55 -0500", "id" : "27148d170d4f0c61c1aac3756f86bc63294b71ed", "msg" : "Making compatible with latest clubb change.", "paths" : [ { "editType" : "edit", "file" : "SRC/micro_field_utils.F90" }, { "editType" : "edit", "file" : "SRC/MICRO_M2005_UWM/microphysics.F90" }, { "editType" : "edit", "file" : "SRC/SGS_CLUBB/clubb_sgs.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "grid_class.F90" ], "commitId" : "add842c9f5797774559dce57ce5f51a506523344", "timestamp" : 1655492801000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Making linear_interpolated_azt_2D and linear_interpolated_azm_2D subroutines just to avoid a needless data copy.\u000a", "date" : "2022-06-17 14:06:41 -0500", "id" : "add842c9f5797774559dce57ce5f51a506523344", "msg" : "Making linear_interpolated_azt_2D and linear_interpolated_azm_2D subroutines just to avoid a needless data copy.", "paths" : [ { "editType" : "edit", "file" : "grid_class.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_xp2_xpyp_module.F90", "clubb_api_module.F90" ], "commitId" : "dc9e57ed7bdf35c97640ff0ddc87e39a6a51897b", "timestamp" : 1655492801000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Making update_xp2_mc 2D and creating interface for 1D calls.\u000a", "date" : "2022-06-17 14:06:41 -0500", "id" : "dc9e57ed7bdf35c97640ff0ddc87e39a6a51897b", "msg" : "Making update_xp2_mc 2D and creating interface for 1D calls.", "paths" : [ { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "stats_zt_module.F90" ], "commitId" : "ed460b8da54ec8c8672698204b962b1f2c0bba76", "timestamp" : 1655835945000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Fixing units in stats_zt_module.F90\u000a\u000aThis change will be BIT_CHANGING because it will affect the descriptions of variables in the netcdf files, but will not change answers.\u000a", "date" : "2022-06-21 12:25:45 -0600", "id" : "ed460b8da54ec8c8672698204b962b1f2c0bba76", "msg" : "Fixing units in stats_zt_module.F90", "paths" : [ { "editType" : "edit", "file" : "stats_zt_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "stats_variables.F90", "stats_zm_module.F90", "mono_flux_limiter.F90" ], "commitId" : "8d3e4542fb9b0c14babe8621eca51648539827a8", "timestamp" : 1658265385000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Fixing a bug in mono_flux_limiter.F90. (#1026)\u000a\u000a* Fixing a bug in mono_flux_limiter.F90. This code was outputting \"xm\" instead of \"wpxp\" in several places.\u000a\u000aThis commit is BIT_CHANGING since it will affect the netcdf output for these variables, even though there\u000ais no real change to answers.\u000a\u000a* Renaming wpthlp_entermfl to wpthlp_enter_mfl which is more consistent with other variable names.\u000a\u000aThis is BIT_CHANGING due to changing the name and description in the output netcdf files.\u000a\u000a* Renaming a few more instances of wpthlp_entermfl to wpthlp_enter_mfl.\u000a", "date" : "2022-07-19 15:16:25 -0600", "id" : "8d3e4542fb9b0c14babe8621eca51648539827a8", "msg" : "Fixing a bug in mono_flux_limiter.F90. (#1026)", "paths" : [ { "editType" : "edit", "file" : "mono_flux_limiter.F90" }, { "editType" : "edit", "file" : "stats_variables.F90" }, { "editType" : "edit", "file" : "stats_zm_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "pdf_closure_module.F90" ], "commitId" : "fde756aa71b25daf7c103c445b2d6fc018df057b", "timestamp" : 1658271937000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "Fixing a bug.\u000a", "date" : "2022-07-19 18:05:37 -0500", "id" : "fde756aa71b25daf7c103c445b2d6fc018df057b", "msg" : "Fixing a bug.", "paths" : [ { "editType" : "edit", "file" : "pdf_closure_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90", "pdf_closure_module.F90", "clubb_api_module.F90" ], "commitId" : "9434be0736f63802f57dc200dad4c6eae62f68be", "timestamp" : 1660590191000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "I changed the w_up_in_cloud code in 2 ways:\u000a\u000a1) The denominator term is now the \"cloudy updraft\" frac in each\u000aPDF component, rather than just the PDF component cloud_frac. This\u000ais more consistent with the quantity being integrated.\u000a\u000a2) I also added a w_down_in_cloud for cloudy downdraft velocity.\u000a\u000aSince these fields are not output as part of standard stats, this\u000acommit will be bit-for-bit for the normal CLUBB output files.\u000a", "date" : "2022-08-15 14:03:11 -0500", "id" : "9434be0736f63802f57dc200dad4c6eae62f68be", "msg" : "I changed the w_up_in_cloud code in 2 ways:", "paths" : [ { "editType" : "edit", "file" : "pdf_closure_module.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "pdf_closure_module.F90", "stats_clubb_utilities.F90", "stats_variables.F90", "advance_clubb_core_module.F90", "stats_zt_module.F90" ], "commitId" : "d0bd6bf033fe043e0218e55cf4059316e0d308e4", "timestamp" : 1660594604000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "I added stats output for w_down_in_cloud to all_stats.in.\u000a\u000aSince this stat was not added to standard_stats.in, official results\u000awill still be bit-for-bit.\u000a", "date" : "2022-08-15 15:16:44 -0500", "id" : "d0bd6bf033fe043e0218e55cf4059316e0d308e4", "msg" : "I added stats output for w_down_in_cloud to all_stats.in.", "paths" : [ { "editType" : "edit", "file" : "stats_clubb_utilities.F90" }, { "editType" : "edit", "file" : "stats_zt_module.F90" }, { "editType" : "edit", "file" : "stats_variables.F90" }, { "editType" : "edit", "file" : "pdf_closure_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SRC/SGS_CLUBB/clubb_sgs.F90" ], "commitId" : "429cdca64b054f2191b7656e76d1aefbe7c8c502", "timestamp" : 1660596766000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "Modified for the latest changes to CLUBB.\u000a", "date" : "2022-08-15 15:52:46 -0500", "id" : "429cdca64b054f2191b7656e76d1aefbe7c8c502", "msg" : "Modified for the latest changes to CLUBB.", "paths" : [ { "editType" : "edit", "file" : "SRC/SGS_CLUBB/clubb_sgs.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "jenkins_tests/sam_micro_drizzle_intel_test/Jenkinsfile" ], "commitId" : "c3df4b35a3ea7f0a68ffd33562ab2df95948546e", "timestamp" : 1660681730000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/cernikt", "fullName" : "cernikt" }, "authorEmail" : "cernikt@msoe.edu", "comment" : "adding line to fix mpi configuration in micro drizzle test\u000a", "date" : "2022-08-16 15:28:50 -0500", "id" : "c3df4b35a3ea7f0a68ffd33562ab2df95948546e", "msg" : "adding line to fix mpi configuration in micro drizzle test", "paths" : [ { "editType" : "edit", "file" : "jenkins_tests/sam_micro_drizzle_intel_test/Jenkinsfile" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "pdf_closure_module.F90" ], "commitId" : "a7de6b09f4f0e09b48f663e2432b3e98b29bfe60", "timestamp" : 1660699106000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "I altered the w_up_in_cloud and w_down_in_cloud code so that a\u000athresholding is used similar to what is seen in the cloud fraction\u000aand cloud water code. If the PDF component mean of w more than\u000athe maximum allow number of standard deviations away from 0, the\u000aPDF component is either all-updrafty or all-downdrafty, and the\u000acode avoids expensive computations where large magnitude values\u000acan potentially be fed into ERF or EXP.\u000a\u000aOf course, the results are not bit-for-bit with the previous version,\u000ameaning that there are some situations where these thresholds come\u000ainto effect. However, plots of all cases show no visible differences\u000ain w_up_in_cloud and w_down_in_cloud.\u000a\u000aSince w_up_in_cloud and w_down_in_cloud are not included in normal\u000astats output, this commit does not change the bit-for-bitness of\u000aCLUBB code.\u000a", "date" : "2022-08-16 20:18:26 -0500", "id" : "a7de6b09f4f0e09b48f663e2432b3e98b29bfe60", "msg" : "I altered the w_up_in_cloud and w_down_in_cloud code so that a", "paths" : [ { "editType" : "edit", "file" : "pdf_closure_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "pdf_closure_module.F90" ], "commitId" : "493cf3aafada57c53b1508b2b5990ce0a7dcafea", "timestamp" : 1660756368000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "I have optimized the new w_up_in_cloud and w_down_in_cloud code by\u000aonly doing repeated operations one time and then saving them as a\u000alocal variable.\u000a\u000aSince the numerical order of operations changes for the argument\u000ato the EXP term, the results will differ at the level of numerical\u000around-off, making this revision not bit-for-bit with the last revision.\u000aThis only affects the w_up_in_cloud and w_down_in_cloud statistical\u000aoutput variables, which in turn are not output as part of\u000astandard_stats.in.\u000a", "date" : "2022-08-17 12:12:48 -0500", "id" : "493cf3aafada57c53b1508b2b5990ce0a7dcafea", "msg" : "I have optimized the new w_up_in_cloud and w_down_in_cloud code by", "paths" : [ { "editType" : "edit", "file" : "pdf_closure_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "fill_holes.F90", "advance_wp2_wp3_module.F90", "advance_xp2_xpyp_module.F90", "advance_clubb_core_module.F90", "clubb_api_module.F90", "advance_xm_wpxp_module.F90" ], "commitId" : "ab4282b0f6e0a3a1e3404836c96121fb79a872d4", "timestamp" : 1661881531000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Refactored fill_holes_vertical to make GPUization simple. This is BIT_CHANGING, but results are bit-for-bit when using -O0 optimization, thus it is not answer changing. The first pass over each grid column will not parallelize well, the k-loop needs to be done in serial. Maximum parallelization has been exposed for the global hole-filling though, at the cost of occasionally doing unneccesary calculations. larson-group/clubb#972.\u000a", "date" : "2022-08-30 12:45:31 -0500", "id" : "ab4282b0f6e0a3a1e3404836c96121fb79a872d4", "msg" : "Refactored fill_holes_vertical to make GPUization simple. This is BIT_CHANGING, but results are bit-for-bit when using -O0 optimization, thus it is not answer changing. The first pass over each grid column will not parallelize well, the k-loop needs to be done in serial. Maximum parallelization has been exposed for the global hole-filling though, at the cost of occasionally doing unneccesary calculations. larson-group/clubb#972.", "paths" : [ { "editType" : "edit", "file" : "clubb_api_module.F90" }, { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" }, { "editType" : "edit", "file" : "fill_holes.F90" }, { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" }, { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "fill_holes.F90", "advance_wp2_wp3_module.F90", "advance_xp2_xpyp_module.F90", "advance_clubb_core_module.F90", "advance_xm_wpxp_module.F90", "constants_clubb.F90" ], "commitId" : "b0eeb2ebed4160829305c9a13bc60818b045fb22", "timestamp" : 1661881531000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Removing fill_holes_multiplicative and replacing magic numbers with parameters from constants_clubb. larson-group/clubb#972\u000a", "date" : "2022-08-30 12:45:31 -0500", "id" : "b0eeb2ebed4160829305c9a13bc60818b045fb22", "msg" : "Removing fill_holes_multiplicative and replacing magic numbers with parameters from constants_clubb. larson-group/clubb#972", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "constants_clubb.F90" }, { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" }, { "editType" : "edit", "file" : "fill_holes.F90" }, { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" }, { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "fill_holes.F90", "stats_clubb_utilities.F90", "advance_clubb_core_module.F90", "clubb_api_module.F90", "mono_flux_limiter.F90", "advance_helper_module.F90" ], "commitId" : "0a21a67e8c0d8373ae4315241b338842259b1d69", "timestamp" : 1661881531000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Moving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972\u000a", "date" : "2022-08-30 12:45:31 -0500", "id" : "0a21a67e8c0d8373ae4315241b338842259b1d69", "msg" : "Moving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972", "paths" : [ { "editType" : "edit", "file" : "mono_flux_limiter.F90" }, { "editType" : "edit", "file" : "stats_clubb_utilities.F90" }, { "editType" : "edit", "file" : "advance_helper_module.F90" }, { "editType" : "edit", "file" : "fill_holes.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "latin_hypercube_driver_module.F90" ], "commitId" : "18677b4114aff3b59943c43e9207fc7a8630060e", "timestamp" : 1661881531000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Moving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972\u000a", "date" : "2022-08-30 12:45:31 -0500", "id" : "18677b4114aff3b59943c43e9207fc7a8630060e", "msg" : "Moving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972", "paths" : [ { "editType" : "edit", "file" : "latin_hypercube_driver_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SRC/MICRO_M2005_UWM/microphysics.F90", "SRC/micro_field_utils.F90", "SRC/SGS_CLUBB/clubb_sgs.F90" ], "commitId" : "b0a22e3ceb0eee4eb4acd9cec7fb987f1c26040d", "timestamp" : 1661970509000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Making compatible with latest clubb change.\u000a", "date" : "2022-08-31 13:28:29 -0500", "id" : "b0a22e3ceb0eee4eb4acd9cec7fb987f1c26040d", "msg" : "Making compatible with latest clubb change.", "paths" : [ { "editType" : "edit", "file" : "SRC/MICRO_M2005_UWM/microphysics.F90" }, { "editType" : "edit", "file" : "SRC/micro_field_utils.F90" }, { "editType" : "edit", "file" : "SRC/SGS_CLUBB/clubb_sgs.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mixing_length.F90", "saturation.F90", "advance_clubb_core_module.F90", "clubb_api_module.F90", "pdf_closure_module.F90", "stats_clubb_utilities.F90", "T_in_K_module.F90", "advance_helper_module.F90" ], "commitId" : "09720448888edc3117ea736bfa140a0c60bd6f04", "timestamp" : 1662512657000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Removing elementalness from sat_vapor_press_liq and making interal procedures subroutines rather than functions to prevent unneccesary data copies. Doing the same for thlm2T_in_K since it is often used in conjunction with sat_vapor_press_liq. Bit-for-bit confirmed with O0 using all single column cases with or without l_diag_Lscale_from_tau, and with cam_coarse_res. larson-group/clubb#972\u000a", "date" : "2022-09-06 20:04:17 -0500", "id" : "09720448888edc3117ea736bfa140a0c60bd6f04", "msg" : "Removing elementalness from sat_vapor_press_liq and making interal procedures subroutines rather than functions to prevent unneccesary data copies. Doing the same for thlm2T_in_K since it is often used in conjunction with sat_vapor_press_liq. Bit-for-bit confirmed with O0 using all single column cases with or without l_diag_Lscale_from_tau, and with cam_coarse_res. larson-group/clubb#972", "paths" : [ { "editType" : "edit", "file" : "pdf_closure_module.F90" }, { "editType" : "edit", "file" : "T_in_K_module.F90" }, { "editType" : "edit", "file" : "stats_clubb_utilities.F90" }, { "editType" : "edit", "file" : "saturation.F90" }, { "editType" : "edit", "file" : "mixing_length.F90" }, { "editType" : "edit", "file" : "advance_helper_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "saturation.F90", "grid_class.F90", "T_in_K_module.F90", "clubb_api_module.F90" ], "commitId" : "a865626a53fb1243fe232896e89537ea0cb47684", "timestamp" : 1662512657000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Adding comments.\u000a", "date" : "2022-09-06 20:04:17 -0500", "id" : "a865626a53fb1243fe232896e89537ea0cb47684", "msg" : "Adding comments.", "paths" : [ { "editType" : "edit", "file" : "T_in_K_module.F90" }, { "editType" : "edit", "file" : "saturation.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" }, { "editType" : "edit", "file" : "grid_class.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "pdf_closure_module.F90" ], "commitId" : "bf79a8d55fe3ca7aacc106b68052a316cc3e359e", "timestamp" : 1662741141000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Adding initial subroutine calc_ice_cloud_frac_component.\u000a", "date" : "2022-09-09 11:32:21 -0500", "id" : "bf79a8d55fe3ca7aacc106b68052a316cc3e359e", "msg" : "Adding initial subroutine calc_ice_cloud_frac_component.", "paths" : [ { "editType" : "edit", "file" : "pdf_closure_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "pdf_closure_module.F90", "saturation.F90", "advance_clubb_core_module.F90", "stats_clubb_utilities.F90" ], "commitId" : "60041d793c8fa3229f278a20ec6bdd9fc468f39f", "timestamp" : 1662741141000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Cleaning up new subroutine calc_liquid_cloud_frac_component, and making sat_mixrat_ice a subroutine that works the same way as sat_mixrat_liq. larson-group/clubb#972\u000a", "date" : "2022-09-09 11:32:21 -0500", "id" : "60041d793c8fa3229f278a20ec6bdd9fc468f39f", "msg" : "Cleaning up new subroutine calc_liquid_cloud_frac_component, and making sat_mixrat_ice a subroutine that works the same way as sat_mixrat_liq. larson-group/clubb#972", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "stats_clubb_utilities.F90" }, { "editType" : "edit", "file" : "saturation.F90" }, { "editType" : "edit", "file" : "pdf_closure_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "pdf_closure_module.F90" ], "commitId" : "448112afd8d8a22416f31cdb5ae6ec00a5558d0e", "timestamp" : 1662741141000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Comment update\u000a", "date" : "2022-09-09 11:32:21 -0500", "id" : "448112afd8d8a22416f31cdb5ae6ec00a5558d0e", "msg" : "Comment update", "paths" : [ { "editType" : "edit", "file" : "pdf_closure_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "saturation.F90" ], "commitId" : "f2673f56e2eb850b910f74fa7f50ed589a9aebb3", "timestamp" : 1662741141000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Removing these paratheses is BIT_CHANGING since it modifies the order of operations, but allows for the multiplication and subraction to be done in parallel for complex pipelines.\u000a", "date" : "2022-09-09 11:32:21 -0500", "id" : "f2673f56e2eb850b910f74fa7f50ed589a9aebb3", "msg" : "Removing these paratheses is BIT_CHANGING since it modifies the order of operations, but allows for the multiplication and subraction to be done in parallel for complex pipelines.", "paths" : [ { "editType" : "edit", "file" : "saturation.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "configurable_model_flags.in" ], "commitId" : "b480b13af511769f302c830635ad3f8c915ee90b", "timestamp" : 1664988430000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Improvements. Netcdf output is now functional and we can detect errors with multiple columns even when the standard output is identical.\u000a", "date" : "2022-10-05 11:47:10 -0500", "id" : "b480b13af511769f302c830635ad3f8c915ee90b", "msg" : "Improvements. Netcdf output is now functional and we can detect errors with multiple columns even when the standard output is identical.", "paths" : [ { "editType" : "edit", "file" : "configurable_model_flags.in" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "configurable_model_flags.in" ], "commitId" : "88c58d4e28a3bc4094b7951c216637cac85846aa", "timestamp" : 1664988430000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Updating column num input in config flags. larson-group/clubb#1033\u000a", "date" : "2022-10-05 11:47:10 -0500", "id" : "88c58d4e28a3bc4094b7951c216637cac85846aa", "msg" : "Updating column num input in config flags. larson-group/clubb#1033", "paths" : [ { "editType" : "edit", "file" : "configurable_model_flags.in" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "configurable_model_flags.in" ], "commitId" : "82413778356ea633e6af15192b30673e29973261", "timestamp" : 1664988430000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Adding comments, setting to num_standalone_columns=1 by default, and preventing multicolumn output when l_stats=false. larson-group/clubb#1033\u000a", "date" : "2022-10-05 11:47:10 -0500", "id" : "82413778356ea633e6af15192b30673e29973261", "msg" : "Adding comments, setting to num_standalone_columns=1 by default, and preventing multicolumn output when l_stats=false. larson-group/clubb#1033", "paths" : [ { "editType" : "edit", "file" : "configurable_model_flags.in" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "output_netcdf.F90" ], "commitId" : "fb2e67620ac50c35b5cf20cb5e18a1a96d504a86", "timestamp" : 1664988430000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Improvements. Netcdf output is now functional and we can detect errors with multiple columns even when the standard output is identical.\u000a", "date" : "2022-10-05 11:47:10 -0500", "id" : "fb2e67620ac50c35b5cf20cb5e18a1a96d504a86", "msg" : "Improvements. Netcdf output is now functional and we can detect errors with multiple columns even when the standard output is identical.", "paths" : [ { "editType" : "edit", "file" : "output_netcdf.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "configurable_model_flags.in" ], "commitId" : "b3d012fd57fce4fdfdba880ae6842e9b039143ee", "timestamp" : 1665074836000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Namelists need to be closed with a '/', and omitting it will break many tests.\u000a", "date" : "2022-10-06 11:47:16 -0500", "id" : "b3d012fd57fce4fdfdba880ae6842e9b039143ee", "msg" : "Namelists need to be closed with a '/', and omitting it will break many tests.", "paths" : [ { "editType" : "edit", "file" : "configurable_model_flags.in" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "configurable_model_flags.in" ], "commitId" : "d1147f62ff1c5ba047a6a5be4714968f253f2683", "timestamp" : 1665088226000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Making save variables in the multicol code threadprivate, this fixes the openmp test. Also changing the way we name and save the multicol output, this allows the parallel run to run with multiple columns. I've reflected the changes in comments where relevant. larson-group/clubb#1033\u000a", "date" : "2022-10-06 15:30:26 -0500", "id" : "d1147f62ff1c5ba047a6a5be4714968f253f2683", "msg" : "Making save variables in the multicol code threadprivate, this fixes the openmp test. Also changing the way we name and save the multicol output, this allows the parallel run to run with multiple columns. I've reflected the changes in comments where relevant. larson-group/clubb#1033", "paths" : [ { "editType" : "edit", "file" : "configurable_model_flags.in" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_xm_wpxp_module.F90" ], "commitId" : "7e894655b82f891a5b60ba4e0e6670ff3c0fa5b0", "timestamp" : 1665426176000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Adds commented-out line that prevents the monotonic flux\u000a\u000alimiter from acting on rtm. The comments are included to remind us of how to do this in case we choose to do so in the future.\u000a", "date" : "2022-10-10 13:22:56 -0500", "id" : "7e894655b82f891a5b60ba4e0e6670ff3c0fa5b0", "msg" : "Adds commented-out line that prevents the monotonic flux", "paths" : [ { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mono_flux_limiter.F90" ], "commitId" : "4ba46bf534c3ed32f9227282f94b102f7006918e", "timestamp" : 1665672953000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Updating monotonic flux limiter code to remove spikes. (#1038)\u000a\u000aAlso putting a commented out code change in advance_xm_wpxp,\u000ain case shutting of the flux limiter entirely for rtm is preferred.\u000a\u000aSee https://github.com/NCAR/amwg_dev/discussions/134 for discussion.\u000a\u000aThis commit will be BIT_CHANGING although the differences are only\u000aobvious in sensitive cases like arm_97.\u000a", "date" : "2022-10-13 08:55:53 -0600", "id" : "4ba46bf534c3ed32f9227282f94b102f7006918e", "msg" : "Updating monotonic flux limiter code to remove spikes. (#1038)", "paths" : [ { "editType" : "edit", "file" : "mono_flux_limiter.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90", "model_flags.F90", "advance_xm_wpxp_module.F90", "clubb_api_module.F90", "mono_flux_limiter.F90" ], "commitId" : "f30bf0d926336356fdb094f944cfb1174a1ec225", "timestamp" : 1665761524000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Creating new flags to control monotonic flux limiter (#1039)\u000a\u000a* Creating new flags to control monotonic flux limiter and the IF statement fix for the spikes found in CAM.\u000a\u000a* Removing no-longer-necessary logical l_mono_flux_lim.\u000a\u000a* Adding requested changes from PR (intent statements and editing error statement).\u000a\u000a* Accidentally set flag to false. Changing to true.\u000a", "date" : "2022-10-14 09:32:04 -0600", "id" : "f30bf0d926336356fdb094f944cfb1174a1ec225", "msg" : "Creating new flags to control monotonic flux limiter (#1039)", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "mono_flux_limiter.F90" }, { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" }, { "editType" : "edit", "file" : "model_flags.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "configurable_model_flags.in" ], "commitId" : "f508c31512366c87e72e70ee26ba6d5e99869d18", "timestamp" : 1665761524000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Creating new flags to control monotonic flux limiter (#1039)\u000a\u000a* Creating new flags to control monotonic flux limiter and the IF statement fix for the spikes found in CAM.\u000a\u000a* Removing no-longer-necessary logical l_mono_flux_lim.\u000a\u000a* Adding requested changes from PR (intent statements and editing error statement).\u000a\u000a* Accidentally set flag to false. Changing to true.\u000a", "date" : "2022-10-14 09:32:04 -0600", "id" : "f508c31512366c87e72e70ee26ba6d5e99869d18", "msg" : "Creating new flags to control monotonic flux limiter (#1039)", "paths" : [ { "editType" : "edit", "file" : "configurable_model_flags.in" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SRC/SGS_CLUBB/clubb_sgs.F90" ], "commitId" : "2c455c0350775d45d36b6ab922e4bbc56664e09e", "timestamp" : 1665761704000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/59519056+bstephens82", "fullName" : "59519056+bstephens82" }, "authorEmail" : "59519056+bstephens82@users.noreply.github.com", "comment" : "Updating for changes to CLUBB. See https://github.com/larson-group/clubb/pull/1039.\u000a", "date" : "2022-10-14 09:35:04 -0600", "id" : "2c455c0350775d45d36b6ab922e4bbc56664e09e", "msg" : "Updating for changes to CLUBB. See https://github.com/larson-group/clubb/pull/1039.", "paths" : [ { "editType" : "edit", "file" : "SRC/SGS_CLUBB/clubb_sgs.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "pdf_closure_module.F90", "stats_clubb_utilities.F90", "stats_variables.F90", "advance_clubb_core_module.F90", "clubb_api_module.F90", "stats_zt_module.F90" ], "commitId" : "3bdab2ca5a22a425da62f8cae4c8e01097f44fa8", "timestamp" : 1665787786000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "I am adding cloudy_updraft_frac and cloudy_downdraft_frac as\u000aoutputs to the calculate_w_up_in_cloud code.\u000a\u000aThese fields are non-interactive for the standard set of cases.\u000aThus, all cases are bit-for-bit identical.\u000a\u000aHowever, for the w_up_in_cloud and w_down_in_cloud results themselves,\u000ait is possible that results might not be bit-for-bit since\u000athe location of the max(eps, ...) clipping in the denominator\u000ais changed. However, results should not be appreciable different.\u000a", "date" : "2022-10-14 17:49:46 -0500", "id" : "3bdab2ca5a22a425da62f8cae4c8e01097f44fa8", "msg" : "I am adding cloudy_updraft_frac and cloudy_downdraft_frac as", "paths" : [ { "editType" : "edit", "file" : "stats_clubb_utilities.F90" }, { "editType" : "edit", "file" : "pdf_closure_module.F90" }, { "editType" : "edit", "file" : "stats_variables.F90" }, { "editType" : "edit", "file" : "stats_zt_module.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SRC/SGS_CLUBB/clubb_sgs.F90" ], "commitId" : "e8059d328d577d6e12021e8fbf6cc081b91e6eb8", "timestamp" : 1665790851000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "Updating SAM-CLUBB for the latest changes to the call to\u000aadvance_clubb_core_api.\u000a", "date" : "2022-10-14 18:40:51 -0500", "id" : "e8059d328d577d6e12021e8fbf6cc081b91e6eb8", "msg" : "Updating SAM-CLUBB for the latest changes to the call to", "paths" : [ { "editType" : "edit", "file" : "SRC/SGS_CLUBB/clubb_sgs.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mono_flux_limiter.F90" ], "commitId" : "200706b307be40ceb42f6121bd0f7d1be2b116c6", "timestamp" : 1667919348000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Minor adjustment to eliminate spikes in thlm tendencies from the monotonic flux limiter. (#1043)\u000a\u000aSee https://github.com/NCAR/amwg_dev/discussions/134.\u000a\u000aThis commit will be BIT_CHANGING. Differences are mainly noticeable in the more sensitive cases.\u000a", "date" : "2022-11-08 07:55:48 -0700", "id" : "200706b307be40ceb42f6121bd0f7d1be2b116c6", "msg" : "Minor adjustment to eliminate spikes in thlm tendencies from the monotonic flux limiter. (#1043)", "paths" : [ { "editType" : "edit", "file" : "mono_flux_limiter.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_wp2_wp3_module.F90", "advance_xp2_xpyp_module.F90", "advance_xm_wpxp_module.F90", "lapack_wrap.F90", "penta_lu_solver.F90", "matrix_solver_wrapper.F90", "advance_windm_edsclrm_module.F90", "mono_flux_limiter.F90" ], "commitId" : "952c923222bf8901dc9b388f286872a73e6c609d", "timestamp" : 1668629680000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Making interface for matrix solvers.\u000a", "date" : "2022-11-16 14:14:40 -0600", "id" : "952c923222bf8901dc9b388f286872a73e6c609d", "msg" : "Making interface for matrix solvers.", "paths" : [ { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" }, { "editType" : "edit", "file" : "lapack_wrap.F90" }, { "editType" : "edit", "file" : "advance_windm_edsclrm_module.F90" }, { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" }, { "editType" : "add", "file" : "penta_lu_solver.F90" }, { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" }, { "editType" : "add", "file" : "matrix_solver_wrapper.F90" }, { "editType" : "edit", "file" : "mono_flux_limiter.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "penta_lu_solver.F90", "matrix_solver_wrapper.F90", "advance_xm_wpxp_module.F90", "lapack_wrap.F90" ], "commitId" : "6d88c22f60109415cdedeafb87ef6ab88ca1b07e", "timestamp" : 1668629680000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Making tridag tridiag everywhere, making sol soln, and adding intent comments.\u000a", "date" : "2022-11-16 14:14:40 -0600", "id" : "6d88c22f60109415cdedeafb87ef6ab88ca1b07e", "msg" : "Making tridag tridiag everywhere, making sol soln, and adding intent comments.", "paths" : [ { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" }, { "editType" : "edit", "file" : "lapack_wrap.F90" }, { "editType" : "edit", "file" : "matrix_solver_wrapper.F90" }, { "editType" : "edit", "file" : "penta_lu_solver.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "constants_clubb.F90", "mono_flux_limiter.F90" ], "commitId" : "5baacd72ae885dceeb8a535b8d190c8be73a6931", "timestamp" : 1669057917000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "A different way of dealing with monotonic flux limiter spikes (#1046)\u000a\u000a* A different way of dealing with monotonic flux limiter spikes in CAM, by increasing the value\u000aof thl_tol_mfl. ALso reverts the earlier fix. BIT_CHANGING.\u000a\u000aSee https://github.com/NCAR/amwg_dev/discussions/134#discussioncomment-4165447.\u000a\u000a* Reducing value of thl_tol_mfl from 0.5 to 0.2.\u000a\u000aThis will be BIT_CHANGING.\u000a", "date" : "2022-11-21 12:11:57 -0700", "id" : "5baacd72ae885dceeb8a535b8d190c8be73a6931", "msg" : "A different way of dealing with monotonic flux limiter spikes (#1046)", "paths" : [ { "editType" : "edit", "file" : "constants_clubb.F90" }, { "editType" : "edit", "file" : "mono_flux_limiter.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_wp2_wp3_module.F90", "advance_clubb_core_module.F90", "numerical_check.F90", "constants_clubb.F90", "pdf_closure_module.F90", "grid_class.F90", "sfc_varnce_module.F90" ], "commitId" : "269513ec0b95ddee2bff960d0c74a4ceccb8feef", "timestamp" : 1669128959000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Steffens tuner fixer branch (#1041)\u000a\u000a* Clubb ticket #1025: Implemented changes dealing with pdf_params%thl1/2 and wp2 floating point errors occurring in tuning runs. BIT_CHANGING\u000a- Added command-line option -t/--tuner to compile.bash which enables the -DTUNER compiler flag.\u000a- Added line to gfortran compilation config file to easily disable openMP\u000a- Added a couple error messages and cleaned up some instances of error handling in src/error.F90, src/clubb_driver.F90, and src/CLUBB_core/advance_clubb_core_module.F90\u000a- Added global constant wp2_max in src/CLUBB_core/constants_clubb.F90 which sets the upper bound for wp2\u000a- In pdf_closure, added sanity checks for pdf_params%thl1/2 (>=190K, <=1000K)\u000a- Added debug warning in src/CLUBB_core/advance_wp2_wp3_module.F90 when wp2 is clipped.\u000a- Added wp2_sfc clipping in src/CLUBB_core/sfc_varnce_module.F90\u000a- Added debug_level_check to NaN check in clubb_driver.F90\u000a- Added mention of the new compiler option to the README\u000a", "date" : "2022-11-22 08:55:59 -0600", "id" : "269513ec0b95ddee2bff960d0c74a4ceccb8feef", "msg" : "Steffens tuner fixer branch (#1041)", "paths" : [ { "editType" : "edit", "file" : "numerical_check.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "constants_clubb.F90" }, { "editType" : "edit", "file" : "grid_class.F90" }, { "editType" : "edit", "file" : "sfc_varnce_module.F90" }, { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" }, { "editType" : "edit", "file" : "pdf_closure_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SRC/SGS_CLUBB/clubb_sgs.F90" ], "commitId" : "ece810498e8b5d2d7ad8157b3c7b973b50c4ff69", "timestamp" : 1669261351000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Making compatible with latest clubb changes.\u000a", "date" : "2022-11-23 21:42:31 -0600", "id" : "ece810498e8b5d2d7ad8157b3c7b973b50c4ff69", "msg" : "Making compatible with latest clubb changes.", "paths" : [ { "editType" : "edit", "file" : "SRC/SGS_CLUBB/clubb_sgs.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_wp2_wp3_module.F90", "advance_xp2_xpyp_module.F90", "advance_clubb_core_module.F90", "model_flags.F90", "clubb_api_module.F90", "advance_xm_wpxp_module.F90", "matrix_solver_wrapper.F90", "advance_windm_edsclrm_module.F90", "mono_flux_limiter.F90" ], "commitId" : "127883ca8f0dce455123056d72efb0cdef4794ca", "timestamp" : 1669261456000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Adding capability to change matrix solving method via clubb_config_flags.\u000a", "date" : "2022-11-23 21:44:16 -0600", "id" : "127883ca8f0dce455123056d72efb0cdef4794ca", "msg" : "Adding capability to change matrix solving method via clubb_config_flags.", "paths" : [ { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" }, { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" }, { "editType" : "edit", "file" : "advance_windm_edsclrm_module.F90" }, { "editType" : "edit", "file" : "model_flags.F90" }, { "editType" : "edit", "file" : "mono_flux_limiter.F90" }, { "editType" : "edit", "file" : "matrix_solver_wrapper.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "matrix_solver_wrapper.F90" ], "commitId" : "d8493869b48641432cac85c681884b5d5bf203a6", "timestamp" : 1669261456000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Fixing small bug, need to pass _copy arrays to prevent lapack mangling the real ones.\u000a", "date" : "2022-11-23 21:44:16 -0600", "id" : "d8493869b48641432cac85c681884b5d5bf203a6", "msg" : "Fixing small bug, need to pass _copy arrays to prevent lapack mangling the real ones.", "paths" : [ { "editType" : "edit", "file" : "matrix_solver_wrapper.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "configurable_model_flags.in" ], "commitId" : "dfe3de1dce4262b2b40a10da8d6f76de1feb3d88", "timestamp" : 1669261456000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Adding capability to change matrix solving method via clubb_config_flags.\u000a", "date" : "2022-11-23 21:44:16 -0600", "id" : "dfe3de1dce4262b2b40a10da8d6f76de1feb3d88", "msg" : "Adding capability to change matrix solving method via clubb_config_flags.", "paths" : [ { "editType" : "edit", "file" : "configurable_model_flags.in" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "penta_lu_solver.F90" ], "commitId" : "4588198937b2b4dcc148fc980125b5ea87fa3354", "timestamp" : 1669261456000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Making GPU and CPU versions of the penta_lu solver the same as discussed in larson-group/clubb#1024.\u000a", "date" : "2022-11-23 21:44:16 -0600", "id" : "4588198937b2b4dcc148fc980125b5ea87fa3354", "msg" : "Making GPU and CPU versions of the penta_lu solver the same as discussed in larson-group/clubb#1024.", "paths" : [ { "editType" : "edit", "file" : "penta_lu_solver.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "configurable_model_flags.in" ], "commitId" : "9e641b5d2bbeb4f1e6b070989ca087a65367101f", "timestamp" : 1669328447000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Replacing $ with & in namelist definition to make consistent.\u000a", "date" : "2022-11-24 16:20:47 -0600", "id" : "9e641b5d2bbeb4f1e6b070989ca087a65367101f", "msg" : "Replacing $ with & in namelist definition to make consistent.", "paths" : [ { "editType" : "edit", "file" : "configurable_model_flags.in" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mixing_length.F90" ], "commitId" : "65b7c1dd0001b0cb328a3b61ffa72e228b14c91c", "timestamp" : 1669684430000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "I added \"smooth\" max clipping for invrs_tau_shear, which is a variable\u000athat is supposed to be positive definite, yet was obtaining negative\u000avalues at the model lower boundary owing to linear extension at the\u000aboundaries as part of the linear interpolation call.\u000a\u000aThis change is BIT_CHANGING.\u000a", "date" : "2022-11-28 19:13:50 -0600", "id" : "65b7c1dd0001b0cb328a3b61ffa72e228b14c91c", "msg" : "I added \"smooth\" max clipping for invrs_tau_shear, which is a variable", "paths" : [ { "editType" : "edit", "file" : "mixing_length.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "adg1_adg2_3d_luhar_pdf.F90" ], "commitId" : "ac76c76a553d2c52a3156258c0afe41f66bea786", "timestamp" : 1670362528000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "ADG1_pdf_driver subroutine port with OpenACC\u000a\u000aAdded OpenACC related flags in linux_x86_64_nvhpc_casper.bash\u000aYou can enable/disable OpenACC compilation using OPENACC=true/false.\u000aAdded OpenACC directives in ADG1_pdf_driver subroutine.\u000a", "date" : "2022-12-06 15:35:28 -0600", "id" : "ac76c76a553d2c52a3156258c0afe41f66bea786", "msg" : "ADG1_pdf_driver subroutine port with OpenACC", "paths" : [ { "editType" : "edit", "file" : "adg1_adg2_3d_luhar_pdf.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "adg1_adg2_3d_luhar_pdf.F90" ], "commitId" : "512e68baec75eb6f5abc36582d6407fb9dceb189", "timestamp" : 1670362528000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Replacing old elemental ADG1_w_closure with new GPUized one. Making G_unit tests work with new version. Also making mixt_frac_max_mag a scalar since it was only being used as such. larson-group/clubb#1049\u000a", "date" : "2022-12-06 15:35:28 -0600", "id" : "512e68baec75eb6f5abc36582d6407fb9dceb189", "msg" : "Replacing old elemental ADG1_w_closure with new GPUized one. Making G_unit tests work with new version. Also making mixt_frac_max_mag a scalar since it was only being used as such. larson-group/clubb#1049", "paths" : [ { "editType" : "edit", "file" : "adg1_adg2_3d_luhar_pdf.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "parameters_tunable.F90" ], "commitId" : "936783d00f3c1e950c0092e31b019249b16042f7", "timestamp" : 1670635449000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "I can now safely remove all the \"ifdef E3SM\" statements from CLUBB's\u000aparameters_tunable.F90. This code is now located in the clubb_intr.F90\u000aportion of E3SM.\u000a", "date" : "2022-12-09 19:24:09 -0600", "id" : "936783d00f3c1e950c0092e31b019249b16042f7", "msg" : "I can now safely remove all the \"ifdef E3SM\" statements from CLUBB's", "paths" : [ { "editType" : "edit", "file" : "parameters_tunable.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "matrix_solver_wrapper.F90", "lapack_wrap.F90" ], "commitId" : "38f9da3d580e38623856fb89bf73e274c5207f79", "timestamp" : 1673472578000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Pushing column loop into lapack wrap.\u000a", "date" : "2023-01-11 15:29:38 -0600", "id" : "38f9da3d580e38623856fb89bf73e274c5207f79", "msg" : "Pushing column loop into lapack wrap.", "paths" : [ { "editType" : "edit", "file" : "matrix_solver_wrapper.F90" }, { "editType" : "edit", "file" : "lapack_wrap.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mixing_length.F90", "saturation.F90", "model_flags.F90", "constants_clubb.F90" ], "commitId" : "21426fea400c37cfd10dbde5beb0f96690a2f838", "timestamp" : 1673549655000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Restructuring and Porting of Compute_mixing_length subroutine(Phase 1) (#1052)\u000a\u000a* Restructuring and Porting of Compute_mixing_length subroutine(Phase 1)\u000a\u000aRestructure: The compute_mixing_length is one of the top most routine taking 35-50%\u000aof the total time in a single timestep. The subroutine has been restructured to\u000apush the i-loop further down to extract vectorization and parallelization.\u000aThe restructuring also involves introduction of sat_mixrat_liq_acc routines to\u000aextract parallelism when called inside a OpenACC parallel region.\u000a\u000aPorting: OpenACC directives are inserted to port the restructured compute_mixing_length\u000acode on to the GPUs. This port is currently unoptimized and there is still room for improvement.\u000a\u000aNOTE: Currently, l_sat_mixrat_lookup = false and saturation_formula = saturation_flatau\u000a(Earthworks config options) case is supported on OpenACC build. Any other options works\u000aon CPUs as usual. OpenACC declare create directives are inserted in model_flags and\u000aconstants_clubb, as these module variables are used inside the saturation routines.\u000a\u000a* Added debug message about only supporting\u000al_sat_mixrat_lookup = false and saturation_formula = saturation_flatau\u000a on GPUs\u000aAnswers are Bit for Bit with arm-multicolumn case + nvhpc compiler.\u000a\u000a* Changing CLUBB debug level 1 to 0 for the saturation formula support\u000arunning on GPUs\u000a\u000a* Changing indentation to make gfortran happy, it wants ifdefs to start at the beginning of the line.\u000a\u000a* Adding use statements for error checks and printouts, also making the errors set err_code to clubb_fatal_error.\u000a\u000aCo-authored-by: huebler \u000a", "date" : "2023-01-12 12:54:15 -0600", "id" : "21426fea400c37cfd10dbde5beb0f96690a2f838", "msg" : "Restructuring and Porting of Compute_mixing_length subroutine(Phase 1) (#1052)", "paths" : [ { "editType" : "edit", "file" : "model_flags.F90" }, { "editType" : "edit", "file" : "saturation.F90" }, { "editType" : "edit", "file" : "constants_clubb.F90" }, { "editType" : "edit", "file" : "mixing_length.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mixing_length.F90", "saturation.F90", "advance_clubb_core_module.F90", "model_flags.F90" ], "commitId" : "38b63ff28ea145707d4ee1d9469013ee20b1697b", "timestamp" : 1674081416000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Restructuring and Porting of Compute_mixing_length subroutine(Phase 2) (#1054)\u000a\u000a* Restructuring and Porting of Compute_mixing_length subroutine(Phase 2)\u000a\u000aRestructure: sat_mixrat_liq_2D_acc is being directly called instead of\u000acalling the 1D version inside the column loop. Changing sat_mixrat_liq_2D_acc\u000ato a subroutine from a function and adding output array, start_index as\u000aadditional argument. This is a workaround for passing sub-arrays. The OpenACC\u000adoen't like the sub-arrays being passed and fails the validation.\u000a\u000aPorting: OpenACC directives are added inside sat_mixrat_liq_2D_acc for porting\u000a\u000aValidation: Answers are Bit for Bit with arm-multicolumn case + nvhpc compiler\u000a\u000a* Fix for compilation issues\u000a\u000aIssue 1: Missed out declaring 'start_index' while intergrating the\u000achange\u000a\u000aIssue 2: The use of error_code module and the procedures inside it\u000acauses OpenACC compilation issues when run on the device.\u000a\u000a* Removing the sat_mixrat_liq_acc and sat_mixrat_liq_2D_acc, making the normal sat_mixrat_liq work for all current use cases, and making the other versions of sat_mixrat_liq (bolton,gfdl,lookup) functional with OPENACC.\u000a\u000aCo-authored-by: huebler \u000a", "date" : "2023-01-18 16:36:56 -0600", "id" : "38b63ff28ea145707d4ee1d9469013ee20b1697b", "msg" : "Restructuring and Porting of Compute_mixing_length subroutine(Phase 2) (#1054)", "paths" : [ { "editType" : "edit", "file" : "saturation.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "mixing_length.F90" }, { "editType" : "edit", "file" : "model_flags.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mono_flux_limiter.F90" ], "commitId" : "9f86ec344fcdd14a084c6249520c33815e225c24", "timestamp" : 1674153381000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Breaking up column loop in mono_flux_limiter. This may not be the final form for GPUization, but it's definitely a start, no longer do we have to copy single column variables to multicolumn ones anywhere. (#1051)\u000a\u000a", "date" : "2023-01-19 12:36:21 -0600", "id" : "9f86ec344fcdd14a084c6249520c33815e225c24", "msg" : "Breaking up column loop in mono_flux_limiter. This may not be the final form for GPUization, but it's definitely a start, no longer do we have to copy single column variables to multicolumn ones anywhere. (#1051)", "paths" : [ { "editType" : "edit", "file" : "mono_flux_limiter.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "penta_lu_solver.F90", "model_flags.F90", "matrix_solver_wrapper.F90", "tridiag_lu_solver.F90", "lapack_wrap.F90" ], "commitId" : "a5ae081b3485ebbd6b470a1bf077eaf8ba2a2979", "timestamp" : 1674153404000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Adding tridiag_lu solver (#1056)\u000a\u000a* Adding tridiag_lu solver\u000a\u000a* Changing low to lower in tridiag_lu and penta_lu, also fixing up some spacing.\u000a\u000a* Making variables that represent matrix solutions more consistently named.\u000a", "date" : "2023-01-19 12:36:44 -0600", "id" : "a5ae081b3485ebbd6b470a1bf077eaf8ba2a2979", "msg" : "Adding tridiag_lu solver (#1056)", "paths" : [ { "editType" : "add", "file" : "tridiag_lu_solver.F90" }, { "editType" : "edit", "file" : "model_flags.F90" }, { "editType" : "edit", "file" : "matrix_solver_wrapper.F90" }, { "editType" : "edit", "file" : "lapack_wrap.F90" }, { "editType" : "edit", "file" : "penta_lu_solver.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mixing_length.F90", "adg1_adg2_3d_luhar_pdf.F90" ], "commitId" : "79e3b2b05f93ffc04d514aad915c1a0aaec0f45f", "timestamp" : 1674580201000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/vlarson", "fullName" : "Vince Larson" }, "authorEmail" : "vlarson@users.noreply.github.com", "comment" : "Adding OpenACC data directives for mixing length and adg routines\u000a\u000aOpenACC structured data regions are added to optimize the data transfers\u000abetween CPU and GPU. These data regions will converted to unstrucutred\u000adata region in the later optimization phase.\u000aResults are bit for bit.\u000a", "date" : "2023-01-24 18:10:01 +0100", "id" : "79e3b2b05f93ffc04d514aad915c1a0aaec0f45f", "msg" : "Adding OpenACC data directives for mixing length and adg routines", "paths" : [ { "editType" : "edit", "file" : "mixing_length.F90" }, { "editType" : "edit", "file" : "adg1_adg2_3d_luhar_pdf.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "adg1_adg2_3d_luhar_pdf.F90" ], "commitId" : "466f229f2b977abcc4be9ac96c4ac11b818d1d37", "timestamp" : 1674585724000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Fixing error causing GPU code not to run. Some variables to be copied were labelled as (ngrdcol,nz) when it should be (:ngrdcol,:nz). I've just removed the data length specifiers completely since they are not neccesary in general.\u000a", "date" : "2023-01-24 12:42:04 -0600", "id" : "466f229f2b977abcc4be9ac96c4ac11b818d1d37", "msg" : "Fixing error causing GPU code not to run. Some variables to be copied were labelled as (ngrdcol,nz) when it should be (:ngrdcol,:nz). I've just removed the data length specifiers completely since they are not neccesary in general.", "paths" : [ { "editType" : "edit", "file" : "adg1_adg2_3d_luhar_pdf.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "stats_clubb_utilities.F90", "saturation.F90" ], "commitId" : "e0a9c3de208ee1855d4b94dc8320d95894c1bc6b", "timestamp" : 1674680903000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "GPUizing sat_mixrat_ice_2D.\u000a", "date" : "2023-01-25 15:08:23 -0600", "id" : "e0a9c3de208ee1855d4b94dc8320d95894c1bc6b", "msg" : "GPUizing sat_mixrat_ice_2D.", "paths" : [ { "editType" : "edit", "file" : "stats_clubb_utilities.F90" }, { "editType" : "edit", "file" : "saturation.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90", "calc_pressure.F90" ], "commitId" : "ef8ea9df21e00777179b628e5deaf68842411ecd", "timestamp" : 1675364876000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Pushing column loop into calculate_thvm\u000a", "date" : "2023-02-02 13:07:56 -0600", "id" : "ef8ea9df21e00777179b628e5deaf68842411ecd", "msg" : "Pushing column loop into calculate_thvm", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "calc_pressure.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "calc_pressure.F90" ], "commitId" : "b0a3a8fc353a232b661ebe6fa26c264d59904993", "timestamp" : 1675364876000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Removing update_pressure since it is no longer called anywhere in clubb or host models. The addition of this subroutine was discussed in larson-group/e3sm#6 and the removal of the call to it was discussed in larson-group/clubb#926.\u000a", "date" : "2023-02-02 13:07:56 -0600", "id" : "b0a3a8fc353a232b661ebe6fa26c264d59904993", "msg" : "Removing update_pressure since it is no longer called anywhere in clubb or host models. The addition of this subroutine was discussed in larson-group/e3sm#6 and the removal of the call to it was discussed in larson-group/clubb#926.", "paths" : [ { "editType" : "edit", "file" : "calc_pressure.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "calc_pressure.F90" ], "commitId" : "6f870bb99c6f94145ebef421ea0435ac083e84f1", "timestamp" : 1675552920000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Removing update_pressure from public list. This was causing compilation crashes. RESOLVED:8c7230fecb877d04fb129ef5e143e0993b4b29b1\u000a", "date" : "2023-02-04 17:22:00 -0600", "id" : "6f870bb99c6f94145ebef421ea0435ac083e84f1", "msg" : "Removing update_pressure from public list. This was causing compilation crashes. RESOLVED:8c7230fecb877d04fb129ef5e143e0993b4b29b1", "paths" : [ { "editType" : "edit", "file" : "calc_pressure.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "saturation.F90", "grid_class.F90", "turbulent_adv_pdf.F90", "mean_adv.F90" ], "commitId" : "4ed2ca7249d959da9e95b40faf2475fb3322f174", "timestamp" : 1675791268000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "GPUizing some helping procedures.\u000a", "date" : "2023-02-07 11:34:28 -0600", "id" : "4ed2ca7249d959da9e95b40faf2475fb3322f174", "msg" : "GPUizing some helping procedures.", "paths" : [ { "editType" : "edit", "file" : "grid_class.F90" }, { "editType" : "edit", "file" : "turbulent_adv_pdf.F90" }, { "editType" : "edit", "file" : "saturation.F90" }, { "editType" : "edit", "file" : "mean_adv.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "adg1_adg2_3d_luhar_pdf.F90" ], "commitId" : "5543d4fdcd60911bcef0658fc693b9ddc50a0e4a", "timestamp" : 1675791268000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Removing sigma_sqd_w from the acc data copyout statement. This is a bug which was causing the code to crash when not using managed memory.\u000a", "date" : "2023-02-07 11:34:28 -0600", "id" : "5543d4fdcd60911bcef0658fc693b9ddc50a0e4a", "msg" : "Removing sigma_sqd_w from the acc data copyout statement. This is a bug which was causing the code to crash when not using managed memory.", "paths" : [ { "editType" : "edit", "file" : "adg1_adg2_3d_luhar_pdf.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "pdf_utilities.F90", "pdf_closure_module.F90" ], "commitId" : "02732556bd0ed380f305bb59f5e421e5a4c615a8", "timestamp" : 1675902842000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Porting pdf_closure subroutine with OpenACC (#1059)\u000a\u000a* Porting pdf_closure subroutine with OpenACC\u000a\u000aOpenACC directives are added to pdf_closure subroutine. The necessary\u000astructured data region is also added for optimzing data movement across\u000akernels. There is opportunity to task parallelize using streams and\u000awill be explored in the future.\u000a\u000aAnswers are bit for bit.\u000a\u000a* Fixing the copyin directives\u000a\u000a* Making work without managed memory.\u000a", "date" : "2023-02-08 18:34:02 -0600", "id" : "02732556bd0ed380f305bb59f5e421e5a4c615a8", "msg" : "Porting pdf_closure subroutine with OpenACC (#1059)", "paths" : [ { "editType" : "edit", "file" : "pdf_utilities.F90" }, { "editType" : "edit", "file" : "pdf_closure_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "stats_zm_module.F90", "advance_clubb_core_module.F90", "stats_variables.F90", "stats_clubb_utilities.F90" ], "commitId" : "74d62d932283ec7f668d1ab7a7eb5cf4c2518e31", "timestamp" : 1676661825000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "Adding wp3_on_wp2_cfl_num to CLUBB's output stats.\u000a", "date" : "2023-02-17 13:23:45 -0600", "id" : "74d62d932283ec7f668d1ab7a7eb5cf4c2518e31", "msg" : "Adding wp3_on_wp2_cfl_num to CLUBB's output stats.", "paths" : [ { "editType" : "edit", "file" : "stats_zm_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "stats_variables.F90" }, { "editType" : "edit", "file" : "stats_clubb_utilities.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90", "pdf_closure_module.F90", "adg1_adg2_3d_luhar_pdf.F90" ], "commitId" : "2cfb4126e2acaad338d58387801f2f0e69f2be66", "timestamp" : 1677519729000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, "authorEmail" : "37674341+huebleruwm@users.noreply.github.com", "comment" : "Removing usage of gr from pdf_closure. It was only ever used for nz, which is now fed in directly.\u000a", "date" : "2023-02-27 11:42:09 -0600", "id" : "2cfb4126e2acaad338d58387801f2f0e69f2be66", "msg" : "Removing usage of gr from pdf_closure. It was only ever used for nz, which is now fed in directly.", "paths" : [ { "editType" : "edit", "file" : "adg1_adg2_3d_luhar_pdf.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "pdf_closure_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "pdf_closure_module.F90" ], "commitId" : "90851771d55ebaeb104a3bd7edae92ffd4a248a6", "timestamp" : 1677613563000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Clubb ticket #1025: Implemented way to make esa tuner reproducible, h… (#1068)\u000a\u000a* Clubb ticket #1025: Implemented way to make esa tuner reproducible, hid error output of optional diagnostic variables behind check, fixed parallelization issue with tuner, esa max_iters parameter is now in stats namelist, fixed issue with TUNER compiler directive, some small fixes.\u000a- New namelist variables prescribed_rand_seed and l_use_prescribed_rand_seed determine if the esa tuner will use a random or a fixed value as random seed. Added descriptions to README.\u000a- Added max_iters to stats namelist to make it more modifiable.\u000a- Renamed stp_adjst_intercept_in and stp_adjst_slope_in to stp_adjst_shift_in and stp_adjst_factor_in, respectively, to better reflect their influence on step size.\u000a- The error output in src/CLUBB_core/pdf_closure_module.F90 for the diagnostic variables wprtp2, wpthlp2, wprtpthlp, and rcp2 is now hidden behind existence checks for these variables. And a clarification was added to \"#ifdef TUNER\" directive.\u000a- NetCDF file access caused the tuner to crash in parallel mode (-fopenmp flag in config file and multiple cases). Adding an $OMP CRITICAL structure around the call to stats_init in clubb_driver.F90 fixed that.\u000a- Fixed compile/README. Config files are specified with the -c option.\u000a- The -t option in run_scripts/run_tuner.bash interfered with the previous usage of the TUNER compiler directive. Renamed the old TUNER directive to NR_SP, a short for \"numerical recipes, single precision\". TUNER now is the option to \"turn on\" code changes required to run the tuner.\u000a", "date" : "2023-02-28 13:46:03 -0600", "id" : "90851771d55ebaeb104a3bd7edae92ffd4a248a6", "msg" : "Clubb ticket #1025: Implemented way to make esa tuner reproducible, h… (#1068)", "paths" : [ { "editType" : "edit", "file" : "pdf_closure_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "pdf_utilities.F90", "mixing_length.F90", "saturation.F90", "advance_clubb_core_module.F90", "mean_adv.F90", "pdf_closure_module.F90", "adg1_adg2_3d_luhar_pdf.F90", "grid_class.F90", "turbulent_adv_pdf.F90" ], "commitId" : "61ea0db56546ea2946cb3c0ee368fd57752c1451", "timestamp" : 1678297579000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Gpu updates (#1070)\u000a\u000a* Fixing bug. This was only triggered when l_input_fields=.true., which I am only testing because it needs to be true so that I can test ADG2_driver.\u000a\u000a* Removing usage of gr from pdf_closure. It was only ever used for nz, which is now fed in directly.\u000a\u000a* Making openacc statements more consistent. Ensuring all statments on double loops have specified gang and vector, and that all parallel loops have an end parallel loop statment at the end of them. Everything BFB on CPUs and GPUs.\u000a\u000a* Pushing acc data region to outermost parts of mixing_length.\u000a\u000a* Removing pdf_implicit_coefs_terms from acc copyin and copyout. It is only used when iiPDF_type == iiPDF_new .or. iiPDF_type == iiPDF_new_hybrid, so we do not need to do any copying with it. The inclusion of it also caused the data statement to copy unallocated arrays, which are just garbage pointers, and that was causing random occasional crashes (either segfaults or gpu out of memory).\u000a\u000a* The update device clauses for return variables seems to only be requried for arrays contained in types. See https://github.com/larson-group/clubb/issues/1049\\#issuecomment-1440624778\u000a\u000a* Moving acc end data to end of pdf_closure. This reuqired removing any conditional return statements that appear before the final return, since we're not allowed to branch out of an acc region early. I also moved a large printout statement outside of a loop. The only reason it was in the loop to begin with was because pdf_params used to be an array of types, but now is a type of arrays, allowing us to print the full arrays directly.\u000a\u000a* Making loop an acc loop. If we weren't outputting w_[up/down]_in_cloud (iw_up_in_cloud <= 0 .or. iw_down_in_cloud <= 0, then these arrays were only being zerod out on the CPU and would've getting overwritten by the uninitialized GPU data at the end of the data statement. This change causes the arrays to get correctly zerod out on the GPU when we need.\u000a\u000a* Update VariableGroupNondimMoments.py\u000a\u000aFixed a typo\u000a\u000a* Merging new changes from master\u000a\u000a* Removing need for -gpu=deepcopy, pushing some acc data statements up call tree, and replacing some acc data statements with acc delare statements so that return statements can be added back in.\u000a\u000a* Adding back an acc loop that was accidentally removed during a merge.\u000a\u000a---------\u000a\u000aCo-authored-by: Brian Griffin <31553422+bmg929@users.noreply.github.com>\u000a", "date" : "2023-03-08 11:46:19 -0600", "id" : "61ea0db56546ea2946cb3c0ee368fd57752c1451", "msg" : "Gpu updates (#1070)", "paths" : [ { "editType" : "edit", "file" : "pdf_utilities.F90" }, { "editType" : "edit", "file" : "pdf_closure_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "mean_adv.F90" }, { "editType" : "edit", "file" : "adg1_adg2_3d_luhar_pdf.F90" }, { "editType" : "edit", "file" : "turbulent_adv_pdf.F90" }, { "editType" : "edit", "file" : "saturation.F90" }, { "editType" : "edit", "file" : "mixing_length.F90" }, { "editType" : "edit", "file" : "grid_class.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mono_flux_limiter.F90" ], "commitId" : "fdf454198c75d605df4d989599620e23c42135fe", "timestamp" : 1678350700000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Implements Thomas Toniazzo's bug fix for spike removal\u000a\u000ain the monotonic flux limiter. See\u000a\u000ahttps://github.com/larson-group/clubb_release/pull/11/files\u000a\u000aThis code change is\u000aexpected to be BIT_CHANGING for cases in which\u000a`l_predict_upwp_vpwp = T`, `l_mono_flux_lim_um = T`\u000aor `l_mono_flux_lim_vm = T`, and the monotonic\u000aflux limiter is triggered.\u000a\u000aThis bug fix prevents non-conservation of momentum\u000awhen the vertical integral of either of the wind components `um` or `vm` is negative.\u000a", "date" : "2023-03-09 02:31:40 -0600", "id" : "fdf454198c75d605df4d989599620e23c42135fe", "msg" : "Implements Thomas Toniazzo's bug fix for spike removal", "paths" : [ { "editType" : "edit", "file" : "mono_flux_limiter.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90", "parameters_tunable.F90", "parameter_indices.F90", "sfc_varnce_module.F90", "clubb_api_module.F90" ], "commitId" : "e2ffb7330b8d80d9d895759c6a1781239ec00141", "timestamp" : 1678723565000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Making 'a_const' into a CLUBB tunable parameter. (#1072)\u000a\u000a* Converting the sfc_varnce_module.F90 parameter 'a_const' into a CLUBB tunable parameter.\u000a\u000aResults should be bit-for-bit since it will be set to 1.8 and with l_vary_convect_depth=F\u000athis is the standard value.\u000a\u000aSome discussion in ticket #994.\u000a\u000a* Completing requested changes, see PR #1072.\u000a", "date" : "2023-03-13 10:06:05 -0600", "id" : "e2ffb7330b8d80d9d895759c6a1781239ec00141", "msg" : "Making 'a_const' into a CLUBB tunable parameter. (#1072)", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "sfc_varnce_module.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" }, { "editType" : "edit", "file" : "parameter_indices.F90" }, { "editType" : "edit", "file" : "parameters_tunable.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "tunable_parameters.in" ], "commitId" : "ea8e240b701e58890146b050319eb71c919a70e0", "timestamp" : 1678723565000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Making 'a_const' into a CLUBB tunable parameter. (#1072)\u000a\u000a* Converting the sfc_varnce_module.F90 parameter 'a_const' into a CLUBB tunable parameter.\u000a\u000aResults should be bit-for-bit since it will be set to 1.8 and with l_vary_convect_depth=F\u000athis is the standard value.\u000a\u000aSome discussion in ticket #994.\u000a\u000a* Completing requested changes, see PR #1072.\u000a", "date" : "2023-03-13 10:06:05 -0600", "id" : "ea8e240b701e58890146b050319eb71c919a70e0", "msg" : "Making 'a_const' into a CLUBB tunable parameter. (#1072)", "paths" : [ { "editType" : "edit", "file" : "tunable_parameters.in" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SRC/SGS_CLUBB/clubb_sgs.F90" ], "commitId" : "a1e67efa7d98dfad48c03bfbc3d73585bd9dc457", "timestamp" : 1678723628000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephens", "fullName" : "benjamin.andrew.stephens" }, "authorEmail" : "benjamin.andrew.stephens@gmail.com", "comment" : "Updating for changes to CLUBB. See PR #1072.\u000a", "date" : "2023-03-13 11:07:08 -0500", "id" : "a1e67efa7d98dfad48c03bfbc3d73585bd9dc457", "msg" : "Updating for changes to CLUBB. See PR #1072.", "paths" : [ { "editType" : "edit", "file" : "SRC/SGS_CLUBB/clubb_sgs.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "Skx_module.F90", "pdf_closure_module.F90", "sigma_sqd_w_module.F90", "advance_clubb_core_module.F90", "T_in_K_module.F90" ], "commitId" : "1463a2c08c088d8c28aaf6831e88e234b76bdddd", "timestamp" : 1678812234000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Pdf closure driver gpuization (#1071)\u000a\u000a* GPUizing pdf_closure_driver, testing still needed, bug likely.\u000a\u000a* Making data movement better. Also fixed some random things. Still need to return returns.\u000a\u000a* Adding back a couple return statments. Moving a comment where it should be. GPUizing a missed loop.\u000a\u000a* Making arguements list satisfy standards.\u000a\u000a* Making arguements list satisfy standards. Also adding max(1,hydrometdim) to hydromet inputs.\u000a\u000a* Capitalizing K\u000a\u000a* Making the error case in compute_cloud_cover behavior a bit differently. This allows the error to be detected immediately by GPU runs as well.\u000a\u000a* Calling compute_cloud_cover only needs to be done if l_use_cloud_cover = .true.\u000a", "date" : "2023-03-14 11:43:54 -0500", "id" : "1463a2c08c088d8c28aaf6831e88e234b76bdddd", "msg" : "Pdf closure driver gpuization (#1071)", "paths" : [ { "editType" : "edit", "file" : "T_in_K_module.F90" }, { "editType" : "edit", "file" : "Skx_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "pdf_closure_module.F90" }, { "editType" : "edit", "file" : "sigma_sqd_w_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90" ], "commitId" : "6dd01b5920350c08035fa76d513f4086340a43f7", "timestamp" : 1679006580000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Moving compute_cloud_cover outside of if ( l_use_cloud_cover ) then statement, the cloud_cover and rcm_in_layer variables they compute aren't output in clubb_standalone, but are in cam, causing cam bit diff tests to break.\u000a", "date" : "2023-03-16 17:43:00 -0500", "id" : "6dd01b5920350c08035fa76d513f4086340a43f7", "msg" : "Moving compute_cloud_cover outside of if ( l_use_cloud_cover ) then statement, the cloud_cover and rcm_in_layer variables they compute aren't output in clubb_standalone, but are in cam, causing cam bit diff tests to break.", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90" ], "commitId" : "f635d227db08b38aa005bebbc8d0e63c4d6ea9ce", "timestamp" : 1679530369000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Adding Skthl_zm to the update host list, I missed this in the last PR. I noticed this by comparing results with and without managed memory, now I've checked BFBness with arm, mpace_b, mc3e, and gabls2.\u000a", "date" : "2023-03-22 19:12:49 -0500", "id" : "f635d227db08b38aa005bebbc8d0e63c4d6ea9ce", "msg" : "Adding Skthl_zm to the update host list, I missed this in the last PR. I noticed this by comparing results with and without managed memory, now I've checked BFBness with arm, mpace_b, mc3e, and gabls2.", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "grid_class.F90", "turbulent_adv_pdf.F90", "pdf_utilities.F90", "mixing_length.F90", "saturation.F90", "advance_clubb_core_module.F90", "mean_adv.F90", "Skx_module.F90", "pdf_closure_module.F90", "sigma_sqd_w_module.F90", "adg1_adg2_3d_luhar_pdf.F90", "T_in_K_module.F90", "parameters_model.F90" ], "commitId" : "adba51a83aea7bd6e044720c58e4d27596b235fa", "timestamp" : 1679711434000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Small GPU fixes (#1076)\u000a\u000a* Fixing small things that I caught by adding the default(present) onto acc loops.\u000a\u000a* Moving default(present) to the end because it looks nicer there.\u000a", "date" : "2023-03-24 21:30:34 -0500", "id" : "adba51a83aea7bd6e044720c58e4d27596b235fa", "msg" : "Small GPU fixes (#1076)", "paths" : [ { "editType" : "edit", "file" : "sigma_sqd_w_module.F90" }, { "editType" : "edit", "file" : "grid_class.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "pdf_utilities.F90" }, { "editType" : "edit", "file" : "mean_adv.F90" }, { "editType" : "edit", "file" : "Skx_module.F90" }, { "editType" : "edit", "file" : "T_in_K_module.F90" }, { "editType" : "edit", "file" : "mixing_length.F90" }, { "editType" : "edit", "file" : "adg1_adg2_3d_luhar_pdf.F90" }, { "editType" : "edit", "file" : "parameters_model.F90" }, { "editType" : "edit", "file" : "pdf_closure_module.F90" }, { "editType" : "edit", "file" : "saturation.F90" }, { "editType" : "edit", "file" : "turbulent_adv_pdf.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_wp2_wp3_module.F90", "advance_clubb_core_module.F90", "model_flags.F90", "clubb_api_module.F90", "clip_explicit.F90" ], "commitId" : "7435d1c799f340302393782cc58d5f7eaeb608ef", "timestamp" : 1680247062000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "Code changes to implement modificiations on wp3 clippings\u000aThis commit contains code changes to implement modifications of skewness\u000aclippings on wp3 in src/CLUBB_core/clip_explicit.F90. The default method attempts\u000ato apply smaller (larger) clippings below (above) 100m AGL level, which\u000acan cause a discontinuities around 100m AGL level. This clippings is\u000afound to trigger sawthooth oscillations in wp3 when linear diffusion is\u000aused. Such swathooth oscillations are eleminated if a smoothed Heaviside\u000afunction is introduced to obtain a smooth transition of clippings at\u000aaround 100m AGL level. The changes is necessary to obtain the first\u000aorder convergence in CLUBB-SCM when lienar diffusion is used.\u000a\u000aPreviously committed by Shixuan.\u000a", "date" : "2023-03-31 02:17:42 -0500", "id" : "7435d1c799f340302393782cc58d5f7eaeb608ef", "msg" : "Code changes to implement modificiations on wp3 clippings", "paths" : [ { "editType" : "edit", "file" : "clubb_api_module.F90" }, { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "clip_explicit.F90" }, { "editType" : "edit", "file" : "model_flags.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "configurable_model_flags.in" ], "commitId" : "43c7d40b518380bcd2ac664595a15a9d60fc1e23", "timestamp" : 1680247062000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "Code changes to implement modificiations on wp3 clippings\u000aThis commit contains code changes to implement modifications of skewness\u000aclippings on wp3 in src/CLUBB_core/clip_explicit.F90. The default method attempts\u000ato apply smaller (larger) clippings below (above) 100m AGL level, which\u000acan cause a discontinuities around 100m AGL level. This clippings is\u000afound to trigger sawthooth oscillations in wp3 when linear diffusion is\u000aused. Such swathooth oscillations are eleminated if a smoothed Heaviside\u000afunction is introduced to obtain a smooth transition of clippings at\u000aaround 100m AGL level. The changes is necessary to obtain the first\u000aorder convergence in CLUBB-SCM when lienar diffusion is used.\u000a\u000aPreviously committed by Shixuan.\u000a", "date" : "2023-03-31 02:17:42 -0500", "id" : "43c7d40b518380bcd2ac664595a15a9d60fc1e23", "msg" : "Code changes to implement modificiations on wp3 clippings", "paths" : [ { "editType" : "edit", "file" : "configurable_model_flags.in" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mixing_length.F90", "advance_clubb_core_module.F90", "model_flags.F90", "clubb_api_module.F90", "advance_helper_module.F90" ], "commitId" : "16fcc9ba1c2ab85f00a4d798dccf7a59cbfc718b", "timestamp" : 1680538287000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "This commit contains code changes to implement modifications on limiters in three places:\u000a\u000a1. remove the limiters in denominator of equation for\u000a brunt_vaisala_freq_sqd_smth, which affects the computed\u000a eddy dissipation time scale in turbulent fluxes (wpxp).\u000a (in mixing_length.F90)\u000a\u000a2. reduce the threshold values of limiters in the equation\u000a for richardson number (sqrt_Ri_zm)\u000a (in mixing_length.F90)\u000a\u000a3. introduce the smoothed max/min function for limiters in\u000a equation of Cx_fnc_Richardson.\u000a (in advance_helper_module.F90).\u000a\u000aAfter the modification, we also apply a zt2m(zm2zt) smoothing\u000aon the calculated quantities. These modifications are found to\u000abe benificial for improving solution convergence in CLUBB-SCM\u000a\u000aThe code changes are controlled by a newly introduced flag named\u000a\"l_modify_limiters_for_cnvg_test\", which is set to .false. (meaning that\u000athe modificaitons on limiters is turned off) by default.\u000a\u000aOriginally committed by Shixuan.\u000a", "date" : "2023-04-03 11:11:27 -0500", "id" : "16fcc9ba1c2ab85f00a4d798dccf7a59cbfc718b", "msg" : "This commit contains code changes to implement modifications on limiters in three places:", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" }, { "editType" : "edit", "file" : "advance_helper_module.F90" }, { "editType" : "edit", "file" : "mixing_length.F90" }, { "editType" : "edit", "file" : "model_flags.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "configurable_model_flags.in" ], "commitId" : "bbdd1ade0e614bb47e5341e8f9fb0f853320cd37", "timestamp" : 1680538287000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "This commit contains code changes to implement modifications on limiters in three places:\u000a\u000a1. remove the limiters in denominator of equation for\u000a brunt_vaisala_freq_sqd_smth, which affects the computed\u000a eddy dissipation time scale in turbulent fluxes (wpxp).\u000a (in mixing_length.F90)\u000a\u000a2. reduce the threshold values of limiters in the equation\u000a for richardson number (sqrt_Ri_zm)\u000a (in mixing_length.F90)\u000a\u000a3. introduce the smoothed max/min function for limiters in\u000a equation of Cx_fnc_Richardson.\u000a (in advance_helper_module.F90).\u000a\u000aAfter the modification, we also apply a zt2m(zm2zt) smoothing\u000aon the calculated quantities. These modifications are found to\u000abe benificial for improving solution convergence in CLUBB-SCM\u000a\u000aThe code changes are controlled by a newly introduced flag named\u000a\"l_modify_limiters_for_cnvg_test\", which is set to .false. (meaning that\u000athe modificaitons on limiters is turned off) by default.\u000a\u000aOriginally committed by Shixuan.\u000a", "date" : "2023-04-03 11:11:27 -0500", "id" : "bbdd1ade0e614bb47e5341e8f9fb0f853320cd37", "msg" : "This commit contains code changes to implement modifications on limiters in three places:", "paths" : [ { "editType" : "edit", "file" : "configurable_model_flags.in" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SRC/SGS_CLUBB/clubb_sgs.F90" ], "commitId" : "0c36e4d0e18216f9e07c93f9d23a4ee6cda7772b", "timestamp" : 1680548426000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "Updated for recent changes to CLUBB.\u000a", "date" : "2023-04-03 14:00:26 -0500", "id" : "0c36e4d0e18216f9e07c93f9d23a4ee6cda7772b", "msg" : "Updated for recent changes to CLUBB.", "paths" : [ { "editType" : "edit", "file" : "SRC/SGS_CLUBB/clubb_sgs.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "tunable_parameters.in" ], "commitId" : "7b3e07a340d0a20ceb50121b98b17575a70940d1", "timestamp" : 1680705925000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/cernikt", "fullName" : "cernikt" }, "authorEmail" : "tjcernik@uwm.edu", "comment" : "changing tunable_parameters\u000a", "date" : "2023-04-05 09:45:25 -0500", "id" : "7b3e07a340d0a20ceb50121b98b17575a70940d1", "msg" : "changing tunable_parameters", "paths" : [ { "editType" : "edit", "file" : "tunable_parameters.in" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "tunable_parameters.in" ], "commitId" : "75f7b52f068621eb5ee822dd7949639fefcebe59", "timestamp" : 1680706442000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/cernikt", "fullName" : "cernikt" }, "authorEmail" : "tjcernik@uwm.edu", "comment" : "changing tunable_parameters\u000a", "date" : "2023-04-05 09:54:02 -0500", "id" : "75f7b52f068621eb5ee822dd7949639fefcebe59", "msg" : "changing tunable_parameters", "paths" : [ { "editType" : "edit", "file" : "tunable_parameters.in" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "tunable_parameters.in" ], "commitId" : "f0d6b74bd5227cb61694f641b178a1d9d7a22f27", "timestamp" : 1680706472000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/cernikt", "fullName" : "cernikt" }, "authorEmail" : "tjcernik@uwm.edu", "comment" : "changing tunable_parameters\u000a", "date" : "2023-04-05 09:54:32 -0500", "id" : "f0d6b74bd5227cb61694f641b178a1d9d7a22f27", "msg" : "changing tunable_parameters", "paths" : [ { "editType" : "edit", "file" : "tunable_parameters.in" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "diffusion.F90", "advance_clubb_core_module.F90", "advance_xm_wpxp_module.F90", "clip_explicit.F90", "mean_adv.F90", "fill_holes.F90", "grid_class.F90", "matrix_solver_wrapper.F90", "turbulent_adv_pdf.F90", "parameters_model.F90", "advance_helper_module.F90", "mono_flux_limiter.F90" ], "commitId" : "781ef9dfc3079f5d20cf22f044eac5970443c1b9", "timestamp" : 1680716686000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Advance xm wpxp gpuization (#1077)\u000a\u000a* Initial commit for GPUizing advance_xm_wpxp.\u000a\u000a* GPUizing fill_holes_vertical\u000a\u000a* Adding Skthl_zm to the update host list, I missed this in the last PR. I noticed this by comparing results with and without managed memory, now I've checked BFBness with arm, mpace_b, mc3e, and gabls2.\u000a\u000a* Small GPU fixes (#1076)\u000a\u000a* Fixing small things that I caught by adding the default(present) onto acc loops.\u000a\u000a* Moving default(present) to the end because it looks nicer there.\u000a\u000a* Adding default(present) to all acc loop statements. Also adding azt to a copyin statement, which was missed previously. All BFB.\u000a\u000a* Incemental update, not well tested yet.\u000a\u000a* Removing some copies and making the sclr_dim change.\u000a\u000a* Fixing a bug that only seemed detectable with astex_a209. We need to pass only single arrays to functions, calling ddzt( nz, ngrdcol, gr, rho_ds_zt * K_zt_nu ) was resulting in rho_ds_zt * K_zt_nu being evluated on the CPU, but the values were only valid on the GPU. So we need to evaluate that expression on the GPU, save it into an array (currently K_zt_nu_tmp), then pass that to ddzt.\u000a\u000a* GPUizing calc_turb_adv_range\u000a\u000a* GPUizing mono_flux_limiter\u000a\u000a* Cleaning up data statments and a couple other things.\u000a\u000a* Updated for some different options.\u000a\u000a* More updates needed for various options.\u000a\u000a* Reverting accidental flag change\u000a\u000a* Should be the final changes, all options tested now.\u000a\u000a* Replacing some comments in monoflux limiter, and also modifying it to make it BFB on CPUs. Also changing incorrect error conditions on tridiag.\u000a\u000a* Adding max_x_allowable to update host statement, missed previous.\u000a\u000a* Properly naming tmp variables and variables calculated from ddzt and ddzm start with ddzt_ and ddzm_.\u000a\u000a* Replacing constants with named ones from constants_clubb.\u000a\u000a* Replacing hard coded numbers in lhs variables representing the number of bands they contain with fortran parameters.\u000a", "date" : "2023-04-05 12:44:46 -0500", "id" : "781ef9dfc3079f5d20cf22f044eac5970443c1b9", "msg" : "Advance xm wpxp gpuization (#1077)", "paths" : [ { "editType" : "edit", "file" : "advance_helper_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "diffusion.F90" }, { "editType" : "edit", "file" : "turbulent_adv_pdf.F90" }, { "editType" : "edit", "file" : "matrix_solver_wrapper.F90" }, { "editType" : "edit", "file" : "mean_adv.F90" }, { "editType" : "edit", "file" : "grid_class.F90" }, { "editType" : "edit", "file" : "parameters_model.F90" }, { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" }, { "editType" : "edit", "file" : "mono_flux_limiter.F90" }, { "editType" : "edit", "file" : "clip_explicit.F90" }, { "editType" : "edit", "file" : "fill_holes.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_xm_wpxp_module.F90" ], "commitId" : "4e5ef2859907a8a3e8b44fea718de72c509ae1a4", "timestamp" : 1680733435000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Small tweaks to fix some GPU bugs. Some variables were uninitialized on the CPU while we were saving them. This could only have been caught by comparing consecutive runs and checking _zt and _zm files, even then few cases were having problems.\u000a", "date" : "2023-04-05 17:23:55 -0500", "id" : "4e5ef2859907a8a3e8b44fea718de72c509ae1a4", "msg" : "Small tweaks to fix some GPU bugs. Some variables were uninitialized on the CPU while we were saving them. This could only have been caught by comparing consecutive runs and checking _zt and _zm files, even then few cases were having problems.", "paths" : [ { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "grid_class.F90" ], "commitId" : "9552ab496758875cdb5dff86d47d80e2d3a7cb0f", "timestamp" : 1680734063000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Fixing a labelling error in redirect_interpolated_azt_2D and similar procedures, since this interpolates to zt the input should be zm. I think this was my fault, so I cleaned all the zt2zm and zm2zt things up to make it a little nicer. Also ordered the routines _k _1D _2D to make it easier to jump around, it was a bit confusing as they were out of order and the typo really made it hard.\u000a", "date" : "2023-04-05 17:34:23 -0500", "id" : "9552ab496758875cdb5dff86d47d80e2d3a7cb0f", "msg" : "Fixing a labelling error in redirect_interpolated_azt_2D and similar procedures, since this interpolates to zt the input should be zm. I think this was my fault, so I cleaned all the zt2zm and zm2zt things up to make it a little nicer. Also ordered the routines _k _1D _2D to make it easier to jump around, it was a bit confusing as they were out of order and the typo really made it hard.", "paths" : [ { "editType" : "edit", "file" : "grid_class.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "parameters_model.F90" ], "commitId" : "c3bec1875abeade74fe0dd0cd38cb5361e7cac8f", "timestamp" : 1680842443000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Making it so sclr_tol is set to 0 before the specified sclr_tol_in. This is so that it is initialized to 0 in the case that sclr_dim = 0, since now we are setting it to have a minimum allocation size of 1 and would otherwise have a garbage value. This is what broke the clubb_openmp_gfortran_test.\u000a", "date" : "2023-04-06 23:40:43 -0500", "id" : "c3bec1875abeade74fe0dd0cd38cb5361e7cac8f", "msg" : "Making it so sclr_tol is set to 0 before the specified sclr_tol_in. This is so that it is initialized to 0 in the case that sclr_dim = 0, since now we are setting it to have a minimum allocation size of 1 and would otherwise have a garbage value. This is what broke the clubb_openmp_gfortran_test.", "paths" : [ { "editType" : "edit", "file" : "parameters_model.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mixing_length.F90", "grid_class.F90", "advance_clubb_core_module.F90", "clip_explicit.F90", "advance_helper_module.F90" ], "commitId" : "40a65a54f061974152b9431e88a562d557f70dc5", "timestamp" : 1681924858000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Lscale GPUization (#1079)\u000a\u000a* Making 2 new functions zm2zt2zm and zt2zm2zt to handle smoothing by interpolation. Replaced the spots in clubb I know that uses this to smooth things. This is just a nice to have and could allow for easy optimizations in the future by inlining the interpolations. All cases BFB on CPU and GPU, checked all relevant options too.\u000a\u000a* GPUizing diagnose_Lscale_from_tau\u000a\u000a* Removing some unused variables.\u000a\u000a* Moving acc data statements from calc_Lscale_directly up to advance_clubb_core.\u000a\u000a* Removing an unused variable.\u000a\u000a* GPUizing the l_smooth_min_max option.\u000a\u000a* GPUizing l_avg_Lscale\u000a\u000a* Changes to variable names to avoid gross long names only used once.\u000a", "date" : "2023-04-19 12:20:58 -0500", "id" : "40a65a54f061974152b9431e88a562d557f70dc5", "msg" : "Lscale GPUization (#1079)", "paths" : [ { "editType" : "edit", "file" : "grid_class.F90" }, { "editType" : "edit", "file" : "advance_helper_module.F90" }, { "editType" : "edit", "file" : "mixing_length.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "clip_explicit.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "grid_class.F90" ], "commitId" : "7094e3620ee063af2bd55a8f072cb32ce3858c4b", "timestamp" : 1681926818000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "gfortran does not like intent(out) specifiers for functions.\u000a", "date" : "2023-04-19 12:53:38 -0500", "id" : "7094e3620ee063af2bd55a8f072cb32ce3858c4b", "msg" : "gfortran does not like intent(out) specifiers for functions.", "paths" : [ { "editType" : "edit", "file" : "grid_class.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "Skx_module.F90", "sigma_sqd_w_module.F90", "interpolation.F90", "advance_clubb_core_module.F90", "calc_pressure.F90", "advance_helper_module.F90" ], "commitId" : "e12416aef4fd25ee8f843abab95e16d9a186d57e", "timestamp" : 1682105140000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "GPUizing Various Small Routines (#1080)\u000a\u000a* GPUizing compute_Cx_fnc_Richardson\u000a\u000a* GPUizing term_wp2_splat and term_wp3_splat\u000a\u000a* GPUizing xp3_LG_2005_ansatz\u000a\u000a* GPUizing calculate_thvm\u000a\u000a* GPUizing pvertinterp even though I don't think we care about the l_do_expldiff_rtm_thlm flag\u000a\u000a* Fixing bug. Setting l_do_expldiff_rtm_thlm causes us to use edsclrm, so we need to also ensure that edsclrm > 1 (1 because it uses a edsclr_dim-1 index)\u000a\u000a* Pushing some data statements up the call tree.\u000a", "date" : "2023-04-21 14:25:40 -0500", "id" : "e12416aef4fd25ee8f843abab95e16d9a186d57e", "msg" : "GPUizing Various Small Routines (#1080)", "paths" : [ { "editType" : "edit", "file" : "interpolation.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "calc_pressure.F90" }, { "editType" : "edit", "file" : "advance_helper_module.F90" }, { "editType" : "edit", "file" : "Skx_module.F90" }, { "editType" : "edit", "file" : "sigma_sqd_w_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "grid_class.F90" ], "commitId" : "0dbf4fc79c628d0d783a67b545a14792662177a3", "timestamp" : 1682273667000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/cernikt", "fullName" : "cernikt" }, "authorEmail" : "tjcernik@uwm.edu", "comment" : "This commit is a commit that changes absolutely nothing. It is meant to trigger a change in the git update scripts, so that I can start the commit message logging in the autocommit updates larson-group/sys_admin#797\u000a", "date" : "2023-04-23 13:14:27 -0500", "id" : "0dbf4fc79c628d0d783a67b545a14792662177a3", "msg" : "This commit is a commit that changes absolutely nothing. It is meant to trigger a change in the git update scripts, so that I can start the commit message logging in the autocommit updates larson-group/sys_admin#797", "paths" : [ { "editType" : "edit", "file" : "grid_class.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "math_utilities.F90" ], "commitId" : "fb9b5e177deabcd39ce0cf36b7b1f0fd883f4af6", "timestamp" : 1682273667000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/cernikt", "fullName" : "cernikt" }, "authorEmail" : "tjcernik@uwm.edu", "comment" : "This commit is a commit that changes absolutely nothing. It is meant to trigger a change in the git update scripts, so that I can start the commit message logging in the autocommit updates larson-group/sys_admin#797\u000a", "date" : "2023-04-23 13:14:27 -0500", "id" : "fb9b5e177deabcd39ce0cf36b7b1f0fd883f4af6", "msg" : "This commit is a commit that changes absolutely nothing. It is meant to trigger a change in the git update scripts, so that I can start the commit message logging in the autocommit updates larson-group/sys_admin#797", "paths" : [ { "editType" : "edit", "file" : "math_utilities.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "interpolation.F90" ], "commitId" : "8360118ab54c355ad8a86ed330ade644c4bdcbd8", "timestamp" : 1682278310000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/cernikt", "fullName" : "cernikt" }, "authorEmail" : "tjcernik@uwm.edu", "comment" : "this is another commit that cahnges nothing that will trigger the gitUpdate scripts\u000a", "date" : "2023-04-23 14:31:50 -0500", "id" : "8360118ab54c355ad8a86ed330ade644c4bdcbd8", "msg" : "this is another commit that cahnges nothing that will trigger the gitUpdate scripts", "paths" : [ { "editType" : "edit", "file" : "interpolation.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "clip_explicit.F90" ], "commitId" : "fa866723ef299b5e7c3574bb3f45f38f3fcb07f5", "timestamp" : 1682909659000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/cernikt", "fullName" : "cernikt" }, "authorEmail" : "tjcernik@uwm.edu", "comment" : "adding an update that changes nothing and is just a test for the autoupdate script\u000a", "date" : "2023-04-30 21:54:19 -0500", "id" : "fa866723ef299b5e7c3574bb3f45f38f3fcb07f5", "msg" : "adding an update that changes nothing and is just a test for the autoupdate script", "paths" : [ { "editType" : "edit", "file" : "clip_explicit.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_wp2_wp3_module.F90", "advance_xp2_xpyp_module.F90", "advance_clubb_core_module.F90", "stats_variables.F90", "stats_zm_module.F90", "sfc_varnce_module.F90", "advance_helper_module.F90" ], "commitId" : "e7a5c0ce02567906f9003eb1b1a1cf5ca94bca4c", "timestamp" : 1682952212000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Making CLUBB's splatting scheme implicit and smoother (#1075)\u000a\u000a* Introducing rough implicit splatting scheme into CLUBB. Not yet implicit for wp3.\u000a\u000a* Implementing implicit splatting for wp3.\u000a\u000a* Further improvements to implicit splatting code, including\u000a\u000a- smoothing of the BV freq used for splatting\u000a- adding a new variable 'bv_freq_sqd_splat' to stats\u000a- add the new variable to pyplotgen standard output\u000a\u000aSee PR #1075 and issue #994.\u000a\u000a* Some cleanup.\u000a\u000a* More cleanup, and adding comments.\u000a\u000a* More comments.\u000a\u000a* Updating implicit splatting scheme.\u000a\u000a* Updates to resolve PR requests.\u000a\u000aUpdates associated with implicit splatting will be BIT_CHANGING.\u000a", "date" : "2023-05-01 08:43:32 -0600", "id" : "e7a5c0ce02567906f9003eb1b1a1cf5ca94bca4c", "msg" : "Making CLUBB's splatting scheme implicit and smoother (#1075)", "paths" : [ { "editType" : "edit", "file" : "stats_variables.F90" }, { "editType" : "edit", "file" : "advance_helper_module.F90" }, { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" }, { "editType" : "edit", "file" : "sfc_varnce_module.F90" }, { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "stats_zm_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90", "sfc_varnce_module.F90", "advance_helper_module.F90" ], "commitId" : "08475cfca3f2571fc6342c8137f1c64d61bd6857", "timestamp" : 1683080989000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Calc sfc varnce GPUization (#1081)\u000a\u000a* Initial loop push for calc_sfc_varnce\u000a\u000a* BIT_CHANGING:3b086a40085284aa49c71d32c001d20153a8ddb4 the last commit is bit changing for only some cases and only when using higher than -02 optimization. uf min seems to be the first calculation that starting to differ bitwise. Using the check_multicol script confirms the differences are small.\u000a\u000a* Adding a tweak to surface values in the extra columns. This helped me check calc_sfc_varance, since we were not changing any arrays that would've affected calculations there.\u000a\u000a* Small optimization, making wstar and ustar2 scalars.\u000a\u000a* GPUizing calc_sfc_varnce\u000a\u000a* Removing conditional around some stats calls. Now we will always save sfc values to stats, because this will change stats files when gr%zm(i,1) > sfc_elevation, this is potentially BIT_CHANGING.\u000a\u000a* Merging with latest clubb changes and making work on GPUs again.\u000a\u000aThis contained 2 commits that are BIT_CHANGING in some situations.\u000a", "date" : "2023-05-02 21:29:49 -0500", "id" : "08475cfca3f2571fc6342c8137f1c64d61bd6857", "msg" : "Calc sfc varnce GPUization (#1081)", "paths" : [ { "editType" : "edit", "file" : "sfc_varnce_module.F90" }, { "editType" : "edit", "file" : "advance_helper_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_helper_module.F90" ], "commitId" : "3daa3257c2033ab03757a3c5bed4d780fae45770", "timestamp" : 1683129413000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephens", "fullName" : "benjamin.andrew.stephens" }, "authorEmail" : "benjamin.andrew.stephens@gmail.com", "comment" : "Reducing C_wp2_splat to 0.25 (from 2.0) for new implicit splatting code.\u000a\u000aAlso fixing bug that shows up when l_brunt_vaisala_freq_moist = T. This\u000awill hopefully help to get some failing CAM tests running again.\u000a\u000aSee #1074 and PR #1075 for info.\u000a\u000aThis is BIT_CHANGING for all cases due to the new tunable parameter value.\u000a", "date" : "2023-05-03 10:56:53 -0500", "id" : "3daa3257c2033ab03757a3c5bed4d780fae45770", "msg" : "Reducing C_wp2_splat to 0.25 (from 2.0) for new implicit splatting code.", "paths" : [ { "editType" : "edit", "file" : "advance_helper_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "tunable_parameters.in" ], "commitId" : "e462b213d8d0ca63221050f70a6ff8a52467b203", "timestamp" : 1683129413000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephens", "fullName" : "benjamin.andrew.stephens" }, "authorEmail" : "benjamin.andrew.stephens@gmail.com", "comment" : "Reducing C_wp2_splat to 0.25 (from 2.0) for new implicit splatting code.\u000a\u000aAlso fixing bug that shows up when l_brunt_vaisala_freq_moist = T. This\u000awill hopefully help to get some failing CAM tests running again.\u000a\u000aSee #1074 and PR #1075 for info.\u000a\u000aThis is BIT_CHANGING for all cases due to the new tunable parameter value.\u000a", "date" : "2023-05-03 10:56:53 -0500", "id" : "e462b213d8d0ca63221050f70a6ff8a52467b203", "msg" : "Reducing C_wp2_splat to 0.25 (from 2.0) for new implicit splatting code.", "paths" : [ { "editType" : "edit", "file" : "tunable_parameters.in" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "clip_explicit.F90" ], "commitId" : "a9af25eeab72b59dae5bd30bd315b35c8c78961a", "timestamp" : 1683399661000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/cernikt", "fullName" : "cernikt" }, "authorEmail" : "tjcernik@uwm.edu", "comment" : "Removed Space From clip_explicit\u000a\u000aThis is another commit that changes absolutely nothing, and only exists to test autocommit changes\u000a", "date" : "2023-05-06 14:01:01 -0500", "id" : "a9af25eeab72b59dae5bd30bd315b35c8c78961a", "msg" : "Removed Space From clip_explicit", "paths" : [ { "editType" : "edit", "file" : "clip_explicit.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "calendar.F90" ], "commitId" : "a7df38330f8cf210f542a395c8b1df60b166859b", "timestamp" : 1683999525000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/cernikt", "fullName" : "cernikt" }, "authorEmail" : "tjcernik@uwm.edu", "comment" : "making changes to trigger autoudpate for test, these commits do nothing\u000a\u000ahere is a body to the commit as well\u000a", "date" : "2023-05-13 12:38:45 -0500", "id" : "a7df38330f8cf210f542a395c8b1df60b166859b", "msg" : "making changes to trigger autoudpate for test, these commits do nothing", "paths" : [ { "editType" : "edit", "file" : "calendar.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "math_utilities.F90" ], "commitId" : "c5d25471ddb6daf201a8dc99ed95aca1b1f6091c", "timestamp" : 1683999525000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/cernikt", "fullName" : "cernikt" }, "authorEmail" : "tjcernik@uwm.edu", "comment" : "making changes to trigger autoudpate for test, these commits do nothing\u000a\u000ahere is a body to the commit as well\u000a", "date" : "2023-05-13 12:38:45 -0500", "id" : "c5d25471ddb6daf201a8dc99ed95aca1b1f6091c", "msg" : "making changes to trigger autoudpate for test, these commits do nothing", "paths" : [ { "editType" : "edit", "file" : "math_utilities.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "calendar.F90" ], "commitId" : "571c3fab16ab4f1315e272fa536064a8dc4720f0", "timestamp" : 1684000665000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/cernikt", "fullName" : "cernikt" }, "authorEmail" : "tjcernik@uwm.edu", "comment" : "Here is another commit that changes nothing\u000a\u000aHere is the body\u000a", "date" : "2023-05-13 12:57:45 -0500", "id" : "571c3fab16ab4f1315e272fa536064a8dc4720f0", "msg" : "Here is another commit that changes nothing", "paths" : [ { "editType" : "edit", "file" : "calendar.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "math_utilities.F90" ], "commitId" : "10561ea5166e8f1045de302b117e2d6526332337", "timestamp" : 1684000665000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/cernikt", "fullName" : "cernikt" }, "authorEmail" : "tjcernik@uwm.edu", "comment" : "Here is another commit that changes nothing\u000a\u000aHere is the body\u000a", "date" : "2023-05-13 12:57:45 -0500", "id" : "10561ea5166e8f1045de302b117e2d6526332337", "msg" : "Here is another commit that changes nothing", "paths" : [ { "editType" : "edit", "file" : "math_utilities.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "endian.F90" ], "commitId" : "81f82f5ff2f9a5f7047d2c810aeff0ac5c296b43", "timestamp" : 1684001427000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/cernikt", "fullName" : "cernikt" }, "authorEmail" : "tjcernik@uwm.edu", "comment" : "change to trigger updates\u000a\u000athis is the last batch\u000a", "date" : "2023-05-13 13:10:27 -0500", "id" : "81f82f5ff2f9a5f7047d2c810aeff0ac5c296b43", "msg" : "change to trigger updates", "paths" : [ { "editType" : "edit", "file" : "endian.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "calc_pressure.F90" ], "commitId" : "c2e0cf01861d6d2e292f0cc51c24a83c8ab1e711", "timestamp" : 1684001497000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/cernikt", "fullName" : "cernikt" }, "authorEmail" : "tjcernik@uwm.edu", "comment" : "change to calc pressure to trigger autoupdate\u000a\u000abody\u000a", "date" : "2023-05-13 13:11:37 -0500", "id" : "c2e0cf01861d6d2e292f0cc51c24a83c8ab1e711", "msg" : "change to calc pressure to trigger autoupdate", "paths" : [ { "editType" : "edit", "file" : "calc_pressure.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90", "advance_helper_module.F90" ], "commitId" : "8287750b397ac2e5d927bb4efe23a830f94c4362", "timestamp" : 1685471093000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "GPUizing Lscale_width_vert_avg. Loops have been restructured for simplicity, and algorithm has a different starting value to avoid k dependency. Results are BFB. (#1083)\u000a\u000a", "date" : "2023-05-30 13:24:53 -0500", "id" : "8287750b397ac2e5d927bb4efe23a830f94c4362", "msg" : "GPUizing Lscale_width_vert_avg. Loops have been restructured for simplicity, and algorithm has a different starting value to avoid k dependency. Results are BFB. (#1083)", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "advance_helper_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90" ], "commitId" : "c7c530d40612ef299f0a4a02b7c19b9141ff7991", "timestamp" : 1685683010000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "GPUizing most of advance_clubb_core (#1084)\u000a\u000a", "date" : "2023-06-02 00:16:50 -0500", "id" : "c7c530d40612ef299f0a4a02b7c19b9141ff7991", "msg" : "GPUizing most of advance_clubb_core (#1084)", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90", "advance_wp2_wp3_module.F90", "clip_explicit.F90" ], "commitId" : "f5f1d7adc31786cff8a7f24873958345b989d143", "timestamp" : 1686085026000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "advance_wp2_wp3 with explicitly managed memory (#1085)\u000a\u000a* GPUizing most of advance_clubb_core\u000a\u000a* GPUizing most of advance_wp2_wp3 based off Supreeths openacc branch\u000a\u000a* Cleanup and small fixes.\u000a\u000a* Converting data statement to declare statement to return the return.\u000a\u000a* Small changes to prevent data copies\u000a", "date" : "2023-06-06 15:57:06 -0500", "id" : "f5f1d7adc31786cff8a7f24873958345b989d143", "msg" : "advance_wp2_wp3 with explicitly managed memory (#1085)", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" }, { "editType" : "edit", "file" : "clip_explicit.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90", "advance_xp2_xpyp_module.F90" ], "commitId" : "78ebf2ff4d7e6b804bf322a713fe95448a09291d", "timestamp" : 1686267553000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "advance_xp2_xpyp with explicitly managed memory (#1086)\u000a\u000a* GPUizing most of advance_clubb_core\u000a\u000a* GPUizing most of advance_wp2_wp3 based off Supreeths openacc branch\u000a\u000a* Cleanup and small fixes.\u000a\u000a* Converting data statement to declare statement to return the return.\u000a\u000a* Small changes to prevent data copies\u000a\u000a* Initial advance_xp2_xpyp GPUization, adapted from Supreeth's branch, clubb_openacc, to work without managed memory.\u000a\u000a* Small cleanup\u000a\u000a* Tweaks to reduce data copies\u000a\u000a* Small change\u000a\u000a* More GPUization and some cleanup\u000a\u000a* Final little fixes\u000a\u000a* Removing magic logicals\u000a", "date" : "2023-06-08 18:39:13 -0500", "id" : "78ebf2ff4d7e6b804bf322a713fe95448a09291d", "msg" : "advance_xp2_xpyp with explicitly managed memory (#1086)", "paths" : [ { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90", "advance_windm_edsclrm_module.F90", "advance_helper_module.F90" ], "commitId" : "3f3703f99ebea92453249f1d9614b64ea1fdc6be", "timestamp" : 1686271203000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "advance_windm_edsclrm with explicitly managed memory (#1087)\u000a\u000a* Initial commit for advance_windm_edsclrm adapted from Supreeth's branch\u000a\u000a* Final fixes\u000a\u000a* Accidentally undid fix\u000a\u000a* Returning returns\u000a", "date" : "2023-06-08 19:40:03 -0500", "id" : "3f3703f99ebea92453249f1d9614b64ea1fdc6be", "msg" : "advance_windm_edsclrm with explicitly managed memory (#1087)", "paths" : [ { "editType" : "edit", "file" : "advance_helper_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "advance_windm_edsclrm_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90", "advance_wp2_wp3_module.F90" ], "commitId" : "543091c32308120ba9fe22873baa81050ac05292", "timestamp" : 1686688221000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Moving data statements to outter most parts of clubb and little fix in advance_wp2_wp3 (#1088)\u000a\u000a", "date" : "2023-06-13 15:30:21 -0500", "id" : "543091c32308120ba9fe22873baa81050ac05292", "msg" : "Moving data statements to outter most parts of clubb and little fix in advance_wp2_wp3 (#1088)", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_wp2_wp3_module.F90", "advance_xp2_xpyp_module.F90", "advance_clubb_core_module.F90", "clip_explicit.F90", "fill_holes.F90", "pdf_closure_module.F90", "advance_helper_module.F90", "mono_flux_limiter.F90" ], "commitId" : "63cc96a19e5b8bd47a08bdc600b8d158741ab2e9", "timestamp" : 1687300675000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Data movement improvement (#1089)\u000a\u000a* Various reductions in data movement\u000a\u000a* Bug fix\u000a\u000a* Optimizations to fill_holes, this involves precalculating a multiplication an a division, so this is BIT_CHANGING.\u000a\u000a* Missed a small part\u000a\u000a* Small fix\u000a", "date" : "2023-06-20 17:37:55 -0500", "id" : "63cc96a19e5b8bd47a08bdc600b8d158741ab2e9", "msg" : "Data movement improvement (#1089)", "paths" : [ { "editType" : "edit", "file" : "clip_explicit.F90" }, { "editType" : "edit", "file" : "advance_helper_module.F90" }, { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" }, { "editType" : "edit", "file" : "mono_flux_limiter.F90" }, { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "fill_holes.F90" }, { "editType" : "edit", "file" : "pdf_closure_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mixing_length.F90", "advance_clubb_core_module.F90", "parameter_indices.F90", "advance_xm_wpxp_module.F90", "clubb_api_module.F90", "parameters_tunable.F90", "advance_helper_module.F90" ], "commitId" : "20ca5caead8ec3ad50ac7b996339efbcc48a6412", "timestamp" : 1687909037000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "CLUBB ticket #1069: (#1092)\u000a\u000a- Added tunable parameter bv_efold\u000a- Removed extraneous use statement in src/CLUBB_core/advance_xm_wpxp_module.F90\u000a- Removed obsolete flag l_update_pressure from input/tunable_parameters_Lscale/configurable_model_flags.in\u000a- Changed tmp_calc_min -> tmp_calc in src/CLUBB_core/advance_helper_module.F90\u000a", "date" : "2023-06-27 18:37:17 -0500", "id" : "20ca5caead8ec3ad50ac7b996339efbcc48a6412", "msg" : "CLUBB ticket #1069: (#1092)", "paths" : [ { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" }, { "editType" : "edit", "file" : "advance_helper_module.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" }, { "editType" : "edit", "file" : "mixing_length.F90" }, { "editType" : "edit", "file" : "parameters_tunable.F90" }, { "editType" : "edit", "file" : "parameter_indices.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "tunable_parameters.in" ], "commitId" : "e35cb4b162ef470d738d15bda20b2067721ac0b8", "timestamp" : 1687909037000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "CLUBB ticket #1069: (#1092)\u000a\u000a- Added tunable parameter bv_efold\u000a- Removed extraneous use statement in src/CLUBB_core/advance_xm_wpxp_module.F90\u000a- Removed obsolete flag l_update_pressure from input/tunable_parameters_Lscale/configurable_model_flags.in\u000a- Changed tmp_calc_min -> tmp_calc in src/CLUBB_core/advance_helper_module.F90\u000a", "date" : "2023-06-27 18:37:17 -0500", "id" : "e35cb4b162ef470d738d15bda20b2067721ac0b8", "msg" : "CLUBB ticket #1069: (#1092)", "paths" : [ { "editType" : "edit", "file" : "tunable_parameters.in" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SRC/SGS_CLUBB/clubb_sgs.F90" ], "commitId" : "919d552ce1c42bb871387acfa843579b984b81da", "timestamp" : 1688069190000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/vlarson", "fullName" : "Vince Larson" }, "authorEmail" : "vlarson@users.noreply.github.com", "comment" : "Added bv_efold changes for CLUBB API calls\u000a", "date" : "2023-06-29 15:06:30 -0500", "id" : "919d552ce1c42bb871387acfa843579b984b81da", "msg" : "Added bv_efold changes for CLUBB API calls", "paths" : [ { "editType" : "edit", "file" : "SRC/SGS_CLUBB/clubb_sgs.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90" ], "commitId" : "42253d9234a3c885d4c8017fa21efee44b8d3f80", "timestamp" : 1688584676000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephens", "fullName" : "benjamin.andrew.stephens" }, "authorEmail" : "benjamin.andrew.stephens@gmail.com", "comment" : "Changing \"Fnc\" to \"fnc\" for consistency and easy search.\u000a", "date" : "2023-07-05 14:17:56 -0500", "id" : "42253d9234a3c885d4c8017fa21efee44b8d3f80", "msg" : "Changing \"Fnc\" to \"fnc\" for consistency and easy search.", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mixing_length.F90", "advance_xp2_xpyp_module.F90", "advance_clubb_core_module.F90", "advance_xm_wpxp_module.F90", "clip_explicit.F90", "pdf_closure_module.F90", "advance_windm_edsclrm_module.F90" ], "commitId" : "a10584a92f2734f4671151e039920a780f1ae1c1", "timestamp" : 1688611277000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Memory usage optimizations (#1091)\u000a\u000a* Fixing merge conflict\u000a\u000a* Fixing a bug.\u000a\u000a* Restoring correct default flag value\u000a\u000a* Undoing changes that push stats variables into pdf_closure. That change may be included in a small future refactoring.\u000a\u000a* Making same sclr_dim changes to hydromet_dim\u000a", "date" : "2023-07-05 21:41:17 -0500", "id" : "a10584a92f2734f4671151e039920a780f1ae1c1", "msg" : "Memory usage optimizations (#1091)", "paths" : [ { "editType" : "edit", "file" : "advance_windm_edsclrm_module.F90" }, { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" }, { "editType" : "edit", "file" : "mixing_length.F90" }, { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "clip_explicit.F90" }, { "editType" : "edit", "file" : "pdf_closure_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SRC/SGS_CLUBB/clubb_sgs.F90" ], "commitId" : "4fc849e5411ca3918dfb306c5d93d6c5a82b1b15", "timestamp" : 1689031950000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Making compatible with latest clubb changes.\u000a", "date" : "2023-07-10 18:32:30 -0500", "id" : "4fc849e5411ca3918dfb306c5d93d6c5a82b1b15", "msg" : "Making compatible with latest clubb changes.", "paths" : [ { "editType" : "edit", "file" : "SRC/SGS_CLUBB/clubb_sgs.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "diffusion.F90", "advance_xm_wpxp_module.F90", "clubb_api_module.F90", "clip_explicit.F90", "grid_class.F90", "advance_windm_edsclrm_module.F90", "turbulent_adv_pdf.F90", "mono_flux_limiter.F90", "advance_helper_module.F90", "advance_wp2_wp3_module.F90", "mixing_length.F90", "advance_xp2_xpyp_module.F90", "advance_clubb_core_module.F90", "mean_adv.F90", "fill_holes.F90", "adg1_adg2_3d_luhar_pdf.F90", "sigma_sqd_w_module.F90", "interpolation.F90", "matrix_solver_wrapper.F90", "sfc_varnce_module.F90" ], "commitId" : "08cf4c792a67a0b4866c749b34a4ac7a987a3198", "timestamp" : 1689032527000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Openacc tweaks and cleanup (#1097)\u000a\u000a* Chaning acc declare statements to acc enter data statement\u000a\u000a* Making acc statements more consistent\u000a\u000a* Making lapack useable while using openacc. Lapack is still run on the CPU\u000a\u000a* Updating setup_clubb_core to now accept clubb_config_flags as an input, and adding warning in case clubb is running with lapack but was compiled with openacc.\u000a", "date" : "2023-07-10 18:42:07 -0500", "id" : "08cf4c792a67a0b4866c749b34a4ac7a987a3198", "msg" : "Openacc tweaks and cleanup (#1097)", "paths" : [ { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" }, { "editType" : "edit", "file" : "interpolation.F90" }, { "editType" : "edit", "file" : "matrix_solver_wrapper.F90" }, { "editType" : "edit", "file" : "adg1_adg2_3d_luhar_pdf.F90" }, { "editType" : "edit", "file" : "diffusion.F90" }, { "editType" : "edit", "file" : "grid_class.F90" }, { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" }, { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" }, { "editType" : "edit", "file" : "advance_windm_edsclrm_module.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "clip_explicit.F90" }, { "editType" : "edit", "file" : "turbulent_adv_pdf.F90" }, { "editType" : "edit", "file" : "sigma_sqd_w_module.F90" }, { "editType" : "edit", "file" : "fill_holes.F90" }, { "editType" : "edit", "file" : "mono_flux_limiter.F90" }, { "editType" : "edit", "file" : "mixing_length.F90" }, { "editType" : "edit", "file" : "sfc_varnce_module.F90" }, { "editType" : "edit", "file" : "mean_adv.F90" }, { "editType" : "edit", "file" : "advance_helper_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mean_adv.F90" ], "commitId" : "40e8eb850e5cc930b2f734acf3504fb8d9e340a5", "timestamp" : 1689430804000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Loop to `nz-1` instead of `nz` because upper boundary condition\u000a\u000ais set in the lines immediately below.\u000a", "date" : "2023-07-15 09:20:04 -0500", "id" : "40e8eb850e5cc930b2f734acf3504fb8d9e340a5", "msg" : "Loop to `nz-1` instead of `nz` because upper boundary condition", "paths" : [ { "editType" : "edit", "file" : "mean_adv.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "diffusion.F90", "clip_semi_implicit.F90", "clip_explicit.F90", "advance_xm_wpxp_module.F90", "clubb_api_module.F90", "numerical_check.F90", "grid_class.F90", "calc_roots.F90", "penta_lu_solver.F90", "advance_windm_edsclrm_module.F90", "turbulent_adv_pdf.F90", "advance_helper_module.F90", "mono_flux_limiter.F90", "advance_wp2_wp3_module.F90", "advance_xp2_xpyp_module.F90", "advance_clubb_core_module.F90", "advance_xp3_module.F90", "tridiag_lu_solver.F90", "mean_adv.F90", "fill_holes.F90", "adg1_adg2_3d_luhar_pdf.F90", "corr_varnce_module.F90" ], "commitId" : "1238826836d00367458527d254d2b3c9d7f87e93", "timestamp" : 1689730027000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Openacc tweaks and cleanup 2 (#1099)\u000a\u000a* Making all end parallel directives specify end loop\u000a\u000a* Replacing last acc declare in a procedure with acc enter/exit data commands\u000a\u000a* Removing pure declarations, turns out they dont really improve performance and openmp isn't allowed within them.\u000a\u000a* Adding explicit directives to penta_lu and tridiag_lu, as opposed to the previously used kernels directive. Also splitting up a loop to improve GPU performance.\u000a\u000a* Splitting up a couple loops for performance reasons.\u000a\u000a* Missed one somehow\u000a", "date" : "2023-07-18 20:27:07 -0500", "id" : "1238826836d00367458527d254d2b3c9d7f87e93", "msg" : "Openacc tweaks and cleanup 2 (#1099)", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "advance_helper_module.F90" }, { "editType" : "edit", "file" : "clip_explicit.F90" }, { "editType" : "edit", "file" : "numerical_check.F90" }, { "editType" : "edit", "file" : "mean_adv.F90" }, { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" }, { "editType" : "edit", "file" : "tridiag_lu_solver.F90" }, { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" }, { "editType" : "edit", "file" : "advance_xp3_module.F90" }, { "editType" : "edit", "file" : "grid_class.F90" }, { "editType" : "edit", "file" : "diffusion.F90" }, { "editType" : "edit", "file" : "advance_windm_edsclrm_module.F90" }, { "editType" : "edit", "file" : "adg1_adg2_3d_luhar_pdf.F90" }, { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" }, { "editType" : "edit", "file" : "clip_semi_implicit.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" }, { "editType" : "edit", "file" : "mono_flux_limiter.F90" }, { "editType" : "edit", "file" : "calc_roots.F90" }, { "editType" : "edit", "file" : "corr_varnce_module.F90" }, { "editType" : "edit", "file" : "penta_lu_solver.F90" }, { "editType" : "edit", "file" : "turbulent_adv_pdf.F90" }, { "editType" : "edit", "file" : "fill_holes.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_xp2_xpyp_module.F90", "Skx_module.F90", "mean_adv.F90" ], "commitId" : "e9ae50fd67886661f7d03ab3549044e5c2c9517a", "timestamp" : 1690323761000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Bit changing changes (#1104)\u000a\u000a* Moving functions called inside loops to their own 2D subroutines. This is for performance, but is also BIT_CHANGING.\u000a\u000a* Correct range of values to calculate for term_dp1_lhs\u000a\u000a* Comments and cleanup\u000a\u000a* Slight change to Skx_func, this is mathematically equivalent but BIT_CHANGING. This is faster on GPUs, and doesn't seem to have a signficiant impact on CPU performance.\u000a\u000a* Introducing wp_coef and wp_coef_zt to reduce needed computations. This changes order of operations, so it is BIT_CHANGING.\u000a", "date" : "2023-07-25 17:22:41 -0500", "id" : "e9ae50fd67886661f7d03ab3549044e5c2c9517a", "msg" : "Bit changing changes (#1104)", "paths" : [ { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" }, { "editType" : "edit", "file" : "mean_adv.F90" }, { "editType" : "edit", "file" : "Skx_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_xp2_xpyp_module.F90" ], "commitId" : "6fa34ce2d5ff0c26b7dcf4fed129a8d32ce7dc69", "timestamp" : 1690679815000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Adding wp_coef and wp_coef_zt to acc data statements.\u000a", "date" : "2023-07-29 20:16:55 -0500", "id" : "6fa34ce2d5ff0c26b7dcf4fed129a8d32ce7dc69", "msg" : "Adding wp_coef and wp_coef_zt to acc data statements.", "paths" : [ { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mixing_length.F90", "advance_clubb_core_module.F90", "advance_helper_module.F90", "stats_zt_module.F90" ], "commitId" : "c0fdc2b307c5f63608c72f08ab493fce4516a741", "timestamp" : 1690921282000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Bv efold bit changing (#1095)\u000a\u000aBIT_CHANGING! Added e-folding code for mixed Brunt Vaisala frequency - CLUBB ticket #1069\u000a- Included usage for bv_efold in src/CLUBB_core/advance_helper_module.F90\u000a- Added intent(out) for correction_stability in subroutine calc_correction_stability\u000a- Removed brunt_vaisala_freq_sqd_plus\u000a- Idiot proofed interaction between l_diag_Lscale_from_tau and l_use_invrs_tau_N2_iso\u000a- Moved stat_update_var(invrs_tau_wp3_zm) out of if ( l_diag_Lscale_from_tau )\u000a- Fixed some typos in src/CLUBB_core/stats_zt_module.F90\u000a- Added comment about to input_misc/tuner/README about t_variables adn input/stats/tuning_stats.in\u000a", "date" : "2023-08-01 15:21:22 -0500", "id" : "c0fdc2b307c5f63608c72f08ab493fce4516a741", "msg" : "Bv efold bit changing (#1095)", "paths" : [ { "editType" : "edit", "file" : "advance_helper_module.F90" }, { "editType" : "edit", "file" : "mixing_length.F90" }, { "editType" : "edit", "file" : "stats_zt_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90", "advance_helper_module.F90" ], "commitId" : "4ebc70252b6ce52cfdb7883770217c34fd2e2107", "timestamp" : 1693937947000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Fixed some oversights for the bv_efold commits and increased string length for tuning field names for invrs_tau variables - CLUBB ticket #1069 (#1106)\u000a\u000aThis commit is NOT bit changing\u000a- Removed remaining mentions of brunt_vaisala_freq_sqd_plus\u000a- Added assignment for invrs_tau_wp3_zm in Lscale mode in advance_clubb_core\u000a- Increased length of string variables hoc_v, les_v, and t_variables in src/error.F90 to accomodate tuning for invrs_tau fields\u000a", "date" : "2023-09-05 13:19:07 -0500", "id" : "4ebc70252b6ce52cfdb7883770217c34fd2e2107", "msg" : "Fixed some oversights for the bv_efold commits and increased string length for tuning field names for invrs_tau variables - CLUBB ticket #1069 (#1106)", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "advance_helper_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mixing_length.F90" ], "commitId" : "395023c230e9f1ddaa7411d592718b573ab65d15", "timestamp" : 1693950812000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "BIT_CHANGING! brunt_vaisala_freq_sqd_mixed now replaces brunt_vaisala_freq_sqd for later calculations - CLUBB ticket #1102\u000a\u000aChanges in src/CLUBB_core/mixing_length.F90:\u000a- brunt_vaisala_freq_sqd_mixed is now used to calculate brunt_vaisala_freq_sqd_smth and brunt_vaisala_freq_sqd_clipped instead of brunt_vaisala_freq_sqd\u000a- Removed 0.1 factor for bkgnd term in calculation of invrs_tau_xp2_zm\u000a- Commented out clipping of invrs_tau_xp2_zm to 0.003 and lower out of cloud\u000a", "date" : "2023-09-05 16:53:32 -0500", "id" : "395023c230e9f1ddaa7411d592718b573ab65d15", "msg" : "BIT_CHANGING! brunt_vaisala_freq_sqd_mixed now replaces brunt_vaisala_freq_sqd for later calculations - CLUBB ticket #1102", "paths" : [ { "editType" : "edit", "file" : "mixing_length.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "model_flags.F90" ], "commitId" : "7afb2bd7070e5e83204950c8b94a12b73b8f88fd", "timestamp" : 1694635856000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "BIT_CHANGING for lscale setup. Updated configurable_model_flags.in and model_flags.F90 - CLUBB ticket #1102 (#1108)\u000a\u000a- Added new flags to inut/tunable_parameters_Lscale/configurable_model_flags.in\u000a- Changed default setting for l_use_tke_in_wp3_pr_turb_term in model_flags.F90 from false to true\u000a", "date" : "2023-09-13 15:10:56 -0500", "id" : "7afb2bd7070e5e83204950c8b94a12b73b8f88fd", "msg" : "BIT_CHANGING for lscale setup. Updated configurable_model_flags.in and model_flags.F90 - CLUBB ticket #1102 (#1108)", "paths" : [ { "editType" : "edit", "file" : "model_flags.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90", "stats_zm_module.F90", "stats_variables.F90" ], "commitId" : "5256cf04633fd71551f6bd29ee0632494b611a93", "timestamp" : 1695154187000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Likely BIT_CHANGING because of added output fields. Added code outputting C6_term and different Brunt Vaisala frequencies to disk - CLUBB ticket #1102 (#1109)\u000a\u000a- Added C6_term and bv_freq fields to all_stats.F90 and standard_stats.F90\u000a- Added new fields to VariableGroupTaus.py in pyplotgen\u000a- Added calls to stat_update_var to advance_clubb_core_module.F90\u000a- Modified stats_variables.F90 and stats_zm_module.F90 accordingly\u000a", "date" : "2023-09-19 15:09:47 -0500", "id" : "5256cf04633fd71551f6bd29ee0632494b611a93", "msg" : "Likely BIT_CHANGING because of added output fields. Added code outputting C6_term and different Brunt Vaisala frequencies to disk - CLUBB ticket #1102 (#1109)", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "stats_zm_module.F90" }, { "editType" : "edit", "file" : "stats_variables.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mixing_length.F90", "advance_clubb_core_module.F90", "stats_zm_module.F90", "stats_variables.F90" ], "commitId" : "0735b8dca68da8eec17c24fca269223d8756e97a", "timestamp" : 1695421268000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Changed sqrt_Ri_zm to Ri_zm in preparation of changing the exponent for calculation of invrs_tau_wpxp_zm in mixing_length.F90 - CLUBB ticket #1102 (#1110)\u000a\u000aBIT_CHANGING! Changed sqrt_Ri_zm to Ri_zm in preparation of changing the exponent for calculation of invrs_tau_wpxp_zm in mixing_length.F90 - CLUBB ticket #1102\u000aChanges in input/stats/all_stats.in, src/CLUBB_core/advance_clubb_core_module.F90, src/CLUBB_core/mixing_length.F90, src/CLUBB_core/stats_variables.F90, and src/CLUBB_core/stats_zm_module.F90\u000aRi_zm was added to input/stats/standard_stats.in\u000a", "date" : "2023-09-22 17:21:08 -0500", "id" : "0735b8dca68da8eec17c24fca269223d8756e97a", "msg" : "Changed sqrt_Ri_zm to Ri_zm in preparation of changing the exponent for calculation of invrs_tau_wpxp_zm in mixing_length.F90 - CLUBB ticket #1102 (#1110)", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "stats_zm_module.F90" }, { "editType" : "edit", "file" : "stats_variables.F90" }, { "editType" : "edit", "file" : "mixing_length.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "stats_variables.F90", "stats_zm_module.F90", "advance_helper_module.F90" ], "commitId" : "62e535382820e1ebdd77dbb79de655e217e552d9", "timestamp" : 1695428333000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "BIT_CHANGING! Removed Richardson_num and all corresponding code - CLUBB ticket #1102 (#1111)\u000a\u000aThis commit is BIT_CHANGING because:\u000a1. the output field Richardson_num was removed.\u000a2. Since the flag l_use_shear_turb_freq_sqd was removed, the variable shear_sqd is now always written to disk. That means previously, the outputted field shear_sqd was 0 everywhere whereas now it is not anymore. The calculation of shear_sqd within CLUBB did not change!\u000a- Removed mentions in input/stats/all_stats.in and standards_stats.in\u000a- Removed mentions in src/CLUBB_core/stats_variables.F90 and stats_zm_module.F90\u000a- In src/CLUBB_core/advance_helper_module.F90 removed mentions to [i]Richardson_num[_clipped], as well as l_use_shear_turb_freq_sqd, l_Richardson_vert_avg, and turb_freq_sqd sinc those are only used for calculation of Richardson_num.\u000a", "date" : "2023-09-22 19:18:53 -0500", "id" : "62e535382820e1ebdd77dbb79de655e217e552d9", "msg" : "BIT_CHANGING! Removed Richardson_num and all corresponding code - CLUBB ticket #1102 (#1111)", "paths" : [ { "editType" : "edit", "file" : "stats_variables.F90" }, { "editType" : "edit", "file" : "stats_zm_module.F90" }, { "editType" : "edit", "file" : "advance_helper_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mixing_length.F90", "parameters_tunable.F90", "parameter_indices.F90", "clubb_api_module.F90" ], "commitId" : "4263da9f7ae792444654c9d5acefb27ba5db0e06", "timestamp" : 1697137474000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Tunable Richardson number exponent - CLUBB ticket #1102 (#1114)\u000a\u000aBIT_CHANGING! Added the exponent to the Richardson number in the calculation of the invrs_tau_wpxp threshold term in src/CLUBB_core/mixing_length.F90 to the list of tunable parameters.\u000aThis is bit changing due to the difference in Fortran between taking the sqrt and the .5th power.\u000a", "date" : "2023-10-12 14:04:34 -0500", "id" : "4263da9f7ae792444654c9d5acefb27ba5db0e06", "msg" : "Tunable Richardson number exponent - CLUBB ticket #1102 (#1114)", "paths" : [ { "editType" : "edit", "file" : "mixing_length.F90" }, { "editType" : "edit", "file" : "parameter_indices.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" }, { "editType" : "edit", "file" : "parameters_tunable.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "tunable_parameters.in" ], "commitId" : "e59f7732ad64c2330f9a51fe673a2c471c1d85f3", "timestamp" : 1697137474000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Tunable Richardson number exponent - CLUBB ticket #1102 (#1114)\u000a\u000aBIT_CHANGING! Added the exponent to the Richardson number in the calculation of the invrs_tau_wpxp threshold term in src/CLUBB_core/mixing_length.F90 to the list of tunable parameters.\u000aThis is bit changing due to the difference in Fortran between taking the sqrt and the .5th power.\u000a", "date" : "2023-10-12 14:04:34 -0500", "id" : "e59f7732ad64c2330f9a51fe673a2c471c1d85f3", "msg" : "Tunable Richardson number exponent - CLUBB ticket #1102 (#1114)", "paths" : [ { "editType" : "edit", "file" : "tunable_parameters.in" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SRC/CLUBB/advance_clubb_core_module.F90", "SRC/CLUBB/clubb_api_module.F90", "SRC/CLUBB/mixing_length.F90", "SRC/CLUBB/model_flags.F90", "SRC/CLUBB/advance_helper_module.F90", "SRC/CLUBB/parameter_indices.F90", "SRC/CLUBB/parameters_tunable.F90", "SRC/CLUBB/stats_variables.F90", "SRC/CLUBB/stats_zm_module.F90" ], "commitId" : "da7fedcbd01590aea425d6cffe7f60be0e1f1ca6", "timestamp" : 1697206669000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/root", "fullName" : "root" }, "authorEmail" : "root@carson.localdomain", "comment" : "Raw-copy updating SRC/CLUBB\u000a", "date" : "2023-10-13 09:17:49 -0500", "id" : "da7fedcbd01590aea425d6cffe7f60be0e1f1ca6", "msg" : "Raw-copy updating SRC/CLUBB", "paths" : [ { "editType" : "edit", "file" : "SRC/CLUBB/advance_helper_module.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/mixing_length.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/parameter_indices.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/parameters_tunable.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/clubb_api_module.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/stats_variables.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/stats_zm_module.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/model_flags.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "CLUBB_PARAMETERS/tunable_parameters.in" ], "commitId" : "a94a7af5f49efba3664f7c4ef423b0ebcf573ddd", "timestamp" : 1697206705000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/root", "fullName" : "root" }, "authorEmail" : "root@carson.localdomain", "comment" : "Raw-copy updating CLUBB_PARAMETERS\u000a", "date" : "2023-10-13 09:18:25 -0500", "id" : "a94a7af5f49efba3664f7c4ef423b0ebcf573ddd", "msg" : "Raw-copy updating CLUBB_PARAMETERS", "paths" : [ { "editType" : "edit", "file" : "CLUBB_PARAMETERS/tunable_parameters.in" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90" ], "commitId" : "1a7e15ee602ebadad150327e1e40ac59800ea1dc", "timestamp" : 1697555413000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Deletes svn id tag, will trigger host-model nightly tests.\u000a", "date" : "2023-10-17 10:10:13 -0500", "id" : "1a7e15ee602ebadad150327e1e40ac59800ea1dc", "msg" : "Deletes svn id tag, will trigger host-model nightly tests.", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SRC/CLUBB/advance_clubb_core_module.F90" ], "commitId" : "949f506868633f80741815c702d389d1eaf2c643", "timestamp" : 1697555534000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/larsongroupsysadmin", "fullName" : "LarsonGroupSysAdmin" }, "authorEmail" : "larsongroupgithub@gmail.com", "comment" : "Raw-copy updating SRC/CLUBB\u000a", "date" : "2023-10-17 10:12:14 -0500", "id" : "949f506868633f80741815c702d389d1eaf2c643", "msg" : "Raw-copy updating SRC/CLUBB", "paths" : [ { "editType" : "edit", "file" : "SRC/CLUBB/advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SRC/SGS_CLUBB/clubb_sgs.F90" ], "commitId" : "833289feb7ac2157c4ccf7e74b32313947cc17c5", "timestamp" : 1697570284000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/42725900+domkesteffen", "fullName" : "42725900+domkesteffen" }, "authorEmail" : "42725900+domkesteffen@users.noreply.github.com", "comment" : "Update clubb_sgs.F90\u000a\u000aAdded CLUBB parameter wpxp_Ri_exp\u000a", "date" : "2023-10-17 14:18:04 -0500", "id" : "833289feb7ac2157c4ccf7e74b32313947cc17c5", "msg" : "Update clubb_sgs.F90", "paths" : [ { "editType" : "edit", "file" : "SRC/SGS_CLUBB/clubb_sgs.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SRC/TIMING/t_stop.c", "SRC/cstuff.c" ], "commitId" : "d95570b09d8b83aa95560e42e4fd66b7e2899c32", "timestamp" : 1697663766000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Add library calls to allow SAM to compile with new icx intel compiler (#154)\u000a\u000a", "date" : "2023-10-18 16:16:06 -0500", "id" : "d95570b09d8b83aa95560e42e4fd66b7e2899c32", "msg" : "Add library calls to allow SAM to compile with new icx intel compiler (#154)", "paths" : [ { "editType" : "edit", "file" : "SRC/cstuff.c" }, { "editType" : "edit", "file" : "SRC/TIMING/t_stop.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_helper_module.F90" ], "commitId" : "8be88d0f94ca7883638a1e87415cb48dc0d03ca0", "timestamp" : 1697723854000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Remove svn id tag in order to trigger nightly tests.\u000a", "date" : "2023-10-19 08:57:34 -0500", "id" : "8be88d0f94ca7883638a1e87415cb48dc0d03ca0", "msg" : "Remove svn id tag in order to trigger nightly tests.", "paths" : [ { "editType" : "edit", "file" : "advance_helper_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_windm_edsclrm_module.F90" ], "commitId" : "ffdd91c97979046cdbe2f9502cb3047a482c6da7", "timestamp" : 1697732821000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Removed 3rd svn id tag in order to trigger nightly tests\u000a", "date" : "2023-10-19 11:27:01 -0500", "id" : "ffdd91c97979046cdbe2f9502cb3047a482c6da7", "msg" : "Removed 3rd svn id tag in order to trigger nightly tests", "paths" : [ { "editType" : "edit", "file" : "advance_windm_edsclrm_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "stats_variables.F90", "stats_clubb_utilities.F90", "clubb_api_module.F90" ], "commitId" : "9ca3f47f2c7361719136ed64975e29e55f893626", "timestamp" : 1698188257000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Finally removing scratch variables. (#1116)\u000a\u000a* Finally removing scratch variables.\u000a\u000a* Zeroing out below ground levels to prevent NaN in stats.\u000a", "date" : "2023-10-24 17:57:37 -0500", "id" : "9ca3f47f2c7361719136ed64975e29e55f893626", "msg" : "Finally removing scratch variables. (#1116)", "paths" : [ { "editType" : "edit", "file" : "stats_variables.F90" }, { "editType" : "edit", "file" : "stats_clubb_utilities.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mixing_length.F90" ], "commitId" : "22872a5139682034753065f97d05099ddf2e3a47", "timestamp" : 1698787332000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Latest batch of non-bit changing code changes - CLUBB ticket #1115 (#1119)\u000a\u000a- Added new folder input/tunable_parameters_tauMatchLscale/ for latest taus code setup reproducing the master Lscale output.\u000a- Changes in src/CLUBB_core_mixing_length.F90:\u000a - Renamed ddzt_umvm -> ddzt_umvm_sqd\u000a ddzt_umvm_clipped -> ddzt_umvm_sqd_clipped\u000a sqrt_ddzt_umvm -> norm_ddzt_umvm\u000a smooth_sqrt_ddzt_umvm -> smooth_norm_ddzt_umvm\u000a Ri_zm_clipped -> Ri_zm_smooth in some places\u000a - Made some variable replacements for consistency's sake\u000a- Fixed path of log files in run_scripts/run_bindiff_all.py\u000a", "date" : "2023-10-31 16:22:12 -0500", "id" : "22872a5139682034753065f97d05099ddf2e3a47", "msg" : "Latest batch of non-bit changing code changes - CLUBB ticket #1115 (#1119)", "paths" : [ { "editType" : "edit", "file" : "mixing_length.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90", "mixing_length.F90" ], "commitId" : "337f2b0a17376a45c2c1ac2250b6cff75f15d6ad", "timestamp" : 1698795774000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "BIT_CHANGING! Fixed some issues with wpxp_Ri_exp, changed z_displace value - CLUBB ticket #1115 (#1120)\u000a\u000a- Removed commented lines from tunable_parameters.in file in input/tunable_parameters_tauMatchLscale\u000a- Increased z_displace value from 10 to 25. This value was chosen so that the taus code with the parameter and flag settings in input/tunable_parameters_tauMatchLscale match the master Lscale output below clouds\u000a- Fixed some issues with the new parameter wpxp_Ri_exp:\u000a - Moved new exponentiation to a place so that it emulates the previous version with sqrt(Ri_zm)\u000a - Adjusted code for l_smooth_min_max=true to match the default version\u000a", "date" : "2023-10-31 18:42:54 -0500", "id" : "337f2b0a17376a45c2c1ac2250b6cff75f15d6ad", "msg" : "BIT_CHANGING! Fixed some issues with wpxp_Ri_exp, changed z_displace value - CLUBB ticket #1115 (#1120)", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "mixing_length.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "parameters_tunable.F90", "clubb_api_module.F90" ], "commitId" : "f7c02bb877ebac54c69c91bc0bbde80bb9f84360", "timestamp" : 1699478932000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "Updated CLUBB so that adj_low_res_nu (which can be called on its own\u000aor called through calling setup_parameters) no longer uses\u000amomentum_heights and thermodynamic_heights, but rather makes use\u000aof gr%zm and gr%zt, which are always set and available by the\u000atime the calls are made.\u000a", "date" : "2023-11-08 15:28:52 -0600", "id" : "f7c02bb877ebac54c69c91bc0bbde80bb9f84360", "msg" : "Updated CLUBB so that adj_low_res_nu (which can be called on its own", "paths" : [ { "editType" : "edit", "file" : "parameters_tunable.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SRC/SGS_CLUBB/clubb_sgs.F90" ], "commitId" : "e522e5115ef0c35a61e345d281508cabd4203d86", "timestamp" : 1699481853000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "Updated the CLUBB interface for recent changes to CLUBB.\u000a", "date" : "2023-11-08 16:17:33 -0600", "id" : "e522e5115ef0c35a61e345d281508cabd4203d86", "msg" : "Updated the CLUBB interface for recent changes to CLUBB.", "paths" : [ { "editType" : "edit", "file" : "SRC/SGS_CLUBB/clubb_sgs.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "grid_class.F90", "advance_clubb_core_module.F90", "clubb_api_module.F90" ], "commitId" : "6e985b7481ae287afeaf0a548e131482930840fe", "timestamp" : 1699486824000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "Removing begin_height and end_height as outputs from setup_grid. They\u000aare only necessary as local variables inside of setup_grid.\u000a", "date" : "2023-11-08 17:40:24 -0600", "id" : "6e985b7481ae287afeaf0a548e131482930840fe", "msg" : "Removing begin_height and end_height as outputs from setup_grid. They", "paths" : [ { "editType" : "edit", "file" : "grid_class.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SRC/SGS_CLUBB/clubb_sgs.F90" ], "commitId" : "933ddceb33a45238f8b639cdafca3bbe55c9c42a", "timestamp" : 1699487183000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "Updated for recent changes to CLUBB.\u000a", "date" : "2023-11-08 17:46:23 -0600", "id" : "933ddceb33a45238f8b639cdafca3bbe55c9c42a", "msg" : "Updated for recent changes to CLUBB.", "paths" : [ { "editType" : "edit", "file" : "SRC/SGS_CLUBB/clubb_sgs.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mixing_length.F90", "advance_clubb_core_module.F90", "parameters_tunable.F90", "parameter_indices.F90", "clubb_api_module.F90" ], "commitId" : "3e0adc18b4f8221be03da5e8670357090c34fd4d", "timestamp" : 1699563846000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Z displace tunable (#1122)\u000a\u000aCLUBB ticket #1115\u000aAdded the previously hard-coded z_displace as a tunable parameter.\u000a", "date" : "2023-11-09 15:04:06 -0600", "id" : "3e0adc18b4f8221be03da5e8670357090c34fd4d", "msg" : "Z displace tunable (#1122)", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "mixing_length.F90" }, { "editType" : "edit", "file" : "parameters_tunable.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" }, { "editType" : "edit", "file" : "parameter_indices.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "tunable_parameters.in" ], "commitId" : "9d0394c0b8514426c19c923d998fcc49675afecd", "timestamp" : 1699563846000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Z displace tunable (#1122)\u000a\u000aCLUBB ticket #1115\u000aAdded the previously hard-coded z_displace as a tunable parameter.\u000a", "date" : "2023-11-09 15:04:06 -0600", "id" : "9d0394c0b8514426c19c923d998fcc49675afecd", "msg" : "Z displace tunable (#1122)", "paths" : [ { "editType" : "edit", "file" : "tunable_parameters.in" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SRC/SGS_CLUBB/clubb_sgs.F90" ], "commitId" : "dbb2eecd8b43407d03d1901934aa82fbefcc452e", "timestamp" : 1699563926000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/42725900+domkesteffen", "fullName" : "42725900+domkesteffen" }, "authorEmail" : "42725900+domkesteffen@users.noreply.github.com", "comment" : "Update clubb_sgs.F90\u000a\u000aAdded z_displace as new tunable parameter\u000a", "date" : "2023-11-09 15:05:26 -0600", "id" : "dbb2eecd8b43407d03d1901934aa82fbefcc452e", "msg" : "Update clubb_sgs.F90", "paths" : [ { "editType" : "edit", "file" : "SRC/SGS_CLUBB/clubb_sgs.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SRC/SGS_CLUBB/sgs.F90", "SRC/main.F90", "SRC/setdata_module.F90", "SRC/SGS_CLUBB/clubb_sgs.F90" ], "commitId" : "1b990bc8ffd1260539b810327a7833de5ef9f61f", "timestamp" : 1699655582000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Making work with latest clubb changes.\u000a", "date" : "2023-11-10 16:33:02 -0600", "id" : "1b990bc8ffd1260539b810327a7833de5ef9f61f", "msg" : "Making work with latest clubb changes.", "paths" : [ { "editType" : "edit", "file" : "SRC/SGS_CLUBB/sgs.F90" }, { "editType" : "edit", "file" : "SRC/main.F90" }, { "editType" : "edit", "file" : "SRC/setdata_module.F90" }, { "editType" : "edit", "file" : "SRC/SGS_CLUBB/clubb_sgs.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SRC/SGS_CLUBB/sgs.F90", "SRC/main.F90", "SRC/setdata_module.F90", "SRC/SGS_CLUBB/clubb_sgs.F90" ], "commitId" : "c42bb744c90f9095306a9dbb3f6b43c52d81ca37", "timestamp" : 1699660105000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Changing stat_indices to stats_metadata_type\u000a", "date" : "2023-11-10 17:48:25 -0600", "id" : "c42bb744c90f9095306a9dbb3f6b43c52d81ca37", "msg" : "Changing stat_indices to stats_metadata_type", "paths" : [ { "editType" : "edit", "file" : "SRC/SGS_CLUBB/sgs.F90" }, { "editType" : "edit", "file" : "SRC/SGS_CLUBB/clubb_sgs.F90" }, { "editType" : "edit", "file" : "SRC/main.F90" }, { "editType" : "edit", "file" : "SRC/setdata_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "clubb_api_module.F90", "clip_explicit.F90", "advance_xm_wpxp_module.F90", "stats_lh_zt_module.F90", "stats_type_utilities.F90", "setup_clubb_pdf_params.F90", "advance_windm_edsclrm_module.F90", "advance_helper_module.F90", "mono_flux_limiter.F90", "mixing_length.F90", "advance_wp2_wp3_module.F90", "advance_xp2_xpyp_module.F90", "output_grads.F90", "stats_rad_zm_module.F90", "stats_rad_zt_module.F90", "pdf_closure_module.F90", "precipitation_fraction.F90", "numerical_check.F90", "stats_lh_sfc_module.F90", "stats_variables.F90", "advance_clubb_core_module.F90", "advance_xp3_module.F90", "stats_zt_module.F90", "fill_holes.F90", "stats_sfc_module.F90", "stats_clubb_utilities.F90", "stats_zm_module.F90", "sfc_varnce_module.F90" ], "commitId" : "0eb82e3d60c5fd567e1f24a0015d2c6fd8f21069", "timestamp" : 1699661720000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "New Stats Indices Type (#1118)\u000a\u000a* Grouping stats indices into a derived type and making that accessible globally, for now. This does not run yet, but a checkpoint I wish to save.\u000a\u000a* Checkpoint to save\u000a\u000a* Checkpoint\u000a\u000a* It actually works now and is BFB with every case.\u000a\u000a* Starting to push the new derived type through the argument list.\u000a\u000a* The new dervied type, now stats_metadata, has been fed through the argument list.\u000a\u000a* Moved l_stats_samp into stats_metadata\u000a\u000a* Moved all the other stats_variables into stats_metadata\u000a\u000a* Small cleanup\u000a\u000a* Fixes a stats bug when calling compute_sample_mean in silhs.\u000a\u000a* Arrays in stats_metadata need only be allocated once, but we may want to call the stats init routines to set up more stats variables. So now we check for allocation before allocating. Also made the stat_indices type publicly available through clubb_api.\u000a\u000a* This should be initialized to 0. The new changes in cam were able to tease this out, which is a good sign.\u000a\u000a* A couple more to initialize to zero.\u000a\u000a* Moving stats_metadata to before stats_ variables in argument lists, just for consistency.\u000a\u000a* Changing stat_indices to stats_metadata_type\u000a", "date" : "2023-11-10 18:15:20 -0600", "id" : "0eb82e3d60c5fd567e1f24a0015d2c6fd8f21069", "msg" : "New Stats Indices Type (#1118)", "paths" : [ { "editType" : "edit", "file" : "setup_clubb_pdf_params.F90" }, { "editType" : "edit", "file" : "stats_type_utilities.F90" }, { "editType" : "edit", "file" : "precipitation_fraction.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" }, { "editType" : "edit", "file" : "advance_helper_module.F90" }, { "editType" : "edit", "file" : "mixing_length.F90" }, { "editType" : "edit", "file" : "sfc_varnce_module.F90" }, { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "clip_explicit.F90" }, { "editType" : "edit", "file" : "pdf_closure_module.F90" }, { "editType" : "edit", "file" : "stats_rad_zm_module.F90" }, { "editType" : "edit", "file" : "stats_zt_module.F90" }, { "editType" : "edit", "file" : "advance_windm_edsclrm_module.F90" }, { "editType" : "edit", "file" : "output_grads.F90" }, { "editType" : "edit", "file" : "stats_variables.F90" }, { "editType" : "edit", "file" : "stats_lh_sfc_module.F90" }, { "editType" : "edit", "file" : "fill_holes.F90" }, { "editType" : "edit", "file" : "stats_clubb_utilities.F90" }, { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" }, { "editType" : "edit", "file" : "numerical_check.F90" }, { "editType" : "edit", "file" : "stats_rad_zt_module.F90" }, { "editType" : "edit", "file" : "stats_sfc_module.F90" }, { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" }, { "editType" : "edit", "file" : "advance_xp3_module.F90" }, { "editType" : "edit", "file" : "stats_lh_zt_module.F90" }, { "editType" : "edit", "file" : "mono_flux_limiter.F90" }, { "editType" : "edit", "file" : "stats_zm_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "silhs_api_module.F90", "output_2D_samples_module.F90", "latin_hypercube_driver_module.F90" ], "commitId" : "1fff41b95831158920098a46667c5bee20b406fd", "timestamp" : 1699661720000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "New Stats Indices Type (#1118)\u000a\u000a* Grouping stats indices into a derived type and making that accessible globally, for now. This does not run yet, but a checkpoint I wish to save.\u000a\u000a* Checkpoint to save\u000a\u000a* Checkpoint\u000a\u000a* It actually works now and is BFB with every case.\u000a\u000a* Starting to push the new derived type through the argument list.\u000a\u000a* The new dervied type, now stats_metadata, has been fed through the argument list.\u000a\u000a* Moved l_stats_samp into stats_metadata\u000a\u000a* Moved all the other stats_variables into stats_metadata\u000a\u000a* Small cleanup\u000a\u000a* Fixes a stats bug when calling compute_sample_mean in silhs.\u000a\u000a* Arrays in stats_metadata need only be allocated once, but we may want to call the stats init routines to set up more stats variables. So now we check for allocation before allocating. Also made the stat_indices type publicly available through clubb_api.\u000a\u000a* This should be initialized to 0. The new changes in cam were able to tease this out, which is a good sign.\u000a\u000a* A couple more to initialize to zero.\u000a\u000a* Moving stats_metadata to before stats_ variables in argument lists, just for consistency.\u000a\u000a* Changing stat_indices to stats_metadata_type\u000a", "date" : "2023-11-10 18:15:20 -0600", "id" : "1fff41b95831158920098a46667c5bee20b406fd", "msg" : "New Stats Indices Type (#1118)", "paths" : [ { "editType" : "edit", "file" : "output_2D_samples_module.F90" }, { "editType" : "edit", "file" : "latin_hypercube_driver_module.F90" }, { "editType" : "edit", "file" : "silhs_api_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "Skx_module.F90" ], "commitId" : "94ceac8b9273b15c668961304300e0f042f9844c", "timestamp" : 1699991156000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Changing order of sqrt and **3 to improve stability, see clubb#1126. Since this is a change to the order of operations, it is BIT_CHANGING.\u000a", "date" : "2023-11-14 13:45:56 -0600", "id" : "94ceac8b9273b15c668961304300e0f042f9844c", "msg" : "Changing order of sqrt and **3 to improve stability, see clubb#1126. Since this is a change to the order of operations, it is BIT_CHANGING.", "paths" : [ { "editType" : "edit", "file" : "Skx_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "constants_clubb.F90" ], "commitId" : "80f7ee00a316e443c95eeb822d14eb5ba4b10b83", "timestamp" : 1699995955000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Setting the minimum tolerance to be epsilon, this is BIT_CHANGING but only for single precision. See larson-group/clubb#1126\u000a", "date" : "2023-11-14 15:05:55 -0600", "id" : "80f7ee00a316e443c95eeb822d14eb5ba4b10b83", "msg" : "Setting the minimum tolerance to be epsilon, this is BIT_CHANGING but only for single precision. See larson-group/clubb#1126", "paths" : [ { "editType" : "edit", "file" : "constants_clubb.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mixing_length.F90" ], "commitId" : "55b6329613ecf69fa8cd632b83ddc2dbf60f6471", "timestamp" : 1699997980000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "BIT_CHANGING! Updated taus code calculations - CLUBB ticket #1115 (#1125)\u000a\u000a- Changed invrs_tau_xp2/wp2 calculations to match the wpxp calculation:\u000a Those now have a brunt_freq_pos and a brunt_freq_out_cloud term\u000a- Changed tmp_calc magic number from .007 to .001\u000a- Changed upper clipping bound for Ri_zm from 12 to 2 in invrs_tau_wpxp calculation\u000a- Reversed accidental changes to input_misc/tuner/error_four_cases.in\u000a", "date" : "2023-11-14 15:39:40 -0600", "id" : "55b6329613ecf69fa8cd632b83ddc2dbf60f6471", "msg" : "BIT_CHANGING! Updated taus code calculations - CLUBB ticket #1115 (#1125)", "paths" : [ { "editType" : "edit", "file" : "mixing_length.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mixing_length.F90", "advance_clubb_core_module.F90", "advance_helper_module.F90" ], "commitId" : "71caa87dc4bf283982e72d7a5d548f0e19d36ca7", "timestamp" : 1700177490000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Added non-trapezoidal zm interpolation for cloud_frac (#1127)\u000a\u000a- Added a calculation for `cloud_frac_zm` when `l_call_pdf_closure_twice=false` and `l_trapezoidal_rule_zt=false`\u000aThis is BIT_CHANGING if `l_call_pdf_closure_twice=false` and `l_trapezoidal_rule_zt=false` since, in that case, `cloud_frac_zm` is now nonzero.\u000a- Some minor formatting fixes\u000a- Some minor fixes to pyplotgen's source code\u000a- Added `a3_coef_min` to Lscale tunable_parameters.in\u000a", "date" : "2023-11-16 17:31:30 -0600", "id" : "71caa87dc4bf283982e72d7a5d548f0e19d36ca7", "msg" : "Added non-trapezoidal zm interpolation for cloud_frac (#1127)", "paths" : [ { "editType" : "edit", "file" : "mixing_length.F90" }, { "editType" : "edit", "file" : "advance_helper_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mixing_length.F90" ], "commitId" : "46dce38d9a340446c91e745aeb1cc059437e2d95", "timestamp" : 1701198848000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/sdomke", "fullName" : "Steffen Domke" }, "authorEmail" : "sdomke@uwm.edu", "comment" : "Re-adjusted cap for invrs_tau_wpxp in src/CLUBB_core/mixing_length.F90\u000aBIT_CHANGING! CLUBB ticket #1115\u000a", "date" : "2023-11-28 13:14:08 -0600", "id" : "46dce38d9a340446c91e745aeb1cc059437e2d95", "msg" : "Re-adjusted cap for invrs_tau_wpxp in src/CLUBB_core/mixing_length.F90", "paths" : [ { "editType" : "edit", "file" : "mixing_length.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_wp2_wp3_module.F90" ], "commitId" : "22b99ad5e75002985bbb982a508764c345927aec", "timestamp" : 1702052124000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/griffinb", "fullName" : "Brian Griffin" }, "authorEmail" : "31553422+bmg929@users.noreply.github.com", "comment" : "Adding boundary conditions for the wp3_term_ta_ADG1_lhs subroutine.\u000aThe value of wp3_zm at the model lower and upper boundaries is now\u000aassumed to be 0 for simplicity and conservation.\u000a", "date" : "2023-12-08 10:15:24 -0600", "id" : "22b99ad5e75002985bbb982a508764c345927aec", "msg" : "Adding boundary conditions for the wp3_term_ta_ADG1_lhs subroutine.", "paths" : [ { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_wp2_wp3_module.F90" ], "commitId" : "961f848884a3fce181c64c6c0ddc3fa73c33120e", "timestamp" : 1702052124000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/griffinb", "fullName" : "Brian Griffin" }, "authorEmail" : "31553422+bmg929@users.noreply.github.com", "comment" : "For single loop vectors, removing the \"collapse(2)\" from the acc statements.\u000a\u000aThis commit is not bit changing, but the previous commit to this branch\u000awas BIT_CHANGING:902d6caed8a4533f59f4165106276959b4f90895\u000a", "date" : "2023-12-08 10:15:24 -0600", "id" : "961f848884a3fce181c64c6c0ddc3fa73c33120e", "msg" : "For single loop vectors, removing the \"collapse(2)\" from the acc statements.", "paths" : [ { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mixing_length.F90", "stats_zm_module.F90", "stats_variables.F90", "advance_clubb_core_module.F90" ], "commitId" : "3ba52c6cb91becf07a3cd181ae018428675298bd", "timestamp" : 1702424778000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/vlarson", "fullName" : "Vince Larson" }, "authorEmail" : "vlarson@users.noreply.github.com", "comment" : "Added new Brunt-Väisälä frequency plots to pyplotgen's VariableGroupTaus\u000aCLUBB ticket #1132, BIT_CHANGING because new output fields were added\u000a- Added 3 new Brunt-Väisälä output fields:\u000a - bv_freq_sqd_smth: The smoothed bv_mixed which is used to calculate the invrs_taus\u000a - bv_freq_pos: The positive part of the sqrt of bv_freq_sqd_smth\u000a - bv_freq_out_cloud: The out-of-cloud part of bv_freq_pos\u000a- Added the plots of those fields to VariableGroupTaus\u000a", "date" : "2023-12-12 17:46:18 -0600", "id" : "3ba52c6cb91becf07a3cd181ae018428675298bd", "msg" : "Added new Brunt-Väisälä frequency plots to pyplotgen's VariableGroupTaus", "paths" : [ { "editType" : "edit", "file" : "mixing_length.F90" }, { "editType" : "edit", "file" : "stats_zm_module.F90" }, { "editType" : "edit", "file" : "stats_variables.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90" ], "commitId" : "59de6e143a1bdbf3e43d13f67d71deb63affdde2", "timestamp" : 1702425732000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Adds commas to fix bug\u000a", "date" : "2023-12-12 18:02:12 -0600", "id" : "59de6e143a1bdbf3e43d13f67d71deb63affdde2", "msg" : "Adds commas to fix bug", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "diffusion.F90" ], "commitId" : "20d6130562d60f6c2c17972cdc5a81de5dacd861", "timestamp" : 1702943185000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/griffinb", "fullName" : "Brian Griffin" }, "authorEmail" : "31553422+bmg929@users.noreply.github.com", "comment" : "Updating the code to set the bottom of the thermodynamic level grid for\u000adiffusion at thermodynamic level 2 -- the first level above the surface.\u000a\u000aThis is being done in preparation for ghostless gridding.\u000a", "date" : "2023-12-18 17:46:25 -0600", "id" : "20d6130562d60f6c2c17972cdc5a81de5dacd861", "msg" : "Updating the code to set the bottom of the thermodynamic level grid for", "paths" : [ { "editType" : "edit", "file" : "diffusion.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_wp2_wp3_module.F90" ], "commitId" : "cebdb21aff77c08197f427a89df4712ee1fa5de0", "timestamp" : 1702943185000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/griffinb", "fullName" : "Brian Griffin" }, "authorEmail" : "31553422+bmg929@users.noreply.github.com", "comment" : "Commit to enforce a fixed-point boundary condition of wp3=0 at\u000athermodynamic level k = 2, the first above-ground thermodynamic level.\u000a\u000aThis is being done in preparation for ghostless gridding.\u000a\u000aThis commit is BIT_CHANGING.\u000a\u000aResults are much more similar to the previous results than using\u000ausing zero-flux as the lower boundary condition for wp3.\u000a", "date" : "2023-12-18 17:46:25 -0600", "id" : "cebdb21aff77c08197f427a89df4712ee1fa5de0", "msg" : "Commit to enforce a fixed-point boundary condition of wp3=0 at", "paths" : [ { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_wp2_wp3_module.F90" ], "commitId" : "39e110e1e0d3a674a66ff616a403f81f470fa877", "timestamp" : 1703174134000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "With wp3 now being set to a fixed-point boundary condition value\u000aof 0 at the current thermodynamic level 2 (first t-lev above the\u000asurface), it is not necessary to loop over level 2 within the code\u000afor each wp3 term.\u000a\u000aThis commit is BIT_CHANGING, but only for the wp3 budget terms\u000a(e.g. wp3_ta) in the zt output file at level k = 2. It doesn't change\u000athe actual answer. All other variables are bit-for-bit identical.\u000a", "date" : "2023-12-21 09:55:34 -0600", "id" : "39e110e1e0d3a674a66ff616a403f81f470fa877", "msg" : "With wp3 now being set to a fixed-point boundary condition value", "paths" : [ { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "clubb_api_module.F90", "clip_explicit.F90", "advance_xm_wpxp_module.F90", "diagnose_correlations_module.F90", "setup_clubb_pdf_params.F90", "advance_windm_edsclrm_module.F90", "advance_helper_module.F90", "mixing_length.F90", "advance_xp2_xpyp_module.F90", "error_code.F90", "pdf_closure_module.F90", "adg1_adg2_3d_luhar_pdf.F90", "new_hybrid_pdf_main.F90", "corr_varnce_module.F90", "precipitation_fraction.F90", "index_mapping.F90", "model_flags.F90", "numerical_check.F90", "output_netcdf.F90", "stat_file_module.F90", "sponge_layer_damping.F90", "array_index.F90", "saturation.F90", "advance_clubb_core_module.F90", "advance_xp3_module.F90", "stats_zt_module.F90", "fill_holes.F90", "stats_zm_module.F90", "stats_clubb_utilities.F90", "parameters_model.F90", "sfc_varnce_module.F90" ], "commitId" : "69a0500429869014c93503d18cff3ccfd516dc6d", "timestamp" : 1704332198000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Threadpublic (#1133)\u000a\u000a* Initial threadprivate removals and simple changes.\u000a\u000a* model flags update, incomplete\u000a\u000a* Some updates, almost working\u000a\u000a* Added saturation_formula and l_host_applies_sfc_fluxes to clubb_config_flags\u000a\u000a* Accompanying changes to flags lists\u000a\u000a* Changes to corrrelation array setup\u000a\u000a* Adding more flag checking\u000a\u000a* Forgot to set l_host_applies_sfc_fluxes in initialize_clubb_config_flags_type and commit adding l_implemented to the argument loit\u000a\u000a* Adding saturation parameters to api\u000a\u000a* Most of the way through passing sclr_dim, hydromet_dim, edsclr_dim, and sclr_tol through arguemnt lists. Moved first_write breaking silhs stats aparently, and bit changing due to the way we were writing sclr_tol for cases that have sclr_dim=0 (arm different, gabls2 BFB).\u000a\u000a* Removing accidentally commited files.\u000a\u000a* Fixed silhs output, all cases BFB but sclr_tol is saved differently to stats files in cases where sclr_dim = 0, so this is bc also bc:fb20458d5212b007c79c17613201af637bbc3d7e since that introduced the difference.\u000a\u000a* Changing stats logicals back to false, only set to true for testing. So technically BIT_CHANGING\u000a\u000a* Starting array_vars changes.\u000a\u000a* No more global scalar indices\u000a\u000a* Starting to remove hydromet indices\u000a\u000a* Finished the annoying part with the microphysics interfaces.\u000a\u000a* No more global variables in array_index. All cases BFB relative to last commit.\u000a\u000a* No more global pdf_dim, Ncnp2_on_Ncnm2 now set via argument list, and added temporary hydromet_dim_glob because I thought it would fix a bug but it didn't, it might in the future though, so I left it in for now, it will be removed soon.\u000a\u000a* Added nan checking before overriding default value for Ncnp2_on_Ncnm2\u000a\u000a* Finished hydromet_dim argument listing and removed global versions of it as well as sclr_dim, edsclr_dim, and sclr_tol.\u000a\u000a* open_netcdf_for_writing does nothing if nvars=0 for a stats file, which is understandable, but now that we call first_write immediately after we need that also to check for nvar=0\u000a\u000a* Adding better error messages to stats_init\u000a\u000a* The nvidia compiler does not like zero size arrays.\u000a\u000a* Adding defaults for scalar arrays values in clubb driver, and adding an error check after calling stats_init.\u000a\u000a* Reverting accidental changes to clubb_thread_test\u000a\u000a* Changing name of scarr/scalar_array to sclr_idx and hydromet_array to hm_metadata\u000a\u000a* Adding new types to _api\u000a\u000a* Fixing erroneous name changes.\u000a\u000a* Fixing bug introduced in 65987c8a77496f7bb10bfd28717345b1f63de1b7\u000a\u000a* Removing print\u000a\u000a* QuadTune: updates setup in order to read in 30x30\u000aregional files automatically.\u000a\u000aFor #910.\u000a\u000a* Updating the code to set the bottom of the thermodynamic level grid for\u000adiffusion at thermodynamic level 2 -- the first level above the surface.\u000a\u000aThis is being done in preparation for ghostless gridding.\u000a\u000a* Commit to enforce a fixed-point boundary condition of wp3=0 at\u000athermodynamic level k = 2, the first above-ground thermodynamic level.\u000a\u000aThis is being done in preparation for ghostless gridding.\u000a\u000aThis commit is bc.\u000a\u000aResults are much more similar to the previous results than using\u000ausing zero-flux as the lower boundary condition for wp3.\u000a\u000a* With wp3 now being set to a fixed-point boundary condition value\u000aof 0 at the current thermodynamic level 2 (first t-lev above the\u000asurface), it is not necessary to loop over level 2 within the code\u000afor each wp3 term.\u000a\u000aThis commit is BIT_CHANGING, but only for the wp3 budget terms\u000a(e.g. wp3_ta) in the zt output file at level k = 2. It doesn't change\u000athe actual answer. All other variables are bit-for-bit identical.\u000a\u000a* Removing omp parallel test line\u000a\u000a* Removing parameter declarion around l_quintic_poly_interp. Having this be a parameter causes bit changes when using -O2\u000a\u000a---------\u000a\u000aCo-authored-by: vlarson \u000aCo-authored-by: bmg929 \u000a", "date" : "2024-01-03 19:36:38 -0600", "id" : "69a0500429869014c93503d18cff3ccfd516dc6d", "msg" : "Threadpublic (#1133)", "paths" : [ { "editType" : "edit", "file" : "parameters_model.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "corr_varnce_module.F90" }, { "editType" : "edit", "file" : "sponge_layer_damping.F90" }, { "editType" : "edit", "file" : "array_index.F90" }, { "editType" : "edit", "file" : "output_netcdf.F90" }, { "editType" : "edit", "file" : "error_code.F90" }, { "editType" : "edit", "file" : "stat_file_module.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" }, { "editType" : "edit", "file" : "diagnose_correlations_module.F90" }, { "editType" : "edit", "file" : "stats_zm_module.F90" }, { "editType" : "edit", "file" : "numerical_check.F90" }, { "editType" : "edit", "file" : "precipitation_fraction.F90" }, { "editType" : "edit", "file" : "stats_zt_module.F90" }, { "editType" : "edit", "file" : "advance_windm_edsclrm_module.F90" }, { "editType" : "edit", "file" : "index_mapping.F90" }, { "editType" : "edit", "file" : "adg1_adg2_3d_luhar_pdf.F90" }, { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" }, { "editType" : "edit", "file" : "advance_xp3_module.F90" }, { "editType" : "edit", "file" : "mixing_length.F90" }, { "editType" : "edit", "file" : "model_flags.F90" }, { "editType" : "edit", "file" : "clip_explicit.F90" }, { "editType" : "edit", "file" : "stats_clubb_utilities.F90" }, { "editType" : "edit", "file" : "setup_clubb_pdf_params.F90" }, { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" }, { "editType" : "edit", "file" : "advance_helper_module.F90" }, { "editType" : "edit", "file" : "fill_holes.F90" }, { "editType" : "edit", "file" : "pdf_closure_module.F90" }, { "editType" : "edit", "file" : "saturation.F90" }, { "editType" : "edit", "file" : "new_hybrid_pdf_main.F90" }, { "editType" : "edit", "file" : "sfc_varnce_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "configurable_model_flags.in" ], "commitId" : "35fc46d7836554463c61b24ac2d907be78a99d0a", "timestamp" : 1704332198000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Threadpublic (#1133)\u000a\u000a* Initial threadprivate removals and simple changes.\u000a\u000a* model flags update, incomplete\u000a\u000a* Some updates, almost working\u000a\u000a* Added saturation_formula and l_host_applies_sfc_fluxes to clubb_config_flags\u000a\u000a* Accompanying changes to flags lists\u000a\u000a* Changes to corrrelation array setup\u000a\u000a* Adding more flag checking\u000a\u000a* Forgot to set l_host_applies_sfc_fluxes in initialize_clubb_config_flags_type and commit adding l_implemented to the argument loit\u000a\u000a* Adding saturation parameters to api\u000a\u000a* Most of the way through passing sclr_dim, hydromet_dim, edsclr_dim, and sclr_tol through arguemnt lists. Moved first_write breaking silhs stats aparently, and bit changing due to the way we were writing sclr_tol for cases that have sclr_dim=0 (arm different, gabls2 BFB).\u000a\u000a* Removing accidentally commited files.\u000a\u000a* Fixed silhs output, all cases BFB but sclr_tol is saved differently to stats files in cases where sclr_dim = 0, so this is bc also bc:fb20458d5212b007c79c17613201af637bbc3d7e since that introduced the difference.\u000a\u000a* Changing stats logicals back to false, only set to true for testing. So technically BIT_CHANGING\u000a\u000a* Starting array_vars changes.\u000a\u000a* No more global scalar indices\u000a\u000a* Starting to remove hydromet indices\u000a\u000a* Finished the annoying part with the microphysics interfaces.\u000a\u000a* No more global variables in array_index. All cases BFB relative to last commit.\u000a\u000a* No more global pdf_dim, Ncnp2_on_Ncnm2 now set via argument list, and added temporary hydromet_dim_glob because I thought it would fix a bug but it didn't, it might in the future though, so I left it in for now, it will be removed soon.\u000a\u000a* Added nan checking before overriding default value for Ncnp2_on_Ncnm2\u000a\u000a* Finished hydromet_dim argument listing and removed global versions of it as well as sclr_dim, edsclr_dim, and sclr_tol.\u000a\u000a* open_netcdf_for_writing does nothing if nvars=0 for a stats file, which is understandable, but now that we call first_write immediately after we need that also to check for nvar=0\u000a\u000a* Adding better error messages to stats_init\u000a\u000a* The nvidia compiler does not like zero size arrays.\u000a\u000a* Adding defaults for scalar arrays values in clubb driver, and adding an error check after calling stats_init.\u000a\u000a* Reverting accidental changes to clubb_thread_test\u000a\u000a* Changing name of scarr/scalar_array to sclr_idx and hydromet_array to hm_metadata\u000a\u000a* Adding new types to _api\u000a\u000a* Fixing erroneous name changes.\u000a\u000a* Fixing bug introduced in 65987c8a77496f7bb10bfd28717345b1f63de1b7\u000a\u000a* Removing print\u000a\u000a* QuadTune: updates setup in order to read in 30x30\u000aregional files automatically.\u000a\u000aFor #910.\u000a\u000a* Updating the code to set the bottom of the thermodynamic level grid for\u000adiffusion at thermodynamic level 2 -- the first level above the surface.\u000a\u000aThis is being done in preparation for ghostless gridding.\u000a\u000a* Commit to enforce a fixed-point boundary condition of wp3=0 at\u000athermodynamic level k = 2, the first above-ground thermodynamic level.\u000a\u000aThis is being done in preparation for ghostless gridding.\u000a\u000aThis commit is bc.\u000a\u000aResults are much more similar to the previous results than using\u000ausing zero-flux as the lower boundary condition for wp3.\u000a\u000a* With wp3 now being set to a fixed-point boundary condition value\u000aof 0 at the current thermodynamic level 2 (first t-lev above the\u000asurface), it is not necessary to loop over level 2 within the code\u000afor each wp3 term.\u000a\u000aThis commit is BIT_CHANGING, but only for the wp3 budget terms\u000a(e.g. wp3_ta) in the zt output file at level k = 2. It doesn't change\u000athe actual answer. All other variables are bit-for-bit identical.\u000a\u000a* Removing omp parallel test line\u000a\u000a* Removing parameter declarion around l_quintic_poly_interp. Having this be a parameter causes bit changes when using -O2\u000a\u000a---------\u000a\u000aCo-authored-by: vlarson \u000aCo-authored-by: bmg929 \u000a", "date" : "2024-01-03 19:36:38 -0600", "id" : "35fc46d7836554463c61b24ac2d907be78a99d0a", "msg" : "Threadpublic (#1133)", "paths" : [ { "editType" : "edit", "file" : "configurable_model_flags.in" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "silhs_api_module.F90", "silhs_importance_sample_module.F90", "transform_to_pdf_module.F90", "latin_hypercube_driver_module.F90", "output_2D_samples_module.F90" ], "commitId" : "14c8636ab5c46f3f20204fae38b1eeb765bc804c", "timestamp" : 1704332198000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Threadpublic (#1133)\u000a\u000a* Initial threadprivate removals and simple changes.\u000a\u000a* model flags update, incomplete\u000a\u000a* Some updates, almost working\u000a\u000a* Added saturation_formula and l_host_applies_sfc_fluxes to clubb_config_flags\u000a\u000a* Accompanying changes to flags lists\u000a\u000a* Changes to corrrelation array setup\u000a\u000a* Adding more flag checking\u000a\u000a* Forgot to set l_host_applies_sfc_fluxes in initialize_clubb_config_flags_type and commit adding l_implemented to the argument loit\u000a\u000a* Adding saturation parameters to api\u000a\u000a* Most of the way through passing sclr_dim, hydromet_dim, edsclr_dim, and sclr_tol through arguemnt lists. Moved first_write breaking silhs stats aparently, and bit changing due to the way we were writing sclr_tol for cases that have sclr_dim=0 (arm different, gabls2 BFB).\u000a\u000a* Removing accidentally commited files.\u000a\u000a* Fixed silhs output, all cases BFB but sclr_tol is saved differently to stats files in cases where sclr_dim = 0, so this is bc also bc:fb20458d5212b007c79c17613201af637bbc3d7e since that introduced the difference.\u000a\u000a* Changing stats logicals back to false, only set to true for testing. So technically BIT_CHANGING\u000a\u000a* Starting array_vars changes.\u000a\u000a* No more global scalar indices\u000a\u000a* Starting to remove hydromet indices\u000a\u000a* Finished the annoying part with the microphysics interfaces.\u000a\u000a* No more global variables in array_index. All cases BFB relative to last commit.\u000a\u000a* No more global pdf_dim, Ncnp2_on_Ncnm2 now set via argument list, and added temporary hydromet_dim_glob because I thought it would fix a bug but it didn't, it might in the future though, so I left it in for now, it will be removed soon.\u000a\u000a* Added nan checking before overriding default value for Ncnp2_on_Ncnm2\u000a\u000a* Finished hydromet_dim argument listing and removed global versions of it as well as sclr_dim, edsclr_dim, and sclr_tol.\u000a\u000a* open_netcdf_for_writing does nothing if nvars=0 for a stats file, which is understandable, but now that we call first_write immediately after we need that also to check for nvar=0\u000a\u000a* Adding better error messages to stats_init\u000a\u000a* The nvidia compiler does not like zero size arrays.\u000a\u000a* Adding defaults for scalar arrays values in clubb driver, and adding an error check after calling stats_init.\u000a\u000a* Reverting accidental changes to clubb_thread_test\u000a\u000a* Changing name of scarr/scalar_array to sclr_idx and hydromet_array to hm_metadata\u000a\u000a* Adding new types to _api\u000a\u000a* Fixing erroneous name changes.\u000a\u000a* Fixing bug introduced in 65987c8a77496f7bb10bfd28717345b1f63de1b7\u000a\u000a* Removing print\u000a\u000a* QuadTune: updates setup in order to read in 30x30\u000aregional files automatically.\u000a\u000aFor #910.\u000a\u000a* Updating the code to set the bottom of the thermodynamic level grid for\u000adiffusion at thermodynamic level 2 -- the first level above the surface.\u000a\u000aThis is being done in preparation for ghostless gridding.\u000a\u000a* Commit to enforce a fixed-point boundary condition of wp3=0 at\u000athermodynamic level k = 2, the first above-ground thermodynamic level.\u000a\u000aThis is being done in preparation for ghostless gridding.\u000a\u000aThis commit is bc.\u000a\u000aResults are much more similar to the previous results than using\u000ausing zero-flux as the lower boundary condition for wp3.\u000a\u000a* With wp3 now being set to a fixed-point boundary condition value\u000aof 0 at the current thermodynamic level 2 (first t-lev above the\u000asurface), it is not necessary to loop over level 2 within the code\u000afor each wp3 term.\u000a\u000aThis commit is BIT_CHANGING, but only for the wp3 budget terms\u000a(e.g. wp3_ta) in the zt output file at level k = 2. It doesn't change\u000athe actual answer. All other variables are bit-for-bit identical.\u000a\u000a* Removing omp parallel test line\u000a\u000a* Removing parameter declarion around l_quintic_poly_interp. Having this be a parameter causes bit changes when using -O2\u000a\u000a---------\u000a\u000aCo-authored-by: vlarson \u000aCo-authored-by: bmg929 \u000a", "date" : "2024-01-03 19:36:38 -0600", "id" : "14c8636ab5c46f3f20204fae38b1eeb765bc804c", "msg" : "Threadpublic (#1133)", "paths" : [ { "editType" : "edit", "file" : "latin_hypercube_driver_module.F90" }, { "editType" : "edit", "file" : "silhs_api_module.F90" }, { "editType" : "edit", "file" : "output_2D_samples_module.F90" }, { "editType" : "edit", "file" : "silhs_importance_sample_module.F90" }, { "editType" : "edit", "file" : "transform_to_pdf_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SRC/stepout_module.F90", "SRC/micro_field_utils.F90", "SRC/SGS_CLUBB/sgs.F90", "SRC/main.F90", "SRC/setdata_module.F90", "SRC/statistics.F90", "SRC/micro_field_utils.mod", "SRC/SGS_CLUBB/stat_clubb.F90", "SRC/SGS_CLUBB/clubb_sgs.F90" ], "commitId" : "b5bc5fa8fda0d316e073bd803e366634c5c4c126", "timestamp" : 1704337415000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Making compatible with latest clubb change.\u000a", "date" : "2024-01-03 21:03:35 -0600", "id" : "b5bc5fa8fda0d316e073bd803e366634c5c4c126", "msg" : "Making compatible with latest clubb change.", "paths" : [ { "editType" : "add", "file" : "SRC/micro_field_utils.mod" }, { "editType" : "edit", "file" : "SRC/micro_field_utils.F90" }, { "editType" : "edit", "file" : "SRC/SGS_CLUBB/sgs.F90" }, { "editType" : "edit", "file" : "SRC/SGS_CLUBB/clubb_sgs.F90" }, { "editType" : "edit", "file" : "SRC/setdata_module.F90" }, { "editType" : "edit", "file" : "SRC/stepout_module.F90" }, { "editType" : "edit", "file" : "SRC/statistics.F90" }, { "editType" : "edit", "file" : "SRC/SGS_CLUBB/stat_clubb.F90" }, { "editType" : "edit", "file" : "SRC/main.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "corr_varnce_module.F90" ], "commitId" : "6d345f45f5c0b3f99bd6b7c54cdf3b6c650943fa", "timestamp" : 1704398011000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Removing awkward nan check in favor of a default for Ncnp2_on_Ncnm2\u000a", "date" : "2024-01-04 13:53:31 -0600", "id" : "6d345f45f5c0b3f99bd6b7c54cdf3b6c650943fa", "msg" : "Removing awkward nan check in favor of a default for Ncnp2_on_Ncnm2", "paths" : [ { "editType" : "edit", "file" : "corr_varnce_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SRC/SGS_CLUBB/clubb_sgs.F90" ], "commitId" : "0f0ec05ba6839ea12c32ae2a6ac766843d1c5f92", "timestamp" : 1704410079000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Fixing bug by changing saturation_equation to match namelist argument, also adding it to namelist.\u000a", "date" : "2024-01-04 17:14:39 -0600", "id" : "0f0ec05ba6839ea12c32ae2a6ac766843d1c5f92", "msg" : "Fixing bug by changing saturation_equation to match namelist argument, also adding it to namelist.", "paths" : [ { "editType" : "edit", "file" : "SRC/SGS_CLUBB/clubb_sgs.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90" ], "commitId" : "f759e61ac5c41dc5fe9615136b3347fcbef3aff4", "timestamp" : 1704774211000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Adding new argument list variables to openacc copyin statements\u000a", "date" : "2024-01-08 22:23:31 -0600", "id" : "f759e61ac5c41dc5fe9615136b3347fcbef3aff4", "msg" : "Adding new argument list variables to openacc copyin statements", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "configurable_model_flags.in" ], "commitId" : "9b85ea408b8e57b9efedf77e8dfe30685fe3b04b", "timestamp" : 1704839542000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Setting l_smooth_Heaviside_tau_wpxp to .true. by default\u000a", "date" : "2024-01-09 16:32:22 -0600", "id" : "9b85ea408b8e57b9efedf77e8dfe30685fe3b04b", "msg" : "Setting l_smooth_Heaviside_tau_wpxp to .true. by default", "paths" : [ { "editType" : "edit", "file" : "configurable_model_flags.in" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mean_adv.F90" ], "commitId" : "830db1eac248ed03a0f52bf1d7402393b227b49e", "timestamp" : 1705003858000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "I am altering the mean advection code in preparation for ghost point\u000aremoval, since the mean advection code incorporates the ghost point\u000ain its current calculations.\u000a\u000aThe lower boundary is now treated in the same manner as the\u000aupper boundary, where a zero derivative over the boundary is assumed.\u000aAny interaction of the current ghost level with the model code is\u000anow removed from the mean advection calculation.\u000a\u000aThe results are bit-for-bit for most cases, but not all of them.\u000aThey are not necessarily expected to be bit-for-bit. There are\u000ano discernable differences on plots of priority cases. However,\u000athis commit is technically BIT_CHANGING.\u000a", "date" : "2024-01-11 14:10:58 -0600", "id" : "830db1eac248ed03a0f52bf1d7402393b227b49e", "msg" : "I am altering the mean advection code in preparation for ghost point", "paths" : [ { "editType" : "edit", "file" : "mean_adv.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "tridiag_lu_solver.F90" ], "commitId" : "ce785a929450dec9c013e6702b1bc9dcbc872b35", "timestamp" : 1705612684000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Fixing tridiag solver bug. See https://github.com/larson-group/clubb/issues/1139\u000a", "date" : "2024-01-18 15:18:04 -0600", "id" : "ce785a929450dec9c013e6702b1bc9dcbc872b35", "msg" : "Fixing tridiag solver bug. See https://github.com/larson-group/clubb/issues/1139", "paths" : [ { "editType" : "edit", "file" : "tridiag_lu_solver.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90", "clubb_api_module.F90" ], "commitId" : "e27a93ac46e46daa6d71e41f24993f9155dc0202", "timestamp" : 1705629086000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Slight rework to acc data statements. This allows us to use return calls in advance_clubb_core again. See https://github.com/larson-group/clubb/issues/1139\u000a", "date" : "2024-01-18 19:51:26 -0600", "id" : "e27a93ac46e46daa6d71e41f24993f9155dc0202", "msg" : "Slight rework to acc data statements. This allows us to use return calls in advance_clubb_core again. See https://github.com/larson-group/clubb/issues/1139", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mixing_length.F90" ], "commitId" : "33a2cb66dae21387f7a43e079180b02f622df464", "timestamp" : 1705629109000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Fixing small GPU stats bug\u000a", "date" : "2024-01-18 19:51:49 -0600", "id" : "33a2cb66dae21387f7a43e079180b02f622df464", "msg" : "Fixing small GPU stats bug", "paths" : [ { "editType" : "edit", "file" : "mixing_length.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mono_flux_limiter.F90" ], "commitId" : "cf82acebf4a1cc31f092af210fd2e7970452e069", "timestamp" : 1705629562000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Changing xm to out in mono flux solver. There is no need for it to be inout, and it confused me for a bit so I'm fixing it.\u000a", "date" : "2024-01-18 19:59:22 -0600", "id" : "cf82acebf4a1cc31f092af210fd2e7970452e069", "msg" : "Changing xm to out in mono flux solver. There is no need for it to be inout, and it confused me for a bit so I'm fixing it.", "paths" : [ { "editType" : "edit", "file" : "mono_flux_limiter.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90" ], "commitId" : "a1fd38a0ba17ef79fa0590646eb851fce4079bdb", "timestamp" : 1705819808000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Adding clubb specific compiler flag -DCLUBB_GPU, intended for use with openmp or openacc running on the GPU. Also adding a compiler flags, -DCUDA, and case statment for generating random numbers in silhs.\u000a", "date" : "2024-01-21 00:50:08 -0600", "id" : "a1fd38a0ba17ef79fa0590646eb851fce4079bdb", "msg" : "Adding clubb specific compiler flag -DCLUBB_GPU, intended for use with openmp or openacc running on the GPU. Also adding a compiler flags, -DCUDA, and case statment for generating random numbers in silhs.", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "latin_hypercube_driver_module.F90" ], "commitId" : "4b9838afa120e0a06c36eebb8e98027d0587dbba", "timestamp" : 1705819808000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Adding clubb specific compiler flag -DCLUBB_GPU, intended for use with openmp or openacc running on the GPU. Also adding a compiler flags, -DCUDA, and case statment for generating random numbers in silhs.\u000a", "date" : "2024-01-21 00:50:08 -0600", "id" : "4b9838afa120e0a06c36eebb8e98027d0587dbba", "msg" : "Adding clubb specific compiler flag -DCLUBB_GPU, intended for use with openmp or openacc running on the GPU. Also adding a compiler flags, -DCUDA, and case statment for generating random numbers in silhs.", "paths" : [ { "editType" : "edit", "file" : "latin_hypercube_driver_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_wp2_wp3_module.F90" ], "commitId" : "623ed86ffb5b16dbcd6b72aa76e4aede6c38be6b", "timestamp" : 1706079736000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "Now that the value of wp3 is being set to a boundary value of 0\u000aat the first thermodynamic grid level above the surface, it doesn't\u000amake sense to loop over budget terms anymore at that particular level,\u000asince they don't factor in the solution and give a false impression.\u000a\u000aWith this commit, wp3 budget terms now start their loop at level 3.\u000a\u000aThis commit is BIT_CHANGING, but the only thing that changes are\u000abudget stats for a couple of wp3 budget terms. The solution\u000adoes not actually change.\u000a", "date" : "2024-01-24 01:02:16 -0600", "id" : "623ed86ffb5b16dbcd6b72aa76e4aede6c38be6b", "msg" : "Now that the value of wp3 is being set to a boundary value of 0", "paths" : [ { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "model_flags.F90" ], "commitId" : "d6d044841a3c4fca653f4822509f1f9ceacfd0eb", "timestamp" : 1706649109000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "This is (amazingly) BIT_CHANGING. The differences are due to some compiler optimizations, see https://github.com/larson-group/clubb/pull/1133\\#issuecomment-1865156979.\u000a", "date" : "2024-01-30 15:11:49 -0600", "id" : "d6d044841a3c4fca653f4822509f1f9ceacfd0eb", "msg" : "This is (amazingly) BIT_CHANGING. The differences are due to some compiler optimizations, see https://github.com/larson-group/clubb/pull/1133\\#issuecomment-1865156979.", "paths" : [ { "editType" : "edit", "file" : "model_flags.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "input_names.F90" ], "commitId" : "89925a4e642c7993be58226934ff9a3cdf9a0d79", "timestamp" : 1706760368000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Removing backslashes. These should be slashes, but gnu,intel,nvidia generate code that treats slashes as whitespace and backslashes as a character, while cray treats backslashes as whitespace as well. This is easily fixed by using quotes, and in the meantime we will change the backslashes to forward slashes. See https://github.com/larson-group/clubb/issues/1138\\#issuecomment-1910844013\u000a", "date" : "2024-01-31 22:06:08 -0600", "id" : "89925a4e642c7993be58226934ff9a3cdf9a0d79", "msg" : "Removing backslashes. These should be slashes, but gnu,intel,nvidia generate code that treats slashes as whitespace and backslashes as a character, while cray treats backslashes as whitespace as well. This is easily fixed by using quotes, and in the meantime we will change the backslashes to forward slashes. See https://github.com/larson-group/clubb/issues/1138\\#issuecomment-1910844013", "paths" : [ { "editType" : "edit", "file" : "input_names.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90", "advance_xm_wpxp_module.F90", "advance_helper_module.F90" ], "commitId" : "f66e6de3fd5790a95a3e2ac792e58129985540fe", "timestamp" : 1707345359000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "Fixing a bug where the Lscale used in calculating the damping\u000acoefficient in advance_xm_wpxp_module.F90 should be Lscale_zm,\u000asince the term is calculated on momentum grid levels.\u000a\u000aAlong the way, I found out that I could streamline the code\u000aby passing in the value of Lscale_zm that was already calculated\u000a(interpolated from Lscale) in advance_clubb_core. This value\u000acould be passed into both advance_xm_wpxp and calc_stability_correction,\u000aand then fed down.\u000a\u000aThis results of this code change are bit-for-bit identical with the\u000aprevious revision, most likely because this code only matters when\u000acertain flags are flipped that are not used by default.\u000a", "date" : "2024-02-07 16:35:59 -0600", "id" : "f66e6de3fd5790a95a3e2ac792e58129985540fe", "msg" : "Fixing a bug where the Lscale used in calculating the damping", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "advance_helper_module.F90" }, { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "model_flags.F90" ], "commitId" : "aa0b5742c1ecb87b896f03ad526ad9483bcc707d", "timestamp" : 1707410339000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephens", "fullName" : "benjamin.andrew.stephens" }, "authorEmail" : "benjamin.andrew.stephens@gmail.com", "comment" : "adding equals sign cuz I've had it up to here with this typo!\u000a", "date" : "2024-02-08 09:38:59 -0700", "id" : "aa0b5742c1ecb87b896f03ad526ad9483bcc707d", "msg" : "adding equals sign cuz I've had it up to here with this typo!", "paths" : [ { "editType" : "edit", "file" : "model_flags.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "stats_zt_module.F90" ], "commitId" : "7533e5fc4247ea19f60309050610a3f35229436a", "timestamp" : 1707839985000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/vlarson", "fullName" : "Vince Larson" }, "authorEmail" : "vlarson@users.noreply.github.com", "comment" : "fixing bug, name of wm_zt was left as \"wm\"\u000a", "date" : "2024-02-13 09:59:45 -0600", "id" : "7533e5fc4247ea19f60309050610a3f35229436a", "msg" : "fixing bug, name of wm_zt was left as \"wm\"", "paths" : [ { "editType" : "edit", "file" : "stats_zt_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "clubb_api_module.F90" ], "commitId" : "9719713bc9b25dda36e2a076736d36d8052eb2a7", "timestamp" : 1707948133000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Add blank line in order to trigger Jenkins tests for CAM\u000a\u000aIn particular, Brian Griffin's code change from 7 Feb 2024, \u000a\u000aBIT_CHANGING:595e2c13024c1e913815d56ae724823a82bddc03 \u000a\u000achanges answers when using l_diag_Lscale_from_tau=.false.\u000a\u000aThis code change was brought into the CAM repo in this commit: \u000a\u000aBIT_CHANGING:d275ac17f3e53d65641c3210df33ce0fad4e5aef\u000a", "date" : "2024-02-14 16:02:13 -0600", "id" : "9719713bc9b25dda36e2a076736d36d8052eb2a7", "msg" : "Add blank line in order to trigger Jenkins tests for CAM", "paths" : [ { "editType" : "edit", "file" : "clubb_api_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mixing_length.F90", "advance_clubb_core_module.F90", "model_flags.F90", "clubb_api_module.F90", "constants_clubb.F90", "pdf_closure_module.F90", "sfc_varnce_module.F90", "mono_flux_limiter.F90", "advance_helper_module.F90" ], "commitId" : "4e3c5f2e0080925f0890ec6e36446f5dc1a67d85", "timestamp" : 1708052285000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Small acc tweaks (#1144)\u000a\u000a* Removing unneccesary acc declare statements.\u000a\u000a* Removing use of acc routine in favor of new 1D array routine for smooth_max.\u000a\u000a* The new tmp_calc_ngrdcol should be copied regardless of flag\u000a\u000a* tmp_calc_ngrdcol also needs to be deleted unconditionally.\u000a\u000a* Making separate conditional acc copy for edsclrdim variables.\u000a\u000a* Adding ifdefs around prints inside of openacc kernel\u000a\u000a* Making erf_cache and exp_cache scalars, there was no need for them to be arrays.\u000a\u000a* Making update host statements with sclr_dim or edsclr_dim conditional. Without these we get runtime errors with cray+openacc\u000a\u000a* Removed files\u000a", "date" : "2024-02-15 20:58:05 -0600", "id" : "4e3c5f2e0080925f0890ec6e36446f5dc1a67d85", "msg" : "Small acc tweaks (#1144)", "paths" : [ { "editType" : "edit", "file" : "clubb_api_module.F90" }, { "editType" : "edit", "file" : "constants_clubb.F90" }, { "editType" : "edit", "file" : "sfc_varnce_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "pdf_closure_module.F90" }, { "editType" : "edit", "file" : "model_flags.F90" }, { "editType" : "edit", "file" : "mono_flux_limiter.F90" }, { "editType" : "edit", "file" : "advance_helper_module.F90" }, { "editType" : "edit", "file" : "mixing_length.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90" ], "commitId" : "09d7b40ad3f996bb73b0f8689947f758705f5311", "timestamp" : 1709675532000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Removes comment about Numerical Recipes\u000a", "date" : "2024-03-05 15:52:12 -0600", "id" : "09d7b40ad3f996bb73b0f8689947f758705f5311", "msg" : "Removes comment about Numerical Recipes", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_wp2_wp3_module.F90", "fill_holes.F90", "advance_clubb_core_module.F90", "advance_xm_wpxp_module.F90", "mono_flux_limiter.F90" ], "commitId" : "e46bd6ab09c336755a83f2ea26efbc6e06641564", "timestamp" : 1710806789000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "OpenMP Optimizations (#1146)\u000a\u000a* Small changes to improve omp performance.\u000a\u000a* Some more small changes to help openmp\u000a\u000a* Adhering to standards a little better by specifying _core_rknd\u000a", "date" : "2024-03-18 19:06:29 -0500", "id" : "e46bd6ab09c336755a83f2ea26efbc6e06641564", "msg" : "OpenMP Optimizations (#1146)", "paths" : [ { "editType" : "edit", "file" : "mono_flux_limiter.F90" }, { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" }, { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "fill_holes.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "fill_holes.F90" ], "commitId" : "b3370acbc97df9a7f10cd183dbc0bb0d68036c49", "timestamp" : 1711137584000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Adding comment to explain unusual code choice.\u000a", "date" : "2024-03-22 14:59:44 -0500", "id" : "b3370acbc97df9a7f10cd183dbc0bb0d68036c49", "msg" : "Adding comment to explain unusual code choice.", "paths" : [ { "editType" : "edit", "file" : "fill_holes.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "fill_holes.F90" ], "commitId" : "2211b4ac393092503821aab54176124651ab4ba8", "timestamp" : 1711302893000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Adding sum part to comment\u000a", "date" : "2024-03-24 12:54:53 -0500", "id" : "2211b4ac393092503821aab54176124651ab4ba8", "msg" : "Adding sum part to comment", "paths" : [ { "editType" : "edit", "file" : "fill_holes.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "clubb_api_module.F90", "clip_explicit.F90", "advance_xm_wpxp_module.F90", "parameters_tunable.F90", "new_pdf_main.F90", "advance_helper_module.F90", "mixing_length.F90", "advance_wp2_wp3_module.F90", "advance_xp2_xpyp_module.F90", "advance_clubb_core_module.F90", "pdf_closure_module.F90", "Skx_module.F90", "adg1_adg2_3d_luhar_pdf.F90", "sfc_varnce_module.F90", "new_hybrid_pdf_main.F90" ], "commitId" : "215f23ff2481515749a198c29db74d1005114b75", "timestamp" : 1711925174000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Putting ngrdcol in clubb_params (#1147)\u000a\u000a* Initial changes to make clubb_params have an ngrdcol dimension. All BFB on CPU and GPU.\u000a\u000a* pdf_closure done\u000a\u000a* pdf_closure missed changes\u000a\u000a* calc_Lscale_directly changes and removed accidentally added files\u000a\u000a* advance_xp2_xpyp done\u000a\u000a* Missed file\u000a\u000a* Added space here because the addition of this line in the last commit is to prevent Ri_zm from being uninitialized when using l_diag_Lscale_from_tau=.false.\u000a\u000a* advance_wp2_wp3 done\u000a\u000a* advance_xm_wpxp done\u000a\u000a* Fixed bugs found by checking l_modify_limiters_for_cnvg_test=.true.\u000a\u000a* Fixed bug found by checking l_diffuse_rtm_and_thlm and l_stability_correct_Kh_N2_zm\u000a\u000a* Removing slightly redundant logic\u000a\u000a* Swapping back order of l_gamma_skw if statements. I'm not sure why I swapped them in the first place.\u000a", "date" : "2024-03-31 17:46:14 -0500", "id" : "215f23ff2481515749a198c29db74d1005114b75", "msg" : "Putting ngrdcol in clubb_params (#1147)", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" }, { "editType" : "edit", "file" : "advance_helper_module.F90" }, { "editType" : "edit", "file" : "adg1_adg2_3d_luhar_pdf.F90" }, { "editType" : "edit", "file" : "clip_explicit.F90" }, { "editType" : "edit", "file" : "new_pdf_main.F90" }, { "editType" : "edit", "file" : "sfc_varnce_module.F90" }, { "editType" : "edit", "file" : "pdf_closure_module.F90" }, { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" }, { "editType" : "edit", "file" : "mixing_length.F90" }, { "editType" : "edit", "file" : "new_hybrid_pdf_main.F90" }, { "editType" : "edit", "file" : "Skx_module.F90" }, { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" }, { "editType" : "edit", "file" : "parameters_tunable.F90" }, { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_xm_wpxp_module.F90" ], "commitId" : "a39122dbb717c71138d553a1cf1f8cfaa7670d0b", "timestamp" : 1712000028000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Fixing bug with C6 parameters, see https://github.com/larson-group/clubb/pull/1147. This is technically BIT_CHANGING, but only when C6thl != C6thlb and l_diag_Lscale_from_tau=.false.\u000a", "date" : "2024-04-01 14:33:48 -0500", "id" : "a39122dbb717c71138d553a1cf1f8cfaa7670d0b", "msg" : "Fixing bug with C6 parameters, see https://github.com/larson-group/clubb/pull/1147. This is technically BIT_CHANGING, but only when C6thl != C6thlb and l_diag_Lscale_from_tau=.false.", "paths" : [ { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SRC/SGS_CLUBB/clubb_sgs.F90" ], "commitId" : "e9e1784e795b395e12909219867bcbd7fe8a8306", "timestamp" : 1712001216000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Making compatible with latest clubb changes.\u000a", "date" : "2024-04-01 14:53:36 -0500", "id" : "e9e1784e795b395e12909219867bcbd7fe8a8306", "msg" : "Making compatible with latest clubb changes.", "paths" : [ { "editType" : "edit", "file" : "SRC/SGS_CLUBB/clubb_sgs.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_xp2_xpyp_module.F90" ], "commitId" : "9e61ef088724b119d7c7f61a21b4c3d306058bcf", "timestamp" : 1712297060000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "At the ghost point below the surface, which does not matter in\u000athe calculations, a value of 0 is now being entered for\u000athermodynamic-level output stats coef_wprtp2_implicit,\u000aterm_wprtp2_explicit, etc.\u000a\u000aWhy would we do this? The answer is \"Why Not??!!!!\"\u000a\u000aThis is being done to keep the trunk results bit-for-bit with\u000athe clubb_ghost_exorcism branch, which is no longer loops over\u000athe ghost level below the surface in the region of code\u000awhere these stats are recorded.\u000a\u000aIn terms of the master, this commit is technically BIT_CHANGING.\u000aHowever, only for these 6 output terms at the ghost point.\u000a", "date" : "2024-04-05 01:04:20 -0500", "id" : "9e61ef088724b119d7c7f61a21b4c3d306058bcf", "msg" : "At the ghost point below the surface, which does not matter in", "paths" : [ { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_windm_edsclrm_module.F90" ], "commitId" : "68d7df96e0daefd601d9649c886f68401a780ba1", "timestamp" : 1712376324000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "The code that advances um and vm when l_predict_upwp_vpwp is turned off\u000a(as found in advance_windm_edsclrm) was accessing the ghost point in\u000aone spot. I rewrote it in the exact way the code in the\u000aclubb_ghost_exorcism branch is written so that it makes the same\u000acalculation without referencing the ghost point.\u000a\u000aI also rewrote a couple stats by outputting a value of 0 at the ghost\u000apoint to maintain stat consistency between the master and the ghost\u000aexorcism branch.\u000a\u000aThis commit is BIT_CHANGING, but only when the l_predict_upwp_vpwp\u000aflag is set to false (which is not the case by default).\u000a", "date" : "2024-04-05 23:05:24 -0500", "id" : "68d7df96e0daefd601d9649c886f68401a780ba1", "msg" : "The code that advances um and vm when l_predict_upwp_vpwp is turned off", "paths" : [ { "editType" : "edit", "file" : "advance_windm_edsclrm_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "configurable_model_flags.in" ], "commitId" : "c73af292ada7bbb25efdfaedd2ad423e2bc78873", "timestamp" : 1712412930000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "It was discovered that the location where the ghost point values\u000aof um and vm were set equal to their respective values at the first\u000athermodynamic level above the surface was not ideal. Their\u000aassignment occurred before the love nudge (l_uv_nudge). Then,\u000athe love nudge came along and altered their values so that\u000aum(1) no longer equaled um(2) -- and analogous for vm(1) and vm(2) --\u000afor a half dozen cases. In addition to making the code inconsistent,\u000ait also caused bit-for-bitness differences between the master\u000aand clubb_ghost_exorcism branches. For those reasons, this\u000aBIT_CHANGING commit is being made.\u000a", "date" : "2024-04-06 09:15:30 -0500", "id" : "c73af292ada7bbb25efdfaedd2ad423e2bc78873", "msg" : "It was discovered that the location where the ghost point values", "paths" : [ { "editType" : "edit", "file" : "configurable_model_flags.in" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_windm_edsclrm_module.F90" ], "commitId" : "79a203f9281c29c1f249395c0cd9beb28851684f", "timestamp" : 1712412930000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "It was discovered that the location where the ghost point values\u000aof um and vm were set equal to their respective values at the first\u000athermodynamic level above the surface was not ideal. Their\u000aassignment occurred before the love nudge (l_uv_nudge). Then,\u000athe love nudge came along and altered their values so that\u000aum(1) no longer equaled um(2) -- and analogous for vm(1) and vm(2) --\u000afor a half dozen cases. In addition to making the code inconsistent,\u000ait also caused bit-for-bitness differences between the master\u000aand clubb_ghost_exorcism branches. For those reasons, this\u000aBIT_CHANGING commit is being made.\u000a", "date" : "2024-04-06 09:15:30 -0500", "id" : "79a203f9281c29c1f249395c0cd9beb28851684f", "msg" : "It was discovered that the location where the ghost point values", "paths" : [ { "editType" : "edit", "file" : "advance_windm_edsclrm_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "configurable_model_flags.in" ], "commitId" : "4fae617e65511ba69bfa7029c5a9289ab2165194", "timestamp" : 1712413386000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "I accidentally committed a couple things in the previous commit\u000athat weren't supposed to be committed, so I am undoing that immediately\u000a", "date" : "2024-04-06 09:23:06 -0500", "id" : "4fae617e65511ba69bfa7029c5a9289ab2165194", "msg" : "I accidentally committed a couple things in the previous commit", "paths" : [ { "editType" : "edit", "file" : "configurable_model_flags.in" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_xm_wpxp_module.F90" ], "commitId" : "09e6e7258c51f674efc6aefc0285458f1e74a2ce", "timestamp" : 1712762923000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "While it doesn't affect results, I fixed what appears to be an\u000aobvious bug in advance_xm_wpxp. If everything is at a singular zm\u000alevel, the referenced height shouldn't be gr%zt, but rather gr%zm.\u000a", "date" : "2024-04-10 10:28:43 -0500", "id" : "09e6e7258c51f674efc6aefc0285458f1e74a2ce", "msg" : "While it doesn't affect results, I fixed what appears to be an", "paths" : [ { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_xm_wpxp_module.F90" ], "commitId" : "5694aa6f6ccaca0ba89e4c4a54119edfbc05ed4b", "timestamp" : 1712768355000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "I am updating the loop in subroutine diagnose_xpwp so that it doesn't\u000aloop over the model upper or lower boundaries. Calculations at those\u000alevels are irrelevant to the results, and their inclusion causes\u000abitness differences between the master and clubb_ghost_exorcism\u000abranches. Since this code change causes differences in the zm\u000astats file at the upper and lower boundaries for a few fields, this\u000acommit is technically BIT_CHANGING, although it should be noted\u000athat it does not change the simulation results.\u000a", "date" : "2024-04-10 11:59:15 -0500", "id" : "5694aa6f6ccaca0ba89e4c4a54119edfbc05ed4b", "msg" : "I am updating the loop in subroutine diagnose_xpwp so that it doesn't", "paths" : [ { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_xm_wpxp_module.F90" ], "commitId" : "04935f95e72f2d182d6717d69c9e950ad3d38713", "timestamp" : 1712811418000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "This commit is being made to keep the stats zt output from the\u000amaster branch inline with the output from the clubb_ghost_exorcism\u000abranch. In short, the only change is that the value of\u000aa couple of inputs relative to wpxp turbulent advection from\u000athermodynamic level 1 are set to 0 for stats output in order to\u000akeep the master and ghost exorcism branches bit-for-bit with\u000aeach other. The output at those levels are not used in\u000aany calculations and are unnecessary. However, this change\u000ais technically BIT_CHANGING.\u000a", "date" : "2024-04-10 23:56:58 -0500", "id" : "04935f95e72f2d182d6717d69c9e950ad3d38713", "msg" : "This commit is being made to keep the stats zt output from the", "paths" : [ { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_helper_module.F90" ], "commitId" : "76244e00c736bd5bbc29f55e9fc41095e0107054", "timestamp" : 1712890626000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "I am committing a bug fix to the code that calculates mixed Brunt\u000aVaisala frequency. The variable ice_supersat_frac was used directly\u000ain calculations that are supposed to take place on a momentum level.\u000aThe fix is to interpolated ice_supersat_frac to momentum levels before\u000ause. This commit is BIT_CHANGING.\u000a", "date" : "2024-04-11 21:57:06 -0500", "id" : "76244e00c736bd5bbc29f55e9fc41095e0107054", "msg" : "I am committing a bug fix to the code that calculates mixed Brunt", "paths" : [ { "editType" : "edit", "file" : "advance_helper_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mono_flux_limiter.F90" ], "commitId" : "a9608e5509c2494c9805c0f6a754f254c5f20c7e", "timestamp" : 1713021941000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "I am committing a stats change to the ghost point values of zt\u000astats output variables found in the monotonic flux limiter. These\u000avalues are all being set simply to 0 at the ghost point for\u000apurposes of providing an easy comparison to stats output files\u000afrom the clubb_ghost_exorcism branch. The code change is\u000anot at all answer changing. However, it is technically BIT_CHANGING.\u000a", "date" : "2024-04-13 10:25:41 -0500", "id" : "a9608e5509c2494c9805c0f6a754f254c5f20c7e", "msg" : "I am committing a stats change to the ghost point values of zt", "paths" : [ { "editType" : "edit", "file" : "mono_flux_limiter.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mixing_length.F90", "advance_xp2_xpyp_module.F90", "advance_xp3_module.F90", "advance_clubb_core_module.F90", "setup_clubb_pdf_params.F90", "calc_pressure.F90", "advance_helper_module.F90" ], "commitId" : "1a044ef468ede907dbb651c69bef76e264906b4b", "timestamp" : 1713448035000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "Committing some thresholding around positive-definite fields after\u000aa zt2zm statement. This commit does not change the results in our\u000aCLUBB standalone cases.\u000a", "date" : "2024-04-18 08:47:15 -0500", "id" : "1a044ef468ede907dbb651c69bef76e264906b4b", "msg" : "Committing some thresholding around positive-definite fields after", "paths" : [ { "editType" : "edit", "file" : "advance_xp3_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "mixing_length.F90" }, { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" }, { "editType" : "edit", "file" : "calc_pressure.F90" }, { "editType" : "edit", "file" : "advance_helper_module.F90" }, { "editType" : "edit", "file" : "setup_clubb_pdf_params.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "grid_class.F90" ], "commitId" : "15e15c30d8454b66017207782a4e949282420a2c", "timestamp" : 1713562695000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "Changing the linear interpolation in the zt2zm function at momentum\u000alevel 1 from an interpolation between the ghost point and the first\u000alevel above the surface to simply a \"drop down\" of the value found\u000aat the first level above the surface.\u000a\u000aThis is being done ahead of the removal of the ghost point from the\u000amodel.\u000a\u000aResults of this change are BIT_CHANGING.\u000a", "date" : "2024-04-19 16:38:15 -0500", "id" : "15e15c30d8454b66017207782a4e949282420a2c", "msg" : "Changing the linear interpolation in the zt2zm function at momentum", "paths" : [ { "editType" : "edit", "file" : "grid_class.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "grid_class.F90" ], "commitId" : "f3b2d7a6a63ceea30a960b27be61c18ea0279b71", "timestamp" : 1713916476000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "I'm changing the way ddzt handles the derivative over momentum level 1.\u000aPreviously, it was based on the differential between the ghost point and\u000athe first level above the surface. Now, the value of the derivative at\u000amomentum level 2 is simply being dropped down to momentum level 1.\u000a\u000aThis is being done in advance of ghost point removal.\u000a\u000aThe results of this commit are BIT_CHANGING.\u000a", "date" : "2024-04-23 18:54:36 -0500", "id" : "f3b2d7a6a63ceea30a960b27be61c18ea0279b71", "msg" : "I'm changing the way ddzt handles the derivative over momentum level 1.", "paths" : [ { "editType" : "edit", "file" : "grid_class.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_xm_wpxp_module.F90" ], "commitId" : "13811b3b0775ce0412d5ca84a1c0e8787e3823f6", "timestamp" : 1714471119000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "Moved the ghost-point setting of xm(1) = xm(2) to the last line\u000aof the subroutine so this command doesn't get overwritten.\u000a\u000aThis is technically BIT_CHANGING because it alters rtm (and some\u000artm-related calculations) at the ghost point, but it is not\u000aanswer changing.\u000a\u000aThis is being done in preparation for ghost point removal.\u000a", "date" : "2024-04-30 04:58:39 -0500", "id" : "13811b3b0775ce0412d5ca84a1c0e8787e3823f6", "msg" : "Moved the ghost-point setting of xm(1) = xm(2) to the last line", "paths" : [ { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mixing_length.F90", "advance_wp2_wp3_module.F90", "advance_xp2_xpyp_module.F90", "advance_xp3_module.F90", "advance_clubb_core_module.F90", "advance_xm_wpxp_module.F90", "grid_class.F90", "setup_clubb_pdf_params.F90", "advance_windm_edsclrm_module.F90", "calc_pressure.F90", "advance_helper_module.F90" ], "commitId" : "6db5d3c85dd296d8ccafe66f5e7e20b241d37188", "timestamp" : 1714534975000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Optional arguments are just best sometimes (#1150)\u000a\u000a* Adding optional argument to zm2zt/zt2zm to act as threshold. This cuts down on lots of bulk and reduces the chances of breaking the GPU code. All BFB.\u000a\u000a* Removing TODO\u000a\u000a* Replacing hardcoded 0.0_core_rknd with zero_threshold\u000a", "date" : "2024-04-30 22:42:55 -0500", "id" : "6db5d3c85dd296d8ccafe66f5e7e20b241d37188", "msg" : "Optional arguments are just best sometimes (#1150)", "paths" : [ { "editType" : "edit", "file" : "advance_xp3_module.F90" }, { "editType" : "edit", "file" : "grid_class.F90" }, { "editType" : "edit", "file" : "mixing_length.F90" }, { "editType" : "edit", "file" : "setup_clubb_pdf_params.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "advance_windm_edsclrm_module.F90" }, { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" }, { "editType" : "edit", "file" : "calc_pressure.F90" }, { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" }, { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" }, { "editType" : "edit", "file" : "advance_helper_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90" ], "commitId" : "d6ca5b0e6179de58c7571bea8650e3cd93c3de5e", "timestamp" : 1714537919000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Fixing bug. RESOLVED:556370c6406e6b943b88affbe7728a5036b1ba22, this was catchable by using debugging flags, but seems to otherwise cause no issues. Investigating I found that it only clips the below ground level, so that must not have been affecting other levels. This is technically BIT_CHANGING since it resolves an issue.\u000a", "date" : "2024-04-30 23:31:59 -0500", "id" : "d6ca5b0e6179de58c7571bea8650e3cd93c3de5e", "msg" : "Fixing bug. RESOLVED:556370c6406e6b943b88affbe7728a5036b1ba22, this was catchable by using debugging flags, but seems to otherwise cause no issues. Investigating I found that it only clips the below ground level, so that must not have been affecting other levels. This is technically BIT_CHANGING since it resolves an issue.", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "fill_holes.F90", "advance_wp2_wp3_module.F90", "advance_xp2_xpyp_module.F90", "advance_clubb_core_module.F90", "advance_xm_wpxp_module.F90", "clubb_api_module.F90" ], "commitId" : "c2849fa3c750562ffdd5abd6bc9937c081e66226", "timestamp" : 1714587276000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Making num_draw_points in fill_holes a constant. We were already using this value as a constant everywhere, but passing a constant by argument list makes it difficult/impossible for a compiler to optimize using that constant, unless it does inlining. Now, rather than passing the constant num_hf_draw_points (or sometimes a hardcoded 2) we just use num_hf_draw_points directly from constants_clubb. This massively improves the performance of a loop in fill holes when using nvhpc+omp, which was the motivation for this, but should also improve the performance on CPUs. Everything is BFB.\u000a", "date" : "2024-05-01 13:14:36 -0500", "id" : "c2849fa3c750562ffdd5abd6bc9937c081e66226", "msg" : "Making num_draw_points in fill_holes a constant. We were already using this value as a constant everywhere, but passing a constant by argument list makes it difficult/impossible for a compiler to optimize using that constant, unless it does inlining. Now, rather than passing the constant num_hf_draw_points (or sometimes a hardcoded 2) we just use num_hf_draw_points directly from constants_clubb. This massively improves the performance of a loop in fill holes when using nvhpc+omp, which was the motivation for this, but should also improve the performance on CPUs. Everything is BFB.", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" }, { "editType" : "edit", "file" : "fill_holes.F90" }, { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" }, { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SRC/MICRO_M2005_UWM/microphysics.F90", "SRC/micro_field_utils.F90", "SRC/SGS_CLUBB/clubb_sgs.F90" ], "commitId" : "ecc32fd475a7a380a33f9361537db3f4741a1962", "timestamp" : 1714587855000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Making compatible with latest clubb changes.\u000a", "date" : "2024-05-01 13:24:15 -0500", "id" : "ecc32fd475a7a380a33f9361537db3f4741a1962", "msg" : "Making compatible with latest clubb changes.", "paths" : [ { "editType" : "edit", "file" : "SRC/MICRO_M2005_UWM/microphysics.F90" }, { "editType" : "edit", "file" : "SRC/micro_field_utils.F90" }, { "editType" : "edit", "file" : "SRC/SGS_CLUBB/clubb_sgs.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_xm_wpxp_module.F90" ], "commitId" : "0e6f459a8ca2110f661d78019a1f717ff9b9407a", "timestamp" : 1714680265000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "I am committing code that effectively ignores the values of certain\u000azt stats at the ghost level by setting them to 0. This is done to\u000aallow for bit-for-bitness comparisons between the master branch\u000aand the clubb_ghost_exorcism branch.\u000a\u000aTechnically, since zt stat file output at the irrelevant ghost\u000alevel is changed for some variables, this commit is BIT_CHANGING.\u000a\u000aEffectively, this commit doesn't change squat in terms of model results.\u000a", "date" : "2024-05-02 15:04:25 -0500", "id" : "0e6f459a8ca2110f661d78019a1f717ff9b9407a", "msg" : "I am committing code that effectively ignores the values of certain", "paths" : [ { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_xm_wpxp_module.F90" ], "commitId" : "4b4adc89f8fe60d9e9f89fadcab3f1f6c9499250", "timestamp" : 1714685456000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "I am moving the advance_xm_wpxp setting of xm(1) = xm(2) from the\u000aend of xm_clipping_and_stats to the very end of advance_xm_wpxp, right\u000abefore the return to advance_clubb_core. The reason I am doing this\u000ais the nudging was done after setting xm(1) = xm(2) and would alter\u000athe results. This is no longer the case, as setting xm(1) = xm(2)\u000ais now being done after nudging.\u000a\u000aThis is being done in advance of removal of the ghost point from CLUBB.\u000aThis helps ensure a bit-for-bit match between the ghost exorcism branch and the\u000amaster branch.\u000a\u000aThis commit technically alter fields such as um, vm, um_bt, vm_bt,\u000awpup2, wpvp2, and shear at level 1 only. Thus, this commit is\u000atechnically BIT_CHANGING.\u000a\u000aEffectively, once again, this commit doesn't change squat.\u000a", "date" : "2024-05-02 16:30:56 -0500", "id" : "4b4adc89f8fe60d9e9f89fadcab3f1f6c9499250", "msg" : "I am moving the advance_xm_wpxp setting of xm(1) = xm(2) from the", "paths" : [ { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_xm_wpxp_module.F90" ], "commitId" : "243d18ebd39084235f84c52d7ed538639bd23f95", "timestamp" : 1714763847000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Adding extra exclamation to acc statement to comment it out.\u000a", "date" : "2024-05-03 14:17:27 -0500", "id" : "243d18ebd39084235f84c52d7ed538639bd23f95", "msg" : "Adding extra exclamation to acc statement to comment it out.", "paths" : [ { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mixing_length.F90" ], "commitId" : "0ce993b309b89a592fddf5c7df4d8384d3514723", "timestamp" : 1715624439000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "gr%zm should be used here instead of gr%zt, since these are\u000amomentum-level variables being calculated. Results are BIT_CHANGING.\u000a", "date" : "2024-05-13 13:20:39 -0500", "id" : "0ce993b309b89a592fddf5c7df4d8384d3514723", "msg" : "gr%zm should be used here instead of gr%zt, since these are", "paths" : [ { "editType" : "edit", "file" : "mixing_length.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90", "mixing_length.F90" ], "commitId" : "880007854a85598da82ccefa4724c4ddbda5f7d6", "timestamp" : 1715635045000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "Thermodynamic-level (zt) values should be used with zt-variable\u000acalculations. This commit changes results (but not visibly)\u000afor the l_avg_Lscale code, but since this code is not the default\u000ain CLUBB, the code remains bit-for-bit since the last commit.\u000a", "date" : "2024-05-13 16:17:25 -0500", "id" : "880007854a85598da82ccefa4724c4ddbda5f7d6", "msg" : "Thermodynamic-level (zt) values should be used with zt-variable", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "mixing_length.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "clubb_api_module.F90", "advance_xm_wpxp_module.F90" ], "commitId" : "805374a14b770257f081e083488dadbf95467044", "timestamp" : 1715800905000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Fixing small GPU bug in advance_xm, also fixing a bug with sclrpthvp that's only detectable when were running 1 column on GPUs.\u000a", "date" : "2024-05-15 14:21:45 -0500", "id" : "805374a14b770257f081e083488dadbf95467044", "msg" : "Fixing small GPU bug in advance_xm, also fixing a bug with sclrpthvp that's only detectable when were running 1 column on GPUs.", "paths" : [ { "editType" : "edit", "file" : "clubb_api_module.F90" }, { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90" ], "commitId" : "c7232ab0ff8a01c790b8ae8d7126696eeed84cc6", "timestamp" : 1715889108000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "Fixing a bug. Does not change default results.\u000a", "date" : "2024-05-16 14:51:48 -0500", "id" : "c7232ab0ff8a01c790b8ae8d7126696eeed84cc6", "msg" : "Fixing a bug. Does not change default results.", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90", "advance_xm_wpxp_module.F90", "clubb_api_module.F90", "advance_helper_module.F90" ], "commitId" : "27bcd976257a9e518b3fef5318e1bb964f3fea74", "timestamp" : 1717028099000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "The variable rc_coef_zm needed to be passed in and saved from\u000atimestep-to-timestep rather than rc_coef. The results of this\u000achange are BIT_CHANGING.\u000a", "date" : "2024-05-29 19:14:59 -0500", "id" : "27bcd976257a9e518b3fef5318e1bb964f3fea74", "msg" : "The variable rc_coef_zm needed to be passed in and saved from", "paths" : [ { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" }, { "editType" : "edit", "file" : "advance_helper_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mt95.f90", "mt95.F90" ], "commitId" : "3d2c815522ee350d0dcb01d72877541e8317a593", "timestamp" : 1717450146000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Making the f in f90 capital for consistency.\u000a", "date" : "2024-06-03 16:29:06 -0500", "id" : "3d2c815522ee350d0dcb01d72877541e8317a593", "msg" : "Making the f in f90 capital for consistency.", "paths" : [ { "editType" : "delete", "file" : "mt95.f90" }, { "editType" : "add", "file" : "mt95.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90" ], "commitId" : "6ab16812ec6b8e1d0e8e98f5dd02e0794363299b", "timestamp" : 1717567979000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Making the only change required to make clubb run with openacc in cam.\u000a", "date" : "2024-06-05 00:12:59 -0600", "id" : "6ab16812ec6b8e1d0e8e98f5dd02e0794363299b", "msg" : "Making the only change required to make clubb run with openacc in cam.", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mixing_length.F90", "advance_clubb_core_module.F90", "advance_helper_module.F90" ], "commitId" : "d5fb86b1bd228c5b17c18f63a17c0a37fead40ae", "timestamp" : 1718832972000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Ri zm calc (Part 1) - Combine and move call to calc_brunt_vaisala_freq_sqd (#1154)\u000a\u000a#1145 Combined call to `calc_brunt_vaisala_freq_sqd` in `advance_clubb_core` for both Lscale and taus code - BITCHANGING\u000a\u000aCall for taus code was moved out and in front of `diagnose_Lscale_from_tau` call and `zm2zt2zm` smoothing of `thlm` was removed.\u000a\u000aBITCHANGING for taus code due to removed smoothing.\u000a", "date" : "2024-06-19 16:36:12 -0500", "id" : "d5fb86b1bd228c5b17c18f63a17c0a37fead40ae", "msg" : "Ri zm calc (Part 1) - Combine and move call to calc_brunt_vaisala_freq_sqd (#1154)", "paths" : [ { "editType" : "edit", "file" : "advance_helper_module.F90" }, { "editType" : "edit", "file" : "mixing_length.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90", "mixing_length.F90" ], "commitId" : "323b3445d15537a72479ff1c41c59edd6b74f646", "timestamp" : 1718834177000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Ri_zm calc (Part 1.5) - Adjusted signature of diagnose_Lscale_from_tau #1145 (#1155)\u000a\u000aRi_zm calc (Part 1.5) - Adjusted signature of diagnose_Lscale_from_tau #1145\u000a", "date" : "2024-06-19 16:56:17 -0500", "id" : "323b3445d15537a72479ff1c41c59edd6b74f646", "msg" : "Ri_zm calc (Part 1.5) - Adjusted signature of diagnose_Lscale_from_tau #1145 (#1155)", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "mixing_length.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90" ], "commitId" : "96205889b3e27c8f482383f28de8a6dd08d36adb", "timestamp" : 1718884181000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Adds blank line so that I can note BIT_CHANGING:5df5fcb3d6c51d6af2e8017d270336eefa75ad3e\u000a", "date" : "2024-06-20 06:49:41 -0500", "id" : "96205889b3e27c8f482383f28de8a6dd08d36adb", "msg" : "Adds blank line so that I can note BIT_CHANGING:5df5fcb3d6c51d6af2e8017d270336eefa75ad3e", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mixing_length.F90", "advance_clubb_core_module.F90", "advance_xm_wpxp_module.F90", "advance_helper_module.F90" ], "commitId" : "1af8762fc4b0c31a64535f1cb6689d893d036926", "timestamp" : 1719948922000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Ri_zm calc (Part 2) - Move the brunt_vaisala smoothing into calc_brunt_vaisala_freq_sqd (#1156)\u000a\u000aCLUBB ticket #1145\u000a\u000aIncludes previous steps:\u000a* First step: Move call to calc_bv\u000a* Ri_zm calc (Part 1.5) - Adjusted signature of diagnose_Lscale_from_tau #1145\u000a\u000aNewest changes: Ri_zm calc (Part 2) - Move brunt_vaisala smoothing into calc_brunt_vaisala_freq_sqd\u000a\u000a`brunt_vaisala_frq_sqd_smth` is now calculated in subroutine `calc_brunt_vaisala_freq_sqd` and it is now written to disk in `advance_clubb_core` with all the other `brunt_vaisala` variables.\u000a\u000aUnfortunately, I had to make a couple more changes since moving this calculation into `calc_brunt_vaisala_freq_sqd` meant that any subroutine involved in calling `calc_stability_correction` would need to get `l_modify_limiters_for_cnvg_test` fed in, because `calc_brunt_vaisala_freq_sqd` is also called in `calc_stability_correction`.\u000a\u000aThis commit is BIT_CHANGING since `brunt_vaisala_frq_sqd_smth` used to be all zeros before this change in Lscale mode and now it is actually calculated. BFB in taus code.\u000a", "date" : "2024-07-02 14:35:22 -0500", "id" : "1af8762fc4b0c31a64535f1cb6689d893d036926", "msg" : "Ri_zm calc (Part 2) - Move the brunt_vaisala smoothing into calc_brunt_vaisala_freq_sqd (#1156)", "paths" : [ { "editType" : "edit", "file" : "advance_helper_module.F90" }, { "editType" : "edit", "file" : "mixing_length.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "runsam.bash", "jenkins_tests/sam_micro_drizzle_intel_test/Jenkinsfile", "jenkins_tests/sam_clubb_silhs_gfortran_build/Jenkinsfile", "Build", "Makefile", "jenkins_tests/sam_clubb_nvhpc_build/Jenkinsfile", "jenkins_tests/sam_clubb_pgi_build/Jenkinsfile" ], "commitId" : "3a5ba59e93df7a18da1558756104d3373b5fb2f5", "timestamp" : 1720730151000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Spack updates (#156)\u000a\u000a* Initial changes to get code working with spack. Also a lot of cleanup+enhancements to make running easier. https://github.com/larson-group/sys_admin/issues/829\u000a\u000a* Adding flag to disable uninit check for intel. This seems to be new for ifx and causes problems easily. A similar issue was noted for cam when compiling with intel, see https://github.com/larson-group/sys_admin/issues/829\\#issuecomment-2209596620. Problems with this option are also discussed on this thread https://community.intel.com/t5/Intel-Fortran-Compiler/MemorySanitizer-use-of-uninitialized-value/td-p/1512631\u000a\u000a* Making changes to jenkins tests to get running with new system and new Makefile changes.\u000a\u000a* Renaming the pgi test to use nvhpc\u000a", "date" : "2024-07-11 15:35:51 -0500", "id" : "3a5ba59e93df7a18da1558756104d3373b5fb2f5", "msg" : "Spack updates (#156)", "paths" : [ { "editType" : "delete", "file" : "jenkins_tests/sam_clubb_pgi_build/Jenkinsfile" }, { "editType" : "edit", "file" : "jenkins_tests/sam_clubb_silhs_gfortran_build/Jenkinsfile" }, { "editType" : "add", "file" : "jenkins_tests/sam_clubb_nvhpc_build/Jenkinsfile" }, { "editType" : "edit", "file" : "runsam.bash" }, { "editType" : "edit", "file" : "Build" }, { "editType" : "edit", "file" : "jenkins_tests/sam_micro_drizzle_intel_test/Jenkinsfile" }, { "editType" : "edit", "file" : "Makefile" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "parameters_tunable.F90" ], "commitId" : "c5fc4e56b888f2b322372097522a5695b3b1386f", "timestamp" : 1720755417000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "This code in adj_low_res_nu was using the ghost point when\u000agrid_type = 2. This has now been changed to not include the ghost\u000alevel. This code is BIT_CHANGING.\u000a", "date" : "2024-07-11 22:36:57 -0500", "id" : "c5fc4e56b888f2b322372097522a5695b3b1386f", "msg" : "This code in adj_low_res_nu was using the ghost point when", "paths" : [ { "editType" : "edit", "file" : "parameters_tunable.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "latin_hypercube_driver_module.F90" ], "commitId" : "916b5a9793d042cc969aec6dabc5abbda67f2100", "timestamp" : 1720943555000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "I am updating the SILHS code that calculates k_lh_start to work\u000aconsistently with ghostless CLUBB. This commit is BIT_CHANGING.\u000a", "date" : "2024-07-14 02:52:35 -0500", "id" : "916b5a9793d042cc969aec6dabc5abbda67f2100", "msg" : "I am updating the SILHS code that calculates k_lh_start to work", "paths" : [ { "editType" : "edit", "file" : "latin_hypercube_driver_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "stats_clubb_utilities.F90", "advance_clubb_core_module.F90" ], "commitId" : "fddad9485d30abe6c743a4be0445fdfe3a6a0a2e", "timestamp" : 1721188165000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "I am committing changes to stats output for cloud_cover, rcm_in_layer,\u000aand z_cloud base owing to the gymnastics it takes to avoid the\u000aghost point in calculations. These changes are BIT_CHANGING, but\u000athey don't change the answer.\u000a", "date" : "2024-07-16 22:49:25 -0500", "id" : "fddad9485d30abe6c743a4be0445fdfe3a6a0a2e", "msg" : "I am committing changes to stats output for cloud_cover, rcm_in_layer,", "paths" : [ { "editType" : "edit", "file" : "stats_clubb_utilities.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "latin_hypercube_driver_module.F90" ], "commitId" : "6bb6d06fa0a70a779d86161b235282f847ef604e", "timestamp" : 1721242346000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "There were furhter issues found with the k_lh_start code.\u000a\u000aThe code would find that sometimes, the maximum location of rcm\u000ain cloud would occur at the ghost level, k = 1, and set that level\u000aas k_lh_start for SILHS. This is undesirable for two reasons:\u000a1) k_lh_start should be set around a legimate, \"within domain\" grid\u000alevel; and\u000a2) Setting k_lh_start to 1 is unachievable for the ghostless branch\u000aof the model, making a match between the master and clubb_ghost_exorcism\u000abranhes unattainable.\u000a\u000aThe issue is corrected here by allowing the maxloc function to only\u000asearch over \"in-domain levels\" for maximum cloud. The results are\u000aBIT_CHANGING.\u000a", "date" : "2024-07-17 13:52:26 -0500", "id" : "6bb6d06fa0a70a779d86161b235282f847ef604e", "msg" : "There were furhter issues found with the k_lh_start code.", "paths" : [ { "editType" : "edit", "file" : "latin_hypercube_driver_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90", "mixing_length.F90", "advance_helper_module.F90" ], "commitId" : "8662dc283f8186f9dc900d82a63fbc46abc65851", "timestamp" : 1721258040000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Ri_zm calc (Part 3) - Moving calculations for Ri_zm out of diagnose_Lscale_from_taus (#1157)\u000a\u000aCLUBB tocket #1145\u000aBIT_CHANGING for lscale since Ri_zm was not calculated before.\u000a\u000a1. mixing_length.F90:\u000a- Removed unused input variables from diagnose_Lscale_from_taus: um, vm, exner, p_in_Pa, rtm, thlm, thvm, rcm, saturation_formula, l_brunt_vaisala_freq_moist, l_use_thvm_in_bv_freq, l_modify_limiters_for_cnvg_test; added ddzt_umvm_sqd as input; changed Ri_zm from out to in\u000a- Removed unused brunt_vaisala_freq_sqd variables from diagnose_Lscale_from_tau\u000a- Removed calculations for Ri_zm and ddzt_umvm_sqd\u000a- Fixed some line length issues\u000a\u000a2. advance_helper_module.F90\u000a- Removed unused input variables and imports\u000a- Fixed some line length issues\u000a\u000a3. advance_clubb_core_module.F90\u000a- Added calculations for ddzt_umvm_sqd and Ri_zm\u000a- Adjusted subroutine calls\u000a- Fixed some line length issues\u000a", "date" : "2024-07-17 18:14:00 -0500", "id" : "8662dc283f8186f9dc900d82a63fbc46abc65851", "msg" : "Ri_zm calc (Part 3) - Moving calculations for Ri_zm out of diagnose_Lscale_from_taus (#1157)", "paths" : [ { "editType" : "edit", "file" : "advance_helper_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "mixing_length.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "latin_hypercube_driver_module.F90" ], "commitId" : "fd2a66ac11b726371135f2233834e2e87562682c", "timestamp" : 1721277738000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "In my previous commit, I changed the domain of the maxloc commands\u000ain the computation of k_lh_start to check over the arrays from\u000alevels 2:nz. However, when that happens, the output will be offset\u000aby 1. Consider a situation where the rcm max is at level 2. By being\u000apassed 2 through nz only, maxloc will return a value of 1. I needed\u000ato add +1 to the output to rectify this issue. The results\u000aare BIT_CHANGING.\u000a", "date" : "2024-07-17 23:42:18 -0500", "id" : "fd2a66ac11b726371135f2233834e2e87562682c", "msg" : "In my previous commit, I changed the domain of the maxloc commands", "paths" : [ { "editType" : "edit", "file" : "latin_hypercube_driver_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "precipitation_fraction.F90", "stats_clubb_utilities.F90" ], "commitId" : "0df67106e4001e1eda48b4740fe1b065df06cd77", "timestamp" : 1721289115000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "This commit brings the stats output from the all cases run with\u000athe master branch (using the default configuration) in\u000abit-for-bit agreement with the stats output from all cases run\u000awith the clubb_ghost_exorcism branch. Of course, this agreement\u000aignores the ghost level output in the zt files run with the\u000amaster branch. This commit is technically BIT_CHANGING because\u000ait alters a few stats for a couple cases, but does not change results.\u000a", "date" : "2024-07-18 02:51:55 -0500", "id" : "0df67106e4001e1eda48b4740fe1b065df06cd77", "msg" : "This commit brings the stats output from the all cases run with", "paths" : [ { "editType" : "edit", "file" : "precipitation_fraction.F90" }, { "editType" : "edit", "file" : "stats_clubb_utilities.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "pdf_closure_module.F90" ], "commitId" : "3e891b5d456b4ea869955e73e012cdd21813c1d9", "timestamp" : 1721347695000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "Committing a change that will initialize this set of variables\u000aunder all circumstances. This change does not affect output\u000aexcept when the New Hybrid PDF is used. In the case of the\u000aNew Hybrid PDF, the variables F_rt, F_thl, F_rt_min, F_rt_max,\u000aF_thl_min, and F_thl_max were never initialized and never set\u000a(they are not part of the New Hybrid PDF -- only in the original\u000aNew PDF), resulting NaN values being output to stat files.\u000a", "date" : "2024-07-18 19:08:15 -0500", "id" : "3e891b5d456b4ea869955e73e012cdd21813c1d9", "msg" : "Committing a change that will initialize this set of variables", "paths" : [ { "editType" : "edit", "file" : "pdf_closure_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_xp2_xpyp_module.F90" ], "commitId" : "23f82fdc538b5a645dba8762085bfa621791cf47", "timestamp" : 1721419124000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "Making a change to the l_C2_cloud_frac option with advance_xp2_xpyp.\u000aCloud fraction needed to be interpolated to momentum levels for\u000aproper use in the code.\u000a\u000aSince this code change does not change CLUBB's default configuration,\u000aresults are bit-for-bit for the default configuration.\u000a", "date" : "2024-07-19 14:58:44 -0500", "id" : "23f82fdc538b5a645dba8762085bfa621791cf47", "msg" : "Making a change to the l_C2_cloud_frac option with advance_xp2_xpyp.", "paths" : [ { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90", "clubb_api_module.F90" ], "commitId" : "9109926fff1ccf00b6495ec70ae57350d85a32ce", "timestamp" : 1721424813000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Fixing bug. qclvar copying is handled by the api, but we were deleting it with an unstructured data statement. I added this due as a fix before thinking qclvar was a local variable, which happened because I mixed up the CLUBB_CAM and CLUBBND_CAM flags. https://github.com/larson-group/cam/issues/175\u000a", "date" : "2024-07-19 15:33:33 -0600", "id" : "9109926fff1ccf00b6495ec70ae57350d85a32ce", "msg" : "Fixing bug. qclvar copying is handled by the api, but we were deleting it with an unstructured data statement. I added this due as a fix before thinking qclvar was a local variable, which happened because I mixed up the CLUBB_CAM and CLUBBND_CAM flags. https://github.com/larson-group/cam/issues/175", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SCRIPTS/LES_setup/setup_LES_KK_micro.bash", "SCRIPTS/UCAR/run_sam.casper", "SCRIPTS/CHEYENNE/run_sam.cheyenne", "SCRIPTS/UCAR/run_sam.derecho" ], "commitId" : "4016cd1964bf1f823be39c6275e7e663d8e41b13", "timestamp" : 1722377234000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephens", "fullName" : "benjamin.andrew.stephens" }, "authorEmail" : "benjamin.andrew.stephens@gmail.com", "comment" : "removing cheyenne-related content and adding new content for\u000aderecho and casper machines.\u000a", "date" : "2024-07-30 16:07:14 -0600", "id" : "4016cd1964bf1f823be39c6275e7e663d8e41b13", "msg" : "removing cheyenne-related content and adding new content for", "paths" : [ { "editType" : "add", "file" : "SCRIPTS/UCAR/run_sam.casper" }, { "editType" : "delete", "file" : "SCRIPTS/CHEYENNE/run_sam.cheyenne" }, { "editType" : "edit", "file" : "SCRIPTS/LES_setup/setup_LES_KK_micro.bash" }, { "editType" : "add", "file" : "SCRIPTS/UCAR/run_sam.derecho" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mono_flux_limiter.F90" ], "commitId" : "c304d15ab5483f1e7f0b0de1b9f01f06fb7d09b9", "timestamp" : 1722452248000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Fixing GPU bug. There is a vertical dependency with wpxp. This is what was breaking the ECT test, see larson-group/cam#175\u000a", "date" : "2024-07-31 13:57:28 -0500", "id" : "c304d15ab5483f1e7f0b0de1b9f01f06fb7d09b9", "msg" : "Fixing GPU bug. There is a vertical dependency with wpxp. This is what was breaking the ECT test, see larson-group/cam#175", "paths" : [ { "editType" : "edit", "file" : "mono_flux_limiter.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90", "pdf_closure_module.F90" ], "commitId" : "32a74a3cbba967b1b3558708ca78d7929dee6d60", "timestamp" : 1722455629000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Fixing bugs that are only caught when not outputting w_[up/down]_in_cloud stats or if l_host_applies_sfc_fluxes=.true. The l_host_applies_sfc_fluxes=.true. isn't testable (at least not in clubb_standalone), and I just caught that visually. The cloudy_updraft_frac and cloudy_downdraft_frac fields not being set were only noticable in cam, because we always run with iw_up_in_cloud>0 and iw_down_in_cloud>0 to output stats.\u000a", "date" : "2024-07-31 14:53:49 -0500", "id" : "32a74a3cbba967b1b3558708ca78d7929dee6d60", "msg" : "Fixing bugs that are only caught when not outputting w_[up/down]_in_cloud stats or if l_host_applies_sfc_fluxes=.true. The l_host_applies_sfc_fluxes=.true. isn't testable (at least not in clubb_standalone), and I just caught that visually. The cloudy_updraft_frac and cloudy_downdraft_frac fields not being set were only noticable in cam, because we always run with iw_up_in_cloud>0 and iw_down_in_cloud>0 to output stats.", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "pdf_closure_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "clubb_api_module.F90" ], "commitId" : "55c6276fbb2a1eb3db01e7b71a7909c22b694d3d", "timestamp" : 1722465051000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Moving pdf_params copying to copyin. This is the data structure that contains pointers, and these pointers will be different on the host and device, so it is bad in theory to copy the structure back to the CPU as it might overwrite cpu memory pointers with gpu memory pointers. In practice though I've seen no problems caused by this, I'm just making this commit preemptively, and it has already been tested with the ECT test.\u000a", "date" : "2024-07-31 17:30:51 -0500", "id" : "55c6276fbb2a1eb3db01e7b71a7909c22b694d3d", "msg" : "Moving pdf_params copying to copyin. This is the data structure that contains pointers, and these pointers will be different on the host and device, so it is bad in theory to copy the structure back to the CPU as it might overwrite cpu memory pointers with gpu memory pointers. In practice though I've seen no problems caused by this, I'm just making this commit preemptively, and it has already been tested with the ECT test.", "paths" : [ { "editType" : "edit", "file" : "clubb_api_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SCRIPTS/UCAR/run_sam.casper", "SCRIPTS/UCAR/run_sam.derecho" ], "commitId" : "e2e09f6e2ad17b4fa461937c1c48328bb502ed7b", "timestamp" : 1723062789000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephens", "fullName" : "benjamin.andrew.stephens" }, "authorEmail" : "benjamin.andrew.stephens@gmail.com", "comment" : "Fixing mpirun command in the derecho and casper batch scripts.\u000a", "date" : "2024-08-07 14:33:09 -0600", "id" : "e2e09f6e2ad17b4fa461937c1c48328bb502ed7b", "msg" : "Fixing mpirun command in the derecho and casper batch scripts.", "paths" : [ { "editType" : "edit", "file" : "SCRIPTS/UCAR/run_sam.casper" }, { "editType" : "edit", "file" : "SCRIPTS/UCAR/run_sam.derecho" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SCRIPTS/LES_setup/setup_LES_KK_micro.bash" ], "commitId" : "639a2929338c80ed393b93f2c55b50baad05b91a", "timestamp" : 1723127615000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephens", "fullName" : "benjamin.andrew.stephens" }, "authorEmail" : "benjamin.andrew.stephens@gmail.com", "comment" : "Editing the LES setup script to give instructions for UCAR computers.\u000a", "date" : "2024-08-08 08:33:35 -0600", "id" : "639a2929338c80ed393b93f2c55b50baad05b91a", "msg" : "Editing the LES setup script to give instructions for UCAR computers.", "paths" : [ { "editType" : "edit", "file" : "SCRIPTS/LES_setup/setup_LES_KK_micro.bash" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_wp2_wp3_module.F90", "advance_xm_wpxp_module.F90" ], "commitId" : "d135c3d79b104de8ec0d611cf9854c542ee16919", "timestamp" : 1723145344000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Added zt2zm2zt-smoothing to remove noise in MPACE_B winds (#1161)\u000a\u000aBIT_CHANGING\u000a\u000aIn order to remove noise in the wind fields in MPACE_B, we added some smoothing.\u000a\u000a* Added `zt2zm2zt`-smoothing to `diagnose_upxp` calls in `advance_xm_wpxp`\u000a* Added `zm2zt2zm`-smoothing to `wp2` and `em` vars fed into `wp3_term_pr_turb_rhs` in `advance_wp2_wp3`\u000a* Changed C_wp2_splat to 0.00 in default tunable_parameters.in\u000a", "date" : "2024-08-08 14:29:04 -0500", "id" : "d135c3d79b104de8ec0d611cf9854c542ee16919", "msg" : "Added zt2zm2zt-smoothing to remove noise in MPACE_B winds (#1161)", "paths" : [ { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" }, { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "tunable_parameters.in" ], "commitId" : "a38c90830d6f11dea4c8abe6f341d22368e3e1b3", "timestamp" : 1723145344000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Added zt2zm2zt-smoothing to remove noise in MPACE_B winds (#1161)\u000a\u000aBIT_CHANGING\u000a\u000aIn order to remove noise in the wind fields in MPACE_B, we added some smoothing.\u000a\u000a* Added `zt2zm2zt`-smoothing to `diagnose_upxp` calls in `advance_xm_wpxp`\u000a* Added `zm2zt2zm`-smoothing to `wp2` and `em` vars fed into `wp3_term_pr_turb_rhs` in `advance_wp2_wp3`\u000a* Changed C_wp2_splat to 0.00 in default tunable_parameters.in\u000a", "date" : "2024-08-08 14:29:04 -0500", "id" : "a38c90830d6f11dea4c8abe6f341d22368e3e1b3", "msg" : "Added zt2zm2zt-smoothing to remove noise in MPACE_B winds (#1161)", "paths" : [ { "editType" : "edit", "file" : "tunable_parameters.in" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "parameters_model.F90" ], "commitId" : "9153bbbc08436d993c2bb238095026e750059b72", "timestamp" : 1723145363000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Moving PosInf to clubb_model_settings.F90\u000a", "date" : "2024-08-08 14:29:23 -0500", "id" : "9153bbbc08436d993c2bb238095026e750059b72", "msg" : "Moving PosInf to clubb_model_settings.F90", "paths" : [ { "editType" : "edit", "file" : "parameters_model.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SRC/CLUBB/mean_adv.F90", "SRC/CLUBB/advance_clubb_core_module.F90", "SRC/SGS_CLUBB/sgs.F90", "SRC/CLUBB/setup_clubb_pdf_params.F90", "SRC/CLUBB/sigma_sqd_w_module.F90", "SRC/CLUBB/turbulent_adv_pdf.F90", "SRC/CLUBB/advance_xm_wpxp_module.F90", "SRC/CLUBB/clip_explicit.F90", "SRC/SILHS/silhs_api_module.F90", "SRC/SILHS/output_2D_samples_module.F90", "SRC/CLUBB/advance_wp2_wp3_module.F90", "SRC/CLUBB/hydromet_pdf_parameter_module.F90", "SRC/CLUBB/pdf_closure_module.F90", "SRC/CLUBB/fill_holes.F90", "SRC/CLUBB/diffusion.F90", "SRC/CLUBB/mixing_length.F90", "SRC/CLUBB/grid_class.F90", "SRC/MICRO_M2005_UWM/microphysics.F90", "SRC/CLUBB/stats_clubb_utilities.F90", "SRC/CLUBB/advance_xp2_xpyp_module.F90", "SRC/SGS_CLUBB/clubb_sgs.F90", "SRC/stepout_module.F90", "SRC/CLUBB/numerical_check.F90", "SRC/CLUBB/Skx_module.F90", "SRC/CLUBB/sfc_varnce_module.F90", "SRC/CLUBB/mono_flux_limiter.F90", "SRC/CLUBB/calc_pressure.F90", "SRC/CLUBB/advance_helper_module.F90", "SRC/CLUBB/parameters_model.F90", "SRC/CLUBB/stats_type.F90", "SRC/CLUBB/precipitation_fraction.F90", "SRC/CLUBB/parameters_tunable.F90", "SRC/SILHS/transform_to_pdf_module.F90", "SRC/SILHS/est_kessler_microphys_module.F90", "SRC/SILHS/latin_hypercube_driver_module.F90", "SRC/CLUBB/adg1_adg2_3d_luhar_pdf.F90", "SRC/CLUBB/advance_windm_edsclrm_module.F90", "SRC/micro_field_utils.F90", "SRC/CLUBB/pos_definite_module.F90", "SRC/SILHS/lh_microphys_var_covar_module.F90", "SRC/CLUBB/clubb_api_module.F90", "SRC/CLUBB/advance_xp3_module.F90", "SRC/SGS_CLUBB/clubbvars.F90", "SRC/SGS_CLUBB/stat_clubb.F90", "SRC/CLUBB/sponge_layer_damping.F90" ], "commitId" : "641a3da63ff867cb33c6228d1cfb5207b68c6572", "timestamp" : 1723491201000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "Updated for ghostless version of CLUBB.\u000a", "date" : "2024-08-12 14:33:21 -0500", "id" : "641a3da63ff867cb33c6228d1cfb5207b68c6572", "msg" : "Updated for ghostless version of CLUBB.", "paths" : [ { "editType" : "edit", "file" : "SRC/SGS_CLUBB/stat_clubb.F90" }, { "editType" : "edit", "file" : "SRC/micro_field_utils.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/diffusion.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/sfc_varnce_module.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/turbulent_adv_pdf.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/pdf_closure_module.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/setup_clubb_pdf_params.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/advance_xp3_module.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/mono_flux_limiter.F90" }, { "editType" : "edit", "file" : "SRC/SILHS/output_2D_samples_module.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/clubb_api_module.F90" }, { "editType" : "edit", "file" : "SRC/SILHS/transform_to_pdf_module.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/advance_windm_edsclrm_module.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/hydromet_pdf_parameter_module.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/mixing_length.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/grid_class.F90" }, { "editType" : "edit", "file" : "SRC/SILHS/latin_hypercube_driver_module.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/sigma_sqd_w_module.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/advance_helper_module.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/calc_pressure.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/pos_definite_module.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/stats_type.F90" }, { "editType" : "edit", "file" : "SRC/SGS_CLUBB/clubbvars.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/precipitation_fraction.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/sponge_layer_damping.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/advance_wp2_wp3_module.F90" }, { "editType" : "edit", "file" : "SRC/SILHS/est_kessler_microphys_module.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/parameters_model.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/parameters_tunable.F90" }, { "editType" : "edit", "file" : "SRC/stepout_module.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/fill_holes.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/adg1_adg2_3d_luhar_pdf.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/advance_xm_wpxp_module.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/numerical_check.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/stats_clubb_utilities.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/Skx_module.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/clip_explicit.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/mean_adv.F90" }, { "editType" : "edit", "file" : "SRC/MICRO_M2005_UWM/microphysics.F90" }, { "editType" : "edit", "file" : "SRC/SILHS/silhs_api_module.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/advance_xp2_xpyp_module.F90" }, { "editType" : "edit", "file" : "SRC/SGS_CLUBB/clubb_sgs.F90" }, { "editType" : "edit", "file" : "SRC/SILHS/lh_microphys_var_covar_module.F90" }, { "editType" : "edit", "file" : "SRC/SGS_CLUBB/sgs.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SRC/CLUBB/advance_xm_wpxp_module.F90", "SRC/CLUBB/parameters_model.F90", "SRC/SGS_CLUBB/sgs.F90", "SRC/CLUBB/advance_wp2_wp3_module.F90", "SRC/SGS_CLUBB/clubb_sgs.F90" ], "commitId" : "54361922bf9e85b072e7b13e863123146e98eed2", "timestamp" : 1723561213000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "Updating to the latest version of CLUBB.\u000a\u000aIf the call to set random initial perturbations are commented out,\u000aa bit-for-bit match can be obtained to results from the current master\u000abranch.\u000a", "date" : "2024-08-13 10:00:13 -0500", "id" : "54361922bf9e85b072e7b13e863123146e98eed2", "msg" : "Updating to the latest version of CLUBB.", "paths" : [ { "editType" : "edit", "file" : "SRC/CLUBB/advance_xm_wpxp_module.F90" }, { "editType" : "edit", "file" : "SRC/SGS_CLUBB/sgs.F90" }, { "editType" : "edit", "file" : "SRC/SGS_CLUBB/clubb_sgs.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/parameters_model.F90" }, { "editType" : "edit", "file" : "SRC/CLUBB/advance_wp2_wp3_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "latin_hypercube_driver_module.F90" ], "commitId" : "0c35bdb2e850e41bab982505438cc7b575c3cde4", "timestamp" : 1723785812000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Nightly clubb plots (#1167)\u000a\u000a* Making step to plot output, copy to pub folder, then create an index.html file to display all plots in that folder.\u000a\u000a* Small tweaks\u000a\u000a* Small fixes in pyplotgen.\u000a\u000a* Copy needs -r\u000a\u000a* Using jenkins env variables and switching to scp/ssh commands to allow plots to be generated and created on any machine.\u000a\u000a* Adding quotes are env variable usage\u000a\u000a* Pyplotgen addition to create a git_info file containing branch and commit name.\u000a\u000a* Script should handle the pyplotgen _generated_on_... suffix.\u000a\u000a* Making script only run arm again during testing.\u000a\u000a* More robust way to get git branch in pyplotgen.\u000a\u000a* Testing single quotes\u000a\u000a* Making all cases run again.\u000a\u000a* Undoing most pyplotgen changes. Making create_plot_list script general and take in a directory. Returning short run test mode.\u000a\u000a* Update to create git_info line\u000a\u000a* Making all cases run again and adding plot support for ifort.\u000a\u000a* Adding plot step to nvhpc gpu diffness test.\u000a\u000a* Fixing error\u000a\u000a* Reverting diffness script, making new one specifically for plotting.\u000a\u000a* Changes to allow plotting of previous output.\u000a\u000a* Setting O0 for testing\u000a\u000a* Branch folder restructure.\u000a\u000a* Making tests run all cases again and update master output only.\u000a\u000a* Clean up and naming changes.\u000a\u000a* Addin -O2 back.\u000a\u000a* Small update to pyplotgen to make title reflect name of output specified in command.\u000a\u000a* This cuda call doesn't work with the subscript for some reason.\u000a\u000a* Making only priority cases run for GPU plot test and preventin it from running on carson\u000a", "date" : "2024-08-16 00:23:32 -0500", "id" : "0c35bdb2e850e41bab982505438cc7b575c3cde4", "msg" : "Nightly clubb plots (#1167)", "paths" : [ { "editType" : "edit", "file" : "latin_hypercube_driver_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_xm_wpxp_module.F90", "clubb_api_module.F90", "clip_explicit.F90", "grid_class.F90", "setup_clubb_pdf_params.F90", "advance_windm_edsclrm_module.F90", "mono_flux_limiter.F90", "advance_helper_module.F90", "advance_wp2_wp3_module.F90", "mixing_length.F90", "advance_xp2_xpyp_module.F90", "Skx_module.F90", "pdf_closure_module.F90", "adg1_adg2_3d_luhar_pdf.F90", "calc_pressure.F90", "precipitation_fraction.F90", "diffusion.F90", "numerical_check.F90", "pos_definite_module.F90", "hydromet_pdf_parameter_module.F90", "parameters_tunable.F90", "sponge_layer_damping.F90", "turbulent_adv_pdf.F90", "advance_xp3_module.F90", "advance_clubb_core_module.F90", "mean_adv.F90", "fill_holes.F90", "stats_type.F90", "sigma_sqd_w_module.F90", "stats_clubb_utilities.F90", "sfc_varnce_module.F90" ], "commitId" : "90c974765822217b0693858a0ac0f115c5b964a2", "timestamp" : 1724333265000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Clubb ghost exorcism (#1159)\u000a\u000a* I am adding grid_class_new.F90 to the code as a copy of grid_class.F90.\u000a\u000aThe first step toward removing the ghost level from the model is to\u000amodify the grid file. Having a second grid file in play will allow\u000afunctions and subroutines that are undergoing modification earlier in\u000athis process to use the new file, while functions and subroutines that\u000ahave not yet been modified will continue to use the old grid file\u000auntil they can be modified.\u000a\u000aAt the end of this process, the old grid file will be able to be\u000aremoved and grid_class_new.F90 will simply be able to be renamed\u000agrid_class.F90 at that point.\u000a\u000aIn this commit, I have altered the schematic and the comments\u000aat the very start of the module to be \"ghostless\".\u000a\u000a* Updated grid_class for the changes to the grid interpolation weighting\u000afunctions for the new \"ghostless\" ascending grid.\u000a\u000a* Committing some updates to the new grid class file for ghostless\u000aascending.\u000a\u000a* Updating to match recent changes made to grid_class.F90.\u000a\u000a* I finished the removal of the ghost level from the entirety of the new\u000agrid_class file. This standalone file compiles successfully.\u000a\u000a* Removing the sources of compiler warnings in grid_class_new.F90 (these\u000awere carried over from grid_class.F90).\u000a\u000a* Committing progress in advance_wp2_wp3_module.F90 with regards to\u000aghostless grid.\u000a\u000a* I am committing the updated version of grid_class_new.F90 that allows\u000aall cases to run, regardless of grid_type.\u000a\u000a* Fixed a bug in grid_class_new.F90\u000a\u000aWhen grid_type = 2, the calculations of the indices begin_height and\u000aend_height are based on the thermodynamic level grids. Those grid indices\u000ashould be used in the call to setup_grid_heights, where the array of\u000athermodynamic_heights, from index begin_height to index end_height,\u000ashould become gr%zt.\u000a\u000aWhen grid_type - 3, the calculations of the indices begin_height and\u000aend_height are based on the momentum grid levels.\u000a\u000aEither way, momentum_heights and thermodynamic_heights should both\u000ahave the array from begin_height to end_height passed in. When\u000agrid_type = 2, only the thermodynamic height array is relevant in\u000athe setup. When grid_type = 3, only the momentum height array is\u000arelevant in the setup.\u000a\u000a* For thermodynamic_height, 1:nzmax-1 is the entire array, but I\u000aentered this for a clarification, especially considering the\u000afollowing check block.\u000a\u000a* Updated grid_class_new to better handle the begin_height and end_height indices.\u000a\u000a* Some modifications to advance_wp2_wp3\u000a\u000a* Committed some temporary code.\u000a\u000a* committed some temporary changes to clubb_api_module.\u000a\u000a* Making a bunch of commits to clubb_driver that are mainly temporary for\u000ainterface and printing purposes.\u000a\u000a* Deghosted another subroutine.\u000a\u000a* Updated wp2_term_ta_lhs to use the new gridding.\u000a\u000a* De-ghosting wp2_terms_ac_pr2_lhs\u000a\u000a* De-ghosted wp2_term_pr3_rhs\u000a\u000a* Deghosting wp3_term_tp_lhs.\u000a\u000a* Deghosted wp3_terms_ac_pr2_lhs\u000a\u000a* Updated the wp3_term_ta_ADG1_lhs subroutine to use boundary conditions\u000awhere wp3 (at the top level and bottom momentum levels of the model)\u000ais assumed to have a value of 0.\u000a\u000a* For single loop vectors, removing the \"collapse(2)\" from the acc\u000astatements.\u000a\u000aThis commit is not bit changing, but the previous commit to this branch\u000awas BIT_CHANGING:902d6caed8a4533f59f4165106276959b4f90895\u000a\u000a* I updated wp3_term_ta_explicit_rhs for the ghostless grid.\u000a\u000aWhen l_explicit_turbulent_adv_wp3 is turned on, the results from\u000athis branch exactly match those found on the master branch.\u000a\u000a* Updating diffusion_zm_lhs for \"Ghostless\" gridding.\u000a\u000a* Fixed a typo in the comments that was introduced in the previous commit.\u000a\u000a* Updated for \"ghostless\" diffusion.\u000a\u000a* With wp3 now being set to a fixed-point boundary condition value\u000aof 0 at the current thermodynamic level 1 (first t-lev above the\u000asurface), it is not necessary to loop over level 1 within the code\u000afor each wp3 term.\u000a\u000aAlso contains code to enforce a fixed-point boundary condition\u000aof wp3=0 at the first thermodynamic level above the surface.\u000a\u000a* Restoring diffusion to the way it should be for the exorcised ghost grid\u000aprior to the most recent master merge. Lines for the ghost point were\u000aaccidentally added during the merge commit.\u000a\u000a* Updated code to correct wp3_bp1 and wp3_pr2 budget terms so that\u000athey still match bit-for-bit what is found in the master branch.\u000a\u000a* Updating term_ma_zm_lhs for ghostless gridding. Results are bit-for-bit\u000aidentical.\u000a\u000a* After debugging, I am now committing the ghostless version of\u000aterm_ma_zt_lhs.\u000a\u000a* Updating the clubb_ghost_exorcism branch for ghostless wp23 rhs,\u000alhs, and solve.\u000a\u000aThis revision runs; however, there are still some issues tracking\u000adown the source of problems in maintaining bit-for-bit results.\u000a\u000a* Updated to maintain bit-for-bitness with the master code.\u000a\u000a* Finished exorcising the ghost from advance_wp2_wp3_module.F90.\u000a\u000a* Small openacc changes to fix GPU runs\u000a\u000a* Adjusting new hybrid PDF code to continue to match the master branch\u000abit-for-bit while construction continues.\u000a\u000a* Committing the first portion of a nomenclature change where the number\u000aof momentum vertical grid levels is denoted as nzm rather than nz.\u000a\u000a* Changing the notation of the number of grid levels on the momentum grid,\u000apreviously nz, to nzm in some files.\u000a\u000a* Changed some comments and a little bit of code in the new grid_class\u000afile to provide a better description.\u000a\u000a* Updated sigma_sqd_w_module for ghostless gridding.\u000a\u000a* I added the new \"ghostless\" discretization to turbulent_adv_pdf.F90,\u000aand also appropriately altered the points in the code where the\u000aturbulent advection subroutines are called from in\u000aadvance_xm_wpxp_module.F90 and advance_xp2_xpyp_module.F90.\u000a\u000aThe code produced bit-for-bit results in regards to the standard\u000aconfiguration, the new hybrid PDF configuration, and also for the\u000aconfiguration with the godunov flags turned on.\u000a\u000a* Altered many of the lower-level subroutines in\u000aadvance_xp2_xpyp_module.F90 for ghostless gridding.\u000a\u000a* Upgraded subroutine calc_xp2_xpyp_ta_terms for ghostless discretization.\u000a\u000aThis should alter the results when the new_hybrid PDF is used in\u000aconjunction with upwind discretization, but it doesn't alter the\u000aresults for anything else.\u000a\u000a* Completed making advance_xp2_xpyp ghostless.\u000a\u000a* Completed the de-ghosting of advance_windm_edsclrm.\u000a\u000aResults are BIT_CHANGING because the ghost level was interacting with\u000athe results.\u000a\u000a* The call to calc_xpwp from advance_microphys was not supposed to be\u000aupdated yet. It wound up being sort of \"partially updated\" for\u000aghostless gridding, which was a bug that led to some diagnostic output\u000afields not being bit-for-bit. In this commit, I returned it to its prior\u000aform so that zm output files once again retain bit-for-bit status\u000abetween this branch and the master.\u000a\u000a* The ghost point interface statements after the return from\u000aadvance_windm_edsclrm needed to be encased in the same conditional\u000astatements that the calculations occurred in with the aforementioned\u000asubroutine. This change fixes a bug where a handful of cases had results\u000athat were not bit-for-bit from revisions before this code was added.\u000a\u000a* Fixed bug where the wrong stats were being recorded to the stats\u000afor coef_wpthlp2_implicit, etc.\u000a\u000a* I am committing a bug fix to the implicit surface flux calculation\u000ain the eddy-diffusivity wind code (which is used when\u000al_predict_upwp_vpwp is turned off).\u000a\u000aI am also committing some temporary ghost point interface stats code\u000awithin advance_windm_edsclrm.\u000a\u000a* I updated the diagrams in advance_windm_edsclrm to reflect the\u000anew ghostless grid.\u000a\u000a* I improved the description section of advance_windm_edsclrm.\u000a\u000a* Made numerous low-level subroutines ghostless within\u000aadvance_xm_wpxp_module.F90. Maintained bit-for-bit results\u000awith the master branch.\u000a\u000a* I am updating the xm wpxp code that calls the wpxp turbulent advection\u000aterm based on your PDF and option for ghostless gridding.\u000a\u000a* Updating some of the lower-level functions of the monotonic flux limiter\u000afor ghostless gridding.\u000a\u000a* I have updated the monotonic flux limiter for ghostless gridding!\u000a\u000a* A couple of redundant declarations were brought in on the last merge.\u000a\u000a* Committing further updates to ghostless gridding, including:\u000a\u000a1) Further modifications to advance_xm_wpxp, which includes branching\u000aout in Brunt-Vaisala frequency calculations in advance_helper;\u000a\u000a2) Update in calculating the initial pressure;\u000a\u000aand 3) updating grid class new to use the same \"value drop down\"\u000ain the zt2zm function and \"derivative drop down\" in the ddzt function\u000athat are now used in grid_class in the master.\u000a\u000aResults are bit-for-bit identical with the master.\u000a\u000a* Updated xm_wpxp_lhs for ghostless gridding.\u000a\u000a* Made xm_wpxp_rhs ghostless.\u000a\u000a* Updated xm_wpxp_solve for ghostless gridding!\u000a\u000a* Updating pos_definite_module.F90 for ghostless gridding.\u000a\u000a* Updated vertical hole filling and xm clipping and stats for\u000aghost point removal.\u000a\u000aResults are still bit-for-bit with the master branch.\u000a\u000a* Updated advance_xm_wpxp to remove the ghost point.\u000a\u000a* Updating some zt stats to use a value of 0 for the \"ghost\" level.\u000a\u000a* Updated subroutine compute_mixing_length for ghostless gridding.\u000a\u000a* Removing the ghost point from calculate_Lscale_directly\u000a\u000a* Added a \"ghostbuster\" option (-g) in the run_bindiff_all.py python\u000ascript that omits the \"ghost\" level from the comparison for _zt.nc\u000aoutput files when envoked.\u000a\u000a* I de-ghosted the l_diagnose_Lscale_from_tau code.\u000a\u000a* Fixing a couple bugs with the merge.\u000a\u000a* De-ghosted a couple of subroutines with advance_helper_module.F90.\u000a\u000a* Code wasn't compiling because of too many characters on one line.\u000a\u000a* De-ghosted precipitation_fraction.F90.\u000a\u000a* De-ghosted more code, including sfc_varnce_module.F90.\u000a\u000a* De-ghosted numerical_check.F90\u000a\u000a* Committing a chunk of code that effectively \"finishes off\" the\u000adeghosting of CLUBB core, although results aren't there yet and it still\u000aneeds more debugging.\u000a\u000a* This corrects the bug where an error would occur when trying to compare\u000aa run with a ghost level to a run without a ghost level.\u000a\u000a* Commiting some necessary ghost point removal code.\u000a\u000a* Updated the calculations of rcm_in_layer and cloud_cover for ghostless\u000agridding.\u000a\u000a* I removed the ghost point from all the files within the Benchmark_cases\u000adirectory.\u000a\u000a* I am committing code that removes the ghost level from\u000asetup_clubb_pdf_params and most of the collection of CLUBB's\u000amicrophysics schemes.\u000a\u000a* Fixing a bug in SILHS where sample point values were being overwritten\u000aat level 1.\u000a\u000a* I fixed some bugs in the ghostless version of the Morrison microphysics\u000adriver.\u000a\u000a* I fixed some array declaration mismatches in silhs_api_module.F90.\u000a\u000a* I have deghosted the call to the code that calculates microphysics\u000atendencies and everything below it.\u000a\u000a* Performed a de-ghosting, as well as an improvement that ensures\u000athat mean sedimentation is always conservative (excluding the\u000aamount of hydrometeor that leaves the domain at the surface),\u000ato all subroutines at the level of microphys_lhs and lower\u000ain advance_microphys_module.F90. This includes all\u000aprocess-related subroutines like those that govern\u000asedimentation or turbulent sedimentation.\u000a\u000aGee, how is it possible that such are large amount of work\u000agets done when there's no office. It must have been magic\u000aelves who did it. I mean, a physical office must be key\u000ato every element of functioning in life, right?\u000a\u000a* Reversing the accidental stats file commit I made in the previous\u000acommit.\u000a\u000a* Updating the \"leftovers\" from the previous merge to make it consistent\u000awith the call syntax in the new, ghostless CLUBB.\u000a\u000a* Updated the turbulent sedimentation code to handle upper and lower\u000aboundary conditions in a better manner.\u000a\u000a* I have finished de-ghosting the entirety of advance_microphys_module.F90\u000aand all codes that are underneath its umbrella.\u000a\u000a* I finished de-ghosting the radiation portion of CLUBB.\u000a\u000a* I have removed the ghost level from hydrostatic_module.F90.\u000a\u000a* I removed the ghost point from parameters_tunable and started\u000areferencing the ghostless grid through the entirety of clubb_api_module\u000aas well as in all of the G-unit tests.\u000a\u000a* Deghosted another file. Not too many left.\u000a\u000a* Deghosted sounding.F90\u000a\u000a* I have deghosted clubb_driver.F90 and everything below its umbrella,\u000awhich is a huge benchmark in this process.\u000a\u000a* It is not necessary to de-ghost the source code for the tuner, since\u000athe information on what levels it is tuning for is fed in from input\u000afiles.\u000a\u000aWithin the tuner input files, I have adjusted the tuning ranges by 1\u000ato compensate for the fact that the ghost level has now been entirely\u000aremoved from the model.\u000a\u000a* Got rid of some unnecessary \"use grid_class\" statements that were\u000astill referencing the old grid.\u000a\u000a* I have found a bug in the ghostless SILHS code in the SILHS\u000acode that calculates the variances and covariances of moisture\u000aand heat (that are fed back into the model predictive equations).\u000aIn short, variables that were used to store the grid mean values\u000aof thl, rt, and w were being set to 0 at level 1. This was fine\u000awhen level 1 was the ghost level, but level 1 is no longer the\u000aghost level. This was root cause of the issue.\u000a\u000a* The line that sets rand_pool at level 1 that was merged in during\u000athe previous merge commit needs to be removed.\u000a\u000a* These lines also needed to be fixed because they were supposed to\u000abe changed to nzt / 2 after the previous merge commit.\u000a\u000a* Correcting a bug in coamps microphysics regarded the unnecessary\u000ainterpolation of hydrometeor sedimentation velocities to the zm grid.\u000aThis interpolation is a bug because CLUBB expects hydrometeor velocities\u000aoutput on the zt grid.\u000a\u000a* I am committing a fix to the _ta budget terms. It will fix the error\u000amessages as well allow for budget term agreement between the master\u000aand clubb_ghost_exorcism branches.\u000a\u000a* Fixing an error in the ghostless budget stats for turbulent\u000asedimentation.\u000a\u000a* After the merge, I am once again updating the merged code for\u000aghost level removal.\u000a\u000a* Getting rid of leftover ghost removal junk that was still lying around.\u000a\u000a* I needed to pass p_sfc inside CLUBB core to help set the value\u000aof p_in_Pa_zm at level 1.\u000a\u000a* C11_Skw_fnc is a zt variable, while Cx_fnc_Richardson is a zm variable.\u000aThe offset is to keep results the same between the current master\u000abranch and the clubb_ghost_exorcism branch when the l_use_C11_Richardson\u000aflag is enabled.\u000a\u000a* Fixed a bug.\u000a\u000a* I found a couple more instances where the api had dimensions switched\u000aaround.\u000a\u000a* Eliminated diffusion_cloud_frac_zt_lhs, which is unused code that isn't\u000aeven hooked up (called from) anywhere in the model anymore.\u000a\u000a* Changes that also needed to be made with the previous commit.\u000a\u000a* The source of the array out-of-bounds error.\u000a\u000a* Moving grid_class_new back to grid_class!\u000a\u000a* Reminder notes in case input_fields gets used in the future.\u000a\u000a* I accidentally committed input fields related changes to rico_model.in\u000athat weren't meant to be committed in the previous commit. I am undoing\u000athose now.\u000a\u000a* Having clubb thermodynamic level 1 below the surface is no longer\u000athe stanard scenario!\u000a\u000a---------\u000a\u000aCo-authored-by: Gunther Huebler \u000a", "date" : "2024-08-22 08:27:45 -0500", "id" : "90c974765822217b0693858a0ac0f115c5b964a2", "msg" : "Clubb ghost exorcism (#1159)", "paths" : [ { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" }, { "editType" : "edit", "file" : "fill_holes.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" }, { "editType" : "edit", "file" : "sfc_varnce_module.F90" }, { "editType" : "edit", "file" : "hydromet_pdf_parameter_module.F90" }, { "editType" : "edit", "file" : "numerical_check.F90" }, { "editType" : "edit", "file" : "Skx_module.F90" }, { "editType" : "edit", "file" : "turbulent_adv_pdf.F90" }, { "editType" : "edit", "file" : "setup_clubb_pdf_params.F90" }, { "editType" : "edit", "file" : "parameters_tunable.F90" }, { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" }, { "editType" : "edit", "file" : "pos_definite_module.F90" }, { "editType" : "edit", "file" : "mono_flux_limiter.F90" }, { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" }, { "editType" : "edit", "file" : "pdf_closure_module.F90" }, { "editType" : "edit", "file" : "calc_pressure.F90" }, { "editType" : "edit", "file" : "stats_clubb_utilities.F90" }, { "editType" : "edit", "file" : "adg1_adg2_3d_luhar_pdf.F90" }, { "editType" : "edit", "file" : "precipitation_fraction.F90" }, { "editType" : "edit", "file" : "advance_helper_module.F90" }, { "editType" : "edit", "file" : "clip_explicit.F90" }, { "editType" : "edit", "file" : "advance_windm_edsclrm_module.F90" }, { "editType" : "edit", "file" : "advance_xp3_module.F90" }, { "editType" : "edit", "file" : "mean_adv.F90" }, { "editType" : "edit", "file" : "stats_type.F90" }, { "editType" : "edit", "file" : "mixing_length.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "grid_class.F90" }, { "editType" : "edit", "file" : "sigma_sqd_w_module.F90" }, { "editType" : "edit", "file" : "diffusion.F90" }, { "editType" : "edit", "file" : "sponge_layer_damping.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "silhs_api_module.F90", "est_kessler_microphys_module.F90", "transform_to_pdf_module.F90", "lh_microphys_var_covar_module.F90", "output_2D_samples_module.F90", "latin_hypercube_driver_module.F90" ], "commitId" : "3b4700eb924086aac1093d1401fb4f59c7a66b50", "timestamp" : 1724333265000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Clubb ghost exorcism (#1159)\u000a\u000a* I am adding grid_class_new.F90 to the code as a copy of grid_class.F90.\u000a\u000aThe first step toward removing the ghost level from the model is to\u000amodify the grid file. Having a second grid file in play will allow\u000afunctions and subroutines that are undergoing modification earlier in\u000athis process to use the new file, while functions and subroutines that\u000ahave not yet been modified will continue to use the old grid file\u000auntil they can be modified.\u000a\u000aAt the end of this process, the old grid file will be able to be\u000aremoved and grid_class_new.F90 will simply be able to be renamed\u000agrid_class.F90 at that point.\u000a\u000aIn this commit, I have altered the schematic and the comments\u000aat the very start of the module to be \"ghostless\".\u000a\u000a* Updated grid_class for the changes to the grid interpolation weighting\u000afunctions for the new \"ghostless\" ascending grid.\u000a\u000a* Committing some updates to the new grid class file for ghostless\u000aascending.\u000a\u000a* Updating to match recent changes made to grid_class.F90.\u000a\u000a* I finished the removal of the ghost level from the entirety of the new\u000agrid_class file. This standalone file compiles successfully.\u000a\u000a* Removing the sources of compiler warnings in grid_class_new.F90 (these\u000awere carried over from grid_class.F90).\u000a\u000a* Committing progress in advance_wp2_wp3_module.F90 with regards to\u000aghostless grid.\u000a\u000a* I am committing the updated version of grid_class_new.F90 that allows\u000aall cases to run, regardless of grid_type.\u000a\u000a* Fixed a bug in grid_class_new.F90\u000a\u000aWhen grid_type = 2, the calculations of the indices begin_height and\u000aend_height are based on the thermodynamic level grids. Those grid indices\u000ashould be used in the call to setup_grid_heights, where the array of\u000athermodynamic_heights, from index begin_height to index end_height,\u000ashould become gr%zt.\u000a\u000aWhen grid_type - 3, the calculations of the indices begin_height and\u000aend_height are based on the momentum grid levels.\u000a\u000aEither way, momentum_heights and thermodynamic_heights should both\u000ahave the array from begin_height to end_height passed in. When\u000agrid_type = 2, only the thermodynamic height array is relevant in\u000athe setup. When grid_type = 3, only the momentum height array is\u000arelevant in the setup.\u000a\u000a* For thermodynamic_height, 1:nzmax-1 is the entire array, but I\u000aentered this for a clarification, especially considering the\u000afollowing check block.\u000a\u000a* Updated grid_class_new to better handle the begin_height and end_height indices.\u000a\u000a* Some modifications to advance_wp2_wp3\u000a\u000a* Committed some temporary code.\u000a\u000a* committed some temporary changes to clubb_api_module.\u000a\u000a* Making a bunch of commits to clubb_driver that are mainly temporary for\u000ainterface and printing purposes.\u000a\u000a* Deghosted another subroutine.\u000a\u000a* Updated wp2_term_ta_lhs to use the new gridding.\u000a\u000a* De-ghosting wp2_terms_ac_pr2_lhs\u000a\u000a* De-ghosted wp2_term_pr3_rhs\u000a\u000a* Deghosting wp3_term_tp_lhs.\u000a\u000a* Deghosted wp3_terms_ac_pr2_lhs\u000a\u000a* Updated the wp3_term_ta_ADG1_lhs subroutine to use boundary conditions\u000awhere wp3 (at the top level and bottom momentum levels of the model)\u000ais assumed to have a value of 0.\u000a\u000a* For single loop vectors, removing the \"collapse(2)\" from the acc\u000astatements.\u000a\u000aThis commit is not bit changing, but the previous commit to this branch\u000awas BIT_CHANGING:902d6caed8a4533f59f4165106276959b4f90895\u000a\u000a* I updated wp3_term_ta_explicit_rhs for the ghostless grid.\u000a\u000aWhen l_explicit_turbulent_adv_wp3 is turned on, the results from\u000athis branch exactly match those found on the master branch.\u000a\u000a* Updating diffusion_zm_lhs for \"Ghostless\" gridding.\u000a\u000a* Fixed a typo in the comments that was introduced in the previous commit.\u000a\u000a* Updated for \"ghostless\" diffusion.\u000a\u000a* With wp3 now being set to a fixed-point boundary condition value\u000aof 0 at the current thermodynamic level 1 (first t-lev above the\u000asurface), it is not necessary to loop over level 1 within the code\u000afor each wp3 term.\u000a\u000aAlso contains code to enforce a fixed-point boundary condition\u000aof wp3=0 at the first thermodynamic level above the surface.\u000a\u000a* Restoring diffusion to the way it should be for the exorcised ghost grid\u000aprior to the most recent master merge. Lines for the ghost point were\u000aaccidentally added during the merge commit.\u000a\u000a* Updated code to correct wp3_bp1 and wp3_pr2 budget terms so that\u000athey still match bit-for-bit what is found in the master branch.\u000a\u000a* Updating term_ma_zm_lhs for ghostless gridding. Results are bit-for-bit\u000aidentical.\u000a\u000a* After debugging, I am now committing the ghostless version of\u000aterm_ma_zt_lhs.\u000a\u000a* Updating the clubb_ghost_exorcism branch for ghostless wp23 rhs,\u000alhs, and solve.\u000a\u000aThis revision runs; however, there are still some issues tracking\u000adown the source of problems in maintaining bit-for-bit results.\u000a\u000a* Updated to maintain bit-for-bitness with the master code.\u000a\u000a* Finished exorcising the ghost from advance_wp2_wp3_module.F90.\u000a\u000a* Small openacc changes to fix GPU runs\u000a\u000a* Adjusting new hybrid PDF code to continue to match the master branch\u000abit-for-bit while construction continues.\u000a\u000a* Committing the first portion of a nomenclature change where the number\u000aof momentum vertical grid levels is denoted as nzm rather than nz.\u000a\u000a* Changing the notation of the number of grid levels on the momentum grid,\u000apreviously nz, to nzm in some files.\u000a\u000a* Changed some comments and a little bit of code in the new grid_class\u000afile to provide a better description.\u000a\u000a* Updated sigma_sqd_w_module for ghostless gridding.\u000a\u000a* I added the new \"ghostless\" discretization to turbulent_adv_pdf.F90,\u000aand also appropriately altered the points in the code where the\u000aturbulent advection subroutines are called from in\u000aadvance_xm_wpxp_module.F90 and advance_xp2_xpyp_module.F90.\u000a\u000aThe code produced bit-for-bit results in regards to the standard\u000aconfiguration, the new hybrid PDF configuration, and also for the\u000aconfiguration with the godunov flags turned on.\u000a\u000a* Altered many of the lower-level subroutines in\u000aadvance_xp2_xpyp_module.F90 for ghostless gridding.\u000a\u000a* Upgraded subroutine calc_xp2_xpyp_ta_terms for ghostless discretization.\u000a\u000aThis should alter the results when the new_hybrid PDF is used in\u000aconjunction with upwind discretization, but it doesn't alter the\u000aresults for anything else.\u000a\u000a* Completed making advance_xp2_xpyp ghostless.\u000a\u000a* Completed the de-ghosting of advance_windm_edsclrm.\u000a\u000aResults are BIT_CHANGING because the ghost level was interacting with\u000athe results.\u000a\u000a* The call to calc_xpwp from advance_microphys was not supposed to be\u000aupdated yet. It wound up being sort of \"partially updated\" for\u000aghostless gridding, which was a bug that led to some diagnostic output\u000afields not being bit-for-bit. In this commit, I returned it to its prior\u000aform so that zm output files once again retain bit-for-bit status\u000abetween this branch and the master.\u000a\u000a* The ghost point interface statements after the return from\u000aadvance_windm_edsclrm needed to be encased in the same conditional\u000astatements that the calculations occurred in with the aforementioned\u000asubroutine. This change fixes a bug where a handful of cases had results\u000athat were not bit-for-bit from revisions before this code was added.\u000a\u000a* Fixed bug where the wrong stats were being recorded to the stats\u000afor coef_wpthlp2_implicit, etc.\u000a\u000a* I am committing a bug fix to the implicit surface flux calculation\u000ain the eddy-diffusivity wind code (which is used when\u000al_predict_upwp_vpwp is turned off).\u000a\u000aI am also committing some temporary ghost point interface stats code\u000awithin advance_windm_edsclrm.\u000a\u000a* I updated the diagrams in advance_windm_edsclrm to reflect the\u000anew ghostless grid.\u000a\u000a* I improved the description section of advance_windm_edsclrm.\u000a\u000a* Made numerous low-level subroutines ghostless within\u000aadvance_xm_wpxp_module.F90. Maintained bit-for-bit results\u000awith the master branch.\u000a\u000a* I am updating the xm wpxp code that calls the wpxp turbulent advection\u000aterm based on your PDF and option for ghostless gridding.\u000a\u000a* Updating some of the lower-level functions of the monotonic flux limiter\u000afor ghostless gridding.\u000a\u000a* I have updated the monotonic flux limiter for ghostless gridding!\u000a\u000a* A couple of redundant declarations were brought in on the last merge.\u000a\u000a* Committing further updates to ghostless gridding, including:\u000a\u000a1) Further modifications to advance_xm_wpxp, which includes branching\u000aout in Brunt-Vaisala frequency calculations in advance_helper;\u000a\u000a2) Update in calculating the initial pressure;\u000a\u000aand 3) updating grid class new to use the same \"value drop down\"\u000ain the zt2zm function and \"derivative drop down\" in the ddzt function\u000athat are now used in grid_class in the master.\u000a\u000aResults are bit-for-bit identical with the master.\u000a\u000a* Updated xm_wpxp_lhs for ghostless gridding.\u000a\u000a* Made xm_wpxp_rhs ghostless.\u000a\u000a* Updated xm_wpxp_solve for ghostless gridding!\u000a\u000a* Updating pos_definite_module.F90 for ghostless gridding.\u000a\u000a* Updated vertical hole filling and xm clipping and stats for\u000aghost point removal.\u000a\u000aResults are still bit-for-bit with the master branch.\u000a\u000a* Updated advance_xm_wpxp to remove the ghost point.\u000a\u000a* Updating some zt stats to use a value of 0 for the \"ghost\" level.\u000a\u000a* Updated subroutine compute_mixing_length for ghostless gridding.\u000a\u000a* Removing the ghost point from calculate_Lscale_directly\u000a\u000a* Added a \"ghostbuster\" option (-g) in the run_bindiff_all.py python\u000ascript that omits the \"ghost\" level from the comparison for _zt.nc\u000aoutput files when envoked.\u000a\u000a* I de-ghosted the l_diagnose_Lscale_from_tau code.\u000a\u000a* Fixing a couple bugs with the merge.\u000a\u000a* De-ghosted a couple of subroutines with advance_helper_module.F90.\u000a\u000a* Code wasn't compiling because of too many characters on one line.\u000a\u000a* De-ghosted precipitation_fraction.F90.\u000a\u000a* De-ghosted more code, including sfc_varnce_module.F90.\u000a\u000a* De-ghosted numerical_check.F90\u000a\u000a* Committing a chunk of code that effectively \"finishes off\" the\u000adeghosting of CLUBB core, although results aren't there yet and it still\u000aneeds more debugging.\u000a\u000a* This corrects the bug where an error would occur when trying to compare\u000aa run with a ghost level to a run without a ghost level.\u000a\u000a* Commiting some necessary ghost point removal code.\u000a\u000a* Updated the calculations of rcm_in_layer and cloud_cover for ghostless\u000agridding.\u000a\u000a* I removed the ghost point from all the files within the Benchmark_cases\u000adirectory.\u000a\u000a* I am committing code that removes the ghost level from\u000asetup_clubb_pdf_params and most of the collection of CLUBB's\u000amicrophysics schemes.\u000a\u000a* Fixing a bug in SILHS where sample point values were being overwritten\u000aat level 1.\u000a\u000a* I fixed some bugs in the ghostless version of the Morrison microphysics\u000adriver.\u000a\u000a* I fixed some array declaration mismatches in silhs_api_module.F90.\u000a\u000a* I have deghosted the call to the code that calculates microphysics\u000atendencies and everything below it.\u000a\u000a* Performed a de-ghosting, as well as an improvement that ensures\u000athat mean sedimentation is always conservative (excluding the\u000aamount of hydrometeor that leaves the domain at the surface),\u000ato all subroutines at the level of microphys_lhs and lower\u000ain advance_microphys_module.F90. This includes all\u000aprocess-related subroutines like those that govern\u000asedimentation or turbulent sedimentation.\u000a\u000aGee, how is it possible that such are large amount of work\u000agets done when there's no office. It must have been magic\u000aelves who did it. I mean, a physical office must be key\u000ato every element of functioning in life, right?\u000a\u000a* Reversing the accidental stats file commit I made in the previous\u000acommit.\u000a\u000a* Updating the \"leftovers\" from the previous merge to make it consistent\u000awith the call syntax in the new, ghostless CLUBB.\u000a\u000a* Updated the turbulent sedimentation code to handle upper and lower\u000aboundary conditions in a better manner.\u000a\u000a* I have finished de-ghosting the entirety of advance_microphys_module.F90\u000aand all codes that are underneath its umbrella.\u000a\u000a* I finished de-ghosting the radiation portion of CLUBB.\u000a\u000a* I have removed the ghost level from hydrostatic_module.F90.\u000a\u000a* I removed the ghost point from parameters_tunable and started\u000areferencing the ghostless grid through the entirety of clubb_api_module\u000aas well as in all of the G-unit tests.\u000a\u000a* Deghosted another file. Not too many left.\u000a\u000a* Deghosted sounding.F90\u000a\u000a* I have deghosted clubb_driver.F90 and everything below its umbrella,\u000awhich is a huge benchmark in this process.\u000a\u000a* It is not necessary to de-ghost the source code for the tuner, since\u000athe information on what levels it is tuning for is fed in from input\u000afiles.\u000a\u000aWithin the tuner input files, I have adjusted the tuning ranges by 1\u000ato compensate for the fact that the ghost level has now been entirely\u000aremoved from the model.\u000a\u000a* Got rid of some unnecessary \"use grid_class\" statements that were\u000astill referencing the old grid.\u000a\u000a* I have found a bug in the ghostless SILHS code in the SILHS\u000acode that calculates the variances and covariances of moisture\u000aand heat (that are fed back into the model predictive equations).\u000aIn short, variables that were used to store the grid mean values\u000aof thl, rt, and w were being set to 0 at level 1. This was fine\u000awhen level 1 was the ghost level, but level 1 is no longer the\u000aghost level. This was root cause of the issue.\u000a\u000a* The line that sets rand_pool at level 1 that was merged in during\u000athe previous merge commit needs to be removed.\u000a\u000a* These lines also needed to be fixed because they were supposed to\u000abe changed to nzt / 2 after the previous merge commit.\u000a\u000a* Correcting a bug in coamps microphysics regarded the unnecessary\u000ainterpolation of hydrometeor sedimentation velocities to the zm grid.\u000aThis interpolation is a bug because CLUBB expects hydrometeor velocities\u000aoutput on the zt grid.\u000a\u000a* I am committing a fix to the _ta budget terms. It will fix the error\u000amessages as well allow for budget term agreement between the master\u000aand clubb_ghost_exorcism branches.\u000a\u000a* Fixing an error in the ghostless budget stats for turbulent\u000asedimentation.\u000a\u000a* After the merge, I am once again updating the merged code for\u000aghost level removal.\u000a\u000a* Getting rid of leftover ghost removal junk that was still lying around.\u000a\u000a* I needed to pass p_sfc inside CLUBB core to help set the value\u000aof p_in_Pa_zm at level 1.\u000a\u000a* C11_Skw_fnc is a zt variable, while Cx_fnc_Richardson is a zm variable.\u000aThe offset is to keep results the same between the current master\u000abranch and the clubb_ghost_exorcism branch when the l_use_C11_Richardson\u000aflag is enabled.\u000a\u000a* Fixed a bug.\u000a\u000a* I found a couple more instances where the api had dimensions switched\u000aaround.\u000a\u000a* Eliminated diffusion_cloud_frac_zt_lhs, which is unused code that isn't\u000aeven hooked up (called from) anywhere in the model anymore.\u000a\u000a* Changes that also needed to be made with the previous commit.\u000a\u000a* The source of the array out-of-bounds error.\u000a\u000a* Moving grid_class_new back to grid_class!\u000a\u000a* Reminder notes in case input_fields gets used in the future.\u000a\u000a* I accidentally committed input fields related changes to rico_model.in\u000athat weren't meant to be committed in the previous commit. I am undoing\u000athose now.\u000a\u000a* Having clubb thermodynamic level 1 below the surface is no longer\u000athe stanard scenario!\u000a\u000a---------\u000a\u000aCo-authored-by: Gunther Huebler \u000a", "date" : "2024-08-22 08:27:45 -0500", "id" : "3b4700eb924086aac1093d1401fb4f59c7a66b50", "msg" : "Clubb ghost exorcism (#1159)", "paths" : [ { "editType" : "edit", "file" : "output_2D_samples_module.F90" }, { "editType" : "edit", "file" : "est_kessler_microphys_module.F90" }, { "editType" : "edit", "file" : "silhs_api_module.F90" }, { "editType" : "edit", "file" : "transform_to_pdf_module.F90" }, { "editType" : "edit", "file" : "latin_hypercube_driver_module.F90" }, { "editType" : "edit", "file" : "lh_microphys_var_covar_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_helper_module.F90" ], "commitId" : "5063ce59ebf30494012df2da0a8d9e1f5cc94589", "timestamp" : 1724704978000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Variable name correction in acc data statement.\u000a", "date" : "2024-08-26 15:42:58 -0500", "id" : "5063ce59ebf30494012df2da0a8d9e1f5cc94589", "msg" : "Variable name correction in acc data statement.", "paths" : [ { "editType" : "edit", "file" : "advance_helper_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_xp2_xpyp_module.F90" ], "commitId" : "8553509b703bf07dd4c56fee55c47f11652aa7e2", "timestamp" : 1724708483000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Splitting zeros_vector into versions with nzt or nzm size to match sizes in subroutine.\u000a", "date" : "2024-08-26 16:41:23 -0500", "id" : "8553509b703bf07dd4c56fee55c47f11652aa7e2", "msg" : "Splitting zeros_vector into versions with nzt or nzm size to match sizes in subroutine.", "paths" : [ { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "clubb_api_module.F90" ], "commitId" : "c571fcfd510bd0c8721aadb8a37380212ac2b4ff", "timestamp" : 1724708509000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Making radf size correct in api and clubb_driver.\u000a", "date" : "2024-08-26 16:41:49 -0500", "id" : "c571fcfd510bd0c8721aadb8a37380212ac2b4ff", "msg" : "Making radf size correct in api and clubb_driver.", "paths" : [ { "editType" : "edit", "file" : "clubb_api_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90", "advance_helper_module.F90" ], "commitId" : "5d6de8e6e5c208f82bfb0bccc4ebf05346f9825a", "timestamp" : 1724956382000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Ri_zm calc (Part 4) - Implementing calc_Ri_zm (#1160)\u000a\u000a* Ri_zm calc (Part 4) - Implementing calc_Ri_zm\u000aCLUBB tocket #1145\u000a\u000a1. advance_helper_module.F90\u000a- Implemented calc_Ri_zm\u000a- Replaced Ri_zm calculations in compute_Cx_fnc_Richardson\u000a\u000a2. advance_clubb_core_module.F90\u000aReplaced Ri_zm calculations in advance_clubb_core\u000a", "date" : "2024-08-29 13:33:02 -0500", "id" : "5d6de8e6e5c208f82bfb0bccc4ebf05346f9825a", "msg" : "Ri_zm calc (Part 4) - Implementing calc_Ri_zm (#1160)", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "advance_helper_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_helper_module.F90" ], "commitId" : "841d3a1606139e363e09e8bab9f6fda4a41f871e", "timestamp" : 1725305536000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Ri zm calc4 (#1168)\u000a\u000aBug fix for Ri_zm calc (Part 4) commit\u000aCLUBB tocket #1145\u000a\u000a* Added missing acc loop directive in calc_Ri_zm\u000a", "date" : "2024-09-02 14:32:16 -0500", "id" : "841d3a1606139e363e09e8bab9f6fda4a41f871e", "msg" : "Ri zm calc4 (#1168)", "paths" : [ { "editType" : "edit", "file" : "advance_helper_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "stats_zm_module.F90", "stats_variables.F90", "clip_semi_implicit.F90", "advance_xm_wpxp_module.F90" ], "commitId" : "4cbb7d19a3edec730aa008d7f0acbfe51978902c", "timestamp" : 1725574649000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, "authorEmail" : "bmg2@uwm.edu", "comment" : "Well, this will probably anger the Grim Reaper, but I have finally\u000aremoved the SICL from CLUBB (as discussed a number of months ago).\u000a\u000aThat term is now expunged from the entirety of CLUBB, including all\u000asource code, stats files, and postprocessing files.\u000a\u000aThis change is technically BIT_CHANGING because two stats variables,\u000awprtp_sicl and wpthlp_sicl, have been removed from stats output files.\u000a\u000aHowever, all results remain exactly the same.\u000a", "date" : "2024-09-05 17:17:29 -0500", "id" : "4cbb7d19a3edec730aa008d7f0acbfe51978902c", "msg" : "Well, this will probably anger the Grim Reaper, but I have finally", "paths" : [ { "editType" : "edit", "file" : "stats_zm_module.F90" }, { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" }, { "editType" : "delete", "file" : "clip_semi_implicit.F90" }, { "editType" : "edit", "file" : "stats_variables.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_wp2_wp3_module.F90", "advance_xp2_xpyp_module.F90", "advance_xm_wpxp_module.F90" ], "commitId" : "c631c7d3db48f650d77a570b2534e358aa02f1a8", "timestamp" : 1726084912000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/vlarson", "fullName" : "Vince Larson" }, "authorEmail" : "vlarson@users.noreply.github.com", "comment" : "Change variables from a1 and a3 to a1_coef and a3_coef\u000aFor issue #977\u000a", "date" : "2024-09-11 15:01:52 -0500", "id" : "c631c7d3db48f650d77a570b2534e358aa02f1a8", "msg" : "Change variables from a1 and a3 to a1_coef and a3_coef", "paths" : [ { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" }, { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" }, { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_xp3_module.F90", "advance_clubb_core_module.F90", "advance_xm_wpxp_module.F90", "numerical_check.F90", "stats_zt_module.F90", "pdf_closure_module.F90", "adg1_adg2_3d_luhar_pdf.F90", "stats_clubb_utilities.F90", "stats_zm_module.F90", "advance_windm_edsclrm_module.F90", "sfc_varnce_module.F90", "new_hybrid_pdf_main.F90" ], "commitId" : "3ab47e7b81c1bc1b6d5b8ee0fc7ab285614ae7c3", "timestamp" : 1726575983000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "change loop index to sclr and edsclr for sclr_dim and edsclr_dim (#1173)\u000a\u000aWhenever a loop is dimensioned sclr_dim, use sclr as the loop index. Whenever a loop is dimensioned edsclr_dim, use edsclr as the loop index.\u000a\u000aAdded changes and tested for binary differences with the following flags for the gabls2 case:\u000al_host_applies_sfc_fluxes=true/false\u000al_call_pdf_closure_twice=true/false\u000al_lmm_stepping=true/false\u000al_explicit_turbulent_adv_wpxp=true/false\u000a\u000aSee #987.\u000a", "date" : "2024-09-17 07:26:23 -0500", "id" : "3ab47e7b81c1bc1b6d5b8ee0fc7ab285614ae7c3", "msg" : "change loop index to sclr and edsclr for sclr_dim and edsclr_dim (#1173)", "paths" : [ { "editType" : "edit", "file" : "stats_clubb_utilities.F90" }, { "editType" : "edit", "file" : "advance_windm_edsclrm_module.F90" }, { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" }, { "editType" : "edit", "file" : "pdf_closure_module.F90" }, { "editType" : "edit", "file" : "adg1_adg2_3d_luhar_pdf.F90" }, { "editType" : "edit", "file" : "advance_xp3_module.F90" }, { "editType" : "edit", "file" : "numerical_check.F90" }, { "editType" : "edit", "file" : "sfc_varnce_module.F90" }, { "editType" : "edit", "file" : "stats_zt_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "new_hybrid_pdf_main.F90" }, { "editType" : "edit", "file" : "stats_zm_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90", "stats_variables.F90", "stats_zm_module.F90", "advance_helper_module.F90" ], "commitId" : "77d72936a35198cc193e31782139908254a6b3f3", "timestamp" : 1726604813000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Ri zm calc5 (#1175)\u000a\u000a* Ri_zm calc (Part 5) - Implementing calc_Ri_zm\u000aCLUBB tocket #1145\u000a\u000aCleaning up subroutine compute_Cx_fnc_Richardson\u000a1) In advance_helper_module.F90:\u000a- Removed superfluous inputs\u000a- Added Brunt Väisälä frequency variables, shear_sqd, and Lscale_zm as inputs\u000a- Removed call to calc_brunt_vaisala_freq_sqd\u000a- Removed zt2zm(Lscale)\u000a- Removed calculation and stat_update_var of shear_sqd\u000a\u000a2) In advance_clubb_core:\u000a- Added stat_update_var for shear_sqd\u000a- Adjusted call to compute_Cx_fnc_Richardson\u000a\u000a3) Renamed netcdf variable `shear_sqd` to `ddzt_umvm_sqd` to keep variable names consistent.\u000a", "date" : "2024-09-17 15:26:53 -0500", "id" : "77d72936a35198cc193e31782139908254a6b3f3", "msg" : "Ri zm calc5 (#1175)", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "stats_variables.F90" }, { "editType" : "edit", "file" : "stats_zm_module.F90" }, { "editType" : "edit", "file" : "advance_helper_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90" ], "commitId" : "fd8b67834697b6fae2a1933b212ba571e5a45e68", "timestamp" : 1726773850000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Removing duplicate definition of edsclr when CLUBB_CAM is defined.\u000a", "date" : "2024-09-19 14:24:10 -0500", "id" : "fd8b67834697b6fae2a1933b212ba571e5a45e68", "msg" : "Removing duplicate definition of edsclr when CLUBB_CAM is defined.", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_clubb_core_module.F90", "advance_xm_wpxp_module.F90" ], "commitId" : "afaafca1b208625a00b7f826cae0d25251d2ad0d", "timestamp" : 1726782540000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Ri zm calc6 (#1177)\u000a\u000a* Ri_zm calc (Part 6) - Implementing calc_Ri_zm\u000aCLUBB tocket #1145\u000a\u000aEliminating call to calc_stability_correction in advance_xm_wpxp\u000a1) In advance_xm_wpxp_module.F90:\u000a- Eliminated call to calc_stability_correction in calc_xm_wpxp_lhs_terms\u000a- stability_correction is now passed through advance_xm_wpxp to calc_xm_wpxp_lhs_terms\u000a- Cleaned up input lists\u000a\u000a2) In advance_clubb_core:\u000a- Adjusted call to advance_xm_wpxp\u000a\u000a3) Adjusted spurious_source_test\u000a", "date" : "2024-09-19 16:49:00 -0500", "id" : "afaafca1b208625a00b7f826cae0d25251d2ad0d", "msg" : "Ri zm calc6 (#1177)", "paths" : [ { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "silhs_api_module.F90", "lh_microphys_var_covar_module.F90", "transform_to_pdf_module.F90", "latin_hypercube_driver_module.F90", "output_2D_samples_module.F90" ], "commitId" : "d52dc47a7c76ddc46b521d0fff0482f25ea91e5e", "timestamp" : 1726848578000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "refactor code to remove compiler warnings for exceeding 100 characters per line and unused variables and parameters (#1179)\u000a\u000a", "date" : "2024-09-20 11:09:38 -0500", "id" : "d52dc47a7c76ddc46b521d0fff0482f25ea91e5e", "msg" : "refactor code to remove compiler warnings for exceeding 100 characters per line and unused variables and parameters (#1179)", "paths" : [ { "editType" : "edit", "file" : "silhs_api_module.F90" }, { "editType" : "edit", "file" : "latin_hypercube_driver_module.F90" }, { "editType" : "edit", "file" : "lh_microphys_var_covar_module.F90" }, { "editType" : "edit", "file" : "transform_to_pdf_module.F90" }, { "editType" : "edit", "file" : "output_2D_samples_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "clubb_api_module.F90", "clip_explicit.F90", "advance_xm_wpxp_module.F90", "stats_lh_zt_module.F90", "mt95.F90", "stats_type_utilities.F90", "grid_class.F90", "penta_lu_solver.F90", "setup_clubb_pdf_params.F90", "new_pdf_main.F90", "advance_windm_edsclrm_module.F90", "mono_flux_limiter.F90", "advance_helper_module.F90", "mixing_length.F90", "advance_wp2_wp3_module.F90", "advance_xp2_xpyp_module.F90", "stats_rad_zm_module.F90", "stats_rad_zt_module.F90", "tridiag_lu_solver.F90", "pdf_closure_module.F90", "Skx_module.F90", "adg1_adg2_3d_luhar_pdf.F90", "matrix_solver_wrapper.F90", "corr_varnce_module.F90", "precipitation_fraction.F90", "diffusion.F90", "model_flags.F90", "numerical_check.F90", "output_netcdf.F90", "stats_lh_sfc_module.F90", "parameters_tunable.F90", "saturation.F90", "advance_xp3_module.F90", "advance_clubb_core_module.F90", "stats_zt_module.F90", "mean_adv.F90", "lapack_wrap.F90", "fill_holes.F90", "stats_sfc_module.F90", "stats_clubb_utilities.F90", "stats_zm_module.F90", "sfc_varnce_module.F90" ], "commitId" : "af499c027fac8a33da80b1430c7f2f1425d3553a", "timestamp" : 1726848578000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "refactor code to remove compiler warnings for exceeding 100 characters per line and unused variables and parameters (#1179)\u000a\u000a", "date" : "2024-09-20 11:09:38 -0500", "id" : "af499c027fac8a33da80b1430c7f2f1425d3553a", "msg" : "refactor code to remove compiler warnings for exceeding 100 characters per line and unused variables and parameters (#1179)", "paths" : [ { "editType" : "edit", "file" : "mixing_length.F90" }, { "editType" : "edit", "file" : "stats_clubb_utilities.F90" }, { "editType" : "edit", "file" : "adg1_adg2_3d_luhar_pdf.F90" }, { "editType" : "edit", "file" : "stats_sfc_module.F90" }, { "editType" : "edit", "file" : "output_netcdf.F90" }, { "editType" : "edit", "file" : "new_pdf_main.F90" }, { "editType" : "edit", "file" : "advance_windm_edsclrm_module.F90" }, { "editType" : "edit", "file" : "diffusion.F90" }, { "editType" : "edit", "file" : "fill_holes.F90" }, { "editType" : "edit", "file" : "sfc_varnce_module.F90" }, { "editType" : "edit", "file" : "saturation.F90" }, { "editType" : "edit", "file" : "stats_rad_zm_module.F90" }, { "editType" : "edit", "file" : "matrix_solver_wrapper.F90" }, { "editType" : "edit", "file" : "advance_xp3_module.F90" }, { "editType" : "edit", "file" : "stats_zt_module.F90" }, { "editType" : "edit", "file" : "pdf_closure_module.F90" }, { "editType" : "edit", "file" : "corr_varnce_module.F90" }, { "editType" : "edit", "file" : "stats_lh_sfc_module.F90" }, { "editType" : "edit", "file" : "grid_class.F90" }, { "editType" : "edit", "file" : "stats_lh_zt_module.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" }, { "editType" : "edit", "file" : "mono_flux_limiter.F90" }, { "editType" : "edit", "file" : "mt95.F90" }, { "editType" : "edit", "file" : "stats_zm_module.F90" }, { "editType" : "edit", "file" : "clip_explicit.F90" }, { "editType" : "edit", "file" : "precipitation_fraction.F90" }, { "editType" : "edit", "file" : "model_flags.F90" }, { "editType" : "edit", "file" : "stats_rad_zt_module.F90" }, { "editType" : "edit", "file" : "tridiag_lu_solver.F90" }, { "editType" : "edit", "file" : "advance_helper_module.F90" }, { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" }, { "editType" : "edit", "file" : "stats_type_utilities.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "parameters_tunable.F90" }, { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" }, { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" }, { "editType" : "edit", "file" : "mean_adv.F90" }, { "editType" : "edit", "file" : "Skx_module.F90" }, { "editType" : "edit", "file" : "penta_lu_solver.F90" }, { "editType" : "edit", "file" : "numerical_check.F90" }, { "editType" : "edit", "file" : "setup_clubb_pdf_params.F90" }, { "editType" : "edit", "file" : "lapack_wrap.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "silhs_api_module.F90", "latin_hypercube_driver_module.F90" ], "commitId" : "004d3f520a1adab77ee44de70ebc6caca27074eb", "timestamp" : 1727204551000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "reduce compiler warnings (#1180)\u000a\u000a* refactor code to remove warnings for exceeding 100 characters per line\u000a\u000a* remove unused variables\u000a\u000a* remove unused parameters #1174\u000a\u000a* fix for the GPU\u000a\u000a* remove new unused parameters\u000a\u000a* remove unused dummy arguments\u000a\u000a* make small changes to reduce compiler warnings\u000a\u000a* put solve_name back in as input variable to band_solve methods\u000a", "date" : "2024-09-24 14:02:31 -0500", "id" : "004d3f520a1adab77ee44de70ebc6caca27074eb", "msg" : "reduce compiler warnings (#1180)", "paths" : [ { "editType" : "edit", "file" : "latin_hypercube_driver_module.F90" }, { "editType" : "edit", "file" : "silhs_api_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "mixing_length.F90", "advance_wp2_wp3_module.F90", "advance_xp2_xpyp_module.F90", "advance_clubb_core_module.F90", "advance_xm_wpxp_module.F90", "clubb_api_module.F90", "clip_explicit.F90", "numerical_check.F90", "stats_clubb_utilities.F90", "matrix_solver_wrapper.F90", "advance_windm_edsclrm_module.F90", "advance_helper_module.F90" ], "commitId" : "c3912e04050490382fe3e514cd9e4763ff18ecb8", "timestamp" : 1727204551000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "reduce compiler warnings (#1180)\u000a\u000a* refactor code to remove warnings for exceeding 100 characters per line\u000a\u000a* remove unused variables\u000a\u000a* remove unused parameters #1174\u000a\u000a* fix for the GPU\u000a\u000a* remove new unused parameters\u000a\u000a* remove unused dummy arguments\u000a\u000a* make small changes to reduce compiler warnings\u000a\u000a* put solve_name back in as input variable to band_solve methods\u000a", "date" : "2024-09-24 14:02:31 -0500", "id" : "c3912e04050490382fe3e514cd9e4763ff18ecb8", "msg" : "reduce compiler warnings (#1180)", "paths" : [ { "editType" : "edit", "file" : "stats_clubb_utilities.F90" }, { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "numerical_check.F90" }, { "editType" : "edit", "file" : "advance_helper_module.F90" }, { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" }, { "editType" : "edit", "file" : "mixing_length.F90" }, { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" }, { "editType" : "edit", "file" : "advance_windm_edsclrm_module.F90" }, { "editType" : "edit", "file" : "matrix_solver_wrapper.F90" }, { "editType" : "edit", "file" : "clip_explicit.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "silhs_api_module.F90", "latin_hypercube_driver_module.F90" ], "commitId" : "034fb232520b1d0f7afa52036f8d25aa53e0d713", "timestamp" : 1727293378000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Removing the target attributes wherever possible. These are artifacts from when gr and the the stats types were globals, and got naively copied when these were pushed through the call stack.\u000a", "date" : "2024-09-25 14:42:58 -0500", "id" : "034fb232520b1d0f7afa52036f8d25aa53e0d713", "msg" : "Removing the target attributes wherever possible. These are artifacts from when gr and the the stats types were globals, and got naively copied when these were pushed through the call stack.", "paths" : [ { "editType" : "edit", "file" : "silhs_api_module.F90" }, { "editType" : "edit", "file" : "latin_hypercube_driver_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "clip_explicit.F90", "clubb_api_module.F90", "advance_xm_wpxp_module.F90", "stats_lh_zt_module.F90", "grid_class.F90", "setup_clubb_pdf_params.F90", "advance_windm_edsclrm_module.F90", "mono_flux_limiter.F90", "advance_helper_module.F90", "mixing_length.F90", "advance_wp2_wp3_module.F90", "advance_xp2_xpyp_module.F90", "stats_rad_zt_module.F90", "stats_rad_zm_module.F90", "calc_pressure.F90", "precipitation_fraction.F90", "diffusion.F90", "pos_definite_module.F90", "stats_lh_sfc_module.F90", "parameters_tunable.F90", "sponge_layer_damping.F90", "turbulent_adv_pdf.F90", "advance_xp3_module.F90", "advance_clubb_core_module.F90", "stats_zt_module.F90", "fill_holes.F90", "stats_sfc_module.F90", "stats_zm_module.F90", "stats_clubb_utilities.F90", "sfc_varnce_module.F90" ], "commitId" : "f0871e6ebc1641bac7b34aa169aa92e42a4ff13e", "timestamp" : 1727293378000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, "authorEmail" : "huebler@uwm.edu", "comment" : "Removing the target attributes wherever possible. These are artifacts from when gr and the the stats types were globals, and got naively copied when these were pushed through the call stack.\u000a", "date" : "2024-09-25 14:42:58 -0500", "id" : "f0871e6ebc1641bac7b34aa169aa92e42a4ff13e", "msg" : "Removing the target attributes wherever possible. These are artifacts from when gr and the the stats types were globals, and got naively copied when these were pushed through the call stack.", "paths" : [ { "editType" : "edit", "file" : "stats_sfc_module.F90" }, { "editType" : "edit", "file" : "clip_explicit.F90" }, { "editType" : "edit", "file" : "setup_clubb_pdf_params.F90" }, { "editType" : "edit", "file" : "stats_rad_zt_module.F90" }, { "editType" : "edit", "file" : "stats_rad_zm_module.F90" }, { "editType" : "edit", "file" : "stats_zm_module.F90" }, { "editType" : "edit", "file" : "turbulent_adv_pdf.F90" }, { "editType" : "edit", "file" : "stats_clubb_utilities.F90" }, { "editType" : "edit", "file" : "stats_lh_sfc_module.F90" }, { "editType" : "edit", "file" : "pos_definite_module.F90" }, { "editType" : "edit", "file" : "mixing_length.F90" }, { "editType" : "edit", "file" : "advance_xp3_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "sfc_varnce_module.F90" }, { "editType" : "edit", "file" : "calc_pressure.F90" }, { "editType" : "edit", "file" : "sponge_layer_damping.F90" }, { "editType" : "edit", "file" : "parameters_tunable.F90" }, { "editType" : "edit", "file" : "clubb_api_module.F90" }, { "editType" : "edit", "file" : "fill_holes.F90" }, { "editType" : "edit", "file" : "mono_flux_limiter.F90" }, { "editType" : "edit", "file" : "precipitation_fraction.F90" }, { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" }, { "editType" : "edit", "file" : "advance_xp2_xpyp_module.F90" }, { "editType" : "edit", "file" : "stats_zt_module.F90" }, { "editType" : "edit", "file" : "diffusion.F90" }, { "editType" : "edit", "file" : "stats_lh_zt_module.F90" }, { "editType" : "edit", "file" : "advance_windm_edsclrm_module.F90" }, { "editType" : "edit", "file" : "advance_helper_module.F90" }, { "editType" : "edit", "file" : "advance_xm_wpxp_module.F90" }, { "editType" : "edit", "file" : "grid_class.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "advance_wp2_wp3_module.F90", "advance_clubb_core_module.F90", "clubb_api_module.F90" ], "commitId" : "2ef3f37556bfcf08c474e6953814504db81c3ff0", "timestamp" : 1727377555000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Remove radf variable from CLUBB call \u000a\u000aFor pull request #1183 and ticket #1152.\u000a", "date" : "2024-09-26 14:05:55 -0500", "id" : "2ef3f37556bfcf08c474e6953814504db81c3ff0", "msg" : "Remove radf variable from CLUBB call", "paths" : [ { "editType" : "edit", "file" : "clubb_api_module.F90" }, { "editType" : "edit", "file" : "advance_wp2_wp3_module.F90" }, { "editType" : "edit", "file" : "advance_clubb_core_module.F90" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "SRC/SGS_CLUBB/clubb_sgs.F90" ], "commitId" : "e2a3ade475ec851c7e0c5f32ae31d41ae8dc8014", "timestamp" : 1727378201000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Remove radf variable from call to CLUBB\u000a\u000aFor pull request #158 and ticket larson-group/clubb#1152.\u000a", "date" : "2024-09-26 14:16:41 -0500", "id" : "e2a3ade475ec851c7e0c5f32ae31d41ae8dc8014", "msg" : "Remove radf variable from call to CLUBB", "paths" : [ { "editType" : "edit", "file" : "SRC/SGS_CLUBB/clubb_sgs.F90" } ] } ], "kind" : "git" } ], "culprits" : [ { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/bmg2", "fullName" : "bmg2" }, { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/root", "fullName" : "root" }, { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/griffinb", "fullName" : "Brian Griffin" }, { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/42725900+domkesteffen", "fullName" : "42725900+domkesteffen" }, { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephens", "fullName" : "benjamin.andrew.stephens" }, { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/sdomke", "fullName" : "Steffen Domke" }, { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/vlarson", "fullName" : "Vince Larson" }, { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm", "fullName" : "37674341+huebleruwm" }, { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/cernikt", "fullName" : "cernikt" }, { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/huebler", "fullName" : "Gunther Huebler" }, { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/59519056+bstephens82", "fullName" : "59519056+bstephens82" }, { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/larsongroupsysadmin", "fullName" : "LarsonGroupSysAdmin" } ], "inProgress" : False, "nextBuild" : { "number" : 77, "url" : "http://carson.math.uwm.edu/jenkins/view/all/job/branch_sam_test/77/" }, "previousBuild" : { "number" : 75, "url" : "http://carson.math.uwm.edu/jenkins/view/all/job/branch_sam_test/75/" } }