BRANCHorigin/masterTESTclubb_pgi_buildStarted by user Gunther HueblerhueblerGunther Huebler54482f6cfeafb97563bfd1f5c3f4f19a85a98b1d0f482f6cfeafb97563bfd1f5c3f4f19a85a98b1d0frefs/remotes/origin/broken_uninit_branch482f6cfeafb97563bfd1f5c3f4f19a85a98b1d0f482f6cfeafb97563bfd1f5c3f4f19a85a98b1d0frefs/remotes/origin/broken_uninit_branch634b16d833e86ad23ef6ea81de67c38c596ebccd254b16d833e86ad23ef6ea81de67c38c596ebccd25refs/remotes/origin/testing_tmp4b16d833e86ad23ef6ea81de67c38c596ebccd254b16d833e86ad23ef6ea81de67c38c596ebccd25refs/remotes/origin/testing_tmp620186c0953e7f6297679083156ead9f5b00da48630186c0953e7f6297679083156ead9f5b00da4863refs/remotes/origin/thlm_spike_fix20186c0953e7f6297679083156ead9f5b00da48630186c0953e7f6297679083156ead9f5b00da4863refs/remotes/origin/thlm_spike_fix25027ea997494b23a928f32489161280adff334596e27ea997494b23a928f32489161280adff334596erefs/remotes/origin/py3_check_budget27ea997494b23a928f32489161280adff334596e27ea997494b23a928f32489161280adff334596erefs/remotes/origin/py3_check_budget4c2430410e13a733d23852dd5abc08bbc6b02307bc2430410e13a733d23852dd5abc08bbc6b02307brefs/remotes/origin/feeding_stats_through_arg_listc2430410e13a733d23852dd5abc08bbc6b02307bc2430410e13a733d23852dd5abc08bbc6b02307brefs/remotes/origin/feeding_stats_through_arg_list640c7fc1f05bfd096c03e190497c2f2b6b7bba45820c7fc1f05bfd096c03e190497c2f2b6b7bba4582refs/remotes/origin/master0c7fc1f05bfd096c03e190497c2f2b6b7bba45820c7fc1f05bfd096c03e190497c2f2b6b7bba4582refs/remotes/origin/master0c7fc1f05bfd096c03e190497c2f2b6b7bba45820c7fc1f05bfd096c03e190497c2f2b6b7bba4582refs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#641171321102164branch_clubb_test #6464false6424646FAILURE1690922737005http://carson.math.uwm.edu/jenkins/view/all/job/branch_clubb_test/64/- run_scripts/README712c7fcb9fe3cd06406e1cff510e45070e9508841666112220000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding space because commit ba3b1ef5ceaa07706f078cc61cfdac22d3c6a1c3 in the sys_admin repo fixed a bug causing tests to fail, this means we have RESOLVED:d8df4eea1e41bee8cbd3de374148241f040fc03c, which was only labelled as failing since we erroneously checked the commit range it was included in.
2022-10-18 11:57:00 -0500712c7fcb9fe3cd06406e1cff510e45070e950884Adding space because commit ba3b1ef5ceaa07706f078cc61cfdac22d3c6a1c3 in the sys_admin repo fixed a bug causing tests to fail, this means we have RESOLVED:d8df4eea1e41bee8cbd3de374148241f040fc03c, which was only labelled as failing since we erroneously checked the commit range it was included in.editrun_scripts/README
- src/clubb_driver.F901715dbb290f3a73115e249c6624092680dc038931667323624000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comMaking clubb_driver only call the multicolumn driver if num_standalone_columns > 1
2022-11-01 12:27:04 -05001715dbb290f3a73115e249c6624092680dc03893Making clubb_driver only call the multicolumn driver if num_standalone_columns > 1editsrc/clubb_driver.F90
- src/CLUBB_core/mono_flux_limiter.F90f2b6fe4f75342f54923d94253bf87d3bd84cf0ff1667919348000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comMinor adjustment to eliminate spikes in thlm tendencies from the monotonic flux limiter. (#1043)
See https://github.com/NCAR/amwg_dev/discussions/134.
This commit will be BIT_CHANGING. Differences are mainly noticeable in the more sensitive cases.
2022-11-08 07:55:48 -0700f2b6fe4f75342f54923d94253bf87d3bd84cf0ffMinor adjustment to eliminate spikes in thlm tendencies from the monotonic flux limiter. (#1043)editsrc/CLUBB_core/mono_flux_limiter.F90
- src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/matrix_solver_wrapper.F90src/advance_microphys_module.F90src/CLUBB_core/mono_flux_limiter.F90src/CLUBB_core/lapack_wrap.F90src/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/penta_lu_solver.F90eaa6bc745ea28193de2b70e32f18d208c0502b461668629680000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comMaking interface for matrix solvers.
2022-11-16 14:14:40 -0600eaa6bc745ea28193de2b70e32f18d208c0502b46Making interface for matrix solvers.editsrc/CLUBB_core/mono_flux_limiter.F90editsrc/advance_microphys_module.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/lapack_wrap.F90addsrc/CLUBB_core/matrix_solver_wrapper.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90addsrc/CLUBB_core/penta_lu_solver.F90
- src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/matrix_solver_wrapper.F90src/advance_microphys_module.F90src/CLUBB_core/lapack_wrap.F90src/CLUBB_core/penta_lu_solver.F903db17ebd160e42d04b1128de2d904cf016a31c931668629680000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comMaking tridag tridiag everywhere, making sol soln, and adding intent comments.
2022-11-16 14:14:40 -06003db17ebd160e42d04b1128de2d904cf016a31c93Making tridag tridiag everywhere, making sol soln, and adding intent comments.editsrc/CLUBB_core/matrix_solver_wrapper.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/lapack_wrap.F90editsrc/CLUBB_core/penta_lu_solver.F90editsrc/advance_microphys_module.F90
- src/CLUBB_core/mono_flux_limiter.F90src/CLUBB_core/constants_clubb.F9081e8853ff0aaa5927cdd1d420489680fd28e4eb31669057917000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comA different way of dealing with monotonic flux limiter spikes (#1046)
* A different way of dealing with monotonic flux limiter spikes in CAM, by increasing the value
of thl_tol_mfl. ALso reverts the earlier fix. BIT_CHANGING.
See https://github.com/NCAR/amwg_dev/discussions/134#discussioncomment-4165447.
* Reducing value of thl_tol_mfl from 0.5 to 0.2.
This will be BIT_CHANGING.
2022-11-21 12:11:57 -070081e8853ff0aaa5927cdd1d420489680fd28e4eb3A different way of dealing with monotonic flux limiter spikes (#1046)editsrc/CLUBB_core/constants_clubb.F90editsrc/CLUBB_core/mono_flux_limiter.F90
- src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/grid_class.F90src/CLUBB_core/numerical_check.F90src/CLUBB_core/sfc_varnce_module.F90input_misc/tuner/error_four_cases.insrc/clubb_tuner.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/constants_clubb.F90src/clubb_driver.F90compile/config/linux_x86_64_gfortran.bashREADMEsrc/error.F90compile/compile.bash7c694ec0241527c624be7ada4de8f0a7b3f6b6101669128959000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comSteffens tuner fixer branch (#1041)
* Clubb ticket #1025: Implemented changes dealing with pdf_params%thl1/2 and wp2 floating point errors occurring in tuning runs. BIT_CHANGING
- Added command-line option -t/--tuner to compile.bash which enables the -DTUNER compiler flag.
- Added line to gfortran compilation config file to easily disable openMP
- Added a couple error messages and cleaned up some instances of error handling in src/error.F90, src/clubb_driver.F90, and src/CLUBB_core/advance_clubb_core_module.F90
- Added global constant wp2_max in src/CLUBB_core/constants_clubb.F90 which sets the upper bound for wp2
- In pdf_closure, added sanity checks for pdf_params%thl1/2 (>=190K, <=1000K)
- Added debug warning in src/CLUBB_core/advance_wp2_wp3_module.F90 when wp2 is clipped.
- Added wp2_sfc clipping in src/CLUBB_core/sfc_varnce_module.F90
- Added debug_level_check to NaN check in clubb_driver.F90
- Added mention of the new compiler option to the README
2022-11-22 08:55:59 -06007c694ec0241527c624be7ada4de8f0a7b3f6b610Steffens tuner fixer branch (#1041)editsrc/CLUBB_core/numerical_check.F90editREADMEeditsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/pdf_closure_module.F90editinput_misc/tuner/error_four_cases.ineditsrc/clubb_driver.F90editcompile/compile.basheditsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/clubb_tuner.F90editsrc/CLUBB_core/grid_class.F90editsrc/CLUBB_core/sfc_varnce_module.F90editsrc/error.F90editsrc/CLUBB_core/constants_clubb.F90editcompile/config/linux_x86_64_gfortran.bash
- src/CLUBB_core/advance_wp2_wp3_module.F90run_scripts/clubb.insrc/G_unit_test_types/spurious_source_test.F90run_scripts/diff.ncrun_scripts/error_diffs.txtsrc/clubb_tuner.F90src/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/CLUBB_core/matrix_solver_wrapper.F90src/clubb_driver.F90src/CLUBB_core/model_flags.F90src/CLUBB_core/clubb_api_module.F90src/advance_microphys_module.F90src/CLUBB_core/mono_flux_limiter.F90src/G_unit_test_types/pdf_parameter_tests.F90input/tunable_parameters/configurable_model_flags.in1a43597bdd06c12411ea8698c4f1f200efec74781669261456000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comAdding capability to change matrix solving method via clubb_config_flags.
2022-11-23 21:44:16 -06001a43597bdd06c12411ea8698c4f1f200efec7478Adding capability to change matrix solving method via clubb_config_flags.editsrc/advance_microphys_module.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/clubb_tuner.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/clubb_api_module.F90editinput/tunable_parameters/configurable_model_flags.ineditsrc/CLUBB_core/matrix_solver_wrapper.F90addrun_scripts/diff.nceditsrc/CLUBB_core/model_flags.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90addrun_scripts/error_diffs.txteditsrc/CLUBB_core/mono_flux_limiter.F90addrun_scripts/clubb.ineditsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/G_unit_test_types/spurious_source_test.F90
- src/CLUBB_core/matrix_solver_wrapper.F90a8f324c4ae9dc0526fb9a1e622e32c8c20a4e0de1669261456000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comFixing small bug, need to pass _copy arrays to prevent lapack mangling the real ones.
2022-11-23 21:44:16 -0600a8f324c4ae9dc0526fb9a1e622e32c8c20a4e0deFixing small bug, need to pass _copy arrays to prevent lapack mangling the real ones.editsrc/CLUBB_core/matrix_solver_wrapper.F90
- src/CLUBB_core/penta_lu_solver.F903ebfa3db3b485a4f58bd654b25f8608c1aa7d7bd1669261456000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comMaking GPU and CPU versions of the penta_lu solver the same as discussed in larson-group/clubb#1024.
2022-11-23 21:44:16 -06003ebfa3db3b485a4f58bd654b25f8608c1aa7d7bdMaking GPU and CPU versions of the penta_lu solver the same as discussed in larson-group/clubb#1024.editsrc/CLUBB_core/penta_lu_solver.F90
- run_scripts/clubb.in2bd6ee654291f54e5cef61d19ed05e2bf3aa31801669261456000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comDelete clubb.in
2022-11-23 21:44:16 -06002bd6ee654291f54e5cef61d19ed05e2bf3aa3180Delete clubb.indeleterun_scripts/clubb.in
- run_scripts/error_diffs.txtcc464d80a7a992f426920d24659455a72a223a911669261456000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comDelete error_diffs.txt
2022-11-23 21:44:16 -0600cc464d80a7a992f426920d24659455a72a223a91Delete error_diffs.txtdeleterun_scripts/error_diffs.txt
- run_scripts/error_diffs.txtrun_scripts/clubb.in33dd904e2f71c1cf801dbcdd71e8b796cc1c55f11669261456000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comAdding capability to change matrix solving method via clubb_config_flags.
2022-11-23 21:44:16 -060033dd904e2f71c1cf801dbcdd71e8b796cc1c55f1Adding capability to change matrix solving method via clubb_config_flags.addrun_scripts/clubb.inaddrun_scripts/error_diffs.txt
- run_scripts/error_diffs.txtrun_scripts/diff.ncrun_scripts/clubb.in873ae270b4c4c112e6e7da83ba0f7df4aff9b9581669261456000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comRemoving unwanted files.
2022-11-23 21:44:16 -0600873ae270b4c4c112e6e7da83ba0f7df4aff9b958Removing unwanted files.deleterun_scripts/error_diffs.txtdeleterun_scripts/diff.ncdeleterun_scripts/clubb.in
- input/tunable_parameters/configurable_model_flags.in61b4a67e170bc2243263ac19fb90b24f5a1e455b1669328447000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduReplacing $ with & in namelist definition to make consistent.
2022-11-24 16:20:47 -060061b4a67e170bc2243263ac19fb90b24f5a1e455bReplacing $ with & in namelist definition to make consistent.editinput/tunable_parameters/configurable_model_flags.in
- utilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/sens_matrix_dashboard.py216528613a53b626f93c97867ec2b69bb7ba9da11669637928000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@users.noreply.github.comCreates separate file for inputting data to the tuner
2022-11-28 13:18:48 +0100216528613a53b626f93c97867ec2b69bb7ba9da1Creates separate file for inputting data to the tunereditutilities/sens_matrix/sens_matrix_dashboard.pyaddutilities/sens_matrix/set_up_dashboard_inputs.py
- src/CLUBB_core/mixing_length.F90c50ab36d29f7c3cdbadbfa6cfa5cf935451e26a21669684430000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added "smooth" max clipping for invrs_tau_shear, which is a variable
that is supposed to be positive definite, yet was obtaining negative
values at the model lower boundary owing to linear extension at the
boundaries as part of the linear interpolation call.
This change is BIT_CHANGING.
2022-11-28 19:13:50 -0600c50ab36d29f7c3cdbadbfa6cfa5cf935451e26a2I added "smooth" max clipping for invrs_tau_shear, which is a variableeditsrc/CLUBB_core/mixing_length.F90
- compile/config/linux_x86_64_nvhpc_casper.bashsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90dd076c1c9334039050dfc1a098d1cbbf997dad911670362528000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comADG1_pdf_driver subroutine port with OpenACC
Added OpenACC related flags in linux_x86_64_nvhpc_casper.bash
You can enable/disable OpenACC compilation using OPENACC=true/false.
Added OpenACC directives in ADG1_pdf_driver subroutine.
2022-12-06 15:35:28 -0600dd076c1c9334039050dfc1a098d1cbbf997dad91ADG1_pdf_driver subroutine port with OpenACCeditsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90editcompile/config/linux_x86_64_nvhpc_casper.bash
- src/G_unit_test_types/pdf_parameter_tests.F90src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90src/G_unit_test_types/spurious_source_test.F90b6d7e4f16f711f1df7e991d2a854936bb07825171670362528000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comReplacing old elemental ADG1_w_closure with new GPUized one. Making G_unit tests work with new version. Also making mixt_frac_max_mag a scalar since it was only being used as such. larson-group/clubb#1049
2022-12-06 15:35:28 -0600b6d7e4f16f711f1df7e991d2a854936bb0782517Replacing old elemental ADG1_w_closure with new GPUized one. Making G_unit tests work with new version. Also making mixt_frac_max_mag a scalar since it was only being used as such. larson-group/clubb#1049editsrc/G_unit_test_types/spurious_source_test.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90
- src/clubb_driver.F90803a30a547fcc2771a30a51f56ebc7de8d8421741670362897000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking the multicolumn code open the netcdf file before writing and close when finished writing. This fixes a bug where the netcdf data wasn't being written.
2022-12-06 15:41:37 -0600803a30a547fcc2771a30a51f56ebc7de8d842174Making the multicolumn code open the netcdf file before writing and close when finished writing. This fixes a bug where the netcdf data wasn't being written.editsrc/clubb_driver.F90
- utilities/sens_matrix/sens_matrix_dashboard.pyutilities/sens_matrix/__pycache__/analyze_sensitivity_matrix.cpython-310.pycutilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/analyze_sensitivity_matrix.pyab881650d8bfbf6dfbc652c1063f8f9ea10e68011670594007000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@users.noreply.github.comFor tuning dashboard, modify the separate input file
that contains "namelist" data (i.e., input data) for tuning runs.
2022-12-09 14:53:27 +0100ab881650d8bfbf6dfbc652c1063f8f9ea10e6801For tuning dashboard, modify the separate input fileeditutilities/sens_matrix/analyze_sensitivity_matrix.pyaddutilities/sens_matrix/__pycache__/analyze_sensitivity_matrix.cpython-310.pyceditutilities/sens_matrix/sens_matrix_dashboard.pyeditutilities/sens_matrix/set_up_dashboard_inputs.py
- utilities/sens_matrix/__pycache__/analyze_sensitivity_matrix.cpython-310.pycfa8048b3d5d5023dfc49e9d8dd4657b80f02f5611670594658000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@users.noreply.github.comDelete tuner file that was accidentally committed
2022-12-09 15:04:18 +0100fa8048b3d5d5023dfc49e9d8dd4657b80f02f561Delete tuner file that was accidentally committeddeleteutilities/sens_matrix/__pycache__/analyze_sensitivity_matrix.cpython-310.pyc
- .gitignore31fd72c504443be6a94bb4d846619ba4cf132da31670594753000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@users.noreply.github.comPrevent accidental commits of python .pyc files
2022-12-09 15:05:53 +010031fd72c504443be6a94bb4d846619ba4cf132da3Prevent accidental commits of python .pyc filesedit.gitignore
- src/CLUBB_core/parameters_tunable.F90caa222a50d383a0400f09f218434327430bdb9961670635449000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI can now safely remove all the "ifdef E3SM" statements from CLUBB's
parameters_tunable.F90. This code is now located in the clubb_intr.F90
portion of E3SM.
2022-12-09 19:24:09 -0600caa222a50d383a0400f09f218434327430bdb996I can now safely remove all the "ifdef E3SM" statements from CLUBB'seditsrc/CLUBB_core/parameters_tunable.F90
- utilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/sens_matrix_dashboard.py94ffde078414db4311ae719e08c642c8a7e9a1131670853584000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@users.noreply.github.comFor the dashboard, creates a forward model solution function.
2022-12-12 14:59:44 +010094ffde078414db4311ae719e08c642c8a7e9a113For the dashboard, creates a forward model solution function.editutilities/sens_matrix/sens_matrix_dashboard.pyeditutilities/sens_matrix/set_up_dashboard_inputs.py
- utilities/sens_matrix/README.mdc2bce735f14469362d3042e38bb5553ef4dbb5551671039291000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comI updated and augmented the instructions to run the tuner.
2022-12-14 18:34:51 +0100c2bce735f14469362d3042e38bb5553ef4dbb555I updated and augmented the instructions to run the tuner.editutilities/sens_matrix/README.md
- utilities/read_sam_moments/netcdf_var_collector.pyutilities/read_sam_moments/README.mdd956707573fb70588a9f8b0219a5585c8577040a1671724607000http://carson.math.uwm.edu/jenkins/user/cerniktcernikttjcernik@uwm.eduadded ntecdf var collector and readme to clubb repo
2022-12-22 09:56:47 -0600d956707573fb70588a9f8b0219a5585c8577040aadded ntecdf var collector and readme to clubb repoaddutilities/read_sam_moments/netcdf_var_collector.pyaddutilities/read_sam_moments/README.md
- utilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/sens_matrix_dashboard.py2f930309d0a901cb4ba97ecd7766e81141b299931672657045000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@users.noreply.github.comAdds to tuner code for min dp for stubborn parameters
and adds code to start adding error bars on arrow plots.
2023-01-02 11:57:25 +01002f930309d0a901cb4ba97ecd7766e81141b29993Adds to tuner code for min dp for stubborn parameterseditutilities/sens_matrix/set_up_dashboard_inputs.pyeditutilities/sens_matrix/sens_matrix_dashboard.py
- compile/config/linux_x86_64_nvhpc_gpu.bashef9acf81f5828bb0d26258d7e2ae2e0ad5959bb51672778933000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding config script to compile with openacc using nvhpc.
2023-01-03 14:48:53 -0600ef9acf81f5828bb0d26258d7e2ae2e0ad5959bb5Adding config script to compile with openacc using nvhpc.addcompile/config/linux_x86_64_nvhpc_gpu.bash
- src/CLUBB_core/matrix_solver_wrapper.F90src/CLUBB_core/lapack_wrap.F906d5d5f573f3866d5d66b028d829342026e5690991673472578000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comPushing column loop into lapack wrap.
2023-01-11 15:29:38 -06006d5d5f573f3866d5d66b028d829342026e569099Pushing column loop into lapack wrap.editsrc/CLUBB_core/matrix_solver_wrapper.F90editsrc/CLUBB_core/lapack_wrap.F90
- compile/config/linux_x86_64_nvhpc_casper.bashsrc/CLUBB_core/constants_clubb.F90src/CLUBB_core/model_flags.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/saturation.F9088b8239840f581d76610aa630dab6219d64d68be1673549655000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRestructuring and Porting of Compute_mixing_length subroutine(Phase 1) (#1052)
* Restructuring and Porting of Compute_mixing_length subroutine(Phase 1)
Restructure: The compute_mixing_length is one of the top most routine taking 35-50%
of the total time in a single timestep. The subroutine has been restructured to
push the i-loop further down to extract vectorization and parallelization.
The restructuring also involves introduction of sat_mixrat_liq_acc routines to
extract parallelism when called inside a OpenACC parallel region.
Porting: OpenACC directives are inserted to port the restructured compute_mixing_length
code on to the GPUs. This port is currently unoptimized and there is still room for improvement.
NOTE: Currently, l_sat_mixrat_lookup = false and saturation_formula = saturation_flatau
(Earthworks config options) case is supported on OpenACC build. Any other options works
on CPUs as usual. OpenACC declare create directives are inserted in model_flags and
constants_clubb, as these module variables are used inside the saturation routines.
* Added debug message about only supporting
l_sat_mixrat_lookup = false and saturation_formula = saturation_flatau
on GPUs
Answers are Bit for Bit with arm-multicolumn case + nvhpc compiler.
* Changing CLUBB debug level 1 to 0 for the saturation formula support
running on GPUs
* Changing indentation to make gfortran happy, it wants ifdefs to start at the beginning of the line.
* Adding use statements for error checks and printouts, also making the errors set err_code to clubb_fatal_error.
Co-authored-by: huebler <huebler@uwm.edu>
2023-01-12 12:54:15 -060088b8239840f581d76610aa630dab6219d64d68beRestructuring and Porting of Compute_mixing_length subroutine(Phase 1) (#1052)editcompile/config/linux_x86_64_nvhpc_casper.basheditsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/model_flags.F90editsrc/CLUBB_core/constants_clubb.F90editsrc/CLUBB_core/saturation.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/model_flags.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/saturation.F907f1decd0252e0b4d80f4b3873b0b48b6d3ec86311674081416000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRestructuring and Porting of Compute_mixing_length subroutine(Phase 2) (#1054)
* Restructuring and Porting of Compute_mixing_length subroutine(Phase 2)
Restructure: sat_mixrat_liq_2D_acc is being directly called instead of
calling the 1D version inside the column loop. Changing sat_mixrat_liq_2D_acc
to a subroutine from a function and adding output array, start_index as
additional argument. This is a workaround for passing sub-arrays. The OpenACC
doen't like the sub-arrays being passed and fails the validation.
Porting: OpenACC directives are added inside sat_mixrat_liq_2D_acc for porting
Validation: Answers are Bit for Bit with arm-multicolumn case + nvhpc compiler
* Fix for compilation issues
Issue 1: Missed out declaring 'start_index' while intergrating the
change
Issue 2: The use of error_code module and the procedures inside it
causes OpenACC compilation issues when run on the device.
* Removing the sat_mixrat_liq_acc and sat_mixrat_liq_2D_acc, making the normal sat_mixrat_liq work for all current use cases, and making the other versions of sat_mixrat_liq (bolton,gfdl,lookup) functional with OPENACC.
Co-authored-by: huebler <huebler@uwm.edu>
2023-01-18 16:36:56 -06007f1decd0252e0b4d80f4b3873b0b48b6d3ec8631Restructuring and Porting of Compute_mixing_length subroutine(Phase 2) (#1054)editsrc/CLUBB_core/model_flags.F90editsrc/CLUBB_core/saturation.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/mixing_length.F90
- src/CLUBB_core/mono_flux_limiter.F90e21e2713eab0f3f228189a4b407c80d4f241038f1674153381000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comBreaking up column loop in mono_flux_limiter. This may not be the final form for GPUization, but it's definitely a start, no longer do we have to copy single column variables to multicolumn ones anywhere. (#1051)
2023-01-19 12:36:21 -0600e21e2713eab0f3f228189a4b407c80d4f241038fBreaking up column loop in mono_flux_limiter. This may not be the final form for GPUization, but it's definitely a start, no longer do we have to copy single column variables to multicolumn ones anywhere. (#1051)editsrc/CLUBB_core/mono_flux_limiter.F90
- src/CLUBB_core/matrix_solver_wrapper.F90src/CLUBB_core/model_flags.F90src/CLUBB_core/tridiag_lu_solver.F90src/CLUBB_core/lapack_wrap.F90src/CLUBB_core/penta_lu_solver.F90dda5e8c57edb41b73340c0f9578d7c327b18e0761674153404000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdding tridiag_lu solver (#1056)
* Adding tridiag_lu solver
* Changing low to lower in tridiag_lu and penta_lu, also fixing up some spacing.
* Making variables that represent matrix solutions more consistently named.
2023-01-19 12:36:44 -0600dda5e8c57edb41b73340c0f9578d7c327b18e076Adding tridiag_lu solver (#1056)editsrc/CLUBB_core/lapack_wrap.F90editsrc/CLUBB_core/penta_lu_solver.F90addsrc/CLUBB_core/tridiag_lu_solver.F90editsrc/CLUBB_core/model_flags.F90editsrc/CLUBB_core/matrix_solver_wrapper.F90
- utilities/sens_matrix/sens_matrix_dashboard.pyf9eb64fb27f4b0515602e0f46848fc644035cfaf1674232314000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@users.noreply.github.comAdds to tuner error bars on bias removal (arrow) plots
and also adds bar graphs that show how each parameter contributes to the bias removal.
2023-01-20 17:31:54 +0100f9eb64fb27f4b0515602e0f46848fc644035cfafAdds to tuner error bars on bias removal (arrow) plotseditutilities/sens_matrix/sens_matrix_dashboard.py
- src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90src/CLUBB_core/mixing_length.F9095217702784b7eddc848ef0d6f7ee705c10d77521674580201000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@users.noreply.github.comAdding OpenACC data directives for mixing length and adg routines
OpenACC structured data regions are added to optimize the data transfers
between CPU and GPU. These data regions will converted to unstrucutred
data region in the later optimization phase.
Results are bit for bit.
2023-01-24 18:10:01 +010095217702784b7eddc848ef0d6f7ee705c10d7752Adding OpenACC data directives for mixing length and adg routineseditsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90editsrc/CLUBB_core/mixing_length.F90
- src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90a0f5313ee697be2153704f9d4b9775cde7d717a11674585724000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing error causing GPU code not to run. Some variables to be copied were labelled as (ngrdcol,nz) when it should be (:ngrdcol,:nz). I've just removed the data length specifiers completely since they are not neccesary in general.
2023-01-24 12:42:04 -0600a0f5313ee697be2153704f9d4b9775cde7d717a1Fixing error causing GPU code not to run. Some variables to be copied were labelled as (ngrdcol,nz) when it should be (:ngrdcol,:nz). I've just removed the data length specifiers completely since they are not neccesary in general.editsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90
- src/CLUBB_core/stats_clubb_utilities.F90src/CLUBB_core/saturation.F9015a351eec8d677c5035bce255aac81898c7958221674680903000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comGPUizing sat_mixrat_ice_2D.
2023-01-25 15:08:23 -060015a351eec8d677c5035bce255aac81898c795822GPUizing sat_mixrat_ice_2D.editsrc/CLUBB_core/stats_clubb_utilities.F90editsrc/CLUBB_core/saturation.F90
- utilities/sens_matrix/sens_matrix_dashboard.py822ec13b0db0f3beb4eb93d796d5221a0d3c5f931674740212000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@users.noreply.github.comAdds to dashboard plots error bars for
bias removal plot, a colored correlation matrix,
a matrix of linear-based 2-point bounds on parameter perturbations,
and a web-page version of the 3-dot subplots.
2023-01-26 14:36:52 +0100822ec13b0db0f3beb4eb93d796d5221a0d3c5f93Adds to dashboard plots error bars foreditutilities/sens_matrix/sens_matrix_dashboard.py
- utilities/sens_matrix/sens_matrix_dashboard.py1025d807ab1f3d5e8d3a8deb72595f2314b1cec51675100849000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@users.noreply.github.comAdds to dashboard a bar plot that separates nonlinear
and linear contributions to bias removal.
Also abbreviates the clubb parameter names in the plots.
2023-01-30 18:47:29 +01001025d807ab1f3d5e8d3a8deb72595f2314b1cec5Adds to dashboard a bar plot that separates nonlineareditutilities/sens_matrix/sens_matrix_dashboard.py
- run_scripts/run_tuner.bashREADMEcfd87ac680ebb26e2fdb7b1aab7a8b8b4fc753201675178299000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@users.noreply.github.comAdded option (-i) to run_tuner.bash script to enable pre-tuning standalone runs. README will be updated.
2023-01-31 16:18:19 +0100cfd87ac680ebb26e2fdb7b1aab7a8b8b4fc75320Added option (-i) to run_tuner.bash script to enable pre-tuning standalone runs. README will be updated.editREADMEeditrun_scripts/run_tuner.bash
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/calc_pressure.F90src/clubb_driver.F90src/input_interpret.F900fafc6b0b1f1a6058d37bf3db4bb3708204504db1675364876000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comPushing column loop into calculate_thvm
2023-02-02 13:07:56 -06000fafc6b0b1f1a6058d37bf3db4bb3708204504dbPushing column loop into calculate_thvmeditsrc/clubb_driver.F90editsrc/input_interpret.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/calc_pressure.F90
- src/CLUBB_core/calc_pressure.F908c7230fecb877d04fb129ef5e143e0993b4b29b11675364876000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comRemoving update_pressure since it is no longer called anywhere in clubb or host models. The addition of this subroutine was discussed in larson-group/e3sm#6 and the removal of the call to it was discussed in larson-group/clubb#926.
2023-02-02 13:07:56 -06008c7230fecb877d04fb129ef5e143e0993b4b29b1Removing update_pressure since it is no longer called anywhere in clubb or host models. The addition of this subroutine was discussed in larson-group/e3sm#6 and the removal of the call to it was discussed in larson-group/clubb#926.editsrc/CLUBB_core/calc_pressure.F90
- src/CLUBB_core/calc_pressure.F902f84d7c748f143990316004c66ebda5486de57521675552920000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving update_pressure from public list. This was causing compilation crashes. RESOLVED:8c7230fecb877d04fb129ef5e143e0993b4b29b1
2023-02-04 17:22:00 -06002f84d7c748f143990316004c66ebda5486de5752Removing update_pressure from public list. This was causing compilation crashes. RESOLVED:8c7230fecb877d04fb129ef5e143e0993b4b29b1editsrc/CLUBB_core/calc_pressure.F90
- src/input_interpret.F905850944600089fe2cb244ca1b08973231b6d91d31675573004000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bug, arrays given a dummy index in 0fafc6b0b1f1a6058d37bf3db4bb3708204504db are declared nsize, but are only used up to nlevels, thus we need the (1,1:nlevels) specifier when passing them. This issue was only caught by our _debug tests, so that's good evidence the new flags we added to initialize unused to memory was effective.
2023-02-04 22:56:44 -06005850944600089fe2cb244ca1b08973231b6d91d3Fixing bug, arrays given a dummy index in 0fafc6b0b1f1a6058d37bf3db4bb3708204504db are declared nsize, but are only used up to nlevels, thus we need the (1,1:nlevels) specifier when passing them. This issue was only caught by our _debug tests, so that's good evidence the new flags we added to initialize unused to memory was effective.editsrc/input_interpret.F90
- src/CLUBB_core/turbulent_adv_pdf.F90src/CLUBB_core/grid_class.F90src/CLUBB_core/mean_adv.F90src/CLUBB_core/saturation.F90c9a950dbbf76e82a3cda0ab2d65f29cd5f28df121675791268000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comGPUizing some helping procedures.
2023-02-07 11:34:28 -0600c9a950dbbf76e82a3cda0ab2d65f29cd5f28df12GPUizing some helping procedures.editsrc/CLUBB_core/grid_class.F90editsrc/CLUBB_core/mean_adv.F90editsrc/CLUBB_core/turbulent_adv_pdf.F90editsrc/CLUBB_core/saturation.F90
- src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F907d6dfad026e40eaf30f29ffa17c23dfbed8820401675791268000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comRemoving sigma_sqd_w from the acc data copyout statement. This is a bug which was causing the code to crash when not using managed memory.
2023-02-07 11:34:28 -06007d6dfad026e40eaf30f29ffa17c23dfbed882040Removing sigma_sqd_w from the acc data copyout statement. This is a bug which was causing the code to crash when not using managed memory.editsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90
- src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/pdf_utilities.F9047cd566e64abb0e774abd20c2ec97deed8dd3ab51675902842000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comPorting pdf_closure subroutine with OpenACC (#1059)
* Porting pdf_closure subroutine with OpenACC
OpenACC directives are added to pdf_closure subroutine. The necessary
structured data region is also added for optimzing data movement across
kernels. There is opportunity to task parallelize using streams and
will be explored in the future.
Answers are bit for bit.
* Fixing the copyin directives
* Making work without managed memory.
2023-02-08 18:34:02 -060047cd566e64abb0e774abd20c2ec97deed8dd3ab5Porting pdf_closure subroutine with OpenACC (#1059)editsrc/CLUBB_core/pdf_utilities.F90editsrc/CLUBB_core/pdf_closure_module.F90
- utilities/read_sam_moments/netcdf_var_collector.pyb361c61e93c25e1a491a5ff4fdbe5cbcc1f0f7351676148083000http://carson.math.uwm.edu/jenkins/user/cerniktcerniktcernikt@msoe.edumade graphing for netcdf_var collector general. #1040
2023-02-11 14:41:23 -0600b361c61e93c25e1a491a5ff4fdbe5cbcc1f0f735made graphing for netcdf_var collector general. #1040editutilities/read_sam_moments/netcdf_var_collector.py
- src/CLUBB_core/advance_clubb_core_module.F90input/stats/standard_stats.insrc/CLUBB_core/stats_variables.F90src/CLUBB_core/stats_clubb_utilities.F90src/CLUBB_core/stats_zm_module.F90input/stats/all_stats.inf4a832bf41d24a08e9b5be84713c057dfa98084e1676661825000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAdding wp3_on_wp2_cfl_num to CLUBB's output stats.
2023-02-17 13:23:45 -0600f4a832bf41d24a08e9b5be84713c057dfa98084eAdding wp3_on_wp2_cfl_num to CLUBB's output stats.editinput/stats/standard_stats.ineditsrc/CLUBB_core/stats_clubb_utilities.F90editsrc/CLUBB_core/stats_zm_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editinput/stats/all_stats.ineditsrc/CLUBB_core/stats_variables.F90
- postprocessing/pyplotgen/config/VariableGroupNondimMoments.py28e0fce01e7815ba9476ef6de24e556755f142d41676666305000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAdded wp3_on_wp2_cfl_num to the VariableGroupNondimMoments.py file for
pyplotgen use.
2023-02-17 14:38:25 -060028e0fce01e7815ba9476ef6de24e556755f142d4Added wp3_on_wp2_cfl_num to the VariableGroupNondimMoments.py file foreditpostprocessing/pyplotgen/config/VariableGroupNondimMoments.py
- postprocessing/pyplotgen/config/VariableGroupNondimMoments.pyf41e9c4d0b929e0bcbfb84ee6705ab3b979a65201677083898000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate VariableGroupNondimMoments.py
Fixed a typo
2023-02-22 10:38:18 -0600f41e9c4d0b929e0bcbfb84ee6705ab3b979a6520Update VariableGroupNondimMoments.pyeditpostprocessing/pyplotgen/config/VariableGroupNondimMoments.py
- src/clubb_driver.F90d3264a2623c048a97b2dd6d8bb43f14c0e496f0c1677519729000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comFixing bug. This was only triggered when l_input_fields=.true., which I am only testing because it needs to be true so that I can test ADG2_driver.
2023-02-27 11:42:09 -0600d3264a2623c048a97b2dd6d8bb43f14c0e496f0cFixing bug. This was only triggered when l_input_fields=.true., which I am only testing because it needs to be true so that I can test ADG2_driver.editsrc/clubb_driver.F90
- src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90fa914b7afea4b486d22cdaa23fb1fa70c05785591677519729000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comRemoving usage of gr from pdf_closure. It was only ever used for nz, which is now fed in directly.
2023-02-27 11:42:09 -0600fa914b7afea4b486d22cdaa23fb1fa70c0578559Removing usage of gr from pdf_closure. It was only ever used for nz, which is now fed in directly.editsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90
- input_misc/tuner/error_atex.ininput_misc/tuner/error_rico.insrc/CLUBB_core/pdf_closure_module.F90input_misc/tuner/error_gabls3_night.ininput_misc/tuner/error_nov11_altocu.insrc/G_unit_test_types/tuner_tests.F90input_misc/tuner/error_four_cases.insrc/clubb_tuner.F90input_misc/tuner/error_dycoms2_rf02_ds.ininput_misc/tuner/error_dycoms2_rf01.ininput_misc/tuner/error_wangara.ininput_misc/tuner/error_dycoms2_rf02_do.ininput_misc/tuner/error_dycoms2_rf02_nd.ininput_misc/tuner/error_arm.ininput_misc/tuner/error_bomex.ininput_misc/tuner/error_bomex_fire.insrc/enhanced_simann.F90compile/READMEinput_misc/tuner/error_all.ininput_misc/tuner/error_arm_97.insrc/clubb_driver.F90input_misc/tuner/error_lba.inREADMEinput_misc/tuner/READMEinput_misc/tuner/error_fire.insrc/error.F90input_misc/tuner/error_gabls2.incompile/compile.bashinput_misc/tuner/error_ticket_756.in981b9ba9bc9b5d80edc82f52f502ab9bcce097db1677613563000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb ticket #1025: Implemented way to make esa tuner reproducible, h… (#1068)
* Clubb ticket #1025: Implemented way to make esa tuner reproducible, hid error output of optional diagnostic variables behind check, fixed parallelization issue with tuner, esa max_iters parameter is now in stats namelist, fixed issue with TUNER compiler directive, some small fixes.
- New namelist variables prescribed_rand_seed and l_use_prescribed_rand_seed determine if the esa tuner will use a random or a fixed value as random seed. Added descriptions to README.
- Added max_iters to stats namelist to make it more modifiable.
- Renamed stp_adjst_intercept_in and stp_adjst_slope_in to stp_adjst_shift_in and stp_adjst_factor_in, respectively, to better reflect their influence on step size.
- The error output in src/CLUBB_core/pdf_closure_module.F90 for the diagnostic variables wprtp2, wpthlp2, wprtpthlp, and rcp2 is now hidden behind existence checks for these variables. And a clarification was added to "#ifdef TUNER" directive.
- NetCDF file access caused the tuner to crash in parallel mode (-fopenmp flag in config file and multiple cases). Adding an $OMP CRITICAL structure around the call to stats_init in clubb_driver.F90 fixed that.
- Fixed compile/README. Config files are specified with the -c option.
- The -t option in run_scripts/run_tuner.bash interfered with the previous usage of the TUNER compiler directive. Renamed the old TUNER directive to NR_SP, a short for "numerical recipes, single precision". TUNER now is the option to "turn on" code changes required to run the tuner.
2023-02-28 13:46:03 -0600981b9ba9bc9b5d80edc82f52f502ab9bcce097dbClubb ticket #1025: Implemented way to make esa tuner reproducible, h… (#1068)editinput_misc/tuner/READMEeditinput_misc/tuner/error_dycoms2_rf02_ds.ineditsrc/clubb_driver.F90editsrc/clubb_tuner.F90editinput_misc/tuner/error_dycoms2_rf02_do.ineditinput_misc/tuner/error_gabls3_night.ineditsrc/G_unit_test_types/tuner_tests.F90editcompile/READMEeditinput_misc/tuner/error_arm.ineditinput_misc/tuner/error_bomex.ineditinput_misc/tuner/error_atex.ineditinput_misc/tuner/error_all.ineditinput_misc/tuner/error_arm_97.ineditinput_misc/tuner/error_dycoms2_rf01.inaddinput_misc/tuner/error_bomex_fire.ineditinput_misc/tuner/error_fire.ineditinput_misc/tuner/error_dycoms2_rf02_nd.ineditinput_misc/tuner/error_lba.ineditREADMEeditsrc/error.F90editinput_misc/tuner/error_four_cases.ineditinput_misc/tuner/error_wangara.ineditcompile/compile.basheditinput_misc/tuner/error_rico.ineditinput_misc/tuner/error_nov11_altocu.ineditinput_misc/tuner/error_ticket_756.ineditinput_misc/tuner/error_gabls2.ineditsrc/enhanced_simann.F90editsrc/CLUBB_core/pdf_closure_module.F90
- utilities/autocommit_message_maker/autocommit_message_maker.py965964e81cc6b58ffbf3213af1d2488080b3371a1677867187000http://carson.math.uwm.edu/jenkins/user/cerniktcernikttjcernik@uwm.eduadded autocommit message maker to clubb so I have an easier time testing it
2023-03-03 12:13:07 -0600965964e81cc6b58ffbf3213af1d2488080b3371aadded autocommit message maker to clubb so I have an easier time testing itaddutilities/autocommit_message_maker/autocommit_message_maker.py
- utilities/autocommit_message_maker/autocommit_message_maker.py6e4204729c1b525b0f2fde3d7c715f5982fc79c31677881620000http://carson.math.uwm.edu/jenkins/user/cerniktcernikttjcernik@uwm.educhanges to integrate message maker into gitUpdate scripts
2023-03-03 16:13:40 -06006e4204729c1b525b0f2fde3d7c715f5982fc79c3changes to integrate message maker into gitUpdate scriptseditutilities/autocommit_message_maker/autocommit_message_maker.py
- utilities/autocommit_message_maker/autocommit_message_maker.pybe6ab481c56acfc66d65990889dba011d6bcd36a1677881884000http://carson.math.uwm.edu/jenkins/user/cerniktcernikttjcernik@uwm.eduOops, I made 1 small error, should be consistent now.
2023-03-03 16:18:04 -0600be6ab481c56acfc66d65990889dba011d6bcd36aOops, I made 1 small error, should be consistent now.editutilities/autocommit_message_maker/autocommit_message_maker.py
- input/case_setups/rico_sounding.ininput/case_setups/bomex_model.ininput/case_setups/rico_silhs_model.ininput/case_setups/dycoms2_rf02_ds_model.ininput/case_setups/rico_model.ininput/case_setups/dycoms2_rf02_do_model.ininput/case_setups/dycoms2_rf02_morr_model.insrc/clubb_driver.F90input/case_setups/wangara_sounding.ininput/case_setups/dycoms2_rf02_nd_model.insrc/sounding.F90input/case_setups/dycoms2_rf02_so_model.ininput/case_setups/dycoms2_rf02_sounding.ininput/case_setups/bomex_sounding.ininput/case_setups/wangara_model.in9aeea149d5970cb99218344f8bde576e1f036d211677883168000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduImplementing changes to the initial conditions.
This commit contains code changes related to the modified initial
conditions for convergence test simulations. These code changes can be
activated by setting l_modify_ic_with_cubic_int = .true. in
the namelist on a case-by-case basis.
Along with this option, the sounding profiles are also modified for
the BOMEX, RICO, DYCOMS2_RF02 and Wangara cases.
-- For BOMEX, RICO, Wangara cases, we add more height levels in the
original sounding profiles so that the cubic spline interpolation
produces consistent profiles with those with linear interpolation
-- For DYCOMS2_RF02, instead of using the formulations in the code to
derive the initial condition profiles (which will results in the
grid-spacing dependent initial condition when we refine grid), we
construct a sounding profiles (still use the same formulas as in
the src/sounding.F90) on a high-resolution grid (refine the standard
grid by a factor of 2^7), then save the profile in
dycoms2_rf02_sounding.in. In this way, the model initiliazation will
always read the same sounding profile for initialization when user
refine the vertical model grid.
Originally committed by Shixuan.
2023-03-03 16:39:28 -06009aeea149d5970cb99218344f8bde576e1f036d21Implementing changes to the initial conditions.editinput/case_setups/rico_silhs_model.ineditinput/case_setups/dycoms2_rf02_ds_model.ineditinput/case_setups/dycoms2_rf02_do_model.ineditinput/case_setups/dycoms2_rf02_so_model.ineditinput/case_setups/bomex_sounding.ineditsrc/clubb_driver.F90editinput/case_setups/rico_model.ineditinput/case_setups/wangara_sounding.ineditinput/case_setups/dycoms2_rf02_morr_model.ineditinput/case_setups/wangara_model.ineditinput/case_setups/dycoms2_rf02_nd_model.ineditinput/case_setups/rico_sounding.ineditinput/case_setups/bomex_model.ineditinput/case_setups/dycoms2_rf02_sounding.ineditsrc/sounding.F90
- READMEa6682998e27e3d01b8ffeb4ec2774872e7311aa41677905458000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThis commit most definitely does not change any bits,
but commit 67878ef was BIT_CHANGING for the DYCOMS-II RF02 family
of cases, RICO (and RICO SILHS), BOMEX, and Wangara.
2023-03-03 22:50:58 -0600a6682998e27e3d01b8ffeb4ec2774872e7311aa4This commit most definitely does not change any bits,editREADME
- run_scripts/convergence_function.pyrun_scripts/run_cnvg_test_multi_cases.cshrun_scripts/plot_l2_convergence.pyrun_scripts/convergence_config.py0e087bee28254a2bc2da5869a28352e1374b2b911678120205000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAdd scripts to configure and run convergence test
This commit contains new scripts created to configure and run
convergence test simulations. There are four scripts:
1. run_scripts/run_cnvg_test_multi_cases.csh. This script is used to
compile and run convergence simulations with specific configurations
(see details in scripts for explations). After the simulations,the
space-time convergence plots will also be generated.
2.run_scripts/convergence_config.py: this script "called" by the
first script to generate the namelist file for CLUBB-SCM simulations.
With this script, the modified configuration will be applied in the
case run directory, while the files in default clubb will not be
touched
3.run_scripts/convergence_function.py: this script contains function
to modify the initial condition profile for convergence test
simulations. It is called by run_scripts/convergence_config.py
when the model is configured to use modified initial conditions
4.run_scripts/plot_l2_convergence.py: this is a sample script to
generate the space-time convergence plots
Originally committed by Shixuan
2023-03-06 10:30:05 -06000e087bee28254a2bc2da5869a28352e1374b2b91Add scripts to configure and run convergence testaddrun_scripts/run_cnvg_test_multi_cases.cshaddrun_scripts/convergence_config.pyaddrun_scripts/plot_l2_convergence.pyaddrun_scripts/convergence_function.py
- run_scripts/convergence_run/convergence_function.pyrun_scripts/convergence_run/run_cnvg_test_multi_cases.cshrun_scripts/plot_l2_convergence.pyrun_scripts/convergence_run/convergence_config.pyrun_scripts/convergence_config.pyrun_scripts/convergence_function.pyrun_scripts/run_cnvg_test_multi_cases.cshrun_scripts/convergence_run/plot_l2_convergence.py53c717bb7dd9bddcd720cba58c46d77b7ad36c9c1678120475000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.edureorgnize the scripts for convergence test simulations
Move the script associated with convergence test simulation
in the folder of run_scripts/convergence_run
Originally committed by Shixuan
2023-03-06 10:34:35 -060053c717bb7dd9bddcd720cba58c46d77b7ad36c9creorgnize the scripts for convergence test simulationsaddrun_scripts/convergence_run/convergence_function.pydeleterun_scripts/convergence_config.pydeleterun_scripts/convergence_function.pydeleterun_scripts/plot_l2_convergence.pyaddrun_scripts/convergence_run/run_cnvg_test_multi_cases.cshdeleterun_scripts/run_cnvg_test_multi_cases.cshaddrun_scripts/convergence_run/convergence_config.pyaddrun_scripts/convergence_run/plot_l2_convergence.py
- READMEdb8d5931d779bc1f776fb80952a1c263c22f84671678293578000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate README
I guess the proper way to do it is this -- BIT_CHANGING:9aeea14
2023-03-08 10:39:38 -0600db8d5931d779bc1f776fb80952a1c263c22f8467Update READMEeditREADME
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/turbulent_adv_pdf.F90src/CLUBB_core/grid_class.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/saturation.F90src/CLUBB_core/mean_adv.F90src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90src/CLUBB_core/pdf_utilities.F90src/CLUBB_core/mixing_length.F90a3bcb0bd343d004b2f085006708b88131be995071678297579000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comGpu updates (#1070)
* Fixing bug. This was only triggered when l_input_fields=.true., which I am only testing because it needs to be true so that I can test ADG2_driver.
* Removing usage of gr from pdf_closure. It was only ever used for nz, which is now fed in directly.
* Making openacc statements more consistent. Ensuring all statments on double loops have specified gang and vector, and that all parallel loops have an end parallel loop statment at the end of them. Everything BFB on CPUs and GPUs.
* Pushing acc data region to outermost parts of mixing_length.
* Removing pdf_implicit_coefs_terms from acc copyin and copyout. It is only used when iiPDF_type == iiPDF_new .or. iiPDF_type == iiPDF_new_hybrid, so we do not need to do any copying with it. The inclusion of it also caused the data statement to copy unallocated arrays, which are just garbage pointers, and that was causing random occasional crashes (either segfaults or gpu out of memory).
* The update device clauses for return variables seems to only be requried for arrays contained in types. See https://github.com/larson-group/clubb/issues/1049\#issuecomment-1440624778
* Moving acc end data to end of pdf_closure. This reuqired removing any conditional return statements that appear before the final return, since we're not allowed to branch out of an acc region early. I also moved a large printout statement outside of a loop. The only reason it was in the loop to begin with was because pdf_params used to be an array of types, but now is a type of arrays, allowing us to print the full arrays directly.
* Making loop an acc loop. If we weren't outputting w_[up/down]_in_cloud (iw_up_in_cloud <= 0 .or. iw_down_in_cloud <= 0, then these arrays were only being zerod out on the CPU and would've getting overwritten by the uninitialized GPU data at the end of the data statement. This change causes the arrays to get correctly zerod out on the GPU when we need.
* Update VariableGroupNondimMoments.py
Fixed a typo
* Merging new changes from master
* Removing need for -gpu=deepcopy, pushing some acc data statements up call tree, and replacing some acc data statements with acc delare statements so that return statements can be added back in.
* Adding back an acc loop that was accidentally removed during a merge.
---------
Co-authored-by: Brian Griffin <31553422+bmg929@users.noreply.github.com>
2023-03-08 11:46:19 -0600a3bcb0bd343d004b2f085006708b88131be99507Gpu updates (#1070)editsrc/CLUBB_core/grid_class.F90editsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90editsrc/CLUBB_core/pdf_utilities.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/turbulent_adv_pdf.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/saturation.F90editsrc/CLUBB_core/mean_adv.F90
- input/case_setups/dycoms2_rf02_morr_model.ininput/case_setups/bomex_model.insrc/clubb_driver.F90input/case_setups/dycoms2_rf02_nd_model.ininput/case_setups/dycoms2_rf02_ds_model.ininput/case_setups/rico_silhs_model.ininput/case_setups/dycoms2_rf02_so_model.ininput/case_setups/rico_model.ininput/case_setups/wangara_model.ininput/case_setups/dycoms2_rf02_do_model.in8e473e08b858df61c5c5116e37e26f3df2431a0b1678316303000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduCode changes to implement modified boundary condition
This commit contains code changes to implement modified boundary
conditions for convergence test simulations. These code changes
can be activated by setting l_modify_bc_for_cnvg_test = .true.
in the CLUBB namelist.
Originally committed by Shixuan.
2023-03-08 16:58:23 -06008e473e08b858df61c5c5116e37e26f3df2431a0bCode changes to implement modified boundary conditioneditinput/case_setups/bomex_model.ineditinput/case_setups/rico_model.ineditsrc/clubb_driver.F90editinput/case_setups/dycoms2_rf02_ds_model.ineditinput/case_setups/dycoms2_rf02_do_model.ineditinput/case_setups/dycoms2_rf02_so_model.ineditinput/case_setups/rico_silhs_model.ineditinput/case_setups/dycoms2_rf02_morr_model.ineditinput/case_setups/dycoms2_rf02_nd_model.ineditinput/case_setups/wangara_model.in
- src/CLUBB_core/mono_flux_limiter.F90c5c29600aa8cf9176127e44fbf6ddccf9474722a1678350700000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comImplements Thomas Toniazzo's bug fix for spike removal
in the monotonic flux limiter. See
https://github.com/larson-group/clubb_release/pull/11/files
This code change is
expected to be BIT_CHANGING for cases in which
`l_predict_upwp_vpwp = T`, `l_mono_flux_lim_um = T`
or `l_mono_flux_lim_vm = T`, and the monotonic
flux limiter is triggered.
This bug fix prevents non-conservation of momentum
when the vertical integral of either of the wind components `um` or `vm` is negative.
2023-03-09 02:31:40 -0600c5c29600aa8cf9176127e44fbf6ddccf9474722aImplements Thomas Toniazzo's bug fix for spike removaleditsrc/CLUBB_core/mono_flux_limiter.F90
- README9512061ddd7b2a7d1009a787409055495fbd39c51678370125000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comFixed an old notation change in the README
2023-03-09 07:55:25 -06009512061ddd7b2a7d1009a787409055495fbd39c5Fixed an old notation change in the READMEeditREADME
- README5cb6f1b9b80536e8a57e8d5f64a73136c824b0a01678370507000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate README
Did this not work because I didn't include all 40 characters of the git hash?
BIT_CHANGING:9aeea149d5970cb99218344f8bde576e1f036d21
2023-03-09 08:01:47 -06005cb6f1b9b80536e8a57e8d5f64a73136c824b0a0Update READMEeditREADME
- input_misc/tuner/error_atex.ininput_misc/tuner/error_rico.ininput_misc/tuner/error_gabls3_night.insrc/CLUBB_core/sfc_varnce_module.F90input_misc/tuner/error_nov11_altocu.ininput_misc/tuner/error_four_cases.ininput_misc/tuner/error_dycoms2_rf01.ininput_misc/tuner/error_dycoms2_rf02_ds.insrc/clubb_standalone.F90input_misc/tuner/error_wangara.ininput/tunable_parameters_compatible_r8029/tunable_parameters.insrc/G_unit_test_types/pdf_parameter_tests.F90input/tunable_parameters/tunable_parameters.ininput_misc/tuner/error_dycoms2_rf02_do.insrc/CLUBB_core/parameter_indices.F90input_misc/tuner/error_dycoms2_rf02_nd.ininput/tunable_parameters_e3sm/tunable_parameters.insrc/CLUBB_core/parameters_tunable.F90input_misc/tuner/error_arm.insrc/G_unit_test_types/spurious_source_test.F90input_misc/tuner/error_bomex.ininput_misc/tuner/error_bomex_fire.insrc/clubb_thread_test.F90src/CLUBB_core/advance_clubb_core_module.F90input/tunable_parameters_Lscale/tunable_parameters.insrc/jacobian.F90input_misc/tuner/error_arm_97.ininput_misc/tuner/error_all.ininput_misc/tuner/error_lba.insrc/CLUBB_core/clubb_api_module.F90input_misc/tuner/error_fire.insrc/error.F90input_misc/tuner/error_gabls2.ininput_misc/tuner/error_ticket_756.in903169aafe5cfd2f7cae35adef3d31e6f51641fe1678723565000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comMaking 'a_const' into a CLUBB tunable parameter. (#1072)
* Converting the sfc_varnce_module.F90 parameter 'a_const' into a CLUBB tunable parameter.
Results should be bit-for-bit since it will be set to 1.8 and with l_vary_convect_depth=F
this is the standard value.
Some discussion in ticket #994.
* Completing requested changes, see PR #1072.
2023-03-13 10:06:05 -0600903169aafe5cfd2f7cae35adef3d31e6f51641feMaking 'a_const' into a CLUBB tunable parameter. (#1072)editinput_misc/tuner/error_gabls3_night.ineditinput_misc/tuner/error_wangara.ineditinput_misc/tuner/error_ticket_756.ineditsrc/G_unit_test_types/pdf_parameter_tests.F90editinput_misc/tuner/error_dycoms2_rf01.ineditinput_misc/tuner/error_bomex.ineditsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/parameters_tunable.F90editsrc/clubb_thread_test.F90editinput_misc/tuner/error_lba.ineditinput_misc/tuner/error_fire.ineditinput/tunable_parameters_Lscale/tunable_parameters.ineditinput_misc/tuner/error_dycoms2_rf02_ds.ineditinput_misc/tuner/error_arm.ineditsrc/jacobian.F90editinput_misc/tuner/error_bomex_fire.ineditinput_misc/tuner/error_four_cases.ineditinput_misc/tuner/error_dycoms2_rf02_nd.ineditinput/tunable_parameters_e3sm/tunable_parameters.ineditinput_misc/tuner/error_arm_97.ineditinput_misc/tuner/error_rico.ineditinput/tunable_parameters_compatible_r8029/tunable_parameters.ineditsrc/error.F90editinput_misc/tuner/error_dycoms2_rf02_do.ineditsrc/clubb_standalone.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editinput_misc/tuner/error_all.ineditinput_misc/tuner/error_gabls2.ineditsrc/CLUBB_core/parameter_indices.F90editsrc/CLUBB_core/clubb_api_module.F90editinput/tunable_parameters/tunable_parameters.ineditinput_misc/tuner/error_atex.ineditinput_misc/tuner/error_nov11_altocu.ineditsrc/CLUBB_core/sfc_varnce_module.F90
- README14c03cc05cfddd0fc31d3845fc13111b3ac08d3a1678743308000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate README
I should've added the answer-changing tag to my previous commit:
BIT_CHANGING:903169a.
That commit doesn't really change answers, but adds a new tunable parameter which will show up in the output files and therefore they will differ from previous output files.
2023-03-13 15:35:08 -060014c03cc05cfddd0fc31d3845fc13111b3ac08d3aUpdate READMEeditREADME
- README2c597f4960cdb75b2bee46e56a511bd56fd722e21678743421000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate README
Oops didn't include all git hash characters:
BIT_CHANGING:903169aafe5cfd2f7cae35adef3d31e6f51641fe
2023-03-13 15:37:01 -06002c597f4960cdb75b2bee46e56a511bd56fd722e2Update READMEeditREADME
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/sigma_sqd_w_module.F90src/CLUBB_core/T_in_K_module.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/Skx_module.F905cbf4f80a34cfafd2fd164415af5ec7d6239bcdd1678812234000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comPdf closure driver gpuization (#1071)
* GPUizing pdf_closure_driver, testing still needed, bug likely.
* Making data movement better. Also fixed some random things. Still need to return returns.
* Adding back a couple return statments. Moving a comment where it should be. GPUizing a missed loop.
* Making arguements list satisfy standards.
* Making arguements list satisfy standards. Also adding max(1,hydrometdim) to hydromet inputs.
* Capitalizing K
* Making the error case in compute_cloud_cover behavior a bit differently. This allows the error to be detected immediately by GPU runs as well.
* Calling compute_cloud_cover only needs to be done if l_use_cloud_cover = .true.
2023-03-14 11:43:54 -05005cbf4f80a34cfafd2fd164415af5ec7d6239bcddPdf closure driver gpuization (#1071)editsrc/CLUBB_core/Skx_module.F90editsrc/CLUBB_core/sigma_sqd_w_module.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/T_in_K_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90
- READMEb6496cec72690bbaa9195b116d015553389537971678891637000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate README
RESOLVED:8e473e08b858df61c5c5116e37e26f3df2431a0b
Above committed on March 8th, 2023
BIT_CHANGING:5cbf4f80a34cfafd2fd164415af5ec7d6239bcdd
Above was committed on March 14th, 2023
2023-03-15 09:47:17 -0500b6496cec72690bbaa9195b116d01555338953797Update READMEeditREADME
- src/CLUBB_core/advance_clubb_core_module.F90fb4556e4cc4cb3d4b6df3520370a28a824f357ef1679006580000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMoving compute_cloud_cover outside of if ( l_use_cloud_cover ) then statement, the cloud_cover and rcm_in_layer variables they compute aren't output in clubb_standalone, but are in cam, causing cam bit diff tests to break.
2023-03-16 17:43:00 -0500fb4556e4cc4cb3d4b6df3520370a28a824f357efMoving compute_cloud_cover outside of if ( l_use_cloud_cover ) then statement, the cloud_cover and rcm_in_layer variables they compute aren't output in clubb_standalone, but are in cam, causing cam bit diff tests to break.editsrc/CLUBB_core/advance_clubb_core_module.F90
- README0cf0157ebf0dfe165d07da57520f34cbf1173bb81679163846000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduUndoing README update, 1 space = 1 byte and we should maximize file sizes to deter hackers from stealing our data. Also BIT_CHANGING:fb4556e4cc4cb3d4b6df3520370a28a824f357ef for configs where l_use_cloud_cover = .false., which means I was wrong about this ever not being bit changing, so I must've either only tested with l_use_cloud_cover = .true. or only tested the multicol diffs when I put compute_cloud_cover inside the if statement.
2023-03-18 13:24:06 -05000cf0157ebf0dfe165d07da57520f34cbf1173bb8Undoing README update, 1 space = 1 byte and we should maximize file sizes to deter hackers from stealing our data. Also BIT_CHANGING:fb4556e4cc4cb3d4b6df3520370a28a824f357ef for configs where l_use_cloud_cover = .false., which means I was wrong about this ever not being bit changing, so I must've either only tested with l_use_cloud_cover = .true. or only tested the multicol diffs when I put compute_cloud_cover inside the if statement.editREADME
- src/CLUBB_core/advance_clubb_core_module.F90dffad1daafea675ddb568df7159dc83c952baab71679530369000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding Skthl_zm to the update host list, I missed this in the last PR. I noticed this by comparing results with and without managed memory, now I've checked BFBness with arm, mpace_b, mc3e, and gabls2.
2023-03-22 19:12:49 -0500dffad1daafea675ddb568df7159dc83c952baab7Adding Skthl_zm to the update host list, I missed this in the last PR. I noticed this by comparing results with and without managed memory, now I've checked BFBness with arm, mpace_b, mc3e, and gabls2.editsrc/CLUBB_core/advance_clubb_core_module.F90
- src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/grid_class.F90src/CLUBB_core/saturation.F90src/CLUBB_core/mean_adv.F90src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90src/CLUBB_core/pdf_utilities.F90src/CLUBB_core/parameters_model.F90src/CLUBB_core/Skx_module.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/turbulent_adv_pdf.F90src/CLUBB_core/sigma_sqd_w_module.F90src/CLUBB_core/T_in_K_module.F90d6db663fb3c7cd893d3d68786c486254e8a28ebb1679711434000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comSmall GPU fixes (#1076)
* Fixing small things that I caught by adding the default(present) onto acc loops.
* Moving default(present) to the end because it looks nicer there.
2023-03-24 21:30:34 -0500d6db663fb3c7cd893d3d68786c486254e8a28ebbSmall GPU fixes (#1076)editsrc/CLUBB_core/Skx_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/saturation.F90editsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90editsrc/CLUBB_core/sigma_sqd_w_module.F90editsrc/CLUBB_core/mean_adv.F90editsrc/CLUBB_core/T_in_K_module.F90editsrc/CLUBB_core/parameters_model.F90editsrc/CLUBB_core/turbulent_adv_pdf.F90editsrc/CLUBB_core/pdf_utilities.F90editsrc/CLUBB_core/grid_class.F90
- README5cd77e018ec1ca2d920bd34b5500529068b957491680086342000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdds blank line to trigger nightly tests
2023-03-29 05:39:02 -05005cd77e018ec1ca2d920bd34b5500529068b95749Adds blank line to trigger nightly testseditREADME
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/clubb_driver.F90src/CLUBB_core/model_flags.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/clubb_api_module.F90src/G_unit_test_types/pdf_parameter_tests.F90src/CLUBB_core/clip_explicit.F90input/tunable_parameters/configurable_model_flags.insrc/clubb_tuner.F90475d569931a16ce1187c26757a0913e53c62abe51680247062000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduCode changes to implement modificiations on wp3 clippings
This commit contains code changes to implement modifications of skewness
clippings on wp3 in src/CLUBB_core/clip_explicit.F90. The default method attempts
to apply smaller (larger) clippings below (above) 100m AGL level, which
can cause a discontinuities around 100m AGL level. This clippings is
found to trigger sawthooth oscillations in wp3 when linear diffusion is
used. Such swathooth oscillations are eleminated if a smoothed Heaviside
function is introduced to obtain a smooth transition of clippings at
around 100m AGL level. The changes is necessary to obtain the first
order convergence in CLUBB-SCM when lienar diffusion is used.
Previously committed by Shixuan.
2023-03-31 02:17:42 -0500475d569931a16ce1187c26757a0913e53c62abe5Code changes to implement modificiations on wp3 clippingseditsrc/CLUBB_core/clubb_api_module.F90editsrc/clubb_driver.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90editinput/tunable_parameters/configurable_model_flags.ineditsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/model_flags.F90editsrc/clubb_tuner.F90editsrc/CLUBB_core/clip_explicit.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/G_unit_test_types/spurious_source_test.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/clubb_driver.F90src/CLUBB_core/model_flags.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/clubb_api_module.F90src/G_unit_test_types/pdf_parameter_tests.F90input/tunable_parameters/configurable_model_flags.insrc/CLUBB_core/advance_helper_module.F90src/CLUBB_core/mixing_length.F90src/clubb_tuner.F904b16d833e86ad23ef6ea81de67c38c596ebccd251680538287000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThis commit contains code changes to implement modifications on limiters in three places:
1. remove the limiters in denominator of equation for
brunt_vaisala_freq_sqd_smth, which affects the computed
eddy dissipation time scale in turbulent fluxes (wpxp).
(in mixing_length.F90)
2. reduce the threshold values of limiters in the equation
for richardson number (sqrt_Ri_zm)
(in mixing_length.F90)
3. introduce the smoothed max/min function for limiters in
equation of Cx_fnc_Richardson.
(in advance_helper_module.F90).
After the modification, we also apply a zt2m(zm2zt) smoothing
on the calculated quantities. These modifications are found to
be benificial for improving solution convergence in CLUBB-SCM
The code changes are controlled by a newly introduced flag named
"l_modify_limiters_for_cnvg_test", which is set to .false. (meaning that
the modificaitons on limiters is turned off) by default.
Originally committed by Shixuan.
2023-04-03 11:11:27 -05004b16d833e86ad23ef6ea81de67c38c596ebccd25This commit contains code changes to implement modifications on limiters in three places:editsrc/clubb_driver.F90editinput/tunable_parameters/configurable_model_flags.ineditsrc/clubb_tuner.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/model_flags.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/mixing_length.F90
- input/tunable_parameters/tunable_parameters.in56b351a7c3870976816a85ac7cc292d57f3daa811680705925000http://carson.math.uwm.edu/jenkins/user/cerniktcernikttjcernik@uwm.educhanging tunable_parameters
2023-04-05 09:45:25 -050056b351a7c3870976816a85ac7cc292d57f3daa81changing tunable_parameterseditinput/tunable_parameters/tunable_parameters.in
- input/tunable_parameters/tunable_parameters.inec5eb04a57d416323f4f67bcacb242246816d5fd1680706442000http://carson.math.uwm.edu/jenkins/user/cerniktcernikttjcernik@uwm.educhanging tunable_parameters
2023-04-05 09:54:02 -0500ec5eb04a57d416323f4f67bcacb242246816d5fdchanging tunable_parameterseditinput/tunable_parameters/tunable_parameters.in
- input/tunable_parameters/tunable_parameters.in3d6022f3fa683a1dcd6d42a6e281b6e25ac9d7f41680706472000http://carson.math.uwm.edu/jenkins/user/cerniktcernikttjcernik@uwm.educhanging tunable_parameters
2023-04-05 09:54:32 -05003d6022f3fa683a1dcd6d42a6e281b6e25ac9d7f4changing tunable_parameterseditinput/tunable_parameters/tunable_parameters.in
- src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/turbulent_adv_pdf.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/matrix_solver_wrapper.F90src/CLUBB_core/grid_class.F90src/CLUBB_core/mean_adv.F90src/CLUBB_core/mono_flux_limiter.F90src/CLUBB_core/fill_holes.F90src/CLUBB_core/clip_explicit.F90src/CLUBB_core/advance_helper_module.F90src/CLUBB_core/parameters_model.F90src/CLUBB_core/diffusion.F9049ec5990089b7f9728eb6707a2b653bbeca94c811680716686000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdvance xm wpxp gpuization (#1077)
* Initial commit for GPUizing advance_xm_wpxp.
* GPUizing fill_holes_vertical
* Adding Skthl_zm to the update host list, I missed this in the last PR. I noticed this by comparing results with and without managed memory, now I've checked BFBness with arm, mpace_b, mc3e, and gabls2.
* Small GPU fixes (#1076)
* Fixing small things that I caught by adding the default(present) onto acc loops.
* Moving default(present) to the end because it looks nicer there.
* Adding default(present) to all acc loop statements. Also adding azt to a copyin statement, which was missed previously. All BFB.
* Incemental update, not well tested yet.
* Removing some copies and making the sclr_dim change.
* Fixing a bug that only seemed detectable with astex_a209. We need to pass only single arrays to functions, calling ddzt( nz, ngrdcol, gr, rho_ds_zt * K_zt_nu ) was resulting in rho_ds_zt * K_zt_nu being evluated on the CPU, but the values were only valid on the GPU. So we need to evaluate that expression on the GPU, save it into an array (currently K_zt_nu_tmp), then pass that to ddzt.
* GPUizing calc_turb_adv_range
* GPUizing mono_flux_limiter
* Cleaning up data statments and a couple other things.
* Updated for some different options.
* More updates needed for various options.
* Reverting accidental flag change
* Should be the final changes, all options tested now.
* Replacing some comments in monoflux limiter, and also modifying it to make it BFB on CPUs. Also changing incorrect error conditions on tridiag.
* Adding max_x_allowable to update host statement, missed previous.
* Properly naming tmp variables and variables calculated from ddzt and ddzm start with ddzt_ and ddzm_.
* Replacing constants with named ones from constants_clubb.
* Replacing hard coded numbers in lhs variables representing the number of bands they contain with fortran parameters.
2023-04-05 12:44:46 -050049ec5990089b7f9728eb6707a2b653bbeca94c81Advance xm wpxp gpuization (#1077)editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/grid_class.F90editsrc/CLUBB_core/matrix_solver_wrapper.F90editsrc/CLUBB_core/clip_explicit.F90editsrc/CLUBB_core/mono_flux_limiter.F90editsrc/CLUBB_core/diffusion.F90editsrc/CLUBB_core/fill_holes.F90editsrc/CLUBB_core/mean_adv.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/parameters_model.F90editsrc/CLUBB_core/turbulent_adv_pdf.F90editsrc/CLUBB_core/advance_clubb_core_module.F90
- compile/config/linux_x86_64_nvhpc_gpu.bashrun_scripts/diff_netcdf_outputs.pyf20b355f2ce4e686d8f3392ad148341f08fd6acc1680726531000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSmall improvements to diff_netcdf_outputs.py, removing reliance on ncdiff, now it is entirely in python. Cleaning up linux_x86_64_nvhpc_gpu.bash, removing outdated parts, improving default parallel compilation, changing pgfortran to nvfortran.
2023-04-05 15:28:51 -0500f20b355f2ce4e686d8f3392ad148341f08fd6accSmall improvements to diff_netcdf_outputs.py, removing reliance on ncdiff, now it is entirely in python. Cleaning up linux_x86_64_nvhpc_gpu.bash, removing outdated parts, improving default parallel compilation, changing pgfortran to nvfortran.editcompile/config/linux_x86_64_nvhpc_gpu.basheditrun_scripts/diff_netcdf_outputs.py
- src/CLUBB_core/advance_xm_wpxp_module.F90c0fb204097dab9c58399ebd3526835db482899cc1680733435000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSmall tweaks to fix some GPU bugs. Some variables were uninitialized on the CPU while we were saving them. This could only have been caught by comparing consecutive runs and checking _zt and _zm files, even then few cases were having problems.
2023-04-05 17:23:55 -0500c0fb204097dab9c58399ebd3526835db482899ccSmall tweaks to fix some GPU bugs. Some variables were uninitialized on the CPU while we were saving them. This could only have been caught by comparing consecutive runs and checking _zt and _zm files, even then few cases were having problems.editsrc/CLUBB_core/advance_xm_wpxp_module.F90
- src/CLUBB_core/grid_class.F9034329990202f44999b237263136111b0086963c41680734063000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing a labelling error in redirect_interpolated_azt_2D and similar procedures, since this interpolates to zt the input should be zm. I think this was my fault, so I cleaned all the zt2zm and zm2zt things up to make it a little nicer. Also ordered the routines _k _1D _2D to make it easier to jump around, it was a bit confusing as they were out of order and the typo really made it hard.
2023-04-05 17:34:23 -050034329990202f44999b237263136111b0086963c4Fixing a labelling error in redirect_interpolated_azt_2D and similar procedures, since this interpolates to zt the input should be zm. I think this was my fault, so I cleaned all the zt2zm and zm2zt things up to make it a little nicer. Also ordered the routines _k _1D _2D to make it easier to jump around, it was a bit confusing as they were out of order and the typo really made it hard.editsrc/CLUBB_core/grid_class.F90
- utilities/autocommit_message_maker/autocommit_message_maker.py6d1ddfc80e3c21483a2a90d03c0f5581c0dd7dff1680816187000http://carson.math.uwm.edu/jenkins/user/cerniktcernikttjcernik@uwm.edubug fixes for the autocommit message maker code
2023-04-06 16:23:07 -05006d1ddfc80e3c21483a2a90d03c0f5581c0dd7dffbug fixes for the autocommit message maker codeeditutilities/autocommit_message_maker/autocommit_message_maker.py
- src/CLUBB_core/parameters_model.F900eca2146266b52e407a4feac444e1be8923fa3c41680842443000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking it so sclr_tol is set to 0 before the specified sclr_tol_in. This is so that it is initialized to 0 in the case that sclr_dim = 0, since now we are setting it to have a minimum allocation size of 1 and would otherwise have a garbage value. This is what broke the clubb_openmp_gfortran_test.
2023-04-06 23:40:43 -05000eca2146266b52e407a4feac444e1be8923fa3c4Making it so sclr_tol is set to 0 before the specified sclr_tol_in. This is so that it is initialized to 0 in the case that sclr_dim = 0, since now we are setting it to have a minimum allocation size of 1 and would otherwise have a garbage value. This is what broke the clubb_openmp_gfortran_test.editsrc/CLUBB_core/parameters_model.F90
- run_scripts/convergence_run/run_cnvg_test_multi_cases_baseline.cshrun_scripts/convergence_run/run_cnvg_test_multi_cases.cshrun_scripts/convergence_run/run_cnvg_test_multi_cases_revall.cshrun_scripts/convergence_run/convergence_config.pyrun_scripts/convergence_run/run_cnvg_test_multi_cases_default.csh4f762ff2971a094b45b591719bc9e28d3de9d06b1681746202000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduupdate the scripts for convergence test
Originally committed by Shixuan.
2023-04-17 10:43:22 -05004f762ff2971a094b45b591719bc9e28d3de9d06bupdate the scripts for convergence testaddrun_scripts/convergence_run/run_cnvg_test_multi_cases_baseline.cshaddrun_scripts/convergence_run/run_cnvg_test_multi_cases_revall.cshdeleterun_scripts/convergence_run/run_cnvg_test_multi_cases.csheditrun_scripts/convergence_run/convergence_config.pyaddrun_scripts/convergence_run/run_cnvg_test_multi_cases_default.csh
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/clip_explicit.F90src/CLUBB_core/advance_helper_module.F90src/CLUBB_core/grid_class.F90src/G_unit_test_types/smooth_heaviside_tests.F90src/CLUBB_core/mixing_length.F90a883cf53b5eff3476a2c5e65dcd5a4093417ff181681924858000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comLscale GPUization (#1079)
* Making 2 new functions zm2zt2zm and zt2zm2zt to handle smoothing by interpolation. Replaced the spots in clubb I know that uses this to smooth things. This is just a nice to have and could allow for easy optimizations in the future by inlining the interpolations. All cases BFB on CPU and GPU, checked all relevant options too.
* GPUizing diagnose_Lscale_from_tau
* Removing some unused variables.
* Moving acc data statements from calc_Lscale_directly up to advance_clubb_core.
* Removing an unused variable.
* GPUizing the l_smooth_min_max option.
* GPUizing l_avg_Lscale
* Changes to variable names to avoid gross long names only used once.
2023-04-19 12:20:58 -0500a883cf53b5eff3476a2c5e65dcd5a4093417ff18Lscale GPUization (#1079)editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/grid_class.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/clip_explicit.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/G_unit_test_types/smooth_heaviside_tests.F90
- src/CLUBB_core/grid_class.F90e7911cd16198153e0a3ca084bd813c0dfad1b4eb1681926818000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.edugfortran does not like intent(out) specifiers for functions.
2023-04-19 12:53:38 -0500e7911cd16198153e0a3ca084bd813c0dfad1b4ebgfortran does not like intent(out) specifiers for functions.editsrc/CLUBB_core/grid_class.F90
- compile/config/linux_x86_64_ifort_anvil.bash7eb659d596d4c75f2da95a56428657ed23fb41e51682011176000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAdded a new file to compile CLUBB on Anvil.
2023-04-20 12:19:36 -05007eb659d596d4c75f2da95a56428657ed23fb41e5Added a new file to compile CLUBB on Anvil.addcompile/config/linux_x86_64_ifort_anvil.bash
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/calc_pressure.F90src/CLUBB_core/sigma_sqd_w_module.F90src/CLUBB_core/interpolation.F90src/CLUBB_core/advance_helper_module.F90src/CLUBB_core/Skx_module.F904205f9567c8864f9caa6d8d20286543b490db4281682105140000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comGPUizing Various Small Routines (#1080)
* GPUizing compute_Cx_fnc_Richardson
* GPUizing term_wp2_splat and term_wp3_splat
* GPUizing xp3_LG_2005_ansatz
* GPUizing calculate_thvm
* GPUizing pvertinterp even though I don't think we care about the l_do_expldiff_rtm_thlm flag
* Fixing bug. Setting l_do_expldiff_rtm_thlm causes us to use edsclrm, so we need to also ensure that edsclrm > 1 (1 because it uses a edsclr_dim-1 index)
* Pushing some data statements up the call tree.
2023-04-21 14:25:40 -05004205f9567c8864f9caa6d8d20286543b490db428GPUizing Various Small Routines (#1080)editsrc/CLUBB_core/Skx_module.F90editsrc/CLUBB_core/sigma_sqd_w_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/interpolation.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/calc_pressure.F90
- src/CLUBB_core/grid_class.F90src/SILHS/math_utilities.F90e66210ad86254314f1855beee0fa43f947ce47541682273667000http://carson.math.uwm.edu/jenkins/user/cerniktcernikttjcernik@uwm.eduThis commit is a commit that changes absolutely nothing. It is meant to trigger a change in the git update scripts, so that I can start the commit message logging in the autocommit updates larson-group/sys_admin#797
2023-04-23 13:14:27 -0500e66210ad86254314f1855beee0fa43f947ce4754This commit is a commit that changes absolutely nothing. It is meant to trigger a change in the git update scripts, so that I can start the commit message logging in the autocommit updates larson-group/sys_admin#797editsrc/SILHS/math_utilities.F90editsrc/CLUBB_core/grid_class.F90
- utilities/autocommit_message_maker/autocommit_message_maker.py5af7321c1c5daa335bb93a2c3cd50076fbdce4181682277462000http://carson.math.uwm.edu/jenkins/user/cerniktcernikttjcernik@uwm.eduFixing an error with the autocommit_update script that was causing it new works
2023-04-23 14:17:42 -05005af7321c1c5daa335bb93a2c3cd50076fbdce418Fixing an error with the autocommit_update script that was causing it new workseditutilities/autocommit_message_maker/autocommit_message_maker.py
- src/CLUBB_core/interpolation.F90b89e73662a3a008cfd8a9790afb7fbeb777dc8711682278310000http://carson.math.uwm.edu/jenkins/user/cerniktcernikttjcernik@uwm.eduthis is another commit that cahnges nothing that will trigger the gitUpdate scripts
2023-04-23 14:31:50 -0500b89e73662a3a008cfd8a9790afb7fbeb777dc871this is another commit that cahnges nothing that will trigger the gitUpdate scriptseditsrc/CLUBB_core/interpolation.F90
- compile/config/linux_x86_64_ifort_anvil.bashrun_scripts/convergence_run/run_cnvg_test_multi_cases_baseline.cshrun_scripts/convergence_run/run_cnvg_test_multi_cases_revall.cshrun_scripts/convergence_run/run_cnvg_test_multi_cases_default.csh898a66bd5d85618c9ec386798ea64722285b69251682878214000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdates to make the convergence tests run on Anvil.
2023-04-30 13:10:14 -0500898a66bd5d85618c9ec386798ea64722285b6925Updates to make the convergence tests run on Anvil.editrun_scripts/convergence_run/run_cnvg_test_multi_cases_revall.csheditrun_scripts/convergence_run/run_cnvg_test_multi_cases_baseline.csheditcompile/config/linux_x86_64_ifort_anvil.basheditrun_scripts/convergence_run/run_cnvg_test_multi_cases_default.csh
- src/CLUBB_core/clip_explicit.F906242bef56ec8f83eb6296133f8a7e6b6379976291682909659000http://carson.math.uwm.edu/jenkins/user/cerniktcernikttjcernik@uwm.eduadding an update that changes nothing and is just a test for the autoupdate script
2023-04-30 21:54:19 -05006242bef56ec8f83eb6296133f8a7e6b637997629adding an update that changes nothing and is just a test for the autoupdate scripteditsrc/CLUBB_core/clip_explicit.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90input/stats/standard_stats.ininput/stats/all_stats.insrc/CLUBB_core/advance_helper_module.F90src/CLUBB_core/sfc_varnce_module.F90postprocessing/pyplotgen/config/VariableGroupBase.pysrc/CLUBB_core/stats_variables.F90src/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/stats_zm_module.F90f0d1d1cb3d182f220a2bc78e2ea389ca8a9a3c711682952212000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comMaking CLUBB's splatting scheme implicit and smoother (#1075)
* Introducing rough implicit splatting scheme into CLUBB. Not yet implicit for wp3.
* Implementing implicit splatting for wp3.
* Further improvements to implicit splatting code, including
- smoothing of the BV freq used for splatting
- adding a new variable 'bv_freq_sqd_splat' to stats
- add the new variable to pyplotgen standard output
See PR #1075 and issue #994.
* Some cleanup.
* More cleanup, and adding comments.
* More comments.
* Updating implicit splatting scheme.
* Updates to resolve PR requests.
Updates associated with implicit splatting will be BIT_CHANGING.
2023-05-01 08:43:32 -0600f0d1d1cb3d182f220a2bc78e2ea389ca8a9a3c71Making CLUBB's splatting scheme implicit and smoother (#1075)editsrc/CLUBB_core/stats_variables.F90editsrc/CLUBB_core/sfc_varnce_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editinput/stats/all_stats.ineditpostprocessing/pyplotgen/config/VariableGroupBase.pyeditsrc/CLUBB_core/stats_zm_module.F90editinput/stats/standard_stats.ineditsrc/CLUBB_core/advance_clubb_core_module.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_helper_module.F90src/clubb_driver.F90src/CLUBB_core/sfc_varnce_module.F909c47857c79559576598918989ef1ce82a72918a11683080989000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comCalc sfc varnce GPUization (#1081)
* Initial loop push for calc_sfc_varnce
* BIT_CHANGING:3b086a40085284aa49c71d32c001d20153a8ddb4 the last commit is bit changing for only some cases and only when using higher than -02 optimization. uf min seems to be the first calculation that starting to differ bitwise. Using the check_multicol script confirms the differences are small.
* Adding a tweak to surface values in the extra columns. This helped me check calc_sfc_varance, since we were not changing any arrays that would've affected calculations there.
* Small optimization, making wstar and ustar2 scalars.
* GPUizing calc_sfc_varnce
* Removing conditional around some stats calls. Now we will always save sfc values to stats, because this will change stats files when gr%zm(i,1) > sfc_elevation, this is potentially BIT_CHANGING.
* Merging with latest clubb changes and making work on GPUs again.
This contained 2 commits that are BIT_CHANGING in some situations.
2023-05-02 21:29:49 -05009c47857c79559576598918989ef1ce82a72918a1Calc sfc varnce GPUization (#1081)editsrc/clubb_driver.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/sfc_varnce_module.F90
- input/tunable_parameters/tunable_parameters.insrc/CLUBB_core/advance_helper_module.F9003f58050e0c59a10d9cca54f01876f1e737a9e241683129413000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comReducing C_wp2_splat to 0.25 (from 2.0) for new implicit splatting code.
Also fixing bug that shows up when l_brunt_vaisala_freq_moist = T. This
will hopefully help to get some failing CAM tests running again.
See #1074 and PR #1075 for info.
This is BIT_CHANGING for all cases due to the new tunable parameter value.
2023-05-03 10:56:53 -050003f58050e0c59a10d9cca54f01876f1e737a9e24Reducing C_wp2_splat to 0.25 (from 2.0) for new implicit splatting code.editinput/tunable_parameters/tunable_parameters.ineditsrc/CLUBB_core/advance_helper_module.F90
- src/CLUBB_core/clip_explicit.F90af6f9d87b088e3e7e5cfa328d4cf93f6fd38c1b41683399661000http://carson.math.uwm.edu/jenkins/user/cerniktcernikttjcernik@uwm.eduRemoved Space From clip_explicit
This is another commit that changes absolutely nothing, and only exists to test autocommit changes
2023-05-06 14:01:01 -0500af6f9d87b088e3e7e5cfa328d4cf93f6fd38c1b4Removed Space From clip_expliciteditsrc/CLUBB_core/clip_explicit.F90
- utilities/autocommit_message_maker/autocommit_message_maker.pycdffbc10d9c3292cc224232bce2432a63e7eccfd1683401721000http://carson.math.uwm.edu/jenkins/user/cerniktcernikttjcernik@uwm.eduupdated autocommit_message_maker to check another error for debugging
I have been having alot of trouble recreating the output that is occuring in the host repos in my test, so I want to add it here to see if it works
2023-05-06 14:35:21 -0500cdffbc10d9c3292cc224232bce2432a63e7eccfdupdated autocommit_message_maker to check another error for debuggingeditutilities/autocommit_message_maker/autocommit_message_maker.py
- utilities/autocommit_message_maker/autocommit_message_maker.py569bd7350c3058e77539bc5e68ba7437abfea2f91683406809000http://carson.math.uwm.edu/jenkins/user/cerniktcernikttjcernik@uwm.eduFixed the autocommit message maker code, should noot error anymore
2023-05-06 16:00:09 -0500569bd7350c3058e77539bc5e68ba7437abfea2f9Fixed the autocommit message maker code, should noot error anymoreeditutilities/autocommit_message_maker/autocommit_message_maker.py
- README8d363835501ec82b96b7d6ed8c3cb162d70ac7871683612180000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am beginning a section on running the convergence tests in the README.
2023-05-09 01:03:00 -05008d363835501ec82b96b7d6ed8c3cb162d70ac787I am beginning a section on running the convergence tests in the README.editREADME
- run_scripts/convergence_run/run_cnvg_test_multi_cases_revall.csh4218a86cb398df01513f3b7b88731af9fdc0e53a1683669769000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate run_cnvg_test_multi_cases_revall.csh
Remove the 6th refinement, which is too close in grid spacing to the 7th and reference refinement.
2023-05-09 17:02:49 -05004218a86cb398df01513f3b7b88731af9fdc0e53aUpdate run_cnvg_test_multi_cases_revall.csheditrun_scripts/convergence_run/run_cnvg_test_multi_cases_revall.csh
- run_scripts/convergence_run/run_cnvg_test_multi_cases_default.csh6eff64f255aafd546ceb594733ea1817a02741491683670120000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate run_cnvg_test_multi_cases_default.csh
Remove the 6th refinement, which is too close in grid spacing to the 7th and reference refinement.
2023-05-09 17:08:40 -05006eff64f255aafd546ceb594733ea1817a0274149Update run_cnvg_test_multi_cases_default.csheditrun_scripts/convergence_run/run_cnvg_test_multi_cases_default.csh
- run_scripts/convergence_run/run_cnvg_test_multi_cases_baseline.csh949fb9dcd752ed0edd1c2e5720e34c49929c03751683670163000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate run_cnvg_test_multi_cases_baseline.csh
Remove the 6th refinement, which is too close in grid spacing to the 7th and reference refinement.
2023-05-09 17:09:23 -0500949fb9dcd752ed0edd1c2e5720e34c49929c0375Update run_cnvg_test_multi_cases_baseline.csheditrun_scripts/convergence_run/run_cnvg_test_multi_cases_baseline.csh
- README1efa8cddfb173eec752a7b80926afebcc353ab841683673118000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate README
Updated the description of the convergence tests.
2023-05-09 17:58:38 -05001efa8cddfb173eec752a7b80926afebcc353ab84Update READMEeditREADME
- src/CLUBB_core/calendar.F90src/SILHS/math_utilities.F907304a4ed399e8db8c3778ffb783b937564b85e6c1683999525000http://carson.math.uwm.edu/jenkins/user/cerniktcernikttjcernik@uwm.edumaking changes to trigger autoudpate for test, these commits do nothing
here is a body to the commit as well
2023-05-13 12:38:45 -05007304a4ed399e8db8c3778ffb783b937564b85e6cmaking changes to trigger autoudpate for test, these commits do nothingeditsrc/CLUBB_core/calendar.F90editsrc/SILHS/math_utilities.F90
- src/CLUBB_core/calendar.F90src/SILHS/math_utilities.F90c072656f70eec308312cd411b9098d16a0b699321684000665000http://carson.math.uwm.edu/jenkins/user/cerniktcernikttjcernik@uwm.eduHere is another commit that changes nothing
Here is the body
2023-05-13 12:57:45 -0500c072656f70eec308312cd411b9098d16a0b69932Here is another commit that changes nothingeditsrc/SILHS/math_utilities.F90editsrc/CLUBB_core/calendar.F90
- src/CLUBB_core/endian.F901c51108c54959fc2146c926a947fb77e2f3229b51684001427000http://carson.math.uwm.edu/jenkins/user/cerniktcernikttjcernik@uwm.educhange to trigger updates
this is the last batch
2023-05-13 13:10:27 -05001c51108c54959fc2146c926a947fb77e2f3229b5change to trigger updateseditsrc/CLUBB_core/endian.F90
- src/CLUBB_core/calc_pressure.F906d00bf5998d8853274782192b3a97d00e045e80a1684001497000http://carson.math.uwm.edu/jenkins/user/cerniktcernikttjcernik@uwm.educhange to calc pressure to trigger autoupdate
body
2023-05-13 13:11:37 -05006d00bf5998d8853274782192b3a97d00e045e80achange to calc pressure to trigger autoupdateeditsrc/CLUBB_core/calc_pressure.F90
- run_scripts/convergence_run/run_cnvg_test_multi_cases_default.cshrun_scripts/convergence_run/run_cnvg_test_multi_cases_revall.cshrun_scripts/convergence_run/run_cnvg_test_multi_cases_baseline.csh8ee870e356243f3861202305bebc6c15fe57e3eb1684160213000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduEditing convergence scripts to show that the directory should be placed in
scratch space, where there is plentiful room to run, given the size of the output files.
2023-05-15 09:16:53 -05008ee870e356243f3861202305bebc6c15fe57e3ebEditing convergence scripts to show that the directory should be placed ineditrun_scripts/convergence_run/run_cnvg_test_multi_cases_default.csheditrun_scripts/convergence_run/run_cnvg_test_multi_cases_revall.csheditrun_scripts/convergence_run/run_cnvg_test_multi_cases_baseline.csh
- run_scripts/convergence_run/run_clubb_baselinerun_scripts/convergence_run/run_clubb_defaultrun_scripts/convergence_run/run_clubb_revall5159c745e8a12eae1616043596dac0a9587abcd11684179917000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduCommitting scripts for use in running CLUBB convergence tests in the background.
2023-05-15 14:45:17 -05005159c745e8a12eae1616043596dac0a9587abcd1Committing scripts for use in running CLUBB convergence tests in the background.addrun_scripts/convergence_run/run_clubb_baselineaddrun_scripts/convergence_run/run_clubb_defaultaddrun_scripts/convergence_run/run_clubb_revall
- run_scripts/convergence_run/run_clubb_baselinerun_scripts/convergence_run/run_clubb_defaultrun_scripts/convergence_run/run_clubb_revallea3a68fd04dd0e23b837dd0f013e8801fdf39eef1684180521000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdated the background run scripts for the convergence tests with a comment
about how to use the script.
2023-05-15 14:55:21 -0500ea3a68fd04dd0e23b837dd0f013e8801fdf39eefUpdated the background run scripts for the convergence tests with a commenteditrun_scripts/convergence_run/run_clubb_revalleditrun_scripts/convergence_run/run_clubb_defaulteditrun_scripts/convergence_run/run_clubb_baseline
- README6b3214004c3ec2e3c2554b0a9b409c8adaa4a5901684259645000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI updated the README to finish the section on the convergence tests.
2023-05-16 12:54:05 -05006b3214004c3ec2e3c2554b0a9b409c8adaa4a590I updated the README to finish the section on the convergence tests.editREADME
- README594b74ff2dd50e8f051f1ceced8af963a83fc3561684261306000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduEdited the README section on CLUBB convergence tests.
2023-05-16 13:21:46 -0500594b74ff2dd50e8f051f1ceced8af963a83fc356Edited the README section on CLUBB convergence tests.editREADME
- run_scripts/convergence_run/convergence_config.pydf63abfa50aa910d527bded7304761051f71fa1b1684518421000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added dycoms2_rf01 to the list of cases that could be run.
2023-05-19 12:47:01 -0500df63abfa50aa910d527bded7304761051f71fa1bI added dycoms2_rf01 to the list of cases that could be run.editrun_scripts/convergence_run/convergence_config.py
- run_scripts/convergence_run/run_cnvg_test_multi_cases_revall.csh2b12091dc37d2ebcca09fa10f1d2b3ccca067d351684533029000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI updated the run_cnvg_test_multi_cases_revall.csh script to include
dycoms2_rf01 in the list of cases that are run.
2023-05-19 16:50:29 -05002b12091dc37d2ebcca09fa10f1d2b3ccca067d35I updated the run_cnvg_test_multi_cases_revall.csh script to includeeditrun_scripts/convergence_run/run_cnvg_test_multi_cases_revall.csh
- run_scripts/convergence_run/run_cnvg_test_multi_cases_default.cshrun_scripts/convergence_run/run_cnvg_test_multi_cases_baseline.cshecc4f9d209b09d254fe889b25dff1e18e5dca5301684533905000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduModified run_cnvg_test_multi_cases_default.csh and
run_cnvg_test_multi_cases_baseline.csh for the inclusion of
dycoms2_rf01.
2023-05-19 17:05:05 -0500ecc4f9d209b09d254fe889b25dff1e18e5dca530Modified run_cnvg_test_multi_cases_default.csh andeditrun_scripts/convergence_run/run_cnvg_test_multi_cases_default.csheditrun_scripts/convergence_run/run_cnvg_test_multi_cases_baseline.csh
- utilities/autocommit_message_maker/autocommit_message_maker.pyb75bf29871855c7e2bb56532f1fb82354a55729e1684601565000http://carson.math.uwm.edu/jenkins/user/cerniktcernikttjcernik@uwm.eduAdded comments to the script to explain ambiguous portions of my code
2023-05-20 11:52:45 -0500b75bf29871855c7e2bb56532f1fb82354a55729eAdded comments to the script to explain ambiguous portions of my codeeditutilities/autocommit_message_maker/autocommit_message_maker.py
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_helper_module.F90982203d015ec33283d4d9b8b9ae03ef9fd19f1dc1685471093000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comGPUizing Lscale_width_vert_avg. Loops have been restructured for simplicity, and algorithm has a different starting value to avoid k dependency. Results are BFB. (#1083)
2023-05-30 13:24:53 -0500982203d015ec33283d4d9b8b9ae03ef9fd19f1dcGPUizing Lscale_width_vert_avg. Loops have been restructured for simplicity, and algorithm has a different starting value to avoid k dependency. Results are BFB. (#1083)editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90
- src/CLUBB_core/advance_clubb_core_module.F90d1bd3cd11584759a8b90ae34dc7c26790e7e26e81685683010000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comGPUizing most of advance_clubb_core (#1084)
2023-06-02 00:16:50 -0500d1bd3cd11584759a8b90ae34dc7c26790e7e26e8GPUizing most of advance_clubb_core (#1084)editsrc/CLUBB_core/advance_clubb_core_module.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/clip_explicit.F90src/CLUBB_core/advance_wp2_wp3_module.F90b6da36ca0e381e4547efc594f7f997507ebb9a341686085026000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comadvance_wp2_wp3 with explicitly managed memory (#1085)
* GPUizing most of advance_clubb_core
* GPUizing most of advance_wp2_wp3 based off Supreeths openacc branch
* Cleanup and small fixes.
* Converting data statement to declare statement to return the return.
* Small changes to prevent data copies
2023-06-06 15:57:06 -0500b6da36ca0e381e4547efc594f7f997507ebb9a34advance_wp2_wp3 with explicitly managed memory (#1085)editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/clip_explicit.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xp2_xpyp_module.F902723c75bbfb000b67f641c3e9aa98f3d28517dce1686267553000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comadvance_xp2_xpyp with explicitly managed memory (#1086)
* GPUizing most of advance_clubb_core
* GPUizing most of advance_wp2_wp3 based off Supreeths openacc branch
* Cleanup and small fixes.
* Converting data statement to declare statement to return the return.
* Small changes to prevent data copies
* Initial advance_xp2_xpyp GPUization, adapted from Supreeth's branch, clubb_openacc, to work without managed memory.
* Small cleanup
* Tweaks to reduce data copies
* Small change
* More GPUization and some cleanup
* Final little fixes
* Removing magic logicals
2023-06-08 18:39:13 -05002723c75bbfb000b67f641c3e9aa98f3d28517dceadvance_xp2_xpyp with explicitly managed memory (#1086)editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/CLUBB_core/advance_helper_module.F9078bdcca4a7002e9c2ceddb62e7fc24c82884a3c71686271203000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comadvance_windm_edsclrm with explicitly managed memory (#1087)
* Initial commit for advance_windm_edsclrm adapted from Supreeth's branch
* Final fixes
* Accidentally undid fix
* Returning returns
2023-06-08 19:40:03 -050078bdcca4a7002e9c2ceddb62e7fc24c82884a3c7advance_windm_edsclrm with explicitly managed memory (#1087)editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90d778246e6f0ab92f0f23a100b1c693bc12345db41686688221000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comMoving data statements to outter most parts of clubb and little fix in advance_wp2_wp3 (#1088)
2023-06-13 15:30:21 -0500d778246e6f0ab92f0f23a100b1c693bc12345db4Moving data statements to outter most parts of clubb and little fix in advance_wp2_wp3 (#1088)editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/fill_holes.F90src/CLUBB_core/mono_flux_limiter.F90src/CLUBB_core/clip_explicit.F90src/CLUBB_core/advance_helper_module.F90src/CLUBB_core/advance_xp2_xpyp_module.F90711714c6821efc75febabf0434b52a814b32a40b1687300675000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comData movement improvement (#1089)
* Various reductions in data movement
* Bug fix
* Optimizations to fill_holes, this involves precalculating a multiplication an a division, so this is BIT_CHANGING.
* Missed a small part
* Small fix
2023-06-20 17:37:55 -0500711714c6821efc75febabf0434b52a814b32a40bData movement improvement (#1089)editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/fill_holes.F90editsrc/CLUBB_core/mono_flux_limiter.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/clip_explicit.F90editsrc/CLUBB_core/advance_helper_module.F90
- input_misc/tuner/error_atex.ininput_misc/tuner/error_rico.ininput_misc/tuner/error_gabls3_night.ininput_misc/tuner/error_nov11_altocu.insrc/CLUBB_core/mixing_length.F90input_misc/tuner/error_four_cases.ininput_misc/tuner/error_dycoms2_rf01.ininput_misc/tuner/error_dycoms2_rf02_ds.insrc/clubb_standalone.F90input_misc/tuner/error_wangara.insrc/G_unit_test_types/pdf_parameter_tests.F90input/tunable_parameters/tunable_parameters.ininput_misc/tuner/error_dycoms2_rf02_do.insrc/CLUBB_core/advance_helper_module.F90src/CLUBB_core/parameter_indices.F90input_misc/tuner/error_dycoms2_rf02_nd.ininput_misc/tuner/error_arm.insrc/CLUBB_core/parameters_tunable.F90src/G_unit_test_types/spurious_source_test.F90input_misc/tuner/error_bomex.insrc/clubb_thread_test.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_clubb_core_module.F90input_misc/tuner/error_arm_97.insrc/jacobian.F90input_misc/tuner/error_all.ininput_misc/tuner/error_lba.insrc/CLUBB_core/clubb_api_module.F90input/tunable_parameters_Lscale/configurable_model_flags.ininput_misc/tuner/error_fire.insrc/error.F90input_misc/tuner/error_gabls2.ininput_misc/tuner/error_ticket_756.ina323ae3e38c8d4f569b839cf64f11614183dd9f11687909037000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comCLUBB ticket #1069: (#1092)
- Added tunable parameter bv_efold
- Removed extraneous use statement in src/CLUBB_core/advance_xm_wpxp_module.F90
- Removed obsolete flag l_update_pressure from input/tunable_parameters_Lscale/configurable_model_flags.in
- Changed tmp_calc_min -> tmp_calc in src/CLUBB_core/advance_helper_module.F90
2023-06-27 18:37:17 -0500a323ae3e38c8d4f569b839cf64f11614183dd9f1CLUBB ticket #1069: (#1092)editinput_misc/tuner/error_fire.ineditsrc/CLUBB_core/mixing_length.F90editsrc/clubb_thread_test.F90editinput_misc/tuner/error_four_cases.ineditinput_misc/tuner/error_gabls2.ineditinput/tunable_parameters/tunable_parameters.ineditinput_misc/tuner/error_arm_97.ineditinput_misc/tuner/error_rico.ineditsrc/CLUBB_core/advance_xm_wpxp_module.F90editinput/tunable_parameters_Lscale/configurable_model_flags.ineditinput_misc/tuner/error_dycoms2_rf02_do.ineditsrc/jacobian.F90editinput_misc/tuner/error_nov11_altocu.ineditinput_misc/tuner/error_all.ineditinput_misc/tuner/error_dycoms2_rf01.ineditsrc/CLUBB_core/parameter_indices.F90editsrc/CLUBB_core/clubb_api_module.F90editinput_misc/tuner/error_wangara.ineditinput_misc/tuner/error_arm.ineditinput_misc/tuner/error_ticket_756.ineditsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/CLUBB_core/parameters_tunable.F90editsrc/G_unit_test_types/spurious_source_test.F90editsrc/clubb_standalone.F90editinput_misc/tuner/error_lba.ineditinput_misc/tuner/error_bomex.ineditsrc/error.F90editinput_misc/tuner/error_dycoms2_rf02_nd.ineditsrc/CLUBB_core/advance_helper_module.F90editinput_misc/tuner/error_dycoms2_rf02_ds.ineditinput_misc/tuner/error_atex.ineditinput_misc/tuner/error_gabls3_night.ineditsrc/CLUBB_core/advance_clubb_core_module.F90
- src/CLUBB_core/advance_clubb_core_module.F900e9723d96823a0347ff6ba8d431d95502bb3046c1688584676000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comChanging "Fnc" to "fnc" for consistency and easy search.
2023-07-05 14:17:56 -05000e9723d96823a0347ff6ba8d431d95502bb3046cChanging "Fnc" to "fnc" for consistency and easy search.editsrc/CLUBB_core/advance_clubb_core_module.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/clip_explicit.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/advance_xp2_xpyp_module.F900b0ab3d530bef06eb90bf6dde21b26eb257802141688611277000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comMemory usage optimizations (#1091)
* Fixing merge conflict
* Fixing a bug.
* Restoring correct default flag value
* Undoing changes that push stats variables into pdf_closure. That change may be included in a small future refactoring.
* Making same sclr_dim changes to hydromet_dim
2023-07-05 21:41:17 -05000b0ab3d530bef06eb90bf6dde21b26eb25780214Memory usage optimizations (#1091)editsrc/CLUBB_core/clip_explicit.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90
- README2e3ed83325fd8b1f95a68dfe1568f872f11c70881688678688000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduModifying README. Last commit was BIT_CHANGING:0b0ab3d530bef06eb90bf6dde21b26eb25780214 see https://github.com/larson-group/clubb/pull/1091 for details.
2023-07-06 16:24:48 -05002e3ed83325fd8b1f95a68dfe1568f872f11c7088Modifying README. Last commit was BIT_CHANGING:0b0ab3d530bef06eb90bf6dde21b26eb25780214 see https://github.com/larson-group/clubb/pull/1091 for details.editREADME
- src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/interpolation.F90src/CLUBB_core/grid_class.F90src/CLUBB_core/mean_adv.F90src/CLUBB_core/clip_explicit.F90src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90src/CLUBB_core/sfc_varnce_module.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/turbulent_adv_pdf.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/CLUBB_core/matrix_solver_wrapper.F90src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/mono_flux_limiter.F90src/CLUBB_core/fill_holes.F90src/CLUBB_core/sigma_sqd_w_module.F90src/CLUBB_core/advance_helper_module.F90src/CLUBB_core/diffusion.F90f9b2927131803620d9af3ac671006bbb2de6b83e1689032527000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comOpenacc tweaks and cleanup (#1097)
* Chaning acc declare statements to acc enter data statement
* Making acc statements more consistent
* Making lapack useable while using openacc. Lapack is still run on the CPU
* Updating setup_clubb_core to now accept clubb_config_flags as an input, and adding warning in case clubb is running with lapack but was compiled with openacc.
2023-07-10 18:42:07 -0500f9b2927131803620d9af3ac671006bbb2de6b83eOpenacc tweaks and cleanup (#1097)editsrc/CLUBB_core/sigma_sqd_w_module.F90editsrc/CLUBB_core/matrix_solver_wrapper.F90editsrc/CLUBB_core/mean_adv.F90editsrc/CLUBB_core/mono_flux_limiter.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/clip_explicit.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/CLUBB_core/fill_holes.F90editsrc/CLUBB_core/sfc_varnce_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/grid_class.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/interpolation.F90editsrc/CLUBB_core/turbulent_adv_pdf.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/diffusion.F90
- run_scripts/run_bindiff_all.py398b8a728ce9f39a6ebc4be4e3cabba7c4bccc361689098897000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduImproving run_bin_diff.py to accept an argument to print the differences, and an argument to define a threshold to ignore differences.
2023-07-11 13:08:17 -0500398b8a728ce9f39a6ebc4be4e3cabba7c4bccc36Improving run_bin_diff.py to accept an argument to print the differences, and an argument to define a threshold to ignore differences.editrun_scripts/run_bindiff_all.py
- postprocessing/pyplotgen/requirements.txt0b9f422518f7159d7c2d040cc3b2b818a71e91431689301389000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate requirements.txt
updated Pillow version to resolve related dependabot alerts
2023-07-13 21:23:09 -05000b9f422518f7159d7c2d040cc3b2b818a71e9143Update requirements.txteditpostprocessing/pyplotgen/requirements.txt
- postprocessing/pyplotgen/requirements.txt4c8e71aad6664c648a84ba517dada0994b796fe51689302775000http://carson.math.uwm.edu/jenkins/user/cerniktcernikttjcernik@uwm.eduUpdate requirements.txt
Also updating numpy version to 1.25.1
2023-07-13 21:46:15 -05004c8e71aad6664c648a84ba517dada0994b796fe5Update requirements.txteditpostprocessing/pyplotgen/requirements.txt
- src/CLUBB_core/mean_adv.F9013de9b8e3a8d758a44b8408fb64cc2ac5ffd2c231689430804000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comLoop to `nz-1` instead of `nz` because upper boundary condition
is set in the lines immediately below.
2023-07-15 09:20:04 -050013de9b8e3a8d758a44b8408fb64cc2ac5ffd2c23Loop to `nz-1` instead of `nz` because upper boundary conditioneditsrc/CLUBB_core/mean_adv.F90
- src/clubb_driver.F9029ad556fe9b55c4071e4fc4b6145b79d471f7a1a1689720547000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdded code to subroutine run_clubb in src/clubb_driver.F90 which prints git log and git diff information to the <case>_setup.txt output file. (#1101)
CLUBB ticket #1098
2023-07-18 17:49:07 -050029ad556fe9b55c4071e4fc4b6145b79d471f7a1aAdded code to subroutine run_clubb in src/clubb_driver.F90 which prints git log and git diff information to the <case>_setup.txt output file. (#1101)editsrc/clubb_driver.F90
- src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/advance_xp3_module.F90src/CLUBB_core/grid_class.F90src/CLUBB_core/tridiag_lu_solver.F90src/CLUBB_core/mean_adv.F90src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90src/CLUBB_core/clip_explicit.F90src/CLUBB_core/numerical_check.F90src/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/turbulent_adv_pdf.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/calc_roots.F90src/CLUBB_core/corr_varnce_module.F90src/CLUBB_core/fill_holes.F90src/CLUBB_core/mono_flux_limiter.F90src/CLUBB_core/advance_helper_module.F90src/CLUBB_core/diffusion.F90src/CLUBB_core/penta_lu_solver.F90src/CLUBB_core/clip_semi_implicit.F901f4d0453a4d5c225be028a20ba8cfe44f32383361689730027000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comOpenacc tweaks and cleanup 2 (#1099)
* Making all end parallel directives specify end loop
* Replacing last acc declare in a procedure with acc enter/exit data commands
* Removing pure declarations, turns out they dont really improve performance and openmp isn't allowed within them.
* Adding explicit directives to penta_lu and tridiag_lu, as opposed to the previously used kernels directive. Also splitting up a loop to improve GPU performance.
* Splitting up a couple loops for performance reasons.
* Missed one somehow
2023-07-18 20:27:07 -05001f4d0453a4d5c225be028a20ba8cfe44f3238336Openacc tweaks and cleanup 2 (#1099)editsrc/CLUBB_core/diffusion.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/turbulent_adv_pdf.F90editsrc/CLUBB_core/numerical_check.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/corr_varnce_module.F90editsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/penta_lu_solver.F90editsrc/CLUBB_core/fill_holes.F90editsrc/CLUBB_core/mono_flux_limiter.F90editsrc/CLUBB_core/clip_explicit.F90editsrc/CLUBB_core/grid_class.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/mean_adv.F90editsrc/CLUBB_core/clip_semi_implicit.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/tridiag_lu_solver.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/advance_xp3_module.F90editsrc/CLUBB_core/calc_roots.F90
- utilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/sens_matrix_dashboard.pyutilities/sens_matrix/analyze_sensitivity_matrix.py1ab8885573872beb8b590e955b48c1f5dc6b9bca1689861335000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@users.noreply.github.comAdds to RegTune a plot of a color-coded normalized sensitivity matrix
2023-07-20 08:55:35 -05001ab8885573872beb8b590e955b48c1f5dc6b9bcaAdds to RegTune a plot of a color-coded normalized sensitivity matrixeditutilities/sens_matrix/sens_matrix_dashboard.pyeditutilities/sens_matrix/analyze_sensitivity_matrix.pyeditutilities/sens_matrix/set_up_dashboard_inputs.py
- utilities/sens_matrix/README.mde1a725970256fc9b1c7c2e5f16675bb7d681da8e1689865497000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdds hint about installing dash for RegTune
2023-07-20 10:04:57 -0500e1a725970256fc9b1c7c2e5f16675bb7d681da8eAdds hint about installing dash for RegTuneeditutilities/sens_matrix/README.md
- utilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/sens_matrix_dashboard.py722630f37286ca8f7fad84ef600af6d0607daf0a1689869874000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduUpdates input files for RegTune.
For #910.
2023-07-20 11:17:54 -0500722630f37286ca8f7fad84ef600af6d0607daf0aUpdates input files for RegTune.editutilities/sens_matrix/sens_matrix_dashboard.pyeditutilities/sens_matrix/set_up_dashboard_inputs.py
- src/CLUBB_core/Skx_module.F90src/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/mean_adv.F90e42078081e3931d7de83f7a5d0f5dabc96cb93971690323761000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comBit changing changes (#1104)
* Moving functions called inside loops to their own 2D subroutines. This is for performance, but is also BIT_CHANGING.
* Correct range of values to calculate for term_dp1_lhs
* Comments and cleanup
* Slight change to Skx_func, this is mathematically equivalent but BIT_CHANGING. This is faster on GPUs, and doesn't seem to have a signficiant impact on CPU performance.
* Introducing wp_coef and wp_coef_zt to reduce needed computations. This changes order of operations, so it is BIT_CHANGING.
2023-07-25 17:22:41 -0500e42078081e3931d7de83f7a5d0f5dabc96cb9397Bit changing changes (#1104)editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/Skx_module.F90editsrc/CLUBB_core/mean_adv.F90
- src/CLUBB_core/advance_xp2_xpyp_module.F903dbe0a48a7a72173093335aee0a1decee4ed73031690679815000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding wp_coef and wp_coef_zt to acc data statements.
2023-07-29 20:16:55 -05003dbe0a48a7a72173093335aee0a1decee4ed7303Adding wp_coef and wp_coef_zt to acc data statements.editsrc/CLUBB_core/advance_xp2_xpyp_module.F90
- utilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/sens_matrix_dashboard.py4739fb54b293d3201087c17e81daa2943f5d76611690802652000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduFor RegTune, update input netcdf files.
For #910.
2023-07-31 06:24:12 -05004739fb54b293d3201087c17e81daa2943f5d7661For RegTune, update input netcdf files.editutilities/sens_matrix/set_up_dashboard_inputs.pyeditutilities/sens_matrix/sens_matrix_dashboard.py
- src/CLUBB_core/stats_zt_module.F90input_misc/tuner/READMEsrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_helper_module.F90input/stats/standard_stats.insrc/CLUBB_core/mixing_length.F900c7fc1f05bfd096c03e190497c2f2b6b7bba45821690921282000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comBv efold bit changing (#1095)
BIT_CHANGING! Added e-folding code for mixed Brunt Vaisala frequency - CLUBB ticket #1069
- Included usage for bv_efold in src/CLUBB_core/advance_helper_module.F90
- Added intent(out) for correction_stability in subroutine calc_correction_stability
- Removed brunt_vaisala_freq_sqd_plus
- Idiot proofed interaction between l_diag_Lscale_from_tau and l_use_invrs_tau_N2_iso
- Moved stat_update_var(invrs_tau_wp3_zm) out of if ( l_diag_Lscale_from_tau )
- Fixed some typos in src/CLUBB_core/stats_zt_module.F90
- Added comment about to input_misc/tuner/README about t_variables adn input/stats/tuning_stats.in
2023-08-01 15:21:22 -05000c7fc1f05bfd096c03e190497c2f2b6b7bba4582Bv efold bit changing (#1095)editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/stats_zt_module.F90editsrc/CLUBB_core/advance_helper_module.F90editinput/stats/standard_stats.ineditinput_misc/tuner/READMEeditsrc/CLUBB_core/advance_clubb_core_module.F90
githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/cerniktcernikthttp://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephenshttp://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonhttp://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwmhttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse65http://carson.math.uwm.edu/jenkins/view/all/job/branch_clubb_test/65/63http://carson.math.uwm.edu/jenkins/view/all/job/branch_clubb_test/63/