BRANCHorigin/masterTESTclubb_backwards_compatibility_gfortran_testStarted by user pbroelspbroelspbroels4c2430410e13a733d23852dd5abc08bbc6b02307bc2430410e13a733d23852dd5abc08bbc6b02307brefs/remotes/origin/feeding_stats_through_arg_listc2430410e13a733d23852dd5abc08bbc6b02307bc2430410e13a733d23852dd5abc08bbc6b02307brefs/remotes/origin/feeding_stats_through_arg_list341cda981a58d39a171f155a4987cec616db96d36b1cda981a58d39a171f155a4987cec616db96d36brefs/remotes/origin/master1cda981a58d39a171f155a4987cec616db96d36b1cda981a58d39a171f155a4987cec616db96d36brefs/remotes/origin/master1cda981a58d39a171f155a4987cec616db96d36b1cda981a58d39a171f155a4987cec616db96d36brefs/remotes/origin/masterhttps://github.com/larson-group/clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/branch_clubb_test/detail/branch_clubb_test/34/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/branch_clubb_test/detail/branch_clubb_test/34/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/branch_clubb_test/detail/branch_clubb_test/34/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/branch_clubb_test/detail/branch_clubb_test/34/testsfalseRemove Idiot ProofingCompileConfigure ClubbRun ClubbCheck output against tolerancefalse#34791401102164branch_clubb_test #3434false3411568SUCCESS1642033082132http://carson.math.uwm.edu/jenkins/view/all/job/branch_clubb_test/34/jenkins_tests/clubb_backwards_compatibility_gfortran_test/Jenkinsfile1cda981a58d39a171f155a4987cec616db96d36b1642033063000http://carson.math.uwm.edu/jenkins/user/pbroelspbroelspbroels@uwm.eduFixing character conflict with sed string in jenkinsfile. 2022-01-12 18:17:43 -06001cda981a58d39a171f155a4987cec616db96d36bFixing character conflict with sed string in jenkinsfile.editjenkins_tests/clubb_backwards_compatibility_gfortran_test/Jenkinsfilegithttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephenshttp://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+jangrnhttp://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwaldhttp://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarsonhttp://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffingriffinbhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhueblerhttp://carson.math.uwm.edu/jenkins/user/pbroelspbroelspbroelsfalseBRANCHorigin/masterTESTclubb_gfortran_buildStarted by user pbroelspbroelspbroels4c2430410e13a733d23852dd5abc08bbc6b02307bc2430410e13a733d23852dd5abc08bbc6b02307brefs/remotes/origin/feeding_stats_through_arg_listc2430410e13a733d23852dd5abc08bbc6b02307bc2430410e13a733d23852dd5abc08bbc6b02307brefs/remotes/origin/feeding_stats_through_arg_list3550a3080a1374291f321eae16b2806e0753e09b2750a3080a1374291f321eae16b2806e0753e09b27refs/remotes/origin/master50a3080a1374291f321eae16b2806e0753e09b2750a3080a1374291f321eae16b2806e0753e09b27refs/remotes/origin/master50a3080a1374291f321eae16b2806e0753e09b2750a3080a1374291f321eae16b2806e0753e09b27refs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#35233801102164branch_clubb_test #3535false3515856FAILURE1654614197034http://carson.math.uwm.edu/jenkins/view/all/job/branch_clubb_test/35/jenkins_tests/clubb_backwards_compatibility_gfortran_test/Jenkinsfile8072476e7423607a78acd991f13442ceb4bcd5211642107948000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemoving sed command as it is unnessecary. larson-group/sys_admin#763 2022-01-13 15:05:48 -06008072476e7423607a78acd991f13442ceb4bcd521Removing sed command as it is unnessecary. larson-group/sys_admin#763editjenkins_tests/clubb_backwards_compatibility_gfortran_test/Jenkinsfilesrc/CLUBB_core/parameters_tunable.F9031351cc3d78ba5f7fc722628e1f23889bd55ef141642115849000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduThis should be BIT_CHANGING, but only because the value of Cx_min should change in the netcdf file. This will not be answer changing. 2022-01-13 17:17:29 -060031351cc3d78ba5f7fc722628e1f23889bd55ef14This should be BIT_CHANGING, but only because the value of Cx_min should change in the netcdf file. This will not be answer changing.editsrc/CLUBB_core/parameters_tunable.F90input/tunable_parameters_Lscale/tunable_parameters.inbcb29622c6699771d244bab3345a7e7ea70ea3231642115982000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comChange value of Cx_min to match what is in parameters_tunable.F90 2022-01-13 17:19:42 -0600bcb29622c6699771d244bab3345a7e7ea70ea323Change value of Cx_min to match what is in parameters_tunable.F90editinput/tunable_parameters_Lscale/tunable_parameters.ininput/tunable_parameters_compatible_r8029/configurable_model_flags.ininput/tunable_parameters_compatible_r8029/tunable_parameters.in067d5ca5d065d2f62e06ea713ac73125ba692eaf1642116689000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding flags and parameters to the r8029 backwards compatible lists. These do not change the backwards compatible results, so that we aren't relying on source code default values. 2022-01-13 17:31:29 -0600067d5ca5d065d2f62e06ea713ac73125ba692eafAdding flags and parameters to the r8029 backwards compatible lists. These do not change the backwards compatible results, so that we aren't relying on source code default values.editinput/tunable_parameters_compatible_r8029/tunable_parameters.ineditinput/tunable_parameters_compatible_r8029/configurable_model_flags.ininput/tunable_parameters/tunable_parameters.insrc/CLUBB_core/parameters_tunable.F903f4e66923a460e96c51d1473153aba6ce1c9c78a1642119958000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduChanging the value of C_invrs_tau_shear from 0.02 to 0.15. This commit is BIT_CHANGING 2022-01-13 18:25:58 -06003f4e66923a460e96c51d1473153aba6ce1c9c78aChanging the value of C_invrs_tau_shear from 0.02 to 0.15.editinput/tunable_parameters/tunable_parameters.ineditsrc/CLUBB_core/parameters_tunable.F90src/CLUBB_core/advance_clubb_core_module.F90108f6ea2c8b3d9357cf551b11a85a2d9a4becc471642120044000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAvoiding stats call for variables that are not set when l_diag_Lscale_from_tau is not true. 2022-01-13 18:27:24 -0600108f6ea2c8b3d9357cf551b11a85a2d9a4becc47Avoiding stats call for variables that are not set when l_diag_Lscale_from_tau is not true.editsrc/CLUBB_core/advance_clubb_core_module.F90READMEe000e918d50566e48e2e35d43e7c7ad76a0e38cd1642122383000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding line to readme because previous commit will be BIT_CHANGING:108f6ea2c8b3d9357cf551b11a85a2d9a4becc47 in the backwards compatibility run since it will prevent NaNs in the .nc files. 2022-01-13 19:06:23 -0600e000e918d50566e48e2e35d43e7c7ad76a0e38cdAdding line to readme because previous commit will be BIT_CHANGING:108f6ea2c8b3d9357cf551b11a85a2d9a4becc47 in the backwards compatibility run since it will prevent NaNs in the .nc files.editREADMErun_scripts/diff_netcdf_outputs.pyrun_scripts/run_bindiff_all.bashee117e4e991e6afcc9327cf8890439e1f90f86af1642188888000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding script that checks if two nc files contain different output fields, rather than just checking bit-for-bitness between the two. Also making our run_bin_diff script use this new nc comparator instead of linux diff. 2022-01-14 13:34:48 -0600ee117e4e991e6afcc9327cf8890439e1f90f86afAdding script that checks if two nc files contain different output fields, rather than just checking bit-for-bitness between the two. Also making our run_bin_diff script use this new nc comparator instead of linux diff.addrun_scripts/diff_netcdf_outputs.pyeditrun_scripts/run_bindiff_all.bashinput/tunable_parameters/tunable_parameters.insrc/CLUBB_core/parameters_tunable.F906dff441959e8cdb1eb5c52576309eb27f4f619c11642203316000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAdjusting the value of C_invrs_tau_shear from 0.15 to 0.16 so that CLUBB (particularly the MC3E case) completes successfully for all compiler tests. You might say that this is BIT_CHANGING. 2022-01-14 17:35:16 -06006dff441959e8cdb1eb5c52576309eb27f4f619c1Adjusting the value of C_invrs_tau_shear from 0.15 to 0.16 so thateditsrc/CLUBB_core/parameters_tunable.F90editinput/tunable_parameters/tunable_parameters.insrc/G_unit_test_types/spurious_source_test.F90input/case_setups/rico_model.insrc/CLUBB_core/mixing_length.F90src/clubb_tuner.F90src/CLUBB_core/advance_clubb_core_module.F90input/case_setups/mc3e_model.insrc/CLUBB_core/constants_clubb.F90src/CLUBB_core/model_flags.F90src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F90input/case_setups/arm_97_model.insrc/G_unit_test_types/pdf_parameter_tests.F90input/tunable_parameters/configurable_model_flags.insrc/CLUBB_core/advance_helper_module.F902f3a8a9c995174067f2a6687aff1fa96de2452e31642358928000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd l_smooth_Heaviside_tau_wpxp to smooth discontinuity in invrs_tau_wpxp_zm This option calls subroutine smooth_heaviside_peskin, which implements the smooth Peskin Heaviside function. The option is turned off for now, and so the results should remain bit for bit. For #965. 2022-01-16 12:48:48 -06002f3a8a9c995174067f2a6687aff1fa96de2452e3Add l_smooth_Heaviside_tau_wpxp to smooth discontinuity in invrs_tau_wpxp_zmeditsrc/CLUBB_core/model_flags.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/constants_clubb.F90editinput/case_setups/rico_model.ineditsrc/CLUBB_core/mixing_length.F90editinput/tunable_parameters/configurable_model_flags.ineditsrc/clubb_driver.F90editinput/case_setups/arm_97_model.ineditsrc/CLUBB_core/advance_helper_module.F90editsrc/clubb_tuner.F90editsrc/G_unit_test_types/spurious_source_test.F90editinput/case_setups/mc3e_model.ineditsrc/G_unit_test_types/pdf_parameter_tests.F90postprocessing/pyplotgen/config/VariableGroupSamBudgets.py6dcce178eab0e55501bd5fc54fab5fbab1b8a5e51642532524000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comUpdating pyplotgen's SAM wp3 budgets to include pressure diffusion, pressure scrambling, and the wp3_tp term. See https://github.com/larson-group/clubb/issues/895. 2022-01-18 13:02:04 -06006dcce178eab0e55501bd5fc54fab5fbab1b8a5e5Updating pyplotgen's SAM wp3 budgets to include pressure diffusion, pressure scrambling, and the wp3_tp term.editpostprocessing/pyplotgen/config/VariableGroupSamBudgets.pysrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/pdf_parameter_module.F90src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F900ad5cf6b50ee98fd3726cfa79632a5741a0dab071642541581000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing column loop into advance_clubb_core, and adding interface for it so that we will not need to update any host models. Everything is bit-for-bit, testing all standalone cases and our cam_coarse res run. larson-group/clubb#972 2022-01-18 15:33:01 -06000ad5cf6b50ee98fd3726cfa79632a5741a0dab07Pushing column loop into advance_clubb_core, and adding interface for it so that we will not need to update any host models. Everything is bit-for-bit, testing all standalone cases and our cam_coarse res run. larson-group/clubb#972editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/pdf_parameter_module.F90editsrc/clubb_driver.F90src/advance_microphys_module.F90ab27fc3d8aaca018eade22528487879e0f7619601642548516000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAdding an error prints subroutine to advance_microphys_module.F90 so that the prints can be called whenever there is an error detected (and before the "return" statement). 2022-01-18 17:28:36 -0600ab27fc3d8aaca018eade22528487879e0f761960Adding an error prints subroutine to advance_microphys_module.F90editsrc/advance_microphys_module.F90src/CLUBB_core/clubb_api_module.F9083b143d94dc8a47731a4f01d04c1c3490d79116f1642618464000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding l_stats check around stats stuff. This fixes the crashing when stats is disabled. larson-group/clubb#972 2022-01-19 12:54:24 -060083b143d94dc8a47731a4f01d04c1c3490d79116fAdding l_stats check around stats stuff. This fixes the crashing when stats is disabled. larson-group/clubb#972editsrc/CLUBB_core/clubb_api_module.F90postprocessing/pyplotgen/config/VariableGroupBase.pyc3db300d526967ef9b8887d271909c0e59408ae51642626069000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comFixing typo in VariableGroupBase.py 2022-01-19 15:01:09 -0600c3db300d526967ef9b8887d271909c0e59408ae5Fixing typo in VariableGroupBase.pyeditpostprocessing/pyplotgen/config/VariableGroupBase.pysrc/CLUBB_core/clubb_api_module.F901a80c9933d421695cee765d284c60438bdec0fa71642631316000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking single and multi column versions of advance clubb core available through clubb_api. larson-group/clubb#972 2022-01-19 16:28:36 -06001a80c9933d421695cee765d284c60438bdec0fa7Making single and multi column versions of advance clubb core available through clubb_api. larson-group/clubb#972editsrc/CLUBB_core/clubb_api_module.F90src/morrison_microphys_module.F9099c51833bb140ec882b95c7d25d97fd6a8db69921642715551000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added error prints to the interface for Morrison microphysics that print many important fields when a NaN has been detected in a microphysics tendency output. 2022-01-20 15:52:31 -060099c51833bb140ec882b95c7d25d97fd6a8db6992I added error prints to the interface for Morrison microphysics thateditsrc/morrison_microphys_module.F90src/CLUBB_core/advance_clubb_core_module.F90831646a1ea7851a89f63f512bc3ce1cdcd2832dc1642725231000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduBreaking up column loop in advance_clubb_core. larson-group/clubb#972 2022-01-20 18:33:51 -0600831646a1ea7851a89f63f512bc3ce1cdcd2832dcBreaking up column loop in advance_clubb_core. larson-group/clubb#972editsrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_clubb_core_module.F904b7d05d439da9c873901b0ca4d1d9478f07ddd7e1642801850000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing loop into pdf_closure and breaking it up. larson-group/clubb#972 2022-01-21 15:50:50 -06004b7d05d439da9c873901b0ca4d1d9478f07ddd7ePushing loop into pdf_closure and breaking it up. larson-group/clubb#972editsrc/CLUBB_core/advance_clubb_core_module.F90input/tunable_parameters/tunable_parameters.insrc/CLUBB_core/parameters_tunable.F9085a583bd16acfc64ef77a80452507b9141423e651642810666000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI changed C_invrs_tau_N2_wp2 from 0.1 to 0.2 to help stop turbulence from going to the model top, which ultimately caused MC3E to crash by becoming too cold. Additionally, I set C_invrs_tau_shear back to 0.15 from 0.16. This commit is BIT_CHANGING. 2022-01-21 18:17:46 -060085a583bd16acfc64ef77a80452507b9141423e65I changed C_invrs_tau_N2_wp2 from 0.1 to 0.2 to help stop turbulenceeditinput/tunable_parameters/tunable_parameters.ineditsrc/CLUBB_core/parameters_tunable.F90run_scripts/run_thread_test.bash4e09f4778cdbe7d008b9a64f5ba89f7f55c998481642866225000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClarifies debugging messages of thread test 2022-01-22 09:43:45 -06004e09f4778cdbe7d008b9a64f5ba89f7f55c99848Clarifies debugging messages of thread testeditrun_scripts/run_thread_test.bashsrc/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/advance_clubb_core_module.F90604c2a9743e7fd6278654754f6bb2494c5f8f63f1643072201000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing loop into pdf_closure_module and breaking it up. larson-group/clubb#972 2022-01-24 18:56:41 -0600604c2a9743e7fd6278654754f6bb2494c5f8f63fPushing loop into pdf_closure_module and breaking it up. larson-group/clubb#972editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/pdf_closure_module.F90187fe41fcbfaf70614ff7e005ced4a8ae8b14efc1643141070000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking the good version of pdf_params used most places. The bad version is the single column version. larson-group/clubb#972 2022-01-25 14:04:30 -0600187fe41fcbfaf70614ff7e005ced4a8ae8b14efcMaking the good version of pdf_params used most places. The bad version is the single column version. larson-group/clubb#972editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/pdf_closure_module.F90input/tunable_parameters/configurable_model_flags.insrc/CLUBB_core/model_flags.F90de28affa68f28363d07fe54c018a0f4b4b06586e1643148928000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduMaking a commit that officially places the call to the PDF in the "post" position (meaning after CLUBB's predictive fields have been advanced). This commit is BIT_CHANGING 2022-01-25 16:15:28 -0600de28affa68f28363d07fe54c018a0f4b4b06586eMaking a commit that officially places the call to the PDF in the "post"editinput/tunable_parameters/configurable_model_flags.ineditsrc/CLUBB_core/model_flags.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F9005c79662a9c7477e64f0c33dd1464001cc6ead961643158136000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing loops into all relevent lowest level routines in pdf_closure. larson-group/clubb#972 2022-01-25 18:48:56 -060005c79662a9c7477e64f0c33dd1464001cc6ead96Pushing loops into all relevent lowest level routines in pdf_closure. larson-group/clubb#972editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90editsrc/CLUBB_core/pdf_closure_module.F90src/G_unit_test_types/pdf_parameter_tests.F90src/G_unit_test_types/w_up_in_cloud_tests.F90fc2eb27b64f549c9749ac9ecfef192c7c2c262231643158196000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMissing files from previous commit. larson-group/clubb#972 2022-01-25 18:49:56 -0600fc2eb27b64f549c9749ac9ecfef192c7c2c26223Missing files from previous commit. larson-group/clubb#972editsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/G_unit_test_types/w_up_in_cloud_tests.F90src/CLUBB_core/pdf_closure_module.F90a3161e5614bf12f8b22700db87b2597d8197efec1643158635000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduForgot an & symbol. 2022-01-25 18:57:15 -0600a3161e5614bf12f8b22700db87b2597d8197efecForgot an & symbol.editsrc/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/pdf_closure_module.F90df3bf7f575baf09926b4299a5e8ab38b42da996c1643238890000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduWe need to initialize our local pdf_implicit_coefs_terms_zm in certain pdf types. We also don't need to zero out pdf_implicit_coefs_terms arrays, since that's done in the initialization. This should fix segfaults when l_call_pdf_closure_twice=.True. larson-group/clubb#972 2022-01-26 17:14:50 -0600df3bf7f575baf09926b4299a5e8ab38b42da996cWe need to initialize our local pdf_implicit_coefs_terms_zm in certain pdf types. We also don't need to zero out pdf_implicit_coefs_terms arrays, since that's done in the initialization. This should fix segfaults when l_call_pdf_closure_twice=.True. larson-group/clubb#972editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/clubb_driver.F9050740107aaf7aa9cc7f573cb75d1e77d7a52e1401643342499000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am updating ice_supersat_frac to be an intent(inout) variable for advance_clubb_core. When the PDF is in the "post" position, there is a chance that it can be used before it is set unless it is preserved from timestep to timestep. 2022-01-27 22:01:39 -060050740107aaf7aa9cc7f573cb75d1e77d7a52e140I am updating ice_supersat_frac to be an intent(inout) variable foreditsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/clubb_driver.F90src/CLUBB_core/advance_clubb_core_module.F9043e3ed467b12b4a67175d9591e106b7c1f5e35511643406577000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduIntializing sigma_sqd_w_zt when not using ADG1. larson-group/clubb#972 2022-01-28 15:49:37 -060043e3ed467b12b4a67175d9591e106b7c1f5e3551Intializing sigma_sqd_w_zt when not using ADG1. larson-group/clubb#972editsrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/pdf_parameter_module.F909fafdc88ad9ff33a142d439e9079e11a9d594cbc1643411572000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bug, we were not initializng pdf_params for all columns. larson-group/clubb#972 2022-01-28 17:12:52 -06009fafdc88ad9ff33a142d439e9079e11a9d594cbcFixing bug, we were not initializng pdf_params for all columns. larson-group/clubb#972editsrc/CLUBB_core/pdf_parameter_module.F90src/input_fields.F90src/clubb_driver.F90432998647cc3004408c9030c0300b00e34a745451643416649000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI updated CLUBB to include new fields to its restart functionality. These fields are necessary to restart CLUBB when the PDF is placed in the "post" position. 2022-01-28 18:37:29 -0600432998647cc3004408c9030c0300b00e34a74545I updated CLUBB to include new fields to its restart functionality.editsrc/input_fields.F90editsrc/clubb_driver.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/grid_class.F9086d05e7dca94d508b29883762875fe0a08dea30e1643747310000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing column index into zm2zt and zt2zm. larson-group/clubb#972 2022-02-01 14:28:30 -060086d05e7dca94d508b29883762875fe0a08dea30ePushing column index into zm2zt and zt2zm. larson-group/clubb#972editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/grid_class.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/Skx_module.F90src/clubb_driver.F90947de4988ae05d123a9ce5920e016d31f589754c1643751025000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing column index into Skx_func and making it a subroutine. larson-group/clubb#972 2022-02-01 15:30:25 -0600947de4988ae05d123a9ce5920e016d31f589754cPushing column index into Skx_func and making it a subroutine. larson-group/clubb#972editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/Skx_module.F90editsrc/clubb_driver.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_helper_module.F90src/CLUBB_core/sigma_sqd_w_module.F90src/CLUBB_core/grid_class.F9087a53ffc8879c37549b77c26005ba6351fdd03e31643762869000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduA variety of small loop pushing. larson-group/clubb#972 2022-02-01 18:47:49 -060087a53ffc8879c37549b77c26005ba6351fdd03e3A variety of small loop pushing. larson-group/clubb#972editsrc/CLUBB_core/grid_class.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/sigma_sqd_w_module.F90src/G_unit_test_types/pdf_parameter_tests.F904483b986d38255b6149600b7a414d3400f49cb221643826714000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMissed a file to commit, causing lots of compilation failures in Jenkins tests. 2022-02-02 12:31:54 -06004483b986d38255b6149600b7a414d3400f49cb22Missed a file to commit, causing lots of compilation failures in Jenkins tests.editsrc/G_unit_test_types/pdf_parameter_tests.F90src/CLUBB_core/sigma_sqd_w_module.F902b13ca146a3a5d9a41093fe29b777311be1ef37b1643831947000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixed small bug that slipped through because the G_unit tests use nz=1. 2022-02-02 13:59:07 -06002b13ca146a3a5d9a41093fe29b777311be1ef37bFixed small bug that slipped through because the G_unit tests use nz=1.editsrc/CLUBB_core/sigma_sqd_w_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_helper_module.F90src/CLUBB_core/mixing_length.F90a2bd9f0b8c90498e2e7dfc9c514934e5a7696f991643840875000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing column index into mixing length routines, not all the way down for the non-tau based calculation. larson-group/clubb#972 2022-02-02 16:27:55 -0600a2bd9f0b8c90498e2e7dfc9c514934e5a7696f99Pushing column index into mixing length routines, not all the way down for the non-tau based calculation. larson-group/clubb#972editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/pdf_parameter_module.F904f9a3b3f34aaaa2e64a01c47df56c9059d44fccc1643927836000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added a subroutine that prints that values of all PDF parameters in type pdf_parameter, which is a useful debugging tool. 2022-02-03 16:37:16 -06004f9a3b3f34aaaa2e64a01c47df56c9059d44fcccI added a subroutine that prints that values of all PDF parameters ineditsrc/CLUBB_core/pdf_parameter_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/Skx_module.F9072be16bd5cd70d3b1da1b67100b8c77e10412fa21643933733000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSmall changes and a loop push. larson-group/clubb#972 2022-02-03 18:15:33 -060072be16bd5cd70d3b1da1b67100b8c77e10412fa2Small changes and a loop push. larson-group/clubb#972editsrc/CLUBB_core/Skx_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/G_unit_tests.F90src/G_unit_test_types/spurious_source_test.F90b129d6d775a4f3a0196fded18d9b01caf25c93ad1643933733000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing loop into advance_xm_wpxp. larson-group/clubb#972 2022-02-03 18:15:33 -0600b129d6d775a4f3a0196fded18d9b01caf25c93adPushing loop into advance_xm_wpxp. larson-group/clubb#972editsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/G_unit_tests.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90src/G_unit_test_types/pdf_parameter_tests.F90src/CLUBB_core/sigma_sqd_w_module.F90bcef2c0c52463de6d112dd7e19705356afa8da771643933733000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking the G_unit test use a dummy column index. This makes it so we don't need an interface for compute_sigma_sqd_w since now we only use it with 2 dimensions. This is just nicer. larson-group/clubb#972 2022-02-03 18:15:33 -0600bcef2c0c52463de6d112dd7e19705356afa8da77Making the G_unit test use a dummy column index. This makes it so we don't need an interface for compute_sigma_sqd_w since now we only use it with 2 dimensions. This is just nicer. larson-group/clubb#972editsrc/CLUBB_core/sigma_sqd_w_module.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90src/CLUBB_core/advance_xm_wpxp_module.F906eac94448cf3cb48302596d50915768cb97105f51644004220000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduBreaking up column loop in advance_xm_wpxp_module. larson-group/clubb#972 2022-02-04 13:50:20 -06006eac94448cf3cb48302596d50915768cb97105f5Breaking up column loop in advance_xm_wpxp_module. larson-group/clubb#972editsrc/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/mono_flux_limiter.F90src/CLUBB_core/advance_xm_wpxp_module.F90fbb92ad980db25d41bea5f0dd39edd8c5976d9411644016923000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing column loop into local functions. larson-group/clubb#972 2022-02-04 17:22:03 -0600fbb92ad980db25d41bea5f0dd39edd8c5976d941Pushing column loop into local functions. larson-group/clubb#972editsrc/CLUBB_core/mono_flux_limiter.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90README68f91aa403537e1f24c3b3756fefcb9930d033da1644272484000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdding a line to trigger the nightly tests. 2022-02-07 16:21:24 -060068f91aa403537e1f24c3b3756fefcb9930d033daAdding a line to trigger the nightly tests.editREADMEsrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90fc75c887ae516e55f31156a6c1cccaedfaf34ff31644444703000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMoving stats call for uprcp and vprcp to after they are calculated. This fixes the silhs restart test. But does not seem to fix the E3SM or CAM tests that are still failing. 2022-02-09 16:11:43 -0600fc75c887ae516e55f31156a6c1cccaedfaf34ff3Moving stats call for uprcp and vprcp to after they are calculated. This fixes the silhs restart test. But does not seem to fix the E3SM or CAM tests that are still failing.editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90README262b7d9fc30851d432951b97533acab4884b2c451644451232000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduThe last commit was BIT_CHANGING:fc75c887ae516e55f31156a6c1cccaedfaf34ff3 since it does change when uprcp and vprcp are saved to stats output. Was not answer changing though. 2022-02-09 18:00:32 -0600262b7d9fc30851d432951b97533acab4884b2c45The last commit was BIT_CHANGING:fc75c887ae516e55f31156a6c1cccaedfaf34ff3 since it does change when uprcp and vprcp are saved to stats output. Was not answer changing though.editREADMEdoc/clubb_coding_standards.mdf069daadb4a27126f9940d1184a90b50e486b4321644507609000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd coding rule to write variables to disk immediately after they are set. 2022-02-10 09:40:09 -0600f069daadb4a27126f9940d1184a90b50e486b432Add coding rule to write variables to disk immediately after they are set.editdoc/clubb_coding_standards.mdsrc/CLUBB_core/clubb_api_module.F90f9b6bb6132447cc3c074be9bef38fb701bd7f08a1645044208000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding 2D version of zt2zm and zm2zt to clubb_api 2022-02-16 14:43:28 -0600f9b6bb6132447cc3c074be9bef38fb701bd7f08aAdding 2D version of zt2zm and zm2zt to clubb_apieditsrc/CLUBB_core/clubb_api_module.F90doc/clubb_coding_standards.md42cd7b738bb3c10d52dd6fd840c84ec65a26103e1645142237000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdds a naming convention for CLUBB's indices 2022-02-17 17:57:17 -060042cd7b738bb3c10d52dd6fd840c84ec65a26103eAdds a naming convention for CLUBB's indiceseditdoc/clubb_coding_standards.mdsrc/CLUBB_core/advance_xm_wpxp_module.F90README7e2a2265b003b9e9db59902fdbb3059b7815d5b91645143350000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comPushing loop into solve_xm_wpxp_with_single_lhs (#986) Co-authored-by: Peter Roels <56004443+pbroels@users.noreply.github.com> 2022-02-17 18:15:50 -06007e2a2265b003b9e9db59902fdbb3059b7815d5b9Pushing loop into solve_xm_wpxp_with_single_lhs (#986)editsrc/CLUBB_core/advance_xm_wpxp_module.F90editREADMEsrc/CLUBB_core/advance_xm_wpxp_module.F9065fb263b15719f312c881622a3d2ae61eb96fc7c1645475225000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRefactoring to remove need for global stats scratch variables. (#988) * Refactoring to remove need for global stats scratch variables. larson-group/clubb#972 * Changing name of new stats_scratch variables to be more descriptive. 2022-02-21 14:27:05 -060065fb263b15719f312c881622a3d2ae61eb96fc7cRefactoring to remove need for global stats scratch variables. (#988)editsrc/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90d284c4656d237114f6ee5db3a8221bb3f1dd09b81645649579000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comGunthers branch (#989) * Refactoring to remove need for global stats scratch variables. larson-group/clubb#972 * Changing name of new stats_scratch variables to be more descriptive. * Breaking up column loop in solve_xm_wpxp_with_single_lhs. larson-group/clubb#972 * Pushing loop into solve_xm_wpxp_with_multiple_lhs and breaking it up. larson-group/clubb#972 * Pusing loop into xm_wpxp_rhs and xm_wpxp_lhs. larson-group/clubb#972 * Pushing loop into xm_wpxp_solve and xm_wpxp_clipping_and_stats. larson-group/clubb#972 2022-02-23 14:52:59 -0600d284c4656d237114f6ee5db3a8221bb3f1dd09b8Gunthers branch (#989)editsrc/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90d0bc4c6b2a3fe086aa365dccfdbcc651b3242e9a1645697712000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing small bug that breaks runs with scalars. 2022-02-24 04:15:12 -0600d0bc4c6b2a3fe086aa365dccfdbcc651b3242e9aFixing small bug that breaks runs with scalars.editsrc/CLUBB_core/advance_xm_wpxp_module.F90compile/file_list/G_unit_tests_filessrc/G_unit_tests.F90src/CLUBB_core/advance_helper_module.F90src/G_unit_test_types/smooth_heaviside_tests.F90input_misc/G_unit_tests.insrc/G_unit_test_types/smooth_min_max_tests.F902bf5ea15ccffb01a9c304230562691fe86d32cc81645806997000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comImplementations of smooth min, max and heaviside function. Added G-Unit tests 2022-02-25 10:36:37 -06002bf5ea15ccffb01a9c304230562691fe86d32cc8Implementations of smooth min, max and heaviside function. Added G-Unit testseditsrc/CLUBB_core/advance_helper_module.F90editsrc/G_unit_tests.F90editinput_misc/G_unit_tests.inaddsrc/G_unit_test_types/smooth_heaviside_tests.F90addsrc/G_unit_test_types/smooth_min_max_tests.F90editcompile/file_list/G_unit_tests_filessrc/G_unit_test_types/smooth_min_max_tests.F90510cec1ef1e792773c23dc4378d796bd97263aea1645806997000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comFixed and added final test. Everything is now functional 2022-02-25 10:36:37 -0600510cec1ef1e792773c23dc4378d796bd97263aeaFixed and added final test. Everything is now functionaleditsrc/G_unit_test_types/smooth_min_max_tests.F90src/G_unit_test_types/smooth_min_max_tests.F90f97155a62bca4366c819f2050e5ea2f2112aba731645806997000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comModified the two inequalities in the final test. (for mostly aesthetic reasons) 2022-02-25 10:36:37 -0600f97155a62bca4366c819f2050e5ea2f2112aba73Modified the two inequalities in the final test. (for mostly aesthetic reasons)editsrc/G_unit_test_types/smooth_min_max_tests.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/setup_clubb_pdf_params.F900a489d994b4430f8c519223acd02000a34fa45471646171654000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking setup_pdf_parameters accept ngrdcols size arrays of stats and grid types. 2022-03-01 15:54:14 -06000a489d994b4430f8c519223acd02000a34fa4547Making setup_pdf_parameters accept ngrdcols size arrays of stats and grid types.editsrc/CLUBB_core/setup_clubb_pdf_params.F90editsrc/CLUBB_core/clubb_api_module.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/setup_clubb_pdf_params.F908290cd1a1cc8c73e21add181c021ba1a551049ee1646172170000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduForgot two small changes. larson-group/cam#129 2022-03-01 16:02:50 -06008290cd1a1cc8c73e21add181c021ba1a551049eeForgot two small changes. larson-group/cam#129editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/setup_clubb_pdf_params.F90src/CLUBB_core/precipitation_fraction.F90src/CLUBB_core/setup_clubb_pdf_params.F903b77fda2d4c4fb99bf4794b2fe98780b9f320d261646174455000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving need for data copies. larson-group/cam#129 2022-03-01 16:40:55 -06003b77fda2d4c4fb99bf4794b2fe98780b9f320d26Removing need for data copies. larson-group/cam#129editsrc/CLUBB_core/setup_clubb_pdf_params.F90editsrc/CLUBB_core/precipitation_fraction.F90src/CLUBB_core/setup_clubb_pdf_params.F90352cf0e9c6565763b797ed8c6c17ed7e1be8920c1646175410000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduChanging column loop index from j to i. larson-group/cam#129 2022-03-01 16:56:50 -0600352cf0e9c6565763b797ed8c6c17ed7e1be8920cChanging column loop index from j to i. larson-group/cam#129editsrc/CLUBB_core/setup_clubb_pdf_params.F90READMEf785d337b24358ab17ad070a9ad2d5e85f2633bf1646865839000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdding a line to trigger the nightly tests. 2022-03-09 16:43:59 -0600f785d337b24358ab17ad070a9ad2d5e85f2633bfAdding a line to trigger the nightly tests.editREADMEsrc/SILHS/latin_hypercube_driver_module.F904285ec7c9d036233e9c6921f7a4f7c457d669c461646950443000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comRemoving data copies that we don't need anymore. This still runs correctly on GPUs. 2022-03-10 16:14:03 -06004285ec7c9d036233e9c6921f7a4f7c457d669c46Removing data copies that we don't need anymore. This still runs correctly on GPUs.editsrc/SILHS/latin_hypercube_driver_module.F90src/SILHS/latin_hypercube_driver_module.F90src/SILHS/silhs_api_module.F90src/clubb_driver.F90985d685d77eabb001a1dfe0449f7b3e6716e5b661646950443000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comMaking clip_transform_silhs_output use an array of gr. This is how it should have been once the column loop was pushed down into it, but at the time clubb was using gr through a use statement making that not possible. 2022-03-10 16:14:03 -0600985d685d77eabb001a1dfe0449f7b3e6716e5b66Making clip_transform_silhs_output use an array of gr. This is how it should have been once the column loop was pushed down into it, but at the time clubb was using gr through a use statement making that not possible.editsrc/SILHS/silhs_api_module.F90editsrc/clubb_driver.F90editsrc/SILHS/latin_hypercube_driver_module.F90src/SILHS/latin_hypercube_driver_module.F909976b866185e562df3c99f7fbe96379192d3ad9d1646950443000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comNo more need for these data copies anymore now that pdf_params is allocated with ngrdcol rather than pcols. 2022-03-10 16:14:03 -06009976b866185e562df3c99f7fbe96379192d3ad9dNo more need for these data copies anymore now that pdf_params is allocated with ngrdcol rather than pcols.editsrc/SILHS/latin_hypercube_driver_module.F90src/CLUBB_core/advance_clubb_core_module.F90617f13253b404b3b6a858298793bad00acaf18781647296994000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdds a blank line to trigger git merge with E3SM 2022-03-14 17:29:54 -0500617f13253b404b3b6a858298793bad00acaf1878Adds a blank line to trigger git merge with E3SMeditsrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_clubb_core_module.F90133eb6aab07b7a39fc5e54513d1426d76d4fa64d1647434771000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemoves a blank line in order to trigger merge with E3SM 2022-03-16 07:46:11 -0500133eb6aab07b7a39fc5e54513d1426d76d4fa64dRemoves a blank line in order to trigger merge with E3SMeditsrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/mono_flux_limiter.F90src/CLUBB_core/advance_xm_wpxp_module.F90580c8c0ce15891a6279a8e42c274db43893a3d111647461903000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comPushing column loop into xm_wpxp_clipping_and_stats and monotonic_turbulent_flux_limit. This essentially completes advance_xm_wpxp for now. larson-group/clubb#972 2022-03-16 15:18:23 -0500580c8c0ce15891a6279a8e42c274db43893a3d11Pushing column loop into xm_wpxp_clipping_and_stats and monotonic_turbulent_flux_limit. This essentially completes advance_xm_wpxp for now. larson-group/clubb#972editsrc/CLUBB_core/mono_flux_limiter.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_xp2_xpyp_module.F90c72d8ca5ce0824b6279b884a13a84740ee2dbbf21647461903000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comReplacing the i loop iterator for scalars with sclr. 2022-03-16 15:18:23 -0500c72d8ca5ce0824b6279b884a13a84740ee2dbbf2Replacing the i loop iterator for scalars with sclr.editsrc/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xp2_xpyp_module.F9047e9d1e613c2c715ea532edb1d4fb72d0fab5b4c1647461903000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comPushing loop into advance_xp2_wpxp. 2022-03-16 15:18:23 -050047e9d1e613c2c715ea532edb1d4fb72d0fab5b4cPushing loop into advance_xp2_wpxp.editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xp2_xpyp_module.F903efae613c219a686eeeaf53617e8c24304fb24ab1647461903000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comMoving the lhs_dp1 calculation to outside of xp2_xpyp_lhs. This gives us more flexibility, since we want to pass lhs_dp1 into xp2_xpyp_implicit_stats. 2022-03-16 15:18:23 -05003efae613c219a686eeeaf53617e8c24304fb24abMoving the lhs_dp1 calculation to outside of xp2_xpyp_lhs. This gives us more flexibility, since we want to pass lhs_dp1 into xp2_xpyp_implicit_stats.editsrc/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/advance_xp2_xpyp_module.F90eefc4e8b7a13d7eaf2e6ccbc0b2b0f9a677166ef1647461903000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comMoving the lmm_stepping and stats calls to immediately after calls to xp2_xpyp_solve. This is because xp2_xpyp_implicit_stats saves things that are saved by scratch variables, and these scratch variables are set by the lhs and rhs setup calls. So for the multiple lhs routine, we need to save the scratch variables immediately after these calls before overwriting them by calling lhs and rhs again for a different variable. Since the stats also saves the variable were solving for, we also have to move the lmm_stepping to before this call. 2022-03-16 15:18:23 -0500eefc4e8b7a13d7eaf2e6ccbc0b2b0f9a677166efMoving the lmm_stepping and stats calls to immediately after calls to xp2_xpyp_solve. This is because xp2_xpyp_implicit_stats saves things that are saved by scratch variables, and these scratch variables are set by the lhs and rhs setup calls. So for the multiple lhs routine, we need to save the scratch variables immediately after these calls before overwriting them by calling lhs and rhs again for a different variable. Since the stats also saves the variable were solving for, we also have to move the lmm_stepping to before this call.editsrc/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/advance_xp2_xpyp_module.F9081be36dbac0aa39981bed980966bece2baed5ecb1647461903000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comRemoving need for stats scratch variables by passing lhs terms to save through agument lists. This makes everything better in every way. 2022-03-16 15:18:23 -050081be36dbac0aa39981bed980966bece2baed5ecbRemoving need for stats scratch variables by passing lhs terms to save through agument lists. This makes everything better in every way.editsrc/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/advance_xp2_xpyp_module.F90757d6ea41b756a86b891b30e5d7de3d0e40674281647461903000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comAdding slicing for some lhs arrays being saved in stats. This was causing bit changing in a few lhs terms when run in multicolumn. 2022-03-16 15:18:23 -0500757d6ea41b756a86b891b30e5d7de3d0e4067428Adding slicing for some lhs arrays being saved in stats. This was causing bit changing in a few lhs terms when run in multicolumn.editsrc/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/advance_xp2_xpyp_module.F90e92c73005948d5698d3a2eada6c8a2881bb414141647461903000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comChanging names of dp1 variables for up2 and vp2. Surrounding where they're set to be within a l_stats_samp. 2022-03-16 15:18:23 -0500e92c73005948d5698d3a2eada6c8a2881bb41414Changing names of dp1 variables for up2 and vp2. Surrounding where they're set to be within a l_stats_samp.editsrc/CLUBB_core/advance_xp2_xpyp_module.F90READMEafafe6ff1798e19d664aa0153d148814cd53c1721647894946000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemoving a line at the top of the README to trigger the nightly tests. 2022-03-21 15:35:46 -0500afafe6ff1798e19d664aa0153d148814cd53c172Removing a line at the top of the README to trigger the nightly tests.editREADMEREADME29c1bb840079d4030b27a37631bfe3cbbf380d041648061021000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdding a line to the README to trigger the nightly tests. 2022-03-23 13:43:41 -050029c1bb840079d4030b27a37631bfe3cbbf380d04Adding a line to the README to trigger the nightly tests.editREADMEsrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/model_flags.F90src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F90src/G_unit_test_types/pdf_parameter_tests.F90input/tunable_parameters_compatible_r8029/configurable_model_flags.ininput/tunable_parameters/configurable_model_flags.insrc/clubb_tuner.F90e63d361593282937950c000aa56281fe1331f04b1648248221000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added l_relax_clipping to CLUBB's config flags. 2022-03-25 17:43:41 -0500e63d361593282937950c000aa56281fe1331f04bI added l_relax_clipping to CLUBB's config flags.editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/clubb_tuner.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90editinput/tunable_parameters/configurable_model_flags.ineditinput/tunable_parameters_compatible_r8029/configurable_model_flags.ineditsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/model_flags.F90editsrc/clubb_driver.F90src/CLUBB_core/advance_clubb_core_module.F90src/clubb_standalone.F90src/CLUBB_core/parameters_tunable.F90src/jacobian.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/clubb_api_module.F90input/tunable_parameters_compatible_r8029/tunable_parameters.insrc/G_unit_test_types/pdf_parameter_tests.F90input/tunable_parameters/tunable_parameters.insrc/clubb_thread_test.F90src/error.F90src/CLUBB_core/parameter_indices.F9096059a242e69c4e7ed340487ee6b7e4239c335411648591498000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAdded a3_coef_min to the list of CLUBB's tunable parameter and then commented-in the a3_coef clipping line found in advance_clubb_core.F90. The results of this revision are bit-for-bit. 2022-03-29 17:04:58 -050096059a242e69c4e7ed340487ee6b7e4239c33541Added a3_coef_min to the list of CLUBB's tunable parameter and theneditsrc/G_unit_test_types/pdf_parameter_tests.F90editinput/tunable_parameters_compatible_r8029/tunable_parameters.ineditsrc/clubb_thread_test.F90editsrc/G_unit_test_types/spurious_source_test.F90editsrc/clubb_standalone.F90editsrc/error.F90editsrc/CLUBB_core/parameters_tunable.F90editinput/tunable_parameters/tunable_parameters.ineditsrc/CLUBB_core/parameter_indices.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/jacobian.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/clubb_api_module.F90src/clubb_driver.F90d0c9b3461825ae93070b9286d743bb6c260672f51649199568000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAdded idiot-proofing to print a warning message when l_diag_Lscale_from_tau is being used and C1, C1b, C2rt, C2thl, C2rtthl, C6rt, C6rtb, C6thl, C6thlb, or C14 do not have a value 1. This can later be upgraded to a fatal error when we can finally run this code with the C2 and C6 families of parameters having a value of 1 (that value is currently 2 right now). 2022-04-05 17:59:28 -0500d0c9b3461825ae93070b9286d743bb6c260672f5Added idiot-proofing to print a warning message when l_diag_Lscale_from_taueditsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/clubb_driver.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/clubb_precision.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/clubb_driver.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/model_flags.F90src/CLUBB_core/clubb_api_module.F90src/G_unit_test_types/pdf_parameter_tests.F90src/CLUBB_core/clip_explicit.F90input/tunable_parameters/configurable_model_flags.insrc/clubb_tuner.F9070e286f86102af741c96a104bc69d0e40dcd66ad1649805129000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added the code for the l_linearize_pbl_winds flag that was originally brought to us by Sean Santos 2022-04-12 18:12:09 -050070e286f86102af741c96a104bc69d0e40dcd66adI added the code for the l_linearize_pbl_winds flag that was originallyeditsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/clubb_precision.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90editinput/tunable_parameters/configurable_model_flags.ineditsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/clip_explicit.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/model_flags.F90editsrc/clubb_tuner.F90postprocessing/pyplotgen/README.md9e84a8e6f9f754e0c697de8a3e707182119726481649942904000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdates description of generating pyplotgen movies 2022-04-14 08:28:24 -05009e84a8e6f9f754e0c697de8a3e70718211972648Updates description of generating pyplotgen movieseditpostprocessing/pyplotgen/README.mdpostprocessing/pyplotgen/config/VariableGroupNondimMoments.py86d4dab13e697291f9e7d5fa111f2f22334b9cb41649943098000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comSet the Priority of nondimensional moments to False. 2022-04-14 08:31:38 -050086d4dab13e697291f9e7d5fa111f2f22334b9cb4Set the Priority of nondimensional moments to False.editpostprocessing/pyplotgen/config/VariableGroupNondimMoments.pysrc/CLUBB_core/advance_xp2_xpyp_module.F90c17af720a34b9aef16110c94baea2ec1702395031650572938000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comGunthers branch (#996) * Pushing column loop into xm_wpxp_clipping_and_stats and monotonic_turbulent_flux_limit. This essentially completes advance_xm_wpxp for now. larson-group/clubb#972 * Replacing the i loop iterator for scalars with sclr. * Pushing loop into advance_xp2_wpxp. * Moving the lhs_dp1 calculation to outside of xp2_xpyp_lhs. This gives us more flexibility, since we want to pass lhs_dp1 into xp2_xpyp_implicit_stats. * Moving the lmm_stepping and stats calls to immediately after calls to xp2_xpyp_solve. This is because xp2_xpyp_implicit_stats saves things that are saved by scratch variables, and these scratch variables are set by the lhs and rhs setup calls. So for the multiple lhs routine, we need to save the scratch variables immediately after these calls before overwriting them by calling lhs and rhs again for a different variable. Since the stats also saves the variable were solving for, we also have to move the lmm_stepping to before this call. * Removing need for stats scratch variables by passing lhs terms to save through agument lists. This makes everything better in every way. * Adding slicing for some lhs arrays being saved in stats. This was causing bit changing in a few lhs terms when run in multicolumn. * Changing names of dp1 variables for up2 and vp2. Surrounding where they're set to be within a l_stats_samp. * Breaking up column loop in advance_xp2_xpyp and pushing column loop into calc_xp2_xpyp_ta_terms. larson-group/cam#972 * Breaking up column loop in calc_xp2_xpyp_ta_terms. * Pushing loop into solve_xp2_xpyp_with_single_lhs. * Fixing mangled merge. * Pushing loops down. * Pushing loops and small cleanup. 2022-04-21 15:28:58 -0500c17af720a34b9aef16110c94baea2ec170239503Gunthers branch (#996)editsrc/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/pdf_utilities.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/advance_xp2_xpyp_module.F90d3faa9d37dcff5f454b172030888fa0910a5a05f1650918954000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduVarious simple changes to improve performance. All bit-for-bit. 2022-04-25 15:35:54 -0500d3faa9d37dcff5f454b172030888fa0910a5a05fVarious simple changes to improve performance. All bit-for-bit.editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/pdf_utilities.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_helper_module.F90b54a633867c820ee25b87dbd63990a5ecde66e561650919440000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing loop into calc_stability_correction. 2022-04-25 15:44:00 -0500b54a633867c820ee25b87dbd63990a5ecde66e56Pushing loop into calc_stability_correction.editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_helper_module.F90src/CLUBB_core/advance_xp2_xpyp_module.F90994bc4819ac0393894d4f8e6e152b3027236ff781650992705000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSmall bug fix. 2022-04-26 12:05:05 -0500994bc4819ac0393894d4f8e6e152b3027236ff78Small bug fix.editsrc/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/advance_xp2_xpyp_module.F90a195ada124b64223daa6c02d5e6521fa81558dee1650994055000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAnother similar small bug fix. 2022-04-26 12:27:35 -0500a195ada124b64223daa6c02d5e6521fa81558deeAnother similar small bug fix.editsrc/CLUBB_core/advance_xp2_xpyp_module.F90postprocessing/pyplotgen/src/VariableGroup.pypostprocessing/pyplotgen/pyplotgen.pyc84772d6afdb29b3180d8965419b2f132ec127761651340012000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@users.noreply.github.comFixed priority property not working as intended, added text indicating time span plotted in pdf files which was previously only displayed in html files. 2022-04-30 12:33:32 -0500c84772d6afdb29b3180d8965419b2f132ec12776Fixed priority property not working as intended, added text indicating time span plotted in pdf files which was previously only displayed in html files.editpostprocessing/pyplotgen/src/VariableGroup.pyeditpostprocessing/pyplotgen/pyplotgen.pysrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90e7d02635c49b9f501e0a96693b5ed4b28a9a50601651606634000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comGunthers branch (#999) * Reworking the flow to make it good. * Cleaning up. * Pushing loop into advance_xp2_wpxp. * Forgot to commit advance_clubb_core. * Slight improvement to logic of lhs_diff_zm_crank calculation, and fixing stats but present when lhs_diff_zm_crank=true. * Pushing lots of loops down. * Changing dimension ordering. * Cleaning up. This completes advance_wp2_wp3. larson-group/clubb#972 * Changing capitalization of intents. 2022-05-03 14:37:14 -0500e7d02635c49b9f501e0a96693b5ed4b28a9a5060Gunthers branch (#999)editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/advance_helper_module.F90src/G_unit_test_types/smooth_heaviside_tests.F90src/CLUBB_core/mixing_length.F90src/G_unit_test_types/smooth_min_max_tests.F909f4f3e3ea562b7f569f6bd38a0c5f7b1d10613511651762515000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comRenamed smth_range to heaviside_smth_range 2022-05-05 09:55:15 -05009f4f3e3ea562b7f569f6bd38a0c5f7b1d1061351Renamed smth_range to heaviside_smth_rangeeditsrc/CLUBB_core/advance_helper_module.F90editsrc/G_unit_test_types/smooth_heaviside_tests.F90editsrc/G_unit_test_types/smooth_min_max_tests.F90editsrc/CLUBB_core/mixing_length.F90postprocessing/pyplotgen/src/VariableGroupNormalizedVariations.pysrc/CLUBB_core/stats_sfc_module.F90src/CLUBB_core/advance_helper_module.F90src/CLUBB_core/stats_variables.F90src/CLUBB_core/stats_clubb_utilities.F90input/stats/all_stats.in092e54d2d3f09a31a6abf3676d3c2b55800746d81651762515000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comAdded tot_vartn_normlzd statistics. Renamed sclr in advance_helper_module to scalar to be more consistent with clubb naming schemes. 2022-05-05 09:55:15 -0500092e54d2d3f09a31a6abf3676d3c2b55800746d8Added tot_vartn_normlzd statistics. Renamed sclr in advance_helper_module to scalar to be more consistent with clubb naming schemes.addpostprocessing/pyplotgen/src/VariableGroupNormalizedVariations.pyeditsrc/CLUBB_core/stats_variables.F90editinput/stats/all_stats.ineditsrc/CLUBB_core/stats_sfc_module.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/stats_clubb_utilities.F90src/CLUBB_core/stats_sfc_module.F90postprocessing/pyplotgen/config/VariableGroupNormalizedVariations.pyinput/stats/standard_stats.insrc/CLUBB_core/stats_variables.F90src/CLUBB_core/stats_clubb_utilities.F90b80c7ffecbf3e77a22642095f8389c1ecd33948d1651762515000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comImplemented three further normalized variation stats. Included a (most likely temporary) check because in a few cases, denominator for normalization would be 0. 2022-05-05 09:55:15 -0500b80c7ffecbf3e77a22642095f8389c1ecd33948dImplemented three further normalized variation stats. Included a (most likely temporary) check because in a few cases, denominator for normalization would be 0.editsrc/CLUBB_core/stats_clubb_utilities.F90editsrc/CLUBB_core/stats_variables.F90addpostprocessing/pyplotgen/config/VariableGroupNormalizedVariations.pyeditsrc/CLUBB_core/stats_sfc_module.F90editinput/stats/standard_stats.inpostprocessing/pyplotgen/pyplotgen.pyfde70b39d01dd19b96d21b2a0adef57a8ac80af11651762515000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comFixed typo in pyplotgen and fixed display of plotted time (previously displayed on the wrong line). 2022-05-05 09:55:15 -0500fde70b39d01dd19b96d21b2a0adef57a8ac80af1Fixed typo in pyplotgen and fixed display of plotted time (previously displayed on the wrong line).editpostprocessing/pyplotgen/pyplotgen.pypostprocessing/pyplotgen/python_html_gallery/static.pypostprocessing/pyplotgen/python_html_gallery/gallery.pypostprocessing/pyplotgen/python_html_gallery/static_varbles.pypostprocessing/pyplotgen/pyplotgen.py748152eb582f6e4543edc8e975e6be8eaba48b431651762515000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comDealt with issue https://github.com/larson-group/clubb/issues/985 2022-05-05 09:55:15 -0500748152eb582f6e4543edc8e975e6be8eaba48b43Dealt with issue https://github.com/larson-group/clubb/issues/985deletepostprocessing/pyplotgen/python_html_gallery/static.pyeditpostprocessing/pyplotgen/pyplotgen.pyeditpostprocessing/pyplotgen/python_html_gallery/gallery.pyaddpostprocessing/pyplotgen/python_html_gallery/static_varbles.pypostprocessing/pyplotgen/config/VariableGroupNormalizedVariations.pysrc/CLUBB_core/stats_clubb_utilities.F908ab8776d665a945b4be75d9e2cc00a2223217b0e1651762515000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comChanged priorities of total normalized variation stats, included error handling in total normalized variation stats. 2022-05-05 09:55:15 -05008ab8776d665a945b4be75d9e2cc00a2223217b0eChanged priorities of total normalized variation stats, included error handling in total normalized variation stats.editpostprocessing/pyplotgen/config/VariableGroupNormalizedVariations.pyeditsrc/CLUBB_core/stats_clubb_utilities.F90postprocessing/pyplotgen/src/VariableGroupNormalizedVariations.pyf0dff4bcf48e5bf267edb8e706e9455f503400f91651762515000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comRemoved duplicate VariableGroupNormalizedVariations.py 2022-05-05 09:55:15 -0500f0dff4bcf48e5bf267edb8e706e9455f503400f9Removed duplicate VariableGroupNormalizedVariations.pydeletepostprocessing/pyplotgen/src/VariableGroupNormalizedVariations.pysrc/CLUBB_core/stats_clubb_utilities.F90postprocessing/pyplotgen/pyplotgen.pye33520905201193174b52f9316fa5ac2ca799af11651762515000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comRenamed pdf_output_filename. Added grid_level constant to avoid magic numbers in stats_update_var_pt calls. 2022-05-05 09:55:15 -0500e33520905201193174b52f9316fa5ac2ca799af1Renamed pdf_output_filename. Added grid_level constant to avoid magic numbers in stats_update_var_pt calls.editsrc/CLUBB_core/stats_clubb_utilities.F90editpostprocessing/pyplotgen/pyplotgen.pysrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/CLUBB_core/advance_helper_module.F90src/CLUBB_core/clubb_api_module.F90src/advance_microphys_module.F90src/CLUBB_core/setup_clubb_pdf_params.F90ff0b28e5052ca104fd67313e5e9759d6f7f802381651782038000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comGunthers branch 2 (#1002) * Pushing loop down through advance_windm. Other files needed to be touched because they were using a simple function, xpwp_func, which has been replaced in relevenant places by the few lines of code it takes to do. * Cleaned up intents * Moving xpwp calcuations back to procedure, but making procedure a 1/2D interface in advance helper. Other various small tweaks as well. 2022-05-05 15:20:38 -0500ff0b28e5052ca104fd67313e5e9759d6f7f80238Gunthers branch 2 (#1002)editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/advance_microphys_module.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/CLUBB_core/setup_clubb_pdf_params.F90postprocessing/pyplotgen/config/Case_definitions.pysrc/CLUBB_core/stats_clubb_utilities.F903e2c65368a75545b887c4bd29875345ff56bee7a1651782218000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comBugfix for merge #1000. stderr was not imported in stat_clubb_utilities.F90, causing compilation to fail. 2022-05-05 15:23:38 -05003e2c65368a75545b887c4bd29875345ff56bee7aBugfix for merge #1000. stderr was not imported in stat_clubb_utilities.F90, causing compilation to fail.editpostprocessing/pyplotgen/config/Case_definitions.pyeditsrc/CLUBB_core/stats_clubb_utilities.F90jenkins_tests/clubb_restart_silhs_gfortran_test/Jenkinsfilejenkins_tests/clubb_timestep_gfortran_tests/Jenkinsfilejenkins_tests/clubb_api_commitment_test/Jenkinsfilejenkins_tests/clubb_bin_diff_regression_gfortran_test_new/Jenkinsfilejenkins_tests/clubb_bin_diff_regression_gfortran_test/Jenkinsfilejenkins_tests/clubb_G_unit_gfortran_tests/Jenkinsfilejenkins_tests/clubb_bin_diff_regression_e3sm_flags_gfortran/Jenkinsfilejenkins_tests/clubb_bin_diff_regression_backwards_compatibility_gfortran_test/Jenkinsfilejenkins_tests/clubb_ifort_build/Jenkinsfilejenkins_tests/clubb_error_handling_gfortran_test/Jenkinsfilejenkins_tests/clubb_fire_tuning_gfortran_test/Jenkinsfilejenkins_tests/clubb_timestep_convergence_gfortran_test/Jenkinsfilejenkins_tests/clubb_pgi_build/Jenkinsfilejenkins_tests/clubb_gfortran_build/Jenkinsfilejenkins_tests/clubb_restart_gfortran_test/Jenkinsfilejenkins_tests/clubb_release_diff_test/Jenkinsfilejenkins_tests/clubb_mac_gfortran_test/Jenkinsfilejenkins_tests/clubb_uninit_var_oracle_test/Jenkinsfilejenkins_tests/clubb_openmp_gfortran_test/Jenkinsfilejenkins_tests/clubb_release_intel_build/Jenkinsfilejenkins_tests/clubb_backwards_compatibility_gfortran_test/Jenkinsfilejenkins_tests/clubb_silhs_convergence_gfortran/Jenkinsfilejenkins_tests/clubb_check_budget_balance_gfortran/Jenkinsfileb518f7f0bbb4edc5825b926c8dcfa4ca54a4a3ce1652301485000http://carson.math.uwm.edu/jenkins/user/pbroelspbroelspbroels@uwm.eduAdding comments to explain confusing or complicated portions of the Jenkinsfiles. 2022-05-11 15:38:05 -0500b518f7f0bbb4edc5825b926c8dcfa4ca54a4a3ceAdding comments to explain confusing or complicated portions of the Jenkinsfiles.editjenkins_tests/clubb_gfortran_build/Jenkinsfileeditjenkins_tests/clubb_release_intel_build/Jenkinsfileeditjenkins_tests/clubb_restart_gfortran_test/Jenkinsfileeditjenkins_tests/clubb_restart_silhs_gfortran_test/Jenkinsfileeditjenkins_tests/clubb_error_handling_gfortran_test/Jenkinsfileeditjenkins_tests/clubb_openmp_gfortran_test/Jenkinsfileeditjenkins_tests/clubb_backwards_compatibility_gfortran_test/Jenkinsfileeditjenkins_tests/clubb_pgi_build/Jenkinsfileeditjenkins_tests/clubb_ifort_build/Jenkinsfileeditjenkins_tests/clubb_api_commitment_test/Jenkinsfileeditjenkins_tests/clubb_timestep_convergence_gfortran_test/Jenkinsfileeditjenkins_tests/clubb_bin_diff_regression_e3sm_flags_gfortran/Jenkinsfileeditjenkins_tests/clubb_G_unit_gfortran_tests/Jenkinsfileeditjenkins_tests/clubb_bin_diff_regression_gfortran_test_new/Jenkinsfileeditjenkins_tests/clubb_uninit_var_oracle_test/Jenkinsfileeditjenkins_tests/clubb_timestep_gfortran_tests/Jenkinsfileeditjenkins_tests/clubb_bin_diff_regression_backwards_compatibility_gfortran_test/Jenkinsfileeditjenkins_tests/clubb_bin_diff_regression_gfortran_test/Jenkinsfileeditjenkins_tests/clubb_fire_tuning_gfortran_test/Jenkinsfileeditjenkins_tests/clubb_silhs_convergence_gfortran/Jenkinsfileeditjenkins_tests/clubb_check_budget_balance_gfortran/Jenkinsfileeditjenkins_tests/clubb_release_diff_test/Jenkinsfileeditjenkins_tests/clubb_mac_gfortran_test/Jenkinsfilesrc/CLUBB_core/advance_helper_module.F90src/CLUBB_core/mixing_length.F90ca240e9d33d4faf380b8e75f910d20048a406a801652459498000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comAdded ability to apply smooth min max functions in mixing_length.F90 2022-05-13 11:31:38 -0500ca240e9d33d4faf380b8e75f910d20048a406a80Added ability to apply smooth min max functions in mixing_length.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/mixing_length.F90src/CLUBB_core/advance_helper_module.F906efeb9d26bd42ce5c02979da7625eaf6381ab7541652459498000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comUpdated deprecated documentation of smooth min and max functions in advance_helper_module.F90. https://github.com/larson-group/clubb/issues/965 2022-05-13 11:31:38 -05006efeb9d26bd42ce5c02979da7625eaf6381ab754Updated deprecated documentation of smooth min and max functions in advance_helper_module.F90. https://github.com/larson-group/clubb/issues/965editsrc/CLUBB_core/advance_helper_module.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/advance_helper_module.F9025b7981de0964d1e329b0a5b3020eef20e0144f61652459498000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comChecked whether results really are identical even with round-off when we have l_smooth_min_max=T and smooth_min_max_mag=zero. Next commit rolls some of these changes back for merge into master. https://github.com/larson-group/clubb/issues/965 2022-05-13 11:31:38 -050025b7981de0964d1e329b0a5b3020eef20e0144f6Checked whether results really are identical even with round-off when we have l_smooth_min_max=T and smooth_min_max_mag=zero. Next commit rolls some of these changes back for merge into master. https://github.com/larson-group/clubb/issues/965editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/advance_helper_module.F90src/CLUBB_core/mixing_length.F90src/G_unit_test_types/smooth_min_max_tests.F900ac05189208ed736ed02f36c1fe97544aeca72f31652459498000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comAdded test cases to smooth_min_max_tests.F90 and updated documentation. 2022-05-13 11:31:38 -05000ac05189208ed736ed02f36c1fe97544aeca72f3Added test cases to smooth_min_max_tests.F90 and updated documentation.editsrc/CLUBB_core/mixing_length.F90editsrc/G_unit_test_types/smooth_min_max_tests.F90src/G_unit_test_types/smooth_min_max_tests.F908d94590933307afaad66bdbc5676fe46de9629771652459498000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comAdded final test cases to smooth_min_max_tests.F90 2022-05-13 11:31:38 -05008d94590933307afaad66bdbc5676fe46de962977Added final test cases to smooth_min_max_tests.F90editsrc/G_unit_test_types/smooth_min_max_tests.F90utilities/sens_matrix/sens_matrix_dashboard.pyutilities/sens_matrix/analyze_sensitivity_matrix.py7181829d98a85d065dcbaf00186c35b5ea02366a1652712094000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduAdd to tuning dashboard some plots of biases vs. sensitivity. Also add a function to calculate maximum parameter perturbations based on the non-linearity of the global model. Also add a function to create a PCA biplot. For #910. 2022-05-16 09:41:34 -05007181829d98a85d065dcbaf00186c35b5ea02366aAdd to tuning dashboard some plots of biases vs. sensitivity.editutilities/sens_matrix/sens_matrix_dashboard.pyeditutilities/sens_matrix/analyze_sensitivity_matrix.pyutilities/sens_matrix/sens_matrix_dashboard.py28c9f9808264281ffed05ea834d78b770bbb15b61652796212000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@users.noreply.github.comUpdate sens_matrix_dashboard.py New observations 2022-05-17 09:03:32 -050028c9f9808264281ffed05ea834d78b770bbb15b6Update sens_matrix_dashboard.pyeditutilities/sens_matrix/sens_matrix_dashboard.pyinput/case_setups/neutral_sclr_sounding.insrc/clubb_driver.F90input/case_setups/neutral_edsclr_sounding.ininput/case_setups/neutral_sounding.inpostprocessing/pyplotgen/config/Case_definitions.pyinput/case_setups/neutral_sfc.insrc/Benchmark_cases/neutral_case.F90input/grid/neutral_case.grdcompile/file_list/clubb_model_filesinput/case_setups/wangara_model.ininput/case_setups/neutral_model.in4e6f0ac7f5463f25a413eda3532505ce63c895bc1652827899000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd shear/neutral case (#1005) * Adding files and modifications necessary to the new shear-driven, neutral case. This case is adapted from George Bryan's shear-driven case from CM1, which is based on Moeng and Sullivan 1994. * Small fixes in new shear case setup file. * Renaming new case from shear_driven to neutral, and other changes as requested in pull request https://github.com/larson-group/clubb/pull/1005. See also https://github.com/larson-group/clubb/issues/991. 2022-05-17 16:51:39 -06004e6f0ac7f5463f25a413eda3532505ce63c895bcAdd shear/neutral case (#1005)addinput/grid/neutral_case.grdaddinput/case_setups/neutral_edsclr_sounding.inaddsrc/Benchmark_cases/neutral_case.F90editcompile/file_list/clubb_model_filesaddinput/case_setups/neutral_sounding.ineditsrc/clubb_driver.F90addinput/case_setups/neutral_sclr_sounding.inaddinput/case_setups/neutral_model.ineditinput/case_setups/wangara_model.ineditpostprocessing/pyplotgen/config/Case_definitions.pyaddinput/case_setups/neutral_sfc.inpostprocessing/pyplotgen/config/VariableGroupSamBudgets.pypostprocessing/pyplotgen/config/VariableGroupBaseBudgetsSamStyle.pypostprocessing/pyplotgen/config/VariableGroupBaseBudgets.pyab7e66218f8dd663d15e9a59fe87c6e922d829ca1652992441000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@users.noreply.github.comChanged priorities on pyplotgen variables. In a priority run, by default only the variables in VariableGroupBase.py will be plotted. This explicitly does not include variables in VariableGroupBaseBudgets, which would have to be included explicitly when desired. 2022-05-19 15:34:01 -0500ab7e66218f8dd663d15e9a59fe87c6e922d829caChanged priorities on pyplotgen variables. In a priority run, by default only the variables in VariableGroupBase.py will be plotted. This explicitly does not include variables in VariableGroupBaseBudgets, which would have to be included explicitly when desired.editpostprocessing/pyplotgen/config/VariableGroupBaseBudgetsSamStyle.pyeditpostprocessing/pyplotgen/config/VariableGroupSamBudgets.pyeditpostprocessing/pyplotgen/config/VariableGroupBaseBudgets.pysrc/KK_microphys/PDF_integrals_means.F9022a1c3ef04adb309140d44ce51708fba1bf202de1653003845000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAdding some description that should have been entered a very long time ago. I think I'm going to peck away at some of these over time. 2022-05-19 18:44:05 -050022a1c3ef04adb309140d44ce51708fba1bf202deAdding some description that should have been entered a very longeditsrc/KK_microphys/PDF_integrals_means.F90postprocessing/pyplotgen/config/Case_definitions.pyfe8bcaf11039a67da4e7ff7982abaed5f15263101653508580000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comCorrecting name of old "shear" case to "neutral" in pyplotgen config file. Also adding benchmark file path. See https://github.com/larson-group/clubb/issues/991. 2022-05-25 14:56:20 -0500fe8bcaf11039a67da4e7ff7982abaed5f1526310Correcting name of old "shear" case to "neutral" in pyplotgen config file. Also adding benchmark file path.editpostprocessing/pyplotgen/config/Case_definitions.pycompile/config/macosx_x86_64_gfortran.bashf2e53a3318bfcb628181e5130b3318104e651b571653508739000http://carson.math.uwm.edu/jenkins/user/pbroelspbroelspbroels@uwm.eduAdding changes to work on new Mac Mini. larson-group/sys_admin#775 2022-05-25 14:58:59 -0500f2e53a3318bfcb628181e5130b3318104e651b57Adding changes to work on new Mac Mini. larson-group/sys_admin#775editcompile/config/macosx_x86_64_gfortran.bashpostprocessing/pyplotgen/config/Case_definitions.pyb12b3745d190c33528b339da6abbee24f854bf7a1653511416000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comMissed a place where I needed to rename shear case to neutral. 2022-05-25 14:43:36 -0600b12b3745d190c33528b339da6abbee24f854bf7aMissed a place where I needed to rename shear case to neutral.editpostprocessing/pyplotgen/config/Case_definitions.pysrc/SILHS/latin_hypercube_driver_module.F90src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/setup_clubb_pdf_params.F90src/SILHS/silhs_api_module.F90e4f125ba067ba8083f917e0e06b6b2398483d3e41653690057000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comConstructing rcm within SILHS (as rcm_pdf) (#1011) * Constructing rcm within SILHS (as rcm_pdf) to avoid having to pass rcm directly to SILHS. Relevant to possibly moving PDF call placement into the "post" position in CAM. See https://github.com/ESCOMP/CAM/issues/582. * Reconstructing rcm inside of setup_pdf_parameters instead of passing it through the argument lists. Might help NCAR move the PDF call placement to "post" position in CAM. See https://github.com/larson-group/clubb/issues/997. * Adding descriptive comment. 2022-05-27 16:20:57 -0600e4f125ba067ba8083f917e0e06b6b2398483d3e4Constructing rcm within SILHS (as rcm_pdf) (#1011)editsrc/SILHS/latin_hypercube_driver_module.F90editsrc/CLUBB_core/setup_clubb_pdf_params.F90editsrc/SILHS/silhs_api_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/clubb_driver.F90src/CLUBB_core/new_hybrid_pdf_main.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/advance_xp3_module.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/grid_class.F90src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90src/CLUBB_core/sponge_layer_damping.F90src/CLUBB_core/stats_type_utilities.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/microphys_driver.F90src/advance_microphys_module.F90src/CLUBB_core/stats_clubb_utilities.F90src/CLUBB_core/mono_flux_limiter.F90src/G_unit_test_types/pdf_parameter_tests.F90src/CLUBB_core/advance_helper_module.F90src/CLUBB_core/new_tsdadg_pdf.F90src/CLUBB_core/LY93_pdf.F90src/CLUBB_core/clip_explicit.F90src/CLUBB_core/numerical_check.F90src/CLUBB_core/new_pdf.F90src/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/turbulent_adv_pdf.F90src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/setup_clubb_pdf_params.F90src/CLUBB_core/fill_holes.F90src/CLUBB_core/new_pdf_main.F90src/CLUBB_core/pos_definite_module.F90e8deb21c70b21643aee441c04fa17278ac8d7c911654031468000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAlmost final loop pushes (#1012) * Pushing loop into clip_rcm * Pushing column loop into trapezoid routines. * Pushing column loop into clip_covar routines. * Pushing column loop into clip_variance and clip_skewness. * Replacing sgn_turbulent_velocity with built in fortran sign * Removing gr from argument list of stats calls, replacing with just nz * Replacing some usages of gr with just the number of vertical levels * Replacing some usages of gr with just the number of vertical levels again * Missed a couple files to commit * Pushing some loops and removing need for gr to be passed into some routines. * Pushing loop into advance_xp3 * Pushing loop into mixing length * Some more loop pushing * Pushing some loops into mono_flux limit, skipping the lhs routine since it's a bit tricky at the moment, will do after change to grid class. * Removing gr from argument list of stats accumulate * Precalculating zt2zm so that we can use 2d version * Precalculating um/vm ddzt so that we can use 2d version * Precalculating things to use 2d version of zt2zm * Making 2d version of cubic interp for grid class * Small modifications to sponge damping code argument lists * Renaming some variables 2022-05-31 16:11:08 -0500e8deb21c70b21643aee441c04fa17278ac8d7c91Almost final loop pushes (#1012)editsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90editsrc/CLUBB_core/new_pdf_main.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/grid_class.F90editsrc/CLUBB_core/new_tsdadg_pdf.F90editsrc/CLUBB_core/setup_clubb_pdf_params.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/new_hybrid_pdf_main.F90editsrc/CLUBB_core/numerical_check.F90editsrc/CLUBB_core/sponge_layer_damping.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/new_pdf.F90editsrc/CLUBB_core/stats_type_utilities.F90editsrc/CLUBB_core/LY93_pdf.F90editsrc/CLUBB_core/fill_holes.F90editsrc/CLUBB_core/mono_flux_limiter.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/pos_definite_module.F90editsrc/CLUBB_core/clip_explicit.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/turbulent_adv_pdf.F90editsrc/CLUBB_core/stats_clubb_utilities.F90editsrc/advance_microphys_module.F90editsrc/CLUBB_core/advance_xp3_module.F90editsrc/microphys_driver.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/CLUBB_core/mixing_length.F90microphysics.F907a9a332ece44f0a0ee2210d5fa63d63fb93a19b81654040073000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking compatible with latest clubb change. 2022-05-31 18:34:33 -05007a9a332ece44f0a0ee2210d5fa63d63fb93a19b8Making compatible with latest clubb change.editmicrophysics.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/new_hybrid_pdf_main.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/clubb_driver.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/clubb_api_module.F90src/G_unit_test_types/pdf_parameter_tests.F90src/CLUBB_core/new_pdf_main.F90src/CLUBB_core/pdf_parameter_module.F90src/CLUBB_core/advance_xp2_xpyp_module.F901e537bac5d385007334ca3a6f2b16a17ae0016e21654040788000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comMaking pdf_implicit_coefs_terms a type containing 2D arrays. (#1014) 2022-05-31 18:46:28 -05001e537bac5d385007334ca3a6f2b16a17ae0016e2Making pdf_implicit_coefs_terms a type containing 2D arrays. (#1014)editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/new_hybrid_pdf_main.F90editsrc/CLUBB_core/new_pdf_main.F90editsrc/CLUBB_core/pdf_parameter_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/G_unit_test_types/spurious_source_test.F90jenkins_tests/clubb_bin_diff_regression_gfortran_test_new/Jenkinsfilejenkins_tests/clubb_bin_diff_regression_gfortran_test/Jenkinsfilejenkins_tests/clubb_bin_diff_regression_gfortran_test_old/Jenkinsfiled3e945d16e887b46b07827c135f73d33831fa9001654109323000http://carson.math.uwm.edu/jenkins/user/pbroelspbroelspbroels@uwm.eduChanged clubb_bin_diff_regression_gfortran_test_new to clubb_bin_diff_regression_gfortran_test and clubb_bin_diff_regression_gfortran_test to clubb_bin_diff_regression_gfortran_test_old to reflect current usage. 2022-06-01 13:48:43 -0500d3e945d16e887b46b07827c135f73d33831fa900Changed clubb_bin_diff_regression_gfortran_test_new to clubb_bin_diff_regression_gfortran_test and clubb_bin_diff_regression_gfortran_test to clubb_bin_diff_regression_gfortran_test_old to reflect current usage.deletejenkins_tests/clubb_bin_diff_regression_gfortran_test_new/Jenkinsfileeditjenkins_tests/clubb_bin_diff_regression_gfortran_test/Jenkinsfileaddjenkins_tests/clubb_bin_diff_regression_gfortran_test_old/JenkinsfileREADME291e87da51321a48b5c9d5c46e6b4459b51ab2a41654109959000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comThis commit is not bit changing 2022-06-01 13:59:19 -0500291e87da51321a48b5c9d5c46e6b4459b51ab2a4This commit is not bit changingeditREADMEREADME0ff480f574ef756272df942a2cd6e217fba760e21654110299000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comThis commt is not bit changing But commit e4f125ba067ba8083f917e0e06b6b2398483d3e4 was BIT_CHANGING for simulations that use silhs 2022-06-01 14:04:59 -05000ff480f574ef756272df942a2cd6e217fba760e2This commt is not bit changingeditREADMEsrc/CLUBB_core/new_hybrid_pdf_main.F90src/G_unit_test_types/pdf_parameter_tests.F90src/CLUBB_core/new_pdf_main.F90src/G_unit_test_types/spurious_source_test.F90aa26820b4f080d4a8721dd0f578737344061f9a31654112656000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduThe G_unit tests never allocated pdf_implicit_coefs_terms. It's unclear to me how these were working before, but it seems that something about making these 2D allocatable arrays exposed the bug. 2022-06-01 14:44:16 -0500aa26820b4f080d4a8721dd0f578737344061f9a3The G_unit tests never allocated pdf_implicit_coefs_terms. It's unclear to me how these were working before, but it seems that something about making these 2D allocatable arrays exposed the bug.editsrc/CLUBB_core/new_hybrid_pdf_main.F90editsrc/CLUBB_core/new_pdf_main.F90editsrc/G_unit_test_types/spurious_source_test.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90src/CLUBB_core/advance_xp2_xpyp_module.F90b736467752bbdc37c77ea2504d0b4ffcc7383ac81654117361000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking zt2zm calls with pdf_implicit_coefs_terms use the 2D version. 2022-06-01 16:02:41 -0500b736467752bbdc37c77ea2504d0b4ffcc7383ac8Making zt2zm calls with pdf_implicit_coefs_terms use the 2D version.editsrc/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/clubb_driver.F908b9b43ecb1c82b2a06882613bbe7e2e61b86e0af1654122180000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving setup_grid and setup_parameters functionality from setup_clubb_core. This is beacuse in host models the required grid information may not be known during the setup process, resulting in dummy arguments for setup_clubb_core and the grid and paramters being setup during runtime anyway. Now, in the host models we can call these subroutines immediately after setup_clubb_core to maintain identical functionality (sam, wrf), and in others we can wait to call these until the main timestepping procedure (cam,e3sm). 2022-06-01 17:23:00 -05008b9b43ecb1c82b2a06882613bbe7e2e61b86e0afRemoving setup_grid and setup_parameters functionality from setup_clubb_core. This is beacuse in host models the required grid information may not be known during the setup process, resulting in dummy arguments for setup_clubb_core and the grid and paramters being setup during runtime anyway. Now, in the host models we can call these subroutines immediately after setup_clubb_core to maintain identical functionality (sam, wrf), and in others we can wait to call these until the main timestepping procedure (cam,e3sm).editsrc/clubb_driver.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/parameters_tunable.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/grid_class.F90ed85915bbcd00d1dba9b17752de763547bfa429b1654129942000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking 2D versions of setup_grid and setup_parameters. 2022-06-01 19:32:22 -0500ed85915bbcd00d1dba9b17752de763547bfa429bMaking 2D versions of setup_grid and setup_parameters.editsrc/CLUBB_core/clubb_api_module.F90editsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/grid_class.F90editsrc/CLUBB_core/parameters_tunable.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/parameters_tunable.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/mixing_length.F902230f5a91f09608cc496fba43d68e0d454049a981654197815000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking lmin a scalar again, twas a mistake to make it an array, it can only take on one value. 2022-06-02 14:23:35 -05002230f5a91f09608cc496fba43d68e0d454049a98Making lmin a scalar again, twas a mistake to make it an array, it can only take on one value.editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/parameters_tunable.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/parameters_tunable.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/clubb_api_module.F90src/advance_microphys_module.F90src/CLUBB_core/advance_xp2_xpyp_module.F9050a3080a1374291f321eae16b2806e0753e09b271654200656000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking nu_vert_res_dep a type containing arrays, as opposed to being an array of types. 2022-06-02 15:10:56 -050050a3080a1374291f321eae16b2806e0753e09b27Making nu_vert_res_dep a type containing arrays, as opposed to being an array of types.editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/parameters_tunable.F90editsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/advance_microphys_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephenshttp://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrnhttp://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonhttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwmhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhttp://carson.math.uwm.edu/jenkins/user/pbroelspbroelsfalse36http://carson.math.uwm.edu/jenkins/view/all/job/branch_clubb_test/36/34http://carson.math.uwm.edu/jenkins/view/all/job/branch_clubb_test/34/BRANCHorigin/masterTESTclubb_backwards_compatibility_gfortran_testStarted by user pbroelspbroelspbroels4c2430410e13a733d23852dd5abc08bbc6b02307bc2430410e13a733d23852dd5abc08bbc6b02307brefs/remotes/origin/feeding_stats_through_arg_listc2430410e13a733d23852dd5abc08bbc6b02307bc2430410e13a733d23852dd5abc08bbc6b02307brefs/remotes/origin/feeding_stats_through_arg_list33fc4a6391f4bbe5c29a9e83625f7813ccaef1fcd5fc4a6391f4bbe5c29a9e83625f7813ccaef1fcd5refs/remotes/origin/masterfc4a6391f4bbe5c29a9e83625f7813ccaef1fcd5fc4a6391f4bbe5c29a9e83625f7813ccaef1fcd5refs/remotes/origin/masterfc4a6391f4bbe5c29a9e83625f7813ccaef1fcd5fc4a6391f4bbe5c29a9e83625f7813ccaef1fcd5refs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#3358341102164branch_clubb_test #3333false3311567FAILURE1642032689911http://carson.math.uwm.edu/jenkins/view/all/job/branch_clubb_test/33/src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/clubb_driver.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/clubb_api_module.F90f1d888a37cfeeac7b39fd67a7efe332cd27ed65e1631318520000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have passed clubb_params down into advance_xm_wpxp_module.F90. The results from this revision are an exact match to the results from the previous revision for all cases. 2021-09-10 19:02:00 -0500f1d888a37cfeeac7b39fd67a7efe332cd27ed65eI have passed clubb_params down into advance_xm_wpxp_module.F90.editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/G_unit_test_types/spurious_source_test.F90src/G_unit_test_types/w_up_in_cloud_tests.F90src/CLUBB_core/pdf_closure_module.F90799c0393e23eee22258c13af0e96935686b16b361632504823000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comSee ticket #958 2021-09-24 12:33:43 -0500799c0393e23eee22258c13af0e96935686b16b36See ticketaddsrc/G_unit_test_types/w_up_in_cloud_tests.F90editsrc/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90a73978a3fa1608e44d1d818dbd6b47edcfb4f5d61632791429000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have passed down CLUBB's tunable parameters into advance_wp2_wp3_module.F90. The results in NetCDF output files from this revision are an exact match to the results in NetCDF output files from the previous revision for all cases. 2021-09-27 20:10:29 -0500a73978a3fa1608e44d1d818dbd6b47edcfb4f5d6I have passed down CLUBB's tunable parameters into advance_wp2_wp3_module.F90.editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/G_unit_test_types/w_up_in_cloud_tests.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/stats_clubb_utilities.F9092c6ab41532c58e19b7c85a05eef3d0b757c50eb1633009731000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comadded some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to disk 2021-09-30 08:48:51 -050092c6ab41532c58e19b7c85a05eef3d0b757c50ebadded some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to diskeditsrc/G_unit_test_types/w_up_in_cloud_tests.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/stats_clubb_utilities.F90editsrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xp2_xpyp_module.F90ef3be1b1378bcd1a447f3866c9f88f8cc47642331633124125000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comUpdates to separate out C4 and C14 in advance_xp2 module. This will make it easier to control which invrs_tau_* variable multiplies each term for example. This commit is BIT_CHANGING owing to order of operations differences, but the pyplotgen output for most cases looks identical to the naked eye. 2021-10-01 16:35:25 -0500ef3be1b1378bcd1a447f3866c9f88f8cc4764233Updates to separate out C4 and C14 in advance_xp2 module. This will make it easier to control which invrs_tau_* variable multiplies each term for example.editsrc/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/advance_xp2_xpyp_module.F903d3b367cfa0230c0323c2063223aec93a8b4ae581633124125000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comChanging the name of dummy_1d variables for clarity. 2021-10-01 16:35:25 -05003d3b367cfa0230c0323c2063223aec93a8b4ae58Changing the name of dummy_1d variables for clarity.editsrc/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xp2_xpyp_module.F90438fbd1f8d117ae85d249575d41e5007775e305d1633127377000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI passed down CLUBB's tunable parameters into advance_xp2_xpyp_module.F90 for most parameters, excluding C4 and C14. Results are unchanged. 2021-10-01 17:29:37 -0500438fbd1f8d117ae85d249575d41e5007775e305dI passed down CLUBB's tunable parameters into advance_xp2_xpyp_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_clubb_core_module.F907db479d9a5bf6e304a7e23ce3e7923103e8b40e01633359161000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd a blank line to trigger nightly tests. 2021-10-04 09:52:41 -05007db479d9a5bf6e304a7e23ce3e7923103e8b40e0Add a blank line to trigger nightly tests.editsrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xp2_xpyp_module.F90fe0fc9f90888412a259fba12fc61e5d14d53faa41633470307000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing down more of CLUBB's tunable parameters. 2021-10-05 16:45:07 -0500fe0fc9f90888412a259fba12fc61e5d14d53faa4Passing down more of CLUBB's tunable parameters.editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_clubb_core_module.F90cdcc03bf39a00d082e57115d1b45ea6d3481a7401633470537000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI accidentally removed an important comment in the previous commit. 2021-10-05 16:48:57 -0500cdcc03bf39a00d082e57115d1b45ea6d3481a740I accidentally removed an important comment in the previous commit.editsrc/CLUBB_core/advance_clubb_core_module.F90postprocessing/pyplotgen/README.md8a4711c32fc8851f00d5f1d5dd66d164d3408a8c1633617842000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate README.md Adding comment to README for pyplotgen. 2021-10-07 09:44:02 -05008a4711c32fc8851f00d5f1d5dd66d164d3408a8cUpdate README.mdeditpostprocessing/pyplotgen/README.mdsrc/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_helper_module.F903c7fecaba43e458a2a0a5f10f98e2c8cd3c6de161633637871000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing down more CLUBB tunable parameters. Everything is bit-for-bit. 2021-10-07 15:17:51 -05003c7fecaba43e458a2a0a5f10f98e2c8cd3c6de16Passing down more CLUBB tunable parameters.editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_helper_module.F90src/G_unit_test_types/pdf_parameter_tests.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F9066af005868cf95e986d51d7f656177cf7344741a1633728172000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduMore passing down CLUBB parameters ... whoop-de-doo 2021-10-08 16:22:52 -050066af005868cf95e986d51d7f656177cf7344741aMore passing down CLUBB parameters ... whoop-de-dooeditsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/clubb_driver.F90src/CLUBB_core/sfc_varnce_module.F90src/CLUBB_core/diagnose_correlations_module.F90src/CLUBB_core/Skx_module.F9055a47e458f6dad402c8c2f5094efe280129494631633732238000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing down more tunable parameters and removing references to parameters_tunable. Results are bit-for-bit. 2021-10-08 17:30:38 -050055a47e458f6dad402c8c2f5094efe28012949463Passing down more tunable parameters and removing references toeditsrc/CLUBB_core/sfc_varnce_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/Skx_module.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/diagnose_correlations_module.F90src/CLUBB_core/advance_clubb_core_module.F9033d475588c4881dee6e4bed10d36c8a26cd2a8dd1634055768000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemoving line to trigger the nightly tests for all repos. 2021-10-12 11:22:48 -050033d475588c4881dee6e4bed10d36c8a26cd2a8ddRemoving line to trigger the nightly tests for all repos.editsrc/CLUBB_core/advance_clubb_core_module.F90compile/file_list/G_unit_tests_filessrc/G_unit_tests.F90postprocessing/pyplotgen/config/VariableGroupWs.pyinput/stats/standard_stats.insrc/CLUBB_core/pdf_closure_module.F90input/stats/all_stats.insrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/model_flags.F90src/G_unit_test_types/w_up_in_cloud_tests.F90postprocessing/pyplotgen/config/Case_definitions.pysrc/CLUBB_core/stats_clubb_utilities.F90src/CLUBB_core/stats_zt_module.F90input/tunable_parameters/configurable_model_flags.insrc/CLUBB_core/stats_variables.F90f5e493c6e8ef60db7ebbb4d7b1ef1ec23ba8ecfc1634058263000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comSee respective messages on the issue 958 on date 10/12/2021 2021-10-12 12:04:23 -0500f5e493c6e8ef60db7ebbb4d7b1ef1ec23ba8ecfcSee respective messages on the issue 958 on date 10/12/2021editsrc/CLUBB_core/pdf_closure_module.F90editpostprocessing/pyplotgen/config/Case_definitions.pyeditsrc/CLUBB_core/stats_zt_module.F90editinput/tunable_parameters/configurable_model_flags.ineditsrc/G_unit_tests.F90editsrc/G_unit_test_types/w_up_in_cloud_tests.F90editpostprocessing/pyplotgen/config/VariableGroupWs.pyeditsrc/CLUBB_core/stats_clubb_utilities.F90editsrc/CLUBB_core/stats_variables.F90editinput/stats/standard_stats.ineditcompile/file_list/G_unit_tests_fileseditsrc/CLUBB_core/model_flags.F90editinput/stats/all_stats.ineditsrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/parameters_tunable.F90src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/mixing_length.F907c8ad62fa35fbe06da2b7dc3ee40ed35234125e81634087718000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduHandling the abomination that is lmin. 2021-10-12 20:15:18 -05007c8ad62fa35fbe06da2b7dc3ee40ed35234125e8Handling the abomination that is lmin.editsrc/CLUBB_core/parameters_tunable.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/clubb_api_module.F90src/CLUBB_core/diffusion.F9041d45340865af62bc644bb7b8506274e8348b3481634219703000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comCommented out the k=1 boundary conditions in diffusion_zm_lhs and diffusion_zt_lhs, since these are not currently fed into the final LHS matrix. I included comments to describe why this was done. Results are b4b. See https://github.com/larson-group/clubb/issues/920#issuecomment-942735433. 2021-10-14 08:55:03 -050041d45340865af62bc644bb7b8506274e8348b348Commented out the k=1 boundary conditions in diffusion_zm_lhs and diffusion_zt_lhs, since these are not currently fed into the final LHS matrix. I included comments to describe why this was done. Results are b4b.editsrc/CLUBB_core/diffusion.F90jenkins_tests/clubb_bin_diff_regression_backwards_compatibility_gfortran_test/Jenkinsfile0fdf13cc3bb83ae86ffc8d99d1783085c54968ef1634249950000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding Jenkinsfile for new clubb backwards compatibility test. larson-group#960 2021-10-14 17:19:10 -05000fdf13cc3bb83ae86ffc8d99d1783085c54968efAdding Jenkinsfile for new clubb backwards compatibility test. larson-group#960addjenkins_tests/clubb_bin_diff_regression_backwards_compatibility_gfortran_test/Jenkinsfilejenkins_tests/clubb_bin_diff_regression_backwards_compatibility_gfortran_test/Jenkinsfileedf396c22d112b1ee54f23a177cc75de8c7b56ed1634250269000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduModifying jenkins script. larson-group/clubb#960 2021-10-14 17:24:29 -0500edf396c22d112b1ee54f23a177cc75de8c7b56edModifying jenkins script. larson-group/clubb#960editjenkins_tests/clubb_bin_diff_regression_backwards_compatibility_gfortran_test/Jenkinsfilesrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/mixing_length.F908f26dce1c7565c16fff85a0661ec47bff2afd3531634254172000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing tunable parameters into the new tau code. 2021-10-14 18:29:32 -05008f26dce1c7565c16fff85a0661ec47bff2afd353Passing tunable parameters into the new tau code.editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/mixing_length.F90utilities/sens_matrix/test_analyzeSensMatrix.pyutilities/sens_matrix/analyze_sensitivity_matrix.pyutilities/sens_matrix/sens_matrix_dashboard.py8c2d853308949c88ecdd0844c8caeb457ec35ff71634743279000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduAdd a scatterplot of residual biases versus default-simulation biases. All points lie along the one-one line if the tuner can remove all bias. Add a calculation of the radius of curvature in order to assess nonlinearity of global model to tunable parameter values. However, the calculation code is still incomplete. Add a second calculation of the error bars on parameter values that is an alternative to the SVD calculation. The code still doesn't pass the test_3x2_C8transformed unit test. For #910. 2021-10-20 10:21:19 -05008c2d853308949c88ecdd0844c8caeb457ec35ff7Add a scatterplot of residual biases versus default-simulation biases.editutilities/sens_matrix/analyze_sensitivity_matrix.pyeditutilities/sens_matrix/test_analyzeSensMatrix.pyeditutilities/sens_matrix/sens_matrix_dashboard.pysrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/clip_explicit.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/clubb_driver.F90src/CLUBB_core/mixing_length.F90b3b3c90a9bfe58517074d1323a4afc072e86ac4d1634768140000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassed down more parameters. Results are bit-for-bit. 2021-10-20 17:15:40 -0500b3b3c90a9bfe58517074d1323a4afc072e86ac4dPassed down more parameters. Results are bit-for-bit.editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/clip_explicit.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/parameters_model.F90a4ea4767df36095f7acac78c07c2ca41d88a0e271634771341000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing through more clubb parameters. Bit-for-bit 2021-10-20 18:09:01 -0500a4ea4767df36095f7acac78c07c2ca41d88a0e27Passing through more clubb parameters. Bit-for-biteditsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/parameters_model.F90jenkins_tests/clubb_bit_diff_e3sm_flags/Jenkinsfile5fccf76538e4f2b7ad5940be707ab5b369e9a4c51634847611000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding jenkins file 2021-10-21 15:20:11 -05005fccf76538e4f2b7ad5940be707ab5b369e9a4c5Adding jenkins fileaddjenkins_tests/clubb_bit_diff_e3sm_flags/Jenkinsfilejenkins_tests/clubb_bit_diff_e3sm_flags/Jenkinsfilejenkins_tests/clubb_bit_diff_e3sm_flags_gfortran/Jenkinsfilef47ad90d2a4de346d6e03b25294c1bfc9ec1931b1634848098000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduChanging name of jenkins tests. larson-group/clubb#960 2021-10-21 15:28:18 -0500f47ad90d2a4de346d6e03b25294c1bfc9ec1931bChanging name of jenkins tests. larson-group/clubb#960deletejenkins_tests/clubb_bit_diff_e3sm_flags/Jenkinsfileaddjenkins_tests/clubb_bit_diff_e3sm_flags_gfortran/Jenkinsfilejenkins_tests/clubb_bit_diff_e3sm_flags_gfortran/Jenkinsfilejenkins_tests/clubb_bin_diff_regression_e3sm_flags_gfortran/Jenkinsfile39843be0ab1d74e82f96041370d4f7da0e30f3701634851764000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRenaming 2021-10-21 16:29:24 -050039843be0ab1d74e82f96041370d4f7da0e30f370Renamingdeletejenkins_tests/clubb_bit_diff_e3sm_flags_gfortran/Jenkinsfileaddjenkins_tests/clubb_bin_diff_regression_e3sm_flags_gfortran/Jenkinsfilesrc/clubb_driver.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/precipitation_fraction.F90src/CLUBB_core/setup_clubb_pdf_params.F90253982d8ae576b347c421c1721742cf9dedeee261634854899000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing down CLUBB's tunable parameters into the setup_pdf_parameters and precipitation fraction portions of the code. Everything is bit-for-bit. 2021-10-21 17:21:39 -0500253982d8ae576b347c421c1721742cf9dedeee26Passing down CLUBB's tunable parameters into the setup_pdf_parameters andeditsrc/CLUBB_core/precipitation_fraction.F90editsrc/CLUBB_core/setup_clubb_pdf_params.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/clubb_api_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/model_flags.F90src/advance_microphys_module.F90src/CLUBB_core/diffusion.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/advance_xp2_xpyp_module.F9095d7773f81117daff784b8ab91f4211c2edc83901634935501000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comThese updates incorporate some of Shixuan Zhang's changes, including: (1) upwind scheme for the eddy diffusion code, which Shixuan says does not make a huge difference; and (2) l_smooth_heaviside_tau_wpxp flag in the mixing_length.F90 code, which is intended to give smoother results. Both of the flags for these changes are turned off, but these updates are BIT_CHANGING because of some minor changes to the way that factors of rho_ds_* and invrs_rho_ds_* are handled going into the diffusion.F90 subroutines. Most cases look identical in pyplotgen, but sensitive cases like arm_97 and rico look slightly different. These changes were originally in pull request #962, but because of conflicts with the master branch code base that developed, they could not be rebased and merged, so I incorporated them into this new commit. 2021-10-22 15:45:01 -050095d7773f81117daff784b8ab91f4211c2edc8390These updates incorporate some of Shixuan Zhang's changes, including:editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/model_flags.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/advance_microphys_module.F90editsrc/CLUBB_core/diffusion.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90src/advance_microphys_module.F90src/clubb_driver.F903a9d5757433916b8b1acd46df13293d5d3cf0d2d1634938465000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI passed down CLUBB's tunable parameters into the advance_microphys portion of the code. It's all bit-for-bit. 2021-10-22 16:34:25 -05003a9d5757433916b8b1acd46df13293d5d3cf0d2dI passed down CLUBB's tunable parameters into the advance_microphys portion ofeditsrc/clubb_driver.F90editsrc/advance_microphys_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/new_hybrid_pdf_main.F90src/G_unit_test_types/pdf_parameter_tests.F90src/CLUBB_core/new_pdf_main.F90src/CLUBB_core/pdf_closure_module.F9083b29b9b67737e9df79afeb31e033f1140fb6d251635207177000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing down CLUBB's tunable parameters into the remainder of the PDF subroutines. Everything is bit-for-bit. 2021-10-25 19:12:57 -050083b29b9b67737e9df79afeb31e033f1140fb6d25Passing down CLUBB's tunable parameters into the remainder of theeditsrc/CLUBB_core/new_pdf_main.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/new_hybrid_pdf_main.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/clubb_api_module.F90src/clubb_driver.F907a306fed7c43c4868e4996ef2fd6e5f604b267321635210039000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI passed down the forgotten thlp2_rad_coef tunable parameter. All bit-for-bit. 2021-10-25 20:00:39 -05007a306fed7c43c4868e4996ef2fd6e5f604b26732I passed down the forgotten thlp2_rad_coef tunable parameter.editsrc/clubb_driver.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/clubb_api_module.F90src/clubb_driver.F90src/microphys_init_cleanup.F90b4d5fb7b8e293100938833b36f3783405c9774d81635214334000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing down CLUBB's tunable parameters into CLUBB's microphysics initialization. 2021-10-25 21:12:14 -0500b4d5fb7b8e293100938833b36f3783405c9774d8Passing down CLUBB's tunable parameters into CLUBB'seditsrc/clubb_driver.F90editsrc/microphys_init_cleanup.F90src/CLUBB_core/diffusion.F909f1e1ad0e80be0a00148ceb1373cd3dd82e9469a1635271688000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comUncommenting diffusion.F90 k=1 lines again to fix Oracle uninit var test. I've updated the accompanying note to state clearly that the lines have no effect on model output, but I guess we need to keep the lines to avoid uninitialized variables. 2021-10-26 13:08:08 -05009f1e1ad0e80be0a00148ceb1373cd3dd82e9469aUncommenting diffusion.F90 k=1 lines again to fix Oracle uninit var test. I've updated the accompanying note to state clearly that the lines have no effect on model output, but I guess we need to keep the lines to avoid uninitialized variables.editsrc/CLUBB_core/diffusion.F90src/CLUBB_core/advance_xm_wpxp_module.F90ae462c9ecc9dac803b2719ccb5aae1126a840c2d1635291046000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am passing down the forgotten parameter, altitude threshold, in advance_xm_wpxp_module.F90. 2021-10-26 18:30:46 -0500ae462c9ecc9dac803b2719ccb5aae1126a840c2dI am passing down the forgotten parameter, altitude threshold, ineditsrc/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/clubb_driver.F90src/CLUBB_core/model_flags.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/clubb_api_module.F90input/tunable_parameters_Lscale/configurable_model_flags.ininput/tunable_parameters_e3sm/configurable_model_flags.insrc/G_unit_test_types/pdf_parameter_tests.F90input/tunable_parameters/configurable_model_flags.insrc/clubb_tuner.F90987d63de489d2baa09ad6e1538b2c6dbb75516901635369371000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding code wrapped in a flag (l_use_tke_in_K_dfsn) to use u_i'u_i' in the wp2 and wp3 eddy diffusion terms, instead of just wp2 or wp3. Relevant to CLUBB issue #920. Results are b4b when the flag is turned off, which it currently is. 2021-10-27 16:16:11 -0500987d63de489d2baa09ad6e1538b2c6dbb7551690Adding code wrapped in a flag (l_use_tke_in_K_dfsn) to use u_i'u_i' in the wp2 and wp3 eddy diffusion terms, instead of just wp2 or wp3. Relevant to CLUBB issue #920.editsrc/CLUBB_core/advance_wp2_wp3_module.F90editinput/tunable_parameters_e3sm/configurable_model_flags.ineditsrc/clubb_driver.F90editinput/tunable_parameters_Lscale/configurable_model_flags.ineditsrc/G_unit_test_types/pdf_parameter_tests.F90editinput/tunable_parameters/configurable_model_flags.ineditsrc/CLUBB_core/model_flags.F90editsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/clubb_tuner.F90editsrc/CLUBB_core/clubb_api_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/clubb_driver.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/model_flags.F90src/CLUBB_core/clubb_api_module.F90input/tunable_parameters_Lscale/configurable_model_flags.ininput/tunable_parameters_e3sm/configurable_model_flags.insrc/G_unit_test_types/pdf_parameter_tests.F90input/tunable_parameters_compatible_r8029/configurable_model_flags.ininput/tunable_parameters/configurable_model_flags.insrc/clubb_tuner.F9079bc651171add5b6a340be02cf6f775ddc779aaa1635369371000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comUpdates as requested to the l_use_tke_in_K_dfsn code: - The name of the flag is changed to l_use_tke_in_wp2_wp3_K_dfsn - Comments are added to the main pieces of code in advance_wp2_wp3 - The flag is added to the "compatible_r8029" configurable flags file. See this comment https://github.com/larson-group/clubb/issues/920#issuecomment-931446401 and following for more information. 2021-10-27 16:16:11 -050079bc651171add5b6a340be02cf6f775ddc779aaaUpdates as requested to the l_use_tke_in_K_dfsn code:editinput/tunable_parameters_Lscale/configurable_model_flags.ineditsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editinput/tunable_parameters_compatible_r8029/configurable_model_flags.ineditsrc/clubb_driver.F90editinput/tunable_parameters/configurable_model_flags.ineditinput/tunable_parameters_e3sm/configurable_model_flags.ineditsrc/G_unit_test_types/spurious_source_test.F90editsrc/clubb_tuner.F90editsrc/CLUBB_core/model_flags.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90postprocessing/pyplotgen/config/VariableGroupWs.pya4edc266802c743ff21a4aebfb4fa66a12b1f6371635521331000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comAdded WSUP from SAM to the VariableGroupWs.py in pyplotgen 2021-10-29 10:28:51 -0500a4edc266802c743ff21a4aebfb4fa66a12b1f637Added WSUP from SAM to the VariableGroupWs.py in pyplotgeneditpostprocessing/pyplotgen/config/VariableGroupWs.pysrc/CLUBB_core/parameters_tunable.F90src/G_unit_test_types/spurious_source_test.F90src/SILHS/silhs_api_module.F90src/SILHS/latin_hypercube_driver_module.F90src/clubb_thread_test.F90src/SILHS/output_2D_samples_module.F90src/clubb_standalone.F90src/jacobian.F90src/CLUBB_core/output_netcdf.F90src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/stats_clubb_utilities.F90src/G_unit_test_types/pdf_parameter_tests.F90src/error.F90bb06897ec9a8a659c69f05c005cb6b7f3380975e1635542624000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am committing the final stage of the "pass-down params" project. The results are bit-for-bit identical. 2021-10-29 16:23:44 -0500bb06897ec9a8a659c69f05c005cb6b7f3380975eI am committing the final stage of the "pass-down params" project.editsrc/clubb_driver.F90editsrc/CLUBB_core/stats_clubb_utilities.F90editsrc/SILHS/output_2D_samples_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/parameters_tunable.F90editsrc/error.F90editsrc/clubb_standalone.F90editsrc/SILHS/latin_hypercube_driver_module.F90editsrc/G_unit_test_types/spurious_source_test.F90editsrc/SILHS/silhs_api_module.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/clubb_thread_test.F90editsrc/jacobian.F90editsrc/CLUBB_core/output_netcdf.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/advance_xp2_xpyp_module.F90edb7bc84684712739876ec803541ba3b165f4a5a1635542673000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding an option to use invrs_tau_N2_iso for C4 terms. The same invrs_tau had been used for C4 and C14 terms, so some adjustments had to be made to separate them out (this was started with an earlier commit: https://github.com/larson-group/clubb/commit/ef3be1b1378bcd1a447f3866c9f88f8cc4764233). The flag is currently set to false so results will be b4b. See also the discussion here: https://github.com/larson-group/clubb/issues/920#issuecomment-920338746 and following comments. 2021-10-29 16:24:33 -0500edb7bc84684712739876ec803541ba3b165f4a5aAdding an option to use invrs_tau_N2_iso for C4 terms. The same invrs_tau had been used for C4 and C14 terms, so some adjustments had to be made to separate them out (this was started with an earlier commit: https://github.com/larson-group/clubb/commit/ef3be1b1378bcd1a447f3866c9f88f8cc4764233). The flag is currently set to false so results will be b4b.editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/advance_wp2_wp3_module.F9017d242a65d579c70299dfcecb853f2aed5e0feb11635542673000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comRenaming invrs_tau_zt and invrs_tauw3t to "invrs_tau_wp3_zt" in advance_wp2_wp3 to avoid confusion. This variable is only used for the wp3 C8 term, so one consistent name is simpler, and the name "invrs_tau_zt" is already used by another variable in advance_clubb_core. 2021-10-29 16:24:33 -050017d242a65d579c70299dfcecb853f2aed5e0feb1Renaming invrs_tau_zt and invrs_tauw3t to "invrs_tau_wp3_zt" in advance_wp2_wp3 to avoid confusion. This variable is only used for the wp3 C8 term, so one consistent name is simpler, and the name "invrs_tau_zt" is already used by another variable in advance_clubb_core.editsrc/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/mixing_length.F90a29c355bfc54d7459a6107cf45b593473dcce8d11635542673000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding comments for clarity. 2021-10-29 16:24:33 -0500a29c355bfc54d7459a6107cf45b593473dcce8d1Adding comments for clarity.editsrc/CLUBB_core/mixing_length.F90src/CLUBB_core/clubb_api_module.F903c47dcdc6b5d8ecb855c2df36a86e3e778e4820d1635637985000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI forgot to add this necessary subroutine call to the clubb API. 2021-10-30 18:53:05 -05003c47dcdc6b5d8ecb855c2df36a86e3e778e4820dI forgot to add this necessary subroutine call to the clubb API.editsrc/CLUBB_core/clubb_api_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90cf9db3f9448ad0c5a97fcf3b005a645b6b6a927a1635789347000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comFixing a minor accounting bug related to the changes in https://github.com/larson-group/clubb/commit/987d63de489d2baa09ad6e1538b2c6dbb7551690. There was some overcounting of the relevant terms. Results are b4b since the l_use_tke_in_wp2_wp3_K_dfsn flag is false. 2021-11-01 12:55:47 -0500cf9db3f9448ad0c5a97fcf3b005a645b6b6a927aFixing a minor accounting bug related to the changes in https://github.com/larson-group/clubb/commit/987d63de489d2baa09ad6e1538b2c6dbb7551690. There was some overcounting of the relevant terms.editsrc/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/CLUBB_core/parameters_tunable.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/clubb_driver.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/clubb_api_module.F90src/advance_microphys_module.F90src/CLUBB_core/diffusion.F90src/CLUBB_core/advance_xp2_xpyp_module.F901b4ca12287908273f189d8588e7a39755cd4fb6d1636150605000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have turned the nu_vert_res_dep family of variables into a derived type and that variable is now being passed throughout the CLUBB code, rather than accessing variables through a USE statement. Everything is 100% bit-for-bit! 2021-11-05 17:16:45 -05001b4ca12287908273f189d8588e7a39755cd4fb6dI have turned the nu_vert_res_dep family of variables into a derivededitsrc/CLUBB_core/clubb_api_module.F90editsrc/advance_microphys_module.F90editsrc/CLUBB_core/parameters_tunable.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/diffusion.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90utilities/sens_matrix/test_analyzeSensMatrix.pyutilities/sens_matrix/analyze_sensitivity_matrix.pyutilities/sens_matrix/sens_matrix_dashboard.pyae681935179f62ffb588fe2aab7c95780034f1531636387557000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduAdd 3 new features to dashboard: 1) Add Huber (confusingly called "Ransac") regressor to find a fit that de-weights outliers. The goal is to identify tuning trade-offs. 2) Add ElasticNet regressor. The goal here is to obtain a good fit that doesn't perturb the parameters too much, and that leaves some parameter values unchanged if possible. 3) Add a routine to create PCA biplots. The goal here is to identify outliers (i.e., tuning trade-offs) analytically. For #910. 2021-11-08 10:05:57 -0600ae681935179f62ffb588fe2aab7c95780034f153Add 3 new features to dashboard:editutilities/sens_matrix/analyze_sensitivity_matrix.pyeditutilities/sens_matrix/test_analyzeSensMatrix.pyeditutilities/sens_matrix/sens_matrix_dashboard.pypostprocessing/tolerance_compare/tolerance_check.pya931651e75fe59f3c0435a3b8d1ced442a89d9cc1636405058000http://carson.math.uwm.edu/jenkins/user/pbroelspbroelspbroels@uwm.eduUpdating tolerance_check.py to Python3. 2021-11-08 14:57:38 -0600a931651e75fe59f3c0435a3b8d1ced442a89d9ccUpdating tolerance_check.py to Python3.editpostprocessing/tolerance_compare/tolerance_check.pysrc/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/stats_zt_module.F90postprocessing/pyplotgen/config/Case_definitions.pydc4d9fa8d3688a4b970446cd4b29ef3f75d2a63f1636491816000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comAdded sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90 2021-11-09 15:03:36 -0600dc4d9fa8d3688a4b970446cd4b29ef3f75d2a63fAdded sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/stats_zt_module.F90editpostprocessing/pyplotgen/config/Case_definitions.pyinput/tunable_parameters_compatible_r8029/configurable_model_flags.in1c59a5018700023f704a46b68ad581445427d51f1636589258000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comTurn off l_Lscale_vert_avg because this flag has been deprecated. We're not concerned about any damage to backwards compatibility because NCAR doesn't run SILHS. Hopefully, this will allow the clubb_bin_diff_regression_backwards_compatibility_gfortran_test Jenkins test to pass. larson-group/sys_admin#763 2021-11-10 18:07:38 -06001c59a5018700023f704a46b68ad581445427d51fTurn off l_Lscale_vert_avg because this flag has been deprecated.editinput/tunable_parameters_compatible_r8029/configurable_model_flags.insrc/CLUBB_core/advance_clubb_core_module.F90src/G_unit_tests.F90input/tunable_parameters/configurable_model_flags.insrc/CLUBB_core/model_flags.F90src/CLUBB_core/pdf_closure_module.F90src/G_unit_test_types/w_up_in_cloud_tests.F90b98df1d99fb3d70d496f49cf3b812c8a246c1bb81636651886000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comResolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details 2021-11-11 11:31:26 -0600b98df1d99fb3d70d496f49cf3b812c8a246c1bb8Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for detailseditsrc/CLUBB_core/pdf_closure_module.F90editsrc/G_unit_test_types/w_up_in_cloud_tests.F90editsrc/G_unit_tests.F90editinput/tunable_parameters/configurable_model_flags.ineditsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/model_flags.F90src/CLUBB_core/pdf_closure_module.F90input/stats/standard_stats.in49c2984d69af2adda36fb151146393decc215dc41636664054000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comIncluded a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge 2021-11-11 14:54:14 -060049c2984d69af2adda36fb151146393decc215dc4Included a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after mergeeditsrc/CLUBB_core/pdf_closure_module.F90editinput/stats/standard_stats.insrc/CLUBB_core/pdf_closure_module.F90939fbbd0b0c6bc00fcce8cfce0f306e84c3155a71636664205000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comfixed a typo in pdf_closure_module.f90, line 1284 2021-11-11 14:56:45 -0600939fbbd0b0c6bc00fcce8cfce0f306e84c3155a7fixed a typo in pdf_closure_module.f90, line 1284editsrc/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/pdf_closure_module.F90src/G_unit_test_types/w_up_in_cloud_tests.F90cea625cee42c8cbf6d1793eaae65f6bb136b16f91636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comSee ticket #958 2021-11-11 15:45:54 -0600cea625cee42c8cbf6d1793eaae65f6bb136b16f9See ticketeditsrc/CLUBB_core/pdf_closure_module.F90addsrc/G_unit_test_types/w_up_in_cloud_tests.F90src/G_unit_test_types/w_up_in_cloud_tests.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/stats_clubb_utilities.F906aa4ad30eef8b9bc2ce8dc46fb355d414b4315421636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comadded some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to disk 2021-11-11 15:45:54 -06006aa4ad30eef8b9bc2ce8dc46fb355d414b431542added some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to diskeditsrc/G_unit_test_types/w_up_in_cloud_tests.F90editsrc/CLUBB_core/stats_clubb_utilities.F90editsrc/CLUBB_core/pdf_closure_module.F90compile/file_list/G_unit_tests_filessrc/G_unit_tests.F90postprocessing/pyplotgen/config/VariableGroupWs.pyinput/stats/standard_stats.insrc/CLUBB_core/pdf_closure_module.F90input/stats/all_stats.insrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/model_flags.F90src/G_unit_test_types/w_up_in_cloud_tests.F90postprocessing/pyplotgen/config/Case_definitions.pysrc/CLUBB_core/stats_clubb_utilities.F90src/CLUBB_core/stats_zt_module.F90input/tunable_parameters/configurable_model_flags.insrc/CLUBB_core/stats_variables.F90e33002f85d35ee72f9b155437f36e9c103765cc31636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comSee respective messages on the issue 958 on date 10/12/2021 2021-11-11 15:45:54 -0600e33002f85d35ee72f9b155437f36e9c103765cc3See respective messages on the issue 958 on date 10/12/2021editcompile/file_list/G_unit_tests_fileseditsrc/G_unit_test_types/w_up_in_cloud_tests.F90editinput/stats/all_stats.ineditsrc/CLUBB_core/advance_clubb_core_module.F90editpostprocessing/pyplotgen/config/Case_definitions.pyeditinput/stats/standard_stats.ineditsrc/G_unit_tests.F90editsrc/CLUBB_core/model_flags.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/stats_clubb_utilities.F90editsrc/CLUBB_core/stats_variables.F90editinput/tunable_parameters/configurable_model_flags.ineditpostprocessing/pyplotgen/config/VariableGroupWs.pyeditsrc/CLUBB_core/stats_zt_module.F90postprocessing/pyplotgen/config/VariableGroupWs.py7a8e16c077839c803937a1346546fd5419c541a21636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comAdded WSUP from SAM to the VariableGroupWs.py in pyplotgen 2021-11-11 15:45:54 -06007a8e16c077839c803937a1346546fd5419c541a2Added WSUP from SAM to the VariableGroupWs.py in pyplotgeneditpostprocessing/pyplotgen/config/VariableGroupWs.pysrc/CLUBB_core/stats_zt_module.F90src/CLUBB_core/pdf_closure_module.F90postprocessing/pyplotgen/config/Case_definitions.pyf7cd1d8ccc310129bfb3ceb243b0c47284eaccf51636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comAdded sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90 2021-11-11 15:45:54 -0600f7cd1d8ccc310129bfb3ceb243b0c47284eaccf5Added sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90editsrc/CLUBB_core/stats_zt_module.F90editsrc/CLUBB_core/pdf_closure_module.F90editpostprocessing/pyplotgen/config/Case_definitions.pysrc/CLUBB_core/advance_clubb_core_module.F90src/G_unit_tests.F90input/tunable_parameters/configurable_model_flags.insrc/CLUBB_core/model_flags.F90src/CLUBB_core/pdf_closure_module.F90src/G_unit_test_types/w_up_in_cloud_tests.F90202f78110b0f343f565b8ac1ea633ded7b27ee111636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comResolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details 2021-11-11 15:45:54 -0600202f78110b0f343f565b8ac1ea633ded7b27ee11Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for detailseditsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/model_flags.F90editinput/tunable_parameters/configurable_model_flags.ineditsrc/CLUBB_core/pdf_closure_module.F90editsrc/G_unit_test_types/w_up_in_cloud_tests.F90editsrc/G_unit_tests.F90src/CLUBB_core/pdf_closure_module.F90input/stats/standard_stats.indf3b263c7525b030ed469116534560eb74ae8ddf1636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comIncluded a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge 2021-11-11 15:45:54 -0600df3b263c7525b030ed469116534560eb74ae8ddfIncluded a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after mergeeditsrc/CLUBB_core/pdf_closure_module.F90editinput/stats/standard_stats.insrc/CLUBB_core/pdf_closure_module.F90335d83b7e89d00fa3cd1ce727356d6d7b006dd361636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comfixed a typo in pdf_closure_module.f90, line 1284 2021-11-11 15:45:54 -0600335d83b7e89d00fa3cd1ce727356d6d7b006dd36fixed a typo in pdf_closure_module.f90, line 1284editsrc/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/clubb_api_module.F90src/clubb_driver.F901c77ed3f85d66c5ec3818b2e146a5cc95bbcf3061637038777000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing w_up_in_cloud out of advance_clubb_core 2021-11-15 22:59:37 -06001c77ed3f85d66c5ec3818b2e146a5cc95bbcf306Passing w_up_in_cloud out of advance_clubb_coreeditsrc/clubb_driver.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/clubb_api_module.F90src/CLUBB_core/stats_variables.F9001902a482d8d51667174e18551fad475b57dc98c1638465215000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comfixed compiler warning regarding w_up_in_cloud 2021-12-02 11:13:35 -060001902a482d8d51667174e18551fad475b57dc98cfixed compiler warning regarding w_up_in_cloudeditsrc/CLUBB_core/stats_variables.F90src/CLUBB_core/advance_clubb_core_module.F904d88fc65090fc186ee942d5247fbb43ddfa67a821638567586000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemove clipping from a3_coef. In principle, removing the clipping should reduce noise. In practice, it makes rico noiser but mpace_b less noisy. It also allows twp_ice to run to completion with the gfortran compiler. This commit is BIT_CHANGING. For #965. 2021-12-03 15:39:46 -06004d88fc65090fc186ee942d5247fbb43ddfa67a82Remove clipping from a3_coef.editsrc/CLUBB_core/advance_clubb_core_module.F90postprocessing/pyplotgen/config/Case_definitions.py25efa002d221b5de85adc86feb1ffd4da51d72321638807612000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd "subcolumns" key to LASSO cases in pyplotgen. 2021-12-06 10:20:12 -060025efa002d221b5de85adc86feb1ffd4da51d7232Add "subcolumns" key to LASSO cases in pyplotgen.editpostprocessing/pyplotgen/config/Case_definitions.pyREADME01983ed11b0daff5e4da31f8d672a07c49e9f0191639609752000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdding a line to the readme to trigger the nightly tests. 2021-12-15 17:09:12 -060001983ed11b0daff5e4da31f8d672a07c49e9f019Adding a line to the readme to trigger the nightly tests.editREADMEREADME13e93594651b217c11b00cfede5784136a16b86d1639694037000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemoving a line to trigger the nightly tests. larson-group/sys_admin#763 2021-12-16 16:33:57 -060013e93594651b217c11b00cfede5784136a16b86dRemoving a line to trigger the nightly tests. larson-group/sys_admin#763editREADMEsrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/G_unit_test_types/spurious_source_test.F90a7c61266346ca0d113aaf2e12fc9580c8a6186d01639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comThese changes allow you to call the 4 clubb "advance" subroutines in any order that you want to try. In the default order (where the order is the same as found in the current version of the CLUBB master), results are bit-for-bit when compared to CLUBB master. 2021-12-17 17:36:25 -0600a7c61266346ca0d113aaf2e12fc9580c8a6186d0These changes allow you to call the 4 clubb "advance" subroutines in anyeditsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_clubb_core_module.F9035d03fc4ee564148d7c718591ba0e48b86c970721639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comPlacing the order variables in a nice, convenient place for testing use. 2021-12-17 17:36:25 -060035d03fc4ee564148d7c718591ba0e48b86c97072Placing the order variables in a nice, convenient place for testing use.editsrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_clubb_core_module.F9005a0c45a46b4d2bb8afbb235969868a878d755d31639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comI reordered advance_clubb_core so that the "Advance xp3" (which is a basic calculation of xp3 by the ansatz by default) section is moved out of the way of the "advance loop" to a point that is after advance_windm_edsclrm (or whatever will be called last in the advance loop. This change does not alter the default results. Everything is still bit-for-bit. 2021-12-17 17:36:25 -060005a0c45a46b4d2bb8afbb235969868a878d755d3I reordered advance_clubb_core so that the "Advance xp3" (which is aeditsrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F90ab8d447789861d018a0e50d06bedea3e044d5ecb1639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comI am committing the idiot-proofing code that forces l_min_xp2_from_corr_wx and l_enable_relaxed_clipping to have opposite values (one must be true and the other must be false). In this commit, both are set to true, so the code will produce an exception. 2021-12-17 17:36:25 -0600ab8d447789861d018a0e50d06bedea3e044d5ecbI am committing the idiot-proofing code that forces l_min_xp2_from_corr_wxeditsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_clubb_core_module.F909b22e11df82804105e6f34728d42e29ebd8dc9da1639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comI am indenting the portion of the code where the advance subroutines are located within the new ordering loop. 2021-12-17 17:36:25 -06009b22e11df82804105e6f34728d42e29ebd8dc9daI am indenting the portion of the code where the advance subroutineseditsrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_clubb_core_module.F9071ab332a524b2802f9e406d8e9ac00712a3b96c01639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comTemporarily commenting out the idiot proofing in order to run some tests ... The results from this branch are still bit-for-bit with the master branch. 2021-12-17 17:36:25 -060071ab332a524b2802f9e406d8e9ac00712a3b96c0Temporarily commenting out the idiot proofing in order to run some tests ...editsrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_clubb_core_module.F9006d48b1c9da2a8a65f080fa16450d807b97a19ea1639784501000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduNow official reinstating the idiot-proofing and turning off the l_enable_relaxed_clipping flag. This commit is BIT_CHANGING 2021-12-17 17:41:41 -060006d48b1c9da2a8a65f080fa16450d807b97a19eaNow official reinstating the idiot-proofing and turning off theeditsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_clubb_core_module.F90fa5559b6fd09f3da30b4d4d0255c532b3dd536071639787077000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am committing some idiot proofing in regards to the advance subroutines ordering. No index can have a value of less than 1, greater than 4, and no index can have the same value as any other index. Each adv routine order index must have a unique value. 2021-12-17 18:24:37 -0600fa5559b6fd09f3da30b4d4d0255c532b3dd53607I am committing some idiot proofing in regards to the advanceeditsrc/CLUBB_core/advance_clubb_core_module.F90postprocessing/pyplotgen/config/VariableGroupBaseBudgetsSamStyle.pyea5b5707470c2d942cbb7081436ede1baedde7041640012072000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comUpdates to SAM-style budget plots for CLUBB output. 2021-12-20 08:54:32 -0600ea5b5707470c2d942cbb7081436ede1baedde704Updates to SAM-style budget plots for CLUBB output.editpostprocessing/pyplotgen/config/VariableGroupBaseBudgetsSamStyle.pysrc/error.F90input_misc/tuner/error_four_cases.in32af4729f9ff1d374e03249b1b4d8d05fd8052d61640202403000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding new four-case tuner script and also some minor updates to error.F90 that avoid the "LES is zero" error for the cloud water and cloud fraction. 2021-12-22 13:46:43 -060032af4729f9ff1d374e03249b1b4d8d05fd8052d6Adding new four-case tuner script and also some minor updates to error.F90 that avoid the "LES is zero" error for the cloud water and cloud fraction.editsrc/error.F90addinput_misc/tuner/error_four_cases.insrc/error.F90f983171d892eb60a4d3193f71125f280169a336f1640202403000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding comments and minor cleanup for my last commit about the tuner update. 2021-12-22 13:46:43 -0600f983171d892eb60a4d3193f71125f280169a336fAdding comments and minor cleanup for my last commit about the tuner update.editsrc/error.F90src/error.F90c665567bd02143fd2060282ad5cb5dea6cdf26791640202403000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comUpdating error.F90 to include the error statement about LES field being zero as a check. 2021-12-22 13:46:43 -0600c665567bd02143fd2060282ad5cb5dea6cdf2679Updating error.F90 to include the error statement about LES field being zero as a check.editsrc/error.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/clubb_api_module.F90src/clubb_driver.F9074c54289ac37740b48512eecab9352c37a19a3241640706464000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdating CLUBB to pass uprcp and vprcp into and out of advance_clubb_core. 2021-12-28 09:47:44 -060074c54289ac37740b48512eecab9352c37a19a324Updating CLUBB to pass uprcp and vprcp into and out of advance_clubb_core.editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/clubb_driver.F90src/CLUBB_core/advance_clubb_core_module.F90517dd59a53c72aab76b5f40e078f08c7a736f0a91640706663000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduNow that uprcp and vprcp have been passed through advance_clubb_core, I can get rid of this idiot-proofing code that stops the run when l_predict_upwp_vpwp is enabled and the PDF is in the "post" position. 2021-12-28 09:51:03 -0600517dd59a53c72aab76b5f40e078f08c7a736f0a9Now that uprcp and vprcp have been passed through advance_clubb_core,editsrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F909cc76af14581bda65bf71ce4d8ba4d70534cf6f51640825295000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am adding more arguments to the argument list for advance_clubb_core so that the model now runs with the PDF in the post position. Result from this change are still bit-for-bit. 2021-12-29 18:48:15 -06009cc76af14581bda65bf71ce4d8ba4d70534cf6f5I am adding more arguments to the argument list for advance_clubb_coreeditsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90postprocessing/pyplotgen/src/CaseGallerySetup.py722d0f5d58787f4c8f9ad9c73a1004e1077c61db1640965359000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comModifying the generate subcolumn panels function to smoothly plot both CLUBB and WRF-LASSO SILHS subcolumns. 2021-12-31 09:42:39 -0600722d0f5d58787f4c8f9ad9c73a1004e1077c61dbModifying the generate subcolumn panels function to smoothly plot both CLUBB and WRF-LASSO SILHS subcolumns.editpostprocessing/pyplotgen/src/CaseGallerySetup.pysrc/CLUBB_core/model_flags.F902a9a0f2c7031013529a4c2a7b78d05c727bdc37c1641839832000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comInsert print about overwriting default flags with namelist values 2022-01-10 12:37:12 -06002a9a0f2c7031013529a4c2a7b78d05c727bdc37cInsert print about overwriting default flags with namelist valueseditsrc/CLUBB_core/model_flags.F90src/CLUBB_core/parameters_tunable.F90ae798c431a9c33366661af3078b56d073b16b0231641840286000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comInsert print about overwriting default parameters with namelist values 2022-01-10 12:44:46 -0600ae798c431a9c33366661af3078b56d073b16b023Insert print about overwriting default parameters with namelist valueseditsrc/CLUBB_core/parameters_tunable.F90README8c4c90049b075b8e615e8e08ddf101bdcddf98561641840820000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comNote that source-code flags and parameter values are overwritten by namelist values 2022-01-10 12:53:40 -06008c4c90049b075b8e615e8e08ddf101bdcddf9856Note that source-code flags and parameter values are overwritten by namelist valueseditREADMEREADME1460a662e1f4056e02af076d44a22b1e5629c9871641841008000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClarify comments in README 2022-01-10 12:56:48 -06001460a662e1f4056e02af076d44a22b1e5629c987Clarify comments in READMEeditREADMEsrc/CLUBB_core/clubb_api_module.F90efea5cc92bbc5ac9bca31f66f10f02f7f56eff8d1641936564000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking api version of setup_grid. larson-group/clubb#972 2022-01-11 15:29:24 -0600efea5cc92bbc5ac9bca31f66f10f02f7f56eff8dMaking api version of setup_grid. larson-group/clubb#972editsrc/CLUBB_core/clubb_api_module.F90src/SILHS/silhs_api_module.F909915baa6935273f632bcc611fc7aef03c1b026ff1642027821000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking some paramters_silhs variables available from the silhs api 2022-01-12 16:50:21 -06009915baa6935273f632bcc611fc7aef03c1b026ffMaking some paramters_silhs variables available from the silhs apieditsrc/SILHS/silhs_api_module.F90src/CLUBB_core/advance_clubb_core_module.F906f037c8025b8131ad603677a418099473fc8239a1642031683000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comComment out setting of fatal error when l_min_xp2_from_corr_wx = F and l_enable_relaxed_clipping = F. The goal is to allow the clubb_backwards_compatibility_gfortran_test Jenkins test to pass again. For #846. 2022-01-12 17:54:43 -06006f037c8025b8131ad603677a418099473fc8239aComment out setting of fatal erroreditsrc/CLUBB_core/advance_clubb_core_module.F90jenkins_tests/clubb_backwards_compatibility_gfortran_test/Jenkinsfilefc4a6391f4bbe5c29a9e83625f7813ccaef1fcd51642032632000http://carson.math.uwm.edu/jenkins/user/pbroelspbroelspbroels@uwm.eduAdding a step to remove idio proofing into backwards compatibility test. larson-group/sys_admin#763 2022-01-12 18:10:32 -0600fc4a6391f4bbe5c29a9e83625f7813ccaef1fcd5Adding a step to remove idio proofing into backwards compatibility test. larson-group/sys_admin#763editjenkins_tests/clubb_backwards_compatibility_gfortran_test/Jenkinsfilegithttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephenshttp://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrnhttp://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldhttp://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonhttp://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens82http://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffinhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhttp://carson.math.uwm.edu/jenkins/user/pbroelspbroelsfalse34http://carson.math.uwm.edu/jenkins/view/all/job/branch_clubb_test/34/32http://carson.math.uwm.edu/jenkins/view/all/job/branch_clubb_test/32/