BRANCHorigin/masterTESTclubb_backwards_compatibility_gfortran_testStarted by user pbroelspbroelspbroels4c2430410e13a733d23852dd5abc08bbc6b02307bc2430410e13a733d23852dd5abc08bbc6b02307brefs/remotes/origin/feeding_stats_through_arg_listc2430410e13a733d23852dd5abc08bbc6b02307bc2430410e13a733d23852dd5abc08bbc6b02307brefs/remotes/origin/feeding_stats_through_arg_list33fc4a6391f4bbe5c29a9e83625f7813ccaef1fcd5fc4a6391f4bbe5c29a9e83625f7813ccaef1fcd5refs/remotes/origin/masterfc4a6391f4bbe5c29a9e83625f7813ccaef1fcd5fc4a6391f4bbe5c29a9e83625f7813ccaef1fcd5refs/remotes/origin/masterfc4a6391f4bbe5c29a9e83625f7813ccaef1fcd5fc4a6391f4bbe5c29a9e83625f7813ccaef1fcd5refs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#3358341102164branch_clubb_test #3333false3311567FAILURE1642032689911http://carson.math.uwm.edu/jenkins/view/all/job/branch_clubb_test/33/- src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/clubb_driver.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/clubb_api_module.F90f1d888a37cfeeac7b39fd67a7efe332cd27ed65e1631318520000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have passed clubb_params down into advance_xm_wpxp_module.F90.
The results from this revision are an exact match to the results from
the previous revision for all cases.
2021-09-10 19:02:00 -0500f1d888a37cfeeac7b39fd67a7efe332cd27ed65eI have passed clubb_params down into advance_xm_wpxp_module.F90.editsrc/clubb_driver.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/advance_clubb_core_module.F90
- src/G_unit_test_types/w_up_in_cloud_tests.F90src/CLUBB_core/pdf_closure_module.F90799c0393e23eee22258c13af0e96935686b16b361632504823000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comSee ticket
#958
2021-09-24 12:33:43 -0500799c0393e23eee22258c13af0e96935686b16b36See ticketaddsrc/G_unit_test_types/w_up_in_cloud_tests.F90editsrc/CLUBB_core/pdf_closure_module.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90a73978a3fa1608e44d1d818dbd6b47edcfb4f5d61632791429000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have passed down CLUBB's tunable parameters into advance_wp2_wp3_module.F90.
The results in NetCDF output files from this revision are an exact match to the
results in NetCDF output files from the previous revision for all cases.
2021-09-27 20:10:29 -0500a73978a3fa1608e44d1d818dbd6b47edcfb4f5d6I have passed down CLUBB's tunable parameters into advance_wp2_wp3_module.F90.editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/pdf_closure_module.F90src/G_unit_test_types/w_up_in_cloud_tests.F90src/CLUBB_core/stats_clubb_utilities.F9092c6ab41532c58e19b7c85a05eef3d0b757c50eb1633009731000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comadded some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to disk
2021-09-30 08:48:51 -050092c6ab41532c58e19b7c85a05eef3d0b757c50ebadded some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to diskeditsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/stats_clubb_utilities.F90editsrc/G_unit_test_types/w_up_in_cloud_tests.F90
- src/CLUBB_core/advance_xp2_xpyp_module.F90ef3be1b1378bcd1a447f3866c9f88f8cc47642331633124125000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comUpdates to separate out C4 and C14 in advance_xp2 module. This will make it easier to control which invrs_tau_* variable multiplies each term for example.
This commit is BIT_CHANGING owing to order of operations differences, but the pyplotgen output for most cases looks identical to the naked eye.
2021-10-01 16:35:25 -0500ef3be1b1378bcd1a447f3866c9f88f8cc4764233Updates to separate out C4 and C14 in advance_xp2 module. This will make it easier to control which invrs_tau_* variable multiplies each term for example.editsrc/CLUBB_core/advance_xp2_xpyp_module.F90
- src/CLUBB_core/advance_xp2_xpyp_module.F903d3b367cfa0230c0323c2063223aec93a8b4ae581633124125000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comChanging the name of dummy_1d variables for clarity.
2021-10-01 16:35:25 -05003d3b367cfa0230c0323c2063223aec93a8b4ae58Changing the name of dummy_1d variables for clarity.editsrc/CLUBB_core/advance_xp2_xpyp_module.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xp2_xpyp_module.F90438fbd1f8d117ae85d249575d41e5007775e305d1633127377000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI passed down CLUBB's tunable parameters into advance_xp2_xpyp_module.F90
for most parameters, excluding C4 and C14. Results are unchanged.
2021-10-01 17:29:37 -0500438fbd1f8d117ae85d249575d41e5007775e305dI passed down CLUBB's tunable parameters into advance_xp2_xpyp_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90
- src/CLUBB_core/advance_clubb_core_module.F907db479d9a5bf6e304a7e23ce3e7923103e8b40e01633359161000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd a blank line to trigger nightly tests.
2021-10-04 09:52:41 -05007db479d9a5bf6e304a7e23ce3e7923103e8b40e0Add a blank line to trigger nightly tests.editsrc/CLUBB_core/advance_clubb_core_module.F90
- src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xp2_xpyp_module.F90fe0fc9f90888412a259fba12fc61e5d14d53faa41633470307000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing down more of CLUBB's tunable parameters.
2021-10-05 16:45:07 -0500fe0fc9f90888412a259fba12fc61e5d14d53faa4Passing down more of CLUBB's tunable parameters.editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90
- src/CLUBB_core/advance_clubb_core_module.F90cdcc03bf39a00d082e57115d1b45ea6d3481a7401633470537000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI accidentally removed an important comment in the previous commit.
2021-10-05 16:48:57 -0500cdcc03bf39a00d082e57115d1b45ea6d3481a740I accidentally removed an important comment in the previous commit.editsrc/CLUBB_core/advance_clubb_core_module.F90
- postprocessing/pyplotgen/README.md8a4711c32fc8851f00d5f1d5dd66d164d3408a8c1633617842000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate README.md
Adding comment to README for pyplotgen.
2021-10-07 09:44:02 -05008a4711c32fc8851f00d5f1d5dd66d164d3408a8cUpdate README.mdeditpostprocessing/pyplotgen/README.md
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_helper_module.F903c7fecaba43e458a2a0a5f10f98e2c8cd3c6de161633637871000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing down more CLUBB tunable parameters.
Everything is bit-for-bit.
2021-10-07 15:17:51 -05003c7fecaba43e458a2a0a5f10f98e2c8cd3c6de16Passing down more CLUBB tunable parameters.editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/advance_helper_module.F90
- src/CLUBB_core/pdf_closure_module.F90src/G_unit_test_types/pdf_parameter_tests.F90src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F9066af005868cf95e986d51d7f656177cf7344741a1633728172000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduMore passing down CLUBB parameters ... whoop-de-doo
2021-10-08 16:22:52 -050066af005868cf95e986d51d7f656177cf7344741aMore passing down CLUBB parameters ... whoop-de-dooeditsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/clubb_driver.F90src/CLUBB_core/sfc_varnce_module.F90src/CLUBB_core/diagnose_correlations_module.F90src/CLUBB_core/Skx_module.F9055a47e458f6dad402c8c2f5094efe280129494631633732238000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing down more tunable parameters and removing references to
parameters_tunable. Results are bit-for-bit.
2021-10-08 17:30:38 -050055a47e458f6dad402c8c2f5094efe28012949463Passing down more tunable parameters and removing references toeditsrc/CLUBB_core/Skx_module.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/sfc_varnce_module.F90editsrc/CLUBB_core/diagnose_correlations_module.F90
- src/CLUBB_core/advance_clubb_core_module.F9033d475588c4881dee6e4bed10d36c8a26cd2a8dd1634055768000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemoving line to trigger the nightly tests for all repos.
2021-10-12 11:22:48 -050033d475588c4881dee6e4bed10d36c8a26cd2a8ddRemoving line to trigger the nightly tests for all repos.editsrc/CLUBB_core/advance_clubb_core_module.F90
- compile/file_list/G_unit_tests_filessrc/G_unit_tests.F90postprocessing/pyplotgen/config/VariableGroupWs.pyinput/stats/standard_stats.insrc/CLUBB_core/pdf_closure_module.F90input/stats/all_stats.insrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/model_flags.F90src/G_unit_test_types/w_up_in_cloud_tests.F90postprocessing/pyplotgen/config/Case_definitions.pysrc/CLUBB_core/stats_clubb_utilities.F90src/CLUBB_core/stats_zt_module.F90input/tunable_parameters/configurable_model_flags.insrc/CLUBB_core/stats_variables.F90f5e493c6e8ef60db7ebbb4d7b1ef1ec23ba8ecfc1634058263000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comSee respective messages on the issue 958 on date 10/12/2021
2021-10-12 12:04:23 -0500f5e493c6e8ef60db7ebbb4d7b1ef1ec23ba8ecfcSee respective messages on the issue 958 on date 10/12/2021editpostprocessing/pyplotgen/config/Case_definitions.pyeditsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/model_flags.F90editinput/stats/standard_stats.ineditsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/stats_zt_module.F90editsrc/G_unit_tests.F90editsrc/CLUBB_core/stats_clubb_utilities.F90editinput/tunable_parameters/configurable_model_flags.ineditcompile/file_list/G_unit_tests_fileseditsrc/CLUBB_core/stats_variables.F90editsrc/G_unit_test_types/w_up_in_cloud_tests.F90editinput/stats/all_stats.ineditpostprocessing/pyplotgen/config/VariableGroupWs.py
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/parameters_tunable.F90src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/mixing_length.F907c8ad62fa35fbe06da2b7dc3ee40ed35234125e81634087718000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduHandling the abomination that is lmin.
2021-10-12 20:15:18 -05007c8ad62fa35fbe06da2b7dc3ee40ed35234125e8Handling the abomination that is lmin.editsrc/CLUBB_core/parameters_tunable.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/mixing_length.F90editsrc/clubb_driver.F90
- src/CLUBB_core/diffusion.F9041d45340865af62bc644bb7b8506274e8348b3481634219703000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comCommented out the k=1 boundary conditions in diffusion_zm_lhs and diffusion_zt_lhs, since these are not currently fed into the final LHS matrix. I included comments to describe why this was done. Results are b4b.
See https://github.com/larson-group/clubb/issues/920#issuecomment-942735433.
2021-10-14 08:55:03 -050041d45340865af62bc644bb7b8506274e8348b348Commented out the k=1 boundary conditions in diffusion_zm_lhs and diffusion_zt_lhs, since these are not currently fed into the final LHS matrix. I included comments to describe why this was done. Results are b4b.editsrc/CLUBB_core/diffusion.F90
- jenkins_tests/clubb_bin_diff_regression_backwards_compatibility_gfortran_test/Jenkinsfile0fdf13cc3bb83ae86ffc8d99d1783085c54968ef1634249950000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding Jenkinsfile for new clubb backwards compatibility test. larson-group#960
2021-10-14 17:19:10 -05000fdf13cc3bb83ae86ffc8d99d1783085c54968efAdding Jenkinsfile for new clubb backwards compatibility test. larson-group#960addjenkins_tests/clubb_bin_diff_regression_backwards_compatibility_gfortran_test/Jenkinsfile
- jenkins_tests/clubb_bin_diff_regression_backwards_compatibility_gfortran_test/Jenkinsfileedf396c22d112b1ee54f23a177cc75de8c7b56ed1634250269000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduModifying jenkins script. larson-group/clubb#960
2021-10-14 17:24:29 -0500edf396c22d112b1ee54f23a177cc75de8c7b56edModifying jenkins script. larson-group/clubb#960editjenkins_tests/clubb_bin_diff_regression_backwards_compatibility_gfortran_test/Jenkinsfile
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/mixing_length.F908f26dce1c7565c16fff85a0661ec47bff2afd3531634254172000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing tunable parameters into the new tau code.
2021-10-14 18:29:32 -05008f26dce1c7565c16fff85a0661ec47bff2afd353Passing tunable parameters into the new tau code.editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/advance_clubb_core_module.F90
- utilities/sens_matrix/test_analyzeSensMatrix.pyutilities/sens_matrix/sens_matrix_dashboard.pyutilities/sens_matrix/analyze_sensitivity_matrix.py8c2d853308949c88ecdd0844c8caeb457ec35ff71634743279000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduAdd a scatterplot of residual biases versus default-simulation biases.
All points lie along the one-one line if the tuner can remove all bias.
Add a calculation of the radius of curvature in order to assess
nonlinearity of global model to tunable parameter values.
However, the calculation code is still incomplete.
Add a second calculation of the error bars on parameter values
that is an alternative to the SVD calculation.
The code still doesn't pass the test_3x2_C8transformed unit test.
For #910.
2021-10-20 10:21:19 -05008c2d853308949c88ecdd0844c8caeb457ec35ff7Add a scatterplot of residual biases versus default-simulation biases.editutilities/sens_matrix/test_analyzeSensMatrix.pyeditutilities/sens_matrix/sens_matrix_dashboard.pyeditutilities/sens_matrix/analyze_sensitivity_matrix.py
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/clip_explicit.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/clubb_driver.F90src/CLUBB_core/mixing_length.F90b3b3c90a9bfe58517074d1323a4afc072e86ac4d1634768140000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassed down more parameters. Results are bit-for-bit.
2021-10-20 17:15:40 -0500b3b3c90a9bfe58517074d1323a4afc072e86ac4dPassed down more parameters. Results are bit-for-bit.editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/clip_explicit.F90editsrc/CLUBB_core/mixing_length.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/parameters_model.F90a4ea4767df36095f7acac78c07c2ca41d88a0e271634771341000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing through more clubb parameters. Bit-for-bit
2021-10-20 18:09:01 -0500a4ea4767df36095f7acac78c07c2ca41d88a0e27Passing through more clubb parameters. Bit-for-biteditsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/parameters_model.F90
- jenkins_tests/clubb_bit_diff_e3sm_flags/Jenkinsfile5fccf76538e4f2b7ad5940be707ab5b369e9a4c51634847611000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding jenkins file
2021-10-21 15:20:11 -05005fccf76538e4f2b7ad5940be707ab5b369e9a4c5Adding jenkins fileaddjenkins_tests/clubb_bit_diff_e3sm_flags/Jenkinsfile
- jenkins_tests/clubb_bit_diff_e3sm_flags/Jenkinsfilejenkins_tests/clubb_bit_diff_e3sm_flags_gfortran/Jenkinsfilef47ad90d2a4de346d6e03b25294c1bfc9ec1931b1634848098000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduChanging name of jenkins tests. larson-group/clubb#960
2021-10-21 15:28:18 -0500f47ad90d2a4de346d6e03b25294c1bfc9ec1931bChanging name of jenkins tests. larson-group/clubb#960addjenkins_tests/clubb_bit_diff_e3sm_flags_gfortran/Jenkinsfiledeletejenkins_tests/clubb_bit_diff_e3sm_flags/Jenkinsfile
- jenkins_tests/clubb_bit_diff_e3sm_flags_gfortran/Jenkinsfilejenkins_tests/clubb_bin_diff_regression_e3sm_flags_gfortran/Jenkinsfile39843be0ab1d74e82f96041370d4f7da0e30f3701634851764000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRenaming
2021-10-21 16:29:24 -050039843be0ab1d74e82f96041370d4f7da0e30f370Renamingaddjenkins_tests/clubb_bin_diff_regression_e3sm_flags_gfortran/Jenkinsfiledeletejenkins_tests/clubb_bit_diff_e3sm_flags_gfortran/Jenkinsfile
- src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/precipitation_fraction.F90src/CLUBB_core/setup_clubb_pdf_params.F90253982d8ae576b347c421c1721742cf9dedeee261634854899000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing down CLUBB's tunable parameters into the setup_pdf_parameters and
precipitation fraction portions of the code. Everything is bit-for-bit.
2021-10-21 17:21:39 -0500253982d8ae576b347c421c1721742cf9dedeee26Passing down CLUBB's tunable parameters into the setup_pdf_parameters andeditsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/setup_clubb_pdf_params.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/precipitation_fraction.F90
- src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/model_flags.F90src/advance_microphys_module.F90src/CLUBB_core/diffusion.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/advance_xp2_xpyp_module.F9095d7773f81117daff784b8ab91f4211c2edc83901634935501000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comThese updates incorporate some of Shixuan Zhang's changes, including:
(1) upwind scheme for the eddy diffusion code, which Shixuan says does not make a huge difference; and
(2) l_smooth_heaviside_tau_wpxp flag in the mixing_length.F90 code, which is intended to give
smoother results.
Both of the flags for these changes are turned off, but these updates are BIT_CHANGING because
of some minor changes to the way that factors of rho_ds_* and invrs_rho_ds_* are handled going
into the diffusion.F90 subroutines. Most cases look identical in pyplotgen, but sensitive cases
like arm_97 and rico look slightly different.
These changes were originally in pull request #962, but because of conflicts with the master
branch code base that developed, they could not be rebased and merged, so I incorporated them
into this new commit.
2021-10-22 15:45:01 -050095d7773f81117daff784b8ab91f4211c2edc8390These updates incorporate some of Shixuan Zhang's changes, including:editsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/model_flags.F90editsrc/advance_microphys_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/diffusion.F90editsrc/CLUBB_core/mixing_length.F90
- src/advance_microphys_module.F90src/clubb_driver.F903a9d5757433916b8b1acd46df13293d5d3cf0d2d1634938465000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI passed down CLUBB's tunable parameters into the advance_microphys portion of
the code. It's all bit-for-bit.
2021-10-22 16:34:25 -05003a9d5757433916b8b1acd46df13293d5d3cf0d2dI passed down CLUBB's tunable parameters into the advance_microphys portion ofeditsrc/advance_microphys_module.F90editsrc/clubb_driver.F90
- src/CLUBB_core/new_hybrid_pdf_main.F90src/CLUBB_core/advance_clubb_core_module.F90src/G_unit_test_types/pdf_parameter_tests.F90src/CLUBB_core/new_pdf_main.F90src/CLUBB_core/pdf_closure_module.F9083b29b9b67737e9df79afeb31e033f1140fb6d251635207177000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing down CLUBB's tunable parameters into the remainder of the
PDF subroutines. Everything is bit-for-bit.
2021-10-25 19:12:57 -050083b29b9b67737e9df79afeb31e033f1140fb6d25Passing down CLUBB's tunable parameters into the remainder of theeditsrc/CLUBB_core/new_hybrid_pdf_main.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/new_pdf_main.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/clubb_api_module.F90src/clubb_driver.F907a306fed7c43c4868e4996ef2fd6e5f604b267321635210039000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI passed down the forgotten thlp2_rad_coef tunable parameter.
All bit-for-bit.
2021-10-25 20:00:39 -05007a306fed7c43c4868e4996ef2fd6e5f604b26732I passed down the forgotten thlp2_rad_coef tunable parameter.editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/clubb_driver.F90
- src/clubb_driver.F90src/microphys_init_cleanup.F90b4d5fb7b8e293100938833b36f3783405c9774d81635214334000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing down CLUBB's tunable parameters into CLUBB's
microphysics initialization.
2021-10-25 21:12:14 -0500b4d5fb7b8e293100938833b36f3783405c9774d8Passing down CLUBB's tunable parameters into CLUBB'seditsrc/clubb_driver.F90editsrc/microphys_init_cleanup.F90
- src/CLUBB_core/diffusion.F909f1e1ad0e80be0a00148ceb1373cd3dd82e9469a1635271688000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comUncommenting diffusion.F90 k=1 lines again to fix Oracle uninit var test. I've updated the accompanying note to state clearly that the lines have no effect on model output, but I guess we need to keep the lines to avoid uninitialized variables.
2021-10-26 13:08:08 -05009f1e1ad0e80be0a00148ceb1373cd3dd82e9469aUncommenting diffusion.F90 k=1 lines again to fix Oracle uninit var test. I've updated the accompanying note to state clearly that the lines have no effect on model output, but I guess we need to keep the lines to avoid uninitialized variables.editsrc/CLUBB_core/diffusion.F90
- src/CLUBB_core/advance_xm_wpxp_module.F90ae462c9ecc9dac803b2719ccb5aae1126a840c2d1635291046000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am passing down the forgotten parameter, altitude threshold, in
advance_xm_wpxp_module.F90.
2021-10-26 18:30:46 -0500ae462c9ecc9dac803b2719ccb5aae1126a840c2dI am passing down the forgotten parameter, altitude threshold, ineditsrc/CLUBB_core/advance_xm_wpxp_module.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/G_unit_test_types/spurious_source_test.F90src/clubb_driver.F90src/CLUBB_core/model_flags.F90src/CLUBB_core/clubb_api_module.F90input/tunable_parameters_Lscale/configurable_model_flags.ininput/tunable_parameters_e3sm/configurable_model_flags.insrc/G_unit_test_types/pdf_parameter_tests.F90input/tunable_parameters/configurable_model_flags.insrc/clubb_tuner.F90987d63de489d2baa09ad6e1538b2c6dbb75516901635369371000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding code wrapped in a flag (l_use_tke_in_K_dfsn) to use u_i'u_i' in the wp2 and wp3 eddy diffusion terms, instead of just wp2 or wp3. Relevant to CLUBB issue #920.
Results are b4b when the flag is turned off, which it currently is.
2021-10-27 16:16:11 -0500987d63de489d2baa09ad6e1538b2c6dbb7551690Adding code wrapped in a flag (l_use_tke_in_K_dfsn) to use u_i'u_i' in the wp2 and wp3 eddy diffusion terms, instead of just wp2 or wp3. Relevant to CLUBB issue #920.editsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/clubb_tuner.F90editsrc/clubb_driver.F90editinput/tunable_parameters/configurable_model_flags.ineditsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/model_flags.F90editinput/tunable_parameters_Lscale/configurable_model_flags.ineditinput/tunable_parameters_e3sm/configurable_model_flags.ineditsrc/CLUBB_core/clubb_api_module.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/model_flags.F90src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F90input/tunable_parameters_Lscale/configurable_model_flags.ininput/tunable_parameters_e3sm/configurable_model_flags.insrc/G_unit_test_types/pdf_parameter_tests.F90input/tunable_parameters_compatible_r8029/configurable_model_flags.ininput/tunable_parameters/configurable_model_flags.insrc/clubb_tuner.F9079bc651171add5b6a340be02cf6f775ddc779aaa1635369371000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comUpdates as requested to the l_use_tke_in_K_dfsn code:
- The name of the flag is changed to l_use_tke_in_wp2_wp3_K_dfsn
- Comments are added to the main pieces of code in advance_wp2_wp3
- The flag is added to the "compatible_r8029" configurable flags file.
See this comment https://github.com/larson-group/clubb/issues/920#issuecomment-931446401 and following for more information.
2021-10-27 16:16:11 -050079bc651171add5b6a340be02cf6f775ddc779aaaUpdates as requested to the l_use_tke_in_K_dfsn code:editsrc/CLUBB_core/advance_wp2_wp3_module.F90editinput/tunable_parameters_compatible_r8029/configurable_model_flags.ineditinput/tunable_parameters/configurable_model_flags.ineditinput/tunable_parameters_e3sm/configurable_model_flags.ineditsrc/G_unit_test_types/spurious_source_test.F90editsrc/clubb_tuner.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/model_flags.F90editsrc/clubb_driver.F90editinput/tunable_parameters_Lscale/configurable_model_flags.ineditsrc/CLUBB_core/advance_clubb_core_module.F90
- postprocessing/pyplotgen/config/VariableGroupWs.pya4edc266802c743ff21a4aebfb4fa66a12b1f6371635521331000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comAdded WSUP from SAM to the VariableGroupWs.py in pyplotgen
2021-10-29 10:28:51 -0500a4edc266802c743ff21a4aebfb4fa66a12b1f637Added WSUP from SAM to the VariableGroupWs.py in pyplotgeneditpostprocessing/pyplotgen/config/VariableGroupWs.py
- src/CLUBB_core/parameters_tunable.F90src/G_unit_test_types/spurious_source_test.F90src/SILHS/silhs_api_module.F90src/SILHS/latin_hypercube_driver_module.F90src/clubb_thread_test.F90src/SILHS/output_2D_samples_module.F90src/clubb_standalone.F90src/CLUBB_core/output_netcdf.F90src/jacobian.F90src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/stats_clubb_utilities.F90src/G_unit_test_types/pdf_parameter_tests.F90src/error.F90bb06897ec9a8a659c69f05c005cb6b7f3380975e1635542624000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am committing the final stage of the "pass-down params" project.
The results are bit-for-bit identical.
2021-10-29 16:23:44 -0500bb06897ec9a8a659c69f05c005cb6b7f3380975eI am committing the final stage of the "pass-down params" project.editsrc/CLUBB_core/output_netcdf.F90editsrc/clubb_standalone.F90editsrc/CLUBB_core/stats_clubb_utilities.F90editsrc/error.F90editsrc/SILHS/silhs_api_module.F90editsrc/clubb_driver.F90editsrc/SILHS/latin_hypercube_driver_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/parameters_tunable.F90editsrc/SILHS/output_2D_samples_module.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/clubb_thread_test.F90editsrc/G_unit_test_types/spurious_source_test.F90editsrc/jacobian.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/advance_xp2_xpyp_module.F90edb7bc84684712739876ec803541ba3b165f4a5a1635542673000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding an option to use invrs_tau_N2_iso for C4 terms. The same invrs_tau had been used for C4 and C14 terms, so some adjustments had to be made to separate them out (this was started with an earlier commit: https://github.com/larson-group/clubb/commit/ef3be1b1378bcd1a447f3866c9f88f8cc4764233). The flag is currently set to false so results will be b4b.
See also the discussion here: https://github.com/larson-group/clubb/issues/920#issuecomment-920338746 and following comments.
2021-10-29 16:24:33 -0500edb7bc84684712739876ec803541ba3b165f4a5aAdding an option to use invrs_tau_N2_iso for C4 terms. The same invrs_tau had been used for C4 and C14 terms, so some adjustments had to be made to separate them out (this was started with an earlier commit: https://github.com/larson-group/clubb/commit/ef3be1b1378bcd1a447f3866c9f88f8cc4764233). The flag is currently set to false so results will be b4b.editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/mixing_length.F90
- src/CLUBB_core/advance_wp2_wp3_module.F9017d242a65d579c70299dfcecb853f2aed5e0feb11635542673000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comRenaming invrs_tau_zt and invrs_tauw3t to "invrs_tau_wp3_zt" in advance_wp2_wp3 to avoid confusion. This variable is only used for the wp3 C8 term, so one consistent name is simpler, and the name "invrs_tau_zt" is already used by another variable in advance_clubb_core.
2021-10-29 16:24:33 -050017d242a65d579c70299dfcecb853f2aed5e0feb1Renaming invrs_tau_zt and invrs_tauw3t to "invrs_tau_wp3_zt" in advance_wp2_wp3 to avoid confusion. This variable is only used for the wp3 C8 term, so one consistent name is simpler, and the name "invrs_tau_zt" is already used by another variable in advance_clubb_core.editsrc/CLUBB_core/advance_wp2_wp3_module.F90
- src/CLUBB_core/mixing_length.F90a29c355bfc54d7459a6107cf45b593473dcce8d11635542673000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding comments for clarity.
2021-10-29 16:24:33 -0500a29c355bfc54d7459a6107cf45b593473dcce8d1Adding comments for clarity.editsrc/CLUBB_core/mixing_length.F90
- src/CLUBB_core/clubb_api_module.F903c47dcdc6b5d8ecb855c2df36a86e3e778e4820d1635637985000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI forgot to add this necessary subroutine call to the clubb API.
2021-10-30 18:53:05 -05003c47dcdc6b5d8ecb855c2df36a86e3e778e4820dI forgot to add this necessary subroutine call to the clubb API.editsrc/CLUBB_core/clubb_api_module.F90
- src/CLUBB_core/advance_wp2_wp3_module.F90cf9db3f9448ad0c5a97fcf3b005a645b6b6a927a1635789347000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comFixing a minor accounting bug related to the changes in https://github.com/larson-group/clubb/commit/987d63de489d2baa09ad6e1538b2c6dbb7551690. There was some overcounting of the relevant terms.
Results are b4b since the l_use_tke_in_wp2_wp3_K_dfsn flag is false.
2021-11-01 12:55:47 -0500cf9db3f9448ad0c5a97fcf3b005a645b6b6a927aFixing a minor accounting bug related to the changes in https://github.com/larson-group/clubb/commit/987d63de489d2baa09ad6e1538b2c6dbb7551690. There was some overcounting of the relevant terms.editsrc/CLUBB_core/advance_wp2_wp3_module.F90
- src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/parameters_tunable.F90src/clubb_driver.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/clubb_api_module.F90src/advance_microphys_module.F90src/CLUBB_core/diffusion.F90src/CLUBB_core/advance_xp2_xpyp_module.F901b4ca12287908273f189d8588e7a39755cd4fb6d1636150605000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have turned the nu_vert_res_dep family of variables into a derived
type and that variable is now being passed throughout the CLUBB code,
rather than accessing variables through a USE statement.
Everything is 100% bit-for-bit!
2021-11-05 17:16:45 -05001b4ca12287908273f189d8588e7a39755cd4fb6dI have turned the nu_vert_res_dep family of variables into a derivededitsrc/clubb_driver.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/parameters_tunable.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/diffusion.F90editsrc/advance_microphys_module.F90
- utilities/sens_matrix/test_analyzeSensMatrix.pyutilities/sens_matrix/analyze_sensitivity_matrix.pyutilities/sens_matrix/sens_matrix_dashboard.pyae681935179f62ffb588fe2aab7c95780034f1531636387557000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduAdd 3 new features to dashboard:
1) Add Huber (confusingly called "Ransac") regressor to find
a fit that de-weights outliers. The goal is to identify tuning trade-offs.
2) Add ElasticNet regressor. The goal here is to obtain
a good fit that doesn't perturb the parameters too much,
and that leaves some parameter values unchanged if possible.
3) Add a routine to create PCA biplots. The goal here
is to identify outliers (i.e., tuning trade-offs) analytically.
For #910.
2021-11-08 10:05:57 -0600ae681935179f62ffb588fe2aab7c95780034f153Add 3 new features to dashboard:editutilities/sens_matrix/analyze_sensitivity_matrix.pyeditutilities/sens_matrix/test_analyzeSensMatrix.pyeditutilities/sens_matrix/sens_matrix_dashboard.py
- postprocessing/tolerance_compare/tolerance_check.pya931651e75fe59f3c0435a3b8d1ced442a89d9cc1636405058000http://carson.math.uwm.edu/jenkins/user/pbroelspbroelspbroels@uwm.eduUpdating tolerance_check.py to Python3.
2021-11-08 14:57:38 -0600a931651e75fe59f3c0435a3b8d1ced442a89d9ccUpdating tolerance_check.py to Python3.editpostprocessing/tolerance_compare/tolerance_check.py
- src/CLUBB_core/stats_zt_module.F90src/CLUBB_core/pdf_closure_module.F90postprocessing/pyplotgen/config/Case_definitions.pydc4d9fa8d3688a4b970446cd4b29ef3f75d2a63f1636491816000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comAdded sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90
2021-11-09 15:03:36 -0600dc4d9fa8d3688a4b970446cd4b29ef3f75d2a63fAdded sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90editsrc/CLUBB_core/stats_zt_module.F90editpostprocessing/pyplotgen/config/Case_definitions.pyeditsrc/CLUBB_core/pdf_closure_module.F90
- input/tunable_parameters_compatible_r8029/configurable_model_flags.in1c59a5018700023f704a46b68ad581445427d51f1636589258000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comTurn off l_Lscale_vert_avg because this flag has been deprecated.
We're not concerned about any damage to backwards compatibility because NCAR doesn't run SILHS.
Hopefully, this will allow the clubb_bin_diff_regression_backwards_compatibility_gfortran_test Jenkins test to pass.
larson-group/sys_admin#763
2021-11-10 18:07:38 -06001c59a5018700023f704a46b68ad581445427d51fTurn off l_Lscale_vert_avg because this flag has been deprecated.editinput/tunable_parameters_compatible_r8029/configurable_model_flags.in
- src/CLUBB_core/advance_clubb_core_module.F90src/G_unit_tests.F90input/tunable_parameters/configurable_model_flags.insrc/CLUBB_core/model_flags.F90src/CLUBB_core/pdf_closure_module.F90src/G_unit_test_types/w_up_in_cloud_tests.F90b98df1d99fb3d70d496f49cf3b812c8a246c1bb81636651886000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comResolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details
2021-11-11 11:31:26 -0600b98df1d99fb3d70d496f49cf3b812c8a246c1bb8Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for detailseditsrc/G_unit_tests.F90editinput/tunable_parameters/configurable_model_flags.ineditsrc/CLUBB_core/pdf_closure_module.F90editsrc/G_unit_test_types/w_up_in_cloud_tests.F90editsrc/CLUBB_core/model_flags.F90editsrc/CLUBB_core/advance_clubb_core_module.F90
- src/CLUBB_core/pdf_closure_module.F90input/stats/standard_stats.in49c2984d69af2adda36fb151146393decc215dc41636664054000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comIncluded a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge
2021-11-11 14:54:14 -060049c2984d69af2adda36fb151146393decc215dc4Included a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after mergeeditsrc/CLUBB_core/pdf_closure_module.F90editinput/stats/standard_stats.in
- src/CLUBB_core/pdf_closure_module.F90939fbbd0b0c6bc00fcce8cfce0f306e84c3155a71636664205000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comfixed a typo in pdf_closure_module.f90, line 1284
2021-11-11 14:56:45 -0600939fbbd0b0c6bc00fcce8cfce0f306e84c3155a7fixed a typo in pdf_closure_module.f90, line 1284editsrc/CLUBB_core/pdf_closure_module.F90
- src/G_unit_test_types/w_up_in_cloud_tests.F90src/CLUBB_core/pdf_closure_module.F90cea625cee42c8cbf6d1793eaae65f6bb136b16f91636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comSee ticket
#958
2021-11-11 15:45:54 -0600cea625cee42c8cbf6d1793eaae65f6bb136b16f9See ticketaddsrc/G_unit_test_types/w_up_in_cloud_tests.F90editsrc/CLUBB_core/pdf_closure_module.F90
- src/G_unit_test_types/w_up_in_cloud_tests.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/stats_clubb_utilities.F906aa4ad30eef8b9bc2ce8dc46fb355d414b4315421636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comadded some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to disk
2021-11-11 15:45:54 -06006aa4ad30eef8b9bc2ce8dc46fb355d414b431542added some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to diskeditsrc/G_unit_test_types/w_up_in_cloud_tests.F90editsrc/CLUBB_core/stats_clubb_utilities.F90editsrc/CLUBB_core/pdf_closure_module.F90
- compile/file_list/G_unit_tests_filessrc/G_unit_tests.F90postprocessing/pyplotgen/config/VariableGroupWs.pyinput/stats/standard_stats.insrc/CLUBB_core/pdf_closure_module.F90input/stats/all_stats.insrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/model_flags.F90src/G_unit_test_types/w_up_in_cloud_tests.F90postprocessing/pyplotgen/config/Case_definitions.pysrc/CLUBB_core/stats_clubb_utilities.F90src/CLUBB_core/stats_zt_module.F90input/tunable_parameters/configurable_model_flags.insrc/CLUBB_core/stats_variables.F90e33002f85d35ee72f9b155437f36e9c103765cc31636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comSee respective messages on the issue 958 on date 10/12/2021
2021-11-11 15:45:54 -0600e33002f85d35ee72f9b155437f36e9c103765cc3See respective messages on the issue 958 on date 10/12/2021editinput/stats/all_stats.ineditsrc/CLUBB_core/pdf_closure_module.F90editsrc/G_unit_tests.F90editsrc/CLUBB_core/model_flags.F90editsrc/CLUBB_core/stats_clubb_utilities.F90editsrc/CLUBB_core/stats_zt_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editinput/stats/standard_stats.ineditsrc/G_unit_test_types/w_up_in_cloud_tests.F90editsrc/CLUBB_core/stats_variables.F90editcompile/file_list/G_unit_tests_fileseditinput/tunable_parameters/configurable_model_flags.ineditpostprocessing/pyplotgen/config/Case_definitions.pyeditpostprocessing/pyplotgen/config/VariableGroupWs.py
- postprocessing/pyplotgen/config/VariableGroupWs.py7a8e16c077839c803937a1346546fd5419c541a21636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comAdded WSUP from SAM to the VariableGroupWs.py in pyplotgen
2021-11-11 15:45:54 -06007a8e16c077839c803937a1346546fd5419c541a2Added WSUP from SAM to the VariableGroupWs.py in pyplotgeneditpostprocessing/pyplotgen/config/VariableGroupWs.py
- src/CLUBB_core/stats_zt_module.F90src/CLUBB_core/pdf_closure_module.F90postprocessing/pyplotgen/config/Case_definitions.pyf7cd1d8ccc310129bfb3ceb243b0c47284eaccf51636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comAdded sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90
2021-11-11 15:45:54 -0600f7cd1d8ccc310129bfb3ceb243b0c47284eaccf5Added sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90editsrc/CLUBB_core/stats_zt_module.F90editpostprocessing/pyplotgen/config/Case_definitions.pyeditsrc/CLUBB_core/pdf_closure_module.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/G_unit_tests.F90input/tunable_parameters/configurable_model_flags.insrc/CLUBB_core/model_flags.F90src/CLUBB_core/pdf_closure_module.F90src/G_unit_test_types/w_up_in_cloud_tests.F90202f78110b0f343f565b8ac1ea633ded7b27ee111636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comResolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details
2021-11-11 15:45:54 -0600202f78110b0f343f565b8ac1ea633ded7b27ee11Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for detailseditinput/tunable_parameters/configurable_model_flags.ineditsrc/CLUBB_core/model_flags.F90editsrc/G_unit_tests.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/G_unit_test_types/w_up_in_cloud_tests.F90editsrc/CLUBB_core/advance_clubb_core_module.F90
- src/CLUBB_core/pdf_closure_module.F90input/stats/standard_stats.indf3b263c7525b030ed469116534560eb74ae8ddf1636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comIncluded a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge
2021-11-11 15:45:54 -0600df3b263c7525b030ed469116534560eb74ae8ddfIncluded a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after mergeeditsrc/CLUBB_core/pdf_closure_module.F90editinput/stats/standard_stats.in
- src/CLUBB_core/pdf_closure_module.F90335d83b7e89d00fa3cd1ce727356d6d7b006dd361636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comfixed a typo in pdf_closure_module.f90, line 1284
2021-11-11 15:45:54 -0600335d83b7e89d00fa3cd1ce727356d6d7b006dd36fixed a typo in pdf_closure_module.f90, line 1284editsrc/CLUBB_core/pdf_closure_module.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/clubb_api_module.F90src/clubb_driver.F901c77ed3f85d66c5ec3818b2e146a5cc95bbcf3061637038777000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing w_up_in_cloud out of advance_clubb_core
2021-11-15 22:59:37 -06001c77ed3f85d66c5ec3818b2e146a5cc95bbcf306Passing w_up_in_cloud out of advance_clubb_coreeditsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/clubb_driver.F90
- src/CLUBB_core/stats_variables.F9001902a482d8d51667174e18551fad475b57dc98c1638465215000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comfixed compiler warning regarding w_up_in_cloud
2021-12-02 11:13:35 -060001902a482d8d51667174e18551fad475b57dc98cfixed compiler warning regarding w_up_in_cloudeditsrc/CLUBB_core/stats_variables.F90
- src/CLUBB_core/advance_clubb_core_module.F904d88fc65090fc186ee942d5247fbb43ddfa67a821638567586000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemove clipping from a3_coef.
In principle, removing the clipping should reduce noise.
In practice, it makes rico noiser but mpace_b less noisy.
It also allows twp_ice to run to completion with the gfortran compiler.
This commit is BIT_CHANGING.
For #965.
2021-12-03 15:39:46 -06004d88fc65090fc186ee942d5247fbb43ddfa67a82Remove clipping from a3_coef.editsrc/CLUBB_core/advance_clubb_core_module.F90
- postprocessing/pyplotgen/config/Case_definitions.py25efa002d221b5de85adc86feb1ffd4da51d72321638807612000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd "subcolumns" key to LASSO cases in pyplotgen.
2021-12-06 10:20:12 -060025efa002d221b5de85adc86feb1ffd4da51d7232Add "subcolumns" key to LASSO cases in pyplotgen.editpostprocessing/pyplotgen/config/Case_definitions.py
- README01983ed11b0daff5e4da31f8d672a07c49e9f0191639609752000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdding a line to the readme to trigger the nightly tests.
2021-12-15 17:09:12 -060001983ed11b0daff5e4da31f8d672a07c49e9f019Adding a line to the readme to trigger the nightly tests.editREADME
- README13e93594651b217c11b00cfede5784136a16b86d1639694037000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemoving a line to trigger the nightly tests. larson-group/sys_admin#763
2021-12-16 16:33:57 -060013e93594651b217c11b00cfede5784136a16b86dRemoving a line to trigger the nightly tests. larson-group/sys_admin#763editREADME
- src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/G_unit_test_types/spurious_source_test.F90a7c61266346ca0d113aaf2e12fc9580c8a6186d01639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comThese changes allow you to call the 4 clubb "advance" subroutines in any
order that you want to try. In the default order (where the order is the
same as found in the current version of the CLUBB master), results are
bit-for-bit when compared to CLUBB master.
2021-12-17 17:36:25 -0600a7c61266346ca0d113aaf2e12fc9580c8a6186d0These changes allow you to call the 4 clubb "advance" subroutines in anyeditsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/G_unit_test_types/spurious_source_test.F90
- src/CLUBB_core/advance_clubb_core_module.F9035d03fc4ee564148d7c718591ba0e48b86c970721639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comPlacing the order variables in a nice, convenient place for testing use.
2021-12-17 17:36:25 -060035d03fc4ee564148d7c718591ba0e48b86c97072Placing the order variables in a nice, convenient place for testing use.editsrc/CLUBB_core/advance_clubb_core_module.F90
- src/CLUBB_core/advance_clubb_core_module.F9005a0c45a46b4d2bb8afbb235969868a878d755d31639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comI reordered advance_clubb_core so that the "Advance xp3" (which is a
basic calculation of xp3 by the ansatz by default) section is moved out
of the way of the "advance loop" to a point that is after
advance_windm_edsclrm (or whatever will be called last in the advance
loop.
This change does not alter the default results. Everything is still
bit-for-bit.
2021-12-17 17:36:25 -060005a0c45a46b4d2bb8afbb235969868a878d755d3I reordered advance_clubb_core so that the "Advance xp3" (which is aeditsrc/CLUBB_core/advance_clubb_core_module.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F90ab8d447789861d018a0e50d06bedea3e044d5ecb1639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comI am committing the idiot-proofing code that forces l_min_xp2_from_corr_wx
and l_enable_relaxed_clipping to have opposite values (one must be true
and the other must be false). In this commit, both are set to true, so
the code will produce an exception.
2021-12-17 17:36:25 -0600ab8d447789861d018a0e50d06bedea3e044d5ecbI am committing the idiot-proofing code that forces l_min_xp2_from_corr_wxeditsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/clubb_driver.F90
- src/CLUBB_core/advance_clubb_core_module.F909b22e11df82804105e6f34728d42e29ebd8dc9da1639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comI am indenting the portion of the code where the advance subroutines
are located within the new ordering loop.
2021-12-17 17:36:25 -06009b22e11df82804105e6f34728d42e29ebd8dc9daI am indenting the portion of the code where the advance subroutineseditsrc/CLUBB_core/advance_clubb_core_module.F90
- src/CLUBB_core/advance_clubb_core_module.F9071ab332a524b2802f9e406d8e9ac00712a3b96c01639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comTemporarily commenting out the idiot proofing in order to run some tests ...
The results from this branch are still bit-for-bit with the master branch.
2021-12-17 17:36:25 -060071ab332a524b2802f9e406d8e9ac00712a3b96c0Temporarily commenting out the idiot proofing in order to run some tests ...editsrc/CLUBB_core/advance_clubb_core_module.F90
- src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_clubb_core_module.F9006d48b1c9da2a8a65f080fa16450d807b97a19ea1639784501000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduNow official reinstating the idiot-proofing and turning off the
l_enable_relaxed_clipping flag. This commit is BIT_CHANGING
2021-12-17 17:41:41 -060006d48b1c9da2a8a65f080fa16450d807b97a19eaNow official reinstating the idiot-proofing and turning off theeditsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90
- src/CLUBB_core/advance_clubb_core_module.F90fa5559b6fd09f3da30b4d4d0255c532b3dd536071639787077000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am committing some idiot proofing in regards to the advance
subroutines ordering. No index can have a value of less than 1,
greater than 4, and no index can have the same value as any other
index. Each adv routine order index must have a unique value.
2021-12-17 18:24:37 -0600fa5559b6fd09f3da30b4d4d0255c532b3dd53607I am committing some idiot proofing in regards to the advanceeditsrc/CLUBB_core/advance_clubb_core_module.F90
- postprocessing/pyplotgen/config/VariableGroupBaseBudgetsSamStyle.pyea5b5707470c2d942cbb7081436ede1baedde7041640012072000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comUpdates to SAM-style budget plots for CLUBB output.
2021-12-20 08:54:32 -0600ea5b5707470c2d942cbb7081436ede1baedde704Updates to SAM-style budget plots for CLUBB output.editpostprocessing/pyplotgen/config/VariableGroupBaseBudgetsSamStyle.py
- input_misc/tuner/error_four_cases.insrc/error.F9032af4729f9ff1d374e03249b1b4d8d05fd8052d61640202403000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding new four-case tuner script and also some minor updates to error.F90 that avoid the "LES is zero" error for the cloud water and cloud fraction.
2021-12-22 13:46:43 -060032af4729f9ff1d374e03249b1b4d8d05fd8052d6Adding new four-case tuner script and also some minor updates to error.F90 that avoid the "LES is zero" error for the cloud water and cloud fraction.addinput_misc/tuner/error_four_cases.ineditsrc/error.F90
- src/error.F90f983171d892eb60a4d3193f71125f280169a336f1640202403000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding comments and minor cleanup for my last commit about the tuner update.
2021-12-22 13:46:43 -0600f983171d892eb60a4d3193f71125f280169a336fAdding comments and minor cleanup for my last commit about the tuner update.editsrc/error.F90
- src/error.F90c665567bd02143fd2060282ad5cb5dea6cdf26791640202403000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comUpdating error.F90 to include the error statement about LES field being zero as a check.
2021-12-22 13:46:43 -0600c665567bd02143fd2060282ad5cb5dea6cdf2679Updating error.F90 to include the error statement about LES field being zero as a check.editsrc/error.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/clubb_api_module.F90src/clubb_driver.F9074c54289ac37740b48512eecab9352c37a19a3241640706464000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdating CLUBB to pass uprcp and vprcp into and out of advance_clubb_core.
2021-12-28 09:47:44 -060074c54289ac37740b48512eecab9352c37a19a324Updating CLUBB to pass uprcp and vprcp into and out of advance_clubb_core.editsrc/clubb_driver.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/clubb_api_module.F90
- src/CLUBB_core/advance_clubb_core_module.F90517dd59a53c72aab76b5f40e078f08c7a736f0a91640706663000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduNow that uprcp and vprcp have been passed through advance_clubb_core,
I can get rid of this idiot-proofing code that stops the run when
l_predict_upwp_vpwp is enabled and the PDF is in the "post" position.
2021-12-28 09:51:03 -0600517dd59a53c72aab76b5f40e078f08c7a736f0a9Now that uprcp and vprcp have been passed through advance_clubb_core,editsrc/CLUBB_core/advance_clubb_core_module.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F909cc76af14581bda65bf71ce4d8ba4d70534cf6f51640825295000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am adding more arguments to the argument list for advance_clubb_core
so that the model now runs with the PDF in the post position.
Result from this change are still bit-for-bit.
2021-12-29 18:48:15 -06009cc76af14581bda65bf71ce4d8ba4d70534cf6f5I am adding more arguments to the argument list for advance_clubb_coreeditsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/advance_clubb_core_module.F90
- postprocessing/pyplotgen/src/CaseGallerySetup.py722d0f5d58787f4c8f9ad9c73a1004e1077c61db1640965359000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comModifying the generate subcolumn panels function to smoothly plot both CLUBB and WRF-LASSO SILHS subcolumns.
2021-12-31 09:42:39 -0600722d0f5d58787f4c8f9ad9c73a1004e1077c61dbModifying the generate subcolumn panels function to smoothly plot both CLUBB and WRF-LASSO SILHS subcolumns.editpostprocessing/pyplotgen/src/CaseGallerySetup.py
- src/CLUBB_core/model_flags.F902a9a0f2c7031013529a4c2a7b78d05c727bdc37c1641839832000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comInsert print about overwriting default flags with namelist values
2022-01-10 12:37:12 -06002a9a0f2c7031013529a4c2a7b78d05c727bdc37cInsert print about overwriting default flags with namelist valueseditsrc/CLUBB_core/model_flags.F90
- src/CLUBB_core/parameters_tunable.F90ae798c431a9c33366661af3078b56d073b16b0231641840286000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comInsert print about overwriting default parameters with namelist values
2022-01-10 12:44:46 -0600ae798c431a9c33366661af3078b56d073b16b023Insert print about overwriting default parameters with namelist valueseditsrc/CLUBB_core/parameters_tunable.F90
- README8c4c90049b075b8e615e8e08ddf101bdcddf98561641840820000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comNote that source-code flags and parameter values are overwritten by namelist values
2022-01-10 12:53:40 -06008c4c90049b075b8e615e8e08ddf101bdcddf9856Note that source-code flags and parameter values are overwritten by namelist valueseditREADME
- README1460a662e1f4056e02af076d44a22b1e5629c9871641841008000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClarify comments in README
2022-01-10 12:56:48 -06001460a662e1f4056e02af076d44a22b1e5629c987Clarify comments in READMEeditREADME
- src/CLUBB_core/clubb_api_module.F90efea5cc92bbc5ac9bca31f66f10f02f7f56eff8d1641936564000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking api version of setup_grid. larson-group/clubb#972
2022-01-11 15:29:24 -0600efea5cc92bbc5ac9bca31f66f10f02f7f56eff8dMaking api version of setup_grid. larson-group/clubb#972editsrc/CLUBB_core/clubb_api_module.F90
- src/SILHS/silhs_api_module.F909915baa6935273f632bcc611fc7aef03c1b026ff1642027821000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking some paramters_silhs variables available from the silhs api
2022-01-12 16:50:21 -06009915baa6935273f632bcc611fc7aef03c1b026ffMaking some paramters_silhs variables available from the silhs apieditsrc/SILHS/silhs_api_module.F90
- src/CLUBB_core/advance_clubb_core_module.F906f037c8025b8131ad603677a418099473fc8239a1642031683000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comComment out setting of fatal error
when l_min_xp2_from_corr_wx = F and l_enable_relaxed_clipping = F.
The goal is to allow the clubb_backwards_compatibility_gfortran_test
Jenkins test to pass again.
For #846.
2022-01-12 17:54:43 -06006f037c8025b8131ad603677a418099473fc8239aComment out setting of fatal erroreditsrc/CLUBB_core/advance_clubb_core_module.F90
- jenkins_tests/clubb_backwards_compatibility_gfortran_test/Jenkinsfilefc4a6391f4bbe5c29a9e83625f7813ccaef1fcd51642032632000http://carson.math.uwm.edu/jenkins/user/pbroelspbroelspbroels@uwm.eduAdding a step to remove idio proofing into backwards compatibility test. larson-group/sys_admin#763
2022-01-12 18:10:32 -0600fc4a6391f4bbe5c29a9e83625f7813ccaef1fcd5Adding a step to remove idio proofing into backwards compatibility test. larson-group/sys_admin#763editjenkins_tests/clubb_backwards_compatibility_gfortran_test/Jenkinsfile
githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephenshttp://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrnhttp://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldhttp://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonhttp://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens82http://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffinhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhttp://carson.math.uwm.edu/jenkins/user/pbroelspbroelsfalse34http://carson.math.uwm.edu/jenkins/view/all/job/branch_clubb_test/34/32http://carson.math.uwm.edu/jenkins/view/all/job/branch_clubb_test/32/