TESTclubb_nvhpc_gpu_vs_cpu_diffnessBRANCHorigin/masterStarted by user carstensencarstensencarstensen634b16d833e86ad23ef6ea81de67c38c596ebccd254b16d833e86ad23ef6ea81de67c38c596ebccd25refs/remotes/origin/testing_tmp4b16d833e86ad23ef6ea81de67c38c596ebccd254b16d833e86ad23ef6ea81de67c38c596ebccd25refs/remotes/origin/testing_tmp689371db00c43ef6f47c11c9efbfe310d5947b058a9371db00c43ef6f47c11c9efbfe310d5947b058arefs/remotes/origin/small_acc_tweaks9371db00c43ef6f47c11c9efbfe310d5947b058a9371db00c43ef6f47c11c9efbfe310d5947b058arefs/remotes/origin/small_acc_tweaks620186c0953e7f6297679083156ead9f5b00da48630186c0953e7f6297679083156ead9f5b00da4863refs/remotes/origin/thlm_spike_fix20186c0953e7f6297679083156ead9f5b00da48630186c0953e7f6297679083156ead9f5b00da4863refs/remotes/origin/thlm_spike_fix25027ea997494b23a928f32489161280adff334596e27ea997494b23a928f32489161280adff334596erefs/remotes/origin/py3_check_budget27ea997494b23a928f32489161280adff334596e27ea997494b23a928f32489161280adff334596erefs/remotes/origin/py3_check_budget701ac4d6b3f57c2175acb0338fa7cf5f8fc41c49081ac4d6b3f57c2175acb0338fa7cf5f8fc41c4908refs/remotes/origin/grid_interp_improvment1ac4d6b3f57c2175acb0338fa7cf5f8fc41c49081ac4d6b3f57c2175acb0338fa7cf5f8fc41c4908refs/remotes/origin/grid_interp_improvment104d3cc675ec94b531a9a6524af8e6ed3f2492b98a6d3cc675ec94b531a9a6524af8e6ed3f2492b98a6refs/remotes/origin/quick_gpu_fixd3cc675ec94b531a9a6524af8e6ed3f2492b98a6d3cc675ec94b531a9a6524af8e6ed3f2492b98a6refs/remotes/origin/quick_gpu_fix167d91585f50959eee4d0550e98b3887bde6de4310dd91585f50959eee4d0550e98b3887bde6de4310drefs/remotes/origin/mono_flux_optimizationsd91585f50959eee4d0550e98b3887bde6de4310dd91585f50959eee4d0550e98b3887bde6de4310drefs/remotes/origin/mono_flux_optimizations17300ff5e2ed346cb382fbdfe7556f0581f92d2a86500ff5e2ed346cb382fbdfe7556f0581f92d2a865refs/remotes/origin/setup_routine_gpuization00ff5e2ed346cb382fbdfe7556f0581f92d2a86500ff5e2ed346cb382fbdfe7556f0581f92d2a865refs/remotes/origin/setup_routine_gpuization1034c05e3d29e153deec2a51bf670c18be2ce88bbc04c05e3d29e153deec2a51bf670c18be2ce88bbc0refs/remotes/origin/spack_updates4c05e3d29e153deec2a51bf670c18be2ce88bbc04c05e3d29e153deec2a51bf670c18be2ce88bbc0refs/remotes/origin/spack_updates54482f6cfeafb97563bfd1f5c3f4f19a85a98b1d0f482f6cfeafb97563bfd1f5c3f4f19a85a98b1d0frefs/remotes/origin/broken_uninit_branch482f6cfeafb97563bfd1f5c3f4f19a85a98b1d0f482f6cfeafb97563bfd1f5c3f4f19a85a98b1d0frefs/remotes/origin/broken_uninit_branch161e9df61765c575546be16548d8ffb96bc03c2cef3e9df61765c575546be16548d8ffb96bc03c2cef3refs/remotes/origin/nightly_clubb_plotse9df61765c575546be16548d8ffb96bc03c2cef3e9df61765c575546be16548d8ffb96bc03c2cef3refs/remotes/origin/nightly_clubb_plots169c9c2925fe242e3154deac843a662452483698edbc9c2925fe242e3154deac843a662452483698edbrefs/remotes/origin/riZm_calc4c9c2925fe242e3154deac843a662452483698edbc9c2925fe242e3154deac843a662452483698edbrefs/remotes/origin/riZm_calc4171d8af6677bc8cc61a5063a6315caff68eabbeb171d8af6677bc8cc61a5063a6315caff68eabbeb171refs/remotes/origin/ticket_977d8af6677bc8cc61a5063a6315caff68eabbeb171d8af6677bc8cc61a5063a6315caff68eabbeb171refs/remotes/origin/ticket_97717463422545ae572c8cc0391f5aa61138d3af5d8fe463422545ae572c8cc0391f5aa61138d3af5d8fe4refs/remotes/origin/riZm_calc563422545ae572c8cc0391f5aa61138d3af5d8fe463422545ae572c8cc0391f5aa61138d3af5d8fe4refs/remotes/origin/riZm_calc517883fceff0ccd7dfa94a7095ddbf84e9e273bbddcc83fceff0ccd7dfa94a7095ddbf84e9e273bbddccrefs/remotes/origin/riZm_calc683fceff0ccd7dfa94a7095ddbf84e9e273bbddcc83fceff0ccd7dfa94a7095ddbf84e9e273bbddccrefs/remotes/origin/riZm_calc666fa32653f94a5c0392a6eb44bcbcc3629430def8cfa32653f94a5c0392a6eb44bcbcc3629430def8crefs/remotes/origin/clubb_ghost_exorcismfa32653f94a5c0392a6eb44bcbcc3629430def8cfa32653f94a5c0392a6eb44bcbcc3629430def8crefs/remotes/origin/clubb_ghost_exorcism4c2430410e13a733d23852dd5abc08bbc6b02307bc2430410e13a733d23852dd5abc08bbc6b02307brefs/remotes/origin/feeding_stats_through_arg_listc2430410e13a733d23852dd5abc08bbc6b02307bc2430410e13a733d23852dd5abc08bbc6b02307brefs/remotes/origin/feeding_stats_through_arg_list181992f5e8829951becc6070215568136a4418dbde5992f5e8829951becc6070215568136a4418dbde5refs/remotes/origin/ticket_1174992f5e8829951becc6070215568136a4418dbde5992f5e8829951becc6070215568136a4418dbde5refs/remotes/origin/ticket_11741829b72d6d80236434b434088ad5fea0bad7fdcf4999b72d6d80236434b434088ad5fea0bad7fdcf499refs/remotes/origin/master9b72d6d80236434b434088ad5fea0bad7fdcf4999b72d6d80236434b434088ad5fea0bad7fdcf499refs/remotes/origin/master9b72d6d80236434b434088ad5fea0bad7fdcf4999b72d6d80236434b434088ad5fea0bad7fdcf499refs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#18213821961102164branch_clubb_test #182182false1822595SUCCESS1726848684283http://carson.math.uwm.edu/jenkins/view/all/job/branch_clubb_test/182/- utilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/sens_matrix_dashboard.py9324242cc87f0d692e5bc39f32ac50f3be0b928b1691090871000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduFor RegTune, adds quadratic curves to three-dot plot.
For #910.
2023-08-03 14:27:51 -05009324242cc87f0d692e5bc39f32ac50f3be0b928bFor RegTune, adds quadratic curves to three-dot plot.editutilities/sens_matrix/sens_matrix_dashboard.pyeditutilities/sens_matrix/set_up_dashboard_inputs.py
- utilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/sens_matrix_dashboard.pyutilities/sens_matrix/analyze_sensitivity_matrix.py9ada7441e588502eeb7f757cd0d618d8803bd08d1691504471000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduFor RegTune, defaults to polynomial fit for sensitivity matrix
and adds observations of sea-level pressure (PSL).
For #910.
2023-08-08 09:21:11 -05009ada7441e588502eeb7f757cd0d618d8803bd08dFor RegTune, defaults to polynomial fit for sensitivity matrixeditutilities/sens_matrix/sens_matrix_dashboard.pyeditutilities/sens_matrix/set_up_dashboard_inputs.pyeditutilities/sens_matrix/analyze_sensitivity_matrix.py
- utilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/sens_matrix_dashboard.pyutilities/sens_matrix/analyze_sensitivity_matrix.pyb0101dc46f5324451c8273188032bda60d135e411691525024000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduIn RegTune, normalizes metrics by a user-specified number
rather than the observed value of the metric.
For #910.
2023-08-08 15:03:44 -0500b0101dc46f5324451c8273188032bda60d135e41In RegTune, normalizes metrics by a user-specified numbereditutilities/sens_matrix/sens_matrix_dashboard.pyeditutilities/sens_matrix/analyze_sensitivity_matrix.pyeditutilities/sens_matrix/set_up_dashboard_inputs.py
- utilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/analyze_sensitivity_matrix.pyutilities/sens_matrix/sens_matrix_dashboard.pyedccdfbf9c5f8ed7c089bee46e30801098af88411692193698000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduFor RegTune, adds color-coded matrix of correlations among parameter vectors.
Also, this commit separates the three-dot panel plot into its own function.
For #910.
2023-08-16 08:48:18 -0500edccdfbf9c5f8ed7c089bee46e30801098af8841For RegTune, adds color-coded matrix of correlations among parameter vectors.editutilities/sens_matrix/analyze_sensitivity_matrix.pyeditutilities/sens_matrix/set_up_dashboard_inputs.pyeditutilities/sens_matrix/sens_matrix_dashboard.py
- utilities/sens_matrix/sens_matrix_dashboard.py31f76a7219f3ed336cc7b2b1159cae4781e672891692200526000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduFor clarity, renames figures in RegTune.
For #910.
2023-08-16 10:42:06 -050031f76a7219f3ed336cc7b2b1159cae4781e67289For clarity, renames figures in RegTune.editutilities/sens_matrix/sens_matrix_dashboard.py
- utilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/sens_matrix_dashboard.pyutilities/sens_matrix/analyze_sensitivity_matrix.py3ac0cb6b68cff942267f3230f210eaab5aedc1821692223459000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduCreates new function, setUpPreliminaries, in RegTune.
setUpPreliminaries calculates some basic quantities
that are used later.
As part of this refactoring, a number of functions
were moved from analyze_sensitivity_matrix to
set_up_dashboard_inputs.
For #910.
2023-08-16 17:04:19 -05003ac0cb6b68cff942267f3230f210eaab5aedc182Creates new function, setUpPreliminaries, in RegTune.editutilities/sens_matrix/sens_matrix_dashboard.pyeditutilities/sens_matrix/set_up_dashboard_inputs.pyeditutilities/sens_matrix/analyze_sensitivity_matrix.py
- utilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/sens_matrix_dashboard.py9d35ffa7e05b85efb23d21700bcf355f007c2b7d1692308947000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduFor RegTune, adds capability to prescribe (not tune) a parameter
to a value that is different from the default.
The code has not been checked, but it does run and produce plots.
For #910.
2023-08-17 16:49:07 -05009d35ffa7e05b85efb23d21700bcf355f007c2b7dFor RegTune, adds capability to prescribe (not tune) a parametereditutilities/sens_matrix/set_up_dashboard_inputs.pyeditutilities/sens_matrix/sens_matrix_dashboard.py
- utilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/sens_matrix_dashboard.pyutilities/sens_matrix/analyze_sensitivity_matrix.pyad7158d4527e636e07a389e813d60013ab2afccb1692390497000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduHides print statements in RegTune by using beVerbose=False.
For #910.
2023-08-18 15:28:17 -0500ad7158d4527e636e07a389e813d60013ab2afccbHides print statements in RegTune by using beVerbose=False.editutilities/sens_matrix/sens_matrix_dashboard.pyeditutilities/sens_matrix/analyze_sensitivity_matrix.pyeditutilities/sens_matrix/set_up_dashboard_inputs.py
- utilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/sens_matrix_dashboard.py8f7ec02116293f4a2f09d5a92edbf87e56686e5e1692643528000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduFixes bug in QuadTune's code that prescribes parameter values.
Also fixes divide-by-zero warning message in dpMin2Pt plotting code.
For #910.
2023-08-21 13:45:28 -05008f7ec02116293f4a2f09d5a92edbf87e56686e5eFixes bug in QuadTune's code that prescribes parameter values.editutilities/sens_matrix/sens_matrix_dashboard.pyeditutilities/sens_matrix/set_up_dashboard_inputs.py
- utilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/analyze_sensitivity_matrix.pyutilities/sens_matrix/sens_matrix_dashboard.pya1bc7132bad1616530c67bbf98b3d0ccfa3e0dc01692818119000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduAdds basic cost function printouts to QuadTune.
Also adds SWCF_RMSE metric.
For #910.
2023-08-23 14:15:19 -0500a1bc7132bad1616530c67bbf98b3d0ccfa3e0dc0Adds basic cost function printouts to QuadTune.editutilities/sens_matrix/analyze_sensitivity_matrix.pyeditutilities/sens_matrix/set_up_dashboard_inputs.pyeditutilities/sens_matrix/sens_matrix_dashboard.py
- utilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/sens_matrix_dashboard.pyutilities/sens_matrix/analyze_sensitivity_matrix.pybb786ccdfdd654621de358074de535e815b1353d1693606359000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: refactored to use more subroutines
and added a bar chart of column vectors (one per tuning parameter.)
For #910.
2023-09-01 17:12:39 -0500bb786ccdfdd654621de358074de535e815b1353dQuadTune: refactored to use more subroutineseditutilities/sens_matrix/set_up_dashboard_inputs.pyeditutilities/sens_matrix/sens_matrix_dashboard.pyeditutilities/sens_matrix/analyze_sensitivity_matrix.py
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_helper_module.F90src/error.F90c1f62c5040949404906f8d13ecb9cf7ee88f4ce51693937947000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comFixed some oversights for the bv_efold commits and increased string length for tuning field names for invrs_tau variables - CLUBB ticket #1069 (#1106)
This commit is NOT bit changing
- Removed remaining mentions of brunt_vaisala_freq_sqd_plus
- Added assignment for invrs_tau_wp3_zm in Lscale mode in advance_clubb_core
- Increased length of string variables hoc_v, les_v, and t_variables in src/error.F90 to accomodate tuning for invrs_tau fields
2023-09-05 13:19:07 -0500c1f62c5040949404906f8d13ecb9cf7ee88f4ce5Fixed some oversights for the bv_efold commits and increased string length for tuning field names for invrs_tau variables - CLUBB ticket #1069 (#1106)editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/error.F90
- src/CLUBB_core/mixing_length.F90346643e9a3d430e30182bc4b244f6251fdf50b9e1693950812000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comBIT_CHANGING! brunt_vaisala_freq_sqd_mixed now replaces brunt_vaisala_freq_sqd for later calculations - CLUBB ticket #1102
Changes in src/CLUBB_core/mixing_length.F90:
- brunt_vaisala_freq_sqd_mixed is now used to calculate brunt_vaisala_freq_sqd_smth and brunt_vaisala_freq_sqd_clipped instead of brunt_vaisala_freq_sqd
- Removed 0.1 factor for bkgnd term in calculation of invrs_tau_xp2_zm
- Commented out clipping of invrs_tau_xp2_zm to 0.003 and lower out of cloud
2023-09-05 16:53:32 -0500346643e9a3d430e30182bc4b244f6251fdf50b9eBIT_CHANGING! brunt_vaisala_freq_sqd_mixed now replaces brunt_vaisala_freq_sqd for later calculations - CLUBB ticket #1102editsrc/CLUBB_core/mixing_length.F90
- postprocessing/pyplotgen/config/VariableGroupBaseBudgetsLumpedBuoy.pypostprocessing/pyplotgen/README.mdpostprocessing/pyplotgen/src/CaseGallerySetup.pypostprocessing/pyplotgen/pyplotgen.py35388814c501b3b4754806ecdb494cbcadc77d0a1694154859000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAdded option to plot "Lumped Buoyance Budgets" (wpxp_bp combined with
wpxp_pr3) to the pyplotgen plotter for CLUBB.
2023-09-08 01:34:19 -050035388814c501b3b4754806ecdb494cbcadc77d0aAdded option to plot "Lumped Buoyance Budgets" (wpxp_bp combined withaddpostprocessing/pyplotgen/config/VariableGroupBaseBudgetsLumpedBuoy.pyeditpostprocessing/pyplotgen/src/CaseGallerySetup.pyeditpostprocessing/pyplotgen/README.mdeditpostprocessing/pyplotgen/pyplotgen.py
- postprocessing/pyplotgen/src/CaseGallerySetup.pydb8ea9192a6aa0da6612223ebf569e46f293c92d1694155550000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAdded a statement that I had previously omitted. The new combined budget
works great!
2023-09-08 01:45:50 -0500db8ea9192a6aa0da6612223ebf569e46f293c92dAdded a statement that I had previously omitted. The new combined budgeteditpostprocessing/pyplotgen/src/CaseGallerySetup.py
- postprocessing/pyplotgen/src/Panel.pypostprocessing/pyplotgen/src/VariableGroup.py616669cf5f2194502e9ecbafb2d267635d439c321694492156000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdating pyplotgen to include a "contour" plot of rcm in the background.
This will be made optional with the next commit.
2023-09-11 23:15:56 -0500616669cf5f2194502e9ecbafb2d267635d439c32Updating pyplotgen to include a "contour" plot of rcm in the background.editpostprocessing/pyplotgen/src/Panel.pyeditpostprocessing/pyplotgen/src/VariableGroup.py
- postprocessing/pyplotgen/config/VariableGroupWs.pypostprocessing/pyplotgen/src/Panel.pypostprocessing/pyplotgen/README.mdpostprocessing/pyplotgen/pyplotgen.pypostprocessing/pyplotgen/config/VariableGroupBase.pypostprocessing/pyplotgen/src/VariableGroup.pypostprocessing/pyplotgen/src/CaseGallerySetup.py09e01df1a3bf71ada4cc050fa3f0d52f285b60281694548709000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added the --background-rcm optional flag to pyplotgen.
2023-09-12 14:58:29 -050009e01df1a3bf71ada4cc050fa3f0d52f285b6028I added the --background-rcm optional flag to pyplotgen.editpostprocessing/pyplotgen/README.mdeditpostprocessing/pyplotgen/config/VariableGroupWs.pyeditpostprocessing/pyplotgen/src/VariableGroup.pyeditpostprocessing/pyplotgen/pyplotgen.pyeditpostprocessing/pyplotgen/src/Panel.pyeditpostprocessing/pyplotgen/src/CaseGallerySetup.pyeditpostprocessing/pyplotgen/config/VariableGroupBase.py
- postprocessing/pyplotgen/config/VariableGroupSubcolumns.pypostprocessing/pyplotgen/config/VariableGroupBaseBudgets.pypostprocessing/pyplotgen/config/VariableGroupLiquidMP.pypostprocessing/pyplotgen/config/VariableGroupCorrelations.pypostprocessing/pyplotgen/config/VariableGroupTaus.pypostprocessing/pyplotgen/config/VariableGroupKKMP.pypostprocessing/pyplotgen/config/VariableGroupNormalizedVariations.pypostprocessing/pyplotgen/config/VariableGroupSamBudgets.pypostprocessing/pyplotgen/config/VariableGroupNondimMoments.pypostprocessing/pyplotgen/config/VariableGroupIceMP.pypostprocessing/pyplotgen/config/VariableGroupSamMultilineProfiles.pypostprocessing/pyplotgen/config/VariableGroupBaseBudgetsLumpedBuoy.pypostprocessing/pyplotgen/config/VariableGroupSamProfiles.pypostprocessing/pyplotgen/config/VariableGroupScalars.pypostprocessing/pyplotgen/config/VariableGroupBaseBudgetsSamStyle.pycbbd5fc72fb563eb89430f77b0d790b32aea1a4c1694570526000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduSmall additions that allow all cases to run with pyplotgen.
2023-09-12 21:02:06 -0500cbbd5fc72fb563eb89430f77b0d790b32aea1a4cSmall additions that allow all cases to run with pyplotgen.editpostprocessing/pyplotgen/config/VariableGroupScalars.pyeditpostprocessing/pyplotgen/config/VariableGroupTaus.pyeditpostprocessing/pyplotgen/config/VariableGroupKKMP.pyeditpostprocessing/pyplotgen/config/VariableGroupIceMP.pyeditpostprocessing/pyplotgen/config/VariableGroupLiquidMP.pyeditpostprocessing/pyplotgen/config/VariableGroupSubcolumns.pyeditpostprocessing/pyplotgen/config/VariableGroupBaseBudgetsLumpedBuoy.pyeditpostprocessing/pyplotgen/config/VariableGroupBaseBudgetsSamStyle.pyeditpostprocessing/pyplotgen/config/VariableGroupBaseBudgets.pyeditpostprocessing/pyplotgen/config/VariableGroupSamBudgets.pyeditpostprocessing/pyplotgen/config/VariableGroupSamProfiles.pyeditpostprocessing/pyplotgen/config/VariableGroupNondimMoments.pyeditpostprocessing/pyplotgen/config/VariableGroupNormalizedVariations.pyeditpostprocessing/pyplotgen/config/VariableGroupCorrelations.pyeditpostprocessing/pyplotgen/config/VariableGroupSamMultilineProfiles.py
- postprocessing/pyplotgen/src/VariableGroup.py693a178ea4becdb7f4950d8406c89a4953bdbbcd1694570977000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduNeeded to remove a print statement.
2023-09-12 21:09:37 -0500693a178ea4becdb7f4950d8406c89a4953bdbbcdNeeded to remove a print statement.editpostprocessing/pyplotgen/src/VariableGroup.py
- postprocessing/pyplotgen/config/VariableGroupSubcolumns.pypostprocessing/pyplotgen/config/VariableGroupWs.pypostprocessing/pyplotgen/config/VariableGroupBaseBudgets.pypostprocessing/pyplotgen/config/VariableGroupLiquidMP.pypostprocessing/pyplotgen/config/VariableGroupCorrelations.pypostprocessing/pyplotgen/config/VariableGroupTaus.pypostprocessing/pyplotgen/config/VariableGroupNormalizedVariations.pypostprocessing/pyplotgen/config/VariableGroupKKMP.pypostprocessing/pyplotgen/config/VariableGroupBase.pypostprocessing/pyplotgen/config/VariableGroupSamBudgets.pypostprocessing/pyplotgen/config/VariableGroupNondimMoments.pypostprocessing/pyplotgen/config/VariableGroupIceMP.pypostprocessing/pyplotgen/config/VariableGroupSamMultilineProfiles.pypostprocessing/pyplotgen/config/VariableGroupBaseBudgetsLumpedBuoy.pypostprocessing/pyplotgen/config/VariableGroupSamProfiles.pypostprocessing/pyplotgen/config/VariableGroupScalars.pypostprocessing/pyplotgen/src/VariableGroup.pypostprocessing/pyplotgen/src/CaseGallerySetup.pypostprocessing/pyplotgen/config/VariableGroupBaseBudgetsSamStyle.pyf974d0717da12952984f5f165abf99e4f15861151694628419000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduIn the previous commits for the --background-rcm option of pyplotgen,
I had previously thought that the code to extract values of rcm from
a file wanted the case name as input, but in actuality it required
the directory name instead of the case name. I am correcting that
error in this commitment.
2023-09-13 13:06:59 -0500f974d0717da12952984f5f165abf99e4f1586115In the previous commits for the --background-rcm option of pyplotgen,editpostprocessing/pyplotgen/config/VariableGroupBaseBudgets.pyeditpostprocessing/pyplotgen/config/VariableGroupNormalizedVariations.pyeditpostprocessing/pyplotgen/config/VariableGroupBase.pyeditpostprocessing/pyplotgen/config/VariableGroupSamProfiles.pyeditpostprocessing/pyplotgen/config/VariableGroupScalars.pyeditpostprocessing/pyplotgen/config/VariableGroupTaus.pyeditpostprocessing/pyplotgen/config/VariableGroupWs.pyeditpostprocessing/pyplotgen/config/VariableGroupSamBudgets.pyeditpostprocessing/pyplotgen/config/VariableGroupNondimMoments.pyeditpostprocessing/pyplotgen/config/VariableGroupCorrelations.pyeditpostprocessing/pyplotgen/src/VariableGroup.pyeditpostprocessing/pyplotgen/src/CaseGallerySetup.pyeditpostprocessing/pyplotgen/config/VariableGroupLiquidMP.pyeditpostprocessing/pyplotgen/config/VariableGroupBaseBudgetsSamStyle.pyeditpostprocessing/pyplotgen/config/VariableGroupSamMultilineProfiles.pyeditpostprocessing/pyplotgen/config/VariableGroupBaseBudgetsLumpedBuoy.pyeditpostprocessing/pyplotgen/config/VariableGroupKKMP.pyeditpostprocessing/pyplotgen/config/VariableGroupIceMP.pyeditpostprocessing/pyplotgen/config/VariableGroupSubcolumns.py
- postprocessing/pyplotgen/src/Panel.py1510c34473a4c7b51f7dd08fb75cff28c701af071694633655000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am updating the --background-rcm option of pyplotgen to make two
changes:
1) Use a grayscale color map.
2) Set the maximum of the colorbar to be twice the largest value in
the rcm plot so that the colors aren't so dark.
2023-09-13 14:34:15 -05001510c34473a4c7b51f7dd08fb75cff28c701af07I am updating the --background-rcm option of pyplotgen to make twoeditpostprocessing/pyplotgen/src/Panel.py
- input/tunable_parameters_Lscale/configurable_model_flags.insrc/CLUBB_core/model_flags.F90e29d9d7e6d8b2857cd4f85382d189b21c31332b71694635856000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comBIT_CHANGING for lscale setup. Updated configurable_model_flags.in and model_flags.F90 - CLUBB ticket #1102 (#1108)
- Added new flags to inut/tunable_parameters_Lscale/configurable_model_flags.in
- Changed default setting for l_use_tke_in_wp3_pr_turb_term in model_flags.F90 from false to true
2023-09-13 15:10:56 -0500e29d9d7e6d8b2857cd4f85382d189b21c31332b7BIT_CHANGING for lscale setup. Updated configurable_model_flags.in and model_flags.F90 - CLUBB ticket #1102 (#1108)editsrc/CLUBB_core/model_flags.F90editinput/tunable_parameters_Lscale/configurable_model_flags.in
- utilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/sens_matrix_dashboard.pyfb63ca4ea140c4abedef5567d8c33c331cce9ec11694692835000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Adds chisqd metric and bar chart for a global run.
linSolnBiasesCol has been redefined to mean simulation - obs.
For #910.
2023-09-14 07:00:35 -0500fb63ca4ea140c4abedef5567d8c33c331cce9ec1QuadTune: Adds chisqd metric and bar chart for a global run.editutilities/sens_matrix/sens_matrix_dashboard.pyeditutilities/sens_matrix/set_up_dashboard_inputs.py
- utilities/sens_matrix/sens_matrix_dashboard.py5ed8fb8308e908d83cc8c9c34c61b80b0449a9951695125054000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: adds commented-out attempt to vary the bar base
but it's not working yet.
For #910.
2023-09-19 07:04:14 -05005ed8fb8308e908d83cc8c9c34c61b80b0449a995QuadTune: adds commented-out attempt to vary the bar baseeditutilities/sens_matrix/sens_matrix_dashboard.py
- src/CLUBB_core/advance_clubb_core_module.F90postprocessing/pyplotgen/config/VariableGroupTaus.pyinput/stats/standard_stats.insrc/CLUBB_core/stats_variables.F90input/stats/all_stats.insrc/CLUBB_core/stats_zm_module.F901a81400d8f997d9c9b3a128a4cf4a001dd849b3e1695154187000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comLikely BIT_CHANGING because of added output fields. Added code outputting C6_term and different Brunt Vaisala frequencies to disk - CLUBB ticket #1102 (#1109)
- Added C6_term and bv_freq fields to all_stats.F90 and standard_stats.F90
- Added new fields to VariableGroupTaus.py in pyplotgen
- Added calls to stat_update_var to advance_clubb_core_module.F90
- Modified stats_variables.F90 and stats_zm_module.F90 accordingly
2023-09-19 15:09:47 -05001a81400d8f997d9c9b3a128a4cf4a001dd849b3eLikely BIT_CHANGING because of added output fields. Added code outputting C6_term and different Brunt Vaisala frequencies to disk - CLUBB ticket #1102 (#1109)editinput/stats/standard_stats.ineditsrc/CLUBB_core/stats_variables.F90editinput/stats/all_stats.ineditsrc/CLUBB_core/advance_clubb_core_module.F90editpostprocessing/pyplotgen/config/VariableGroupTaus.pyeditsrc/CLUBB_core/stats_zm_module.F90
- src/CLUBB_core/advance_clubb_core_module.F90input/stats/standard_stats.insrc/CLUBB_core/stats_variables.F90src/CLUBB_core/mixing_length.F90input/stats/all_stats.insrc/CLUBB_core/stats_zm_module.F906654de29a1f573a0a6562d29393a4e18eeabd2ef1695421268000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comChanged sqrt_Ri_zm to Ri_zm in preparation of changing the exponent for calculation of invrs_tau_wpxp_zm in mixing_length.F90 - CLUBB ticket #1102 (#1110)
BIT_CHANGING! Changed sqrt_Ri_zm to Ri_zm in preparation of changing the exponent for calculation of invrs_tau_wpxp_zm in mixing_length.F90 - CLUBB ticket #1102
Changes in input/stats/all_stats.in, src/CLUBB_core/advance_clubb_core_module.F90, src/CLUBB_core/mixing_length.F90, src/CLUBB_core/stats_variables.F90, and src/CLUBB_core/stats_zm_module.F90
Ri_zm was added to input/stats/standard_stats.in
2023-09-22 17:21:08 -05006654de29a1f573a0a6562d29393a4e18eeabd2efChanged sqrt_Ri_zm to Ri_zm in preparation of changing the exponent for calculation of invrs_tau_wpxp_zm in mixing_length.F90 - CLUBB ticket #1102 (#1110)editsrc/CLUBB_core/advance_clubb_core_module.F90editinput/stats/all_stats.ineditinput/stats/standard_stats.ineditsrc/CLUBB_core/stats_variables.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/stats_zm_module.F90
- postprocessing/pyplotgen/config/VariableGroupTaus.pysrc/CLUBB_core/advance_helper_module.F90src/CLUBB_core/stats_variables.F90input/stats/all_stats.insrc/CLUBB_core/stats_zm_module.F90405d449ae8bc9a7dad1b37fe5cb4964e397bd92e1695428333000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comBIT_CHANGING! Removed Richardson_num and all corresponding code - CLUBB ticket #1102 (#1111)
This commit is BIT_CHANGING because:
1. the output field Richardson_num was removed.
2. Since the flag l_use_shear_turb_freq_sqd was removed, the variable shear_sqd is now always written to disk. That means previously, the outputted field shear_sqd was 0 everywhere whereas now it is not anymore. The calculation of shear_sqd within CLUBB did not change!
- Removed mentions in input/stats/all_stats.in and standards_stats.in
- Removed mentions in src/CLUBB_core/stats_variables.F90 and stats_zm_module.F90
- In src/CLUBB_core/advance_helper_module.F90 removed mentions to [i]Richardson_num[_clipped], as well as l_use_shear_turb_freq_sqd, l_Richardson_vert_avg, and turb_freq_sqd sinc those are only used for calculation of Richardson_num.
2023-09-22 19:18:53 -0500405d449ae8bc9a7dad1b37fe5cb4964e397bd92eBIT_CHANGING! Removed Richardson_num and all corresponding code - CLUBB ticket #1102 (#1111)editsrc/CLUBB_core/stats_variables.F90editpostprocessing/pyplotgen/config/VariableGroupTaus.pyeditinput/stats/all_stats.ineditsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/stats_zm_module.F90
- utilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/sens_matrix_dashboard.pycb5a053323264071fc1a7862137cfd2a06193b191695677623000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Adds fnc to plot a horizonal bar chart for metrics.
For #910
2023-09-25 16:33:43 -0500cb5a053323264071fc1a7862137cfd2a06193b19QuadTune: Adds fnc to plot a horizonal bar chart for metrics.editutilities/sens_matrix/set_up_dashboard_inputs.pyeditutilities/sens_matrix/sens_matrix_dashboard.py
- utilities/sens_matrix/sens_matrix_dashboard.pya4f7432f4f85c2ec4f9d97d723f9574cc13206231695694497000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Includes full perturbation in params bar chart
2023-09-25 21:14:57 -0500a4f7432f4f85c2ec4f9d97d723f9574cc1320623QuadTune: Includes full perturbation in params bar charteditutilities/sens_matrix/sens_matrix_dashboard.py
- utilities/sens_matrix/sens_matrix_dashboard.py59786b03dd4afb944e5e9284a2b207220122dbb91696287802000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Adds new parameter correlation matrix plot.
For #910.
2023-10-02 18:03:22 -050059786b03dd4afb944e5e9284a2b207220122dbb9QuadTune: Adds new parameter correlation matrix plot.editutilities/sens_matrix/sens_matrix_dashboard.py
- run_scripts/RUN_CASESrun_scripts/run_bindiff_all.pyinput/stats/standard_stats.inrun_scripts/run_scm.bashinput/stats/all_stats.in6de84c3d28a538d620009cbe3d98a634782820be1696965177000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comMajor overhaul of run_bindiff_all.py
CLUBB ticket #1102 - pull request #1113
- Changed the outputs to be more evocative and differentiating between types of differences: Now we can distinguish between differences in the set of variables or differences in specific variables
- Fixed the issue where a variable that appears in only one of the compared files would either not be detected or cause the script to crash, depending on the order of input.
- Changed file output structure
- Changed case handling depending on existing files:
- Case is still treated even if it is commented in RUN_CASES
- Case is still treated even if not all files exist and messages are printed accordingly
2023-10-10 14:12:57 -05006de84c3d28a538d620009cbe3d98a634782820beMajor overhaul of run_bindiff_all.pyeditinput/stats/all_stats.ineditrun_scripts/run_scm.basheditrun_scripts/run_bindiff_all.pyeditinput/stats/standard_stats.ineditrun_scripts/RUN_CASES
- input_misc/tuner/error_atex.ininput_misc/tuner/error_rico.ininput_misc/tuner/error_gabls3_night.ininput_misc/tuner/error_nov11_altocu.ininput_misc/tuner/error_four_cases.insrc/CLUBB_core/mixing_length.F90input_misc/tuner/error_dycoms2_rf02_ds.ininput_misc/tuner/error_dycoms2_rf01.insrc/clubb_standalone.F90input_misc/tuner/error_wangara.insrc/G_unit_test_types/pdf_parameter_tests.F90input/tunable_parameters/tunable_parameters.ininput_misc/tuner/error_dycoms2_rf02_do.insrc/CLUBB_core/parameter_indices.F90input_misc/tuner/error_dycoms2_rf02_nd.ininput_misc/tuner/error_arm.insrc/CLUBB_core/parameters_tunable.F90src/G_unit_test_types/spurious_source_test.F90input_misc/tuner/error_bomex.insrc/clubb_thread_test.F90src/jacobian.F90input_misc/tuner/error_all.ininput_misc/tuner/error_arm_97.ininput_misc/tuner/error_lba.insrc/CLUBB_core/clubb_api_module.F90src/error.F90input_misc/tuner/error_fire.ininput_misc/tuner/error_gabls2.ininput_misc/tuner/error_ticket_756.inf7a5473a232f30408d811214f1b190beeeb60dbf1697137474000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comTunable Richardson number exponent - CLUBB ticket #1102 (#1114)
BIT_CHANGING! Added the exponent to the Richardson number in the calculation of the invrs_tau_wpxp threshold term in src/CLUBB_core/mixing_length.F90 to the list of tunable parameters.
This is bit changing due to the difference in Fortran between taking the sqrt and the .5th power.
2023-10-12 14:04:34 -0500f7a5473a232f30408d811214f1b190beeeb60dbfTunable Richardson number exponent - CLUBB ticket #1102 (#1114)editinput_misc/tuner/error_arm.ineditinput_misc/tuner/error_dycoms2_rf02_ds.ineditinput_misc/tuner/error_dycoms2_rf02_nd.ineditsrc/error.F90editinput_misc/tuner/error_atex.ineditinput_misc/tuner/error_fire.ineditinput_misc/tuner/error_wangara.ineditsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/jacobian.F90editsrc/CLUBB_core/clubb_api_module.F90editinput_misc/tuner/error_ticket_756.ineditsrc/clubb_standalone.F90editinput_misc/tuner/error_four_cases.ineditinput_misc/tuner/error_all.ineditinput_misc/tuner/error_arm_97.ineditinput_misc/tuner/error_nov11_altocu.ineditsrc/CLUBB_core/mixing_length.F90editsrc/clubb_thread_test.F90editinput_misc/tuner/error_dycoms2_rf02_do.ineditinput_misc/tuner/error_rico.ineditinput_misc/tuner/error_gabls3_night.ineditinput_misc/tuner/error_lba.ineditsrc/CLUBB_core/parameter_indices.F90editsrc/G_unit_test_types/spurious_source_test.F90editinput/tunable_parameters/tunable_parameters.ineditinput_misc/tuner/error_gabls2.ineditinput_misc/tuner/error_bomex.ineditinput_misc/tuner/error_dycoms2_rf01.ineditsrc/CLUBB_core/parameters_tunable.F90
- README2358af6c221f109c86a08abd4f931d2b9bf3eb621697554789000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemoves blank line in order to trigger nightly tests.
2023-10-17 09:59:49 -05002358af6c221f109c86a08abd4f931d2b9bf3eb62Removes blank line in order to trigger nightly tests.editREADME
- src/CLUBB_core/advance_clubb_core_module.F9015c23aa0933af85cc5c0d07485d212d16caf32ad1697555413000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comDeletes svn id tag, will trigger host-model nightly tests.
2023-10-17 10:10:13 -050015c23aa0933af85cc5c0d07485d212d16caf32adDeletes svn id tag, will trigger host-model nightly tests.editsrc/CLUBB_core/advance_clubb_core_module.F90
- src/CLUBB_core/advance_helper_module.F908ac8b4b85ad54142546809eb769fcd978e459be11697723854000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemove svn id tag in order to trigger nightly tests.
2023-10-19 08:57:34 -05008ac8b4b85ad54142546809eb769fcd978e459be1Remove svn id tag in order to trigger nightly tests.editsrc/CLUBB_core/advance_helper_module.F90
- src/CLUBB_core/advance_windm_edsclrm_module.F90d2c14c9ed1141dfd9410b5f4b58b62b77547baca1697732821000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemoved 3rd svn id tag in order to trigger nightly tests
2023-10-19 11:27:01 -0500d2c14c9ed1141dfd9410b5f4b58b62b77547bacaRemoved 3rd svn id tag in order to trigger nightly testseditsrc/CLUBB_core/advance_windm_edsclrm_module.F90
- src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/stats_variables.F90src/advance_microphys_module.F90src/CLUBB_core/stats_clubb_utilities.F90aaad88e68620248c5f8c728ec64bdc936fced30e1698188257000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comFinally removing scratch variables. (#1116)
* Finally removing scratch variables.
* Zeroing out below ground levels to prevent NaN in stats.
2023-10-24 17:57:37 -0500aaad88e68620248c5f8c728ec64bdc936fced30eFinally removing scratch variables. (#1116)editsrc/CLUBB_core/stats_variables.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/stats_clubb_utilities.F90editsrc/advance_microphys_module.F90
- run_scripts/run_bindiff_all.pya303b16f68a765506741747704be2f3f4bf26c2e1698259166000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking run_bindiff_all.py an executable.
2023-10-25 13:39:26 -0500a303b16f68a765506741747704be2f3f4bf26c2eMaking run_bindiff_all.py an executable.editrun_scripts/run_bindiff_all.py
- utilities/sens_matrix/sens_matrix_dashboard.py025ae22bbb833bc0fdc786857915c673941ef29f1698341660000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Imposes lower bound of 0 on tuned parameter values.
For #910.
2023-10-26 12:34:20 -0500025ae22bbb833bc0fdc786857915c673941ef29fQuadTune: Imposes lower bound of 0 on tuned parameter values.editutilities/sens_matrix/sens_matrix_dashboard.py
- utilities/sens_matrix/sens_matrix_dashboard.py1baa5eece206ee0ce52fcdcc487e737aa34c87991698442309000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Adds marker for residual bias on metrics bar chart.
For #910.
2023-10-27 16:31:49 -05001baa5eece206ee0ce52fcdcc487e737aa34c8799QuadTune: Adds marker for residual bias on metrics bar chart.editutilities/sens_matrix/sens_matrix_dashboard.py
- utilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/sens_matrix_dashboard.pyc4b477cbb4e60bfaa2de7ca9afa404ab96d026fa1698506973000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Updates setup to reproduce results from sens0707 sample 34.
For #910.
2023-10-28 10:29:33 -0500c4b477cbb4e60bfaa2de7ca9afa404ab96d026faQuadTune: Updates setup to reproduce results from sens0707 sample 34.editutilities/sens_matrix/set_up_dashboard_inputs.pyeditutilities/sens_matrix/sens_matrix_dashboard.py
- run_scripts/run_bindiff_all.pyinput/tunable_parameters_tauMatchLscale/configurable_model_flags.insrc/CLUBB_core/mixing_length.F90input/tunable_parameters_tauMatchLscale/tunable_parameters.in12364631b5749635e3cb3e50974ddab3a7fe5d4e1698787332000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comLatest batch of non-bit changing code changes - CLUBB ticket #1115 (#1119)
- Added new folder input/tunable_parameters_tauMatchLscale/ for latest taus code setup reproducing the master Lscale output.
- Changes in src/CLUBB_core_mixing_length.F90:
- Renamed ddzt_umvm -> ddzt_umvm_sqd
ddzt_umvm_clipped -> ddzt_umvm_sqd_clipped
sqrt_ddzt_umvm -> norm_ddzt_umvm
smooth_sqrt_ddzt_umvm -> smooth_norm_ddzt_umvm
Ri_zm_clipped -> Ri_zm_smooth in some places
- Made some variable replacements for consistency's sake
- Fixed path of log files in run_scripts/run_bindiff_all.py
2023-10-31 16:22:12 -050012364631b5749635e3cb3e50974ddab3a7fe5d4eLatest batch of non-bit changing code changes - CLUBB ticket #1115 (#1119)editrun_scripts/run_bindiff_all.pyaddinput/tunable_parameters_tauMatchLscale/configurable_model_flags.ineditsrc/CLUBB_core/mixing_length.F90addinput/tunable_parameters_tauMatchLscale/tunable_parameters.in
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/mixing_length.F90input/tunable_parameters_tauMatchLscale/tunable_parameters.in05a4556763f089ac3afdb1aeb032e827040cc8741698795774000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comBIT_CHANGING! Fixed some issues with wpxp_Ri_exp, changed z_displace value - CLUBB ticket #1115 (#1120)
- Removed commented lines from tunable_parameters.in file in input/tunable_parameters_tauMatchLscale
- Increased z_displace value from 10 to 25. This value was chosen so that the taus code with the parameter and flag settings in input/tunable_parameters_tauMatchLscale match the master Lscale output below clouds
- Fixed some issues with the new parameter wpxp_Ri_exp:
- Moved new exponentiation to a place so that it emulates the previous version with sqrt(Ri_zm)
- Adjusted code for l_smooth_min_max=true to match the default version
2023-10-31 18:42:54 -050005a4556763f089ac3afdb1aeb032e827040cc874BIT_CHANGING! Fixed some issues with wpxp_Ri_exp, changed z_displace value - CLUBB ticket #1115 (#1120)editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/mixing_length.F90editinput/tunable_parameters_tauMatchLscale/tunable_parameters.in
- src/CLUBB_core/parameters_tunable.F90src/G_unit_test_types/spurious_source_test.F90src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F90d8f2de7144923bda3de7c3d1995433caa88778211699478932000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdated CLUBB so that adj_low_res_nu (which can be called on its own
or called through calling setup_parameters) no longer uses
momentum_heights and thermodynamic_heights, but rather makes use
of gr%zm and gr%zt, which are always set and available by the
time the calls are made.
2023-11-08 15:28:52 -0600d8f2de7144923bda3de7c3d1995433caa8877821Updated CLUBB so that adj_low_res_nu (which can be called on its owneditsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/parameters_tunable.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/clubb_driver.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/G_unit_test_types/spurious_source_test.F90src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/grid_class.F9084ce1af7b0d5df14062d543b1cf684bea914378e1699486824000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduRemoving begin_height and end_height as outputs from setup_grid. They
are only necessary as local variables inside of setup_grid.
2023-11-08 17:40:24 -060084ce1af7b0d5df14062d543b1cf684bea914378eRemoving begin_height and end_height as outputs from setup_grid. Theyeditsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/grid_class.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/clubb_driver.F90
- input_misc/tuner/error_atex.ininput_misc/tuner/error_rico.ininput_misc/tuner/error_gabls3_night.ininput_misc/tuner/error_nov11_altocu.ininput_misc/tuner/error_four_cases.insrc/CLUBB_core/mixing_length.F90input_misc/tuner/error_dycoms2_rf01.ininput_misc/tuner/error_dycoms2_rf02_ds.insrc/clubb_standalone.F90input_misc/tuner/error_wangara.ininput/tunable_parameters_tauMatchLscale/tunable_parameters.insrc/G_unit_test_types/pdf_parameter_tests.F90input/tunable_parameters/tunable_parameters.ininput_misc/tuner/error_dycoms2_rf02_do.insrc/CLUBB_core/parameter_indices.F90input_misc/tuner/error_dycoms2_rf02_nd.ininput_misc/tuner/error_arm.insrc/CLUBB_core/parameters_tunable.F90src/G_unit_test_types/spurious_source_test.F90input_misc/tuner/error_bomex.insrc/clubb_thread_test.F90src/CLUBB_core/advance_clubb_core_module.F90input/tunable_parameters_Lscale/tunable_parameters.insrc/jacobian.F90input_misc/tuner/error_arm_97.ininput_misc/tuner/error_lba.insrc/CLUBB_core/clubb_api_module.F90src/error.F90input_misc/tuner/error_fire.ininput_misc/tuner/error_gabls2.ininput_misc/tuner/error_ticket_756.in63825a3122331a050c2e4972913b86cae0ce4b831699563846000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comZ displace tunable (#1122)
CLUBB ticket #1115
Added the previously hard-coded z_displace as a tunable parameter.
2023-11-09 15:04:06 -060063825a3122331a050c2e4972913b86cae0ce4b83Z displace tunable (#1122)editinput_misc/tuner/error_nov11_altocu.ineditinput_misc/tuner/error_dycoms2_rf01.ineditinput_misc/tuner/error_rico.ineditsrc/error.F90editinput_misc/tuner/error_bomex.ineditinput/tunable_parameters_tauMatchLscale/tunable_parameters.ineditinput_misc/tuner/error_gabls3_night.ineditsrc/CLUBB_core/parameter_indices.F90editinput/tunable_parameters_Lscale/tunable_parameters.ineditinput_misc/tuner/error_arm.ineditinput_misc/tuner/error_four_cases.ineditsrc/jacobian.F90editinput_misc/tuner/error_gabls2.ineditinput_misc/tuner/error_fire.ineditinput_misc/tuner/error_arm_97.ineditinput_misc/tuner/error_lba.ineditinput_misc/tuner/error_dycoms2_rf02_do.ineditsrc/CLUBB_core/mixing_length.F90editinput_misc/tuner/error_dycoms2_rf02_ds.ineditinput_misc/tuner/error_ticket_756.ineditinput_misc/tuner/error_dycoms2_rf02_nd.ineditsrc/G_unit_test_types/spurious_source_test.F90editinput_misc/tuner/error_atex.ineditsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/clubb_standalone.F90editinput_misc/tuner/error_wangara.ineditsrc/CLUBB_core/clubb_api_module.F90editsrc/clubb_thread_test.F90editinput/tunable_parameters/tunable_parameters.ineditsrc/CLUBB_core/parameters_tunable.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90
- postprocessing/pyplotgen/src/AnimationPanel.py37ef1bb08dd6e2246215d26d3fc4128d9ffe3cec1699652834000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comQuick fix for AnimationPanel so it works with the background-rcm changes (#1123)
- Modified super call in AnimationPanel constructor
- Removed first frame from consideration when determining x-axis scaling since the starting values are sometimes large compared to the other time steps
2023-11-10 15:47:14 -060037ef1bb08dd6e2246215d26d3fc4128d9ffe3cecQuick fix for AnimationPanel so it works with the background-rcm changes (#1123)editpostprocessing/pyplotgen/src/AnimationPanel.py
- src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/advance_xp3_module.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/stats_rad_zt_module.F90src/Benchmark_cases/cloud_sed_module.F90src/CLUBB_core/sfc_varnce_module.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/stats_type_utilities.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/advance_microphys_module.F90src/CLUBB_core/clip_explicit.F90src/SILHS/latin_hypercube_driver_module.F90src/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/SILHS/output_2D_samples_module.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/stats_lh_zt_module.F90src/CLUBB_core/setup_clubb_pdf_params.F90src/CLUBB_core/stats_variables.F90src/CLUBB_core/stats_rad_zm_module.F90src/KK_microphys_module.F90src/estimate_scm_microphys_module.F90src/ice_dfsn_module.F90src/lh_microphys_driver_module.F90src/microphys_driver.F90src/silhs_category_variance_module.F90src/CLUBB_core/stats_clubb_utilities.F90src/CLUBB_core/mono_flux_limiter.F90src/CLUBB_core/advance_helper_module.F90src/microphys_interface.incsrc/CLUBB_core/stats_lh_sfc_module.F90src/CLUBB_core/output_grads.F90src/G_unit_test_types/spurious_source_test.F90src/SILHS/silhs_api_module.F90src/mixed_moment_PDF_integrals.F90src/soil_vegetation.F90src/CLUBB_core/numerical_check.F90src/Microphys_utils/microphys_stats_vars_module.F90src/CLUBB_core/precipitation_fraction.F90src/CLUBB_core/stats_zm_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/stats_sfc_module.F90src/jacobian.F90src/simple_rad_module.F90src/morrison_microphys_module.F90src/clubb_driver.F90src/CLUBB_core/stats_zt_module.F90src/CLUBB_core/fill_holes.F90src/KK_microphys/KK_upscaled_turbulent_sed.F90src/KK_microphys/KK_upscaled_covariances.F90src/coamps_microphys_driver_module.F903dc7571b0baa54dc855087caef4c36315b067fbb1699661720000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comNew Stats Indices Type (#1118)
* Grouping stats indices into a derived type and making that accessible globally, for now. This does not run yet, but a checkpoint I wish to save.
* Checkpoint to save
* Checkpoint
* It actually works now and is BFB with every case.
* Starting to push the new derived type through the argument list.
* The new dervied type, now stats_metadata, has been fed through the argument list.
* Moved l_stats_samp into stats_metadata
* Moved all the other stats_variables into stats_metadata
* Small cleanup
* Fixes a stats bug when calling compute_sample_mean in silhs.
* Arrays in stats_metadata need only be allocated once, but we may want to call the stats init routines to set up more stats variables. So now we check for allocation before allocating. Also made the stat_indices type publicly available through clubb_api.
* This should be initialized to 0. The new changes in cam were able to tease this out, which is a good sign.
* A couple more to initialize to zero.
* Moving stats_metadata to before stats_ variables in argument lists, just for consistency.
* Changing stat_indices to stats_metadata_type
2023-11-10 18:15:20 -06003dc7571b0baa54dc855087caef4c36315b067fbbNew Stats Indices Type (#1118)editsrc/CLUBB_core/stats_lh_sfc_module.F90editsrc/Microphys_utils/microphys_stats_vars_module.F90editsrc/soil_vegetation.F90editsrc/CLUBB_core/stats_clubb_utilities.F90editsrc/CLUBB_core/stats_zm_module.F90editsrc/G_unit_test_types/spurious_source_test.F90editsrc/advance_microphys_module.F90editsrc/simple_rad_module.F90editsrc/CLUBB_core/clip_explicit.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/CLUBB_core/stats_zt_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/numerical_check.F90editsrc/CLUBB_core/stats_lh_zt_module.F90editsrc/ice_dfsn_module.F90editsrc/CLUBB_core/setup_clubb_pdf_params.F90editsrc/CLUBB_core/output_grads.F90editsrc/KK_microphys_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/stats_type_utilities.F90editsrc/CLUBB_core/stats_rad_zm_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/morrison_microphys_module.F90editsrc/CLUBB_core/stats_variables.F90editsrc/KK_microphys/KK_upscaled_turbulent_sed.F90editsrc/SILHS/latin_hypercube_driver_module.F90editsrc/estimate_scm_microphys_module.F90editsrc/clubb_driver.F90editsrc/SILHS/silhs_api_module.F90editsrc/Benchmark_cases/cloud_sed_module.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_xp3_module.F90editsrc/CLUBB_core/fill_holes.F90editsrc/CLUBB_core/stats_rad_zt_module.F90editsrc/CLUBB_core/mono_flux_limiter.F90editsrc/CLUBB_core/precipitation_fraction.F90editsrc/KK_microphys/KK_upscaled_covariances.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/sfc_varnce_module.F90editsrc/CLUBB_core/stats_sfc_module.F90editsrc/jacobian.F90editsrc/coamps_microphys_driver_module.F90editsrc/microphys_driver.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/lh_microphys_driver_module.F90editsrc/microphys_interface.inceditsrc/mixed_moment_PDF_integrals.F90editsrc/silhs_category_variance_module.F90editsrc/SILHS/output_2D_samples_module.F90
- src/clubb_driver.F90f4dabf64f8f2e4b1345d7a071020a406f365dedc1699905096000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.edustats_metadata needs to be threadprivate to make our standalone thread test work.
2023-11-13 13:51:36 -0600f4dabf64f8f2e4b1345d7a071020a406f365dedcstats_metadata needs to be threadprivate to make our standalone thread test work.editsrc/clubb_driver.F90
- src/CLUBB_core/Skx_module.F908bb631162837feba13cb64f43c1a40aa478730201699991156000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduChanging order of sqrt and **3 to improve stability, see clubb#1126. Since this is a change to the order of operations, it is BIT_CHANGING.
2023-11-14 13:45:56 -06008bb631162837feba13cb64f43c1a40aa47873020Changing order of sqrt and **3 to improve stability, see clubb#1126. Since this is a change to the order of operations, it is BIT_CHANGING.editsrc/CLUBB_core/Skx_module.F90
- src/CLUBB_core/constants_clubb.F90527360ddcce694dc3b89e69890792de97bd411da1699995955000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSetting the minimum tolerance to be epsilon, this is BIT_CHANGING but only for single precision. See larson-group/clubb#1126
2023-11-14 15:05:55 -0600527360ddcce694dc3b89e69890792de97bd411daSetting the minimum tolerance to be epsilon, this is BIT_CHANGING but only for single precision. See larson-group/clubb#1126editsrc/CLUBB_core/constants_clubb.F90
- src/CLUBB_core/mixing_length.F90input_misc/tuner/error_four_cases.in54063504021c09c54346da26e76e5888b2f50fe21699997980000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comBIT_CHANGING! Updated taus code calculations - CLUBB ticket #1115 (#1125)
- Changed invrs_tau_xp2/wp2 calculations to match the wpxp calculation:
Those now have a brunt_freq_pos and a brunt_freq_out_cloud term
- Changed tmp_calc magic number from .007 to .001
- Changed upper clipping bound for Ri_zm from 12 to 2 in invrs_tau_wpxp calculation
- Reversed accidental changes to input_misc/tuner/error_four_cases.in
2023-11-14 15:39:40 -060054063504021c09c54346da26e76e5888b2f50fe2BIT_CHANGING! Updated taus code calculations - CLUBB ticket #1115 (#1125)editsrc/CLUBB_core/mixing_length.F90editinput_misc/tuner/error_four_cases.in
- src/CLUBB_core/advance_clubb_core_module.F90src/input_netcdf.F90input/tunable_parameters_Lscale/tunable_parameters.inpostprocessing/pyplotgen/src/Panel.pysrc/CLUBB_core/advance_helper_module.F90postprocessing/pyplotgen/src/AnimationPanel.pysrc/CLUBB_core/mixing_length.F90c107cfd8ebdc72966cc1ae4889b6f0e83b1f9b251700177490000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdded non-trapezoidal zm interpolation for cloud_frac (#1127)
- Added a calculation for `cloud_frac_zm` when `l_call_pdf_closure_twice=false` and `l_trapezoidal_rule_zt=false`
This is BIT_CHANGING if `l_call_pdf_closure_twice=false` and `l_trapezoidal_rule_zt=false` since, in that case, `cloud_frac_zm` is now nonzero.
- Some minor formatting fixes
- Some minor fixes to pyplotgen's source code
- Added `a3_coef_min` to Lscale tunable_parameters.in
2023-11-16 17:31:30 -0600c107cfd8ebdc72966cc1ae4889b6f0e83b1f9b25Added non-trapezoidal zm interpolation for cloud_frac (#1127)editpostprocessing/pyplotgen/src/AnimationPanel.pyeditsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/mixing_length.F90editinput/tunable_parameters_Lscale/tunable_parameters.ineditpostprocessing/pyplotgen/src/Panel.pyeditsrc/input_netcdf.F90
- utilities/print_tunable_parameters_table.pyutilities/README4dcbd3cd96bd4ed860fb961678d59f9e35ab1eb81700586904000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdded new utility script print_tunable_parameters_table.py (#1130)
2023-11-21 11:15:04 -06004dcbd3cd96bd4ed860fb961678d59f9e35ab1eb8Added new utility script print_tunable_parameters_table.py (#1130)addutilities/print_tunable_parameters_table.pyeditutilities/README
- src/CLUBB_core/mixing_length.F900ea7656762902d44825603f83c24b74f817d502f1701198848000http://carson.math.uwm.edu/jenkins/user/sdomkeSteffen Domkesdomke@uwm.eduRe-adjusted cap for invrs_tau_wpxp in src/CLUBB_core/mixing_length.F90
BIT_CHANGING! CLUBB ticket #1115
2023-11-28 13:14:08 -06000ea7656762902d44825603f83c24b74f817d502fRe-adjusted cap for invrs_tau_wpxp in src/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/mixing_length.F90
- src/CLUBB_core/advance_wp2_wp3_module.F906a1ad520c171e5f5eb8cc1c590e1405459574dd61702052124000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comAdding boundary conditions for the wp3_term_ta_ADG1_lhs subroutine.
The value of wp3_zm at the model lower and upper boundaries is now
assumed to be 0 for simplicity and conservation.
2023-12-08 10:15:24 -06006a1ad520c171e5f5eb8cc1c590e1405459574dd6Adding boundary conditions for the wp3_term_ta_ADG1_lhs subroutine.editsrc/CLUBB_core/advance_wp2_wp3_module.F90
- src/CLUBB_core/advance_wp2_wp3_module.F90ed4235dea7c79ddba33a46759c16a1c149b92e571702052124000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comFor single loop vectors, removing the "collapse(2)" from the acc statements.
This commit is not bit changing, but the previous commit to this branch
was BIT_CHANGING:902d6caed8a4533f59f4165106276959b4f90895
2023-12-08 10:15:24 -0600ed4235dea7c79ddba33a46759c16a1c149b92e57For single loop vectors, removing the "collapse(2)" from the acc statements.editsrc/CLUBB_core/advance_wp2_wp3_module.F90
- src/CLUBB_core/advance_clubb_core_module.F90input/stats/standard_stats.ininput/stats/all_stats.inpostprocessing/pyplotgen/config/VariableGroupTaus.pysrc/CLUBB_core/stats_variables.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/stats_zm_module.F90d4e06311a21b35319ff520a156da3f4e5ea21fa91702424778000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@users.noreply.github.comAdded new Brunt-Väisälä frequency plots to pyplotgen's VariableGroupTaus
CLUBB ticket #1132, BIT_CHANGING because new output fields were added
- Added 3 new Brunt-Väisälä output fields:
- bv_freq_sqd_smth: The smoothed bv_mixed which is used to calculate the invrs_taus
- bv_freq_pos: The positive part of the sqrt of bv_freq_sqd_smth
- bv_freq_out_cloud: The out-of-cloud part of bv_freq_pos
- Added the plots of those fields to VariableGroupTaus
2023-12-12 17:46:18 -0600d4e06311a21b35319ff520a156da3f4e5ea21fa9Added new Brunt-Väisälä frequency plots to pyplotgen's VariableGroupTauseditinput/stats/standard_stats.ineditinput/stats/all_stats.ineditsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/stats_variables.F90editsrc/CLUBB_core/stats_zm_module.F90editpostprocessing/pyplotgen/config/VariableGroupTaus.py
- src/CLUBB_core/advance_clubb_core_module.F90f76ff058288183ffc88269355473315d645f67ed1702425732000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdds commas to fix bug
2023-12-12 18:02:12 -0600f76ff058288183ffc88269355473315d645f67edAdds commas to fix bugeditsrc/CLUBB_core/advance_clubb_core_module.F90
- utilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/sens_matrix_dashboard.py7a0ec8d6672de534c53569c0904ca034a0df627a1702916756000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: updates setup in order to read in 30x30
regional files automatically.
For #910.
2023-12-18 10:25:56 -06007a0ec8d6672de534c53569c0904ca034a0df627aQuadTune: updates setup in order to read in 30x30editutilities/sens_matrix/set_up_dashboard_inputs.pyeditutilities/sens_matrix/sens_matrix_dashboard.py
- src/CLUBB_core/diffusion.F907b2313fdf3b27db1521bac1facbbc9e595a729df1702943185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comUpdating the code to set the bottom of the thermodynamic level grid for
diffusion at thermodynamic level 2 -- the first level above the surface.
This is being done in preparation for ghostless gridding.
2023-12-18 17:46:25 -06007b2313fdf3b27db1521bac1facbbc9e595a729dfUpdating the code to set the bottom of the thermodynamic level grid foreditsrc/CLUBB_core/diffusion.F90
- src/CLUBB_core/advance_wp2_wp3_module.F9077ce77409e9da770515f66bbb50a869da74aca7d1702943185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comCommit to enforce a fixed-point boundary condition of wp3=0 at
thermodynamic level k = 2, the first above-ground thermodynamic level.
This is being done in preparation for ghostless gridding.
This commit is BIT_CHANGING.
Results are much more similar to the previous results than using
using zero-flux as the lower boundary condition for wp3.
2023-12-18 17:46:25 -060077ce77409e9da770515f66bbb50a869da74aca7dCommit to enforce a fixed-point boundary condition of wp3=0 ateditsrc/CLUBB_core/advance_wp2_wp3_module.F90
- src/CLUBB_core/advance_wp2_wp3_module.F90d0a28efd5a173fe59114e69f16d999ab31cc60801703174134000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduWith wp3 now being set to a fixed-point boundary condition value
of 0 at the current thermodynamic level 2 (first t-lev above the
surface), it is not necessary to loop over level 2 within the code
for each wp3 term.
This commit is BIT_CHANGING, but only for the wp3 budget terms
(e.g. wp3_ta) in the zt output file at level k = 2. It doesn't change
the actual answer. All other variables are bit-for-bit identical.
2023-12-21 09:55:34 -0600d0a28efd5a173fe59114e69f16d999ab31cc6080With wp3 now being set to a fixed-point boundary condition valueeditsrc/CLUBB_core/advance_wp2_wp3_module.F90
- src/Benchmark_cases/atex.F90src/CLUBB_core/saturation.F90input/case_setups/cgils_s12_model.insrc/CLUBB_core/sfc_varnce_module.F90src/CLUBB_core/sponge_layer_damping.F90src/CLUBB_core/mixing_length.F90src/G_unit_test_types/KK_integrals_tests.F90src/CLUBB_core/model_flags.F90src/time_dependent_input.F90src/advance_microphys_module.F90input/case_setups/cobra_model.ininput/case_setups/arm_97_model.insrc/Benchmark_cases/sfc_flux.F90src/CLUBB_core/stat_file_module.F90src/G_unit_test_types/pdf_parameter_tests.F90input/case_setups/lba_model.ininput/case_setups/atex_model.ininput/case_setups/gabls3_model.ininput/case_setups/nov11_altocu_model.insrc/SILHS/latin_hypercube_driver_module.F90input/tunable_parameters_compatible_r8029/configurable_model_flags.ininput/case_setups/cgils_s11_model.insrc/Benchmark_cases/cloud_feedback.F90src/CLUBB_core/advance_xp2_xpyp_module.F90src/SILHS/output_2D_samples_module.F90src/CLUBB_core/clubb_api_module.F90input/tunable_parameters_tauMatchLscale/configurable_model_flags.ininput/tunable_parameters/configurable_model_flags.insrc/CLUBB_core/diagnose_correlations_module.F90src/CLUBB_core/new_hybrid_pdf_main.F90input/case_setups/bomex_model.insrc/estimate_scm_microphys_module.F90src/ice_dfsn_module.F90input/case_setups/dycoms2_rf01_model.insrc/SILHS/transform_to_pdf_module.F90src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90input/case_setups/cgils_s6_p2k_model.ininput/case_setups/rico_model.insrc/Benchmark_cases/dycoms2_rf02.F90input/case_setups/cloud_feedback_s6_model.ininput/case_setups/arm_model.ininput/case_setups/neutral_model.insrc/Benchmark_cases/twp_ice.F90input/case_setups/twp_ice_model.insrc/KK_microphys/KK_utilities.F90src/microphys_interface.incsrc/Benchmark_cases/mpace_b.F90input/case_setups/READMEinput/case_setups/clex9_nov02_model.ininput/case_setups/jun25_altocu_model.insrc/input_fields.F90src/G_unit_test_types/spurious_source_test.F90src/SILHS/silhs_api_module.F90input/case_setups/arm_3year_model.insrc/mixed_moment_PDF_integrals.F90input/case_setups/cloud_feedback_s11_p2k_model.insrc/G_unit_test_types/read_corr_mtx_test.F90src/CLUBB_core/numerical_check.F90src/CLUBB_core/parameters_model.F90src/CLUBB_core/precipitation_fraction.F90input/case_setups/dycoms2_rf02_do_model.insrc/CLUBB_core/stats_zm_module.F90src/CLUBB_core/advance_clubb_core_module.F90input/case_setups/dycoms2_rf02_morr_model.ininput/case_setups/dycoms2_rf02_nd_model.insrc/clubb_driver.F90src/CLUBB_core/corr_varnce_module.F90src/CLUBB_core/index_mapping.F90input/tunable_parameters_e3sm/configurable_model_flags.insrc/CLUBB_core/fill_holes.F90input/case_setups/cgils_s12_p2k_model.insrc/Benchmark_cases/lba.F90input/case_setups/dycoms2_rf01_fixed_sst_model.insrc/CLUBB_core/advance_xp3_module.F90input/case_setups/cloud_feedback_s6_p2k_model.insrc/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/array_index.F90src/extended_atmosphere_module.F90src/Benchmark_cases/wangara.F90src/CLUBB_core/error_code.F90src/clubb_tuner.F90src/CLUBB_core/advance_windm_edsclrm_module.F90input/case_setups/mc3e_model.insrc/Benchmark_cases/astex_a209.F90src/CLUBB_core/output_netcdf.F90input/case_setups/cgils_s6_model.insrc/SILHS/silhs_importance_sample_module.F90input/case_setups/mpace_b_silhs_model.ininput/case_setups/rico_silhs_model.insrc/CLUBB_core/clip_explicit.F90input/case_setups/mpace_a_model.insrc/Benchmark_cases/gabls2.F90src/microphys_init_cleanup.F90src/CLUBB_core/advance_xm_wpxp_module.F90input/case_setups/cloud_feedback_s11_model.ininput/case_setups/mpace_b_model.insrc/Benchmark_cases/bomex.F90src/Benchmark_cases/fire.F90input/tunable_parameters_Lscale/configurable_model_flags.insrc/CLUBB_core/setup_clubb_pdf_params.F90input/case_setups/arm_0003_model.insrc/Benchmark_cases/cobra.F90input/case_setups/dycoms2_rf02_so_model.ininput/case_setups/astex_a209_model.insrc/G_unit_test_types/hole_filling_tests.F90src/KK_microphys_module.F90input/case_setups/cloud_feedback_s12_model.ininput/case_setups/dycoms2_rf02_ds_model.insrc/lh_microphys_driver_module.F90input/case_setups/gabls2_model.insrc/microphys_driver.F90src/Parabolic.f90src/silhs_category_variance_module.F90src/CLUBB_core/stats_clubb_utilities.F90src/CLUBB_core/advance_helper_module.F90src/Benchmark_cases/dycoms2_rf01.F90src/Benchmark_cases/rico.F90input/case_setups/fire_model.insrc/input_interpret.F90input/case_setups/cloud_feedback_s12_p2k_model.insrc/Benchmark_cases/mpace_a.F90src/morrison_microphys_module.F90src/sounding.F90src/CLUBB_core/stats_zt_module.F90input/case_setups/cgils_s11_p2k_model.insrc/coamps_microphys_driver_module.F90input/case_setups/gabls3_night_model.ininput/case_setups/wangara_model.ininput/case_setups/clex9_oct14_model.inddbb50b7dd661e83d6b06136f6596ca5b139e64b1704332198000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comThreadpublic (#1133)
* Initial threadprivate removals and simple changes.
* model flags update, incomplete
* Some updates, almost working
* Added saturation_formula and l_host_applies_sfc_fluxes to clubb_config_flags
* Accompanying changes to flags lists
* Changes to corrrelation array setup
* Adding more flag checking
* Forgot to set l_host_applies_sfc_fluxes in initialize_clubb_config_flags_type and commit adding l_implemented to the argument loit
* Adding saturation parameters to api
* Most of the way through passing sclr_dim, hydromet_dim, edsclr_dim, and sclr_tol through arguemnt lists. Moved first_write breaking silhs stats aparently, and bit changing due to the way we were writing sclr_tol for cases that have sclr_dim=0 (arm different, gabls2 BFB).
* Removing accidentally commited files.
* Fixed silhs output, all cases BFB but sclr_tol is saved differently to stats files in cases where sclr_dim = 0, so this is bc also bc:fb20458d5212b007c79c17613201af637bbc3d7e since that introduced the difference.
* Changing stats logicals back to false, only set to true for testing. So technically BIT_CHANGING
* Starting array_vars changes.
* No more global scalar indices
* Starting to remove hydromet indices
* Finished the annoying part with the microphysics interfaces.
* No more global variables in array_index. All cases BFB relative to last commit.
* No more global pdf_dim, Ncnp2_on_Ncnm2 now set via argument list, and added temporary hydromet_dim_glob because I thought it would fix a bug but it didn't, it might in the future though, so I left it in for now, it will be removed soon.
* Added nan checking before overriding default value for Ncnp2_on_Ncnm2
* Finished hydromet_dim argument listing and removed global versions of it as well as sclr_dim, edsclr_dim, and sclr_tol.
* open_netcdf_for_writing does nothing if nvars=0 for a stats file, which is understandable, but now that we call first_write immediately after we need that also to check for nvar=0
* Adding better error messages to stats_init
* The nvidia compiler does not like zero size arrays.
* Adding defaults for scalar arrays values in clubb driver, and adding an error check after calling stats_init.
* Reverting accidental changes to clubb_thread_test
* Changing name of scarr/scalar_array to sclr_idx and hydromet_array to hm_metadata
* Adding new types to _api
* Fixing erroneous name changes.
* Fixing bug introduced in 65987c8a77496f7bb10bfd28717345b1f63de1b7
* Removing print
* QuadTune: updates setup in order to read in 30x30
regional files automatically.
For #910.
* Updating the code to set the bottom of the thermodynamic level grid for
diffusion at thermodynamic level 2 -- the first level above the surface.
This is being done in preparation for ghostless gridding.
* Commit to enforce a fixed-point boundary condition of wp3=0 at
thermodynamic level k = 2, the first above-ground thermodynamic level.
This is being done in preparation for ghostless gridding.
This commit is bc.
Results are much more similar to the previous results than using
using zero-flux as the lower boundary condition for wp3.
* With wp3 now being set to a fixed-point boundary condition value
of 0 at the current thermodynamic level 2 (first t-lev above the
surface), it is not necessary to loop over level 2 within the code
for each wp3 term.
This commit is BIT_CHANGING, but only for the wp3 budget terms
(e.g. wp3_ta) in the zt output file at level k = 2. It doesn't change
the actual answer. All other variables are bit-for-bit identical.
* Removing omp parallel test line
* Removing parameter declarion around l_quintic_poly_interp. Having this be a parameter causes bit changes when using -O2
---------
Co-authored-by: vlarson <vlarson@uwm.edu>
Co-authored-by: bmg929 <bmg2@uwm.edu>
2024-01-03 19:36:38 -0600ddbb50b7dd661e83d6b06136f6596ca5b139e64bThreadpublic (#1133)editsrc/Benchmark_cases/cloud_feedback.F90editinput/tunable_parameters_tauMatchLscale/configurable_model_flags.ineditsrc/Benchmark_cases/astex_a209.F90editsrc/CLUBB_core/clip_explicit.F90editinput/case_setups/dycoms2_rf02_so_model.ineditsrc/CLUBB_core/sponge_layer_damping.F90editsrc/SILHS/transform_to_pdf_module.F90editsrc/mixed_moment_PDF_integrals.F90editsrc/morrison_microphys_module.F90editsrc/Benchmark_cases/fire.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/CLUBB_core/precipitation_fraction.F90editsrc/microphys_driver.F90editinput/case_setups/neutral_model.ineditinput/case_setups/arm_0003_model.ineditsrc/CLUBB_core/parameters_model.F90editsrc/G_unit_test_types/KK_integrals_tests.F90editinput/case_setups/lba_model.ineditsrc/coamps_microphys_driver_module.F90editsrc/SILHS/silhs_importance_sample_module.F90editinput/case_setups/cgils_s12_p2k_model.ineditsrc/extended_atmosphere_module.F90editsrc/Benchmark_cases/twp_ice.F90editinput/case_setups/mpace_b_silhs_model.ineditinput/case_setups/bomex_model.ineditinput/case_setups/twp_ice_model.ineditsrc/CLUBB_core/sfc_varnce_module.F90editinput/case_setups/rico_model.ineditsrc/CLUBB_core/pdf_closure_module.F90editsrc/Benchmark_cases/wangara.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/CLUBB_core/stats_zt_module.F90editsrc/advance_microphys_module.F90editinput/case_setups/astex_a209_model.ineditinput/case_setups/gabls3_model.ineditsrc/SILHS/silhs_api_module.F90editsrc/time_dependent_input.F90editinput/case_setups/clex9_nov02_model.ineditinput/tunable_parameters/configurable_model_flags.ineditsrc/Benchmark_cases/bomex.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editinput/case_setups/arm_97_model.ineditsrc/Benchmark_cases/atex.F90editinput/case_setups/dycoms2_rf02_do_model.ineditsrc/CLUBB_core/stats_clubb_utilities.F90editinput/case_setups/mc3e_model.ineditsrc/CLUBB_core/array_index.F90editinput/case_setups/cgils_s6_model.ineditinput/case_setups/arm_3year_model.ineditinput/case_setups/cobra_model.ineditsrc/Benchmark_cases/sfc_flux.F90editinput/case_setups/wangara_model.ineditsrc/sounding.F90editinput/case_setups/cloud_feedback_s11_p2k_model.ineditsrc/input_fields.F90editsrc/SILHS/output_2D_samples_module.F90editsrc/CLUBB_core/stat_file_module.F90editsrc/G_unit_test_types/hole_filling_tests.F90editinput/case_setups/mpace_a_model.ineditsrc/KK_microphys_module.F90editsrc/KK_microphys/KK_utilities.F90editsrc/CLUBB_core/advance_xp3_module.F90editinput/case_setups/dycoms2_rf02_morr_model.ineditinput/tunable_parameters_Lscale/configurable_model_flags.ineditsrc/microphys_interface.inceditinput/case_setups/cloud_feedback_s6_model.ineditsrc/CLUBB_core/diagnose_correlations_module.F90editsrc/CLUBB_core/numerical_check.F90editinput/case_setups/cgils_s11_model.ineditinput/case_setups/cloud_feedback_s12_p2k_model.ineditinput/case_setups/rico_silhs_model.ineditsrc/clubb_tuner.F90editinput/case_setups/gabls3_night_model.ineditinput/case_setups/arm_model.ineditinput/case_setups/dycoms2_rf02_nd_model.ineditsrc/CLUBB_core/mixing_length.F90editsrc/Benchmark_cases/mpace_a.F90editsrc/CLUBB_core/stats_zm_module.F90editsrc/lh_microphys_driver_module.F90editsrc/G_unit_test_types/read_corr_mtx_test.F90editsrc/ice_dfsn_module.F90editsrc/Benchmark_cases/rico.F90editsrc/estimate_scm_microphys_module.F90editinput/case_setups/gabls2_model.ineditsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/new_hybrid_pdf_main.F90editsrc/CLUBB_core/fill_holes.F90editinput/case_setups/nov11_altocu_model.ineditsrc/Benchmark_cases/gabls2.F90editsrc/CLUBB_core/corr_varnce_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/Benchmark_cases/cobra.F90editsrc/CLUBB_core/saturation.F90editsrc/CLUBB_core/setup_clubb_pdf_params.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/output_netcdf.F90editinput/case_setups/cloud_feedback_s11_model.ineditinput/case_setups/dycoms2_rf01_fixed_sst_model.ineditsrc/silhs_category_variance_module.F90editinput/case_setups/clex9_oct14_model.ineditinput/case_setups/cloud_feedback_s12_model.ineditinput/case_setups/cgils_s12_model.ineditsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/index_mapping.F90editinput/case_setups/dycoms2_rf02_ds_model.ineditsrc/Parabolic.f90editinput/case_setups/dycoms2_rf01_model.ineditsrc/Benchmark_cases/lba.F90editinput/case_setups/mpace_b_model.ineditinput/case_setups/jun25_altocu_model.ineditsrc/Benchmark_cases/dycoms2_rf02.F90editinput/case_setups/atex_model.ineditinput/case_setups/cgils_s6_p2k_model.ineditinput/case_setups/READMEeditsrc/SILHS/latin_hypercube_driver_module.F90editsrc/CLUBB_core/model_flags.F90editinput/case_setups/fire_model.ineditsrc/Benchmark_cases/dycoms2_rf01.F90editinput/case_setups/cgils_s11_p2k_model.ineditinput/case_setups/cloud_feedback_s6_p2k_model.ineditsrc/input_interpret.F90editsrc/CLUBB_core/error_code.F90editsrc/Benchmark_cases/mpace_b.F90editinput/tunable_parameters_e3sm/configurable_model_flags.ineditsrc/microphys_init_cleanup.F90editinput/tunable_parameters_compatible_r8029/configurable_model_flags.in
- src/CLUBB_core/corr_varnce_module.F90src/microphys_init_cleanup.F90a727ecf09a079d734398c45486510c6b655fcff21704398011000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving awkward nan check in favor of a default for Ncnp2_on_Ncnm2
2024-01-04 13:53:31 -0600a727ecf09a079d734398c45486510c6b655fcff2Removing awkward nan check in favor of a default for Ncnp2_on_Ncnm2editsrc/microphys_init_cleanup.F90editsrc/CLUBB_core/corr_varnce_module.F90
- jenkins_tests/clubb_nvhpc_gpu_acc_vs_cpu_diffness/Jenkinsfilerun_scripts/check_multicol_error.py121575bfcd9c69e364a803b537adc839ea79e3bb1704760015000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduInitial creation of gpu vs cpu output comparison jenkins test
2024-01-08 18:26:55 -0600121575bfcd9c69e364a803b537adc839ea79e3bbInitial creation of gpu vs cpu output comparison jenkins testaddjenkins_tests/clubb_nvhpc_gpu_acc_vs_cpu_diffness/Jenkinsfileeditrun_scripts/check_multicol_error.py
- jenkins_tests/clubb_nvhpc_gpu_acc_vs_cpu_diffness/Jenkinsfilef41f798e984888b18a7fff7c5322e65bd25fb6c81704760427000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding clean step before compiling GPU to new jenkins test
2024-01-08 18:33:47 -0600f41f798e984888b18a7fff7c5322e65bd25fb6c8Adding clean step before compiling GPU to new jenkins testeditjenkins_tests/clubb_nvhpc_gpu_acc_vs_cpu_diffness/Jenkinsfile
- jenkins_tests/clubb_nvhpc_gpu_acc_vs_cpu_diffness/Jenkinsfile1d7763e236f2a1a9a9f54ccb13869c01608073b51704760571000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking script check the specific multicore files
2024-01-08 18:36:11 -06001d7763e236f2a1a9a9f54ccb13869c01608073b5Making script check the specific multicore fileseditjenkins_tests/clubb_nvhpc_gpu_acc_vs_cpu_diffness/Jenkinsfile
- jenkins_tests/clubb_nvhpc_gpu_acc_vs_cpu_diffness/Jenkinsfilead40e1c1c619ac6535a60ed99155162fc9c989f41704768204000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding more cases to test
2024-01-08 20:43:24 -0600ad40e1c1c619ac6535a60ed99155162fc9c989f4Adding more cases to testeditjenkins_tests/clubb_nvhpc_gpu_acc_vs_cpu_diffness/Jenkinsfile
- src/CLUBB_core/advance_clubb_core_module.F90src/clubb_driver.F9079d08b6b6da219ed06ea1ada4d4d16bf6b6d7ae41704774211000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding new argument list variables to openacc copyin statements
2024-01-08 22:23:31 -060079d08b6b6da219ed06ea1ada4d4d16bf6b6d7ae4Adding new argument list variables to openacc copyin statementseditsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/clubb_driver.F90
- jenkins_tests/clubb_nvhpc_gpu_acc_vs_cpu_diffness/Jenkinsfile2b18aa50062d4ae24b2c7f4daf4238b67e3b97221704775038000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduLimiting gabls2 to 500 timesteps in new jenkins test
2024-01-08 22:37:18 -06002b18aa50062d4ae24b2c7f4daf4238b67e3b9722Limiting gabls2 to 500 timesteps in new jenkins testeditjenkins_tests/clubb_nvhpc_gpu_acc_vs_cpu_diffness/Jenkinsfile
- jenkins_tests/clubb_nvhpc_gpu_acc_vs_cpu_diffness/Jenkinsfile0a5c95ab0f0eb41271f5fc4ebd96fc12e3e12cf01704785365000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduChanging sclr test case to cobra, keeping 500 timestpes, gabls2 appears less stable as a result of commit 77ce77409e9da770515f66bbb50a869da74aca7d
2024-01-09 01:29:25 -06000a5c95ab0f0eb41271f5fc4ebd96fc12e3e12cf0Changing sclr test case to cobra, keeping 500 timestpes, gabls2 appears less stable as a result of commit 77ce77409e9da770515f66bbb50a869da74aca7deditjenkins_tests/clubb_nvhpc_gpu_acc_vs_cpu_diffness/Jenkinsfile
- input/tunable_parameters/configurable_model_flags.incompile/config/linux_x86_64_nvhpc_gpu.bash1ce764cad4ea41e739b6ce9d95d8bec7db72097f1704839542000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSetting l_smooth_Heaviside_tau_wpxp to .true. by default
2024-01-09 16:32:22 -06001ce764cad4ea41e739b6ce9d95d8bec7db72097fSetting l_smooth_Heaviside_tau_wpxp to .true. by defaulteditinput/tunable_parameters/configurable_model_flags.ineditcompile/config/linux_x86_64_nvhpc_gpu.bash
- compile/config/linux_x86_64_nvhpc_gpu.bashdd59f60c668e6989bf231b72032771c3ac9518d51704839725000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduUndoing accidental changes to compiler config
2024-01-09 16:35:25 -0600dd59f60c668e6989bf231b72032771c3ac9518d5Undoing accidental changes to compiler configeditcompile/config/linux_x86_64_nvhpc_gpu.bash
- README753138f581f211a7c4d6798f031b4109c5e085591704930792000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduBIT_CHANGING:1ce764cad4ea41e739b6ce9d95d8bec7db72097f
2024-01-10 17:53:12 -0600753138f581f211a7c4d6798f031b4109c5e08559BIT_CHANGING:1ce764cad4ea41e739b6ce9d95d8bec7db72097feditREADME
- compile/config/linux_x86_64_nvhpc.bashjenkins_tests/clubb_nvhpc_gpu_acc_vs_cpu_diffness/Jenkinsfilea993b7b3e95ba78c077dd24290baff1b08f169c51704948886000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking nightly cpu vs gpu test use a new config script for the cpu compile. This is the minimize the differences to be only whether or not the openacc GPU code is enabled.
2024-01-10 22:54:46 -0600a993b7b3e95ba78c077dd24290baff1b08f169c5Making nightly cpu vs gpu test use a new config script for the cpu compile. This is the minimize the differences to be only whether or not the openacc GPU code is enabled.addcompile/config/linux_x86_64_nvhpc.basheditjenkins_tests/clubb_nvhpc_gpu_acc_vs_cpu_diffness/Jenkinsfile
- jenkins_tests/clubb_nvhpc_gpu_acc_vs_cpu_diffness/Jenkinsfilef4277535627c705e8851dc3112160fd4152520421704951278000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduLimiting mpace_b to 250 timestpes for gpu vs cpu test. The mpace_b test passed on my home GPU (RTX 3080), but not when run in jenkens on nelson (P4000). So either the tolerance is too strict, or we're running too many timesteps for mpace_b. Currently the largest difference on mpace_b multicol check is 3.31551e-05 on jenkins, so if this fails also I'll up the tolerance for mpace_b instead of further reducing timesteps run.
2024-01-10 23:34:38 -0600f4277535627c705e8851dc3112160fd415252042Limiting mpace_b to 250 timestpes for gpu vs cpu test. The mpace_b test passed on my home GPU (RTX 3080), but not when run in jenkens on nelson (P4000). So either the tolerance is too strict, or we're running too many timesteps for mpace_b. Currently the largest difference on mpace_b multicol check is 3.31551e-05 on jenkins, so if this fails also I'll up the tolerance for mpace_b instead of further reducing timesteps run.editjenkins_tests/clubb_nvhpc_gpu_acc_vs_cpu_diffness/Jenkinsfile
- src/CLUBB_core/mean_adv.F9018afbb900eaa3202bc48b64daf9daa974ee8dd4c1705003858000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am altering the mean advection code in preparation for ghost point
removal, since the mean advection code incorporates the ghost point
in its current calculations.
The lower boundary is now treated in the same manner as the
upper boundary, where a zero derivative over the boundary is assumed.
Any interaction of the current ghost level with the model code is
now removed from the mean advection calculation.
The results are bit-for-bit for most cases, but not all of them.
They are not necessarily expected to be bit-for-bit. There are
no discernable differences on plots of priority cases. However,
this commit is technically BIT_CHANGING.
2024-01-11 14:10:58 -060018afbb900eaa3202bc48b64daf9daa974ee8dd4cI am altering the mean advection code in preparation for ghost pointeditsrc/CLUBB_core/mean_adv.F90
- src/clubb_driver.F90be2fe61a1e5897d417ae01cf335caa727a85c7fe1705612663000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bug. See https://github.com/larson-group/clubb/issues/1139
2024-01-18 15:17:43 -0600be2fe61a1e5897d417ae01cf335caa727a85c7feFixing bug. See https://github.com/larson-group/clubb/issues/1139editsrc/clubb_driver.F90
- src/CLUBB_core/tridiag_lu_solver.F90cad1c8b0360b5beaef4648ef0d755818e0823e891705612684000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing tridiag solver bug. See https://github.com/larson-group/clubb/issues/1139
2024-01-18 15:18:04 -0600cad1c8b0360b5beaef4648ef0d755818e0823e89Fixing tridiag solver bug. See https://github.com/larson-group/clubb/issues/1139editsrc/CLUBB_core/tridiag_lu_solver.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/clubb_api_module.F90src/clubb_driver.F90f28975376d58c19257922a4cca10ae07ff251d051705629086000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSlight rework to acc data statements. This allows us to use return calls in advance_clubb_core again. See https://github.com/larson-group/clubb/issues/1139
2024-01-18 19:51:26 -0600f28975376d58c19257922a4cca10ae07ff251d05Slight rework to acc data statements. This allows us to use return calls in advance_clubb_core again. See https://github.com/larson-group/clubb/issues/1139editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/clubb_driver.F90
- src/CLUBB_core/mixing_length.F90ec65c38de8cd427398f788dfdfc3537434a15dd71705629109000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing small GPU stats bug
2024-01-18 19:51:49 -0600ec65c38de8cd427398f788dfdfc3537434a15dd7Fixing small GPU stats bugeditsrc/CLUBB_core/mixing_length.F90
- src/CLUBB_core/mono_flux_limiter.F9023fa7789cb8cb963c4536910b97b0c48d6f105c21705629562000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduChanging xm to out in mono flux solver. There is no need for it to be inout, and it confused me for a bit so I'm fixing it.
2024-01-18 19:59:22 -060023fa7789cb8cb963c4536910b97b0c48d6f105c2Changing xm to out in mono flux solver. There is no need for it to be inout, and it confused me for a bit so I'm fixing it.editsrc/CLUBB_core/mono_flux_limiter.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/SILHS/latin_hypercube_driver_module.F90529afce6dc6af438b9658f44ffa108d16a5ad1471705819808000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding clubb specific compiler flag -DCLUBB_GPU, intended for use with openmp or openacc running on the GPU. Also adding a compiler flags, -DCUDA, and case statment for generating random numbers in silhs.
2024-01-21 00:50:08 -0600529afce6dc6af438b9658f44ffa108d16a5ad147Adding clubb specific compiler flag -DCLUBB_GPU, intended for use with openmp or openacc running on the GPU. Also adding a compiler flags, -DCUDA, and case statment for generating random numbers in silhs.editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/SILHS/latin_hypercube_driver_module.F90
- compile/config/linux_x86_64_nvhpc_gpu.bashab99eb01e08ba10a80c1f6881dc13eaca2c9e9921705820078000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding new compiler flags to nvfortran GPU compile script
2024-01-21 00:54:38 -0600ab99eb01e08ba10a80c1f6881dc13eaca2c9e992Adding new compiler flags to nvfortran GPU compile scripteditcompile/config/linux_x86_64_nvhpc_gpu.bash
- compile/convert_acc_to_omp.bashcompile/config/linux_x86_64_ifort_gpu_openmp.bashcompile/config/linux_x86_64_nvhpc_gpu_openmp.bashcompile/config/linux_x86_64_nvhpc_gpu.bashjenkins_tests/clubb_nvhpc_gpu_acc_vs_cpu_diffness/Jenkinsfilecompile/config/linux_x86_64_nvhpc_gpu_openacc.bash199660fe742bfdd7f79e491498770d486bdf3ab11705824114000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding openacc to openmp conversion script, and making some new compiler config files.
2024-01-21 02:01:54 -0600199660fe742bfdd7f79e491498770d486bdf3ab1Adding openacc to openmp conversion script, and making some new compiler config files.addcompile/config/linux_x86_64_nvhpc_gpu_openacc.bashaddcompile/config/linux_x86_64_ifort_gpu_openmp.bashdeletecompile/config/linux_x86_64_nvhpc_gpu.bashaddcompile/convert_acc_to_omp.bashaddcompile/config/linux_x86_64_nvhpc_gpu_openmp.basheditjenkins_tests/clubb_nvhpc_gpu_acc_vs_cpu_diffness/Jenkinsfile
- compile/convert_acc_to_omp.bash821ee17aa39585afb8e82c1ca5c4f71a45f74e701705963169000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdds comments to openmp conversion script
2024-01-22 16:39:29 -0600821ee17aa39585afb8e82c1ca5c4f71a45f74e70Adds comments to openmp conversion scripteditcompile/convert_acc_to_omp.bash
- src/CLUBB_core/advance_wp2_wp3_module.F908237a01f73c7604f4480689a9703daff0df851781706079736000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduNow that the value of wp3 is being set to a boundary value of 0
at the first thermodynamic grid level above the surface, it doesn't
make sense to loop over budget terms anymore at that particular level,
since they don't factor in the solution and give a false impression.
With this commit, wp3 budget terms now start their loop at level 3.
This commit is BIT_CHANGING, but the only thing that changes are
budget stats for a couple of wp3 budget terms. The solution
does not actually change.
2024-01-24 01:02:16 -06008237a01f73c7604f4480689a9703daff0df85178Now that the value of wp3 is being set to a boundary value of 0editsrc/CLUBB_core/advance_wp2_wp3_module.F90
- src/CLUBB_core/model_flags.F902e41ead98e7d13b192c3a7762336fa3dbc5a69891706649109000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduThis is (amazingly) BIT_CHANGING. The differences are due to some compiler optimizations, see https://github.com/larson-group/clubb/pull/1133\#issuecomment-1865156979.
2024-01-30 15:11:49 -06002e41ead98e7d13b192c3a7762336fa3dbc5a6989This is (amazingly) BIT_CHANGING. The differences are due to some compiler optimizations, see https://github.com/larson-group/clubb/pull/1133\#issuecomment-1865156979.editsrc/CLUBB_core/model_flags.F90
- src/clubb_driver.F9005f2b8b38bf748ece44a7038f2b50044e26eaa5d1706657370000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving git log print before logging to file. On some systems/configs the command would cause a busy wait until the person running hit q, and it is superfluous since we are already saving the git log to a file.
2024-01-30 17:29:30 -060005f2b8b38bf748ece44a7038f2b50044e26eaa5dRemoving git log print before logging to file. On some systems/configs the command would cause a busy wait until the person running hit q, and it is superfluous since we are already saving the git log to a file.editsrc/clubb_driver.F90
- input/case_setups/neutral_sounding.ininput/case_setups/cgils_s6_sfc.ininput/case_setups/wangara_edsclr_sounding.ininput/case_setups/wangara_sclr_sounding.ininput/case_setups/cloud_feedback_s11_p2k_sfc.ininput/case_setups/cloud_feedback_s6_sfc.ininput/case_setups/arm_forcings.ininput/case_setups/mc3e_forcings.ininput/case_setups/mpace_b_edsclr_sounding.ininput/case_setups/lba_sounding.ininput/case_setups/bomex_edsclr_sounding.ininput/case_setups/bomex_sclr_sounding.ininput/case_setups/cgils_s11_p2k_forcings.ininput/case_setups/cgils_s6_forcings.ininput/case_setups/gabls3_night_forcings.ininput/case_setups/cobra_sfc.ininput/case_setups/gabls3_forcings.ininput/case_setups/gabls3_night_sounding.ininput/case_setups/jun25_altocu_sclr_sounding.ininput/case_setups/dycoms2_rf01_sclr_sounding.ininput/case_setups/gabls3_edsclr_sounding.ininput/case_setups/gabls2_edsclr_sounding.ininput/case_setups/dycoms2_rf01_edsclr_sounding.ininput/case_setups/cgils_s11_p2k_sfc.ininput/case_setups/dycoms2_rf02_sclr_sounding.ininput/case_setups/arm_97_forcings.ininput/case_setups/nov11_altocu_forcings.ininput/case_setups/fire_sclr_sounding.ininput/case_setups/arm_0003_forcings.ininput/case_setups/cgils_s12_p2k_sfc.ininput/case_setups/jun25_altocu_sfc.ininput/case_setups/lba_sclr_sounding.ininput/case_setups/mpace_a_forcings.ininput/case_setups/dycoms2_rf02_sfc.ininput/case_setups/mpace_b_sclr_sounding.ininput/case_setups/atex_sounding.ininput/case_setups/mpace_a_edsclr_sounding.ininput/case_setups/arm_sclr_sounding.ininput/case_setups/cloud_feedback_s12_p2k_forcings.ininput/case_setups/clex9_oct14_forcings.ininput/case_setups/cloud_feedback_s12_p2k_sfc.ininput/case_setups/cgils_s12_sfc.ininput/case_setups/mc3e_sfc.ininput/case_setups/arm_97_sclr_sounding.ininput/case_setups/rico_sounding.ininput/case_setups/arm_97_sfc.ininput/case_setups/clex9_nov02_sounding.ininput/case_setups/nov11_altocu_sfc.ininput/case_setups/cloud_feedback_s6_p2k_forcings.ininput/case_setups/clex9_nov02_edsclr_sounding.ininput/case_setups/gabls2_sclr_sounding.ininput/case_setups/cloud_feedback_s6_forcings.ininput/case_setups/astex_a209_forcings.ininput/case_setups/clex9_nov02_sfc.ininput/case_setups/rico_sclr_sounding.ininput/case_setups/arm_0003_sfc.ininput/case_setups/arm_3year_edsclr_sounding.ininput/case_setups/cloud_feedback_s11_sfc.ininput/case_setups/cgils_s12_p2k_forcings.ininput/case_setups/cgils_s11_forcings.ininput/case_setups/cgils_s12_forcings.ininput/case_setups/cobra_edsclr_sounding.ininput/case_setups/cloud_feedback_s6_p2k_sfc.ininput/case_setups/gabls3_sounding.ininput/case_setups/cloud_feedback_s12_sfc.ininput/case_setups/jun25_altocu_sounding.ininput/case_setups/bomex_sounding.ininput/case_setups/twp_ice_sclr_sounding.ininput/case_setups/clex9_oct14_sounding.ininput/case_setups/fire_sounding.ininput/case_setups/clex9_oct14_sfc.ininput/case_setups/arm_0003_sclr_sounding.ininput/case_setups/gabls3_sclr_sounding.ininput/case_setups/twp_ice_sounding.ininput/case_setups/nov11_altocu_sclr_sounding.ininput/case_setups/gabls2_sounding.ininput/case_setups/arm_97_edsclr_sounding.ininput/case_setups/nov11_altocu_edsclr_sounding.ininput/case_setups/cobra_sounding.ininput/case_setups/nov11_altocu_sounding.ininput/case_setups/wangara_sounding.ininput/case_setups/mpace_a_sounding.ininput/case_setups/cobra_forcings.ininput/case_setups/arm_3year_sfc.ininput/case_setups/mpace_b_sounding.ininput/case_setups/arm_97_sounding.ininput/case_setups/dycoms2_rf02_edsclr_sounding.ininput/case_setups/clex9_nov02_sclr_sounding.ininput/case_setups/mpace_b_sfc.insrc/CLUBB_core/input_names.F90input/case_setups/jun25_altocu_edsclr_sounding.ininput/case_setups/jun25_altocu_forcings.ininput/case_setups/cloud_feedback_s12_forcings.ininput/case_setups/cloud_feedback_s11_forcings.ininput/case_setups/twp_ice_forcings.ininput/case_setups/atex_edsclr_sounding.ininput/case_setups/dycoms2_rf01_sfc.ininput/case_setups/rico_edsclr_sounding.ininput/case_setups/cgils_s6_p2k_sfc.ininput/case_setups/cgils_s11_sfc.ininput/case_setups/dycoms2_rf02_sounding.ininput/case_setups/arm_0003_edsclr_sounding.ininput/case_setups/mpace_a_sclr_sounding.ininput/case_setups/arm_sounding.ininput/case_setups/arm_edsclr_sounding.ininput/case_setups/atex_sclr_sounding.ininput/case_setups/clex9_oct14_edsclr_sounding.ininput/case_setups/dycoms2_rf01_sounding.ininput/case_setups/mc3e_sounding.ininput/case_setups/astex_a209_sounding.ininput/case_setups/arm_3year_sounding.ininput/case_setups/arm_3year_sclr_sounding.ininput/case_setups/cobra_sclr_sounding.ininput/case_setups/clex9_nov02_forcings.ininput/case_setups/cloud_feedback_s11_p2k_forcings.ininput/case_setups/fire_edsclr_sounding.ininput/case_setups/clex9_oct14_sclr_sounding.ininput/case_setups/arm_0003_sounding.ininput/case_setups/lba_edsclr_sounding.ininput/case_setups/cgils_s6_p2k_forcings.ininput/case_setups/arm_sfc.in9b495acd26a0b009ec84845aa289c36befff0c411706760368000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving backslashes. These should be slashes, but gnu,intel,nvidia generate code that treats slashes as whitespace and backslashes as a character, while cray treats backslashes as whitespace as well. This is easily fixed by using quotes, and in the meantime we will change the backslashes to forward slashes. See https://github.com/larson-group/clubb/issues/1138\#issuecomment-1910844013
2024-01-31 22:06:08 -06009b495acd26a0b009ec84845aa289c36befff0c41Removing backslashes. These should be slashes, but gnu,intel,nvidia generate code that treats slashes as whitespace and backslashes as a character, while cray treats backslashes as whitespace as well. This is easily fixed by using quotes, and in the meantime we will change the backslashes to forward slashes. See https://github.com/larson-group/clubb/issues/1138\#issuecomment-1910844013editinput/case_setups/lba_sclr_sounding.ineditinput/case_setups/cgils_s11_forcings.ineditinput/case_setups/rico_sclr_sounding.ineditinput/case_setups/arm_sclr_sounding.ineditinput/case_setups/neutral_sounding.ineditinput/case_setups/clex9_nov02_forcings.ineditinput/case_setups/clex9_oct14_forcings.ineditinput/case_setups/cgils_s11_p2k_forcings.ineditinput/case_setups/clex9_nov02_edsclr_sounding.ineditinput/case_setups/twp_ice_sclr_sounding.ineditinput/case_setups/cloud_feedback_s6_sfc.ineditinput/case_setups/arm_0003_forcings.ineditinput/case_setups/gabls3_night_forcings.ineditinput/case_setups/cgils_s12_forcings.ineditinput/case_setups/clex9_oct14_sfc.ineditinput/case_setups/bomex_sounding.ineditinput/case_setups/cgils_s12_sfc.ineditinput/case_setups/cobra_edsclr_sounding.ineditinput/case_setups/arm_97_sounding.ineditinput/case_setups/gabls3_edsclr_sounding.ineditinput/case_setups/cgils_s11_p2k_sfc.ineditinput/case_setups/twp_ice_sounding.ineditinput/case_setups/dycoms2_rf02_edsclr_sounding.ineditinput/case_setups/cgils_s6_sfc.ineditinput/case_setups/arm_0003_sounding.ineditinput/case_setups/arm_0003_sfc.ineditinput/case_setups/arm_97_sfc.ineditinput/case_setups/cobra_sclr_sounding.ineditinput/case_setups/mpace_a_sclr_sounding.ineditinput/case_setups/wangara_edsclr_sounding.ineditinput/case_setups/cgils_s6_p2k_forcings.ineditinput/case_setups/gabls2_sounding.ineditinput/case_setups/gabls3_forcings.ineditinput/case_setups/cgils_s12_p2k_sfc.ineditinput/case_setups/gabls2_sclr_sounding.ineditinput/case_setups/cloud_feedback_s11_p2k_sfc.ineditinput/case_setups/gabls3_sounding.ineditinput/case_setups/mpace_b_sclr_sounding.ineditinput/case_setups/arm_97_forcings.ineditinput/case_setups/jun25_altocu_forcings.ineditinput/case_setups/arm_3year_edsclr_sounding.ineditinput/case_setups/nov11_altocu_sounding.ineditinput/case_setups/cloud_feedback_s12_p2k_sfc.ineditinput/case_setups/cloud_feedback_s12_forcings.ineditinput/case_setups/cloud_feedback_s6_forcings.ineditinput/case_setups/nov11_altocu_forcings.ineditinput/case_setups/arm_3year_sounding.ineditinput/case_setups/clex9_oct14_sounding.ineditinput/case_setups/bomex_sclr_sounding.ineditinput/case_setups/clex9_nov02_sfc.ineditinput/case_setups/arm_sounding.ineditinput/case_setups/fire_sclr_sounding.ineditinput/case_setups/astex_a209_sounding.ineditinput/case_setups/cloud_feedback_s12_p2k_forcings.ineditinput/case_setups/jun25_altocu_sounding.ineditinput/case_setups/rico_sounding.ineditinput/case_setups/cloud_feedback_s6_p2k_sfc.ineditinput/case_setups/lba_sounding.ineditinput/case_setups/arm_edsclr_sounding.ineditinput/case_setups/dycoms2_rf02_sfc.ineditinput/case_setups/cloud_feedback_s11_sfc.ineditinput/case_setups/mpace_a_edsclr_sounding.ineditinput/case_setups/clex9_nov02_sclr_sounding.ineditinput/case_setups/arm_97_sclr_sounding.ineditinput/case_setups/cgils_s6_forcings.ineditinput/case_setups/cloud_feedback_s12_sfc.ineditinput/case_setups/arm_forcings.ineditinput/case_setups/cloud_feedback_s11_p2k_forcings.ineditinput/case_setups/dycoms2_rf02_sounding.ineditinput/case_setups/atex_sounding.ineditinput/case_setups/lba_edsclr_sounding.ineditinput/case_setups/nov11_altocu_sfc.ineditinput/case_setups/wangara_sounding.ineditinput/case_setups/mpace_b_sfc.ineditinput/case_setups/arm_sfc.ineditinput/case_setups/cloud_feedback_s6_p2k_forcings.ineditinput/case_setups/mpace_a_forcings.ineditinput/case_setups/mpace_b_sounding.ineditinput/case_setups/clex9_oct14_sclr_sounding.ineditinput/case_setups/gabls2_edsclr_sounding.ineditinput/case_setups/clex9_oct14_edsclr_sounding.ineditinput/case_setups/rico_edsclr_sounding.ineditinput/case_setups/atex_sclr_sounding.ineditinput/case_setups/arm_0003_sclr_sounding.ineditinput/case_setups/cobra_sfc.ineditinput/case_setups/arm_97_edsclr_sounding.ineditinput/case_setups/fire_sounding.ineditinput/case_setups/jun25_altocu_sclr_sounding.ineditinput/case_setups/cloud_feedback_s11_forcings.ineditinput/case_setups/gabls3_night_sounding.ineditsrc/CLUBB_core/input_names.F90editinput/case_setups/mpace_a_sounding.ineditinput/case_setups/cgils_s12_p2k_forcings.ineditinput/case_setups/jun25_altocu_sfc.ineditinput/case_setups/cgils_s11_sfc.ineditinput/case_setups/bomex_edsclr_sounding.ineditinput/case_setups/nov11_altocu_sclr_sounding.ineditinput/case_setups/dycoms2_rf01_sclr_sounding.ineditinput/case_setups/mc3e_forcings.ineditinput/case_setups/astex_a209_forcings.ineditinput/case_setups/dycoms2_rf02_sclr_sounding.ineditinput/case_setups/nov11_altocu_edsclr_sounding.ineditinput/case_setups/twp_ice_forcings.ineditinput/case_setups/wangara_sclr_sounding.ineditinput/case_setups/mpace_b_edsclr_sounding.ineditinput/case_setups/cobra_sounding.ineditinput/case_setups/mc3e_sfc.ineditinput/case_setups/arm_3year_sclr_sounding.ineditinput/case_setups/mc3e_sounding.ineditinput/case_setups/dycoms2_rf01_edsclr_sounding.ineditinput/case_setups/dycoms2_rf01_sounding.ineditinput/case_setups/arm_3year_sfc.ineditinput/case_setups/arm_0003_edsclr_sounding.ineditinput/case_setups/cgils_s6_p2k_sfc.ineditinput/case_setups/dycoms2_rf01_sfc.ineditinput/case_setups/gabls3_sclr_sounding.ineditinput/case_setups/atex_edsclr_sounding.ineditinput/case_setups/cobra_forcings.ineditinput/case_setups/clex9_nov02_sounding.ineditinput/case_setups/fire_edsclr_sounding.ineditinput/case_setups/jun25_altocu_edsclr_sounding.in
- src/clubb_driver.F90c3e2f32190f1d5c89b665126d1bc05d6dfbc91db1706760919000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding ifdefs around multicol netcdf outputting.
2024-01-31 22:15:19 -0600c3e2f32190f1d5c89b665126d1bc05d6dfbc91dbAdding ifdefs around multicol netcdf outputting.editsrc/clubb_driver.F90
- input/case_setups/neutral_sounding.ininput/case_setups/cgils_s6_sfc.ininput/case_setups/wangara_edsclr_sounding.ininput/case_setups/wangara_sclr_sounding.ininput/case_setups/cloud_feedback_s11_p2k_sfc.ininput/case_setups/cloud_feedback_s6_sfc.ininput/case_setups/arm_forcings.ininput/case_setups/mc3e_forcings.ininput/case_setups/mpace_b_edsclr_sounding.ininput/case_setups/lba_sounding.ininput/case_setups/bomex_edsclr_sounding.ininput/case_setups/bomex_sclr_sounding.ininput/case_setups/cgils_s6_forcings.ininput/case_setups/cgils_s11_p2k_forcings.ininput/case_setups/gabls3_night_forcings.ininput/case_setups/cobra_sfc.ininput/case_setups/gabls3_forcings.ininput/case_setups/gabls3_night_sounding.ininput/case_setups/jun25_altocu_sclr_sounding.ininput/case_setups/dycoms2_rf01_sclr_sounding.ininput/case_setups/gabls3_edsclr_sounding.ininput/case_setups/gabls2_edsclr_sounding.ininput/case_setups/dycoms2_rf01_edsclr_sounding.ininput/case_setups/cgils_s11_p2k_sfc.ininput/case_setups/dycoms2_rf02_sclr_sounding.ininput/case_setups/arm_97_forcings.ininput/case_setups/fire_sclr_sounding.ininput/case_setups/nov11_altocu_forcings.ininput/case_setups/arm_0003_forcings.ininput/case_setups/cgils_s12_p2k_sfc.ininput/case_setups/jun25_altocu_sfc.ininput/case_setups/lba_sclr_sounding.ininput/case_setups/mpace_a_forcings.ininput/case_setups/dycoms2_rf02_sfc.ininput/case_setups/atex_sounding.ininput/case_setups/mpace_b_sclr_sounding.ininput/case_setups/mpace_a_edsclr_sounding.ininput/case_setups/arm_sclr_sounding.ininput/case_setups/cloud_feedback_s12_p2k_forcings.ininput/case_setups/clex9_oct14_forcings.ininput/case_setups/cloud_feedback_s12_p2k_sfc.ininput/case_setups/cgils_s12_sfc.ininput/case_setups/mc3e_sfc.ininput/case_setups/arm_97_sclr_sounding.ininput/case_setups/rico_sounding.ininput/case_setups/arm_97_sfc.ininput/case_setups/clex9_nov02_sounding.ininput/case_setups/nov11_altocu_sfc.ininput/case_setups/cloud_feedback_s6_p2k_forcings.ininput/case_setups/clex9_nov02_edsclr_sounding.ininput/case_setups/gabls2_sclr_sounding.ininput/case_setups/cloud_feedback_s6_forcings.ininput/case_setups/astex_a209_forcings.ininput/case_setups/clex9_nov02_sfc.ininput/case_setups/rico_sclr_sounding.ininput/case_setups/arm_0003_sfc.ininput/case_setups/arm_3year_edsclr_sounding.ininput/case_setups/cgils_s12_p2k_forcings.ininput/case_setups/cloud_feedback_s11_sfc.ininput/case_setups/cgils_s11_forcings.ininput/case_setups/cgils_s12_forcings.ininput/case_setups/cloud_feedback_s6_p2k_sfc.ininput/case_setups/cobra_edsclr_sounding.ininput/case_setups/gabls3_sounding.ininput/case_setups/cloud_feedback_s12_sfc.ininput/case_setups/jun25_altocu_sounding.ininput/case_setups/bomex_sounding.ininput/case_setups/fire_sounding.ininput/case_setups/clex9_oct14_sounding.ininput/case_setups/clex9_oct14_sfc.ininput/case_setups/arm_0003_sclr_sounding.ininput/case_setups/gabls3_sclr_sounding.ininput/case_setups/twp_ice_sounding.ininput/case_setups/nov11_altocu_sclr_sounding.ininput/case_setups/gabls2_sounding.ininput/case_setups/arm_97_edsclr_sounding.ininput/case_setups/cobra_sounding.ininput/case_setups/nov11_altocu_edsclr_sounding.ininput/case_setups/nov11_altocu_sounding.ininput/case_setups/wangara_sounding.ininput/case_setups/cobra_forcings.ininput/case_setups/mpace_a_sounding.ininput/case_setups/arm_3year_sfc.ininput/case_setups/mpace_b_sounding.ininput/case_setups/arm_97_sounding.ininput/case_setups/dycoms2_rf02_edsclr_sounding.ininput/case_setups/mpace_b_sfc.ininput/case_setups/clex9_nov02_sclr_sounding.ininput/case_setups/jun25_altocu_edsclr_sounding.ininput/case_setups/jun25_altocu_forcings.ininput/case_setups/cloud_feedback_s11_forcings.ininput/case_setups/cloud_feedback_s12_forcings.ininput/case_setups/twp_ice_forcings.ininput/case_setups/atex_edsclr_sounding.ininput/case_setups/dycoms2_rf01_sfc.ininput/case_setups/rico_edsclr_sounding.ininput/case_setups/cgils_s6_p2k_sfc.ininput/case_setups/cgils_s11_sfc.ininput/case_setups/dycoms2_rf02_sounding.ininput/case_setups/arm_0003_edsclr_sounding.ininput/case_setups/mpace_a_sclr_sounding.ininput/case_setups/arm_edsclr_sounding.ininput/case_setups/arm_sounding.ininput/case_setups/atex_sclr_sounding.ininput/case_setups/clex9_oct14_edsclr_sounding.ininput/case_setups/dycoms2_rf01_sounding.ininput/case_setups/mc3e_sounding.ininput/case_setups/astex_a209_sounding.ininput/case_setups/arm_3year_sounding.ininput/case_setups/arm_3year_sclr_sounding.ininput/case_setups/cobra_sclr_sounding.ininput/case_setups/clex9_nov02_forcings.ininput/case_setups/cloud_feedback_s11_p2k_forcings.ininput/case_setups/fire_edsclr_sounding.ininput/case_setups/clex9_oct14_sclr_sounding.ininput/case_setups/lba_edsclr_sounding.ininput/case_setups/arm_0003_sounding.ininput/case_setups/cgils_s6_p2k_forcings.ininput/case_setups/arm_sfc.in5ef956de6d5f08463887774b6ef968bb23309d971706813870000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduThese should've been single quotes. I didn't tested a files with single quotes, then for some reason did all the changes as double quotes and only retested with gfortran. RESOLVED:9b495acd26a0b009ec84845aa289c36befff0c41
2024-02-01 12:57:50 -06005ef956de6d5f08463887774b6ef968bb23309d97These should've been single quotes. I didn't tested a files with single quotes, then for some reason did all the changes as double quotes and only retested with gfortran. RESOLVED:9b495acd26a0b009ec84845aa289c36befff0c41editinput/case_setups/lba_edsclr_sounding.ineditinput/case_setups/jun25_altocu_sounding.ineditinput/case_setups/fire_sounding.ineditinput/case_setups/cgils_s6_p2k_forcings.ineditinput/case_setups/bomex_sounding.ineditinput/case_setups/neutral_sounding.ineditinput/case_setups/arm_sclr_sounding.ineditinput/case_setups/dycoms2_rf02_sclr_sounding.ineditinput/case_setups/bomex_sclr_sounding.ineditinput/case_setups/twp_ice_sounding.ineditinput/case_setups/rico_edsclr_sounding.ineditinput/case_setups/clex9_nov02_sounding.ineditinput/case_setups/arm_97_sfc.ineditinput/case_setups/arm_sfc.ineditinput/case_setups/cloud_feedback_s12_sfc.ineditinput/case_setups/lba_sounding.ineditinput/case_setups/arm_3year_sounding.ineditinput/case_setups/wangara_sclr_sounding.ineditinput/case_setups/clex9_nov02_forcings.ineditinput/case_setups/arm_97_edsclr_sounding.ineditinput/case_setups/dycoms2_rf02_edsclr_sounding.ineditinput/case_setups/fire_sclr_sounding.ineditinput/case_setups/cgils_s12_sfc.ineditinput/case_setups/clex9_nov02_sfc.ineditinput/case_setups/arm_edsclr_sounding.ineditinput/case_setups/cloud_feedback_s11_forcings.ineditinput/case_setups/gabls2_sounding.ineditinput/case_setups/cloud_feedback_s12_p2k_forcings.ineditinput/case_setups/arm_97_sounding.ineditinput/case_setups/cgils_s6_p2k_sfc.ineditinput/case_setups/astex_a209_forcings.ineditinput/case_setups/mpace_a_edsclr_sounding.ineditinput/case_setups/gabls3_sclr_sounding.ineditinput/case_setups/arm_3year_edsclr_sounding.ineditinput/case_setups/cloud_feedback_s6_p2k_sfc.ineditinput/case_setups/arm_sounding.ineditinput/case_setups/dycoms2_rf02_sounding.ineditinput/case_setups/mc3e_sfc.ineditinput/case_setups/arm_0003_sfc.ineditinput/case_setups/cloud_feedback_s6_forcings.ineditinput/case_setups/arm_3year_sclr_sounding.ineditinput/case_setups/nov11_altocu_sfc.ineditinput/case_setups/cobra_sfc.ineditinput/case_setups/jun25_altocu_forcings.ineditinput/case_setups/gabls3_sounding.ineditinput/case_setups/bomex_edsclr_sounding.ineditinput/case_setups/atex_edsclr_sounding.ineditinput/case_setups/arm_forcings.ineditinput/case_setups/cobra_sounding.ineditinput/case_setups/gabls3_edsclr_sounding.ineditinput/case_setups/nov11_altocu_sclr_sounding.ineditinput/case_setups/arm_3year_sfc.ineditinput/case_setups/lba_sclr_sounding.ineditinput/case_setups/mpace_b_sfc.ineditinput/case_setups/nov11_altocu_edsclr_sounding.ineditinput/case_setups/cobra_edsclr_sounding.ineditinput/case_setups/mc3e_forcings.ineditinput/case_setups/mpace_b_sounding.ineditinput/case_setups/jun25_altocu_sfc.ineditinput/case_setups/wangara_sounding.ineditinput/case_setups/clex9_oct14_sfc.ineditinput/case_setups/cgils_s12_p2k_forcings.ineditinput/case_setups/wangara_edsclr_sounding.ineditinput/case_setups/cloud_feedback_s6_p2k_forcings.ineditinput/case_setups/jun25_altocu_edsclr_sounding.ineditinput/case_setups/arm_0003_sounding.ineditinput/case_setups/arm_97_sclr_sounding.ineditinput/case_setups/cgils_s11_sfc.ineditinput/case_setups/arm_97_forcings.ineditinput/case_setups/clex9_nov02_edsclr_sounding.ineditinput/case_setups/gabls3_night_sounding.ineditinput/case_setups/astex_a209_sounding.ineditinput/case_setups/atex_sounding.ineditinput/case_setups/rico_sounding.ineditinput/case_setups/dycoms2_rf02_sfc.ineditinput/case_setups/cloud_feedback_s12_forcings.ineditinput/case_setups/atex_sclr_sounding.ineditinput/case_setups/cgils_s6_forcings.ineditinput/case_setups/dycoms2_rf01_sounding.ineditinput/case_setups/cgils_s11_forcings.ineditinput/case_setups/dycoms2_rf01_edsclr_sounding.ineditinput/case_setups/arm_0003_forcings.ineditinput/case_setups/cobra_sclr_sounding.ineditinput/case_setups/nov11_altocu_forcings.ineditinput/case_setups/cgils_s12_forcings.ineditinput/case_setups/nov11_altocu_sounding.ineditinput/case_setups/dycoms2_rf01_sfc.ineditinput/case_setups/clex9_oct14_forcings.ineditinput/case_setups/mpace_b_sclr_sounding.ineditinput/case_setups/cgils_s11_p2k_forcings.ineditinput/case_setups/cgils_s12_p2k_sfc.ineditinput/case_setups/arm_0003_sclr_sounding.ineditinput/case_setups/cgils_s11_p2k_sfc.ineditinput/case_setups/mc3e_sounding.ineditinput/case_setups/mpace_b_edsclr_sounding.ineditinput/case_setups/gabls3_forcings.ineditinput/case_setups/cloud_feedback_s11_p2k_forcings.ineditinput/case_setups/twp_ice_forcings.ineditinput/case_setups/clex9_oct14_sclr_sounding.ineditinput/case_setups/mpace_a_sclr_sounding.ineditinput/case_setups/clex9_nov02_sclr_sounding.ineditinput/case_setups/cloud_feedback_s11_sfc.ineditinput/case_setups/fire_edsclr_sounding.ineditinput/case_setups/jun25_altocu_sclr_sounding.ineditinput/case_setups/arm_0003_edsclr_sounding.ineditinput/case_setups/cobra_forcings.ineditinput/case_setups/cloud_feedback_s11_p2k_sfc.ineditinput/case_setups/mpace_a_forcings.ineditinput/case_setups/rico_sclr_sounding.ineditinput/case_setups/gabls2_sclr_sounding.ineditinput/case_setups/mpace_a_sounding.ineditinput/case_setups/clex9_oct14_sounding.ineditinput/case_setups/gabls3_night_forcings.ineditinput/case_setups/cloud_feedback_s12_p2k_sfc.ineditinput/case_setups/cloud_feedback_s6_sfc.ineditinput/case_setups/dycoms2_rf01_sclr_sounding.ineditinput/case_setups/gabls2_edsclr_sounding.ineditinput/case_setups/clex9_oct14_edsclr_sounding.ineditinput/case_setups/cgils_s6_sfc.in
- input/case_setups/cloud_feedback_s11_ozone_sounding.ininput/case_setups/cloud_feedback_s6_sounding.ininput/case_setups/neutral_sounding.ininput/case_setups/cgils_s12_p2k_forcings.ininput/case_setups/cgils_s11_forcings.ininput/case_setups/cgils_s12_forcings.ininput/case_setups/arm_forcings.ininput/case_setups/mc3e_forcings.ininput/case_setups/gabls3_sounding.ininput/case_setups/jun25_altocu_sounding.ininput/case_setups/bomex_sounding.ininput/case_setups/clex9_oct14_sounding.ininput/case_setups/fire_sounding.ininput/case_setups/lba_sounding.ininput/case_setups/gabls3_night_sfc.ininput/case_setups/cloud_feedback_s12_p2k_ozone_sounding.ininput/case_setups/bomex_sfc.ininput/case_setups/ADDING_A_NEW_CASEinput/case_setups/clex9_oct14_sfc.ininput/case_setups/cgils_s12_p2k_sounding.ininput/case_setups/cgils_s11_p2k_forcings.ininput/case_setups/cgils_s6_forcings.ininput/case_setups/gabls3_night_forcings.ininput/case_setups/cobra_sfc.ininput/case_setups/twp_ice_sounding.ininput/case_setups/cloud_feedback_s12_ozone_sounding.ininput/case_setups/gabls2_sounding.ininput/case_setups/cobra_sounding.ininput/case_setups/gabls3_forcings.ininput/case_setups/arm_forcings_code/generate_forcing_file.F90input/case_setups/gabls3_night_sounding.ininput/case_setups/nov11_altocu_sounding.ininput/case_setups/wangara_sounding.ininput/case_setups/cgils_s6_sounding.ininput/case_setups/cloud_feedback_s11_sounding.ininput/case_setups/mpace_a_sounding.ininput/case_setups/cobra_forcings.ininput/case_setups/mpace_b_sounding.ininput/case_setups/arm_97_sounding.ininput/case_setups/cloud_feedback_s12_sounding.ininput/case_setups/jun25_altocu_forcings.ininput/case_setups/cloud_feedback_s11_forcings.ininput/case_setups/cloud_feedback_s12_forcings.ininput/case_setups/arm_97_forcings.ininput/case_setups/twp_ice_forcings.ininput/case_setups/cloud_feedback_s6_p2k_ozone_sounding.ininput/case_setups/nov11_altocu_forcings.ininput/case_setups/arm_0003_forcings.ininput/case_setups/cloud_feedback_s6_p2k_sounding.ininput/case_setups/cgils_s11_ozone_sounding.ininput/case_setups/cgils_s11_sounding.ininput/case_setups/jun25_altocu_sfc.ininput/case_setups/mpace_a_forcings.ininput/case_setups/cloud_feedback_s11_p2k_ozone_sounding.ininput/case_setups/cgils_s11_p2k_sounding.ininput/case_setups/atex_sounding.ininput/case_setups/cloud_feedback_s12_p2k_sounding.ininput/case_setups/cloud_feedback_s12_p2k_forcings.ininput/case_setups/clex9_oct14_forcings.ininput/case_setups/dycoms2_rf02_sounding.ininput/case_setups/cgils_s6_p2k_ozone_sounding.ininput/case_setups/arm_sounding.ininput/case_setups/cgils_s12_ozone_sounding.ininput/case_setups/cgils_s6_p2k_sounding.ininput/case_setups/rico_sounding.ininput/case_setups/dycoms2_rf01_sounding.ininput/case_setups/mc3e_sounding.ininput/case_setups/cgils_s11_p2k_ozone_sounding.ininput/case_setups/astex_a209_sounding.ininput/case_setups/cgils_s12_p2k_ozone_sounding.ininput/case_setups/clex9_nov02_sounding.ininput/case_setups/arm_3year_sounding.ininput/case_setups/nov11_altocu_sfc.ininput/case_setups/clex9_nov02_forcings.ininput/case_setups/cloud_feedback_s6_p2k_forcings.ininput/case_setups/cloud_feedback_s11_p2k_forcings.ininput/case_setups/twp_ice_ozone_sounding.ininput/case_setups/cgils_s12_sounding.ininput/case_setups/cloud_feedback_s6_ozone_sounding.ininput/case_setups/arm_0003_sounding.ininput/case_setups/cgils_s6_ozone_sounding.ininput/case_setups/cloud_feedback_s6_forcings.ininput/case_setups/astex_a209_forcings.ininput/case_setups/clex9_nov02_sfc.ininput/case_setups/cgils_s6_p2k_forcings.ininput/case_setups/cloud_feedback_s11_p2k_sounding.inb5ee3141be816d210f2942609e2889e2ddfc5b5a1706816764000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSome files have tabs in them, this broke my previous sed commands in various spots.
2024-02-01 13:46:04 -0600b5ee3141be816d210f2942609e2889e2ddfc5b5aSome files have tabs in them, this broke my previous sed commands in various spots.editinput/case_setups/arm_sounding.ineditinput/case_setups/neutral_sounding.ineditinput/case_setups/cobra_sfc.ineditinput/case_setups/cgils_s11_p2k_sounding.ineditinput/case_setups/mc3e_sounding.ineditinput/case_setups/twp_ice_sounding.ineditinput/case_setups/mpace_a_forcings.ineditinput/case_setups/ADDING_A_NEW_CASEeditinput/case_setups/dycoms2_rf01_sounding.ineditinput/case_setups/cloud_feedback_s12_p2k_sounding.ineditinput/case_setups/arm_97_forcings.ineditinput/case_setups/arm_forcings_code/generate_forcing_file.F90editinput/case_setups/jun25_altocu_sounding.ineditinput/case_setups/cloud_feedback_s6_ozone_sounding.ineditinput/case_setups/twp_ice_ozone_sounding.ineditinput/case_setups/cloud_feedback_s6_p2k_forcings.ineditinput/case_setups/cloud_feedback_s6_sounding.ineditinput/case_setups/astex_a209_forcings.ineditinput/case_setups/arm_forcings.ineditinput/case_setups/clex9_oct14_sounding.ineditinput/case_setups/wangara_sounding.ineditinput/case_setups/nov11_altocu_forcings.ineditinput/case_setups/fire_sounding.ineditinput/case_setups/gabls3_night_sfc.ineditinput/case_setups/nov11_altocu_sfc.ineditinput/case_setups/dycoms2_rf02_sounding.ineditinput/case_setups/cloud_feedback_s11_forcings.ineditinput/case_setups/mpace_b_sounding.ineditinput/case_setups/gabls3_night_sounding.ineditinput/case_setups/cloud_feedback_s12_ozone_sounding.ineditinput/case_setups/cobra_sounding.ineditinput/case_setups/cgils_s12_sounding.ineditinput/case_setups/cgils_s6_p2k_sounding.ineditinput/case_setups/cgils_s6_sounding.ineditinput/case_setups/bomex_sfc.ineditinput/case_setups/clex9_oct14_sfc.ineditinput/case_setups/twp_ice_forcings.ineditinput/case_setups/cgils_s11_ozone_sounding.ineditinput/case_setups/cgils_s12_p2k_sounding.ineditinput/case_setups/cgils_s6_p2k_forcings.ineditinput/case_setups/clex9_nov02_forcings.ineditinput/case_setups/mc3e_forcings.ineditinput/case_setups/cgils_s11_sounding.ineditinput/case_setups/cloud_feedback_s11_p2k_sounding.ineditinput/case_setups/arm_97_sounding.ineditinput/case_setups/cloud_feedback_s11_sounding.ineditinput/case_setups/arm_0003_sounding.ineditinput/case_setups/cgils_s12_p2k_ozone_sounding.ineditinput/case_setups/clex9_nov02_sounding.ineditinput/case_setups/mpace_a_sounding.ineditinput/case_setups/cgils_s11_p2k_forcings.ineditinput/case_setups/cgils_s6_ozone_sounding.ineditinput/case_setups/clex9_nov02_sfc.ineditinput/case_setups/cgils_s11_p2k_ozone_sounding.ineditinput/case_setups/cgils_s6_forcings.ineditinput/case_setups/cloud_feedback_s11_ozone_sounding.ineditinput/case_setups/cloud_feedback_s11_p2k_ozone_sounding.ineditinput/case_setups/gabls3_night_forcings.ineditinput/case_setups/cgils_s12_p2k_forcings.ineditinput/case_setups/cloud_feedback_s12_p2k_forcings.ineditinput/case_setups/cgils_s12_forcings.ineditinput/case_setups/cgils_s6_p2k_ozone_sounding.ineditinput/case_setups/cobra_forcings.ineditinput/case_setups/rico_sounding.ineditinput/case_setups/atex_sounding.ineditinput/case_setups/jun25_altocu_sfc.ineditinput/case_setups/cgils_s11_forcings.ineditinput/case_setups/arm_3year_sounding.ineditinput/case_setups/cloud_feedback_s11_p2k_forcings.ineditinput/case_setups/gabls3_forcings.ineditinput/case_setups/cloud_feedback_s6_p2k_ozone_sounding.ineditinput/case_setups/cloud_feedback_s12_sounding.ineditinput/case_setups/cloud_feedback_s12_p2k_ozone_sounding.ineditinput/case_setups/gabls3_sounding.ineditinput/case_setups/nov11_altocu_sounding.ineditinput/case_setups/gabls2_sounding.ineditinput/case_setups/lba_sounding.ineditinput/case_setups/cgils_s12_ozone_sounding.ineditinput/case_setups/cloud_feedback_s12_forcings.ineditinput/case_setups/arm_0003_forcings.ineditinput/case_setups/astex_a209_sounding.ineditinput/case_setups/cloud_feedback_s6_forcings.ineditinput/case_setups/cloud_feedback_s6_p2k_sounding.ineditinput/case_setups/clex9_oct14_forcings.ineditinput/case_setups/jun25_altocu_forcings.ineditinput/case_setups/bomex_sounding.in
- compile/convert_acc_to_omp.bash5d5c3fc2bbc789e680c668a92865d405828bb73b1706816883000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding -no-declare-mapper to the openmp conversion script. This adds a sort of data mapper for derived types, but we just copy those in explicitly so they are unneccesary. They also cause problems for the cray compiler.
2024-02-01 13:48:03 -06005d5c3fc2bbc789e680c668a92865d405828bb73bAdding -no-declare-mapper to the openmp conversion script. This adds a sort of data mapper for derived types, but we just copy those in explicitly so they are unneccesary. They also cause problems for the cray compiler.editcompile/convert_acc_to_omp.bash
- input/case_setups/cloud_feedback_s12_forcings.ininput/case_setups/cloud_feedback_s11_forcings.ininput/std_atmosphere/atmosphere.ininput/case_setups/twp_ice_forcings.ininput/case_setups/cgils_s11_p2k_forcings.ininput/case_setups/cgils_s6_forcings.ininput/case_setups/cgils_s12_p2k_forcings.ininput/case_setups/cgils_s11_forcings.ininput/case_setups/gabls3_forcings.ininput/case_setups/cgils_s12_forcings.ininput/case_setups/cloud_feedback_s6_p2k_forcings.ininput/case_setups/cloud_feedback_s11_p2k_forcings.ininput/case_setups/cloud_feedback_s6_forcings.ininput/case_setups/cloud_feedback_s12_p2k_forcings.ininput/case_setups/astex_a209_forcings.ininput/case_setups/cgils_s6_p2k_forcings.ininput/case_setups/lba_sounding.in34f6783b8a903a4d1cb7311ad4ac06d78ce4541a1706817691000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSome more places we need changes.
2024-02-01 14:01:31 -060034f6783b8a903a4d1cb7311ad4ac06d78ce4541aSome more places we need changes.editinput/case_setups/cgils_s11_p2k_forcings.ineditinput/case_setups/cloud_feedback_s6_forcings.ineditinput/case_setups/cloud_feedback_s12_forcings.ineditinput/case_setups/cgils_s11_forcings.ineditinput/case_setups/cgils_s12_p2k_forcings.ineditinput/case_setups/cloud_feedback_s12_p2k_forcings.ineditinput/case_setups/cgils_s6_forcings.ineditinput/case_setups/gabls3_forcings.ineditinput/case_setups/cgils_s12_forcings.ineditinput/case_setups/twp_ice_forcings.ineditinput/case_setups/cloud_feedback_s11_p2k_forcings.ineditinput/std_atmosphere/atmosphere.ineditinput/case_setups/cloud_feedback_s6_p2k_forcings.ineditinput/case_setups/lba_sounding.ineditinput/case_setups/cgils_s6_p2k_forcings.ineditinput/case_setups/cloud_feedback_s11_forcings.ineditinput/case_setups/astex_a209_forcings.in
- input/case_setups/jun25_altocu_forcings.ininput/case_setups/cloud_feedback_s11_forcings.ininput/case_setups/cloud_feedback_s12_forcings.ininput/case_setups/twp_ice_forcings.ininput/case_setups/arm_97_forcings.ininput/case_setups/cgils_s6_forcings.ininput/case_setups/gabls3_night_forcings.ininput/case_setups/nov11_altocu_forcings.ininput/case_setups/arm_0003_forcings.ininput/case_setups/clex9_nov02_forcings.ininput/case_setups/mpace_a_forcings.ininput/case_setups/cloud_feedback_s6_p2k_forcings.ininput/case_setups/cloud_feedback_s11_p2k_forcings.ininput/case_setups/cobra_forcings.ininput/case_setups/cloud_feedback_s6_forcings.ininput/case_setups/cloud_feedback_s12_p2k_forcings.ininput/case_setups/clex9_oct14_forcings.ininput/case_setups/cgils_s6_p2k_forcings.in0959fd13263a987aa267187eee415f7cb9b1da5a1706818453000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduHopefully the final sneaky error
2024-02-01 14:14:13 -06000959fd13263a987aa267187eee415f7cb9b1da5aHopefully the final sneaky erroreditinput/case_setups/twp_ice_forcings.ineditinput/case_setups/mpace_a_forcings.ineditinput/case_setups/cobra_forcings.ineditinput/case_setups/cloud_feedback_s11_forcings.ineditinput/case_setups/nov11_altocu_forcings.ineditinput/case_setups/cloud_feedback_s12_p2k_forcings.ineditinput/case_setups/arm_97_forcings.ineditinput/case_setups/clex9_nov02_forcings.ineditinput/case_setups/gabls3_night_forcings.ineditinput/case_setups/cloud_feedback_s12_forcings.ineditinput/case_setups/cgils_s6_p2k_forcings.ineditinput/case_setups/jun25_altocu_forcings.ineditinput/case_setups/clex9_oct14_forcings.ineditinput/case_setups/cloud_feedback_s6_p2k_forcings.ineditinput/case_setups/cloud_feedback_s6_forcings.ineditinput/case_setups/arm_0003_forcings.ineditinput/case_setups/cgils_s6_forcings.ineditinput/case_setups/cloud_feedback_s11_p2k_forcings.in
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_helper_module.F90595e2c13024c1e913815d56ae724823a82bddc031707345359000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduFixing a bug where the Lscale used in calculating the damping
coefficient in advance_xm_wpxp_module.F90 should be Lscale_zm,
since the term is calculated on momentum grid levels.
Along the way, I found out that I could streamline the code
by passing in the value of Lscale_zm that was already calculated
(interpolated from Lscale) in advance_clubb_core. This value
could be passed into both advance_xm_wpxp and calc_stability_correction,
and then fed down.
This results of this code change are bit-for-bit identical with the
previous revision, most likely because this code only matters when
certain flags are flipped that are not used by default.
2024-02-07 16:35:59 -0600595e2c13024c1e913815d56ae724823a82bddc03Fixing a bug where the Lscale used in calculating the dampingeditsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90
- src/CLUBB_core/model_flags.F90f33de5875ae5ea3ea237e8123efb804de0f822281707410339000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comadding equals sign cuz I've had it up to here with this typo!
2024-02-08 09:38:59 -0700f33de5875ae5ea3ea237e8123efb804de0f82228adding equals sign cuz I've had it up to here with this typo!editsrc/CLUBB_core/model_flags.F90
- src/CLUBB_core/stats_zt_module.F904b25d3a0efe6174e27aca762ff4a26fb0b6560471707839985000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@users.noreply.github.comfixing bug, name of wm_zt was left as "wm"
2024-02-13 09:59:45 -06004b25d3a0efe6174e27aca762ff4a26fb0b656047fixing bug, name of wm_zt was left as "wm"editsrc/CLUBB_core/stats_zt_module.F90
- READMEa1965f133c3edf1eee0a090a1ee34b7e619f66ff1707869263000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduREADME change to add BIT_CHANGING:595e2c13024c1e913815d56ae724823a82bddc03 when using l_diag_Lscale_from_tau=.false. and for the CAM repo we have BIT_CHANGING:d275ac17f3e53d65641c3210df33ce0fad4e5aef as the hash
2024-02-13 18:07:43 -0600a1965f133c3edf1eee0a090a1ee34b7e619f66ffREADME change to add BIT_CHANGING:595e2c13024c1e913815d56ae724823a82bddc03 when using l_diag_Lscale_from_tau=.false. and for the CAM repo we have BIT_CHANGING:d275ac17f3e53d65641c3210df33ce0fad4e5aef as the hasheditREADME
- src/CLUBB_core/clubb_api_module.F90b7ae0f1b35db3daf7bee3b5a6dd9221bd3c7e50d1707948133000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd blank line in order to trigger Jenkins tests for CAM
In particular, Brian Griffin's code change from 7 Feb 2024,
BIT_CHANGING:595e2c13024c1e913815d56ae724823a82bddc03
changes answers when using l_diag_Lscale_from_tau=.false.
This code change was brought into the CAM repo in this commit:
BIT_CHANGING:d275ac17f3e53d65641c3210df33ce0fad4e5aef
2024-02-14 16:02:13 -0600b7ae0f1b35db3daf7bee3b5a6dd9221bd3c7e50dAdd blank line in order to trigger Jenkins tests for CAMeditsrc/CLUBB_core/clubb_api_module.F90
- src/input_fields.F908eb97839237623e96720a0101dc0c40f522759271707952876000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing restarts by changing wm to wm_zt, the stats output name was changed in 4b25d3a
2024-02-14 17:21:16 -06008eb97839237623e96720a0101dc0c40f52275927Fixing restarts by changing wm to wm_zt, the stats output name was changed in 4b25d3aeditsrc/input_fields.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/constants_clubb.F90src/CLUBB_core/model_flags.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/mono_flux_limiter.F90src/CLUBB_core/advance_helper_module.F90src/CLUBB_core/sfc_varnce_module.F90src/CLUBB_core/mixing_length.F9090f3976ec42f513108090135011800a1b93017341708052285000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comSmall acc tweaks (#1144)
* Removing unneccesary acc declare statements.
* Removing use of acc routine in favor of new 1D array routine for smooth_max.
* The new tmp_calc_ngrdcol should be copied regardless of flag
* tmp_calc_ngrdcol also needs to be deleted unconditionally.
* Making separate conditional acc copy for edsclrdim variables.
* Adding ifdefs around prints inside of openacc kernel
* Making erf_cache and exp_cache scalars, there was no need for them to be arrays.
* Making update host statements with sclr_dim or edsclr_dim conditional. Without these we get runtime errors with cray+openacc
* Removed files
2024-02-15 20:58:05 -060090f3976ec42f513108090135011800a1b9301734Small acc tweaks (#1144)editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/sfc_varnce_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/constants_clubb.F90editsrc/CLUBB_core/model_flags.F90editsrc/CLUBB_core/mono_flux_limiter.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/mixing_length.F90
- src/CLUBB_core/advance_clubb_core_module.F90fc6fd8cf6ef01fb1f1e151abee424ad5203c4d721709675532000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemoves comment about Numerical Recipes
2024-03-05 15:52:12 -0600fc6fd8cf6ef01fb1f1e151abee424ad5203c4d72Removes comment about Numerical Recipeseditsrc/CLUBB_core/advance_clubb_core_module.F90
- compile/config/linux_x86_64_cray_frontier.bash30fc720efe7da567c76182426718583cd814697a1710265373000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerguntherhuebler@login01.frontier.olcf.ornl.govAdding new compile script for frontier+cray
2024-03-12 13:42:53 -040030fc720efe7da567c76182426718583cd814697aAdding new compile script for frontier+crayaddcompile/config/linux_x86_64_cray_frontier.bash
- src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/mono_flux_limiter.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/fill_holes.F90src/CLUBB_core/advance_wp2_wp3_module.F906909e9aa343dc087ffc261cee0a9b8a8646bdc1b1710806789000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comOpenMP Optimizations (#1146)
* Small changes to improve omp performance.
* Some more small changes to help openmp
* Adhering to standards a little better by specifying _core_rknd
2024-03-18 19:06:29 -05006909e9aa343dc087ffc261cee0a9b8a8646bdc1bOpenMP Optimizations (#1146)editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/mono_flux_limiter.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/fill_holes.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90
- src/CLUBB_core/fill_holes.F90db81035ebff94b1342910180c9042dea956ed7461711137584000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding comment to explain unusual code choice.
2024-03-22 14:59:44 -0500db81035ebff94b1342910180c9042dea956ed746Adding comment to explain unusual code choice.editsrc/CLUBB_core/fill_holes.F90
- src/CLUBB_core/fill_holes.F90650cd4c0dc90ff1c184e4617092fbc9c1c2a657e1711302893000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding sum part to comment
2024-03-24 12:54:53 -0500650cd4c0dc90ff1c184e4617092fbc9c1c2a657eAdding sum part to commenteditsrc/CLUBB_core/fill_holes.F90
- src/CLUBB_core/new_hybrid_pdf_main.F90src/CLUBB_core/parameters_tunable.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/clip_explicit.F90src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90src/clubb_thread_test.F90src/CLUBB_core/sfc_varnce_module.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/Skx_module.F90src/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/clubb_standalone.F90src/jacobian.F90src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F90src/variables_radiation_module.F90src/G_unit_test_types/pdf_parameter_tests.F90src/error.F90src/CLUBB_core/advance_helper_module.F90src/CLUBB_core/new_pdf_main.F9035d228ebbb66b1463f30659321cd4f7d76adffa21711925174000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comPutting ngrdcol in clubb_params (#1147)
* Initial changes to make clubb_params have an ngrdcol dimension. All BFB on CPU and GPU.
* pdf_closure done
* pdf_closure missed changes
* calc_Lscale_directly changes and removed accidentally added files
* advance_xp2_xpyp done
* Missed file
* Added space here because the addition of this line in the last commit is to prevent Ri_zm from being uninitialized when using l_diag_Lscale_from_tau=.false.
* advance_wp2_wp3 done
* advance_xm_wpxp done
* Fixed bugs found by checking l_modify_limiters_for_cnvg_test=.true.
* Fixed bug found by checking l_diffuse_rtm_and_thlm and l_stability_correct_Kh_N2_zm
* Removing slightly redundant logic
* Swapping back order of l_gamma_skw if statements. I'm not sure why I swapped them in the first place.
2024-03-31 17:46:14 -050035d228ebbb66b1463f30659321cd4f7d76adffa2Putting ngrdcol in clubb_params (#1147)editsrc/CLUBB_core/parameters_tunable.F90editsrc/CLUBB_core/mixing_length.F90editsrc/clubb_standalone.F90editsrc/error.F90editsrc/variables_radiation_module.F90editsrc/jacobian.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/Skx_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/clip_explicit.F90editsrc/clubb_thread_test.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90editsrc/CLUBB_core/sfc_varnce_module.F90editsrc/CLUBB_core/new_hybrid_pdf_main.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/CLUBB_core/new_pdf_main.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/clubb_api_module.F90
- src/CLUBB_core/advance_xm_wpxp_module.F906a1e8890090ef11ea420d2868ad6d2f102021cb81712000028000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bug with C6 parameters, see https://github.com/larson-group/clubb/pull/1147. This is technically BIT_CHANGING, but only when C6thl != C6thlb and l_diag_Lscale_from_tau=.false.
2024-04-01 14:33:48 -05006a1e8890090ef11ea420d2868ad6d2f102021cb8Fixing bug with C6 parameters, see https://github.com/larson-group/clubb/pull/1147. This is technically BIT_CHANGING, but only when C6thl != C6thlb and l_diag_Lscale_from_tau=.false.editsrc/CLUBB_core/advance_xm_wpxp_module.F90
- README76e4ab2bacd0c770cc861330436f1631dd8c11c41712000383000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding space to make commit because last commit RESOLVED:35d228ebbb66b1463f30659321cd4f7d76adffa2
2024-04-01 14:39:43 -050076e4ab2bacd0c770cc861330436f1631dd8c11c4Adding space to make commit because last commit RESOLVED:35d228ebbb66b1463f30659321cd4f7d76adffa2editREADME
- src/variables_radiation_module.F90f4eddbe57c7e8def8bfbcda6a7ef2fa5cdb7af141712005481000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing a bug. These directives get added when running the ACC to OMP conversion script. I'm unsure how I accidentally commited this, and equally unsure of how only one file is affected. This was found while debugging the clubb thread test
2024-04-01 16:04:41 -0500f4eddbe57c7e8def8bfbcda6a7ef2fa5cdb7af14Fixing a bug. These directives get added when running the ACC to OMP conversion script. I'm unsure how I accidentally commited this, and equally unsure of how only one file is affected. This was found while debugging the clubb thread testeditsrc/variables_radiation_module.F90
- src/CLUBB_core/advance_xp2_xpyp_module.F9045b34a9553d7741f7f6f057941c82b20801c17511712297060000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAt the ghost point below the surface, which does not matter in
the calculations, a value of 0 is now being entered for
thermodynamic-level output stats coef_wprtp2_implicit,
term_wprtp2_explicit, etc.
Why would we do this? The answer is "Why Not??!!!!"
This is being done to keep the trunk results bit-for-bit with
the clubb_ghost_exorcism branch, which is no longer loops over
the ghost level below the surface in the region of code
where these stats are recorded.
In terms of the master, this commit is technically BIT_CHANGING.
However, only for these 6 output terms at the ghost point.
2024-04-05 01:04:20 -050045b34a9553d7741f7f6f057941c82b20801c1751At the ghost point below the surface, which does not matter ineditsrc/CLUBB_core/advance_xp2_xpyp_module.F90
- src/CLUBB_core/advance_windm_edsclrm_module.F9056254ef6787724e586ed16a974b53a66539af8a91712376324000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThe code that advances um and vm when l_predict_upwp_vpwp is turned off
(as found in advance_windm_edsclrm) was accessing the ghost point in
one spot. I rewrote it in the exact way the code in the
clubb_ghost_exorcism branch is written so that it makes the same
calculation without referencing the ghost point.
I also rewrote a couple stats by outputting a value of 0 at the ghost
point to maintain stat consistency between the master and the ghost
exorcism branch.
This commit is BIT_CHANGING, but only when the l_predict_upwp_vpwp
flag is set to false (which is not the case by default).
2024-04-05 23:05:24 -050056254ef6787724e586ed16a974b53a66539af8a9The code that advances um and vm when l_predict_upwp_vpwp is turned offeditsrc/CLUBB_core/advance_windm_edsclrm_module.F90
- src/CLUBB_core/advance_windm_edsclrm_module.F90input/case_setups/lba_model.ininput/tunable_parameters/configurable_model_flags.in5e8d77d91747026bab725541591873b57d68e4301712412930000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduIt was discovered that the location where the ghost point values
of um and vm were set equal to their respective values at the first
thermodynamic level above the surface was not ideal. Their
assignment occurred before the love nudge (l_uv_nudge). Then,
the love nudge came along and altered their values so that
um(1) no longer equaled um(2) -- and analogous for vm(1) and vm(2) --
for a half dozen cases. In addition to making the code inconsistent,
it also caused bit-for-bitness differences between the master
and clubb_ghost_exorcism branches. For those reasons, this
BIT_CHANGING commit is being made.
2024-04-06 09:15:30 -05005e8d77d91747026bab725541591873b57d68e430It was discovered that the location where the ghost point valueseditinput/case_setups/lba_model.ineditinput/tunable_parameters/configurable_model_flags.ineditsrc/CLUBB_core/advance_windm_edsclrm_module.F90
- input/tunable_parameters/configurable_model_flags.ininput/case_setups/lba_model.ina492228d3adfed56f8777d12176fcd7d165260f61712413386000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI accidentally committed a couple things in the previous commit
that weren't supposed to be committed, so I am undoing that immediately
2024-04-06 09:23:06 -0500a492228d3adfed56f8777d12176fcd7d165260f6I accidentally committed a couple things in the previous commiteditinput/tunable_parameters/configurable_model_flags.ineditinput/case_setups/lba_model.in
- src/hydrostatic_module.F90eb12d64551ab8a400cc2c876fa8c5af4d395b05e1712426051000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing loop into calc_ref_z_linear_thvm to prevent erroneous inlining optimizations by nvfortran. This is BFB on nvhpc 24.3 with -O0 and BFB on nvhpc 22.5 with -O2. https://github.com/larson-group/clubb/issues/1148
2024-04-06 12:54:11 -0500eb12d64551ab8a400cc2c876fa8c5af4d395b05ePushing loop into calc_ref_z_linear_thvm to prevent erroneous inlining optimizations by nvfortran. This is BFB on nvhpc 24.3 with -O0 and BFB on nvhpc 22.5 with -O2. https://github.com/larson-group/clubb/issues/1148editsrc/hydrostatic_module.F90
- README3d47f2c171172eb9d99fc8c0abf747d8ec4106ce1712450573000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking commit to test jenkins.
2024-04-06 19:42:53 -05003d47f2c171172eb9d99fc8c0abf747d8ec4106ceMaking commit to test jenkins.editREADME
- README259ad39f5a5809336e44222a7420fee9cc2cbed21712549608000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking change to add RESOLVED:a492228d3adfed56f8777d12176fcd7d165260f6, which was technically bit changing because it undid changes to the config flags AND was tested relative to the previous commit (which introduced the flag changes) because that one was labelled as bit changing.
2024-04-07 23:13:28 -0500259ad39f5a5809336e44222a7420fee9cc2cbed2Making change to add RESOLVED:a492228d3adfed56f8777d12176fcd7d165260f6, which was technically bit changing because it undid changes to the config flags AND was tested relative to the previous commit (which introduced the flag changes) because that one was labelled as bit changing.editREADME
- src/CLUBB_core/advance_xm_wpxp_module.F902bcf4d87557d3c6cf32ba0651d109fae70ef09bf1712762923000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduWhile it doesn't affect results, I fixed what appears to be an
obvious bug in advance_xm_wpxp. If everything is at a singular zm
level, the referenced height shouldn't be gr%zt, but rather gr%zm.
2024-04-10 10:28:43 -05002bcf4d87557d3c6cf32ba0651d109fae70ef09bfWhile it doesn't affect results, I fixed what appears to be aneditsrc/CLUBB_core/advance_xm_wpxp_module.F90
- src/CLUBB_core/advance_xm_wpxp_module.F90be09281d23655b337060e449482df6e6f3f3b9191712768355000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am updating the loop in subroutine diagnose_xpwp so that it doesn't
loop over the model upper or lower boundaries. Calculations at those
levels are irrelevant to the results, and their inclusion causes
bitness differences between the master and clubb_ghost_exorcism
branches. Since this code change causes differences in the zm
stats file at the upper and lower boundaries for a few fields, this
commit is technically BIT_CHANGING, although it should be noted
that it does not change the simulation results.
2024-04-10 11:59:15 -0500be09281d23655b337060e449482df6e6f3f3b919I am updating the loop in subroutine diagnose_xpwp so that it doesn'teditsrc/CLUBB_core/advance_xm_wpxp_module.F90
- src/CLUBB_core/advance_xm_wpxp_module.F9077b2d91b0655bc1c51a18daa253436a86f7aa80e1712811418000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThis commit is being made to keep the stats zt output from the
master branch inline with the output from the clubb_ghost_exorcism
branch. In short, the only change is that the value of
a couple of inputs relative to wpxp turbulent advection from
thermodynamic level 1 are set to 0 for stats output in order to
keep the master and ghost exorcism branches bit-for-bit with
each other. The output at those levels are not used in
any calculations and are unnecessary. However, this change
is technically BIT_CHANGING.
2024-04-10 23:56:58 -050077b2d91b0655bc1c51a18daa253436a86f7aa80eThis commit is being made to keep the stats zt output from theeditsrc/CLUBB_core/advance_xm_wpxp_module.F90
- src/CLUBB_core/advance_helper_module.F9078772016357da67602b1675dd70e64c5eac194861712890626000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am committing a bug fix to the code that calculates mixed Brunt
Vaisala frequency. The variable ice_supersat_frac was used directly
in calculations that are supposed to take place on a momentum level.
The fix is to interpolated ice_supersat_frac to momentum levels before
use. This commit is BIT_CHANGING.
2024-04-11 21:57:06 -050078772016357da67602b1675dd70e64c5eac19486I am committing a bug fix to the code that calculates mixed Brunteditsrc/CLUBB_core/advance_helper_module.F90
- compile/config/linux_x86_64_nvhpc_gpu_openmp.basha9512e56aefd1309b096ef23170fc5b7090f09a21712978557000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding -noacc to nvhpc openmp config script, sometimes nvhpc compiles acc code automatically, and this shuts it off.
2024-04-12 22:22:37 -0500a9512e56aefd1309b096ef23170fc5b7090f09a2Adding -noacc to nvhpc openmp config script, sometimes nvhpc compiles acc code automatically, and this shuts it off.editcompile/config/linux_x86_64_nvhpc_gpu_openmp.bash
- src/CLUBB_core/mono_flux_limiter.F90573dc6073eb8dea603e3e6ba00111787bb7509951713021941000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am committing a stats change to the ghost point values of zt
stats output variables found in the monotonic flux limiter. These
values are all being set simply to 0 at the ghost point for
purposes of providing an easy comparison to stats output files
from the clubb_ghost_exorcism branch. The code change is
not at all answer changing. However, it is technically BIT_CHANGING.
2024-04-13 10:25:41 -0500573dc6073eb8dea603e3e6ba00111787bb750995I am committing a stats change to the ghost point values of zteditsrc/CLUBB_core/mono_flux_limiter.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xp3_module.F90src/G_unit_test_types/spurious_source_test.F90src/advance_microphys_module.F90src/CLUBB_core/setup_clubb_pdf_params.F90src/CLUBB_core/calc_pressure.F90src/CLUBB_core/advance_helper_module.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/advance_xp2_xpyp_module.F9084588a46852a812266d19e36a8220f71ad56043a1713448035000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduCommitting some thresholding around positive-definite fields after
a zt2zm statement. This commit does not change the results in our
CLUBB standalone cases.
2024-04-18 08:47:15 -050084588a46852a812266d19e36a8220f71ad56043aCommitting some thresholding around positive-definite fields aftereditsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/setup_clubb_pdf_params.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/advance_xp3_module.F90editsrc/G_unit_test_types/spurious_source_test.F90editsrc/advance_microphys_module.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/calc_pressure.F90editsrc/CLUBB_core/mixing_length.F90
- src/CLUBB_core/grid_class.F903d364fec45434074a7d9d1815861b4ff8d6df6741713562695000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduChanging the linear interpolation in the zt2zm function at momentum
level 1 from an interpolation between the ghost point and the first
level above the surface to simply a "drop down" of the value found
at the first level above the surface.
This is being done ahead of the removal of the ghost point from the
model.
Results of this change are BIT_CHANGING.
2024-04-19 16:38:15 -05003d364fec45434074a7d9d1815861b4ff8d6df674Changing the linear interpolation in the zt2zm function at momentumeditsrc/CLUBB_core/grid_class.F90
- src/CLUBB_core/grid_class.F909136bf065fe59e64db24c8a3f2aeee71784502731713916476000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI'm changing the way ddzt handles the derivative over momentum level 1.
Previously, it was based on the differential between the ghost point and
the first level above the surface. Now, the value of the derivative at
momentum level 2 is simply being dropped down to momentum level 1.
This is being done in advance of ghost point removal.
The results of this commit are BIT_CHANGING.
2024-04-23 18:54:36 -05009136bf065fe59e64db24c8a3f2aeee7178450273I'm changing the way ddzt handles the derivative over momentum level 1.editsrc/CLUBB_core/grid_class.F90
- README7b429b2f394be33db0348d15755e28d832264e071714415012000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding space to include BIT_CHANGING:84588a46852a812266d19e36a8220f71ad56043a. This (https://github.com/larson-group/clubb/commit/84588a46852a812266d19e36a8220f71ad56043a) is described as not bit changing, but that seems to depend on the compiler version and some flags. The bin diff tests detected differences in only twp_ice when using e3sm flags on nelson, and both e3sm flags and default flags on carson.
2024-04-29 13:23:32 -05007b429b2f394be33db0348d15755e28d832264e07Adding space to include BIT_CHANGING:84588a46852a812266d19e36a8220f71ad56043a. This (https://github.com/larson-group/clubb/commit/84588a46852a812266d19e36a8220f71ad56043a) is described as not bit changing, but that seems to depend on the compiler version and some flags. The bin diff tests detected differences in only twp_ice when using e3sm flags on nelson, and both e3sm flags and default flags on carson.editREADME
- src/CLUBB_core/advance_xm_wpxp_module.F90b2af0adcfce248292c5d48aefd9226666ee633e51714471119000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduMoved the ghost-point setting of xm(1) = xm(2) to the last line
of the subroutine so this command doesn't get overwritten.
This is technically BIT_CHANGING because it alters rtm (and some
rtm-related calculations) at the ghost point, but it is not
answer changing.
This is being done in preparation for ghost point removal.
2024-04-30 04:58:39 -0500b2af0adcfce248292c5d48aefd9226666ee633e5Moved the ghost-point setting of xm(1) = xm(2) to the last lineeditsrc/CLUBB_core/advance_xm_wpxp_module.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/CLUBB_core/advance_xp3_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/grid_class.F90src/CLUBB_core/setup_clubb_pdf_params.F90src/CLUBB_core/calc_pressure.F90src/CLUBB_core/advance_helper_module.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/advance_xp2_xpyp_module.F90556370c6406e6b943b88affbe7728a5036b1ba221714534975000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comOptional arguments are just best sometimes (#1150)
* Adding optional argument to zm2zt/zt2zm to act as threshold. This cuts down on lots of bulk and reduces the chances of breaking the GPU code. All BFB.
* Removing TODO
* Replacing hardcoded 0.0_core_rknd with zero_threshold
2024-04-30 22:42:55 -0500556370c6406e6b943b88affbe7728a5036b1ba22Optional arguments are just best sometimes (#1150)editsrc/CLUBB_core/advance_xp3_module.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/calc_pressure.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/grid_class.F90editsrc/CLUBB_core/setup_clubb_pdf_params.F90
- src/CLUBB_core/advance_clubb_core_module.F90e904e3ffbf83888681ba64f9008890329bd186311714537919000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bug. RESOLVED:556370c6406e6b943b88affbe7728a5036b1ba22, this was catchable by using debugging flags, but seems to otherwise cause no issues. Investigating I found that it only clips the below ground level, so that must not have been affecting other levels. This is technically BIT_CHANGING since it resolves an issue.
2024-04-30 23:31:59 -0500e904e3ffbf83888681ba64f9008890329bd18631Fixing bug. RESOLVED:556370c6406e6b943b88affbe7728a5036b1ba22, this was catchable by using debugging flags, but seems to otherwise cause no issues. Investigating I found that it only clips the below ground level, so that must not have been affecting other levels. This is technically BIT_CHANGING since it resolves an issue.editsrc/CLUBB_core/advance_clubb_core_module.F90
- src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/Morrison_microphys/microphysics.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/fill_holes.F90src/CLUBB_core/advance_xp2_xpyp_module.F903abb325943da1a557e1213b2908ead3c828aff161714587276000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking num_draw_points in fill_holes a constant. We were already using this value as a constant everywhere, but passing a constant by argument list makes it difficult/impossible for a compiler to optimize using that constant, unless it does inlining. Now, rather than passing the constant num_hf_draw_points (or sometimes a hardcoded 2) we just use num_hf_draw_points directly from constants_clubb. This massively improves the performance of a loop in fill holes when using nvhpc+omp, which was the motivation for this, but should also improve the performance on CPUs. Everything is BFB.
2024-05-01 13:14:36 -05003abb325943da1a557e1213b2908ead3c828aff16Making num_draw_points in fill_holes a constant. We were already using this value as a constant everywhere, but passing a constant by argument list makes it difficult/impossible for a compiler to optimize using that constant, unless it does inlining. Now, rather than passing the constant num_hf_draw_points (or sometimes a hardcoded 2) we just use num_hf_draw_points directly from constants_clubb. This massively improves the performance of a loop in fill holes when using nvhpc+omp, which was the motivation for this, but should also improve the performance on CPUs. Everything is BFB.editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/Morrison_microphys/microphysics.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/fill_holes.F90
- microphysics.F90ada570416e5b0d8d9dc6b1745eb4c1d5ae6ba6641714587855000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking compatible with latest clubb changes.
2024-05-01 13:24:15 -0500ada570416e5b0d8d9dc6b1745eb4c1d5ae6ba664Making compatible with latest clubb changes.editmicrophysics.F90
- src/Morrison_microphys/microphysics.F902090eb2e167c2bd651d84762128d49894a7d54601714622486000http://carson.math.uwm.edu/jenkins/user/pickettCole Pickettlarsongroupgithub@gmail.comRaw-copy updating src/Morrison_microphys
2024-05-01 23:01:26 -05002090eb2e167c2bd651d84762128d49894a7d5460Raw-copy updating src/Morrison_microphyseditsrc/Morrison_microphys/microphysics.F90
- src/CLUBB_core/advance_xm_wpxp_module.F906146f6bd56087e573b5c660d1481e3dc928ff5411714680265000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am committing code that effectively ignores the values of certain
zt stats at the ghost level by setting them to 0. This is done to
allow for bit-for-bitness comparisons between the master branch
and the clubb_ghost_exorcism branch.
Technically, since zt stat file output at the irrelevant ghost
level is changed for some variables, this commit is BIT_CHANGING.
Effectively, this commit doesn't change squat in terms of model results.
2024-05-02 15:04:25 -05006146f6bd56087e573b5c660d1481e3dc928ff541I am committing code that effectively ignores the values of certaineditsrc/CLUBB_core/advance_xm_wpxp_module.F90
- src/CLUBB_core/advance_xm_wpxp_module.F903b3339a9e9932452f21db516965e9b7e379a22281714685456000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am moving the advance_xm_wpxp setting of xm(1) = xm(2) from the
end of xm_clipping_and_stats to the very end of advance_xm_wpxp, right
before the return to advance_clubb_core. The reason I am doing this
is the nudging was done after setting xm(1) = xm(2) and would alter
the results. This is no longer the case, as setting xm(1) = xm(2)
is now being done after nudging.
This is being done in advance of removal of the ghost point from CLUBB.
This helps ensure a bit-for-bit match between the ghost exorcism branch and the
master branch.
This commit technically alter fields such as um, vm, um_bt, vm_bt,
wpup2, wpvp2, and shear at level 1 only. Thus, this commit is
technically BIT_CHANGING.
Effectively, once again, this commit doesn't change squat.
2024-05-02 16:30:56 -05003b3339a9e9932452f21db516965e9b7e379a2228I am moving the advance_xm_wpxp setting of xm(1) = xm(2) from theeditsrc/CLUBB_core/advance_xm_wpxp_module.F90
- doc/triple_gaussian/w_prime_theta_l_prime_2_bar.ipynbdoc/triple_gaussian/w_bar.ipynbdoc/triple_gaussian/checked_functions.pydoc/triple_gaussian/theta_l_prime_r_t_prime_bar.ipynbdoc/triple_gaussian/w_prime_2_theta_l_prime_bar.ipynbdoc/triple_gaussian/names.pydoc/triple_gaussian/limits.ipynbdoc/triple_gaussian/theta_l_prime_3_bar_beta.ipynbdoc/triple_gaussian/w_prime_r_t_prime_theta_l_prime_bar.ipynbdoc/triple_gaussian/w_prime_4_bar.ipynbdoc/triple_gaussian/w_prime_r_t_prime_theta_l_prime_bar_beta.ipynbdoc/triple_gaussian/w_prime_theta_l_prime_bar.ipynbdoc/triple_gaussian/plots2d.ipynbdoc/triple_gaussian/plots1d.ipynbdoc/triple_gaussian/w_prime_3_bar.ipynbdoc/triple_gaussian/theta_l_prime_2_bar.ipynbdoc/triple_gaussian/dataframes.pydoc/triple_gaussian/w_prime_2_bar.ipynbdoc/triple_gaussian/theta_l_prime_3_bar.ipynbdoc/triple_gaussian/w_prime_r_t_prime_theta_l_prime_bar_E.ipynbdoc/triple_gaussian/w_prime_theta_l_prime_2_bar_beta.ipynbdoc/triple_gaussian/symbols.pydoc/triple_gaussian/relationship_delta_lambda.ipynbdoc/triple_gaussian/README.mdec0c1d8f05f9e5b47110f431cf36a3dca1322d951714755359000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comJupyter Notebooks for proving formulas (#1151)
* Implement equations 1 through 5.
* Update TrivariateGaussian.ipynb
Adds parentheses to delta equation
* Fixed sigma equation.
* Type in higher order equation.
* Implement rhs of the equation (48)
* Implement ith Gaussian
* Somehow add integration with sympy
* Somehow add integration with sympy
* Added integration with sympy and adjusted variables.
* Integration now works.
* Add 4th and second order moments.
* check equation 56 with 20, 11 and 4
* check equation 56 with 20, 11 and 4
* remove unnecessary symbols
* Move documents and rename
* Rename document
* Add files and start to implement the analytic integral
* Add functions
* Add symbols and functions.
Tried analytic integration with simpler functions but the triple integral still does not work. For integrating numerically I like to use lambdify and then numpy but therefore the symbols have to be renamed because lambdify does not like backslashes.
* Numerical evaluation of the first, second, third, and fourth order moments of the triple Gaussian with limits -10 to 10.
* Added mixture fractions to the Gaussian.
* Convert results to dataframe for better readability.
* Check results for third Gaussian, also adjusted the third Gaussian.
* Tidy up code.
* Changed name of file.
Added function for evaluating the fraction w_prime_4_bar divided by w_prime_2_bar_squared which is parameterized.
* Added columns to the dataframe to check if the numerical evaluation of the 4th order moment is equal to the parameterized evaluation of the 4th order moment.
* Adjusted symbols and added the constant for lambda_w.
* Added documentation.
* Added check for w_prime_4_bar calculated just with the parameters.
* Improved functions and improved calculating the moments from a dataframe.
* Tidied up code
* Tidied up code
* Reordered document
* Added some files and restructured the document.
* Added a file to compute another function
* Added a file for computing the 4th order moment based on the parameters and checking this with the numeric integrals.
* fixed notebook
* Checked some equations analytically.
* Added document for checking eq_26
* Added document for checking eq_24
* Added document for checking eq_33
* Fixed some parameters
* finished document for computing the moments numerically.
* Verified(?) eq 75
* Changed values for ?verifying? eq 75
* Adjusted alphas and deltas but did not run it to the end yet.
* Ran the code with the adjusted alphas and deltas.
* Calculated the integral based on the marginal of G_3
* Ran the notebook again.
* Added Checking for eq 80. Not done yet.
* Added new document.
* Calculated w_bar
* Finished 1 dim integral.
* Added calculation for sigma_lambda_w and lambda_w.
* Added calculation for sigma_lambda_w and lambda_w.
* Added third Gaussian.
* Calculated 4th order moment.
* Added files and split up evaluation of the moments for w
* Verified all moments for w.
* Fixed a typo.
* Set up document for another integral.
* Working on the integral for w_prime_theta_l_prime_bar.
* Working on the integral for w_prime_theta_l_prime_bar.
* Did the check for w_prime_theta_l_prime_bar.
* Did the check for w_prime_theta_l_prime_bar.
* Did the check for w_prime_theta_l_prime_bar with rational numbers.
* Add numerical difference.
* Add numerical difference.
* Finished the check for w_prime_theta_l_prime
* Finished the check for w_prime_squared_theta_l_prime
* Finished the check for theta_l_prime_3_bar
* Finished the check for w_prime_theta_l_prime_squared_bar
* Did the checks again with arbitrary distinct values.
* Did the checks again with arbitrary distinct values.
* Add check for theta_l_prime_2_bar.
* Calculated $\beta$.
* Corrected a minor mistake.
* Backed out beta from the theta_prime_l_bar equation.
* Checked the beta equation numerically.
* Printed all NaN values.
* Reformat Check.
* Reformat Check.
* Reformat Check.
* Reformat Check.
* Reformat Check.
* Reformat Check.
* Reformat Check.
* Reformat Check.
* Reformat Check.
* Changed Heading.
* Changed the limits of integration.
* Delete doc/.ipynb_checkpoints directory
* Rearrange symbols
* Added beta to the dataframe.
* Added diagnostic values to the dataframe.
* Fixed typo.
* rearranged dataframe
* rearranged dataframe
* rearranged dataframe
* rearranged dataframe
* rearranged dataframe
* Computed the triple integral again.
* Rearranged symbols.
* Working on the trivariate Normal.
* Fixed numerical integration for triple gaussian
* plot relationship between delta and lambda_w
* plotted proposed relationship
* Rearranged files and computed everything again.
* Added README.md
* Added file to README.md
* Add function for plotting
* Finished numerical check for w_prime_q_t_prime_theta_l_prime_bar_beta.ipynb
* Finished numerical check for w_prime_q_t_prime_theta_l_prime_bar_beta.ipynb
* Finished numerical check for theta_l_prime_q_t_prime_bar.ipynb
* Worked on plotting
* Worked on README.md
* replace q_t with r_t
* replace q_t with r_t
* replace q_t with r_t
* Add explanation
* Reformat code
* Corrected a file
* Corrected a file
* Worked on checking w_prime_r_t_prime_theta_l_prime_bar_beta.ipynb
* Simplified creating of dataframe.
* - Added calculation for w_prime_r_t_prime_theta_l_prime_bar_E.ipynb and improved diagnostics output.
* Changed all sigma_lamda to sigma_3 and plotted \lambda vs \delta
* Plotted \lambda vs \delta with the "initial condition"
* Plotted \lambda vs \delta with the "initial condition"
* Update README.md
* Reran jupyter notebooks
* Refactored code
* Reran notebook
* Rearranged README.md
* Rearranged README.md
* Remove files
---------
Co-authored-by: Vincent Larson <vlarson@users.noreply.github.com>
2024-05-03 11:55:59 -0500ec0c1d8f05f9e5b47110f431cf36a3dca1322d95Jupyter Notebooks for proving formulas (#1151)adddoc/triple_gaussian/names.pyadddoc/triple_gaussian/dataframes.pyadddoc/triple_gaussian/w_prime_theta_l_prime_2_bar_beta.ipynbadddoc/triple_gaussian/w_prime_2_theta_l_prime_bar.ipynbadddoc/triple_gaussian/theta_l_prime_3_bar.ipynbadddoc/triple_gaussian/w_prime_r_t_prime_theta_l_prime_bar.ipynbadddoc/triple_gaussian/plots2d.ipynbadddoc/triple_gaussian/checked_functions.pyadddoc/triple_gaussian/limits.ipynbadddoc/triple_gaussian/symbols.pyadddoc/triple_gaussian/theta_l_prime_r_t_prime_bar.ipynbadddoc/triple_gaussian/relationship_delta_lambda.ipynbadddoc/triple_gaussian/w_prime_r_t_prime_theta_l_prime_bar_beta.ipynbadddoc/triple_gaussian/w_prime_theta_l_prime_bar.ipynbadddoc/triple_gaussian/theta_l_prime_3_bar_beta.ipynbadddoc/triple_gaussian/w_prime_3_bar.ipynbadddoc/triple_gaussian/w_prime_theta_l_prime_2_bar.ipynbadddoc/triple_gaussian/w_prime_r_t_prime_theta_l_prime_bar_E.ipynbadddoc/triple_gaussian/w_prime_2_bar.ipynbadddoc/triple_gaussian/plots1d.ipynbadddoc/triple_gaussian/README.mdadddoc/triple_gaussian/w_prime_4_bar.ipynbadddoc/triple_gaussian/w_bar.ipynbadddoc/triple_gaussian/theta_l_prime_2_bar.ipynb
- src/CLUBB_core/advance_xm_wpxp_module.F900ab983f84a6e8e298c04ac606654aa3d0798dfc81714763847000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding extra exclamation to acc statement to comment it out.
2024-05-03 14:17:27 -05000ab983f84a6e8e298c04ac606654aa3d0798dfc8Adding extra exclamation to acc statement to comment it out.editsrc/CLUBB_core/advance_xm_wpxp_module.F90
- src/CLUBB_core/mixing_length.F90f935993f179e274666a9ac959773d37732c2c64b1715624439000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.edugr%zm should be used here instead of gr%zt, since these are
momentum-level variables being calculated. Results are BIT_CHANGING.
2024-05-13 13:20:39 -0500f935993f179e274666a9ac959773d37732c2c64bgr%zm should be used here instead of gr%zt, since these areeditsrc/CLUBB_core/mixing_length.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/mixing_length.F90bf951bc321723e266b7cca9e37fced6aae8f7b911715635045000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThermodynamic-level (zt) values should be used with zt-variable
calculations. This commit changes results (but not visibly)
for the l_avg_Lscale code, but since this code is not the default
in CLUBB, the code remains bit-for-bit since the last commit.
2024-05-13 16:17:25 -0500bf951bc321723e266b7cca9e37fced6aae8f7b91Thermodynamic-level (zt) values should be used with zt-variableeditsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/mixing_length.F90
- src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/clubb_api_module.F904fa1344ba92c32d05010b15362181ec5004dd8a91715800905000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing small GPU bug in advance_xm, also fixing a bug with sclrpthvp that's only detectable when were running 1 column on GPUs.
2024-05-15 14:21:45 -05004fa1344ba92c32d05010b15362181ec5004dd8a9Fixing small GPU bug in advance_xm, also fixing a bug with sclrpthvp that's only detectable when were running 1 column on GPUs.editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/clubb_api_module.F90
- src/CLUBB_core/advance_clubb_core_module.F90a29122b397fd78f5b4fede7c8fd520e927660b4b1715889108000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduFixing a bug. Does not change default results.
2024-05-16 14:51:48 -0500a29122b397fd78f5b4fede7c8fd520e927660b4bFixing a bug. Does not change default results.editsrc/CLUBB_core/advance_clubb_core_module.F90
- utilities/sens_matrix/set_up_dashboard_inputs.py678e448bed0d6791b77f9f9f361bf99463b15fcf1716904406000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Brings in CAM regional files.
For #910.
2024-05-28 08:53:26 -0500678e448bed0d6791b77f9f9f361bf99463b15fcfQuadTune: Brings in CAM regional files.editutilities/sens_matrix/set_up_dashboard_inputs.py
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_helper_module.F90src/input_fields.F90src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F90a3a589a1cfcc34b2d84a163f958bd9d4090d9bff1717028099000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThe variable rc_coef_zm needed to be passed in and saved from
timestep-to-timestep rather than rc_coef. The results of this
change are BIT_CHANGING.
2024-05-29 19:14:59 -0500a3a589a1cfcc34b2d84a163f958bd9d4090d9bffThe variable rc_coef_zm needed to be passed in and saved fromeditsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/input_fields.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/clubb_driver.F90
- utilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/create_figs.pyutilities/sens_matrix/sens_matrix_dashboard.py4a157a41ada7c94ad9d4d626d8effb2f89b787ab1717434797000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Moves plotting code to new fnc, createFigs.
For #910.
2024-06-03 12:13:17 -05004a157a41ada7c94ad9d4d626d8effb2f89b787abQuadTune: Moves plotting code to new fnc, createFigs.editutilities/sens_matrix/set_up_dashboard_inputs.pyaddutilities/sens_matrix/create_figs.pyeditutilities/sens_matrix/sens_matrix_dashboard.py
- src/CLUBB_core/mt95.F90src/CLUBB_core/mt95.f90e9cf9a87c16e65f678c6146663dbb8ff9b22b5c71717450146000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking the f in f90 capital for consistency.
2024-06-03 16:29:06 -0500e9cf9a87c16e65f678c6146663dbb8ff9b22b5c7Making the f in f90 capital for consistency.addsrc/CLUBB_core/mt95.F90deletesrc/CLUBB_core/mt95.f90
- src/enhanced_simann.F90ed26ee90739d5041950bc843717fa39c922934ed1717451252000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSurrounding print statement with debug flag check.
2024-06-03 16:47:32 -0500ed26ee90739d5041950bc843717fa39c922934edSurrounding print statement with debug flag check.editsrc/enhanced_simann.F90
- run_scripts/check_multicol_error.pya67e22194ccac507c0dc1b684db1336cf93054fe1717452564000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking multicol diffness script rely on the largest difference detected, rather the the sum/total of differences. This is essentially to relax the cpu vs gpu diffness test because mpace_b is noisey and often causes the test to fail for innocent bit changing commits. Looking at the largest difference does have the advantage of the check being less sensitive to case differences, such as number of timesteps, vertical levels, number of columns, etc.
2024-06-03 17:09:24 -0500a67e22194ccac507c0dc1b684db1336cf93054feMaking multicol diffness script rely on the largest difference detected, rather the the sum/total of differences. This is essentially to relax the cpu vs gpu diffness test because mpace_b is noisey and often causes the test to fail for innocent bit changing commits. Looking at the largest difference does have the advantage of the check being less sensitive to case differences, such as number of timesteps, vertical levels, number of columns, etc.editrun_scripts/check_multicol_error.py
- src/CLUBB_core/advance_clubb_core_module.F9073d60f64a17ad0db20fc8ff6d24543bf8ea663831717567979000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking the only change required to make clubb run with openacc in cam.
2024-06-05 00:12:59 -060073d60f64a17ad0db20fc8ff6d24543bf8ea66383Making the only change required to make clubb run with openacc in cam.editsrc/CLUBB_core/advance_clubb_core_module.F90
- utilities/sens_matrix/create_figs.py5b57780b508e1995f430af7cb872067c745df4d51717786006000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Removes LWCF and PRECT from 2-point dpMin plot.
For #910.
2024-06-07 13:46:46 -05005b57780b508e1995f430af7cb872067c745df4d5QuadTune: Removes LWCF and PRECT from 2-point dpMin plot.editutilities/sens_matrix/create_figs.py
- src/microphys_driver.F9041a547a1afbbd334310b067c1a4789d4db8315741717857940000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI fixed a bug where the array declarations for X_mixt_comp_all_levs,
lh_rt_clipped, lh_thl_clipped, lh_rc_clipped, lh_rv_clipped, and
lh_Nc_clipped had been declared backwards.
Fortunately, results are still bit-for-bit.
2024-06-08 09:45:40 -050041a547a1afbbd334310b067c1a4789d4db831574I fixed a bug where the array declarations for X_mixt_comp_all_levs,editsrc/microphys_driver.F90
- utilities/sens_matrix/create_figs.py8ab44c1c52fb945beb576d18e4bd78754b78e17f1718039448000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Customizes inputs to threeDotFig.
For #910.
2024-06-10 12:10:48 -05008ab44c1c52fb945beb576d18e4bd78754b78e17fQuadTune: Customizes inputs to threeDotFig.editutilities/sens_matrix/create_figs.py
- utilities/sens_matrix/create_figs.py087017905fd225ad66fede72079954738ea653d01718477354000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Customizes metrics shown in parameter adjustment bar chart.
For #910.
2024-06-15 13:49:14 -0500087017905fd225ad66fede72079954738ea653d0QuadTune: Customizes metrics shown in parameter adjustment bar chart.editutilities/sens_matrix/create_figs.py
- utilities/sens_matrix/create_figs.py622b5c3a3d22d21c085fe761b1e673cafbce7df91718636028000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Clarifies some plot titles.
For #910.
2024-06-17 09:53:48 -0500622b5c3a3d22d21c085fe761b1e673cafbce7df9QuadTune: Clarifies some plot titles.editutilities/sens_matrix/create_figs.py
- utilities/sens_matrix/create_figs.pyutilities/sens_matrix/sens_matrix_dashboard.pya33330ff0d806f2d99fccdf2f37eafff834e92431718721866000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Uses flags to shut off calculations for unwanted plots.
For #910.
2024-06-18 09:44:26 -0500a33330ff0d806f2d99fccdf2f37eafff834e9243QuadTune: Uses flags to shut off calculations for unwanted plots.editutilities/sens_matrix/create_figs.pyeditutilities/sens_matrix/sens_matrix_dashboard.py
- jenkins_tests/clubb_nvhpc_gpu_acc_vs_cpu_diffness/Jenkinsfilejenkins_tests/clubb_nvhpc_gpu_vs_cpu_diffness/Jenkinsfilee6be1b287b1c9c06792327bf75f498407d327c281718741219000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking CPU vs GPU jenkins test compare openmp code also.
2024-06-18 15:06:59 -0500e6be1b287b1c9c06792327bf75f498407d327c28Making CPU vs GPU jenkins test compare openmp code also.deletejenkins_tests/clubb_nvhpc_gpu_acc_vs_cpu_diffness/Jenkinsfileaddjenkins_tests/clubb_nvhpc_gpu_vs_cpu_diffness/Jenkinsfile
- compile/convert_acc_to_omp.bashc1a22d2f11fc8344f0186049669463f3d4e404b11718741656000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduThis allows the conversion script to be called anywhere.
2024-06-18 15:14:16 -0500c1a22d2f11fc8344f0186049669463f3d4e404b1This allows the conversion script to be called anywhere.editcompile/convert_acc_to_omp.bash
- jenkins_tests/clubb_nvhpc_gpu_vs_cpu_diffness/Jenkinsfile6a881c89ed27787eb3c5eecd4210ecadffecd4851718741744000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bug in jenkinsfiles.
2024-06-18 15:15:44 -05006a881c89ed27787eb3c5eecd4210ecadffecd485Fixing bug in jenkinsfiles.editjenkins_tests/clubb_nvhpc_gpu_vs_cpu_diffness/Jenkinsfile
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_helper_module.F90src/CLUBB_core/mixing_length.F905df5fcb3d6c51d6af2e8017d270336eefa75ad3e1718832972000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRi zm calc (Part 1) - Combine and move call to calc_brunt_vaisala_freq_sqd (#1154)
#1145 Combined call to `calc_brunt_vaisala_freq_sqd` in `advance_clubb_core` for both Lscale and taus code - BITCHANGING
Call for taus code was moved out and in front of `diagnose_Lscale_from_tau` call and `zm2zt2zm` smoothing of `thlm` was removed.
BITCHANGING for taus code due to removed smoothing.
2024-06-19 16:36:12 -05005df5fcb3d6c51d6af2e8017d270336eefa75ad3eRi zm calc (Part 1) - Combine and move call to calc_brunt_vaisala_freq_sqd (#1154)editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/advance_clubb_core_module.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/mixing_length.F907ec7a22933275dc519ecf12d9a607458c9bfe49e1718834177000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRi_zm calc (Part 1.5) - Adjusted signature of diagnose_Lscale_from_tau #1145 (#1155)
Ri_zm calc (Part 1.5) - Adjusted signature of diagnose_Lscale_from_tau #1145
2024-06-19 16:56:17 -05007ec7a22933275dc519ecf12d9a607458c9bfe49eRi_zm calc (Part 1.5) - Adjusted signature of diagnose_Lscale_from_tau #1145 (#1155)editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/mixing_length.F90
- src/CLUBB_core/advance_clubb_core_module.F90ea1f30ac69032feb7dc61b13dcbdeec32f66e0f51718884181000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdds blank line so that I can note BIT_CHANGING:5df5fcb3d6c51d6af2e8017d270336eefa75ad3e
2024-06-20 06:49:41 -0500ea1f30ac69032feb7dc61b13dcbdeec32f66e0f5Adds blank line so that I can note BIT_CHANGING:5df5fcb3d6c51d6af2e8017d270336eefa75ad3eeditsrc/CLUBB_core/advance_clubb_core_module.F90
- utilities/sens_matrix/create_figs.py02b137307477a140ce3b25a28dca20ef9b52570d1718901366000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Adds more flags to toggle plots.
For #910.
2024-06-20 11:36:06 -050002b137307477a140ce3b25a28dca20ef9b52570dQuadTune: Adds more flags to toggle plots.editutilities/sens_matrix/create_figs.py
- src/advance_microphys_module.F9056ddf19ef3d99d2f774df7bb03268d1e708a9c0a1719343922000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThis commit fixes 2 issues in regards to hydrometeor sedimentation:
1) The code was taking into consideration the value of the hydrometeor
at the ghost point within the center-differenced option.
2) If a hydrometeor was present (value > 0) at the highest thermodynamic grid level, the code was potentially not conservative.
Both these issues are fixed with this commit. The results are
BIT_CHANGING.
2024-06-25 14:32:02 -050056ddf19ef3d99d2f774df7bb03268d1e708a9c0aThis commit fixes 2 issues in regards to hydrometeor sedimentation:editsrc/advance_microphys_module.F90
- src/advance_microphys_module.F907edd25befa70a598ca8960114ea76a171e27cc191719423650000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdated the turbulent sedimentation code to account for ghost point
removal and also for improved boundary-level handling.
This commit is BIT_CHANGING for all cases that use KK upscaled
turbulent sedimentation.
2024-06-26 12:40:50 -05007edd25befa70a598ca8960114ea76a171e27cc19Updated the turbulent sedimentation code to account for ghost pointeditsrc/advance_microphys_module.F90
- utilities/sens_matrix/set_up_dashboard_inputs.py5341e1136aef41c3a2687944a2a42e68ac9dc66f1719881840000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Feeds in 20degree_CAM_TAUS_202404 runs.
For #910.
2024-07-01 19:57:20 -05005341e1136aef41c3a2687944a2a42e68ac9dc66fQuadTune: Feeds in 20degree_CAM_TAUS_202404 runs.deleteutilities/sens_matrix/set_up_dashboard_inputs.py
- utilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/create_figs.pyc26a54de4f25c01f48a95e30d806400e7772c2bc1719882061000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Feeds in 20degree_CAM_TAUS_2020404, take 2.
For #910.
2024-07-01 20:01:01 -0500c26a54de4f25c01f48a95e30d806400e7772c2bcQuadTune: Feeds in 20degree_CAM_TAUS_2020404, take 2.editutilities/sens_matrix/create_figs.pyaddutilities/sens_matrix/set_up_dashboard_inputs.py
- src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_helper_module.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/mixing_length.F90e3a10e0ff494ca2a57b5895f5ab8cb40b45e70361719948922000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRi_zm calc (Part 2) - Move the brunt_vaisala smoothing into calc_brunt_vaisala_freq_sqd (#1156)
CLUBB ticket #1145
Includes previous steps:
* First step: Move call to calc_bv
* Ri_zm calc (Part 1.5) - Adjusted signature of diagnose_Lscale_from_tau #1145
Newest changes: Ri_zm calc (Part 2) - Move brunt_vaisala smoothing into calc_brunt_vaisala_freq_sqd
`brunt_vaisala_frq_sqd_smth` is now calculated in subroutine `calc_brunt_vaisala_freq_sqd` and it is now written to disk in `advance_clubb_core` with all the other `brunt_vaisala` variables.
Unfortunately, I had to make a couple more changes since moving this calculation into `calc_brunt_vaisala_freq_sqd` meant that any subroutine involved in calling `calc_stability_correction` would need to get `l_modify_limiters_for_cnvg_test` fed in, because `calc_brunt_vaisala_freq_sqd` is also called in `calc_stability_correction`.
This commit is BIT_CHANGING since `brunt_vaisala_frq_sqd_smth` used to be all zeros before this change in Lscale mode and now it is actually calculated. BFB in taus code.
2024-07-02 14:35:22 -0500e3a10e0ff494ca2a57b5895f5ab8cb40b45e7036Ri_zm calc (Part 2) - Move the brunt_vaisala smoothing into calc_brunt_vaisala_freq_sqd (#1156)editsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/mixing_length.F90
- compile/config/linux_x86_64_nvhpc.bashjenkins_tests/clubb_nvhpc_gpu_vs_cpu_diffness/Jenkinsfilecompile/config/linux_x86_64_nvhpc_gpu_openmp.bashcompile/config/linux_x86_64_nvhpc_gpu_openacc.bash40d301330e9263c649c014bcae7e371829f42ac81719958353000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduTesting the new module system with our GPU diffness test. See https://github.com/larson-group/sys_admin/issues/829
2024-07-02 17:12:33 -050040d301330e9263c649c014bcae7e371829f42ac8Testing the new module system with our GPU diffness test. See https://github.com/larson-group/sys_admin/issues/829editcompile/config/linux_x86_64_nvhpc.basheditjenkins_tests/clubb_nvhpc_gpu_vs_cpu_diffness/Jenkinsfileeditcompile/config/linux_x86_64_nvhpc_gpu_openacc.basheditcompile/config/linux_x86_64_nvhpc_gpu_openmp.bash
- jenkins_tests/clubb_nvhpc_gpu_vs_cpu_diffness/Jenkinsfilea166adc53620547cc0858fc77d0ab03095fcce701719960091000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduThe module system is setup via paths in /etc/profile.d/larson-group.sh, so we need to source it. https://github.com/larson-group/sys_admin/issues/829
2024-07-02 17:41:31 -0500a166adc53620547cc0858fc77d0ab03095fcce70The module system is setup via paths in /etc/profile.d/larson-group.sh, so we need to source it. https://github.com/larson-group/sys_admin/issues/829editjenkins_tests/clubb_nvhpc_gpu_vs_cpu_diffness/Jenkinsfile
- jenkins_tests/clubb_nvhpc_gpu_vs_cpu_diffness/Jenkinsfilebff26070fff07143dd27206fd332f3ccbfc2556b1719960388000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bug in jenkinsfiles.
2024-07-02 17:46:28 -0500bff26070fff07143dd27206fd332f3ccbfc2556bFixing bug in jenkinsfiles.editjenkins_tests/clubb_nvhpc_gpu_vs_cpu_diffness/Jenkinsfile
- jenkins_tests/clubb_restart_silhs_gfortran_test/Jenkinsfilecompile/config/linux_x86_64_ifort_compy.bashjenkins_tests/clubb_G_unit_gfortran_tests/Jenkinsfilejenkins_tests/clubb_bin_diff_regression_e3sm_flags_gfortran/Jenkinsfilecompile/config/linux_x86_64_ifort_r4_debug.bashjenkins_tests/clubb_fire_tuning_gfortran_test/Jenkinsfilecompile/config/linux_x86_64_ifort_optimizing.bashjenkins_tests/clubb_ifort_debug_run/Jenkinsfilejenkins_tests/clubb_timestep_convergence_gfortran_test/Jenkinsfilecompile/config/linux_x86_64_pgroup_debug_NCAR.bashcompile/config/linux_x86_64_ifort_r4.bashjenkins_tests/clubb_gfortran_build/Jenkinsfilejenkins_tests/clubb_openmp_gfortran_test/Jenkinsfilecompile/config/linux_x86_64_pgroup.bashjenkins_tests/clubb_backwards_compatibility_gfortran_test/Jenkinsfilejenkins_tests/clubb_silhs_convergence_gfortran/Jenkinsfilejenkins_tests/clubb_check_budget_balance_gfortran/Jenkinsfilejenkins_tests/clubb_gfortran_debug_run/Jenkinsfilejenkins_tests/clubb_timestep_gfortran_tests/Jenkinsfilejenkins_tests/clubb_bin_diff_regression_gfortran_test/Jenkinsfilecompile/config/linux_x86_64_ifort_debug.bashcompile/config/linux_x86_64_ifort.bashjenkins_tests/clubb_bin_diff_regression_backwards_compatibility_gfortran_test/Jenkinsfilecompile/config/linux_x86_64_nvhpc_casper.bashjenkins_tests/clubb_ifort_build/Jenkinsfilecompile/config/linux_x86_64_ifort_anvil.bashjenkins_tests/clubb_nvhpc_gpu_vs_cpu_diffness/Jenkinsfilecompile/config/linux_x86_64_ifort_gpu_openmp.bashjenkins_tests/clubb_error_handling_gfortran_test/Jenkinsfilecompile/config/linux_x86_64_pgroup_debug.bashjenkins_tests/clubb_bin_diff_regression_gfortran_test_old/Jenkinsfilejenkins_tests/clubb_pgi_build/Jenkinsfilecompile/config/linux_x86_64_gfortran.bashjenkins_tests/clubb_restart_gfortran_test/Jenkinsfilejenkins_tests/clubb_release_intel_build/Jenkinsfilecompile/config/linux_x86_64_gfortran_r4.bashcompile/config/linux_x86_64_gfortran_debug.bash05c2978bb4fb2b7ec8e58ce73ff99ed7f94c3e321720633999000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comSpack updates (#1158)
* Initial changes to get code working with the new spack+module system. See https://github.com/larson-group/sys_admin/issues/829
* Changes for restart_gfortran_test
* Possible fix for tuning test
* Part 2 to tuning test fix. It's unclear why the recent change caused top level directory for these stages to be in clubb, rather than the parent directory. Perhaps it has to do with the triple quote
* Adding the mkl flag back to intel config scripts. It's still usable when adding -m or --mkl_lapack to our compile script call, and now we have intel-oneapi-mkl installed because wrf needs it.
2024-07-10 12:53:19 -050005c2978bb4fb2b7ec8e58ce73ff99ed7f94c3e32Spack updates (#1158)editjenkins_tests/clubb_gfortran_debug_run/Jenkinsfileeditjenkins_tests/clubb_ifort_debug_run/Jenkinsfileeditjenkins_tests/clubb_gfortran_build/Jenkinsfileeditjenkins_tests/clubb_G_unit_gfortran_tests/Jenkinsfileeditcompile/config/linux_x86_64_gfortran_debug.bashdeletecompile/config/linux_x86_64_nvhpc_casper.basheditjenkins_tests/clubb_ifort_build/Jenkinsfileeditjenkins_tests/clubb_restart_silhs_gfortran_test/Jenkinsfileeditjenkins_tests/clubb_nvhpc_gpu_vs_cpu_diffness/Jenkinsfileeditcompile/config/linux_x86_64_ifort_gpu_openmp.basheditjenkins_tests/clubb_backwards_compatibility_gfortran_test/Jenkinsfileeditjenkins_tests/clubb_bin_diff_regression_backwards_compatibility_gfortran_test/Jenkinsfiledeletecompile/config/linux_x86_64_pgroup_debug.bashdeletecompile/config/linux_x86_64_pgroup_debug_NCAR.basheditjenkins_tests/clubb_restart_gfortran_test/Jenkinsfileeditjenkins_tests/clubb_silhs_convergence_gfortran/Jenkinsfiledeletejenkins_tests/clubb_bin_diff_regression_gfortran_test_old/Jenkinsfileeditcompile/config/linux_x86_64_gfortran_r4.basheditcompile/config/linux_x86_64_ifort_r4_debug.basheditjenkins_tests/clubb_error_handling_gfortran_test/Jenkinsfileeditcompile/config/linux_x86_64_ifort_optimizing.basheditcompile/config/linux_x86_64_ifort.basheditcompile/config/linux_x86_64_ifort_compy.basheditjenkins_tests/clubb_release_intel_build/Jenkinsfiledeletecompile/config/linux_x86_64_pgroup.basheditjenkins_tests/clubb_bin_diff_regression_e3sm_flags_gfortran/Jenkinsfileeditcompile/config/linux_x86_64_ifort_debug.basheditjenkins_tests/clubb_fire_tuning_gfortran_test/Jenkinsfileeditcompile/config/linux_x86_64_gfortran.basheditjenkins_tests/clubb_timestep_gfortran_tests/Jenkinsfileeditcompile/config/linux_x86_64_ifort_anvil.basheditcompile/config/linux_x86_64_ifort_r4.bashdeletejenkins_tests/clubb_pgi_build/Jenkinsfileeditjenkins_tests/clubb_check_budget_balance_gfortran/Jenkinsfileeditjenkins_tests/clubb_openmp_gfortran_test/Jenkinsfileeditjenkins_tests/clubb_bin_diff_regression_gfortran_test/Jenkinsfileeditjenkins_tests/clubb_timestep_convergence_gfortran_test/Jenkinsfile
- compile/config/linux_x86_64_ifort_r4.bashcompile/config/linux_x86_64_ifort_compy.bashcompile/config/linux_x86_64_ifort_debug.bashcompile/config/linux_x86_64_ifort.bashcompile/config/linux_x86_64_ifort_r4_debug.bashcompile/config/linux_x86_64_ifort_anvil.bashcompile/config/linux_x86_64_ifort_gpu_openmp.bashcompile/compile.bashcompile/config/linux_x86_64_ifort_optimizing.bash77e9eb3414a86bd055ea21be33463ff9fc41fdb31720636214000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking our mkl compile config work directly in the compile script rather than relying on a correspondence with the config files. Also settig main config scripts to use new ifx compiler.
2024-07-10 13:30:14 -050077e9eb3414a86bd055ea21be33463ff9fc41fdb3Making our mkl compile config work directly in the compile script rather than relying on a correspondence with the config files. Also settig main config scripts to use new ifx compiler.editcompile/config/linux_x86_64_ifort_debug.basheditcompile/config/linux_x86_64_ifort_optimizing.basheditcompile/config/linux_x86_64_ifort_compy.basheditcompile/config/linux_x86_64_ifort.basheditcompile/compile.basheditcompile/config/linux_x86_64_ifort_anvil.basheditcompile/config/linux_x86_64_ifort_gpu_openmp.basheditcompile/config/linux_x86_64_ifort_r4_debug.basheditcompile/config/linux_x86_64_ifort_r4.bash
- src/clubb_driver.F9098f09c130ce3487dc010ff1eab26439cc72798c11720636828000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving allocatable status of some variables. These need not be declared allocatable and ifx seems to have a problem with it. The allocatable status is an artifact from when we had these as arrays of initially unknown size.
2024-07-10 13:40:28 -050098f09c130ce3487dc010ff1eab26439cc72798c1Removing allocatable status of some variables. These need not be declared allocatable and ifx seems to have a problem with it. The allocatable status is an artifact from when we had these as arrays of initially unknown size.editsrc/clubb_driver.F90
- jenkins_tests/clubb_nvhpc_gpu_vs_cpu_diffness/Jenkinsfilede4b158da241ce4321c6fb9c3e2d3bdd0fff15ce1720637088000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing the run agent to be carson, since it has the only GPU capable of running with openmp gpu offloading.
2024-07-10 13:44:48 -0500de4b158da241ce4321c6fb9c3e2d3bdd0fff15ceFixing the run agent to be carson, since it has the only GPU capable of running with openmp gpu offloading.editjenkins_tests/clubb_nvhpc_gpu_vs_cpu_diffness/Jenkinsfile
- jenkins_tests/clubb_bin_diff_regression_gfortran_test/Jenkinsfilejenkins_tests/clubb_bin_diff_regression_backwards_compatibility_gfortran_test/.Jenkinsfile.swpjenkins_tests/clubb_bin_diff_regression_e3sm_flags_gfortran/Jenkinsfilejenkins_tests/clubb_bin_diff_regression_backwards_compatibility_gfortran_test/Jenkinsfile165b2ca54fe98baff8f567eaa81a0ee2cc564a321720724163000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking jenkins bit diff tests only run on carson. This is because these tests are defined by a file we store on carson that needs to be updated after each test.
2024-07-11 13:56:03 -0500165b2ca54fe98baff8f567eaa81a0ee2cc564a32Making jenkins bit diff tests only run on carson. This is because these tests are defined by a file we store on carson that needs to be updated after each test.editjenkins_tests/clubb_bin_diff_regression_e3sm_flags_gfortran/Jenkinsfileeditjenkins_tests/clubb_bin_diff_regression_gfortran_test/Jenkinsfileaddjenkins_tests/clubb_bin_diff_regression_backwards_compatibility_gfortran_test/.Jenkinsfile.swpeditjenkins_tests/clubb_bin_diff_regression_backwards_compatibility_gfortran_test/Jenkinsfile
- compile/config/linux_x86_64_nvhpc.bashjenkins_tests/clubb_nvhpc_single_prec_build/Jenkinsfilejenkins_tests/clubb_nvhpc_debug_build/Jenkinsfilecompile/config/linux_x86_64_nvhpc_gpu_openmp.bashcompile/config/linux_x86_64_nvhpc_debug.bashcompile/config/linux_x86_64_nvhpc_gpu_openacc.bash840a65123a35bc789346706861b71876d170a38b1720738185000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduReplacing pgi references with nvhpc, and adding nvhpc_debug config script along with new jenkins tests.
2024-07-11 17:49:45 -0500840a65123a35bc789346706861b71876d170a38bReplacing pgi references with nvhpc, and adding nvhpc_debug config script along with new jenkins tests.addcompile/config/linux_x86_64_nvhpc_debug.bashaddjenkins_tests/clubb_nvhpc_single_prec_build/Jenkinsfileeditcompile/config/linux_x86_64_nvhpc_gpu_openmp.basheditcompile/config/linux_x86_64_nvhpc_gpu_openacc.bashaddjenkins_tests/clubb_nvhpc_debug_build/Jenkinsfileeditcompile/config/linux_x86_64_nvhpc.bash
- compile/config/linux_x86_64_nvhpc_debug.bashe579a898763fa35f934376ce079cb4e0b3c0f3851720739578000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving flag meant for gpu debugging.
2024-07-11 18:12:58 -0500e579a898763fa35f934376ce079cb4e0b3c0f385Removing flag meant for gpu debugging.editcompile/config/linux_x86_64_nvhpc_debug.bash
- src/CLUBB_core/parameters_tunable.F90ef65d2727180b4c76d113cc0da1f6b5d4d3f16101720755417000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThis code in adj_low_res_nu was using the ghost point when
grid_type = 2. This has now been changed to not include the ghost
level. This code is BIT_CHANGING.
2024-07-11 22:36:57 -0500ef65d2727180b4c76d113cc0da1f6b5d4d3f1610This code in adj_low_res_nu was using the ghost point wheneditsrc/CLUBB_core/parameters_tunable.F90
- src/advance_microphys_module.F90524390e3bf242e70f087ddb511273cb16f62760a1720808667000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThis technically BIT_CHANGING commit is being made to keep results in
_zm.nc output files the same between the master branch and the
clubb_ghost_exorcism branch.
2024-07-12 13:24:27 -0500524390e3bf242e70f087ddb511273cb16f62760aThis technically BIT_CHANGING commit is being made to keep results ineditsrc/advance_microphys_module.F90
- src/SILHS/latin_hypercube_driver_module.F907dab4b45efa0845b25a3ab7e6f68148f5dd139f31720943555000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am updating the SILHS code that calculates k_lh_start to work
consistently with ghostless CLUBB. This commit is BIT_CHANGING.
2024-07-14 02:52:35 -05007dab4b45efa0845b25a3ab7e6f68148f5dd139f3I am updating the SILHS code that calculates k_lh_start to workeditsrc/SILHS/latin_hypercube_driver_module.F90
- utilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/create_figs.py360ded1ba8967a18620426bf0a2bef72c161525e1721073282000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Adds arrow plot and plot of bias vs. a diagnostic field such as U10.
For #910.
2024-07-15 14:54:42 -0500360ded1ba8967a18620426bf0a2bef72c161525eQuadTune: Adds arrow plot and plot of bias vs. a diagnostic field such as U10.editutilities/sens_matrix/create_figs.pyeditutilities/sens_matrix/set_up_dashboard_inputs.py
- src/coamps_microphys_driver_module.F90253c4a69a11b450a9d100726820d9f35976f7d5a1721077282000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am making this commit because, as part of deghosting, I discovered 2
bugs in the way that COAMPS microphysics was set up.
1) The code that was handling the grid flipping for hydrometeor sedimentation
velocities output from coamps (flipping from the coamps grid to the
clubb grid) was mis-aligned;
2) The code within coamps then interpolated those velocities to the zm grid
However, CLUBB expected that output on the zt grid.
These issues were corrected in this commit that is BIT_CHANGING for
mpace_b -- the only case that uses COAMPS microphysics by default.
2024-07-15 16:01:22 -0500253c4a69a11b450a9d100726820d9f35976f7d5aI am making this commit because, as part of deghosting, I discovered 2editsrc/coamps_microphys_driver_module.F90
- src/coamps_microphys_driver_module.F90933df4321f09c1fec44e953ec022ad2b3c7e4fb21721104295000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am updating the snowslope output stat so it matches bit-for-bit
with the output of the clubb_ghost_exorcism branch. This commit
is BIT_CHANGING.
2024-07-15 23:31:35 -0500933df4321f09c1fec44e953ec022ad2b3c7e4fb2I am updating the snowslope output stat so it matches bit-for-biteditsrc/coamps_microphys_driver_module.F90
- src/advance_microphys_module.F90babbea90fd1f140ca1634aae59fd8df3366404571721151675000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduSetting the value of K_hm to 0 at the non-interactive upper and lower
boundaries. The values of that variable at those levels don't get used
in the code.
This change is meant to keep stats the same between the master branch
and the clubb_ghost_exorcism branch. This changes does not change
the simulations, but yet it is BIT_CHANGING because it changes stat
files output at those levels.
2024-07-16 12:41:15 -0500babbea90fd1f140ca1634aae59fd8df336640457Setting the value of K_hm to 0 at the non-interactive upper and lowereditsrc/advance_microphys_module.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/stats_clubb_utilities.F90c9083983343f851915dccdd10d7d6ff7baad24b31721188165000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am committing changes to stats output for cloud_cover, rcm_in_layer,
and z_cloud base owing to the gymnastics it takes to avoid the
ghost point in calculations. These changes are BIT_CHANGING, but
they don't change the answer.
2024-07-16 22:49:25 -0500c9083983343f851915dccdd10d7d6ff7baad24b3I am committing changes to stats output for cloud_cover, rcm_in_layer,editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/stats_clubb_utilities.F90
- src/SILHS/latin_hypercube_driver_module.F901cb88726a7f824b8844fe32eff22b09991b8de6c1721242346000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThere were furhter issues found with the k_lh_start code.
The code would find that sometimes, the maximum location of rcm
in cloud would occur at the ghost level, k = 1, and set that level
as k_lh_start for SILHS. This is undesirable for two reasons:
1) k_lh_start should be set around a legimate, "within domain" grid
level; and
2) Setting k_lh_start to 1 is unachievable for the ghostless branch
of the model, making a match between the master and clubb_ghost_exorcism
branhes unattainable.
The issue is corrected here by allowing the maxloc function to only
search over "in-domain levels" for maximum cloud. The results are
BIT_CHANGING.
2024-07-17 13:52:26 -05001cb88726a7f824b8844fe32eff22b09991b8de6cThere were furhter issues found with the k_lh_start code.editsrc/SILHS/latin_hypercube_driver_module.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/advance_helper_module.F90acdd31a8d397f5a8874cba8023e9376fe1d9e6511721258040000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRi_zm calc (Part 3) - Moving calculations for Ri_zm out of diagnose_Lscale_from_taus (#1157)
CLUBB tocket #1145
BIT_CHANGING for lscale since Ri_zm was not calculated before.
1. mixing_length.F90:
- Removed unused input variables from diagnose_Lscale_from_taus: um, vm, exner, p_in_Pa, rtm, thlm, thvm, rcm, saturation_formula, l_brunt_vaisala_freq_moist, l_use_thvm_in_bv_freq, l_modify_limiters_for_cnvg_test; added ddzt_umvm_sqd as input; changed Ri_zm from out to in
- Removed unused brunt_vaisala_freq_sqd variables from diagnose_Lscale_from_tau
- Removed calculations for Ri_zm and ddzt_umvm_sqd
- Fixed some line length issues
2. advance_helper_module.F90
- Removed unused input variables and imports
- Fixed some line length issues
3. advance_clubb_core_module.F90
- Added calculations for ddzt_umvm_sqd and Ri_zm
- Adjusted subroutine calls
- Fixed some line length issues
2024-07-17 18:14:00 -0500acdd31a8d397f5a8874cba8023e9376fe1d9e651Ri_zm calc (Part 3) - Moving calculations for Ri_zm out of diagnose_Lscale_from_taus (#1157)editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_helper_module.F90
- src/SILHS/latin_hypercube_driver_module.F90370b85fd1991810e0a1dec311f66ad10fa92275f1721277738000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduIn my previous commit, I changed the domain of the maxloc commands
in the computation of k_lh_start to check over the arrays from
levels 2:nz. However, when that happens, the output will be offset
by 1. Consider a situation where the rcm max is at level 2. By being
passed 2 through nz only, maxloc will return a value of 1. I needed
to add +1 to the output to rectify this issue. The results
are BIT_CHANGING.
2024-07-17 23:42:18 -0500370b85fd1991810e0a1dec311f66ad10fa92275fIn my previous commit, I changed the domain of the maxloc commandseditsrc/SILHS/latin_hypercube_driver_module.F90
- src/CLUBB_core/stats_clubb_utilities.F90src/CLUBB_core/precipitation_fraction.F90876a5a7674acbc3609a50dfeb45e791acee015831721289115000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThis commit brings the stats output from the all cases run with
the master branch (using the default configuration) in
bit-for-bit agreement with the stats output from all cases run
with the clubb_ghost_exorcism branch. Of course, this agreement
ignores the ghost level output in the zt files run with the
master branch. This commit is technically BIT_CHANGING because
it alters a few stats for a couple cases, but does not change results.
2024-07-18 02:51:55 -0500876a5a7674acbc3609a50dfeb45e791acee01583This commit brings the stats output from the all cases run witheditsrc/CLUBB_core/stats_clubb_utilities.F90editsrc/CLUBB_core/precipitation_fraction.F90
- READMEb539e93847e36a7817553cc8b13b1b7c61b814a01721336360000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdates README so that I can note that BIT_CHANGING:9ca167aa8b04cbebe4a1177a72f13731454e1e11
2024-07-18 15:59:20 -0500b539e93847e36a7817553cc8b13b1b7c61b814a0Updates README so that I can note that BIT_CHANGING:9ca167aa8b04cbebe4a1177a72f13731454e1e11editREADME
- src/CLUBB_core/pdf_closure_module.F90f29869940fc51861eeb04350cdc567727b1e95f21721347695000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduCommitting a change that will initialize this set of variables
under all circumstances. This change does not affect output
except when the New Hybrid PDF is used. In the case of the
New Hybrid PDF, the variables F_rt, F_thl, F_rt_min, F_rt_max,
F_thl_min, and F_thl_max were never initialized and never set
(they are not part of the New Hybrid PDF -- only in the original
New PDF), resulting NaN values being output to stat files.
2024-07-18 19:08:15 -0500f29869940fc51861eeb04350cdc567727b1e95f2Committing a change that will initialize this set of variableseditsrc/CLUBB_core/pdf_closure_module.F90
- src/CLUBB_core/advance_xp2_xpyp_module.F908f1115676aa257869d00331d0355159754208e1e1721419124000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduMaking a change to the l_C2_cloud_frac option with advance_xp2_xpyp.
Cloud fraction needed to be interpolated to momentum levels for
proper use in the code.
Since this code change does not change CLUBB's default configuration,
results are bit-for-bit for the default configuration.
2024-07-19 14:58:44 -05008f1115676aa257869d00331d0355159754208e1eMaking a change to the l_C2_cloud_frac option with advance_xp2_xpyp.editsrc/CLUBB_core/advance_xp2_xpyp_module.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/clubb_api_module.F90a67d637da217289ec8a0ddd2ea464d782b9ca79c1721424813000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bug. qclvar copying is handled by the api, but we were deleting it with an unstructured data statement. I added this due as a fix before thinking qclvar was a local variable, which happened because I mixed up the CLUBB_CAM and CLUBBND_CAM flags. https://github.com/larson-group/cam/issues/175
2024-07-19 15:33:33 -0600a67d637da217289ec8a0ddd2ea464d782b9ca79cFixing bug. qclvar copying is handled by the api, but we were deleting it with an unstructured data statement. I added this due as a fix before thinking qclvar was a local variable, which happened because I mixed up the CLUBB_CAM and CLUBBND_CAM flags. https://github.com/larson-group/cam/issues/175editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/clubb_api_module.F90
- src/clubb_driver.F9088e63b7dc56295efbebde1b090107c748daef5411721689147000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduWhen l_vert_avg_closure is enabled, the flags l_call_pdf_closure_twice,
l_trapezoidal_rule_zt, and l_trapezoidal_rule_zm should all be enabled.
That is not changed by this commit.
However, when l_vert_avg_closure is disabled, then the setting of those
other 3 flags should be left to whatever setting they have in the
configurable flags file. They should **not** be automatically
overwritten to false.
Since all 4 of those flags are all turned off by default anyway in
CLUBB, this commit will have no effect on the default results.
2024-07-22 17:59:07 -050088e63b7dc56295efbebde1b090107c748daef541When l_vert_avg_closure is enabled, the flags l_call_pdf_closure_twice,editsrc/clubb_driver.F90
- src/CLUBB_core/mono_flux_limiter.F907e50946517204cc06f78f8d12c3bca5b283d83f01722452248000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing GPU bug. There is a vertical dependency with wpxp. This is what was breaking the ECT test, see larson-group/cam#175
2024-07-31 13:57:28 -05007e50946517204cc06f78f8d12c3bca5b283d83f0Fixing GPU bug. There is a vertical dependency with wpxp. This is what was breaking the ECT test, see larson-group/cam#175editsrc/CLUBB_core/mono_flux_limiter.F90
- src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/advance_clubb_core_module.F90e7c07d8527cafa4ab3ee16b1b90ce1abe24941f31722455629000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bugs that are only caught when not outputting w_[up/down]_in_cloud stats or if l_host_applies_sfc_fluxes=.true. The l_host_applies_sfc_fluxes=.true. isn't testable (at least not in clubb_standalone), and I just caught that visually. The cloudy_updraft_frac and cloudy_downdraft_frac fields not being set were only noticable in cam, because we always run with iw_up_in_cloud>0 and iw_down_in_cloud>0 to output stats.
2024-07-31 14:53:49 -0500e7c07d8527cafa4ab3ee16b1b90ce1abe24941f3Fixing bugs that are only caught when not outputting w_[up/down]_in_cloud stats or if l_host_applies_sfc_fluxes=.true. The l_host_applies_sfc_fluxes=.true. isn't testable (at least not in clubb_standalone), and I just caught that visually. The cloudy_updraft_frac and cloudy_downdraft_frac fields not being set were only noticable in cam, because we always run with iw_up_in_cloud>0 and iw_down_in_cloud>0 to output stats.editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90
- src/CLUBB_core/clubb_api_module.F903f865924bdcf798fa45acaa67b57c44f40c32d891722465051000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMoving pdf_params copying to copyin. This is the data structure that contains pointers, and these pointers will be different on the host and device, so it is bad in theory to copy the structure back to the CPU as it might overwrite cpu memory pointers with gpu memory pointers. In practice though I've seen no problems caused by this, I'm just making this commit preemptively, and it has already been tested with the ECT test.
2024-07-31 17:30:51 -05003f865924bdcf798fa45acaa67b57c44f40c32d89Moving pdf_params copying to copyin. This is the data structure that contains pointers, and these pointers will be different on the host and device, so it is bad in theory to copy the structure back to the CPU as it might overwrite cpu memory pointers with gpu memory pointers. In practice though I've seen no problems caused by this, I'm just making this commit preemptively, and it has already been tested with the ECT test.editsrc/CLUBB_core/clubb_api_module.F90
- src/input_fields.F9047c5a7c9fede199a6ce4400f50474c7a9e49aaad1722792456000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdating input fields so that the zt2zm function is used for
interpolation from thermodynamic to momentum grids in the case
of reading in UP2 and Vp2 from SAM LES output.
2024-08-04 12:27:36 -050047c5a7c9fede199a6ce4400f50474c7a9e49aaadUpdating input fields so that the zt2zm function is used foreditsrc/input_fields.F90
- src/CLUBB_core/advance_xm_wpxp_module.F90input/tunable_parameters/tunable_parameters.insrc/CLUBB_core/advance_wp2_wp3_module.F90a5e586ca398dcd4733c05082addacaa66e24b2f61723145344000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdded zt2zm2zt-smoothing to remove noise in MPACE_B winds (#1161)
BIT_CHANGING
In order to remove noise in the wind fields in MPACE_B, we added some smoothing.
* Added `zt2zm2zt`-smoothing to `diagnose_upxp` calls in `advance_xm_wpxp`
* Added `zm2zt2zm`-smoothing to `wp2` and `em` vars fed into `wp3_term_pr_turb_rhs` in `advance_wp2_wp3`
* Changed C_wp2_splat to 0.00 in default tunable_parameters.in
2024-08-08 14:29:04 -0500a5e586ca398dcd4733c05082addacaa66e24b2f6Added zt2zm2zt-smoothing to remove noise in MPACE_B winds (#1161)editinput/tunable_parameters/tunable_parameters.ineditsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90
- src/stat_file_utils.F90src/jacobian.F90src/CLUBB_core/parameters_model.F90src/clubb_model_settings.F901f96b03b404757544a6954e41ebea65a4771d3331723145363000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMoving PosInf to clubb_model_settings.F90
2024-08-08 14:29:23 -05001f96b03b404757544a6954e41ebea65a4771d333Moving PosInf to clubb_model_settings.F90editsrc/CLUBB_core/parameters_model.F90editsrc/stat_file_utils.F90editsrc/jacobian.F90editsrc/clubb_model_settings.F90
- compile/convert_acc_to_omp.bash46fe460263003ad92fd5f942a2c99d006bcbf0fa1723155345000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduChanging openacc to openmp migration repo to a fork with a change to switch the order of copyins and copies. This is to allow us to only copyin the pdf_params structure, but copy the internal arrays. When the copying of the internal arrays happens first, followed by the copyin of the structure, we overwrite the pointers to the internal arrays on the GPU version of the structure. Hence why we want the copyins to precede the copy statements.
2024-08-08 17:15:45 -050046fe460263003ad92fd5f942a2c99d006bcbf0faChanging openacc to openmp migration repo to a fork with a change to switch the order of copyins and copies. This is to allow us to only copyin the pdf_params structure, but copy the internal arrays. When the copying of the internal arrays happens first, followed by the copyin of the structure, we overwrite the pointers to the internal arrays on the GPU version of the structure. Hence why we want the copyins to precede the copy statements.editcompile/convert_acc_to_omp.bash
- microphysics.F9057e0224ef7232895588a7a5cdb565fda261095941723491201000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdated for ghostless version of CLUBB.
2024-08-12 14:33:21 -050057e0224ef7232895588a7a5cdb565fda26109594Updated for ghostless version of CLUBB.editmicrophysics.F90
- postprocessing/pyplotgen/requirements.txtjenkins_tests/clubb_ifort_debug_plot/Jenkinsfilejenkins_tests/clubb_nvhpc_gpu_vs_cpu_plot/Jenkinsfilepostprocessing/pyplotgen/src/DataReader.pypostprocessing/pyplotgen/pyplotgen.pysrc/SILHS/latin_hypercube_driver_module.F90postprocessing/pyplotgen/python_html_gallery/gallery.pypostprocessing/pyplotgen/src/interoperability.pyjenkins_tests/clubb_ifort_debug_run/Jenkinsfile3d5089d92afb342c7fb3337ebffc1128bb7f08f71723785812000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comNightly clubb plots (#1167)
* Making step to plot output, copy to pub folder, then create an index.html file to display all plots in that folder.
* Small tweaks
* Small fixes in pyplotgen.
* Copy needs -r
* Using jenkins env variables and switching to scp/ssh commands to allow plots to be generated and created on any machine.
* Adding quotes are env variable usage
* Pyplotgen addition to create a git_info file containing branch and commit name.
* Script should handle the pyplotgen _generated_on_... suffix.
* Making script only run arm again during testing.
* More robust way to get git branch in pyplotgen.
* Testing single quotes
* Making all cases run again.
* Undoing most pyplotgen changes. Making create_plot_list script general and take in a directory. Returning short run test mode.
* Update to create git_info line
* Making all cases run again and adding plot support for ifort.
* Adding plot step to nvhpc gpu diffness test.
* Fixing error
* Reverting diffness script, making new one specifically for plotting.
* Changes to allow plotting of previous output.
* Setting O0 for testing
* Branch folder restructure.
* Making tests run all cases again and update master output only.
* Clean up and naming changes.
* Addin -O2 back.
* Small update to pyplotgen to make title reflect name of output specified in command.
* This cuda call doesn't work with the subscript for some reason.
* Making only priority cases run for GPU plot test and preventin it from running on carson
2024-08-16 00:23:32 -05003d5089d92afb342c7fb3337ebffc1128bb7f08f7Nightly clubb plots (#1167)addjenkins_tests/clubb_ifort_debug_plot/Jenkinsfileeditsrc/SILHS/latin_hypercube_driver_module.F90editpostprocessing/pyplotgen/pyplotgen.pyeditpostprocessing/pyplotgen/requirements.txteditpostprocessing/pyplotgen/src/interoperability.pyeditpostprocessing/pyplotgen/src/DataReader.pydeletejenkins_tests/clubb_ifort_debug_run/Jenkinsfileaddjenkins_tests/clubb_nvhpc_gpu_vs_cpu_plot/Jenkinsfileeditpostprocessing/pyplotgen/python_html_gallery/gallery.py
- jenkins_tests/clubb_ifort_debug_plot/Jenkinsfilejenkins_tests/clubb_nvhpc_gpu_vs_cpu_plot/Jenkinsfile396b3ecedbfdd99727f788b16931106efbd8880f1724296670000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSlight variable name change in attempt to get the Update Master Output step to run.
2024-08-21 22:17:50 -0500396b3ecedbfdd99727f788b16931106efbd8880fSlight variable name change in attempt to get the Update Master Output step to run.editjenkins_tests/clubb_ifort_debug_plot/Jenkinsfileeditjenkins_tests/clubb_nvhpc_gpu_vs_cpu_plot/Jenkinsfile
- src/CLUBB_core/advance_wp2_wp3_module.F90src/Benchmark_cases/atex.F90src/CLUBB_core/mean_adv.F90src/Benchmark_cases/cloud_sed_module.F90src/CLUBB_core/sfc_varnce_module.F90src/CLUBB_core/sponge_layer_damping.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/stats_type.F90input_misc/tuner/error_dycoms2_rf02_ds.ininput_misc/tuner/error_dycoms2_rf01.insrc/time_dependent_input.F90src/G_unit_test_types/w_up_in_cloud_tests.F90src/advance_microphys_module.F90src/G_unit_test_types/pdf_parameter_tests.F90src/bugsrad_driver.F90input/grid/ecmwf_90lev_zt_grid.grdsrc/CLUBB_core/parameters_tunable.F90input_misc/tuner/error_arm.ininput/grid/48_level_gfdl/dycoms2_rf02_ds.grdsrc/SILHS/latin_hypercube_driver_module.F90src/Benchmark_cases/nov11.F90src/CLUBB_core/advance_xp2_xpyp_module.F90src/SILHS/output_2D_samples_module.F90src/CLUBB_core/clubb_api_module.F90input_misc/tuner/error_atex.ininput/grid/dycoms2_rf02_sam_zt_grid.grdsrc/estimate_scm_microphys_module.F90src/ice_dfsn_module.F90src/SILHS/transform_to_pdf_module.F90src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90src/Benchmark_cases/dycoms2_rf02.F90input_misc/tuner/error_four_cases.insrc/CLUBB_core/calc_pressure.F90src/CLUBB_core/hydromet_pdf_parameter_module.F90src/Benchmark_cases/mpace_b.F90src/hydrostatic_module.F90input/grid/deep_convection_128lev_27km_zt_grid.grdsrc/input_fields.F90src/G_unit_test_types/spurious_source_test.F90src/SILHS/silhs_api_module.F90src/mixed_moment_PDF_integrals.F90src/CLUBB_core/numerical_check.F90src/CLUBB_core/precipitation_fraction.F90src/CLUBB_core/turbulent_adv_pdf.F90src/CLUBB_core/advance_clubb_core_module.F90input_misc/tuner/error_all.ininput_misc/tuner/error_lba.insrc/clubb_driver.F90input/grid/48_level_gfdl/mpace_b.grdsrc/CLUBB_core/fill_holes.F90src/Benchmark_cases/lba.F90input_misc/tuner/error_ticket_756.insrc/CLUBB_core/advance_xp3_module.F90input_misc/tuner/error_rico.insrc/CLUBB_core/grid_class.F90src/CLUBB_core/pdf_closure_module.F90input_misc/tuner/error_gabls3_night.insrc/extended_atmosphere_module.F90src/Benchmark_cases/wangara.F90src/gfdl_activation.F90input_misc/tuner/error_nov11_altocu.insrc/clubb_tuner.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/Benchmark_cases/astex_a209.F90input/grid/48_level_gfdl/arm_97.grdinput_misc/tuner/error_dycoms2_rf02_do.insrc/CLUBB_core/diffusion.F90input/grid/48_level_gfdl/rico.grdsrc/Morrison_microphys/microphysics.F90src/CLUBB_core/clip_explicit.F90src/Benchmark_cases/gabls2.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/Benchmark_cases/bomex.F90input_misc/tuner/error_arm_97.insrc/CLUBB_core/setup_clubb_pdf_params.F90input/grid/48_level_gfdl/atex.grdsrc/Benchmark_cases/cobra.F90input_misc/tuner/error_fire.insrc/CLUBB_core/pos_definite_module.F90input_misc/tuner/error_gabls2.insrc/KK_microphys_module.F90input/grid/dycoms2_rf02_97lev_grid.grdsrc/lh_microphys_driver_module.F90src/CLUBB_core/Skx_module.F90src/microphys_driver.F90src/silhs_category_variance_module.F90src/SILHS/est_kessler_microphys_module.F90src/CLUBB_core/stats_clubb_utilities.F90src/CLUBB_core/mono_flux_limiter.F90src/CLUBB_core/sigma_sqd_w_module.F90src/Benchmark_cases/dycoms2_rf01.F90src/CLUBB_core/advance_helper_module.F90src/Benchmark_cases/rico.F90input_misc/tuner/error_bomex.ininput_misc/tuner/error_bomex_fire.ininput/grid/48_level_gfdl/bomex.grdsrc/Benchmark_cases/mpace_a.F90run_scripts/run_bindiff_all.pysrc/SILHS/lh_microphys_var_covar_module.F90src/morrison_microphys_module.F90src/simple_rad_module.F90src/variables_radiation_module.F90src/sounding.F90input/grid/48_level_gfdl/dycoms2_rf01.grdinput/grid/coarse_30lev_32km_zt_grid.grdsrc/coamps_microphys_driver_module.F90fa3e59573b8c754e973edfb4a08117a6efa142681724333265000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb ghost exorcism (#1159)
* I am adding grid_class_new.F90 to the code as a copy of grid_class.F90.
The first step toward removing the ghost level from the model is to
modify the grid file. Having a second grid file in play will allow
functions and subroutines that are undergoing modification earlier in
this process to use the new file, while functions and subroutines that
have not yet been modified will continue to use the old grid file
until they can be modified.
At the end of this process, the old grid file will be able to be
removed and grid_class_new.F90 will simply be able to be renamed
grid_class.F90 at that point.
In this commit, I have altered the schematic and the comments
at the very start of the module to be "ghostless".
* Updated grid_class for the changes to the grid interpolation weighting
functions for the new "ghostless" ascending grid.
* Committing some updates to the new grid class file for ghostless
ascending.
* Updating to match recent changes made to grid_class.F90.
* I finished the removal of the ghost level from the entirety of the new
grid_class file. This standalone file compiles successfully.
* Removing the sources of compiler warnings in grid_class_new.F90 (these
were carried over from grid_class.F90).
* Committing progress in advance_wp2_wp3_module.F90 with regards to
ghostless grid.
* I am committing the updated version of grid_class_new.F90 that allows
all cases to run, regardless of grid_type.
* Fixed a bug in grid_class_new.F90
When grid_type = 2, the calculations of the indices begin_height and
end_height are based on the thermodynamic level grids. Those grid indices
should be used in the call to setup_grid_heights, where the array of
thermodynamic_heights, from index begin_height to index end_height,
should become gr%zt.
When grid_type - 3, the calculations of the indices begin_height and
end_height are based on the momentum grid levels.
Either way, momentum_heights and thermodynamic_heights should both
have the array from begin_height to end_height passed in. When
grid_type = 2, only the thermodynamic height array is relevant in
the setup. When grid_type = 3, only the momentum height array is
relevant in the setup.
* For thermodynamic_height, 1:nzmax-1 is the entire array, but I
entered this for a clarification, especially considering the
following check block.
* Updated grid_class_new to better handle the begin_height and end_height indices.
* Some modifications to advance_wp2_wp3
* Committed some temporary code.
* committed some temporary changes to clubb_api_module.
* Making a bunch of commits to clubb_driver that are mainly temporary for
interface and printing purposes.
* Deghosted another subroutine.
* Updated wp2_term_ta_lhs to use the new gridding.
* De-ghosting wp2_terms_ac_pr2_lhs
* De-ghosted wp2_term_pr3_rhs
* Deghosting wp3_term_tp_lhs.
* Deghosted wp3_terms_ac_pr2_lhs
* Updated the wp3_term_ta_ADG1_lhs subroutine to use boundary conditions
where wp3 (at the top level and bottom momentum levels of the model)
is assumed to have a value of 0.
* For single loop vectors, removing the "collapse(2)" from the acc
statements.
This commit is not bit changing, but the previous commit to this branch
was BIT_CHANGING:902d6caed8a4533f59f4165106276959b4f90895
* I updated wp3_term_ta_explicit_rhs for the ghostless grid.
When l_explicit_turbulent_adv_wp3 is turned on, the results from
this branch exactly match those found on the master branch.
* Updating diffusion_zm_lhs for "Ghostless" gridding.
* Fixed a typo in the comments that was introduced in the previous commit.
* Updated for "ghostless" diffusion.
* With wp3 now being set to a fixed-point boundary condition value
of 0 at the current thermodynamic level 1 (first t-lev above the
surface), it is not necessary to loop over level 1 within the code
for each wp3 term.
Also contains code to enforce a fixed-point boundary condition
of wp3=0 at the first thermodynamic level above the surface.
* Restoring diffusion to the way it should be for the exorcised ghost grid
prior to the most recent master merge. Lines for the ghost point were
accidentally added during the merge commit.
* Updated code to correct wp3_bp1 and wp3_pr2 budget terms so that
they still match bit-for-bit what is found in the master branch.
* Updating term_ma_zm_lhs for ghostless gridding. Results are bit-for-bit
identical.
* After debugging, I am now committing the ghostless version of
term_ma_zt_lhs.
* Updating the clubb_ghost_exorcism branch for ghostless wp23 rhs,
lhs, and solve.
This revision runs; however, there are still some issues tracking
down the source of problems in maintaining bit-for-bit results.
* Updated to maintain bit-for-bitness with the master code.
* Finished exorcising the ghost from advance_wp2_wp3_module.F90.
* Small openacc changes to fix GPU runs
* Adjusting new hybrid PDF code to continue to match the master branch
bit-for-bit while construction continues.
* Committing the first portion of a nomenclature change where the number
of momentum vertical grid levels is denoted as nzm rather than nz.
* Changing the notation of the number of grid levels on the momentum grid,
previously nz, to nzm in some files.
* Changed some comments and a little bit of code in the new grid_class
file to provide a better description.
* Updated sigma_sqd_w_module for ghostless gridding.
* I added the new "ghostless" discretization to turbulent_adv_pdf.F90,
and also appropriately altered the points in the code where the
turbulent advection subroutines are called from in
advance_xm_wpxp_module.F90 and advance_xp2_xpyp_module.F90.
The code produced bit-for-bit results in regards to the standard
configuration, the new hybrid PDF configuration, and also for the
configuration with the godunov flags turned on.
* Altered many of the lower-level subroutines in
advance_xp2_xpyp_module.F90 for ghostless gridding.
* Upgraded subroutine calc_xp2_xpyp_ta_terms for ghostless discretization.
This should alter the results when the new_hybrid PDF is used in
conjunction with upwind discretization, but it doesn't alter the
results for anything else.
* Completed making advance_xp2_xpyp ghostless.
* Completed the de-ghosting of advance_windm_edsclrm.
Results are BIT_CHANGING because the ghost level was interacting with
the results.
* The call to calc_xpwp from advance_microphys was not supposed to be
updated yet. It wound up being sort of "partially updated" for
ghostless gridding, which was a bug that led to some diagnostic output
fields not being bit-for-bit. In this commit, I returned it to its prior
form so that zm output files once again retain bit-for-bit status
between this branch and the master.
* The ghost point interface statements after the return from
advance_windm_edsclrm needed to be encased in the same conditional
statements that the calculations occurred in with the aforementioned
subroutine. This change fixes a bug where a handful of cases had results
that were not bit-for-bit from revisions before this code was added.
* Fixed bug where the wrong stats were being recorded to the stats
for coef_wpthlp2_implicit, etc.
* I am committing a bug fix to the implicit surface flux calculation
in the eddy-diffusivity wind code (which is used when
l_predict_upwp_vpwp is turned off).
I am also committing some temporary ghost point interface stats code
within advance_windm_edsclrm.
* I updated the diagrams in advance_windm_edsclrm to reflect the
new ghostless grid.
* I improved the description section of advance_windm_edsclrm.
* Made numerous low-level subroutines ghostless within
advance_xm_wpxp_module.F90. Maintained bit-for-bit results
with the master branch.
* I am updating the xm wpxp code that calls the wpxp turbulent advection
term based on your PDF and option for ghostless gridding.
* Updating some of the lower-level functions of the monotonic flux limiter
for ghostless gridding.
* I have updated the monotonic flux limiter for ghostless gridding!
* A couple of redundant declarations were brought in on the last merge.
* Committing further updates to ghostless gridding, including:
1) Further modifications to advance_xm_wpxp, which includes branching
out in Brunt-Vaisala frequency calculations in advance_helper;
2) Update in calculating the initial pressure;
and 3) updating grid class new to use the same "value drop down"
in the zt2zm function and "derivative drop down" in the ddzt function
that are now used in grid_class in the master.
Results are bit-for-bit identical with the master.
* Updated xm_wpxp_lhs for ghostless gridding.
* Made xm_wpxp_rhs ghostless.
* Updated xm_wpxp_solve for ghostless gridding!
* Updating pos_definite_module.F90 for ghostless gridding.
* Updated vertical hole filling and xm clipping and stats for
ghost point removal.
Results are still bit-for-bit with the master branch.
* Updated advance_xm_wpxp to remove the ghost point.
* Updating some zt stats to use a value of 0 for the "ghost" level.
* Updated subroutine compute_mixing_length for ghostless gridding.
* Removing the ghost point from calculate_Lscale_directly
* Added a "ghostbuster" option (-g) in the run_bindiff_all.py python
script that omits the "ghost" level from the comparison for _zt.nc
output files when envoked.
* I de-ghosted the l_diagnose_Lscale_from_tau code.
* Fixing a couple bugs with the merge.
* De-ghosted a couple of subroutines with advance_helper_module.F90.
* Code wasn't compiling because of too many characters on one line.
* De-ghosted precipitation_fraction.F90.
* De-ghosted more code, including sfc_varnce_module.F90.
* De-ghosted numerical_check.F90
* Committing a chunk of code that effectively "finishes off" the
deghosting of CLUBB core, although results aren't there yet and it still
needs more debugging.
* This corrects the bug where an error would occur when trying to compare
a run with a ghost level to a run without a ghost level.
* Commiting some necessary ghost point removal code.
* Updated the calculations of rcm_in_layer and cloud_cover for ghostless
gridding.
* I removed the ghost point from all the files within the Benchmark_cases
directory.
* I am committing code that removes the ghost level from
setup_clubb_pdf_params and most of the collection of CLUBB's
microphysics schemes.
* Fixing a bug in SILHS where sample point values were being overwritten
at level 1.
* I fixed some bugs in the ghostless version of the Morrison microphysics
driver.
* I fixed some array declaration mismatches in silhs_api_module.F90.
* I have deghosted the call to the code that calculates microphysics
tendencies and everything below it.
* Performed a de-ghosting, as well as an improvement that ensures
that mean sedimentation is always conservative (excluding the
amount of hydrometeor that leaves the domain at the surface),
to all subroutines at the level of microphys_lhs and lower
in advance_microphys_module.F90. This includes all
process-related subroutines like those that govern
sedimentation or turbulent sedimentation.
Gee, how is it possible that such are large amount of work
gets done when there's no office. It must have been magic
elves who did it. I mean, a physical office must be key
to every element of functioning in life, right?
* Reversing the accidental stats file commit I made in the previous
commit.
* Updating the "leftovers" from the previous merge to make it consistent
with the call syntax in the new, ghostless CLUBB.
* Updated the turbulent sedimentation code to handle upper and lower
boundary conditions in a better manner.
* I have finished de-ghosting the entirety of advance_microphys_module.F90
and all codes that are underneath its umbrella.
* I finished de-ghosting the radiation portion of CLUBB.
* I have removed the ghost level from hydrostatic_module.F90.
* I removed the ghost point from parameters_tunable and started
referencing the ghostless grid through the entirety of clubb_api_module
as well as in all of the G-unit tests.
* Deghosted another file. Not too many left.
* Deghosted sounding.F90
* I have deghosted clubb_driver.F90 and everything below its umbrella,
which is a huge benchmark in this process.
* It is not necessary to de-ghost the source code for the tuner, since
the information on what levels it is tuning for is fed in from input
files.
Within the tuner input files, I have adjusted the tuning ranges by 1
to compensate for the fact that the ghost level has now been entirely
removed from the model.
* Got rid of some unnecessary "use grid_class" statements that were
still referencing the old grid.
* I have found a bug in the ghostless SILHS code in the SILHS
code that calculates the variances and covariances of moisture
and heat (that are fed back into the model predictive equations).
In short, variables that were used to store the grid mean values
of thl, rt, and w were being set to 0 at level 1. This was fine
when level 1 was the ghost level, but level 1 is no longer the
ghost level. This was root cause of the issue.
* The line that sets rand_pool at level 1 that was merged in during
the previous merge commit needs to be removed.
* These lines also needed to be fixed because they were supposed to
be changed to nzt / 2 after the previous merge commit.
* Correcting a bug in coamps microphysics regarded the unnecessary
interpolation of hydrometeor sedimentation velocities to the zm grid.
This interpolation is a bug because CLUBB expects hydrometeor velocities
output on the zt grid.
* I am committing a fix to the _ta budget terms. It will fix the error
messages as well allow for budget term agreement between the master
and clubb_ghost_exorcism branches.
* Fixing an error in the ghostless budget stats for turbulent
sedimentation.
* After the merge, I am once again updating the merged code for
ghost level removal.
* Getting rid of leftover ghost removal junk that was still lying around.
* I needed to pass p_sfc inside CLUBB core to help set the value
of p_in_Pa_zm at level 1.
* C11_Skw_fnc is a zt variable, while Cx_fnc_Richardson is a zm variable.
The offset is to keep results the same between the current master
branch and the clubb_ghost_exorcism branch when the l_use_C11_Richardson
flag is enabled.
* Fixed a bug.
* I found a couple more instances where the api had dimensions switched
around.
* Eliminated diffusion_cloud_frac_zt_lhs, which is unused code that isn't
even hooked up (called from) anywhere in the model anymore.
* Changes that also needed to be made with the previous commit.
* The source of the array out-of-bounds error.
* Moving grid_class_new back to grid_class!
* Reminder notes in case input_fields gets used in the future.
* I accidentally committed input fields related changes to rico_model.in
that weren't meant to be committed in the previous commit. I am undoing
those now.
* Having clubb thermodynamic level 1 below the surface is no longer
the stanard scenario!
---------
Co-authored-by: Gunther Huebler <huebler@uwm.edu>
2024-08-22 08:27:45 -0500fa3e59573b8c754e973edfb4a08117a6efa14268Clubb ghost exorcism (#1159)editinput_misc/tuner/error_nov11_altocu.ineditsrc/CLUBB_core/sigma_sqd_w_module.F90editsrc/clubb_tuner.F90editsrc/CLUBB_core/Skx_module.F90editsrc/CLUBB_core/mixing_length.F90editsrc/Benchmark_cases/cloud_sed_module.F90editsrc/Benchmark_cases/dycoms2_rf01.F90editinput_misc/tuner/error_atex.ineditinput/grid/48_level_gfdl/dycoms2_rf02_ds.grdeditsrc/input_fields.F90editsrc/silhs_category_variance_module.F90editsrc/Benchmark_cases/lba.F90editsrc/CLUBB_core/numerical_check.F90editinput_misc/tuner/error_arm_97.ineditsrc/Benchmark_cases/astex_a209.F90editinput_misc/tuner/error_bomex.ineditinput/grid/48_level_gfdl/arm_97.grdeditinput_misc/tuner/error_all.ineditsrc/bugsrad_driver.F90editinput/grid/48_level_gfdl/rico.grdeditsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/ice_dfsn_module.F90editsrc/SILHS/transform_to_pdf_module.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/microphys_driver.F90editinput_misc/tuner/error_lba.ineditsrc/hydrostatic_module.F90editsrc/advance_microphys_module.F90editinput_misc/tuner/error_dycoms2_rf02_ds.ineditsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90editsrc/CLUBB_core/hydromet_pdf_parameter_module.F90editsrc/CLUBB_core/grid_class.F90editinput_misc/tuner/error_bomex_fire.ineditsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/stats_type.F90editsrc/morrison_microphys_module.F90editsrc/Benchmark_cases/mpace_a.F90editsrc/Benchmark_cases/nov11.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/sponge_layer_damping.F90editsrc/lh_microphys_driver_module.F90editinput_misc/tuner/error_rico.ineditsrc/CLUBB_core/advance_windm_edsclrm_module.F90editinput_misc/tuner/error_dycoms2_rf02_do.ineditsrc/mixed_moment_PDF_integrals.F90editsrc/clubb_driver.F90editinput_misc/tuner/error_four_cases.ineditinput/grid/dycoms2_rf02_97lev_grid.grdeditsrc/variables_radiation_module.F90editsrc/SILHS/silhs_api_module.F90editsrc/SILHS/est_kessler_microphys_module.F90editsrc/CLUBB_core/clip_explicit.F90editsrc/CLUBB_core/precipitation_fraction.F90editrun_scripts/run_bindiff_all.pyeditinput_misc/tuner/error_ticket_756.ineditinput/grid/48_level_gfdl/mpace_b.grdeditsrc/CLUBB_core/pos_definite_module.F90editsrc/SILHS/lh_microphys_var_covar_module.F90editsrc/Benchmark_cases/rico.F90editsrc/time_dependent_input.F90editinput/grid/48_level_gfdl/bomex.grdeditsrc/coamps_microphys_driver_module.F90editinput/grid/48_level_gfdl/dycoms2_rf01.grdeditsrc/extended_atmosphere_module.F90editinput_misc/tuner/error_gabls2.ineditsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/stats_clubb_utilities.F90editsrc/Benchmark_cases/wangara.F90editsrc/CLUBB_core/sfc_varnce_module.F90editsrc/CLUBB_core/turbulent_adv_pdf.F90editsrc/Benchmark_cases/bomex.F90editsrc/CLUBB_core/calc_pressure.F90editinput/grid/48_level_gfdl/atex.grdeditsrc/CLUBB_core/mono_flux_limiter.F90editinput_misc/tuner/error_fire.ineditsrc/CLUBB_core/advance_xp3_module.F90editsrc/CLUBB_core/mean_adv.F90editsrc/CLUBB_core/parameters_tunable.F90editsrc/Benchmark_cases/atex.F90editsrc/G_unit_test_types/w_up_in_cloud_tests.F90editsrc/simple_rad_module.F90editsrc/Benchmark_cases/gabls2.F90editsrc/Morrison_microphys/microphysics.F90editinput_misc/tuner/error_gabls3_night.ineditsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/sounding.F90editsrc/SILHS/latin_hypercube_driver_module.F90editinput/grid/deep_convection_128lev_27km_zt_grid.grdeditsrc/Benchmark_cases/dycoms2_rf02.F90editsrc/CLUBB_core/clubb_api_module.F90editinput/grid/coarse_30lev_32km_zt_grid.grdeditsrc/CLUBB_core/diffusion.F90editsrc/CLUBB_core/fill_holes.F90editinput/grid/dycoms2_rf02_sam_zt_grid.grdeditsrc/gfdl_activation.F90editsrc/Benchmark_cases/cobra.F90editinput_misc/tuner/error_dycoms2_rf01.ineditsrc/estimate_scm_microphys_module.F90editsrc/KK_microphys_module.F90editinput_misc/tuner/error_arm.ineditsrc/CLUBB_core/setup_clubb_pdf_params.F90editsrc/Benchmark_cases/mpace_b.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/SILHS/output_2D_samples_module.F90editinput/grid/ecmwf_90lev_zt_grid.grd
- READMEae5433c83c88388bbe3c6d73f2869767d78778911724336163000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdated the README to explain the grid notations gr%nzm and gr%nzt,
as well as added a note about the use of the generic nz number of
grid levels.
2024-08-22 09:16:03 -0500ae5433c83c88388bbe3c6d73f2869767d7877891Updated the README to explain the grid notations gr%nzm and gr%nzt,editREADME
- src/Morrison_microphys/microphysics.F90737a45580db293a11a08aaa87d85be42125019451724472094000http://carson.math.uwm.edu/jenkins/user/pickettCole Pickettlarsongroupgithub@gmail.comRaw-copy updating src/Morrison_microphys
2024-08-23 23:01:34 -0500737a45580db293a11a08aaa87d85be4212501945Raw-copy updating src/Morrison_microphyseditsrc/Morrison_microphys/microphysics.F90
- utilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/create_figs.pyutilities/sens_matrix/sens_matrix_dashboard.py69a9b60d5fcf66dd50b2a79e08f72f3cd05b099f1724682729000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Plots subsets of 20x20-degree regions.
For #910.
2024-08-26 09:32:09 -050069a9b60d5fcf66dd50b2a79e08f72f3cd05b099fQuadTune: Plots subsets of 20x20-degree regions.editutilities/sens_matrix/create_figs.pyeditutilities/sens_matrix/sens_matrix_dashboard.pyeditutilities/sens_matrix/set_up_dashboard_inputs.py
- src/BUGSrad/bugs_rad.Fsrc/parameters_radiation.F902fa28500b9fcba8c34f2b154c8c0d5bac0f6784f1724704623000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSmall bugs fix in bugsrad code. This was only caught when compiling with intel debug and using '-warn all', which compares interface dimensions/declaration between files.
2024-08-26 15:37:03 -05002fa28500b9fcba8c34f2b154c8c0d5bac0f6784fSmall bugs fix in bugsrad code. This was only caught when compiling with intel debug and using '-warn all', which compares interface dimensions/declaration between files.editsrc/parameters_radiation.F90editsrc/BUGSrad/bugs_rad.F
- src/CLUBB_core/advance_helper_module.F9043bba04e1cbb60b75bf4336ad46f0cbf9986abeb1724704978000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduVariable name correction in acc data statement.
2024-08-26 15:42:58 -050043bba04e1cbb60b75bf4336ad46f0cbf9986abebVariable name correction in acc data statement.editsrc/CLUBB_core/advance_helper_module.F90
- src/CLUBB_core/advance_xp2_xpyp_module.F906a2d0b828127e5759276be61e429315dcd470c531724708483000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSplitting zeros_vector into versions with nzt or nzm size to match sizes in subroutine.
2024-08-26 16:41:23 -05006a2d0b828127e5759276be61e429315dcd470c53Splitting zeros_vector into versions with nzt or nzm size to match sizes in subroutine.editsrc/CLUBB_core/advance_xp2_xpyp_module.F90
- src/CLUBB_core/clubb_api_module.F90src/clubb_driver.F901a8be6de1f5a784dd528f827357b4edae4198bbd1724708509000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking radf size correct in api and clubb_driver.
2024-08-26 16:41:49 -05001a8be6de1f5a784dd528f827357b4edae4198bbdMaking radf size correct in api and clubb_driver.editsrc/CLUBB_core/clubb_api_module.F90editsrc/clubb_driver.F90
- postprocessing/pyplotgen/README.mddc75b0832f7d9834f7038a05aeec4eac9dc97d321724787705000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdates pyplotgen's readme
2024-08-27 14:41:45 -0500dc75b0832f7d9834f7038a05aeec4eac9dc97d32Updates pyplotgen's readmeeditpostprocessing/pyplotgen/README.md
- postprocessing/pyplotgen/requirements.txtf3020b6c9cc8074dc30c3531c59ea6d91c1553211724789775000http://carson.math.uwm.edu/jenkins/user/0-freundlich-adenin0-freundlich-adenin0-freundlich-adenin@icloud.comchange opencv requirement to use headless and update Pillow minor
version
2024-08-27 15:16:15 -0500f3020b6c9cc8074dc30c3531c59ea6d91c155321change opencv requirement to use headless and update Pillow minoreditpostprocessing/pyplotgen/requirements.txt
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_helper_module.F907e33d718280afab43dd3d8fcdc45f1c749ae72921724956382000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRi_zm calc (Part 4) - Implementing calc_Ri_zm (#1160)
* Ri_zm calc (Part 4) - Implementing calc_Ri_zm
CLUBB tocket #1145
1. advance_helper_module.F90
- Implemented calc_Ri_zm
- Replaced Ri_zm calculations in compute_Cx_fnc_Richardson
2. advance_clubb_core_module.F90
Replaced Ri_zm calculations in advance_clubb_core
2024-08-29 13:33:02 -05007e33d718280afab43dd3d8fcdc45f1c749ae7292Ri_zm calc (Part 4) - Implementing calc_Ri_zm (#1160)editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90
- utilities/sens_matrix/create_figs.pyutilities/sens_matrix/sens_matrix_dashboard.py5c3a77e0c4306930e481035c9c0771de44c20fa71725297388000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Use quadratic programming to calculate the smallest dparam needed to debias 2 regions.
For #910.
2024-09-02 12:16:28 -05005c3a77e0c4306930e481035c9c0771de44c20fa7QuadTune: Use quadratic programming to calculate the smallest dparam needed to debias 2 regions.editutilities/sens_matrix/create_figs.pyeditutilities/sens_matrix/sens_matrix_dashboard.py
- src/CLUBB_core/advance_helper_module.F903b21ab44d1b0291162a4394f45f88c8c64cb01571725305536000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRi zm calc4 (#1168)
Bug fix for Ri_zm calc (Part 4) commit
CLUBB tocket #1145
* Added missing acc loop directive in calc_Ri_zm
2024-09-02 14:32:16 -05003b21ab44d1b0291162a4394f45f88c8c64cb0157Ri zm calc4 (#1168)editsrc/CLUBB_core/advance_helper_module.F90
- postprocessing/plotgen/cases/clubb/cgils_s11_p2k_budgets.casepostprocessing/plotgen/cases/clubb/dycoms2_rf02_ds_budgets.casepostprocessing/plotgen/cases/clubb/nov11_altocu_budgets.caseinput/stats/standard_stats.inpostprocessing/plotgen/cases/clubb/arm_budgets.casepostprocessing/plotgen/cases/clubb/cloud_feedback_s06_budgets.casepostprocessing/plotgen/cases/clubb/dycoms2_rf02_do_budgets.casepostprocessing/plotgen/cases/clubb/cloud_feedback_s12_p2k_budgets.casepostprocessing/plotgen/cases/clubb/cloud_feedback_s11_p2k_budgets.casepostprocessing/plotgen/cases/clubb/fire_budgets.casepostprocessing/plotgen/cases/clubb/cgils_s12_p2k_budgets.casepostprocessing/plotgen/cases/clubb/mpace_a_budgets.casepostprocessing/plotgen/cases/clubb/cobra_budgets.casepostprocessing/plotgen/cases/clubb/cgils_s11_budgets.casepostprocessing/plotgen/cases/clubb/wangara_budgets.casedoc/CLUBBeqns.texpostprocessing/plotgen/cases/clubb/bomex_budgets.casepostprocessing/plotgen/cases/clubb/dycoms2_rf02_so_budgets.casepostprocessing/plotgen/cases/clubb/templates/template_budget.casepostprocessing/plotgen/cases/clubb/gabls3_budgets.casepostprocessing/plotgen/cases/clubb/rico_silhs_inter_budgets.caseinput/stats/scalars_stats.inpostprocessing/pyplotgen/config/VariableGroupBaseBudgetsSamStyle.pypostprocessing/plotgen/cases/clubb/mc3e_budgets.casepostprocessing/plotgen/cases/clubb/clex9_nov02_budgets.casepostprocessing/plotgen/cases/cam/ne_pac_lo_iop_budgets.casepostprocessing/plotgen/cases/clubb/cloud_feedback_s12_budgets.casepostprocessing/plotgen/cases/clubb/dycoms2_rf02_nd_budgets.casepostprocessing/plotgen/cases/clubb/cloud_feedback_s11_budgets.caseinput/stats/all_stats.inpostprocessing/plotgen/cases/clubb/lba_budgets.casepostprocessing/plotgen/cases/clubb/gabls3_night_budgets.casepostprocessing/plotgen/cases/cam/se_pac_hi_iop_budgets.casepostprocessing/plotgen/cases/clubb/arm_97_budgets.casesrc/CLUBB_core/advance_xm_wpxp_module.F90postprocessing/pyplotgen/docs/_build/html/searchindex.jspostprocessing/plotgen/cases/cam/iop_budgets.casepostprocessing/plotgen/cases/clubb/twp_ice_budgets.casepostprocessing/plotgen/cases/clubb/cgils_s06_budgets.casepostprocessing/plotgen/cases/cam/se_atl_hi_iop_budgets.casesrc/CLUBB_core/stats_variables.F90postprocessing/pyplotgen/config/VariableGroupBaseBudgets.pypostprocessing/plotgen/cases/clubb/mpace_b_silhs_budgets.casepostprocessing/plotgen/cases/clubb/mpace_b_budgets.casepostprocessing/plotgen/cases/clubb/rico_budgets.casepostprocessing/plotgen/cases/clubb/lba_subperiods/lba_budgets_deep.casepostprocessing/plotgen/cases/clubb/cgils_s12_budgets.casepostprocessing/plotgen/cases/clubb/dycoms2_rf01_fixed_sst_budgets.casepostprocessing/pyplotgen/config/VariableGroupBaseBudgetsLumpedBuoy.pypostprocessing/plotgen/cases/clubb/cgils_s06_p2k_budgets.casepostprocessing/pyplotgen/docs/_build/html/pyplotgen.config.htmlinput/stats/host_budgets_stats.inpostprocessing/plotgen/cases/clubb/gabls2_budgets.casepostprocessing/plotgen/cases/clubb/atex_budgets.casepostprocessing/plotgen/cases/cam/se_pac_lo_iop_budgets.casesrc/CLUBB_core/clip_semi_implicit.F90postprocessing/plotgen/cases/clubb/dycoms2_rf01_budgets.casepostprocessing/plotgen/cases/cam/se_atl_lo_iop_budgets.casepostprocessing/plotgen/cases/clubb/lba_subperiods/lba_budgets_early.casepostprocessing/plotgen/cases/clubb/clex9_oct14_budgets.casesrc/CLUBB_core/stats_zm_module.F90postprocessing/plotgen/cases/clubb/dycoms2_rf02_ds_nightly_budgets.casepostprocessing/plotgen/cases/cam/ne_pac_hi_iop_budgets.casepostprocessing/plotgen/cases/clubb/astex_a209_budgets.casepostprocessing/plotgen/cases/clubb/jun25_altocu_budgets.casepostprocessing/plotgen/cases/clubb/lba_subperiods/lba_budgets_middle.casepostprocessing/plotgen/cases/clubb/cloud_feedback_s06_p2k_budgets.case93d4edb5ce70fc4018aa6dfd4f6184f8682513351725574649000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduWell, this will probably anger the Grim Reaper, but I have finally
removed the SICL from CLUBB (as discussed a number of months ago).
That term is now expunged from the entirety of CLUBB, including all
source code, stats files, and postprocessing files.
This change is technically BIT_CHANGING because two stats variables,
wprtp_sicl and wpthlp_sicl, have been removed from stats output files.
However, all results remain exactly the same.
2024-09-05 17:17:29 -050093d4edb5ce70fc4018aa6dfd4f6184f868251335Well, this will probably anger the Grim Reaper, but I have finallyeditpostprocessing/plotgen/cases/clubb/mpace_b_silhs_budgets.caseeditpostprocessing/plotgen/cases/clubb/wangara_budgets.caseeditpostprocessing/plotgen/cases/cam/se_pac_hi_iop_budgets.caseeditpostprocessing/plotgen/cases/clubb/bomex_budgets.caseeditpostprocessing/plotgen/cases/clubb/clex9_oct14_budgets.caseeditpostprocessing/plotgen/cases/clubb/lba_budgets.caseeditpostprocessing/plotgen/cases/clubb/cloud_feedback_s06_p2k_budgets.caseeditpostprocessing/plotgen/cases/clubb/dycoms2_rf01_budgets.caseeditpostprocessing/plotgen/cases/clubb/clex9_nov02_budgets.caseeditpostprocessing/plotgen/cases/clubb/lba_subperiods/lba_budgets_middle.casedeletesrc/CLUBB_core/clip_semi_implicit.F90editpostprocessing/plotgen/cases/cam/se_pac_lo_iop_budgets.caseeditpostprocessing/plotgen/cases/clubb/twp_ice_budgets.caseeditpostprocessing/plotgen/cases/clubb/cloud_feedback_s11_p2k_budgets.caseeditpostprocessing/plotgen/cases/clubb/jun25_altocu_budgets.caseeditpostprocessing/plotgen/cases/clubb/lba_subperiods/lba_budgets_early.caseeditpostprocessing/plotgen/cases/clubb/rico_silhs_inter_budgets.caseeditpostprocessing/plotgen/cases/clubb/cloud_feedback_s11_budgets.caseeditpostprocessing/plotgen/cases/clubb/cgils_s11_p2k_budgets.caseeditpostprocessing/pyplotgen/config/VariableGroupBaseBudgets.pyeditpostprocessing/plotgen/cases/clubb/nov11_altocu_budgets.caseeditpostprocessing/plotgen/cases/clubb/lba_subperiods/lba_budgets_deep.caseeditinput/stats/scalars_stats.ineditpostprocessing/plotgen/cases/cam/se_atl_lo_iop_budgets.caseeditinput/stats/standard_stats.ineditpostprocessing/plotgen/cases/clubb/gabls3_night_budgets.caseeditpostprocessing/plotgen/cases/clubb/mc3e_budgets.caseeditsrc/CLUBB_core/stats_zm_module.F90editpostprocessing/plotgen/cases/clubb/cgils_s12_budgets.caseeditpostprocessing/plotgen/cases/clubb/cobra_budgets.caseeditdoc/CLUBBeqns.texeditpostprocessing/plotgen/cases/clubb/dycoms2_rf02_do_budgets.caseeditpostprocessing/plotgen/cases/clubb/cgils_s12_p2k_budgets.caseeditpostprocessing/plotgen/cases/clubb/astex_a209_budgets.caseeditpostprocessing/plotgen/cases/clubb/cgils_s06_p2k_budgets.caseeditpostprocessing/plotgen/cases/clubb/rico_budgets.caseeditpostprocessing/plotgen/cases/clubb/templates/template_budget.caseeditpostprocessing/plotgen/cases/cam/se_atl_hi_iop_budgets.caseeditpostprocessing/plotgen/cases/clubb/cgils_s06_budgets.caseeditpostprocessing/plotgen/cases/clubb/mpace_a_budgets.caseeditpostprocessing/plotgen/cases/clubb/dycoms2_rf02_so_budgets.caseeditpostprocessing/plotgen/cases/clubb/gabls3_budgets.caseeditpostprocessing/plotgen/cases/clubb/gabls2_budgets.caseeditpostprocessing/plotgen/cases/clubb/cloud_feedback_s06_budgets.caseeditpostprocessing/plotgen/cases/clubb/cloud_feedback_s12_budgets.caseeditpostprocessing/plotgen/cases/clubb/arm_97_budgets.caseeditpostprocessing/plotgen/cases/clubb/dycoms2_rf02_ds_budgets.caseeditpostprocessing/plotgen/cases/clubb/cloud_feedback_s12_p2k_budgets.caseeditpostprocessing/plotgen/cases/clubb/fire_budgets.caseeditpostprocessing/pyplotgen/config/VariableGroupBaseBudgetsLumpedBuoy.pyeditpostprocessing/plotgen/cases/clubb/atex_budgets.caseeditsrc/CLUBB_core/advance_xm_wpxp_module.F90editpostprocessing/plotgen/cases/clubb/cgils_s11_budgets.caseeditpostprocessing/pyplotgen/config/VariableGroupBaseBudgetsSamStyle.pyeditpostprocessing/pyplotgen/docs/_build/html/pyplotgen.config.htmleditsrc/CLUBB_core/stats_variables.F90editpostprocessing/plotgen/cases/clubb/arm_budgets.caseeditinput/stats/all_stats.ineditpostprocessing/plotgen/cases/clubb/dycoms2_rf01_fixed_sst_budgets.caseeditpostprocessing/plotgen/cases/cam/ne_pac_lo_iop_budgets.caseeditinput/stats/host_budgets_stats.ineditpostprocessing/plotgen/cases/clubb/dycoms2_rf02_ds_nightly_budgets.caseeditpostprocessing/plotgen/cases/cam/ne_pac_hi_iop_budgets.caseeditpostprocessing/plotgen/cases/clubb/dycoms2_rf02_nd_budgets.caseeditpostprocessing/plotgen/cases/cam/iop_budgets.caseeditpostprocessing/pyplotgen/docs/_build/html/searchindex.jseditpostprocessing/plotgen/cases/clubb/mpace_b_budgets.case
- READMEe27a7e6ba8d499897429f88886722ef88f601c551725986354000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate README so that it mentions run_bindiff_all.py
2024-09-10 11:39:14 -0500e27a7e6ba8d499897429f88886722ef88f601c55Update README so that it mentions run_bindiff_all.pyeditREADME
- src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/advance_xp2_xpyp_module.F90bbe60eb01ef75981949e0212046581228ef095601726084912000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@users.noreply.github.comChange variables from a1 and a3 to a1_coef and a3_coef
For issue #977
2024-09-11 15:01:52 -0500bbe60eb01ef75981949e0212046581228ef09560Change variables from a1 and a3 to a1_coef and a3_coefeditsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90
- src/error.F9091b4c342760c219594f77fa5b72df0c50d47f9211726248914000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdating tuner code to include an option to save all netcdf files (#1171)
* Updating tuner code to include an option to save all netcdf files
from a tuner run. Works with multiple tuner cases, and labels
the files with "_iter0001.nc" or "_iter0108.nc", for example.
* Clarifying that there is no need to define "tuning_filename" in error.F90
to avoid confusion for posterity.
2024-09-13 12:35:14 -050091b4c342760c219594f77fa5b72df0c50d47f921Updating tuner code to include an option to save all netcdf files (#1171)editsrc/error.F90
- utilities/sens_matrix/README.mdcdae675182304b23223c32141ac7b8891d084a881726251720000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate documentation for QuadTune.
2024-09-13 13:22:00 -0500cdae675182304b23223c32141ac7b8891d084a88Update documentation for QuadTune.editutilities/sens_matrix/README.md
- utilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/create_figs.py9e1cc767adc5db5f0cebbd284eb48f6549eaef5b1726364273000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Add column parameter vector and equals sign to sens matrix equation plot.
For #910.
2024-09-14 20:37:53 -05009e1cc767adc5db5f0cebbd284eb48f6549eaef5bQuadTune: Add column parameter vector and equals sign to sens matrix equation plot.editutilities/sens_matrix/set_up_dashboard_inputs.pyeditutilities/sens_matrix/create_figs.py
- src/CLUBB_core/new_hybrid_pdf_main.F90src/CLUBB_core/advance_xp3_module.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90src/CLUBB_core/numerical_check.F90src/CLUBB_core/sfc_varnce_module.F90src/CLUBB_core/stats_zm_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/clubb_driver.F90src/sounding.F90src/CLUBB_core/stats_clubb_utilities.F90src/CLUBB_core/stats_zt_module.F904f7294c182d43d0550fe0bc92568d3232c3cd41e1726575983000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comchange loop index to sclr and edsclr for sclr_dim and edsclr_dim (#1173)
Whenever a loop is dimensioned sclr_dim, use sclr as the loop index. Whenever a loop is dimensioned edsclr_dim, use edsclr as the loop index.
Added changes and tested for binary differences with the following flags for the gabls2 case:
l_host_applies_sfc_fluxes=true/false
l_call_pdf_closure_twice=true/false
l_lmm_stepping=true/false
l_explicit_turbulent_adv_wpxp=true/false
See #987.
2024-09-17 07:26:23 -05004f7294c182d43d0550fe0bc92568d3232c3cd41echange loop index to sclr and edsclr for sclr_dim and edsclr_dim (#1173)editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/numerical_check.F90editsrc/CLUBB_core/advance_xp3_module.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/CLUBB_core/stats_zm_module.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90editsrc/CLUBB_core/sfc_varnce_module.F90editsrc/sounding.F90editsrc/CLUBB_core/new_hybrid_pdf_main.F90editsrc/CLUBB_core/stats_zt_module.F90editsrc/CLUBB_core/stats_clubb_utilities.F90
- src/CLUBB_core/advance_clubb_core_module.F90input/stats/standard_stats.insrc/CLUBB_core/advance_helper_module.F90src/CLUBB_core/stats_variables.F90input/stats/all_stats.insrc/CLUBB_core/stats_zm_module.F900a575085cd29259f1fe05f40951e7d682f06e7ea1726604813000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRi zm calc5 (#1175)
* Ri_zm calc (Part 5) - Implementing calc_Ri_zm
CLUBB tocket #1145
Cleaning up subroutine compute_Cx_fnc_Richardson
1) In advance_helper_module.F90:
- Removed superfluous inputs
- Added Brunt Väisälä frequency variables, shear_sqd, and Lscale_zm as inputs
- Removed call to calc_brunt_vaisala_freq_sqd
- Removed zt2zm(Lscale)
- Removed calculation and stat_update_var of shear_sqd
2) In advance_clubb_core:
- Added stat_update_var for shear_sqd
- Adjusted call to compute_Cx_fnc_Richardson
3) Renamed netcdf variable `shear_sqd` to `ddzt_umvm_sqd` to keep variable names consistent.
2024-09-17 15:26:53 -05000a575085cd29259f1fe05f40951e7d682f06e7eaRi zm calc5 (#1175)editinput/stats/standard_stats.ineditsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/stats_variables.F90editinput/stats/all_stats.ineditsrc/CLUBB_core/stats_zm_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90
- src/CLUBB_core/advance_clubb_core_module.F90221a4ef55f3752211b191529c8d47fa38db7b3c21726773850000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving duplicate definition of edsclr when CLUBB_CAM is defined.
2024-09-19 14:24:10 -0500221a4ef55f3752211b191529c8d47fa38db7b3c2Removing duplicate definition of edsclr when CLUBB_CAM is defined.editsrc/CLUBB_core/advance_clubb_core_module.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/G_unit_test_types/spurious_source_test.F90acfdc3cd0d3a13e8db27fcd0edcb7bbcf7d051891726782540000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRi zm calc6 (#1177)
* Ri_zm calc (Part 6) - Implementing calc_Ri_zm
CLUBB tocket #1145
Eliminating call to calc_stability_correction in advance_xm_wpxp
1) In advance_xm_wpxp_module.F90:
- Eliminated call to calc_stability_correction in calc_xm_wpxp_lhs_terms
- stability_correction is now passed through advance_xm_wpxp to calc_xm_wpxp_lhs_terms
- Cleaned up input lists
2) In advance_clubb_core:
- Adjusted call to advance_xm_wpxp
3) Adjusted spurious_source_test
2024-09-19 16:49:00 -0500acfdc3cd0d3a13e8db27fcd0edcb7bbcf7d05189Ri zm calc6 (#1177)editsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90
- utilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/create_figs.py85b1742e4e5b33bf047d99e7305fa9bd82873db41726843441000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Add check of global-mean SWCF.
For #910.
2024-09-20 09:44:01 -050085b1742e4e5b33bf047d99e7305fa9bd82873db4QuadTune: Add check of global-mean SWCF.editutilities/sens_matrix/set_up_dashboard_inputs.pyeditutilities/sens_matrix/create_figs.py
- src/CLUBB_core/mt95.F90src/CLUBB_core/advance_xp3_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/grid_class.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/stats_rad_zt_module.F90src/CLUBB_core/saturation.F90src/CLUBB_core/mean_adv.F90src/CLUBB_core/sfc_varnce_module.F90src/CLUBB_core/stats_type_utilities.F90src/CLUBB_core/mixing_length.F90src/clubb_tuner.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/CLUBB_core/output_netcdf.F90src/CLUBB_core/model_flags.F90src/G_unit_test_types/w_up_in_cloud_tests.F90src/advance_microphys_module.F90src/G_unit_test_types/pdf_parameter_tests.F90src/CLUBB_core/diffusion.F90src/CLUBB_core/parameters_tunable.F90src/SILHS/latin_hypercube_driver_module.F90src/CLUBB_core/clip_explicit.F90src/microphys_init_cleanup.F90src/CLUBB_core/advance_xp2_xpyp_module.F90src/Benchmark_cases/cloud_feedback.F90src/G_unit_test_types/smooth_min_max_tests.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/SILHS/output_2D_samples_module.F90src/CLUBB_core/matrix_solver_wrapper.F90src/Benchmark_cases/fire.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/stats_lh_zt_module.F90src/CLUBB_core/setup_clubb_pdf_params.F90src/G_unit_tests.F90src/CLUBB_core/stats_rad_zm_module.F90src/KK_microphys_module.F90src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90src/SILHS/transform_to_pdf_module.F90src/CLUBB_core/Skx_module.F90src/G_unit_test_types/smooth_heaviside_tests.F90src/CLUBB_core/stats_clubb_utilities.F90src/CLUBB_core/mono_flux_limiter.F90src/CLUBB_core/advance_helper_module.F90src/Benchmark_cases/dycoms2_rf01.F90src/CLUBB_core/stats_lh_sfc_module.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/tridiag_lu_solver.F90src/input_interpret.F90src/SILHS/silhs_api_module.F90src/mixed_moment_PDF_integrals.F90src/CLUBB_core/numerical_check.F90src/CLUBB_core/lapack_wrap.F90src/CLUBB_core/precipitation_fraction.F90src/CLUBB_core/stats_zm_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/stats_sfc_module.F90src/jacobian.F90src/SILHS/lh_microphys_var_covar_module.F90src/morrison_microphys_module.F90src/clubb_driver.F90src/simple_rad_module.F90src/CLUBB_core/corr_varnce_module.F90src/sounding.F90src/CLUBB_core/fill_holes.F90src/CLUBB_core/stats_zt_module.F90src/Benchmark_cases/neutral_case.F90src/CLUBB_core/new_pdf_main.F90src/coamps_microphys_driver_module.F90src/CLUBB_core/penta_lu_solver.F909b72d6d80236434b434088ad5fea0bad7fdcf4991726848578000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comrefactor code to remove compiler warnings for exceeding 100 characters per line and unused variables and parameters (#1179)
2024-09-20 11:09:38 -05009b72d6d80236434b434088ad5fea0bad7fdcf499refactor code to remove compiler warnings for exceeding 100 characters per line and unused variables and parameters (#1179)editsrc/CLUBB_core/stats_type_utilities.F90editsrc/CLUBB_core/output_netcdf.F90editsrc/jacobian.F90editsrc/CLUBB_core/lapack_wrap.F90editsrc/mixed_moment_PDF_integrals.F90editsrc/CLUBB_core/precipitation_fraction.F90editsrc/CLUBB_core/sfc_varnce_module.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/input_interpret.F90editsrc/CLUBB_core/corr_varnce_module.F90editsrc/CLUBB_core/matrix_solver_wrapper.F90editsrc/CLUBB_core/stats_rad_zt_module.F90editsrc/G_unit_test_types/spurious_source_test.F90editsrc/G_unit_test_types/w_up_in_cloud_tests.F90editsrc/microphys_init_cleanup.F90editsrc/morrison_microphys_module.F90editsrc/CLUBB_core/model_flags.F90editsrc/SILHS/lh_microphys_var_covar_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/advance_xp3_module.F90editsrc/CLUBB_core/penta_lu_solver.F90editsrc/CLUBB_core/stats_lh_zt_module.F90editsrc/CLUBB_core/grid_class.F90editsrc/simple_rad_module.F90editsrc/CLUBB_core/fill_holes.F90editsrc/Benchmark_cases/cloud_feedback.F90editsrc/G_unit_tests.F90editsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90editsrc/CLUBB_core/stats_clubb_utilities.F90editsrc/clubb_tuner.F90editsrc/CLUBB_core/Skx_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/G_unit_test_types/smooth_min_max_tests.F90editsrc/CLUBB_core/stats_zt_module.F90editsrc/advance_microphys_module.F90editsrc/CLUBB_core/stats_rad_zm_module.F90editsrc/sounding.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/SILHS/silhs_api_module.F90editsrc/Benchmark_cases/fire.F90editsrc/CLUBB_core/saturation.F90editsrc/CLUBB_core/diffusion.F90editsrc/coamps_microphys_driver_module.F90editsrc/CLUBB_core/numerical_check.F90editsrc/CLUBB_core/stats_sfc_module.F90editsrc/Benchmark_cases/neutral_case.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/mean_adv.F90editsrc/SILHS/transform_to_pdf_module.F90editsrc/Benchmark_cases/dycoms2_rf01.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/stats_lh_sfc_module.F90editsrc/CLUBB_core/mono_flux_limiter.F90editsrc/CLUBB_core/stats_zm_module.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/CLUBB_core/setup_clubb_pdf_params.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/SILHS/latin_hypercube_driver_module.F90editsrc/G_unit_test_types/smooth_heaviside_tests.F90editsrc/KK_microphys_module.F90editsrc/CLUBB_core/mixing_length.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/CLUBB_core/clip_explicit.F90editsrc/CLUBB_core/mt95.F90editsrc/CLUBB_core/new_pdf_main.F90editsrc/CLUBB_core/tridiag_lu_solver.F90editsrc/CLUBB_core/parameters_tunable.F90editsrc/SILHS/output_2D_samples_module.F90
githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephenshttp://carson.math.uwm.edu/jenkins/user/pickettCole Picketthttp://carson.math.uwm.edu/jenkins/user/0-freundlich-adenin0-freundlich-adeninhttp://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonhttp://carson.math.uwm.edu/jenkins/user/sdomkeSteffen Domkehttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffinhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse183http://carson.math.uwm.edu/jenkins/view/all/job/branch_clubb_test/183/181http://carson.math.uwm.edu/jenkins/view/all/job/branch_clubb_test/181/