BRANCHorigin/clubb_silhs_develTESTcam_scam_gfortran_testStarted by user Gunther HueblerhueblerGunther Huebler2248289184281ea91bd170ad41282d0c54f31531b848289184281ea91bd170ad41282d0c54f31531b8refs/remotes/origin/flag_removal48289184281ea91bd170ad41282d0c54f31531b848289184281ea91bd170ad41282d0c54f31531b8refs/remotes/origin/flag_removal128d415ba99d560e60b641054bb34c77d3f22dd1fd8d415ba99d560e60b641054bb34c77d3f22dd1fdrefs/remotes/origin/stats_testing8d415ba99d560e60b641054bb34c77d3f22dd1fd8d415ba99d560e60b641054bb34c77d3f22dd1fdrefs/remotes/origin/stats_testing240c3aa442df83297eefc4464684781a5595e53b450c3aa442df83297eefc4464684781a5595e53b45refs/remotes/origin/l_vary_convect_depth_addition0c3aa442df83297eefc4464684781a5595e53b450c3aa442df83297eefc4464684781a5595e53b45refs/remotes/origin/l_vary_convect_depth_addition9d43073a5be7ffc3127a26c1398e691d75074d201d43073a5be7ffc3127a26c1398e691d75074d201refs/remotes/origin/changes_to_not_breakd43073a5be7ffc3127a26c1398e691d75074d201d43073a5be7ffc3127a26c1398e691d75074d201refs/remotes/origin/changes_to_not_break20ffa1ab054f2a61734d248d2f481b5a180291e4e0ffa1ab054f2a61734d248d2f481b5a180291e4e0refs/remotes/origin/stats_to_hostsffa1ab054f2a61734d248d2f481b5a180291e4e0ffa1ab054f2a61734d248d2f481b5a180291e4e0refs/remotes/origin/stats_to_hosts27f839568c86ee78f3d6f9cd46b517640041248cabf839568c86ee78f3d6f9cd46b517640041248cabrefs/remotes/origin/masterf839568c86ee78f3d6f9cd46b517640041248cabf839568c86ee78f3d6f9cd46b517640041248cabrefs/remotes/origin/master360805082d217c3a8009d33721b75ff43841c65a4a0805082d217c3a8009d33721b75ff43841c65a4arefs/remotes/origin/clubb_silhs_devel0805082d217c3a8009d33721b75ff43841c65a4a0805082d217c3a8009d33721b75ff43841c65a4arefs/remotes/origin/clubb_silhs_devel0805082d217c3a8009d33721b75ff43841c65a4a0805082d217c3a8009d33721b75ff43841c65a4arefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/branch_cam_test/detail/branch_cam_test/36/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/branch_cam_test/detail/branch_cam_test/36/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/branch_cam_test/detail/branch_cam_test/36/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/branch_cam_test/detail/branch_cam_test/36/testsfalsefalse#36548730928218branch_cam_test #3636false3611417SUCCESS1641850528081http://carson.math.uwm.edu/jenkins/view/all/job/branch_cam_test/36/bld/namelist_files/namelist_defaults_cam.xml3e914cd46fbdbe4b2f76d36a49d99647dbd14b6f1640214591000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comSet `clubb_l_min_xp2_from_corr_wx = T` and also set `clubb_l_min_wp2_from_corr_wx = T`. These are the correct settings when `enable_relaxed_clipping = F`. This code change is BIT_CHANGING. For larson-group/clubb#846. 2021-12-22 17:09:51 -06003e914cd46fbdbe4b2f76d36a49d99647dbd14b6fSet `clubb_l_min_xp2_from_corr_wx = T`editbld/namelist_files/namelist_defaults_cam.xmlrun_scripts/run_scam.bashec7f7e65d116a8c30f6a6d2a6cbec61ec4d8b2441640645802000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemove blank line in order to resolve cam_coarse_res_bin_diff_regression_gfortran_test in Jenkins. CAM was stopping because some idiot-proofing was blocking the former flag settings, namely, `clubb_l_min_xp2_from_corr_wx = F`, `clubb_l_min_wp2_from_corr_wx = F`. These values are now blocked when `enable_relaxed_clipping = F`. RESOLVED:45c07c927222e38de62dfe513875a416652866cc RESOLVED:03b5534cf8ee3458340690cf5c15092844416d08 For larson-group/clubb#846. 2021-12-27 16:56:42 -0600ec7f7e65d116a8c30f6a6d2a6cbec61ec4d8b244Remove blank line in order to resolveeditrun_scripts/run_scam.bashadvance_clubb_core_module.F90clubb_api_module.F901e234f56b4722f109ec9d657776244a94dadfc181640706464000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdating CLUBB to pass uprcp and vprcp into and out of advance_clubb_core. 2021-12-28 09:47:44 -06001e234f56b4722f109ec9d657776244a94dadfc18Updating CLUBB to pass uprcp and vprcp into and out of advance_clubb_core.editadvance_clubb_core_module.F90editclubb_api_module.F90advance_clubb_core_module.F90aa0da18281105ee85a148af1640952342bc058ec1640706663000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduNow that uprcp and vprcp have been passed through advance_clubb_core, I can get rid of this idiot-proofing code that stops the run when l_predict_upwp_vpwp is enabled and the PDF is in the "post" position. 2021-12-28 09:51:03 -0600aa0da18281105ee85a148af1640952342bc058ecNow that uprcp and vprcp have been passed through advance_clubb_core,editadvance_clubb_core_module.F90advance_clubb_core_module.F90advance_wp2_wp3_module.F90clubb_api_module.F90af8d23225e3393b52c07fbe123f01444d14124f01640825295000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am adding more arguments to the argument list for advance_clubb_core so that the model now runs with the PDF in the post position. Result from this change are still bit-for-bit. 2021-12-29 18:48:15 -0600af8d23225e3393b52c07fbe123f01444d14124f0I am adding more arguments to the argument list for advance_clubb_coreeditadvance_clubb_core_module.F90editclubb_api_module.F90editadvance_wp2_wp3_module.F90src/physics/cam/clubb_intr.F909b0a9c2e869a0a687ea291ace9d3371a3210e6421640861405000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am updating clubb_intr.F90 to account for new changes to the call to advance_clubb_core. 2021-12-30 04:50:05 -06009b0a9c2e869a0a687ea291ace9d3371a3210e642I am updating clubb_intr.F90 to account for new changes to the calleditsrc/physics/cam/clubb_intr.F90src/physics/cam/clubb_intr.F900805082d217c3a8009d33721b75ff43841c65a4a1640906256000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffinbmg2@uwm.eduFixed a goof. 2021-12-30 16:17:36 -07000805082d217c3a8009d33721b75ff43841c65a4aFixed a goof.editsrc/physics/cam/clubb_intr.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffingriffinbhttp://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreplyfalseBRANCHorigin/clubb_silhs_develTESTcam_scam_gfortran_testStarted by user pbroelspbroelspbroels2248289184281ea91bd170ad41282d0c54f31531b848289184281ea91bd170ad41282d0c54f31531b8refs/remotes/origin/flag_removal48289184281ea91bd170ad41282d0c54f31531b848289184281ea91bd170ad41282d0c54f31531b8refs/remotes/origin/flag_removal128d415ba99d560e60b641054bb34c77d3f22dd1fd8d415ba99d560e60b641054bb34c77d3f22dd1fdrefs/remotes/origin/stats_testing8d415ba99d560e60b641054bb34c77d3f22dd1fd8d415ba99d560e60b641054bb34c77d3f22dd1fdrefs/remotes/origin/stats_testing240c3aa442df83297eefc4464684781a5595e53b450c3aa442df83297eefc4464684781a5595e53b45refs/remotes/origin/l_vary_convect_depth_addition0c3aa442df83297eefc4464684781a5595e53b450c3aa442df83297eefc4464684781a5595e53b45refs/remotes/origin/l_vary_convect_depth_addition9d43073a5be7ffc3127a26c1398e691d75074d201d43073a5be7ffc3127a26c1398e691d75074d201refs/remotes/origin/changes_to_not_breakd43073a5be7ffc3127a26c1398e691d75074d201d43073a5be7ffc3127a26c1398e691d75074d201refs/remotes/origin/changes_to_not_break20ffa1ab054f2a61734d248d2f481b5a180291e4e0ffa1ab054f2a61734d248d2f481b5a180291e4e0refs/remotes/origin/stats_to_hostsffa1ab054f2a61734d248d2f481b5a180291e4e0ffa1ab054f2a61734d248d2f481b5a180291e4e0refs/remotes/origin/stats_to_hosts27f839568c86ee78f3d6f9cd46b517640041248cabf839568c86ee78f3d6f9cd46b517640041248cabrefs/remotes/origin/masterf839568c86ee78f3d6f9cd46b517640041248cabf839568c86ee78f3d6f9cd46b517640041248cabrefs/remotes/origin/master3754748fad84e1e694350da85f95535cc6c01ad11f54748fad84e1e694350da85f95535cc6c01ad11frefs/remotes/origin/clubb_silhs_devel54748fad84e1e694350da85f95535cc6c01ad11f54748fad84e1e694350da85f95535cc6c01ad11frefs/remotes/origin/clubb_silhs_devel54748fad84e1e694350da85f95535cc6c01ad11f54748fad84e1e694350da85f95535cc6c01ad11frefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#37614851928218branch_cam_test #3737false3712978SUCCESS1644272402538http://carson.math.uwm.edu/jenkins/view/all/job/branch_cam_test/37/model_flags.F90af2e320388670ca0a57e2f176c1bc5d627b9098d1641839832000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comInsert print about overwriting default flags with namelist values 2022-01-10 12:37:12 -0600af2e320388670ca0a57e2f176c1bc5d627b9098dInsert print about overwriting default flags with namelist valueseditmodel_flags.F90parameters_tunable.F908f225830ad630ade0b0f818521e3420cf71da15d1641840286000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comInsert print about overwriting default parameters with namelist values 2022-01-10 12:44:46 -06008f225830ad630ade0b0f818521e3420cf71da15dInsert print about overwriting default parameters with namelist valueseditparameters_tunable.F90src/physics/cam/clubb_intr.F909b67756c7029fdd2ade3029a55e2766aa857ba4c1641936421000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking call to setup_grid use new api version. larson-group/clubb#972 2022-01-11 15:27:01 -06009b67756c7029fdd2ade3029a55e2766aa857ba4cMaking call to setup_grid use new api version. larson-group/clubb#972editsrc/physics/cam/clubb_intr.F90clubb_api_module.F90f3942b808f629c080b43dfaca5c50c6ce080ef9a1641936564000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking api version of setup_grid. larson-group/clubb#972 2022-01-11 15:29:24 -0600f3942b808f629c080b43dfaca5c50c6ce080ef9aMaking api version of setup_grid. larson-group/clubb#972editclubb_api_module.F90src/physics/cam/clubb_intr.F900fd2fe6adde201caeb15329a43d45fd20752d8181641943209000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduBreaking up column loop some more. larson-group/clubb#972 2022-01-11 17:20:09 -06000fd2fe6adde201caeb15329a43d45fd20752d818Breaking up column loop some more. larson-group/clubb#972editsrc/physics/cam/clubb_intr.F90silhs_api_module.F903db947c8588aef8f34322cfdf19bc0b3e0e7be791642027821000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking some paramters_silhs variables available from the silhs api 2022-01-12 16:50:21 -06003db947c8588aef8f34322cfdf19bc0b3e0e7be79Making some paramters_silhs variables available from the silhs apieditsilhs_api_module.F90advance_clubb_core_module.F9065acb9b0c8906c6bd4001aa5eb2cb31b117608351642031683000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comComment out setting of fatal error when l_min_xp2_from_corr_wx = F and l_enable_relaxed_clipping = F. The goal is to allow the clubb_backwards_compatibility_gfortran_test Jenkins test to pass again. For #846. 2022-01-12 17:54:43 -060065acb9b0c8906c6bd4001aa5eb2cb31b11760835Comment out setting of fatal erroreditadvance_clubb_core_module.F90src/physics/cam/clubb_intr.F90302c3069435e837e84c86681aade287dbf294c731642034746000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduBig column loop is now gone entirely. Replaced by fast small loops. larson-group/clubb#972 2022-01-12 18:45:46 -0600302c3069435e837e84c86681aade287dbf294c73Big column loop is now gone entirely. Replaced by fast small loops. larson-group/clubb#972editsrc/physics/cam/clubb_intr.F90parameters_tunable.F907ec140fc6d8e5e40e4dd195f225d62cdaa8fbabe1642115849000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduThis should be BIT_CHANGING, but only because the value of Cx_min should change in the netcdf file. This will not be answer changing. 2022-01-13 17:17:29 -06007ec140fc6d8e5e40e4dd195f225d62cdaa8fbabeThis should be BIT_CHANGING, but only because the value of Cx_min should change in the netcdf file. This will not be answer changing.editparameters_tunable.F90parameters_tunable.F905bf9927ebb2fdd8006f9aee4380dd467515d2c061642119958000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduChanging the value of C_invrs_tau_shear from 0.02 to 0.15. This commit is BIT_CHANGING 2022-01-13 18:25:58 -06005bf9927ebb2fdd8006f9aee4380dd467515d2c06Changing the value of C_invrs_tau_shear from 0.02 to 0.15.editparameters_tunable.F90advance_clubb_core_module.F9004279f676a57a9710d4b60f0dafcd0c331a4f18e1642120044000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAvoiding stats call for variables that are not set when l_diag_Lscale_from_tau is not true. 2022-01-13 18:27:24 -060004279f676a57a9710d4b60f0dafcd0c331a4f18eAvoiding stats call for variables that are not set when l_diag_Lscale_from_tau is not true.editadvance_clubb_core_module.F90src/physics/cam/clubb_intr.F90e7450ff97e11a4ff45bd9edd21b75ec7cf43d70c1642197062000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdated cam to reflect the changes in the clubb driver api 2022-01-14 15:51:02 -0600e7450ff97e11a4ff45bd9edd21b75ec7cf43d70cUpdated cam to reflect the changes in the clubb driver apieditsrc/physics/cam/clubb_intr.F90parameters_tunable.F9003f14dd627f8df25c1e8c40b407a2c60b943f9721642203316000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAdjusting the value of C_invrs_tau_shear from 0.15 to 0.16 so that CLUBB (particularly the MC3E case) completes successfully for all compiler tests. You might say that this is BIT_CHANGING. 2022-01-14 17:35:16 -060003f14dd627f8df25c1e8c40b407a2c60b943f972Adjusting the value of C_invrs_tau_shear from 0.15 to 0.16 so thateditparameters_tunable.F90mixing_length.F90advance_clubb_core_module.F90model_flags.F90clubb_api_module.F90advance_helper_module.F90constants_clubb.F90d8836de198f0c3f3457f195fb08642497dead21b1642358928000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd l_smooth_Heaviside_tau_wpxp to smooth discontinuity in invrs_tau_wpxp_zm This option calls subroutine smooth_heaviside_peskin, which implements the smooth Peskin Heaviside function. The option is turned off for now, and so the results should remain bit for bit. For #965. 2022-01-16 12:48:48 -0600d8836de198f0c3f3457f195fb08642497dead21bAdd l_smooth_Heaviside_tau_wpxp to smooth discontinuity in invrs_tau_wpxp_zmeditmixing_length.F90editadvance_clubb_core_module.F90editadvance_helper_module.F90editmodel_flags.F90editconstants_clubb.F90editclubb_api_module.F90pdf_parameter_module.F90advance_clubb_core_module.F90clubb_api_module.F904d506fc219eb83b1977f318f6b46c3a1f75f09c51642541581000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing column loop into advance_clubb_core, and adding interface for it so that we will not need to update any host models. Everything is bit-for-bit, testing all standalone cases and our cam_coarse res run. larson-group/clubb#972 2022-01-18 15:33:01 -06004d506fc219eb83b1977f318f6b46c3a1f75f09c5Pushing column loop into advance_clubb_core, and adding interface for it so that we will not need to update any host models. Everything is bit-for-bit, testing all standalone cases and our cam_coarse res run. larson-group/clubb#972editpdf_parameter_module.F90editclubb_api_module.F90editadvance_clubb_core_module.F90src/physics/cam/clubb_intr.F90193a0adcd7c4de940097e80d38a8cd909a64034c1642549709000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking cam use the multicolumn interface for advance_clubb_core. Everything bit-for-bit. larson-group/clubb#972 2022-01-18 17:48:29 -0600193a0adcd7c4de940097e80d38a8cd909a64034cMaking cam use the multicolumn interface for advance_clubb_core. Everything bit-for-bit. larson-group/clubb#972editsrc/physics/cam/clubb_intr.F90clubb_api_module.F90946ca541e9acab72c5dbd52b2df8651bfc0bfb761642618464000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding l_stats check around stats stuff. This fixes the crashing when stats is disabled. larson-group/clubb#972 2022-01-19 12:54:24 -0600946ca541e9acab72c5dbd52b2df8651bfc0bfb76Adding l_stats check around stats stuff. This fixes the crashing when stats is disabled. larson-group/clubb#972editclubb_api_module.F90clubb_api_module.F907e6744fa4864a0219f8e4a32d0d72fb2664598d91642631316000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking single and multi column versions of advance clubb core available through clubb_api. larson-group/clubb#972 2022-01-19 16:28:36 -06007e6744fa4864a0219f8e4a32d0d72fb2664598d9Making single and multi column versions of advance clubb core available through clubb_api. larson-group/clubb#972editclubb_api_module.F90advance_clubb_core_module.F900bae8e4aaa7651515c8d5df797909bd9de345c2f1642725231000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduBreaking up column loop in advance_clubb_core. larson-group/clubb#972 2022-01-20 18:33:51 -06000bae8e4aaa7651515c8d5df797909bd9de345c2fBreaking up column loop in advance_clubb_core. larson-group/clubb#972editadvance_clubb_core_module.F90advance_clubb_core_module.F90d55d2cbc2faec828838317f478b04fa8ea410f7a1642801850000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing loop into pdf_closure and breaking it up. larson-group/clubb#972 2022-01-21 15:50:50 -0600d55d2cbc2faec828838317f478b04fa8ea410f7aPushing loop into pdf_closure and breaking it up. larson-group/clubb#972editadvance_clubb_core_module.F90parameters_tunable.F90fabb386b09890bd8a64d59b5ae24bae937af9f931642810666000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI changed C_invrs_tau_N2_wp2 from 0.1 to 0.2 to help stop turbulence from going to the model top, which ultimately caused MC3E to crash by becoming too cold. Additionally, I set C_invrs_tau_shear back to 0.15 from 0.16. This commit is BIT_CHANGING. 2022-01-21 18:17:46 -0600fabb386b09890bd8a64d59b5ae24bae937af9f93I changed C_invrs_tau_N2_wp2 from 0.1 to 0.2 to help stop turbulenceeditparameters_tunable.F90advance_clubb_core_module.F90pdf_closure_module.F902c6b628542302815ac566410bfa583f64b2524641643072201000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing loop into pdf_closure_module and breaking it up. larson-group/clubb#972 2022-01-24 18:56:41 -06002c6b628542302815ac566410bfa583f64b252464Pushing loop into pdf_closure_module and breaking it up. larson-group/clubb#972editpdf_closure_module.F90editadvance_clubb_core_module.F90advance_clubb_core_module.F90pdf_closure_module.F90af9c183212dde92967cca80d87ef80f1aabd76b11643141070000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking the good version of pdf_params used most places. The bad version is the single column version. larson-group/clubb#972 2022-01-25 14:04:30 -0600af9c183212dde92967cca80d87ef80f1aabd76b1Making the good version of pdf_params used most places. The bad version is the single column version. larson-group/clubb#972editadvance_clubb_core_module.F90editpdf_closure_module.F90src/physics/cam/clubb_intr.F901c7f56ead0a5db7256f1d9a1061197884ef091521643148692000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRather than allocating pdf_params with pcols grid columns, we should use ncol. Which is what this commit does. We should do this same thing for all the other arrays too, but this change was required to move forward with our loop pushing. larson-group/clubb#972 2022-01-25 16:11:32 -06001c7f56ead0a5db7256f1d9a1061197884ef09152Rather than allocating pdf_params with pcols grid columns, we should use ncol. Which is what this commit does. We should do this same thing for all the other arrays too, but this change was required to move forward with our loop pushing. larson-group/clubb#972editsrc/physics/cam/clubb_intr.F90model_flags.F90c0b2297dad094c1121026e8520de001748c1d0a71643148928000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduMaking a commit that officially places the call to the PDF in the "post" position (meaning after CLUBB's predictive fields have been advanced). This commit is BIT_CHANGING 2022-01-25 16:15:28 -0600c0b2297dad094c1121026e8520de001748c1d0a7Making a commit that officially places the call to the PDF in the "post"editmodel_flags.F90advance_clubb_core_module.F90pdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F90f1c545226c133b42ec11c523daee00e938910cf31643158136000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing loops into all relevent lowest level routines in pdf_closure. larson-group/clubb#972 2022-01-25 18:48:56 -0600f1c545226c133b42ec11c523daee00e938910cf3Pushing loops into all relevent lowest level routines in pdf_closure. larson-group/clubb#972editadg1_adg2_3d_luhar_pdf.F90editpdf_closure_module.F90editadvance_clubb_core_module.F90pdf_closure_module.F9007b04afa6c644e22e0a920739ba49eab985c08821643158635000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduForgot an & symbol. 2022-01-25 18:57:15 -060007b04afa6c644e22e0a920739ba49eab985c0882Forgot an & symbol.editpdf_closure_module.F90advance_clubb_core_module.F90pdf_closure_module.F90376d0e4907dc788fce6a52b6d0dc5ad4d7481f341643238890000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduWe need to initialize our local pdf_implicit_coefs_terms_zm in certain pdf types. We also don't need to zero out pdf_implicit_coefs_terms arrays, since that's done in the initialization. This should fix segfaults when l_call_pdf_closure_twice=.True. larson-group/clubb#972 2022-01-26 17:14:50 -0600376d0e4907dc788fce6a52b6d0dc5ad4d7481f34We need to initialize our local pdf_implicit_coefs_terms_zm in certain pdf types. We also don't need to zero out pdf_implicit_coefs_terms arrays, since that's done in the initialization. This should fix segfaults when l_call_pdf_closure_twice=.True. larson-group/clubb#972editadvance_clubb_core_module.F90editpdf_closure_module.F90advance_clubb_core_module.F90clubb_api_module.F900201571e2624e4580ec5e4f44582e187d7908ebb1643342499000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am updating ice_supersat_frac to be an intent(inout) variable for advance_clubb_core. When the PDF is in the "post" position, there is a chance that it can be used before it is set unless it is preserved from timestep to timestep. 2022-01-27 22:01:39 -06000201571e2624e4580ec5e4f44582e187d7908ebbI am updating ice_supersat_frac to be an intent(inout) variable foreditclubb_api_module.F90editadvance_clubb_core_module.F90src/physics/cam/clubb_intr.F901a024c7a0be62e143aafbbdbdee1839194ad91671643396163000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking compatible with latest clubb change. 2022-01-28 12:56:03 -06001a024c7a0be62e143aafbbdbdee1839194ad9167Making compatible with latest clubb change.editsrc/physics/cam/clubb_intr.F90advance_clubb_core_module.F90aa44cb502926842665f158cbfab7c8cf1df5c3c51643406577000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduIntializing sigma_sqd_w_zt when not using ADG1. larson-group/clubb#972 2022-01-28 15:49:37 -0600aa44cb502926842665f158cbfab7c8cf1df5c3c5Intializing sigma_sqd_w_zt when not using ADG1. larson-group/clubb#972editadvance_clubb_core_module.F90src/physics/cam/clubb_intr.F90cba1a8b172fbc73f5e75e73ec504a30d8ef2ded31643407733000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduSetting up ice_supersat_frac to be saved from one timestep to the next for use in advance_clubb_core_api, including proper saving in restart files. 2022-01-28 16:08:53 -0600cba1a8b172fbc73f5e75e73ec504a30d8ef2ded3Setting up ice_supersat_frac to be saved from one timestep to the nexteditsrc/physics/cam/clubb_intr.F90pdf_parameter_module.F905088c109e589f0398450ea86996147836b8b75d81643411572000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bug, we were not initializng pdf_params for all columns. larson-group/clubb#972 2022-01-28 17:12:52 -06005088c109e589f0398450ea86996147836b8b75d8Fixing bug, we were not initializng pdf_params for all columns. larson-group/clubb#972editpdf_parameter_module.F90run_scripts/run_cesm_uwm_coarse_res_r8029_flags.shbld/namelist_files/namelist_definition.xmlsrc/physics/cam/subcol_SILHS.F90src/physics/cam/clubb_intr.F90b61128d4e0326a3eecbb69be5f6436513fcaa9dc1643670504000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduImproving config flag setup process and adding run script using r8029 flag set. larson-group/clubb#984 2022-01-31 17:08:24 -0600b61128d4e0326a3eecbb69be5f6436513fcaa9dcImproving config flag setup process and adding run script using r8029 flag set. larson-group/clubb#984addrun_scripts/run_cesm_uwm_coarse_res_r8029_flags.sheditbld/namelist_files/namelist_definition.xmleditsrc/physics/cam/clubb_intr.F90editsrc/physics/cam/subcol_SILHS.F90jenkins_tests/cam_coarse_res_r8029_flags_bin_diff_regression_gfortran_test/Jenkinsfilec74b49460cf50e9d572f594b23b59d4ba4a6c20c1643671999000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding nightly test script for the r8029 flag version of the coarse res run. larson-group/clubb#972 2022-01-31 17:33:19 -0600c74b49460cf50e9d572f594b23b59d4ba4a6c20cAdding nightly test script for the r8029 flag version of the coarse res run. larson-group/clubb#972addjenkins_tests/cam_coarse_res_r8029_flags_bin_diff_regression_gfortran_test/Jenkinsfilejenkins_tests/cam_coarse_res_bin_diff_regression_gfortran_test/Jenkinsfiled06eb5587a1e568b9f335d5d63541e16376dc0ff1643672959000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduUpdating scripts 2022-01-31 17:49:19 -0600d06eb5587a1e568b9f335d5d63541e16376dc0ffUpdating scriptseditjenkins_tests/cam_coarse_res_bin_diff_regression_gfortran_test/Jenkinsfilejenkins_tests/cam_coarse_res_r8029_flags_bin_diff_regression_gfortran_test/Jenkinsfilejenkins_tests/cam_coarse_res_bin_diff_regression_gfortran_test/Jenkinsfileabdea2ab94da931d73eb5701e5a7e158a82240ff1643673736000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing scripts, I updated the wrong one. 2022-01-31 18:02:16 -0600abdea2ab94da931d73eb5701e5a7e158a82240ffFixing scripts, I updated the wrong one.editjenkins_tests/cam_coarse_res_bin_diff_regression_gfortran_test/Jenkinsfileeditjenkins_tests/cam_coarse_res_r8029_flags_bin_diff_regression_gfortran_test/Jenkinsfileadvance_clubb_core_module.F90grid_class.F90f1154aed2f15410ec35a99adb03d2d517f9fad2d1643747310000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing column index into zm2zt and zt2zm. larson-group/clubb#972 2022-02-01 14:28:30 -0600f1154aed2f15410ec35a99adb03d2d517f9fad2dPushing column index into zm2zt and zt2zm. larson-group/clubb#972editadvance_clubb_core_module.F90editgrid_class.F90advance_clubb_core_module.F90Skx_module.F90932c80e272c18da1ccf51719eed39b370ca459121643751025000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing column index into Skx_func and making it a subroutine. larson-group/clubb#972 2022-02-01 15:30:25 -0600932c80e272c18da1ccf51719eed39b370ca45912Pushing column index into Skx_func and making it a subroutine. larson-group/clubb#972editadvance_clubb_core_module.F90editSkx_module.F90sigma_sqd_w_module.F90advance_clubb_core_module.F90grid_class.F90advance_helper_module.F90a3665dbc5e18abd7e8281d753abed2bbb03d8f1c1643762869000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduA variety of small loop pushing. larson-group/clubb#972 2022-02-01 18:47:49 -0600a3665dbc5e18abd7e8281d753abed2bbb03d8f1cA variety of small loop pushing. larson-group/clubb#972editadvance_clubb_core_module.F90editadvance_helper_module.F90editgrid_class.F90editsigma_sqd_w_module.F90sigma_sqd_w_module.F907f7db11cab062c725e5fe2787d45f0225e4ba60f1643831947000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixed small bug that slipped through because the G_unit tests use nz=1. 2022-02-02 13:59:07 -06007f7db11cab062c725e5fe2787d45f0225e4ba60fFixed small bug that slipped through because the G_unit tests use nz=1.editsigma_sqd_w_module.F90advance_clubb_core_module.F90mixing_length.F90advance_helper_module.F903c97bd65f2133f211f2d8502473f2cf32a025be11643840875000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing column index into mixing length routines, not all the way down for the non-tau based calculation. larson-group/clubb#972 2022-02-02 16:27:55 -06003c97bd65f2133f211f2d8502473f2cf32a025be1Pushing column index into mixing length routines, not all the way down for the non-tau based calculation. larson-group/clubb#972editadvance_clubb_core_module.F90editmixing_length.F90editadvance_helper_module.F90pdf_parameter_module.F90df7da80153115bfa7df377decb342e4aee4481cf1643927836000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added a subroutine that prints that values of all PDF parameters in type pdf_parameter, which is a useful debugging tool. 2022-02-03 16:37:16 -0600df7da80153115bfa7df377decb342e4aee4481cfI added a subroutine that prints that values of all PDF parameters ineditpdf_parameter_module.F90advance_clubb_core_module.F90Skx_module.F90445f590cf1d278eee326fe3a3355fdc0deab0d211643933733000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSmall changes and a loop push. larson-group/clubb#972 2022-02-03 18:15:33 -0600445f590cf1d278eee326fe3a3355fdc0deab0d21Small changes and a loop push. larson-group/clubb#972editSkx_module.F90editadvance_clubb_core_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90c9f575df03cc82bf9e0783bd2608ef27d0b4b6371643933733000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing loop into advance_xm_wpxp. larson-group/clubb#972 2022-02-03 18:15:33 -0600c9f575df03cc82bf9e0783bd2608ef27d0b4b637Pushing loop into advance_xm_wpxp. larson-group/clubb#972editadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90sigma_sqd_w_module.F90eb106afc75f2daab341edd31b7508557525f6fb21643933733000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking the G_unit test use a dummy column index. This makes it so we don't need an interface for compute_sigma_sqd_w since now we only use it with 2 dimensions. This is just nicer. larson-group/clubb#972 2022-02-03 18:15:33 -0600eb106afc75f2daab341edd31b7508557525f6fb2Making the G_unit test use a dummy column index. This makes it so we don't need an interface for compute_sigma_sqd_w since now we only use it with 2 dimensions. This is just nicer. larson-group/clubb#972editsigma_sqd_w_module.F90advance_xm_wpxp_module.F90bcda3f8c752053316304a5ce21d56977f49c53b41644004220000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduBreaking up column loop in advance_xm_wpxp_module. larson-group/clubb#972 2022-02-04 13:50:20 -0600bcda3f8c752053316304a5ce21d56977f49c53b4Breaking up column loop in advance_xm_wpxp_module. larson-group/clubb#972editadvance_xm_wpxp_module.F90advance_xm_wpxp_module.F90mono_flux_limiter.F900a7b2cda84e35cf4f34a3a582daf8b67a6a621941644016923000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing column loop into local functions. larson-group/clubb#972 2022-02-04 17:22:03 -06000a7b2cda84e35cf4f34a3a582daf8b67a6a62194Pushing column loop into local functions. larson-group/clubb#972editadvance_xm_wpxp_module.F90editmono_flux_limiter.F90jenkins_tests/cam_scam_gfortran_test/Jenkinsfilejenkins_tests/cam_global_regression_gfortran_test/Jenkinsfilecfc2f8f83323478ae5b63a48655731e0aea28cf31644270939000http://carson.math.uwm.edu/jenkins/user/pbroelspbroelspbroels@uwm.eduAdding in functionality for displaying log output into post step. 2022-02-07 15:55:39 -0600cfc2f8f83323478ae5b63a48655731e0aea28cf3Adding in functionality for displaying log output into post step.editjenkins_tests/cam_scam_gfortran_test/Jenkinsfileeditjenkins_tests/cam_global_regression_gfortran_test/Jenkinsfilejenkins_tests/cam_scam_gfortran_test/Jenkinsfilejenkins_tests/cam_global_regression_gfortran_test/Jenkinsfile54748fad84e1e694350da85f95535cc6c01ad11f1644272330000http://carson.math.uwm.edu/jenkins/user/pbroelspbroelspbroels@uwm.eduFixing whitespace issues with the jenkinsfile changes. 2022-02-07 16:18:50 -060054748fad84e1e694350da85f95535cc6c01ad11fFixing whitespace issues with the jenkinsfile changes.editjenkins_tests/cam_scam_gfortran_test/Jenkinsfileeditjenkins_tests/cam_global_regression_gfortran_test/Jenkinsfilegithttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhttp://carson.math.uwm.edu/jenkins/user/pbroelspbroelsfalse38http://carson.math.uwm.edu/jenkins/view/all/job/branch_cam_test/38/36http://carson.math.uwm.edu/jenkins/view/all/job/branch_cam_test/36/BRANCHorigin/clubb_silhs_develTESTcam_scam_gfortran_testStarted by user pbroelspbroelspbroels2248289184281ea91bd170ad41282d0c54f31531b848289184281ea91bd170ad41282d0c54f31531b8refs/remotes/origin/flag_removal48289184281ea91bd170ad41282d0c54f31531b848289184281ea91bd170ad41282d0c54f31531b8refs/remotes/origin/flag_removal128d415ba99d560e60b641054bb34c77d3f22dd1fd8d415ba99d560e60b641054bb34c77d3f22dd1fdrefs/remotes/origin/stats_testing8d415ba99d560e60b641054bb34c77d3f22dd1fd8d415ba99d560e60b641054bb34c77d3f22dd1fdrefs/remotes/origin/stats_testing240c3aa442df83297eefc4464684781a5595e53b450c3aa442df83297eefc4464684781a5595e53b45refs/remotes/origin/l_vary_convect_depth_addition0c3aa442df83297eefc4464684781a5595e53b450c3aa442df83297eefc4464684781a5595e53b45refs/remotes/origin/l_vary_convect_depth_addition9d43073a5be7ffc3127a26c1398e691d75074d201d43073a5be7ffc3127a26c1398e691d75074d201refs/remotes/origin/changes_to_not_breakd43073a5be7ffc3127a26c1398e691d75074d201d43073a5be7ffc3127a26c1398e691d75074d201refs/remotes/origin/changes_to_not_break20ffa1ab054f2a61734d248d2f481b5a180291e4e0ffa1ab054f2a61734d248d2f481b5a180291e4e0refs/remotes/origin/stats_to_hostsffa1ab054f2a61734d248d2f481b5a180291e4e0ffa1ab054f2a61734d248d2f481b5a180291e4e0refs/remotes/origin/stats_to_hosts27f839568c86ee78f3d6f9cd46b517640041248cabf839568c86ee78f3d6f9cd46b517640041248cabrefs/remotes/origin/masterf839568c86ee78f3d6f9cd46b517640041248cabf839568c86ee78f3d6f9cd46b517640041248cabrefs/remotes/origin/master3545c07c927222e38de62dfe513875a416652866cc45c07c927222e38de62dfe513875a416652866ccrefs/remotes/origin/clubb_silhs_devel45c07c927222e38de62dfe513875a416652866cc45c07c927222e38de62dfe513875a416652866ccrefs/remotes/origin/clubb_silhs_devel45c07c927222e38de62dfe513875a416652866cc45c07c927222e38de62dfe513875a416652866ccrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#35229533928218branch_cam_test #3535false3511081FAILURE1640119355514http://carson.math.uwm.edu/jenkins/view/all/job/branch_cam_test/35/advance_clubb_core_module.F90advance_windm_edsclrm_module.F90advance_xm_wpxp_module.F90fe10a3988ec9c5ae38f9a6521364e5114303dc971639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comThese changes allow you to call the 4 clubb "advance" subroutines in any order that you want to try. In the default order (where the order is the same as found in the current version of the CLUBB master), results are bit-for-bit when compared to CLUBB master. 2021-12-17 17:36:25 -0600fe10a3988ec9c5ae38f9a6521364e5114303dc97These changes allow you to call the 4 clubb "advance" subroutines in anyeditadvance_windm_edsclrm_module.F90editadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90advance_clubb_core_module.F90da7e393336c65553c3897fdb66f276cc70ba5a581639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comPlacing the order variables in a nice, convenient place for testing use. 2021-12-17 17:36:25 -0600da7e393336c65553c3897fdb66f276cc70ba5a58Placing the order variables in a nice, convenient place for testing use.editadvance_clubb_core_module.F90advance_clubb_core_module.F908aae767c4fcc474647d6b76867a06416de8057bd1639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comI reordered advance_clubb_core so that the "Advance xp3" (which is a basic calculation of xp3 by the ansatz by default) section is moved out of the way of the "advance loop" to a point that is after advance_windm_edsclrm (or whatever will be called last in the advance loop. This change does not alter the default results. Everything is still bit-for-bit. 2021-12-17 17:36:25 -06008aae767c4fcc474647d6b76867a06416de8057bdI reordered advance_clubb_core so that the "Advance xp3" (which is aeditadvance_clubb_core_module.F90advance_clubb_core_module.F90clubb_api_module.F90advance_xm_wpxp_module.F9089ceef8b3be53379b14beba84d90cef1f9ec9a391639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comI am committing the idiot-proofing code that forces l_min_xp2_from_corr_wx and l_enable_relaxed_clipping to have opposite values (one must be true and the other must be false). In this commit, both are set to true, so the code will produce an exception. 2021-12-17 17:36:25 -060089ceef8b3be53379b14beba84d90cef1f9ec9a39I am committing the idiot-proofing code that forces l_min_xp2_from_corr_wxeditclubb_api_module.F90editadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90advance_clubb_core_module.F9051776de85578ab39a37d41b3a28771e66d58657f1639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comI am indenting the portion of the code where the advance subroutines are located within the new ordering loop. 2021-12-17 17:36:25 -060051776de85578ab39a37d41b3a28771e66d58657fI am indenting the portion of the code where the advance subroutineseditadvance_clubb_core_module.F90advance_clubb_core_module.F909ffac7f447029ffd2f8bac3d59fb93019127171e1639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comTemporarily commenting out the idiot proofing in order to run some tests ... The results from this branch are still bit-for-bit with the master branch. 2021-12-17 17:36:25 -06009ffac7f447029ffd2f8bac3d59fb93019127171eTemporarily commenting out the idiot proofing in order to run some tests ...editadvance_clubb_core_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90c587754da66182880513b7c16ccc23c289952ab51639784501000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduNow official reinstating the idiot-proofing and turning off the l_enable_relaxed_clipping flag. This commit is BIT_CHANGING 2021-12-17 17:41:41 -0600c587754da66182880513b7c16ccc23c289952ab5Now official reinstating the idiot-proofing and turning off theeditadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90advance_clubb_core_module.F90b778226f990c7e852735312d0123c76452338a211639787077000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am committing some idiot proofing in regards to the advance subroutines ordering. No index can have a value of less than 1, greater than 4, and no index can have the same value as any other index. Each adv routine order index must have a unique value. 2021-12-17 18:24:37 -0600b778226f990c7e852735312d0123c76452338a21I am committing some idiot proofing in regards to the advanceeditadvance_clubb_core_module.F90src/physics/cam/clubb_intr.F9003b5534cf8ee3458340690cf5c15092844416d081639788020000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpgrading for the latest version of CLUBB. 2021-12-17 18:40:20 -060003b5534cf8ee3458340690cf5c15092844416d08Upgrading for the latest version of CLUBB.editsrc/physics/cam/clubb_intr.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffinfalse36http://carson.math.uwm.edu/jenkins/view/all/job/branch_cam_test/36/34http://carson.math.uwm.edu/jenkins/view/all/job/branch_cam_test/34/