BRANCHorigin/clubb_silhs_develTESTcam_scam_gfortran_testStarted by user pbroelspbroelspbroels2248289184281ea91bd170ad41282d0c54f31531b848289184281ea91bd170ad41282d0c54f31531b8refs/remotes/origin/flag_removal48289184281ea91bd170ad41282d0c54f31531b848289184281ea91bd170ad41282d0c54f31531b8refs/remotes/origin/flag_removal128d415ba99d560e60b641054bb34c77d3f22dd1fd8d415ba99d560e60b641054bb34c77d3f22dd1fdrefs/remotes/origin/stats_testing8d415ba99d560e60b641054bb34c77d3f22dd1fd8d415ba99d560e60b641054bb34c77d3f22dd1fdrefs/remotes/origin/stats_testing240c3aa442df83297eefc4464684781a5595e53b450c3aa442df83297eefc4464684781a5595e53b45refs/remotes/origin/l_vary_convect_depth_addition0c3aa442df83297eefc4464684781a5595e53b450c3aa442df83297eefc4464684781a5595e53b45refs/remotes/origin/l_vary_convect_depth_addition9d43073a5be7ffc3127a26c1398e691d75074d201d43073a5be7ffc3127a26c1398e691d75074d201refs/remotes/origin/changes_to_not_breakd43073a5be7ffc3127a26c1398e691d75074d201d43073a5be7ffc3127a26c1398e691d75074d201refs/remotes/origin/changes_to_not_break20ffa1ab054f2a61734d248d2f481b5a180291e4e0ffa1ab054f2a61734d248d2f481b5a180291e4e0refs/remotes/origin/stats_to_hostsffa1ab054f2a61734d248d2f481b5a180291e4e0ffa1ab054f2a61734d248d2f481b5a180291e4e0refs/remotes/origin/stats_to_hosts27f839568c86ee78f3d6f9cd46b517640041248cabf839568c86ee78f3d6f9cd46b517640041248cabrefs/remotes/origin/masterf839568c86ee78f3d6f9cd46b517640041248cabf839568c86ee78f3d6f9cd46b517640041248cabrefs/remotes/origin/master3545c07c927222e38de62dfe513875a416652866cc45c07c927222e38de62dfe513875a416652866ccrefs/remotes/origin/clubb_silhs_devel45c07c927222e38de62dfe513875a416652866cc45c07c927222e38de62dfe513875a416652866ccrefs/remotes/origin/clubb_silhs_devel45c07c927222e38de62dfe513875a416652866cc45c07c927222e38de62dfe513875a416652866ccrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/branch_cam_test/detail/branch_cam_test/35/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/branch_cam_test/detail/branch_cam_test/35/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/branch_cam_test/detail/branch_cam_test/35/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/branch_cam_test/detail/branch_cam_test/35/testsfalsefalse#35229533928218branch_cam_test #3535false3511081FAILURE1640119355514http://carson.math.uwm.edu/jenkins/view/all/job/branch_cam_test/35/advance_clubb_core_module.F90advance_windm_edsclrm_module.F90advance_xm_wpxp_module.F90fe10a3988ec9c5ae38f9a6521364e5114303dc971639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comThese changes allow you to call the 4 clubb "advance" subroutines in any order that you want to try. In the default order (where the order is the same as found in the current version of the CLUBB master), results are bit-for-bit when compared to CLUBB master. 2021-12-17 17:36:25 -0600fe10a3988ec9c5ae38f9a6521364e5114303dc97These changes allow you to call the 4 clubb "advance" subroutines in anyeditadvance_windm_edsclrm_module.F90editadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90advance_clubb_core_module.F90da7e393336c65553c3897fdb66f276cc70ba5a581639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comPlacing the order variables in a nice, convenient place for testing use. 2021-12-17 17:36:25 -0600da7e393336c65553c3897fdb66f276cc70ba5a58Placing the order variables in a nice, convenient place for testing use.editadvance_clubb_core_module.F90advance_clubb_core_module.F908aae767c4fcc474647d6b76867a06416de8057bd1639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comI reordered advance_clubb_core so that the "Advance xp3" (which is a basic calculation of xp3 by the ansatz by default) section is moved out of the way of the "advance loop" to a point that is after advance_windm_edsclrm (or whatever will be called last in the advance loop. This change does not alter the default results. Everything is still bit-for-bit. 2021-12-17 17:36:25 -06008aae767c4fcc474647d6b76867a06416de8057bdI reordered advance_clubb_core so that the "Advance xp3" (which is aeditadvance_clubb_core_module.F90advance_clubb_core_module.F90clubb_api_module.F90advance_xm_wpxp_module.F9089ceef8b3be53379b14beba84d90cef1f9ec9a391639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comI am committing the idiot-proofing code that forces l_min_xp2_from_corr_wx and l_enable_relaxed_clipping to have opposite values (one must be true and the other must be false). In this commit, both are set to true, so the code will produce an exception. 2021-12-17 17:36:25 -060089ceef8b3be53379b14beba84d90cef1f9ec9a39I am committing the idiot-proofing code that forces l_min_xp2_from_corr_wxeditclubb_api_module.F90editadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90advance_clubb_core_module.F9051776de85578ab39a37d41b3a28771e66d58657f1639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comI am indenting the portion of the code where the advance subroutines are located within the new ordering loop. 2021-12-17 17:36:25 -060051776de85578ab39a37d41b3a28771e66d58657fI am indenting the portion of the code where the advance subroutineseditadvance_clubb_core_module.F90advance_clubb_core_module.F909ffac7f447029ffd2f8bac3d59fb93019127171e1639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comTemporarily commenting out the idiot proofing in order to run some tests ... The results from this branch are still bit-for-bit with the master branch. 2021-12-17 17:36:25 -06009ffac7f447029ffd2f8bac3d59fb93019127171eTemporarily commenting out the idiot proofing in order to run some tests ...editadvance_clubb_core_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90c587754da66182880513b7c16ccc23c289952ab51639784501000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduNow official reinstating the idiot-proofing and turning off the l_enable_relaxed_clipping flag. This commit is BIT_CHANGING 2021-12-17 17:41:41 -0600c587754da66182880513b7c16ccc23c289952ab5Now official reinstating the idiot-proofing and turning off theeditadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90advance_clubb_core_module.F90b778226f990c7e852735312d0123c76452338a211639787077000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am committing some idiot proofing in regards to the advance subroutines ordering. No index can have a value of less than 1, greater than 4, and no index can have the same value as any other index. Each adv routine order index must have a unique value. 2021-12-17 18:24:37 -0600b778226f990c7e852735312d0123c76452338a21I am committing some idiot proofing in regards to the advanceeditadvance_clubb_core_module.F90src/physics/cam/clubb_intr.F9003b5534cf8ee3458340690cf5c15092844416d081639788020000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpgrading for the latest version of CLUBB. 2021-12-17 18:40:20 -060003b5534cf8ee3458340690cf5c15092844416d08Upgrading for the latest version of CLUBB.editsrc/physics/cam/clubb_intr.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2http://carson.math.uwm.edu/jenkins/user/griffinbBrian GriffingriffinbfalseBRANCHorigin/clubb_silhs_develTESTcam_scam_gfortran_testStarted by user Gunther HueblerhueblerGunther Huebler2248289184281ea91bd170ad41282d0c54f31531b848289184281ea91bd170ad41282d0c54f31531b8refs/remotes/origin/flag_removal48289184281ea91bd170ad41282d0c54f31531b848289184281ea91bd170ad41282d0c54f31531b8refs/remotes/origin/flag_removal128d415ba99d560e60b641054bb34c77d3f22dd1fd8d415ba99d560e60b641054bb34c77d3f22dd1fdrefs/remotes/origin/stats_testing8d415ba99d560e60b641054bb34c77d3f22dd1fd8d415ba99d560e60b641054bb34c77d3f22dd1fdrefs/remotes/origin/stats_testing240c3aa442df83297eefc4464684781a5595e53b450c3aa442df83297eefc4464684781a5595e53b45refs/remotes/origin/l_vary_convect_depth_addition0c3aa442df83297eefc4464684781a5595e53b450c3aa442df83297eefc4464684781a5595e53b45refs/remotes/origin/l_vary_convect_depth_addition9d43073a5be7ffc3127a26c1398e691d75074d201d43073a5be7ffc3127a26c1398e691d75074d201refs/remotes/origin/changes_to_not_breakd43073a5be7ffc3127a26c1398e691d75074d201d43073a5be7ffc3127a26c1398e691d75074d201refs/remotes/origin/changes_to_not_break20ffa1ab054f2a61734d248d2f481b5a180291e4e0ffa1ab054f2a61734d248d2f481b5a180291e4e0refs/remotes/origin/stats_to_hostsffa1ab054f2a61734d248d2f481b5a180291e4e0ffa1ab054f2a61734d248d2f481b5a180291e4e0refs/remotes/origin/stats_to_hosts27f839568c86ee78f3d6f9cd46b517640041248cabf839568c86ee78f3d6f9cd46b517640041248cabrefs/remotes/origin/masterf839568c86ee78f3d6f9cd46b517640041248cabf839568c86ee78f3d6f9cd46b517640041248cabrefs/remotes/origin/master360805082d217c3a8009d33721b75ff43841c65a4a0805082d217c3a8009d33721b75ff43841c65a4arefs/remotes/origin/clubb_silhs_devel0805082d217c3a8009d33721b75ff43841c65a4a0805082d217c3a8009d33721b75ff43841c65a4arefs/remotes/origin/clubb_silhs_devel0805082d217c3a8009d33721b75ff43841c65a4a0805082d217c3a8009d33721b75ff43841c65a4arefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#36548730928218branch_cam_test #3636false3611417SUCCESS1641850528081http://carson.math.uwm.edu/jenkins/view/all/job/branch_cam_test/36/bld/namelist_files/namelist_defaults_cam.xml3e914cd46fbdbe4b2f76d36a49d99647dbd14b6f1640214591000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comSet `clubb_l_min_xp2_from_corr_wx = T` and also set `clubb_l_min_wp2_from_corr_wx = T`. These are the correct settings when `enable_relaxed_clipping = F`. This code change is BIT_CHANGING. For larson-group/clubb#846. 2021-12-22 17:09:51 -06003e914cd46fbdbe4b2f76d36a49d99647dbd14b6fSet `clubb_l_min_xp2_from_corr_wx = T`editbld/namelist_files/namelist_defaults_cam.xmlrun_scripts/run_scam.bashec7f7e65d116a8c30f6a6d2a6cbec61ec4d8b2441640645802000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemove blank line in order to resolve cam_coarse_res_bin_diff_regression_gfortran_test in Jenkins. CAM was stopping because some idiot-proofing was blocking the former flag settings, namely, `clubb_l_min_xp2_from_corr_wx = F`, `clubb_l_min_wp2_from_corr_wx = F`. These values are now blocked when `enable_relaxed_clipping = F`. RESOLVED:45c07c927222e38de62dfe513875a416652866cc RESOLVED:03b5534cf8ee3458340690cf5c15092844416d08 For larson-group/clubb#846. 2021-12-27 16:56:42 -0600ec7f7e65d116a8c30f6a6d2a6cbec61ec4d8b244Remove blank line in order to resolveeditrun_scripts/run_scam.bashadvance_clubb_core_module.F90clubb_api_module.F901e234f56b4722f109ec9d657776244a94dadfc181640706464000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdating CLUBB to pass uprcp and vprcp into and out of advance_clubb_core. 2021-12-28 09:47:44 -06001e234f56b4722f109ec9d657776244a94dadfc18Updating CLUBB to pass uprcp and vprcp into and out of advance_clubb_core.editadvance_clubb_core_module.F90editclubb_api_module.F90advance_clubb_core_module.F90aa0da18281105ee85a148af1640952342bc058ec1640706663000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduNow that uprcp and vprcp have been passed through advance_clubb_core, I can get rid of this idiot-proofing code that stops the run when l_predict_upwp_vpwp is enabled and the PDF is in the "post" position. 2021-12-28 09:51:03 -0600aa0da18281105ee85a148af1640952342bc058ecNow that uprcp and vprcp have been passed through advance_clubb_core,editadvance_clubb_core_module.F90advance_clubb_core_module.F90advance_wp2_wp3_module.F90clubb_api_module.F90af8d23225e3393b52c07fbe123f01444d14124f01640825295000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am adding more arguments to the argument list for advance_clubb_core so that the model now runs with the PDF in the post position. Result from this change are still bit-for-bit. 2021-12-29 18:48:15 -0600af8d23225e3393b52c07fbe123f01444d14124f0I am adding more arguments to the argument list for advance_clubb_coreeditadvance_clubb_core_module.F90editclubb_api_module.F90editadvance_wp2_wp3_module.F90src/physics/cam/clubb_intr.F909b0a9c2e869a0a687ea291ace9d3371a3210e6421640861405000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am updating clubb_intr.F90 to account for new changes to the call to advance_clubb_core. 2021-12-30 04:50:05 -06009b0a9c2e869a0a687ea291ace9d3371a3210e642I am updating clubb_intr.F90 to account for new changes to the calleditsrc/physics/cam/clubb_intr.F90src/physics/cam/clubb_intr.F900805082d217c3a8009d33721b75ff43841c65a4a1640906256000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffinbmg2@uwm.eduFixed a goof. 2021-12-30 16:17:36 -07000805082d217c3a8009d33721b75ff43841c65a4aFixed a goof.editsrc/physics/cam/clubb_intr.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffinhttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse37http://carson.math.uwm.edu/jenkins/view/all/job/branch_cam_test/37/35http://carson.math.uwm.edu/jenkins/view/all/job/branch_cam_test/35/BRANCHorigin/clubb_silhs_develTESTcam_global_regression_gfortran_testStarted by user pbroelspbroelspbroels2248289184281ea91bd170ad41282d0c54f31531b848289184281ea91bd170ad41282d0c54f31531b8refs/remotes/origin/flag_removal48289184281ea91bd170ad41282d0c54f31531b848289184281ea91bd170ad41282d0c54f31531b8refs/remotes/origin/flag_removal128d415ba99d560e60b641054bb34c77d3f22dd1fd8d415ba99d560e60b641054bb34c77d3f22dd1fdrefs/remotes/origin/stats_testing8d415ba99d560e60b641054bb34c77d3f22dd1fd8d415ba99d560e60b641054bb34c77d3f22dd1fdrefs/remotes/origin/stats_testing240c3aa442df83297eefc4464684781a5595e53b450c3aa442df83297eefc4464684781a5595e53b45refs/remotes/origin/l_vary_convect_depth_addition0c3aa442df83297eefc4464684781a5595e53b450c3aa442df83297eefc4464684781a5595e53b45refs/remotes/origin/l_vary_convect_depth_addition9d43073a5be7ffc3127a26c1398e691d75074d201d43073a5be7ffc3127a26c1398e691d75074d201refs/remotes/origin/changes_to_not_breakd43073a5be7ffc3127a26c1398e691d75074d201d43073a5be7ffc3127a26c1398e691d75074d201refs/remotes/origin/changes_to_not_break20ffa1ab054f2a61734d248d2f481b5a180291e4e0ffa1ab054f2a61734d248d2f481b5a180291e4e0refs/remotes/origin/stats_to_hostsffa1ab054f2a61734d248d2f481b5a180291e4e0ffa1ab054f2a61734d248d2f481b5a180291e4e0refs/remotes/origin/stats_to_hosts27f839568c86ee78f3d6f9cd46b517640041248cabf839568c86ee78f3d6f9cd46b517640041248cabrefs/remotes/origin/masterf839568c86ee78f3d6f9cd46b517640041248cabf839568c86ee78f3d6f9cd46b517640041248cabrefs/remotes/origin/master34e64b4cc834d0e033dd4353a13af3883980ea1396e64b4cc834d0e033dd4353a13af3883980ea1396refs/remotes/origin/clubb_silhs_devele64b4cc834d0e033dd4353a13af3883980ea1396e64b4cc834d0e033dd4353a13af3883980ea1396refs/remotes/origin/clubb_silhs_devele64b4cc834d0e033dd4353a13af3883980ea1396e64b4cc834d0e033dd4353a13af3883980ea1396refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#341278210928218branch_cam_test #3434false3410855SUCCESS1639610542708http://carson.math.uwm.edu/jenkins/view/all/job/branch_cam_test/34/false35http://carson.math.uwm.edu/jenkins/view/all/job/branch_cam_test/35/33http://carson.math.uwm.edu/jenkins/view/all/job/branch_cam_test/33/