BRANCHorigin/clubb_silhs_develTESTcam_global_regression_intel_testStarted by user pbroelspbroelspbroels2248289184281ea91bd170ad41282d0c54f31531b848289184281ea91bd170ad41282d0c54f31531b8refs/remotes/origin/flag_removal48289184281ea91bd170ad41282d0c54f31531b848289184281ea91bd170ad41282d0c54f31531b8refs/remotes/origin/flag_removal128d415ba99d560e60b641054bb34c77d3f22dd1fd8d415ba99d560e60b641054bb34c77d3f22dd1fdrefs/remotes/origin/stats_testing8d415ba99d560e60b641054bb34c77d3f22dd1fd8d415ba99d560e60b641054bb34c77d3f22dd1fdrefs/remotes/origin/stats_testing240c3aa442df83297eefc4464684781a5595e53b450c3aa442df83297eefc4464684781a5595e53b45refs/remotes/origin/l_vary_convect_depth_addition0c3aa442df83297eefc4464684781a5595e53b450c3aa442df83297eefc4464684781a5595e53b45refs/remotes/origin/l_vary_convect_depth_addition9d43073a5be7ffc3127a26c1398e691d75074d201d43073a5be7ffc3127a26c1398e691d75074d201refs/remotes/origin/changes_to_not_breakd43073a5be7ffc3127a26c1398e691d75074d201d43073a5be7ffc3127a26c1398e691d75074d201refs/remotes/origin/changes_to_not_break20ffa1ab054f2a61734d248d2f481b5a180291e4e0ffa1ab054f2a61734d248d2f481b5a180291e4e0refs/remotes/origin/stats_to_hostsffa1ab054f2a61734d248d2f481b5a180291e4e0ffa1ab054f2a61734d248d2f481b5a180291e4e0refs/remotes/origin/stats_to_hosts27f839568c86ee78f3d6f9cd46b517640041248cabf839568c86ee78f3d6f9cd46b517640041248cabrefs/remotes/origin/masterf839568c86ee78f3d6f9cd46b517640041248cabf839568c86ee78f3d6f9cd46b517640041248cabrefs/remotes/origin/master30e34157339067bc637318077e49783a832750ea5de34157339067bc637318077e49783a832750ea5drefs/remotes/origin/clubb_silhs_devele34157339067bc637318077e49783a832750ea5de34157339067bc637318077e49783a832750ea5drefs/remotes/origin/clubb_silhs_devele34157339067bc637318077e49783a832750ea5de34157339067bc637318077e49783a832750ea5drefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#306139928218branch_cam_test #3030false3010770FAILURE1638818173201http://carson.math.uwm.edu/jenkins/view/all/job/branch_cam_test/30/- advance_clubb_core_module.F90advance_xm_wpxp_module.F90clubb_api_module.F90ecf50b7dd71b99418e7b378199bec3f540f9ab8f1631318520000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have passed clubb_params down into advance_xm_wpxp_module.F90.
The results from this revision are an exact match to the results from
the previous revision for all cases.
2021-09-10 19:02:00 -0500ecf50b7dd71b99418e7b378199bec3f540f9ab8fI have passed clubb_params down into advance_xm_wpxp_module.F90.editadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90editclubb_api_module.F90
- pdf_closure_module.F9069a9f213c5189310355d117e82d7047829f4e5501632504823000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comSee ticket
#958
2021-09-24 12:33:43 -050069a9f213c5189310355d117e82d7047829f4e550See ticketeditpdf_closure_module.F90
- advance_wp2_wp3_module.F90advance_clubb_core_module.F90b33af07b27883cd48fed63d9fa1557d3b2d4464d1632791429000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have passed down CLUBB's tunable parameters into advance_wp2_wp3_module.F90.
The results in NetCDF output files from this revision are an exact match to the
results in NetCDF output files from the previous revision for all cases.
2021-09-27 20:10:29 -0500b33af07b27883cd48fed63d9fa1557d3b2d4464dI have passed down CLUBB's tunable parameters into advance_wp2_wp3_module.F90.editadvance_wp2_wp3_module.F90editadvance_clubb_core_module.F90
- stats_clubb_utilities.F90advance_clubb_core_module.F90pdf_closure_module.F90f743922fbd8e78ed86270101cb28dbcbb5f5c0f71633009731000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comadded some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to disk
2021-09-30 08:48:51 -0500f743922fbd8e78ed86270101cb28dbcbb5f5c0f7added some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to diskeditpdf_closure_module.F90editstats_clubb_utilities.F90editadvance_clubb_core_module.F90
- advance_xp2_xpyp_module.F900f9530e65dbeccc6103c09e4497072ffef4fbf361633124125000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comUpdates to separate out C4 and C14 in advance_xp2 module. This will make it easier to control which invrs_tau_* variable multiplies each term for example.
This commit is BIT_CHANGING owing to order of operations differences, but the pyplotgen output for most cases looks identical to the naked eye.
2021-10-01 16:35:25 -05000f9530e65dbeccc6103c09e4497072ffef4fbf36Updates to separate out C4 and C14 in advance_xp2 module. This will make it easier to control which invrs_tau_* variable multiplies each term for example.editadvance_xp2_xpyp_module.F90
- advance_xp2_xpyp_module.F904a3fe3288e95f3ff0042b328a2221113baa445a81633124125000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comChanging the name of dummy_1d variables for clarity.
2021-10-01 16:35:25 -05004a3fe3288e95f3ff0042b328a2221113baa445a8Changing the name of dummy_1d variables for clarity.editadvance_xp2_xpyp_module.F90
- advance_clubb_core_module.F90advance_xp2_xpyp_module.F90724a970d8e0b0977d63512e25c4462d2600392901633127377000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI passed down CLUBB's tunable parameters into advance_xp2_xpyp_module.F90
for most parameters, excluding C4 and C14. Results are unchanged.
2021-10-01 17:29:37 -0500724a970d8e0b0977d63512e25c4462d260039290I passed down CLUBB's tunable parameters into advance_xp2_xpyp_module.F90editadvance_xp2_xpyp_module.F90editadvance_clubb_core_module.F90
- advance_clubb_core_module.F90860a184b28c1e3889801dfc39a1c96768fd870461633359161000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd a blank line to trigger nightly tests.
2021-10-04 09:52:41 -0500860a184b28c1e3889801dfc39a1c96768fd87046Add a blank line to trigger nightly tests.editadvance_clubb_core_module.F90
- advance_clubb_core_module.F90advance_xp2_xpyp_module.F90pdf_closure_module.F909ac836f8b76e39e820b5fecaae969f70a7b39c211633470307000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing down more of CLUBB's tunable parameters.
2021-10-05 16:45:07 -05009ac836f8b76e39e820b5fecaae969f70a7b39c21Passing down more of CLUBB's tunable parameters.editadvance_clubb_core_module.F90editadvance_xp2_xpyp_module.F90editpdf_closure_module.F90
- advance_clubb_core_module.F907b950575ac2c00c63de42c11f33c459e649af0281633470537000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI accidentally removed an important comment in the previous commit.
2021-10-05 16:48:57 -05007b950575ac2c00c63de42c11f33c459e649af028I accidentally removed an important comment in the previous commit.editadvance_clubb_core_module.F90
- advance_clubb_core_module.F90advance_xm_wpxp_module.F90advance_helper_module.F90835d3d3155f98b2a9b6ba60cb9fa02a94fb7800b1633637871000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing down more CLUBB tunable parameters.
Everything is bit-for-bit.
2021-10-07 15:17:51 -0500835d3d3155f98b2a9b6ba60cb9fa02a94fb7800bPassing down more CLUBB tunable parameters.editadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90editadvance_helper_module.F90
- run_scripts/run_scam.bashdbd8ca423fe6c5bf69df15e3318cb25203007d741633646089000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduUpdating run_scam.bash to work with newest merge from cam_development. larson-group/cam#140
2021-10-07 17:34:49 -0500dbd8ca423fe6c5bf69df15e3318cb25203007d74Updating run_scam.bash to work with newest merge from cam_development. larson-group/cam#140editrun_scripts/run_scam.bash
- pdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F90b65e4cfa8ab2923db015ef2723e3e69071d2c83c1633728172000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduMore passing down CLUBB parameters ... whoop-de-doo
2021-10-08 16:22:52 -0500b65e4cfa8ab2923db015ef2723e3e69071d2c83cMore passing down CLUBB parameters ... whoop-de-dooeditadg1_adg2_3d_luhar_pdf.F90editpdf_closure_module.F90
- Skx_module.F90diagnose_correlations_module.F90advance_clubb_core_module.F90sfc_varnce_module.F90351cc9aa27aa212ef6cefb48b6c85ec601a993b01633732238000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing down more tunable parameters and removing references to
parameters_tunable. Results are bit-for-bit.
2021-10-08 17:30:38 -0500351cc9aa27aa212ef6cefb48b6c85ec601a993b0Passing down more tunable parameters and removing references toeditadvance_clubb_core_module.F90editdiagnose_correlations_module.F90editSkx_module.F90editsfc_varnce_module.F90
- advance_clubb_core_module.F903c883d2e41e77b89ea758961d5e11ac577a1fa821634055768000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemoving line to trigger the nightly tests for all repos.
2021-10-12 11:22:48 -05003c883d2e41e77b89ea758961d5e11ac577a1fa82Removing line to trigger the nightly tests for all repos.editadvance_clubb_core_module.F90
- jenkins_tests/cam_run_intel_test/Jenkinsfilejenkins_tests/cam_global_regression_gfortran_test/Jenkinsfilejenkins_tests/cam_scam_gfortran_test/Jenkinsfilejenkins_tests/cam_global_regression_intel_test/Jenkinsfile6c77ab0ca280a2122b7085edffb6412a7107164c1634056102000http://carson.math.uwm.edu/jenkins/user/pbroelspbroelsroelspbr@gmail.comChanging jenkinsfiles and thier diectory to reflect changes to test name. larson-group/sys_admin#735
2021-10-12 11:28:22 -05006c77ab0ca280a2122b7085edffb6412a7107164cChanging jenkinsfiles and thier diectory to reflect changes to test name. larson-group/sys_admin#735deletejenkins_tests/cam_global_regression_intel_test/Jenkinsfileaddjenkins_tests/cam_scam_gfortran_test/Jenkinsfileaddjenkins_tests/cam_global_regression_gfortran_test/Jenkinsfiledeletejenkins_tests/cam_run_intel_test/Jenkinsfile
- pdf_closure_module.F90stats_clubb_utilities.F90advance_clubb_core_module.F90stats_variables.F90model_flags.F90stats_zt_module.F9024ab4b2089583ab183efc1963c23fb3153fd20481634058263000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comSee respective messages on the issue 958 on date 10/12/2021
2021-10-12 12:04:23 -050024ab4b2089583ab183efc1963c23fb3153fd2048See respective messages on the issue 958 on date 10/12/2021editmodel_flags.F90editstats_clubb_utilities.F90editadvance_clubb_core_module.F90editpdf_closure_module.F90editstats_variables.F90editstats_zt_module.F90
- mixing_length.F90advance_clubb_core_module.F90parameters_tunable.F90clubb_api_module.F9040e87490f501202d6d95e7fd2c9c2ccab164ab731634087718000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduHandling the abomination that is lmin.
2021-10-12 20:15:18 -050040e87490f501202d6d95e7fd2c9c2ccab164ab73Handling the abomination that is lmin.editadvance_clubb_core_module.F90editclubb_api_module.F90editmixing_length.F90editparameters_tunable.F90
- diffusion.F90db7584133b87452bedc0538fed00f339dca49ae31634219703000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comCommented out the k=1 boundary conditions in diffusion_zm_lhs and diffusion_zt_lhs, since these are not currently fed into the final LHS matrix. I included comments to describe why this was done. Results are b4b.
See https://github.com/larson-group/clubb/issues/920#issuecomment-942735433.
2021-10-14 08:55:03 -0500db7584133b87452bedc0538fed00f339dca49ae3Commented out the k=1 boundary conditions in diffusion_zm_lhs and diffusion_zt_lhs, since these are not currently fed into the final LHS matrix. I included comments to describe why this was done. Results are b4b.editdiffusion.F90
- run_scripts/run_cesm_uwm.sh2938d8e0648a8673b15783ebfd608129ddff05a31634238686000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd a blank line in order to note that
this commit, BIT_CHANGING:dd911dca7243ed284b44685820389cca115266da, changed CAM's result because CLUBB-core changed.
The commits below were changed because the compiler version on nelson changed (larson-group/sys_admin#757)
RESOLVED:807d306af0fef7b246dfcafe46d0119b17b5a160
RESOLVED:dbd8ca423fe6c5bf69df15e3318cb25203007d74.
2021-10-14 14:11:26 -05002938d8e0648a8673b15783ebfd608129ddff05a3Add a blank line in order to note thateditrun_scripts/run_cesm_uwm.sh
- mixing_length.F90advance_clubb_core_module.F90c8cadb5e9708e898ac688db79e1da0ec0ff2ad291634254172000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing tunable parameters into the new tau code.
2021-10-14 18:29:32 -0500c8cadb5e9708e898ac688db79e1da0ec0ff2ad29Passing tunable parameters into the new tau code.editmixing_length.F90editadvance_clubb_core_module.F90
- advance_wp2_wp3_module.F90mixing_length.F90advance_clubb_core_module.F90clip_explicit.F90e6aa931ab2aa8134704c137db183ec06ee9dfcee1634768140000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassed down more parameters. Results are bit-for-bit.
2021-10-20 17:15:40 -0500e6aa931ab2aa8134704c137db183ec06ee9dfceePassed down more parameters. Results are bit-for-bit.editadvance_wp2_wp3_module.F90editclip_explicit.F90editmixing_length.F90editadvance_clubb_core_module.F90
- advance_clubb_core_module.F90parameters_model.F90d07f2f6c2df3af24ddc90862bc2a656bdd9015d51634771341000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing through more clubb parameters. Bit-for-bit
2021-10-20 18:09:01 -0500d07f2f6c2df3af24ddc90862bc2a656bdd9015d5Passing through more clubb parameters. Bit-for-biteditparameters_model.F90editadvance_clubb_core_module.F90
- precipitation_fraction.F90setup_clubb_pdf_params.F90clubb_api_module.F90704eedf20b71e552fe32df3633005d50af58c27f1634854899000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing down CLUBB's tunable parameters into the setup_pdf_parameters and
precipitation fraction portions of the code. Everything is bit-for-bit.
2021-10-21 17:21:39 -0500704eedf20b71e552fe32df3633005d50af58c27fPassing down CLUBB's tunable parameters into the setup_pdf_parameters andeditclubb_api_module.F90editsetup_clubb_pdf_params.F90editprecipitation_fraction.F90
- mixing_length.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90diffusion.F90model_flags.F90advance_xm_wpxp_module.F90advance_windm_edsclrm_module.F902ee6d2a1e31e43bca3e03a406917c4454cb71e671634935501000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comThese updates incorporate some of Shixuan Zhang's changes, including:
(1) upwind scheme for the eddy diffusion code, which Shixuan says does not make a huge difference; and
(2) l_smooth_heaviside_tau_wpxp flag in the mixing_length.F90 code, which is intended to give
smoother results.
Both of the flags for these changes are turned off, but these updates are BIT_CHANGING because
of some minor changes to the way that factors of rho_ds_* and invrs_rho_ds_* are handled going
into the diffusion.F90 subroutines. Most cases look identical in pyplotgen, but sensitive cases
like arm_97 and rico look slightly different.
These changes were originally in pull request #962, but because of conflicts with the master
branch code base that developed, they could not be rebased and merged, so I incorporated them
into this new commit.
2021-10-22 15:45:01 -05002ee6d2a1e31e43bca3e03a406917c4454cb71e67These updates incorporate some of Shixuan Zhang's changes, including:editdiffusion.F90editmixing_length.F90editadvance_wp2_wp3_module.F90editadvance_xm_wpxp_module.F90editmodel_flags.F90editadvance_xp2_xpyp_module.F90editadvance_windm_edsclrm_module.F90
- pdf_closure_module.F90advance_clubb_core_module.F90new_pdf_main.F90new_hybrid_pdf_main.F9062d364561a81e2b878f95a327df36a4ca4bc31491635207177000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing down CLUBB's tunable parameters into the remainder of the
PDF subroutines. Everything is bit-for-bit.
2021-10-25 19:12:57 -050062d364561a81e2b878f95a327df36a4ca4bc3149Passing down CLUBB's tunable parameters into the remainder of theeditadvance_clubb_core_module.F90editpdf_closure_module.F90editnew_pdf_main.F90editnew_hybrid_pdf_main.F90
- advance_clubb_core_module.F90clubb_api_module.F9040315247ab8dc38382642bf30f1d96b329c1304d1635210039000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI passed down the forgotten thlp2_rad_coef tunable parameter.
All bit-for-bit.
2021-10-25 20:00:39 -050040315247ab8dc38382642bf30f1d96b329c1304dI passed down the forgotten thlp2_rad_coef tunable parameter.editadvance_clubb_core_module.F90editclubb_api_module.F90
- diffusion.F9059c90454cd1a93522940f998c123795db4f23b171635271688000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comUncommenting diffusion.F90 k=1 lines again to fix Oracle uninit var test. I've updated the accompanying note to state clearly that the lines have no effect on model output, but I guess we need to keep the lines to avoid uninitialized variables.
2021-10-26 13:08:08 -050059c90454cd1a93522940f998c123795db4f23b17Uncommenting diffusion.F90 k=1 lines again to fix Oracle uninit var test. I've updated the accompanying note to state clearly that the lines have no effect on model output, but I guess we need to keep the lines to avoid uninitialized variables.editdiffusion.F90
- advance_xm_wpxp_module.F9024592ec9879d2c704c4d7301c8d18c794f2ff7441635291046000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am passing down the forgotten parameter, altitude threshold, in
advance_xm_wpxp_module.F90.
2021-10-26 18:30:46 -050024592ec9879d2c704c4d7301c8d18c794f2ff744I am passing down the forgotten parameter, altitude threshold, ineditadvance_xm_wpxp_module.F90
- src/physics/cam/clubb_intr.F90e3fae2814a1d0b2958afedec74d950f50b728d221635369212000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comUpdating for changes to CLUBB. See https://github.com/larson-group/clubb/pull/968.
2021-10-27 16:13:32 -0500e3fae2814a1d0b2958afedec74d950f50b728d22Updating for changes to CLUBB. See https://github.com/larson-group/clubb/pull/968.editsrc/physics/cam/clubb_intr.F90
- advance_wp2_wp3_module.F90advance_clubb_core_module.F90model_flags.F90clubb_api_module.F90bda6b42375dfc09907e7f9b37719b0d149f456711635369371000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding code wrapped in a flag (l_use_tke_in_K_dfsn) to use u_i'u_i' in the wp2 and wp3 eddy diffusion terms, instead of just wp2 or wp3. Relevant to CLUBB issue #920.
Results are b4b when the flag is turned off, which it currently is.
2021-10-27 16:16:11 -0500bda6b42375dfc09907e7f9b37719b0d149f45671Adding code wrapped in a flag (l_use_tke_in_K_dfsn) to use u_i'u_i' in the wp2 and wp3 eddy diffusion terms, instead of just wp2 or wp3. Relevant to CLUBB issue #920.editadvance_clubb_core_module.F90editmodel_flags.F90editclubb_api_module.F90editadvance_wp2_wp3_module.F90
- advance_wp2_wp3_module.F90advance_clubb_core_module.F90model_flags.F90clubb_api_module.F90fecf90bda798d6330f0c3982e5f24ef5dce274a31635369371000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comUpdates as requested to the l_use_tke_in_K_dfsn code:
- The name of the flag is changed to l_use_tke_in_wp2_wp3_K_dfsn
- Comments are added to the main pieces of code in advance_wp2_wp3
- The flag is added to the "compatible_r8029" configurable flags file.
See this comment https://github.com/larson-group/clubb/issues/920#issuecomment-931446401 and following for more information.
2021-10-27 16:16:11 -0500fecf90bda798d6330f0c3982e5f24ef5dce274a3Updates as requested to the l_use_tke_in_K_dfsn code:editmodel_flags.F90editadvance_wp2_wp3_module.F90editclubb_api_module.F90editadvance_clubb_core_module.F90
- output_netcdf.F90parameters_tunable.F90stats_clubb_utilities.F90clubb_api_module.F9048d34a44dac4e6c069b8edf7484da102a7b3e03c1635542624000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am committing the final stage of the "pass-down params" project.
The results are bit-for-bit identical.
2021-10-29 16:23:44 -050048d34a44dac4e6c069b8edf7484da102a7b3e03cI am committing the final stage of the "pass-down params" project.editclubb_api_module.F90editparameters_tunable.F90editoutput_netcdf.F90editstats_clubb_utilities.F90
- silhs_api_module.F90output_2D_samples_module.F90latin_hypercube_driver_module.F90a59d8a9d971fa58d96ca0c7c0e3a8999903394011635542624000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am committing the final stage of the "pass-down params" project.
The results are bit-for-bit identical.
2021-10-29 16:23:44 -0500a59d8a9d971fa58d96ca0c7c0e3a899990339401I am committing the final stage of the "pass-down params" project.editoutput_2D_samples_module.F90editsilhs_api_module.F90editlatin_hypercube_driver_module.F90
- advance_wp2_wp3_module.F90mixing_length.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90e21f33631a9962fc7af096d0f7c4a7a3f6ff021b1635542673000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding an option to use invrs_tau_N2_iso for C4 terms. The same invrs_tau had been used for C4 and C14 terms, so some adjustments had to be made to separate them out (this was started with an earlier commit: https://github.com/larson-group/clubb/commit/ef3be1b1378bcd1a447f3866c9f88f8cc4764233). The flag is currently set to false so results will be b4b.
See also the discussion here: https://github.com/larson-group/clubb/issues/920#issuecomment-920338746 and following comments.
2021-10-29 16:24:33 -0500e21f33631a9962fc7af096d0f7c4a7a3f6ff021bAdding an option to use invrs_tau_N2_iso for C4 terms. The same invrs_tau had been used for C4 and C14 terms, so some adjustments had to be made to separate them out (this was started with an earlier commit: https://github.com/larson-group/clubb/commit/ef3be1b1378bcd1a447f3866c9f88f8cc4764233). The flag is currently set to false so results will be b4b.editadvance_clubb_core_module.F90editadvance_wp2_wp3_module.F90editmixing_length.F90editadvance_xp2_xpyp_module.F90
- advance_wp2_wp3_module.F90575d6fe14ed80295cce4f30a51ff3d6aac83b5ee1635542673000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comRenaming invrs_tau_zt and invrs_tauw3t to "invrs_tau_wp3_zt" in advance_wp2_wp3 to avoid confusion. This variable is only used for the wp3 C8 term, so one consistent name is simpler, and the name "invrs_tau_zt" is already used by another variable in advance_clubb_core.
2021-10-29 16:24:33 -0500575d6fe14ed80295cce4f30a51ff3d6aac83b5eeRenaming invrs_tau_zt and invrs_tauw3t to "invrs_tau_wp3_zt" in advance_wp2_wp3 to avoid confusion. This variable is only used for the wp3 C8 term, so one consistent name is simpler, and the name "invrs_tau_zt" is already used by another variable in advance_clubb_core.editadvance_wp2_wp3_module.F90
- mixing_length.F90b1a5dc605454ba0bd6ce90b50c1b1c4e5238daa21635542673000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding comments for clarity.
2021-10-29 16:24:33 -0500b1a5dc605454ba0bd6ce90b50c1b1c4e5238daa2Adding comments for clarity.editmixing_length.F90
- clubb_api_module.F903cc2a48057cff47763a8de0fc7a9c2d6bd1717821635637985000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI forgot to add this necessary subroutine call to the clubb API.
2021-10-30 18:53:05 -05003cc2a48057cff47763a8de0fc7a9c2d6bd171782I forgot to add this necessary subroutine call to the clubb API.editclubb_api_module.F90
- src/physics/cam/clubb_intr.F90run_scripts/run_cesm_default_config.shsrc/physics/cam/subcol_SILHS.F908494265c8989baaa89a37406c625730c6ff9c6441635707111000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffinbmg2@uwm.eduI am updating CAM-CLUBB-SILHS (the clubb_silhs_devel) branch so
that it runs with the new version of CLUBB.
2021-10-31 13:05:11 -06008494265c8989baaa89a37406c625730c6ff9c644I am updating CAM-CLUBB-SILHS (the clubb_silhs_devel) branch soeditsrc/physics/cam/subcol_SILHS.F90editsrc/physics/cam/clubb_intr.F90editrun_scripts/run_cesm_default_config.sh
- advance_wp2_wp3_module.F9043b0e9b176c2c5f8d2537b61e1f1781a147878961635789347000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comFixing a minor accounting bug related to the changes in https://github.com/larson-group/clubb/commit/987d63de489d2baa09ad6e1538b2c6dbb7551690. There was some overcounting of the relevant terms.
Results are b4b since the l_use_tke_in_wp2_wp3_K_dfsn flag is false.
2021-11-01 12:55:47 -050043b0e9b176c2c5f8d2537b61e1f1781a14787896Fixing a minor accounting bug related to the changes in https://github.com/larson-group/clubb/commit/987d63de489d2baa09ad6e1538b2c6dbb7551690. There was some overcounting of the relevant terms.editadvance_wp2_wp3_module.F90
- src/physics/cam/subcol_SILHS.F902ee1e660d23872ebe9d786a8881a78b5a0d969f21636148384000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduFixing the SILHS code so that CAM-CLUBB-SILHS compiles and runs again.
2021-11-05 16:39:44 -05002ee1e660d23872ebe9d786a8881a78b5a0d969f2Fixing the SILHS code so that CAM-CLUBB-SILHS compiles and runs again.editsrc/physics/cam/subcol_SILHS.F90
- run_scripts/run_scam.bash7e76984d1df730b194fae2b35abae908ce2f235d1636149888000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd blank line to run_scam.bash in order to note that
a commit is BIT_CHANGING:44103d2962a0f9690a8b891e7203de6e04c38ebc because clubb_core changed
in this commit larson-group/clubb.git@95d7773f81117daff784b8ab91f4211c2edc8390 on 22 Oct 2021.
2021-11-05 17:04:48 -05007e76984d1df730b194fae2b35abae908ce2f235dAdd blank line to run_scam.bash in order to note thateditrun_scripts/run_scam.bash
- advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90diffusion.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90clubb_api_module.F90parameters_tunable.F90advance_windm_edsclrm_module.F900c99971894e34f471bb13a0608799da3e26fd75b1636150605000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have turned the nu_vert_res_dep family of variables into a derived
type and that variable is now being passed throughout the CLUBB code,
rather than accessing variables through a USE statement.
Everything is 100% bit-for-bit!
2021-11-05 17:16:45 -05000c99971894e34f471bb13a0608799da3e26fd75bI have turned the nu_vert_res_dep family of variables into a derivededitadvance_clubb_core_module.F90editadvance_wp2_wp3_module.F90editdiffusion.F90editadvance_xm_wpxp_module.F90editadvance_xp2_xpyp_module.F90editadvance_windm_edsclrm_module.F90editclubb_api_module.F90editparameters_tunable.F90
- src/physics/cam/clubb_intr.F90b02a38818dee2d02240dacc737d86df3e256ea3a1636153478000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am updating clubb_intr.F90 for the new version of CLUBB that
now passes the nu_vert_res_dep derived type variable.
2021-11-05 18:04:38 -0500b02a38818dee2d02240dacc737d86df3e256ea3aI am updating clubb_intr.F90 for the new version of CLUBB thateditsrc/physics/cam/clubb_intr.F90
- pdf_closure_module.F90stats_zt_module.F905aad62fb6b44998c8eeea4e274d53e9f5b6fda2a1636491816000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comAdded sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90
2021-11-09 15:03:36 -06005aad62fb6b44998c8eeea4e274d53e9f5b6fda2aAdded sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90editstats_zt_module.F90editpdf_closure_module.F90
- advance_clubb_core_module.F90model_flags.F90pdf_closure_module.F900918704e4ca667f2dd901df9481fcab6d04ad5591636651886000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comResolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details
2021-11-11 11:31:26 -06000918704e4ca667f2dd901df9481fcab6d04ad559Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for detailseditpdf_closure_module.F90editadvance_clubb_core_module.F90editmodel_flags.F90
- pdf_closure_module.F9081d326f9c04198f2635a6b56b25bc395da7414351636664054000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comIncluded a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge
2021-11-11 14:54:14 -060081d326f9c04198f2635a6b56b25bc395da741435Included a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after mergeeditpdf_closure_module.F90
- pdf_closure_module.F90dc3c4b8f58acb3383731109218706676f789be071636664205000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comfixed a typo in pdf_closure_module.f90, line 1284
2021-11-11 14:56:45 -0600dc3c4b8f58acb3383731109218706676f789be07fixed a typo in pdf_closure_module.f90, line 1284editpdf_closure_module.F90
- run_scripts/run_scam.bash10ee6f1aa978c9c3ca552a0a65e4e11d7a8637191636666035000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemove blank line from run_scam.bash
in order to trigger Jenkins test.
We think that the following "differences" are due to failures of compilation, although we didn't go back and re-run fixed versions to check for answer changes:
RESOLVED:2ee1e660d23872ebe9d786a8881a78b5a0d969f2
RESOLVED:b02a38818dee2d02240dacc737d86df3e256ea3a
RESOLVED:27325febfd0a9af7199815e835e48a429a153107
For larson-group/sys_admin#763
2021-11-11 15:27:15 -060010ee6f1aa978c9c3ca552a0a65e4e11d7a863719Remove blank line from run_scam.basheditrun_scripts/run_scam.bash
- pdf_closure_module.F903c5029210448e2a9df59b5757f5cd952d8ab41881636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comSee ticket
#958
2021-11-11 15:45:54 -06003c5029210448e2a9df59b5757f5cd952d8ab4188See ticketeditpdf_closure_module.F90
- stats_clubb_utilities.F90pdf_closure_module.F90a75256d61b53e5e09ec2e386790c89d4e51f04721636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comadded some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to disk
2021-11-11 15:45:54 -0600a75256d61b53e5e09ec2e386790c89d4e51f0472added some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to diskeditpdf_closure_module.F90editstats_clubb_utilities.F90
- pdf_closure_module.F90stats_variables.F90stats_clubb_utilities.F90advance_clubb_core_module.F90model_flags.F90stats_zt_module.F90a83e91f008656f68d7535574cd90be52d82dd50f1636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comSee respective messages on the issue 958 on date 10/12/2021
2021-11-11 15:45:54 -0600a83e91f008656f68d7535574cd90be52d82dd50fSee respective messages on the issue 958 on date 10/12/2021editstats_zt_module.F90editpdf_closure_module.F90editstats_variables.F90editstats_clubb_utilities.F90editmodel_flags.F90editadvance_clubb_core_module.F90
- pdf_closure_module.F90stats_zt_module.F900ba99cd44f06718d995fadd8eacb1b6b191c8cf51636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comAdded sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90
2021-11-11 15:45:54 -06000ba99cd44f06718d995fadd8eacb1b6b191c8cf5Added sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90editstats_zt_module.F90editpdf_closure_module.F90
- advance_clubb_core_module.F90model_flags.F90pdf_closure_module.F90f4f26820fd4d03cd818e862b342716e11ea0c6731636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comResolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details
2021-11-11 15:45:54 -0600f4f26820fd4d03cd818e862b342716e11ea0c673Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for detailseditpdf_closure_module.F90editadvance_clubb_core_module.F90editmodel_flags.F90
- pdf_closure_module.F902b90c415701478f497ef1b01769bff21fd75e46a1636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comIncluded a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge
2021-11-11 15:45:54 -06002b90c415701478f497ef1b01769bff21fd75e46aIncluded a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after mergeeditpdf_closure_module.F90
- pdf_closure_module.F90e235fe78eae6527a511973ecdc46aaa4cb2b23791636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comfixed a typo in pdf_closure_module.f90, line 1284
2021-11-11 15:45:54 -0600e235fe78eae6527a511973ecdc46aaa4cb2b2379fixed a typo in pdf_closure_module.f90, line 1284editpdf_closure_module.F90
- advance_clubb_core_module.F90clubb_api_module.F90a3f3633376a9a95a1ddbab690425c6b71a4efbff1637038777000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing w_up_in_cloud out of advance_clubb_core
2021-11-15 22:59:37 -0600a3f3633376a9a95a1ddbab690425c6b71a4efbffPassing w_up_in_cloud out of advance_clubb_coreeditclubb_api_module.F90editadvance_clubb_core_module.F90
- src/physics/cam/clubb_intr.F90da723f58873b1060def48ef6f322b73b8b446f951637051810000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdating cam for changes in the call to advance_clubb_core_api
2021-11-16 02:36:50 -0600da723f58873b1060def48ef6f322b73b8b446f95Updating cam for changes in the call to advance_clubb_core_apieditsrc/physics/cam/clubb_intr.F90
- stats_variables.F90e1572555370199b4fe0abf791462f1a0830a22f71638465215000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comfixed compiler warning regarding w_up_in_cloud
2021-12-02 11:13:35 -0600e1572555370199b4fe0abf791462f1a0830a22f7fixed compiler warning regarding w_up_in_cloudeditstats_variables.F90
- advance_clubb_core_module.F90fcf74be3a201e5043cabaad104cc37cdbb8c0e9d1638567586000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemove clipping from a3_coef.
In principle, removing the clipping should reduce noise.
In practice, it makes rico noiser but mpace_b less noisy.
It also allows twp_ice to run to completion with the gfortran compiler.
This commit is BIT_CHANGING.
For #965.
2021-12-03 15:39:46 -0600fcf74be3a201e5043cabaad104cc37cdbb8c0e9dRemove clipping from a3_coef.editadvance_clubb_core_module.F90
githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephenshttp://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrnhttp://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldhttp://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens82http://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffinhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhttp://carson.math.uwm.edu/jenkins/user/pbroelspbroelsfalse31http://carson.math.uwm.edu/jenkins/view/all/job/branch_cam_test/31/29http://carson.math.uwm.edu/jenkins/view/all/job/branch_cam_test/29/