Started by an SCM change8512407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master12407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master70b19b67713baf175f99baa0cb0bdde6e8c1fbc588b19b67713baf175f99baa0cb0bdde6e8c1fbc588origin/grid_fixesb19b67713baf175f99baa0cb0bdde6e8c1fbc588b19b67713baf175f99baa0cb0bdde6e8c1fbc588origin/grid_fixes64b928767c7238139d599dc55420d2a0956161726ab928767c7238139d599dc55420d2a0956161726aorigin/feeding_gr_to_hostb928767c7238139d599dc55420d2a0956161726ab928767c7238139d599dc55420d2a0956161726aorigin/feeding_gr_to_host4254b16d833e86ad23ef6ea81de67c38c596ebccd254b16d833e86ad23ef6ea81de67c38c596ebccd25refs/remotes/origin/master4b16d833e86ad23ef6ea81de67c38c596ebccd254b16d833e86ad23ef6ea81de67c38c596ebccd25refs/remotes/origin/master4b16d833e86ad23ef6ea81de67c38c596ebccd254b16d833e86ad23ef6ea81de67c38c596ebccd25refs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#42518923685812207721clubb_mac_gfortran_test #425425false42522015SUCCESS1680424689282http://carson.math.uwm.edu/jenkins/view/Production%20View/job/clubb_mac_gfortran_test/425/- src/CLUBB_core/matrix_solver_wrapper.F90src/CLUBB_core/lapack_wrap.F906d5d5f573f3866d5d66b028d829342026e5690991673472578000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comPushing column loop into lapack wrap.
2023-01-11 15:29:38 -06006d5d5f573f3866d5d66b028d829342026e569099Pushing column loop into lapack wrap.editsrc/CLUBB_core/matrix_solver_wrapper.F90editsrc/CLUBB_core/lapack_wrap.F90
- compile/config/linux_x86_64_nvhpc_casper.bashsrc/CLUBB_core/constants_clubb.F90src/CLUBB_core/model_flags.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/saturation.F9088b8239840f581d76610aa630dab6219d64d68be1673549655000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRestructuring and Porting of Compute_mixing_length subroutine(Phase 1) (#1052)
* Restructuring and Porting of Compute_mixing_length subroutine(Phase 1)
Restructure: The compute_mixing_length is one of the top most routine taking 35-50%
of the total time in a single timestep. The subroutine has been restructured to
push the i-loop further down to extract vectorization and parallelization.
The restructuring also involves introduction of sat_mixrat_liq_acc routines to
extract parallelism when called inside a OpenACC parallel region.
Porting: OpenACC directives are inserted to port the restructured compute_mixing_length
code on to the GPUs. This port is currently unoptimized and there is still room for improvement.
NOTE: Currently, l_sat_mixrat_lookup = false and saturation_formula = saturation_flatau
(Earthworks config options) case is supported on OpenACC build. Any other options works
on CPUs as usual. OpenACC declare create directives are inserted in model_flags and
constants_clubb, as these module variables are used inside the saturation routines.
* Added debug message about only supporting
l_sat_mixrat_lookup = false and saturation_formula = saturation_flatau
on GPUs
Answers are Bit for Bit with arm-multicolumn case + nvhpc compiler.
* Changing CLUBB debug level 1 to 0 for the saturation formula support
running on GPUs
* Changing indentation to make gfortran happy, it wants ifdefs to start at the beginning of the line.
* Adding use statements for error checks and printouts, also making the errors set err_code to clubb_fatal_error.
Co-authored-by: huebler <huebler@uwm.edu>
2023-01-12 12:54:15 -060088b8239840f581d76610aa630dab6219d64d68beRestructuring and Porting of Compute_mixing_length subroutine(Phase 1) (#1052)editcompile/config/linux_x86_64_nvhpc_casper.basheditsrc/CLUBB_core/constants_clubb.F90editsrc/CLUBB_core/model_flags.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/saturation.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/model_flags.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/saturation.F907f1decd0252e0b4d80f4b3873b0b48b6d3ec86311674081416000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRestructuring and Porting of Compute_mixing_length subroutine(Phase 2) (#1054)
* Restructuring and Porting of Compute_mixing_length subroutine(Phase 2)
Restructure: sat_mixrat_liq_2D_acc is being directly called instead of
calling the 1D version inside the column loop. Changing sat_mixrat_liq_2D_acc
to a subroutine from a function and adding output array, start_index as
additional argument. This is a workaround for passing sub-arrays. The OpenACC
doen't like the sub-arrays being passed and fails the validation.
Porting: OpenACC directives are added inside sat_mixrat_liq_2D_acc for porting
Validation: Answers are Bit for Bit with arm-multicolumn case + nvhpc compiler
* Fix for compilation issues
Issue 1: Missed out declaring 'start_index' while intergrating the
change
Issue 2: The use of error_code module and the procedures inside it
causes OpenACC compilation issues when run on the device.
* Removing the sat_mixrat_liq_acc and sat_mixrat_liq_2D_acc, making the normal sat_mixrat_liq work for all current use cases, and making the other versions of sat_mixrat_liq (bolton,gfdl,lookup) functional with OPENACC.
Co-authored-by: huebler <huebler@uwm.edu>
2023-01-18 16:36:56 -06007f1decd0252e0b4d80f4b3873b0b48b6d3ec8631Restructuring and Porting of Compute_mixing_length subroutine(Phase 2) (#1054)editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/model_flags.F90editsrc/CLUBB_core/saturation.F90
- src/CLUBB_core/mono_flux_limiter.F90e21e2713eab0f3f228189a4b407c80d4f241038f1674153381000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comBreaking up column loop in mono_flux_limiter. This may not be the final form for GPUization, but it's definitely a start, no longer do we have to copy single column variables to multicolumn ones anywhere. (#1051)
2023-01-19 12:36:21 -0600e21e2713eab0f3f228189a4b407c80d4f241038fBreaking up column loop in mono_flux_limiter. This may not be the final form for GPUization, but it's definitely a start, no longer do we have to copy single column variables to multicolumn ones anywhere. (#1051)editsrc/CLUBB_core/mono_flux_limiter.F90
- src/CLUBB_core/matrix_solver_wrapper.F90src/CLUBB_core/model_flags.F90src/CLUBB_core/tridiag_lu_solver.F90src/CLUBB_core/lapack_wrap.F90src/CLUBB_core/penta_lu_solver.F90dda5e8c57edb41b73340c0f9578d7c327b18e0761674153404000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdding tridiag_lu solver (#1056)
* Adding tridiag_lu solver
* Changing low to lower in tridiag_lu and penta_lu, also fixing up some spacing.
* Making variables that represent matrix solutions more consistently named.
2023-01-19 12:36:44 -0600dda5e8c57edb41b73340c0f9578d7c327b18e076Adding tridiag_lu solver (#1056)editsrc/CLUBB_core/matrix_solver_wrapper.F90editsrc/CLUBB_core/model_flags.F90editsrc/CLUBB_core/lapack_wrap.F90editsrc/CLUBB_core/penta_lu_solver.F90addsrc/CLUBB_core/tridiag_lu_solver.F90
- utilities/sens_matrix/sens_matrix_dashboard.pyf9eb64fb27f4b0515602e0f46848fc644035cfaf1674232314000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@users.noreply.github.comAdds to tuner error bars on bias removal (arrow) plots
and also adds bar graphs that show how each parameter contributes to the bias removal.
2023-01-20 17:31:54 +0100f9eb64fb27f4b0515602e0f46848fc644035cfafAdds to tuner error bars on bias removal (arrow) plotseditutilities/sens_matrix/sens_matrix_dashboard.py
- src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90src/CLUBB_core/mixing_length.F9095217702784b7eddc848ef0d6f7ee705c10d77521674580201000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@users.noreply.github.comAdding OpenACC data directives for mixing length and adg routines
OpenACC structured data regions are added to optimize the data transfers
between CPU and GPU. These data regions will converted to unstrucutred
data region in the later optimization phase.
Results are bit for bit.
2023-01-24 18:10:01 +010095217702784b7eddc848ef0d6f7ee705c10d7752Adding OpenACC data directives for mixing length and adg routineseditsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90editsrc/CLUBB_core/mixing_length.F90
- src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90a0f5313ee697be2153704f9d4b9775cde7d717a11674585724000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing error causing GPU code not to run. Some variables to be copied were labelled as (ngrdcol,nz) when it should be (:ngrdcol,:nz). I've just removed the data length specifiers completely since they are not neccesary in general.
2023-01-24 12:42:04 -0600a0f5313ee697be2153704f9d4b9775cde7d717a1Fixing error causing GPU code not to run. Some variables to be copied were labelled as (ngrdcol,nz) when it should be (:ngrdcol,:nz). I've just removed the data length specifiers completely since they are not neccesary in general.editsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90
- src/CLUBB_core/stats_clubb_utilities.F90src/CLUBB_core/saturation.F9015a351eec8d677c5035bce255aac81898c7958221674680903000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comGPUizing sat_mixrat_ice_2D.
2023-01-25 15:08:23 -060015a351eec8d677c5035bce255aac81898c795822GPUizing sat_mixrat_ice_2D.editsrc/CLUBB_core/saturation.F90editsrc/CLUBB_core/stats_clubb_utilities.F90
- utilities/sens_matrix/sens_matrix_dashboard.py822ec13b0db0f3beb4eb93d796d5221a0d3c5f931674740212000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@users.noreply.github.comAdds to dashboard plots error bars for
bias removal plot, a colored correlation matrix,
a matrix of linear-based 2-point bounds on parameter perturbations,
and a web-page version of the 3-dot subplots.
2023-01-26 14:36:52 +0100822ec13b0db0f3beb4eb93d796d5221a0d3c5f93Adds to dashboard plots error bars foreditutilities/sens_matrix/sens_matrix_dashboard.py
- utilities/sens_matrix/sens_matrix_dashboard.py1025d807ab1f3d5e8d3a8deb72595f2314b1cec51675100849000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@users.noreply.github.comAdds to dashboard a bar plot that separates nonlinear
and linear contributions to bias removal.
Also abbreviates the clubb parameter names in the plots.
2023-01-30 18:47:29 +01001025d807ab1f3d5e8d3a8deb72595f2314b1cec5Adds to dashboard a bar plot that separates nonlineareditutilities/sens_matrix/sens_matrix_dashboard.py
- run_scripts/run_tuner.bashREADMEcfd87ac680ebb26e2fdb7b1aab7a8b8b4fc753201675178299000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@users.noreply.github.comAdded option (-i) to run_tuner.bash script to enable pre-tuning standalone runs. README will be updated.
2023-01-31 16:18:19 +0100cfd87ac680ebb26e2fdb7b1aab7a8b8b4fc75320Added option (-i) to run_tuner.bash script to enable pre-tuning standalone runs. README will be updated.editREADMEeditrun_scripts/run_tuner.bash
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/calc_pressure.F90src/clubb_driver.F90src/input_interpret.F900fafc6b0b1f1a6058d37bf3db4bb3708204504db1675364876000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comPushing column loop into calculate_thvm
2023-02-02 13:07:56 -06000fafc6b0b1f1a6058d37bf3db4bb3708204504dbPushing column loop into calculate_thvmeditsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/calc_pressure.F90editsrc/input_interpret.F90editsrc/clubb_driver.F90
- src/CLUBB_core/calc_pressure.F908c7230fecb877d04fb129ef5e143e0993b4b29b11675364876000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comRemoving update_pressure since it is no longer called anywhere in clubb or host models. The addition of this subroutine was discussed in larson-group/e3sm#6 and the removal of the call to it was discussed in larson-group/clubb#926.
2023-02-02 13:07:56 -06008c7230fecb877d04fb129ef5e143e0993b4b29b1Removing update_pressure since it is no longer called anywhere in clubb or host models. The addition of this subroutine was discussed in larson-group/e3sm#6 and the removal of the call to it was discussed in larson-group/clubb#926.editsrc/CLUBB_core/calc_pressure.F90
- src/CLUBB_core/calc_pressure.F902f84d7c748f143990316004c66ebda5486de57521675552920000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving update_pressure from public list. This was causing compilation crashes. RESOLVED:8c7230fecb877d04fb129ef5e143e0993b4b29b1
2023-02-04 17:22:00 -06002f84d7c748f143990316004c66ebda5486de5752Removing update_pressure from public list. This was causing compilation crashes. RESOLVED:8c7230fecb877d04fb129ef5e143e0993b4b29b1editsrc/CLUBB_core/calc_pressure.F90
- src/input_interpret.F905850944600089fe2cb244ca1b08973231b6d91d31675573004000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bug, arrays given a dummy index in 0fafc6b0b1f1a6058d37bf3db4bb3708204504db are declared nsize, but are only used up to nlevels, thus we need the (1,1:nlevels) specifier when passing them. This issue was only caught by our _debug tests, so that's good evidence the new flags we added to initialize unused to memory was effective.
2023-02-04 22:56:44 -06005850944600089fe2cb244ca1b08973231b6d91d3Fixing bug, arrays given a dummy index in 0fafc6b0b1f1a6058d37bf3db4bb3708204504db are declared nsize, but are only used up to nlevels, thus we need the (1,1:nlevels) specifier when passing them. This issue was only caught by our _debug tests, so that's good evidence the new flags we added to initialize unused to memory was effective.editsrc/input_interpret.F90
- src/CLUBB_core/turbulent_adv_pdf.F90src/CLUBB_core/grid_class.F90src/CLUBB_core/saturation.F90src/CLUBB_core/mean_adv.F90c9a950dbbf76e82a3cda0ab2d65f29cd5f28df121675791268000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comGPUizing some helping procedures.
2023-02-07 11:34:28 -0600c9a950dbbf76e82a3cda0ab2d65f29cd5f28df12GPUizing some helping procedures.editsrc/CLUBB_core/saturation.F90editsrc/CLUBB_core/turbulent_adv_pdf.F90editsrc/CLUBB_core/grid_class.F90editsrc/CLUBB_core/mean_adv.F90
- src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F907d6dfad026e40eaf30f29ffa17c23dfbed8820401675791268000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comRemoving sigma_sqd_w from the acc data copyout statement. This is a bug which was causing the code to crash when not using managed memory.
2023-02-07 11:34:28 -06007d6dfad026e40eaf30f29ffa17c23dfbed882040Removing sigma_sqd_w from the acc data copyout statement. This is a bug which was causing the code to crash when not using managed memory.editsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90
- src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/pdf_utilities.F9047cd566e64abb0e774abd20c2ec97deed8dd3ab51675902842000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comPorting pdf_closure subroutine with OpenACC (#1059)
* Porting pdf_closure subroutine with OpenACC
OpenACC directives are added to pdf_closure subroutine. The necessary
structured data region is also added for optimzing data movement across
kernels. There is opportunity to task parallelize using streams and
will be explored in the future.
Answers are bit for bit.
* Fixing the copyin directives
* Making work without managed memory.
2023-02-08 18:34:02 -060047cd566e64abb0e774abd20c2ec97deed8dd3ab5Porting pdf_closure subroutine with OpenACC (#1059)editsrc/CLUBB_core/pdf_utilities.F90editsrc/CLUBB_core/pdf_closure_module.F90
- utilities/read_sam_moments/netcdf_var_collector.pyb361c61e93c25e1a491a5ff4fdbe5cbcc1f0f7351676148083000http://carson.math.uwm.edu/jenkins/user/cerniktcerniktcernikt@msoe.edumade graphing for netcdf_var collector general. #1040
2023-02-11 14:41:23 -0600b361c61e93c25e1a491a5ff4fdbe5cbcc1f0f735made graphing for netcdf_var collector general. #1040editutilities/read_sam_moments/netcdf_var_collector.py
- src/CLUBB_core/advance_clubb_core_module.F90input/stats/standard_stats.insrc/CLUBB_core/stats_variables.F90src/CLUBB_core/stats_clubb_utilities.F90src/CLUBB_core/stats_zm_module.F90input/stats/all_stats.inf4a832bf41d24a08e9b5be84713c057dfa98084e1676661825000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAdding wp3_on_wp2_cfl_num to CLUBB's output stats.
2023-02-17 13:23:45 -0600f4a832bf41d24a08e9b5be84713c057dfa98084eAdding wp3_on_wp2_cfl_num to CLUBB's output stats.editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/stats_variables.F90editsrc/CLUBB_core/stats_zm_module.F90editinput/stats/standard_stats.ineditinput/stats/all_stats.ineditsrc/CLUBB_core/stats_clubb_utilities.F90
- postprocessing/pyplotgen/config/VariableGroupNondimMoments.py28e0fce01e7815ba9476ef6de24e556755f142d41676666305000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAdded wp3_on_wp2_cfl_num to the VariableGroupNondimMoments.py file for
pyplotgen use.
2023-02-17 14:38:25 -060028e0fce01e7815ba9476ef6de24e556755f142d4Added wp3_on_wp2_cfl_num to the VariableGroupNondimMoments.py file foreditpostprocessing/pyplotgen/config/VariableGroupNondimMoments.py
- postprocessing/pyplotgen/config/VariableGroupNondimMoments.pyf41e9c4d0b929e0bcbfb84ee6705ab3b979a65201677083898000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate VariableGroupNondimMoments.py
Fixed a typo
2023-02-22 10:38:18 -0600f41e9c4d0b929e0bcbfb84ee6705ab3b979a6520Update VariableGroupNondimMoments.pyeditpostprocessing/pyplotgen/config/VariableGroupNondimMoments.py
- src/clubb_driver.F90d3264a2623c048a97b2dd6d8bb43f14c0e496f0c1677519729000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comFixing bug. This was only triggered when l_input_fields=.true., which I am only testing because it needs to be true so that I can test ADG2_driver.
2023-02-27 11:42:09 -0600d3264a2623c048a97b2dd6d8bb43f14c0e496f0cFixing bug. This was only triggered when l_input_fields=.true., which I am only testing because it needs to be true so that I can test ADG2_driver.editsrc/clubb_driver.F90
- src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90fa914b7afea4b486d22cdaa23fb1fa70c05785591677519729000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comRemoving usage of gr from pdf_closure. It was only ever used for nz, which is now fed in directly.
2023-02-27 11:42:09 -0600fa914b7afea4b486d22cdaa23fb1fa70c0578559Removing usage of gr from pdf_closure. It was only ever used for nz, which is now fed in directly.editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90
- input_misc/tuner/error_atex.ininput_misc/tuner/error_rico.insrc/CLUBB_core/pdf_closure_module.F90input_misc/tuner/error_gabls3_night.ininput_misc/tuner/error_nov11_altocu.ininput_misc/tuner/error_four_cases.insrc/G_unit_test_types/tuner_tests.F90src/clubb_tuner.F90input_misc/tuner/error_dycoms2_rf01.ininput_misc/tuner/error_dycoms2_rf02_ds.ininput_misc/tuner/error_wangara.ininput_misc/tuner/error_dycoms2_rf02_do.ininput_misc/tuner/error_dycoms2_rf02_nd.ininput_misc/tuner/error_arm.ininput_misc/tuner/error_bomex.ininput_misc/tuner/error_bomex_fire.insrc/enhanced_simann.F90compile/READMEinput_misc/tuner/error_all.ininput_misc/tuner/error_arm_97.ininput_misc/tuner/error_lba.insrc/clubb_driver.F90READMEinput_misc/tuner/READMEinput_misc/tuner/error_fire.insrc/error.F90input_misc/tuner/error_gabls2.incompile/compile.bashinput_misc/tuner/error_ticket_756.in981b9ba9bc9b5d80edc82f52f502ab9bcce097db1677613563000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb ticket #1025: Implemented way to make esa tuner reproducible, h… (#1068)
* Clubb ticket #1025: Implemented way to make esa tuner reproducible, hid error output of optional diagnostic variables behind check, fixed parallelization issue with tuner, esa max_iters parameter is now in stats namelist, fixed issue with TUNER compiler directive, some small fixes.
- New namelist variables prescribed_rand_seed and l_use_prescribed_rand_seed determine if the esa tuner will use a random or a fixed value as random seed. Added descriptions to README.
- Added max_iters to stats namelist to make it more modifiable.
- Renamed stp_adjst_intercept_in and stp_adjst_slope_in to stp_adjst_shift_in and stp_adjst_factor_in, respectively, to better reflect their influence on step size.
- The error output in src/CLUBB_core/pdf_closure_module.F90 for the diagnostic variables wprtp2, wpthlp2, wprtpthlp, and rcp2 is now hidden behind existence checks for these variables. And a clarification was added to "#ifdef TUNER" directive.
- NetCDF file access caused the tuner to crash in parallel mode (-fopenmp flag in config file and multiple cases). Adding an $OMP CRITICAL structure around the call to stats_init in clubb_driver.F90 fixed that.
- Fixed compile/README. Config files are specified with the -c option.
- The -t option in run_scripts/run_tuner.bash interfered with the previous usage of the TUNER compiler directive. Renamed the old TUNER directive to NR_SP, a short for "numerical recipes, single precision". TUNER now is the option to "turn on" code changes required to run the tuner.
2023-02-28 13:46:03 -0600981b9ba9bc9b5d80edc82f52f502ab9bcce097dbClubb ticket #1025: Implemented way to make esa tuner reproducible, h… (#1068)editcompile/READMEeditinput_misc/tuner/error_all.ineditinput_misc/tuner/READMEeditinput_misc/tuner/error_ticket_756.ineditinput_misc/tuner/error_atex.ineditinput_misc/tuner/error_lba.ineditinput_misc/tuner/error_gabls3_night.ineditinput_misc/tuner/error_fire.ineditinput_misc/tuner/error_dycoms2_rf01.ineditinput_misc/tuner/error_dycoms2_rf02_do.ineditsrc/CLUBB_core/pdf_closure_module.F90editsrc/error.F90editinput_misc/tuner/error_gabls2.ineditinput_misc/tuner/error_arm.ineditcompile/compile.basheditinput_misc/tuner/error_nov11_altocu.ineditsrc/clubb_driver.F90editREADMEeditinput_misc/tuner/error_arm_97.ineditsrc/clubb_tuner.F90editinput_misc/tuner/error_dycoms2_rf02_ds.ineditinput_misc/tuner/error_bomex.ineditinput_misc/tuner/error_wangara.ineditinput_misc/tuner/error_rico.ineditinput_misc/tuner/error_dycoms2_rf02_nd.inaddinput_misc/tuner/error_bomex_fire.ineditsrc/enhanced_simann.F90editinput_misc/tuner/error_four_cases.ineditsrc/G_unit_test_types/tuner_tests.F90
- utilities/autocommit_message_maker/autocommit_message_maker.py965964e81cc6b58ffbf3213af1d2488080b3371a1677867187000http://carson.math.uwm.edu/jenkins/user/cerniktcernikttjcernik@uwm.eduadded autocommit message maker to clubb so I have an easier time testing it
2023-03-03 12:13:07 -0600965964e81cc6b58ffbf3213af1d2488080b3371aadded autocommit message maker to clubb so I have an easier time testing itaddutilities/autocommit_message_maker/autocommit_message_maker.py
- utilities/autocommit_message_maker/autocommit_message_maker.py6e4204729c1b525b0f2fde3d7c715f5982fc79c31677881620000http://carson.math.uwm.edu/jenkins/user/cerniktcernikttjcernik@uwm.educhanges to integrate message maker into gitUpdate scripts
2023-03-03 16:13:40 -06006e4204729c1b525b0f2fde3d7c715f5982fc79c3changes to integrate message maker into gitUpdate scriptseditutilities/autocommit_message_maker/autocommit_message_maker.py
- utilities/autocommit_message_maker/autocommit_message_maker.pybe6ab481c56acfc66d65990889dba011d6bcd36a1677881884000http://carson.math.uwm.edu/jenkins/user/cerniktcernikttjcernik@uwm.eduOops, I made 1 small error, should be consistent now.
2023-03-03 16:18:04 -0600be6ab481c56acfc66d65990889dba011d6bcd36aOops, I made 1 small error, should be consistent now.editutilities/autocommit_message_maker/autocommit_message_maker.py
- input/case_setups/rico_sounding.ininput/case_setups/bomex_model.ininput/case_setups/rico_silhs_model.ininput/case_setups/dycoms2_rf02_ds_model.ininput/case_setups/rico_model.ininput/case_setups/dycoms2_rf02_do_model.ininput/case_setups/dycoms2_rf02_morr_model.ininput/case_setups/wangara_sounding.ininput/case_setups/dycoms2_rf02_nd_model.insrc/clubb_driver.F90src/sounding.F90input/case_setups/dycoms2_rf02_sounding.ininput/case_setups/dycoms2_rf02_so_model.ininput/case_setups/bomex_sounding.ininput/case_setups/wangara_model.in9aeea149d5970cb99218344f8bde576e1f036d211677883168000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduImplementing changes to the initial conditions.
This commit contains code changes related to the modified initial
conditions for convergence test simulations. These code changes can be
activated by setting l_modify_ic_with_cubic_int = .true. in
the namelist on a case-by-case basis.
Along with this option, the sounding profiles are also modified for
the BOMEX, RICO, DYCOMS2_RF02 and Wangara cases.
-- For BOMEX, RICO, Wangara cases, we add more height levels in the
original sounding profiles so that the cubic spline interpolation
produces consistent profiles with those with linear interpolation
-- For DYCOMS2_RF02, instead of using the formulations in the code to
derive the initial condition profiles (which will results in the
grid-spacing dependent initial condition when we refine grid), we
construct a sounding profiles (still use the same formulas as in
the src/sounding.F90) on a high-resolution grid (refine the standard
grid by a factor of 2^7), then save the profile in
dycoms2_rf02_sounding.in. In this way, the model initiliazation will
always read the same sounding profile for initialization when user
refine the vertical model grid.
Originally committed by Shixuan.
2023-03-03 16:39:28 -06009aeea149d5970cb99218344f8bde576e1f036d21Implementing changes to the initial conditions.editinput/case_setups/wangara_sounding.ineditinput/case_setups/dycoms2_rf02_sounding.ineditinput/case_setups/rico_model.ineditinput/case_setups/rico_silhs_model.ineditinput/case_setups/rico_sounding.ineditinput/case_setups/dycoms2_rf02_so_model.ineditinput/case_setups/dycoms2_rf02_morr_model.ineditinput/case_setups/bomex_model.ineditinput/case_setups/dycoms2_rf02_ds_model.ineditinput/case_setups/dycoms2_rf02_nd_model.ineditinput/case_setups/dycoms2_rf02_do_model.ineditinput/case_setups/bomex_sounding.ineditinput/case_setups/wangara_model.ineditsrc/sounding.F90editsrc/clubb_driver.F90
- READMEa6682998e27e3d01b8ffeb4ec2774872e7311aa41677905458000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThis commit most definitely does not change any bits,
but commit 67878ef was BIT_CHANGING for the DYCOMS-II RF02 family
of cases, RICO (and RICO SILHS), BOMEX, and Wangara.
2023-03-03 22:50:58 -0600a6682998e27e3d01b8ffeb4ec2774872e7311aa4This commit most definitely does not change any bits,editREADME
- run_scripts/convergence_function.pyrun_scripts/run_cnvg_test_multi_cases.cshrun_scripts/plot_l2_convergence.pyrun_scripts/convergence_config.py0e087bee28254a2bc2da5869a28352e1374b2b911678120205000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAdd scripts to configure and run convergence test
This commit contains new scripts created to configure and run
convergence test simulations. There are four scripts:
1. run_scripts/run_cnvg_test_multi_cases.csh. This script is used to
compile and run convergence simulations with specific configurations
(see details in scripts for explations). After the simulations,the
space-time convergence plots will also be generated.
2.run_scripts/convergence_config.py: this script "called" by the
first script to generate the namelist file for CLUBB-SCM simulations.
With this script, the modified configuration will be applied in the
case run directory, while the files in default clubb will not be
touched
3.run_scripts/convergence_function.py: this script contains function
to modify the initial condition profile for convergence test
simulations. It is called by run_scripts/convergence_config.py
when the model is configured to use modified initial conditions
4.run_scripts/plot_l2_convergence.py: this is a sample script to
generate the space-time convergence plots
Originally committed by Shixuan
2023-03-06 10:30:05 -06000e087bee28254a2bc2da5869a28352e1374b2b91Add scripts to configure and run convergence testaddrun_scripts/convergence_function.pyaddrun_scripts/plot_l2_convergence.pyaddrun_scripts/run_cnvg_test_multi_cases.cshaddrun_scripts/convergence_config.py
- run_scripts/convergence_run/run_cnvg_test_multi_cases.cshrun_scripts/convergence_run/convergence_function.pyrun_scripts/convergence_run/convergence_config.pyrun_scripts/plot_l2_convergence.pyrun_scripts/convergence_config.pyrun_scripts/convergence_function.pyrun_scripts/run_cnvg_test_multi_cases.cshrun_scripts/convergence_run/plot_l2_convergence.py53c717bb7dd9bddcd720cba58c46d77b7ad36c9c1678120475000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.edureorgnize the scripts for convergence test simulations
Move the script associated with convergence test simulation
in the folder of run_scripts/convergence_run
Originally committed by Shixuan
2023-03-06 10:34:35 -060053c717bb7dd9bddcd720cba58c46d77b7ad36c9creorgnize the scripts for convergence test simulationsdeleterun_scripts/run_cnvg_test_multi_cases.cshdeleterun_scripts/convergence_function.pydeleterun_scripts/convergence_config.pyaddrun_scripts/convergence_run/convergence_config.pyaddrun_scripts/convergence_run/run_cnvg_test_multi_cases.cshdeleterun_scripts/plot_l2_convergence.pyaddrun_scripts/convergence_run/plot_l2_convergence.pyaddrun_scripts/convergence_run/convergence_function.py
- READMEdb8d5931d779bc1f776fb80952a1c263c22f84671678293578000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate README
I guess the proper way to do it is this -- BIT_CHANGING:9aeea14
2023-03-08 10:39:38 -0600db8d5931d779bc1f776fb80952a1c263c22f8467Update READMEeditREADME
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/turbulent_adv_pdf.F90src/CLUBB_core/grid_class.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/saturation.F90src/CLUBB_core/mean_adv.F90src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90src/CLUBB_core/pdf_utilities.F90src/CLUBB_core/mixing_length.F90a3bcb0bd343d004b2f085006708b88131be995071678297579000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comGpu updates (#1070)
* Fixing bug. This was only triggered when l_input_fields=.true., which I am only testing because it needs to be true so that I can test ADG2_driver.
* Removing usage of gr from pdf_closure. It was only ever used for nz, which is now fed in directly.
* Making openacc statements more consistent. Ensuring all statments on double loops have specified gang and vector, and that all parallel loops have an end parallel loop statment at the end of them. Everything BFB on CPUs and GPUs.
* Pushing acc data region to outermost parts of mixing_length.
* Removing pdf_implicit_coefs_terms from acc copyin and copyout. It is only used when iiPDF_type == iiPDF_new .or. iiPDF_type == iiPDF_new_hybrid, so we do not need to do any copying with it. The inclusion of it also caused the data statement to copy unallocated arrays, which are just garbage pointers, and that was causing random occasional crashes (either segfaults or gpu out of memory).
* The update device clauses for return variables seems to only be requried for arrays contained in types. See https://github.com/larson-group/clubb/issues/1049\#issuecomment-1440624778
* Moving acc end data to end of pdf_closure. This reuqired removing any conditional return statements that appear before the final return, since we're not allowed to branch out of an acc region early. I also moved a large printout statement outside of a loop. The only reason it was in the loop to begin with was because pdf_params used to be an array of types, but now is a type of arrays, allowing us to print the full arrays directly.
* Making loop an acc loop. If we weren't outputting w_[up/down]_in_cloud (iw_up_in_cloud <= 0 .or. iw_down_in_cloud <= 0, then these arrays were only being zerod out on the CPU and would've getting overwritten by the uninitialized GPU data at the end of the data statement. This change causes the arrays to get correctly zerod out on the GPU when we need.
* Update VariableGroupNondimMoments.py
Fixed a typo
* Merging new changes from master
* Removing need for -gpu=deepcopy, pushing some acc data statements up call tree, and replacing some acc data statements with acc delare statements so that return statements can be added back in.
* Adding back an acc loop that was accidentally removed during a merge.
---------
Co-authored-by: Brian Griffin <31553422+bmg929@users.noreply.github.com>
2023-03-08 11:46:19 -0600a3bcb0bd343d004b2f085006708b88131be99507Gpu updates (#1070)editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/turbulent_adv_pdf.F90editsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90editsrc/CLUBB_core/grid_class.F90editsrc/CLUBB_core/saturation.F90editsrc/CLUBB_core/mean_adv.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/pdf_utilities.F90editsrc/CLUBB_core/pdf_closure_module.F90
- input/case_setups/dycoms2_rf02_morr_model.insrc/clubb_driver.F90input/case_setups/bomex_model.ininput/case_setups/dycoms2_rf02_nd_model.ininput/case_setups/rico_silhs_model.ininput/case_setups/dycoms2_rf02_ds_model.ininput/case_setups/dycoms2_rf02_so_model.ininput/case_setups/rico_model.ininput/case_setups/wangara_model.ininput/case_setups/dycoms2_rf02_do_model.in8e473e08b858df61c5c5116e37e26f3df2431a0b1678316303000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduCode changes to implement modified boundary condition
This commit contains code changes to implement modified boundary
conditions for convergence test simulations. These code changes
can be activated by setting l_modify_bc_for_cnvg_test = .true.
in the CLUBB namelist.
Originally committed by Shixuan.
2023-03-08 16:58:23 -06008e473e08b858df61c5c5116e37e26f3df2431a0bCode changes to implement modified boundary conditioneditinput/case_setups/dycoms2_rf02_so_model.ineditinput/case_setups/dycoms2_rf02_morr_model.ineditinput/case_setups/rico_model.ineditinput/case_setups/dycoms2_rf02_do_model.ineditinput/case_setups/wangara_model.ineditinput/case_setups/rico_silhs_model.ineditinput/case_setups/dycoms2_rf02_ds_model.ineditsrc/clubb_driver.F90editinput/case_setups/bomex_model.ineditinput/case_setups/dycoms2_rf02_nd_model.in
- src/CLUBB_core/mono_flux_limiter.F90c5c29600aa8cf9176127e44fbf6ddccf9474722a1678350700000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comImplements Thomas Toniazzo's bug fix for spike removal
in the monotonic flux limiter. See
https://github.com/larson-group/clubb_release/pull/11/files
This code change is
expected to be BIT_CHANGING for cases in which
`l_predict_upwp_vpwp = T`, `l_mono_flux_lim_um = T`
or `l_mono_flux_lim_vm = T`, and the monotonic
flux limiter is triggered.
This bug fix prevents non-conservation of momentum
when the vertical integral of either of the wind components `um` or `vm` is negative.
2023-03-09 02:31:40 -0600c5c29600aa8cf9176127e44fbf6ddccf9474722aImplements Thomas Toniazzo's bug fix for spike removaleditsrc/CLUBB_core/mono_flux_limiter.F90
- README9512061ddd7b2a7d1009a787409055495fbd39c51678370125000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comFixed an old notation change in the README
2023-03-09 07:55:25 -06009512061ddd7b2a7d1009a787409055495fbd39c5Fixed an old notation change in the READMEeditREADME
- README5cb6f1b9b80536e8a57e8d5f64a73136c824b0a01678370507000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate README
Did this not work because I didn't include all 40 characters of the git hash?
BIT_CHANGING:9aeea149d5970cb99218344f8bde576e1f036d21
2023-03-09 08:01:47 -06005cb6f1b9b80536e8a57e8d5f64a73136c824b0a0Update READMEeditREADME
- input_misc/tuner/error_atex.ininput_misc/tuner/error_rico.ininput_misc/tuner/error_gabls3_night.insrc/CLUBB_core/sfc_varnce_module.F90input_misc/tuner/error_nov11_altocu.ininput_misc/tuner/error_four_cases.ininput_misc/tuner/error_dycoms2_rf01.ininput_misc/tuner/error_dycoms2_rf02_ds.insrc/clubb_standalone.F90input_misc/tuner/error_wangara.ininput/tunable_parameters_compatible_r8029/tunable_parameters.insrc/G_unit_test_types/pdf_parameter_tests.F90input/tunable_parameters/tunable_parameters.ininput_misc/tuner/error_dycoms2_rf02_do.insrc/CLUBB_core/parameter_indices.F90input_misc/tuner/error_dycoms2_rf02_nd.ininput/tunable_parameters_e3sm/tunable_parameters.ininput_misc/tuner/error_arm.insrc/CLUBB_core/parameters_tunable.F90src/G_unit_test_types/spurious_source_test.F90input_misc/tuner/error_bomex.ininput_misc/tuner/error_bomex_fire.insrc/clubb_thread_test.F90src/CLUBB_core/advance_clubb_core_module.F90input/tunable_parameters_Lscale/tunable_parameters.ininput_misc/tuner/error_arm_97.ininput_misc/tuner/error_all.insrc/jacobian.F90input_misc/tuner/error_lba.insrc/CLUBB_core/clubb_api_module.F90input_misc/tuner/error_fire.insrc/error.F90input_misc/tuner/error_gabls2.ininput_misc/tuner/error_ticket_756.in903169aafe5cfd2f7cae35adef3d31e6f51641fe1678723565000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comMaking 'a_const' into a CLUBB tunable parameter. (#1072)
* Converting the sfc_varnce_module.F90 parameter 'a_const' into a CLUBB tunable parameter.
Results should be bit-for-bit since it will be set to 1.8 and with l_vary_convect_depth=F
this is the standard value.
Some discussion in ticket #994.
* Completing requested changes, see PR #1072.
2023-03-13 10:06:05 -0600903169aafe5cfd2f7cae35adef3d31e6f51641feMaking 'a_const' into a CLUBB tunable parameter. (#1072)editinput_misc/tuner/error_four_cases.ineditinput_misc/tuner/error_fire.ineditsrc/CLUBB_core/sfc_varnce_module.F90editinput_misc/tuner/error_gabls3_night.ineditsrc/clubb_standalone.F90editinput/tunable_parameters_compatible_r8029/tunable_parameters.ineditsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/CLUBB_core/clubb_api_module.F90editinput_misc/tuner/error_arm_97.ineditinput_misc/tuner/error_atex.ineditinput/tunable_parameters_Lscale/tunable_parameters.ineditsrc/CLUBB_core/advance_clubb_core_module.F90editinput/tunable_parameters/tunable_parameters.ineditinput_misc/tuner/error_lba.ineditinput_misc/tuner/error_bomex_fire.ineditinput_misc/tuner/error_rico.ineditinput_misc/tuner/error_bomex.ineditinput_misc/tuner/error_all.ineditinput_misc/tuner/error_ticket_756.ineditsrc/G_unit_test_types/spurious_source_test.F90editsrc/error.F90editinput_misc/tuner/error_arm.ineditinput_misc/tuner/error_dycoms2_rf02_nd.ineditinput_misc/tuner/error_dycoms2_rf01.ineditinput_misc/tuner/error_gabls2.ineditsrc/CLUBB_core/parameters_tunable.F90editinput_misc/tuner/error_nov11_altocu.ineditinput/tunable_parameters_e3sm/tunable_parameters.ineditinput_misc/tuner/error_dycoms2_rf02_ds.ineditinput_misc/tuner/error_wangara.ineditsrc/CLUBB_core/parameter_indices.F90editsrc/clubb_thread_test.F90editinput_misc/tuner/error_dycoms2_rf02_do.ineditsrc/jacobian.F90
- README14c03cc05cfddd0fc31d3845fc13111b3ac08d3a1678743308000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate README
I should've added the answer-changing tag to my previous commit:
BIT_CHANGING:903169a.
That commit doesn't really change answers, but adds a new tunable parameter which will show up in the output files and therefore they will differ from previous output files.
2023-03-13 15:35:08 -060014c03cc05cfddd0fc31d3845fc13111b3ac08d3aUpdate READMEeditREADME
- README2c597f4960cdb75b2bee46e56a511bd56fd722e21678743421000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate README
Oops didn't include all git hash characters:
BIT_CHANGING:903169aafe5cfd2f7cae35adef3d31e6f51641fe
2023-03-13 15:37:01 -06002c597f4960cdb75b2bee46e56a511bd56fd722e2Update READMEeditREADME
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/sigma_sqd_w_module.F90src/CLUBB_core/T_in_K_module.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/Skx_module.F905cbf4f80a34cfafd2fd164415af5ec7d6239bcdd1678812234000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comPdf closure driver gpuization (#1071)
* GPUizing pdf_closure_driver, testing still needed, bug likely.
* Making data movement better. Also fixed some random things. Still need to return returns.
* Adding back a couple return statments. Moving a comment where it should be. GPUizing a missed loop.
* Making arguements list satisfy standards.
* Making arguements list satisfy standards. Also adding max(1,hydrometdim) to hydromet inputs.
* Capitalizing K
* Making the error case in compute_cloud_cover behavior a bit differently. This allows the error to be detected immediately by GPU runs as well.
* Calling compute_cloud_cover only needs to be done if l_use_cloud_cover = .true.
2023-03-14 11:43:54 -05005cbf4f80a34cfafd2fd164415af5ec7d6239bcddPdf closure driver gpuization (#1071)editsrc/CLUBB_core/sigma_sqd_w_module.F90editsrc/CLUBB_core/T_in_K_module.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/Skx_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90
- READMEb6496cec72690bbaa9195b116d015553389537971678891637000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate README
RESOLVED:8e473e08b858df61c5c5116e37e26f3df2431a0b
Above committed on March 8th, 2023
BIT_CHANGING:5cbf4f80a34cfafd2fd164415af5ec7d6239bcdd
Above was committed on March 14th, 2023
2023-03-15 09:47:17 -0500b6496cec72690bbaa9195b116d01555338953797Update READMEeditREADME
- src/CLUBB_core/advance_clubb_core_module.F90fb4556e4cc4cb3d4b6df3520370a28a824f357ef1679006580000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMoving compute_cloud_cover outside of if ( l_use_cloud_cover ) then statement, the cloud_cover and rcm_in_layer variables they compute aren't output in clubb_standalone, but are in cam, causing cam bit diff tests to break.
2023-03-16 17:43:00 -0500fb4556e4cc4cb3d4b6df3520370a28a824f357efMoving compute_cloud_cover outside of if ( l_use_cloud_cover ) then statement, the cloud_cover and rcm_in_layer variables they compute aren't output in clubb_standalone, but are in cam, causing cam bit diff tests to break.editsrc/CLUBB_core/advance_clubb_core_module.F90
- README0cf0157ebf0dfe165d07da57520f34cbf1173bb81679163846000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduUndoing README update, 1 space = 1 byte and we should maximize file sizes to deter hackers from stealing our data. Also BIT_CHANGING:fb4556e4cc4cb3d4b6df3520370a28a824f357ef for configs where l_use_cloud_cover = .false., which means I was wrong about this ever not being bit changing, so I must've either only tested with l_use_cloud_cover = .true. or only tested the multicol diffs when I put compute_cloud_cover inside the if statement.
2023-03-18 13:24:06 -05000cf0157ebf0dfe165d07da57520f34cbf1173bb8Undoing README update, 1 space = 1 byte and we should maximize file sizes to deter hackers from stealing our data. Also BIT_CHANGING:fb4556e4cc4cb3d4b6df3520370a28a824f357ef for configs where l_use_cloud_cover = .false., which means I was wrong about this ever not being bit changing, so I must've either only tested with l_use_cloud_cover = .true. or only tested the multicol diffs when I put compute_cloud_cover inside the if statement.editREADME
- src/CLUBB_core/advance_clubb_core_module.F90dffad1daafea675ddb568df7159dc83c952baab71679530369000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding Skthl_zm to the update host list, I missed this in the last PR. I noticed this by comparing results with and without managed memory, now I've checked BFBness with arm, mpace_b, mc3e, and gabls2.
2023-03-22 19:12:49 -0500dffad1daafea675ddb568df7159dc83c952baab7Adding Skthl_zm to the update host list, I missed this in the last PR. I noticed this by comparing results with and without managed memory, now I've checked BFBness with arm, mpace_b, mc3e, and gabls2.editsrc/CLUBB_core/advance_clubb_core_module.F90
- src/CLUBB_core/grid_class.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/mean_adv.F90src/CLUBB_core/saturation.F90src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90src/CLUBB_core/pdf_utilities.F90src/CLUBB_core/parameters_model.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/Skx_module.F90src/CLUBB_core/turbulent_adv_pdf.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/sigma_sqd_w_module.F90src/CLUBB_core/T_in_K_module.F90d6db663fb3c7cd893d3d68786c486254e8a28ebb1679711434000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comSmall GPU fixes (#1076)
* Fixing small things that I caught by adding the default(present) onto acc loops.
* Moving default(present) to the end because it looks nicer there.
2023-03-24 21:30:34 -0500d6db663fb3c7cd893d3d68786c486254e8a28ebbSmall GPU fixes (#1076)editsrc/CLUBB_core/grid_class.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/sigma_sqd_w_module.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/T_in_K_module.F90editsrc/CLUBB_core/parameters_model.F90editsrc/CLUBB_core/turbulent_adv_pdf.F90editsrc/CLUBB_core/mean_adv.F90editsrc/CLUBB_core/Skx_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90editsrc/CLUBB_core/pdf_utilities.F90editsrc/CLUBB_core/saturation.F90
- README5cd77e018ec1ca2d920bd34b5500529068b957491680086342000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdds blank line to trigger nightly tests
2023-03-29 05:39:02 -05005cd77e018ec1ca2d920bd34b5500529068b95749Adds blank line to trigger nightly testseditREADME
- src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/model_flags.F90src/clubb_driver.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/clubb_api_module.F90src/G_unit_test_types/pdf_parameter_tests.F90src/CLUBB_core/clip_explicit.F90input/tunable_parameters/configurable_model_flags.insrc/clubb_tuner.F90475d569931a16ce1187c26757a0913e53c62abe51680247062000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduCode changes to implement modificiations on wp3 clippings
This commit contains code changes to implement modifications of skewness
clippings on wp3 in src/CLUBB_core/clip_explicit.F90. The default method attempts
to apply smaller (larger) clippings below (above) 100m AGL level, which
can cause a discontinuities around 100m AGL level. This clippings is
found to trigger sawthooth oscillations in wp3 when linear diffusion is
used. Such swathooth oscillations are eleminated if a smoothed Heaviside
function is introduced to obtain a smooth transition of clippings at
around 100m AGL level. The changes is necessary to obtain the first
order convergence in CLUBB-SCM when lienar diffusion is used.
Previously committed by Shixuan.
2023-03-31 02:17:42 -0500475d569931a16ce1187c26757a0913e53c62abe5Code changes to implement modificiations on wp3 clippingseditsrc/CLUBB_core/advance_wp2_wp3_module.F90editinput/tunable_parameters/configurable_model_flags.ineditsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/clip_explicit.F90editsrc/CLUBB_core/model_flags.F90editsrc/clubb_driver.F90editsrc/clubb_tuner.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/G_unit_test_types/spurious_source_test.F90
- src/CLUBB_core/advance_clubb_core_module.F90src/clubb_driver.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/model_flags.F90src/CLUBB_core/clubb_api_module.F90src/G_unit_test_types/pdf_parameter_tests.F90src/CLUBB_core/advance_helper_module.F90input/tunable_parameters/configurable_model_flags.insrc/CLUBB_core/mixing_length.F90src/clubb_tuner.F904b16d833e86ad23ef6ea81de67c38c596ebccd251680538287000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThis commit contains code changes to implement modifications on limiters in three places:
1. remove the limiters in denominator of equation for
brunt_vaisala_freq_sqd_smth, which affects the computed
eddy dissipation time scale in turbulent fluxes (wpxp).
(in mixing_length.F90)
2. reduce the threshold values of limiters in the equation
for richardson number (sqrt_Ri_zm)
(in mixing_length.F90)
3. introduce the smoothed max/min function for limiters in
equation of Cx_fnc_Richardson.
(in advance_helper_module.F90).
After the modification, we also apply a zt2m(zm2zt) smoothing
on the calculated quantities. These modifications are found to
be benificial for improving solution convergence in CLUBB-SCM
The code changes are controlled by a newly introduced flag named
"l_modify_limiters_for_cnvg_test", which is set to .false. (meaning that
the modificaitons on limiters is turned off) by default.
Originally committed by Shixuan.
2023-04-03 11:11:27 -05004b16d833e86ad23ef6ea81de67c38c596ebccd25This commit contains code changes to implement modifications on limiters in three places:editsrc/clubb_driver.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/clubb_api_module.F90editinput/tunable_parameters/configurable_model_flags.ineditsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/CLUBB_core/model_flags.F90editsrc/clubb_tuner.F90
githttp://carson.math.uwm.edu/jenkins/user/cerniktcernikthttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonhttp://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwmhttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse426http://carson.math.uwm.edu/jenkins/view/Production%20View/job/clubb_mac_gfortran_test/426/424http://carson.math.uwm.edu/jenkins/view/Production%20View/job/clubb_mac_gfortran_test/424/