BRANCHorigin/clubb_silhs_develTESTe3sm_ne4_silhs_run_gfortran_testStarted by user Gunther HueblerhueblerGunther Huebler17f3d45e4040e92e34f6b549a0229302abbabfdb57f3d45e4040e92e34f6b549a0229302abbabfdb57refs/remotes/origin/flag_removalf3d45e4040e92e34f6b549a0229302abbabfdb57f3d45e4040e92e34f6b549a0229302abbabfdb57refs/remotes/origin/flag_removal361e06a5688bd7f057c27553e8d412db1e523c615e1e06a5688bd7f057c27553e8d412db1e523c615erefs/remotes/origin/quick_test1e06a5688bd7f057c27553e8d412db1e523c615e1e06a5688bd7f057c27553e8d412db1e523c615erefs/remotes/origin/quick_test716ecd9e153a67ca03ff5f5911eee202adab3c4b316ecd9e153a67ca03ff5f5911eee202adab3c4b3refs/remotes/origin/stats_testing16ecd9e153a67ca03ff5f5911eee202adab3c4b316ecd9e153a67ca03ff5f5911eee202adab3c4b3refs/remotes/origin/stats_testing20f8cf673e3f3a9375ba57fba3a55961dcb8f4c47cf8cf673e3f3a9375ba57fba3a55961dcb8f4c47crefs/remotes/origin/l_vary_convect_depth_additionf8cf673e3f3a9375ba57fba3a55961dcb8f4c47cf8cf673e3f3a9375ba57fba3a55961dcb8f4c47crefs/remotes/origin/l_vary_convect_depth_addition1541429a51ebc3f3fd440aca4bbe7d1a36de05030541429a51ebc3f3fd440aca4bbe7d1a36de05030refs/remotes/origin/changes_to_not_break541429a51ebc3f3fd440aca4bbe7d1a36de05030541429a51ebc3f3fd440aca4bbe7d1a36de05030refs/remotes/origin/changes_to_not_break28ba623886b19d1bb3e3c061d138f3dc949bdbbb9eba623886b19d1bb3e3c061d138f3dc949bdbbb9erefs/remotes/origin/bmg929/atm/E3SM_clubb_silhs_1c77ed3_20211115_P3ba623886b19d1bb3e3c061d138f3dc949bdbbb9eba623886b19d1bb3e3c061d138f3dc949bdbbb9erefs/remotes/origin/bmg929/atm/E3SM_clubb_silhs_1c77ed3_20211115_P31589a5bb84d2469f135f7d600724cf0471a85f6cdc89a5bb84d2469f135f7d600724cf0471a85f6cdcrefs/remotes/origin/stats_to_hosts89a5bb84d2469f135f7d600724cf0471a85f6cdc89a5bb84d2469f135f7d600724cf0471a85f6cdcrefs/remotes/origin/stats_to_hosts376adba402c5df8819383f0728669ffc3ed186edb66adba402c5df8819383f0728669ffc3ed186edb6refs/remotes/origin/clubb_silhs_devel6adba402c5df8819383f0728669ffc3ed186edb66adba402c5df8819383f0728669ffc3ed186edb6refs/remotes/origin/clubb_silhs_devel6adba402c5df8819383f0728669ffc3ed186edb66adba402c5df8819383f0728669ffc3ed186edb6refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#377815161949700branch_e3sm_test #3737false3712036SUCCESS1642711517913http://carson.math.uwm.edu/jenkins/view/Branch%20View/job/branch_e3sm_test/37/advance_clubb_core_module.F90clubb_api_module.F90advance_xm_wpxp_module.F90ecf50b7dd71b99418e7b378199bec3f540f9ab8f1631318520000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have passed clubb_params down into advance_xm_wpxp_module.F90. The results from this revision are an exact match to the results from the previous revision for all cases. 2021-09-10 19:02:00 -0500ecf50b7dd71b99418e7b378199bec3f540f9ab8fI have passed clubb_params down into advance_xm_wpxp_module.F90.editclubb_api_module.F90editadvance_xm_wpxp_module.F90editadvance_clubb_core_module.F90pdf_closure_module.F9069a9f213c5189310355d117e82d7047829f4e5501632504823000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comSee ticket #958 2021-09-24 12:33:43 -050069a9f213c5189310355d117e82d7047829f4e550See ticketeditpdf_closure_module.F90advance_clubb_core_module.F90advance_wp2_wp3_module.F90b33af07b27883cd48fed63d9fa1557d3b2d4464d1632791429000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have passed down CLUBB's tunable parameters into advance_wp2_wp3_module.F90. The results in NetCDF output files from this revision are an exact match to the results in NetCDF output files from the previous revision for all cases. 2021-09-27 20:10:29 -0500b33af07b27883cd48fed63d9fa1557d3b2d4464dI have passed down CLUBB's tunable parameters into advance_wp2_wp3_module.F90.editadvance_clubb_core_module.F90editadvance_wp2_wp3_module.F90stats_clubb_utilities.F90advance_clubb_core_module.F90pdf_closure_module.F90f743922fbd8e78ed86270101cb28dbcbb5f5c0f71633009731000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comadded some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to disk 2021-09-30 08:48:51 -0500f743922fbd8e78ed86270101cb28dbcbb5f5c0f7added some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to diskeditpdf_closure_module.F90editstats_clubb_utilities.F90editadvance_clubb_core_module.F90advance_xp2_xpyp_module.F900f9530e65dbeccc6103c09e4497072ffef4fbf361633124125000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comUpdates to separate out C4 and C14 in advance_xp2 module. This will make it easier to control which invrs_tau_* variable multiplies each term for example. This commit is BIT_CHANGING owing to order of operations differences, but the pyplotgen output for most cases looks identical to the naked eye. 2021-10-01 16:35:25 -05000f9530e65dbeccc6103c09e4497072ffef4fbf36Updates to separate out C4 and C14 in advance_xp2 module. This will make it easier to control which invrs_tau_* variable multiplies each term for example.editadvance_xp2_xpyp_module.F90advance_xp2_xpyp_module.F904a3fe3288e95f3ff0042b328a2221113baa445a81633124125000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comChanging the name of dummy_1d variables for clarity. 2021-10-01 16:35:25 -05004a3fe3288e95f3ff0042b328a2221113baa445a8Changing the name of dummy_1d variables for clarity.editadvance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xp2_xpyp_module.F90724a970d8e0b0977d63512e25c4462d2600392901633127377000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI passed down CLUBB's tunable parameters into advance_xp2_xpyp_module.F90 for most parameters, excluding C4 and C14. Results are unchanged. 2021-10-01 17:29:37 -0500724a970d8e0b0977d63512e25c4462d260039290I passed down CLUBB's tunable parameters into advance_xp2_xpyp_module.F90editadvance_xp2_xpyp_module.F90editadvance_clubb_core_module.F90advance_clubb_core_module.F90860a184b28c1e3889801dfc39a1c96768fd870461633359161000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd a blank line to trigger nightly tests. 2021-10-04 09:52:41 -0500860a184b28c1e3889801dfc39a1c96768fd87046Add a blank line to trigger nightly tests.editadvance_clubb_core_module.F90advance_clubb_core_module.F90advance_xp2_xpyp_module.F90pdf_closure_module.F909ac836f8b76e39e820b5fecaae969f70a7b39c211633470307000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing down more of CLUBB's tunable parameters. 2021-10-05 16:45:07 -05009ac836f8b76e39e820b5fecaae969f70a7b39c21Passing down more of CLUBB's tunable parameters.editadvance_xp2_xpyp_module.F90editpdf_closure_module.F90editadvance_clubb_core_module.F90advance_clubb_core_module.F907b950575ac2c00c63de42c11f33c459e649af0281633470537000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI accidentally removed an important comment in the previous commit. 2021-10-05 16:48:57 -05007b950575ac2c00c63de42c11f33c459e649af028I accidentally removed an important comment in the previous commit.editadvance_clubb_core_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90advance_helper_module.F90835d3d3155f98b2a9b6ba60cb9fa02a94fb7800b1633637871000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing down more CLUBB tunable parameters. Everything is bit-for-bit. 2021-10-07 15:17:51 -0500835d3d3155f98b2a9b6ba60cb9fa02a94fb7800bPassing down more CLUBB tunable parameters.editadvance_clubb_core_module.F90editadvance_helper_module.F90editadvance_xm_wpxp_module.F90pdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F90b65e4cfa8ab2923db015ef2723e3e69071d2c83c1633728172000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduMore passing down CLUBB parameters ... whoop-de-doo 2021-10-08 16:22:52 -0500b65e4cfa8ab2923db015ef2723e3e69071d2c83cMore passing down CLUBB parameters ... whoop-de-dooeditadg1_adg2_3d_luhar_pdf.F90editpdf_closure_module.F90Skx_module.F90diagnose_correlations_module.F90advance_clubb_core_module.F90sfc_varnce_module.F90351cc9aa27aa212ef6cefb48b6c85ec601a993b01633732238000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing down more tunable parameters and removing references to parameters_tunable. Results are bit-for-bit. 2021-10-08 17:30:38 -0500351cc9aa27aa212ef6cefb48b6c85ec601a993b0Passing down more tunable parameters and removing references toeditSkx_module.F90editsfc_varnce_module.F90editdiagnose_correlations_module.F90editadvance_clubb_core_module.F90advance_clubb_core_module.F903c883d2e41e77b89ea758961d5e11ac577a1fa821634055768000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemoving line to trigger the nightly tests for all repos. 2021-10-12 11:22:48 -05003c883d2e41e77b89ea758961d5e11ac577a1fa82Removing line to trigger the nightly tests for all repos.editadvance_clubb_core_module.F90pdf_closure_module.F90advance_clubb_core_module.F90stats_clubb_utilities.F90stats_variables.F90model_flags.F90stats_zt_module.F9024ab4b2089583ab183efc1963c23fb3153fd20481634058263000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comSee respective messages on the issue 958 on date 10/12/2021 2021-10-12 12:04:23 -050024ab4b2089583ab183efc1963c23fb3153fd2048See respective messages on the issue 958 on date 10/12/2021editpdf_closure_module.F90editadvance_clubb_core_module.F90editmodel_flags.F90editstats_zt_module.F90editstats_clubb_utilities.F90editstats_variables.F90mixing_length.F90parameters_tunable.F90advance_clubb_core_module.F90clubb_api_module.F9040e87490f501202d6d95e7fd2c9c2ccab164ab731634087718000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduHandling the abomination that is lmin. 2021-10-12 20:15:18 -050040e87490f501202d6d95e7fd2c9c2ccab164ab73Handling the abomination that is lmin.editparameters_tunable.F90editadvance_clubb_core_module.F90editclubb_api_module.F90editmixing_length.F90diffusion.F90db7584133b87452bedc0538fed00f339dca49ae31634219703000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comCommented out the k=1 boundary conditions in diffusion_zm_lhs and diffusion_zt_lhs, since these are not currently fed into the final LHS matrix. I included comments to describe why this was done. Results are b4b. See https://github.com/larson-group/clubb/issues/920#issuecomment-942735433. 2021-10-14 08:55:03 -0500db7584133b87452bedc0538fed00f339dca49ae3Commented out the k=1 boundary conditions in diffusion_zm_lhs and diffusion_zt_lhs, since these are not currently fed into the final LHS matrix. I included comments to describe why this was done. Results are b4b.editdiffusion.F90mixing_length.F90advance_clubb_core_module.F90c8cadb5e9708e898ac688db79e1da0ec0ff2ad291634254172000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing tunable parameters into the new tau code. 2021-10-14 18:29:32 -0500c8cadb5e9708e898ac688db79e1da0ec0ff2ad29Passing tunable parameters into the new tau code.editmixing_length.F90editadvance_clubb_core_module.F90advance_wp2_wp3_module.F90mixing_length.F90advance_clubb_core_module.F90clip_explicit.F90e6aa931ab2aa8134704c137db183ec06ee9dfcee1634768140000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassed down more parameters. Results are bit-for-bit. 2021-10-20 17:15:40 -0500e6aa931ab2aa8134704c137db183ec06ee9dfceePassed down more parameters. Results are bit-for-bit.editadvance_clubb_core_module.F90editadvance_wp2_wp3_module.F90editclip_explicit.F90editmixing_length.F90advance_clubb_core_module.F90parameters_model.F90d07f2f6c2df3af24ddc90862bc2a656bdd9015d51634771341000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing through more clubb parameters. Bit-for-bit 2021-10-20 18:09:01 -0500d07f2f6c2df3af24ddc90862bc2a656bdd9015d5Passing through more clubb parameters. Bit-for-biteditparameters_model.F90editadvance_clubb_core_module.F90precipitation_fraction.F90setup_clubb_pdf_params.F90clubb_api_module.F90704eedf20b71e552fe32df3633005d50af58c27f1634854899000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing down CLUBB's tunable parameters into the setup_pdf_parameters and precipitation fraction portions of the code. Everything is bit-for-bit. 2021-10-21 17:21:39 -0500704eedf20b71e552fe32df3633005d50af58c27fPassing down CLUBB's tunable parameters into the setup_pdf_parameters andeditprecipitation_fraction.F90editsetup_clubb_pdf_params.F90editclubb_api_module.F90mixing_length.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90diffusion.F90model_flags.F90advance_xm_wpxp_module.F90advance_windm_edsclrm_module.F902ee6d2a1e31e43bca3e03a406917c4454cb71e671634935501000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comThese updates incorporate some of Shixuan Zhang's changes, including: (1) upwind scheme for the eddy diffusion code, which Shixuan says does not make a huge difference; and (2) l_smooth_heaviside_tau_wpxp flag in the mixing_length.F90 code, which is intended to give smoother results. Both of the flags for these changes are turned off, but these updates are BIT_CHANGING because of some minor changes to the way that factors of rho_ds_* and invrs_rho_ds_* are handled going into the diffusion.F90 subroutines. Most cases look identical in pyplotgen, but sensitive cases like arm_97 and rico look slightly different. These changes were originally in pull request #962, but because of conflicts with the master branch code base that developed, they could not be rebased and merged, so I incorporated them into this new commit. 2021-10-22 15:45:01 -05002ee6d2a1e31e43bca3e03a406917c4454cb71e67These updates incorporate some of Shixuan Zhang's changes, including:editadvance_xm_wpxp_module.F90editmixing_length.F90editadvance_wp2_wp3_module.F90editmodel_flags.F90editdiffusion.F90editadvance_windm_edsclrm_module.F90editadvance_xp2_xpyp_module.F90pdf_closure_module.F90advance_clubb_core_module.F90new_hybrid_pdf_main.F90new_pdf_main.F9062d364561a81e2b878f95a327df36a4ca4bc31491635207177000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing down CLUBB's tunable parameters into the remainder of the PDF subroutines. Everything is bit-for-bit. 2021-10-25 19:12:57 -050062d364561a81e2b878f95a327df36a4ca4bc3149Passing down CLUBB's tunable parameters into the remainder of theeditnew_hybrid_pdf_main.F90editadvance_clubb_core_module.F90editpdf_closure_module.F90editnew_pdf_main.F90advance_clubb_core_module.F90clubb_api_module.F9040315247ab8dc38382642bf30f1d96b329c1304d1635210039000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI passed down the forgotten thlp2_rad_coef tunable parameter. All bit-for-bit. 2021-10-25 20:00:39 -050040315247ab8dc38382642bf30f1d96b329c1304dI passed down the forgotten thlp2_rad_coef tunable parameter.editadvance_clubb_core_module.F90editclubb_api_module.F90diffusion.F9059c90454cd1a93522940f998c123795db4f23b171635271688000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comUncommenting diffusion.F90 k=1 lines again to fix Oracle uninit var test. I've updated the accompanying note to state clearly that the lines have no effect on model output, but I guess we need to keep the lines to avoid uninitialized variables. 2021-10-26 13:08:08 -050059c90454cd1a93522940f998c123795db4f23b17Uncommenting diffusion.F90 k=1 lines again to fix Oracle uninit var test. I've updated the accompanying note to state clearly that the lines have no effect on model output, but I guess we need to keep the lines to avoid uninitialized variables.editdiffusion.F90advance_xm_wpxp_module.F9024592ec9879d2c704c4d7301c8d18c794f2ff7441635291046000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am passing down the forgotten parameter, altitude threshold, in advance_xm_wpxp_module.F90. 2021-10-26 18:30:46 -050024592ec9879d2c704c4d7301c8d18c794f2ff744I am passing down the forgotten parameter, altitude threshold, ineditadvance_xm_wpxp_module.F90components/cam/src/physics/cam/clubb_intr.F9027c5227c6454362cb873c745fd7c69a3505239591635369265000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comUpdating for changes to CLUBB. See https://github.com/larson-group/clubb/pull/968. 2021-10-27 16:14:25 -050027c5227c6454362cb873c745fd7c69a350523959Updating for changes to CLUBB. See https://github.com/larson-group/clubb/pull/968.editcomponents/cam/src/physics/cam/clubb_intr.F90advance_wp2_wp3_module.F90advance_clubb_core_module.F90model_flags.F90clubb_api_module.F90bda6b42375dfc09907e7f9b37719b0d149f456711635369371000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding code wrapped in a flag (l_use_tke_in_K_dfsn) to use u_i'u_i' in the wp2 and wp3 eddy diffusion terms, instead of just wp2 or wp3. Relevant to CLUBB issue #920. Results are b4b when the flag is turned off, which it currently is. 2021-10-27 16:16:11 -0500bda6b42375dfc09907e7f9b37719b0d149f45671Adding code wrapped in a flag (l_use_tke_in_K_dfsn) to use u_i'u_i' in the wp2 and wp3 eddy diffusion terms, instead of just wp2 or wp3. Relevant to CLUBB issue #920.editclubb_api_module.F90editadvance_clubb_core_module.F90editadvance_wp2_wp3_module.F90editmodel_flags.F90advance_wp2_wp3_module.F90advance_clubb_core_module.F90model_flags.F90clubb_api_module.F90fecf90bda798d6330f0c3982e5f24ef5dce274a31635369371000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comUpdates as requested to the l_use_tke_in_K_dfsn code: - The name of the flag is changed to l_use_tke_in_wp2_wp3_K_dfsn - Comments are added to the main pieces of code in advance_wp2_wp3 - The flag is added to the "compatible_r8029" configurable flags file. See this comment https://github.com/larson-group/clubb/issues/920#issuecomment-931446401 and following for more information. 2021-10-27 16:16:11 -0500fecf90bda798d6330f0c3982e5f24ef5dce274a3Updates as requested to the l_use_tke_in_K_dfsn code:editadvance_clubb_core_module.F90editmodel_flags.F90editclubb_api_module.F90editadvance_wp2_wp3_module.F90output_netcdf.F90parameters_tunable.F90stats_clubb_utilities.F90clubb_api_module.F9048d34a44dac4e6c069b8edf7484da102a7b3e03c1635542624000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am committing the final stage of the "pass-down params" project. The results are bit-for-bit identical. 2021-10-29 16:23:44 -050048d34a44dac4e6c069b8edf7484da102a7b3e03cI am committing the final stage of the "pass-down params" project.editoutput_netcdf.F90editclubb_api_module.F90editparameters_tunable.F90editstats_clubb_utilities.F90silhs_api_module.F90latin_hypercube_driver_module.F90output_2D_samples_module.F90a59d8a9d971fa58d96ca0c7c0e3a8999903394011635542624000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am committing the final stage of the "pass-down params" project. The results are bit-for-bit identical. 2021-10-29 16:23:44 -0500a59d8a9d971fa58d96ca0c7c0e3a899990339401I am committing the final stage of the "pass-down params" project.editlatin_hypercube_driver_module.F90editsilhs_api_module.F90editoutput_2D_samples_module.F90advance_wp2_wp3_module.F90mixing_length.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90e21f33631a9962fc7af096d0f7c4a7a3f6ff021b1635542673000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding an option to use invrs_tau_N2_iso for C4 terms. The same invrs_tau had been used for C4 and C14 terms, so some adjustments had to be made to separate them out (this was started with an earlier commit: https://github.com/larson-group/clubb/commit/ef3be1b1378bcd1a447f3866c9f88f8cc4764233). The flag is currently set to false so results will be b4b. See also the discussion here: https://github.com/larson-group/clubb/issues/920#issuecomment-920338746 and following comments. 2021-10-29 16:24:33 -0500e21f33631a9962fc7af096d0f7c4a7a3f6ff021bAdding an option to use invrs_tau_N2_iso for C4 terms. The same invrs_tau had been used for C4 and C14 terms, so some adjustments had to be made to separate them out (this was started with an earlier commit: https://github.com/larson-group/clubb/commit/ef3be1b1378bcd1a447f3866c9f88f8cc4764233). The flag is currently set to false so results will be b4b.editadvance_wp2_wp3_module.F90editadvance_xp2_xpyp_module.F90editmixing_length.F90editadvance_clubb_core_module.F90advance_wp2_wp3_module.F90575d6fe14ed80295cce4f30a51ff3d6aac83b5ee1635542673000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comRenaming invrs_tau_zt and invrs_tauw3t to "invrs_tau_wp3_zt" in advance_wp2_wp3 to avoid confusion. This variable is only used for the wp3 C8 term, so one consistent name is simpler, and the name "invrs_tau_zt" is already used by another variable in advance_clubb_core. 2021-10-29 16:24:33 -0500575d6fe14ed80295cce4f30a51ff3d6aac83b5eeRenaming invrs_tau_zt and invrs_tauw3t to "invrs_tau_wp3_zt" in advance_wp2_wp3 to avoid confusion. This variable is only used for the wp3 C8 term, so one consistent name is simpler, and the name "invrs_tau_zt" is already used by another variable in advance_clubb_core.editadvance_wp2_wp3_module.F90mixing_length.F90b1a5dc605454ba0bd6ce90b50c1b1c4e5238daa21635542673000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding comments for clarity. 2021-10-29 16:24:33 -0500b1a5dc605454ba0bd6ce90b50c1b1c4e5238daa2Adding comments for clarity.editmixing_length.F90clubb_api_module.F903cc2a48057cff47763a8de0fc7a9c2d6bd1717821635637985000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI forgot to add this necessary subroutine call to the clubb API. 2021-10-30 18:53:05 -05003cc2a48057cff47763a8de0fc7a9c2d6bd171782I forgot to add this necessary subroutine call to the clubb API.editclubb_api_module.F90advance_wp2_wp3_module.F9043b0e9b176c2c5f8d2537b61e1f1781a147878961635789347000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comFixing a minor accounting bug related to the changes in https://github.com/larson-group/clubb/commit/987d63de489d2baa09ad6e1538b2c6dbb7551690. There was some overcounting of the relevant terms. Results are b4b since the l_use_tke_in_wp2_wp3_K_dfsn flag is false. 2021-11-01 12:55:47 -050043b0e9b176c2c5f8d2537b61e1f1781a14787896Fixing a minor accounting bug related to the changes in https://github.com/larson-group/clubb/commit/987d63de489d2baa09ad6e1538b2c6dbb7551690. There was some overcounting of the relevant terms.editadvance_wp2_wp3_module.F90components/cam/src/physics/cam/clubb_intr.F90components/cam/src/physics/cam/subcol_SILHS.F909af53143676f1f868706d65621089805e201becc1635843469000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduApplying the fix for the new CLUBB code to the developmental branch of clubb_silhs_devel. 2021-11-02 03:57:49 -05009af53143676f1f868706d65621089805e201beccApplying the fix for the new CLUBB code to the developmentaleditcomponents/cam/src/physics/cam/clubb_intr.F90editcomponents/cam/src/physics/cam/subcol_SILHS.F90components/cam/src/physics/cam/clubb_intr.F90components/cam/src/physics/cam/subcol_SILHS.F9015dbad3a48411bb76ee616c649eb070e31812d1f1636021064000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI fixed a couple of errors. 2021-11-04 05:17:44 -050015dbad3a48411bb76ee616c649eb070e31812d1fI fixed a couple of errors.editcomponents/cam/src/physics/cam/clubb_intr.F90editcomponents/cam/src/physics/cam/subcol_SILHS.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90diffusion.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90clubb_api_module.F90parameters_tunable.F90advance_windm_edsclrm_module.F900c99971894e34f471bb13a0608799da3e26fd75b1636150605000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have turned the nu_vert_res_dep family of variables into a derived type and that variable is now being passed throughout the CLUBB code, rather than accessing variables through a USE statement. Everything is 100% bit-for-bit! 2021-11-05 17:16:45 -05000c99971894e34f471bb13a0608799da3e26fd75bI have turned the nu_vert_res_dep family of variables into a derivededitadvance_wp2_wp3_module.F90editadvance_xm_wpxp_module.F90editadvance_clubb_core_module.F90editadvance_windm_edsclrm_module.F90editclubb_api_module.F90editadvance_xp2_xpyp_module.F90editparameters_tunable.F90editdiffusion.F90components/cam/src/physics/cam/clubb_intr.F90d537da58fda63a3fd7ba59c3692deb7700c6c5e61636188879000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdating for changes to CLUBB. 2021-11-06 03:54:39 -0500d537da58fda63a3fd7ba59c3692deb7700c6c5e6Updating for changes to CLUBB.editcomponents/cam/src/physics/cam/clubb_intr.F90pdf_closure_module.F90stats_zt_module.F905aad62fb6b44998c8eeea4e274d53e9f5b6fda2a1636491816000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comAdded sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90 2021-11-09 15:03:36 -06005aad62fb6b44998c8eeea4e274d53e9f5b6fda2aAdded sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90editstats_zt_module.F90editpdf_closure_module.F90advance_clubb_core_module.F90model_flags.F90pdf_closure_module.F900918704e4ca667f2dd901df9481fcab6d04ad5591636651886000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comResolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details 2021-11-11 11:31:26 -06000918704e4ca667f2dd901df9481fcab6d04ad559Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for detailseditmodel_flags.F90editadvance_clubb_core_module.F90editpdf_closure_module.F90pdf_closure_module.F9081d326f9c04198f2635a6b56b25bc395da7414351636664054000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comIncluded a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge 2021-11-11 14:54:14 -060081d326f9c04198f2635a6b56b25bc395da741435Included a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after mergeeditpdf_closure_module.F90pdf_closure_module.F90dc3c4b8f58acb3383731109218706676f789be071636664205000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comfixed a typo in pdf_closure_module.f90, line 1284 2021-11-11 14:56:45 -0600dc3c4b8f58acb3383731109218706676f789be07fixed a typo in pdf_closure_module.f90, line 1284editpdf_closure_module.F90pdf_closure_module.F903c5029210448e2a9df59b5757f5cd952d8ab41881636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comSee ticket #958 2021-11-11 15:45:54 -06003c5029210448e2a9df59b5757f5cd952d8ab4188See ticketeditpdf_closure_module.F90stats_clubb_utilities.F90pdf_closure_module.F90a75256d61b53e5e09ec2e386790c89d4e51f04721636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comadded some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to disk 2021-11-11 15:45:54 -0600a75256d61b53e5e09ec2e386790c89d4e51f0472added some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to diskeditpdf_closure_module.F90editstats_clubb_utilities.F90pdf_closure_module.F90advance_clubb_core_module.F90stats_variables.F90stats_clubb_utilities.F90model_flags.F90stats_zt_module.F90a83e91f008656f68d7535574cd90be52d82dd50f1636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comSee respective messages on the issue 958 on date 10/12/2021 2021-11-11 15:45:54 -0600a83e91f008656f68d7535574cd90be52d82dd50fSee respective messages on the issue 958 on date 10/12/2021editstats_zt_module.F90editadvance_clubb_core_module.F90editpdf_closure_module.F90editstats_variables.F90editstats_clubb_utilities.F90editmodel_flags.F90pdf_closure_module.F90stats_zt_module.F900ba99cd44f06718d995fadd8eacb1b6b191c8cf51636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comAdded sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90 2021-11-11 15:45:54 -06000ba99cd44f06718d995fadd8eacb1b6b191c8cf5Added sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90editstats_zt_module.F90editpdf_closure_module.F90advance_clubb_core_module.F90model_flags.F90pdf_closure_module.F90f4f26820fd4d03cd818e862b342716e11ea0c6731636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comResolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details 2021-11-11 15:45:54 -0600f4f26820fd4d03cd818e862b342716e11ea0c673Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for detailseditpdf_closure_module.F90editadvance_clubb_core_module.F90editmodel_flags.F90pdf_closure_module.F902b90c415701478f497ef1b01769bff21fd75e46a1636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comIncluded a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge 2021-11-11 15:45:54 -06002b90c415701478f497ef1b01769bff21fd75e46aIncluded a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after mergeeditpdf_closure_module.F90pdf_closure_module.F90e235fe78eae6527a511973ecdc46aaa4cb2b23791636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comfixed a typo in pdf_closure_module.f90, line 1284 2021-11-11 15:45:54 -0600e235fe78eae6527a511973ecdc46aaa4cb2b2379fixed a typo in pdf_closure_module.f90, line 1284editpdf_closure_module.F90advance_clubb_core_module.F90clubb_api_module.F90a3f3633376a9a95a1ddbab690425c6b71a4efbff1637038777000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing w_up_in_cloud out of advance_clubb_core 2021-11-15 22:59:37 -0600a3f3633376a9a95a1ddbab690425c6b71a4efbffPassing w_up_in_cloud out of advance_clubb_coreeditclubb_api_module.F90editadvance_clubb_core_module.F90components/cam/src/physics/cam/clubb_intr.F903eec0569a27a14548a1bd1832acdbc7b660e38171637051928000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdating clubb_intr.F90 for the changes to advance_clubb_core_api 2021-11-16 02:38:48 -06003eec0569a27a14548a1bd1832acdbc7b660e3817Updating clubb_intr.F90 for the changes to advance_clubb_core_apieditcomponents/cam/src/physics/cam/clubb_intr.F90stats_variables.F90e1572555370199b4fe0abf791462f1a0830a22f71638465215000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comfixed compiler warning regarding w_up_in_cloud 2021-12-02 11:13:35 -0600e1572555370199b4fe0abf791462f1a0830a22f7fixed compiler warning regarding w_up_in_cloudeditstats_variables.F90advance_clubb_core_module.F90fcf74be3a201e5043cabaad104cc37cdbb8c0e9d1638567586000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemove clipping from a3_coef. In principle, removing the clipping should reduce noise. In practice, it makes rico noiser but mpace_b less noisy. It also allows twp_ice to run to completion with the gfortran compiler. This commit is BIT_CHANGING. For #965. 2021-12-03 15:39:46 -0600fcf74be3a201e5043cabaad104cc37cdbb8c0e9dRemove clipping from a3_coef.editadvance_clubb_core_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90advance_windm_edsclrm_module.F90fe10a3988ec9c5ae38f9a6521364e5114303dc971639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comThese changes allow you to call the 4 clubb "advance" subroutines in any order that you want to try. In the default order (where the order is the same as found in the current version of the CLUBB master), results are bit-for-bit when compared to CLUBB master. 2021-12-17 17:36:25 -0600fe10a3988ec9c5ae38f9a6521364e5114303dc97These changes allow you to call the 4 clubb "advance" subroutines in anyeditadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90editadvance_windm_edsclrm_module.F90advance_clubb_core_module.F90da7e393336c65553c3897fdb66f276cc70ba5a581639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comPlacing the order variables in a nice, convenient place for testing use. 2021-12-17 17:36:25 -0600da7e393336c65553c3897fdb66f276cc70ba5a58Placing the order variables in a nice, convenient place for testing use.editadvance_clubb_core_module.F90advance_clubb_core_module.F908aae767c4fcc474647d6b76867a06416de8057bd1639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comI reordered advance_clubb_core so that the "Advance xp3" (which is a basic calculation of xp3 by the ansatz by default) section is moved out of the way of the "advance loop" to a point that is after advance_windm_edsclrm (or whatever will be called last in the advance loop. This change does not alter the default results. Everything is still bit-for-bit. 2021-12-17 17:36:25 -06008aae767c4fcc474647d6b76867a06416de8057bdI reordered advance_clubb_core so that the "Advance xp3" (which is aeditadvance_clubb_core_module.F90advance_clubb_core_module.F90clubb_api_module.F90advance_xm_wpxp_module.F9089ceef8b3be53379b14beba84d90cef1f9ec9a391639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comI am committing the idiot-proofing code that forces l_min_xp2_from_corr_wx and l_enable_relaxed_clipping to have opposite values (one must be true and the other must be false). In this commit, both are set to true, so the code will produce an exception. 2021-12-17 17:36:25 -060089ceef8b3be53379b14beba84d90cef1f9ec9a39I am committing the idiot-proofing code that forces l_min_xp2_from_corr_wxeditclubb_api_module.F90editadvance_xm_wpxp_module.F90editadvance_clubb_core_module.F90advance_clubb_core_module.F9051776de85578ab39a37d41b3a28771e66d58657f1639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comI am indenting the portion of the code where the advance subroutines are located within the new ordering loop. 2021-12-17 17:36:25 -060051776de85578ab39a37d41b3a28771e66d58657fI am indenting the portion of the code where the advance subroutineseditadvance_clubb_core_module.F90advance_clubb_core_module.F909ffac7f447029ffd2f8bac3d59fb93019127171e1639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comTemporarily commenting out the idiot proofing in order to run some tests ... The results from this branch are still bit-for-bit with the master branch. 2021-12-17 17:36:25 -06009ffac7f447029ffd2f8bac3d59fb93019127171eTemporarily commenting out the idiot proofing in order to run some tests ...editadvance_clubb_core_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90c587754da66182880513b7c16ccc23c289952ab51639784501000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduNow official reinstating the idiot-proofing and turning off the l_enable_relaxed_clipping flag. This commit is BIT_CHANGING 2021-12-17 17:41:41 -0600c587754da66182880513b7c16ccc23c289952ab5Now official reinstating the idiot-proofing and turning off theeditadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90advance_clubb_core_module.F90b778226f990c7e852735312d0123c76452338a211639787077000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am committing some idiot proofing in regards to the advance subroutines ordering. No index can have a value of less than 1, greater than 4, and no index can have the same value as any other index. Each adv routine order index must have a unique value. 2021-12-17 18:24:37 -0600b778226f990c7e852735312d0123c76452338a21I am committing some idiot proofing in regards to the advanceeditadvance_clubb_core_module.F90components/cam/src/physics/cam/clubb_intr.F90821bc5a0c2628d9fb13ac3f5933fd1e8fe9d98cb1639788262000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdating for the latest version of CLUBB. 2021-12-17 18:44:22 -0600821bc5a0c2628d9fb13ac3f5933fd1e8fe9d98cbUpdating for the latest version of CLUBB.editcomponents/cam/src/physics/cam/clubb_intr.F90advance_clubb_core_module.F90clubb_api_module.F901e234f56b4722f109ec9d657776244a94dadfc181640706464000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdating CLUBB to pass uprcp and vprcp into and out of advance_clubb_core. 2021-12-28 09:47:44 -06001e234f56b4722f109ec9d657776244a94dadfc18Updating CLUBB to pass uprcp and vprcp into and out of advance_clubb_core.editadvance_clubb_core_module.F90editclubb_api_module.F90advance_clubb_core_module.F90aa0da18281105ee85a148af1640952342bc058ec1640706663000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduNow that uprcp and vprcp have been passed through advance_clubb_core, I can get rid of this idiot-proofing code that stops the run when l_predict_upwp_vpwp is enabled and the PDF is in the "post" position. 2021-12-28 09:51:03 -0600aa0da18281105ee85a148af1640952342bc058ecNow that uprcp and vprcp have been passed through advance_clubb_core,editadvance_clubb_core_module.F90advance_clubb_core_module.F90advance_wp2_wp3_module.F90clubb_api_module.F90af8d23225e3393b52c07fbe123f01444d14124f01640825295000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am adding more arguments to the argument list for advance_clubb_core so that the model now runs with the PDF in the post position. Result from this change are still bit-for-bit. 2021-12-29 18:48:15 -0600af8d23225e3393b52c07fbe123f01444d14124f0I am adding more arguments to the argument list for advance_clubb_coreeditadvance_clubb_core_module.F90editadvance_wp2_wp3_module.F90editclubb_api_module.F90components/cam/src/physics/cam/clubb_intr.F90f7714d3432c0768eaa82c6a65cf24470fc066b861640884170000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am updating clubb_intr.F90 to account for recent changes to the call to advance_clubb_core_api. 2021-12-30 11:09:30 -0600f7714d3432c0768eaa82c6a65cf24470fc066b86I am updating clubb_intr.F90 to account for recent changes to the call toeditcomponents/cam/src/physics/cam/clubb_intr.F90components/cam/src/physics/cam/clubb_intr.F90224edcd49d7ddd2da841869bf61e2415a096f1bc1641508280000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAdding omitted lines to the call to advance_clubb_core_api. 2022-01-06 16:31:20 -0600224edcd49d7ddd2da841869bf61e2415a096f1bcAdding omitted lines to the call to advance_clubb_core_api.editcomponents/cam/src/physics/cam/clubb_intr.F90cime/config/e3sm/machines/config_compilers.xmlcime/config/e3sm/machines/config_machines.xml1b238fec0edfdb459fed113c86476201aaa642e81641511612000http://carson.math.uwm.edu/jenkins/user/pbroelspbroelspbroels@uwm.eduReverting to using Gfortran 8 temporarily to get things working. 2022-01-06 17:26:52 -06001b238fec0edfdb459fed113c86476201aaa642e8Reverting to using Gfortran 8 temporarily to get things working.editcime/config/e3sm/machines/config_compilers.xmleditcime/config/e3sm/machines/config_machines.xmlmodel_flags.F90af2e320388670ca0a57e2f176c1bc5d627b9098d1641839832000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comInsert print about overwriting default flags with namelist values 2022-01-10 12:37:12 -0600af2e320388670ca0a57e2f176c1bc5d627b9098dInsert print about overwriting default flags with namelist valueseditmodel_flags.F90parameters_tunable.F908f225830ad630ade0b0f818521e3420cf71da15d1641840286000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comInsert print about overwriting default parameters with namelist values 2022-01-10 12:44:46 -06008f225830ad630ade0b0f818521e3420cf71da15dInsert print about overwriting default parameters with namelist valueseditparameters_tunable.F90clubb_api_module.F90f3942b808f629c080b43dfaca5c50c6ce080ef9a1641936564000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking api version of setup_grid. larson-group/clubb#972 2022-01-11 15:29:24 -0600f3942b808f629c080b43dfaca5c50c6ce080ef9aMaking api version of setup_grid. larson-group/clubb#972editclubb_api_module.F90silhs_api_module.F903db947c8588aef8f34322cfdf19bc0b3e0e7be791642027821000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking some paramters_silhs variables available from the silhs api 2022-01-12 16:50:21 -06003db947c8588aef8f34322cfdf19bc0b3e0e7be79Making some paramters_silhs variables available from the silhs apieditsilhs_api_module.F90advance_clubb_core_module.F9065acb9b0c8906c6bd4001aa5eb2cb31b117608351642031683000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comComment out setting of fatal error when l_min_xp2_from_corr_wx = F and l_enable_relaxed_clipping = F. The goal is to allow the clubb_backwards_compatibility_gfortran_test Jenkins test to pass again. For #846. 2022-01-12 17:54:43 -060065acb9b0c8906c6bd4001aa5eb2cb31b11760835Comment out setting of fatal erroreditadvance_clubb_core_module.F90parameters_tunable.F907ec140fc6d8e5e40e4dd195f225d62cdaa8fbabe1642115849000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduThis should be BIT_CHANGING, but only because the value of Cx_min should change in the netcdf file. This will not be answer changing. 2022-01-13 17:17:29 -06007ec140fc6d8e5e40e4dd195f225d62cdaa8fbabeThis should be BIT_CHANGING, but only because the value of Cx_min should change in the netcdf file. This will not be answer changing.editparameters_tunable.F90parameters_tunable.F905bf9927ebb2fdd8006f9aee4380dd467515d2c061642119958000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduChanging the value of C_invrs_tau_shear from 0.02 to 0.15. This commit is BIT_CHANGING 2022-01-13 18:25:58 -06005bf9927ebb2fdd8006f9aee4380dd467515d2c06Changing the value of C_invrs_tau_shear from 0.02 to 0.15.editparameters_tunable.F90advance_clubb_core_module.F9004279f676a57a9710d4b60f0dafcd0c331a4f18e1642120044000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAvoiding stats call for variables that are not set when l_diag_Lscale_from_tau is not true. 2022-01-13 18:27:24 -060004279f676a57a9710d4b60f0dafcd0c331a4f18eAvoiding stats call for variables that are not set when l_diag_Lscale_from_tau is not true.editadvance_clubb_core_module.F90components/cam/src/physics/cam/clubb_intr.F90ce06da177efa476dc19c2bae854401287ff202891642197360000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdated e3sm to fit the new clubb driver api 2022-01-14 15:56:00 -0600ce06da177efa476dc19c2bae854401287ff20289Updated e3sm to fit the new clubb driver apieditcomponents/cam/src/physics/cam/clubb_intr.F90parameters_tunable.F9003f14dd627f8df25c1e8c40b407a2c60b943f9721642203316000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAdjusting the value of C_invrs_tau_shear from 0.15 to 0.16 so that CLUBB (particularly the MC3E case) completes successfully for all compiler tests. You might say that this is BIT_CHANGING. 2022-01-14 17:35:16 -060003f14dd627f8df25c1e8c40b407a2c60b943f972Adjusting the value of C_invrs_tau_shear from 0.15 to 0.16 so thateditparameters_tunable.F90mixing_length.F90advance_clubb_core_module.F90model_flags.F90clubb_api_module.F90advance_helper_module.F90constants_clubb.F90d8836de198f0c3f3457f195fb08642497dead21b1642358928000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd l_smooth_Heaviside_tau_wpxp to smooth discontinuity in invrs_tau_wpxp_zm This option calls subroutine smooth_heaviside_peskin, which implements the smooth Peskin Heaviside function. The option is turned off for now, and so the results should remain bit for bit. For #965. 2022-01-16 12:48:48 -0600d8836de198f0c3f3457f195fb08642497dead21bAdd l_smooth_Heaviside_tau_wpxp to smooth discontinuity in invrs_tau_wpxp_zmeditmodel_flags.F90editclubb_api_module.F90editadvance_helper_module.F90editadvance_clubb_core_module.F90editconstants_clubb.F90editmixing_length.F90pdf_parameter_module.F90advance_clubb_core_module.F90clubb_api_module.F904d506fc219eb83b1977f318f6b46c3a1f75f09c51642541581000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing column loop into advance_clubb_core, and adding interface for it so that we will not need to update any host models. Everything is bit-for-bit, testing all standalone cases and our cam_coarse res run. larson-group/clubb#972 2022-01-18 15:33:01 -06004d506fc219eb83b1977f318f6b46c3a1f75f09c5Pushing column loop into advance_clubb_core, and adding interface for it so that we will not need to update any host models. Everything is bit-for-bit, testing all standalone cases and our cam_coarse res run. larson-group/clubb#972editpdf_parameter_module.F90editadvance_clubb_core_module.F90editclubb_api_module.F90cime/config/e3sm/machines/config_compilers.xmlace1154e69e709b4d0d8886866e168131e21b42d1642550232000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate the config_compilers.xml for carson. I changed the flag `-lrefblas` to `-lblas` for a fix to the carson nightly tests. 2022-01-18 17:57:12 -0600ace1154e69e709b4d0d8886866e168131e21b42dUpdate the config_compilers.xml for carson.editcime/config/e3sm/machines/config_compilers.xmlclubb_api_module.F90946ca541e9acab72c5dbd52b2df8651bfc0bfb761642618464000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding l_stats check around stats stuff. This fixes the crashing when stats is disabled. larson-group/clubb#972 2022-01-19 12:54:24 -0600946ca541e9acab72c5dbd52b2df8651bfc0bfb76Adding l_stats check around stats stuff. This fixes the crashing when stats is disabled. larson-group/clubb#972editclubb_api_module.F90components/cam/src/physics/cam/clubb_intr.F90db4593f73e3fe65968cdee9579c6d6996f3f83c81642631245000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking e3sm use the single column version of advance clubb core directly, since it does not want to use the interface version. larson-group/clubb#972 2022-01-19 16:27:25 -0600db4593f73e3fe65968cdee9579c6d6996f3f83c8Making e3sm use the single column version of advance clubb core directly, since it does not want to use the interface version. larson-group/clubb#972editcomponents/cam/src/physics/cam/clubb_intr.F90clubb_api_module.F907e6744fa4864a0219f8e4a32d0d72fb2664598d91642631316000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking single and multi column versions of advance clubb core available through clubb_api. larson-group/clubb#972 2022-01-19 16:28:36 -06007e6744fa4864a0219f8e4a32d0d72fb2664598d9Making single and multi column versions of advance clubb core available through clubb_api. larson-group/clubb#972editclubb_api_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephenshttp://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrnhttp://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldhttp://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens82http://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffinhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhttp://carson.math.uwm.edu/jenkins/user/pbroelspbroelsfalse38http://carson.math.uwm.edu/jenkins/view/Branch%20View/job/branch_e3sm_test/38/36http://carson.math.uwm.edu/jenkins/view/Branch%20View/job/branch_e3sm_test/36/