BRANCHorigin/clubb_silhs_develTESTe3sm_ne4_silhs_run_gfortran_testStarted by user pbroelspbroelspbroels17f3d45e4040e92e34f6b549a0229302abbabfdb57f3d45e4040e92e34f6b549a0229302abbabfdb57refs/remotes/origin/flag_removalf3d45e4040e92e34f6b549a0229302abbabfdb57f3d45e4040e92e34f6b549a0229302abbabfdb57refs/remotes/origin/flag_removal716ecd9e153a67ca03ff5f5911eee202adab3c4b316ecd9e153a67ca03ff5f5911eee202adab3c4b3refs/remotes/origin/stats_testing16ecd9e153a67ca03ff5f5911eee202adab3c4b316ecd9e153a67ca03ff5f5911eee202adab3c4b3refs/remotes/origin/stats_testing1541429a51ebc3f3fd440aca4bbe7d1a36de05030541429a51ebc3f3fd440aca4bbe7d1a36de05030refs/remotes/origin/changes_to_not_break541429a51ebc3f3fd440aca4bbe7d1a36de05030541429a51ebc3f3fd440aca4bbe7d1a36de05030refs/remotes/origin/changes_to_not_break1589a5bb84d2469f135f7d600724cf0471a85f6cdc89a5bb84d2469f135f7d600724cf0471a85f6cdcrefs/remotes/origin/stats_to_hosts89a5bb84d2469f135f7d600724cf0471a85f6cdc89a5bb84d2469f135f7d600724cf0471a85f6cdcrefs/remotes/origin/stats_to_hosts18eb4cdd98a18cb717d699273363e808b85bf268e7eb4cdd98a18cb717d699273363e808b85bf268e7refs/remotes/origin/clubb_silhs_develeb4cdd98a18cb717d699273363e808b85bf268e7eb4cdd98a18cb717d699273363e808b85bf268e7refs/remotes/origin/clubb_silhs_develeb4cdd98a18cb717d699273363e808b85bf268e7eb4cdd98a18cb717d699273363e808b85bf268e7refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/e3sm.gitfalse#182578051949700branch_e3sm_test #1818false188125FAILURE1629138526688http://carson.math.uwm.edu/jenkins/view/Branch%20View/job/branch_e3sm_test/18/- advance_wp2_wp3_module.F90advance_clubb_core_module.F90parameter_indices.F90stats_zt_module.F90pdf_closure_module.F90stats_clubb_utilities.F90stats_variables.F90parameters_tunable.F90stats_zm_module.F90c7775211705fd48dec941135fc4a9fd44d2b98b91627323773000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comCode changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978. Related to #920.
This is BIT_CHANGING, but only because it will introduce some new output variables in the netcdf files. It will not affect results currently since the pressure diffusion coefficient is set to zero.
2021-07-26 13:22:53 -0500c7775211705fd48dec941135fc4a9fd44d2b98b9Code changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978. Related to #920.editadvance_clubb_core_module.F90editstats_clubb_utilities.F90editstats_zt_module.F90editadvance_wp2_wp3_module.F90editparameter_indices.F90editstats_variables.F90editpdf_closure_module.F90editparameters_tunable.F90editstats_zm_module.F90
- advance_wp2_wp3_module.F909da282e948a7779026d75c8251148c3db0c86e081627323773000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comFixing comment for the wp2_term_pr_dfsn subroutine. Related to #920.
2021-07-26 13:22:53 -05009da282e948a7779026d75c8251148c3db0c86e08Fixing comment for the wp2_term_pr_dfsn subroutine. Related to #920.editadvance_wp2_wp3_module.F90
- advance_wp2_wp3_module.F90f6dcf5918b70b39693d2f4c2396ddf03fb6ef8c21627323773000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comUpdating wp3 pressure diffusion term to be consistent with the Lumley 1978 formula for the perturbation pressure. For #920.
2021-07-26 13:22:53 -0500f6dcf5918b70b39693d2f4c2396ddf03fb6ef8c2Updating wp3 pressure diffusion term to be consistent with the Lumley 1978 formula for the perturbation pressure. For #920.editadvance_wp2_wp3_module.F90
- advance_clubb_core_module.F90advance_wp2_wp3_module.F90bdfc25a13cf9388a0cdba98fc9cfded02f0f4f741627323773000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comMaking requested changes to the wp2 pressure diffuion additions, including correcting some grid-level related issues. Related to #920.
2021-07-26 13:22:53 -0500bdfc25a13cf9388a0cdba98fc9cfded02f0f4f74Making requested changes to the wp2 pressure diffuion additions, including correcting some grid-level related issues. Related to #920.editadvance_clubb_core_module.F90editadvance_wp2_wp3_module.F90
- advance_clubb_core_module.F90stats_clubb_utilities.F90advance_wp2_wp3_module.F90c1c60fe744dc2e7e126babeb6548151e13d96a941627323773000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comFixing some comments.
2021-07-26 13:22:53 -0500c1c60fe744dc2e7e126babeb6548151e13d96a94Fixing some comments.editadvance_clubb_core_module.F90editstats_clubb_utilities.F90editadvance_wp2_wp3_module.F90
- pdf_closure_module.F90stats_zt_module.F902a15f13230db5f5ca0dddbda5245b0dc67dd707a1627331205000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comCorrecting a typo bug and adding some descriptive comments to two new variables. This is a BIT_CHANGING commit becuase it will affect the newly calculated variables and descriptions in the output files, but it won't affect any plotted results. Related to #920.
2021-07-26 15:26:45 -05002a15f13230db5f5ca0dddbda5245b0dc67dd707aCorrecting a typo bug and adding some descriptive comments to two new variables. This is a BIT_CHANGING commit becuase it will affect the newly calculated variables and descriptions in the output files, but it won't affect any plotted results. Related to #920.editstats_zt_module.F90editpdf_closure_module.F90
- components/cam/src/physics/clubb/new_hybrid_pdf_main.F90components/cam/src/physics/silhs/latin_hypercube_driver_module.F90components/cam/src/physics/clubb/stats_variables.F90components/cam/src/physics/cam/subcol_SILHS.F90components/cam/src/physics/silhs/silhs_api_module.F90components/cam/src/physics/clubb/clubb_api_module.F90components/cam/src/physics/cam/clubb_intr.F9056dd734bc405097dec3d397ef2039ceaa5d5688e1627409250000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comFeeding stats variables to needed subroutines
2021-07-27 13:07:30 -050056dd734bc405097dec3d397ef2039ceaa5d5688eFeeding stats variables to needed subroutineseditcomponents/cam/src/physics/cam/subcol_SILHS.F90editcomponents/cam/src/physics/cam/clubb_intr.F90editcomponents/cam/src/physics/clubb/new_hybrid_pdf_main.F90editcomponents/cam/src/physics/silhs/silhs_api_module.F90editcomponents/cam/src/physics/silhs/latin_hypercube_driver_module.F90editcomponents/cam/src/physics/clubb/stats_variables.F90editcomponents/cam/src/physics/clubb/clubb_api_module.F90
- components/cam/src/physics/cam/clubb_intr.F90467d598d02e400d292c61eb0fee6563885498d931627409250000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comFixing compiliation errors
2021-07-27 13:07:30 -0500467d598d02e400d292c61eb0fee6563885498d93Fixing compiliation errorseditcomponents/cam/src/physics/cam/clubb_intr.F90
- components/cam/src/physics/cam/clubb_intr.F904189cded5f24e9e02d441a120c48a9c37aafa3a11627409250000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comFixing compiliation errors
2021-07-27 13:07:30 -05004189cded5f24e9e02d441a120c48a9c37aafa3a1Fixing compiliation errorseditcomponents/cam/src/physics/cam/clubb_intr.F90
- nightly_test/clubb_intr.F90233e7c5c8489250b21c205d624d515cc29c11adb1627409250000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comReflecting changes to nightly tests clubb_intr
2021-07-27 13:07:30 -0500233e7c5c8489250b21c205d624d515cc29c11adbReflecting changes to nightly tests clubb_intreditnightly_test/clubb_intr.F90
- components/cam/src/physics/clubb/new_hybrid_pdf_main.F90components/cam/src/physics/silhs/silhs_api_module.F90components/cam/src/physics/silhs/latin_hypercube_driver_module.F90components/cam/src/physics/clubb/clubb_api_module.F90components/cam/src/physics/clubb/stats_variables.F90fa52ac299ce3c9302a1831245ea9b837163ac2bb1627409250000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comRemoving updated clubb and silhs directories
2021-07-27 13:07:30 -0500fa52ac299ce3c9302a1831245ea9b837163ac2bbRemoving updated clubb and silhs directorieseditcomponents/cam/src/physics/silhs/silhs_api_module.F90editcomponents/cam/src/physics/silhs/latin_hypercube_driver_module.F90editcomponents/cam/src/physics/clubb/stats_variables.F90editcomponents/cam/src/physics/clubb/clubb_api_module.F90editcomponents/cam/src/physics/clubb/new_hybrid_pdf_main.F90
- components/cam/src/physics/cam/subcol_SILHS.F90381481560de2313069533eaef92c0c47e188a7021627409250000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comFixing incorrect coding standard
2021-07-27 13:07:30 -0500381481560de2313069533eaef92c0c47e188a702Fixing incorrect coding standardeditcomponents/cam/src/physics/cam/subcol_SILHS.F90
- stats_variables.F90clubb_api_module.F903e33479b7b92dbd3b3195f0b18730302ae188bd01627409573000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comMoving the stats variables to module variables of clubb_driver.
This change means I had to modify clubb_api_module's arg list
along with other arg lists throughout clubb.
Everything compiles and results remain BFB identical.
For ticket #733.
2021-07-27 13:12:53 -05003e33479b7b92dbd3b3195f0b18730302ae188bd0Moving the stats variables to module variables of clubb_driver.editclubb_api_module.F90editstats_variables.F90
- silhs_api_module.F90latin_hypercube_driver_module.F9029b6903d922283c188dba7426812537e02c8a5f81627409573000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comMoving the stats variables to module variables of clubb_driver.
This change means I had to modify clubb_api_module's arg list
along with other arg lists throughout clubb.
Everything compiles and results remain BFB identical.
For ticket #733.
2021-07-27 13:12:53 -050029b6903d922283c188dba7426812537e02c8a5f8Moving the stats variables to module variables of clubb_driver.editlatin_hypercube_driver_module.F90editsilhs_api_module.F90
- advance_clubb_core_module.F90setup_clubb_pdf_params.F90advance_xp2_xpyp_module.F90e542998c8db09fe108f69821eef74868caba2c461627569049000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFixing coding standard viloation of lines exceeding 100 characters.
Violations were introduced as a result of changes made by ticket #733,
this commit resolves the coding standard violations.
Results BFB identical.
2021-07-29 09:30:49 -0500e542998c8db09fe108f69821eef74868caba2c46Fixing coding standard viloation of lines exceeding 100 characters.editadvance_xp2_xpyp_module.F90editsetup_clubb_pdf_params.F90editadvance_clubb_core_module.F90
- silhs_api_module.F90d5bdc8fbbb988928416a1fff23ec2592bb6142cd1627569049000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFixing coding standard viloation of lines exceeding 100 characters.
Violations were introduced as a result of changes made by ticket #733,
this commit resolves the coding standard violations.
Results BFB identical.
2021-07-29 09:30:49 -0500d5bdc8fbbb988928416a1fff23ec2592bb6142cdFixing coding standard viloation of lines exceeding 100 characters.editsilhs_api_module.F90
- advance_wp2_wp3_module.F90stats_variables.F90parameters_tunable.F90parameter_indices.F90stats_zt_module.F90b1418c5d2b27c7560b6e18d9b05837722e7b13bb1627579701000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding wp3_pr_tp (aka "negative nose" term) to wp3 equation. Related to #920.
This is not set up to change results currently, since the coefficient of the new term is zero, but it is BIT_CHANGING since it will include new output in the netcdf files.
Also includes updates to pyplotgen to accommodate the new term.
2021-07-29 12:28:21 -0500b1418c5d2b27c7560b6e18d9b05837722e7b13bbAdding wp3_pr_tp (aka "negative nose" term) to wp3 equation. Related to #920.editstats_zt_module.F90editstats_variables.F90editparameters_tunable.F90editparameter_indices.F90editadvance_wp2_wp3_module.F90
- parameters_tunable.F90advance_wp2_wp3_module.F90stats_zt_module.F903c12f9c674cc1a5d8e49b0f2c71ca8e2159fcc991627579701000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comChanging the way the new wp3_pr_tp term works, by generalizing the wp3_terp_pr_lhs subroutine. Also cleaning up comments and changing the description of the wp3_pr_tp variable in the netcdf output files, hence this commit is BIT_CHANGING, although it will not affect numerical results since the wp3_pr_tp coefficient (C_wp3_pr_tp) is set to zero.
Related to #920.
2021-07-29 12:28:21 -05003c12f9c674cc1a5d8e49b0f2c71ca8e2159fcc99Changing the way the new wp3_pr_tp term works, by generalizing the wp3_terp_pr_lhs subroutine. Also cleaning up comments and changing the description of the wp3_pr_tp variable in the netcdf output files, hence this commit is BIT_CHANGING, although it will not affect numerical results since the wp3_pr_tp coefficient (C_wp3_pr_tp) is set to zero.editstats_zt_module.F90editparameters_tunable.F90editadvance_wp2_wp3_module.F90
- setup_clubb_pdf_params.F90d7fab3c6bdd5d928a2f6c377fe38514933d91cae1627654958000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduRemoving l_interp_prescribed_params from setup_clubb_pdf_params.
The flag has been removed and so has any code underneat a logic statement
involving this statement unless it has multiple flags. The else statement
in the if block involving this flag has been set to execute without an
if block.
For ticket #916
Results are BFB identical. Additionally, complex logic statements
with the use of more flags had those flags adjusted and BFB results
were also confirmed with these changes.
2021-07-30 09:22:38 -0500d7fab3c6bdd5d928a2f6c377fe38514933d91caeRemoving l_interp_prescribed_params from setup_clubb_pdf_params.editsetup_clubb_pdf_params.F90
- calendar.F90clip_explicit.F90clubb_api_module.F90input_reader.F90diagnose_correlations_module.F90grid_class.F90setup_clubb_pdf_params.F90mono_flux_limiter.F90advance_wp2_wp3_module.F90mixing_length.F90file_functions.F90advance_xp2_xpyp_module.F90output_grads.F90stats_rad_zt_module.F90stats_rad_zm_module.F90pdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F90code_timer_module.F90corr_varnce_module.F90precipitation_fraction.F90clip_semi_implicit.F90numerical_check.F90output_netcdf.F90mt95.f90pdf_parameter_module.F90parameters_tunable.F90sponge_layer_damping.F90advance_xp3_module.F90advance_clubb_core_module.F90stats_zt_module.F90fill_holes.F90interpolation.F90stats_clubb_utilities.F90stats_zm_module.F90sfc_varnce_module.F90matrix_operations.F903f4568e6d528cb591d7bbdd4b36faea5c65ab97d1627927021000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduAdding comments labeling subroutine calls with intent.
Goes all the way up until stats_clubb_utils.
BFB identical.
For ticket #942.
2021-08-02 12:57:01 -05003f4568e6d528cb591d7bbdd4b36faea5c65ab97dAdding comments labeling subroutine calls with intent.editpdf_closure_module.F90editsfc_varnce_module.F90editclip_explicit.F90editinterpolation.F90editadvance_wp2_wp3_module.F90editoutput_netcdf.F90editstats_clubb_utilities.F90editstats_zt_module.F90editmixing_length.F90editprecipitation_fraction.F90editoutput_grads.F90editstats_rad_zt_module.F90editnumerical_check.F90editstats_rad_zm_module.F90editmatrix_operations.F90editclubb_api_module.F90editadvance_xp3_module.F90editclip_semi_implicit.F90editadvance_clubb_core_module.F90editadvance_xp2_xpyp_module.F90editsetup_clubb_pdf_params.F90editcalendar.F90editpdf_parameter_module.F90editfile_functions.F90editadg1_adg2_3d_luhar_pdf.F90editcode_timer_module.F90editmt95.f90editdiagnose_correlations_module.F90editparameters_tunable.F90editcorr_varnce_module.F90editfill_holes.F90editmono_flux_limiter.F90editgrid_class.F90editsponge_layer_damping.F90editinput_reader.F90editstats_zm_module.F90
- output_grads.F90stats_rad_zm_module.F90stats_rad_zt_module.F90output_netcdf.F90stats_lh_zt_module.F90stats_lh_sfc_module.F90stats_type_utilities.F90stats_clubb_utilities.F908ae8997357c4cf9424fff53c57a41f07d0e589a51628008649000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduAdding intent labels for subroutines throughout clubb.
All calls to subroutines now have intent comments next to them
all the way up through stats_sfc_module.
Results are BFB identical.
For ticket #942.
2021-08-03 11:37:29 -05008ae8997357c4cf9424fff53c57a41f07d0e589a5Adding intent labels for subroutines throughout clubb.editoutput_netcdf.F90editstats_clubb_utilities.F90editstats_rad_zm_module.F90editstats_type_utilities.F90editstats_lh_zt_module.F90editoutput_grads.F90editstats_lh_sfc_module.F90editstats_rad_zt_module.F90
- advance_wp2_wp3_module.F90de5061956ab80fe70758fae3535569ac2577ffca1628009021000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemoving unnecessary constant from use statement
2021-08-03 11:43:41 -0500de5061956ab80fe70758fae3535569ac2577ffcaRemoving unnecessary constant from use statementeditadvance_wp2_wp3_module.F90
- diagnostic_v2_0/draw_clubb_budget.pydiagnostic_v2_0/draw_plots_hoz_3D.pydiagnostic_v2_0/E3SM_CLUBB_diag.pydiagnostic_v2_0/draw_plots_hoz_2D.pydiagnostic_v2_0/draw_large_scale.pydiagnostic_v2_0/function_cal_mean.pydiagnostic_v2_0/analyze_sensitivity_matrix.py64c6ecec553bf58453380154a81f3849b262da5f1628061213000http://carson.math.uwm.edu/jenkins/user/guozhunguozhunguozhun@lasg.iap.ac.cnUpdate the diagnostic. Put white boxes on global plot for all regions. Issue #36.
2021-08-04 02:13:33 -050064c6ecec553bf58453380154a81f3849b262da5fUpdate the diagnostic. Put white boxes on global plot for all regions. Issue #36.editdiagnostic_v2_0/E3SM_CLUBB_diag.pyeditdiagnostic_v2_0/draw_plots_hoz_3D.pyeditdiagnostic_v2_0/draw_large_scale.pyeditdiagnostic_v2_0/draw_plots_hoz_2D.pyeditdiagnostic_v2_0/draw_clubb_budget.pyeditdiagnostic_v2_0/analyze_sensitivity_matrix.pyeditdiagnostic_v2_0/function_cal_mean.py
- parameters_tunable.F9031547c8162b2ca222d55734a83f0275949b45b4d1628617949000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_nu_grid_dependent as requested.
For ticket #926.
Results are BFB identical.
2021-08-10 12:52:29 -050031547c8162b2ca222d55734a83f0275949b45b4dEliminating l_nu_grid_dependent as requested.editparameters_tunable.F90
- parameters_tunable.F90advance_clubb_core_module.F906e5b373349a82f025de7446b87f5bfd28476e05c1628620641000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_use_buoy_mod_Km_zm.
For ticket #926
if we use a buoyancy-modified expression for Km_zm.
Results are BFB identical.
2021-08-10 13:37:21 -05006e5b373349a82f025de7446b87f5bfd28476e05cEliminating l_use_buoy_mod_Km_zm.editparameters_tunable.F90editadvance_clubb_core_module.F90
- advance_clubb_core_module.F90advance_xp2_xpyp_module.F90c77d1e61d3b579d49e0fd2ccfe75479b651141741628624038000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_iter_xp2_xpyp flag.
For ticket #926.
Results are BFB identical.
2021-08-10 14:33:58 -0500c77d1e61d3b579d49e0fd2ccfe75479b65114174Eliminating l_iter_xp2_xpyp flag.editadvance_xp2_xpyp_module.F90editadvance_clubb_core_module.F90
- advance_clubb_core_module.F9076a87a65732f989e80d89d8cbf1755cc345985c71628702483000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_apply_rule_to_pdf_params flag.
For ticket #926.
Results are BFB identical.
2021-08-11 12:21:23 -050076a87a65732f989e80d89d8cbf1755cc345985c7Eliminating l_apply_rule_to_pdf_params flag.editadvance_clubb_core_module.F90
- mean_adv.F905d26a06857f44e9dacecd3a90398832306a35d441628703668000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_ub_const_deriv flag.
For ticket #926.
Results are BFB identical.
2021-08-11 12:41:08 -05005d26a06857f44e9dacecd3a90398832306a35d44Eliminating l_ub_const_deriv flag.editmean_adv.F90
- interpolation.F908eafa1e949712db4690b67cdc67ecb4e1aa0d0fc1628705685000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_equation_21 flag.
For ticket #926.
Results are BFB identical
2021-08-11 13:14:45 -05008eafa1e949712db4690b67cdc67ecb4e1aa0d0fcEliminating l_equation_21 flag.editinterpolation.F90
- advance_wp2_wp3_module.F90277403a3256e3d2bc78d7689c6cbf46db2779d381628708452000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_wp3_2nd_buoyancy flag.
Code surrounding the flag is still present.
For ticket #926.
Results are BFB identical.
2021-08-11 14:00:52 -0500277403a3256e3d2bc78d7689c6cbf46db2779d38Eliminating l_wp3_2nd_buoyancy flag.editadvance_wp2_wp3_module.F90
- advance_clubb_core_module.F909072ea2f2525fae365156d81b3868c5fa7649e8a1628710372000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_refine_grid_in_cloud and l_interactive_refined.
For ticket #926.
Results are BFB identical.
2021-08-11 14:32:52 -05009072ea2f2525fae365156d81b3868c5fa7649e8aEliminating l_refine_grid_in_cloud and l_interactive_refined.editadvance_clubb_core_module.F90
- advance_clubb_core_module.F90advance_xp2_xpyp_module.F90bf0a2f0ffe74c69148a533e47f60db8ccf1fab4f1628713599000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_use_experimental_term_pr2 and l_use_vert_avg_winds
For ticket #926
Results are BFB identical.
2021-08-11 15:26:39 -0500bf0a2f0ffe74c69148a533e47f60db8ccf1fab4fEliminating l_use_experimental_term_pr2 and l_use_vert_avg_windseditadvance_xp2_xpyp_module.F90editadvance_clubb_core_module.F90
- advance_clubb_core_module.F90advance_wp2_wp3_module.F90model_flags.F9096b8289cf47870ece5fb23fc50008a2919be70331628777541000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_use_wp3_pr3 flag.
For ticket #926.
Results are BFB identical.
2021-08-12 09:12:21 -050096b8289cf47870ece5fb23fc50008a2919be7033Eliminating l_use_wp3_pr3 flag.editmodel_flags.F90editadvance_clubb_core_module.F90editadvance_wp2_wp3_module.F90
- advance_wp2_wp3_module.F90output_netcdf.F90parameters_tunable.F90model_flags.F90advance_xm_wpxp_module.F904bf75cca24dd38c8a3ce3d62332efe876b9ae9a01628781691000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_clip_semi_implicit flag.
For ticket #926.
This commit is BIT_CHANGING due to how the flag needed to be removed.
More details on why this commit is bit changing can be seen on the ticket page.
2021-08-12 10:21:31 -05004bf75cca24dd38c8a3ce3d62332efe876b9ae9a0Eliminating l_clip_semi_implicit flag.editmodel_flags.F90editoutput_netcdf.F90editadvance_xm_wpxp_module.F90editparameters_tunable.F90editadvance_wp2_wp3_module.F90
- advance_clubb_core_module.F90numerical_check.F90stats_type_utilities.F90c500b18f4ca3e29435b68642ab71147d1334683e1628783267000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduAdding intent labels for subroutines throughout clubb.
Remaining files now have intent comments for subroutines.
Additionally, all lines are now less than 100 characters.
For ticket #942.
Results are BFB identical.
2021-08-12 10:47:47 -0500c500b18f4ca3e29435b68642ab71147d1334683eAdding intent labels for subroutines throughout clubb.editnumerical_check.F90editadvance_clubb_core_module.F90editstats_type_utilities.F90
- components/cam/src/physics/clubb/advance_clubb_core_module.F90components/cam/src/physics/clubb/output_netcdf.F90components/cam/src/physics/clubb/parameters_tunable.F90components/cam/src/physics/clubb/advance_xp2_xpyp_module.F90components/cam/src/physics/clubb/clubb_api_module.F90components/cam/src/physics/silhs/silhs_api_module.F90components/cam/src/physics/cam/subcol_SILHS.F90components/cam/src/physics/clubb/model_flags.F90components/cam/src/physics/clubb/parameter_indices.F90components/cam/src/physics/silhs/latin_hypercube_driver_module.F90components/cam/src/physics/silhs/output_2D_samples_module.F90components/cam/src/physics/clubb/stats_clubb_utilities.F90components/cam/src/physics/cam/clubb_intr.F90adb0a20c5c54dfe7031121a3299214e349baab2e1628881608000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comCommiting to test host models
2021-08-13 14:06:48 -0500adb0a20c5c54dfe7031121a3299214e349baab2eCommiting to test host modelseditcomponents/cam/src/physics/clubb/parameters_tunable.F90editcomponents/cam/src/physics/silhs/latin_hypercube_driver_module.F90editcomponents/cam/src/physics/clubb/clubb_api_module.F90editcomponents/cam/src/physics/clubb/stats_clubb_utilities.F90editcomponents/cam/src/physics/cam/clubb_intr.F90editcomponents/cam/src/physics/clubb/model_flags.F90editcomponents/cam/src/physics/clubb/advance_clubb_core_module.F90editcomponents/cam/src/physics/clubb/parameter_indices.F90editcomponents/cam/src/physics/silhs/silhs_api_module.F90editcomponents/cam/src/physics/cam/subcol_SILHS.F90editcomponents/cam/src/physics/clubb/output_netcdf.F90editcomponents/cam/src/physics/silhs/output_2D_samples_module.F90editcomponents/cam/src/physics/clubb/advance_xp2_xpyp_module.F90
- components/cam/src/physics/clubb/advance_clubb_core_module.F90components/cam/src/physics/silhs/latin_hypercube_driver_module.F90components/cam/src/physics/clubb/output_netcdf.F90components/cam/src/physics/clubb/parameters_tunable.F90components/cam/src/physics/clubb/advance_xp2_xpyp_module.F90components/cam/src/physics/silhs/output_2D_samples_module.F90components/cam/src/physics/clubb/clubb_api_module.F90components/cam/src/physics/silhs/silhs_api_module.F90components/cam/src/physics/clubb/model_flags.F90components/cam/src/physics/clubb/stats_clubb_utilities.F90components/cam/src/physics/clubb/parameter_indices.F90eb4cdd98a18cb717d699273363e808b85bf268e71628881608000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comReverting changes to clubb and silhs
2021-08-13 14:06:48 -0500eb4cdd98a18cb717d699273363e808b85bf268e7Reverting changes to clubb and silhseditcomponents/cam/src/physics/clubb/parameters_tunable.F90editcomponents/cam/src/physics/clubb/parameter_indices.F90editcomponents/cam/src/physics/clubb/model_flags.F90editcomponents/cam/src/physics/clubb/advance_xp2_xpyp_module.F90editcomponents/cam/src/physics/clubb/clubb_api_module.F90editcomponents/cam/src/physics/silhs/latin_hypercube_driver_module.F90editcomponents/cam/src/physics/clubb/advance_clubb_core_module.F90editcomponents/cam/src/physics/clubb/output_netcdf.F90editcomponents/cam/src/physics/silhs/silhs_api_module.F90editcomponents/cam/src/physics/silhs/output_2D_samples_module.F90editcomponents/cam/src/physics/clubb/stats_clubb_utilities.F90
githttp://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeeganhttp://carson.math.uwm.edu/jenkins/user/guozhunguozhunhttp://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskhttp://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephenshttp://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens82http://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse19http://carson.math.uwm.edu/jenkins/view/Branch%20View/job/branch_e3sm_test/19/17http://carson.math.uwm.edu/jenkins/view/Branch%20View/job/branch_e3sm_test/17/