TESTclubb_nvhpc_gpu_vs_cpu_diffnessBRANCHorigin/remove_err_codeStarted by user Steffen DomkesdomkeSteffen Domke21479e716a0558ab22aeb6d38426bb9735d0728d97079e716a0558ab22aeb6d38426bb9735d0728d970refs/remotes/origin/multicol_clubb_79e716a79e716a0558ab22aeb6d38426bb9735d0728d97079e716a0558ab22aeb6d38426bb9735d0728d970refs/remotes/origin/multicol_clubb_79e716a634b16d833e86ad23ef6ea81de67c38c596ebccd254b16d833e86ad23ef6ea81de67c38c596ebccd25refs/remotes/origin/testing_tmp4b16d833e86ad23ef6ea81de67c38c596ebccd254b16d833e86ad23ef6ea81de67c38c596ebccd25refs/remotes/origin/testing_tmp620186c0953e7f6297679083156ead9f5b00da48630186c0953e7f6297679083156ead9f5b00da4863refs/remotes/origin/thlm_spike_fix20186c0953e7f6297679083156ead9f5b00da48630186c0953e7f6297679083156ead9f5b00da4863refs/remotes/origin/thlm_spike_fix2104d3cc675ec94b531a9a6524af8e6ed3f2492b98a6d3cc675ec94b531a9a6524af8e6ed3f2492b98a6refs/remotes/origin/quick_gpu_fixd3cc675ec94b531a9a6524af8e6ed3f2492b98a6d3cc675ec94b531a9a6524af8e6ed3f2492b98a6refs/remotes/origin/quick_gpu_fix21783c37a02cf80bd754721d60542518fd8b9b8517083c37a02cf80bd754721d60542518fd8b9b85170refs/remotes/origin/multicol_clubb_83c37a083c37a02cf80bd754721d60542518fd8b9b8517083c37a02cf80bd754721d60542518fd8b9b85170refs/remotes/origin/multicol_clubb_83c37a033350d974e95a49be504e678329005f4daa70d2f80a50d974e95a49be504e678329005f4daa70d2f80arefs/remotes/origin/merge_cons_remapping50d974e95a49be504e678329005f4daa70d2f80a50d974e95a49be504e678329005f4daa70d2f80arefs/remotes/origin/merge_cons_remapping31579bf58c7473bd49baffd9ba65253f4a67186346c79bf58c7473bd49baffd9ba65253f4a67186346crefs/remotes/origin/fix_wp2_min_array79bf58c7473bd49baffd9ba65253f4a67186346c79bf58c7473bd49baffd9ba65253f4a67186346crefs/remotes/origin/fix_wp2_min_array1034c05e3d29e153deec2a51bf670c18be2ce88bbc04c05e3d29e153deec2a51bf670c18be2ce88bbc0refs/remotes/origin/spack_updates4c05e3d29e153deec2a51bf670c18be2ce88bbc04c05e3d29e153deec2a51bf670c18be2ce88bbc0refs/remotes/origin/spack_updates161e9df61765c575546be16548d8ffb96bc03c2cef3e9df61765c575546be16548d8ffb96bc03c2cef3refs/remotes/origin/nightly_clubb_plotse9df61765c575546be16548d8ffb96bc03c2cef3e9df61765c575546be16548d8ffb96bc03c2cef3refs/remotes/origin/nightly_clubb_plots171d8af6677bc8cc61a5063a6315caff68eabbeb171d8af6677bc8cc61a5063a6315caff68eabbeb171refs/remotes/origin/ticket_977d8af6677bc8cc61a5063a6315caff68eabbeb171d8af6677bc8cc61a5063a6315caff68eabbeb171refs/remotes/origin/ticket_9773168444ca34df09cef8305616bbfacf1f46cc826d318444ca34df09cef8305616bbfacf1f46cc826d31refs/remotes/origin/change_l_min_wp2_from_corr_wx_to_False8444ca34df09cef8305616bbfacf1f46cc826d318444ca34df09cef8305616bbfacf1f46cc826d31refs/remotes/origin/change_l_min_wp2_from_corr_wx_to_False2706895a7014837d519e1d22e416bef057802f39fe16895a7014837d519e1d22e416bef057802f39fe1refs/remotes/origin/fix_binormal_correlation_clipping6895a7014837d519e1d22e416bef057802f39fe16895a7014837d519e1d22e416bef057802f39fe1refs/remotes/origin/fix_binormal_correlation_clipping2195fc909222271e380f0e34c4efd7e58cb41cb85dc5fc909222271e380f0e34c4efd7e58cb41cb85dcrefs/remotes/origin/multicol_clubb5fc909222271e380f0e34c4efd7e58cb41cb85dc5fc909222271e380f0e34c4efd7e58cb41cb85dcrefs/remotes/origin/multicol_clubb3084d3661b9957da4cbe3e0da4c9cff253f5be079674d3661b9957da4cbe3e0da4c9cff253f5be07967refs/remotes/origin/multi_col_output_update4d3661b9957da4cbe3e0da4c9cff253f5be079674d3661b9957da4cbe3e0da4c9cff253f5be07967refs/remotes/origin/multi_col_output_update66fa32653f94a5c0392a6eb44bcbcc3629430def8cfa32653f94a5c0392a6eb44bcbcc3629430def8crefs/remotes/origin/clubb_ghost_exorcismfa32653f94a5c0392a6eb44bcbcc3629430def8cfa32653f94a5c0392a6eb44bcbcc3629430def8crefs/remotes/origin/clubb_ghost_exorcism21579d477c4d9b0d4f51315cf11b665a6cdf54ec7fa79d477c4d9b0d4f51315cf11b665a6cdf54ec7farefs/remotes/origin/multicol_clubb_79d477c79d477c4d9b0d4f51315cf11b665a6cdf54ec7fa79d477c4d9b0d4f51315cf11b665a6cdf54ec7farefs/remotes/origin/multicol_clubb_79d477c4c2430410e13a733d23852dd5abc08bbc6b02307bc2430410e13a733d23852dd5abc08bbc6b02307brefs/remotes/origin/feeding_stats_through_arg_listc2430410e13a733d23852dd5abc08bbc6b02307bc2430410e13a733d23852dd5abc08bbc6b02307brefs/remotes/origin/feeding_stats_through_arg_list216f1b8dad34e5d214ef354d3603446ef7f7d9d1813f1b8dad34e5d214ef354d3603446ef7f7d9d1813refs/remotes/origin/multicol_clubb_f1b8dadf1b8dad34e5d214ef354d3603446ef7f7d9d1813f1b8dad34e5d214ef354d3603446ef7f7d9d1813refs/remotes/origin/multicol_clubb_f1b8dad3386e3bbf3ef436357dc36a3bf4d1b995304d090f286e3bbf3ef436357dc36a3bf4d1b995304d090f28refs/remotes/origin/remove_err_code6e3bbf3ef436357dc36a3bf4d1b995304d090f286e3bbf3ef436357dc36a3bf4d1b995304d090f28refs/remotes/origin/remove_err_code190bf163dbde7f4829564cfb8fee4409ca8892449a6bf163dbde7f4829564cfb8fee4409ca8892449a6refs/remotes/origin/ticket_1174bf163dbde7f4829564cfb8fee4409ca8892449a6bf163dbde7f4829564cfb8fee4409ca8892449a6refs/remotes/origin/ticket_11741854cc19469106258d054f024949f31c7cbf12aec7c4cc19469106258d054f024949f31c7cbf12aec7crefs/remotes/origin/ticket_11524cc19469106258d054f024949f31c7cbf12aec7c4cc19469106258d054f024949f31c7cbf12aec7crefs/remotes/origin/ticket_1152689371db00c43ef6f47c11c9efbfe310d5947b058a9371db00c43ef6f47c11c9efbfe310d5947b058arefs/remotes/origin/small_acc_tweaks9371db00c43ef6f47c11c9efbfe310d5947b058a9371db00c43ef6f47c11c9efbfe310d5947b058arefs/remotes/origin/small_acc_tweaks3268c49e64f21fc44e58d54437fdb9bcd49a011edcb8c49e64f21fc44e58d54437fdb9bcd49a011edcbrefs/remotes/origin/gpu_diffness_testfix8c49e64f21fc44e58d54437fdb9bcd49a011edcb8c49e64f21fc44e58d54437fdb9bcd49a011edcbrefs/remotes/origin/gpu_diffness_testfix253757d942fa1a8e9f1769ee5f7ef55a0c310f8f80f757d942fa1a8e9f1769ee5f7ef55a0c310f8f80frefs/remotes/origin/multi_col_mirror_test757d942fa1a8e9f1769ee5f7ef55a0c310f8f80f757d942fa1a8e9f1769ee5f7ef55a0c310f8f80frefs/remotes/origin/multi_col_mirror_test5027ea997494b23a928f32489161280adff334596e27ea997494b23a928f32489161280adff334596erefs/remotes/origin/py3_check_budget27ea997494b23a928f32489161280adff334596e27ea997494b23a928f32489161280adff334596erefs/remotes/origin/py3_check_budget701ac4d6b3f57c2175acb0338fa7cf5f8fc41c49081ac4d6b3f57c2175acb0338fa7cf5f8fc41c4908refs/remotes/origin/grid_interp_improvment1ac4d6b3f57c2175acb0338fa7cf5f8fc41c49081ac4d6b3f57c2175acb0338fa7cf5f8fc41c4908refs/remotes/origin/grid_interp_improvment319f243c7212be4818860ddae4a71982455bacbd1b5f243c7212be4818860ddae4a71982455bacbd1b5refs/remotes/origin/add_horz_tke_holeFillingf243c7212be4818860ddae4a71982455bacbd1b5f243c7212be4818860ddae4a71982455bacbd1b5refs/remotes/origin/add_horz_tke_holeFilling29356097f69b75fc95109ebf13f0753abf74e6dc86156097f69b75fc95109ebf13f0753abf74e6dc861refs/remotes/origin/clubb_driver_semi_gpuization_part456097f69b75fc95109ebf13f0753abf74e6dc86156097f69b75fc95109ebf13f0753abf74e6dc861refs/remotes/origin/clubb_driver_semi_gpuization_part4167d91585f50959eee4d0550e98b3887bde6de4310dd91585f50959eee4d0550e98b3887bde6de4310drefs/remotes/origin/mono_flux_optimizationsd91585f50959eee4d0550e98b3887bde6de4310dd91585f50959eee4d0550e98b3887bde6de4310drefs/remotes/origin/mono_flux_optimizations17300ff5e2ed346cb382fbdfe7556f0581f92d2a86500ff5e2ed346cb382fbdfe7556f0581f92d2a865refs/remotes/origin/setup_routine_gpuization00ff5e2ed346cb382fbdfe7556f0581f92d2a86500ff5e2ed346cb382fbdfe7556f0581f92d2a865refs/remotes/origin/setup_routine_gpuization2319c67cc1a2acd6e009fdd0e7d0ae5d10bbce6ec179c67cc1a2acd6e009fdd0e7d0ae5d10bbce6ec17refs/remotes/origin/clubb_driver_semi_gpuization_part29c67cc1a2acd6e009fdd0e7d0ae5d10bbce6ec179c67cc1a2acd6e009fdd0e7d0ae5d10bbce6ec17refs/remotes/origin/clubb_driver_semi_gpuization_part254482f6cfeafb97563bfd1f5c3f4f19a85a98b1d0f482f6cfeafb97563bfd1f5c3f4f19a85a98b1d0frefs/remotes/origin/broken_uninit_branch482f6cfeafb97563bfd1f5c3f4f19a85a98b1d0f482f6cfeafb97563bfd1f5c3f4f19a85a98b1d0frefs/remotes/origin/broken_uninit_branch169c9c2925fe242e3154deac843a662452483698edbc9c2925fe242e3154deac843a662452483698edbrefs/remotes/origin/riZm_calc4c9c2925fe242e3154deac843a662452483698edbc9c2925fe242e3154deac843a662452483698edbrefs/remotes/origin/riZm_calc417463422545ae572c8cc0391f5aa61138d3af5d8fe463422545ae572c8cc0391f5aa61138d3af5d8fe4refs/remotes/origin/riZm_calc563422545ae572c8cc0391f5aa61138d3af5d8fe463422545ae572c8cc0391f5aa61138d3af5d8fe4refs/remotes/origin/riZm_calc5193585114a95636f77a9a2c63ec87a4d5af0ee98531585114a95636f77a9a2c63ec87a4d5af0ee98531refs/remotes/origin/monoflux_test585114a95636f77a9a2c63ec87a4d5af0ee98531585114a95636f77a9a2c63ec87a4d5af0ee98531refs/remotes/origin/monoflux_test218cc7b70fa19be8d79d89ec4673afa3ca20fcc96bccc7b70fa19be8d79d89ec4673afa3ca20fcc96bcrefs/remotes/origin/multicol_clubb_cc7b70fcc7b70fa19be8d79d89ec4673afa3ca20fcc96bccc7b70fa19be8d79d89ec4673afa3ca20fcc96bcrefs/remotes/origin/multicol_clubb_cc7b70f288b5c624cb4094643138450a3a839cbe8a2f918c6cb5c624cb4094643138450a3a839cbe8a2f918c6crefs/remotes/origin/fix_wp2_clippingb5c624cb4094643138450a3a839cbe8a2f918c6cb5c624cb4094643138450a3a839cbe8a2f918c6crefs/remotes/origin/fix_wp2_clipping2541dcff7e314e41861f8d8cfbd434eb194c6f144181dcff7e314e41861f8d8cfbd434eb194c6f14418refs/remotes/origin/clubb_driver_semi_gpuization_part4_rebase1dcff7e314e41861f8d8cfbd434eb194c6f144181dcff7e314e41861f8d8cfbd434eb194c6f14418refs/remotes/origin/clubb_driver_semi_gpuization_part4_rebase17883fceff0ccd7dfa94a7095ddbf84e9e273bbddcc83fceff0ccd7dfa94a7095ddbf84e9e273bbddccrefs/remotes/origin/riZm_calc683fceff0ccd7dfa94a7095ddbf84e9e273bbddcc83fceff0ccd7dfa94a7095ddbf84e9e273bbddccrefs/remotes/origin/riZm_calc63242469618844963ff7c026fd0a863ceaa3ff3e58f82469618844963ff7c026fd0a863ceaa3ff3e58f8refs/remotes/origin/clubb_performance_testing2469618844963ff7c026fd0a863ceaa3ff3e58f82469618844963ff7c026fd0a863ceaa3ff3e58f8refs/remotes/origin/clubb_performance_testing1969e511b08381f4a6a583fb76f9de1f4b7c933e1dc9e511b08381f4a6a583fb76f9de1f4b7c933e1dcrefs/remotes/origin/mono_flux_optimizations_new9e511b08381f4a6a583fb76f9de1f4b7c933e1dc9e511b08381f4a6a583fb76f9de1f4b7c933e1dcrefs/remotes/origin/mono_flux_optimizations_new18741bc3c222c8719acc68e5924bf8f65e4521572c241bc3c222c8719acc68e5924bf8f65e4521572c2refs/remotes/origin/stats_removal41bc3c222c8719acc68e5924bf8f65e4521572c241bc3c222c8719acc68e5924bf8f65e4521572c2refs/remotes/origin/stats_removal221c22703ee053fefa8ae3a19bc317a35f4a2c9ad26c22703ee053fefa8ae3a19bc317a35f4a2c9ad26refs/remotes/origin/ticket_1166c22703ee053fefa8ae3a19bc317a35f4a2c9ad26c22703ee053fefa8ae3a19bc317a35f4a2c9ad26refs/remotes/origin/ticket_1166184bf54ede1394cb1706dac50e463e7907036e71adebf54ede1394cb1706dac50e463e7907036e71aderefs/remotes/origin/masterbf54ede1394cb1706dac50e463e7907036e71adebf54ede1394cb1706dac50e463e7907036e71aderefs/remotes/origin/master191595daaf07141d1d4946deca3a5a877f7ad667e1b595daaf07141d1d4946deca3a5a877f7ad667e1brefs/remotes/origin/copyout_nuke595daaf07141d1d4946deca3a5a877f7ad667e1b595daaf07141d1d4946deca3a5a877f7ad667e1brefs/remotes/origin/copyout_nuke6e3bbf3ef436357dc36a3bf4d1b995304d090f286e3bbf3ef436357dc36a3bf4d1b995304d090f28refs/remotes/origin/remove_err_codehttps://github.com/larson-group/clubb.gitfalse#3386494831102164branch_clubb_test #338338false3386773SUCCESS1739984482783http://carson.math.uwm.edu/jenkins/view/Branch%20View/job/branch_clubb_test/338/jenkins_tests/clubb_monoflux_CPU_vs_GPU_diff/Jenkinsfilesrc/SILHS/silhs_api_module.F90src/SILHS/latin_hypercube_driver_module.F90src/SILHS/transform_to_pdf_module.F90src/CLUBB_core/pdf_utilities.F90src/soil_vegetation.F90jenkins_tests/clubb_nvhpc_gpu_vs_cpu_diffness/Jenkinsfilesrc/CLUBB_core/advance_clubb_core_module.F90jenkins_tests/clubb_plot_nvhpc_gpu_vs_cpu/Jenkinsfilesrc/CLUBB_core/output_netcdf.F90src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F90run_scripts/test_monoflux_limiter_GPU.pysrc/CLUBB_core/mono_flux_limiter.F90jenkins_tests/clubb_nvhpc_gpu_column_mirror_test/Jenkinsfilerun_scripts/check_multi_col_error.pybb0b6c6de3c0b80ef8599dc9ea18219146ddb20c1731982903000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb Driver Semi GPUization Part4 (#1209) * Initial GPUization, and testing multi_col output method as single precision. * advance_clubb_core tweaks * Adding radht acc update * Updates * Adding new flags to the mono_flux test to prevent CPU and GPU divergence which breaks it. * Small changes and improvements. * Making new monoflux test lines * Reworking some SILHS GPUization to make it more similar to the GPU code in the rest of clubb. This adds some extra parts that run on GPUs, so it is BIT_CHANGING * Cleanup and comment update * Cleanup * Removing DCUDA flag from compile config scripts to help GPU and CPU results match for silhs cases * Removing accidentally added file. * Updating script * Updating script * Updating script * Updating tolerance in script to handle rico_silhs differences, and hopefully final GPU updates * Small cleanup * Adding option to multi_col diff check script to scale the differences by the field avg. This is only needed (so far) for thlm differences that are slightly too large * Testing gpu lock method * Adding GPU locking to rest of GPU tests. * Small fixes 2024-11-18 20:21:43 -0600bb0b6c6de3c0b80ef8599dc9ea18219146ddb20cClubb Driver Semi GPUization Part4 (#1209)editsrc/CLUBB_core/pdf_utilities.F90editsrc/clubb_driver.F90editsrc/soil_vegetation.F90editjenkins_tests/clubb_nvhpc_gpu_column_mirror_test/Jenkinsfileeditjenkins_tests/clubb_plot_nvhpc_gpu_vs_cpu/Jenkinsfileeditsrc/SILHS/latin_hypercube_driver_module.F90editsrc/SILHS/silhs_api_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/SILHS/transform_to_pdf_module.F90editjenkins_tests/clubb_monoflux_CPU_vs_GPU_diff/Jenkinsfileeditjenkins_tests/clubb_nvhpc_gpu_vs_cpu_diffness/Jenkinsfileeditsrc/CLUBB_core/clubb_api_module.F90editrun_scripts/test_monoflux_limiter_GPU.pyeditsrc/CLUBB_core/mono_flux_limiter.F90editsrc/CLUBB_core/output_netcdf.F90editrun_scripts/check_multi_col_error.pyutilities/sens_matrix/create_figs.py90da93a5bb3dc5a7b27f02b45978ce1cf9bef6fd1732038377000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Plot a map of the change in the loss function for each region. This map tells us which regions are improved and which are degraded. I.e., it displays the tuning trade-offs. For #910. 2024-11-19 11:46:17 -060090da93a5bb3dc5a7b27f02b45978ce1cf9bef6fdQuadTune: Plot a map of the change in the loss function for each region.editutilities/sens_matrix/create_figs.pypostprocessing/pyplotgen/src/ContourPanel.pypostprocessing/pyplotgen/config/Style_definitions.pypostprocessing/pyplotgen/src/VariableGroup.pypostprocessing/pyplotgen/config/VariableGroupCorrelations.py9c043092f464dd4e353d3ff565e7f7c09c73dac61732048487000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comFixed time-height plot colormaps (#1210) CLUBB ticket #1164 Added a "quick" fix for the generation of the time-height plot colormaps when variables are not correlations (i.e. values outside of [-1;1]) Updated VariableGroupCorrelations to include all correlations that are usually output in CLUBB. 2024-11-19 14:34:47 -06009c043092f464dd4e353d3ff565e7f7c09c73dac6Fixed time-height plot colormaps (#1210)editpostprocessing/pyplotgen/src/VariableGroup.pyeditpostprocessing/pyplotgen/src/ContourPanel.pyeditpostprocessing/pyplotgen/config/VariableGroupCorrelations.pyeditpostprocessing/pyplotgen/config/Style_definitions.pyrun_scripts/check_multi_col_avg.pysrc/clubb_standalone.F90src/jacobian.F90run_scripts/create_multi_col_params.pysrc/CLUBB_core/output_netcdf.F90src/clubb_driver.F90jenkins_tests/clubb_nvhpc_gpu_multi_col_avg_test/Jenkinsfilerun_scripts/test_monoflux_limiter_GPU.pysrc/clubb_thread_test.F90src/error.F908572001d7a87cba485b292f57adfb7abc970e4621732270912000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comMulti col output update (#1211) * Multi_col output update to enable averaging over timesteps and outputting with single precision. This replaces the timestep batched output method used before, which was only noticably faster at low column numbers. This is technically BC (edited during merge, PR no longer BC), because the single precision output will be interpretted as different from the current double precision output. * Small cleanup * Script updates * Script update * Script update * Adding capability to output multi_col as double or single precision using new flag l_output_double_prec. * Removing accidentally added file. * Making new jenkins script run single and double precision tests. * Update to jenkins test 2024-11-22 04:21:52 -06008572001d7a87cba485b292f57adfb7abc970e462Multi col output update (#1211)editsrc/jacobian.F90addrun_scripts/check_multi_col_avg.pyeditsrc/clubb_standalone.F90editsrc/clubb_driver.F90editrun_scripts/create_multi_col_params.pyeditrun_scripts/test_monoflux_limiter_GPU.pyeditsrc/clubb_thread_test.F90editsrc/CLUBB_core/output_netcdf.F90addjenkins_tests/clubb_nvhpc_gpu_multi_col_avg_test/Jenkinsfileeditsrc/error.F90utilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/create_figs.pyutilities/sens_matrix/sens_matrix_dashboard.py91d31581a8a77559266dfc2cc76c09ec71366c161732748242000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Added colorbars to regional map plots. For #910. 2024-11-27 16:57:22 -060091d31581a8a77559266dfc2cc76c09ec71366c16QuadTune: Added colorbars to regional map plots.editutilities/sens_matrix/create_figs.pyeditutilities/sens_matrix/sens_matrix_dashboard.pyeditutilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/create_figs.py50fe6be42a8a75a9d62659a64b56a64e8d7bd5a01732981900000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: 1) Change coloring of scatterpoints to represent either loss changes or residuals. 2) Add map of residuals to complement map of bias. For #910. 2024-11-30 09:51:40 -060050fe6be42a8a75a9d62659a64b56a64e8d7bd5a0QuadTune: 1) Change coloring of scatterpoints to represent either loss changes or residuals. 2) Add map of residuals to complement map of bias.editutilities/sens_matrix/create_figs.pysrc/CLUBB_core/clip_explicit.F90src/CLUBB_core/error_code.F90src/CLUBB_core/advance_wp2_wp3_module.F907447595af2409f56faa42e4fa915078e13a2cbf11733239180000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comLikely non-bit-changing housekeeping (#1213) Non-bit-changing housekeeping regarding wp2 clipping CLUBB ticket #1165 Renamed threshold_array -> wp2_min_array Moved upper clipping of wp2 into clip_variance Added warning outputs where wp2 is hard-clipped Added debugging checks to hole-filling and wp2_min_array clipping Some necessary OpenACC-modifications 2024-12-03 09:19:40 -06007447595af2409f56faa42e4fa915078e13a2cbf1Likely non-bit-changing housekeeping (#1213)editsrc/CLUBB_core/clip_explicit.F90editsrc/CLUBB_core/error_code.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90postprocessing/pyplotgen/src/ContourPanel.pypostprocessing/pyplotgen/config/Style_definitions.pyafcbd644e18802286f1de588197dde479b2297ea1733247598000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comFix pyplotgen timeheight cmaps (#1212) * Fixed time-height plot colormaps CLUBB ticket #1199 Added a "quick" fix for time-height plot colormaps when variables are not correlations (i.e. values in [-1;1]) Updated VariableGroupCorrelations to include all correlations that are usually output in CLUBB. * Fixed time-height plot colormaps CLUBB ticket #1199 Fixed distinction for colormaps in time-height plots and added tick formatter. We now check the labels for the string "corr" to find correlation variables. Otherwise we just use one-sided or two-sided normed colormaps. 2024-12-03 11:39:58 -0600afcbd644e18802286f1de588197dde479b2297eaFix pyplotgen timeheight cmaps (#1212)editpostprocessing/pyplotgen/src/ContourPanel.pyeditpostprocessing/pyplotgen/config/Style_definitions.pyutilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/create_figs.pyutilities/sens_matrix/sens_matrix_dashboard.py7f1ff523d411b020d4b8f71a89668ec8a79a10d91733322634000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: 1) Add bar chart that shows |metric_changes| due to each parameter. 2) Fix colorbars on maps. 3) Allow download of hi-res figures. 4) Make background of scatterplots grey. For #910. 2024-12-04 08:30:34 -06007f1ff523d411b020d4b8f71a89668ec8a79a10d9QuadTune: 1) Add bar chart that shows |metric_changes| due to each parameter. 2) Fix colorbars on maps. 3) Allow download of hi-res figures. 4) Make background of scatterplots grey.editutilities/sens_matrix/set_up_dashboard_inputs.pyeditutilities/sens_matrix/create_figs.pyeditutilities/sens_matrix/sens_matrix_dashboard.pysrc/CLUBB_core/advance_wp2_wp3_module.F909509e1b7c67cfcd60412b46b3f7b110eb85cc1211733327941000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comReduced the upper bound for wp2_min_array to 1.0 (#1214) CLUBB ticket #1165 This is BIT_CHANGING for at least the cases ARM_97 and TWP_ICE, and likely any other more non-standard cases. This change will prevent the minimum clipping value for wp2 from exploding when l_min_wp2_from_corr_wx=.true. 2024-12-04 09:59:01 -06009509e1b7c67cfcd60412b46b3f7b110eb85cc121Reduced the upper bound for wp2_min_array to 1.0 (#1214)editsrc/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_wp2_wp3_module.F907b703667bc54f062406c39e6173dc4083dee7db21733422068000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdded up2 and vp2 to calculation of wp2_min_array (#1215) CLUBB ticket #1165 This is BIT_CHANGING for the cases ARM_97, ATEX, CGILS_S6, GABLS3_NIGHT, LBA, MPACE_B, and TWP_ICE out of the priority cases. These lines of code were added since the fields `u`, `v`, `rt`, and `thl`, and their correlations with `w` should be treated equally. 2024-12-05 12:07:48 -06007b703667bc54f062406c39e6173dc4083dee7db2Added up2 and vp2 to calculation of wp2_min_array (#1215)editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90utilities/sens_matrix/create_figs.pyeba3ae9e61fd97b54bee120570aaddb9be1564b71733426133000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Add bar chart showing linear vs. nonlinear contributions of each parameter. For #910. 2024-12-05 13:15:33 -0600eba3ae9e61fd97b54bee120570aaddb9be1564b7QuadTune: Add bar chart showing linear vs. nonlinear contributions of each parameter.editutilities/sens_matrix/create_figs.pyinput/tunable_parameters/configurable_model_flags.ininput/tunable_parameters_Lscale/configurable_model_flags.insrc/CLUBB_core/model_flags.F90d7b7306c8f0f7a0150cade9a0d73db293ed895241733514208000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comChanged default setting of flag l_min_wp2_from_corr_wx to false (#1216) CLUBB ticket #1165 BIT_CHANGING Changed default setting in configurable_model_flags.in and model_flags.F90 to decrease clipping contribution to `wp2` and increase clipping to `rtp2` and `thl2`. 2024-12-06 13:43:28 -0600d7b7306c8f0f7a0150cade9a0d73db293ed89524Changed default setting of flag l_min_wp2_from_corr_wx to false (#1216)editsrc/CLUBB_core/model_flags.F90editinput/tunable_parameters/configurable_model_flags.ineditinput/tunable_parameters_Lscale/configurable_model_flags.inutilities/sens_matrix/sens_matrix_dashboard.pyutilities/sens_matrix/create_figs.pyc807b993dc1b68e4a08f6b40d9b1ca8d3a0c1d031733768387000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Add map plots of "linSoln" output from global E3SM runs. For #910. 2024-12-09 12:19:47 -0600c807b993dc1b68e4a08f6b40d9b1ca8d3a0c1d03QuadTune: Add map plots of "linSoln" output from global E3SM runs.editutilities/sens_matrix/sens_matrix_dashboard.pyeditutilities/sens_matrix/create_figs.pyutilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/create_figs.pyutilities/sens_matrix/sens_matrix_dashboard.py373be4b540b7491d836fb01e39d2d8351fb293651734028422000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Include special regions (DYCOMS, HAWAII, etc.), in addition to 20x20 regions. However, the weights are set to epsilon, which wrecks the loss calculation. This will have to be remedied later. For #910. 2024-12-12 12:33:42 -0600373be4b540b7491d836fb01e39d2d8351fb29365QuadTune: Include special regions (DYCOMS, HAWAII, etc.), in addition to 20x20 regions. However, the weights are set to epsilon, which wrecks the loss calculation. This will have to be remedied later.editutilities/sens_matrix/create_figs.pyeditutilities/sens_matrix/set_up_dashboard_inputs.pyeditutilities/sens_matrix/sens_matrix_dashboard.pysrc/CLUBB_core/mono_flux_limiter.F900b6031b8f484c7143e0edf14eb3537f9999be78e1734129641000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduRecoded a loop within the mono flux limiter so that it's written in a more convenient manner to allow for easier coding for generalized gridding. Results are bit-for-bit. 2024-12-13 16:40:41 -06000b6031b8f484c7143e0edf14eb3537f9999be78eRecoded a loop within the mono flux limiter so that it's writteneditsrc/CLUBB_core/mono_flux_limiter.F90src/CLUBB_core/mono_flux_limiter.F90e215a047457743d0a235bd5261b7400aeb580bde1734130983000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduChanged some variable names so that it is clear that, while they contain the word wpxp_, they are actually thermodynamic-level variables. Results are bit-for-bit. 2024-12-13 17:03:03 -0600e215a047457743d0a235bd5261b7400aeb580bdeChanged some variable names so that it is clear that, while they containeditsrc/CLUBB_core/mono_flux_limiter.F90src/CLUBB_core/mono_flux_limiter.F902c420dcb69cceaef32bda45193b8dbadc38d1ca21734132394000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduWithin the mono flux limiter, a thermodynamic-level variable needed to be interpolated to momentum levels so it could be directly compared to wpxp. The results of this change are BIT_CHANGING for the ARM 97, MC3E, and TWP-ICE cases. 2024-12-13 17:26:34 -06002c420dcb69cceaef32bda45193b8dbadc38d1ca2Within the mono flux limiter, a thermodynamic-level variable needed toeditsrc/CLUBB_core/mono_flux_limiter.F90src/CLUBB_core/mono_flux_limiter.F907641404dd67426fd141ddffd90000abb5a58520e1734133196000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI forgot to add the new variable to the Atlantic Coast Conference statements in the previous commit. 2024-12-13 17:39:56 -06007641404dd67426fd141ddffd90000abb5a58520eI forgot to add the new variable to the Atlantic Coast Conferenceeditsrc/CLUBB_core/mono_flux_limiter.F90src/CLUBB_core/mono_flux_limiter.F90ec06720353601ed5d790e7ffa43d8ab28d5512fa1734371299000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduChanging a couple loop limits in mono flux limiter. Results do not change. 2024-12-16 11:48:19 -0600ec06720353601ed5d790e7ffa43d8ab28d5512faChanging a couple loop limits in mono flux limiter.editsrc/CLUBB_core/mono_flux_limiter.F90utilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/sens_matrix_dashboard.pyutilities/sens_matrix/create_figs.pycc24b7290a21866963bcb4d5f21f3f0b6115a2931734464305000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Remedy loss function and facilitate plotting of special, non-20x20 regions (DYCOMS, HAWAII, etc.). For #910. 2024-12-17 13:38:25 -0600cc24b7290a21866963bcb4d5f21f3f0b6115a293QuadTune: Remedy loss function and facilitate plotting of special, non-20x20 regions (DYCOMS, HAWAII, etc.).editutilities/sens_matrix/sens_matrix_dashboard.pyeditutilities/sens_matrix/set_up_dashboard_inputs.pyeditutilities/sens_matrix/create_figs.pysrc/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/advance_helper_module.F90src/CLUBB_core/pdf_utilities.F90673beb053c2f32cc4a92340a492afab4c74f71701734646199000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comFix binormal correlation clipping (#1199) Fixed clipping in binormal correlation calc CLUBB ticket #1164 BIT_CHANGING * Implemented new denominator with smooth_max clipping * Created subroutine `smooth_corr_quotient` in pdf_utilities.F90, outsourcing smooth correlation division * This subroutine is used `calc_comp_corrs_binormal` and `transform_pdf_chi_eta_component` 2024-12-19 16:09:59 -0600673beb053c2f32cc4a92340a492afab4c74f7170Fix binormal correlation clipping (#1199)editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/pdf_utilities.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/G_unit_test_types/spurious_source_test.F90input/tunable_parameters_compatible_r8029/configurable_model_flags.insrc/CLUBB_core/clip_explicit.F90src/clubb_tuner.F90src/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/clubb_standalone.F90src/CLUBB_core/model_flags.F90src/clubb_driver.F90input/tunable_parameters_Lscale/configurable_model_flags.insrc/CLUBB_core/stats_clubb_utilities.F90src/G_unit_test_types/pdf_parameter_tests.F90src/CLUBB_core/fill_holes.F90input/tunable_parameters/configurable_model_flags.ine430c6b5a72a8a88fa602e13b4cb946d3361895e1737065191000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdded new hole-filling method which takes TKE from up2 and vp2 (#1217) Added new hole-filling method which takes TKE from up2 and vp2 CLUBB ticket #1165 BIT_CHANGING if flag `l_wp2_fill_holes_tke` is set to true Introduced new flag `l_wp2_fill_holes_tke` to turn on new wp2 hole-filling subroutine that takes TKE from up2 and vp2. 2025-01-16 16:06:31 -0600e430c6b5a72a8a88fa602e13b4cb946d3361895eAdded new hole-filling method which takes TKE from up2 and vp2 (#1217)editinput/tunable_parameters_compatible_r8029/configurable_model_flags.ineditsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/clubb_tuner.F90editinput/tunable_parameters/configurable_model_flags.ineditsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/clip_explicit.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/fill_holes.F90editsrc/clubb_standalone.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/G_unit_test_types/spurious_source_test.F90editinput/tunable_parameters_Lscale/configurable_model_flags.ineditsrc/CLUBB_core/stats_clubb_utilities.F90editsrc/CLUBB_core/model_flags.F90editsrc/clubb_driver.F90jenkins_tests/clubb_nvhpc_gpu_vs_cpu_diffness/Jenkinsfilerun_scripts/check_multi_col_error.py316180d8b915f47e7ddcf24ecdb81661ee4a2ca21737492438000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comFinally fixing gpu_diffness test (#1219) * Modifying diffness test to handle fields with < 0 averages and accept an argument as the threshold. * Overwriting correct variable. 2025-01-21 14:47:18 -0600316180d8b915f47e7ddcf24ecdb81661ee4a2ca2Finally fixing gpu_diffness test (#1219)editjenkins_tests/clubb_nvhpc_gpu_vs_cpu_diffness/Jenkinsfileeditrun_scripts/check_multi_col_error.pyrun_scripts/run_silhs_test.bash2fbf4c2defd75913f167a34077526832ffbeaff91737670313000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSlightly relaxing the convergence criteria to fix convergence test. 2025-01-23 16:11:53 -06002fbf4c2defd75913f167a34077526832ffbeaff9Slightly relaxing the convergence criteria to fix convergence test.editrun_scripts/run_silhs_test.bashutilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/create_figs.pyutilities/sens_matrix/sens_matrix_dashboard.pyfe762cbcb94c872048986f55c9b4ab5e70ea7ea51737811450000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: On matrix-eqn bar chart, plot only extraMetricsToPlot. Add sens-bias scatterplot of only extraMetricsToPlot. In parameter increments bar chart, change absolute values to squares. For #910. 2025-01-25 07:24:10 -0600fe762cbcb94c872048986f55c9b4ab5e70ea7ea5QuadTune: On matrix-eqn bar chart, plot only extraMetricsToPlot. Add sens-bias scatterplot of only extraMetricsToPlot. In parameter increments bar chart, change absolute values to squares.editutilities/sens_matrix/set_up_dashboard_inputs.pyeditutilities/sens_matrix/create_figs.pyeditutilities/sens_matrix/sens_matrix_dashboard.pyutilities/sens_matrix/create_figs.pyutilities/sens_matrix/sens_matrix_dashboard.py0159cfd38c725851d8f3e92ea2c0c411fdfb2dee1738423460000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Add useLongTitle option, which adds extra information on the plotted quantity, if desired. For #910. 2025-02-01 09:24:20 -06000159cfd38c725851d8f3e92ea2c0c411fdfb2deeQuadTune: Add useLongTitle option, which adds extra information on the plotted quantity, if desired.editutilities/sens_matrix/create_figs.pyeditutilities/sens_matrix/sens_matrix_dashboard.pyutilities/sens_matrix/create_figs.py9fbd3da928e373d8cb9b7108cbe56cc997ba68e81738450181000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Plot bias instead of negative bias on metricsBarChart and bias-vs-sensitivity plots. For #910. 2025-02-01 16:49:41 -06009fbd3da928e373d8cb9b7108cbe56cc997ba68e8QuadTune: Plot bias instead of negative bias on metricsBarChart and bias-vs-sensitivity plots.editutilities/sens_matrix/create_figs.pysrc/CLUBB_core/mono_flux_limiter.F90e3707bdb9336e23f2215ba647eb2df43cdab9d9a1738606672000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comMonoflux GPU optimization (#1221) * Making a fast version of the serial loop to check if we even need to perform the slow version at all. * Updates * Final touches to make new version logically the same. * Improving comments and variables names 2025-02-03 12:17:52 -0600e3707bdb9336e23f2215ba647eb2df43cdab9d9aMonoflux GPU optimization (#1221)editsrc/CLUBB_core/mono_flux_limiter.F90utilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/sens_matrix_dashboard.pyutilities/sens_matrix/create_figs.pyd969819b327e31310ce38e44303561aab48757281738961177000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduQuadTune: Made plot_PcSensMap work when len(varPrefixes) > 1. For #910. 2025-02-07 14:46:17 -0600d969819b327e31310ce38e44303561aab4875728QuadTune: Made plot_PcSensMap work when len(varPrefixes) > 1.editutilities/sens_matrix/sens_matrix_dashboard.pyeditutilities/sens_matrix/create_figs.pyeditutilities/sens_matrix/set_up_dashboard_inputs.pyutilities/sens_matrix/bootstrap_calculations.pyutilities/sens_matrix/sens_matrix_dashboard.pyutilities/sens_matrix/create_figs.pyutilities/sens_matrix/bootstrap_plots.pyutilities/sens_matrix/set_up_dashboard_inputs.py112b1d1518ebaad008f69cf0337f2d6466b0ebb01738964377000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comQuadTune: Merge in bootstrap sampling @LuisHasenauer added bootstrap sampling code to QuadTune. Bootstrap calculations are performed if `useBootstrap=T`. Luis and I checked that the best-fit parameter values and weighted chiSqd are unchanged either with `useBootstrap=T` or `useBootstrap=F`. 2025-02-07 15:39:37 -0600112b1d1518ebaad008f69cf0337f2d6466b0ebb0QuadTune: Merge in bootstrap samplingaddutilities/sens_matrix/bootstrap_plots.pyeditutilities/sens_matrix/sens_matrix_dashboard.pyaddutilities/sens_matrix/bootstrap_calculations.pyeditutilities/sens_matrix/create_figs.pyeditutilities/sens_matrix/set_up_dashboard_inputs.pysrc/CLUBB_core/mixing_length.F90adb2c4b1d0d1f187405f733ff704392231fcecc41738965924000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSwapping the loop order on a few kernels, I found this faster for the nvhpc compiler and it's BFB 2025-02-07 16:05:24 -0600adb2c4b1d0d1f187405f733ff704392231fcecc4Swapping the loop order on a few kernels, I found this faster for the nvhpc compiler and it's BFBeditsrc/CLUBB_core/mixing_length.F90src/clubb_driver.F9075cd543bfb7f6754b868dc51af85c200a43954271739484770000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduBIT_CHANGING bug fix that only affects l_t_dependent cases running with multiple columns, I detected this with cgils cases, but I'm not sure how it slipped through initially. 2025-02-13 16:12:50 -060075cd543bfb7f6754b868dc51af85c200a4395427BIT_CHANGING bug fix that only affects l_t_dependent cases running with multiple columns, I detected this with cgils cases, but I'm not sure how it slipped through initially.editsrc/clubb_driver.F90input/tunable_parameters_compatible_r8029/configurable_model_flags.ininput/tunable_parameters/configurable_model_flags.insrc/CLUBB_core/model_flags.F90input/tunable_parameters_Lscale/configurable_model_flags.in9e59dc4769f9362564a50e74dc1aa8301bf68b341739884009000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comSet l_wp2_fill_holes_tke to true by default (#1226) This code change is BIT_CHANGING for extreme cases (e.g. TWP_ICE, LBA, ARM_97). Changed configurable_model_flags.in files and default value in model_flags.F90. For CLUBB ticket #1165. 2025-02-18 07:06:49 -06009e59dc4769f9362564a50e74dc1aa8301bf68b34Set l_wp2_fill_holes_tke to true by default (#1226)editinput/tunable_parameters/configurable_model_flags.ineditinput/tunable_parameters_compatible_r8029/configurable_model_flags.ineditinput/tunable_parameters_Lscale/configurable_model_flags.ineditsrc/CLUBB_core/model_flags.F90src/advance_microphys_module.F90src/clubb_driver.F90c6dde82098cfbd856d8389181300112e589c47fd1739982717000http://carson.math.uwm.edu/jenkins/user/sdomkeSteffen Domkesdomke@uwm.eduSneaky commit 2025-02-19 10:31:57 -0600c6dde82098cfbd856d8389181300112e589c47fdSneaky commiteditsrc/clubb_driver.F90editsrc/advance_microphys_module.F90src/clubb_driver.F906e3bbf3ef436357dc36a3bf4d1b995304d090f281739983616000http://carson.math.uwm.edu/jenkins/user/sdomkeSteffen Domkesdomke@uwm.eduFixing ordering of parameter lists in clubb_driver 2025-02-19 10:46:56 -06006e3bbf3ef436357dc36a3bf4d1b995304d090f28Fixing ordering of parameter lists in clubb_drivereditsrc/clubb_driver.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonhttp://carson.math.uwm.edu/jenkins/user/sdomkeSteffen Domkehttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse339http://carson.math.uwm.edu/jenkins/view/Branch%20View/job/branch_clubb_test/339/337http://carson.math.uwm.edu/jenkins/view/Branch%20View/job/branch_clubb_test/337/