Adding in a git clone step to the Cam Clubb Copy test.
(details / githubweb)
Trying out git command rather than checkout for cloning.
(details / githubweb)
Adding correct scm command and removed redundant run commond from end.
(details / githubweb)
Adding space because commit 26b7e8f8d7007f78d655b8fc15045015ce8d4790 fixed the jenkins test that were failing, but did not include the proper resolving messages. RESOLVED:7046396a59f73087323f04b267cd8614ff1653f2 RESOLVED:30559bb00c20ce8a8c21242272f6d16cecb12b45 RESOLVED:970b880d9144efe00ce9d6fa34bcd49a493ac65b RESOLVED:633e158c8e6d5818b39963e6836ef71c1489faf9 RESOLVED:4ae233813e39a8bc7e3b58e600c0f71103fff8b3
(details / githubweb)
Various simple changes to improve performance. All bit-for-bit.
(details / githubweb)
Pushing loop into calc_stability_correction.
(details / githubweb)
Adding in comments to explaining the technical tricks and methods in each jenkins file so it is clear what they do and why they are there.
(details / githubweb)
Renamed smth_range to heaviside_smth_range
(details / githubweb)
Added tot_vartn_normlzd statistics. Renamed sclr in advance_helper_module to scalar to be more consistent with clubb naming schemes.
(details / githubweb)
Implemented three further normalized variation stats. Included a (most likely temporary) check because in a few cases, denominator for normalization would be 0.
(details / githubweb)
Changed priorities of total normalized variation stats, included error handling in total normalized variation stats.
(details / githubweb)
Renamed pdf_output_filename. Added grid_level constant to avoid magic numbers in stats_update_var_pt calls.
(details / githubweb)
Bugfix for merge #1000. stderr was not imported in stat_clubb_utilities.F90, causing compilation to fail.
(details / githubweb)
Added ability to apply smooth min max functions in mixing_length.F90
(details / githubweb)
Updated deprecated documentation of smooth min and max functions in advance_helper_module.F90. https://github.com/larson-group/clubb/issues/965
(details / githubweb)
Checked whether results really are identical even with round-off when we have l_smooth_min_max=T and smooth_min_max_mag=zero. Next commit rolls some of these changes back for merge into master. https://github.com/larson-group/clubb/issues/965
(details / githubweb)
Added test cases to smooth_min_max_tests.F90 and updated documentation.
(details / githubweb)
Constructing rcm within SILHS (as rcm_pdf) (#1011)
(details / githubweb)
Constructing rcm within SILHS (as rcm_pdf) (#1011)
(details / githubweb)
Updating for changes to CLUBB. See https://github.com/larson-group/clubb/commit/e4f125ba067ba8083f917e0e06b6b2398483d3e4.
(details / githubweb)
The G_unit tests never allocated pdf_implicit_coefs_terms. It's unclear to me how these were working before, but it seems that something about making these 2D allocatable arrays exposed the bug.
(details / githubweb)
Making zt2zm calls with pdf_implicit_coefs_terms use the 2D version.
(details / githubweb)
Removing setup_grid and setup_parameters functionality from setup_clubb_core. This is beacuse in host models the required grid information may not be known during the setup process, resulting in dummy arguments for setup_clubb_core and the grid and paramters being setup during runtime anyway. Now, in the host models we can call these subroutines immediately after setup_clubb_core to maintain identical functionality (sam, wrf), and in others we can wait to call these until the main timestepping procedure (cam,e3sm).
(details / githubweb)
Making compatible with latest clubb change.
(details / githubweb)
Making 2D versions of setup_grid and setup_parameters.
(details / githubweb)
Now using 2D versions of setup_grid and setup_parameters
(details / githubweb)
Making lmin a scalar again, twas a mistake to make it an array, it can only take on one value.
(details / githubweb)
Making compatible with latest clubb change.
(details / githubweb)
Making nu_vert_res_dep a type containing arrays, as opposed to being an array of types.
(details / githubweb)
Making compatible with latest clubb change.
(details / githubweb)
Making silhs use the new 2D version of setup_grid. This also inadvertently fixes a bug added in commit c816bcbd4bb8b8cfa89aa9c0f976ee799cb795e2. The issue was that we used pver when we wanted pverp.
(details / githubweb)
Small bug fix. This was not a bit changing bug, but could cause crashes if we compile with floating point trapping in a multicolumn run.
(details / githubweb)
Small refactoring to mfl_xm_lhs, just removing need to pass in gr.
(details / githubweb)
Final loop pushes needed before the grid change.
(details / githubweb)
Changing NETCDF path in jenkins test command.
(details / githubweb)
Modifying shell commands to be the more recognized version. |& should be understood by bash version >= 3.2.25 but that does not seem to be the case, so we're reverting it to the equivalent 2>&1 |
(details / githubweb)
Changing the cam_global_ERP_Ln9_gfortran_test jenkins test to specify the computer when configuring.
(details / githubweb)
The big grid change. Converting gr from being an array of types containing 1D arrays, to a type containing 2D arrays. All cases BFB, cam multicolumn+silhs BFB, and cam multicolumn (no silhs) with backwards compatible settings BFB.
(details / githubweb)
The big grid change. Converting gr from being an array of types containing 1D arrays, to a type containing 2D arrays. All cases BFB, cam multicolumn+silhs BFB, and cam multicolumn (no silhs) with backwards compatible settings BFB.
(details / githubweb)
Making compatible with latest clubb change. update_xp2_mc will be broken by this, but all we need to do to fix it is push the column loop into it.
(details / githubweb)
Removing the zt2zm interface from clubb_api and making the api calls just redirect to the grid class interface for it.
(details / githubweb)
Pushing column loop into mean advection procedures.
(details / githubweb)
Making linear_interpolated_azt_2D and linear_interpolated_azm_2D subroutines just to avoid a needless data copy.
(details / githubweb)
Making update_xp2_mc 2D and creating interface for 1D calls.
(details / githubweb)
Making use of new 2D call to update_xp2_mc
(details / githubweb)
Declaring local variables with state%ncol rather than pcols. This avoid occasional slicing and other complications. Also making everything in clubb_tend_cam follow the same indentation scheme.
(details / githubweb)
added ulimit tag to arm97 case of scam test to avoid stack overflow errors larson-group/sys_admin#781
(details / githubweb)
Adding run script for gpu runs without silhs. The only thing making this a GPU script right now is that it's set for casper using nvhpc with acc flags, but there might be more settings in the future we want to add here.
(details / githubweb)
Compiler and machine scripts to include the lastest changes in the cime repo, but also keeping our custom configurations in.
(details / githubweb)
Adding compiler optioned needed to compile with latest gnu version. These were accidentally removed and caused tests to fail. RESOLVED:f98790fed7b9283cce7e9981d7e0c2be7fe8e3fb
(details / githubweb)
Fixing a bug in mono_flux_limiter.F90. (#1026)
(details / githubweb)
I altered the w_up_in_cloud and w_down_in_cloud code so that a
(details / githubweb)
I have optimized the new w_up_in_cloud and w_down_in_cloud code by
(details / githubweb)
Refactored fill_holes_vertical to make GPUization simple. This is BIT_CHANGING, but results are bit-for-bit when using -O0 optimization, thus it is not answer changing. The first pass over each grid column will not parallelize well, the k-loop needs to be done in serial. Maximum parallelization has been exposed for the global hole-filling though, at the cost of occasionally doing unneccesary calculations. larson-group/clubb#972.
(details / githubweb)
Removing fill_holes_multiplicative and replacing magic numbers with parameters from constants_clubb. larson-group/clubb#972
(details / githubweb)
Moving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972
(details / githubweb)
Moving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972
(details / githubweb)
Removing elementalness from sat_vapor_press_liq and making interal procedures subroutines rather than functions to prevent unneccesary data copies. Doing the same for thlm2T_in_K since it is often used in conjunction with sat_vapor_press_liq. Bit-for-bit confirmed with O0 using all single column cases with or without l_diag_Lscale_from_tau, and with cam_coarse_res. larson-group/clubb#972
(details / githubweb)
Cleaning up new subroutine calc_liquid_cloud_frac_component, and making sat_mixrat_ice a subroutine that works the same way as sat_mixrat_liq. larson-group/clubb#972
(details / githubweb)
Removing these paratheses is BIT_CHANGING since it modifies the order of operations, but allows for the multiplication and subraction to be done in parallel for complex pipelines.
(details / githubweb)
Adding line to indicate BIT_CHANGING:0f8ff1baa73dd122911de7978d0067ad1fcc348b. This is because of actual bit changing commits, and is expected. See https://github.com/larson-group/clubb/pull/1034.
(details / githubweb)
Improvements. Netcdf output is now functional and we can detect errors with multiple columns even when the standard output is identical.
(details / githubweb)
Adds commented-out line that prevents the monotonic flux
(details / githubweb)
Creating new flags to control monotonic flux limiter (#1039)
(details / githubweb)
Updating for changes to CLUBB. See https://github.com/larson-group/clubb/pull/1039.
(details / githubweb)
I am adding cloudy_updraft_frac and cloudy_downdraft_frac as
(details / githubweb)
Modified for changes to advance_clubb_core_api.
(details / githubweb)
Minor adjustment to eliminate spikes in thlm tendencies from the monotonic flux limiter. (#1043)
(details / githubweb)
Adding line to indicate BIT_CHANGING:5abaa74c4daad3b827fff70359563703a9152d1b. This is because of actual bit changing commits, and is expected
(details / githubweb)
Adding space to file since previous commit was intentionally BIT_CHANGING:a466f958c140acbd260290c59213a96f3c049793.
(details / githubweb)
Adding capability to change matrix solving method via clubb_config_flags.
(details / githubweb)
Fixing small bug, need to pass _copy arrays to prevent lapack mangling the real ones.
(details / githubweb)
Making GPU and CPU versions of the penta_lu solver the same as discussed in larson-group/clubb#1024.
(details / githubweb)
Making compatible with latest clubb change.
(details / githubweb)
I added "smooth" max clipping for invrs_tau_shear, which is a variable
(details / githubweb)
ADG1_pdf_driver subroutine port with OpenACC
(details / githubweb)
Replacing old elemental ADG1_w_closure with new GPUized one. Making G_unit tests work with new version. Also making mixt_frac_max_mag a scalar since it was only being used as such. larson-group/clubb#1049
(details / githubweb)
I can now safely remove all the "ifdef E3SM" statements from CLUBB's
(details / githubweb)
Restructuring and Porting of Compute_mixing_length subroutine(Phase 1) (#1052)
(details / githubweb)
Restructuring and Porting of Compute_mixing_length subroutine(Phase 2) (#1054)
(details / githubweb)
Breaking up column loop in mono_flux_limiter. This may not be the final form for GPUization, but it's definitely a start, no longer do we have to copy single column variables to multicolumn ones anywhere. (#1051)
(details / githubweb)
Adding OpenACC data directives for mixing length and adg routines
(details / githubweb)
Fixing error causing GPU code not to run. Some variables to be copied were labelled as (ngrdcol,nz) when it should be (:ngrdcol,:nz). I've just removed the data length specifiers completely since they are not neccesary in general.
(details / githubweb)
Removing update_pressure since it is no longer called anywhere in clubb or host models. The addition of this subroutine was discussed in larson-group/e3sm#6 and the removal of the call to it was discussed in larson-group/clubb#926.
(details / githubweb)
Removing update_pressure from public list. This was causing compilation crashes. RESOLVED:8c7230fecb877d04fb129ef5e143e0993b4b29b1
(details / githubweb)
Removing sigma_sqd_w from the acc data copyout statement. This is a bug which was causing the code to crash when not using managed memory.
(details / githubweb)
Porting pdf_closure subroutine with OpenACC (#1059)
(details / githubweb)
Adding wp3_on_wp2_cfl_num to CLUBB's output stats.
(details / githubweb)
Removing usage of gr from pdf_closure. It was only ever used for nz, which is now fed in directly.
(details / githubweb)
Clubb ticket #1025: Implemented way to make esa tuner reproducible, h… (#1068)
(details / githubweb)
Moving compute_cloud_cover outside of if ( l_use_cloud_cover ) then statement, the cloud_cover and rcm_in_layer variables they compute aren't output in clubb_standalone, but are in cam, causing cam bit diff tests to break.
(details / githubweb)
Adding Skthl_zm to the update host list, I missed this in the last PR. I noticed this by comparing results with and without managed memory, now I've checked BFBness with arm, mpace_b, mc3e, and gabls2.
(details / githubweb)
Small tweaks to fix some GPU bugs. Some variables were uninitialized on the CPU while we were saving them. This could only have been caught by comparing consecutive runs and checking _zt and _zm files, even then few cases were having problems.
(details / githubweb)
Fixing a labelling error in redirect_interpolated_azt_2D and similar procedures, since this interpolates to zt the input should be zm. I think this was my fault, so I cleaned all the zt2zm and zm2zt things up to make it a little nicer. Also ordered the routines _k _1D _2D to make it easier to jump around, it was a bit confusing as they were out of order and the typo really made it hard.
(details / githubweb)
Making it so sclr_tol is set to 0 before the specified sclr_tol_in. This is so that it is initialized to 0 in the case that sclr_dim = 0, since now we are setting it to have a minimum allocation size of 1 and would otherwise have a garbage value. This is what broke the clubb_openmp_gfortran_test.
(details / githubweb)
This commit is a commit that changes absolutely nothing. It is meant to trigger a change in the git update scripts, so that I can start the commit message logging in the autocommit updates larson-group/sys_admin#797
(details / githubweb)
This commit is a commit that changes absolutely nothing. It is meant to trigger a change in the git update scripts, so that I can start the commit message logging in the autocommit updates larson-group/sys_admin#797
(details / githubweb)
this is another commit that cahnges nothing that will trigger the gitUpdate scripts
(details / githubweb)
adding an update that changes nothing and is just a test for the autoupdate script
(details / githubweb)
Making CLUBB's splatting scheme implicit and smoother (#1075)
(details / githubweb)
change to calc pressure to trigger autoupdate
(details / githubweb)
GPUizing Lscale_width_vert_avg. Loops have been restructured for simplicity, and algorithm has a different starting value to avoid k dependency. Results are BFB. (#1083)
(details / githubweb)
GPUizing most of advance_clubb_core (#1084)
(details / githubweb)
advance_wp2_wp3 with explicitly managed memory (#1085)
(details / githubweb)
advance_xp2_xpyp with explicitly managed memory (#1086)
(details / githubweb)
advance_windm_edsclrm with explicitly managed memory (#1087)
(details / githubweb)
Moving data statements to outter most parts of clubb and little fix in advance_wp2_wp3 (#1088)
(details / githubweb)
![[Jenkins]](/jenkins/static/57c8a776/images/svgs/logo.svg){kind=logo}
