Skip to content
Started 3 yr 3 mo ago
Took 13 min
Success

Build #37 (Jan 20, 2022, 2:45:17 PM)

Changes
  1. I have passed clubb_params down into advance_xm_wpxp_module.F90. (details / githubweb)
  2. See ticket (details / githubweb)
  3. I have passed down CLUBB's tunable parameters into advance_wp2_wp3_module.F90. (details / githubweb)
  4. added some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to disk (details / githubweb)
  5. Updates to separate out C4 and C14 in advance_xp2 module.  This will make it easier to control which invrs_tau_* variable multiplies each term for example. (details / githubweb)
  6. Changing the name of dummy_1d variables for clarity. (details / githubweb)
  7. I passed down CLUBB's tunable parameters into advance_xp2_xpyp_module.F90 (details / githubweb)
  8. Add a blank line to trigger nightly tests. (details / githubweb)
  9. Passing down more of CLUBB's tunable parameters. (details / githubweb)
  10. I accidentally removed an important comment in the previous commit. (details / githubweb)
  11. Passing down more CLUBB tunable parameters. (details / githubweb)
  12. More passing down CLUBB parameters ... whoop-de-doo (details / githubweb)
  13. Passing down more tunable parameters and removing references to (details / githubweb)
  14. Removing line to trigger the nightly tests for all repos. (details / githubweb)
  15. See respective messages on the issue 958 on date 10/12/2021 (details / githubweb)
  16. Handling the abomination that is lmin. (details / githubweb)
  17. Commented out the k=1 boundary conditions in diffusion_zm_lhs and diffusion_zt_lhs, since these are not currently fed into the final LHS matrix.  I included comments to describe why this was done.  Results are b4b. (details / githubweb)
  18. Passing tunable parameters into the new tau code. (details / githubweb)
  19. Passed down more parameters. Results are bit-for-bit. (details / githubweb)
  20. Passing through more clubb parameters. Bit-for-bit (details / githubweb)
  21. Passing down CLUBB's tunable parameters into the setup_pdf_parameters and (details / githubweb)
  22. These updates incorporate some of Shixuan Zhang's changes, including: (details / githubweb)
  23. Passing down CLUBB's tunable parameters into the remainder of the (details / githubweb)
  24. I passed down the forgotten thlp2_rad_coef tunable parameter. (details / githubweb)
  25. Uncommenting diffusion.F90 k=1 lines again to fix Oracle uninit var test.  I've updated the accompanying note to state clearly that the lines have no effect on model output, but I guess we need to keep the lines to avoid uninitialized variables. (details / githubweb)
  26. I am passing down the forgotten parameter, altitude threshold, in (details / githubweb)
  27. Updating for changes to CLUBB.  See https://github.com/larson-group/clubb/pull/968. (details / githubweb)
  28. Adding code wrapped in a flag (l_use_tke_in_K_dfsn) to use u_i'u_i' in the wp2 and wp3 eddy diffusion terms, instead of just wp2 or wp3.  Relevant to CLUBB issue #920. (details / githubweb)
  29. Updates as requested to the l_use_tke_in_K_dfsn code: (details / githubweb)
  30. I am committing the final stage of the "pass-down params" project. (details / githubweb)
  31. I am committing the final stage of the "pass-down params" project. (details / githubweb)
  32. Adding an option to use invrs_tau_N2_iso for C4 terms.  The same invrs_tau had been used for C4 and C14 terms, so some adjustments had to be made to separate them out (this was started with an earlier commit: https://github.com/larson-group/clubb/commit/ef3be1b1378bcd1a447f3866c9f88f8cc4764233).  The flag is currently set to false so results will be b4b. (details / githubweb)
  33. Renaming invrs_tau_zt and invrs_tauw3t to "invrs_tau_wp3_zt" in advance_wp2_wp3 to avoid confusion.  This variable is only used for the wp3 C8 term, so one consistent name is simpler, and the name "invrs_tau_zt" is already used by another variable in advance_clubb_core. (details / githubweb)
  34. Adding comments for clarity. (details / githubweb)
  35. I forgot to add this necessary subroutine call to the clubb API. (details / githubweb)
  36. Fixing a minor accounting bug related to the changes in https://github.com/larson-group/clubb/commit/987d63de489d2baa09ad6e1538b2c6dbb7551690.  There was some overcounting of the relevant terms. (details / githubweb)
  37. Applying the fix for the new CLUBB code to the developmental (details / githubweb)
  38. I fixed a couple of errors. (details / githubweb)
  39. I have turned the nu_vert_res_dep family of variables into a derived (details / githubweb)
  40. Updating for changes to CLUBB. (details / githubweb)
  41. Added sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90 (details / githubweb)
  42. Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details (details / githubweb)
  43. Included a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge (details / githubweb)
  44. fixed a typo in pdf_closure_module.f90, line 1284 (details / githubweb)
  45. See ticket (details / githubweb)
  46. added some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to disk (details / githubweb)
  47. See respective messages on the issue 958 on date 10/12/2021 (details / githubweb)
  48. Added sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90 (details / githubweb)
  49. Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details (details / githubweb)
  50. Included a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge (details / githubweb)
  51. fixed a typo in pdf_closure_module.f90, line 1284 (details / githubweb)
  52. Passing w_up_in_cloud out of advance_clubb_core (details / githubweb)
  53. Updating clubb_intr.F90 for the changes to advance_clubb_core_api (details / githubweb)
  54. fixed compiler warning regarding w_up_in_cloud (details / githubweb)
  55. Remove clipping from a3_coef. (details / githubweb)
  56. These changes allow you to call the 4 clubb "advance" subroutines in any (details / githubweb)
  57. Placing the order variables in a nice, convenient place for testing use. (details / githubweb)
  58. I reordered advance_clubb_core so that the "Advance xp3" (which is a (details / githubweb)
  59. I am committing the idiot-proofing code that forces l_min_xp2_from_corr_wx (details / githubweb)
  60. I am indenting the portion of the code where the advance subroutines (details / githubweb)
  61. Temporarily commenting out the idiot proofing in order to run some tests ... (details / githubweb)
  62. Now official reinstating the idiot-proofing and turning off the (details / githubweb)
  63. I am committing some idiot proofing in regards to the advance (details / githubweb)
  64. Updating for the latest version of CLUBB. (details / githubweb)
  65. Updating CLUBB to pass uprcp and vprcp into and out of advance_clubb_core. (details / githubweb)
  66. Now that uprcp and vprcp have been passed through advance_clubb_core, (details / githubweb)
  67. I am adding more arguments to the argument list for advance_clubb_core (details / githubweb)
  68. I am updating clubb_intr.F90 to account for recent changes to the call to (details / githubweb)
  69. Adding omitted lines to the call to advance_clubb_core_api. (details / githubweb)
  70. Reverting to using Gfortran 8 temporarily to get things working. (details / githubweb)
  71. Insert print about overwriting default flags with namelist values (details / githubweb)
  72. Insert print about overwriting default parameters with namelist values (details / githubweb)
  73. Making api version of setup_grid. larson-group/clubb#972 (details / githubweb)
  74. Making some paramters_silhs variables available from the silhs api (details / githubweb)
  75. Comment out setting of fatal error (details / githubweb)
  76. This should be BIT_CHANGING, but only because the value of Cx_min should change in the netcdf file. This will not be answer changing. (details / githubweb)
  77. Changing the value of C_invrs_tau_shear from 0.02 to 0.15. (details / githubweb)
  78. Avoiding stats call for variables that are not set when l_diag_Lscale_from_tau is not true. (details / githubweb)
  79. Updated e3sm to fit the new clubb driver api (details / githubweb)
  80. Adjusting the value of C_invrs_tau_shear from 0.15 to 0.16 so that (details / githubweb)
  81. Add l_smooth_Heaviside_tau_wpxp to smooth discontinuity in invrs_tau_wpxp_zm (details / githubweb)
  82. Pushing column loop into advance_clubb_core, and adding interface for it so that we will not need to update any host models. Everything is bit-for-bit, testing all standalone cases and our cam_coarse res run. larson-group/clubb#972 (details / githubweb)
  83. Update the config_compilers.xml for carson. (details / githubweb)
  84. Adding l_stats check around stats stuff. This fixes the crashing when stats is disabled. larson-group/clubb#972 (details / githubweb)
  85. Making e3sm use the single column version of advance clubb core directly, since it does not want to use the interface version. larson-group/clubb#972 (details / githubweb)
  86. Making single and multi column versions of advance clubb core available through clubb_api. larson-group/clubb#972 (details / githubweb)

Started by user Gunther Huebler

Revision: 6adba402c5df8819383f0728669ffc3ed186edb6
Repository: https://github.com/larson-group/e3sm.git
  • refs/remotes/origin/clubb_silhs_devel