The big grid change. Converting gr from being an array of types containing 1D arrays, to a type containing 2D arrays. All cases BFB, cam multicolumn+silhs BFB, and cam multicolumn (no silhs) with backwards compatible settings BFB.
(details / githubweb)
Adds to tuning dashboard an arrow plot of biases.
(details / githubweb)
Removing the zt2zm interface from clubb_api and making the api calls just redirect to the grid class interface for it.
(details / githubweb)
Pushing column loop into mean advection procedures.
(details / githubweb)
Just a line to read me, because commit a19386022f26aa17da805381904bcde4c59cb521 fixed the bit diff tests after a previous commit broke it, RESOLVED:991ebceb8caba2ad56c1125871b7de1de3c04dba.
(details / githubweb)
modified clubb_ifort_configuration file to support nan trapping for uninitialized variables
(details / githubweb)
renamed clubb_ifort_build to clubb_ifort_debug_run and updated jenkinsfile to reflect
(details / githubweb)
forgot to change if statements in jenkinsfile
(details / githubweb)
created debug case for gfortran as well as updating jenkins files to work with it, as well as a forgotten change to the ifort debug test jenkinsfile
(details / githubweb)
Adds to the tuning dashboard a quadratic optimizer.
(details / githubweb)
Changed intent out to inout to fix grid deallocation error during cleanup.
(details / githubweb)
Added a3_coef_min_minmax entry to namelist init_minmax for ALL the tuner input files to prevent error with gfortran compiler (min > max)
(details / githubweb)
Added some comments. Changing some variable names might be nicer, loss might make more sense than energy, n1 and n2 are meaningless, etc.
(details / githubweb)
updating timestep_convergence_test.py to python 3 #693
(details / githubweb)
Refactored fill_holes_vertical to make GPUization simple. This is BIT_CHANGING, but results are bit-for-bit when using -O0 optimization, thus it is not answer changing. The first pass over each grid column will not parallelize well, the k-loop needs to be done in serial. Maximum parallelization has been exposed for the global hole-filling though, at the cost of occasionally doing unneccesary calculations. larson-group/clubb#972.
(details / githubweb)
Removing fill_holes_multiplicative and replacing magic numbers with parameters from constants_clubb. larson-group/clubb#972
(details / githubweb)
Moving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972
(details / githubweb)
Making compatible with latest clubb change.
(details / githubweb)
rewrote run_bindiff_all.bash into python, and added extra functionality to view output of diff_netcdf_outputs.py script that is run inside of it. #980
(details / githubweb)
Removing elementalness from sat_vapor_press_liq and making interal procedures subroutines rather than functions to prevent unneccesary data copies. Doing the same for thlm2T_in_K since it is often used in conjunction with sat_vapor_press_liq. Bit-for-bit confirmed with O0 using all single column cases with or without l_diag_Lscale_from_tau, and with cam_coarse_res. larson-group/clubb#972
(details / githubweb)
Cleaning up new subroutine calc_liquid_cloud_frac_component, and making sat_mixrat_ice a subroutine that works the same way as sat_mixrat_liq. larson-group/clubb#972
(details / githubweb)
Removing these paratheses is BIT_CHANGING since it modifies the order of operations, but allows for the multiplication and subraction to be done in parallel for complex pipelines.
(details / githubweb)
Adding line to indicate BIT_CHANGING:055f83d512354e6330233a5eecd5cff0456c0292 to fix nightly tests. The commit which introduced calc_ice_cloud_frac_component was not BFB using -O2 optimization. See pull request https://github.com/larson-group/clubb/pull/1034 for detail.
(details / githubweb)
Adding a kludgy but functional trimming for the (non-CLUBB) variables that are
(details / githubweb)
In tuner, creates box and whiskers version of plot
(details / githubweb)
Making multicolumn version of advance_clubb_core in clubb_driver that accepts a number of columns to run clubb with. All bit-for-bit output on standalone cases, so the first column is correct.
(details / githubweb)
Improvements. Netcdf output is now functional and we can detect errors with multiple columns even when the standard output is identical.
(details / githubweb)
Now the multicolumn netcdf output is correct. Adding comments too. larson-group/clubb#1033
(details / githubweb)
Made the multicolumn inout arrays save from timestep to timestep. This makes the extra columns more independent from the main column and allows differences in the extra columns to propagate more. larson-group/clubb#1033
(details / githubweb)
Adding some fields to tweak for extra columns. This might be sufficient, the netcdf data for the column is similar but visually different, and I tested with up to 64 columns and there wasn't any crashes. larson-group/clubb#1033
(details / githubweb)
Adding script to compare netcdf outputs. This will print the max absolute diff and max percent diff for each field. This is made specifically for the multicolumn netcdf output. The script is not done, but this is the basics of it. larson-group/clubb#1033
(details / githubweb)
Casting 0.0 to correct precision that format_date wants.
(details / githubweb)
Updating script to compare netcdf output. larson-group/clubb#1033
(details / githubweb)
Updating column num input in config flags. larson-group/clubb#1033
(details / githubweb)
Adding small check to allow configurable_multi_column_nl to be optional. If configurable_multi_column_nl is omitted from configurable_model_flags, then we assume we only want 1 column and a warning is printed. larson-group/clubb#1033
(details / githubweb)
Adding comments, setting to num_standalone_columns=1 by default, and preventing multicolumn output when l_stats=false. larson-group/clubb#1033
(details / githubweb)
Namelists need to be closed with a '/', and omitting it will break many tests.
(details / githubweb)
Making save variables in the multicol code threadprivate, this fixes the openmp test. Also changing the way we name and save the multicol output, this allows the parallel run to run with multiple columns. I've reflected the changes in comments where relevant. larson-group/clubb#1033
(details / githubweb)
Adds commented-out line that prevents the monotonic flux
(details / githubweb)
![[Jenkins]](/jenkins/static/57c8a776/images/svgs/logo.svg){kind=logo}
